Re: [PATCH] integrity: powerpc: Do not select CA_MACHINE_KEYRING

2023-09-11 Thread Nayna
On 9/7/23 13:32, Michal Suchánek wrote: Adding more CC's from the original patch, looks like get_maintainers is not that great for this file. On Thu, Sep 07, 2023 at 06:52:19PM +0200, Michal Suchanek wrote: No other platform needs CA_MACHINE_KEYRING, either. This is policy that should be

Re: [PATCH v3] eventfs: Fix the NULL pointer dereference bug in eventfs_remove_rec()

2023-09-11 Thread Ruan Jinjie
On 2023/9/12 5:39, Steven Rostedt wrote: > On Mon, 11 Sep 2023 20:51:25 +0900 > Masami Hiramatsu (Google) wrote: > >> Instead, >> >> ef = eventfs_add_subsystem_dir(name, parent); >> if (IS_ERR(ef)) { >> ... >> } else >> dir->ef = ef; > > > Note, as

Re: [PATCH v3] eventfs: Fix the NULL pointer dereference bug in eventfs_remove_rec()

2023-09-11 Thread Ruan Jinjie
On 2023/9/11 19:51, Masami Hiramatsu (Google) wrote: > Hi Jinjie, > > On Mon, 11 Sep 2023 13:28:17 +0800 > Jinjie Ruan wrote: > >> Inject fault while probing btrfs.ko, if kstrdup() fails in >> eventfs_prepare_ef() in eventfs_add_dir(), it will return ERR_PTR >> to assign file->ef. But the

[PATCH v4] eventfs: Fix the NULL pointer dereference bug in eventfs_remove_rec()

2023-09-11 Thread Jinjie Ruan
Inject fault while probing btrfs.ko, if kstrdup() fails in eventfs_prepare_ef() in eventfs_add_dir(), it will return ERR_PTR to assign file->ef. But the eventfs_remove() check NULL in trace_module_remove_events(), which causes the below NULL pointer dereference. As both Masami and Steven suggest,

Re: [PATCH] certs: Restrict blacklist updates to the secondary trusted keyring

2023-09-11 Thread Jarkko Sakkinen
On Sat Sep 9, 2023 at 12:34 AM EEST, Eric Snowberg wrote: > Currently root can dynamically update the blacklist keyring if the hash > being added is signed and vouched for by the builtin trusted keyring. > Currently keys in the secondary trusted keyring can not be used. > > Keys within the

Re: [RESEND][PATCH] tracing/synthetic: Fix order of struct trace_dynamic_info

2023-09-11 Thread Steven Rostedt
On Mon, 11 Sep 2023 09:26:12 +0900 Masami Hiramatsu (Google) wrote: > > Fix this and just to be safe also add "__packed". > > > > Link: > > https://lore.kernel.org/all/20230908154417.5172e...@gandalf.local.home/ > > Good catch! I'm not sure why this worked. Maybe we don't have any testcase

Re: [PATCH] certs: Restrict blacklist updates to the secondary trusted keyring

2023-09-11 Thread Jarkko Sakkinen
On Mon Sep 11, 2023 at 4:29 PM EEST, Mimi Zohar wrote: > Hi Eric, > > On Fri, 2023-09-08 at 17:34 -0400, Eric Snowberg wrote: > > Currently root can dynamically update the blacklist keyring if the hash > > being added is signed and vouched for by the builtin trusted keyring. > > Currently keys in

[PATCH][next] RDMA/core: Use size_{add,mul}() in calls to struct_size()

2023-09-11 Thread Gustavo A. R. Silva
Harden calls to struct_size() with size_add() and size_mul(). This results in no differences in binary output. Fixes: 467f432a521a ("RDMA/core: Split port and device counter sysfs attributes") Fixes: a4676388e2e2 ("RDMA/core: Simplify how the gid_attrs sysfs is created") Signed-off-by: Gustavo

Re: [PATCH v5] Randomized slab caches for kmalloc()

2023-09-11 Thread Kees Cook
On Mon, Sep 11, 2023 at 11:18:15PM +0200, jvoisin wrote: > I wrote a small blogpost[1] about this series, and was told[2] that it > would be interesting to share it on this thread, so here it is, copied > verbatim: Thanks for posting! > Ruiqi Gong and Xiu Jianfeng got their > [Randomized slab

[PATCH 1/2] remoteproc: imx_dsp_rproc: add mandatory find_loaded_rsc_table op

2023-09-11 Thread Iuliana Prodan (OSS)
From: Iuliana Prodan Add the .find_loaded_rsc_table operation for i.MX DSP. We need it for inter-process communication between DSP and main core. This callback is used to find the resource table (defined in remote processor linker script) where the address of the vrings along with the other

Re: suspicious RCU usage warning on tracing/urgent

2023-09-11 Thread Steven Rostedt
On Mon, 11 Sep 2023 12:00:53 +0900 Masami Hiramatsu (Google) wrote: > But it seems correctly taking srcu_read_lock(). > > 452 > 453 ei = ti->private; > 454 idx = srcu_read_lock(_srcu); > 455 list_for_each_entry_rcu(ef, >e_top_files, list) { > 456

Re: [PATCH] certs: Restrict blacklist updates to the secondary trusted keyring

2023-09-11 Thread Eric Snowberg
> On Sep 11, 2023, at 5:08 PM, Mimi Zohar wrote: > > On Mon, 2023-09-11 at 22:17 +, Eric Snowberg wrote: >> >>> On Sep 11, 2023, at 10:51 AM, Mickaël Salaün wrote: >>> >>> On Mon, Sep 11, 2023 at 09:29:07AM -0400, Mimi Zohar wrote: Hi Eric, On Fri, 2023-09-08 at 17:34

Re: [PATCH 1/2] mm/damon/core: add a tracepoint for damos apply target regions

2023-09-11 Thread Steven Rostedt
On Mon, 11 Sep 2023 20:36:42 + SeongJae Park wrote: > > Then tracing is fully enabled here, and now we enter: > > > > if (trace_damos_before_apply_enabled()) { > > trace_damos_before_apply(cidx, sidx, tidx, r, > > damon_nr_regions(t)); > > } >

Re: [PATCH 1/2] mm/damon/core: add a tracepoint for damos apply target regions

2023-09-11 Thread Steven Rostedt
On Tue, 12 Sep 2023 01:43:08 + SeongJae Park wrote: > Nevertheless, since the variable is unsigned int, I would need to use UINT_MAX > instead. To make the code easier to understand, I'd prefer to add a third > parameter, as you suggested as another option at the original reply, like >

Re: [PATCH v3] eventfs: Fix the NULL pointer dereference bug in eventfs_remove_rec()

2023-09-11 Thread Steven Rostedt
On Mon, 11 Sep 2023 20:51:25 +0900 Masami Hiramatsu (Google) wrote: > Instead, > > ef = eventfs_add_subsystem_dir(name, parent); > if (IS_ERR(ef)) { > ... > } else > dir->ef = ef; Note, as the error has a goto out_free, it just needs to be:

[PATCH 0/2] Rpmsg support for i.MX DSP with resource table

2023-09-11 Thread Iuliana Prodan (OSS)
From: Iuliana Prodan These patches are needed in order to support rpmsg on DSP when a resource table is available. Iuliana Prodan (2): remoteproc: imx_dsp_rproc: add mandatory find_loaded_rsc_table op arm64: dts: imx8mp: add reserve-memory nodes for DSP

Re: [PATCH] Fix typo in tpmrm class definition

2023-09-11 Thread Jarkko Sakkinen
On Fri Sep 8, 2023 at 5:06 PM EEST, Justin M. Forbes wrote: > Commit d2e8071bed0be ("tpm: make all 'class' structures const") > unfortunately had a typo for the name on tpmrm. > > Fixes: d2e8071bed0b ("tpm: make all 'class' structures const") > Signed-off-by: Justin M. Forbes > --- >

[PATCH] tracefs/eventfs: Use list_for_each_srcu() in dcache_dir_open_wrapper()

2023-09-11 Thread Steven Rostedt
From: "Steven Rostedt (Google)" The eventfs files list is protected by SRCU. In earlier iterations it was protected with just RCU, but because it needed to also call sleepable code, it had to be switch to SRCU. The dcache_dir_open_wrapper() list_for_each_rcu() was missed and did not get

Re: [PATCH 1/2] mm/damon/core: add a tracepoint for damos apply target regions

2023-09-11 Thread SeongJae Park
On Mon, 11 Sep 2023 16:51:44 -0400 Steven Rostedt wrote: > On Mon, 11 Sep 2023 20:36:42 + > SeongJae Park wrote: > > > > Then tracing is fully enabled here, and now we enter: > > > > > > if (trace_damos_before_apply_enabled()) { > > > trace_damos_before_apply(cidx, sidx, tidx,

Re: [PATCH] x86/tdx: refactor deprecated strncpy

2023-09-11 Thread Justin Stitt
On Mon, Sep 11, 2023 at 11:51 AM Dave Hansen wrote: > > On 9/11/23 11:27, Justin Stitt wrote: > > `strncpy` is deprecated and we should prefer more robust string apis. > > I dunno. It actually seems like a pretty good fit here. > > > In this case, `message.str` is not expected to be

Re: [PATCH] integrity: powerpc: Do not select CA_MACHINE_KEYRING

2023-09-11 Thread Jarkko Sakkinen
On Thu Sep 7, 2023 at 7:52 PM EEST, Michal Suchanek wrote: > No other platform needs CA_MACHINE_KEYRING, either. > > This is policy that should be decided by the administrator, not Kconfig s/administrator/distributor/ ? > dependencies. > > cc: joeyli > Signed-off-by: Michal Suchanek > --- >

[PATCH] auxdisplay: panel: refactor deprecated strncpy

2023-09-11 Thread Justin Stitt
s); return key; } --- base-commit: 2dde18cd1d8fac735875f2e4987f11817cc0bc2c change-id: 20230911-strncpy-drivers-auxdisplay-panel-c-83bce51f32cb Best regards, -- Justin Stitt

Re: [PATCH] certs: Restrict blacklist updates to the secondary trusted keyring

2023-09-11 Thread Mimi Zohar
On Mon, 2023-09-11 at 22:17 +, Eric Snowberg wrote: > > > On Sep 11, 2023, at 10:51 AM, Mickaël Salaün wrote: > > > > On Mon, Sep 11, 2023 at 09:29:07AM -0400, Mimi Zohar wrote: > >> Hi Eric, > >> > >> On Fri, 2023-09-08 at 17:34 -0400, Eric Snowberg wrote: > >>> Currently root can

[PATCH v2][next] RDMA/core: Use size_{add,mul}() in calls to struct_size()

2023-09-11 Thread Gustavo A. R. Silva
Harden calls to struct_size() with size_add() and size_mul(). Fixes: 467f432a521a ("RDMA/core: Split port and device counter sysfs attributes") Fixes: a4676388e2e2 ("RDMA/core: Simplify how the gid_attrs sysfs is created") Signed-off-by: Gustavo A. R. Silva --- Changes in v2: - Update

[PATCH 2/2] arm64: dts: imx8mp: add reserve-memory nodes for DSP

2023-09-11 Thread Iuliana Prodan (OSS)
From: Iuliana Prodan Add the reserve-memory nodes used by DSP when the rpmsg feature is enabled. These can be later used in a dsp node, like: dsp: dsp@3b6e8000 { compatible = "fsl,imx8mp-dsp"; reg = <0x3b6e8000 0x88000>; mbox-names = "tx0", "rx0", "rxdb0"; mboxes

Re: [PATCH] certs: Restrict blacklist updates to the secondary trusted keyring

2023-09-11 Thread Eric Snowberg
> On Sep 11, 2023, at 4:04 PM, Jarkko Sakkinen wrote: > > On Mon Sep 11, 2023 at 4:29 PM EEST, Mimi Zohar wrote: >> Hi Eric, >> >> On Fri, 2023-09-08 at 17:34 -0400, Eric Snowberg wrote: >>> Currently root can dynamically update the blacklist keyring if the hash >>> being added is signed and

Re: [PATCH] Fix typo in tpmrm class definition

2023-09-11 Thread Jarkko Sakkinen
On Fri Sep 8, 2023 at 5:06 PM EEST, Justin M. Forbes wrote: > Commit d2e8071bed0be ("tpm: make all 'class' structures const") > unfortunately had a typo for the name on tpmrm. > > Fixes: d2e8071bed0b ("tpm: make all 'class' structures const") > Signed-off-by: Justin M. Forbes > --- >

[PATCH] tpm: Fix typo in tpmrm class definition

2023-09-11 Thread Justin M. Forbes
Commit d2e8071bed0be ("tpm: make all 'class' structures const") unfortunately had a typo for the name on tpmrm. Fixes: d2e8071bed0b ("tpm: make all 'class' structures const") Signed-off-by: Justin M. Forbes --- drivers/char/tpm/tpm-chip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH] certs: Restrict blacklist updates to the secondary trusted keyring

2023-09-11 Thread Eric Snowberg
> On Sep 11, 2023, at 10:51 AM, Mickaël Salaün wrote: > > On Mon, Sep 11, 2023 at 09:29:07AM -0400, Mimi Zohar wrote: >> Hi Eric, >> >> On Fri, 2023-09-08 at 17:34 -0400, Eric Snowberg wrote: >>> Currently root can dynamically update the blacklist keyring if the hash >>> being added is signed

[PATCH] tracefs/eventfs: Use list_for_each_srcu() in dcache_dir_open_wrapper()

2023-09-11 Thread Steven Rostedt
From: "Steven Rostedt (Google)" The eventfs files list is protected by SRCU. In earlier iterations it was protected with just RCU, but because it needed to also call sleepable code, it had to be switch to SRCU. The dcache_dir_open_wrapper() list_for_each_rcu() was missed and did not get

Re: [PATCH] Fix typo in tpmrm class definition

2023-09-11 Thread Justin Forbes
On Mon, Sep 11, 2023 at 5:09 PM Jarkko Sakkinen wrote: > > On Fri Sep 8, 2023 at 5:06 PM EEST, Justin M. Forbes wrote: > > Commit d2e8071bed0be ("tpm: make all 'class' structures const") > > unfortunately had a typo for the name on tpmrm. > > > > Fixes: d2e8071bed0b ("tpm: make all 'class'

Re: [PATCH v5] Randomized slab caches for kmalloc()

2023-09-11 Thread jvoisin
I wrote a small blogpost[1] about this series, and was told[2] that it would be interesting to share it on this thread, so here it is, copied verbatim: Ruiqi Gong and Xiu Jianfeng got their [Randomized slab caches for

Re: [PATCH kmod v5 0/5] kmod /usr support

2023-09-11 Thread Michal Suchánek
On Sat, Aug 19, 2023 at 08:25:52PM +0900, Masahiro Yamada wrote: > On Fri, Aug 18, 2023 at 12:15 PM Michal Suchánek wrote: > > > > Hello, > > > > On Tue, Jul 18, 2023 at 02:01:51PM +0200, Michal Suchanek wrote: > > > Hello, > > > > > > with these patches it is possible to install kernel modules

Re: [PATCH 1/2] mm/damon/core: add a tracepoint for damos apply target regions

2023-09-11 Thread SeongJae Park
Hi Steven, On Mon, 11 Sep 2023 14:19:55 -0400 Steven Rostedt wrote: > On Mon, 11 Sep 2023 04:59:07 + > SeongJae Park wrote: > > > --- a/mm/damon/core.c > > +++ b/mm/damon/core.c > > @@ -950,6 +950,28 @@ static void damos_apply_scheme(struct damon_ctx *c, > > struct damon_target *t, > >

[PATCH] kbuild: rpm-pkg: Fix build with non-default MODLIB

2023-09-11 Thread Michal Suchanek
The default MODLIB value is composed of two variables and the hardcoded string '/lib/modules/'. MODLIB = $(INSTALL_MOD_PATH)/lib/modules/$(KERNELRELEASE) Defining this middle part as a variable was rejected on the basis that users can pass the whole MODLIB to make, such as make

Re: [PATCH] certs: Restrict blacklist updates to the secondary trusted keyring

2023-09-11 Thread Mimi Zohar
Hi Eric, On Fri, 2023-09-08 at 17:34 -0400, Eric Snowberg wrote: > Currently root can dynamically update the blacklist keyring if the hash > being added is signed and vouched for by the builtin trusted keyring. > Currently keys in the secondary trusted keyring can not be used. > > Keys within

Re: [PATCH v4 4/9] fprobe: rethook: Use ftrace_regs in fprobe exit handler and rethook

2023-09-11 Thread Google
On Mon, 11 Sep 2023 09:55:09 +0200 Sven Schnelle wrote: > Masami Hiramatsu (Google) writes: > > >> > IOW, it is ftrace save regs/restore regs code issue. I need to check how > >> > the > >> > function_graph implements it. > >> > >> gpr2-gpr14 are always saved in

Re: [PATCH v3] tpm: Enable hwrng only for Pluton on AMD CPUs

2023-09-11 Thread Jarkko Sakkinen
On Tue Sep 5, 2023 at 3:01 PM EEST, Thorsten Leemhuis wrote: > On 05.09.23 00:32, Jarkko Sakkinen wrote: > > On Fri Sep 1, 2023 at 11:49 AM EEST, Thorsten Leemhuis wrote: > >> On 29.08.23 10:38, Linux regression tracking (Thorsten Leemhuis) wrote: > >>> On 28.08.23 02:35, Mario Limonciello wrote:

Re: [PATCH 1/2] mm/damon/core: add a tracepoint for damos apply target regions

2023-09-11 Thread Steven Rostedt
On Mon, 11 Sep 2023 04:59:07 + SeongJae Park wrote: > --- a/mm/damon/core.c > +++ b/mm/damon/core.c > @@ -950,6 +950,28 @@ static void damos_apply_scheme(struct damon_ctx *c, > struct damon_target *t, > struct timespec64 begin, end; > unsigned long sz_applied = 0; > int

Re: [PATCH v3] scripts/link-vmlinux.sh: Add alias to duplicate symbols for kallsyms

2023-09-11 Thread Alexander Lobakin
From: Alessandro Carminati (Red Hat) Date: Mon, 28 Aug 2023 08:04:23 + > From: Alessandro Carminati > > It is not uncommon for drivers or modules related to similar peripherals > to have symbols with the exact same name. [...] > Changes from v2: > - Alias tags are created by querying

Re: Slow boot and shutdown/reboot problems with 6.5.0+

2023-09-11 Thread Thorsten Leemhuis
On 11.09.23 16:00, Bagas Sanjaya wrote: > On 07/09/2023 20:56, Marcus Seyfarth wrote: >> As to bisecting: Unfortunately I cannot afford the time right now to bisect >> this further as the system is used in production and already did invest a >> lot of time without success into it. Hopefully

Re: [PATCH 1/2] mm/damon/core: add a tracepoint for damos apply target regions

2023-09-11 Thread SeongJae Park
On Mon, 11 Sep 2023 16:31:27 -0400 Steven Rostedt wrote: > On Mon, 11 Sep 2023 19:05:04 + > SeongJae Park wrote: > > > > Also, this if statement is only done when the trace event is enabled, so > > > it's equivalent to: > > > > > > if (trace_damos_before_apply_enabled()) { > > >

Re: [PATCH RFC 00/37] Add support for arm64 MTE dynamic tag storage reuse

2023-09-11 Thread Catalin Marinas
On Wed, Sep 06, 2023 at 12:23:21PM +0100, Alexandru Elisei wrote: > On Thu, Aug 24, 2023 at 04:24:30PM +0100, Catalin Marinas wrote: > > On Thu, Aug 24, 2023 at 01:25:41PM +0200, David Hildenbrand wrote: > > > On 24.08.23 13:06, David Hildenbrand wrote: > > > > Regarding one complication: "The

Re: [PATCH v3] tpm: Enable hwrng only for Pluton on AMD CPUs

2023-09-11 Thread Jarkko Sakkinen
On Mon Sep 11, 2023 at 1:40 PM EEST, Jarkko Sakkinen wrote: > Personally I think bugzilla, being user approachable system, should > be better defined but *theoretically*, at least by the process, it > can be fully ignored. I.e. I don't think it should be ignored :-) BR, Jarkko

Re: [PATCH] KEYS: trusted: tee: Refactor register SHM usage

2023-09-11 Thread Jarkko Sakkinen
On Tue Sep 5, 2023 at 2:04 PM EEST, Sumit Garg wrote: > Hi Jarkko, > > On Wed, 23 Aug 2023 at 19:58, Jens Wiklander > wrote: > > > > On Wed, Aug 23, 2023 at 3:04 PM Sumit Garg wrote: > > > > > > On Wed, 23 Aug 2023 at 13:32, Jens Wiklander > > > wrote: > > > > > > > > On Wed, Aug 23, 2023 at

Re: Slow boot and shutdown/reboot problems with 6.5.0+

2023-09-11 Thread Bagas Sanjaya
On 07/09/2023 20:56, Marcus Seyfarth wrote: > As to bisecting: Unfortunately I cannot afford the time right now to bisect > this further as the system is used in production and already did invest a lot > of time without success into it. Hopefully someone else can find the root > cause of the

Re: [PATCH v1 1/1] bitops: Share BYTES_TO_BITS() for everyone

2023-09-11 Thread Alexander Lobakin
From: Yury Norov Date: Sun, 10 Sep 2023 07:07:16 -0700 > On Wed, Sep 06, 2023 at 05:54:26PM +0300, Andy Shevchenko wrote: >> On Wed, Sep 06, 2023 at 04:40:39PM +0200, Alexander Lobakin wrote: >>> From: Andy Shevchenko >>> Date: Thu, 31 Aug 2023 16:21:30 +0300 On Fri, Aug 25, 2023 at

[PATCH] tracing/synthetic: Print out u64 values properly

2023-09-11 Thread Tero Kristo
The synth traces incorrectly print pointer to the synthetic event values instead of the actual value when using u64 type. Fix by addressing the contents of the union properly. Fixes: ddeea494a16f ("tracing/synthetic: Use union instead of casts") Cc: sta...@vger.kernel.org Signed-off-by: Tero

Re: [PATCH v3] eventfs: Fix the NULL pointer dereference bug in eventfs_remove_rec()

2023-09-11 Thread Google
Hi Jinjie, On Mon, 11 Sep 2023 13:28:17 +0800 Jinjie Ruan wrote: > Inject fault while probing btrfs.ko, if kstrdup() fails in > eventfs_prepare_ef() in eventfs_add_dir(), it will return ERR_PTR > to assign file->ef. But the eventfs_remove() check NULL in > trace_module_remove_events(), which

Re: [PATCH 1/2] mm/damon/core: add a tracepoint for damos apply target regions

2023-09-11 Thread Steven Rostedt
On Mon, 11 Sep 2023 19:05:04 + SeongJae Park wrote: > > Also, this if statement is only done when the trace event is enabled, so > > it's equivalent to: > > > > if (trace_damos_before_apply_enabled()) { > > if (sdx >= 0) > > trace_damos_before_apply(cidx,

Re: [PATCH v2 11/25] security: Align inode_setattr hook definition with EVM

2023-09-11 Thread Jarkko Sakkinen
On Tue Sep 5, 2023 at 6:56 PM EEST, Casey Schaufler wrote: > On 9/4/2023 2:08 PM, Jarkko Sakkinen wrote: > > On Thu Aug 31, 2023 at 1:41 PM EEST, Roberto Sassu wrote: > >> From: Roberto Sassu > >> > >> Add the idmap parameter to the definition, so that evm_inode_setattr() can > >> be registered

Re: [PATCH RFC 00/37] Add support for arm64 MTE dynamic tag storage reuse

2023-09-11 Thread David Hildenbrand
On 11.09.23 13:52, Catalin Marinas wrote: On Wed, Sep 06, 2023 at 12:23:21PM +0100, Alexandru Elisei wrote: On Thu, Aug 24, 2023 at 04:24:30PM +0100, Catalin Marinas wrote: On Thu, Aug 24, 2023 at 01:25:41PM +0200, David Hildenbrand wrote: On 24.08.23 13:06, David Hildenbrand wrote:

Re: [PATCH] certs: Restrict blacklist updates to the secondary trusted keyring

2023-09-11 Thread Mickaël Salaün
On Mon, Sep 11, 2023 at 09:29:07AM -0400, Mimi Zohar wrote: > Hi Eric, > > On Fri, 2023-09-08 at 17:34 -0400, Eric Snowberg wrote: > > Currently root can dynamically update the blacklist keyring if the hash > > being added is signed and vouched for by the builtin trusted keyring. > > Currently

[PATCH] ACPI: OSI: refactor deprecated strncpy

2023-09-11 Thread Justin Stitt
--- base-commit: 2dde18cd1d8fac735875f2e4987f11817cc0bc2c change-id: 20230911-strncpy-drivers-acpi-osi-c-c801b7427987 Best regards, -- Justin Stitt

Re: [PATCH] slub: Introduce CONFIG_SLUB_RCU_DEBUG

2023-09-11 Thread Dmitry Vyukov
On Mon, 28 Aug 2023 at 16:40, Jann Horn wrote: > > On Sat, Aug 26, 2023 at 5:32 AM Dmitry Vyukov wrote: > > On Fri, 25 Aug 2023 at 23:15, Jann Horn wrote: > > > Currently, KASAN is unable to catch use-after-free in SLAB_TYPESAFE_BY_RCU > > > slabs because use-after-free is allowed within the

Re: [PATCH] x86/tdx: refactor deprecated strncpy

2023-09-11 Thread Dave Hansen
On 9/11/23 11:27, Justin Stitt wrote: > `strncpy` is deprecated and we should prefer more robust string apis. I dunno. It actually seems like a pretty good fit here. > In this case, `message.str` is not expected to be NUL-terminated as it > is simply a buffer of characters residing in a union

RE: [PATCH V2] ACPI: APEI: Use ERST timeout for slow devices

2023-09-11 Thread Jeshua Smith
Any further questions? Anything else holding up this patch? -Original Message- From: Jeshua Smith Sent: Friday, August 4, 2023 7:05 PM To: Luck, Tony ; keesc...@chromium.org; gpicc...@igalia.com; raf...@kernel.org; l...@kernel.org; james.mo...@arm.com; b...@alien8.de Cc:

Re: [PATCH] slub: Introduce CONFIG_SLUB_RCU_DEBUG

2023-09-11 Thread Marco Elver
On Fri, 25 Aug 2023 at 23:15, 'Jann Horn' via kasan-dev wrote: > > Currently, KASAN is unable to catch use-after-free in SLAB_TYPESAFE_BY_RCU > slabs because use-after-free is allowed within the RCU grace period by > design. > > Add a SLUB debugging feature which RCU-delays every individual >

Re: [PATCH] remoteproc: k3-r5: Wait for core0 power-up before powering up core1

2023-09-11 Thread Mathieu Poirier
Hi Apurva, On Wed, Sep 06, 2023 at 06:17:56PM +0530, Apurva Nandan wrote: > PSC controller has a limitation that it can only power-up the second core > when the first core is in ON state. Power-state for core0 should be equal > to or higher than core1, else the kernel is seen hanging during rproc

[PATCH] x86/tdx: refactor deprecated strncpy

2023-09-11 Thread Justin Stitt
ase-commit: 2dde18cd1d8fac735875f2e4987f11817cc0bc2c change-id: 20230911-strncpy-arch-x86-coco-tdx-tdx-c-98b0b966bb8d Best regards, -- Justin Stitt

[PATCH] xen/efi: refactor deprecated strncpy

2023-09-11 Thread Justin Stitt
loader_signature)); boot_params->efi_info.efi_systab = (__u32)__pa(efi_systab_xen); boot_params->efi_info.efi_systab_hi = (__u32)(__pa(efi_systab_xen) >> 32); --- base-commit: 2dde18cd1d8fac735875f2e4987f11817cc0bc2c change-id: 20230911-strncpy-arch-x86-xen-efi-c-14292f5a79ee Best regards, -- Justin Stitt

[PATCH] um,ethertap: refactor deprecated strncpy

2023-09-11 Thread Justin Stitt
, 15); + strscpy(gate_buf, gate, sizeof(gate_buf)); args = setup_args; } else args = nosetup_args; --- base-commit: 2dde18cd1d8fac735875f2e4987f11817cc0bc2c change-id: 20230911-strncpy-arch-um-os-linux-drivers-ethertap_user-c-859160d13f59 Best regards, -- Justin Stitt

Re: [PATCH 04/11] arm64: dts: qcom: pm7250b: make SID configurable

2023-09-11 Thread Luca Weiss
On Tue Sep 5, 2023 at 10:30 AM CEST, Luca Weiss wrote: > On Thu Aug 31, 2023 at 2:27 PM CEST, Dmitry Baryshkov wrote: > > On Thu, 31 Aug 2023 at 14:54, Krzysztof Kozlowski > > wrote: > > > > > > On 31/08/2023 13:33, Dmitry Baryshkov wrote: > > > > On Thu, 31 Aug 2023 at 13:13, Luca Weiss > > >

Re: [PATCH 04/11] arm64: dts: qcom: pm7250b: make SID configurable

2023-09-11 Thread Krzysztof Kozlowski
On 11/09/2023 10:34, Luca Weiss wrote: > On Tue Sep 5, 2023 at 10:30 AM CEST, Luca Weiss wrote: >> On Thu Aug 31, 2023 at 2:27 PM CEST, Dmitry Baryshkov wrote: >>> On Thu, 31 Aug 2023 at 14:54, Krzysztof Kozlowski >>> wrote: On 31/08/2023 13:33, Dmitry Baryshkov wrote: > On Thu, 31

Re: [PATCH 04/11] arm64: dts: qcom: pm7250b: make SID configurable

2023-09-11 Thread Luca Weiss
On Mon Sep 11, 2023 at 11:44 AM CEST, Krzysztof Kozlowski wrote: > On 11/09/2023 10:34, Luca Weiss wrote: > > On Tue Sep 5, 2023 at 10:30 AM CEST, Luca Weiss wrote: > >> On Thu Aug 31, 2023 at 2:27 PM CEST, Dmitry Baryshkov wrote: > >>> On Thu, 31 Aug 2023 at 14:54, Krzysztof Kozlowski > >>>

Re: [PATCH 04/11] arm64: dts: qcom: pm7250b: make SID configurable

2023-09-11 Thread Konrad Dybcio
On 11.09.2023 13:15, Krzysztof Kozlowski wrote: > On 11/09/2023 11:59, Luca Weiss wrote: >> On Mon Sep 11, 2023 at 11:44 AM CEST, Krzysztof Kozlowski wrote: >>> On 11/09/2023 10:34, Luca Weiss wrote: On Tue Sep 5, 2023 at 10:30 AM CEST, Luca Weiss wrote: > On Thu Aug 31, 2023 at 2:27 PM

Re: [PATCH 04/11] arm64: dts: qcom: pm7250b: make SID configurable

2023-09-11 Thread Krzysztof Kozlowski
On 11/09/2023 11:59, Luca Weiss wrote: > On Mon Sep 11, 2023 at 11:44 AM CEST, Krzysztof Kozlowski wrote: >> On 11/09/2023 10:34, Luca Weiss wrote: >>> On Tue Sep 5, 2023 at 10:30 AM CEST, Luca Weiss wrote: On Thu Aug 31, 2023 at 2:27 PM CEST, Dmitry Baryshkov wrote: > On Thu, 31 Aug 2023

Re: [PATCH RESEND v3 1/2] selftests/resctrl: Fix schemata write error check

2023-09-11 Thread Reinette Chatre
Hi Maciej, On 9/1/2023 6:42 AM, Wieczor-Retman Maciej wrote: > Writing bitmasks to the schemata can fail when the bitmask doesn't > adhere to constraints defined by what a particular CPU supports. > Some example of constraints are max length or having contiguous bits. > The driver should properly

Re: [FIX PATCH] selftests: tracing: Fix to unmount tracefs for recovering environment

2023-09-11 Thread Steven Rostedt
On Sat, 9 Sep 2023 18:36:39 +0900 "Masami Hiramatsu (Google)" wrote: > From: Masami Hiramatsu (Google) > > Fix to unmount the tracefs if the ftracetest mounted it for recovering > system environment. If the tracefs is already mounted, this does nothing. > > Suggested-by: Mark Brown > Link:

[PATCH 0/5] selftests/resctrl: Fixes to failing tests

2023-09-11 Thread Ilpo Järvinen
Fix three issues with resctrl selftests. The signal handling fix became necessary after the mount/umount fixes. The other two came up when I ran resctrl selftests across the server fleet in our lab to validate the upcoming CAT test rewrite (the rewrite is not part of this series). These are

RE: [EXTERNAL] Re: [Patch v5 0/5] RDMA/mana_ib

2023-09-11 Thread Ajay Sharma
I have updated the last patch to use xarray, will post the update patch. We currently use aux bus for ib device. Gd_register_device is firmware specific. All the patches use RDMA/mana_ib format which is aligned with drivers/infiniband/hw/mana/ . Thanks > -Original Message- > From:

Re: [Patch v5 0/5] RDMA/mana_ib

2023-09-11 Thread Leon Romanovsky
On Thu, Sep 07, 2023 at 09:52:34AM -0700, sharmaa...@linuxonhyperv.com wrote: > From: Ajay Sharma > > Change from v4: > Send qp fatal error event to the context that > created the qp. Add lookup table for qp. > > Ajay Sharma (5): > RDMA/mana_ib : Rename all mana_ib_dev type variables to

RE: [PATCH v2] uapi: fix __DECLARE_FLEX_ARRAY for C++

2023-09-11 Thread David Laight
... > Okay, can you please split the patch so they can be backported > separately? Then I'll get them landed, etc. Since the header with just the extra #endif is badly broken on C++ isn't it best to ensure they get back-ported together? So one patch is probably better. David -

Re: [PATCH] x86/hyperv/vtl: Replace real_mode_header only under Hyper-V

2023-09-11 Thread Mathias Krause
On 08.09.23 17:02, Saurabh Singh Sengar wrote: > On Fri, Sep 08, 2023 at 12:26:10PM +0200, Mathias Krause wrote: >> Booting a CONFIG_HYPERV_VTL_MODE=y enabled kernel on bare metal or a >> non-Hyper-V hypervisor leads to serve memory corruption as > > FWIW, CONFIG_HYPERV_VTL_MODE is not expected

Re: [PATCH v4 4/9] fprobe: rethook: Use ftrace_regs in fprobe exit handler and rethook

2023-09-11 Thread Sven Schnelle
Masami Hiramatsu (Google) writes: >> > IOW, it is ftrace save regs/restore regs code issue. I need to check how >> > the >> > function_graph implements it. >> >> gpr2-gpr14 are always saved in ftrace_caller/ftrace_regs_caller(), >> regardless of the FTRACE_WITH_REGS flags. The only difference

Re: [PATCH] selftests: ALSA: remove unused variables

2023-09-11 Thread Takashi Iwai
On Fri, 08 Sep 2023 10:10:40 +0200, Ding Xiang wrote: > > These variables are never referenced in the code, just remove them. > > Signed-off-by: Ding Xiang Thanks, applied. Takashi

Re: [PATCH] selftests/nolibc: libc-test: avoid -Wstringop-overflow warnings

2023-09-11 Thread Willy Tarreau
Hi Thomas, On Sun, Sep 10, 2023 at 09:29:01PM +0200, Thomas Weißschuh wrote: > Newer versions of glibc annotate the poll() function with > __attribute__(access) which triggers a compiler warning inside the > testcase poll_fault. > Avoid this by using a plain NULL which is enough for the testcase.