On 2023/9/12 5:39, Steven Rostedt wrote:
> On Mon, 11 Sep 2023 20:51:25 +0900
> Masami Hiramatsu (Google) <mhira...@kernel.org> wrote:
> 
>> Instead,
>>
>>      ef = eventfs_add_subsystem_dir(name, parent);
>>      if (IS_ERR(ef)) {
>>              ...
>>      } else
>>              dir->ef = ef;
> 
> 
> Note, as the error has a goto out_free, it just needs to be:
> 
>       if (IS_ERR(ef)) {
>               ...
>               goto out_free;
>       }
> 
>       dir->ef = ef;

Thank you! I'll fix it sooner.


> 
> And for event_create_dir()
> 
>       ef = eventfs_add_dir(name, ef_subsystem);
>       if (IS_ERR(ef)) {
>               ...
>               return -1;
>       }
> 
>       file->ef = ef;
> 
> -- Steve
> 

Reply via email to