Re: [PATCH net-next 03/10] net: macsec: move some definitions in a dedicated header

2019-01-24 Thread Antoine Tenart
Hi Florian, On Wed, Jan 23, 2019 at 12:11:37PM -0800, Florian Fainelli wrote: > On 1/23/19 7:56 AM, Antoine Tenart wrote: > > This patch moves some structure, type and identifier definitions into a > > MACsec specific header. This patch does not modify how the MACsec code > >

Re: [PATCH net-next 05/10] net: phy: introduce a phy_driver macsec helper

2019-01-24 Thread Antoine Tenart
Hi Andrew, On Wed, Jan 23, 2019 at 06:08:16PM +0100, Andrew Lunn wrote: > > +int phy_macsec(struct phy_device *phydev, struct netdev_macsec *macsec) > > +{ > > + int ret = -EOPNOTSUPP; > > + > > + if (!phydev->drv) > > + return -EIO; > > + > > + mutex_lock(>lock); > > + > > + if

Re: [PATCH net-next 02/10] net: macsec: convert to SPDX

2019-01-24 Thread Antoine Tenart
Hi Andrew, On Wed, Jan 23, 2019 at 06:03:06PM +0100, Andrew Lunn wrote: > On Wed, Jan 23, 2019 at 04:56:30PM +0100, Antoine Tenart wrote: > > This cosmetic patch converts the macsec implementation license header to > > the now recommended format, SPDX. > > > > Si

[PATCH net-next 02/10] net: macsec: convert to SPDX

2019-01-23 Thread Antoine Tenart
This cosmetic patch converts the macsec implementation license header to the now recommended format, SPDX. Signed-off-by: Antoine Tenart --- drivers/net/macsec.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/net/macsec.c b/drivers/net/macsec.c index

[PATCH net-next 03/10] net: macsec: move some definitions in a dedicated header

2019-01-23 Thread Antoine Tenart
outside macsec.c. Signed-off-by: Antoine Tenart --- drivers/net/macsec.c | 164 +-- include/net/macsec.h | 178 +++ 2 files changed, 179 insertions(+), 163 deletions(-) create mode 100644 include/net/macsec.h diff --git

[PATCH net-next 04/10] net: macsec: introduce the netdev_macsec structure

2019-01-23 Thread Antoine Tenart
specific structures which contain the actual MACsec configuration. Signed-off-by: Antoine Tenart --- include/net/macsec.h | 45 1 file changed, 45 insertions(+) diff --git a/include/net/macsec.h b/include/net/macsec.h index 15ff331dd670..1e4d37c190ed

[PATCH net-next 10/10] net: phy: mscc: macsec support

2019-01-23 Thread Antoine Tenart
a Microsemi Ocelot PHY. Signed-off-by: Antoine Tenart --- drivers/net/phy/Kconfig | 2 + drivers/net/phy/mscc.c| 559 ++ drivers/net/phy/mscc_macsec.h | 2 + 3 files changed, 563 insertions(+) diff --git a/drivers/net/phy/Kconfig b/drivers/net

[PATCH net-next 06/10] net: introduce a net_device_ops macsec helper

2019-01-23 Thread Antoine Tenart
This patch introduces a net_device_ops MACsec helper to allow net device drivers to implement a MACsec offloading solution. Signed-off-by: Antoine Tenart --- include/linux/netdevice.h | 8 1 file changed, 8 insertions(+) diff --git a/include/linux/netdevice.h b/include/linux

[PATCH net-next 01/10] net: introduce the MACSEC netdev feature

2019-01-23 Thread Antoine Tenart
This patch introduce a new netdev feature, which will be used by drivers to state they can perform MACsec transformations in hardware. Signed-off-by: Antoine Tenart --- include/linux/netdev_features.h | 3 +++ net/core/ethtool.c | 1 + 2 files changed, 4 insertions(+) diff --git

[PATCH net-next 07/10] net: macsec: hardware offloading infrastructure

2019-01-23 Thread Antoine Tenart
, but it should be added in the future so that the MACsec state can be reported to the user (which would also improve the debug). Signed-off-by: Antoine Tenart --- drivers/net/macsec.c | 296 +-- 1 file changed, 283 insertions(+), 13 deletions(-) diff --git

[PATCH net-next 08/10] net: phy: export __phy_read_page/__phy_write_page

2019-01-23 Thread Antoine Tenart
ports. With the upcoming MACsec offloading support in this PHY, we'll need to configure the MACsec engine and to do so changing pages is required. Signed-off-by: Antoine Tenart --- drivers/net/phy/phy-core.c | 6 -- include/linux/phy.h| 3 +++ 2 files changed, 7 insertions(+), 2

[PATCH net-next 05/10] net: phy: introduce a phy_driver macsec helper

2019-01-23 Thread Antoine Tenart
This patch introduces a phy_driver MACsec helper to allow PHYs to implement a MACsec offloading solution. The phy_driver MACsec helper is called through a wrapper, phy_macsec, to perform this call while holding the phydev lock. Signed-off-by: Antoine Tenart --- drivers/net/phy/phy.c | 17

[PATCH net-next 09/10] net: phy: mscc: macsec initialization

2019-01-23 Thread Antoine Tenart
-by: Antoine Tenart --- drivers/net/phy/mscc.c | 401 +++ drivers/net/phy/mscc_fc_buffer.h | 64 + drivers/net/phy/mscc_mac.h | 159 drivers/net/phy/mscc_macsec.h| 256 4 files changed, 880 insertions(+) create mode

[PATCH net-next 00/10] net: macsec: initial support for hardware offloading

2019-01-23 Thread Antoine Tenart
. The second patch implements the phy_driver macsec() helper in the Microsemi Ocelot PHY driver, and introduce helpers to configure MACsec transformations and flows to match specific packets. Comments are of course welcomed. Thanks! Antoine Antoine Tenart (10): net: introduce the MACSEC netdev

[PATCH net v4] net: mvpp2: fix the phylink mode validation

2018-12-19 Thread Antoine Tenart
) Reported-by: Russell King Signed-off-by: Antoine Tenart --- Since v3: - Rebase on top of net/master. Since v2, v1: - N/A. drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c b/d

Re: [PATCH net v3 0/2] net: mvpp2: phylink validate fixes

2018-12-19 Thread Antoine Tenart
Hi David, On Wed, Dec 19, 2018 at 08:34:18AM -0800, David Miller wrote: > From: Antoine Tenart > Date: Wed, 19 Dec 2018 09:26:09 +0100 > > > > The patch 2/2 ("net: mvpp2: fix the phylink mode validation") is still > > relevant, in addition to the pat

Re: [PATCH net v3 0/2] net: mvpp2: phylink validate fixes

2018-12-19 Thread Antoine Tenart
Hi David, On Tue, Dec 18, 2018 at 04:42:52PM -0800, David Miller wrote: > From: Antoine Tenart > Date: Mon, 17 Dec 2018 15:56:04 +0100 > > > This small series introduces 2 fixes for the phylink validate function > > of the Marvell PPv2 Ethernet driver. > >

[PATCH net v3 2/2] net: mvpp2: fix the phylink mode validation

2018-12-17 Thread Antoine Tenart
) Reported-by: Russell King Signed-off-by: Antoine Tenart --- drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c index 88aa488054a8..f1

[PATCH net v3 1/2] net: mvpp2: 10G modes aren't supported on all ports

2018-12-17 Thread Antoine Tenart
ction of 10G SFP modules") Cc: Baruch Siach Signed-off-by: Antoine Tenart --- drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c b/drivers/net/ethernet/mar

[PATCH net v3 0/2] net: mvpp2: phylink validate fixes

2018-12-17 Thread Antoine Tenart
Hi, This small series introduces 2 fixes for the phylink validate function of the Marvell PPv2 Ethernet driver. Since v2: - Added an additional patch (2/2) as suggested by Russell. - Rebased on top of net/master. Since v1: - Rebased on top of net/master. Antoine Tenart (2): net: mvpp2

Re: [PATCH net v2] net: mvpp2: 10G modes aren't supported on all ports

2018-12-14 Thread Antoine Tenart
Hi Russell, On Fri, Dec 14, 2018 at 04:02:50PM +, Russell King - ARM Linux wrote: > On Fri, Dec 14, 2018 at 10:34:51AM +0100, Antoine Tenart wrote: > > The mvpp2_phylink_validate() function sets all modes that are > > supported by a given PPv2 port. A recent change

[PATCH net v2] net: mvpp2: 10G modes aren't supported on all ports

2018-12-14 Thread Antoine Tenart
ction of 10G SFP modules") Cc: Baruch Siach Signed-off-by: Antoine Tenart --- Since v1: - Rebased on top of the latest net master branch. drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethern

Re: [PATCH net] net: mvpp2: 10G modes aren't supported on all ports

2018-12-12 Thread Antoine Tenart
Hi, On Wed, Dec 12, 2018 at 10:30:33AM +0100, Antoine Tenart wrote: > On Tue, Dec 11, 2018 at 06:51:56PM +, Russell King - ARM Linux wrote: > > On Tue, Dec 11, 2018 at 07:53:42PM +0200, Baruch Siach wrote: > > > That is, something like this, right? > > > >

Re: [PATCH net] net: mvpp2: 10G modes aren't supported on all ports

2018-12-12 Thread Antoine Tenart
Hi Stefan, On Tue, Dec 11, 2018 at 09:11:31PM +, Stefan Chulski wrote: > > > > > Are these modes supported on anything except port 0? If not, you should be > > rejecting these, rather than just treating them as RGMII. > > In CP115(which has PPv2) PHY_INTERFACE_MODE_10GKR supported on

Re: [PATCH net] net: mvpp2: 10G modes aren't supported on all ports

2018-12-12 Thread Antoine Tenart
Hi Russell, Baruch, On Tue, Dec 11, 2018 at 06:51:56PM +, Russell King - ARM Linux wrote: > On Tue, Dec 11, 2018 at 07:53:42PM +0200, Baruch Siach wrote: > > That is, something like this, right? > > > > diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > >

[PATCH net] net: mvpp2: 10G modes aren't supported on all ports

2018-12-11 Thread Antoine Tenart
ction of 10G SFP modules") Cc: Baruch Siach Signed-off-by: Antoine Tenart --- drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c b/drivers/net/ethernet/mar

Re: [PATCH v2] phy: mvebu-cp110-comphy: fix spelling in structure name

2018-11-23 Thread Antoine Tenart
Hi Miquel, On Fri, Nov 23, 2018 at 10:21:15AM +0100, Miquel Raynal wrote: > Rename the mvebu_comhy_conf structure to be mvebu_comphy_conf, which is > probably what the original author meant. > > Signed-off-by: Miquel Raynal Acked-by: Antoine Tenart Thanks! Antoine > --- >

Re: [PATCH v2] phy: mvebu-cp110-comphy: fix spelling in structure name

2018-11-23 Thread Antoine Tenart
Hi Miquel, On Fri, Nov 23, 2018 at 10:21:15AM +0100, Miquel Raynal wrote: > Rename the mvebu_comhy_conf structure to be mvebu_comphy_conf, which is > probably what the original author meant. > > Signed-off-by: Miquel Raynal Acked-by: Antoine Tenart Thanks! Antoine > --- >

Re: [PATCH] phy: mvebu-cp110-comphy: fix spelling in structure name

2018-11-23 Thread Antoine Tenart
Hi Miquel, On Thu, Nov 22, 2018 at 09:19:09PM +0100, Miquel Raynal wrote: > Rename the mvebu_comhy_conf structure to be mvebu_comphy_conf, which is > probably what the original author meant. > > Fixes: d0438bd6aa09 ("phy: add the mvebu cp110 comphy driver") Could you drop the Fixes tag and send

Re: [PATCH] phy: mvebu-cp110-comphy: fix spelling in structure name

2018-11-23 Thread Antoine Tenart
Hi Miquel, On Thu, Nov 22, 2018 at 09:19:09PM +0100, Miquel Raynal wrote: > Rename the mvebu_comhy_conf structure to be mvebu_comphy_conf, which is > probably what the original author meant. > > Fixes: d0438bd6aa09 ("phy: add the mvebu cp110 comphy driver") Could you drop the Fixes tag and send

[PATCH net-next v2] net: mscc: allow extracting the FCS into the skb

2018-10-11 Thread Antoine Tenart
This patch adds support for the NETIF_F_RXFCS feature in the Mscc Ethernet driver. This feature is disabled by default and allow a user to request the driver not to drop the FCS and to extract it into the skb for debugging purposes. Signed-off-by: Antoine Tenart Reviewed-by: Alexandre Belloni

[PATCH net-next v2] net: mscc: allow extracting the FCS into the skb

2018-10-11 Thread Antoine Tenart
This patch adds support for the NETIF_F_RXFCS feature in the Mscc Ethernet driver. This feature is disabled by default and allow a user to request the driver not to drop the FCS and to extract it into the skb for debugging purposes. Signed-off-by: Antoine Tenart Reviewed-by: Alexandre Belloni

Re: [PATCH net-next] net: mscc: allow extracting the FCS into the skb

2018-10-11 Thread Antoine Tenart
Hi Florian, Dave, On Wed, Oct 10, 2018 at 10:26:05AM -0700, David Miller wrote: > From: Florian Fainelli > Date: Wed, 10 Oct 2018 09:25:01 -0700 > > > > On October 10, 2018 7:46:31 AM PDT, Antoine Tenart > > wrote: > >> > >>@Dave, Florian: it seems

Re: [PATCH net-next] net: mscc: allow extracting the FCS into the skb

2018-10-11 Thread Antoine Tenart
Hi Florian, Dave, On Wed, Oct 10, 2018 at 10:26:05AM -0700, David Miller wrote: > From: Florian Fainelli > Date: Wed, 10 Oct 2018 09:25:01 -0700 > > > > On October 10, 2018 7:46:31 AM PDT, Antoine Tenart > > wrote: > >> > >>@Dave, Florian: it seems

[PATCH net-next] net: mscc: allow extracting the FCS into the skb

2018-10-01 Thread Antoine Tenart
This patch adds support for the NETIF_F_RXFCS feature in the Mscc Ethernet driver. This feature is disabled by default and allow an user to request the driver not to drop the FCS and to extract it into the skb for debugging purposes. Signed-off-by: Antoine Tenart --- drivers/net/ethernet/mscc

[PATCH net-next] net: mscc: allow extracting the FCS into the skb

2018-10-01 Thread Antoine Tenart
This patch adds support for the NETIF_F_RXFCS feature in the Mscc Ethernet driver. This feature is disabled by default and allow an user to request the driver not to drop the FCS and to extract it into the skb for debugging purposes. Signed-off-by: Antoine Tenart --- drivers/net/ethernet/mscc

[PATCH 1/2] arm64: dts: marvell: armada-cp110: change the PPv2 IRQ names

2018-09-24 Thread Antoine Tenart
wouldn't make sense. Signed-off-by: Antoine Tenart --- arch/arm64/boot/dts/marvell/armada-cp110.dtsi | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/arm64/boot/dts/marvell/armada-cp110.dtsi b/arch/arm64/boot/dts/marvell/armada-cp110.dtsi index 840c8454d03e

[PATCH 2/2] arm64: dts: marvell: armada-cp110: describe more PPv2 interrupts

2018-09-24 Thread Antoine Tenart
This patch describes 3 additional interrupts per PPv2 port. Those interrupts will be used later in future versions of the Marvell PPv2 driver, and now the device tree description matches the hardware capabilities. Signed-off-by: Antoine Tenart --- arch/arm64/boot/dts/marvell/armada-cp110.dtsi

[PATCH 1/2] arm64: dts: marvell: armada-cp110: change the PPv2 IRQ names

2018-09-24 Thread Antoine Tenart
wouldn't make sense. Signed-off-by: Antoine Tenart --- arch/arm64/boot/dts/marvell/armada-cp110.dtsi | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/arm64/boot/dts/marvell/armada-cp110.dtsi b/arch/arm64/boot/dts/marvell/armada-cp110.dtsi index 840c8454d03e

[PATCH 2/2] arm64: dts: marvell: armada-cp110: describe more PPv2 interrupts

2018-09-24 Thread Antoine Tenart
This patch describes 3 additional interrupts per PPv2 port. Those interrupts will be used later in future versions of the Marvell PPv2 driver, and now the device tree description matches the hardware capabilities. Signed-off-by: Antoine Tenart --- arch/arm64/boot/dts/marvell/armada-cp110.dtsi

[PATCH net] net: mscc: fix the frame extraction into the skb

2018-09-20 Thread Antoine Tenart
extraction behaviour by discarding the FCS. Fixes: a556c76adc05 ("net: mscc: Add initial Ocelot switch support") Signed-off-by: Antoine Tenart --- Hi all, Once this patch will be accepted and net merged into net-next, I'll probably send another patch to fill skb->csum with

[PATCH net] net: mscc: fix the frame extraction into the skb

2018-09-20 Thread Antoine Tenart
extraction behaviour by discarding the FCS. Fixes: a556c76adc05 ("net: mscc: Add initial Ocelot switch support") Signed-off-by: Antoine Tenart --- Hi all, Once this patch will be accepted and net merged into net-next, I'll probably send another patch to fill skb->csum with

Re: [PATCH 1/2] phy: berlin-usb: switch to SPDX identifier

2018-09-19 Thread Antoine Tenart
On Wed, Sep 19, 2018 at 12:50:51PM +0530, Kishon Vijay Abraham I wrote: > On Wednesday 19 September 2018 12:43 PM, Antoine Tenart wrote: > > > > Any update about these two patches? > > Looks like patches for this from Jisheng Zhang has already made into the 4.19 > ke

Re: [PATCH 1/2] phy: berlin-usb: switch to SPDX identifier

2018-09-19 Thread Antoine Tenart
On Wed, Sep 19, 2018 at 12:50:51PM +0530, Kishon Vijay Abraham I wrote: > On Wednesday 19 September 2018 12:43 PM, Antoine Tenart wrote: > > > > Any update about these two patches? > > Looks like patches for this from Jisheng Zhang has already made into the 4.19 > ke

Re: [PATCH 1/2] phy: berlin-usb: switch to SPDX identifier

2018-09-19 Thread Antoine Tenart
Hello Kishon, Any update about these two patches? Thanks! Antoine On Fri, Jul 13, 2018 at 05:47:03PM +0200, Antoine Tenart wrote: > Use the appropriate SPDX license identifier and drop the license text. > This patch is only cosmetic. > > Signed-off-by: Antoine Tenart > ---

Re: [PATCH 1/2] phy: berlin-usb: switch to SPDX identifier

2018-09-19 Thread Antoine Tenart
Hello Kishon, Any update about these two patches? Thanks! Antoine On Fri, Jul 13, 2018 at 05:47:03PM +0200, Antoine Tenart wrote: > Use the appropriate SPDX license identifier and drop the license text. > This patch is only cosmetic. > > Signed-off-by: Antoine Tenart > ---

[PATCH] MAINTAINERS: update the Annapurna Labs maintainer email

2018-09-19 Thread Antoine Tenart
Free Electrons became Bootlin. Update my email accordingly. Signed-off-by: Antoine Tenart --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 4ece30f15777..b63f3683d485 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1251,7 +1251,7

[PATCH] MAINTAINERS: update the Annapurna Labs maintainer email

2018-09-19 Thread Antoine Tenart
Free Electrons became Bootlin. Update my email accordingly. Signed-off-by: Antoine Tenart --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 4ece30f15777..b63f3683d485 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1251,7 +1251,7

[PATCH 2/2] phy: berlin-sata: switch to SPDX identifier

2018-07-13 Thread Antoine Tenart
Use the appropriate SPDX license identifier and drop the license text. This patch is only cosmetic. Signed-off-by: Antoine Tenart --- drivers/phy/marvell/phy-berlin-sata.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/phy/marvell/phy-berlin-sata.c b/drivers

[PATCH 2/2] phy: berlin-sata: switch to SPDX identifier

2018-07-13 Thread Antoine Tenart
Use the appropriate SPDX license identifier and drop the license text. This patch is only cosmetic. Signed-off-by: Antoine Tenart --- drivers/phy/marvell/phy-berlin-sata.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/phy/marvell/phy-berlin-sata.c b/drivers

[PATCH 1/2] phy: berlin-usb: switch to SPDX identifier

2018-07-13 Thread Antoine Tenart
Use the appropriate SPDX license identifier and drop the license text. This patch is only cosmetic. Signed-off-by: Antoine Tenart --- drivers/phy/marvell/phy-berlin-usb.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/phy/marvell/phy-berlin-usb.c b/drivers/phy

[PATCH 1/2] phy: berlin-usb: switch to SPDX identifier

2018-07-13 Thread Antoine Tenart
Use the appropriate SPDX license identifier and drop the license text. This patch is only cosmetic. Signed-off-by: Antoine Tenart --- drivers/phy/marvell/phy-berlin-usb.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/phy/marvell/phy-berlin-usb.c b/drivers/phy

[PATCH] phy: mvebu-cp110-comphy: switch to SPDX identifier

2018-07-13 Thread Antoine Tenart
Use the appropriate SPDX license identifier and drop the license text. This patch is only cosmetic. Signed-off-by: Antoine Tenart --- drivers/phy/marvell/phy-mvebu-cp110-comphy.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/phy/marvell/phy-mvebu-cp110-comphy.c

[PATCH] phy: mvebu-cp110-comphy: switch to SPDX identifier

2018-07-13 Thread Antoine Tenart
Use the appropriate SPDX license identifier and drop the license text. This patch is only cosmetic. Signed-off-by: Antoine Tenart --- drivers/phy/marvell/phy-mvebu-cp110-comphy.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/phy/marvell/phy-mvebu-cp110-comphy.c

[PATCH] crypto: inside-secure - increase minimum transfer size

2018-05-28 Thread Antoine Tenart
rvell.com> Signed-off-by: Antoine Tenart <antoine.ten...@bootlin.com> --- Hi Herbert, This patch fixes/improves the AEAD support in the SafeXcel driver. As the AEAD support (which introduces the issue) was only merge a few days ago, this patch is not flagged as being a fix. Thanks! Antoin

[PATCH] crypto: inside-secure - increase minimum transfer size

2018-05-28 Thread Antoine Tenart
From: Ofer Heifetz The token size was increased for AEAD support. Occasional authentication fails arise since the result descriptor overflows. This is because the token size and the engine minimal thresholds must be in sync. Signed-off-by: Ofer Heifetz Signed-off-by: Antoine Tenart --- Hi

Re: [PATCH net-next v2 0/3] net: sfp: small improvements

2018-05-24 Thread Antoine Tenart
Hi Florian, On Wed, May 23, 2018 at 11:40:50AM -0700, Florian Fainelli wrote: > > Antoine, can you please do CC the people who worked on that code before, > arguably, send an update to MAINTAINERS file to create a specific > section for PHYLINK. My bad, sorry for that, I'll make sure to Cc

Re: [PATCH net-next v2 0/3] net: sfp: small improvements

2018-05-24 Thread Antoine Tenart
Hi Florian, On Wed, May 23, 2018 at 11:40:50AM -0700, Florian Fainelli wrote: > > Antoine, can you please do CC the people who worked on that code before, > arguably, send an update to MAINTAINERS file to create a specific > section for PHYLINK. My bad, sorry for that, I'll make sure to Cc

[PATCH net-next v2 3/3] Documentation/bindings: net: the sfp i2c-bus property is now mandatory

2018-05-22 Thread Antoine Tenart
The i2c-bus property for sfp modules was made mandatory. Update the documentation to keep it in sync with the driver's behaviour. Signed-off-by: Antoine Tenart <antoine.ten...@bootlin.com> --- Documentation/devicetree/bindings/net/sff,sfp.txt | 4 ++-- 1 file changed, 2 insertions

[PATCH net-next v2 3/3] Documentation/bindings: net: the sfp i2c-bus property is now mandatory

2018-05-22 Thread Antoine Tenart
The i2c-bus property for sfp modules was made mandatory. Update the documentation to keep it in sync with the driver's behaviour. Signed-off-by: Antoine Tenart --- Documentation/devicetree/bindings/net/sff,sfp.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH net-next v2 1/3] net: phy: sfp: warn the user when no tx_disable pin is available

2018-05-22 Thread Antoine Tenart
tx_disable pin wired or available. Signed-off-by: Antoine Tenart <antoine.ten...@bootlin.com> Acked-by: Russell King <rmk+ker...@armlinux.org.uk> --- drivers/net/phy/sfp.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c index

[PATCH net-next v2 2/3] net: phy: sfp: make the i2c-bus dt property mandatory

2018-05-22 Thread Antoine Tenart
This patch makes the i2c-bus property mandatory when using a device tree. If the sfp i2c bus isn't described it's impossible to guess the protocol to use for a given module, and the sfp module would then not work in most cases. Signed-off-by: Antoine Tenart <antoine.ten...@bootlin.

[PATCH net-next v2 1/3] net: phy: sfp: warn the user when no tx_disable pin is available

2018-05-22 Thread Antoine Tenart
tx_disable pin wired or available. Signed-off-by: Antoine Tenart Acked-by: Russell King --- drivers/net/phy/sfp.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c index 4ab6e9a50bbe..a91d12209a81 100644 --- a/drivers/net/phy/sfp.c +++ b

[PATCH net-next v2 2/3] net: phy: sfp: make the i2c-bus dt property mandatory

2018-05-22 Thread Antoine Tenart
This patch makes the i2c-bus property mandatory when using a device tree. If the sfp i2c bus isn't described it's impossible to guess the protocol to use for a given module, and the sfp module would then not work in most cases. Signed-off-by: Antoine Tenart --- drivers/net/phy/sfp.c | 28

[PATCH net-next v2 0/3] net: sfp: small improvements

2018-05-22 Thread Antoine Tenart
patches to make the i2c-bus property mandatory for sfp modules. Since the phylink series: - s/-EOPNOTSUPP/-ENODEV/ in patch 1/2. - I added the acked-by tag in patch 2/2. Antoine Tenart (3): net: phy: sfp: warn the user when no tx_disable pin is available net: phy: sfp: make the i2c-bus dt

[PATCH net-next v2 0/3] net: sfp: small improvements

2018-05-22 Thread Antoine Tenart
patches to make the i2c-bus property mandatory for sfp modules. Since the phylink series: - s/-EOPNOTSUPP/-ENODEV/ in patch 1/2. - I added the acked-by tag in patch 2/2. Antoine Tenart (3): net: phy: sfp: warn the user when no tx_disable pin is available net: phy: sfp: make the i2c-bus dt

Re: [PATCH net-next 0/2] net: sfp: small improvements

2018-05-22 Thread Antoine Tenart
Hi David, On Mon, May 21, 2018 at 11:51:15AM -0400, David Miller wrote: > From: Antoine Tenart <antoine.ten...@bootlin.com> > Date: Thu, 17 May 2018 10:29:05 +0200 > > > This series was part of the mvpp2 phylink one but as we reworked it to > > use fixed-link on the

Re: [PATCH net-next 0/2] net: sfp: small improvements

2018-05-22 Thread Antoine Tenart
Hi David, On Mon, May 21, 2018 at 11:51:15AM -0400, David Miller wrote: > From: Antoine Tenart > Date: Thu, 17 May 2018 10:29:05 +0200 > > > This series was part of the mvpp2 phylink one but as we reworked it to > > use fixed-link on the DB boards, the SFP commits weren

[PATCH] net: mvpp2: typo and cosmetic fixes

2018-05-18 Thread Antoine Tenart
This patch on the Marvell PPv2 driver is only cosmetic. Two typos are removed as well as other cosmetic fixes, such as extra new lines or tabs vs spaces. Suggested-by: Stefan Chulski <stef...@marvell.com> Signed-off-by: Antoine Tenart <antoine.ten...@bootlin.com> --- drivers/net/ethe

[PATCH] net: mvpp2: typo and cosmetic fixes

2018-05-18 Thread Antoine Tenart
This patch on the Marvell PPv2 driver is only cosmetic. Two typos are removed as well as other cosmetic fixes, such as extra new lines or tabs vs spaces. Suggested-by: Stefan Chulski Signed-off-by: Antoine Tenart --- drivers/net/ethernet/marvell/mvpp2.c | 12 1 file changed, 4

[PATCH] crypto: inside-secure - do not use memset on MMIO

2018-05-17 Thread Antoine Tenart
: 1b44c5a60c13 ("crypto: inside-secure - add SafeXcel EIP197 crypto engine driver") Reported-by: Ofer Heifetz <of...@marvell.com> Signed-off-by: Antoine Tenart <antoine.ten...@bootlin.com> --- drivers/crypto/inside-secure/safexcel.c | 4 ++-- 1 file changed, 2 insertions(+), 2 de

[PATCH] crypto: inside-secure - do not use memset on MMIO

2018-05-17 Thread Antoine Tenart
: 1b44c5a60c13 ("crypto: inside-secure - add SafeXcel EIP197 crypto engine driver") Reported-by: Ofer Heifetz Signed-off-by: Antoine Tenart --- drivers/crypto/inside-secure/safexcel.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/inside-secure/saf

Re: [PATCH net-next 1/2] net: phy: sfp: make the i2c-bus property really optional

2018-05-17 Thread Antoine Tenart
On Thu, May 17, 2018 at 03:04:06PM +0200, Andrew Lunn wrote: > > I was thinking about how it reads the bit rate from the EEPROM. From > that it determines what mode the MAC could use, 1000-Base-X, > 2500-Base-X, etc. Can you still configure this correctly via ethtool, > if you don't have the

Re: [PATCH net-next 1/2] net: phy: sfp: make the i2c-bus property really optional

2018-05-17 Thread Antoine Tenart
On Thu, May 17, 2018 at 03:04:06PM +0200, Andrew Lunn wrote: > > I was thinking about how it reads the bit rate from the EEPROM. From > that it determines what mode the MAC could use, 1000-Base-X, > 2500-Base-X, etc. Can you still configure this correctly via ethtool, > if you don't have the

Re: [PATCH net-next 1/2] net: phy: sfp: make the i2c-bus property really optional

2018-05-17 Thread Antoine Tenart
Hi Andrew, On Thu, May 17, 2018 at 02:41:28PM +0200, Andrew Lunn wrote: > On Thu, May 17, 2018 at 10:29:06AM +0200, Antoine Tenart wrote: > > The SFF,SFP documentation is clear about making all the DT properties, > > with the exception of the compatible, option

Re: [PATCH net-next 1/2] net: phy: sfp: make the i2c-bus property really optional

2018-05-17 Thread Antoine Tenart
Hi Andrew, On Thu, May 17, 2018 at 02:41:28PM +0200, Andrew Lunn wrote: > On Thu, May 17, 2018 at 10:29:06AM +0200, Antoine Tenart wrote: > > The SFF,SFP documentation is clear about making all the DT properties, > > with the exception of the compatible, option

Re: [PATCH net-next v3 00/10] net: mvpp2: phylink conversion

2018-05-17 Thread Antoine Tenart
Hi Russell, On Thu, May 17, 2018 at 10:18:56AM +0100, Russell King - ARM Linux wrote: > On Thu, May 17, 2018 at 10:29:29AM +0200, Antoine Tenart wrote: > > Since v2: > > - Removed the SFP description from the DB boards, as their SFP cages > > are wired properly.

Re: [PATCH net-next v3 00/10] net: mvpp2: phylink conversion

2018-05-17 Thread Antoine Tenart
Hi Russell, On Thu, May 17, 2018 at 10:18:56AM +0100, Russell King - ARM Linux wrote: > On Thu, May 17, 2018 at 10:29:29AM +0200, Antoine Tenart wrote: > > Since v2: > > - Removed the SFP description from the DB boards, as their SFP cages > > are wired properly.

[PATCH net-next v3 05/10] net: mvpp2: 1000baseX support

2018-05-17 Thread Antoine Tenart
This patch adds the 1000Base-X PHY mode support in the Marvell PPv2 driver. 1000Base-X is quite close the SGMII and uses nearly the same code path. Signed-off-by: Antoine Tenart <antoine.ten...@bootlin.com> --- drivers/net/ethernet/marvell/mvpp2.c | 72

[PATCH net-next v3 05/10] net: mvpp2: 1000baseX support

2018-05-17 Thread Antoine Tenart
This patch adds the 1000Base-X PHY mode support in the Marvell PPv2 driver. 1000Base-X is quite close the SGMII and uses nearly the same code path. Signed-off-by: Antoine Tenart --- drivers/net/ethernet/marvell/mvpp2.c | 72 1 file changed, 51 insertions(+), 21

[PATCH net-next 0/3] net: mvpp2: small improvements

2018-05-17 Thread Antoine Tenart
Hi all, Those 3 patches are small improvements to the Marvell PPv2 driver. The series does not conflict with the one sent about phylink and 1000/2500baseX support, so the two series can live in parallel. Thanks! Antoine Yan Markman (3): net: mvpp2: avoid checking for free aggregated

[PATCH net-next 0/3] net: mvpp2: small improvements

2018-05-17 Thread Antoine Tenart
Hi all, Those 3 patches are small improvements to the Marvell PPv2 driver. The series does not conflict with the one sent about phylink and 1000/2500baseX support, so the two series can live in parallel. Thanks! Antoine Yan Markman (3): net: mvpp2: avoid checking for free aggregated

[PATCH net-next 1/3] net: mvpp2: avoid checking for free aggregated descriptors twice

2018-05-17 Thread Antoine Tenart
From: Yan Markman <ymark...@marvell.com> Avoid repeating the check for free aggregated descriptors when it already failed at the beginning of the function. Signed-off-by: Yan Markman <ymark...@marvell.com> [Antoine: commit message] Signed-off-by: Antoine Tenart <antoine.ten

[PATCH net-next 3/3] net: mvpp2: print rx error with rate-limit

2018-05-17 Thread Antoine Tenart
From: Yan Markman <ymark...@marvell.com> Prevent flood of RX error prints during heavy traffic with weak signal in link by checking net_ratelimit() before using netdev_err(). Signed-off-by: Yan Markman <ymark...@marvell.com> [Antoine: small rework, commit message] Signed-off-by: An

[PATCH net-next 1/3] net: mvpp2: avoid checking for free aggregated descriptors twice

2018-05-17 Thread Antoine Tenart
From: Yan Markman Avoid repeating the check for free aggregated descriptors when it already failed at the beginning of the function. Signed-off-by: Yan Markman [Antoine: commit message] Signed-off-by: Antoine Tenart --- drivers/net/ethernet/marvell/mvpp2.c | 7 +++ 1 file changed, 3

[PATCH net-next 3/3] net: mvpp2: print rx error with rate-limit

2018-05-17 Thread Antoine Tenart
From: Yan Markman Prevent flood of RX error prints during heavy traffic with weak signal in link by checking net_ratelimit() before using netdev_err(). Signed-off-by: Yan Markman [Antoine: small rework, commit message] Signed-off-by: Antoine Tenart --- drivers/net/ethernet/marvell/mvpp2.c

[PATCH net-next 2/3] net: mvpp2: set mac address does not require the stop/start sequence

2018-05-17 Thread Antoine Tenart
y: Yan Markman <ymark...@marvell.com> [Antoine: commit message] Signed-off-by: Antoine Tenart <antoine.ten...@bootlin.com> --- drivers/net/ethernet/marvell/mvpp2.c | 38 +--- 1 file changed, 7 insertions(+), 31 deletions(-) diff --git a/drivers/net/ethernet/

[PATCH net-next 2/3] net: mvpp2: set mac address does not require the stop/start sequence

2018-05-17 Thread Antoine Tenart
: commit message] Signed-off-by: Antoine Tenart --- drivers/net/ethernet/marvell/mvpp2.c | 38 +--- 1 file changed, 7 insertions(+), 31 deletions(-) diff --git a/drivers/net/ethernet/marvell/mvpp2.c b/drivers/net/ethernet/marvell/mvpp2.c index 73b2f2d331c5..a9483da18e00 100644

[PATCH net-next v3 07/10] arm64: dts: marvell: mcbin: add 10G SFP support

2018-05-17 Thread Antoine Tenart
From: Russell King <rmk+ker...@armlinux.org.uk> This patch adds the SFP cage description in the Marvell Armada 8040 mcbin, for both 10G interfaces. Signed-off-by: Russell King <rmk+ker...@armlinux.org.uk> [Antoine: small reworks, commit message] Signed-off-by: Antoine Tenart

[PATCH net-next v3 07/10] arm64: dts: marvell: mcbin: add 10G SFP support

2018-05-17 Thread Antoine Tenart
From: Russell King This patch adds the SFP cage description in the Marvell Armada 8040 mcbin, for both 10G interfaces. Signed-off-by: Russell King [Antoine: small reworks, commit message] Signed-off-by: Antoine Tenart --- .../boot/dts/marvell/armada-8040-mcbin.dts| 38

[PATCH net-next 0/2] net: sfp: small improvements

2018-05-17 Thread Antoine Tenart
in a separate series. Thanks! Antoine Since last time: - s/-EOPNOTSUPP/-ENODEV/ in patch 1/2. - I added the acked-by tag in patch 2/2. Antoine Tenart (2): net: phy: sfp: make the i2c-bus property really optional net: phy: sfp: warn the user when no tx_disable pin is available drivers/net

[PATCH net-next 2/2] net: phy: sfp: warn the user when no tx_disable pin is available

2018-05-17 Thread Antoine Tenart
tx_disable pin wired or available. Signed-off-by: Antoine Tenart <antoine.ten...@bootlin.com> Acked-by: Russell King <rmk+ker...@armlinux.org.uk> --- drivers/net/phy/sfp.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c index

[PATCH net-next 0/2] net: sfp: small improvements

2018-05-17 Thread Antoine Tenart
in a separate series. Thanks! Antoine Since last time: - s/-EOPNOTSUPP/-ENODEV/ in patch 1/2. - I added the acked-by tag in patch 2/2. Antoine Tenart (2): net: phy: sfp: make the i2c-bus property really optional net: phy: sfp: warn the user when no tx_disable pin is available drivers/net

[PATCH net-next 2/2] net: phy: sfp: warn the user when no tx_disable pin is available

2018-05-17 Thread Antoine Tenart
tx_disable pin wired or available. Signed-off-by: Antoine Tenart Acked-by: Russell King --- drivers/net/phy/sfp.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c index 0fd2a92a6f7b..4e62769b3e00 100644 --- a/drivers/net/phy/sfp.c +++ b

[PATCH net-next v3 08/10] arm64: dts: marvell: mcbin: enable the fourth network interface

2018-05-17 Thread Antoine Tenart
This patch enables the fourth network interface on the Marvell Macchiatobin. It is configured in the 2500Base-X PHY mode. The SFP cage is also described. Signed-off-by: Antoine Tenart <antoine.ten...@bootlin.com> --- .../boot/dts/marvell/armada-8040-mcbin.dts| 32 +++

[PATCH net-next v3 08/10] arm64: dts: marvell: mcbin: enable the fourth network interface

2018-05-17 Thread Antoine Tenart
This patch enables the fourth network interface on the Marvell Macchiatobin. It is configured in the 2500Base-X PHY mode. The SFP cage is also described. Signed-off-by: Antoine Tenart --- .../boot/dts/marvell/armada-8040-mcbin.dts| 32 +++ 1 file changed, 32 insertions

[PATCH net-next v3 02/10] net: mvpp2: phylink support

2018-05-17 Thread Antoine Tenart
, and the changes shouldn't impact its use. Signed-off-by: Antoine Tenart <antoine.ten...@bootlin.com> --- drivers/net/ethernet/marvell/Kconfig | 1 + drivers/net/ethernet/marvell/mvpp2.c | 846 --- 2 files changed, 509 insertions(+), 338 deletions(-) diff --git a/drive

[PATCH net-next v3 02/10] net: mvpp2: phylink support

2018-05-17 Thread Antoine Tenart
, and the changes shouldn't impact its use. Signed-off-by: Antoine Tenart --- drivers/net/ethernet/marvell/Kconfig | 1 + drivers/net/ethernet/marvell/mvpp2.c | 846 --- 2 files changed, 509 insertions(+), 338 deletions(-) diff --git a/drivers/net/ethernet/marvell/Kconfig b

[PATCH net-next v3 03/10] phy: add 2.5G SGMII mode to the phy_mode enum

2018-05-17 Thread Antoine Tenart
This patch adds one more generic PHY mode to the phy_mode enum, to allow configuring generic PHYs to the 2.5G SGMII mode by using the set_mode callback. Signed-off-by: Antoine Tenart <antoine.ten...@bootlin.com> Acked-by: Kishon Vijay Abraham I <kis...@ti.com> --- include/linux/p

[PATCH net-next v3 03/10] phy: add 2.5G SGMII mode to the phy_mode enum

2018-05-17 Thread Antoine Tenart
This patch adds one more generic PHY mode to the phy_mode enum, to allow configuring generic PHYs to the 2.5G SGMII mode by using the set_mode callback. Signed-off-by: Antoine Tenart Acked-by: Kishon Vijay Abraham I --- include/linux/phy/phy.h | 1 + 1 file changed, 1 insertion(+) diff --git

<    1   2   3   4   5   6   7   8   9   10   >