Re: [PATCH v9] pgo: add clang's Profile Guided Optimization infrastructure

2021-04-07 Thread Bill Wendling
On Wed, Apr 7, 2021 at 2:47 PM Nathan Chancellor wrote: > > Hi Bill, > > On Wed, Apr 07, 2021 at 02:17:04PM -0700, Bill Wendling wrote: > > From: Sami Tolvanen > > > > Enable the use of clang's Profile-Guided Optimization[1]. To generate a > > profile,

[PATCH v9] pgo: add clang's Profile Guided Optimization infrastructure

2021-04-07 Thread Bill Wendling
ve, unlike the clang support in kernel/gcov. [1] https://clang.llvm.org/docs/UsersManual.html#profile-guided-optimization Signed-off-by: Sami Tolvanen Co-developed-by: Bill Wendling Signed-off-by: Bill Wendling Tested-by: Nick Desaulniers Reviewed-by: Nick Desaulniers Reviewed-by: Fangrui So

Re: [PATCH v8] pgo: add clang's Profile Guided Optimization infrastructure

2021-02-26 Thread Bill Wendling
On Fri, Feb 26, 2021 at 2:20 PM Bill Wendling wrote: > > From: Sami Tolvanen > > Enable the use of clang's Profile-Guided Optimization[1]. To generate a > profile, the kernel is instrumented with PGO counters, a representative > workload is run, and the raw profile data is col

[PATCH v8] pgo: add clang's Profile Guided Optimization infrastructure

2021-02-26 Thread Bill Wendling
ve, unlike the clang support in kernel/gcov. [1] https://clang.llvm.org/docs/UsersManual.html#profile-guided-optimization Signed-off-by: Sami Tolvanen Co-developed-by: Bill Wendling Signed-off-by: Bill Wendling --- v8: - Rebased on top-of-tree. v7: - Fix minor build failure reported by Sedat.

Re: [PATCH v7] pgo: add clang's Profile Guided Optimization infrastructure

2021-02-22 Thread Bill Wendling
Another bump for review. :-) On Wed, Feb 10, 2021 at 3:25 PM Bill Wendling wrote: > > Bumping for review from Masahiro Yamada and Andrew Morton. > > -bw > > On Fri, Jan 22, 2021 at 2:12 AM Bill Wendling wrote: > > > > From: Sami Tolvanen > > > >

Re: [PATCH v7] pgo: add clang's Profile Guided Optimization infrastructure

2021-02-10 Thread Bill Wendling
Bumping for review from Masahiro Yamada and Andrew Morton. -bw On Fri, Jan 22, 2021 at 2:12 AM Bill Wendling wrote: > > From: Sami Tolvanen > > Enable the use of clang's Profile-Guided Optimization[1]. To generate a > profile, the kernel is instrumented with PGO counters, a

[PATCH v7] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-22 Thread Bill Wendling
ve, unlike the clang support in kernel/gcov. [1] https://clang.llvm.org/docs/UsersManual.html#profile-guided-optimization Signed-off-by: Sami Tolvanen Co-developed-by: Bill Wendling Signed-off-by: Bill Wendling Tested-by: Nick Desaulniers --- v2: - Added "__llvm_profile_instrument_memop&q

Re: [PATCH v5] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-21 Thread Bill Wendling
would consider picking this up. > > On Sat, Jan 16, 2021 at 1:44 AM Bill Wendling wrote: > > > > From: Sami Tolvanen > > > > Enable the use of clang's Profile-Guided Optimization[1]. To generate a > > profile, the kernel is instrumented with PGO counters

[PATCH v6] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-21 Thread Bill Wendling
ve, unlike the clang support in kernel/gcov. [1] https://clang.llvm.org/docs/UsersManual.html#profile-guided-optimization Signed-off-by: Sami Tolvanen Co-developed-by: Bill Wendling Signed-off-by: Bill Wendling Tested-by: Nick Desaulniers --- v2: - Added "__llvm_profile_instrument_memop&q

Re: [PATCH v5] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-18 Thread Bill Wendling
On Mon, Jan 18, 2021 at 9:26 AM Sedat Dilek wrote: > > On Mon, Jan 18, 2021 at 1:39 PM Sedat Dilek wrote: > > > > On Mon, Jan 18, 2021 at 3:32 AM Bill Wendling wrote: > > > > > > On Sun, Jan 17, 2021 at 4:27 PM Sedat Dilek wrote: > > > >

Re: [PATCH v5] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-17 Thread Bill Wendling
On Sun, Jan 17, 2021 at 4:27 PM Sedat Dilek wrote: > > [ big snip ] [More snippage.] > [ CC Fangrui ] > > With the attached... > >[PATCH v3] module: Ignore _GLOBAL_OFFSET_TABLE_ when warning for > undefined symbols > > ...I was finally able to boot into a rebuild PGO-optimized Linux-kernel.

Re: [PATCH v5] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-17 Thread Bill Wendling
> > > > > > On Sun, Jan 17, 2021 at 12:23 PM Sedat Dilek > > > > wrote: > > > > > > > > > > On Sun, Jan 17, 2021 at 11:53 AM Sedat Dilek > > > > > wrote: > > > > > > > > > > > >

Re: [PATCH v5] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-16 Thread Bill Wendling
On Sat, Jan 16, 2021 at 9:39 AM Sedat Dilek wrote: > On Sat, Jan 16, 2021 at 10:44 AM 'Bill Wendling' via Clang Built Linux > wrote: > > > > From: Sami Tolvanen > > > > Enable the use of clang's Profile-Guided Optimization[1]. To generate a > > profile,

[PATCH v5] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-16 Thread Bill Wendling
ve, unlike the clang support in kernel/gcov. [1] https://clang.llvm.org/docs/UsersManual.html#profile-guided-optimization Signed-off-by: Sami Tolvanen Co-developed-by: Bill Wendling Signed-off-by: Bill Wendling --- v2: - Added "__llvm_profile_instrument_memop" based on Nathan Chance

Re: [PATCH v4] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-13 Thread Bill Wendling
On Wed, Jan 13, 2021 at 12:55 PM Nathan Chancellor wrote: > > Hi Bill, > > On Tue, Jan 12, 2021 at 10:19:58PM -0800, Bill Wendling wrote: > > From: Sami Tolvanen > > > > Enable the use of clang's Profile-Guided Optimization[1]. To generate a > > profile,

[PATCH v4] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-12 Thread Bill Wendling
ve, unlike the clang support in kernel/gcov. [1] https://clang.llvm.org/docs/UsersManual.html#profile-guided-optimization Signed-off-by: Sami Tolvanen Co-developed-by: Bill Wendling Signed-off-by: Bill Wendling Change-Id: Ic78e69c682286d3a44c4549a0138578c98138b77 --- v

[PATCH v3] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-11 Thread Bill Wendling
and isn't compatible with clang's gcov support in kernel/gcov. [1] https://clang.llvm.org/docs/UsersManual.html#profile-guided-optimization Signed-off-by: Sami Tolvanen Co-developed-by: Bill Wendling Signed-off-by: Bill Wendling --- v2: - Added "__llvm_profile_instrument_memop&q

[PATCH v2] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-11 Thread Bill Wendling
and isn't compatible with clang's gcov support in kernel/gcov. [1] https://clang.llvm.org/docs/UsersManual.html#profile-guided-optimization Signed-off-by: Sami Tolvanen Co-developed-by: Bill Wendling Signed-off-by: Bill Wendling --- Documentation/dev-tools/index.rst | 1 + Documentation

Re: [PATCH] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-11 Thread Bill Wendling
On Mon, Jan 11, 2021 at 12:31 PM Fangrui Song wrote: > On 2021-01-11, Bill Wendling wrote: > >On Mon, Jan 11, 2021 at 12:12 PM Fangrui Song wrote: > >> > >> On 2021-01-11, 'Bill Wendling' via Clang Built Linux wrote: > >> >From: Sami Tolvanen > &g

Re: [PATCH] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-11 Thread Bill Wendling
On Mon, Jan 11, 2021 at 1:18 PM Nick Desaulniers wrote: > > On Mon, Jan 11, 2021 at 1:04 PM Nathan Chancellor > wrote: > > > > On Mon, Jan 11, 2021 at 12:18:21AM -0800, Bill Wendling wrote: > > > From: Sami Tolvanen > > > > > > Enable

Re: [PATCH] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-11 Thread Bill Wendling
On Mon, Jan 11, 2021 at 12:12 PM Fangrui Song wrote: > > On 2021-01-11, 'Bill Wendling' via Clang Built Linux wrote: > >From: Sami Tolvanen > > > >Enable the use of clang's Profile-Guided Optimization[1]. To generate a > >profile, the kernel is instrumented with

Re: [PATCH] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-11 Thread Bill Wendling
On Mon, Jan 11, 2021 at 12:39 AM Sedat Dilek wrote: > > On Mon, Jan 11, 2021 at 9:18 AM 'Bill Wendling' via Clang Built Linux > wrote: > > > > From: Sami Tolvanen > > > > Enable the use of clang's Profile-Guided Optimization[1]. To generate a > > profi

[PATCH] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-11 Thread Bill Wendling
n verified to work with PGO. Note that this method of profiling the kernel is clang-native and isn't compatible with clang's gcov support in kernel/gcov. [1] https://clang.llvm.org/docs/UsersManual.html#profile-guided-optimization Signed-off-by: Sami Tolvanen Co-developed-by: Bill Wendling

Re: [PATCH] riscv: Explicitly specify the build id style in vDSO Makefile again

2020-11-12 Thread Bill Wendling
is shouldn't matter in general, but there are some tools out there that expect the build id to be of a certain length, i.e. the BFD style's length, because BFD is more prevalent. The obvious response "well, why don't they just change the expected length?" is difficult in all situations

[PATCH] kbuild: explicitly specify the build id style

2020-09-22 Thread Bill Wendling
ld's --build-id defaults to "sha1" style, while lld defaults to "fast". The build IDs are very different between the two, which may confuse programs that reference them. Signed-off-by: Bill Wendling --- Makefile | 4 ++-- arch/arm/vdso/Makefi

Re: [PATCH] x86/smap: Fix the smap_save() asm

2020-09-15 Thread Bill Wendling
On Tue, Sep 15, 2020 at 4:40 PM Andrew Cooper wrote: > > On 16/09/2020 00:11, Andy Lutomirski wrote: > >> On Sep 15, 2020, at 2:24 PM, Nick Desaulniers > >> wrote: > >> > >> On Tue, Sep 15, 2020 at 1:56 PM Andy Lutomirski wrote: > >>> The old smap_save() code was: > >>> > >>> pushf > >>>

Re: [PATCH] x86/smap: Fix the smap_save() asm

2020-09-15 Thread Bill Wendling
On Tue, Sep 15, 2020 at 2:24 PM Nick Desaulniers wrote: > On Tue, Sep 15, 2020 at 1:56 PM Andy Lutomirski wrote: > > Fixes: e74deb11931f ("x86/uaccess: Introduce user_access_{save,restore}()") > > Cc: sta...@vger.kernel.org > > Reported-by: Bill Wendling # I thin

Re: [PATCH bpf-next] selftests/bpf: Switch test_vmlinux to use hrtimer_range_start_ns.

2020-06-30 Thread Bill Wendling
On Tue, Jun 30, 2020 at 3:48 PM Hao Luo wrote: > > On Tue, Jun 30, 2020 at 1:37 PM Yonghong Song wrote: > > > > On 6/30/20 11:49 AM, Hao Luo wrote: > > > The test_vmlinux test uses hrtimer_nanosleep as hook to test tracing > > > programs. But it seems Clang may have done an aggressive

Re: [PATCH] be2net: fix adapter->big_page_size miscaculation

2019-07-18 Thread Bill Wendling
Possibly. I'd need to ask him. :-) On Thu, Jul 18, 2019 at 2:22 PM Nick Desaulniers wrote: > > On Thu, Jul 18, 2019 at 2:18 PM Bill Wendling wrote: > > > > Top-of-tree clang says that it's const: > > > > $ gcc a.c -O2 && ./a.out > > a is

Re: [PATCH] be2net: fix adapter->big_page_size miscaculation

2019-07-18 Thread Bill Wendling
[My previous response was marked as spam...] Top-of-tree clang says that it's const: $ gcc a.c -O2 && ./a.out a is a const. $ clang a.c -O2 && ./a.out a is a const. On Thu, Jul 18, 2019 at 2:10 PM Nick Desaulniers wrote: > > On Thu, Jul 18, 2019 at 2:01 PM Qian Cai wrote: > > > > > > > > >

>2G Files

2001-05-02 Thread Bill Wendling
Hi all, Question: Does Linux support >2G files and, if so, how do I implement this? Thanks. -- || Bill Wendling[EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More m

2G Files

2001-05-02 Thread Bill Wendling
Hi all, Question: Does Linux support 2G files and, if so, how do I implement this? Thanks. -- || Bill Wendling[EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: [PATCH] gcc-3.0 warnings

2001-03-23 Thread Bill Wendling
then bad things could happen... -- || Bill Wendling[EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Pl

Re: [PATCH] gcc-3.0 warnings

2001-03-23 Thread Bill Wendling
bad things could happen... -- || Bill Wendling[EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please r

Re: [rfc] Near-constant time directory index for Ext2

2001-02-21 Thread Bill Wendling
key, but we were originally } > talking about extending ext2, so such massive changes are out of question } > and your log n access argument is right. } > } } It would still be tricky since you have to have actual files in the } filesystem as well. } But that's just a user space iss

Re: [rfc] Near-constant time directory index for Ext2

2001-02-21 Thread Bill Wendling
such massive changes are out of question } and your log n access argument is right. } } } It would still be tricky since you have to have actual files in the } filesystem as well. } But that's just a user space issue, isn't it. (Just kidding :-) -- || Bill Wendling

Re: [IDE] meaningless #ifndef?

2001-02-19 Thread Bill Wendling
gt; If i see well, then this is always same whether CONFIG_IDEDMA_IVB is } > defined or not. } > What's the clue? } [snip...] The use of the ternary operator is superfluous, though...and makes the code look ugly IMNSHO :). -- || Bill Wendling[EMAIL PROTECTED] - To uns

Re: [IDE] meaningless #ifndef?

2001-02-19 Thread Bill Wendling
...] The use of the ternary operator is superfluous, though...and makes the code look ugly IMNSHO :). -- || Bill Wendling[EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More

Re: Linux stifles innovation...

2001-02-15 Thread Bill Wendling
Source? } With the horrid (pro-Microsoft) Aschroft in office, who knows what MS can get away with. Not to mention all of the pro-business, anti-human cronies in Washington running the Presidency (cause \/\/ just can't do it). -- || Bill Wendling[EMAIL PROTECTED

Re: Linux stifles innovation...

2001-02-15 Thread Bill Wendling
Source? } With the horrid (pro-Microsoft) Aschroft in office, who knows what MS can get away with. Not to mention all of the pro-business, anti-human cronies in Washington running the Presidency (cause \/\/ just can't do it). -- || Bill Wendling[EMAIL PROTECTED

OOPs in 2.4.1 SMP

2001-02-12 Thread Bill Wendling
/208] [system_call+51/56] Feb 12 16:03:17 dangermouse kernel: Feb 12 16:03:17 dangermouse kernel: Code: 8b 70 08 8b 46 3c 8b 56 40 89 41 3c 0f ac d0 09 89 41 54 8b -- || Bill Wendling[EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe

OOPs in 2.4.1 SMP

2001-02-12 Thread Bill Wendling
] [sys_lseek+196/208] [system_call+51/56] Feb 12 16:03:17 dangermouse kernel: Feb 12 16:03:17 dangermouse kernel: Code: 8b 70 08 8b 46 3c 8b 56 40 89 41 3c 0f ac d0 09 89 41 54 8b -- || Bill Wendling[EMAIL PROTECTED] - To unsubscribe from this list: send the line

WaveLAN Gold Driver...Anyone?

2001-02-01 Thread Bill Wendling
Hi all, Is anyone working on porting the driver for Lucent Technologies's WaveLAN Gold wireless ethernet card to the 2.4.x kernel? Just didn't want to duplicate effort. Thanks! -- || Bill Wendling[EMAIL PROTECTED] - To unsubscribe from this list: send the line

WaveLAN Gold Driver...Anyone?

2001-02-01 Thread Bill Wendling
Hi all, Is anyone working on porting the driver for Lucent Technologies's WaveLAN Gold wireless ethernet card to the 2.4.x kernel? Just didn't want to duplicate effort. Thanks! -- || Bill Wendling[EMAIL PROTECTED] - To unsubscribe from this list: send the line

Re: Poll and Select not scaling

2001-01-10 Thread Bill Wendling
but I } am unable to do either a select or a poll on them. Does any one know what I } can do to fix this? } Hi Micah, Which kernel version are you using? -- || Bill Wendling[EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe linux-k

Re: Poll and Select not scaling

2001-01-10 Thread Bill Wendling
but I } am unable to do either a select or a poll on them. Does any one know what I } can do to fix this? } Hi Micah, Which kernel version are you using? -- || Bill Wendling[EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe linux-k

Re: Linux 2.4.0ac1

2001-01-05 Thread Bill Wendling
Also sprach Miles Lane: } Bill Wendling wrote: } } > Also sprach Keith Owens: } > } On Thu, 04 Jan 2001 21:54:29 -0800, } > } Miles Lane <[EMAIL PROTECTED]> wrote: } > } >make[4]: Entering directory `/usr/src/linux/drivers/acpi' } > } >/usr/src/linux/Rules.make:

Re: Linux 2.4.0ac1

2001-01-04 Thread Bill Wendling
work as well... -- || Bill Wendling[EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/

Re: Linux 2.4.0ac1

2001-01-04 Thread Bill Wendling
... -- || Bill Wendling[EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/

Laggin Mouse on IBM Thinkpad 240

2000-11-14 Thread Bill Wendling
CONFIG_APM_IGNORE_SUSPEND_BOUNCE=y # CONFIG_APM_RTC_IS_GMT is not set # CONFIG_APM_ALLOWS_INTS is not set # CONFIG_APM_REAL_MODE_POWER_OFF is not set I've tried the 2.4.0test* kernels with similar results... -- || Bill Wendling[EMAIL PROTECTED] - To unsubscribe from this list: send

Laggin Mouse on IBM Thinkpad 240

2000-11-14 Thread Bill Wendling
CONFIG_APM_IGNORE_SUSPEND_BOUNCE=y # CONFIG_APM_RTC_IS_GMT is not set # CONFIG_APM_ALLOWS_INTS is not set # CONFIG_APM_REAL_MODE_POWER_OFF is not set I've tried the 2.4.0test* kernels with similar results... -- || Bill Wendling[EMAIL PROTECTED] - To unsubscribe from this list: send

Re: Linux 2.4 Status / TODO page (Updated as of 2.4.0-test10)

2000-11-03 Thread Bill Wendling
ers? -- || Bill Wendling[EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/

Re: Linux 2.4 Status / TODO page (Updated as of 2.4.0-test10)

2000-11-03 Thread Bill Wendling
. It was buggy, is buggy } and will be buggy. It is inavoidable, as soon as you have hundreds } of drivers. } If they are buggy and unsupported, why aren't they being expunged from the main source tree and placed into a ``contrib'' directory or something for people who may want those drivers? -- || Bill

[patch(?)] question wrt context switching during disk i/o

2000-10-21 Thread Bill Wendling
t; sync flush (wait for I/O completation) */ int balance_dirty_state(kdev_t dev) { Which leads me to believe that the `<' should be either `==' or `<='. I tried it with the `<=' and it doesn't seem to be so bad...Here's a patch to see if it helps you? -- || Bill Wendling[EMAIL

[patch(?)] question wrt context switching during disk i/o

2000-10-21 Thread Bill Wendling
dev) { Which leads me to believe that the `' should be either `==' or `='. I tried it with the `=' and it doesn't seem to be so bad...Here's a patch to see if it helps you? -- || Bill Wendling[EMAIL PROTECTED] --- linux/fs/buffer.c Sat Oct 21 02:55:41 2000 +++ linux

Re: Patch to remove undefined C code

2000-10-17 Thread Bill Wendling
for convenience, but I don't believe it's in the standard. -- || Bill Wendling[EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/

Re: Patch to remove undefined C code

2000-10-17 Thread Bill Wendling
timing test indicate } > that the new code is significantly quicker. } } This is something the compiler ought to know about. } A compiler can only guess so much. Don't look to a compiler to fix poorly written code... -- || Bill Wendling[EMAIL PROTECTED] - To unsubscribe fr

Re: Patch to remove undefined C code

2000-10-17 Thread Bill Wendling
ings is to look at what the standard says and follow it. All else is hopes and wishes. The above code is specified as working in the standard (evaluating the assign and then evaluating the 2). -- || Bill Wendling[EMAIL PROTECTED] - To unsubscribe from this list: send the

Re: Patch to remove undefined C code

2000-10-17 Thread Bill Wendling
s is to look at what the standard says and follow it. All else is hopes and wishes. The above code is specified as working in the standard (evaluating the assign and then evaluating the 2). -- || Bill Wendling[EMAIL PROTECTED] - To unsubscribe from this list: send the line "

Re: Patch to remove undefined C code

2000-10-17 Thread Bill Wendling
nificantly quicker. } } This is something the compiler ought to know about. } A compiler can only guess so much. Don't look to a compiler to fix poorly written code... -- || Bill Wendling[EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscri

Re: Patch to remove undefined C code

2000-10-17 Thread Bill Wendling
for convenience, but I don't believe it's in the standard. -- || Bill Wendling[EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/

Re: Is this a valid construct?

2000-10-16 Thread Bill Wendling
curances where I get the IRQ } (yes, I'm sure of it) but flagvar == 1, which confuses me. } Are you sure there isn't a race on the flagvar variable? Like, the interrupt happens, it gets set to 0, then before we can ``up'' the semaphore, it's set to 1 in the function_called_from_kernel_thread()?

Re: Patch to remove undefined C code

2000-10-16 Thread Bill Wendling
gt;8; } } 6 shift } 4 and } 3 or } Plus 3 assigns...but they may get optimized out. :) } instead of } } 8 shift } 8 and } 7 or } -- || Bill Wendling[EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/

Re: Patch to remove undefined C code

2000-10-16 Thread Bill Wendling
out. :) } instead of } } 8 shift } 8 and } 7 or } -- || Bill Wendling[EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/

Re: Is this a valid construct?

2000-10-16 Thread Bill Wendling
curances where I get the IRQ } (yes, I'm sure of it) but flagvar == 1, which confuses me. } Are you sure there isn't a race on the flagvar variable? Like, the interrupt happens, it gets set to 0, then before we can ``up'' the semaphore, it's set to 1 in the function_called_from_kernel_thread()?

[patch-2.4.0-test9-pre1] mm/filemap.c

2000-09-16 Thread Bill Wendling
joy! -- || Bill Wendling[EMAIL PROTECTED] --- linux-2.4.0-test9-pre1/mm/filemap.c Sat Sep 16 02:21:03 2000 +++ linux-2.4.0-test9-pre1-new/mm/filemap.c Sat Sep 16 02:31:54 2000 @@ -193,12 +193,10 @@ repeat: head = >pages; spin_lock(_lock); - curr = head

[patch-2.4.0-test9-pre1] mm/filemap.c

2000-09-16 Thread Bill Wendling
! -- || Bill Wendling[EMAIL PROTECTED] --- linux-2.4.0-test9-pre1/mm/filemap.c Sat Sep 16 02:21:03 2000 +++ linux-2.4.0-test9-pre1-new/mm/filemap.c Sat Sep 16 02:31:54 2000 @@ -193,12 +193,10 @@ repeat: head = mapping-pages; spin_lock(pagecache_lock

Re: [PATCH 2.4.0-test8] mm/filemap.c

2000-09-14 Thread Bill Wendling
Also sprach Juan J. Quintela: } >>>>> "bill" == Bill Wendling <[EMAIL PROTECTED]> writes: } } Hi } } Linus, please don't apply. } } bill> - The `head = >pages;' statement is useless inside the } bill> repeat, since head isn't m

Re: [PATCH 2.4.0-test8] mm/filemap.c

2000-09-14 Thread Bill Wendling
Also sprach David Mansfield: } Bill Wendling wrote: } > } > Hi Linus, } > } > Here's a small optimization for the mm/filemap.c file. } > } > - The `head = >pages;' statement is useless inside the } > repeat, since head isn't modified inside the loop.

[PATCH 2.4.0-test8] mm/filemap.c

2000-09-14 Thread Bill Wendling
taken. I changed the while() into a for() loop to accomodate this better. Share and enjoy! -- || Bill Wendling[EMAIL PROTECTED] --- linux-2.4.0-test8/mm/filemap.c Sat Sep 9 02:35:09 2000 +++ linux-2.4.0-test8-new/mm/filemap.c Thu Sep 14 03:14:0

Re: Linux-2.4.0-test8-pre6

2000-09-07 Thread Bill Wendling
Also sprach dean gaudet: } On Thu, 7 Sep 2000, Bill Wendling wrote: } > Don't be stupid. } } dude, i gave at least three hints that i was joking up there. stupid } would be if i claimed that it was obvious that a debugger would have } helped this situation. instead all i'm claim

Re: Linux-2.4.0-test8-pre6

2000-09-07 Thread Bill Wendling
if you don't have a debugger you're forced to "think about the code } to find the correct fix"? so, like, why are you guessing right now? :) } Don't be stupid. Because some bugs are very hard to fix no matter what tool/brain you throw at it... -- || Bill Wendling

Re: Linux-2.4.0-test8-pre6

2000-09-07 Thread Bill Wendling
don't have a debugger you're forced to "think about the code } to find the correct fix"? so, like, why are you guessing right now? :) } Don't be stupid. Because some bugs are very hard to fix no matter what tool/brain you throw at it... -- || Bill Wendling[EMAIL

Re: Linux-2.4.0-test8-pre6

2000-09-07 Thread Bill Wendling
Also sprach dean gaudet: } On Thu, 7 Sep 2000, Bill Wendling wrote: } Don't be stupid. } } dude, i gave at least three hints that i was joking up there. stupid } would be if i claimed that it was obvious that a debugger would have } helped this situation. instead all i'm claiming is that it's

Re: linux-2.4.0-test8-pre5

2000-09-06 Thread Bill Wendling
ax):(v))) } } Or perhaps this is a lot better: } } #define FIT(v,min,max) ((v)>(max)?(max):((v)<(min)?(min):(v))) } *pukes* Wouldn't an inline'd function be much much more readable/maintainable?? -- || Bill Wendling[EMAIL PROTECTED] - To unsubscribe from this

Re: linux-2.4.0-test8-pre5

2000-09-06 Thread Bill Wendling
: } } #define FIT(v,min,max) ((v)(max)?(max):((v)(min)?(min):(v))) } *pukes* Wouldn't an inline'd function be much much more readable/maintainable?? -- || Bill Wendling[EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe linux-kernel" i