[PATCH v3] virt: kvm: arm: vgic: Process the failure case when kvm_register_device_ops() fails

2014-12-01 Thread Chen Gang
kvm_register_device_ops() may fail, so need process the related failure case. Since it is related with neither vgic_arch_setup() nor on_each_cpu(), can move it before them, then simplify the related failure processing code. Signed-off-by: Chen Gang --- virt/kvm/arm/vgic.c | 11 +-- 1

Re: [PATCH] arch: uapi: asm: mman.h: Support MADV_FREE for madvise()

2014-12-01 Thread Chen Gang
On 12/2/14 06:01, Carlos O'Donell wrote: On Mon, Dec 1, 2014 at 4:35 PM, Geert Uytterhoeven ge...@linux-m68k.org wrote: On Mon, Dec 1, 2014 at 9:52 PM, Max Filippov jcmvb...@gmail.com wrote: On Mon, Dec 1, 2014 at 11:43 PM, Chen Gang gang.chen.5...@gmail.com wrote: At present, kernel

Re: [PATCH] arch: uapi: asm: mman.h: Support MADV_FREE for madvise()

2014-12-01 Thread Chen Gang
On 12/2/14 09:55, James Bottomley wrote: On Mon, 2014-12-01 at 17:01 -0500, Carlos O'Donell wrote: On Mon, Dec 1, 2014 at 4:35 PM, Geert Uytterhoeven ge...@linux-m68k.org wrote: On Mon, Dec 1, 2014 at 9:52 PM, Max Filippov jcmvb...@gmail.com wrote: On Mon, Dec 1, 2014 at 11:43 PM, Chen Gang

[PATCH v3] virt: kvm: arm: vgic: Process the failure case when kvm_register_device_ops() fails

2014-12-01 Thread Chen Gang
kvm_register_device_ops() may fail, so need process the related failure case. Since it is related with neither vgic_arch_setup() nor on_each_cpu(), can move it before them, then simplify the related failure processing code. Signed-off-by: Chen Gang gang.chen.5...@gmail.com --- virt/kvm/arm

[PATCH] arch: uapi: asm: mman.h: Support MADV_FREE for madvise()

2014-12-01 Thread Chen Gang
MADV_FREE: ^ make[1]: *** [mm/madvise.o] Error 1 make: *** [mm] Error 2 Signed-off-by: Chen Gang gang.chen.5...@gmail.com --- arch/alpha/include/uapi/asm/mman.h | 1 + arch/mips/include/uapi/asm/mman.h | 1 + arch/parisc/include/uapi/asm/mman.h | 1 + arch/xtensa/include/uapi/asm

[PATCH] arch: uapi: asm: mman.h: Support MADV_FREE for madvise()

2014-12-01 Thread Chen Gang
MADV_FREE: ^ make[1]: *** [mm/madvise.o] Error 1 make: *** [mm] Error 2 Signed-off-by: Chen Gang gang.chen.5...@gmail.com --- arch/alpha/include/uapi/asm/mman.h | 1 + arch/mips/include/uapi/asm/mman.h | 1 + arch/parisc/include/uapi/asm/mman.h | 1 + arch/xtensa/include/uapi/asm

Re: [PATCH] kvm: arm: vgic: Let one looping code instead of two looping code

2014-11-30 Thread Chen Gang
On 11/30/14 19:08, Christoffer Dall wrote: > On Mon, Dec 01, 2014 at 10:04:32PM +0800, Chen Gang wrote: >> On 11/30/2014 06:07 PM, Christoffer Dall wrote: >>> On Sun, Nov 30, 2014 at 12:18:04PM +0800, Chen Gang wrote: >>>> Use one looping instead of two, so can

Re: [PATCH] kvm: arm: vgic: Let one looping code instead of two looping code

2014-11-30 Thread Chen Gang
On 11/30/2014 06:07 PM, Christoffer Dall wrote: > On Sun, Nov 30, 2014 at 12:18:04PM +0800, Chen Gang wrote: >> Use one looping instead of two, so can let code more simpler and get a >> little better performance. >> >> Signed-off-by: Chen Gang > > Performa

Re: [PATCH] kvm: arm: vgic: Let one looping code instead of two looping code

2014-11-30 Thread Chen Gang
On 11/30/2014 06:07 PM, Christoffer Dall wrote: On Sun, Nov 30, 2014 at 12:18:04PM +0800, Chen Gang wrote: Use one looping instead of two, so can let code more simpler and get a little better performance. Signed-off-by: Chen Gang gang.chen.5...@gmail.com Performance? Please

Re: [PATCH] kvm: arm: vgic: Let one looping code instead of two looping code

2014-11-30 Thread Chen Gang
On 11/30/14 19:08, Christoffer Dall wrote: On Mon, Dec 01, 2014 at 10:04:32PM +0800, Chen Gang wrote: On 11/30/2014 06:07 PM, Christoffer Dall wrote: On Sun, Nov 30, 2014 at 12:18:04PM +0800, Chen Gang wrote: Use one looping instead of two, so can let code more simpler and get a little better

[PATCH] kvm: arm: vgic: Let one looping code instead of two looping code

2014-11-29 Thread Chen Gang
Use one looping instead of two, so can let code more simpler and get a little better performance. Signed-off-by: Chen Gang --- virt/kvm/arm/vgic.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/virt/kvm/arm/vgic.c b/virt/kvm/arm/vgic.c index cf23c13..eb1a51b 100644 --- a/virt/kvm/arm

Re: [PATCH v2] virt: kvm: arm: vgic: Process the failure case when kvm_register_device_ops() fails

2014-11-29 Thread Chen Gang
Hello maintainers: Is this discussion OK? If necessary, I shall send patch v3 according to your taste. Thanks. On 11/15/14 00:30, Chen Gang wrote: > > According to your taste, we need improve 2 contents below: > > On 11/14/2014 11:55 PM, Marc Zyngier wrote: >> >>

Re: [PATCH] drivers: scsi: megaraid: Add "megaraid_sas_internal.h" for internal shared functions using

2014-11-29 Thread Chen Gang
On 11/17/14 19:51, Sumit Saxena wrote: >> -Original Message- >> From: Chen Gang [mailto:gang.chen.5...@gmail.com] >> Sent: Monday, November 17, 2014 5:17 PM >> To: Sumit Saxena >> Cc: megaraidli...@lsi.com; linux-s...@vger.kernel.org; linux- >> ker...@vg

Re: [PATCH] drivers: scsi: megaraid: Add megaraid_sas_internal.h for internal shared functions using

2014-11-29 Thread Chen Gang
On 11/17/14 19:51, Sumit Saxena wrote: -Original Message- From: Chen Gang [mailto:gang.chen.5...@gmail.com] Sent: Monday, November 17, 2014 5:17 PM To: Sumit Saxena Cc: megaraidli...@lsi.com; linux-s...@vger.kernel.org; linux- ker...@vger.kernel.org Subject: RE: [PATCH] drivers

Re: [PATCH v2] virt: kvm: arm: vgic: Process the failure case when kvm_register_device_ops() fails

2014-11-29 Thread Chen Gang
Hello maintainers: Is this discussion OK? If necessary, I shall send patch v3 according to your taste. Thanks. On 11/15/14 00:30, Chen Gang wrote: According to your taste, we need improve 2 contents below: On 11/14/2014 11:55 PM, Marc Zyngier wrote: No. This is completely overdesigned

[PATCH] kvm: arm: vgic: Let one looping code instead of two looping code

2014-11-29 Thread Chen Gang
Use one looping instead of two, so can let code more simpler and get a little better performance. Signed-off-by: Chen Gang gang.chen.5...@gmail.com --- virt/kvm/arm/vgic.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/virt/kvm/arm/vgic.c b/virt/kvm/arm/vgic.c index cf23c13..eb1a51b

RE: [PATCH] drivers: scsi: megaraid: Add "megaraid_sas_internal.h" for internal shared functions using

2014-11-17 Thread Chen Gang
OK, I will send patch v2 for it. I sent this patch based on Linux next tree, please tell me the tree location (git address) which I shall base on for sending patch v2. Thanks. Send from Lenovo A788t. Sumit Saxena wrote: >>-Original Message- >>From: Chen Gang [mailto

RE: [PATCH] drivers: scsi: megaraid: Add megaraid_sas_internal.h for internal shared functions using

2014-11-17 Thread Chen Gang
OK, I will send patch v2 for it. I sent this patch based on Linux next tree, please tell me the tree location (git address) which I shall base on for sending patch v2. Thanks. Send from Lenovo A788t. Sumit Saxena sumit.sax...@avagotech.com wrote: -Original Message- From: Chen Gang

Re: [PATCH v2] virt: kvm: arm: vgic: Process the failure case when kvm_register_device_ops() fails

2014-11-14 Thread Chen Gang
gt; out_free_irq: > free_percpu_irq(vgic->maint_irq, kvm_get_running_vcpus()); > > This achieves the exact same effect. > > Thanks, > > M. > -- Chen Gang Open share and attitude like air water and life which God blessed -- To unsubscribe from this list: s

[PATCH v2] virt: kvm: arm: vgic: Process the failure case when kvm_register_device_ops() fails

2014-11-14 Thread Chen Gang
When kvm_register_device_ops() fails, need disable_percpu_irq(), need vgic_arch_unsetup(), need __unregister_cpu_notifier(), and also need free_percpu_irq(). At present, there is no vgic_arch_unsetup(), so add it for resetting '__vgic_sr_vectors'. Signed-off-by: Chen Gang --- arch/arm/include

Re: [PATCH] virt: kvm: arm: vgic: Process the failure case when kvm_register_device_ops() fails

2014-11-14 Thread Chen Gang
On 11/14/2014 10:53 PM, Marc Zyngier wrote: > On 14/11/14 14:27, Chen Gang wrote: >> On 11/14/2014 10:09 PM, Marc Zyngier wrote: >>> On 14/11/14 14:05, Chen Gang wrote: >>>> On 11/13/2014 11:30 PM, Marc Zyngier wrote: >>>>> On 13/11/14 15:04, Chen Ga

Re: [PATCH] virt: kvm: arm: vgic: Process the failure case when kvm_register_device_ops() fails

2014-11-14 Thread Chen Gang
On 11/14/2014 10:09 PM, Marc Zyngier wrote: > On 14/11/14 14:05, Chen Gang wrote: >> On 11/13/2014 11:30 PM, Marc Zyngier wrote: >>> On 13/11/14 15:04, Chen Gang wrote: >>>> When kvm_register_device_ops() fails, also need call free_percpu_irq() >>

Re: [PATCH] virt: kvm: arm: vgic: Process the failure case when kvm_register_device_ops() fails

2014-11-14 Thread Chen Gang
On 11/13/2014 11:30 PM, Marc Zyngier wrote: > On 13/11/14 15:04, Chen Gang wrote: >> When kvm_register_device_ops() fails, also need call free_percpu_irq() >> just like others have down within kvm_vgic_hyp_init(). >> >> Signed-off-by: Chen Gang >> --- >> vi

Re: [PATCH] virt: kvm: arm: vgic: Process the failure case when kvm_register_device_ops() fails

2014-11-14 Thread Chen Gang
On 11/13/2014 11:30 PM, Marc Zyngier wrote: > On 13/11/14 15:04, Chen Gang wrote: >> When kvm_register_device_ops() fails, also need call free_percpu_irq() >> just like others have down within kvm_vgic_hyp_init(). >> >> Signed-off-by: Chen Gang >> --- >> vi

Re: [PATCH] virt: kvm: arm: vgic: Process the failure case when kvm_register_device_ops() fails

2014-11-14 Thread Chen Gang
On 11/13/2014 11:30 PM, Marc Zyngier wrote: On 13/11/14 15:04, Chen Gang wrote: When kvm_register_device_ops() fails, also need call free_percpu_irq() just like others have down within kvm_vgic_hyp_init(). Signed-off-by: Chen Gang gang.chen.5...@gmail.com --- virt/kvm/arm/vgic.c | 10

Re: [PATCH] virt: kvm: arm: vgic: Process the failure case when kvm_register_device_ops() fails

2014-11-14 Thread Chen Gang
On 11/13/2014 11:30 PM, Marc Zyngier wrote: On 13/11/14 15:04, Chen Gang wrote: When kvm_register_device_ops() fails, also need call free_percpu_irq() just like others have down within kvm_vgic_hyp_init(). Signed-off-by: Chen Gang gang.chen.5...@gmail.com --- virt/kvm/arm/vgic.c | 10

Re: [PATCH] virt: kvm: arm: vgic: Process the failure case when kvm_register_device_ops() fails

2014-11-14 Thread Chen Gang
On 11/14/2014 10:09 PM, Marc Zyngier wrote: On 14/11/14 14:05, Chen Gang wrote: On 11/13/2014 11:30 PM, Marc Zyngier wrote: On 13/11/14 15:04, Chen Gang wrote: When kvm_register_device_ops() fails, also need call free_percpu_irq() just like others have down within kvm_vgic_hyp_init

Re: [PATCH] virt: kvm: arm: vgic: Process the failure case when kvm_register_device_ops() fails

2014-11-14 Thread Chen Gang
On 11/14/2014 10:53 PM, Marc Zyngier wrote: On 14/11/14 14:27, Chen Gang wrote: On 11/14/2014 10:09 PM, Marc Zyngier wrote: On 14/11/14 14:05, Chen Gang wrote: On 11/13/2014 11:30 PM, Marc Zyngier wrote: On 13/11/14 15:04, Chen Gang wrote: When kvm_register_device_ops() fails, also need call

[PATCH v2] virt: kvm: arm: vgic: Process the failure case when kvm_register_device_ops() fails

2014-11-14 Thread Chen Gang
When kvm_register_device_ops() fails, need disable_percpu_irq(), need vgic_arch_unsetup(), need __unregister_cpu_notifier(), and also need free_percpu_irq(). At present, there is no vgic_arch_unsetup(), so add it for resetting '__vgic_sr_vectors'. Signed-off-by: Chen Gang gang.chen.5

Re: [PATCH v2] virt: kvm: arm: vgic: Process the failure case when kvm_register_device_ops() fails

2014-11-14 Thread Chen Gang
the exact same effect. Thanks, M. -- Chen Gang Open share and attitude like air water and life which God blessed -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

[PATCH] virt: kvm: arm: vgic: Process the failure case when kvm_register_device_ops() fails

2014-11-13 Thread Chen Gang
When kvm_register_device_ops() fails, also need call free_percpu_irq() just like others have down within kvm_vgic_hyp_init(). Signed-off-by: Chen Gang --- virt/kvm/arm/vgic.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/virt/kvm/arm/vgic.c b/virt/kvm/arm/vgic.c

[PATCH] virt: kvm: arm: vgic: Process the failure case when kvm_register_device_ops() fails

2014-11-13 Thread Chen Gang
When kvm_register_device_ops() fails, also need call free_percpu_irq() just like others have down within kvm_vgic_hyp_init(). Signed-off-by: Chen Gang gang.chen.5...@gmail.com --- virt/kvm/arm/vgic.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/virt/kvm/arm

Re: [PATCH] arch: tile: gxio: Export symbols for module using in 'mpipe.c'

2014-11-12 Thread Chen Gang
On 11/13/14 4:18, Chris Metcalf wrote: > On 11/11/2014 7:16 PM, Chen Gang wrote: >> And I also want to consult, can tile be run under qemu or other >> simulators? Welcome any ideas, suggestions, and completions. > > Our use of qemu so far as been purely in the context of vi

Re: [PATCH] virt: kvm: arm: vgic: Return failure code '-EBUSY' when mutex_trylock() fails

2014-11-12 Thread Chen Gang
On 11/13/14 3:41, Christoffer Dall wrote: > On Wed, Nov 12, 2014 at 11:04:23PM +0800, Chen Gang wrote: >> When mutex_trylock() fails, kvm_vgic_create() will not create 'vgic', so >> it need return failure code '-EBUSY' instead of '0' to let outside know >> about it. >

Re: [PATCH] arch: tile: kernel: kgdb.c: Use memcpy() instead of pointer copy one by one

2014-11-12 Thread Chen Gang
Thank you for your detail information, and what you said sounds reasonable to me. Send from Lenovo A788t. Jeff Epler wrote: >On Wed, Nov 12, 2014 at 11:43:08PM +0800, Chen Gang wrote: >> > (I assume the >> > compiler

Re: [PATCH] arch: tile: kernel: kgdb.c: Use memcpy() instead of pointer copy one by one

2014-11-12 Thread Chen Gang
ad from memory with > a constant load or even no load at all) > Excuse me, my English is not quite well, I can not understand what you said above. (If necessary, please help provide more details for it). Thanks. -- Chen Gang Open share and attitude like air water and life which God

[PATCH] virt: kvm: arm: vgic: Return failure code '-EBUSY' when mutex_trylock() fails

2014-11-12 Thread Chen Gang
variable 'vcpu_lock_idx'. Signed-off-by: Chen Gang --- virt/kvm/arm/vgic.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/virt/kvm/arm/vgic.c b/virt/kvm/arm/vgic.c index 3aaca49..5846725 100644 --- a/virt/kvm/arm/vgic.c +++ b/virt/kvm/arm/vgic.c @@ -1933,7 +1933,7

[PATCH] virt: kvm: arm: vgic: Return failure code '-EBUSY' when mutex_trylock() fails

2014-11-12 Thread Chen Gang
variable 'vcpu_lock_idx'. Signed-off-by: Chen Gang gang.chen.5...@gmail.com --- virt/kvm/arm/vgic.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/virt/kvm/arm/vgic.c b/virt/kvm/arm/vgic.c index 3aaca49..5846725 100644 --- a/virt/kvm/arm/vgic.c +++ b/virt/kvm/arm

Re: [PATCH] arch: tile: kernel: kgdb.c: Use memcpy() instead of pointer copy one by one

2014-11-12 Thread Chen Gang
provide more details for it). Thanks. -- Chen Gang Open share and attitude like air water and life which God blessed -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH] arch: tile: kernel: kgdb.c: Use memcpy() instead of pointer copy one by one

2014-11-12 Thread Chen Gang
Thank you for your detail information, and what you said sounds reasonable to me. Send from Lenovo A788t. Jeff Epler jep...@unpythonic.net wrote: On Wed, Nov 12, 2014 at 11:43:08PM +0800, Chen Gang wrote: (I assume the compiler could do

Re: [PATCH] virt: kvm: arm: vgic: Return failure code '-EBUSY' when mutex_trylock() fails

2014-11-12 Thread Chen Gang
On 11/13/14 3:41, Christoffer Dall wrote: On Wed, Nov 12, 2014 at 11:04:23PM +0800, Chen Gang wrote: When mutex_trylock() fails, kvm_vgic_create() will not create 'vgic', so it need return failure code '-EBUSY' instead of '0' to let outside know about it. I already sent a patch

Re: [PATCH] arch: tile: gxio: Export symbols for module using in 'mpipe.c'

2014-11-12 Thread Chen Gang
On 11/13/14 4:18, Chris Metcalf wrote: On 11/11/2014 7:16 PM, Chen Gang wrote: And I also want to consult, can tile be run under qemu or other simulators? Welcome any ideas, suggestions, and completions. Our use of qemu so far as been purely in the context of virtualization, where

Re: [PATCH] arch: tile: kernel: kgdb.c: Use memcpy() instead of pointer copy one by one

2014-11-11 Thread Chen Gang
Hello maintainer: Please help check this patch, when you have time (sorry for my original typo for your email address, so maybe you did not notice about the original mail). Thanks. On 11/1/14 21:17, Chen Gang wrote: > Not only memcpy() is faster than pointer copy, but also let code m

Re: [PATCH] arch: tile: gxio: Export symbols for module using in 'mpipe.c'

2014-11-11 Thread Chen Gang
: >On 11/9/2014 5:32 AM, Chen Gang wrote: >> 'gxio_mpipe_adjust_timestamp', 'gxio_mpipe_link_instance', >> 'gxio_mpipe_get_timestamp', and 'gxio_mpipe_set_timestamp' may be use by >> other tile modules, so export them. >> >> The related error (with allmodconfig under tile)

Re: [PATCH] arch: tile: gxio: Export symbols for module using in 'mpipe.c'

2014-11-11 Thread Chen Gang
...@ezchip.com wrote: On 11/9/2014 5:32 AM, Chen Gang wrote: 'gxio_mpipe_adjust_timestamp', 'gxio_mpipe_link_instance', 'gxio_mpipe_get_timestamp', and 'gxio_mpipe_set_timestamp' may be use by other tile modules, so export them. The related error (with allmodconfig under tile): MODPOST 4002

Re: [PATCH] arch: tile: kernel: kgdb.c: Use memcpy() instead of pointer copy one by one

2014-11-11 Thread Chen Gang
Hello maintainer: Please help check this patch, when you have time (sorry for my original typo for your email address, so maybe you did not notice about the original mail). Thanks. On 11/1/14 21:17, Chen Gang wrote: Not only memcpy() is faster than pointer copy, but also let code more clearer

Re: [PATCH] drivers: input: mouse: Use "static inline" instead of "inline" in "lifebook.h"

2014-11-09 Thread Chen Gang
After this patch, our tile can pass allmodconfig building. :-) Thanks. On 11/09/2014 06:46 PM, Chen Gang wrote: > For inline function in header file, better to be "static inline", or may > cause building break under the latest upstream gcc (although, probably, > it should

[PATCH] drivers: input: mouse: Use "static inline" instead of "inline" in "lifebook.h"

2014-11-09 Thread Chen Gang
quot; [drivers/input/mouse/psmouse.ko] undefined! Signed-off-by: Chen Gang --- drivers/input/mouse/lifebook.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/input/mouse/lifebook.h b/drivers/input/mouse/lifebook.h index 4c4326c..0baf02a 100644 --- a/drivers/input/mo

[PATCH] arch: tile: gxio: Export symbols for module using in 'mpipe.c'

2014-11-09 Thread Chen Gang
et/ethernet/tile/tile_net.ko] undefined! Signed-off-by: Chen Gang --- arch/tile/gxio/mpipe.c | 4 1 file changed, 4 insertions(+) diff --git a/arch/tile/gxio/mpipe.c b/arch/tile/gxio/mpipe.c index 320ff5e..6f00e985 100644 --- a/arch/tile/gxio/mpipe.c +++ b/arch/tile/gxio/mpipe.c @@ -463,

[PATCH] drivers: scsi: megaraid: Add "megaraid_sas_internal.h" for internal shared functions using

2014-11-09 Thread Chen Gang
's or ld's issue), the related error (with allmodconfig under tile): MODPOST 4002 modules ERROR: "megasas_return_cmd" [drivers/scsi/megaraid/megaraid_sas.ko] undefined! ERROR: "megasas_is_ldio" [drivers/scsi/megaraid/megaraid_sas.ko] undefined! Signed-off-by: Chen Ga

[PATCH] drivers: scsi: megaraid: Add "megaraid_sas_internal.h" for internal shared functions using

2014-11-09 Thread Chen Gang
's or ld's issue), the related error (with allmodconfig under tile): MODPOST 4002 modules ERROR: "megasas_return_cmd" [drivers/scsi/megaraid/megaraid_sas.ko] undefined! ERROR: "megasas_is_ldio" [drivers/scsi/megaraid/megaraid_sas.ko] undefined! Signed-off-by: Chen Ga

Re: [PATCH] lib: mpi: Use "static inline" instead of "extern inline" in header file for __GNUC__

2014-11-09 Thread Chen Gang
On 11/09/2014 05:11 PM, Joe Perches wrote: > On Sun, 2014-11-09 at 16:58 +0800, Chen Gang wrote: >> In header file, "extern inline" may cause multiple definition, so need >> change it to "static inline". And also need be quoted by __GNUC__ for >> they

[PATCH] lib: mpi: Use "static inline" instead of "extern inline" in header file for __GNUC__

2014-11-09 Thread Chen Gang
eneric_mpih-lshift.c:(.text+0x278): first defined here lib/mpi/generic_mpih-mul1.o: In function `mpihelp_sub': generic_mpih-mul1.c:(.text+0x368): multiple definition of `mpihelp_sub' lib/mpi/generic_mpih-lshift.o:generic_mpih-lshift.c:(.text+0x368): first defined here ... Signed-off-by:

[PATCH] lib: mpi: Use static inline instead of extern inline in header file for __GNUC__

2014-11-09 Thread Chen Gang
:(.text+0x278): first defined here lib/mpi/generic_mpih-mul1.o: In function `mpihelp_sub': generic_mpih-mul1.c:(.text+0x368): multiple definition of `mpihelp_sub' lib/mpi/generic_mpih-lshift.o:generic_mpih-lshift.c:(.text+0x368): first defined here ... Signed-off-by: Chen Gang gang.chen.5

Re: [PATCH] lib: mpi: Use static inline instead of extern inline in header file for __GNUC__

2014-11-09 Thread Chen Gang
On 11/09/2014 05:11 PM, Joe Perches wrote: On Sun, 2014-11-09 at 16:58 +0800, Chen Gang wrote: In header file, extern inline may cause multiple definition, so need change it to static inline. And also need be quoted by __GNUC__ for they are as inline functions only for __GNUC__. [] diff

[PATCH] drivers: scsi: megaraid: Add megaraid_sas_internal.h for internal shared functions using

2014-11-09 Thread Chen Gang
issue), the related error (with allmodconfig under tile): MODPOST 4002 modules ERROR: megasas_return_cmd [drivers/scsi/megaraid/megaraid_sas.ko] undefined! ERROR: megasas_is_ldio [drivers/scsi/megaraid/megaraid_sas.ko] undefined! Signed-off-by: Chen Gang gang.chen.5...@gmail.com

[PATCH] drivers: scsi: megaraid: Add megaraid_sas_internal.h for internal shared functions using

2014-11-09 Thread Chen Gang
issue), the related error (with allmodconfig under tile): MODPOST 4002 modules ERROR: megasas_return_cmd [drivers/scsi/megaraid/megaraid_sas.ko] undefined! ERROR: megasas_is_ldio [drivers/scsi/megaraid/megaraid_sas.ko] undefined! Signed-off-by: Chen Gang gang.chen.5...@gmail.com

[PATCH] arch: tile: gxio: Export symbols for module using in 'mpipe.c'

2014-11-09 Thread Chen Gang
! Signed-off-by: Chen Gang gang.chen.5...@gmail.com --- arch/tile/gxio/mpipe.c | 4 1 file changed, 4 insertions(+) diff --git a/arch/tile/gxio/mpipe.c b/arch/tile/gxio/mpipe.c index 320ff5e..6f00e985 100644 --- a/arch/tile/gxio/mpipe.c +++ b/arch/tile/gxio/mpipe.c @@ -463,6 +463,7 @@ int

[PATCH] drivers: input: mouse: Use static inline instead of inline in lifebook.h

2014-11-09 Thread Chen Gang
/psmouse.ko] undefined! Signed-off-by: Chen Gang gang.chen.5...@gmail.com --- drivers/input/mouse/lifebook.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/input/mouse/lifebook.h b/drivers/input/mouse/lifebook.h index 4c4326c..0baf02a 100644 --- a/drivers/input

Re: [PATCH] drivers: input: mouse: Use static inline instead of inline in lifebook.h

2014-11-09 Thread Chen Gang
After this patch, our tile can pass allmodconfig building. :-) Thanks. On 11/09/2014 06:46 PM, Chen Gang wrote: For inline function in header file, better to be static inline, or may cause building break under the latest upstream gcc (although, probably, it should be the gcc's issue

[PATCH] drivers: staging: lustre: Kconfig: Let LUSTRE_LLITE_LLOOP depend on all !"*_64K*" page

2014-11-08 Thread Chen Gang
K" to find all 64K page macros. Signed-off-by: Chen Gang --- drivers/staging/lustre/lustre/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/Kconfig b/drivers/staging/lustre/lustre/Kconfig index 4f65ba1..6725467 100644 --- a/drivers/s

[PATCH] drivers: staging: lustre: Kconfig: Let LUSTRE_LLITE_LLOOP depend on all !*_64K* page

2014-11-08 Thread Chen Gang
. Signed-off-by: Chen Gang gang.chen.5...@gmail.com --- drivers/staging/lustre/lustre/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/Kconfig b/drivers/staging/lustre/lustre/Kconfig index 4f65ba1..6725467 100644 --- a/drivers/staging/lustre

Re: [PATCH] include/linux/audit.h: Move dummy audit_file() from !AUDIT area to !AUDITSYSCALL area

2014-11-06 Thread Chen Gang
I intended to put it here for topology symmetric position with the real world declaration. Please check. Thanks. Send from Lenovo A788t. Paul Moore wrote: >On Thursday, November 06, 2014 11:19:06 AM Chen Gang wrote: >> On 11/6/14 4:43, Paul Moore wrote: >> > On Tuesday, No

Re: [PATCH] include/linux/audit.h: Move dummy audit_file() from !AUDIT area to !AUDITSYSCALL area

2014-11-06 Thread Chen Gang
I intended to put it here for topology symmetric position with the real world declaration. Please check. Thanks. Send from Lenovo A788t. Paul Moore p...@paul-moore.com wrote: On Thursday, November 06, 2014 11:19:06 AM Chen Gang wrote: On 11/6/14 4:43, Paul Moore wrote: On Tuesday, November

Re: [PATCH] include/linux/audit.h: Move dummy audit_file() from !AUDIT area to !AUDITSYSCALL area

2014-11-05 Thread Chen Gang
On 11/6/14 4:43, Paul Moore wrote: > On Tuesday, November 04, 2014 11:09:52 PM Chen Gang wrote: >> audit_file() is related with AUDITSYSCALL, not related with AUDIT, so >> need move dummy one from !AUDIT area to !AUDITSYSCALL area. Or it will >> cause

Re: [PATCH] include/linux/audit.h: Move dummy audit_file() from !AUDIT area to !AUDITSYSCALL area

2014-11-05 Thread Chen Gang
On 11/6/14 4:43, Paul Moore wrote: On Tuesday, November 04, 2014 11:09:52 PM Chen Gang wrote: audit_file() is related with AUDITSYSCALL, not related with AUDIT, so need move dummy one from !AUDIT area to !AUDITSYSCALL area. Or it will cause issue if CONFIG_AUDIT with !CONFIG_AUDITSYSCALL

[PATCH] include/linux/audit.h: Move dummy audit_file() from !AUDIT area to !AUDITSYSCALL area

2014-11-04 Thread Chen Gang
'SYSC_fchmod': fs/open.c:530:3: error: implicit declaration of function 'audit_file' [-Werror=implicit-function-declaration] audit_file(f.file); ^ Signed-off-by: Chen Gang --- include/linux/audit.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/include/linux

[PATCH] drivers: net: ethernet: xilinx: xilinx_emaclite: revert the original commit "1db3ddff1602edf2390b7667dcbaa0f71512e3ea"

2014-11-04 Thread Chen Gang
(which based on the device tree). The original issue is related with qemu, so can only change the hardware version string in qemu for it, then keep the original driver no touch ( qemu is for virtualization which has much easier life than real world). Signed-off-by: Chen Gang --- drivers/net

[PATCH] drivers: net: ethernet: xilinx: xilinx_emaclite: revert the original commit 1db3ddff1602edf2390b7667dcbaa0f71512e3ea

2014-11-04 Thread Chen Gang
(which based on the device tree). The original issue is related with qemu, so can only change the hardware version string in qemu for it, then keep the original driver no touch ( qemu is for virtualization which has much easier life than real world). Signed-off-by: Chen Gang gang.chen.5

[PATCH] include/linux/audit.h: Move dummy audit_file() from !AUDIT area to !AUDITSYSCALL area

2014-11-04 Thread Chen Gang
'SYSC_fchmod': fs/open.c:530:3: error: implicit declaration of function 'audit_file' [-Werror=implicit-function-declaration] audit_file(f.file); ^ Signed-off-by: Chen Gang gang.chen.5...@gmail.com --- include/linux/audit.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff

[PATCH v2] arch: tile: kernel: signal.c: Use __copy_from/to_user() instead of __get/put_user()

2014-11-01 Thread Chen Gang
pt_regs)/sizeof(long); ++i) ^ Signed-off-by: Chen Gang --- arch/tile/kernel/signal.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/arch/tile/kernel/signal.c b/arch/tile/kernel/signal.c index 7c2fecc..f867783 100644 --- a/arch/tile/kernel/signal.c +++ b/ar

Re: [PATCH] arch: tile: kernel: signal.c: Use explicitly type case "unsigned long *" for register copy

2014-11-01 Thread Chen Gang
On 11/2/14 4:23, Al Viro wrote: > On Sat, Nov 01, 2014 at 08:49:45PM +0800, Chen Gang wrote: >> setup_sigcontext() wants to copy all kernel related registers to user >> space. So let it copy explicitly instead of copying by exceeding member >> array border. So let code m

[PATCH] arch: tile: kernel: kgdb.c: Use memcpy() instead of pointer copy one by one

2014-11-01 Thread Chen Gang
ote: containing loop for (reg = 0; reg <= TREG_LAST_GPR; reg++) ^ Signed-off-by: Chen Gang --- arch/tile/kernel/kgdb.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/arch/tile/kernel/kgdb.c b/arch/tile/kernel/kgdb.c index 4cd8838..ff5335a 100644 --- a/arch/tile/

[PATCH] arch: tile: kernel: signal.c: Use explicitly type case "unsigned long *" for register copy

2014-11-01 Thread Chen Gang
gnal.c:115:2: note: containing loop for (i = 0; i < sizeof(struct pt_regs)/sizeof(long); ++i) ^ Signed-off-by: Chen Gang --- arch/tile/kernel/signal.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/tile/kernel/signal.c b/arch/tile/kernel/signal.c index 7

[PATCH] drivers: scsi: qla2xxx: Remove redundant declaration in 'qla_gbl.h'

2014-11-01 Thread Chen Gang
i_qla_host *vha); ^ Signed-off-by: Chen Gang --- drivers/scsi/qla2xxx/qla_gbl.h | 2 -- drivers/scsi/qla2xxx/qla_nx2.c | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_gbl.h b/drivers/scsi/qla2xxx/qla_gbl.h index b1865a7..7686

[PATCH] drivers: scsi: qla2xxx: Remove redundant declaration in 'qla_gbl.h'

2014-11-01 Thread Chen Gang
); ^ Signed-off-by: Chen Gang gang.chen.5...@gmail.com --- drivers/scsi/qla2xxx/qla_gbl.h | 2 -- drivers/scsi/qla2xxx/qla_nx2.c | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_gbl.h b/drivers/scsi/qla2xxx/qla_gbl.h index b1865a7

[PATCH] arch: tile: kernel: signal.c: Use explicitly type case unsigned long * for register copy

2014-11-01 Thread Chen Gang
pt_regs)/sizeof(long); ++i) ^ Signed-off-by: Chen Gang gang.chen.5...@gmail.com --- arch/tile/kernel/signal.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/tile/kernel/signal.c b/arch/tile/kernel/signal.c index 7c2fecc..a584ea1 100644 --- a/arch/tile/kernel/signal.c

[PATCH] arch: tile: kernel: kgdb.c: Use memcpy() instead of pointer copy one by one

2014-11-01 Thread Chen Gang
: containing loop for (reg = 0; reg = TREG_LAST_GPR; reg++) ^ Signed-off-by: Chen Gang gang.chen.5...@gmail.com --- arch/tile/kernel/kgdb.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/arch/tile/kernel/kgdb.c b/arch/tile/kernel/kgdb.c index 4cd8838..ff5335a 100644

Re: [PATCH] arch: tile: kernel: signal.c: Use explicitly type case unsigned long * for register copy

2014-11-01 Thread Chen Gang
On 11/2/14 4:23, Al Viro wrote: On Sat, Nov 01, 2014 at 08:49:45PM +0800, Chen Gang wrote: setup_sigcontext() wants to copy all kernel related registers to user space. So let it copy explicitly instead of copying by exceeding member array border. So let code more clearer and avoid warning

[PATCH v2] arch: tile: kernel: signal.c: Use __copy_from/to_user() instead of __get/put_user()

2014-11-01 Thread Chen Gang
; \ ^ arch/tile/kernel/signal.c:116:10: note: in expansion of macro '__put_user' err |= __put_user(regs-regs[i], sc-gregs[i]); ^ arch/tile/kernel/signal.c:115:2: note: containing loop for (i = 0; i sizeof(struct pt_regs)/sizeof(long); ++i) ^ Signed-off-by: Chen

Re: [PATCH] drivers: net: ethernet: xilinx: xilinx_emaclite: Compatible with 'xlnx,xps-ethernetlite-2.00.b' for QEMU using

2014-10-31 Thread Chen Gang
On 11/1/14 11:08, Chen Gang wrote: > When use current latest upstream qemu (current version: 2.1.2), need let > driver compatible with 'xlnx,xps-ethernetlite-2.00.b', or can not find > net device in microblaze qemu. Related QEMU commands under fedora 20: > > yum install libvirt

[PATCH] drivers: net: ethernet: xilinx: xilinx_emaclite: Compatible with 'xlnx,xps-ethernetlite-2.00.b' for QEMU using

2014-10-31 Thread Chen Gang
with glibc for it), then outside can telnet to it without password. Signed-off-by: Chen Gang --- drivers/net/ethernet/xilinx/xilinx_emaclite.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c b/drivers/net/ethernet/xilinx/xilinx_emaclite.c ind

[PATCH] drivers: net: ethernet: xilinx: xilinx_emaclite: Compatible with 'xlnx,xps-ethernetlite-2.00.b' for QEMU using

2014-10-31 Thread Chen Gang
for it), then outside can telnet to it without password. Signed-off-by: Chen Gang gang.chen.5...@gmail.com --- drivers/net/ethernet/xilinx/xilinx_emaclite.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c b/drivers/net/ethernet/xilinx

Re: [PATCH] drivers: net: ethernet: xilinx: xilinx_emaclite: Compatible with 'xlnx,xps-ethernetlite-2.00.b' for QEMU using

2014-10-31 Thread Chen Gang
On 11/1/14 11:08, Chen Gang wrote: When use current latest upstream qemu (current version: 2.1.2), need let driver compatible with 'xlnx,xps-ethernetlite-2.00.b', or can not find net device in microblaze qemu. Related QEMU commands under fedora 20: yum install libvirt yum install tunctl

Re: [PATCH] um: kernel: ksyms: Export symbol syscall() for fixing modpost issue

2014-10-24 Thread Chen Gang
Hello Maintainers: Please help check this patch, when you have time. Thanks. On 10/4/14 21:11, Chen Gang wrote: > syscall() is implemented in libc.so/a (e.g. for glibc, in "syscall.o"), > so for normal ".o" files, it is undefined, neither can be found within > kerne

Re: [PATCH next] xen: pcifront: Process failure for pcifront_(re)scan_root()

2014-10-24 Thread Chen Gang
On 10/16/14 5:03, Konrad Rzeszutek Wilk wrote: > On Wed, Oct 15, 2014 at 08:20:06AM +0800, Chen Gang wrote: >> >> At least for me, what you said sound OK. > > Let me review it - next week. Please help check this patch, when you have time. Thanks. >> >> Thanks

Re: [PATCH next] xen: pcifront: Process failure for pcifront_(re)scan_root()

2014-10-24 Thread Chen Gang
On 10/16/14 5:03, Konrad Rzeszutek Wilk wrote: On Wed, Oct 15, 2014 at 08:20:06AM +0800, Chen Gang wrote: At least for me, what you said sound OK. Let me review it - next week. Please help check this patch, when you have time. Thanks. Thanks. Send from Lenovo A788t. Bjorn Helgaas

Re: [PATCH] um: kernel: ksyms: Export symbol syscall() for fixing modpost issue

2014-10-24 Thread Chen Gang
Hello Maintainers: Please help check this patch, when you have time. Thanks. On 10/4/14 21:11, Chen Gang wrote: syscall() is implemented in libc.so/a (e.g. for glibc, in syscall.o), so for normal .o files, it is undefined, neither can be found within kernel wide, so will break modpost

Re: [PATCH next] xen: pcifront: Process failure for pcifront_(re)scan_root()

2014-10-14 Thread Chen Gang
At least for me, what you said sound OK. Thanks. Send from Lenovo A788t. Bjorn Helgaas wrote: >On Mon, Oct 06, 2014 at 11:04:45AM +0800, Chen Gang wrote: >> When pcifront_rescan_root() or pcifront_scan_root() fails, need return >> error code, neither set XenbusStateConnec

Re: [PATCH next] xen: pcifront: Process failure for pcifront_(re)scan_root()

2014-10-14 Thread Chen Gang
At least for me, what you said sound OK. Thanks. Send from Lenovo A788t. Bjorn Helgaas bhelg...@google.com wrote: On Mon, Oct 06, 2014 at 11:04:45AM +0800, Chen Gang wrote: When pcifront_rescan_root() or pcifront_scan_root() fails, need return error code, neither set XenbusStateConnected

Re: [PATCH] staging: lustre: lustre: ptlrpc: sec.c: Replacing strncat with strlcat to avoid overwrite size

2014-10-13 Thread Chen Gang
; sptlrpc_flavor2name_bulk(sf, [1], sizeof(bspec) - 1); > - strncat(buf, bspec, bufsize); > + strlcat(buf, bspec, bufsize); > } > > - buf[bufsize - 1] = '\0'; > return buf; > } > EXPORT_SYMBOL(sptlrpc_flavor2name

Re: [PATCH] staging: lustre: lustre: ptlrpc: sec.c: Replacing strncat with strlcat to avoid overwrite size

2014-10-13 Thread Chen Gang
); - strncat(buf, bspec, bufsize); + strlcat(buf, bspec, bufsize); } - buf[bufsize - 1] = '\0'; return buf; } EXPORT_SYMBOL(sptlrpc_flavor2name); At least for me, it is OK. Acked-by: Chen Gang gang.chen.5...@gmail.com Thanks. -- Chen Gang Open, share

Re: [PATCH] drivers/pwm/Kconfig: Let PWM_CLPS711X depend on HAS_IOMEM

2014-10-06 Thread Chen Gang
On 10/6/14 18:08, Thierry Reding wrote: > On Sat, Oct 04, 2014 at 05:48:42PM +0800, Chen Gang wrote: >> PWM_CLPS711X needs HAS_IOMEM, so depend on it, the related error (with >> allmodconfig under um): >> >> MODPOST 1205 modules >> ERROR: "devm_ioremap_

Re: [PATCH] drivers/net/phy/Kconfig: Let MDIO_BCM_UNIMAC depend on HAS_IOMEM

2014-10-06 Thread Chen Gang
On 10/6/14 12:46, David Miller wrote: > From: Chen Gang > Date: Sat, 04 Oct 2014 17:54:33 +0800 > >> MDIO_BCM_UNIMAC needs HAS_IOMEM, so depend on it, the related error ( >> with allmodconfig under um): >> >> MODPOST 1205 modules >> ERROR: "devm_

Re: [PATCH] drivers/net/phy/Kconfig: Let MDIO_BCM_UNIMAC depend on HAS_IOMEM

2014-10-06 Thread Chen Gang
On 10/6/14 12:46, David Miller wrote: From: Chen Gang gang.chen.5...@gmail.com Date: Sat, 04 Oct 2014 17:54:33 +0800 MDIO_BCM_UNIMAC needs HAS_IOMEM, so depend on it, the related error ( with allmodconfig under um): MODPOST 1205 modules ERROR: devm_ioremap [drivers/net/phy/mdio-bcm

Re: [PATCH] drivers/pwm/Kconfig: Let PWM_CLPS711X depend on HAS_IOMEM

2014-10-06 Thread Chen Gang
On 10/6/14 18:08, Thierry Reding wrote: On Sat, Oct 04, 2014 at 05:48:42PM +0800, Chen Gang wrote: PWM_CLPS711X needs HAS_IOMEM, so depend on it, the related error (with allmodconfig under um): MODPOST 1205 modules ERROR: devm_ioremap_resource [drivers/pwm/pwm-clps711x.ko] undefined

[PATCH next] xen: pcifront: Process failure for pcifront_(re)scan_root()

2014-10-05 Thread Chen Gang
_scan_root(), it will return 0 ("num_roots = 0;", set 0 by the return value of xenbus_switch_state, which always return 0, at present). Signed-off-by: Chen Gang --- drivers/pci/xen-pcifront.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/pci/xen-pcifront

Re: [PATCH] drivers: base: power: domain: Use 'pm_cpu_data' instead of 'cpu_data' for compiling break

2014-10-05 Thread Chen Gang
On 10/6/14 5:32, Rafael J. Wysocki wrote: > On Saturday, October 04, 2014 10:19:50 PM Chen Gang wrote: >> 'cpu_data' is too common to be already used by some architectures (e.g. >> um, m32r, and mn10300), so need use 'pm_cpu_data' instead of, or cause >> compiling bre

Re: [PATCH] drivers: base: power: domain: Use 'pm_cpu_data' instead of 'cpu_data' for compiling break

2014-10-05 Thread Chen Gang
On 10/6/14 5:32, Rafael J. Wysocki wrote: On Saturday, October 04, 2014 10:19:50 PM Chen Gang wrote: 'cpu_data' is too common to be already used by some architectures (e.g. um, m32r, and mn10300), so need use 'pm_cpu_data' instead of, or cause compiling break. The related error

[PATCH next] xen: pcifront: Process failure for pcifront_(re)scan_root()

2014-10-05 Thread Chen Gang
(), it will return 0 (num_roots = 0;, set 0 by the return value of xenbus_switch_state, which always return 0, at present). Signed-off-by: Chen Gang gang.chen.5...@gmail.com --- drivers/pci/xen-pcifront.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/pci/xen-pcifront.c b

<    1   2   3   4   5   6   7   8   9   10   >