Re: [RFC PATCH 0/3] Separate BE DAI HW constraints from FE ones

2021-04-16 Thread Codrin.Ciubotariu
On 16.04.2021 19:31, Mark Brown wrote: > On Fri, Apr 16, 2021 at 04:03:05PM +, codrin.ciubota...@microchip.com > wrote: > >> Thank you for the links! So basically the machine driver disappears and >> all the components will be visible in user-space. > > Not entirely - you still need

Re: [RFC PATCH 0/3] Separate BE DAI HW constraints from FE ones

2021-04-16 Thread Codrin.Ciubotariu
On 15.04.2021 20:25, Mark Brown wrote: > On Thu, Apr 15, 2021 at 04:56:00PM +, codrin.ciubota...@microchip.com > wrote: > >> Are there any plans for refactoring DPCM? any ideas ongoing? I also have >> some changes for PCM dmaengine, in the same 'style', similar to what I >> sent some time

Re: [RFC PATCH 0/3] Separate BE DAI HW constraints from FE ones

2021-04-15 Thread Codrin.Ciubotariu
On 15.04.2021 19:17, Mark Brown wrote: > On Wed, Apr 14, 2021 at 02:58:10PM +, codrin.ciubota...@microchip.com > wrote: > >> How about using a different API for ASoC only, since that's the place of >> DPCM. Only drivers that do not involve DSPs would have to to be changed >> to call the new

Re: [RFC PATCH 0/3] Separate BE DAI HW constraints from FE ones

2021-04-14 Thread Codrin.Ciubotariu
On 23.03.2021 16:18, codrin.ciubota...@microchip.com wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On 23.03.2021 14:15, Jaroslav Kysela wrote: >> EXTERNAL EMAIL: Do not click links or open attachments unless you know the >> content is

Re: [PATCH 02/17] ASoC: atmel: fix shadowed variable

2021-03-29 Thread Codrin.Ciubotariu
On 26.03.2021 23:59, Pierre-Louis Bossart wrote: > Fix cppcheck warning: > > sound/soc/atmel/atmel-classd.c:51:14: style: Local variable 'pwm_type' > shadows outer variable [shadowVariable] > const char *pwm_type; > ^ > sound/soc/atmel/atmel-classd.c:226:27: note: Shadowed

Re: [PATCH 03/17] ASoC: atmel: atmel-i2s: remove useless initialization

2021-03-29 Thread Codrin.Ciubotariu
On 26.03.2021 23:59, Pierre-Louis Bossart wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > Cppcheck complains: > > sound/soc/atmel/atmel-i2s.c:628:6: style: Redundant initialization for 'err'. > The initialized value is overwritten

Re: [RFC PATCH 0/3] Separate BE DAI HW constraints from FE ones

2021-03-24 Thread Codrin.Ciubotariu
On 24.03.2021 17:28, Pierre-Louis Bossart wrote: >> I am using hw_params_fixup, but it's not enough. The first thing I do is >> to not add the BE HW constraint rules in runtime->hw_constraints, >> because this will potentially affect the FE HW params. If the FE does >> sampling rate conversion,

Re: [RFC PATCH 0/3] Separate BE DAI HW constraints from FE ones

2021-03-24 Thread Codrin.Ciubotariu
On 23.03.2021 21:25, Pierre-Louis Bossart wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know > the content is safe > > On 3/23/21 6:43 AM, Codrin Ciubotariu wrote: >> HW constraints are needed to set limitations for HW parameters used to >> configure the DAIs. All

Re: [RFC PATCH 0/3] Separate BE DAI HW constraints from FE ones

2021-03-23 Thread Codrin.Ciubotariu
On 23.03.2021 14:15, Jaroslav Kysela wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > Dne 23. 03. 21 v 12:43 Codrin Ciubotariu napsal(a): > >> To achieve this, the first thing needed is to detect whether a HW >> constraint rule is

Re: [PATCH 1/7] ASoC: convert Microchip I2SMCC binding to yaml

2021-03-01 Thread Codrin.Ciubotariu
On 01.03.2021 15:59, Mark Brown wrote: > On Tue, Feb 23, 2021 at 08:19:23PM +0200, Codrin Ciubotariu wrote: >> This patch converts the Microchip I2SMCC bindings to DT schema format >> using json-schema. > > Please place any DT binding conversion patches at the end of patch > serieses, there is a

Re: [PATCH] ASoC: atmel: fix spelling mistake in Kconfig "programable" -> "programmable"

2020-12-16 Thread Codrin.Ciubotariu
On 16.12.2020 13:26, Colin King wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > From: Colin Ian King > > There are a couple of spelling mistakes in the Kconfig help text. Fix them. > > Signed-off-by: Colin Ian King Reviewed-by:

Re: [RFC PATCH] ASoC: pcm_dmaengine: Add support for BE DAIs

2020-12-11 Thread Codrin.Ciubotariu
On 08.12.2020 21:31, Mark Brown wrote: > On Tue, Dec 08, 2020 at 07:26:35PM +, codrin.ciubota...@microchip.com > wrote: > >> I do not know too much about the dummy PCM. It seems like it is creating >> a card without DPCM links and fakes a buffer, which is not quite what I >> need. I will

Re: [PATCH v3] i2c: pxa: move to generic GPIO recovery

2020-12-10 Thread Codrin.Ciubotariu
>> patch not tested. > > LGTM. In case we missed a glitch, we can still revert the patch later. > Sure, just CC me if anything goes wrong.

Re: [RFC PATCH] ASoC: pcm_dmaengine: Add support for BE DAIs

2020-12-08 Thread Codrin.Ciubotariu
On 08.12.2020 19:04, Mark Brown wrote: > On Wed, Dec 02, 2020 at 10:58:38AM +0200, Codrin Ciubotariu wrote: > >> This patch is more or less incomplete for the described scenario. This >> is because DMAengine's pcm->config is ignored for the BE DAI link, so >> runtime->hw is not updated. Also,

Re: [PATCH] ASoC: atmel: mchp-spdifrx needs COMMON_CLK

2020-12-04 Thread Codrin.Ciubotariu
On 04.12.2020 00:38, Arnd Bergmann wrote: > From: Arnd Bergmann > > Compile-testing this driver on an older platform without CONFIG_COMMON_CLK > fails with > > ERROR: modpost: "clk_set_min_rate" [sound/soc/atmel/snd-soc-mchp-spdifrx.ko] > undefined! > > Make this is a strict dependency. > >

Re: [PATCH] ARM: dts: at91: add serial MFD sub-node for usart

2020-11-02 Thread Codrin.Ciubotariu
On 02.11.2020 14:55, codrin.ciubota...@microchip.com wrote: > On 02.11.2020 14:29, Lee Jones wrote: >> EXTERNAL EMAIL: Do not click links or open attachments unless you know the >> content is safe >> >> On Mon, 02 Nov 2020, codrin.ciubota...@microchip.com wrote: >> >>> On 02.11.2020 11:01, Lee

Re: [PATCH] ARM: dts: at91: add serial MFD sub-node for usart

2020-11-02 Thread Codrin.Ciubotariu
On 02.11.2020 14:29, Lee Jones wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Mon, 02 Nov 2020, codrin.ciubota...@microchip.com wrote: > >> On 02.11.2020 11:01, Lee Jones wrote: >>> On Fri, 30 Oct 2020, Nicolas Ferre wrote: >>>

Re: [PATCH] ARM: dts: at91: add serial MFD sub-node for usart

2020-11-02 Thread Codrin.Ciubotariu
On 02.11.2020 11:07, Lee Jones wrote: > On Fri, 30 Oct 2020, codrin.ciubota...@microchip.com wrote: > >> On 30.10.2020 15:38, Nicolas Ferre wrote: >>> On 30/10/2020 at 12:07, Codrin Ciubotariu wrote: The "atmel,at91sam9260-usart" driver is a MFD driver, so it needs sub-nodes to

Re: [PATCH] ARM: dts: at91: add serial MFD sub-node for usart

2020-11-02 Thread Codrin.Ciubotariu
On 02.11.2020 11:01, Lee Jones wrote: > On Fri, 30 Oct 2020, Nicolas Ferre wrote: > >> On 30/10/2020 at 12:07, Codrin Ciubotariu wrote: >>> The "atmel,at91sam9260-usart" driver is a MFD driver, so it needs sub-nodes >>> to match the registered platform device. For this reason, we add a serial >>>

Re: [PATCH] ARM: dts: at91: add serial MFD sub-node for usart

2020-10-30 Thread Codrin.Ciubotariu
On 30.10.2020 15:38, Nicolas Ferre wrote: > On 30/10/2020 at 12:07, Codrin Ciubotariu wrote: >> The "atmel,at91sam9260-usart" driver is a MFD driver, so it needs >> sub-nodes >> to match the registered platform device. For this reason, we add a serial >> subnode to all the

Re: [PATCH] i2c: aT91: remove legacy DMA left overs

2020-10-10 Thread Codrin.Ciubotariu
On 30.09.2020 17:56, Alexandre Belloni wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > Commit dc6df6e90de9 ("i2c: at91: remove legacy DMA support") removed legcy > DMA support from the driver. Remove the last use of the definitions from >

Re: [PATCH -next] i2c: at91: Use devm_platform_get_and_ioremap_resource()

2020-10-10 Thread Codrin.Ciubotariu
On 18.09.2020 11:21, Wang ShaoBo wrote: > Make use of devm_platform_get_and_ioremap_resource() provided by > driver core platform instead of duplicated analogue. > > Signed-off-by: Wang ShaoBo Reviewed-by: Codrin Ciubotariu Thanks! > --- > drivers/i2c/busses/i2c-at91-core.c | 11

Re: [PATCH][next] ASoC: mchp-spdifrx: fix spelling mistake "overrrun" -> "overrun"

2020-10-06 Thread Codrin.Ciubotariu
On 06.10.2020 18:20, Colin King wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > From: Colin Ian King > > There is a spelling mistake in a dev_warn message. Fix it. > > Signed-off-by: Colin Ian King Reviewed-by: Codrin Ciubotariu

Re: [PATCH v2] i2c: pxa: move to generic GPIO recovery

2020-10-04 Thread Codrin.Ciubotariu
On 04.10.2020 12:24, Russell King - ARM Linux admin wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Sun, Oct 04, 2020 at 12:16:56PM +0300, Codrin Ciubotariu wrote: >> Starting with >> commit 75820314de26 ("i2c: core: add generic I2C

Re: [PATCH] i2c: pxa: move to generic GPIO recovery

2020-10-03 Thread Codrin.Ciubotariu
>> static void i2c_pxa_unprepare_recovery(struct i2c_adapter *adap) >> @@ -1325,8 +1320,6 @@ static void i2c_pxa_unprepare_recovery(struct >> i2c_adapter *adap) >>i2c_pxa_do_reset(i2c); >>} >> >> - WARN_ON(pinctrl_select_state(i2c->pinctrl, i2c->pinctrl_default)); >>

Re: [PATCH net] net: dsa: microchip: ksz8795: really set the correct number of ports

2020-09-16 Thread Codrin.Ciubotariu
On 16.09.2020 13:08, Matthias Schiffer wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > The KSZ9477 and KSZ8795 use the port_cnt field differently: For the > KSZ9477, it includes the CPU port(s), while for the KSZ8795, it doesn't. > > It

Re: Re: Re: [RFC PATCH 4/4] i2c: at91: Move to generic GPIO bus recovery

2020-09-04 Thread Codrin.Ciubotariu
On 26.08.2020 09:14, Wolfram Sang wrote: > >> Thanks, this would be great! I tested this on a sam9x60, with the HW >> feature for the 9 pulses disabled, with a picky audio codec as I2C device. >> Please let me know of the result. > > I can't make use of the feature on the platform I had in mind,

Re: Re: [PATCH 0/4] i2c: core: add generic GPIO bus recovery

2020-08-05 Thread Codrin.Ciubotariu
On 05.08.2020 11:52, w...@kernel.org wrote: > Codrin, everyone > >> This patch series was previously sent as a RFC. Significant changes >> since RFC: >> - "recovery" pinctrl state marked as deprecared in bindings; >> - move to "gpio" pinctrl state done after the call to prepare_recovery() >>

Re: [PATCH v3 2/2] ASoC: mchp-spdiftx: add driver for S/PDIF TX Controller

2020-08-04 Thread Codrin.Ciubotariu
On 03.08.2020 20:11, Claudiu Beznea - M18063 wrote: > > > On 03.08.2020 19:11, Codrin Ciubotariu - M19940 wrote: >> On 03.08.2020 16:06, Claudiu Beznea - M18063 wrote: >>> >>> >>> On 03.08.2020 11:18, Codrin Ciubotariu wrote: The new SPDIF TX controller is a serial port compliant with the

Re: [RFC PATCH 1/4] dt-binding: i2c: add generic properties for GPIO bus recovery

2020-08-03 Thread Codrin.Ciubotariu
On 03.08.2020 17:16, Russell King - ARM Linux admin wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Thu, Jul 30, 2020 at 09:00:36AM +, codrin.ciubota...@microchip.com > wrote: >> On 27.07.2020 13:50, Russell King - ARM Linux admin

Re: [PATCH v3 2/2] ASoC: mchp-spdiftx: add driver for S/PDIF TX Controller

2020-08-03 Thread Codrin.Ciubotariu
On 03.08.2020 16:06, Claudiu Beznea - M18063 wrote: > > > On 03.08.2020 11:18, Codrin Ciubotariu wrote: >> The new SPDIF TX controller is a serial port compliant with the IEC- >> 60958 standard. It also supports programmable User Data and Channel >> Status fields. >> >> This IP is embedded in

Re: Re: [RFC PATCH 4/4] i2c: at91: Move to generic GPIO bus recovery

2020-08-03 Thread Codrin.Ciubotariu
On 02.08.2020 20:08, Wolfram Sang wrote: > On Fri, Jun 19, 2020 at 05:19:04PM +0300, Codrin Ciubotariu wrote: >> Make the Microchip at91 driver the first to use the generic GPIO bus >> recovery support from the I2C core and discard the driver implementation. >> >> Signed-off-by: Codrin Ciubotariu

Re: Re: [RFC PATCH 3/4] i2c: core: treat EPROBE_DEFER when acquiring SCL/SDA GPIOs

2020-08-03 Thread Codrin.Ciubotariu
On 02.08.2020 20:05, Wolfram Sang wrote: > On Fri, Jun 19, 2020 at 05:19:03PM +0300, Codrin Ciubotariu wrote: >> Even if I2C bus GPIO recovery is optional, devm_gpiod_get() can return >> -EPROBE_DEFER, so we should at least treat that. This ends up with >> i2c_register_adapter() to be able to

Re: Re: [RFC PATCH 2/4] i2c: core: add generic I2C GPIO recovery

2020-08-03 Thread Codrin.Ciubotariu
On 02.08.2020 19:54, Wolfram Sang wrote: > On Fri, Jun 19, 2020 at 05:19:02PM +0300, Codrin Ciubotariu wrote: >> Multiple I2C bus drivers use similar bindings to obtain information needed >> for I2C recovery. For example, for platforms using device-tree, the >> properties look something like this:

Re: [RFC PATCH 1/4] dt-binding: i2c: add generic properties for GPIO bus recovery

2020-07-30 Thread Codrin.Ciubotariu
On 27.07.2020 13:50, Russell King - ARM Linux admin wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Mon, Jul 27, 2020 at 10:44:57AM +, codrin.ciubota...@microchip.com > wrote: >> On 24.07.2020 23:52, Russell King - ARM Linux admin

Re: [RFC PATCH 1/4] dt-binding: i2c: add generic properties for GPIO bus recovery

2020-07-27 Thread Codrin.Ciubotariu
On 24.07.2020 23:52, Russell King - ARM Linux admin wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Fri, Jul 24, 2020 at 09:39:13PM +0200, Wolfram Sang wrote: >> On Sun, Jul 05, 2020 at 11:19:18PM +0200, Wolfram Sang wrote: >>> +-

Re: [PATCH net-next v3 3/7] net: macb: parse PHY nodes found under an MDIO node

2020-07-27 Thread Codrin.Ciubotariu
On 24.07.2020 20:40, Florian Fainelli wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On 7/24/20 3:50 AM, Codrin Ciubotariu wrote: >> The MACB embeds an MDIO bus controller. For this reason, the PHY nodes >> were represented as sub-nodes

Re: [PATCH net-next v2 3/7] net: macb: parse PHY nodes found under an MDIO node

2020-07-23 Thread Codrin.Ciubotariu
On 23.07.2020 21:59, Florian Fainelli wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On 7/21/20 10:13 AM, Codrin Ciubotariu wrote: >> The MACB embeds an MDIO bus controller. For this reason, the PHY nodes >> were represented as sub-nodes

Re: [PATCH net-next v2 0/7] Add an MDIO sub-node under MACB

2020-07-23 Thread Codrin.Ciubotariu
On 23.07.2020 10:51, Claudiu Beznea - M18063 wrote: > > > On 22.07.2020 14:38, Codrin Ciubotariu - M19940 wrote: >> On 22.07.2020 13:32, Claudiu Beznea - M18063 wrote: >>> >>> >>> On 21.07.2020 20:13, Codrin Ciubotariu wrote: Adding the PHY nodes directly under the Ethernet node became

Re: [PATCH net-next v2 0/7] Add an MDIO sub-node under MACB

2020-07-22 Thread Codrin.Ciubotariu
On 22.07.2020 13:32, Claudiu Beznea - M18063 wrote: > > > On 21.07.2020 20:13, Codrin Ciubotariu wrote: >> Adding the PHY nodes directly under the Ethernet node became deprecated, >> so the aim of this patch series is to make MACB use an MDIO node as >> container for MDIO devices. >> This patch

Re: [PATCH net-next 3/7] net: macb: parse PHY nodes found under an MDIO node

2020-07-21 Thread Codrin.Ciubotariu
On 21.07.2020 16:36, Andrew Lunn wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > >> @@ -755,7 +765,6 @@ static int macb_mdiobus_register(struct macb *bp) >> * decrement it before returning. >>

Re: [PATCH net-next 2/7] macb: bindings doc: use an MDIO node as a container for PHY nodes

2020-07-21 Thread Codrin.Ciubotariu
On 21.07.2020 16:29, Alexandre Belloni wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > Hi, > > The proper subject prefix is dt-bindings: net: macb: Will fix in v2. Thanks! > > On 21/07/2020 13:02:29+0300, Codrin Ciubotariu wrote: >>

Re: [PATCH net-next 3/7] net: macb: parse PHY nodes found under an MDIO node

2020-07-21 Thread Codrin.Ciubotariu
On 21.07.2020 16:36, Andrew Lunn wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > >> @@ -755,7 +765,6 @@ static int macb_mdiobus_register(struct macb *bp) >> * decrement it before returning. >>

Re: [PATCH net-next 3/7] net: macb: parse PHY nodes found under an MDIO node

2020-07-21 Thread Codrin.Ciubotariu
On 21.07.2020 16:36, Andrew Lunn wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > >> @@ -755,7 +765,6 @@ static int macb_mdiobus_register(struct macb *bp) >> * decrement it before returning. >>

Re: [PATCH 11/19] clk: at91: clk-generated: pass the id of changeable parent at registration

2020-07-16 Thread Codrin.Ciubotariu
Hi Claudiu, On 15.07.2020 14:24, Claudiu Beznea wrote: > Pass the ID of changeable parent at registration. This will allow > the scalability of this clock driver with regards to the changeable > parent ID for versions of this IP where changeable parent is not the > last one in the parents list

Re: [PATCH net] net: dsa: microchip: set the correct number of ports

2020-07-02 Thread Codrin.Ciubotariu
On 02.07.2020 16:50, Andrew Lunn wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Thu, Jul 02, 2020 at 12:44:50PM +0300, Codrin Ciubotariu wrote: >> The number of ports is incorrectly set to the maximum available for a DSA >> switch.

Re: [PATCH net-next] net: dsa: microchip: split adjust_link() in phylink_mac_link_{up|down}()

2020-07-02 Thread Codrin.Ciubotariu
On 02.07.2020 13:19, Russell King - ARM Linux admin wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Thu, Jul 02, 2020 at 12:54:39PM +0300, Codrin Ciubotariu wrote: >> The DSA subsystem moved to phylink and adjust_link() became

Re: [PATCH 1/2] net: dsa: microchip: set the correct number of ports in dsa_switch

2020-07-01 Thread Codrin.Ciubotariu
On 01.07.2020 20:09, Andrew Lunn wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Wed, Jul 01, 2020 at 07:51:27PM +0300, Codrin Ciubotariu wrote: >> The number of ports is incorrectly set to the maximum available for a DSA >> switch.

Re: [PATCH 3/3] Revert "ARM: at91/dt: sama5d2 Xplained: add pdmic node"

2020-06-18 Thread Codrin.Ciubotariu
On 18.06.2020 00:34, Alexandre Belloni wrote: > Hi, > > The correct subject line prefix is "ARM: dts: at91:" I just reverted the original patch. I can make it a normal commit if you want. > > On 15/06/2020 12:55:25+0300, Codrin Ciubotariu wrote: >> There are no PDM microphones on SAMA5D2

Re: Re: Re: [RFC PATCH] i2c: at91: Fix pinmux after devm_gpiod_get() for bus recovery

2020-06-09 Thread Codrin.Ciubotariu
On 20.05.2020 19:27, Wolfram Sang wrote: > >>> This will do for 5.7. For 5.8 or 5.9, I can imagine to take the two >>> pinctrl_state pointers into bus_recovery_info and handle all this in the >>> core. I will try this later this week if noone is super-eager to try it >>> out before. >>> >> >> By

Re: [PATCH] ARM: dts: at91: Configure I2C SCL gpio as open drain

2020-05-15 Thread Codrin.Ciubotariu
On 15.05.2020 17:58, Alexandre Belloni wrote: > On 15/05/2020 17:00:01+0300, Codrin Ciubotariu wrote: >> The SCL gpio pin used by I2C bus for recovery needs to be configured as >> open drain. >> >> Fixes: 455fec938bbb ("ARM: dts: at91: sama5d2: add i2c gpio pinctrl") >> Fixes: a4bd8da893a3 ("ARM:

Re: Re: [RFC PATCH] i2c: at91: Fix pinmux after devm_gpiod_get() for bus recovery

2020-05-13 Thread Codrin.Ciubotariu
On 05.05.2020 18:12, Wolfram Sang wrote: > On Wed, Apr 15, 2020 at 10:06:43AM +0300, Codrin Ciubotariu wrote: >> devm_gpiod_get() usually calls gpio_request_enable() for non-strict pinmux >> drivers. These puts the pins in GPIO mode, whithout notifying the pinctrl >> driver. At this point, the I2C

Re: [PATCH] i2c: at91: Send bus clear command if SCL or SDA is down

2019-09-19 Thread Codrin.Ciubotariu
On 19.09.2019 18:06, kbouhara wrote: > > On 9/11/19 11:58 AM, Codrin Ciubotariu wrote: >> After a transfer timeout, some faulty I2C slave devices might hold down >> the SCL or the SDA pins. We can generate a bus clear command, hoping that >> the slave might release the pins. >> >> Signed-off-by:

Re: [PATCH v2 6/6] ASoC: atmel_ssc_dai: Enable shared FSYNC source in frame-slave mode

2019-08-26 Thread Codrin.Ciubotariu
On 24.08.2019 23:26, Michał Mirosław wrote: > SSC driver allows only synchronous TX and RX. In slave mode for BCLK > it uses only one of TK or RK pin, but for LRCLK it configured separate > inputs from TF and RF pins. Allow configuration with common FS signal. > > Signed-off-by: Michał Mirosław

Re: [PATCH v2 5/6] misc: atmel-ssc: get LRCLK pin selection from DT

2019-08-26 Thread Codrin.Ciubotariu
On 24.08.2019 23:26, Michał Mirosław wrote: > Store LRCLK pin selection for use by ASoC DAI driver. > > Signed-off-by: Michał Mirosław Reviewed-by: Codrin Ciubotariu Thanks and best regards, Codrin > > --- >v2: split from ASoC implementation > > --- > drivers/misc/atmel-ssc.c | 9

Re: [PATCH v2 3/6] ASoC: atmel_ssc_dai: implement left-justified data mode

2019-08-26 Thread Codrin.Ciubotariu
> Enable support for left-justified data mode for SSC-codec link. > > Signed-off-by: Michał Mirosław > > --- > v2: rebased I noticed you also added a description and you removed two comments from v1. Please include all the changes in the changelog. I already added my 'Reviewed-by' in v1,

Re: [PATCH v2 2/6] ASoC: atmel_ssc_dai: rework DAI format configuration

2019-08-26 Thread Codrin.Ciubotariu
On 24.08.2019 23:26, Michał Mirosław wrote: > Rework DAI format calculation in preparation for adding more formats > later. As a side-effect this enables all CBM/CBS x CFM/CFS combinations > for supported formats. (Note: the additional modes are not tested.) The only mode added (and not tested)

Re: [PATCH v2 1/6] ASoC: atmel: enable SOC_SSC_PDC and SOC_SSC_DMA in Kconfig

2019-08-26 Thread Codrin.Ciubotariu
On 24.08.2019 23:26, Michał Mirosław wrote: > Allow SSC to be used on platforms described using audio-graph-card > in Device Tree. > > Signed-off-by: Michał Mirosław Reviewed-by: Codrin Ciubotariu Thanks! Best regards, Codrin > > --- > v2: extended to PDC mode > reworked and fixed

Re: [alsa-devel] [PATCH 1/2] ASoC: codecs: ad193x: Group register initialization at probe

2019-07-03 Thread Codrin.Ciubotariu
On 03.07.2019 10:39, Tzung-Bi Shih wrote: > On Thu, Jun 27, 2019 at 8:05 PM Codrin Ciubotariu > wrote: >> +struct ad193x_reg_default { >> + unsigned int reg; >> + unsigned int val; >> +}; > You probably don't need to define this. There is a struct > reg_sequence in regmap.h. > >> +

Re: [PATCH 2/2] ASoC: codecs: ad193x: Reset DAC Control 1 register at probe

2019-06-26 Thread Codrin.Ciubotariu
On 26.06.2019 14:23, Mark Brown wrote: > On Wed, Jun 26, 2019 at 01:49:47PM +0300, Codrin Ciubotariu wrote: >> Since the ad193x codecs have no software reset, we have to reinitialize the >> registers after a hardware reset. For example, if we change the >> device-tree between these resets,

[PATCH] clk: at91: generated: Truncate divisor to GENERATED_MAX_DIV + 1

2019-06-10 Thread Codrin.Ciubotariu
From: Codrin Ciubotariu In clk_generated_determine_rate(), if the divisor is greater than GENERATED_MAX_DIV + 1, then the wrong best_rate will be returned. If clk_generated_set_rate() will be called later with this wrong rate, it will return -EINVAL, so the generated clock won't change its

[PATCH 2/2] ASoC: mchp-i2s-mcc: add driver for I2SC Multi-Channel Controller

2019-03-05 Thread Codrin.Ciubotariu
From: Codrin Ciubotariu The Inter-IC Sound Controller (I2SMCC) provides a 5-wire, bidirectional, synchronous, digital audio link to external audio devices: I2SMCC_DIN, I2SMCC_DOUT, I2SMCC_WS, I2SMCC_CK, and I2SMCC_MCK pins. The I2SMCC complies with the Inter-IC Sound (I2S) bus specification and

[PATCH 1/2] ASoC: mchp-i2s-mcc: dt-bindings: add DT bindings for I2S Multi-Channel Controller

2019-03-05 Thread Codrin.Ciubotariu
From: Codrin Ciubotariu This patch adds DT bindings for the new Microchip I2S Multi-Channel controller embedded inside sam9x60 SoCs. Signed-off-by: Codrin Ciubotariu --- .../bindings/sound/mchp-i2s-mcc.txt | 43 +++ 1 file changed, 43 insertions(+) create mode

Re: [PATCH v2 2/2] ASoC: codecs: pcm186x: Fix energysense SLEEP bit

2019-02-20 Thread Codrin.Ciubotariu
On 19.02.2019 19:06, Andrew F. Davis wrote: > On 2/19/19 10:29 AM, codrin.ciubota...@microchip.com wrote: >> From: Codrin Ciubotariu >> >> The ADCs are sleeping when the SLEEP bit is set and running when it's >> cleared, so the bit should be inverted. >> Tested on pcm1863. >> > > Did this work

[PATCH v2 2/2] ASoC: codecs: pcm186x: Fix energysense SLEEP bit

2019-02-19 Thread Codrin.Ciubotariu
From: Codrin Ciubotariu The ADCs are sleeping when the SLEEP bit is set and running when it's cleared, so the bit should be inverted. Tested on pcm1863. Signed-off-by: Codrin Ciubotariu --- Changes in v2: - none; sound/soc/codecs/pcm186x.c | 6 +++--- 1 file changed, 3 insertions(+), 3

[PATCH v2 1/2] ASoC: codecs: pcm186x: fix wrong usage of DECLARE_TLV_DB_SCALE()

2019-02-19 Thread Codrin.Ciubotariu
From: Codrin Ciubotariu According to DS, the gain is between -12 dB and 40 dB, with a 0.5 dB step. Tested on pcm1863. Signed-off-by: Codrin Ciubotariu --- Changes in v2: - fixed title - added correct macro; - revert the removal of a new line; sound/soc/codecs/pcm186x.c | 2 +- 1 file

[PATCH 2/2] ASoC: codecs: pcm186x: Fix energysense SLEEP bit

2019-02-19 Thread Codrin.Ciubotariu
From: Codrin Ciubotariu The ADCs are sleeping when the SLEEP bit is set and running when it's cleared, so the bit should be inverted. Tested on pcm1863. Signed-off-by: Codrin Ciubotariu --- sound/soc/codecs/pcm186x.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 1/2] ASoC: codecs: pcm186x: fix wrong usage of DECLARE_TLV_DB_LINEAR()

2019-02-19 Thread Codrin.Ciubotariu
From: Codrin Ciubotariu According to DS, the gain is between -12 dB and 40 dB, with a 0.5 dB step. Tested on pcm1863. Signed-off-by: Codrin Ciubotariu --- sound/soc/codecs/pcm186x.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sound/soc/codecs/pcm186x.c

Re: [PATCH 1/2] ASoC: codecs: pcm186x: fix wrong usage of DECLARE_TLV_DB_LINEAR()

2019-02-19 Thread Codrin.Ciubotariu
On 19.02.2019 18:15, Codrin Ciubotariu - M19940 wrote: > From: Codrin Ciubotariu > > According to DS, the gain is between -12 dB and 40 dB, with a 0.5 dB step. > Tested on pcm1863. > > Signed-off-by: Codrin Ciubotariu > --- > sound/soc/codecs/pcm186x.c | 3 +-- > 1 file changed, 1

Re: [PATCH 0/5] ASoC: codecs: ad193x: Several fixes and imprevements

2019-02-18 Thread Codrin.Ciubotariu
On 18.02.2019 18:10, Codrin Ciubotariu - M19940 wrote: > From: Codrin Ciubotariu > > This patch set contains some changes I needed to make I2S and TDM > (DSP_A) formats work. I tested only with ad1936, but the patches actually, it's ad1934. Sorry about that. Best regards, Codrin > should work

[PATCH 4/5] ASoC: codecs: ad193x: Add runtime support for DSP_A and I2S modes

2019-02-18 Thread Codrin.Ciubotariu
From: Codrin Ciubotariu The driver only supports DPS_A for DAC, which is configured at probe. This patch adds support for DSP_A and I2S modes by using the set_fmt() callback. A trivial break is also removed from a case's default branch. Signed-off-by: Codrin Ciubotariu ---

[PATCH 0/5] ASoC: codecs: ad193x: Several fixes and imprevements

2019-02-18 Thread Codrin.Ciubotariu
From: Codrin Ciubotariu This patch set contains some changes I needed to make I2S and TDM (DSP_A) formats work. I tested only with ad1936, but the patches should work fine for all the codecs that use this driver. Although I checked the DS for all of them (I hope) to assure that the patches

[PATCH 2/5] ASoC: codecs: ad193x: Set constraint to always have 32 sample bits

2019-02-18 Thread Codrin.Ciubotariu
From: Codrin Ciubotariu DACs and ADCs on ad193x codecs require a 32 bit slot size. We should assure that no other size is used. Signed-off-by: Codrin Ciubotariu --- sound/soc/codecs/ad193x.c | 16 1 file changed, 16 insertions(+) diff --git a/sound/soc/codecs/ad193x.c

[PATCH 1/5] ASoC: codecs: ad193x: Remove capture support for codecs without ADC

2019-02-18 Thread Codrin.Ciubotariu
From: Codrin Ciubotariu Some ad193x codecs don't have ADCs, so they have no capture capabilities. This way, we can use this driver in multicodec cards. Signed-off-by: Codrin Ciubotariu --- sound/soc/codecs/ad193x.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-)

[PATCH 3/5] ASoC: codecs: ad193x: Fix frame polarity for DSP_A format

2019-02-18 Thread Codrin.Ciubotariu
From: Codrin Ciubotariu By default, the codec starts to interpret the left (first) channel on the falling edge (low polarity) of LRCLK. However, for DSP_A, the left channel needs to start on the rising edge of LRCLK. This patch fixes this channel swap by toggling the bit which selects the LRCLK

[PATCH 5/5] ASoC: codecs: ad193x: Add support to disable on-chip PLL

2019-02-18 Thread Codrin.Ciubotariu
From: Codrin Ciubotariu The on-chip PLL can be disabled if on the MCLKI pin we have an external clock at 512 x fs. This clock can be used as direct internal clock for ADCs or DACs. To support this, we add an extra clock id that can be configured using the set_sysclk() callback. Signed-off-by:

Re: [PATCH v2] dmaengine: at_xdmac: Fix wrongfull report of a channel as in use

2019-01-23 Thread Codrin.Ciubotariu
On 23.01.2019 18:33, Codrin Ciubotariu - M19940 wrote: > From: Codrin Ciubotariu > > atchan->status variable is used to store two different information: > - pass channel interrupts status from interrupt handler to tasklet; > - channel information like whether it is cyclic or paused; > >

[PATCH v2] dmaengine: at_xdmac: Fix wrongfull report of a channel as in use

2019-01-23 Thread Codrin.Ciubotariu
From: Codrin Ciubotariu atchan->status variable is used to store two different information: - pass channel interrupts status from interrupt handler to tasklet; - channel information like whether it is cyclic or paused; This causes a bug when device_terminate_all() is called,

Re: [PATCH] dmaengine: at_xdmac: Fix wrongfull report of a channel as in use

2019-01-21 Thread Codrin.Ciubotariu
On 20.01.2019 13:04, Vinod Koul wrote: > Hi Codrin, > > On 17-01-19, 16:10, codrin.ciubota...@microchip.com wrote: >> From: Codrin Ciubotariu >> >> atchan->status is used for two things: >> - pass channel interrupts status from interrupt handler to tasklet; >> - channel information like

[PATCH] dmaengine: at_xdmac: Fix wrongfull report of a channel as in use

2019-01-17 Thread Codrin.Ciubotariu
From: Codrin Ciubotariu atchan->status is used for two things: - pass channel interrupts status from interrupt handler to tasklet; - channel information like whether it is cyclic or paused; Since these operations have nothing in common, this patch adds a different struct member to keep the