Re: linux-next: Signed-off-by missing for commit in the rdma tree

On 4/8/2021 6:00 PM, Stephen Rothwell wrote: Hi all, Commit 042a00f93aad ("IB/{ipoib,hfi1}: Add a timeout handler for rdma_netdev") is missing a Signed-off-by from its author. Doh! That's my fault. I must have fat fingered the delete button instead of editing the line when I was

Re: [PATCH] IB/hfi1: Avoid allocing memory on memoryless numa node

On 10/16/2020 10:11 AM, Jason Gunthorpe wrote: On Mon, Oct 12, 2020 at 08:36:57AM -0400, Dennis Dalessandro wrote: On 10/10/2020 4:57 AM, Xianting Tian wrote: In architecture like powerpc, we can have cpus without any local memory attached to it. In such cases the node does not have real

Re: [PATCH] IB/hfi1: Avoid allocing memory on memoryless numa node

On 10/10/2020 4:57 AM, Xianting Tian wrote: In architecture like powerpc, we can have cpus without any local memory attached to it. In such cases the node does not have real memory. Use local_memory_node(), which is guaranteed to have memory. local_memory_node is a noop in other architectures

Re: [PATCH] IB/rdmavt: Fix sizeof mismatch

s), GFP_KERNEL); if (!rdi->ports) ib_dealloc_device(>ibdev); Acked-by: Dennis Dalessandro

Re: [PATCH v2 3/8] IB/hfi1: Convert PCIBIOS_* errors to generic -E* errors

-by: Bolarinwa Olayemi Saheed Looks like we may have had a problem when calling pci_read_config_dword() from the init dd path and doing a check for < 0 to bail. So this looks like goodness to me. Reviewed-by: Dennis Dalessandro

Re: [PATCH v2 2/8] IB/hfi1: Convert PCIBIOS_* errors to generic -E* errors

if ((linkcap & PCI_EXP_LNKCAP_SLS) != PCI_EXP_LNKCAP_SLS_8_0GB) { Reviewed-by: Dennis Dalessandro

Re: [PATCH] IB/hfi1: Add explicit cast OPA_MTU_8192 to 'enum ib_mtu'

here. Fixes: 6d72344cf6c4 ("IB/ipoib: Increase ipoib Datagram mode MTU's upper limit") Link: https://github.com/ClangBuiltLinux/linux/issues/1062 Link: https://lore.kernel.org/linux-rdma/20200527040350.GA3118979@ubuntu-s3-xlarge-x86/ Signed-off-by: Nathan Chancellor --- Acked-

Re: [PATCH v2] RDMA/rvt: Fix potential memory leak caused by rvt_alloc_rq

Signed-off-by: Aditya Pakki --- v1: Fix incorrect order of rvt_free_rq and free_ud_wq_attr. Suggested by Dennis Dalessandro. --- drivers/infiniband/sw/rdmavt/qp.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/infiniband/sw/rdmavt/qp.c b/drivers/infiniband/sw/r

Re: [PATCH] RDMA/rvt: Fix potential memory leak caused by rvt_alloc_rq

On 6/12/2020 3:54 PM, Aditya Pakki wrote: In case of failure of alloc_ud_wq_attr, the memory allocated by rvt_alloc_rq() is not freed. The patch fixes this issue by calling rvt_free_rq(). Signed-off-by: Aditya Pakki --- drivers/infiniband/sw/rdmavt/qp.c | 1 + 1 file changed, 1 insertion(+)

Re: [PATCH 11/17] drivers: infiniband: Fix trivial spelling

q = txp->txq; Thanks Acked-by: Dennis Dalessandro

Re: [PATCH 02/17] drivers: infiniband: Fix trivial spelling

e sdma descriptors are there */ tx->txreq.num_desc = 0; /* Set the header type */ tx->phdr.hdr.hdr_type = priv->hdr_type; Thanks Acked-by: Dennis Dalessandro

Re: [PATCH -next] IB/hfi1: Use free_netdev() in hfi1_netdev_free()

; - kfree(dd->dummy_netdev); + free_netdev(dd->dummy_netdev); dd->dummy_netdev = NULL; } } For the kfree->free_netdev, you probably want to add: Reported-by: kbuild test robot Reported-by: Dan Carpenter Also can add: Reviewed-by: Dennis Dalessandro Thanks

Re: [PATCH][next] IB/hfi1: fix spelling mistake "enought" -> "enough"

, NUM_NETDEV_MAP_ENTRIES)) { - dd_dev_err(dd, "Not enought RMT entries used = %d\n", + dd_dev_err(dd, "Not enough RMT entries used = %d\n", rmt_start); return false; } Thanks! Acked-by: Dennis Dalessandro

Re: [PATCH] IB/hfi1: prevent memory leak in sdma_init

(tmp_sdma_rht, _rht_params); - if (ret < 0) + if (ret < 0) { + kfree(tmp_sdma_rht); goto bail; + } + dd->sdma_rht = tmp_sdma_rht; dd_dev_info(dd, "SDMA num_sdma: %u\n", dd->num_sdma); Yeah looks like a problem to me, tha

Re: [PATCH] infiniband: hfi1: fix memory leaks

the error. Signed-off-by: Wenwen Wang Acked-by: Dennis Dalessandro

Re: [PATCH] infiniband: hfi1: fix a memory leak bug

On 8/18/2019 3:29 PM, Wenwen Wang wrote: In fault_opcodes_read(), 'data' is not deallocated if debugfs_file_get() fails, leading to a memory leak. To fix this bug, introduce the 'free_data' label to free 'data' before returning the error. Signed-off-by: Wenwen Wang Acked-by: Dennis

Re: linux-next: build failure after merge of the rdma tree

On 7/8/2019 12:08 PM, Jason Gunthorpe wrote: On Mon, Jul 08, 2019 at 12:57:25PM +1000, Stephen Rothwell wrote: Hi all, After merging the rdma tree, today's linux-next build (x86_64 allmodconfig) failed like this: In file included from :32: ./usr/include/rdma/rvt-abi.h:13:10: fatal error:

Re: [PATCH][next] IB/hfi1: Use struct_size() helper

(struct _vls_ectrs); + response_data_size = struct_size(req, port[0].vls, num_vls); if (response_data_size > sizeof(pmp->data)) { pmp->mad_hdr.status |= IB_SMP_INVALID_FIELD; Reviewed-by: Dennis Dalessandro

Re: [PATCH][next] IB/qib: Use struct_size() helper

eof(*pkt) + sizeof(pkt->addr[0])*n; + pktsize = struct_size(pkt, addr, n); /* * Determine if this is tid-sdma or just sdma. Again, same minor objection but correct patch none the less. Reviewed-by: Dennis Dalessandro

Re: [PATCH][next] IB/rdmavt: Use struct_size() helper

The macro name "struct_size" is misleading to me. Maybe that's just me, and in any case... Reviewed-by: Dennis Dalessandro

Re: [PATCH 5/5] IB/hfi1: Fix improper uses of smp_mb__before_atomic()

On 5/9/2019 5:12 PM, Andrea Parri wrote: On Tue, Apr 30, 2019 at 01:16:57AM +0200, Andrea Parri wrote: Hi Mike, This barrier only applies to the read-modify-write operations; in particular, it does not apply to the atomic_read() primitive. Replace the barrier with an smp_mb(). This is one

Re: [RFC PATCH 31/68] vfs: Convert qib_fs/ipathfs to use the new mount API

don't think. Signed-off-by: David Howells cc: Dennis Dalessandro cc: Mike Marciniszyn cc: linux-r...@vger.kernel.org Reviewed-by: Dennis Dalessandro

Re: [PATCH][next] opa_vnic: fix check on record->event, incorrect operator used

t;element.port_num); - if (record->event != IB_EVENT_PORT_ERR || + if (record->event != IB_EVENT_PORT_ERR && record->event != IB_EVENT_PORT_ACTIVE) return; Missed this in code review. Thanks! Acked-by: Dennis Dalessandro

Re: [PATCH] IB/qib: fix spelling mistake "colescing" -> "coalescing"

completion and data coalescing, on Intel 5x00 and 7300 Thanks! Reviewed-by: Dennis Dalessandro

Re: [PATCH] IB/qib: fix spelling mistake "colescing" -> "coalescing"

completion and data coalescing, on Intel 5x00 and 7300 Thanks! Reviewed-by: Dennis Dalessandro

Re: [PATCH v3 0/3] get_user_pages*() and RDMA: first steps

to Jerome's feedback. Also: -- Dennis, thanks for your earlier review, and I have not yet added your Reviewed-by tag, because this revision changes the things that you had previously reviewed, thus potentially requiring another look. This spin looks fine to me. Reviewed-by: Dennis

Re: [PATCH v3 0/3] get_user_pages*() and RDMA: first steps

to Jerome's feedback. Also: -- Dennis, thanks for your earlier review, and I have not yet added your Reviewed-by tag, because this revision changes the things that you had previously reviewed, thus potentially requiring another look. This spin looks fine to me. Reviewed-by: Dennis

Re: [PATCH 3/4] infiniband/mm: convert to the new put_user_page() call

er will be stuck with that. Here's a differential patch with that, that shows a nice little cleanup in a couple of IB places, and as you point out, it also provides the hooks for performance upgrades (via batching) in the future. Does this API look about right? I'm on board with that and the changes to

Re: [PATCH 3/4] infiniband/mm: convert to the new put_user_page() call

er will be stuck with that. Here's a differential patch with that, that shows a nice little cleanup in a couple of IB places, and as you point out, it also provides the hooks for performance upgrades (via batching) in the future. Does this API look about right? I'm on board with that and the changes to

Re: [PATCH 1/2] IB/hfi1: Try slot reset before secondary bus reset

gle.com>; linux-...@vger.kernel.org; sulr...@codeaurora.org; ti...@codeaurora.org; linux-arm- m...@vger.kernel.org; linux-arm-ker...@lists.infradead.org; Mike Marciniszyn <mike.marcinis...@intel.com>; Dennis Dalessandro <dennis.dalessan...@intel.com>; Doug Ledford <dledf...@redhat.com

Re: [PATCH 1/2] IB/hfi1: Try slot reset before secondary bus reset

-arm- m...@vger.kernel.org; linux-arm-ker...@lists.infradead.org; Mike Marciniszyn ; Dennis Dalessandro ; Doug Ledford ; open list:HFI1 DRIVER ; open list ; Deucher, Alexander Subject: Re: [PATCH 1/2] IB/hfi1: Try slot reset before secondary bus reset [+cc Alex, who might know why DRM drivers have

Re: [PATCH v3 0/2] IB/hfi1: Cleanup PCIe link configuration

On 4/17/2018 10:32 AM, Bjorn Helgaas wrote: [+cc Bartlomiej, who recently changed do_pcie_gen3_transition(), LKML] On Mon, Apr 16, 2018 at 11:53:43PM -0700, Christoph Hellwig wrote: On Mon, Apr 16, 2018 at 07:28:23PM -0500, Frederick Lawler wrote: The IB/hfi1 driver uses custom macros to

Re: [PATCH v3 0/2] IB/hfi1: Cleanup PCIe link configuration

On 4/17/2018 10:32 AM, Bjorn Helgaas wrote: [+cc Bartlomiej, who recently changed do_pcie_gen3_transition(), LKML] On Mon, Apr 16, 2018 at 11:53:43PM -0700, Christoph Hellwig wrote: On Mon, Apr 16, 2018 at 07:28:23PM -0500, Frederick Lawler wrote: The IB/hfi1 driver uses custom macros to

Re: [PATCH v2] IB: make INFINIBAND_ADDR_TRANS configurable

On 4/13/2018 1:27 PM, Greg Thelen wrote: Allow INFINIBAND without INFINIBAND_ADDR_TRANS. Signed-off-by: Greg Thelen Cc: Tarick Bedeir Change-Id: I6fbbf8a432e467710fa65e4904b7d61880b914e5 Forgot to remove the Gerrit thing. -Denny

Re: [PATCH v2] IB: make INFINIBAND_ADDR_TRANS configurable

On 4/13/2018 1:27 PM, Greg Thelen wrote: Allow INFINIBAND without INFINIBAND_ADDR_TRANS. Signed-off-by: Greg Thelen Cc: Tarick Bedeir Change-Id: I6fbbf8a432e467710fa65e4904b7d61880b914e5 Forgot to remove the Gerrit thing. -Denny

Re: [PATCH 1/3] infiniband: i40iw: Replace GFP_ATOMIC with GFP_KERNEL in i40iw_add_mqh_4

On 4/11/2018 3:32 AM, Jia-Ju Bai wrote: i40iw_add_mqh_4() is never called in atomic context, because it calls rtnl_lock() that can sleep. Despite never getting called from atomic context, i40iw_add_mqh_4() calls kzalloc() with GFP_ATOMIC, which does not sleep for allocation. GFP_ATOMIC is not

Re: [PATCH 1/3] infiniband: i40iw: Replace GFP_ATOMIC with GFP_KERNEL in i40iw_add_mqh_4

On 4/11/2018 3:32 AM, Jia-Ju Bai wrote: i40iw_add_mqh_4() is never called in atomic context, because it calls rtnl_lock() that can sleep. Despite never getting called from atomic context, i40iw_add_mqh_4() calls kzalloc() with GFP_ATOMIC, which does not sleep for allocation. GFP_ATOMIC is not

Re: [PATCH 3/7] RDMAVT: Fix synchronization around percpu_ref

end on internal behaviors like this. To address the above issues, this patch removes the the fast exit and Typo above too many "the". adds an explicit synchronize_rcu(). Signed-off-by: Tejun Heo <t...@kernel.org> Cc: Dennis Dalessandro <dennis.dalessan...@intel.com> Cc: Mike M

Re: [PATCH 3/7] RDMAVT: Fix synchronization around percpu_ref

end on internal behaviors like this. To address the above issues, this patch removes the the fast exit and Typo above too many "the". adds an explicit synchronize_rcu(). Signed-off-by: Tejun Heo Cc: Dennis Dalessandro Cc: Mike Marciniszyn Cc: linux-r...@vger.kernel.org Cc: Linus Torval

Re: [Outreachy kernel] [PATCH] infiniband: hw: Drop unnecessary continue

On 3/3/2018 9:07 AM, Julia Lawall wrote: diff --git a/drivers/infiniband/hw/qib/qib_init.c b/drivers/infiniband/hw/qib/qib_init.c index 3990f38..1bd3b32 100644 --- a/drivers/infiniband/hw/qib/qib_init.c +++ b/drivers/infiniband/hw/qib/qib_init.c @@ -681,7 +681,6 @@ int qib_init(struct

Re: [Outreachy kernel] [PATCH] infiniband: hw: Drop unnecessary continue

On 3/3/2018 9:07 AM, Julia Lawall wrote: diff --git a/drivers/infiniband/hw/qib/qib_init.c b/drivers/infiniband/hw/qib/qib_init.c index 3990f38..1bd3b32 100644 --- a/drivers/infiniband/hw/qib/qib_init.c +++ b/drivers/infiniband/hw/qib/qib_init.c @@ -681,7 +681,6 @@ int qib_init(struct

Re: [PATCH] infiniband: hw: Drop unnecessary continue

On 3/3/2018 8:03 AM, Arushi Singhal wrote: Continue at the bottom of a loop are removed. Issue found using drop_continue.cocci Coccinelle script. Signed-off-by: Arushi Singhal --- drivers/infiniband/hw/qib/qib_init.c | 1 - 1 file changed, 1 deletion(-)

Re: [PATCH] infiniband: hw: Drop unnecessary continue

On 3/3/2018 8:03 AM, Arushi Singhal wrote: Continue at the bottom of a loop are removed. Issue found using drop_continue.cocci Coccinelle script. Signed-off-by: Arushi Singhal --- drivers/infiniband/hw/qib/qib_init.c | 1 - 1 file changed, 1 deletion(-) diff --git

Re: [PATCH 2/2] IB/qib: Move char *qib_sdma_state_names[] and constify while there.

oks OK to me, thanks. Reviewed-by: Dennis Dalessandro <dennis.dalessan...@intel.com>

Re: [PATCH 2/2] IB/qib: Move char *qib_sdma_state_names[] and constify while there.

-by: Dennis Dalessandro

Re: [PATCH 0/3] RDMA/hns: Bug fixes in hns RoCE driver

On 11/28/2017 2:33 PM, Jason Gunthorpe wrote: On Tue, Nov 28, 2017 at 06:50:44PM +, Bart Van Assche wrote: On Tue, 2017-11-28 at 11:39 -0700, Jason Gunthorpe wrote: On Tue, Nov 28, 2017 at 08:20:09AM -0500, Dennis Dalessandro wrote: I could resubmit just the series, or you could just pick

Re: [PATCH 0/3] RDMA/hns: Bug fixes in hns RoCE driver

On 11/28/2017 2:33 PM, Jason Gunthorpe wrote: On Tue, Nov 28, 2017 at 06:50:44PM +, Bart Van Assche wrote: On Tue, 2017-11-28 at 11:39 -0700, Jason Gunthorpe wrote: On Tue, Nov 28, 2017 at 08:20:09AM -0500, Dennis Dalessandro wrote: I could resubmit just the series, or you could just pick

Re: [PATCH 0/3] RDMA/hns: Bug fixes in hns RoCE driver

On 11/28/2017 1:15 AM, Leon Romanovsky wrote: On Mon, Nov 27, 2017 at 11:36:37AM -0700, Jason Gunthorpe wrote: On Mon, Nov 27, 2017 at 10:41:21AM +0800, Wei Hu (Xavier) wrote: This patch-set introduces three patches to fix about the memory related issues. If these patches are for-rc can you

Re: [PATCH 0/3] RDMA/hns: Bug fixes in hns RoCE driver

On 11/28/2017 1:15 AM, Leon Romanovsky wrote: On Mon, Nov 27, 2017 at 11:36:37AM -0700, Jason Gunthorpe wrote: On Mon, Nov 27, 2017 at 10:41:21AM +0800, Wei Hu (Xavier) wrote: This patch-set introduces three patches to fix about the memory related issues. If these patches are for-rc can you

Re: [PATCH v3 5/8] IB/hfi1: convert to debugfs_file_get() and -put()

data") Signed-off-by: Nicolai Stange <nicsta...@gmail.com> Looks OK to me. Reviewed-by: Dennis Dalessandro <dennis.dalessan...@intel.com>

Re: [PATCH v3 5/8] IB/hfi1: convert to debugfs_file_get() and -put()

data") Signed-off-by: Nicolai Stange Looks OK to me. Reviewed-by: Dennis Dalessandro

Re: IB/mlx4: Use common error handling code in __mlx4_ib_create_flow()

On 10/27/2017 4:53 PM, SF Markus Elfring wrote: This change adds nothing except code churn. I guess that the shown change possibility can reduce the object code size for the affected function. Do you care for such an detail? Regards, Markus You guess? Well perhaps you should find out for

Re: IB/mlx4: Use common error handling code in __mlx4_ib_create_flow()

On 10/27/2017 4:53 PM, SF Markus Elfring wrote: This change adds nothing except code churn. I guess that the shown change possibility can reduce the object code size for the affected function. Do you care for such an detail? Regards, Markus You guess? Well perhaps you should find out for

Re: [PATCH] IB/mlx4: Use common error handling code in __mlx4_ib_create_flow()

On 10/26/2017 12:12 PM, SF Markus Elfring wrote: From: Markus Elfring Date: Thu, 26 Oct 2017 17:54:15 +0200 Add a jump target so that a bit of exception handling can be better reused at the end of this function. I'm not sure this is that big of a win. I mean

Re: [PATCH] IB/mlx4: Use common error handling code in __mlx4_ib_create_flow()

On 10/26/2017 12:12 PM, SF Markus Elfring wrote: From: Markus Elfring Date: Thu, 26 Oct 2017 17:54:15 +0200 Add a jump target so that a bit of exception handling can be better reused at the end of this function. I'm not sure this is that big of a win. I mean you aren't really making the

Re: [PATCH] IB/hfil: Delete unused bypass flags

On 10/11/2017 5:35 PM, Don Hiatt wrote: On 10/11/2017 1:56 PM, Christos Gkekas wrote: Clean up unused bypass variables in verbs. Signed-off-by: Christos Gkekas ---   drivers/infiniband/hw/hfi1/verbs.c | 4   1 file changed, 4 deletions(-) diff --git

Re: [PATCH] IB/hfil: Delete unused bypass flags

On 10/11/2017 5:35 PM, Don Hiatt wrote: On 10/11/2017 1:56 PM, Christos Gkekas wrote: Clean up unused bypass variables in verbs. Signed-off-by: Christos Gkekas ---   drivers/infiniband/hw/hfi1/verbs.c | 4   1 file changed, 4 deletions(-) diff --git a/drivers/infiniband/hw/hfi1/verbs.c

Re: [PATCH for-next] IB,hfi1 Add MODULE_FIRMWARE statements

On 10/11/2017 11:49 AM, Leon Romanovsky wrote: On Wed, Oct 11, 2017 at 11:31:18AM -0400, Dennis Dalessandro wrote: On 10/11/2017 8:41 AM, Thomas Bogendoerfer wrote: Provide information about used firmware files via modinfo. Signed-off-by: Thomas Bogendoerfer <tbogendoer...@suse

Re: [PATCH for-next] IB,hfi1 Add MODULE_FIRMWARE statements

On 10/11/2017 11:49 AM, Leon Romanovsky wrote: On Wed, Oct 11, 2017 at 11:31:18AM -0400, Dennis Dalessandro wrote: On 10/11/2017 8:41 AM, Thomas Bogendoerfer wrote: Provide information about used firmware files via modinfo. Signed-off-by: Thomas Bogendoerfer --- drivers/infiniband/hw/hfi1

Re: [PATCH for-next] IB,hfi1 Add MODULE_FIRMWARE statements

On 10/11/2017 11:31 AM, Dennis Dalessandro wrote: On 10/11/2017 8:41 AM, Thomas Bogendoerfer wrote: Provide information about used firmware files via modinfo. Signed-off-by: Thomas Bogendoerfer <tbogendoer...@suse.de> ---   drivers/infiniband/hw/hfi1/firmware.c | 5 +   1 file chan

Re: [PATCH for-next] IB,hfi1 Add MODULE_FIRMWARE statements

On 10/11/2017 11:31 AM, Dennis Dalessandro wrote: On 10/11/2017 8:41 AM, Thomas Bogendoerfer wrote: Provide information about used firmware files via modinfo. Signed-off-by: Thomas Bogendoerfer ---   drivers/infiniband/hw/hfi1/firmware.c | 5 +   1 file changed, 5 insertions(+) diff --git

Re: [PATCH for-next] IB,hfi1 Add MODULE_FIRMWARE statements

nd this terribly useful, but if it's useful for you I'm sure it is for others as well, so I have no problem with it. Reviewed-by: Dennis Dalessandro <dennis.dalessan...@intel.com>

Re: [PATCH for-next] IB,hfi1 Add MODULE_FIRMWARE statements

t's useful for you I'm sure it is for others as well, so I have no problem with it. Reviewed-by: Dennis Dalessandro

Re: [PATCH 2/2] IB/hfi1: Handle packets in the theaded handler only

On 10/3/2017 11:49 AM, Arnaldo Carvalho de Melo wrote: Cc: Clark Williams <willi...@redhat.com> Cc: Dean Luick <dean.lu...@intel.com> Cc: Dennis Dalessandro <dennis.dalessan...@intel.com> Cc: Doug Ledford <dledf...@redhat.com> Cc: Julia Cartwright <ju...@n

Re: [PATCH 2/2] IB/hfi1: Handle packets in the theaded handler only

On 10/3/2017 11:49 AM, Arnaldo Carvalho de Melo wrote: Cc: Clark Williams Cc: Dean Luick Cc: Dennis Dalessandro Cc: Doug Ledford Cc: Julia Cartwright Cc: Kaike Wan Cc: Leon Romanovsky Cc: linux-r...@vger.kernel.org Cc: Peter Zijlstra Cc: Sebastian Andrzej Siewior Cc: Sebastian Sanchez

Re: [PATCH 1/2] IB/hfi1: Use preempt_{dis,en}able_nort()

is locking is done for performance reasons, not for correctness, so use the _nort() variants to avoid the above problem. Suggested-by: Julia Cartwright <ju...@ni.com> Cc: Clark Williams <willi...@redhat.com> Cc: Dean Luick <dean.lu...@intel.com> Cc: Dennis Dalessandro <dennis.dale

Re: [PATCH 1/2] IB/hfi1: Use preempt_{dis,en}able_nort()

formance reasons, not for correctness, so use the _nort() variants to avoid the above problem. Suggested-by: Julia Cartwright Cc: Clark Williams Cc: Dean Luick Cc: Dennis Dalessandro Cc: Doug Ledford Cc: Kaike Wan Cc: Leon Romanovsky Cc: linux-r...@vger.kernel.org Cc: Peter Zijlstra Cc: Sebas

Re: [PATCH] IB/hfi1: fix spelling mistake: "Maximim" -> "Maximum"

ratelimited("hfi1: Maximum trap limit reached for 0x%0x traps\n", trap->data.generic_type); kfree(trap); } Thanks! Acked-by: Dennis Dalessandro <dennis.dalessan...@intel.com>

Re: [PATCH] IB/hfi1: fix spelling mistake: "Maximim" -> "Maximum"

ached for 0x%0x traps\n", trap->data.generic_type); kfree(trap); } Thanks! Acked-by: Dennis Dalessandro

Re: [PATCH] IB/hfi1: fix spelling mistake in variable name continious

On 7/13/2017 6:13 PM, Colin King wrote: From: Colin Ian King <colin.k...@canonical.com> Trivial fix to spelling mistake, rename variable 'continious' to the correct spelling 'continuous' Signed-off-by: Colin Ian King <colin.k...@canonical.com> --- Thanks! Acked-by: Dennis

Re: [PATCH] IB/hfi1: fix spelling mistake in variable name continious

On 7/13/2017 6:13 PM, Colin King wrote: From: Colin Ian King Trivial fix to spelling mistake, rename variable 'continious' to the correct spelling 'continuous' Signed-off-by: Colin Ian King --- Thanks! Acked-by: Dennis Dalessandro

Re: [PATCH] IB/qib: remove duplicate code

ine to me code wise. Reviewed-by: Dennis Dalessandro <dennis.dalessan...@intel.com>

Re: [PATCH] IB/qib: remove duplicate code

wed-by: Dennis Dalessandro

Re: [PATCH 5/7] IB/hfi1: use pcie_flr instead of duplicating it

On 04/24/2017 10:35 AM, Christoph Hellwig wrote: On Mon, Apr 24, 2017 at 02:16:31PM +, Byczkowski, Jakub wrote: Tested-by: Jakub Byczkowski Are you (and Doug) ok with queueing this up in the PCI tree? We are fine however Doug wants to handle it. -Denny

Re: [PATCH 5/7] IB/hfi1: use pcie_flr instead of duplicating it

On 04/24/2017 10:35 AM, Christoph Hellwig wrote: On Mon, Apr 24, 2017 at 02:16:31PM +, Byczkowski, Jakub wrote: Tested-by: Jakub Byczkowski Are you (and Doug) ok with queueing this up in the PCI tree? We are fine however Doug wants to handle it. -Denny

Re: [PATCH v2 03/12] IB/ocrdma: Improve size determinations in ten functions

On 04/23/2017 03:33 AM, Leon Romanovsky wrote: On Sat, Apr 22, 2017 at 04:36:19PM +0200, SF Markus Elfring wrote: From: Markus Elfring Date: Sat, 22 Apr 2017 13:26:49 +0200 Replace the specification of data types by pointer dereferences as the parameter for the

Re: [PATCH v2 03/12] IB/ocrdma: Improve size determinations in ten functions

On 04/23/2017 03:33 AM, Leon Romanovsky wrote: On Sat, Apr 22, 2017 at 04:36:19PM +0200, SF Markus Elfring wrote: From: Markus Elfring Date: Sat, 22 Apr 2017 13:26:49 +0200 Replace the specification of data types by pointer dereferences as the parameter for the operator "sizeof" to make the

Re: [PATCH 0/5] IB/qib: Fine-tuning for four function implementations

On 04/05/2017 09:50 AM, SF Markus Elfring wrote: From: Markus Elfring Date: Wed, 5 Apr 2017 15:34:32 +0200 A few update suggestions were taken into account from static source code analysis. Markus Elfring (5): Use kcalloc() in qib_init_iba7322_funcs() Use

Re: [PATCH 0/5] IB/qib: Fine-tuning for four function implementations

On 04/05/2017 09:50 AM, SF Markus Elfring wrote: From: Markus Elfring Date: Wed, 5 Apr 2017 15:34:32 +0200 A few update suggestions were taken into account from static source code analysis. Markus Elfring (5): Use kcalloc() in qib_init_iba7322_funcs() Use kmalloc_array() in

Re: [PATCH 4/5] IB/hfi1: Use memdup_user() rather than duplicating its implementation in hfi1_user_sdma_process_request()

On 02/10/2017 04:04 PM, SF Markus Elfring wrote: From: Markus Elfring Date: Fri, 10 Feb 2017 21:01:55 +0100 Reuse existing functionality from memdup_user() instead of keeping duplicate source code. Signed-off-by: Markus Elfring

Re: [PATCH 4/5] IB/hfi1: Use memdup_user() rather than duplicating its implementation in hfi1_user_sdma_process_request()

On 02/10/2017 04:04 PM, SF Markus Elfring wrote: From: Markus Elfring Date: Fri, 10 Feb 2017 21:01:55 +0100 Reuse existing functionality from memdup_user() instead of keeping duplicate source code. Signed-off-by: Markus Elfring Thanks for the patch, but this one is already taken care of

Re: [PATCH] IB/qib: use rb_entry()

On 12/20/2016 09:02 AM, Geliang Tang wrote: To make the code clearer, use rb_entry() instead of container_of() to deal with rbtree. Signed-off-by: Geliang Tang <geliangt...@gmail.com> Reviewed-by: Dennis Dalessandro <dennis.dalessan...@intel.com> Thanks -Denny

Re: [PATCH] IB/qib: use rb_entry()

On 12/20/2016 09:02 AM, Geliang Tang wrote: To make the code clearer, use rb_entry() instead of container_of() to deal with rbtree. Signed-off-by: Geliang Tang Reviewed-by: Dennis Dalessandro Thanks -Denny

Re: hfi1 use of PCI internals

On Thu, Jun 16, 2016 at 03:08:17PM -0500, Bjorn Helgaas wrote: As far as I can tell, none of these PCI questions were raised on linux-pci, so we never even had a chance to have a conversation about them. I'll let Ashutosh handle the technical details here since he is most familiar with the

Re: hfi1 use of PCI internals

On Thu, Jun 16, 2016 at 03:08:17PM -0500, Bjorn Helgaas wrote: As far as I can tell, none of these PCI questions were raised on linux-pci, so we never even had a chance to have a conversation about them. I'll let Ashutosh handle the technical details here since he is most familiar with the

Re: [patch] IB/hfi1: fix some indenting

dd->rcvhdrtail_dummy_physaddr); - dd->rcvhdrtail_dummy_kvaddr = NULL; + dd->rcvhdrtail_dummy_kvaddr = NULL; } for (ctxt = 0; tmp && ctxt < dd->num_rcv_contexts; ctxt++) { Acked-by: Dennis Dalessandro <dennis.dalessan...@intel.com>

Re: [patch] IB/hfi1: fix some indenting

mmy_physaddr); - dd->rcvhdrtail_dummy_kvaddr = NULL; + dd->rcvhdrtail_dummy_kvaddr = NULL; } for (ctxt = 0; tmp && ctxt < dd->num_rcv_contexts; ctxt++) { Acked-by: Dennis Dalessandro

Re: [PATCH 1/1] Staging: rdma: hfi1: sdma.c: Fixed coding style issues

On Mon, May 23, 2016 at 12:06:02PM +0530, Shyam Saini wrote: Fixed following checkpatch.pl warnings: Prefer 'unsigned int' to bare use of 'unsigned' Prefer READ_ONCE() over ACCESS_ONCE() Same response [1] as to your previous patch. If you do spin the READ_ONCE bit please squash the two.

Re: [PATCH 1/1] Staging: rdma: hfi1: sdma.c: Fixed coding style issues

On Mon, May 23, 2016 at 12:06:02PM +0530, Shyam Saini wrote: Fixed following checkpatch.pl warnings: Prefer 'unsigned int' to bare use of 'unsigned' Prefer READ_ONCE() over ACCESS_ONCE() Same response [1] as to your previous patch. If you do spin the READ_ONCE bit please squash the two.

Re: [PATCH 1/1] Staging: rdma: hfi1: rc.c: Fixed coding style issues

On Mon, May 23, 2016 at 12:06:01PM +0530, Shyam Saini wrote: Fixed following checkpatch.pl warnings: Prefer 'unsigned int' to bare use of 'unsigned' Prefer READ_ONCE() over ACCESS_ONCE() In general please don't fix two types of issues in the same patch. Also, as to the unsinged -> unsigned

Re: [PATCH 1/1] Staging: rdma: hfi1: rc.c: Fixed coding style issues

On Mon, May 23, 2016 at 12:06:01PM +0530, Shyam Saini wrote: Fixed following checkpatch.pl warnings: Prefer 'unsigned int' to bare use of 'unsigned' Prefer READ_ONCE() over ACCESS_ONCE() In general please don't fix two types of issues in the same patch. Also, as to the unsinged -> unsigned

Re: [PATCH v2 3/5] IB/hfi1: Add ioctl() interface for user commands

On Thu, May 12, 2016 at 03:28:21PM -0600, Jason Gunthorpe wrote: On Thu, May 12, 2016 at 03:48:16PM -0400, Doug Ledford wrote: were going to rip out the EEPROM code. In any case, the best fix would be to rebase the two series that are remaining and move any "rip out things like eeprom support"

Re: [PATCH v2 3/5] IB/hfi1: Add ioctl() interface for user commands

On Thu, May 12, 2016 at 03:28:21PM -0600, Jason Gunthorpe wrote: On Thu, May 12, 2016 at 03:48:16PM -0400, Doug Ledford wrote: were going to rip out the EEPROM code. In any case, the best fix would be to rebase the two series that are remaining and move any "rip out things like eeprom support"

Re: [PATCH v2 0/5] IB/hfi1: Remove write() and use ioctl() for user access

On Thu, May 12, 2016 at 01:25:08PM -0600, Jason Gunthorpe wrote: On Thu, May 12, 2016 at 03:07:38PM -0400, Dennis Dalessandro wrote: >>There is also a driver software version being exported via a sysfs >>file. This is needed so that user space applications (psm) can >>det

Re: [PATCH v2 0/5] IB/hfi1: Remove write() and use ioctl() for user access

On Thu, May 12, 2016 at 01:25:08PM -0600, Jason Gunthorpe wrote: On Thu, May 12, 2016 at 03:07:38PM -0400, Dennis Dalessandro wrote: >>There is also a driver software version being exported via a sysfs >>file. This is needed so that user space applications (psm) can >>det

Re: [PATCH v2 3/5] IB/hfi1: Add ioctl() interface for user commands

On Thu, May 12, 2016 at 11:43:32AM -0600, Jason Gunthorpe wrote: On Thu, May 12, 2016 at 10:18:47AM -0700, Dennis Dalessandro wrote: + case HFI1_IOCTL_EP_INFO: + case HFI1_IOCTL_EP_ERASE_CHIP: + case HFI1_IOCTL_EP_ERASE_RANGE: + case HFI1_IOCTL_EP_READ_RANGE

Re: [PATCH v2 3/5] IB/hfi1: Add ioctl() interface for user commands

On Thu, May 12, 2016 at 11:43:32AM -0600, Jason Gunthorpe wrote: On Thu, May 12, 2016 at 10:18:47AM -0700, Dennis Dalessandro wrote: + case HFI1_IOCTL_EP_INFO: + case HFI1_IOCTL_EP_ERASE_CHIP: + case HFI1_IOCTL_EP_ERASE_RANGE: + case HFI1_IOCTL_EP_READ_RANGE

Re: [PATCH v2 0/5] IB/hfi1: Remove write() and use ioctl() for user access

On Thu, May 12, 2016 at 11:34:45AM -0600, Jason Gunthorpe wrote: On Thu, May 12, 2016 at 10:18:27AM -0700, Dennis Dalessandro wrote: There is also a driver software version being exported via a sysfs file. This is needed so that user space applications (psm) can determine if it needs to do

Re: [PATCH v2 0/5] IB/hfi1: Remove write() and use ioctl() for user access

On Thu, May 12, 2016 at 11:34:45AM -0600, Jason Gunthorpe wrote: On Thu, May 12, 2016 at 10:18:27AM -0700, Dennis Dalessandro wrote: There is also a driver software version being exported via a sysfs file. This is needed so that user space applications (psm) can determine if it needs to do

[PATCH v2 4/5] IB/hfi1: Remove write(), use ioctl() for user cmds

Remove the write() handler for user space commands now that ioctl handling is available. User apps will need to change to use ioctl from this point forward. Reviewed-by: Mitko Haralanov <mitko.harala...@intel.com> Signed-off-by: Dennis Dalessandro <dennis.dalessan...@intel.com>

  1   2   >