Hi Roman,
On Tue, May 19, 2020 at 04:16:17AM +0300, Roman Kovalivskyi wrote:
> From: Dave Stevenson
>
> Add support for an optional GPIO connected to PWDN on the sensor. This
> allows the use of hardware standby mode where internal device clock
> and circuit activities are halted.
>
> Please noth
Hi Roman, Sakari
On Tue, May 19, 2020 at 02:57:07PM +0300, Sakari Ailus wrote:
> Hi Roman,
>
> On Tue, May 19, 2020 at 04:16:18AM +0300, Roman Kovalivskyi wrote:
> > From: Dave Stevenson
> >
> > The driver was only supporting continuous clock mode
> > although this was not stated anywhere.
> > No
Hi Rob,
On Mon, Jun 15, 2020 at 09:02:28AM -0600, Rob Herring wrote:
> On Sat, Jun 13, 2020 at 6:28 AM Jacopo Mondi wrote:
> >
> > Hi Rob,
> >
> > On Fri, Jun 12, 2020 at 04:10:03PM -0600, Rob Herring wrote:
> > > On Fri, 12 Jun 2020 15:47:10 +0100, Kieran
utputs them on a CSI-2 port using up
> > to 4 data lanes.
> >
> > Signed-off-by: Laurent Pinchart
> > Signed-off-by: Jacopo Mondi
> > Signed-off-by: Kieran Bingham
> > Reviewed-by: Niklas Söderlund
> > Signed-off-by: Niklas Söderlund
> > Re
Hi Eugeniu
On Mon, Jun 08, 2020 at 11:44:32AM +0200, Eugeniu Rosca wrote:
> Hello,
>
> Many thanks for your comments and involvement.
>
> On Sun, Jun 07, 2020 at 05:41:58AM +0300, Laurent Pinchart wrote:
> > On Fri, Jun 05, 2020 at 03:53:15PM +0200, Jacopo Mondi wrote:
>
Hi Eugeniu,
On Tue, Jun 09, 2020 at 04:29:59PM +0200, Eugeniu Rosca wrote:
> Hi Laurent,
>
> On Sun, Jun 07, 2020 at 05:41:58AM +0300, Laurent Pinchart wrote:
> > Note that the CMM driver is controlled by the DU driver. As the DU
> > driver will reenable the display during resume, it will call
> >
Hi Eugeniu
On Fri, Jun 05, 2020 at 03:41:24PM +0200, Eugeniu Rosca wrote:
> Hi Jacopo,
>
> On Fri, Jun 05, 2020 at 03:29:00PM +0200, Jacopo Mondi wrote:
> > On Wed, May 27, 2020 at 09:15:55AM +0200, Eugeniu Rosca wrote:
> > > Could you kindly share the cross compilation s
Hello Eugeniu,
sorry for the late reply
On Wed, May 27, 2020 at 09:15:55AM +0200, Eugeniu Rosca wrote:
> Hi Jacopo,
>
> On Tue, Oct 15, 2019 at 12:46:13PM +0200, Jacopo Mondi wrote:
> 8<---
>
> > * Testing
> > I have tested by injecting a color inversi
Hi Kieran, Sakari
On Mon, May 18, 2020 at 12:45:18PM +0100, Kieran Bingham wrote:
> Hi Sakari,
>
> There are only fairly minor comments here, fix ups will be included in a
> v10.
>
> Is there anything major blocking integration?
>
> Regards
>
> Kieran
>
>
>
> On 16/05/2020 22:51, Sakari Ailus wrot
Hi Sakari
On Sun, May 17, 2020 at 01:36:57AM +0300, Sakari Ailus wrote:
> Hi Kieran,
>
[snip]
> > +
> > +/*
> > + * As the drivers supports a single MEDIA_BUS_FMT_UYVY8_2X8 format we
> > + * can harcode the pixel rate.
>
> Is this somehow the property of RDACM20? Or could you use other
> configu
and outputs them on a CSI-2 port using up
> > to 4 data lanes.
> >
> > Signed-off-by: Laurent Pinchart
> > Signed-off-by: Jacopo Mondi
> > Signed-off-by: Kieran Bingham
> > Reviewed-by: Niklas Söderlund
> > Signed-off-by: Niklas Söderlund
> > Re
Hi, sorry for not having replied earlier
On Wed, Oct 16, 2019 at 02:56:57PM +0200, Linus Walleij wrote:
> On Mon, Oct 14, 2019 at 10:12 AM Lee Jones wrote:
>
> > > arch/sh/boards/mach-ecovec24/setup.c | 33 --
> >
> > I guess we're just waiting for the SH Acks now?
>
> The one mainta
Uytterhoeven
Signed-off-by: Jacopo Mondi
---
Geert,
I've not been able to reproduce the issue on my boards (M3-N
Salvator-XS and M3-W Salvator-X). As you reported the issue you might be
able to reproduce it, could you please test this?
Also, I opted for deferring probe instead of arbitrary r
erday with informations on testing is available at:
https://lkml.org/lkml/2019/10/15/337
Geert will you collect for DTS patches for the next release?
I assume the DU changes go through Laurent instead ?
Thanks
j
Jacopo Mondi (8):
dt-bindings: display: renesas,cmm: Add R-Car CMM document
Add CMM units to Renesas R-Car Gen3 SoC that support it, and reference them
from the Display Unit they are connected to.
Sort the 'vsps', 'renesas,cmm' and 'status' properties in the DU unit
consistently in all the involved DTS.
Signed-off-by: Jacopo Mondi
--
Expand comment in the 'vsps' parsing routine to specify the LIF
channel index defaults to 0 in case the second cell of the property
is not specified to remain compatible with older DT bindings.
Reviewed-by: Laurent Pinchart
Signed-off-by: Jacopo Mondi
---
drivers/gpu/drm/rcar-du/rca
Hi Laurent,
On Thu, Sep 19, 2019 at 01:55:35AM +0300, Laurent Pinchart wrote:
> Hi Jacopo,
>
> Thank you for the patch.
>
> On Fri, Sep 06, 2019 at 03:54:30PM +0200, Jacopo Mondi wrote:
> > Add a driver for the R-Car Display Unit Color Correction Module.
> >
> &
g the pointer that is returned.
> > This nicely avoids referencing the match table when it is undefined with
> > configurations where CONFIG_OF=n.
> >
> > Cc: Arnd Bergmann
> > Cc: Geert Uytterhoeven
> > Cc: Jacopo Mondi
> > Cc: Mauro Carvalho Chehab
> >
r "fr > OV5640_15_FPS" so that it's safe for future
extensions.
(And I would check for the resolution first then FPS, so you check
the most unlikely condition first, but that's really a minor
optimization).
With the above small details addressed
Reviewed-by: Jacopo Mondi
T
still can successfully
program registers..
In any case, assuming 720p still works:
Reviewed-by: Jacopo Mondi
Thanks
j
On Wed, Oct 02, 2019 at 08:51:33AM -0500, Benoit Parrot wrote:
> In the 1920x1080 register array an extra pair of reset ctrl disable
> re-enable was causing unwa
Hi Benoit,
On Wed, Oct 02, 2019 at 08:51:32AM -0500, Benoit Parrot wrote:
> Add v4l2 controls to report the pixel rates of each mode. This is
> needed by some CSI2 receiver in order to perform proper DPHY
> configuration.
>
> Signed-off-by: Benoit Parrot
> ---
> drivers/media/i2c/ov5640.c | 25 +
Hi Benoit,
On Wed, Oct 02, 2019 at 10:06:15AM -0500, Benoit Parrot wrote:
> Jacopo Mondi wrote on Wed [2019-Oct-02 16:32:26 +0200]:
> > Hi Benoit,
> >
> > On Wed, Oct 02, 2019 at 07:14:38AM -0500, Benoit Parrot wrote:
> > > Hi Jacopo,
> > >
> > >
ari pointed out, going from one to the other is trivial and
could be done on top.
Thanks
j
> Regard,
> Benoit
>
> Jacopo Mondi wrote on Wed [2019-Oct-02 09:59:51 +0200]:
> > Hi Benoit,
> > +Hugues
> >
> > If you're considering an helper, this thread might be useful to you:
> > https://patchwork.kernel.org/patch/11019673/
> >
> > Thanks
> >j
> >
>
>
signature.asc
Description: PGP signature
Hi Benoit,
+Hugues
If you're considering an helper, this thread might be useful to you:
https://patchwork.kernel.org/patch/11019673/
Thanks
j
On Tue, Oct 01, 2019 at 11:23:41AM -0500, Benoit Parrot wrote:
> Hi Sakari,
>
> Thanks for the review.
>
> Sakari Ailus wrote on Tue [2019-Oct-01
>
Hello Manivannan,
On Tue, Oct 01, 2019 at 08:25:03PM +0530, Manivannan Sadhasivam wrote:
> The caller of v4l2_fwnode_endpoint_alloc_parse() is expected to pass a
> valid bus_type parameter for proper working of this API. Hence, pass
> V4L2_MBUS_CSI2_DPHY as the bus_type parameter as this driver on
Hi Ricardo,
On Fri, Sep 20, 2019 at 03:51:37PM +0200, Ricardo Ribalda Delgado wrote:
> From: Ricardo Ribalda Delgado
>
> According to the product brief, the unit cell size is 1120 nanometers^2.
>
> https://www.sony-semicon.co.jp/products_en/IS/sensor1/img/products/ProductBrief_IMX214_20150428.pdf
o was in favour of having min, max and step defined
(and applied to both width and height).
Really a minor issue from my side, feel free to keep it the way it is
Reviewed-by: Jacopo Mondi
Thanks
j
> * - ``V4L2_CTRL_TYPE_H264_SPS``
>- n/a
>- n/a
> --
> 2.23.0
>
signature.asc
Description: PGP signature
{
> __u32 denominator;
> };
>
> +struct v4l2_area {
> + __u32 width;
> + __u32 height;
> +};
> +
> /**
>* struct v4l2_capability - Describes V4L2 device caps returned by
> VIDIOC_QUERYCAP
>*
> @@ -1720,6 +1725,7 @@ enum v4l2_ctrl_type {
> V4L2_CTRL_TYPE_U8= 0x0100,
> V4L2_CTRL_TYPE_U16 = 0x0101,
> V4L2_CTRL_TYPE_U32 = 0x0102,
> + V4L2_CTRL_TYPE_AREA = 0x0106,
I'll let Hans comment on these two bits as I don't know if that's
adding a new control type is right or not.
Have my R-b for the rest though:
Reviewed-by: Jacopo Mondi
Thanks
j
> };
>
> /* Used in the VIDIOC_QUERYCTRL ioctl for querying controls */
> --
> 2.23.0
>
signature.asc
Description: PGP signature
pound controls can be added by calling
Standard compound controls with a driver provided default value can be..
Or is it un-necessary to re-state it?
In any case:
Reviewed-by: Jacopo Mondi
Thanks
j
> +:c:func:`v4l2_ctrl_new_std_compound`:
> +
> +.. code-block:: c
> +
> +
Hi Ricardo,
On Fri, Sep 20, 2019 at 03:51:31PM +0200, Ricardo Ribalda Delgado wrote:
> Currently compound controls do not have a simple way of initializing its
> values. This results in ofuscated code with type_ops init.
>
> This patch introduces a new field on the control with the default value
>
/cgit/kmsxx/commit/?h=gamma_lut&id=fe178a43861da7c8e79618e2a13fa0f19dbcd03d
Pretty happy with the result, which seems to be consistent across system
suspend/resume.
Testing with real world use cases might be beneficial. Rajesh are you still
interested in giving this series a spin?
Thanks
j
Jacopo Mond
Hi Laurent,
On Tue, Aug 27, 2019 at 03:05:17AM +0300, Laurent Pinchart wrote:
> Hi Jacopo,
>
> (Question for Daniel below)
>
> Thank you for the patch.
>
> On Sun, Aug 25, 2019 at 03:51:54PM +0200, Jacopo Mondi wrote:
> > When resuming from system suspend, the D
Hi Pavel,
On Sun, Sep 01, 2019 at 07:24:57PM +0200, Pavel Machek wrote:
> Hi!
>
> > > @@ -510,6 +510,29 @@ enum v4l2_scene_mode -
> > > value down. A value of zero stops the motion if one is in
> > > progress
> > > and has no effect otherwise.
> > >
> > > +``V4L2
Hi Luca,
thanks for keep pushing this series! I hope we can use part of this
for the (long time) on-going GMSL work...
I hope you will be patient enough to provide (another :) overview
of this work during the BoF Wolfram has organized at LPC for the next
week.
In the meantime I would have some
Hi Ricardo,
On Fri, Aug 23, 2019 at 02:37:37PM +0200, Ricardo Ribalda Delgado wrote:
> Instead of creating manually the V4L2_CID_UNIT_CELL_SIZE control, lets
> use the helper.
>
I think you should drop 4/7 and use directly the new helper here.
Thanks
j
> Signed-off-by: Ricardo Ribalda Delgado
Hi Ricardo,
On Fri, Aug 23, 2019 at 02:37:36PM +0200, Ricardo Ribalda Delgado wrote:
> Helper for creating area controls.
>
> Signed-off-by: Ricardo Ribalda Delgado
With this squashed on 5/7 or separated if we want documentation
changes to get in separately
Reviewed-by: Jacopo Mondi
.type_ops = &area_ops,
> > > > + };
> > > > +
> > > > + return v4l2_ctrl_new_custom(hdl, &ctrl, (void *)area);
> > > > +}
> > > > +EXPORT_SYMBOL(v4l2_ctrl_new_area);
> > > > +
> > > > +/* Helper function for standard integer menu controls */
> > >
> > > ... here?
> >
> > Because I screwed up :). Let me fix that sorry.
> >
> > I will push all your changes to:
> >
> > https://github.com/ribalda/linux/tree/unit-size-v4
> >
> > plus any other comment and then I will wait 2-3 days for resend
>
> Awesome, thanks! Feel free to add
>
> Reviewed-by: Philipp Zabel
With the issue pointed out by Philipp addressed
Reviewed-by: Jacopo Mondi
Thanks
j
>
> regards
> Philipp
signature.asc
Description: PGP signature
Hi Ricardo,
On Fri, Aug 23, 2019 at 02:37:33PM +0200, Ricardo Ribalda Delgado wrote:
> A struct v4l2_area containing the width and the height of a rectangular
> area.
>
> Signed-off-by: Ricardo Ribalda Delgado
> Suggested-by: Hans Verkuil
> ---
> Documentation/media/uapi/v4l/vidioc-queryctrl.rs
Hi Ricardo,
On Fri, Aug 23, 2019 at 02:37:31PM +0200, Ricardo Ribalda Delgado wrote:
> This control returns the unit cell size in nanometres. The struct provides
> the width and the height in separated fields to take into consideration
> asymmetric pixels and/or hardware binning.
> This control is
gt; + __u32 height;
> +};
> +
> /**
>* struct v4l2_capability - Describes V4L2 device caps returned by
> VIDIOC_QUERYCAP
>*
> @@ -1720,6 +1725,12 @@ enum v4l2_ctrl_type {
> V4L2_CTRL_TYPE_U8= 0x0100,
> V4L2_CTRL_TYPE_U16 = 0x0101,
> V4L2_CTRL_TYPE_U32
Hi Ricardo,
On Wed, Aug 21, 2019 at 06:31:05PM +0200, Ricardo Ribalda Delgado wrote:
> Hi Jacopo
>
>
> On Wed, Aug 21, 2019 at 6:14 PM Jacopo Mondi wrote:
> >
> > Hi Ricardo,
> >
> > On Mon, Aug 19, 2019 at 02:17:20PM +0200, Ricardo Ribalda Delgado wrote:
Hi Ricardo,
On Mon, Aug 19, 2019 at 02:17:20PM +0200, Ricardo Ribalda Delgado wrote:
> According to the product brief, the unit cell size is 1120 nanometers^2.
Should this information come from DT ?
I'm asking as I've a series in review that adds an helper that
collectes dt properties and regist
Hi Ricardo,
On Mon, Aug 19, 2019 at 02:17:18PM +0200, Ricardo Ribalda Delgado wrote:
> This control returns the pixel size in nanometres. The struct provides
> the width and the height in separated fields to take into consideration
> asymmetric pixels and/or hardware binning.
> This control is req
Hi Geert
On Wed, Aug 21, 2019 at 01:28:16PM +0200, Geert Uytterhoeven wrote:
> Hi Jonathan, Jacopo,
>
> On Mon, Aug 5, 2019 at 7:15 PM Jonathan Cameron wrote:
> > On Mon, 5 Aug 2019 17:55:15 +0200
> > Jacopo Mondi wrote:
> >
> > > The max9611 driver reads
Hi Geert,
sorry for the delayed response..
On Mon, Aug 19, 2019 at 03:45:54PM +0200, Geert Uytterhoeven wrote:
> Hi Jacopo,
>
> On Mon, Jul 8, 2019 at 9:58 AM Geert Uytterhoeven
> wrote:
> > On Sat, Jul 6, 2019 at 4:07 PM Jacopo Mondi
> > wrote:
> > > Add d
Add support for the newly defined V4L2_CID_LOCATION read-only control
used to report the camera device mounting position.
Signed-off-by: Jacopo Mondi
---
drivers/media/v4l2-core/v4l2-ctrls.c | 2 ++
include/uapi/linux/v4l2-controls.h | 5 +
2 files changed, 7 insertions(+)
diff --git a
Use the newly introduced helper to parse properties from firmware and
registerer the associated v4l2 control.
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/ov13858.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/media/i2c/ov13858.c b/drivers/media/i2c/ov13858.c
index
Use the newly introduced helper to parse properties from firmware and
registerer the associated v4l2 control.
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/ov5670.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/media/i2c/ov5670.c b/drivers/media/i2c/ov5670.c
index
ned-off-by: Jacopo Mondi
---
drivers/media/v4l2-core/v4l2-fwnode.c | 40 +++
include/media/v4l2-fwnode.h | 29 +++
2 files changed, 69 insertions(+)
diff --git a/drivers/media/v4l2-core/v4l2-fwnode.c
b/drivers/media/v4l2-core/v4l2-fwno
Add documentation for the V4L2_CID_LOCATION camera control. The newly
added read-only control reports the camera device mounting position.
Signed-off-by: Jacopo Mondi
---
.../media/uapi/v4l/ext-ctrls-camera.rst | 34 +++
1 file changed, 34 insertions(+)
diff --git a
Add the 'location' device property, used to specify the camera device
mounting position. The property is particularly meaningful for mobile
devices with a well defined usage orientation.
Signed-off-by: Jacopo Mondi
---
.../devicetree/bindings/media/video-interfaces.txt | 10 +++
all. What other properties could be
parsed and registered as controls which I have missed?
Thanks
j
Jacopo Mondi (6):
media: dt-bindings: Document 'location' property
media: v4l2-ctrl: Document V4L2_CID_LOCATION
media: v4l2-ctrls: Add support for V4L2_CID_LOCATION
media: v4l2-fw
Hi Hans,
On Thu, Aug 15, 2019 at 04:14:38PM +0200, Hans Verkuil wrote:
> On 8/15/19 4:10 PM, Hans Verkuil wrote:
> > On 8/15/19 12:43 AM, Laurent Pinchart wrote:
> >> Hi Jacopo,
> >>
> >> Thank you for the patch.
> >>
> >> On Wed, Aug 14, 2
Hi Hans,
On Thu, Aug 15, 2019 at 03:30:59PM +0200, Hans Verkuil wrote:
> On 8/14/19 10:28 PM, Jacopo Mondi wrote:
> > Add documentation for the V4L2_CID_LOCATION camera control. The newly
> > added read-only control reports the camera device mounting position.
> >
> >
Hi Hans,
On Thu, Aug 15, 2019 at 03:23:47PM +0200, Hans Verkuil wrote:
> On 8/14/19 10:28 PM, Jacopo Mondi wrote:
> > Add support for the newly defined V4L2_CID_LOCATION read-only control
> > used to report the camera device mounting position.
> >
> >
Hi Hans,
On Thu, Aug 15, 2019 at 03:41:53PM +0200, Hans Verkuil wrote:
> On 8/15/19 3:02 PM, Jacopo Mondi wrote:
> > Hi Laurent,
> >
> > On Thu, Aug 15, 2019 at 01:53:53AM +0300, Laurent Pinchart wrote:
> >> Hi Jacopo,
> >>
> >> Thank you for th
Hi Laurent,
On Thu, Aug 15, 2019 at 01:53:53AM +0300, Laurent Pinchart wrote:
> Hi Jacopo,
>
> Thank you for the patch.
>
> On Wed, Aug 14, 2019 at 10:28:13PM +0200, Jacopo Mondi wrote:
> > Add support for the newly defined V4L2_CID_LOCATION read-only control
> > used
Hi Laurent,
On Thu, Aug 15, 2019 at 01:43:40AM +0300, Laurent Pinchart wrote:
> Hi Jacopo,
>
> Thank you for the patch.
>
> On Wed, Aug 14, 2019 at 10:28:12PM +0200, Jacopo Mondi wrote:
> > Add documentation for the V4L2_CID_LOCATION camera control. The newly
> > adde
Hi Sakari,
On Thu, Aug 15, 2019 at 09:56:35AM +0300, Sakari Ailus wrote:
> Hi Jacopo,
>
> On Wed, Aug 14, 2019 at 10:28:11PM +0200, Jacopo Mondi wrote:
> > Add the 'location' device property, used to specify the camera device
> > mounting position. The property
Add documentation for the V4L2_CID_LOCATION camera control. The newly
added read-only control reports the camera device mounting position.
Signed-off-by: Jacopo Mondi
---
.../media/uapi/v4l/ext-ctrls-camera.rst | 23 +++
1 file changed, 23 insertions(+)
diff --git a
Add the 'location' device property, used to specify the camera device
mounting position. The property is particularly meaningful for mobile
devices with a well defined usage orientation.
Signed-off-by: Jacopo Mondi
---
Documentation/devicetree/bindings/media/video-interfaces.txt |
The camera location is retrieved from the firmware interface parsing
the "location" device property and reported through the read-only
V4L2_CID_LOCATION control.
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/ov5670.c | 11 +++
1 file changed, 11 insertions(+)
diff --git
Add support for the newly defined V4L2_CID_LOCATION read-only control
used to report the camera device mounting position.
Signed-off-by: Jacopo Mondi
---
drivers/media/v4l2-core/v4l2-ctrls.c | 7 +++
include/uapi/linux/v4l2-controls.h | 4
2 files changed, 11 insertions(+)
diff
The camera location is retrieved from the firmware interface parsing
the "location" device property and reported through the read-only
V4L2_CID_LOCATION control.
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/ov13858.c | 11 +++
1 file changed, 11 insertions(+)
diff --git
such as
"orientation", "position", "mounting-position" but none of them really satisfied
me, so I picked the most simple one. Feedbacks are welcome here too.
Thanks
j
Jacopo Mondi (5):
media: dt-bindings: Document 'location' property
media: v4l2-ct
Hi Jonathan,
On Mon, Aug 05, 2019 at 06:12:44PM +0100, Jonathan Cameron wrote:
> On Mon, 5 Aug 2019 17:55:15 +0200
> Jacopo Mondi wrote:
>
> > The max9611 driver reads the die temperature at probe time to validate
> > the communication channel. Use the actual read valu
is in the range of supported temperatures.
Fixes: 69780a3bbc0b ("iio: adc: Add Maxim max9611 ADC driver")
Signed-off-by: Jacopo Mondi
---
drivers/iio/adc/max9611.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/adc/max9611.c b/drivers/iio/adc/max96
Hello,
so I finally run some test and...
On Sun, Jul 14, 2019 at 05:19:32AM -0700, Joe Perches wrote:
> On Sun, 2019-07-14 at 12:54 +0100, Jonathan Cameron wrote:
> > On Tue, 9 Jul 2019 22:04:17 -0700
> > Joe Perches wrote:
> >
> > > Arguments are supposed to be ordered high then low.
> > >
>
Hi Joe, Jonathan,
On Sun, Jul 14, 2019 at 05:19:32AM -0700, Joe Perches wrote:
> On Sun, 2019-07-14 at 12:54 +0100, Jonathan Cameron wrote:
> > On Tue, 9 Jul 2019 22:04:17 -0700
> > Joe Perches wrote:
> >
> > > Arguments are supposed to be ordered high then low.
> > >
> > > Signed-off-by: Joe Pe
LUT to the internal RAM memory,
> + * we need to first make sure the dsp_lut_en bit is cleared.
> + */
> + spin_lock(&vop->reg_lock);
> + VOP_REG_SET(vop, common, dsp_lut_en, 0);
> + vop_cfg_done(vop);
> + spin_unlock(&vop->reg_lock);
>
Hi Lubomir, Sakari,
On Thu, Jun 20, 2019 at 01:37:53PM +0200, Lubomir Rintel wrote:
> On Thu, 2019-06-20 at 14:35 +0300, Sakari Ailus wrote:
> > Ping?
> >
> > Lubomir: I'm applying the set now, but please addres Jacopo's comment.
> > Thanks.
>
> Hi, I'm wondering if you could wait a couple of minu
On Tue, May 28, 2019 at 11:07:29AM +0200, Lubomir Rintel wrote:
> The platform data is actually not used anywhere (along with the CSI
> support) and should be safe to remove.
>
> Signed-off-by: Lubomir Rintel
> Acked-by: Pavel Machek
>
> ---
> Changes since v1:
> - s/This are/These are/ in a comm
Hi Lubomir,
On Sun, May 05, 2019 at 04:00:24PM +0200, Lubomir Rintel wrote:
> The commit 05fed81625bf ("[media] marvell-ccic: add MIPI support for
> marvell-ccic driver") that claimed to add CSI2 turned on C0_EOF_VSYNC for
> parallel bus without a very good explanation.
>
> That broke camera on OL
synchronization polarity (only required for
> + parallel bus)
> + - vsync-active: vertical synchronization polarity (only required for
> + parallel bus)
Minor nit: if you don't want to specify what maps to 0/1 in the
properties, could you add "as defined in video-i
eg_write(cam, REG_DMA_DESC_Y, buf->dma_desc_pa);
> mcam_reg_write(cam, REG_DESC_LEN_Y,
> - buf->dma_desc_nent*sizeof(struct mcam_dma_desc));
> + sg_table->nents*sizeof(struct mcam_dma_desc));
Space betwen operators (it was there already, I
Hi Laurent,
thanks for the review
On Fri, Jun 07, 2019 at 02:35:40PM +0300, Laurent Pinchart wrote:
> Hi Jacopo,
>
> Thank you for the patch.
>
> On Thu, Jun 06, 2019 at 04:22:14PM +0200, Jacopo Mondi wrote:
> > Add a driver for the R-Car Display Unit Color Correction Mo
Hi Laurent,
thanks for review
On Fri, Jun 07, 2019 at 03:03:04PM +0300, Laurent Pinchart wrote:
> Hi Jacopo,
>
> Thank you for the patch.
>
> On Thu, Jun 06, 2019 at 04:22:19PM +0200, Jacopo Mondi wrote:
> > Enable the GAMMA_LUT KMS property using the framework helper
Hi Kangjie,
thanks for the patch.
On Sat, Mar 09, 2019 at 01:14:24AM -0600, Kangjie Lu wrote:
> In case of_match_device cannot find a match, the check returns
> -EINVAL to avoid a potential NULL pointer dereference
>
> Signed-off-by: Kangjie Lu
> ---
> drivers/media/platform/renesas-ceu.c | 5
ned-off-by: Jacopo Mondi
---
Hans pointed me to this error quite some time ago, but it took me a kbuild
error to address this. Sorry for the delay.
Again, should this go through media as this is caused by soc_camera related
churn?
Thanks
j
---
arch/sh/boards/mach-migor/setup.c | 1 +
1 file
of
ov5640_try_frame_interval() never gets satisfied (0 < 0 ?) and 'rate' retains
its initial value of 30FPS.
if (abs(curr_fps - fps) < abs(best_fps - fps)) {
best_fps = curr_fps;
rate = i;
}
To make more clear what&#x
Hi Alexey,
thanks for the patch
On Sun, Dec 30, 2018 at 12:35:20AM +0300, Alexey Khoroshilov wrote:
> If gpiod_get_optional() fails in tw9910_power_on(), clk is left undisabled.
>
Correct, thanks for spotting this.
I think pdn_gpio should also be handled if rstb_gpio fails.
What's your opinio
On Wed, Dec 12, 2018 at 09:43:23AM +0100, Michael Nazzareno Trimarchi wrote:
> Hi
>
> On Wed, Dec 12, 2018 at 9:39 AM jacopo mondi wrote:
> >
> > Hi Michael,
> >
> > On Tue, Dec 11, 2018 at 02:53:24PM +0100, Michael Nazzareno Trimarchi wrote:
> > > Hi Jac
Hi Michael,
On Tue, Dec 11, 2018 at 02:53:24PM +0100, Michael Nazzareno Trimarchi wrote:
> Hi Jacopo
>
> On Tue, Dec 11, 2018 at 12:39 PM jacopo mondi wrote:
> >
> > Hi Michael,
> >
> > On Mon, Dec 10, 2018 at 10:45:02PM +0100, Michael Nazzareno Trimarchi wrote:
Hi Michael,
On Mon, Dec 10, 2018 at 10:45:02PM +0100, Michael Nazzareno Trimarchi wrote:
> Hi Jacopo
>
> Let's see what I have done
>
> On Sun, Dec 9, 2018 at 8:39 PM jacopo mondi wrote:
> >
> > Hi Michael, Jagan, Hans,
> >
> > On Sat, Dec 08,
Hi Sakari,
thanks for digging this out
On Mon, Dec 10, 2018 at 01:39:17AM +0200, sakari.ai...@iki.fi wrote:
> Hi Jacopo,
>
> On Fri, Dec 29, 2017 at 01:22:26PM +0100, Jacopo Mondi wrote:
> > The following commits:
> > commit f6dd927f34d6 ("[media] media: ov7670: ca
Hi Michael, Jagan, Hans,
On Sat, Dec 08, 2018 at 06:07:04PM +0100, Michael Nazzareno Trimarchi wrote:
> Hi
>
> Down you have my tentative of connection
>
> I need to hack a bit to have tuner registered. I'm using imx-media
>
> On Sat, Dec 8, 2018 at 12:48 PM Michael Nazzareno Trimarchi
> wrote:
>
) respectively rza1_parse_gpiochip() return
> negative values so -ENOMEM in the (unlikely) failure case of
> devm_kasprintf() should be fine here.
devm_kasprintf() returns -ENOMEM in case of failure (which I agree it's
unlikely, but still...), so I guess it's fine returning -ENOMEM a
Hi Lubo,
On Mon, Nov 05, 2018 at 02:12:18PM +0100, Lubomir Rintel wrote:
> Hello,
>
> On Mon, 2018-11-05 at 11:58 +0100, jacopo mondi wrote:
> > Hi Lubomir,
> >+Sakari in Cc
> >
> > I just noticed this, and the patch is now in v4.20, but let me comment
> &
4 ("media: arch: sh: kfr2r09: Use new renesas-ceu camera
> driver")
Not sure if this is worth pointing out, but this commit only resorts
headers. The one introducing the warning is actually 33893d7aa.
I felt like reporting this, as introducing a "Fixes" line for that
commi
Hi Mark,
On Fri, Oct 12, 2018 at 06:44:24PM +0200, Mark Brown wrote:
> On Fri, Oct 12, 2018 at 04:26:12PM +0200, jacopo mondi wrote:
>
> > Sorry, I'm going slightly OT with this, but please read below.
>
> > On Fri, Oct 12, 2018 at 02:54:12PM +0200, Linus Wallei
Hi Linus,
+ Laurent, as he reviewed most of that driver code
Sorry, I'm going slightly OT with this, but please read below.
On Fri, Oct 12, 2018 at 02:54:12PM +0200, Linus Walleij wrote:
> This allows nonexclusive (simultaneous) access to a single
> GPIO line for the fixed regulator enable lin
Hi Phil,
On Tue, Sep 18, 2018 at 11:55:16AM +, Phil Edworthy wrote:
> Hi Jacopo,
>
[snip]
> > > +
> > > +/*
> > > + * Structure detailing the HW registers on the RZ/N1 devices.
> > > + * Both the Level 1 mux registers and Level 2 mux registers have the
> > > +same
> > > + * structure. The on
Hi Sakari,
On Thu, Sep 13, 2018 at 03:44:25PM +0300, Sakari Ailus wrote:
> Hi Jacopo,
>
> On Thu, Sep 13, 2018 at 12:37:27PM +0200, jacopo mondi wrote:
> > Hi Steve,
> >
> > On Mon, Jul 09, 2018 at 03:39:06PM -0700, Steve Longerbeam wrote:
> > > Adds v4l2_asyn
Hi Sakari,
On Fri, Aug 31, 2018 at 03:25:58PM +0300, Sakari Ailus wrote:
> Hi Jacopo,
>
> On Mon, May 28, 2018 at 06:37:06PM +0200, Jacopo Mondi wrote:
> > Hello,
> > this series removes dependencies on the soc_camera based
> > sh_mobile_ceu_camera driver from 3
Hi,
On Mon, Jul 30, 2018 at 10:24:45AM +0300, Sakari Ailus wrote:
> Hi folks,
>
> On Mon, Jul 30, 2018 at 12:00:53PM +1000, Stephen Rothwell wrote:
> > Hi Rafael,
> >
> > After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
> > produced this warning:
> >
> > drivers/media/i2c/
From: Jacopo Mondi
Add V4L2 sensor driver for Aptina MT9V111 CMOS image sensor.
The MT9V111 is a 1/4-Inch CMOS image sensor based on MT9V011 with an
integrated Image Flow Processor.
Reviewed-by: Kieran Bingham
Signed-off-by: Jacopo Mondi
---
drivers/media/i2c/Kconfig | 11 +
drivers
From: Jacopo Mondi
Add documentation for Aptina MT9V111 image sensor.
Reviewed-by: Rob Herring
Signed-off-by: Jacopo Mondi
---
.../bindings/media/i2c/aptina,mt9v111.txt | 46 ++
MAINTAINERS| 8
2 files changed, 54
posure and auto-white-balancing
- Move MAINTAINERS modifications to bindings patch
- Fix resolution in bindings document
- Drop dependency on OF
- Drop subdev 'open' function in favour of pad operation init_cfg and use a
default configuration to initialize the sensor
- Turn off power if sen
selector in case we need to remove them. Otherwise
> the selector use will be racy for deferred probe at least.
>
> Fixes: 5a49b644b307 ("pinctrl: Renesas RZ/A1 pin and gpio controller")
> Reported-by: H. Nikolaus Schaller
> Cc: Haojian Zhuang
> Cc: Jacopo Mondi
> Cc
initialized with auto-exposure control, auto white balancing and flickering
control disabled.
Tested VGA, QVGA QQVGA resolutions at 5, 10, 15 and 30 frame per second.
Thanks
j
Jacopo Mondi (2):
dt-bindings: media: i2c: Document MT9V111 bindings
media: i2c: Add driver for Aptina MT9V111
301 - 400 of 949 matches
Mail list logo
