EQPACKET is set and then cleared,
>then seqpacket_allow will not be cleared appropriately
>(existing apps I know about don't usually do this but
> it's legal and there's no way to be sure no one relies
> on this).
Acked-by: Jakub Kicinski
--
pw-bot: nap
On Mon, 29 Apr 2024 17:15:57 +0800 (CST) xu.xi...@zte.com.cn wrote:
> Introduce a tracepoint for icmp_send, which can help users to get more
> detail information conveniently when icmp abnormal events happen.
Rebase please, it doesn't apply. And please put the change log under
the --- delimiter.
On Thu, 25 Apr 2024 18:28:40 +0200 Ismael Luceno wrote:
> Changes since v2:
> * Use only skb_is_gso, no need to check for GSO type
v2 is already in the tree, if the change is important you need to send
an incremental fix.
On Tue, 23 Apr 2024 17:23:39 +0800 (CST) xu.xi...@zte.com.cn wrote:
> +#include
> \ No newline at end of file
Please fix.
--
pw-bot: cr
On Thu, 18 Apr 2024 11:30:02 +0800 Jason Xing wrote:
> I'm not sure why the patch series has been changed to 'Changes
> Requested', until now I don't think I need to change something.
>
> Should I repost this series (keeping the v6 tag) and then wait for
> more comments?
If Eric doesn't like it
On Thu, 11 Apr 2024 16:52:16 +0800 Liang Chen wrote:
> + switch (__le16_to_cpu(hdr_hash->hash_report)) {
> + case VIRTIO_NET_HASH_REPORT_TCPv4:
Please indent things according to the kernel coding style.
Checkpatch finds 2 problems in this change.
--
pw-bot: cr
On Wed, 3 Apr 2024 15:31:38 +0800 Jason Xing wrote:
> It's based on top of
> https://patchwork.kernel.org/project/netdevbpf/list/?series=840182
Please post as RFC if there's a dependency.
We don't maintain patch queues for people.
--
pw-bot: cr
On Sun, 31 Mar 2024 16:20:30 -0400 Michael S. Tsirkin wrote:
> > Fixes: c7114b1249fa ("drivers/net/virtio_net: Added basic RSS support.")
> > Cc: sta...@vger.kernel.org
>
> net has its own stable process, don't CC stable on net patches.
Not any more, FWIW:
1.5.7. Stable tree
While it
On Tue, 26 Mar 2024 12:08:01 +0100 Paolo Abeni wrote:
> > - TP_PROTO(const struct sock *sk, const struct sk_buff *skb),
> > + TP_PROTO(
> > + const struct sock *sk,
> > + const struct sk_buff *skb,
> > + void *location),
>
> Very minor nit: the above lines
On Mon, 25 Mar 2024 11:29:18 +0100 Balazs Scheidler wrote:
> +memset(__entry->saddr, 0, sizeof(struct sockaddr_in6));
> +memset(__entry->daddr, 0, sizeof(struct sockaddr_in6));
Indent with tabs please, checkpatch says:
ERROR: code indent should use tabs where
On Tue, 26 Mar 2024 10:13:55 +0800 Jason Xing wrote:
> Yesterday, I posted two series to do two kinds of things. They are not
> the same. Maybe you get me wrong :S
Ah, my bad, sorry about that. I see that they are different now.
One is v1 the other v2, both targeting tcp tracing... Easy to miss
On Mon, 25 Mar 2024 14:28:28 +0800 Jason Xing wrote:
> Before this, we miss some cases where the TCP layer could send rst but
> we cannot trace it. So I decided to complete it :)
>
> v2
> 1. fix spelling mistakes
Not only do you post it before we "officially" open net-next but
also ignoring the
On Thu, 21 Mar 2024 11:09:18 +0800 (CST) xu.xi...@zte.com.cn wrote:
> +/* This part must be outside protection */
> +#include
> \ No newline at end of file
In addition to Jason's comments please make sure there is a new line at
the end of the file.
And please post v4 on Monday, net-next is
On Thu, 14 Mar 2024 21:09:31 +0800 Heng Qi wrote:
> The NetDIM library provides excellent acceleration for many modern
> network cards. However, the default profiles of DIM limits its maximum
> capabilities for different NICs, so providing a channel through which
> the NIC can be custom configured
On Sun, 10 Mar 2024 20:14:03 +0800 Jason Xing wrote:
> Using the macro for other tracepoints use to be more concise.
> No functional change.
The merge window for 6.9 has started and we try not to apply patches
to net-next during the merge window. Please repost in 2 weeks, once
Linus has tagged
On Tue, 13 Feb 2024 14:57:49 +0100 Eric Dumazet wrote:
> Please note that adding other sysfs entries is expensive for workloads
> creating/deleting netdev and netns often.
>
> I _think_ we should find a way for not creating
> /sys/class/net//queues/tx-{Q}/byte_queue_limits directory
> and files
On Sat, 3 Feb 2024 00:01:26 +0900 Masahiro Yamada wrote:
> I do not see why it is useful.
> As you discussed in 3/4, if UTS_RELEASE is unneeded,
> it is better to get rid of it.
To be clear - the discussion on 3/4 was about the fact that netdev
already prints UTS_RELEASE into the version member
On Thu, 1 Feb 2024 14:20:23 +0100 Jiri Pirko wrote:
> >BTW, I assume that changes like this are also ok:
> >
> >8<-
> >
> > net: team: Don't bother filling in ethtool driver version
Yup, just to be clear - you can send this independently from the series,
tag is as
[PATCH
On Wed, 31 Jan 2024 10:48:50 + John Garry wrote:
> Instead of using UTS_RELEASE, use uts_release, which means that we don't
> need to rebuild the code just for the git head commit changing.
>
> Signed-off-by: John Garry
Yes, please!
Acked-by: Jakub Kicinski
On Wed, 10 Jan 2024 09:50:08 -0800 Shakeel Butt wrote:
> On Thu, Jan 4, 2024 at 1:44 PM Jakub Kicinski wrote:
> > You seem to be trying hard to make struct netmem a thing.
> > Perhaps you have a reason I'm not getting?
>
> Mina already went with your suggestion and that i
On Thu, 21 Dec 2023 15:44:22 -0800 Mina Almasry wrote:
> The warning is like so:
>
> ./include/net/page_pool/helpers.h: In function ‘page_pool_alloc’:
> ./include/linux/stddef.h:8:14: warning: returning ‘void *’ from a
> function with return type ‘netmem_ref’ {aka ‘long unsigned int’} makes
>
On Tue, 5 Dec 2023 19:34:40 +0800 Yunsheng Lin wrote:
> __GFP_DIRECT_RECLAIM is xor'd to avoid
> direct reclaim in skb_page_frag_refill(), but it is not
> xor'd in __page_frag_cache_refill().
xor is not the same thing as masking a bit off.
The patch itself LGTM.
On Tue, 5 Dec 2023 15:10:50 + Russell King (Oracle) wrote:
> I've raised this before in other subsystems, and it's suggested that
> it's better to have it in the .c file. I guess the reason is that it's
> more obvious that the function is documented when modifying it, so
> there's a higher
On Tue, 10 Oct 2023 11:04:18 +0300 Jani Nikula wrote:
> > If you do invest in build testing automation, why can't your automation
> > count warnings rather than depend on WERROR? I don't understand.
>
> Because having both CI and the subsystem/driver developers enable a
> local WERROR actually
On Mon, 9 Oct 2023 16:18:59 +0200 Arnd Bergmann wrote:
> The last localtalk driver is gone now, and ppp support was never fully
> merged, so clean up the appletalk code by removing the obvious dead
> code paths.
>
> Notably, this removes one of the two callers of the old .ndo_do_ioctl()
>
On Mon, 9 Oct 2023 12:33:53 -0700 Sean Christopherson wrote:
> > We do have sympathy for these folks, we are mostly volunteers after
> > all. At the same time someone's under-investment should not be causing
> > pain to those of us who _do_ build test stuff carefully.
>
> This is a bit over the
On Mon, 9 Oct 2023 10:43:43 -0700 Sean Christopherson wrote:
> On Fri, Oct 06, 2023, Jakub Kicinski wrote:
> > Setting WERROR for random subsystems make life really hard
> > for subsystems which want to build-test their stuff with W=1.
> > WERROR for the entire kernel now e
...
Link:
https://lore.kernel.org/all/0da9874b6e9fcbaaa5edeb345d7e2a7c859fc818.1696271334.git.thomas.lenda...@amd.com/
Signed-off-by: Jakub Kicinski
---
Documentation/process/maintainer-kvm-x86.rst | 2 +-
arch/x86/kvm/Kconfig | 14 --
arch/x86/kvm/Makefile
On Wed, 27 Sep 2023 11:00:30 +0200 Greg Kroah-Hartman wrote:
> The COPS Appletalk support is very old, never said to actually work
> properly, and the firmware code for the devices are under a very suspect
> license. Remove it all to clear up the license issue, if it is still
> needed and
On Wed, 4 Oct 2023 12:35:24 -0400 Steven Rostedt wrote:
> > Potentially naive question - the trace point holds enum skb_drop_reason.
> > The user space can get the names from BTF. Can we not teach user space
> > to generically look up names of enums in BTF?
>
> That puts a hard requirement to
On Thu, 21 Sep 2023 10:51:30 +0200 Johannes Berg wrote:
> So I was frustrated with not seeing the names of SKB dropreasons
> for all but the core reasons, and then while looking into this
> all, realized, that the current __print_symbolic() is pretty bad
> anyway.
>
> So I came up with a new
On Tue, 20 Apr 2021 10:34:17 +0200 Eric Dumazet wrote:
> On Tue, Apr 20, 2021 at 9:54 AM AceLan Kao wrote:
> >
> > From: "Chia-Lin Kao (AceLan)"
> >
> > The rtnl_lock() has been called in rtnetlink_rcv_msg(), and then in
> > __dev_open() it calls pm_runtime_resume() to resume devices, and in
> >
On Tue, 20 Apr 2021 07:00:39 + Hayes Wang wrote:
> > > @@ -6878,7 +8942,11 @@ static int rtl8152_probe(struct usb_interface
> > > *intf,
> > > set_ethernet_addr(tp);
> > >
> > > usb_set_intfdata(intf, tp);
> > > - netif_napi_add(netdev, >napi, r8152_poll, RTL8152_NAPI_WEIGHT);
> > > +
>
- netfilter: nftables: clone set element expression template
- netfilter: flowtable: fix NAT IPv6 offload mangling
- net: geneve: check skb is large enough for IPv4/IPv6 header
- netlink: don't call ->netlink_bind with table lock held
Signed-off-by
On Fri, 16 Apr 2021 16:04:35 +0800 Hayes Wang wrote:
> Support RTL8153C, RTL8153D, RTL8156A, and RTL8156B. The RTL8156A
> and RTL8156B are the 2.5G ethernet.
>
> Signed-off-by: Hayes Wang
> + switch (tp->version) {
> + case RTL_VER_10:
> + data = ocp_reg_read(tp, 0xad40);
>
On Fri, 16 Apr 2021 15:16:56 +0200 Steen Hegelund wrote:
> + "rx_in_bytes",
> + "rx_symbol_err",
> + "rx_pause",
> + "rx_unsup_opcode",
> + "rx_ok_bytes",
> + "rx_bad_bytes",
> + "rx_unicast",
> + "rx_multicast",
> + "rx_broadcast",
> + "rx_crc_err",
> +
On Fri, 16 Apr 2021 15:16:50 +0200 Steen Hegelund wrote:
> +static int sparx5_set_mac_address(struct net_device *dev, void *p)
> +{
> + const struct sockaddr *addr = p;
> +
> + /* Record the address */
> + ether_addr_copy(dev->dev_addr, addr->sa_data);
I think you need to validate
On Wed, 14 Apr 2021 22:45:19 -0700 Dexuan Cui wrote:
> + buf = dma_alloc_coherent(gmi->dev, length, _handle,
> + GFP_KERNEL | __GFP_ZERO);
No need for GFP_ZERO, dma_alloc_coherent() zeroes the memory these days.
> +static int mana_gd_register_irq(struct
On Thu, 15 Apr 2021 14:59:49 +0800 jin yiting wrote:
> From 71e63af579edd15ad7f7395760a19f67d9a1d7d3 Mon Sep 17 00:00:00 2001
> From: jin yiting
> Date: Wed, 31 Mar 2021 20:38:40 +0800
> Subject: [PATCH] bonding: 3ad: update slave arr after initialize
> MIME-Version: 1.0
> Content-Type:
On Thu, 15 Apr 2021 15:07:36 +0200 Oleksij Rempel wrote:
> With this patch FEC on iMX will able to run generic net selftests
>
> Signed-off-by: Oleksij Rempel
allmodconfig build fails starting from this patch and still fails
after patch 7:
net/core/selftests.o: In function `net_selftest':
On Mon, 12 Apr 2021 19:35:09 -0700 Dexuan Cui wrote:
> + apc->port_st_save = apc->port_is_up;
> + apc->port_is_up = false;
> + apc->start_remove = true;
> +
> + /* Ensure port state updated before txq state */
> + smp_wmb();
> +
> + netif_tx_disable(ndev);
In your napi
On Tue, 13 Apr 2021 18:06:39 +0200 Thierry Reding wrote:
> given where we are in the release cycle, I think it'd be best to revert
> commit 9c63faaa931e ("net: stmmac: re-init rx buffers when mac resume
> back") for now.
>
> To summarize the discussion: the patch was meant as a workaround to fix
On Sun, 11 Apr 2021 19:34:55 -0700 Dexuan Cui wrote:
> + for (i = 0; i < ANA_INDIRECT_TABLE_SIZE; i++)
> + apc->indir_table[i] = i % apc->num_queues;
ethtool_rxfh_indir_default()
> + err = mana_cfg_vport_steering(apc, rx, true, update_hash, update_tab);
> + return err;
Other than the minor nit below LGTM. Let's give Richard one more day.
On Thu, 8 Apr 2021 01:04:42 +0800 Wong Vee Khee wrote:
> +static void timestamp_interrupt(struct stmmac_priv *priv)
> +{
> + struct ptp_clock_event event;
> + unsigned long flags;
> + u32 num_snapshot;
> + u32
On Fri, 9 Apr 2021 19:50:09 +0800 samirweng1979 wrote:
> From: wengjianfeng
>
> In many places,first assign a value to a variable and then return
> the variable. which is redundant, we should directly return the value.
> in pn533_rf_field funciton,return statement in the if statement is
>
initialized stack memory in ct limit reply
Jacek Bułatek (1):
ice: Fix for dereference of NULL pointer
Jakub Kicinski (4):
docs: ethtool: fix some copy-paste errors
ethtool: un-kdocify extended link state
ethtool: document reserved fields in the uAPI
ethtool: fix kdoc in hea
On Fri, 9 Apr 2021 22:44:50 +0200 Matteo Croce wrote:
> > What pops to mind (although quite nit picky) is the question if the
> > assembly changes much between driver which used to cache nr_frags and
> > now always going skb_shinfo(skb)->nr_frags? It's a relatively common
> > pattern.
>
> Since
On Fri, 9 Apr 2021 21:41:06 +0300 Radu Pirea (NXP OSS) wrote:
> Add driver for tja1103 driver and for future NXP C45 PHYs.
>
> Signed-off-by: Radu Pirea (NXP OSS)
drivers/net/phy/nxp-c45: struct mdio_device_id is 8 bytes. The last of 1 is:
0x10 0xb0 0x1b 0x00 0xf0 0xff 0xff 0xff
FATAL:
On Fri, 9 Apr 2021 22:01:51 +0300 Ilias Apalodimas wrote:
> On Fri, Apr 09, 2021 at 11:56:48AM -0700, Jakub Kicinski wrote:
> > On Fri, 2 Apr 2021 20:17:31 +0200 Matteo Croce wrote:
> > > Co-developed-by: Jesper Dangaard Brouer
> > > Co-developed-by: Matteo Croce
On Fri, 2 Apr 2021 20:17:31 +0200 Matteo Croce wrote:
> Co-developed-by: Jesper Dangaard Brouer
> Co-developed-by: Matteo Croce
> Signed-off-by: Ilias Apalodimas
Checkpatch says we need sign-offs from all authors.
Especially you since you're posting.
On Fri, 9 Apr 2021 20:06:04 +0200 Matteo Croce wrote:
> From: Matteo Croce
>
> use the new helper macro skb_for_each_frag() which allows to iterate
> through all the SKB fragments.
>
> The patch was created with Coccinelle, this was the semantic patch:
Bunch of set but not used warnings here.
On Fri, 9 Apr 2021 17:07:08 +0800 Joakim Zhang wrote:
> This patch set adds new properties for of_get_mac_address from nvmem.
Apart from addressing Rob's (and potentially other comments to come)
please also make sure to rebase before posting. This series doesn't
seem to apply to net-next.
On Fri, 9 Apr 2021 20:01:14 +0300 Vadym Kochan wrote:
> On Fri, Apr 09, 2021 at 09:51:13AM -0700, Samudrala, Sridhar wrote:
> > On 4/9/2021 9:22 AM, Oleksandr Mazur wrote:
> > > I'd like to discuss a possibility of handling devlink port parameters
> > > with devlink port pointer supplied.
> > >
On Wed, 7 Apr 2021 20:03:32 +0200 Andrea Mayer wrote:
> This patch provides counters for SRv6 Behaviors as defined in [1], section
> 6. For each SRv6 Behavior instance, the counters defined in [1] are:
>
> - the total number of packets that have been correctly processed;
> - the total amount
On Wed, 7 Apr 2021 09:25:28 -0700 Alexander Duyck wrote:
> On Wed, Apr 7, 2021 at 8:37 AM Jakub Kicinski wrote:
> >
> > On Wed, 7 Apr 2021 08:00:53 +0200 Oleksandr Natalenko wrote:
> > > Thanks for the effort, but reportedly [1] it made no difference,
> > > unf
On Wed, 7 Apr 2021 08:00:53 +0200 Oleksandr Natalenko wrote:
> Thanks for the effort, but reportedly [1] it made no difference,
> unfortunately.
>
> [1] https://bugzilla.kernel.org/show_bug.cgi?id=212573#c8
The only other option I see is that somehow the NAPI has no rings.
diff --git
)
> Cc: # 5.10.x
> Cc: Michal Kubecek
> Signed-off-by: Wong Vee Khee
Reviewed-by: Jakub Kicinski
On Tue, 6 Apr 2021 14:36:19 +0200 Oleksandr Natalenko wrote:
> Hello.
>
> I've raised this here [1] first, but was suggested to engage igb devs,
> so here we are.
>
> I'm experiencing the following woes while using netconsole regularly:
>
> ```
> [22038.710800] [ cut here
On Tue, 6 Apr 2021 11:18:13 +0800 Qiheng Lin wrote:
> Eliminate the following coccicheck warning:
> drivers/net/netdevsim/fib.c:569:2-3: Unneeded semicolon
>
> Signed-off-by: Qiheng Lin
Acked-by: Jakub Kicinski
ic packet generated using pktgen script
> 'pktgen_sample03_burst_single_flow.sh'.
>
> v3: Added 'nq->trans_start = jiffies' to avoid TX time-out as we are
> sharing TX queue between slow path and XDP. Thanks to Jakub Kicinski
> for pointing out.
>
&
On Tue, 30 Mar 2021 10:49:48 +0800 Ong Boon Leong wrote:
> + __netif_tx_lock(nq, cpu);
> + res = stmmac_xdp_xmit_xdpf(priv, queue, xdpf);
> + if (res == STMMAC_XDP_TX) {
> + stmmac_flush_tx_descriptors(priv, queue);
> + stmmac_tx_timer_arm(priv, queue);
> +
On Tue, 30 Mar 2021 10:49:47 +0800 Ong Boon Leong wrote:
> + if (!skb) {
> + dma_sync_single_for_cpu(priv->device, buf->addr,
> + buf1_len, dma_dir);
> +
> + xdp.data = page_address(buf->page) +
freed.
>
> Fixes: bcf0cafab44fd ("nfp: split out common control message handling code")
> Signed-off-by: Lv Yunlong
Reviewed-by: Jakub Kicinski
gt; > > can avoid one of the checkpatch complaints.
> > >
> > > Internally we are fine to use the ENOTSUPP.
> > > Checkpatch false positives there.
> > >
> > > I doubt we need this change. Rather checkpatch should rephrase this to
> > > point
et per-queue coalesce setting:-
> $ ethtool --per-queue queue_mask --coalesce \
> [rx-usecs N] [rx-frames M] [tx-usecs P] [tx-frames Q]
>
> Signed-off-by: Ong Boon Leong
Acked-by: Jakub Kicinski
> + if (queue < tx_cnt) {
> + ec->tx_coalesce_usecs = p
On Wed, 17 Mar 2021 12:07:12 +0530 sundeep subbaraya wrote:
> On Tue, Mar 16, 2021 at 10:53 PM Jakub Kicinski wrote:
> >
> > On Tue, 16 Mar 2021 14:57:08 +0530 Hariprasad Kelam wrote:
> > > From: Subbaraya Sundeep
> > >
> > > TOS overlaps with DMAC fie
On Tue, 16 Mar 2021 05:42:37 -0700 Jarvis Jiang wrote:
> drivers/bus/mhi/devices/mhi_netdev.c | 1830 +
There's already a drivers/net/mhi/
Please make sure the drivers live in their respective subsystem.
Virtio drivers don't sit under drivers/virtio, and most certainly not
On Tue, 16 Mar 2021 20:18:22 +0800 Voon Weifeng wrote:
> From: Ong Boon Leong
>
> Intel mgbe controller supports multi-vector interrupts:
> msi_rx_vec0,2,4,6,8,10,12,14
> msi_tx_vec1,3,5,7,9,11,13,15
> msi_sfty_ue_vec 26
> msi_sfty_ce_vec 27
> msi_lpi_vec 28
> msi_mac_vec
On Tue, 16 Mar 2021 20:18:21 +0800 Voon Weifeng wrote:
> From: Ong Boon Leong
>
> Now we introduce MSI interrupt service routines and hook these routines
> up if stmmac_open() sees valid irq line being requested:-
>
> stmmac_mac_interrupt():- MAC (dev->irq), WOL (wol_irq), LPI (lpi_irq)
>
On Tue, 16 Mar 2021 20:18:20 +0800 Voon Weifeng wrote:
> + if (unlikely(!dev)) {
> + netdev_err(priv->dev, "%s: invalid dev pointer\n", __func__);
> + return IRQ_NONE;
> + }
Where did this check come from? Please avoid defensive programming
in the kernel unless
On Mon, 15 Mar 2021 23:28:08 -0700 Arjun Roy wrote:
> On Mon, Mar 15, 2021 at 11:22 PM Arjun Roy wrote:
> >
> > On Mon, Mar 15, 2021 at 9:29 PM Shakeel Butt wrote:
> > >
> > > On Mon, Mar 15, 2021 at 9:20 PM Arjun Roy wrote:
> [...]
> > > [...]
> [...]
> [...]
> > >
> > > It is
On Tue, 16 Mar 2021 10:57:36 +0800 Yejune Deng wrote:
> proc_creat_seq() that directly take a struct seq_operations,
> and deal with network namespaces in ->open.
>
> Signed-off-by: Yejune Deng
Looks equivalent to me:
Reviewed-by: Jakub Kicinski
On Tue, 16 Mar 2021 23:33:40 +0530 sundeep subbaraya wrote:
> On Tue, Mar 16, 2021 at 10:53 PM Jakub Kicinski wrote:
> >
> > On Tue, 16 Mar 2021 14:57:07 +0530 Hariprasad Kelam wrote:
> > > From: Subbaraya Sundeep
> > >
> > > Memory for driver p
On Tue, 16 Mar 2021 14:57:08 +0530 Hariprasad Kelam wrote:
> From: Subbaraya Sundeep
>
> TOS overlaps with DMAC field in mcam search key and hence installing
> rules for TX side are failing. Hence remove TOS field from TX profile.
Could you clarify what "installing rules is failing" means?
On Tue, 16 Mar 2021 14:57:07 +0530 Hariprasad Kelam wrote:
> From: Subbaraya Sundeep
>
> Memory for driver private structure rvu_devlink is
> also allocated during devlink_alloc. Hence use
> the allocated memory by devlink_alloc and access it
> by devlink_priv call.
>
> Fixes:
On Tue, 16 Mar 2021 14:57:05 +0530 Hariprasad Kelam wrote:
> From: Subbaraya Sundeep
>
> In the ETHTOOL_GRXCLSRLALL ioctl ethtool uses
> below structure to read number of rules from the driver.
>
> struct ethtool_rxnfc {
> __u32 cmd;
> __u32
On Tue, 16 Mar 2021 06:14:08 +0800 mohammad.athari.ism...@intel.com
wrote:
> From: Voon Weifeng
>
> Enabled EST related interrupts as below:
> 1) Constant Gate Control Error (CGCE)
> 2) Head-of-Line Blocking due to Scheduling (HLBS)
> 3) Head-of-Line Blocking due to Frame Size (HLBF).
> 4) Base
On Mon, 15 Mar 2021 14:44:48 +0800 Ong Boon Leong wrote:
> Extending the driver to support per-queue RX and TX coalesce settings in
> order to support below commands:
>
> To show per-queue coalesce setting:-
> $ ethtool --per-queue queue_mask --show-coalesce
>
> To set per-queue coalesce
On Mon, 15 Mar 2021 16:11:40 +0100 Álvaro Fernández Rojas wrote:
> Add device tree support to b53_mmap.c while keeping platform devices support.
>
> Signed-off-by: Álvaro Fernández Rojas
> ---
> v2: add change suggested by Florian Fainelli (less "OF-centric") and replace
> brcm,ports property
On Mon, 15 Mar 2021 09:38:57 + Alexander Lobakin wrote:
> From: Vladimir Oltean
> Date: Sun, 14 Mar 2021 23:04:53 +0200
>
> > On Sun, Mar 14, 2021 at 11:11:32AM +, Alexander Lobakin wrote:
> > > Caught by the text editor. Fix it separately from the actual changes.
> > >
> > >
On Mon, 15 Mar 2021 11:10:18 +0800 Yunsheng Lin wrote:
> @@ -606,6 +623,11 @@ static const u8 prio2band[TC_PRIO_MAX + 1] = {
> */
> struct pfifo_fast_priv {
> struct skb_array q[PFIFO_FAST_BANDS];
> +
> + /* protect against data race between enqueue/dequeue and
> + * qdisc->empty
On Sat, 13 Mar 2021 22:21:28 +0530 Chinmayi Shetty wrote:
> Signed-off-by: Chinmayi Shetty
> ---
> drivers/net/gtp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c
> index efe5247d8c42..79998f4394e5 100644
> --- a/drivers/net/gtp.c
laborate on the fairly simple
> integration.
Nacked-by: Jakub Kicinski
Please move on.
On Mon, 15 Mar 2021 16:04:24 +0100 Steen Hegelund wrote:
> Hi Kishon, Vinod, Andrew, Jacub, and David,
>
> I just wanted to know if you think that the Generic PHY subsystem might
> not be the right place for this Ethernet SerDes PHY driver after all.
>
> Originally I chose this subsystem for
On Thu, 11 Mar 2021 16:28:47 -0800 Xie He wrote:
> On Thu, Mar 11, 2021 at 4:10 PM Jakub Kicinski wrote:
> >
> > And the "noqueue" queue is there because it's on top of hdlc_fr.c
> > somehow or some out of tree driver? Or do you install it manually?
>
On Thu, 11 Mar 2021 15:13:01 -0800 Xie He wrote:
> On Thu, Mar 11, 2021 at 2:52 PM Jakub Kicinski wrote:
> >
> > Normally driver's ndo_stop() calls netif_tx_disable() which takes TX
> > locks, so unless your driver is lockless (LLTX) there should be no xmit
> > calls
On Thu, 11 Mar 2021 13:12:25 -0800 Xie He wrote:
> On Thu, Mar 11, 2021 at 12:43 PM Jakub Kicinski wrote:
> >
> > Is this a theoretical issues or do you see a path where it triggers?
> >
> > Who are the callers sending frames to a device which went down?
>
&g
On Wed, 10 Mar 2021 23:23:09 -0800 Xie He wrote:
> There are two "netif_running" checks in this driver. One is in
> "lapbeth_xmit" and the other is in "lapbeth_rcv". They serve to make
> sure that the LAPB APIs called in these functions are called before
> "lapb_unregister" is called by the
On Thu, 11 Mar 2021 15:11:01 +0800 Jiapeng Chong wrote:
> Fix the following coccicheck warnings:
>
> ./drivers/net/netdevsim/fib.c:874:5-8: Unneeded variable: "err". Return
> "0" on line 889.
>
> Reported-by: Abaci Robot
> Signed-off-by: Jiapeng Chong
Reviewed-by: Jakub Kicinski
On Thu, 11 Mar 2021 18:43:27 +0200 stef...@marvell.com wrote:
> According to Armada SoC architecture and design, all the PPv2 ports
> which are populated on the same communication processor silicon die
> (CP11x) share the same Classifier and Parser engines.
>
> Armada is an embedded platform and
On Wed, 10 Mar 2021 14:12:43 -0800 Florian Fainelli wrote:
> phydev::dev_flags contains a bitmask of configuration bits requested by
> the consumer of a PHY device (Ethernet MAC or switch) towards the PHY
> driver. Since these flags are often used for requesting LED or other
> type of
On Mon, 8 Mar 2021 21:59:27 +0100 Loic Poulain wrote:
> ---
> v2: update copyright (2021)
Please look again at my reply to your v1.
On Mon, 8 Mar 2021 19:41:02 +0100 Álvaro Fernández Rojas wrote:
> This controller is present on BCM6318, BCM6328, BCM6362, BCM6368 and BCM63268
> SoCs.
>
> Signed-off-by: Álvaro Fernández Rojas
make[2]: *** Deleting file 'Module.symvers'
ERROR: modpost: missing MODULE_LICENSE() in
On Mon, 8 Mar 2021 19:40:51 +0100 Loic Poulain wrote:
> The MHI WWWAN control driver allows MHI Qcom based modems to expose
> different modem control protocols to userspace, so that userspace
> modem tools or daemon (e.g. ModemManager) can control WWAN config
> and state (APN config, SMS,
On Fri, 5 Mar 2021 11:07:08 -0800 Don Bollinger wrote:
> Acknowledging your objections, I nonetheless request that optoe be accepted
> into upstream as an eeprom driver in drivers/misc/eeprom. It is a
> legitimate driver, with a legitimate user community, which deserves the
> benefits of being
On Tue, 02 Mar 2021 08:04:20 +0100 Martin Schiller wrote:
> On 2021-03-01 09:56, Xie He wrote:
> > On Sun, Feb 28, 2021 at 10:56 PM Martin Schiller wrote:
> >> I mean the change from only one hdlc interface to both hdlc and
> >> hdlc_x25.
> >>
> >> I can't estimate how many users are out there
On Tue, 2 Mar 2021 12:55:47 +0100 Dmitry Vyukov wrote:
> On Tue, Mar 2, 2021 at 10:06 AM Hillf Danton wrote:
> > On Mar 2, 2021 at 16:40 Dmitry Vyukov wrote:
> > >I hoped this would get at least into 5.12. syzbot can't start testing
> > >arm32 because of this.
FWIW the submission never got
On Sun, 28 Feb 2021 19:58:17 +0300 Alexey Dobriyan wrote:
> From c17ac63e1334c742686cd411736699c1d34d45a7 Mon Sep 17 00:00:00 2001
> From: Alexey Dobriyan
> Date: Wed, 10 Feb 2021 21:07:45 +0300
> Subject: [PATCH 01/11] pragma once: delete include/linux/atm_suni.h
>
> This file has been empty
On Sun, 28 Feb 2021 18:14:46 + Alexander Lobakin wrote:
> > [1] WARNING in __alloc_pages_nodemask+0x5f8/0x730 mm/page_alloc.c:5014
> > Call Trace:
> > __alloc_pages include/linux/gfp.h:511 [inline]
> > __alloc_pages_node include/linux/gfp.h:524 [inline]
> > alloc_pages_node
On Fri, 26 Feb 2021 15:44:42 +0800 Huazhong Tan wrote:
> From: Guangbin Huang
>
> If phy uses generic driver and autoneg is on, enter command
> "ethtool -s eth0 speed 50" will not change phy speed actually, but
> command "ethtool eth0" shows speed is 50Mb/s because phydev->speed
> has been set
1 - 100 of 2080 matches
Mail list logo
