Re: [PATCH] remoteproc: st: Use device_get_match_data()

2023-10-10 Thread Patrice CHOTARD
onfig = (struct st_rproc_config *)match->data; > + ddata->config = (struct st_rproc_config *)device_get_match_data(dev); > + if (!ddata->config) > + goto free_rproc; > > platform_set_drvdata(pdev, rproc); > Reviewed-by: Patrice Chotard Thanks Patrice

Re: linux-next: build warning after merge of the spi tree

2021-04-20 Thread Patrice CHOTARD
Hi Mark I will send a patch to fix this warning, sorry for that. Patrice. On 4/20/21 5:48 AM, Stephen Rothwell wrote: > Hi all, > > After merging the spi tree, today's linux-next build (x86_64 allmodconfig) > produced this warning: > > In file included from include/linux/printk.h:409, >

Re: [Linux-stm32] [RESEND PATCH 0/3] MAINTAINERS: update STMicroelectronics email

2021-04-12 Thread Patrice CHOTARD
On 4/12/21 3:48 PM, Arnd Bergmann wrote: > On Mon, Apr 12, 2021 at 12:19 PM Patrice CHOTARD > wrote: >> >> Hi >> >> I think this series has been forgotten, any chance to see it merged into >> v5.13 ? > > It's in -rc7, but it appears that

Re: [Linux-stm32] [RESEND PATCH 0/3] MAINTAINERS: update STMicroelectronics email

2021-04-12 Thread Patrice CHOTARD
Hi I think this series has been forgotten, any chance to see it merged into v5.13 ? Thanks Patrice On 3/11/21 4:24 PM, Patrice CHOTARD wrote: > Hi > > It's just a gentle reminder to not forgot this series. > > Thanks > > Patrice > > On 2/16/21 8:49 AM, patric

Re: [PATCH -next] mmc: sdhci-st: Remove unnecessary error log

2021-04-09 Thread Patrice CHOTARD
n(>dev, "FlashSS Top Dly registers not available"); > + if (IS_ERR(pdata->top_ioaddr)) > pdata->top_ioaddr = NULL; > - } > > pltfm_host->clk = clk; > pdata->icnclk = icnclk; > Reviewed-by: Patrice Chotard Thanks Patrice

Re: [PATCH v3 4/7] clk: st: clkgen-pll: embed soc clock outputs within compatible data

2021-03-31 Thread Patrice CHOTARD
lkgen_c32_pll1_setup); > > +static void __init clkgen_c32_pll1_c0_setup(struct device_node *np) > +{ > + clkgen_c32_pll_setup(np, > + (struct clkgen_pll_data_clks *) _pll3200c32_c1_data); > +} > +CLK_OF_DECLARE(c32_pll1_c0, "st,clkgen-pll1-c0", clkgen_c32_pll1_c0_setup); > + > static void __init clkgen_c32_plla9_setup(struct device_node *np) > { > clkgen_c32_pll_setup(np, > - (struct clkgen_pll_data *) _pll3200c32_407_a9); > + (struct clkgen_pll_data_clks *) _pll3200c32_407_a9_data); > } > CLK_OF_DECLARE(c32_plla9, "st,stih407-clkgen-plla9", clkgen_c32_plla9_setup); > > static void __init clkgen_c28_plla9_setup(struct device_node *np) > { > clkgen_c32_pll_setup(np, > - (struct clkgen_pll_data *) _pll4600c28_418_a9); > + (struct clkgen_pll_data_clks *) _pll4600c28_418_a9_data); > } > CLK_OF_DECLARE(c28_plla9, "st,stih418-clkgen-plla9", clkgen_c28_plla9_setup); > Reviewed-by: Patrice Chotard Thanks

Re: [PATCH v3 6/7] clk: st: clkgen-fsyn: embed soc clock outputs within compatible data

2021-03-31 Thread Patrice CHOTARD
fs_data *) _fs660c32_D); > + st_of_quadfs_setup(np, > + (struct clkgen_quadfs_data_clks *) _fs660c32_D_data); > } > CLK_OF_DECLARE(quadfs660D, "st,quadfs", st_of_quadfs660D_setup); > + > +static void __init st_of_quadfs660D0_setup(struct device_node *np) > +{ > + st_of_quadfs_setup(np, > + (struct clkgen_quadfs_data_clks *) _fs660c32_D0_data); > +} > +CLK_OF_DECLARE(quadfs660D0, "st,quadfs-d0", st_of_quadfs660D0_setup); > + > +static void __init st_of_quadfs660D2_setup(struct device_node *np) > +{ > + st_of_quadfs_setup(np, > + (struct clkgen_quadfs_data_clks *) _fs660c32_D2_data); > +} > +CLK_OF_DECLARE(quadfs660D2, "st,quadfs-d2", st_of_quadfs660D2_setup); > + > +static void __init st_of_quadfs660D3_setup(struct device_node *np) > +{ > + st_of_quadfs_setup(np, > + (struct clkgen_quadfs_data_clks *) _fs660c32_D3_data); > +} > +CLK_OF_DECLARE(quadfs660D3, "st,quadfs-d3", st_of_quadfs660D3_setup); > Reviewed-by: Patrice Chotard Thanks

Re: [PATCH v3 1/7] clk: st: clkgen-pll: remove unused variable of struct clkgen_pll

2021-03-31 Thread Patrice CHOTARD
ndiv; > u32 idf; > - u32 odf; > u32 cp; > }; > > Reviewed-by: Patrice Chotard Thanks

Re: [PATCH v3 2/7] clk: st: flexgen: embed soc clock outputs within compatible data

2021-03-31 Thread Patrice CHOTARD
t;, }, > + { .name = "clk-st231-gp-1", }, > + { .name = "clk-st231-dmu", }, > + /* This clk needs to be on to keep bus interconnect alive */ > + { .name = "clk-icn-lmi", .flags = CLK_IS_CRITICAL }, > + { .name

Re: [RESEND PATCH 0/3] MAINTAINERS: update STMicroelectronics email

2021-03-11 Thread Patrice CHOTARD
Hi It's just a gentle reminder to not forgot this series. Thanks Patrice On 2/16/21 8:49 AM, patrice.chot...@foss.st.com wrote: > From: Patrice Chotard > > This series: > _ Update st.com to foss.st.com email for some maintainers. > _ Remove Vincent Abriou as STI/STM DRM d

Re: [RESEND PATCH 0/3] MAINTAINERS: update STMicroelectronics email

2021-03-11 Thread Patrice CHOTARD
Hi It's just a gentle reminder to not forgot this series. Thanks Patrice On 2/16/21 8:49 AM, patrice.chot...@foss.st.com wrote: > From: Patrice Chotard > > This series: > _ Update st.com to foss.st.com email for some maintainers. > _ Remove Vincent Abriou as STI/STM DRM d

Re: [PATCH 0/3] MAINTAINERS: update STMicroelectronics email

2021-02-15 Thread Patrice CHOTARD
Hi Arnd On 2/15/21 3:19 PM, Arnd Bergmann wrote: > On Mon, Feb 15, 2021 at 2:17 PM Patrice CHOTARD > wrote: >> >> Hi Arnd, Olof, Kevin >> >> What is the best way to get this series merged ? >> Do you pick it and apply it directly, or do we integrate it in the

Re: [PATCH 0/3] MAINTAINERS: update STMicroelectronics email

2021-02-15 Thread Patrice CHOTARD
Hi Arnd, Olof, Kevin What is the best way to get this series merged ? Do you pick it and apply it directly, or do we integrate it in the next STM32 pull request ? Thanks Patrice On 2/1/21 11:00 AM, patrice.chot...@foss.st.com wrote: > From: Patrice Chotard > > This series: >

Re: [PATCH] ARM: sti: Fix spelling mistake in Kconfig "targetted" -> "targeted"

2020-12-17 Thread Patrice CHOTARD
les support for STMicroelectronics Digital Consumer > - Electronics family StiH407 parts, targetted at set-top-box > + Electronics family StiH407 parts, targeted at set-top-box > and other digital audio/video applications using Flattened Device > Trees. > Reviewed-by: Patrice Chotard Thanks Patrice

Re: [PATCH v3 07/10] arm: dts: stih407-family: Harmonize DWC USB3 DT nodes name

2020-12-09 Thread Patrice CHOTARD
status = "disabled"; > > - dwc3: dwc3@990 { > + dwc3: usb@990 { > compatible = "snps,dwc3"; > reg = <0x0990 0x10>; > interrupts = IRQ_TYPE_LEVEL_HIGH>; Reviewed-by: Patrice Chotard Thanks Patrice

Re: [PATCH v2 0/2] arm: sti: LL_UART updates & STiH418 addition

2020-11-19 Thread Patrice CHOTARD
After discussion with Alain, he will take care to submit them to Russell's patch tracker. Thanks On 11/19/20 10:57 AM, Patrice CHOTARD wrote: > Hi Linus > > On 11/19/20 9:26 AM, Linus Walleij wrote: >> On Thu, Nov 19, 2020 at 9:08 AM Patrice CHOTARD >> wrote: >&

Re: [PATCH v2 0/2] arm: sti: LL_UART updates & STiH418 addition

2020-11-19 Thread Patrice CHOTARD
Hi Linus On 11/19/20 9:26 AM, Linus Walleij wrote: > On Thu, Nov 19, 2020 at 9:08 AM Patrice CHOTARD > wrote: > >> Is there any reason for this series not being merged ? > Did you put them into Russell's patch tracker as I asked? > I haven't seen them there. > htt

Re: [PATCH v2 0/2] arm: sti: LL_UART updates & STiH418 addition

2020-11-19 Thread Patrice CHOTARD
Hi Russell Is there any reason for this series not being merged ? Thanks Patrice On 8/30/20 9:57 PM, Alain Volmat wrote: > This serie update the STi Platform LL_UART code to rely on > DEBUG_UART_PHYS & DEBUG_UART_VIRT and add the STiH418 SoC support. > > Alain Volmat (2): > arm: use

Re: [PATCH] reset: sti: reset-syscfg: fix struct description warnings

2020-11-18 Thread Patrice CHOTARD
figuration registers. > + * struct syscfg_reset_controller - A reset controller which groups together > + * a set of related reset bits, which may be located in different system > + * configuration registers. > * > * @rst: base reset controller structure. > * @active_low: are the resets in this controller active low, i.e. clearing Reviewed-by: Patrice Chotard Thanks Patrice

Re: [PATCH v1 0/4] PM: Add dev_wakeup_path() helper

2020-11-18 Thread Patrice CHOTARD
Hi Rafael On 11/18/20 2:08 PM, Rafael J. Wysocki wrote: > On Fri, Nov 6, 2020 at 8:34 AM wrote: >> From: Patrice Chotard >> >> Add dev_wakeup_path() helper to avoid to spread >> dev->power.wakeup_path test in drivers. > OK > >> Cc: amelie.

Re: [PATCH 2/3] watchdog: st_lpc_wdt: remove unnecessary CONFIG_PM_SLEEP

2020-10-29 Thread Patrice CHOTARD
evice *dev)   |    ^~~ Can you add missing "__maybe unused"  attribute ? Thanks Patrice On 10/29/20 8:58 AM, Patrice CHOTARD wrote: > Hi Coiby > > On 10/29/20 8:53 AM, Coiby Xu wrote: >> SIMPLE_DEV_PM_OPS has already took good care of CONFIG_PM_CONFIG. >> >&

Re: [PATCH 2/3] watchdog: st_lpc_wdt: remove unnecessary CONFIG_PM_SLEEP

2020-10-29 Thread Patrice CHOTARD
LEEP > static int st_wdog_suspend(struct device *dev) > { > struct st_wdog *st_wdog = watchdog_get_drvdata(_wdog_dev); > @@ -285,7 +284,6 @@ static int st_wdog_resume(struct device *dev) > > return 0; > } > -#endif > > static SIMPLE_DEV_PM_OPS(st_wdog_p

Re: [PATCH v2 2/2] arm: sti LL_UART: add STiH418 SBC UART0 support

2020-10-06 Thread Patrice CHOTARD
TI81XXUART1 > default 0xfa022000 if DEBUG_TI81XXUART2 > @@ -1864,7 +1878,8 @@ config DEBUG_UART_VIRT > DEBUG_BCM63XX_UART || DEBUG_ASM9260_UART || \ > DEBUG_SIRFSOC_UART || DEBUG_DIGICOLOR_UA0 || \ > DEBUG_AT91_UART || DEBUG_STM32_UART || \ &g

Re: [PATCH v2 1/2] arm: use DEBUG_UART_PHYS and DEBUG_UART_VIRT for sti LL_UART

2020-10-06 Thread Patrice CHOTARD
-#ifndef DEBUG_LL_UART_BASE > -#error "DEBUG UART is not Configured" > -#endif > - > #define ASC_TX_BUF_OFF 0x04 > #define ASC_CTRL_OFF0x0c > #define ASC_STA_OFF 0x14 > @@ -37,8 +15,8 @@ > > > .macro addruart, rp, rv, tmp > - ldr \rp, =DEBUG_LL_UART_BASE @ physical base > - ldr \rv, =VIRT_ADDRESS(DEBUG_LL_UART_BASE) @ virt base > + ldr \rp, =CONFIG_DEBUG_UART_PHYS @ physical base > + ldr \rv, =CONFIG_DEBUG_UART_VIRT @ virt base > .endm > > .macro senduart,rd,rx Reviewed-by: Patrice Chotard Thanks Patrice

Re: [PATCH 4/7] usb: dwc3: convert to devm_platform_ioremap_resource_byname

2020-07-27 Thread Patrice CHOTARD
Hi Chunfeng On 7/22/20 9:51 AM, Chunfeng Yun wrote: > Use devm_platform_ioremap_resource_byname() to simplify code > > Cc: Patrice Chotard > Signed-off-by: Chunfeng Yun > --- > drivers/usb/dwc3/dwc3-st.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > &g

Re: [PATCH -next 11/13] hwrng: st - use devm_platform_ioremap_resource() to simplify code

2019-10-16 Thread Patrice CHOTARD
m_device *pdev) > if (!ddata) > return -ENOMEM; > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - base = devm_ioremap_resource(>dev, res); > + base = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(base)) > return PTR_ERR(base); > Reviewed-by: Patrice Chotard Thanks

Re: ARM: multi_v7_defconfig: Enable SPI_STM32_QSPI support

2019-07-31 Thread Patrice CHOTARD
29, 2019 at 3:55 PM wrote: >> From: Patrice Chotard >> >> Enable support for QSPI block on STM32 SoCs. >> >> Signed-off-by: Patrice Chotard >> --- >> arch/arm/configs/multi_v7_defconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> dif

Re: [PATCH 1/6] ARM: dts: STi: Switch to SPDX header

2019-06-14 Thread Patrice CHOTARD
tih418.dtsi b/arch/arm/boot/dts/stih418.dtsi > index 0efb3cd6a86e..f3f0a0e0f23c 100644 > --- a/arch/arm/boot/dts/stih418.dtsi > +++ b/arch/arm/boot/dts/stih418.dtsi > @@ -1,10 +1,7 @@ > +// SPDX-License-Identifier: GPL-2.0 > /* > * Copyright (C) 2014 STMicroelectronics Limited. > * Author: Peter Griffin > - * > - * This program is free software; you can redistribute it and/or modify > - * it under the terms of the GNU General Public License version 2 as > - * publishhed by the Free Software Foundation. > */ > #include "stih418-clock.dtsi" > #include "stih407-family.dtsi" Acked-by: Patrice Chotard Thanks

Re: [PATCH -next] usb: host: ehci-st: Remove set but not used variable 'ehci'

2019-06-03 Thread Patrice CHOTARD
> priv = hcd_to_ehci_priv(hcd); > - ehci = hcd_to_ehci(hcd); > > priv->phy = devm_phy_get(>dev, "usb"); > if (IS_ERR(priv->phy)) { > Acked-by: Patrice Chotard Thanks Patrice

Re: [PATCH -next] usb: host: ohci-st: Remove set but not used variable 'ohci'

2019-06-03 Thread Patrice CHOTARD
v = hcd_to_ohci_priv(hcd); > - ohci = hcd_to_ohci(hcd); > > priv->phy = devm_phy_get(>dev, "usb"); > if (IS_ERR(priv->phy)) { > Acked-by: Patrice Chotard Thanks

Re: [PATCH 3/5] pinctrl: st: fix leaked of_node references

2019-04-12 Thread Patrice CHOTARD
this function. > ./drivers/pinctrl/pinctrl-st.c:1199:2-8: ERROR: missing of_node_put; acquired > a node pointer with refcount incremented on line 1175, but without a > corresponding object release within this function. > > Signed-off-by: Wen Yang > Cc: Patrice Chotard >

Re: [PATCH 19/23] watchdog: st_lpc_wdt: Convert to use device managed functions

2019-04-10 Thread Patrice CHOTARD
t instead of > dereferencing it repeatedly > - Use devm_watchdog_register_driver() to register watchdog device > > Cc: Patrice Chotard > Signed-off-by: Guenter Roeck > --- > drivers/watchdog/st_lpc_wdt.c | 47 > --- > 1 file c

Re: [PATCH] watchdog: Convert to use devm_platform_ioremap_resource

2019-04-04 Thread Patrice CHOTARD
n Hilman > Cc: Matthias Brugger > Cc: Avi Fishman > Cc: Nancy Yuen > Cc: Brendan Higgins > Cc: Wan ZongShun > Cc: Michal Simek > Cc: Sylvain Lemieux > Cc: Kukjin Kim > Cc: Barry Song > Cc: Orson Zhai > Cc: Patrice Chotard > Cc: Maxime Coquelin > C

Re: [PATCH] USB: dwc3: add missing of_node_put()

2019-02-06 Thread Patrice CHOTARD
we also should release that reference. > This patch fixes those 2 issues. > > Signed-off-by: Wen Yang > Cc: Patrice Chotard > Cc: Felipe Balbi > Cc: Greg Kroah-Hartman > Cc: linux-arm-ker...@lists.infradead.org > Cc: linux-...@vger.kernel.org > Cc: linux-kernel@vger

Re: [PATCH] phy: Variable "val" in function miphy_osc_is_ready() could be uninitialized

2019-02-06 Thread Patrice CHOTARD
gmap, > + ret = regmap_read(miphy_dev->regmap, > miphy_phy->syscfg_reg[SYSCFG_STATUS], ); > + if (ret) > + return ret; > > if ((val & MIPHY_OSC_RDY) != MIPHY_OSC_RDY) > cpu_relax(); > Reviewed-by: Patrice Chotard Thanks

Re: [PATCH] dmaengine: st_fdma: use struct_size() in kzalloc()

2019-01-07 Thread Patrice CHOTARD
int i; > > - fdesc = kzalloc(sizeof(*fdesc) + > - sizeof(struct st_fdma_sw_node) * sg_len, GFP_NOWAIT); > + fdesc = kzalloc(struct_size(fdesc, node, sg_len), GFP_NOWAIT); > if (!fdesc) > return NULL; > > Acked-by: Patrice Chotard Thanks

[GIT PULL] STi SoC update for v4.21 round 1

2018-12-20 Thread Patrice CHOTARD
and boot_lock cleanup initiated by Russell King, .smp_prepare_cpus and .smp_boot_secondary STi callbacks must be reworked to keep secondary CPU's bringup. Patrice Chotard (1): ARM: sti: remove pen_release and boot_lock arch/arm

Re: [PATCH 1/1] ARM: STi: Restore secondary CPU's bringup

2018-12-19 Thread Patrice CHOTARD
On 12/19/18 12:28 PM, Russell King - ARM Linux wrote: > On Wed, Dec 19, 2018 at 10:31:35AM +0000, Patrice CHOTARD wrote: >> Hi Russell >> >> On 12/18/18 6:27 PM, Russell King - ARM Linux wrote: >>> On Tue, Dec 18, 2018 at 05:05:18PM +, Patrice CHOTARD wrote: >

Re: [PATCH 1/1] ARM: STi: Restore secondary CPU's bringup

2018-12-19 Thread Patrice CHOTARD
Hi Russell On 12/18/18 6:27 PM, Russell King - ARM Linux wrote: > On Tue, Dec 18, 2018 at 05:05:18PM +0000, Patrice CHOTARD wrote: >> Hi Russell >> >> On 12/18/18 4:52 PM, Russell King - ARM Linux wrote: >>> On Tue, Dec 18, 2018 at 03:48:13PM +0100, patrice.c

Re: [PATCH 1/1] ARM: STi: Restore secondary CPU's bringup

2018-12-18 Thread Patrice CHOTARD
Hi Russell On 12/18/18 4:52 PM, Russell King - ARM Linux wrote: > On Tue, Dec 18, 2018 at 03:48:13PM +0100, patrice.chot...@st.com wrote: >> From: Patrice Chotard >> >> Due to pen_release and boot_lock removal, secondary CPU's bringup >> was broken. Restore CPU's br

[GIT PULL] STi DT update for v4.20 round 1

2018-09-25 Thread Patrice CHOTARD
Hi Arnd, Kevin, Olof PLease consider this first round of STi dts update for v4.20 The following changes since commit 5b394b2ddf0347bef56e50c69a58773c94343ff3: Linux 4.19-rc1 (2018-08-26 14:11:59 -0700) are available in the git repository at:

[GIT PULL] STi DT update for v4.20 round 1

2018-09-25 Thread Patrice CHOTARD
Hi Arnd, Kevin, Olof PLease consider this first round of STi dts update for v4.20 The following changes since commit 5b394b2ddf0347bef56e50c69a58773c94343ff3: Linux 4.19-rc1 (2018-08-26 14:11:59 -0700) are available in the git repository at:

Re: [PATCH] pinctrl: Convert to using %pOFn instead of device_node.name

2018-09-03 Thread Patrice CHOTARD
olas Ferre > Cc: Alexandre Belloni > Cc: Heiko Stuebner > Cc: Tony Lindgren > Cc: Haojian Zhuang > Cc: Patrice Chotard > Cc: Barry Song > Cc: Maxime Coquelin > Cc: Alexandre Torgue > Cc: Maxime Ripard > Cc: Chen-Yu Tsai > Cc: linux-g...@vger.kernel.org >

Re: [PATCH] pinctrl: Convert to using %pOFn instead of device_node.name

2018-09-03 Thread Patrice CHOTARD
olas Ferre > Cc: Alexandre Belloni > Cc: Heiko Stuebner > Cc: Tony Lindgren > Cc: Haojian Zhuang > Cc: Patrice Chotard > Cc: Barry Song > Cc: Maxime Coquelin > Cc: Alexandre Torgue > Cc: Maxime Ripard > Cc: Chen-Yu Tsai > Cc: linux-g...@vger.kernel.org >

Re: [PATCH v2 3/3] ARM: dts: stm32: Fix DT dtc warnings for stm32f4

2018-08-07 Thread Patrice CHOTARD
Hi Rob On 08/07/2018 04:08 PM, Rob Herring wrote: > On Tue, Aug 7, 2018 at 6:55 AM wrote: >> >> From: Patrice Chotard >> >> Fix the following DT dtc warnings for stm32f429 and >> stm32f469 boards: >> >> Warning (node_name_chars_strict

Re: [PATCH v2 3/3] ARM: dts: stm32: Fix DT dtc warnings for stm32f4

2018-08-07 Thread Patrice CHOTARD
Hi Rob On 08/07/2018 04:08 PM, Rob Herring wrote: > On Tue, Aug 7, 2018 at 6:55 AM wrote: >> >> From: Patrice Chotard >> >> Fix the following DT dtc warnings for stm32f429 and >> stm32f469 boards: >> >> Warning (node_name_chars_strict

Re: [PATCH 1/3] ARM: dts: stm32: Fix DT dtc warnings for stm32h7

2018-08-07 Thread Patrice CHOTARD
I will send a v2 Thanks for reviewing ;-) Patrice On 08/07/2018 01:56 PM, Alexandre Torgue wrote: > Hi Patrice > > On 08/07/2018 01:38 PM, Alexandre Torgue wrote: >>> +    #address-cells = <1>; >>> +    #size-cells = <1>; >>> + >>>   clocks { >>>   clk_hse: clk-hse { >>>    

Re: [PATCH 1/3] ARM: dts: stm32: Fix DT dtc warnings for stm32h7

2018-08-07 Thread Patrice CHOTARD
I will send a v2 Thanks for reviewing ;-) Patrice On 08/07/2018 01:56 PM, Alexandre Torgue wrote: > Hi Patrice > > On 08/07/2018 01:38 PM, Alexandre Torgue wrote: >>> +    #address-cells = <1>; >>> +    #size-cells = <1>; >>> + >>>   clocks { >>>   clk_hse: clk-hse { >>>    

Re: [U-BOOT internal] ARM: dts: stm32: Add clk-lse node's label on stm32f429

2018-07-19 Thread Patrice CHOTARD
Sorry, don't take care about this patch, it was send using the wrong script Patrice On 07/19/2018 03:10 PM, patrice.chot...@st.com wrote: > From: Patrice Chotard > > Add missing clk_lse label for node clk-lse. > > Signed-off-by: Patrice Chotard > --- > arch/arm/boot/d

Re: [U-BOOT internal] ARM: dts: stm32: Add clk-lse node's label on stm32f429

2018-07-19 Thread Patrice CHOTARD
Sorry, don't take care about this patch, it was send using the wrong script Patrice On 07/19/2018 03:10 PM, patrice.chot...@st.com wrote: > From: Patrice Chotard > > Add missing clk_lse label for node clk-lse. > > Signed-off-by: Patrice Chotard > --- > arch/arm/boot/d

Re: [PATCH V2] ARM: STi: warn if scu mapping fails

2018-07-18 Thread Patrice CHOTARD
cholas Mc Guire > Link: http://lkml.org/lkml/2018/7/16/219 > Fixes: commit 65ebcc115889 ("ARM: sti: Add STiH415 SOC support") > --- > > V2: replacement of WARN_ON() by a meaningful pr_err as suggested by > Patrice CHOTARD . > > Problem was found by an expe

Re: [PATCH V2] ARM: STi: warn if scu mapping fails

2018-07-18 Thread Patrice CHOTARD
cholas Mc Guire > Link: http://lkml.org/lkml/2018/7/16/219 > Fixes: commit 65ebcc115889 ("ARM: sti: Add STiH415 SOC support") > --- > > V2: replacement of WARN_ON() by a meaningful pr_err as suggested by > Patrice CHOTARD . > > Problem was found by an expe

Re: [PATCH] ARM: STi: at least warn if of_iomap fails

2018-07-16 Thread Patrice CHOTARD
Hi Nicholas On 07/12/2018 05:48 PM, Nicholas Mc Guire wrote: > The call to of_iomap() is unchecked but scu_enable(), which the returned > address is passed on to, assumes a valid mapping. If the mapping is > invalid this could probably lead to undefined system state so at least > a warning should

Re: [PATCH] ARM: STi: at least warn if of_iomap fails

2018-07-16 Thread Patrice CHOTARD
Hi Nicholas On 07/12/2018 05:48 PM, Nicholas Mc Guire wrote: > The call to of_iomap() is unchecked but scu_enable(), which the returned > address is passed on to, assumes a valid mapping. If the mapping is > invalid this could probably lead to undefined system state so at least > a warning should

Re: [PATCH] mmc: sdhci-*: Don't emit error msg if sdhci_add_host() fails

2018-05-25 Thread Patrice CHOTARD
rs/mmc/host/sdhci-st.c > index c32daed0d418..8f95647195d9 100644 > --- a/drivers/mmc/host/sdhci-st.c > +++ b/drivers/mmc/host/sdhci-st.c > @@ -422,10 +422,8 @@ static int sdhci_st_probe(struct platform_device *pdev) > st_mmcss_cconfig(np, host); > > ret = sdhci_add_host(host); > - if (ret) { > - dev_err(>dev, "Failed sdhci_add_host\n"); > + if (ret) > goto err_out; > - } > > host_version = readw_relaxed((host->ioaddr + SDHCI_HOST_VERSION)); > > For drivers/mmc/host/sdhci-st.c: Acked-by: Patrice Chotard <patrice.chot...@st.com> Thanks

Re: [PATCH] mmc: sdhci-*: Don't emit error msg if sdhci_add_host() fails

2018-05-25 Thread Patrice CHOTARD
8..8f95647195d9 100644 > --- a/drivers/mmc/host/sdhci-st.c > +++ b/drivers/mmc/host/sdhci-st.c > @@ -422,10 +422,8 @@ static int sdhci_st_probe(struct platform_device *pdev) > st_mmcss_cconfig(np, host); > > ret = sdhci_add_host(host); > - if (ret) { > - dev_err(>dev, "Failed sdhci_add_host\n"); > + if (ret) > goto err_out; > - } > > host_version = readw_relaxed((host->ioaddr + SDHCI_HOST_VERSION)); > > For drivers/mmc/host/sdhci-st.c: Acked-by: Patrice Chotard Thanks

Re: [PATCH v2] rtc: st-lpc: add range

2018-05-23 Thread Patrice CHOTARD
gt; rtc->rtc_dev->ops = _rtc_ops; > + rtc->rtc_dev->range_max = U64_MAX; > + do_div(rtc->rtc_dev->range_max, rtc->clkrate); > > ret = rtc_register_device(rtc->rtc_dev); > if (ret) { > Acked-by: Patrice Chotard <patrice.chot...@st.com> Patrice

Re: [PATCH v2] rtc: st-lpc: add range

2018-05-23 Thread Patrice CHOTARD
_rtc_ops; > + rtc->rtc_dev->range_max = U64_MAX; > + do_div(rtc->rtc_dev->range_max, rtc->clkrate); > > ret = rtc_register_device(rtc->rtc_dev); > if (ret) { > Acked-by: Patrice Chotard Patrice

Re: [PATCH 1/2] rtc: st-lpc: fix possible race condition

2018-05-23 Thread Patrice CHOTARD
rn 0; > -} > - > #ifdef CONFIG_PM_SLEEP > static int st_rtc_suspend(struct device *dev) > { > @@ -325,7 +320,6 @@ static struct platform_driver st_rtc_platform_driver = { > .of_match_table = st_rtc_match, > }, > .probe = st_rtc_probe, > - .remove = st_rtc_remove, > }; > > module_platform_driver(st_rtc_platform_driver); > Acked-by: Patrice Chotard <patrice.chot...@st.com> Thanks Patrice

Re: [PATCH 1/2] rtc: st-lpc: fix possible race condition

2018-05-23 Thread Patrice CHOTARD
f CONFIG_PM_SLEEP > static int st_rtc_suspend(struct device *dev) > { > @@ -325,7 +320,6 @@ static struct platform_driver st_rtc_platform_driver = { > .of_match_table = st_rtc_match, > }, > .probe = st_rtc_probe, > - .remove = st_rtc_remove, > }; > > module_platform_driver(st_rtc_platform_driver); > Acked-by: Patrice Chotard Thanks Patrice

[GIT PULL] STi DT update for v4.18 round 1

2018-05-14 Thread Patrice CHOTARD
for 4.18: - Fix complain about IRQ_TYPE_NONE_usage Patrice Chotard (5): ARM: dts: stih407-family: Fix complain about IRQ_TYPE_NONE usage ARM: dts: stih407-pinctrl: Fix complain about IRQ_TYPE_NONE usage ARM: dts

[GIT PULL] STi DT update for v4.18 round 1

2018-05-14 Thread Patrice CHOTARD
for 4.18: - Fix complain about IRQ_TYPE_NONE_usage Patrice Chotard (5): ARM: dts: stih407-family: Fix complain about IRQ_TYPE_NONE usage ARM: dts: stih407-pinctrl: Fix complain about IRQ_TYPE_NONE usage ARM: dts

Re: [PATCH 53/61] tty: serial: simplify getting .drvdata

2018-04-20 Thread Patrice CHOTARD
_port *port = dev_get_drvdata(dev); > struct cdns_uart *cdns_uart = port->private_data; > > clk_disable(cdns_uart->uartclk); > @@ -1441,8 +1440,7 @@ static int __maybe_unused cdns_runtime_suspend(struct > device *dev) > > static int __maybe_unused cdns_runtime_resume(struct device *dev) > { > - struct platform_device *pdev = to_platform_device(dev); > - struct uart_port *port = platform_get_drvdata(pdev); > + struct uart_port *port = dev_get_drvdata(dev); > struct cdns_uart *cdns_uart = port->private_data; > > clk_enable(cdns_uart->pclk); > For st-asc: Acked-by: Patrice Chotard <patrice.chot...@st.com> Thanks

Re: [PATCH 53/61] tty: serial: simplify getting .drvdata

2018-04-20 Thread Patrice CHOTARD
struct cdns_uart *cdns_uart = port->private_data; > > clk_disable(cdns_uart->uartclk); > @@ -1441,8 +1440,7 @@ static int __maybe_unused cdns_runtime_suspend(struct > device *dev) > > static int __maybe_unused cdns_runtime_resume(struct device *dev) > { > - struct platform_device *pdev = to_platform_device(dev); > - struct uart_port *port = platform_get_drvdata(pdev); > + struct uart_port *port = dev_get_drvdata(dev); > struct cdns_uart *cdns_uart = port->private_data; > > clk_enable(cdns_uart->pclk); > For st-asc: Acked-by: Patrice Chotard Thanks

Re: [PATCH] ata: ahci-platform: add reset control support

2018-04-05 Thread Patrice CHOTARD
Hi Hans On 04/05/2018 03:27 PM, Hans de Goede wrote: > Hi, > > On 05-04-18 15:17, Patrice CHOTARD wrote: >> Hi Thierry >> >> On 04/05/2018 11:54 AM, Thierry Reding wrote: >>> On Fri, Mar 23, 2018 at 10:30:53AM +0900, Kunihiko Hayashi wrote: >>>>

Re: [PATCH] ata: ahci-platform: add reset control support

2018-04-05 Thread Patrice CHOTARD
Hi Hans On 04/05/2018 03:27 PM, Hans de Goede wrote: > Hi, > > On 05-04-18 15:17, Patrice CHOTARD wrote: >> Hi Thierry >> >> On 04/05/2018 11:54 AM, Thierry Reding wrote: >>> On Fri, Mar 23, 2018 at 10:30:53AM +0900, Kunihiko Hayashi wrote: >>>>

Re: [PATCH] ata: ahci-platform: add reset control support

2018-04-05 Thread Patrice CHOTARD
Hi Thierry On 04/05/2018 11:54 AM, Thierry Reding wrote: > On Fri, Mar 23, 2018 at 10:30:53AM +0900, Kunihiko Hayashi wrote: >> Add support to get and control a list of resets for the device >> as optional and shared. These resets must be kept de-asserted until >> the device is enabled. >> >>

Re: [PATCH] ata: ahci-platform: add reset control support

2018-04-05 Thread Patrice CHOTARD
Hi Thierry On 04/05/2018 11:54 AM, Thierry Reding wrote: > On Fri, Mar 23, 2018 at 10:30:53AM +0900, Kunihiko Hayashi wrote: >> Add support to get and control a list of resets for the device >> as optional and shared. These resets must be kept de-asserted until >> the device is enabled. >> >>

Re: linux-next: Signed-off-by missing for commit in the arm-soc tree

2018-03-23 Thread Patrice CHOTARD
On 03/22/2018 10:01 PM, Alexandre Belloni wrote: > On 16/03/2018 at 07:34:06 +0000, Patrice CHOTARD wrote: >> Hi Arnd, Stephen >> >> On 03/15/2018 10:06 PM, Arnd Bergmann wrote: >>> On Thu, Mar 15, 2018 at 9:56 PM, Stephen Rothwell <s...@canb.auug.org.au> >

Re: linux-next: Signed-off-by missing for commit in the arm-soc tree

2018-03-23 Thread Patrice CHOTARD
On 03/22/2018 10:01 PM, Alexandre Belloni wrote: > On 16/03/2018 at 07:34:06 +0000, Patrice CHOTARD wrote: >> Hi Arnd, Stephen >> >> On 03/15/2018 10:06 PM, Arnd Bergmann wrote: >>> On Thu, Mar 15, 2018 at 9:56 PM, Stephen Rothwell >>&g

Re: linux-next: Signed-off-by missing for commit in the arm-soc tree

2018-03-16 Thread Patrice CHOTARD
Hi Arnd, Stephen On 03/15/2018 10:06 PM, Arnd Bergmann wrote: > On Thu, Mar 15, 2018 at 9:56 PM, Stephen Rothwell > wrote: >> Hi all, >> >> Commit >> >>9a5f4879cd8d ("ARM: dts: stih4xx: Add missing #sound-dai-cells") >> >> is missing a Signed-off-by from its

Re: linux-next: Signed-off-by missing for commit in the arm-soc tree

2018-03-16 Thread Patrice CHOTARD
Hi Arnd, Stephen On 03/15/2018 10:06 PM, Arnd Bergmann wrote: > On Thu, Mar 15, 2018 at 9:56 PM, Stephen Rothwell > wrote: >> Hi all, >> >> Commit >> >>9a5f4879cd8d ("ARM: dts: stih4xx: Add missing #sound-dai-cells") >> >> is missing a Signed-off-by from its committer. > > Thanks for the

Re: [GIT PULL] STi DT update for v4.17 round 2

2018-03-15 Thread Patrice CHOTARD
Hi Arnd On 03/15/2018 03:59 PM, Arnd Bergmann wrote: > On Thu, Mar 15, 2018 at 10:06 AM, Patrice CHOTARD > <patrice.chot...@st.com> wrote: >> Hi Arnd, Kevin, Olof >> >> PLease consider this second round of STi dts update for v4.17 >> &

Re: [GIT PULL] STi DT update for v4.17 round 2

2018-03-15 Thread Patrice CHOTARD
Hi Arnd On 03/15/2018 03:59 PM, Arnd Bergmann wrote: > On Thu, Mar 15, 2018 at 10:06 AM, Patrice CHOTARD > wrote: >> Hi Arnd, Kevin, Olof >> >> PLease consider this second round of STi dts update for v4.17 >> >> The following changes since commit 0e04

[GIT PULL] STi DT update for v4.17 round 2

2018-03-15 Thread Patrice CHOTARD
Hi Arnd, Kevin, Olof PLease consider this second round of STi dts update for v4.17 The following changes since commit 0e04ce02e6a2ac30d21294d8bb2aeceb8489e52b: ARM: dts: STi: Remove unused clk_ext2f_a9 clock (2018-02-13 13:31:38 +0100) are available in the git repository at:

[GIT PULL] STi DT update for v4.17 round 2

2018-03-15 Thread Patrice CHOTARD
Hi Arnd, Kevin, Olof PLease consider this second round of STi dts update for v4.17 The following changes since commit 0e04ce02e6a2ac30d21294d8bb2aeceb8489e52b: ARM: dts: STi: Remove unused clk_ext2f_a9 clock (2018-02-13 13:31:38 +0100) are available in the git repository at:

Re: [RESEND PATCH v4 3/3] ARM: dts: STi: Remove console=ttyASN from bootargs for STi boards] ARM: dts: STi: Remove "console=ttyASN" from bootargs for STi boards

2018-03-14 Thread Patrice CHOTARD
Sorry I just noticed that the commit header is corrupted I will resend this patch Patrice On 03/14/2018 03:52 PM, patrice.chot...@st.com wrote: > From: Patrice Chotard <patrice.chot...@st.com> > > As serial interface is already specified into stdout-path property, > &quo

Re: [RESEND PATCH v4 3/3] ARM: dts: STi: Remove console=ttyASN from bootargs for STi boards] ARM: dts: STi: Remove "console=ttyASN" from bootargs for STi boards

2018-03-14 Thread Patrice CHOTARD
Sorry I just noticed that the commit header is corrupted I will resend this patch Patrice On 03/14/2018 03:52 PM, patrice.chot...@st.com wrote: > From: Patrice Chotard > > As serial interface is already specified into stdout-path property, > "console=ttyASN,115200&q

Re: [PATCH v4 3/3] ARM: dts: STi: Remove "console=ttyASN" from bootargs for STi boards

2018-03-14 Thread Patrice CHOTARD
Hi Greg On 03/14/2018 02:57 PM, Greg KH wrote: > On Wed, Mar 07, 2018 at 06:35:34PM +0100, patrice.chot...@st.com wrote: >> From: Patrice Chotard <patrice.chot...@st.com> >> >> As serial interface is already specified into stdout-path property, >> "co

Re: [PATCH v4 3/3] ARM: dts: STi: Remove "console=ttyASN" from bootargs for STi boards

2018-03-14 Thread Patrice CHOTARD
Hi Greg On 03/14/2018 02:57 PM, Greg KH wrote: > On Wed, Mar 07, 2018 at 06:35:34PM +0100, patrice.chot...@st.com wrote: >> From: Patrice Chotard >> >> As serial interface is already specified into stdout-path property, >> "console=ttyASN,115200" from boot

Re: [PATCH v3 04/10] otm

2018-03-13 Thread Patrice CHOTARD
Hi Yannick There is a problem with patch 4. I received two patches 04/10, this one and [PATCH v3 04/10] video: add support of panel OTM8009A. Patrice On 03/13/2018 02:50 PM, yannick fertre wrote: > --- > drivers/video/orisetech_otm8009a.c | 4 +++- > 1 file changed, 3 insertions(+), 1

Re: [PATCH v3 04/10] otm

2018-03-13 Thread Patrice CHOTARD
Hi Yannick There is a problem with patch 4. I received two patches 04/10, this one and [PATCH v3 04/10] video: add support of panel OTM8009A. Patrice On 03/13/2018 02:50 PM, yannick fertre wrote: > --- > drivers/video/orisetech_otm8009a.c | 4 +++- > 1 file changed, 3 insertions(+), 1

Re: [PATCH v3 10/10] board: Add STM32F769 SoC, discovery board support

2018-03-13 Thread Patrice CHOTARD
Hi Yannick You have forgotten the commit message Patrice On 03/13/2018 02:50 PM, yannick fertre wrote: > Signed-off-by: yannick fertre > --- > configs/stm32f769-disco_defconfig | 65 > +++ > 1 file changed, 65 insertions(+) >

Re: [PATCH v3 10/10] board: Add STM32F769 SoC, discovery board support

2018-03-13 Thread Patrice CHOTARD
Hi Yannick You have forgotten the commit message Patrice On 03/13/2018 02:50 PM, yannick fertre wrote: > Signed-off-by: yannick fertre > --- > configs/stm32f769-disco_defconfig | 65 > +++ > 1 file changed, 65 insertions(+) > create mode 100644

Re: [PATCH v2 07/10] video: add support of panel rm68200

2018-03-13 Thread Patrice CHOTARD
Hi yannick On 03/02/2018 04:44 PM, yannick fertre wrote: > Support for Raydium rm68200 720p dsi 2dl video mode panel. > > Signed-off-by: yannick fertre > --- > drivers/video/Kconfig | 8 + > drivers/video/Makefile | 1 + >

Re: [PATCH v2 07/10] video: add support of panel rm68200

2018-03-13 Thread Patrice CHOTARD
Hi yannick On 03/02/2018 04:44 PM, yannick fertre wrote: > Support for Raydium rm68200 720p dsi 2dl video mode panel. > > Signed-off-by: yannick fertre > --- > drivers/video/Kconfig | 8 + > drivers/video/Makefile | 1 + > drivers/video/raydium-rm68200.c | 329 >

Re: [PATCH v2 06/10] video: add support of STM32 MIPI DSI controller driver

2018-03-13 Thread Patrice CHOTARD
Hi yannick On 03/02/2018 04:44 PM, yannick fertre wrote: > Add the STM32 DSI controller driver that uses the Synopsys DesignWare > MIPI DSI host controller bridge. > > Signed-off-by: yannick fertre > --- > drivers/video/stm32/Kconfig | 10 + >

Re: [PATCH v2 06/10] video: add support of STM32 MIPI DSI controller driver

2018-03-13 Thread Patrice CHOTARD
Hi yannick On 03/02/2018 04:44 PM, yannick fertre wrote: > Add the STM32 DSI controller driver that uses the Synopsys DesignWare > MIPI DSI host controller bridge. > > Signed-off-by: yannick fertre > --- > drivers/video/stm32/Kconfig | 10 + > drivers/video/stm32/Makefile| 1 + >

Re: [PATCH v2 04/10] video: add support of panel OTM8009A

2018-03-13 Thread Patrice CHOTARD
Hi Yannick On 03/02/2018 04:44 PM, yannick fertre wrote: > Support for Orise Tech otm8009a 480p dsi 2dl video mode panel. > > Signed-off-by: yannick fertre > --- > drivers/video/Kconfig | 8 + > drivers/video/Makefile | 1 + >

Re: [PATCH v2 04/10] video: add support of panel OTM8009A

2018-03-13 Thread Patrice CHOTARD
Hi Yannick On 03/02/2018 04:44 PM, yannick fertre wrote: > Support for Orise Tech otm8009a 480p dsi 2dl video mode panel. > > Signed-off-by: yannick fertre > --- > drivers/video/Kconfig | 8 + > drivers/video/Makefile | 1 + > drivers/video/orisetech_otm8009a.c

Re: [PATCH v2 02/10] video: stm32: stm32_ltdc: update debug log

2018-03-13 Thread Patrice CHOTARD
Hi Yannick On 03/02/2018 04:44 PM, yannick fertre wrote: > Replace macro debug by pr_error, pr_warn or pr_info. > > Signed-off-by: yannick fertre > --- > drivers/video/stm32/stm32_ltdc.c | 62 > > 1 file changed, 31

Re: [PATCH v2 02/10] video: stm32: stm32_ltdc: update debug log

2018-03-13 Thread Patrice CHOTARD
Hi Yannick On 03/02/2018 04:44 PM, yannick fertre wrote: > Replace macro debug by pr_error, pr_warn or pr_info. > > Signed-off-by: yannick fertre > --- > drivers/video/stm32/stm32_ltdc.c | 62 > > 1 file changed, 31 insertions(+), 31 deletions(-) >

Re: [PATCH v2 01/10] video: stm32: stm32_ltdc: add bridge to display controller

2018-03-13 Thread Patrice CHOTARD
Hi Yannick On 03/02/2018 04:44 PM, yannick fertre wrote: > Manage a bridge insert between the display controller & a panel. > > Signed-off-by: yannick fertre > --- > drivers/video/stm32/stm32_ltdc.c | 107 > ++- > 1 file changed, 71

Re: [PATCH v2 01/10] video: stm32: stm32_ltdc: add bridge to display controller

2018-03-13 Thread Patrice CHOTARD
Hi Yannick On 03/02/2018 04:44 PM, yannick fertre wrote: > Manage a bridge insert between the display controller & a panel. > > Signed-off-by: yannick fertre > --- > drivers/video/stm32/stm32_ltdc.c | 107 > ++- > 1 file changed, 71 insertions(+), 36

Re: [PATCH v2 10/10] board: Add STM32F769 SoC, discovery board support

2018-03-13 Thread Patrice CHOTARD
Hi Yannick On 03/02/2018 04:44 PM, yannick fertre wrote: > Signed-off-by: yannick fertre Can you add a commit message explaining why you add a specific defconfig for this board. FYI, previously, the same defconfig was used for all STM32F7 boards (ie

Re: [PATCH v2 10/10] board: Add STM32F769 SoC, discovery board support

2018-03-13 Thread Patrice CHOTARD
Hi Yannick On 03/02/2018 04:44 PM, yannick fertre wrote: > Signed-off-by: yannick fertre Can you add a commit message explaining why you add a specific defconfig for this board. FYI, previously, the same defconfig was used for all STM32F7 boards (ie /stm32f746-disco_defconfig). You will also

Re: [PATCH v3 1/3] ARM: dts: STi: Fix aliases property name for STi boards

2018-03-07 Thread Patrice CHOTARD
Hi Rob On 03/07/2018 05:15 PM, Rob Herring wrote: > On Wed, Mar 7, 2018 at 2:49 AM, <patrice.chot...@st.com> wrote: >> From: Patrice Chotard <patrice.chot...@st.com> >> >> Update serial aliases from "ttyASN" to more common "serialN". >>

Re: [PATCH v3 1/3] ARM: dts: STi: Fix aliases property name for STi boards

2018-03-07 Thread Patrice CHOTARD
Hi Rob On 03/07/2018 05:15 PM, Rob Herring wrote: > On Wed, Mar 7, 2018 at 2:49 AM, wrote: >> From: Patrice Chotard >> >> Update serial aliases from "ttyASN" to more common "serialN". >> >> Since dtc v1.4.6-9-gaadd0b65c987, aliases proper

Re: [PATCH v2 0/6] Add mmc support for STM32F7 boards

2018-03-07 Thread Patrice CHOTARD
Hi Lee On 03/07/2018 09:35 AM, Lee Jones wrote: > On Mon, 05 Mar 2018, Alexandre Torgue wrote: > >> Hi Patrice, >> >> On 03/01/2018 11:53 AM, patrice.chot...@st.com wrote: >>> From: Patrice Chotard <patrice.chot...@st.com> >>> >>> This ser

Re: [PATCH v2 0/6] Add mmc support for STM32F7 boards

2018-03-07 Thread Patrice CHOTARD
Hi Lee On 03/07/2018 09:35 AM, Lee Jones wrote: > On Mon, 05 Mar 2018, Alexandre Torgue wrote: > >> Hi Patrice, >> >> On 03/01/2018 11:53 AM, patrice.chot...@st.com wrote: >>> From: Patrice Chotard >>> >>> This series adds : >>>

  1   2   3   4   5   >