Hi Claudiu
One more reply to this patch...
On Wed, Feb 27, 2019 at 04:24:16PM +, claudiu.bez...@microchip.com wrote:
> From: Claudiu Beznea
>
> SAM9x60 LCD Controller has no option to select clock source as previous
> controllers have. To be able to use the same driver even for this LCD
>
r with ATMEL_HLCDC_CLKSEL - fine.
But cfg is directly assigned.
If cfg was bitwise or the ATMEL_HLCDC_CLKSEL value then the code was prepared
to have extra flags added above these lines.
Only a small change and no functional difference.
With or without this change:
Reviewed-by: Sam Ravnborg
Hi Alexandre.
> > >
> > > These patches adds support for SAM9X60's LCD controller.
> > Can you elaborate a little more which chips that are relevant.
> > To be able to look into the right data-sheet, while reviewing.
> > Link to data-sheet would be nice too.
> >
>
> sam9x60 is the chip name
Hi Claudiu
On Wed, Feb 27, 2019 at 04:24:11PM +, claudiu.bez...@microchip.com wrote:
> From: Claudiu Beznea
>
> Hi,
>
> These patches adds support for SAM9X60's LCD controller.
Can you elaborate a little more which chips that are relevant.
To be able to look into the right data-sheet,
ni
Reviewed-by: Sam Ravnborg
.
>
> [1]: https://patchwork.kernel.org/patch/9632347/
>
> Signed-off-by: Masahiro Yamada
Patch looks good:
Reviewed-by: Sam Ravnborg
> ---
>
> I put all gpu/drm changes into a single patch because
> they are trivial conversion.
>
> Please let me know if I nee
g
> Aries based phones.
>
> Signed-off-by: Paweł Chmiel
> Reviewed-by: Sam Ravnborg
> Reviewed-by: Andrzej Hajda
I took a last look at the driver.
Everything looks good to me now, and I consider this driver ready to be applied.
Sam
Hi Guido.
Thanks for this patch.
See below for some review feedback.
The driver includes the "allpixelson_set" debugfs feature.
Is this a debug leftover, or is there a real need for this?
If this is a debug feature that is no logner needed then no
need to add it to the mainline driver.
Hi Peter.
Driver looks to be in good shape now.
With the few comments below addressed you can add my:
Reviewed-by: Sam Ravnborg
Sam
On Fri, Feb 22, 2019 at 03:16:18PM +0200, Peter Ujfalusi wrote:
> The panel is similar to OSD101T2045-53TS (which is handled by panel-simple)
> wi
Hi Peter.
Always good to see that feedback input is used.
> OK.
>
> >> +
> >> + return 0;
> >> +}
> >> +
> >> +static void osd101t2587_panel_shutdown(struct mipi_dsi_device *dsi)
> >> +{
> >> + struct osd101t2587_panel *osd101t2587 = mipi_dsi_get_drvdata(dsi);
> >> +
> > Maybe call
Hi Peter.
On Wed, Feb 20, 2019 at 12:39:11PM +0200, Peter Ujfalusi wrote:
> Hi Sam,
>
> On 15/02/2019 20.07, Sam Ravnborg wrote:
> >> +#include
> >> +#include
> >> +#include
> >> +#include
> >> +
> >> +#include
> > Ple
Hi Thierry
> Pleas let me know if you any further comments on this?
No further comments from my side, and I consider it
ready to apply.
Sam
Hi Peter.
Good with more panel drivers.
Some comments in the following, please do not blindly follow them but
check that this is OK.
Sam
On Fri, Feb 15, 2019 at 04:03:15PM +0200, Peter Ujfalusi via dri-devel wrote:
> The panel is similar to OSD101T2045-53TS (which is handled by
Hi Hans
> >
> >>Which bring me back to a question asked a week ago or so.
> >>What is missing before we can move vboxvideo out of staging/
> >
> >I think it boils down to someone needs to submit it and we'll take a look.
>
> Right, I have this on my TODO, but I did not manage to find time for
Hi Daniel.
On Mon, Feb 11, 2019 at 06:15:20PM +0100, Daniel Vetter wrote:
> Hi all,
>
> Here's the typed component topic branch.
>
> drm-intel maintainers: Please pull, I need this for the mei hdcp work from
> Ram.
>
> drm-misc maintainers: Please pull, there's a drm doc patch follow-up
>
Hi Hean-Loong, Ong
Patch looks good to me, but there is a few trivial
things I spotted while browsing the code.
See below.
Sam
> +++ b/drivers/gpu/drm/ivip/Makefile
> @@ -0,0 +1,7 @@
> +#
> +# Makefile for the drm device driver. This driver provides support for the
> +# Direct
Hi Daniel/Stephen
Thanks for the report and the hints how to move forward to fix it.
> Sam, can you pls take a look at what komeda needs? you need to
> manually merge together drm-misc-next and drm-next first I think.
Merged the two tree and fixed build.
Undid the merge and checked that the
amp;_drop and
> everything
> +related to this. kms clients can handle hotplugs.
> -Extend this TODO with the results of that review
>
> Please send any patches to Greg Kroah-Hartman ,
The syntax around "master_set&_drop" could be better.
I wondered if the "&&qu
d at the file for a long time and so far no dragon
was staring back at me. There was a few "#ifdef" that screamed
at me, and a drm_fb_helper_fbdev_setup() that looked
suspicious alas no dragon :-(
As for the change above, dragon or no dragon:
Reviewed-by: Sam Ravnborg
Sam
Hi Joe.
> My preference would also convert all the
> DRM_DEV_ uses to drm_dev_ eventually.
>
> Also, the macros themselves could change to use a
> more consistent mechanism.
>
> This would make the drm logging mechanisms more like
> other logging mechanisms used in the kernel.
>
> Something
ng-ld9040. It can be found for example in some of Samsung
> Aries based phones.
>
> Signed-off-by: Paweł Chmiel
If you consider (do not change unless you think it better) the
following nits than you can add my:
Reviewed-by: Sam Ravnborg
Sam
> diff --git a/drivers/gpu/drm/panel/
Hi Thierry.
> I'm slightly on the fence about this patch.
Please ignore patch 3-19, there is no consensus on the logging changes.
We do not want to apply these and then have to redo parts/all of
it later.
But the first two patches has not seen any feedback yet:
[PATCH v1 01/19] drm/panel:
Hi Thierry.
>
> I personally like the DRM_DEV_* variants better because of the
> additional information that they provide. That can be useful when
> grepping logs etc.
>
> I'm slightly on the fence about this patch. The unwritten, and
> admittedly fuzzy, rules that I've been using so far are
Hi Sean.
> Hey Sam,
> Thanks for the patchset, this will make dmesg grepping easier! One comment,
> and
> you're going to hate me for it: Why use DRM_DEV* instead of DRM_*?
>
> When I introduced DRM_DEV, it was to cover the case where there are multiple
> instances of the same driver (ie:
Hi all.
On Thu, Jan 31, 2019 at 08:26:00PM +0100, Sam Ravnborg wrote:
> Hi Thierry et al.
>
> While reviewing a number of new panel drivers there was a
> certain pattern in the feedback:
> - the now deprecated drmP.h file was used
> - dev_err() and friends was used
>
>
Use of drmP.h is discouraged and yet we see new panel
drivers utilising drmP.h.
Remove usage of drmP.h from current panel drivers to set a good
example for new drivers.
While touching list of include files sort them.
Build tested on arm/x86.
Signed-off-by: Sam Ravnborg
Cc: Linus Walleij
Cc
Introduce use of DRM_DEV* for logging.
This makes logging in the drm subsystem more consistent.
Signed-off-by: Sam Ravnborg
Cc: Thierry Reding
Cc: David Airlie
Cc: Daniel Vetter
---
drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions
Introduce use of DRM_DEV* for logging.
This makes logging in the drm subsystem more consistent.
Signed-off-by: Sam Ravnborg
Cc: Thierry Reding
Cc: David Airlie
Cc: Daniel Vetter
---
drivers/gpu/drm/panel/panel-jdi-lt070me05000.c | 64 ++
1 file changed, 34 insertions
Introduce use of DRM_DEV* for logging.
This makes logging in the drm subsystem more consistent.
Signed-off-by: Sam Ravnborg
Cc: Thierry Reding
Cc: David Airlie
Cc: Daniel Vetter
---
drivers/gpu/drm/panel/panel-ilitek-ili9322.c | 93 +++
drivers/gpu/drm/panel/panel
Introduce use of DRM_DEV* for logging.
This makes logging in the drm subsystem more consistent.
Signed-off-by: Sam Ravnborg
Cc: Thierry Reding
Cc: David Airlie
Cc: Daniel Vetter
---
drivers/gpu/drm/panel/panel-innolux-p079zca.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions
Introduce use of DRM_DEV* for logging.
This makes logging in the drm subsystem more consistent.
Signed-off-by: Sam Ravnborg
Cc: Thierry Reding
Cc: David Airlie
Cc: Daniel Vetter
Cc: Stefan Mavrodiev
---
drivers/gpu/drm/panel/panel-truly-nt35597.c | 2 +-
1 file changed, 1 insertion(+), 1
Introduce use of DRM_DEV* for logging.
This makes logging in the drm subsystem more consistent.
Signed-off-by: Sam Ravnborg
Cc: Stefan Mavrodiev
Cc: Thierry Reding
Cc: David Airlie
Cc: Daniel Vetter
---
drivers/gpu/drm/panel/panel-olimex-lcd-olinuxino.c | 26 +-
1 file
Introduce use of DRM_DEV* for logging.
This makes logging in the drm subsystem more consistent.
Signed-off-by: Sam Ravnborg
Cc: Thierry Reding
Cc: David Airlie
Cc: Daniel Vetter
---
drivers/gpu/drm/panel/panel-lg-lg4573.c | 20 +++-
1 file changed, 11 insertions(+), 9
Introduce use of DRM_DEV* for logging.
This makes logging in the drm subsystem more consistent.
Signed-off-by: Sam Ravnborg
Cc: Thierry Reding
Cc: David Airlie
Cc: Daniel Vetter
---
drivers/gpu/drm/panel/panel-orisetech-otm8009a.c | 8
1 file changed, 4 insertions(+), 4 deletions
Introduce use of DRM_DEV* for logging.
This makes logging in the drm subsystem more consistent.
Signed-off-by: Sam Ravnborg
Cc: Thierry Reding
Cc: David Airlie
Cc: Daniel Vetter
---
drivers/gpu/drm/panel/panel-lvds.c | 38 ++
1 file changed, 22 insertions
Introduce use of DRM_DEV* for logging.
This makes logging in the drm subsystem more consistent.
Signed-off-by: Sam Ravnborg
Cc: Thierry Reding
Cc: David Airlie
Cc: Daniel Vetter
---
drivers/gpu/drm/panel/panel-samsung-ld9040.c | 12 +--
drivers/gpu/drm/panel/panel-samsung-s6e3ha2
Introduce use of DRM_DEV* for logging.
This makes logging in the drm subsystem more consistent.
Signed-off-by: Sam Ravnborg
Cc: Thierry Reding
Cc: David Airlie
Cc: Daniel Vetter
---
drivers/gpu/drm/panel/panel-seiko-43wvf1g.c | 14 --
1 file changed, 8 insertions(+), 6 deletions
The num_supplies variable is not used, delete it.
Build tested.
Signed-off-by: Sam Ravnborg
Cc: Thierry Reding
Cc: David Airlie
Cc: Daniel Vetter
---
drivers/gpu/drm/panel/panel-innolux-p079zca.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/panel/panel-innolux-p079zca.c
Introduce use of DRM_DEV* for logging.
This makes logging in the drm subsystem more consistent.
Signed-off-by: Sam Ravnborg
Cc: Thierry Reding
Cc: David Airlie
Cc: Daniel Vetter
---
drivers/gpu/drm/panel/panel-simple.c | 19 ---
1 file changed, 12 insertions(+), 7 deletions
meone else (Thierry?) to commit this.
Patches are made on top of drm-misc-next as of a few days ago.
Comments welcome!
Sam
Sam Ravnborg (19):
drm/panel: drop drmP.h usage
drm/panel: panel-innolux: drop unused variable
drm/panel: samsung: use DRM_DEV*
drm/panel: arm
Introduce use of DRM_DEV* for logging.
This makes logging in the drm subsystem more consistent.
Signed-off-by: Sam Ravnborg
Cc: Thierry Reding
Cc: David Airlie
Cc: Daniel Vetter
Cc: Stefan Mavrodiev
---
drivers/gpu/drm/panel/panel-arm-versatile.c | 18 ++
1 file changed, 10
Introduce use of DRM_DEV* for logging.
This makes logging in the drm subsystem more consistent.
Signed-off-by: Sam Ravnborg
Cc: Thierry Reding
Cc: David Airlie
Cc: Daniel Vetter
---
.../gpu/drm/panel/panel-raspberrypi-touchscreen.c | 22 ++
1 file changed, 14 insertions
Introduce use of DRM_DEV* for logging.
This makes logging in the drm subsystem more consistent.
Signed-off-by: Sam Ravnborg
Cc: Thierry Reding
Cc: David Airlie
Cc: Daniel Vetter
---
drivers/gpu/drm/panel/panel-panasonic-vvx10f034n00.c | 16 ++--
1 file changed, 10 insertions
Introduce use of DRM_DEV* for logging.
This makes logging in the drm subsystem more consistent.
Signed-off-by: Sam Ravnborg
Cc: Thierry Reding
Cc: David Airlie
Cc: Daniel Vetter
---
drivers/gpu/drm/panel/panel-sharp-lq101r1sx01.c | 63 -
drivers/gpu/drm/panel/panel
Introduce use of DRM_DEV* for logging.
This makes logging in the drm subsystem more consistent.
Signed-off-by: Sam Ravnborg
Cc: Thierry Reding
Cc: David Airlie
Cc: Daniel Vetter
---
drivers/gpu/drm/panel/panel-raydium-rm68200.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions
Hi Jagan.
> >
> > I see DRM_MODE_ARG as mode argument, that print all mode timings but
> > here we need only 3 timings out of it. do we really need? if yes
> > please suggest an example.
>
> fyi: sent v6 for this except this change. Let me know if you have any
> comments on this.
Drivers looks
Hi Pawel.
Thanks for this nice patch too.
Comment follows and you need to judge what to follow.
The timing part will not be commented as this was covered in
feedback on the binding.
Using a sysfs file to select the gamma mode looks like a local hack.
Someone with more drm knowledge needs
Hi Pawel.
Thanks for the patch, some comments follows.
Please judge what comments you chose to follow, see this as suggestions.
According to Documentation/devicetree/bindings/submitting-patches.rst:
The preferred subject prefix for binding patches is:
"dt-bindings: : ..."
It
-lane MIPI DSI LCD panel.
>
> Driver now registering mipi_dsi device, but indeed it can extendable
> for RGB if any requirement trigger in future.
>
> Signed-off-by: Jagan Teki
> Reviewed-by: Sam Ravnborg
The driver is, as far as I can tell, ready to be committed
allmodconfig / allyesconfig.
Signed-off-by: Sam Ravnborg
Cc: Greg Kroah-Hartman
Cc: Hans de Goede
Cc: Daniel Vetter
---
drivers/staging/vboxvideo/vbox_drv.c | 6 +-
drivers/staging/vboxvideo/vbox_fb.c | 18 ++
drivers/staging/vboxvideo/vbox_mode.c | 5 -
3 files changed, 19
drm_probe_helper and other
required several updates
Signed-off-by: Sam Ravnborg
Cc: Laurent Pinchart
Cc: Kieran Bingham
Cc: David Airlie
Cc: Daniel Vetter
Cc: linux-renesas-...@vger.kernel.org
---
drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 3 +++
drivers/gpu/drm/rcar-du/rcar_du_drv.c | 1
on x86 and arm allmodconfig / allyesconfig.
Signed-off-by: Sam Ravnborg
Cc: Jani Nikula
Cc: Joonas Lahtinen
Cc: Rodrigo Vivi
Cc: David Airlie
Cc: Daniel Vetter
Cc: intel-...@lists.freedesktop.org
---
drivers/gpu/drm/i915/i915_drv.c | 4 +++-
drivers/gpu/drm/i915/intel_atomic.c
The use of drmP.h is discouraged and removal of it from
drm_modeset_helper.h caused drm/ to fail to build.
This patch introduce the necessary fixes to prepare for the
drmP.h removal from drm_modeset_helper.h.
Build tested on x86, arm, alpha, ia64 allmodconfig/allyesconfig.
Signed-off-by: Sam
dependency chain.
v2:
- moved updates of .c files in drm/ to a dedicated
patch. This allows the updates to the *.c files
to be committed without the removal part.
So this patch can wait if it causes build failures
due to pending changes
Signed-off-by: Sam Ravnborg
Reviewed-by: Laurent
oc comments to drm_util.h
- moved EXPORT_SYMBOL_FOR_TESTS_ONLY to drm_util.h
- added note to drmP.h not to add new stuff and not to use in new files
Sam Ravnborg (5):
staging/vboxvideo: prepare for drmP.h removal from drm_modeset_helper.h
drm/i915: prepare for drmP.h removal from drm_m
sider my inputs (I know you will) then you can add my:
Reviewed-by: Sam Ravnborg
> + msleep(20);
> +
> + gpiod_set_value(ctx->reset, 0);
> + /* T5 + T6 (avdd rise + video & logic signal rise)
> + * T5 >= 10ms, 0 < T6 <= 10ms
> + */
> +
Hi Noralf.
> > Lovely diffstat, thanks to the new generic fbdev emulation.
> >
> > drm/qxl/Makefile |2
> > drm/qxl/qxl_draw.c | 232
> > drm/qxl/qxl_drv.h | 21 ---
> > drm/qxl/qxl_fb.c | 300
> >
Hi Sean/Hans.
> > Hans de Goede sent out patches in September to convert it to a proper
> > atomic driver.
> > I recall that the feedback was mostly positive and that there was only
> > minor things to left to do. Hans?
I browsed the archieves and I could not find anything that was not
Hi Sean.
> >
> > Merge the previous 5 patches from this series, but this now goes boom on
> > vbox in staging. Needs another prep patch I think.
>
> Soo, can we drop vboxvideo yet?
Hans de Goede sent out patches in September to convert it to a proper
atomic driver.
I recall that the feedback
Hi Jagan.
Thanks for this nice patch, a few comments below.
On Fri, Jan 25, 2019 at 12:13:13AM +0530, Jagan Teki wrote:
> Feiyang FY07024DI26A30-D is 1024x600, 4-lane MIPI-DSI LCD panel.
>
> Add panel driver for it.
>
> Signed-off-by: Jagan Teki
> ---
> Changes for v5:
> - rebase on master
>
ht->dev);
> +
> + return 0;
> +}
Please address this comment from Noralf:
"This happens automatically on driver detach if devm_of_find_backlight()
is used"
In other words, no need to do anything with backlight in st7701_dsi_remove()
With these details fixed you can add back my:
Reviewed-by: Sam Ravnborg
On Thu, Jan 24, 2019 at 03:03:20PM +0100, Daniel Vetter wrote:
> On Sat, Jan 19, 2019 at 09:40:14AM +0100, Sam Ravnborg wrote:
> > With the removal of drmP.h from drm_modeset_helper.h
> > the drmP.h are no longer included by any include files
> > in include/drm.
> > T
capacitance load.
The default value matches that of the current Linux driver.
With a dedicated binding remove the entry in rtc.txt
Signed-off-by: Søren Andersen
Signed-off-by: Sam Ravnborg
Reviewed-by: Rob Herring
Cc: Alessandro Zummo
Cc: Alexandre Belloni
Cc: Mark Rutland
---
Documentation
.
(The DT uses femto Farad to avoid decimal numbers).
Other values are warned and the driver uses the default value.
Signed-off-by: Sam Ravnborg
Cc: Alessandro Zummo
Cc: Alexandre Belloni
Cc: Urs Fässler
---
drivers/rtc/rtc-pcf85063.c | 39 +++
1 file changed, 39
When dealing with capacitance of 0.5 pF then
a smaller unit is preferred.
Add femtofarads to deal with this.
Signed-off-by: Sam Ravnborg
Reviewed-by: Rob Herring
Cc: Mark Rutland
Cc: Alessandro Zummo
Cc: Alexandre Belloni
---
Documentation/devicetree/bindings/property-units.txt | 1 +
1
patible
- Reduced logging
- Warn, when we continue with a default value
- Tested, by Søren Andersen, on real HW
- Rebased on top of v5.0-rc1
Sam
Sam Ravnborg (6):
devicetree: property-units: Add femtofarads unit
dt-bindings: rtc: Add quartz-load-femtofarads property
dt-binding: p
The quartz-load-femtofarads are relevant for
several users. Add it as a common property in rtc.
Note that valid values and default values must be documented.
Signed-off-by: Sam Ravnborg
Suggested-by: Rob Herring
Cc: Alessandro Zummo
Cc: Alexandre Belloni
Cc: Rob Herring
Cc: Mark Rutland
.
(The DT uses femto Farad to avoid decimal numbers).
Other values are warned and the driver uses the default value.
Signed-off-by: Sam Ravnborg
Cc: Alessandro Zummo
Cc: Alexandre Belloni
---
drivers/rtc/rtc-pcf8523.c | 28
1 file changed, 20 insertions(+), 8 deletions
capacitance load.
The default value matches that of the current Linux driver.
With a dedicated binding remove the entry in rtc.txt
Signed-off-by: Søren Andersen
Signed-off-by: Sam Ravnborg
Cc: Alessandro Zummo
Cc: Alexandre Belloni
Cc: Rob Herring
Cc: Mark Rutland
Cc: Urs Fässler
the preferred fix
is something where we have coverage on 32bit ARM too.
v2:
- Sort list of include files
Signed-off-by: Sam Ravnborg
Cc: Xinliang Liu
Cc: Rongrong Zou
Cc: Xinwei Kong
Cc: Chen Feng
Cc: David Airlie
Cc: Daniel Vetter
---
drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c | 11 +++
-off-by: Sam Ravnborg
Acked-by: Benjamin Gaignard
Cc: Yannick Fertre
Cc: Philippe Cornu
Cc: Vincent Abriou
Cc: David Airlie
Cc: Daniel Vetter
---
drivers/gpu/drm/stm/drv.c | 6 +-
drivers/gpu/drm/stm/ltdc.c | 9 -
2 files changed, 13 insertions(+), 2 deletions(-)
diff --git
dependency chain.
Include build failure fixes in drm files after the drmP.h removal.
Signed-off-by: Sam Ravnborg
Reviewed-by: Laurent Pinchart
Cc: Maarten Lankhorst
Cc: Maxime Ripard
Cc: Sean Paul
Cc: David Airlie
Cc: Daniel Vetter
---
drivers/gpu/drm/drm_damage_helper.c | 1 +
drivers
allmodconfig.
Signed-off-by: Sam Ravnborg
Acked-by: Alexey Brodkin
Cc: David Airlie
Cc: Daniel Vetter
---
drivers/gpu/drm/arc/arcpgu_sim.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/arc/arcpgu_sim.c b/drivers/gpu/drm/arc/arcpgu_sim.c
index 6530d88f7293
The use of drmP.h is discouraged and removal of it from
drm_modeset_helper.h caused cdns to fail to build.
This patch introduce the necessary fixes to prepare for the
drmP.h removal from drm_modeset_helper.h.
Build tested on arm x86 and arm allmodconfig.
Signed-off-by: Sam Ravnborg
Cc: Andrzej
The use of drmP.h is discouraged and removal of it from
drm_modeset_helper.h caused rcar-du to fail to build.
This patch introduce the necessary fixes to prepare for the
drmP.h removal from drm_modeset_helper.h.
Build tested on arm x86 and arm allmodconfig.
Signed-off-by: Sam Ravnborg
Reviewed
Laurent Pinchart)
- add drm_framebuffer.h patch
- add kernel-doc comments to drm_util.h
- moved EXPORT_SYMBOL_FOR_TESTS_ONLY to drm_util.h
- added note to drmP.h not to add new stuff and not to use in new files
Sam Ravnborg (6):
drm/stm: prepare for drmP.h removal from drm_modeset_helper.h
Hi Christoph
On Thu, Jan 17, 2019 at 03:55:31PM +0100, Christoph Hellwig wrote:
> Hi Masahiro, hi Michal,
>
> I just got this beatiful warning:
>
> hch@carbon:~/work/xfs$ make -j4 SUBDIRS=fs/xfs
> Makefile:189: = WARNING
> Makefile:190: 'SUBDIRS' will be removed
Hi all.
> Commit
>
> 94520db52fc0 ("drm: fix alpha build after drm_util.h change")
>
> has a malformed Fixes tag:
>
> Fixes: 733748ac37b45 ("drm: move drm_can_sleep() to drm_util.h")
>
> The SHA1 does not reference a commit currently in the tree. Maybe it
> was meant to be e9eafcb58921.
Hi Rob.
> > +
> > +Optional property:
> > +- quartz-load-femtofarads: The capacitive load of the quartz(x-tal),
>
> Probably should put this in rtc.txt so it can be shared.
Good point - will do and respin the patchset.
>
> > + expressed in femto Farad (fF). Valid values are 7000 and 12500.
>
Hi Eugen.
Patch looks good, but a small improvement proposal.
On Mon, Jan 14, 2019 at 09:43:31AM +, eugen.hris...@microchip.com wrote:
> From: Eugen Hristev
>
> PDA 91-00156-A0 5.0 is a 5.0" WVGA TFT LCD panel.
> This panel with backlight is found in PDA 5" LCD screen (TM5000 series or
>
Hi Eugen.
On Mon, Jan 14, 2019 at 09:43:26AM +, eugen.hris...@microchip.com wrote:
> From: Eugen Hristev
>
> Precision Design Associates, Inc. (PDA) manufactures standard and custom
> capacitive touch screens, LCD's embedded controllers and custom embedded
> software. They specialize in
In the quest to get rid of drmP.h move the newly
added EXPORT_SYMBOL_FOR_TESTS_ONLY to drm_util.h.
Fix the single user.
Add a note to drmP.h to avoid further use of it.
Signed-off-by: Sam Ravnborg
Cc: Maarten Lankhorst
Cc: Maxime Ripard
Cc: Sean Paul
Cc: David Airlie
Cc: Daniel Vetter
The use of drmP.h is discouraged and removal of it from
drm_modeset_helper.h caused drm/stm to fail to build.
This patch introduce the necessary fixes to prepare for the
drmP.h removal from drm_modeset_helper.h.
Build tested on arm and x86 allmodconfig
Signed-off-by: Sam Ravnborg
Cc: Yannick
The use of drmP.h is discouraged and removal of it from
drm_modeset_helper.h caused cdns to fail to build.
This patch introduce the necessary fixes to prepare for the
drmP.h removal from drm_modeset_helper.h.
Build tested on arm x86 and arm allmodconfig.
Signed-off-by: Sam Ravnborg
Cc: Andrzej
The use of drmP.h is discouraged and removal of it from
drm_modeset_helper.h caused rcar-du to fail to build.
This patch introduce the necessary fixes to prepare for the
drmP.h removal from drm_modeset_helper.h.
Build tested on arm x86 and arm allmodconfig.
Signed-off-by: Sam Ravnborg
Cc
Y to drm_util.h
- added note to drmP.h not to add new stuff and not to use in new files
Sam Ravnborg (8):
drm: move drm_can_sleep() to drm_util.h
drm: move EXPORT_SYMBOL_FOR_TESTS_ONLY to drm_util.h
drm/stm: prepare for drmP.h removal from drm_modeset_helper.h
drm/h
(Daniel)
- Add FIXME to drm_can_sleep and add note that this
function should not be used in new code (Daniel)
v3:
- Fix kernel-doc syntax (Daniel)
- Plug drm_util.h into drm-internels.rst (Daniel)
Signed-off-by: Sam Ravnborg
Cc: Maarten Lankhorst
Cc: Maxime Ripard
Cc: Sean Paul
Cc: David
dependency chain.
Include build failures fixes in drm files after the drmP.h removal.
Signed-off-by: Sam Ravnborg
Cc: Maarten Lankhorst
Cc: Maxime Ripard
Cc: Sean Paul
Cc: David Airlie
Cc: Daniel Vetter
---
drivers/gpu/drm/drm_damage_helper.c | 1 +
drivers/gpu/drm/drm_modeset_helper.c | 2
the preferred fix
is something where we have coverage on 32bit ARM too.
Signed-off-by: Sam Ravnborg
Cc: Xinliang Liu
Cc: Rongrong Zou
Cc: Xinwei Kong
Cc: Chen Feng
Cc: David Airlie
Cc: Daniel Vetter
---
drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c | 11 ---
1 file changed, 8 i
allmodconfig.
Signed-off-by: Sam Ravnborg
Cc: Alexey Brodkin
Cc: David Airlie
Cc: Daniel Vetter
---
drivers/gpu/drm/arc/arcpgu_sim.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/arc/arcpgu_sim.c b/drivers/gpu/drm/arc/arcpgu_sim.c
index 6530d88f7293
Hi Jagan.
> When did .unprepare and .disable are actually called? I turn-off the
> backlight by echo 1 > /sys/class/backlight/backlight/bl_power and even
> power of the board I assume the video transmission stop so it would
> ended-up calling these, but I couldn't see prints. does it the same
>
Hi Jagan.
> > But as we just assert reset (set it to 0), this timing constraint can be
> > ignored.
>
> But we unaware of reset pulse duration right? it's the hardware that
> bring the reset assert if we set the line 0. am I correct or do we
> need to explicitly wait 10us after reset initiated?
> >
> > > > > +
> > > > > + msleep(st7701->sleep_delay);
> > > > > +
> > > > > + gpiod_set_value(st7701->reset, 0);
> > > > > +
> > > > > + gpiod_set_value(st7701->reset, 1);
> > > > > +
> > > > > + gpiod_set_value(st7701->reset, 0);
> > > > No timing constrains here? In prepare
Hi Jagan.
> On Sat, Jan 12, 2019 at 2:49 AM Sam Ravnborg wrote:
> >
> > Hi Jagan.
> >
> > Gave this another more detailed read - triggered some additional comments.
> > Depite the comments it looks good, and this is all more or
> > less cosmetic i
Hi Jagan.
Gave this another more detailed read - triggered some additional comments.
Depite the comments it looks good, and this is all more or
less cosmetic improvements.
Sam
> +struct st7701_panel_desc {
> + const struct drm_display_mode *mode;
> + unsigned int lanes;
> +
Hi Peter.
(Hijacking this thread as I lost the orginal mails)
> >
> > I found an unfortunate issue while recoding plane handling to use
> > drm_atomic_helper_check_plane_state(). The driver rotates clockwise,
> > which is not correct. I simply fixed it (patch 1/4), but maybe that
> > will cause
On Wed, Jan 09, 2019 at 11:24:05PM +0100, Daniel Vetter wrote:
> On Tue, Jan 08, 2019 at 08:29:39PM +0100, Sam Ravnborg wrote:
> > With all dependencies fixed we can now remove
> > drmP.h from drm_gem_cma_helper.h.
> > It is replaced by the include files required,
> &
Hi Benjamin.
On Wed, Jan 09, 2019 at 09:21:39AM +0100, Benjamin Gaignard wrote:
> Le mar. 8 janv. 2019 à 20:30, Sam Ravnborg a écrit :
> I just notice the a typo in the title of the commit message reply ->rely ?
Randy already told me this, but I missed that in the update.
Will
already use
TASK_COMM_LEN to check for length etc.
v2:
- Added forward declaration of drm_gem_object (Noralf)
- Added ack from Noralf
Signed-off-by: Sam Ravnborg
Acked-by: Noralf Trønnes
Cc: Maarten Lankhorst
Cc: Maxime Ripard
Cc: Sean Paul
Cc: David Airlie
Cc: Daniel Vetter
---
include/drm
tested with arm and x86.
v2:
- prefer forward declarations when possible (Laurent Pinchart)
- sort include files (Laurent Pinchart)
Signed-off-by: Sam Ravnborg
Reviewed-by: Laurent Pinchart
Cc: Archit Taneja
Cc: Andrzej Hajda
Cc: David Airlie
Cc: Daniel Vetter
Cc: Kieran Bingham
Cc: Fabio
501 - 600 of 4807 matches
Mail list logo
