RE: [PATCH] vfio/pci: Fix SR-IOV VF handling with MMIO blocking

> -Original Message- > From: Alex Williamson > Sent: Sunday, June 28, 2020 12:09 > To: Wang, Haiyue > Cc: k...@vger.kernel.org; linux-kernel@vger.kernel.org; > maxime.coque...@redhat.com; David Marchand > ; Kevin Traynor > Subject: Re: [PATCH] vfio/pci: Fix SR-I

RE: [PATCH] vfio/pci: Fix SR-IOV VF handling with MMIO blocking

> -Original Message- > From: kvm-ow...@vger.kernel.org On Behalf Of Alex > Williamson > Sent: Friday, June 26, 2020 00:57 > To: alex.william...@redhat.com > Cc: k...@vger.kernel.org; linux-kernel@vger.kernel.org; > maxime.coque...@redhat.com > Subject: [PATCH] vfio/pci: Fix SR-IOV VF

Re: [RFC PATCH 15/17] ipmi: kcs: aspeed: Implement v2 bindings

在 2019-07-26 13:39, Andrew Jeffery 写道: The v2 bindings allow us to extract the resources from the devicetree. The table in the driver is retained to derive the channel index, which removes the need for kcs_chan property from the v1 bindings. The v2 bindings allow us to reduce the number of

Re: [PATCHv7 1/3] dt-bindings: i2c: document bindings for i2c-slave-mqueue

在 2019-06-12 07:14, Rob Herring 写道: On Wed, Jun 05, 2019 at 09:46:49AM -0700, Eduardo Valentin wrote: Document the i2c-slave-mqueue binding by adding descriptor, required properties, and example. Cc: Rob Herring Cc: Mark Rutland Cc: Wolfram Sang Cc: linux-...@vger.kernel.org Cc:

Re: [PATCH i2c/slave-mqueue v5] i2c: slave-mqueue: add a slave backend to receive and queue messages

在 2019-05-30 07:11, Eduardo Valentin 写道: this code goes access and modify data here, e.g. msg->len and msg->buf. On this case (I2C_SLAVE_WRITE_RECEIVED), this code wont protect access. This can cause concurrence issues if you receive an IRQ when the user is on your bin_read(). User will not

Re: [PATCH i2c/slave-mqueue v5] i2c: slave-mqueue: add a slave backend to receive and queue messages

在 2019-05-25 01:33, Eduardo Valentin 写道: Hey, On Fri, May 24, 2019 at 10:43:16AM +0800, Wang, Haiyue wrote: Thanks for interest, the design idea is from: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/i2c/i2c-slave-eeprom.c?h=v5.2-rc1 and https

Re: [PATCH i2c/slave-mqueue v5] i2c: slave-mqueue: add a slave backend to receive and queue messages

Thanks for interest, the design idea is from: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/i2c/i2c-slave-eeprom.c?h=v5.2-rc1 and https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/i2c/slave-interface Then you will get the

Re: [PATCH] ipmi: kcs_bmc: handle devm_kasprintf() failure case

[Resend for wrong reply HTML format mail] Great check for making kcs_bmc module be more stable and handle things gracefully. My tag if needed. Reviewed-by: Haiyue Wang 在 2018-11-27 21:36, Corey Minyard 写道: On 11/21/18 9:08 AM, Nicholas Mc Guire wrote: devm_kasprintf() may return NULL

Re: [PATCH] ipmi: kcs_bmc: handle devm_kasprintf() failure case

[Resend for wrong reply HTML format mail] Great check for making kcs_bmc module be more stable and handle things gracefully. My tag if needed. Reviewed-by: Haiyue Wang 在 2018-11-27 21:36, Corey Minyard 写道: On 11/21/18 9:08 AM, Nicholas Mc Guire wrote: devm_kasprintf() may return NULL

Re: [PATCH dts/arm/aspeed-g5 v1] ARM: dts: aspeed-g5: Add IPMI KCS node

Hi Joel & Andrew This patch is out of date. ;-) New: https://patchwork.ozlabs.org/patch/893720/ On 2018-05-25 12:34, Joel Stanley wrote: Hello Andrew, On 16 March 2018 at 11:17, Wang, Haiyue <haiyue.w...@linux.intel.com> wrote: Hi Joel and Andrew, Have time to review this pa

Re: [PATCH dts/arm/aspeed-g5 v1] ARM: dts: aspeed-g5: Add IPMI KCS node

Hi Joel & Andrew This patch is out of date. ;-) New: https://patchwork.ozlabs.org/patch/893720/ On 2018-05-25 12:34, Joel Stanley wrote: Hello Andrew, On 16 March 2018 at 11:17, Wang, Haiyue wrote: Hi Joel and Andrew, Have time to review this patch ? Hope for your comments. :-)

Re: [PATCH ipmi/kcs_bmc v1] ipmi: add an NPCM7xx KCS BMC driver

Thanks, Corey. BR, Haiyue On 2018-04-13 23:56, Corey Minyard wrote: On 03/22/2018 07:50 AM, Haiyue Wang wrote: This driver exposes the Keyboard Controller Style (KCS) interface on Novoton NPCM7xx SoCs as a character device. Such SOCs are commonly used as a BaseBoard Management Controller

Re: [PATCH ipmi/kcs_bmc v1] ipmi: add an NPCM7xx KCS BMC driver

Thanks, Corey. BR, Haiyue On 2018-04-13 23:56, Corey Minyard wrote: On 03/22/2018 07:50 AM, Haiyue Wang wrote: This driver exposes the Keyboard Controller Style (KCS) interface on Novoton NPCM7xx SoCs as a character device. Such SOCs are commonly used as a BaseBoard Management Controller

Re: [PATCH ipmi/kcs_bmc v1] ipmi: kcs_bmc: optimize the data buffers allocation

On 2018-04-13 21:50, Corey Minyard wrote: On 04/07/2018 02:54 AM, Wang, Haiyue wrote: Hi Corey, Since IPMI 2.0 just defined minimum, no maximum: KCS/SMIC Input : Required: 40 bytes IPMI Message, minimum KCS/SMIC Output : Required: 38 bytes IPMI Message, minimum Yes, though

Re: [PATCH ipmi/kcs_bmc v1] ipmi: kcs_bmc: optimize the data buffers allocation

On 2018-04-13 21:50, Corey Minyard wrote: On 04/07/2018 02:54 AM, Wang, Haiyue wrote: Hi Corey, Since IPMI 2.0 just defined minimum, no maximum: KCS/SMIC Input : Required: 40 bytes IPMI Message, minimum KCS/SMIC Output : Required: 38 bytes IPMI Message, minimum Yes, though

Re: [PATCH ipmi/kcs_bmc v1] ipmi: kcs_bmc: optimize the data buffers allocation

case. And I think this patch make checking simple (from 3 to 1), and the code clean, this is the biggest reason I want to change. The TLB is just memory management study from book, no data to support access improvement. :) BR, Haiyue On 2018-04-07 10:37, Wang, Haiyue wrote: On 2018-04-07

Re: [PATCH ipmi/kcs_bmc v1] ipmi: kcs_bmc: optimize the data buffers allocation

case. And I think this patch make checking simple (from 3 to 1), and the code clean, this is the biggest reason I want to change. The TLB is just memory management study from book, no data to support access improvement. :) BR, Haiyue On 2018-04-07 10:37, Wang, Haiyue wrote: On 2018-04-07

Re: [PATCH ipmi/kcs_bmc v1] ipmi: kcs_bmc: optimize the data buffers allocation

On 2018-04-07 05:47, Corey Minyard wrote: On 03/15/2018 07:20 AM, Haiyue Wang wrote: Allocate a continuous memory block for the three KCS data buffers with related index assignment. I'm finally getting to this. Is there a reason you want to do this?  In general, it's better to not try to

Re: [PATCH ipmi/kcs_bmc v1] ipmi: kcs_bmc: optimize the data buffers allocation

On 2018-04-07 05:47, Corey Minyard wrote: On 03/15/2018 07:20 AM, Haiyue Wang wrote: Allocate a continuous memory block for the three KCS data buffers with related index assignment. I'm finally getting to this. Is there a reason you want to do this?  In general, it's better to not try to

Re: [PATCH ipmi/kcs_bmc v1] ipmi: kcs_bmc: optimize the data buffers allocation

Just a small piece of cake, not so urgent. I just try to understand the code commitment process, such as time etc. :) Thanks! BR, Haiyue On 2018-04-04 02:45, Corey Minyard wrote: On 04/03/2018 01:00 AM, Wang, Haiyue wrote: Hi Corey, The 4.17 merge window is opened now, this patch

Re: [PATCH ipmi/kcs_bmc v1] ipmi: kcs_bmc: optimize the data buffers allocation

Just a small piece of cake, not so urgent. I just try to understand the code commitment process, such as time etc. :) Thanks! BR, Haiyue On 2018-04-04 02:45, Corey Minyard wrote: On 04/03/2018 01:00 AM, Wang, Haiyue wrote: Hi Corey, The 4.17 merge window is opened now, this patch

Re: [PATCH ipmi/kcs_bmc v1] ipmi: kcs_bmc: optimize the data buffers allocation

Hi Corey, The 4.17 merge window is opened now, this patch is not yet in linux-next tree, so it will be merged into 4.18 ? Thanks & Regards, Haiyue On 2018-03-15 20:20, Haiyue Wang wrote: Allocate a continuous memory block for the three KCS data buffers with related index assignment.

Re: [PATCH ipmi/kcs_bmc v1] ipmi: kcs_bmc: optimize the data buffers allocation

Hi Corey, The 4.17 merge window is opened now, this patch is not yet in linux-next tree, so it will be merged into 4.18 ? Thanks & Regards, Haiyue On 2018-03-15 20:20, Haiyue Wang wrote: Allocate a continuous memory block for the three KCS data buffers with related index assignment.

Re: [PATCH i2c/slave-mqueue v1] i2c: slave-mqueue: add a slave backend to receive and queue messages

Thanks, Andy. Hi Wolfram, Let me introduce some development background, it is used for OpenBMC project, which belongs to the Linux Foundation now

Re: [PATCH i2c/slave-mqueue v1] i2c: slave-mqueue: add a slave backend to receive and queue messages

Thanks, Andy. Hi Wolfram, Let me introduce some development background, it is used for OpenBMC project, which belongs to the Linux Foundation now

Re: [PATCH dts/arm/aspeed-g5 v1] ARM: dts: aspeed-g5: Add IPMI KCS node

Hi Joel and Andrew, Have time to review this patch ? Hope for your comments. :-) BR, Haiyue On 2018-03-07 13:04, Haiyue Wang wrote: The IPMI KCS device part of the LPC interface and is used for communication with the host processor. Signed-off-by: Haiyue Wang

Re: [PATCH dts/arm/aspeed-g5 v1] ARM: dts: aspeed-g5: Add IPMI KCS node

Hi Joel and Andrew, Have time to review this patch ? Hope for your comments. :-) BR, Haiyue On 2018-03-07 13:04, Haiyue Wang wrote: The IPMI KCS device part of the LPC interface and is used for communication with the host processor. Signed-off-by: Haiyue Wang ---

Re: [PATCH dts/arm/aspeed-g5 v1] ARM: dts: aspeed-g5: Add IPMI KCS node

On 2018-03-07 11:56, Joel Stanley wrote: And the patch is generated by rebasing on: https://git.kernel.org/pub/scm/linux/kernel/git/joel/aspeed.git Please help to review. Thanks for the patch. I suggest you submit this patch for inclusion in the upstream kernel. To do this, send it to: Joel

Re: [PATCH dts/arm/aspeed-g5 v1] ARM: dts: aspeed-g5: Add IPMI KCS node

On 2018-03-07 11:56, Joel Stanley wrote: And the patch is generated by rebasing on: https://git.kernel.org/pub/scm/linux/kernel/git/joel/aspeed.git Please help to review. Thanks for the patch. I suggest you submit this patch for inclusion in the upstream kernel. To do this, send it to: Joel

Re: [PATCH ipmi/kcs_bmc v6] ipmi: kcs_bmc: coding-style fixes and use new poll type

On 2018-02-26 23:50, Corey Minyard wrote: On 02/26/2018 09:48 AM, Haiyue Wang wrote: Many for coding-style fixes, and update the poll API with the new type '__poll_t', this is new commit from linux-4.16-rc1. Signed-off-by: Haiyue Wang Sorry for the delay, I

Re: [PATCH ipmi/kcs_bmc v6] ipmi: kcs_bmc: coding-style fixes and use new poll type

On 2018-02-26 23:50, Corey Minyard wrote: On 02/26/2018 09:48 AM, Haiyue Wang wrote: Many for coding-style fixes, and update the poll API with the new type '__poll_t', this is new commit from linux-4.16-rc1. Signed-off-by: Haiyue Wang Sorry for the delay, I was on jury duty last week. 

Re: [PATCH arm/aspeed/ast2500 v2] eSPI: add ASPEED AST2500 eSPI driver to boot a host with PCH runs on eSPI

On 2018-02-23 18:25, Andy Shevchenko wrote: On Fri, 2018-02-23 at 15:04 +0800, Haiyue Wang wrote: When PCH works under eSPI mode, the PMC (Power Management Controller) in PCH is waiting for SUS_ACK from BMC after it alerts SUS_WARN. It is in dead loop if no SUS_ACK assert. This is the basic

Re: [PATCH arm/aspeed/ast2500 v2] eSPI: add ASPEED AST2500 eSPI driver to boot a host with PCH runs on eSPI

On 2018-02-23 18:25, Andy Shevchenko wrote: On Fri, 2018-02-23 at 15:04 +0800, Haiyue Wang wrote: When PCH works under eSPI mode, the PMC (Power Management Controller) in PCH is waiting for SUS_ACK from BMC after it alerts SUS_WARN. It is in dead loop if no SUS_ACK assert. This is the basic

Re: [PATCH] MAINTAINERS: Update ASPEED entry with details

On 2018-02-23 08:11, Andrew Jeffery wrote: Hi Haiyue, On Thu, 22 Feb 2018, at 19:20, Wang, Haiyue wrote: Dear Andrew & Joel, Since you are ASPEED BMC experts, any time and interest in eSPI code review ? I've sent it before, but no more response. Intel recommends eSPI bus than LPC as I

Re: [PATCH] MAINTAINERS: Update ASPEED entry with details

On 2018-02-23 08:11, Andrew Jeffery wrote: Hi Haiyue, On Thu, 22 Feb 2018, at 19:20, Wang, Haiyue wrote: Dear Andrew & Joel, Since you are ASPEED BMC experts, any time and interest in eSPI code review ? I've sent it before, but no more response. Intel recommends eSPI bus than LPC as I

Re: [PATCH] MAINTAINERS: Update ASPEED entry with details

Dear Andrew & Joel, Since you are ASPEED BMC experts, any time and interest in eSPI code review ? I've sent it before, but no more response. Intel recommends eSPI bus than LPC as I know. I just kept the minimal eSPI code which is approved to work well in our real server boards for two

Re: [PATCH] MAINTAINERS: Update ASPEED entry with details

Dear Andrew & Joel, Since you are ASPEED BMC experts, any time and interest in eSPI code review ? I've sent it before, but no more response. Intel recommends eSPI bus than LPC as I know. I just kept the minimal eSPI code which is approved to work well in our real server boards for two

Re: [PATCH ipmi/kcs_bmc v2] ipmi: kcs_bmc: make the code be more clean

On 2018-02-20 21:29, Corey Minyard wrote: On 02/19/2018 09:55 AM, Haiyue Wang wrote: --- When you use ---, it means everything following is not in the commit text, including your signature. Got it. v1 -> v2: Do you want me to fold this into the previous patch?  That's generally not how

Re: [PATCH ipmi/kcs_bmc v2] ipmi: kcs_bmc: make the code be more clean

On 2018-02-20 21:29, Corey Minyard wrote: On 02/19/2018 09:55 AM, Haiyue Wang wrote: --- When you use ---, it means everything following is not in the commit text, including your signature. Got it. v1 -> v2: Do you want me to fold this into the previous patch?  That's generally not how

Re: [PATCH] ipmi: kcs_bmc: mark expected switch fall-through in kcs_bmc_handle_data

On 2018-02-15 05:46, Corey Minyard wrote: On 02/14/2018 11:30 AM, Gustavo A. R. Silva wrote: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Thanks, queued for next release. -corey Addresses-Coverity-ID: 1465255 ("Missing break

Re: [PATCH] ipmi: kcs_bmc: mark expected switch fall-through in kcs_bmc_handle_data

On 2018-02-15 05:46, Corey Minyard wrote: On 02/14/2018 11:30 AM, Gustavo A. R. Silva wrote: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Thanks, queued for next release. -corey Addresses-Coverity-ID: 1465255 ("Missing break

Re: [PATCH arm/aspeed/ast2500 v5 1/2] ipmi: add a KCS IPMI BMC driver

On 2018-02-02 21:52, Corey Minyard wrote: On 02/01/2018 08:16 PM, Haiyue Wang wrote: --- v4->v5 - Fix -Wdiscarded-qualifiers 'const' compile warning. - Fix size_t printk compile error. v3->v4 - Change to accept WRITE_START any time. v2->v3 - Update the KCS phase state machine. - Fix the race

Re: [PATCH arm/aspeed/ast2500 v5 1/2] ipmi: add a KCS IPMI BMC driver

On 2018-02-02 21:52, Corey Minyard wrote: On 02/01/2018 08:16 PM, Haiyue Wang wrote: --- v4->v5 - Fix -Wdiscarded-qualifiers 'const' compile warning. - Fix size_t printk compile error. v3->v4 - Change to accept WRITE_START any time. v2->v3 - Update the KCS phase state machine. - Fix the race

Re: [PATCH arm/aspeed/ast2500 v4 1/2] ipmi: add a KCS IPMI BMC driver

On 2018-02-02 09:10, Corey Minyard wrote: I loaded this in, tried a compile on x86_64, and got the following: In file included from ../drivers/char/ipmi/kcs_bmc.c:15:0: ../drivers/char/ipmi/kcs_bmc.h: In function ‘kcs_bmc_priv’: ../drivers/char/ipmi/kcs_bmc.h:100:9: warning: return discards

Re: [PATCH arm/aspeed/ast2500 v4 1/2] ipmi: add a KCS IPMI BMC driver

On 2018-02-02 09:10, Corey Minyard wrote: I loaded this in, tried a compile on x86_64, and got the following: In file included from ../drivers/char/ipmi/kcs_bmc.c:15:0: ../drivers/char/ipmi/kcs_bmc.h: In function ‘kcs_bmc_priv’: ../drivers/char/ipmi/kcs_bmc.h:100:9: warning: return discards

Re: [PATCH arm/aspeed/ast2500 v3 1/2] ipmi: add a KCS IPMI BMC driver

On 2018-02-02 04:32, Corey Minyard wrote: +static void kcs_bmc_handle_cmd(struct kcs_bmc *kcs_bmc) +{ +    u8 cmd; + +    set_state(kcs_bmc, WRITE_STATE); +    write_data(kcs_bmc, KCS_ZERO_DATA); + +    cmd = read_data(kcs_bmc); +    switch (cmd) { +    case KCS_CMD_WRITE_START: +    if

Re: [PATCH arm/aspeed/ast2500 v3 1/2] ipmi: add a KCS IPMI BMC driver

On 2018-02-02 04:32, Corey Minyard wrote: +static void kcs_bmc_handle_cmd(struct kcs_bmc *kcs_bmc) +{ +    u8 cmd; + +    set_state(kcs_bmc, WRITE_STATE); +    write_data(kcs_bmc, KCS_ZERO_DATA); + +    cmd = read_data(kcs_bmc); +    switch (cmd) { +    case KCS_CMD_WRITE_START: +    if

Re: [PATCH arm/aspeed/ast2500 v2] ipmi: add an Aspeed KCS IPMI BMC driver

On 2018-01-31 09:52, Corey Minyard wrote: On 01/30/2018 07:37 PM, Wang, Haiyue wrote: On 2018-01-31 09:25, Corey Minyard wrote: On 01/30/2018 07:02 PM, Wang, Haiyue wrote: On 2018-01-31 08:52, Corey Minyard wrote: On 01/30/2018 06:02 PM, Wang, Haiyue wrote: On 2018-01-30 21:49

Re: [PATCH arm/aspeed/ast2500 v2] ipmi: add an Aspeed KCS IPMI BMC driver

On 2018-01-31 09:52, Corey Minyard wrote: On 01/30/2018 07:37 PM, Wang, Haiyue wrote: On 2018-01-31 09:25, Corey Minyard wrote: On 01/30/2018 07:02 PM, Wang, Haiyue wrote: On 2018-01-31 08:52, Corey Minyard wrote: On 01/30/2018 06:02 PM, Wang, Haiyue wrote: On 2018-01-30 21:49

Re: [PATCH arm/aspeed/ast2500 v2] ipmi: add an Aspeed KCS IPMI BMC driver

On 2018-01-31 09:25, Corey Minyard wrote: On 01/30/2018 07:02 PM, Wang, Haiyue wrote: On 2018-01-31 08:52, Corey Minyard wrote: On 01/30/2018 06:02 PM, Wang, Haiyue wrote: On 2018-01-30 21:49, Corey Minyard wrote: On 01/29/2018 07:57 AM, Wang, Haiyue wrote: On 2018-01-26 22:48

Re: [PATCH arm/aspeed/ast2500 v2] ipmi: add an Aspeed KCS IPMI BMC driver

On 2018-01-31 09:25, Corey Minyard wrote: On 01/30/2018 07:02 PM, Wang, Haiyue wrote: On 2018-01-31 08:52, Corey Minyard wrote: On 01/30/2018 06:02 PM, Wang, Haiyue wrote: On 2018-01-30 21:49, Corey Minyard wrote: On 01/29/2018 07:57 AM, Wang, Haiyue wrote: On 2018-01-26 22:48

Re: [PATCH arm/aspeed/ast2500 v2] ipmi: add an Aspeed KCS IPMI BMC driver

On 2018-01-31 08:52, Corey Minyard wrote: On 01/30/2018 06:02 PM, Wang, Haiyue wrote: On 2018-01-30 21:49, Corey Minyard wrote: On 01/29/2018 07:57 AM, Wang, Haiyue wrote: On 2018-01-26 22:48, Corey Minyard wrote: On 01/26/2018 12:08 AM, Wang, Haiyue wrote: On 2018-01-25 01:48

Re: [PATCH arm/aspeed/ast2500 v2] ipmi: add an Aspeed KCS IPMI BMC driver

On 2018-01-31 08:52, Corey Minyard wrote: On 01/30/2018 06:02 PM, Wang, Haiyue wrote: On 2018-01-30 21:49, Corey Minyard wrote: On 01/29/2018 07:57 AM, Wang, Haiyue wrote: On 2018-01-26 22:48, Corey Minyard wrote: On 01/26/2018 12:08 AM, Wang, Haiyue wrote: On 2018-01-25 01:48

Re: [PATCH arm/aspeed/ast2500 v2] ipmi: add an Aspeed KCS IPMI BMC driver

On 2018-01-30 21:49, Corey Minyard wrote: On 01/29/2018 07:57 AM, Wang, Haiyue wrote: On 2018-01-26 22:48, Corey Minyard wrote: On 01/26/2018 12:08 AM, Wang, Haiyue wrote: On 2018-01-25 01:48, Corey Minyard wrote: On 01/24/2018 10:06 AM, Haiyue Wang wrote: The KCS (Keyboard Controller

Re: [PATCH arm/aspeed/ast2500 v2] ipmi: add an Aspeed KCS IPMI BMC driver

On 2018-01-30 21:49, Corey Minyard wrote: On 01/29/2018 07:57 AM, Wang, Haiyue wrote: On 2018-01-26 22:48, Corey Minyard wrote: On 01/26/2018 12:08 AM, Wang, Haiyue wrote: On 2018-01-25 01:48, Corey Minyard wrote: On 01/24/2018 10:06 AM, Haiyue Wang wrote: The KCS (Keyboard Controller

Re: [PATCH arm/aspeed/ast2500 v2] ipmi: add an Aspeed KCS IPMI BMC driver

On 2018-01-26 22:48, Corey Minyard wrote: On 01/26/2018 12:08 AM, Wang, Haiyue wrote: On 2018-01-25 01:48, Corey Minyard wrote: On 01/24/2018 10:06 AM, Haiyue Wang wrote: The KCS (Keyboard Controller Style) interface is used to perform in-band IPMI communication between a server host

Re: [PATCH arm/aspeed/ast2500 v2] ipmi: add an Aspeed KCS IPMI BMC driver

On 2018-01-26 22:48, Corey Minyard wrote: On 01/26/2018 12:08 AM, Wang, Haiyue wrote: On 2018-01-25 01:48, Corey Minyard wrote: On 01/24/2018 10:06 AM, Haiyue Wang wrote: The KCS (Keyboard Controller Style) interface is used to perform in-band IPMI communication between a server host

Re: [PATCH arm/aspeed/ast2500 v2] ipmi: add an Aspeed KCS IPMI BMC driver

On 2018-01-25 01:48, Corey Minyard wrote: On 01/24/2018 10:06 AM, Haiyue Wang wrote: The KCS (Keyboard Controller Style) interface is used to perform in-band IPMI communication between a server host and its BMC (BaseBoard Management Controllers). This driver exposes the KCS interface on

Re: [PATCH arm/aspeed/ast2500 v2] ipmi: add an Aspeed KCS IPMI BMC driver

On 2018-01-25 01:48, Corey Minyard wrote: On 01/24/2018 10:06 AM, Haiyue Wang wrote: The KCS (Keyboard Controller Style) interface is used to perform in-band IPMI communication between a server host and its BMC (BaseBoard Management Controllers). This driver exposes the KCS interface on

Re: [PATCH arm/aspeed/ast2500 v2] ipmi: add an Aspeed KCS IPMI BMC driver

On 2018-01-25 01:48, Corey Minyard wrote: On 01/24/2018 10:06 AM, Haiyue Wang wrote: The KCS (Keyboard Controller Style) interface is used to perform in-band IPMI communication between a server host and its BMC (BaseBoard Management Controllers). This driver exposes the KCS interface on

Re: [PATCH arm/aspeed/ast2500 v2] ipmi: add an Aspeed KCS IPMI BMC driver

On 2018-01-25 01:48, Corey Minyard wrote: On 01/24/2018 10:06 AM, Haiyue Wang wrote: The KCS (Keyboard Controller Style) interface is used to perform in-band IPMI communication between a server host and its BMC (BaseBoard Management Controllers). This driver exposes the KCS interface on

Re: [PATCH arm/aspeed/ast2500 v2] ipmi: add an Aspeed KCS IPMI BMC driver

On 2018-01-25 01:05, Andy Shevchenko wrote: On Thu, 2018-01-25 at 00:06 +0800, Haiyue Wang wrote: The KCS (Keyboard Controller Style) interface is used to perform in- band IPMI communication between a server host and its BMC (BaseBoard Management Controllers). +config ASPEED_KCS_IPMI_BMC +

Re: [PATCH arm/aspeed/ast2500 v2] ipmi: add an Aspeed KCS IPMI BMC driver

On 2018-01-25 01:05, Andy Shevchenko wrote: On Thu, 2018-01-25 at 00:06 +0800, Haiyue Wang wrote: The KCS (Keyboard Controller Style) interface is used to perform in- band IPMI communication between a server host and its BMC (BaseBoard Management Controllers). +config ASPEED_KCS_IPMI_BMC +

Re: [PATCH arm/aspeed/ast2500 v1] eSPI: add Aspeed AST2500 eSPI driver to boot a host with PCH runs on eSPI

On 2018-01-23 16:44, Greg KH wrote: On Tue, Jan 16, 2018 at 07:52:32PM +0800, Haiyue Wang wrote: When PCH works under eSPI mode, the PMC (Power Management Controller) in PCH is waiting for SUS_ACK from BMC after it alerts SUS_WARN. It is in dead loop if no SUS_ACK assert. This is the basic

Re: [PATCH arm/aspeed/ast2500 v1] eSPI: add Aspeed AST2500 eSPI driver to boot a host with PCH runs on eSPI

On 2018-01-23 16:44, Greg KH wrote: On Tue, Jan 16, 2018 at 07:52:32PM +0800, Haiyue Wang wrote: When PCH works under eSPI mode, the PMC (Power Management Controller) in PCH is waiting for SUS_ACK from BMC after it alerts SUS_WARN. It is in dead loop if no SUS_ACK assert. This is the basic

Re: [PATCH arm/aspeed/ast2500 v1] ipmi: add an Aspeed KCS IPMI BMC driver

On 2018-01-18 10:58, Corey Minyard wrote: On 01/17/2018 06:16 PM, Wang, Haiyue wrote: On 2018-01-17 23:59, Corey Minyard wrote: On 01/17/2018 08:31 AM, Wang, Haiyue wrote: On 2018-01-17 06:12, Corey Minyard wrote: On 01/16/2018 02:59 PM, Corey Minyard wrote: On 01/16/2018 05:43 AM

Re: [PATCH arm/aspeed/ast2500 v1] ipmi: add an Aspeed KCS IPMI BMC driver

On 2018-01-18 10:58, Corey Minyard wrote: On 01/17/2018 06:16 PM, Wang, Haiyue wrote: On 2018-01-17 23:59, Corey Minyard wrote: On 01/17/2018 08:31 AM, Wang, Haiyue wrote: On 2018-01-17 06:12, Corey Minyard wrote: On 01/16/2018 02:59 PM, Corey Minyard wrote: On 01/16/2018 05:43 AM

Re: [PATCH arm/aspeed/ast2500 v1] ipmi: add an Aspeed KCS IPMI BMC driver

On 2018-01-18 00:31, Corey Minyard wrote: On 01/17/2018 08:31 AM, Wang, Haiyue wrote: Snip... + +struct kcs_bmc { +    struct regmap *map; +    spinlock_t lock; This lock is only used in threads, as far as I can tell. Couldn't it just be a normal mutex? But more on this later

Re: [PATCH arm/aspeed/ast2500 v1] ipmi: add an Aspeed KCS IPMI BMC driver

On 2018-01-18 00:31, Corey Minyard wrote: On 01/17/2018 08:31 AM, Wang, Haiyue wrote: Snip... + +struct kcs_bmc { +    struct regmap *map; +    spinlock_t lock; This lock is only used in threads, as far as I can tell. Couldn't it just be a normal mutex? But more on this later

Re: [PATCH arm/aspeed/ast2500 v1] ipmi: add an Aspeed KCS IPMI BMC driver

On 2018-01-17 23:59, Corey Minyard wrote: On 01/17/2018 08:31 AM, Wang, Haiyue wrote: On 2018-01-17 06:12, Corey Minyard wrote: On 01/16/2018 02:59 PM, Corey Minyard wrote: On 01/16/2018 05:43 AM, Haiyue Wang wrote: The KCS (Keyboard Controller Style) interface is used to perform in-band

Re: [PATCH arm/aspeed/ast2500 v1] ipmi: add an Aspeed KCS IPMI BMC driver

On 2018-01-17 23:59, Corey Minyard wrote: On 01/17/2018 08:31 AM, Wang, Haiyue wrote: On 2018-01-17 06:12, Corey Minyard wrote: On 01/16/2018 02:59 PM, Corey Minyard wrote: On 01/16/2018 05:43 AM, Haiyue Wang wrote: The KCS (Keyboard Controller Style) interface is used to perform in-band

Re: [PATCH arm/aspeed/ast2500 v1] ipmi: add an Aspeed KCS IPMI BMC driver

Thanks Avi, wait for your response when new patch is ready. :-) BR, Haiyue On 2018-01-17 20:54, Avi Fishman wrote: Sounds great for us (Nuvoton). Avi. On Wed, Jan 17, 2018 at 8:32 AM, Wang, Haiyue <haiyue.w...@linux.intel.com> wrote: On 2018-01-17 07:06, Joel Stanley wrote: On Tue,

Re: [PATCH arm/aspeed/ast2500 v1] ipmi: add an Aspeed KCS IPMI BMC driver

Thanks Avi, wait for your response when new patch is ready. :-) BR, Haiyue On 2018-01-17 20:54, Avi Fishman wrote: Sounds great for us (Nuvoton). Avi. On Wed, Jan 17, 2018 at 8:32 AM, Wang, Haiyue wrote: On 2018-01-17 07:06, Joel Stanley wrote: On Tue, Jan 16, 2018 at 2:59 PM, Corey

Re: [PATCH arm/aspeed/ast2500 v1] ipmi: add an Aspeed KCS IPMI BMC driver

On 2018-01-17 06:12, Corey Minyard wrote: On 01/16/2018 02:59 PM, Corey Minyard wrote: On 01/16/2018 05:43 AM, Haiyue Wang wrote: The KCS (Keyboard Controller Style) interface is used to perform in-band IPMI communication between a server host and its BMC (BaseBoard Management

Re: [PATCH arm/aspeed/ast2500 v1] ipmi: add an Aspeed KCS IPMI BMC driver

On 2018-01-17 06:12, Corey Minyard wrote: On 01/16/2018 02:59 PM, Corey Minyard wrote: On 01/16/2018 05:43 AM, Haiyue Wang wrote: The KCS (Keyboard Controller Style) interface is used to perform in-band IPMI communication between a server host and its BMC (BaseBoard Management

Re: [PATCH arm/aspeed/ast2500 v1] ipmi: add an Aspeed KCS IPMI BMC driver

On 2018-01-17 07:06, Joel Stanley wrote: On Tue, Jan 16, 2018 at 2:59 PM, Corey Minyard wrote: On 01/16/2018 05:43 AM, Haiyue Wang wrote: The KCS (Keyboard Controller Style) interface is used to perform in-band IPMI communication between a server host and its BMC (BaseBoard

Re: [PATCH arm/aspeed/ast2500 v1] ipmi: add an Aspeed KCS IPMI BMC driver

On 2018-01-17 07:06, Joel Stanley wrote: On Tue, Jan 16, 2018 at 2:59 PM, Corey Minyard wrote: On 01/16/2018 05:43 AM, Haiyue Wang wrote: The KCS (Keyboard Controller Style) interface is used to perform in-band IPMI communication between a server host and its BMC (BaseBoard Management

Re: [PATCH v1] eSPI: add Aspeed AST2500 eSPI driver to boot a host with PCH runs on eSPI

On 2018-01-04 01:08, Wang, Haiyue wrote: On 2018-01-04 00:43, Wang, Haiyue wrote: On 2018-01-03 23:17, Arnd Bergmann wrote: On Wed, Jan 3, 2018 at 3:21 AM, Wang, Haiyue <haiyue.w...@linux.intel.com> wrote: On 2018-01-03 00:23, Arnd Bergmann wrote: On Tue, Jan 2, 2018 at 4:36 PM

Re: [PATCH v1] eSPI: add Aspeed AST2500 eSPI driver to boot a host with PCH runs on eSPI

On 2018-01-04 01:08, Wang, Haiyue wrote: On 2018-01-04 00:43, Wang, Haiyue wrote: On 2018-01-03 23:17, Arnd Bergmann wrote: On Wed, Jan 3, 2018 at 3:21 AM, Wang, Haiyue wrote: On 2018-01-03 00:23, Arnd Bergmann wrote: On Tue, Jan 2, 2018 at 4:36 PM, Wang, Haiyue wrote: On 2018-01-02

Re: [PATCH v1] eSPI: add Aspeed AST2500 eSPI driver to boot a host with PCH runs on eSPI

On 2018-01-03 22:32, Mark Brown wrote: On Wed, Jan 03, 2018 at 10:28:22PM +0800, Wang, Haiyue wrote: Should send to like this ? Because I add patch for Aspeed chip: ./scripts/get_maintainer.pl drivers/misc/aspeed-lpc-snoop.c Joel Stanley <j...@jms.id.au> (maintainer:ARM/ASPEED M

Re: [PATCH v1] eSPI: add Aspeed AST2500 eSPI driver to boot a host with PCH runs on eSPI

On 2018-01-03 22:32, Mark Brown wrote: On Wed, Jan 03, 2018 at 10:28:22PM +0800, Wang, Haiyue wrote: Should send to like this ? Because I add patch for Aspeed chip: ./scripts/get_maintainer.pl drivers/misc/aspeed-lpc-snoop.c Joel Stanley (maintainer:ARM/ASPEED MACHINE SUPPORT) Arnd Bergmann

Re: [PATCH v1] eSPI: add Aspeed AST2500 eSPI driver to boot a host with PCH runs on eSPI

On 2018-01-03 19:38, Mark Brown wrote: On Sun, Dec 31, 2017 at 12:10:51AM +0100, Arnd Bergmann wrote: On Fri, Dec 29, 2017 at 2:53 AM, Haiyue Wang wrote: When PCH works under eSPI mode, the PMC (Power Management Controller) in PCH is waiting for SUS_ACK from BMC

Re: [PATCH v1] eSPI: add Aspeed AST2500 eSPI driver to boot a host with PCH runs on eSPI

On 2018-01-03 19:38, Mark Brown wrote: On Sun, Dec 31, 2017 at 12:10:51AM +0100, Arnd Bergmann wrote: On Fri, Dec 29, 2017 at 2:53 AM, Haiyue Wang wrote: When PCH works under eSPI mode, the PMC (Power Management Controller) in PCH is waiting for SUS_ACK from BMC after it alerts SUS_WARN. It

Re: [PATCH v1] eSPI: add Aspeed AST2500 eSPI driver to boot a host with PCH runs on eSPI

On 2018-01-03 00:23, Arnd Bergmann wrote: On Tue, Jan 2, 2018 at 4:36 PM, Wang, Haiyue <haiyue.w...@linux.intel.com> wrote: On 2018-01-02 23:13, Arnd Bergmann wrote: On 2017-12-31 07:10, Arnd Bergmann wrote: It also seems rather inflexible to have a single driver that is responsibl

Re: [PATCH v1] eSPI: add Aspeed AST2500 eSPI driver to boot a host with PCH runs on eSPI

On 2018-01-03 00:23, Arnd Bergmann wrote: On Tue, Jan 2, 2018 at 4:36 PM, Wang, Haiyue wrote: On 2018-01-02 23:13, Arnd Bergmann wrote: On 2017-12-31 07:10, Arnd Bergmann wrote: It also seems rather inflexible to have a single driver that is responsible both for the transport (eSPI

Re: [PATCH v1] eSPI: add Aspeed AST2500 eSPI driver to boot a host with PCH runs on eSPI

On 2018-01-02 23:13, Arnd Bergmann wrote: On 2017-12-31 07:10, Arnd Bergmann wrote: On Fri, Dec 29, 2017 at 2:53 AM, Haiyue Wang wrote: When PCH works under eSPI mode, the PMC (Power Management Controller) in PCH is waiting for SUS_ACK from BMC after it alerts

Re: [PATCH v1] eSPI: add Aspeed AST2500 eSPI driver to boot a host with PCH runs on eSPI

On 2018-01-02 23:13, Arnd Bergmann wrote: On 2017-12-31 07:10, Arnd Bergmann wrote: On Fri, Dec 29, 2017 at 2:53 AM, Haiyue Wang wrote: When PCH works under eSPI mode, the PMC (Power Management Controller) in PCH is waiting for SUS_ACK from BMC after it alerts SUS_WARN. It is in dead loop

Re: [PATCH linux ipmi for BMC v2] ipmi: add an Aspeed KCS IPMI BMC driver

On 2017-12-21 09:07, Joel Stanley wrote: On Thu, Dec 21, 2017 at 6:41 AM, Corey Minyard wrote: On 12/14/2017 10:34 PM, Haiyue Wang wrote: This patch adds a simple device driver to expose the KCS interface on Aspeed SOCs (AST2400 and AST2500) as a character device. Such

Re: [PATCH linux ipmi for BMC v2] ipmi: add an Aspeed KCS IPMI BMC driver

On 2017-12-21 09:07, Joel Stanley wrote: On Thu, Dec 21, 2017 at 6:41 AM, Corey Minyard wrote: On 12/14/2017 10:34 PM, Haiyue Wang wrote: This patch adds a simple device driver to expose the KCS interface on Aspeed SOCs (AST2400 and AST2500) as a character device. Such SOCs are commonly

Re: [PATCH linux ipmi for BMC v2] ipmi: add an Aspeed KCS IPMI BMC driver

On 2017-12-21 09:12, Corey Minyard wrote: On 12/20/2017 06:59 PM, Wang, Haiyue wrote: On 2017-12-21 04:11, Corey Minyard wrote: On 12/14/2017 10:34 PM, Haiyue Wang wrote: This patch adds a simple device driver to expose the KCS interface on Aspeed SOCs (AST2400 and AST2500) as a character

Re: [PATCH linux ipmi for BMC v2] ipmi: add an Aspeed KCS IPMI BMC driver

On 2017-12-21 09:12, Corey Minyard wrote: On 12/20/2017 06:59 PM, Wang, Haiyue wrote: On 2017-12-21 04:11, Corey Minyard wrote: On 12/14/2017 10:34 PM, Haiyue Wang wrote: This patch adds a simple device driver to expose the KCS interface on Aspeed SOCs (AST2400 and AST2500) as a character

Re: [PATCH linux ipmi for BMC v2] ipmi: add an Aspeed KCS IPMI BMC driver

On 2017-12-21 04:11, Corey Minyard wrote: On 12/14/2017 10:34 PM, Haiyue Wang wrote: This patch adds a simple device driver to expose the KCS interface on Aspeed SOCs (AST2400 and AST2500) as a character device. Such SOCs are commonly used as BMCs (BaseBoard Management Controllers) and this

Re: [PATCH linux ipmi for BMC v2] ipmi: add an Aspeed KCS IPMI BMC driver

On 2017-12-21 04:11, Corey Minyard wrote: On 12/14/2017 10:34 PM, Haiyue Wang wrote: This patch adds a simple device driver to expose the KCS interface on Aspeed SOCs (AST2400 and AST2500) as a character device. Such SOCs are commonly used as BMCs (BaseBoard Management Controllers) and this