Re: [PATCH v1 2/3] armv8: gpio: add gpio feature

2020-05-09 Thread Russell King - ARM Linux admin
On Sat, May 09, 2020 at 07:18:45PM +0100, Russell King - ARM Linux admin wrote: > On Sat, May 09, 2020 at 11:34:59PM +0530, Amit Tomer wrote: > > > From what I can tell, these patches are not for the kernel. The > > > filenames don't match th kernel layout. > > > &g

Re: [PATCH v1 2/3] armv8: gpio: add gpio feature

2020-05-09 Thread Russell King - ARM Linux admin
On Sat, May 09, 2020 at 11:34:59PM +0530, Amit Tomer wrote: > > From what I can tell, these patches are not for the kernel. The > > filenames don't match th kernel layout. > > These files looks to be from U-boot, and must be intended for U-boot > as I see U-boot mailing address in recipient's

Re: [PATCH v1 2/3] armv8: gpio: add gpio feature

2020-05-09 Thread Russell King - ARM Linux admin
On Sat, May 09, 2020 at 05:33:15PM +0200, Andrew Lunn wrote: > On Sat, May 09, 2020 at 06:39:55PM +0800, Hui Song wrote: > > From: "hui.song" > > > > add one struct mpc8xxx_gpio_plat to enable gpio feature. > > > > Signed-off-by: hui.song > > --- > > .../include/asm/arch-fsl-layerscape/gpio.h

Re: [EXT] Re: [PATCH net-next 3/5] net: mvpp2: cls: Use RSS contexts to handle RSS tables

2020-05-09 Thread Russell King - ARM Linux admin
On Sat, May 09, 2020 at 02:51:05PM +0100, Russell King - ARM Linux admin wrote: > On Sat, May 09, 2020 at 03:14:05PM +0200, Matteo Croce wrote: > > On Sat, May 9, 2020 at 1:45 PM Russell King - ARM Linux admin > > wrote: > > > > > > On Sat, May 09, 2020 at 11:15

Re: [EXT] Re: [PATCH net-next 3/5] net: mvpp2: cls: Use RSS contexts to handle RSS tables

2020-05-09 Thread Russell King - ARM Linux admin
On Sat, May 09, 2020 at 03:14:05PM +0200, Matteo Croce wrote: > On Sat, May 9, 2020 at 1:45 PM Russell King - ARM Linux admin > wrote: > > > > On Sat, May 09, 2020 at 11:15:58AM +, Stefan Chulski wrote: > > > > > > > > > > -Original Messa

Re: [EXT] Re: [PATCH net-next 3/5] net: mvpp2: cls: Use RSS contexts to handle RSS tables

2020-05-09 Thread Russell King - ARM Linux admin
t; ; Antoine Tenart > > ; Thomas Petazzoni > > ; gregory.clem...@bootlin.com; > > miquel.ray...@bootlin.com; Nadav Haklai ; Marcin > > Wojtas ; Linux ARM > ker...@lists.infradead.org>; Russell King - ARM Linux admin > > > > Subject: Re: [EXT] Re: [PATCH net-n

Re: [EXT] Re: [PATCH net-next 3/5] net: mvpp2: cls: Use RSS contexts to handle RSS tables

2020-05-09 Thread Russell King - ARM Linux admin
On Sat, May 09, 2020 at 02:16:44PM +0200, Thomas Petazzoni wrote: > Hello, > > On Sat, 9 May 2020 12:45:18 +0100 > Russell King - ARM Linux admin wrote: > > > Looking at the timeline here, it looks like Matteo raised the issue > > very quickly after the patch

Re: [EXT] Re: [PATCH net-next 3/5] net: mvpp2: cls: Use RSS contexts to handle RSS tables

2020-05-09 Thread Russell King - ARM Linux admin
gt; Tenart ; Thomas Petazzoni > > ; gregory.clem...@bootlin.com; > > miquel.ray...@bootlin.com; Nadav Haklai ; Stefan > > Chulski ; Marcin Wojtas ; Linux > > ARM ; Russell King - ARM Linux admin > > > > Subject: [EXT] Re: [PATCH net-next 3/5] net: mvpp2: cls: Use

Re: [PATCH v1 1/3] gpio: mpc8xxx: support fsl-layerscape platform.

2020-05-09 Thread Russell King - ARM Linux admin
On Sat, May 09, 2020 at 06:35:35PM +0800, Hui Song wrote: > From: "hui.song" > > Make the MPC8XXX gpio driver to support the fsl-layerscape. > > Signed-off-by: hui.song > --- > drivers/gpio/mpc8xxx_gpio.c | 59 + > 1 file changed, 59 insertions(+) What

Re: [PATCH] ARM: OMAP2+: remove unneeded variable "errata" in configure_dma_errata()

2020-05-06 Thread Russell King - ARM Linux admin
On Wed, May 06, 2020 at 02:19:00PM +0800, Jason Yan wrote: > Fix the following coccicheck warning: > > arch/arm/mach-omap2/dma.c:82:10-16: Unneeded variable: "errata". Return > "0" on line 161 NAK. Look closer at what the code is doing, thanks. This warning is basically incorrect. -- RMK's

Re: [net-next PATCH v3 1/5] net: phy: Introduce phy related fwnode functions

2020-05-05 Thread Russell King - ARM Linux admin
On Tue, May 05, 2020 at 06:59:01PM +0530, Calvin Johnson wrote: > +static inline struct phy_device *device_phy_find_device(struct device *dev) > +{ > + return NULL; > +} > + > +struct fwnode_handle *fwnode_get_phy_node(struct fwnode_handle *fwnode) > +{ > + return NULL; > +} This wants to

Re: [net-next PATCH v3 1/5] net: phy: Introduce phy related fwnode functions

2020-05-05 Thread Russell King - ARM Linux admin
On Tue, May 05, 2020 at 06:59:01PM +0530, Calvin Johnson wrote: > Define fwnode_phy_find_device() to iterate an mdiobus and find the > phy device of the provided phy fwnode. Additionally define > device_phy_find_device() to find phy device of provided device. > > Define fwnode_get_phy_node() to

Re: [net-next PATCH v3 3/5] phylink: Introduce phylink_fwnode_phy_connect()

2020-05-05 Thread Russell King - ARM Linux admin
On Tue, May 05, 2020 at 06:59:03PM +0530, Calvin Johnson wrote: > Define phylink_fwnode_phy_connect() to connect phy specified by > a fwnode to a phylink instance. > > Signed-off-by: Calvin Johnson > --- > > Changes in v3: > remove NULL return check as it is invalid > remove unused

Re: [net-next PATCH v3 4/5] net: phy: Introduce fwnode_get_phy_id()

2020-05-05 Thread Russell King - ARM Linux admin
On Tue, May 05, 2020 at 05:15:16PM +0300, Andy Shevchenko wrote: > On Tue, May 5, 2020 at 4:29 PM Calvin Johnson > > + if (sscanf(cp, "ethernet-phy-id%4x.%4x", > > + , ) == 2) { > > > + *phy_id = ((upper & 0x) << 16) | (lower & > >

Re: [PATCH] ARM: use ARM unwinder for gcov

2020-05-05 Thread Russell King - ARM Linux admin
On Tue, May 05, 2020 at 04:11:56PM +0200, Arnd Bergmann wrote: > Using gcov on ARM fails when the frame pointer unwinder is used: > > arm-linux-gnueabi-ld: kernel/softirq.o:(.ARM.exidx+0x120): undefined > reference to `__aeabi_unwind_cpp_pr0' > arm-linux-gnueabi-ld:

Re: [Patch include request] ARM: dts: imx6qdl-sr-som-ti: indicate powering off wifi is safe

2020-05-04 Thread Russell King - ARM Linux admin
On Mon, May 04, 2020 at 11:58:32AM +0200, Greg KH wrote: > On Fri, May 01, 2020 at 09:23:49PM +0100, Miguel Borges de Freitas wrote: > > Dear all, > > > > This is a request to backport b7dc7205b2ae6b6c9d9cfc3e47d6f08da8647b10 > > (Arm: dts: imx6qdl-sr-som-ti: indicate powering off wifi is safe),

Re: [PATCH] arm: Drop CONFIG_MTD_M25P80 in various defconfig files

2020-05-02 Thread Russell King - ARM Linux admin
On Fri, May 01, 2020 at 09:23:28PM -0700, Bin Meng wrote: > From: Bin Meng > > Drop CONFIG_MTD_M25P80 that was removed in > commit b35b9a10362d ("mtd: spi-nor: Move m25p80 code in spi-nor.c") Have you checked whether these defconfigs contain the new symbol? It seems at least one does not. $

Re: [PATCH] net: dsa: sja1105: fix speed setting for 10 MBPS

2020-05-01 Thread Russell King - ARM Linux admin
On Fri, May 01, 2020 at 06:00:52PM +, Walter Harms wrote: > IMHO it would be better to use switch case here to improve readability. > > switch (bmcr & mask) { > > case BMCR_SPEED1000: > speed = SPEED_1000; > break; > case

Re: [PATCH 04/18] ARM: debug-ll: Add support for r8a7742

2020-04-29 Thread Russell King - ARM Linux admin
On Wed, Apr 29, 2020 at 10:56:41PM +0100, Lad Prabhakar wrote: > @@ -1701,6 +1709,7 @@ config DEBUG_UART_PHYS > default 0xe6e6 if DEBUG_RCAR_GEN2_SCIF0 > default 0xe6e68000 if DEBUG_RCAR_GEN2_SCIF1 > default 0xe6ee if DEBUG_RCAR_GEN2_SCIF4 > + default 0xe6c6 if

Re: [PATCH v2 0/5] Fix ELF / FDPIC ELF core dumping, and use mmap_sem properly in there

2020-04-29 Thread Russell King - ARM Linux admin
On Wed, Apr 29, 2020 at 11:49:49PM +0200, Jann Horn wrote: > At the moment, we have that rather ugly mmget_still_valid() helper to > work around : ELF core dumping > doesn't take the mmap_sem while traversing the task's VMAs, and if > anything (like

Re: [PATCH] net: dsa: mv88e6xxx: remove duplicate assignment of struct members

2020-04-29 Thread Russell King - ARM Linux admin
On Wed, Apr 29, 2020 at 10:10:01PM +0800, Jason Yan wrote: > These struct members named 'phylink_validate' was assigned twice: > > static const struct mv88e6xxx_ops mv88e6190_ops = { > .. > .phylink_validate = mv88e6390_phylink_validate, > .. > .phylink_validate =

Re: [PATCH] [v2] ARM: oabi-compat: fix epoll_ctl build failure

2020-04-29 Thread Russell King - ARM Linux admin
On Wed, Apr 29, 2020 at 03:23:24PM +0200, Arnd Bergmann wrote: > Two functions are not declared or defined when CONFIG_EPOLL is > disabled: > > arch/arm/kernel/sys_oabi-compat.c: In function 'sys_oabi_epoll_ctl': > arch/arm/kernel/sys_oabi-compat.c:258:6: error: implicit declaration of >

Re: Xilinx axienet 1000BaseX support

2020-04-29 Thread Russell King - ARM Linux admin
On Tue, Apr 28, 2020 at 05:51:58PM -0600, Robert Hancock wrote: > On 2020-04-28 5:01 p.m., Russell King - ARM Linux admin wrote: > > On Tue, Apr 28, 2020 at 03:59:45PM -0600, Robert Hancock wrote: > > > On 2020-04-22 1:51 a.m., Russell King - ARM Linux admin wrote: > >

Re: Xilinx axienet 1000BaseX support

2020-04-28 Thread Russell King - ARM Linux admin
On Tue, Apr 28, 2020 at 03:59:45PM -0600, Robert Hancock wrote: > On 2020-04-22 1:51 a.m., Russell King - ARM Linux admin wrote: > > On Tue, Apr 21, 2020 at 07:45:47PM -0600, Robert Hancock wrote: > > > Hi Andre/Russell, > > > > > > Just wondering where thin

Re: [PATCH 1/2] Revert "ASoC: hdmi-codec: re-introduce mutex locking"

2019-10-23 Thread Russell King - ARM Linux admin
On Wed, Oct 23, 2019 at 05:37:16PM +0100, Mark Brown wrote: > On Wed, Oct 23, 2019 at 06:12:02PM +0200, Jerome Brunet wrote: > > This reverts commit eb1ecadb7f67dde94ef0efd3ddaed5cb6c9a65ed. > > > > This fixes the following warning reported by lockdep and a potential > > issue with hibernation >

Re: [PATCH v3 1/5] net: ag71xx: port to phylink

2019-10-21 Thread Russell King - ARM Linux admin
On Mon, Oct 21, 2019 at 07:38:07AM +0200, Oleksij Rempel wrote: > +static void ag71xx_mac_validate(struct phylink_config *config, > + unsigned long *supported, > + struct phylink_link_state *state) > { > - struct ag71xx *ag = netdev_priv(ndev);

Re: [PATCH net-next 2/2] net: phy: Add ability to debug RGMII connections

2019-10-18 Thread Russell King - ARM Linux admin
On Fri, Oct 18, 2019 at 04:37:55PM +0300, Vladimir Oltean wrote: > On Fri, 18 Oct 2019 at 16:23, Russell King - ARM Linux admin > wrote: > > > > On Fri, Oct 18, 2019 at 04:09:30PM +0300, Vladimir Oltean wrote: > > > Hi Andrew, > > > > > > On

Re: [PATCH net-next 2/2] net: phy: Add ability to debug RGMII connections

2019-10-18 Thread Russell King - ARM Linux admin
On Fri, Oct 18, 2019 at 04:09:30PM +0300, Vladimir Oltean wrote: > Hi Andrew, > > On Fri, 18 Oct 2019 at 16:01, Andrew Lunn wrote: > > > > > Well, that's the tricky part. You're sending a frame out, with no > > > guarantee you'll get the same frame back in. So I'm not sure that any > > >

Re: [PATCH v2 1/5] net: ag71xx: port to phylink

2019-10-18 Thread Russell King - ARM Linux admin
Hi, On Fri, Oct 18, 2019 at 11:39:25AM +0200, Oleksij Rempel wrote: > The port to phylink was done as close as possible to initial > functionality. > Theoretically this HW can support flow control, practically seems to be not > enough to just enable it. So, more work should be done. > >

Re: [RFC PATCH 0/3] watchdog servicing during decompression

2019-10-17 Thread Russell King - ARM Linux admin
On Thu, Oct 17, 2019 at 02:34:52PM +0200, Rasmus Villemoes wrote: > On 17/10/2019 14.03, Russell King - ARM Linux admin wrote: > > We used to have this on ARM - it was called from the decompressor > > code via an arch_decomp_wdog() hook. > > > > That code got rem

Re: [RFC PATCH 0/3] watchdog servicing during decompression

2019-10-17 Thread Russell King - ARM Linux admin
We used to have this on ARM - it was called from the decompressor code via an arch_decomp_wdog() hook. That code got removed because it is entirely unsuitable for a multi- platform kernel. This looks like it takes an address for the watchdog from the Kconfig, and builds that into the

Re: [PATCH 3/6] PCI: mobiveil: Add PCIe Gen4 EP driver for NXP Layerscape SoCs

2019-10-15 Thread Russell King - ARM Linux admin
On Tue, Oct 15, 2019 at 09:14:00AM +, Xiaowei Bao wrote: > > -Original Message- > > From: Russell King - ARM Linux admin > > Sent: 2019年10月15日 17:08 > > To: Xiaowei Bao > > Cc: Z.q. Hou ; bhelg...@google.com; > > robh...@kernel.org; mark.rutl...@

Re: [PATCH 3/6] PCI: mobiveil: Add PCIe Gen4 EP driver for NXP Layerscape SoCs

2019-10-15 Thread Russell King - ARM Linux admin
On Tue, Oct 15, 2019 at 07:46:12AM +, Xiaowei Bao wrote: > > > > -Original Message- > > From: Russell King - ARM Linux admin > > Sent: 2019年9月25日 0:39 > > To: Xiaowei Bao > > Cc: Z.q. Hou ; bhelg...@google.com; > > robh...@kernel.org; mark

Re: [PATCH v2 1/3] net: phylink: switch to using fwnode_gpiod_get_index()

2019-10-14 Thread Russell King - ARM Linux admin
On Mon, Oct 14, 2019 at 10:40:20AM -0700, Dmitry Torokhov wrote: > Instead of fwnode_get_named_gpiod() that I plan to hide away, let's use > the new fwnode_gpiod_get_index() that mimics gpiod_get_index(), but > works with arbitrary firmware node. > > Reviewed-by: Andy Shevchenko > Acked-by:

Re: [PATCH 3/3] arm64: configs: unset CPU_BIG_ENDIAN

2019-10-12 Thread Russell King - ARM Linux admin
On Sat, Oct 12, 2019 at 12:47:45AM +0200, Arnd Bergmann wrote: > On Fri, Oct 11, 2019 at 12:33 PM Russell King - ARM Linux admin > wrote: > > 32-bit ARM experience is that telco class users really like big > > endian. > > Right, basically anyone with a large code base mi

Re: [PATCH] compiler: enable CONFIG_OPTIMIZE_INLINING forcibly

2019-10-12 Thread Russell King - ARM Linux admin
On Sat, Oct 12, 2019 at 12:15:42PM +0200, Stefan Wahren wrote: > Hi, > > Am 03.10.19 um 18:36 schrieb Will Deacon: > > On Wed, Oct 02, 2019 at 01:39:40PM -0700, Linus Torvalds wrote: > >> On Wed, Oct 2, 2019 at 5:56 AM Geert Uytterhoeven > >> wrote: > Then use the C preprocessor to force

Re: [PATCH 3/3] arm64: configs: unset CPU_BIG_ENDIAN

2019-10-11 Thread Russell King - ARM Linux admin
On Fri, Oct 11, 2019 at 11:27:48AM +0100, Will Deacon wrote: > Does anybody use BIG_ENDIAN? If we're not even building it then maybe we > should get rid of it altogether on arm64. I don't know of any supported > userspace that supports it or any CPUs that are unable to run little-endian >

Re: [PATCH 34/36] ARM: s3c: stop including mach/hardware.h from mach/io.h

2019-10-10 Thread Russell King - ARM Linux admin
On Thu, Oct 10, 2019 at 10:30:18PM +0200, Arnd Bergmann wrote: > A number of other files rely on mach/map.h to be indirectly > included from mach/io.h through mach/hardware.h. > > Reduce this to the minimal plat/map-base.h and add explicit > includes everywhere else. > > Signed-off-by: Arnd

Re: [PATCH 5.3 076/148] mmc: sdhci-of-esdhc: set DMA snooping based on DMA coherence

2019-10-10 Thread Russell King - ARM Linux admin
Hi Greg, On 5th October, Christian Zigotzky reported a problem with this on PowerPC (at a guess, it looks like there's a PowerPC user of this where the DT does not mark the device as dma-coherent, but the hardware requires it to be DMA coherent.) However, despite sending a reply to him within

Re: [PATCH v6] gpio/mpc8xxx: change irq handler from chained to normal

2019-10-09 Thread Russell King - ARM Linux admin
On Wed, Oct 09, 2019 at 04:30:21PM +0800, Hui Song wrote: > From: Song Hui > > More than one gpio controllers can share one interrupt, change the > driver to request shared irq. > > While this will work, it will mess up userspace accounting of the number > of interrupts per second in tools such

Re: MAP_FIXED_NOREPLACE appears to break older i386 binaries

2019-10-06 Thread Russell King - ARM Linux admin
On Sat, Oct 05, 2019 at 05:18:05PM -0700, Linus Torvalds wrote: > Duh. > > I only looked at recent issues in this area, and overlooked your > sentence in between the two ELF section dumps, and it appears that you > have already biseced it to something else: I hadn't - I'd looked at the changes

MAP_FIXED_NOREPLACE appears to break older i386 binaries

2019-10-05 Thread Russell King - ARM Linux admin
Under a 4.19 kernel (debian stable), I am surprised to find that some previously working i386 binaries no longer work, whereas others are fine. ls, for example, dies with a SEGV, but bash is fine. Looking at the kernel log reveals: [13117.361000] 20899 (ls): Uhuuh, elf segment at

Re: [PATCH] panic: Ensure preemption is disabled during panic()

2019-10-04 Thread Russell King - ARM Linux admin
On Fri, Oct 04, 2019 at 11:11:42AM +0200, Petr Mladek wrote: > On Thu 2019-10-03 21:56:34, Will Deacon wrote: > > Hi Kees, > > > > On Wed, Oct 02, 2019 at 01:58:46PM -0700, Kees Cook wrote: > > > On Wed, Oct 02, 2019 at 01:35:38PM +0100, Will Deacon wrote: > > > > Calling 'panic()' on a kernel

Re: [PATCH v2 00/21] Refine memblock API

2019-10-04 Thread Russell King - ARM Linux admin
On Thu, Oct 03, 2019 at 02:30:10PM +0300, Mike Rapoport wrote: > On Thu, Oct 03, 2019 at 09:49:14AM +0100, Russell King - ARM Linux admin > wrote: > > On Thu, Oct 03, 2019 at 08:34:52AM +0300, Mike Rapoport wrote: > > > (trimmed the CC) > > > > > > On Wed,

Re: [PATCH v2 00/21] Refine memblock API

2019-10-04 Thread Russell King - ARM Linux admin
On Thu, Oct 03, 2019 at 07:46:06AM -0700, Chris Healy wrote: > > > > The iMX6 does not have MMUv2 hardware, it has MMUv1. With MMUv1 > > hardware requires command buffers within the first 2GiB of physical > > RAM. > > > I thought that the i.MX6q has the MMUv1 and GC2000 GPU while the > i.MX6qp

Re: [PATCH v2 00/21] Refine memblock API

2019-10-03 Thread Russell King - ARM Linux admin
On Thu, Oct 03, 2019 at 08:34:52AM +0300, Mike Rapoport wrote: > (trimmed the CC) > > On Wed, Oct 02, 2019 at 06:14:11AM -0500, Adam Ford wrote: > > On Wed, Oct 2, 2019 at 2:36 AM Mike Rapoport wrote: > > > > > > > Before the patch: > > > > # cat /sys/kernel/debug/memblock/memory > >0:

Re: [PATCH 0/6] Add the Mobiveil EP and Layerscape Gen4 EP driver support

2019-10-02 Thread Russell King - ARM Linux admin
On Wed, Oct 02, 2019 at 04:14:21PM -0500, Bjorn Helgaas wrote: > On Tue, Sep 24, 2019 at 04:52:23PM +0100, Russell King - ARM Linux admin > wrote: > > On Tue, Sep 24, 2019 at 03:18:47PM +0100, Russell King - ARM Linux admin > > wrote: > > > On Mon, Sep 16, 2019 at 10

Re: [PATCHv3] ARM: drivers/amba: release and cleanup the resource to allow for deferred probe

2019-10-02 Thread Russell King - ARM Linux admin
On Wed, Oct 02, 2019 at 09:35:51AM -0500, Dinh Nguyen wrote: > With commit "79bdcb202a35 ARM: 8906/1: drivers/amba: add reset control to > amba bus probe", the amba bus driver needs to be deferred probe because the > reset driver is probed later. However with a deferred probe, the call to >

Re: [PATCHv2] ARM: drivers/amba: release the resource to allow for deferred probe

2019-10-02 Thread Russell King - ARM Linux admin
On Wed, Oct 02, 2019 at 07:33:49AM -0500, Dinh Nguyen wrote: > With commit "79bdcb202a35 ARM: 8906/1: drivers/amba: add reset control to > amba bus probe", the amba bus driver needs to be deferred probe because the > reset driver is probed later. However with a deferred probe, the call to >

Re: [PATCH v2] ARM: add __always_inline to functions called from __get_user_check()

2019-10-02 Thread Russell King - ARM Linux admin
On Tue, Oct 01, 2019 at 10:03:50AM -0700, Nick Desaulniers wrote: > On Tue, Oct 1, 2019 at 1:37 AM Masahiro Yamada > wrote: > > > > KernelCI reports that bcm2835_defconfig is no longer booting since > > commit ac7c3e4ff401 ("compiler: enable CONFIG_OPTIMIZE_INLINING > > forcibly")

Re: [PATCH] compiler: enable CONFIG_OPTIMIZE_INLINING forcibly

2019-10-01 Thread Russell King - ARM Linux admin
On Tue, Oct 01, 2019 at 02:32:54PM -0700, Nick Desaulniers wrote: > On Tue, Oct 1, 2019 at 2:26 PM Russell King - ARM Linux admin > wrote: > > > > On Tue, Oct 01, 2019 at 09:59:38PM +0100, Russell King - ARM Linux admin > > wrote: > > > On Tue, Oct 01, 2019 at 0

Re: [PATCH] ARM: drivers/amba: release the resource to allow for deferred probe

2019-10-01 Thread Russell King - ARM Linux admin
On Tue, Oct 01, 2019 at 04:40:26PM -0500, Dinh Nguyen wrote: > With commit "79bdcb202a35 ARM: 8906/1: drivers/amba: add reset control to > amba bus probe", the amba bus driver needs to be deferred probe because the > reset driver is probed later than the amba bus. However with a deferred > probe,

Re: [PATCH] compiler: enable CONFIG_OPTIMIZE_INLINING forcibly

2019-10-01 Thread Russell King - ARM Linux admin
On Tue, Oct 01, 2019 at 09:59:38PM +0100, Russell King - ARM Linux admin wrote: > On Tue, Oct 01, 2019 at 01:21:44PM -0700, Nick Desaulniers wrote: > > On Tue, Oct 1, 2019 at 11:14 AM Russell King - ARM Linux admin > > wrote: > > > > > > On Tue, Oct 01, 2019 at 1

Re: [PATCH] compiler: enable CONFIG_OPTIMIZE_INLINING forcibly

2019-10-01 Thread Russell King - ARM Linux admin
On Tue, Oct 01, 2019 at 01:21:44PM -0700, Nick Desaulniers wrote: > On Tue, Oct 1, 2019 at 11:14 AM Russell King - ARM Linux admin > wrote: > > > > On Tue, Oct 01, 2019 at 11:00:11AM -0700, Nick Desaulniers wrote: > > > On Tue, Oct 1, 2019 at 10:55 AM Russell King - A

Re: [PATCH] compiler: enable CONFIG_OPTIMIZE_INLINING forcibly

2019-10-01 Thread Russell King - ARM Linux admin
On Tue, Oct 01, 2019 at 11:00:11AM -0700, Nick Desaulniers wrote: > On Tue, Oct 1, 2019 at 10:55 AM Russell King - ARM Linux admin > wrote: > > > > On Tue, Oct 01, 2019 at 10:44:43AM -0700, Nick Desaulniers wrote: > > > I apologize; I don't mean to be difficult.

Re: [PATCH] compiler: enable CONFIG_OPTIMIZE_INLINING forcibly

2019-10-01 Thread Russell King - ARM Linux admin
On Tue, Oct 01, 2019 at 10:44:43AM -0700, Nick Desaulniers wrote: > I apologize; I don't mean to be difficult. I would just like to avoid > surprises when code written with the assumption that it will be > inlined is not. It sounds like we found one issue in arm32 and one in > arm64 related to

Re: [PATCH] Partially revert "compiler: enable CONFIG_OPTIMIZE_INLINING forcibly"

2019-10-01 Thread Russell King - ARM Linux admin
On Tue, Oct 01, 2019 at 04:28:27PM +0100, Andrew Murray wrote: > I hadn't noticed the use of __OPTIMIZE__ - indeed if __compiletime_assert > is no-op'd and you reach it then you won't have a build error - but you > may get uninitialised values instead. > > Presumably the purpose of __OPTIMIZE__

Re: [PATCH] Partially revert "compiler: enable CONFIG_OPTIMIZE_INLINING forcibly"

2019-10-01 Thread Russell King - ARM Linux admin
On Tue, Oct 01, 2019 at 12:41:30PM +0100, Andrew Murray wrote: > On Tue, Oct 01, 2019 at 11:42:54AM +0100, Will Deacon wrote: > > On Tue, Oct 01, 2019 at 06:40:26PM +0900, Masahiro Yamada wrote: > > > On Mon, Sep 30, 2019 at 8:45 PM Will Deacon wrote: > > > > diff --git a/lib/Kconfig.debug

Re: [PATCH] ARM: fix __get_user_check() in case uaccess_* calls are not inlined

2019-09-30 Thread Russell King - ARM Linux admin
On Mon, Sep 30, 2019 at 02:59:25PM +0900, Masahiro Yamada wrote: > KernelCI reports that bcm2835_defconfig is no longer booting since > commit ac7c3e4ff401 ("compiler: enable CONFIG_OPTIMIZE_INLINING > forcibly"): > > https://lkml.org/lkml/2019/9/26/825 > > I also received a regression report

perf annotate fails with "Invalid -1 error code"

2019-09-30 Thread Russell King - ARM Linux admin
Hi, While using perf report on aarch64, I try to annotate __arch_copy_to_user, and it fails with: Error: Couldn't annotate __arch_copy_to_user: Internal error: Invalid -1 error code which is not very helpful. Looking at the code, the error message appended to the "Couldn't annotate ...:"

Re: [PATCH v5] gpio/mpc8xxx: change irq handler from chained to normal

2019-09-26 Thread Russell King - ARM Linux admin
On Mon, Sep 16, 2019 at 01:58:17PM +0800, Hui Song wrote: > From: Song Hui > > More than one gpio controllers can share one interrupt, change the > driver to request shared irq. > > Signed-off-by: Laurentiu Tudor > Signed-off-by: Alex Marginean > Signed-off-by: Song Hui While this will

Re: [PATCH 4/6] PCI: mobiveil: Add workaround for unsupported request error

2019-09-24 Thread Russell King - ARM Linux admin
On Mon, Sep 16, 2019 at 10:17:40AM +0800, Xiaowei Bao wrote: > Errata: unsupported request error on inbound posted write > transaction, PCIe controller reports advisory error instead > of uncorrectable error message to RC. > > Signed-off-by: Xiaowei Bao > --- >

Re: [PATCH 3/6] PCI: mobiveil: Add PCIe Gen4 EP driver for NXP Layerscape SoCs

2019-09-24 Thread Russell King - ARM Linux admin
On Mon, Sep 16, 2019 at 10:17:39AM +0800, Xiaowei Bao wrote: > This PCIe controller is based on the Mobiveil GPEX IP, it work in EP > mode if select this config opteration. > > Signed-off-by: Xiaowei Bao > --- > MAINTAINERS| 2 + >

Re: [PATCH 0/6] Add the Mobiveil EP and Layerscape Gen4 EP driver support

2019-09-24 Thread Russell King - ARM Linux admin
On Tue, Sep 24, 2019 at 03:18:47PM +0100, Russell King - ARM Linux admin wrote: > On Mon, Sep 16, 2019 at 10:17:36AM +0800, Xiaowei Bao wrote: > > This patch set are for adding Mobiveil EP driver and adding PCIe Gen4 > > EP driver of NXP Layerscape platform. > > >

Re: [PATCH 0/6] Add the Mobiveil EP and Layerscape Gen4 EP driver support

2019-09-24 Thread Russell King - ARM Linux admin
On Mon, Sep 16, 2019 at 10:17:36AM +0800, Xiaowei Bao wrote: > This patch set are for adding Mobiveil EP driver and adding PCIe Gen4 > EP driver of NXP Layerscape platform. > > This patch set depends on: > https://patchwork.kernel.org/project/linux-pci/list/?series=159139 > > Xiaowei Bao (6): >

Re: [PATCH] arm: export memblock_reserve()d regions via /proc/iomem

2019-09-23 Thread Russell King - ARM Linux admin
On Mon, Sep 23, 2019 at 11:42:54PM +0800, Yu Chen wrote: > From: Yu Chen > > On Sat, 21 Sep 2019 15:51:38, Russell King - ARM Linux admin wrote: > > On Sat, Sep 21, 2019 at 09:02:49PM +0800, Yu Chen wrote: > > > From: Yu Chen > > > > > > memblock r

Re: [PATCH] quota: code cleanup for hash bits calculation

2019-09-23 Thread admin
在 星期一, 2019-09-23 18:02:53 Jan Kara 撰写 > On Sat 21-09-19 09:56:28, Chengguang Xu wrote: > > Code cleanup for hash bits calculation by > > calling rounddown_pow_of_two() and ilog2() > > > > Signed-off-by: Chengguang Xu > > Thanks for the patch! One comment below: > > > diff

Re: [PATCH] arm: export memblock_reserve()d regions via /proc/iomem

2019-09-21 Thread Russell King - ARM Linux admin
On Sat, Sep 21, 2019 at 09:02:49PM +0800, Yu Chen wrote: > From: Yu Chen > > memblock reserved regions are not reported via /proc/iomem on ARM, kexec's > user-space doesn't know about memblock_reserve()d regions and thus > possible for kexec to overwrite with the new kernel or initrd. Many

Re: [PATCH] ARM: dts: imx6dl: SolidRun: add phy node with 100Mb/s max-speed

2019-09-20 Thread Russell King - ARM Linux admin
On Tue, Sep 17, 2019 at 10:42:01PM +0100, Russell King - ARM Linux admin wrote: > On Tue, Sep 17, 2019 at 06:19:13PM +0100, Russell King - ARM Linux admin > wrote: > > whether you can get the link to come up at all. You might need to see > > whether wiggling the RJ45 helps (

Re: [PATCH] ARM: dts: imx6dl: SolidRun: add phy node with 100Mb/s max-speed

2019-09-20 Thread Russell King - ARM Linux admin
On Tue, Sep 17, 2019 at 08:39:34PM +0200, Andrew Lunn wrote: > > > Well, the _correct_ driver needs to be used for the PHY specific > > > features to be properly controlled. Using the generic driver > > > in this situation will not be guaranteed to work. > > I fully agree about the PHY driver.

Re: [PATCH] ARM: dts: imx6dl: SolidRun: add phy node with 100Mb/s max-speed

2019-09-17 Thread Russell King - ARM Linux admin
On Tue, Sep 17, 2019 at 11:30:13PM +0100, Russell King - ARM Linux admin wrote: > On Tue, Sep 17, 2019 at 04:32:53PM +0300, tinywrkb wrote: > > Here's the output of # mii-tool -v -v eth0 > > > > * linux-test-5.1rc1-a2703de70942-without_bad_commit > > > >

Re: [PATCH] ARM: dts: imx6dl: SolidRun: add phy node with 100Mb/s max-speed

2019-09-17 Thread Russell King - ARM Linux admin
On Tue, Sep 17, 2019 at 04:32:53PM +0300, tinywrkb wrote: > Here's the output of # mii-tool -v -v eth0 > > * linux-test-5.1rc1-a2703de70942-without_bad_commit > > Using SIOCGMIIPHY=0x8947 > eth0: negotiated 100baseTx-FD flow-control, link ok > registers for MII PHY 0: > 3100 796d 004d

Re: [PATCH] ARM: dts: imx6dl: SolidRun: add phy node with 100Mb/s max-speed

2019-09-17 Thread Russell King - ARM Linux admin
On Tue, Sep 17, 2019 at 06:19:13PM +0100, Russell King - ARM Linux admin wrote: > whether you can get the link to come up at all. You might need to see > whether wiggling the RJ45 helps (I've had that sort of thing with some > cables.) > > You might also need "ethtool -s

Re: [PATCH] ARM: dts: imx6dl: SolidRun: add phy node with 100Mb/s max-speed

2019-09-17 Thread Russell King - ARM Linux admin
On Tue, Sep 17, 2019 at 06:37:28PM +0100, Russell King - ARM Linux admin wrote: > On Tue, Sep 17, 2019 at 07:26:58PM +0200, Andrew Lunn wrote: > > > diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c > > > index b3893347804d..85cf4a4a5e81 100644 > > >

Re: [PATCH] ARM: dts: imx6dl: SolidRun: add phy node with 100Mb/s max-speed

2019-09-17 Thread Russell King - ARM Linux admin
On Tue, Sep 17, 2019 at 07:26:58PM +0200, Andrew Lunn wrote: > > diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c > > index b3893347804d..85cf4a4a5e81 100644 > > --- a/drivers/net/phy/at803x.c > > +++ b/drivers/net/phy/at803x.c > > Hi Russell > > This won't work. In the kernel

Re: [PATCH] ARM: dts: imx6dl: SolidRun: add phy node with 100Mb/s max-speed

2019-09-17 Thread Russell King - ARM Linux admin
On Tue, Sep 17, 2019 at 06:04:19PM +0100, Russell King - ARM Linux admin wrote: > On Tue, Sep 17, 2019 at 07:34:27PM +0300, tinywrkb wrote: > > The patch didn't fix the issue. > > > > # ethtool eth0 > > > > Settings for eth0: > > Supported ports:

Re: [PATCH] ARM: dts: imx6dl: SolidRun: add phy node with 100Mb/s max-speed

2019-09-17 Thread Russell King - ARM Linux admin
On Tue, Sep 17, 2019 at 07:34:27PM +0300, tinywrkb wrote: > The patch didn't fix the issue. > > # ethtool eth0 > > Settings for eth0: > Supported ports: [ TP MII ] > Supported link modes: 10baseT/Half 10baseT/Full > 100baseT/Half 100baseT/Full >

Re: [PATCH] ARM: dts: imx6dl: SolidRun: add phy node with 100Mb/s max-speed

2019-09-17 Thread Russell King - ARM Linux admin
On Tue, Sep 17, 2019 at 04:17:07PM +0100, Russell King - ARM Linux admin wrote: > On Tue, Sep 17, 2019 at 02:39:43PM +0100, Russell King - ARM Linux admin > wrote: > > On Tue, Sep 17, 2019 at 04:32:53PM +0300, tinywrkb wrote: > > > On Tue, Sep 17, 2019 at 02:54:34PM +02

Re: [PATCH] ARM: dts: imx6dl: SolidRun: add phy node with 100Mb/s max-speed

2019-09-17 Thread Russell King - ARM Linux admin
On Tue, Sep 17, 2019 at 02:39:43PM +0100, Russell King - ARM Linux admin wrote: > On Tue, Sep 17, 2019 at 04:32:53PM +0300, tinywrkb wrote: > > On Tue, Sep 17, 2019 at 02:54:34PM +0200, Andrew Lunn wrote: > > > On Tue, Sep 17, 2019 at 03:41:01PM +0300, tinywrkb wrote: > >

Re: [PATCH] ARM: dts: imx6dl: SolidRun: add phy node with 100Mb/s max-speed

2019-09-17 Thread Russell King - ARM Linux admin
On Tue, Sep 17, 2019 at 04:32:53PM +0300, tinywrkb wrote: > On Tue, Sep 17, 2019 at 02:54:34PM +0200, Andrew Lunn wrote: > > On Tue, Sep 17, 2019 at 03:41:01PM +0300, tinywrkb wrote: > > > On Sun, Sep 15, 2019 at 03:56:52PM +0200, Andrew Lunn wrote: > > > > > Tinywrkb confirmed to me in private

Re: [breakage] panic() does not halt arm64 systems under certain conditions

2019-09-17 Thread Russell King - ARM Linux admin
On Tue, Sep 17, 2019 at 11:45:19AM +0100, Will Deacon wrote: > Hi, > > [Expanding CC list; original message is here: > > https://lore.kernel.org/linux-arm-kernel/BX1W47JXPMR8.58IYW53H6M5N@dragonstone/] > > On Mon, Sep 16, 2019 at 09:35:36PM -0400, Xogium wrote: > > On arm64 in some situations

Re: [PATCH] arm: fix page faults in do_alignment

2019-09-15 Thread Russell King - ARM Linux admin
On Fri, Sep 06, 2019 at 04:17:59PM +0100, Russell King - ARM Linux admin wrote: > On Mon, Sep 02, 2019 at 12:36:56PM -0500, Eric W. Biederman wrote: > > Russell King - ARM Linux admin writes: > > > > > On Fri, Aug 30, 2019 at 04:02:48PM -0500, Eric W. Biederman wrote: &

Re: [PATCH] ARM: dts: imx6dl: SolidRun: add phy node with 100Mb/s max-speed

2019-09-15 Thread Russell King - ARM Linux admin
On Sun, Sep 15, 2019 at 04:42:52PM +0200, Andrew Lunn wrote: > > > OF: fdt: Machine model: SolidRun HummingBoard Solo/DualLite > > > ... > > > # ethtool eth0 > > > Settings for eth0: > > > Supported ports: [ TP MII ] > > > Supported link modes: 10baseT/Half 10baseT/Full > > >

Re: [PATCH] ARM: dts: imx6dl: SolidRun: add phy node with 100Mb/s max-speed

2019-09-15 Thread Russell King - ARM Linux admin
On Sun, Sep 15, 2019 at 03:06:39PM +0100, Russell King - ARM Linux admin wrote: > On Sun, Sep 15, 2019 at 03:56:52PM +0200, Andrew Lunn wrote: > > > Tinywrkb confirmed to me in private communication that revert of > > > 5502b218e001 fixes Ethernet for him on effected system.

Re: [PATCH] ARM: dts: imx6dl: SolidRun: add phy node with 100Mb/s max-speed

2019-09-15 Thread Russell King - ARM Linux admin
On Sun, Sep 15, 2019 at 03:56:52PM +0200, Andrew Lunn wrote: > > Tinywrkb confirmed to me in private communication that revert of > > 5502b218e001 fixes Ethernet for him on effected system. > > > > He also referred me to an old Cubox-i spec that lists 10/100 Ethernet > > only for i.MX6

Re: [PATCH] ARM: dts: imx6dl: SolidRun: add phy node with 100Mb/s max-speed

2019-09-15 Thread Russell King - ARM Linux admin
On Sun, Sep 15, 2019 at 09:30:00AM +0300, Baruch Siach wrote: > Hi Andrew, > > On Tue, Sep 10 2019, Andrew Lunn wrote: > > On Tue, Sep 10, 2019 at 06:55:07PM +0300, tinywrkb wrote: > >> Cubox-i Solo/DualLite carrier board has 100Mb/s magnetics while the > >> Atheros AR8035 PHY on the MicroSoM

Re: [RFC PATCH v2 00/12] Unify SMP stop generic logic to common code

2019-09-13 Thread Russell King - ARM Linux admin
On Fri, Sep 13, 2019 at 07:19:41PM +0100, Cristian Marussi wrote: > Tested as follows: > > - arm: > 1. boot So this basically means the code paths you're touching are untested on ARM... given that, and the variety of systems we have out there, why should the patches touching ARM be taken? Given

Re: [PATCH 04/11] net: phylink: switch to using fwnode_gpiod_get_index()

2019-09-12 Thread Russell King - ARM Linux admin
On Thu, Sep 12, 2019 at 04:44:29PM +0300, Andy Shevchenko wrote: > On Thu, Sep 12, 2019 at 10:41:43AM +0100, Linus Walleij wrote: > > On Wed, Sep 11, 2019 at 10:51 AM Dmitry Torokhov > > wrote: > > > > > If we are willing to sacrifice the custom label for the GPIO that > > >

Re: linux-next: Signed-off-by missing for commit in the arm tree

2019-09-11 Thread Russell King - ARM Linux admin
On Wed, Sep 11, 2019 at 03:21:07PM +0100, Mike Rapoport wrote: > On Tue, Sep 10, 2019 at 03:21:28PM +0100, Russell King - ARM Linux admin > wrote: > > This is correctly signed off, but Mike didn't send the patch correctly. > > It missed a From: line for the proper au

Re: [PATCH 04/11] net: phylink: switch to using fwnode_gpiod_get_index()

2019-09-11 Thread Russell King - ARM Linux admin
On Wed, Sep 11, 2019 at 02:55:11AM -0700, Dmitry Torokhov wrote: > On Wed, Sep 11, 2019 at 10:49:29AM +0100, Russell King - ARM Linux admin > wrote: > > On Wed, Sep 11, 2019 at 12:46:19PM +0300, Andy Shevchenko wrote: > > > On Wed, Sep 11, 2019 at 10:39:14AM +0100, Russell K

Re: [PATCH 04/11] net: phylink: switch to using fwnode_gpiod_get_index()

2019-09-11 Thread Russell King - ARM Linux admin
On Wed, Sep 11, 2019 at 12:46:19PM +0300, Andy Shevchenko wrote: > On Wed, Sep 11, 2019 at 10:39:14AM +0100, Russell King - ARM Linux admin > wrote: > > On Wed, Sep 11, 2019 at 12:25:14PM +0300, Andy Shevchenko wrote: > > > On Wed, Sep 11, 2019 at 12:52:08AM -0700,

Re: [PATCH] ARM: module: Drop 'rel->r_offset < 0' always false statement

2019-09-11 Thread Russell King - ARM Linux admin
On Wed, Sep 11, 2019 at 01:54:08PM +0900, Austin Kim wrote: > Since rel->r_offset is declared as Elf32_Addr, > this value is always non-negative. > typedef struct elf32_rel { > Elf32_Addrr_offset; > Elf32_Word r_info; > } Elf32_Rel; > > typedef __u32 Elf32_Addr; > typedef

Re: [PATCH 04/11] net: phylink: switch to using fwnode_gpiod_get_index()

2019-09-11 Thread Russell King - ARM Linux admin
On Wed, Sep 11, 2019 at 12:25:14PM +0300, Andy Shevchenko wrote: > On Wed, Sep 11, 2019 at 12:52:08AM -0700, Dmitry Torokhov wrote: > > Instead of fwnode_get_named_gpiod() that I plan to hide away, let's use > > the new fwnode_gpiod_get_index() that mimics gpiod_get_index(), bit > > works with

Re: [PATCH] ARM: dts: imx6dl: SolidRun: add phy node with 100Mb/s max-speed

2019-09-10 Thread Russell King - ARM Linux admin
On Tue, Sep 10, 2019 at 06:55:07PM +0300, tinywrkb wrote: > Cubox-i Solo/DualLite carrier board has 100Mb/s magnetics while the That statement is false, sorry. All boards support 1G. > Atheros AR8035 PHY on the MicroSoM v1.3 CPU module is a 1GbE PHY device. > > Since commit 5502b218e001 ("net:

Re: linux-next: Signed-off-by missing for commit in the arm tree

2019-09-10 Thread Russell King - ARM Linux admin
This is correctly signed off, but Mike didn't send the patch correctly. It missed a From: line for the proper author, so the patch was committed as if Mike had authored it, which he didn't. On Wed, Sep 11, 2019 at 12:14:59AM +1000, Stephen Rothwell wrote: > Hi all, > > Commit > > 2505b9ba9c37

Re: [PATCH v2] drm: bridge/dw_hdmi: add audio sample channel status setting

2019-09-08 Thread Russell King - ARM Linux admin
On Thu, Sep 05, 2019 at 05:43:25PM +0800, Cheng-Yi Chiang wrote: > From: Yakir Yang > > When transmitting IEC60985 linear PCM audio, we configure the > Aduio Sample Channel Status information of all the channel > status bits in the IEC60958 frame. > Refer to 60958-3 page 10 for frequency,

Re: [PATCH] arm: fix page faults in do_alignment

2019-09-06 Thread Russell King - ARM Linux admin
On Mon, Sep 02, 2019 at 12:36:56PM -0500, Eric W. Biederman wrote: > Russell King - ARM Linux admin writes: > > > On Fri, Aug 30, 2019 at 04:02:48PM -0500, Eric W. Biederman wrote: > >> Russell King - ARM Linux admin writes: > >> > >> > On Fri

Re: [PATCH] net: phylink: Fix flow control resolution

2019-09-05 Thread Russell King - ARM Linux admin
On Thu, Sep 05, 2019 at 07:46:18PM +0300, stef...@marvell.com wrote: > From: Stefan Chulski > > Regarding to IEEE 802.3-2015 standard section 2 > 28B.3 Priority resolution - Table 28-3 - Pause resolution > > In case of Local device Pause=1 AsymDir=0, Link partner > Pause=1 AsymDir=1, Local

Re: [PATCH] arm: fix page faults in do_alignment

2019-08-31 Thread Russell King - ARM Linux admin
On Sat, Aug 31, 2019 at 09:49:45AM +0800, Jing Xiangfeng wrote: > On 2019/8/30 21:35, Russell King - ARM Linux admin wrote: > > On Fri, Aug 30, 2019 at 09:31:17PM +0800, Jing Xiangfeng wrote: > >> The function do_alignment can handle misaligned address for user and

Re: [PATCH] arm: fix page faults in do_alignment

2019-08-30 Thread Russell King - ARM Linux admin
On Fri, Aug 30, 2019 at 04:02:48PM -0500, Eric W. Biederman wrote: > Russell King - ARM Linux admin writes: > > > On Fri, Aug 30, 2019 at 02:45:36PM -0500, Eric W. Biederman wrote: > >> Russell King - ARM Linux admin writes: > >> > >> > On Fri, Aug 30

<    1   2   3   4   5   6   7   8   9   10   >