Re: [PATCH] mmc: core: Check regulator pointer

2016-10-18 Thread Shawn Lin
在 2016/10/18 17:47, Maxime Ripard 写道: Hi, On Tue, Oct 18, 2016 at 11:03:02AM +0200, Ulf Hansson wrote: On 18 October 2016 at 10:43, Maxime Ripard wrote: mmc_regulator_get_supply might silently fail if the regulators are not found, which is the right thing to

Re: [PATCH] mmc: core: Check regulator pointer

2016-10-18 Thread Shawn Lin
在 2016/10/18 17:47, Maxime Ripard 写道: Hi, On Tue, Oct 18, 2016 at 11:03:02AM +0200, Ulf Hansson wrote: On 18 October 2016 at 10:43, Maxime Ripard wrote: mmc_regulator_get_supply might silently fail if the regulators are not found, which is the right thing to do since both these regulators

Re: [PATCH] mmc: core: Check regulator pointer

2016-10-18 Thread Ulf Hansson
On 18 October 2016 at 11:47, Maxime Ripard wrote: > Hi, > > On Tue, Oct 18, 2016 at 11:03:02AM +0200, Ulf Hansson wrote: >> On 18 October 2016 at 10:43, Maxime Ripard >> wrote: >> > mmc_regulator_get_supply might silently fail

Re: [PATCH] mmc: core: Check regulator pointer

2016-10-18 Thread Ulf Hansson
On 18 October 2016 at 11:47, Maxime Ripard wrote: > Hi, > > On Tue, Oct 18, 2016 at 11:03:02AM +0200, Ulf Hansson wrote: >> On 18 October 2016 at 10:43, Maxime Ripard >> wrote: >> > mmc_regulator_get_supply might silently fail if the regulators are not >> > found, which is the right thing to do

Re: [PATCH] mmc: core: Check regulator pointer

2016-10-18 Thread Maxime Ripard
Hi, On Tue, Oct 18, 2016 at 11:03:02AM +0200, Ulf Hansson wrote: > On 18 October 2016 at 10:43, Maxime Ripard > wrote: > > mmc_regulator_get_supply might silently fail if the regulators are not > > found, which is the right thing to do since both these

Re: [PATCH] mmc: core: Check regulator pointer

2016-10-18 Thread Maxime Ripard
Hi, On Tue, Oct 18, 2016 at 11:03:02AM +0200, Ulf Hansson wrote: > On 18 October 2016 at 10:43, Maxime Ripard > wrote: > > mmc_regulator_get_supply might silently fail if the regulators are not > > found, which is the right thing to do since both these regulators are > > optional. > > > >

Re: [PATCH] mmc: core: Check regulator pointer

2016-10-18 Thread Ulf Hansson
On 18 October 2016 at 10:43, Maxime Ripard wrote: > mmc_regulator_get_supply might silently fail if the regulators are not > found, which is the right thing to do since both these regulators are > optional. > > However, the drivers then have no way to know

Re: [PATCH] mmc: core: Check regulator pointer

2016-10-18 Thread Ulf Hansson
On 18 October 2016 at 10:43, Maxime Ripard wrote: > mmc_regulator_get_supply might silently fail if the regulators are not > found, which is the right thing to do since both these regulators are > optional. > > However, the drivers then have no way to know whether or not they should > proceed and

Re: [PATCH] mmc: core: Check regulator pointer

2016-10-18 Thread Baolin Wang
Hi, On 18 October 2016 at 16:43, Maxime Ripard wrote: > mmc_regulator_get_supply might silently fail if the regulators are not > found, which is the right thing to do since both these regulators are > optional. > > However, the drivers then have no way to know

Re: [PATCH] mmc: core: Check regulator pointer

2016-10-18 Thread Baolin Wang
Hi, On 18 October 2016 at 16:43, Maxime Ripard wrote: > mmc_regulator_get_supply might silently fail if the regulators are not > found, which is the right thing to do since both these regulators are > optional. > > However, the drivers then have no way to know whether or not they should >

[PATCH] mmc: core: Check regulator pointer

2016-10-18 Thread Maxime Ripard
mmc_regulator_get_supply might silently fail if the regulators are not found, which is the right thing to do since both these regulators are optional. However, the drivers then have no way to know whether or not they should proceed and call mmc_regulator_set_ocr. And since this function doesn't

[PATCH] mmc: core: Check regulator pointer

2016-10-18 Thread Maxime Ripard
mmc_regulator_get_supply might silently fail if the regulators are not found, which is the right thing to do since both these regulators are optional. However, the drivers then have no way to know whether or not they should proceed and call mmc_regulator_set_ocr. And since this function doesn't