Re: [PATCH 01/14] dma: sun6i-dma: Add burst case of 4

2016-11-13 Thread Vinod Koul
On Tue, Nov 01, 2016 at 10:55:13PM +0800, Chen-Yu Tsai wrote: > >> * @src_maxburst: the maximum number of words (note: words, as in > >> * units of the src_addr_width member, not bytes) that can be sent > >> * in one burst to the device. Typically something like half the > >> * FIFO depth on

Re: [PATCH 01/14] dma: sun6i-dma: Add burst case of 4

2016-11-13 Thread Vinod Koul
On Tue, Nov 01, 2016 at 10:55:13PM +0800, Chen-Yu Tsai wrote: > >> * @src_maxburst: the maximum number of words (note: words, as in > >> * units of the src_addr_width member, not bytes) that can be sent > >> * in one burst to the device. Typically something like half the > >> * FIFO depth on

Re: [PATCH 01/14] dma: sun6i-dma: Add burst case of 4

2016-11-01 Thread Chen-Yu Tsai
On Tue, Nov 1, 2016 at 9:46 PM, Koul, Vinod wrote: > On Sun, 2016-10-30 at 10:06 +0800, Chen-Yu Tsai wrote: >> Looking at the dmaengine API, I believe we got it wrong. >> >> max_burst in dma_slave_config denotes the largest amount of data >> a single transfer should be, as

Re: [PATCH 01/14] dma: sun6i-dma: Add burst case of 4

2016-11-01 Thread Chen-Yu Tsai
On Tue, Nov 1, 2016 at 9:46 PM, Koul, Vinod wrote: > On Sun, 2016-10-30 at 10:06 +0800, Chen-Yu Tsai wrote: >> Looking at the dmaengine API, I believe we got it wrong. >> >> max_burst in dma_slave_config denotes the largest amount of data >> a single transfer should be, as described in

Re: [PATCH 01/14] dma: sun6i-dma: Add burst case of 4

2016-11-01 Thread Koul, Vinod
On Sun, 2016-10-30 at 10:06 +0800, Chen-Yu Tsai wrote: > Looking at the dmaengine API, I believe we got it wrong. > > max_burst in dma_slave_config denotes the largest amount of data > a single transfer should be, as described in dmaengine.h: Not a single transfer but smallest transaction within

Re: [PATCH 01/14] dma: sun6i-dma: Add burst case of 4

2016-11-01 Thread Koul, Vinod
On Sun, 2016-10-30 at 10:06 +0800, Chen-Yu Tsai wrote: > Looking at the dmaengine API, I believe we got it wrong. > > max_burst in dma_slave_config denotes the largest amount of data > a single transfer should be, as described in dmaengine.h: Not a single transfer but smallest transaction within

Re: [PATCH 01/14] dma: sun6i-dma: Add burst case of 4

2016-10-30 Thread Jean-Francois Moine
On Sun, 30 Oct 2016 10:06:20 +0800 Chen-Yu Tsai wrote: > >> Yes, I know that the burst size is always a power of 2. > >> The best way to check it would be to change the {src,dts}_maxburst to a > >> bitmap of the possible bursts as 0x0d for 1,4 and 8 bytes. But this > >> asks for a

Re: [PATCH 01/14] dma: sun6i-dma: Add burst case of 4

2016-10-30 Thread Jean-Francois Moine
On Sun, 30 Oct 2016 10:06:20 +0800 Chen-Yu Tsai wrote: > >> Yes, I know that the burst size is always a power of 2. > >> The best way to check it would be to change the {src,dts}_maxburst to a > >> bitmap of the possible bursts as 0x0d for 1,4 and 8 bytes. But this > >> asks for a lot of

Re: [PATCH 01/14] dma: sun6i-dma: Add burst case of 4

2016-10-29 Thread Chen-Yu Tsai
Hi, On Fri, Oct 28, 2016 at 1:51 AM, Maxime Ripard wrote: > On Sun, Oct 23, 2016 at 06:31:07PM +0200, Jean-Francois Moine wrote: >> On Tue, 4 Oct 2016 18:55:54 +0200 >> Maxime Ripard wrote: >> >> > On Tue, Oct 04, 2016 at

Re: [PATCH 01/14] dma: sun6i-dma: Add burst case of 4

2016-10-29 Thread Chen-Yu Tsai
Hi, On Fri, Oct 28, 2016 at 1:51 AM, Maxime Ripard wrote: > On Sun, Oct 23, 2016 at 06:31:07PM +0200, Jean-Francois Moine wrote: >> On Tue, 4 Oct 2016 18:55:54 +0200 >> Maxime Ripard wrote: >> >> > On Tue, Oct 04, 2016 at 12:40:11PM +0200, Jean-Francois Moine wrote: >> > > On Tue, 4 Oct 2016

Re: [PATCH 01/14] dma: sun6i-dma: Add burst case of 4

2016-10-27 Thread Maxime Ripard
On Sun, Oct 23, 2016 at 06:31:07PM +0200, Jean-Francois Moine wrote: > On Tue, 4 Oct 2016 18:55:54 +0200 > Maxime Ripard wrote: > > > On Tue, Oct 04, 2016 at 12:40:11PM +0200, Jean-Francois Moine wrote: > > > On Tue, 4 Oct 2016 11:46:14 +0200 > > > Mylène

Re: [PATCH 01/14] dma: sun6i-dma: Add burst case of 4

2016-10-27 Thread Maxime Ripard
On Sun, Oct 23, 2016 at 06:31:07PM +0200, Jean-Francois Moine wrote: > On Tue, 4 Oct 2016 18:55:54 +0200 > Maxime Ripard wrote: > > > On Tue, Oct 04, 2016 at 12:40:11PM +0200, Jean-Francois Moine wrote: > > > On Tue, 4 Oct 2016 11:46:14 +0200 > > > Mylène Josserand wrote: > > > > > > > Add

Re: [PATCH 01/14] dma: sun6i-dma: Add burst case of 4

2016-10-23 Thread Jean-Francois Moine
On Tue, 4 Oct 2016 18:55:54 +0200 Maxime Ripard wrote: > On Tue, Oct 04, 2016 at 12:40:11PM +0200, Jean-Francois Moine wrote: > > On Tue, 4 Oct 2016 11:46:14 +0200 > > Mylène Josserand wrote: > > > > > Add the case of a

Re: [PATCH 01/14] dma: sun6i-dma: Add burst case of 4

2016-10-23 Thread Jean-Francois Moine
On Tue, 4 Oct 2016 18:55:54 +0200 Maxime Ripard wrote: > On Tue, Oct 04, 2016 at 12:40:11PM +0200, Jean-Francois Moine wrote: > > On Tue, 4 Oct 2016 11:46:14 +0200 > > Mylène Josserand wrote: > > > > > Add the case of a burst of 4 which is handled by the SoC. > > > > > > Signed-off-by:

Re: [PATCH 01/14] dma: sun6i-dma: Add burst case of 4

2016-10-04 Thread Maxime Ripard
On Tue, Oct 04, 2016 at 12:40:11PM +0200, Jean-Francois Moine wrote: > On Tue, 4 Oct 2016 11:46:14 +0200 > Mylène Josserand wrote: > > > Add the case of a burst of 4 which is handled by the SoC. > > > > Signed-off-by: Mylène Josserand

Re: [PATCH 01/14] dma: sun6i-dma: Add burst case of 4

2016-10-04 Thread Maxime Ripard
On Tue, Oct 04, 2016 at 12:40:11PM +0200, Jean-Francois Moine wrote: > On Tue, 4 Oct 2016 11:46:14 +0200 > Mylène Josserand wrote: > > > Add the case of a burst of 4 which is handled by the SoC. > > > > Signed-off-by: Mylène Josserand > > --- > > drivers/dma/sun6i-dma.c | 2 ++ > > 1 file

Re: [PATCH 01/14] dma: sun6i-dma: Add burst case of 4

2016-10-04 Thread Vinod Koul
On Tue, Oct 04, 2016 at 03:46:51PM +0200, Jean-Francois Moine wrote: > On Tue, 4 Oct 2016 14:12:21 +0200 > Thomas Petazzoni wrote: > > > > > Add the case of a burst of 4 which is handled by the SoC. > > > > > > > > Signed-off-by: Mylène Josserand

Re: [PATCH 01/14] dma: sun6i-dma: Add burst case of 4

2016-10-04 Thread Vinod Koul
On Tue, Oct 04, 2016 at 03:46:51PM +0200, Jean-Francois Moine wrote: > On Tue, 4 Oct 2016 14:12:21 +0200 > Thomas Petazzoni wrote: > > > > > Add the case of a burst of 4 which is handled by the SoC. > > > > > > > > Signed-off-by: Mylène Josserand > > > > --- > > > > drivers/dma/sun6i-dma.c |

Re: [PATCH 01/14] dma: sun6i-dma: Add burst case of 4

2016-10-04 Thread Jean-Francois Moine
On Tue, 4 Oct 2016 14:12:21 +0200 Thomas Petazzoni wrote: > > > Add the case of a burst of 4 which is handled by the SoC. > > > > > > Signed-off-by: Mylène Josserand > > > --- > > > drivers/dma/sun6i-dma.c | 2 ++ > > >

Re: [PATCH 01/14] dma: sun6i-dma: Add burst case of 4

2016-10-04 Thread Jean-Francois Moine
On Tue, 4 Oct 2016 14:12:21 +0200 Thomas Petazzoni wrote: > > > Add the case of a burst of 4 which is handled by the SoC. > > > > > > Signed-off-by: Mylène Josserand > > > --- > > > drivers/dma/sun6i-dma.c | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git

Re: [PATCH 01/14] dma: sun6i-dma: Add burst case of 4

2016-10-04 Thread Thomas Petazzoni
Hello, On Tue, 4 Oct 2016 12:40:11 +0200, Jean-Francois Moine wrote: > > Add the case of a burst of 4 which is handled by the SoC. > > > > Signed-off-by: Mylène Josserand > > --- > > drivers/dma/sun6i-dma.c | 2 ++ > > 1 file changed, 2 insertions(+) > >

Re: [PATCH 01/14] dma: sun6i-dma: Add burst case of 4

2016-10-04 Thread Thomas Petazzoni
Hello, On Tue, 4 Oct 2016 12:40:11 +0200, Jean-Francois Moine wrote: > > Add the case of a burst of 4 which is handled by the SoC. > > > > Signed-off-by: Mylène Josserand > > --- > > drivers/dma/sun6i-dma.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git

Re: [PATCH 01/14] dma: sun6i-dma: Add burst case of 4

2016-10-04 Thread Jean-Francois Moine
On Tue, 4 Oct 2016 11:46:14 +0200 Mylène Josserand wrote: > Add the case of a burst of 4 which is handled by the SoC. > > Signed-off-by: Mylène Josserand > --- > drivers/dma/sun6i-dma.c | 2 ++ > 1 file changed, 2

Re: [PATCH 01/14] dma: sun6i-dma: Add burst case of 4

2016-10-04 Thread Jean-Francois Moine
On Tue, 4 Oct 2016 11:46:14 +0200 Mylène Josserand wrote: > Add the case of a burst of 4 which is handled by the SoC. > > Signed-off-by: Mylène Josserand > --- > drivers/dma/sun6i-dma.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/dma/sun6i-dma.c

[PATCH 01/14] dma: sun6i-dma: Add burst case of 4

2016-10-04 Thread Mylène Josserand
Add the case of a burst of 4 which is handled by the SoC. Signed-off-by: Mylène Josserand --- drivers/dma/sun6i-dma.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/dma/sun6i-dma.c b/drivers/dma/sun6i-dma.c index 8346199..0485204 100644 ---

[PATCH 01/14] dma: sun6i-dma: Add burst case of 4

2016-10-04 Thread Mylène Josserand
Add the case of a burst of 4 which is handled by the SoC. Signed-off-by: Mylène Josserand --- drivers/dma/sun6i-dma.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/dma/sun6i-dma.c b/drivers/dma/sun6i-dma.c index 8346199..0485204 100644 --- a/drivers/dma/sun6i-dma.c +++