Re: [PATCH 1/2] ARM: irq: Call irqchit_init if no init_irq function is specified

2013-04-02 Thread Olof Johansson
On Thu, Mar 28, 2013 at 09:46:44PM +0100, Maxime Ripard wrote: > More and more sub-architectures are using only the irqchip_init > function. Make the core code call this function if no init_irq field is > provided in the machine description to remove some boilerplate code. > > Signed-off-by:

Re: [PATCH 1/2] ARM: irq: Call irqchit_init if no init_irq function is specified

2013-04-02 Thread Olof Johansson
On Thu, Mar 28, 2013 at 09:46:44PM +0100, Maxime Ripard wrote: More and more sub-architectures are using only the irqchip_init function. Make the core code call this function if no init_irq field is provided in the machine description to remove some boilerplate code. Signed-off-by: Maxime

Re: [PATCH 1/2] ARM: irq: Call irqchit_init if no init_irq function is specified

2013-03-28 Thread Rob Herring
On 03/28/2013 03:46 PM, Maxime Ripard wrote: > More and more sub-architectures are using only the irqchip_init > function. Make the core code call this function if no init_irq field is > provided in the machine description to remove some boilerplate code. > > Signed-off-by: Maxime Ripard

[PATCH 1/2] ARM: irq: Call irqchit_init if no init_irq function is specified

2013-03-28 Thread Maxime Ripard
More and more sub-architectures are using only the irqchip_init function. Make the core code call this function if no init_irq field is provided in the machine description to remove some boilerplate code. Signed-off-by: Maxime Ripard --- arch/arm/kernel/irq.c |6 +- 1 file changed, 5

Re: [PATCH 1/2] ARM: irq: Call irqchit_init if no init_irq function is specified

2013-03-28 Thread Russell King - ARM Linux
On Thu, Mar 28, 2013 at 01:40:09PM -0500, Rob Herring wrote: > On 03/28/2013 09:51 AM, Russell King - ARM Linux wrote: > > On Thu, Mar 28, 2013 at 09:48:18AM -0500, Rob Herring wrote: > >> On 03/28/2013 04:41 AM, Maxime Ripard wrote: > >>> + if (machine_desc->init_irq) > >>> +

Re: [PATCH 1/2] ARM: irq: Call irqchit_init if no init_irq function is specified

2013-03-28 Thread Rob Herring
On 03/28/2013 09:51 AM, Russell King - ARM Linux wrote: > On Thu, Mar 28, 2013 at 09:48:18AM -0500, Rob Herring wrote: >> On 03/28/2013 04:41 AM, Maxime Ripard wrote: >>> + if (machine_desc->init_irq) >>> + machine_desc->init_irq(); >>> + else >>> + irqchip_init(); >> >>

Re: [PATCH 1/2] ARM: irq: Call irqchit_init if no init_irq function is specified

2013-03-28 Thread Maxime Ripard
Le 28/03/2013 16:49, Arnd Bergmann a écrit : > On Thursday 28 March 2013, Russell King - ARM Linux wrote: >> On Thu, Mar 28, 2013 at 03:25:42PM +, Arnd Bergmann wrote: >>> if (IS_DEFINED(CONFIG_OF) && !machine_desc->init_irq) >>> irqchip_init(); >>> else >>>

Re: [PATCH 1/2] ARM: irq: Call irqchit_init if no init_irq function is specified

2013-03-28 Thread Arnd Bergmann
On Thursday 28 March 2013, Russell King - ARM Linux wrote: > On Thu, Mar 28, 2013 at 03:25:42PM +, Arnd Bergmann wrote: > > if (IS_DEFINED(CONFIG_OF) && !machine_desc->init_irq) > > irqchip_init(); > > else > > machine_desc->init_irq(); > > > > to the

Re: [PATCH 1/2] ARM: irq: Call irqchit_init if no init_irq function is specified

2013-03-28 Thread Russell King - ARM Linux
On Thu, Mar 28, 2013 at 03:25:42PM +, Arnd Bergmann wrote: > On Thursday 28 March 2013, Russell King - ARM Linux wrote: > > Better: > > > > #ifdef CONFIG_OF > > if (!machine_desc->init_irq) > > irqchip_init(); > > else > > #endif > >

Re: [PATCH 1/2] ARM: irq: Call irqchit_init if no init_irq function is specified

2013-03-28 Thread Arnd Bergmann
On Thursday 28 March 2013, Russell King - ARM Linux wrote: > Better: > > #ifdef CONFIG_OF > if (!machine_desc->init_irq) > irqchip_init(); > else > #endif > machine_desc->init_irq(); > > which means we don't even get the test if !OF, and if someone

Re: [PATCH 1/2] ARM: irq: Call irqchit_init if no init_irq function is specified

2013-03-28 Thread Russell King - ARM Linux
On Thu, Mar 28, 2013 at 09:48:18AM -0500, Rob Herring wrote: > On 03/28/2013 04:41 AM, Maxime Ripard wrote: > > + if (machine_desc->init_irq) > > + machine_desc->init_irq(); > > + else > > + irqchip_init(); > > There needs to be an empty version defined for !OF. Better:

Re: [PATCH 1/2] ARM: irq: Call irqchit_init if no init_irq function is specified

2013-03-28 Thread Rob Herring
On 03/28/2013 04:41 AM, Maxime Ripard wrote: > More and more sub-architectures are using only the irqchip_init > function. Make the core code call this function if no init_irq field is > provided in the machine description to remove some boilerplate code. > > Signed-off-by: Maxime Ripard > --- >

[PATCH 1/2] ARM: irq: Call irqchit_init if no init_irq function is specified

2013-03-28 Thread Maxime Ripard
More and more sub-architectures are using only the irqchip_init function. Make the core code call this function if no init_irq field is provided in the machine description to remove some boilerplate code. Signed-off-by: Maxime Ripard --- arch/arm/kernel/irq.c |6 +- 1 file changed, 5

Re: [PATCH 1/2] ARM: irq: Call irqchit_init if no init_irq function is specified

2013-03-28 Thread Maxime Ripard
Le 28/03/2013 16:49, Arnd Bergmann a écrit : On Thursday 28 March 2013, Russell King - ARM Linux wrote: On Thu, Mar 28, 2013 at 03:25:42PM +, Arnd Bergmann wrote: if (IS_DEFINED(CONFIG_OF) !machine_desc-init_irq) irqchip_init(); else

Re: [PATCH 1/2] ARM: irq: Call irqchit_init if no init_irq function is specified

2013-03-28 Thread Rob Herring
On 03/28/2013 09:51 AM, Russell King - ARM Linux wrote: On Thu, Mar 28, 2013 at 09:48:18AM -0500, Rob Herring wrote: On 03/28/2013 04:41 AM, Maxime Ripard wrote: + if (machine_desc-init_irq) + machine_desc-init_irq(); + else + irqchip_init(); There needs to be an

Re: [PATCH 1/2] ARM: irq: Call irqchit_init if no init_irq function is specified

2013-03-28 Thread Russell King - ARM Linux
On Thu, Mar 28, 2013 at 01:40:09PM -0500, Rob Herring wrote: On 03/28/2013 09:51 AM, Russell King - ARM Linux wrote: On Thu, Mar 28, 2013 at 09:48:18AM -0500, Rob Herring wrote: On 03/28/2013 04:41 AM, Maxime Ripard wrote: + if (machine_desc-init_irq) + machine_desc-init_irq();

[PATCH 1/2] ARM: irq: Call irqchit_init if no init_irq function is specified

2013-03-28 Thread Maxime Ripard
More and more sub-architectures are using only the irqchip_init function. Make the core code call this function if no init_irq field is provided in the machine description to remove some boilerplate code. Signed-off-by: Maxime Ripard maxime.rip...@free-electrons.com --- arch/arm/kernel/irq.c |

Re: [PATCH 1/2] ARM: irq: Call irqchit_init if no init_irq function is specified

2013-03-28 Thread Rob Herring
On 03/28/2013 03:46 PM, Maxime Ripard wrote: More and more sub-architectures are using only the irqchip_init function. Make the core code call this function if no init_irq field is provided in the machine description to remove some boilerplate code. Signed-off-by: Maxime Ripard

[PATCH 1/2] ARM: irq: Call irqchit_init if no init_irq function is specified

2013-03-28 Thread Maxime Ripard
More and more sub-architectures are using only the irqchip_init function. Make the core code call this function if no init_irq field is provided in the machine description to remove some boilerplate code. Signed-off-by: Maxime Ripard maxime.rip...@free-electrons.com --- arch/arm/kernel/irq.c |

Re: [PATCH 1/2] ARM: irq: Call irqchit_init if no init_irq function is specified

2013-03-28 Thread Rob Herring
On 03/28/2013 04:41 AM, Maxime Ripard wrote: More and more sub-architectures are using only the irqchip_init function. Make the core code call this function if no init_irq field is provided in the machine description to remove some boilerplate code. Signed-off-by: Maxime Ripard

Re: [PATCH 1/2] ARM: irq: Call irqchit_init if no init_irq function is specified

2013-03-28 Thread Russell King - ARM Linux
On Thu, Mar 28, 2013 at 09:48:18AM -0500, Rob Herring wrote: On 03/28/2013 04:41 AM, Maxime Ripard wrote: + if (machine_desc-init_irq) + machine_desc-init_irq(); + else + irqchip_init(); There needs to be an empty version defined for !OF. Better: #ifdef

Re: [PATCH 1/2] ARM: irq: Call irqchit_init if no init_irq function is specified

2013-03-28 Thread Arnd Bergmann
On Thursday 28 March 2013, Russell King - ARM Linux wrote: Better: #ifdef CONFIG_OF if (!machine_desc-init_irq) irqchip_init(); else #endif machine_desc-init_irq(); which means we don't even get the test if !OF, and if someone mistakenly

Re: [PATCH 1/2] ARM: irq: Call irqchit_init if no init_irq function is specified

2013-03-28 Thread Russell King - ARM Linux
On Thu, Mar 28, 2013 at 03:25:42PM +, Arnd Bergmann wrote: On Thursday 28 March 2013, Russell King - ARM Linux wrote: Better: #ifdef CONFIG_OF if (!machine_desc-init_irq) irqchip_init(); else #endif machine_desc-init_irq();

Re: [PATCH 1/2] ARM: irq: Call irqchit_init if no init_irq function is specified

2013-03-28 Thread Arnd Bergmann
On Thursday 28 March 2013, Russell King - ARM Linux wrote: On Thu, Mar 28, 2013 at 03:25:42PM +, Arnd Bergmann wrote: if (IS_DEFINED(CONFIG_OF) !machine_desc-init_irq) irqchip_init(); else machine_desc-init_irq(); to the same effect.