Re: [PATCH] pcmcia: fix i82092 printk format

2008-02-08 Thread Andrew Morton
On Fri, 8 Feb 2008 15:22:44 -0800 Randy Dunlap [EMAIL PROTECTED] wrote: From: Randy Dunlap [EMAIL PROTECTED] Fix printk format warnings: linux-2.6.24-git19/drivers/pcmcia/i82092.c:650: warning: format '%lx' expects type 'long unsigned int', but argument 3 has type 'resource_size_t'

Re: [patch] [git pull] Input updates for 2.6.25-rc0

2008-02-08 Thread Andrew Morton
On Fri, 8 Feb 2008 15:37:41 -0800 Randy Dunlap [EMAIL PROTECTED] wrote: I think someone already sent a patch to select the LEDS I did... and more. Who will merge it? (below) --- From: Randy Dunlap [EMAIL PROTECTED] Add I2C to config since the driver makes several i2c*() calls.

Re: [patch 0/6] MMU Notifiers V6

2008-02-08 Thread Andrew Morton
On Fri, 8 Feb 2008 17:43:02 -0600 Robin Holt [EMAIL PROTECTED] wrote: On Fri, Feb 08, 2008 at 03:41:24PM -0800, Christoph Lameter wrote: On Fri, 8 Feb 2008, Robin Holt wrote: What about ib_umem_get()? Correct. You missed the turn of the conversation to how ib_umem_get()

Re: [patch] block layer: kmemcheck fixes

2008-02-08 Thread Nick Piggin
On Fri, Feb 08, 2008 at 02:56:09PM -0800, Arjan van de Ven wrote: Nick Piggin wrote: Maybe cpus these days have so much store bandwith that doing things like the above is OK, but I doubt it :-) on modern x86 cpus the memset may even be faster if the memory isn't in cache; the explicit

Re: [PATCH] USB: mark USB drivers as being GPL only

2008-02-08 Thread Daniel Hazelton
On Friday 08 February 2008 16:36:37 Alan Cox wrote: In other words EXPORT_SYMBOL_GPL isn't his idea of a good legal idea, but people ignoring this and doing things that circumvent this will, eventually, have problems with the people who hold the copyright on the code. (In addition, he

Re: 2.6.24-git15 Keyboard Issue?

2008-02-08 Thread Jiri Kosina
On Fri, 8 Feb 2008, Jiri Kosina wrote: I hope that, from at least my perspective, your question is rhetorical. Yeah. The non rhetorical one was directed to Jiri. :) Actually, I have no idea :) I am right now confused too, I am quite surprised that 'nohpet' fixes the problem for you,

Re: [git pull] Input updates for 2.6.25-rc0

2008-02-08 Thread Ingo Molnar
* Dmitry Torokhov [EMAIL PROTECTED] wrote: Stephen Hemminger (2): Input: add driver for Fujitsu application buttons this change broke the build on x86 in randconfig testing: drivers/built-in.o: In function `apanel_detach_client': apanel.c:(.text+0x15c120): undefined reference to

Re: [git pull] Input updates for 2.6.25-rc0

2008-02-08 Thread Stephen Hemminger
On Sat, 9 Feb 2008 00:25:36 +0100 Ingo Molnar [EMAIL PROTECTED] wrote: * Dmitry Torokhov [EMAIL PROTECTED] wrote: Stephen Hemminger (2): Input: add driver for Fujitsu application buttons this change broke the build on x86 in randconfig testing: drivers/built-in.o: In

Re: [patch 0/6] MMU Notifiers V6

2008-02-08 Thread Christoph Lameter
On Fri, 8 Feb 2008, Andrew Morton wrote: What about ib_umem_get()? Ok. It pins using an elevated refcount. Same as XPmem right now. With that we effectively pin a page (page migration will fail) but we will continually be reclaiming the page and may repeatedly try to move it. We have issues

Re: [rft] s2ram wakeup moves to .c, could fix few machines

2008-02-08 Thread Rafael J. Wysocki
On Friday, 8 of February 2008, Pavel Machek wrote: Hi! Rafael, this is for you. Thanks. My cleanups, relative to your cleanup patch. You may need manual patching around rep/stosd. OK, I'll try to merge it. Rafael diff --git a/arch/x86/kernel/acpi/realmode/Makefile

Re: [rft] s2ram wakeup moves to .c, could fix few machines

2008-02-08 Thread Sam Ravnborg
On Fri, Feb 08, 2008 at 10:41:45PM +0100, Pavel Machek wrote: Do we never need data from a .h file? If we do name it wakeup.lds.S and kbuild will fix it (assuming we have wakeup.lds as a prerequisite where it is needed. Ok, I got it to work... but notice the ugly #undef :-(. Great. We

[PATCH] x86 cleanup: suspend_asm_64.S - use X86_CR4_PGE instead of numeric value

2008-02-08 Thread Cyrill Gorcunov
By including asm/processor-flags.h we're allowed to use X86_CR4_PGE instead of numeric constant. md5 sums of compiled files are differ due to this inclusion but .text section remains the same. --- If anyone has an objection on this patch - just drop it please. I'm not sure but this could have

Re: [linux-pm] Re: [rft] s2ram wakeup moves to .c, could fix few machines

2008-02-08 Thread Rafael J. Wysocki
On Friday, 8 of February 2008, Pavel Machek wrote: On Fri 2008-02-08 13:27:30, H. Peter Anvin wrote: Pavel Machek wrote: See arch/x86/kernel/acpi/realmode/wakeup.S (the version that was sent to the list). No problem there, but table stored at nonzero offset. Short jump at the beggining

Re: [linux-pm] Re: [rft] s2ram wakeup moves to .c, could fix few machines

2008-02-08 Thread Pavel Machek
On Fri 2008-02-08 22:56:08, Rafael J. Wysocki wrote: On Friday, 8 of February 2008, Pavel Machek wrote: On Fri 2008-02-08 13:27:30, H. Peter Anvin wrote: Pavel Machek wrote: See arch/x86/kernel/acpi/realmode/wakeup.S (the version that was sent to the list). No problem there, but

[PATCH 03/37] KEYS: Allow the callout data to be passed as a blob rather than a string

2008-02-08 Thread David Howells
Allow the callout data to be passed as a blob rather than a string for internal kernel services that call any request_key_*() interface other than request_key(). request_key() itself still takes a NUL-terminated string. The functions that change are: request_key_with_auxdata()

[PATCH] SUNPRC: Fix printk format warning

2008-02-08 Thread Roland Dreier
net/sunrpc/xprtrdma/svc_rdma_sendto.c:160: warning: format '%llx' expects type 'long long unsigned int', but argument 3 has type 'u64' Signed-off-by: Roland Dreier [EMAIL PROTECTED] --- diff --git a/net/sunrpc/xprtrdma/svc_rdma_sendto.c b/net/sunrpc/xprtrdma/svc_rdma_sendto.c index

Scheduler(?) regression from 2.6.22 to 2.6.24 for short-lived threads

2008-02-08 Thread Olof Johansson
Hi, I ended up with a customer benchmark in my lap this week that doesn't do well on recent kernels. :( After cutting it down to a simple testcase/microbenchmark, it seems like recent kernels don't do as well with short-lived threads competing with the thread it's cloned off of. The CFS

scsi/arm/fas216.c compile error

2008-02-08 Thread Adrian Bunk
Commit 30b0c37b27485a9cb897bfe3824f6f517b8c80d6 causes the following compile error: -- snip -- ... CC drivers/scsi/arm/fas216.o /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/scsi/arm/fas216.c: In function 'fas216_std_done':

Re: [patch 0/6] MMU Notifiers V6

2008-02-08 Thread Christoph Lameter
On Fri, 8 Feb 2008, Andrew Morton wrote: You took it correctly, and I didn't understand the answer ;) We have done several rounds of discussion on linux-kernel about this so far and the IB folks have not shown up to join in. I have tried to make this as general as possible. -- To unsubscribe

Re: uml compile error

2008-02-08 Thread Jiri Kosina
On Sat, 9 Feb 2008, Adrian Bunk wrote: Commit dd2cc4dff3b08ab54c4c177a080046bcc84ac41d broke uml: -- snip -- ... CC fs/hostfs/hostfs_kern.o /home/bunk/linux/kernel-2.6/git/linux-2.6/fs/hostfs/hostfs_kern.c: In function 'hostfs_show_options':

Re: [patch 0/6] MMU Notifiers V6

2008-02-08 Thread Andrew Morton
On Fri, 8 Feb 2008 16:05:00 -0800 (PST) Christoph Lameter [EMAIL PROTECTED] wrote: On Fri, 8 Feb 2008, Andrew Morton wrote: You took it correctly, and I didn't understand the answer ;) We have done several rounds of discussion on linux-kernel about this so far and the IB folks have not

ide/arm/bast-ide.c compile error

2008-02-08 Thread Adrian Bunk
Commit 9e016a719209d95338e314b46c3012cc7feaaeec causes the following compile error: -- snip -- ... CC drivers/ide/arm/bast-ide.o /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/ide/arm/bast-ide.c: In function 'bastide_register':

Re: [ofa-general] Re: [patch 0/6] MMU Notifiers V6

2008-02-08 Thread Christoph Lameter
On Fri, 8 Feb 2008, Roland Dreier wrote: In general, this MMU notifier stuff will only be useful to a subset of InfiniBand/RDMA hardware. Some adapters are smart enough to handle changing the IO virtual - bus/physical mapping on the fly, but some aren't. For the dumb adapters, I think the

Re: [patch 0/6] MMU Notifiers V6

2008-02-08 Thread Christoph Lameter
On Fri, 8 Feb 2008, Andrew Morton wrote: Quite possibly none of the infiniband developers even know about it.. Well Andrea's initial approach was even featured on LWN a couple of weeks back. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to

Re: [rft] s2ram wakeup moves to .c, could fix few machines

2008-02-08 Thread Rafael J. Wysocki
On Friday, 8 of February 2008, Pavel Machek wrote: On Fri 2008-02-08 23:01:51, Rafael J. Wysocki wrote: On Friday, 8 of February 2008, Pavel Machek wrote: Hi! Rafael, this is for you. Thanks. My cleanups, relative to your cleanup patch. You may need manual patching

Re: [-mm PATCH] sysdev_unregister() should call kobject_del()

2008-02-08 Thread Greg KH
On Fri, Feb 08, 2008 at 03:22:29PM -0800, Badari Pulavarty wrote: On Thu, 2008-02-07 at 20:55 -0800, Greg KH wrote: On Thu, Feb 07, 2008 at 05:25:46PM -0800, Badari Pulavarty wrote: On Thu, 2008-02-07 at 16:38 -0800, Greg KH wrote: On Thu, Feb 07, 2008 at 03:56:58PM -0800, Badari

Re: Scheduler(?) regression from 2.6.22 to 2.6.24 for short-lived threads

2008-02-08 Thread Olof Johansson
On Sat, Feb 09, 2008 at 01:08:30AM +0100, Ingo Molnar wrote: * Olof Johansson [EMAIL PROTECTED] wrote: 2.6.22: 3332 ms 2.6.23: 4397 ms 2.6.24: 8953 ms 2.6.24-git19: 8986 ms if you enable SCHED_DEBUG, and subtract 4 from the value of /proc/sys/kernel/sched_features, does it get

Re: Integration of SCST in the mainstream Linux kernel

2008-02-08 Thread Nicholas A. Bellinger
On Fri, 2008-02-08 at 17:42 +0300, Vladislav Bolkhovitin wrote: Nicholas A. Bellinger wrote: On Thu, 2008-02-07 at 12:37 -0800, Luben Tuikov wrote: Is there an open iSCSI Target implementation which does NOT issue commands to sub-target devices via the SCSI mid-layer, but bypasses it

Re: [PATCH 1/2] prevent gpio chip drivers from unloading while used

2008-02-08 Thread David Brownell
On Friday 08 February 2008, Guennadi Liakhovetski wrote: As long as one or more GPIOs on a gpio chip are used its driver should not be unloaded. The mechanism currently in place is to have gpiochip_remove() fail if the platform's teardown() logic doesn't reject it. (It may be practical to

Re: Scheduler(?) regression from 2.6.22 to 2.6.24 for short-lived threads

2008-02-08 Thread Ingo Molnar
* Olof Johansson [EMAIL PROTECTED] wrote: 2.6.22: 3332 ms 2.6.23: 4397 ms 2.6.24: 8953 ms 2.6.24-git19: 8986 ms if you enable SCHED_DEBUG, and subtract 4 from the value of /proc/sys/kernel/sched_features, does it get any better? if not, does writing 0 into /proc/sys/kernel/sched_features

Re: [ofa-general] Re: [patch 0/6] MMU Notifiers V6

2008-02-08 Thread Roland Dreier
I thought the adaptor can always remove the mapping by renegotiating with the remote side? Even if its dumb then a callback could notify the driver that it may be required to tear down the mapping. We then hold the pages until we get okay by the driver that the mapping has been removed.

Re: [PATCH] Documenting patch tags yet one more time

2008-02-08 Thread Paul Jackson
Jon wrote: So here's a version which merges the information into SubmittingPatches instead. Reviewed-by: Paul Jackson [EMAIL PROTECTED] --- That's my first time using that tag ... fun. Now I'm wondering if there might be some improvements that you, me, or someone could make to the

Re: uml compile error

2008-02-08 Thread Adrian Bunk
On Sat, Feb 09, 2008 at 01:05:15AM +0100, Jiri Kosina wrote: On Sat, 9 Feb 2008, Adrian Bunk wrote: Commit dd2cc4dff3b08ab54c4c177a080046bcc84ac41d broke uml: -- snip -- ... CC fs/hostfs/hostfs_kern.o /home/bunk/linux/kernel-2.6/git/linux-2.6/fs/hostfs/hostfs_kern.c: In

[PATCH 9/9] x86: define DEBUG_SIG in signal_64.c

2008-02-08 Thread Harvey Harrison
Make it more like signal_32.c Signed-off-by: Harvey Harrison [EMAIL PROTECTED] --- arch/x86/kernel/signal_64.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/x86/kernel/signal_64.c b/arch/x86/kernel/signal_64.c index 40b30cd..6278083 100644 ---

Re: [PATCH] USB: mark USB drivers as being GPL only

2008-02-08 Thread David Newall
Greg KH wrote: A driver is not an application as you tried to reference in your prior quotes. I think your treating what the learned Professors said to literally. It is a tiny portion of the whole kernel, The Copyright Act draws no such a distinction. and as such, does fall under the

Re: [rft] s2ram wakeup moves to .c, could fix few machines

2008-02-08 Thread H. Peter Anvin
Rafael J. Wysocki wrote: Consolidated patch is appended. I'll test it tomorrow on x86-64. I'd like to add the cleaned up beeping code to it and perhaps try to push it for -mm testing without any further changes. We can still do more cleanups in followup patches. The other thing to figure

Re: [ofa-general] Re: [patch 0/6] MMU Notifiers V6

2008-02-08 Thread Christoph Lameter
On Fri, 8 Feb 2008, Roland Dreier wrote: That would of course work -- dumb adapters would just always fail, which might be inefficient. H.. that means we need something that actually pins pages for good so that the VM can avoid reclaiming it and so that page migration can avoid trying to

Re: [PATCH 1/2] prevent gpio chip drivers from unloading while used

2008-02-08 Thread Guennadi Liakhovetski
On Fri, 8 Feb 2008, David Brownell wrote: On Friday 08 February 2008, Guennadi Liakhovetski wrote: As long as one or more GPIOs on a gpio chip are used its driver should not be unloaded. The mechanism currently in place is to have gpiochip_remove() fail if the platform's teardown()

Re: [LINUX-KERNEL] C++ in linux kernel

2008-02-08 Thread Joonwoo Park
2008/2/9, Jan Engelhardt [EMAIL PROTECTED]: On Feb 9 2008 00:14, Joonwoo Park wrote: 2008/2/8, rohit h [EMAIL PROTECTED]: Hi, I am a kernel newbie. I tried to insmod a C++ module containing classes, inheritance. I am getting 'unresolved symbol' error when I use the 'new' keyword.

Re: [ofa-general] Re: [patch 0/6] MMU Notifiers V6

2008-02-08 Thread Andrea Arcangeli
On Fri, Feb 08, 2008 at 04:36:16PM -0800, Christoph Lameter wrote: On Fri, 8 Feb 2008, Roland Dreier wrote: That would of course work -- dumb adapters would just always fail, which might be inefficient. H.. that means we need something that actually pins pages for good so that the

Re: [ofa-general] Re: [patch 0/6] MMU Notifiers V6

2008-02-08 Thread Christoph Lameter
On Sat, 9 Feb 2008, Andrea Arcangeli wrote: H.. that means we need something that actually pins pages for good so that the VM can avoid reclaiming it and so that page migration can avoid trying to migrate them. Something like yet another page flag. What's wrong with pinning with

Re: [stable] [patch 00/45] 2.6.24-stable review

2008-02-08 Thread Greg KH
On Thu, Feb 07, 2008 at 01:58:34PM -0800, Greg KH wrote: On Thu, Feb 07, 2008 at 11:41:42PM +0200, S.??a??lar Onur wrote: Hi; 07 ??ub 2008 Per tarihinde, Greg KH ??unlar?? yazmt??: This is the start of the stable review cycle for the 2.6.24.1 release. There are 45 patches in

Re: [PATCH] scsi_error: Fix language abuse.

2008-02-08 Thread Douglas Gilbert
Alan Cox wrote: The word illegal has a precise dictionary meaning of prohibited by law. Also contrary to or forbidden by official rules, regulations, etc. So word meanings are like standards, there are so many to choose from. The error messages are therefore incorrect as so far nobody has

Re: [ofa-general] Re: [patch 0/6] MMU Notifiers V6

2008-02-08 Thread Christoph Lameter
On Sat, 9 Feb 2008, Andrea Arcangeli wrote: The VM shouldn't break if try_to_unmap doesn't actually make the page freeable for whatever reason. Permanent pins shouldn't happen anyway, VM is livelocking if too many page are pinned that way right now. The higher the processors per node the

Re: [PATCH] correct inconsistent ntp interval/tick_length usage

2008-02-08 Thread john stultz
On Fri, 2008-02-08 at 18:33 +0100, Roman Zippel wrote: Hi, On Fri, 1 Feb 2008, John Stultz wrote: CLOCK_TICK_ADJUST is based on LATCH and HZ, if the update frequency isn't based on HZ, there is no point in using it! Hey Roman, Again, I'm sorry I don't seem to be following

[PATCH] affs: fix shadowed variable sparse warnings

2008-02-08 Thread Harvey Harrison
Introduce _tmp in the small if-blocks where this is shadowed. fs/affs/file.c:573:8: warning: symbol 'tmp' shadows an earlier one fs/affs/file.c:530:6: originally declared here fs/affs/file.c:714:9: warning: symbol 'tmp' shadows an earlier one fs/affs/file.c:661:6: originally declared here

Re: [PATCH] affs: fix shadowed variable sparse warnings

2008-02-08 Thread Joe Perches
On Fri, 2008-02-08 at 18:53 -0800, Harvey Harrison wrote: diff --git a/fs/affs/file.c b/fs/affs/file.c index 6e0c939..ac05dc2 100644 --- a/fs/affs/file.c +++ b/fs/affs/file.c @@ -570,11 +570,11 @@ affs_extent_file_ofs(struct inode *inode, u32 newsize) bh-b_state = ~(1UL

REPOST: [PATCH] Add iSCSI iBFT support (v0.4.7)

2008-02-08 Thread Konrad Rzeszutek
Whoops. I've attached an incorrect patch in the previous e-mail (http://lkml.org/lkml/2008/2/8/350) that didn't take in to account the 'reserve_bootmem' parameters changes. Here is fresher copy which has been tested on 2.6.24-git19 on a machine with iBFT and without. This patch (v0.4.7) adds

Re: [PATCH] x86 (Linux Tiny): configure out support for some processors

2008-02-08 Thread Taral
On 2/8/08, Michael Opdenacker [EMAIL PROTECTED] wrote: +config CPU_SUP_INTEL + default y + bool Support Intel processors if PROCESSOR_SELECT + help + This enables extended support for Intel processors -obj-$(CONFIG_X86_32) += intel.o +obj-$(CONFIG_CPU_SUP_INTEL)

Re: [PATCH] keyboard notifier documentation

2008-02-08 Thread Randy Dunlap
On Sat, 9 Feb 2008 01:33:22 + Samuel Thibault wrote: Document the keyboard notifier. Signed-off-by: Samuel Thibault [EMAIL PROTECTED] --- /dev/null 2008-02-09 01:22:34.790011677 + +++ linux/Documentation/input/notifier.txt2008-02-09 01:28:12.0 + @@ -0,0 +1,52 @@

kobject must be initialized before calling kobject_init()?!

2008-02-08 Thread Roland Dreier
So I was perusing the code in lib/kobject.c, and I saw this: void kobject_init(struct kobject *kobj, struct kobj_type *ktype) { // [a couple of of parameter checks...] if (kobj-state_initialized) { /* do not error out as

[PATCH] docbook: drop z85230 library from kernel-api

2008-02-08 Thread Randy Dunlap
From: Randy Dunlap [EMAIL PROTECTED] cc: Alan Cox [EMAIL PROTECTED] Drop z85230 support library info from kernel-api since it's duplicated in the Z85230 book. Alan, is this OK with you? (This is one of several patches that I have my queue for reducing the size of kernel-api.* .) Signed-off-by:

[PATCH] Input: i8042 -

2008-02-08 Thread Roland Dreier
Commit c18bab80 (Input: i8042 - non-x86 build fix) introduced the following warning on non-x86 builds: drivers/input/serio/i8042.c: In function 'i8042_probe': drivers/input/serio/i8042.c:1154: warning: unused variable 'param' Fix this by moving the parameter variable declaration into the

[PATCH] Input: i8042 - Fix warning on non-x86 builds

2008-02-08 Thread Roland Dreier
Commit c18bab80 (Input: i8042 - non-x86 build fix) introduced the following warning on non-x86 builds: drivers/input/serio/i8042.c: In function 'i8042_probe': drivers/input/serio/i8042.c:1154: warning: unused variable 'param' Fix this by moving the parameter variable declaration into the

Re: [PATCH] correct inconsistent ntp interval/tick_length usage

2008-02-08 Thread Roman Zippel
Hi, On Fri, 8 Feb 2008, john stultz wrote: clock = clocksource_get_next(); - clocksource_calculate_interval(clock, - (unsigned long)(current_tick_length()TICK_LENGTH_SHIFT)); + clocksource_calculate_interval(clock, NTP_INTERVAL_LENGTH); clock-cycle_last =

Re: [RFC][PATCH 06/30] make open_namei() return a filp

2008-02-08 Thread Christoph Hellwig
On Fri, Feb 08, 2008 at 02:26:54PM -0800, Dave Hansen wrote: open_namei() will, in the future, need to take mount write counts over its creation and truncation (via may_open()) operations. It needs to keep these write counts until any potential filp that is created gets __fput()'d. This

Re: kobject must be initialized before calling kobject_init()?!

2008-02-08 Thread Greg KH
On Fri, Feb 08, 2008 at 08:24:25PM -0800, Roland Dreier wrote: So I was perusing the code in lib/kobject.c, and I saw this: void kobject_init(struct kobject *kobj, struct kobj_type *ktype) { // [a couple of of parameter checks...] if

Re: [PATCH] correct inconsistent ntp interval/tick_length usage

2008-02-08 Thread Andrew Morton
On Sat, 9 Feb 2008 05:47:18 +0100 (CET) Roman Zippel [EMAIL PROTECTED] wrote: Hi, On Fri, 8 Feb 2008, john stultz wrote: clock = clocksource_get_next(); - clocksource_calculate_interval(clock, - (unsigned long)(current_tick_length()TICK_LENGTH_SHIFT)); +

Re: REPOST: [PATCH] Add iSCSI iBFT support (v0.4.7)

2008-02-08 Thread James Bottomley
On Fri, 2008-02-08 at 23:10 -0400, Konrad Rzeszutek wrote: +/* + * Physical location of iSCSI Boot Format Table. This is now the Virtual address, isn't it? So just drop the Physical. + */ +unsigned long ibft_addr; +EXPORT_SYMBOL(ibft_addr); And since it is the virtual address, there's no

Re: REPOST: [PATCH] Add iSCSI iBFT support (v0.4.7)

2008-02-08 Thread James Bottomley
On Fri, 2008-02-08 at 23:10 -0400, Konrad Rzeszutek wrote: + ibft_device = kmalloc(len, GFP_KERNEL); + if (!ibft_device) + return -ENOMEM; + + memcpy(ibft_device, hdr, len); This piece looks a bit odd. you're making ibft_device an exact duplicate of ibft_addr

Re: REPOST: [PATCH] Add iSCSI iBFT support (v0.4.7)

2008-02-08 Thread James Bottomley
On Fri, 2008-02-08 at 23:10 -0400, Konrad Rzeszutek wrote: + if (hdr-id == id_nic) { + pci_dev = pci_get_bus_and_slot((nic-pci_bdf 0xff00) 8, + (nic-pci_bdf 0xff)); + if (pci_dev) { + rc =

Re: [GIT PATCH] ACPI patches for 2.6.25-rc0 (#2)

2008-02-08 Thread Ingo Molnar
(Carlos Cc:-ed too) * Ingo Molnar [EMAIL PROTECTED] wrote: * Len Brown [EMAIL PROTECTED] wrote: Len Brown (6): ACPI: add newline to printk ACPI: build WMI on X86 only acer-wmi, tc1100-wmi: select ACPI_WMI hm, this new WMI code caused a bootup crash in the

Re: Integration of SCST in the mainstream Linux kernel

2008-02-08 Thread david
On Fri, 8 Feb 2008, Vladislav Bolkhovitin wrote: 2. I think, everybody will agree that Linux iSCSI target should work over some standard SCSI target framework. Hence the choice gets narrower: SCST vs STGT. I don't think there's a way for a dedicated iSCSI target (i.e. PyX/LIO) in the

struct page vs page_link

2008-02-08 Thread Mark Tuttle
Regarding: commit 18dabf473e15850c0dbc8ff13ac1e2806d542c15 This actually breaks the 802.11 subsystem (http://80211.sf.net) which relies on the page struct. (ieee80211_crypt_wep.c, line 190) Can anyone suggest an alternative kernel function or method? As of 2.6.24, the 802.11 subsystem cannot

Re: [GIT PATCH] ACPI patches for 2.6.25-rc0

2008-02-08 Thread Ingo Molnar
* Len Brown [EMAIL PROTECTED] wrote: Hi Linus, please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/lenb/linux-acpi-2.6.git release one of these caused a build failure in x86.git overnight randconfig testing: drivers/built-in.o: In function `acpi_fan_remove':

Re: [GIT PATCH] ACPI patches for 2.6.25-rc0

2008-02-08 Thread Ingo Molnar
* Ingo Molnar [EMAIL PROTECTED] wrote: one of these caused a build failure in x86.git overnight randconfig testing: drivers/built-in.o: In function `acpi_fan_remove': fan.c:(.text+0x361d5): undefined reference to `thermal_cooling_device_unregister' drivers/built-in.o: In function

Re: [RFC][PATCH 00/30] Read-only bind mounts (-mm resend)

2008-02-08 Thread Christoph Hellwig
On Fri, Feb 08, 2008 at 02:26:41PM -0800, Dave Hansen wrote: This is against current Linus git (a4ffc0a0b240a29cbe489f6db9dae112a49ef1c1). This rolls up all the -mm bugfixes that were accumulated, and addresses some new review comments from Al. Also contains some reworking from hch and a

Re: [PATCH 1/8] LinuxPPS core support.

2008-02-08 Thread Greg KH
On Fri, Feb 08, 2008 at 07:00:37PM +0100, Rodolfo Giometti wrote: This patch adds the kernel side of the PPS support currently named LinuxPPS. PPS means pulse per second and a PPS source is just a device which provides a high precision signal each second so that an application can use it to

[git pull] kgdb core and rs232 I/O drivers

2008-02-08 Thread Jason Wessel
The kgdb tree has been collapsed review. It includes the kgdb core, the x86 arch, the kgdb8250 uart driver and the kgdb console sharing driver. Since the last time the kgdb patches were posted to LKML several months ago, the kgdb core has undergone some significant cleanup, as well as the kgdb

Re: Linux 2.6.24.1 - kernel does not boot; IRQ trouble?

2008-02-08 Thread Greg KH
On Fri, Feb 08, 2008 at 11:31:24PM +, Chris Rankin wrote: Hi, I've just tried booting the 2.6.24.1 kernel, except without nmi_watchdog being enabled. It looks like there are IRQs still not being enabled. Does 2.6.24 work? Is this a 2.6.24.1 regression? thanks, greg k-h -- To

Re: [git pull] kgdb core and rs232 I/O drivers

2008-02-08 Thread Christoph Hellwig
On Sat, Feb 09, 2008 at 12:39:41AM -0600, Jason Wessel wrote: The kgdb tree has been collapsed review. It includes the kgdb core, the x86 arch, the kgdb8250 uart driver and the kgdb console sharing driver. Since the last time the kgdb patches were posted to LKML several months ago, the

[PATCH] fix up kerneldoc in fs/ioctl.c a little bit

2008-02-08 Thread Christoph Hellwig
- remove non-standard in/out markers - use tabs for formatting Signed-off-by: Christoph Hellwig [EMAIL PROTECTED] Index: linux-2.6/fs/ioctl.c === --- linux-2.6.orig/fs/ioctl.c 2008-02-09 07:49:02.0 +0100 +++

Re: [PATCH] fix up kerneldoc in fs/ioctl.c a little bit

2008-02-08 Thread Erez Zadok
In message [EMAIL PROTECTED], Christoph Hellwig writes: - remove non-standard in/out markers - use tabs for formatting Signed-off-by: Christoph Hellwig [EMAIL PROTECTED] Index: linux-2.6/fs/ioctl.c === ---

Re: [PATCH] fix up kerneldoc in fs/ioctl.c a little bit

2008-02-08 Thread Christoph Hellwig
On Sat, Feb 09, 2008 at 02:19:27AM -0500, Erez Zadok wrote: * Invokes filesystem specific -unlocked_ioctl, if one exists; otherwise * invokes * filesystem specific -ioctl method. If neither method exists, ^ I also think this extra '*' in the last comment line above is

Re: [git pull] latency tracer

2008-02-08 Thread Andrew Morton
On Fri, 8 Feb 2008 22:45:22 +0100 Ingo Molnar [EMAIL PROTECTED] wrote: Linus, please pull the latency tracer tree from: git://git.kernel.org/pub/scm/linux/kernel/git/mingo/linux-2.6-sched.git Find the shortlog below. This is the latency tracer from -rt I've never seen any of this

Re: Integration of SCST in the mainstream Linux kernel

2008-02-08 Thread Luben Tuikov
--- On Fri, 2/8/08, Vladislav Bolkhovitin [EMAIL PROTECTED] wrote: Is there an open iSCSI Target implementation which does NOT issue commands to sub-target devices via the SCSI mid-layer, but bypasses it completely? What do you mean? To call directly low level backstorage SCSI drivers

Re: [git pull] latency tracer

2008-02-08 Thread Ingo Molnar
* Andrew Morton [EMAIL PROTECTED] wrote: On Fri, 8 Feb 2008 22:45:22 +0100 Ingo Molnar [EMAIL PROTECTED] wrote: Linus, please pull the latency tracer tree from: git://git.kernel.org/pub/scm/linux/kernel/git/mingo/linux-2.6-sched.git Find the shortlog below. This is the

Re: [Scst-devel] Integration of SCST in the mainstream Linux kernel

2008-02-08 Thread Luben Tuikov
--- On Fri, 2/8/08, Nicholas A. Bellinger [EMAIL PROTECTED] wrote: Is there an open iSCSI Target implementation which does NOT issue commands to sub-target devices via the SCSI mid-layer, but bypasses it completely? Luben Hi Luben, I am guessing you mean futher down the

Re: [2.6.24 REGRESSION] BUG: Soft lockup - with VFS

2008-02-08 Thread Pete Zaitcev
On Tue, 5 Feb 2008 14:05:06 -0800, Andrew Morton [EMAIL PROTECTED] wrote: http://students.zipernowsky.hu/~oliverp/kernel/regression_2624/ I think ub.c is basically abandoned in favour of usb-storage. If so, perhaps we should remove or disble ub.c? Looks like it's just Tomo or Jens made a

Re: [RFC][PATCH 00/30] Read-only bind mounts (-mm resend)

2008-02-08 Thread Al Viro
On Fri, Feb 08, 2008 at 02:26:41PM -0800, Dave Hansen wrote: This is against current Linus git (a4ffc0a0b240a29cbe489f6db9dae112a49ef1c1). This rolls up all the -mm bugfixes that were accumulated, and addresses some new review comments from Al. Also contains some reworking from hch and a

Re: [PATCH] USB: mark USB drivers as being GPL only

2008-02-08 Thread Diego Zuccato
David Newall ha scritto: Precisely: One purpose of the driver is to enforce local compliance. It can't *enforce* it anyway, at least if the users are all around the world. Yes it can. You're confusing the software with different or modified software. Different things. And by the way, if

Re: IO queuing and complete affinity with threads (was Re: [PATCH 0/8] IO queuing and complete affinity)

2008-02-08 Thread Nick Piggin
On Fri, Feb 08, 2008 at 09:24:22AM +0100, Jens Axboe wrote: On Fri, Feb 08 2008, Nick Piggin wrote: On Fri, Feb 08, 2008 at 08:59:55AM +0100, Jens Axboe wrote: On Fri, Feb 08 2008, Nick Piggin wrote: And if you don't? Well if you don't ask for anything, you wont get anything :-)

Re: [GIT PATCH] final SCSI updates for 2.6.24 merge window

2008-02-08 Thread Geert Uytterhoeven
On Thu, 7 Feb 2008, James Bottomley wrote: On Thu, 2008-02-07 at 17:04 -0800, Harvey Harrison wrote: On Thu, 2008-02-07 at 18:56 -0600, James Bottomley wrote: Quite a bit of this is fixing things broken previously (the advansys fix is still pending resolution, but I'll send it as an -rc

Re: [PATCH] [POWERPC] Xilinx: hwicap driver

2008-02-08 Thread Jiri Slaby
On 02/08/2008 03:17 AM, Stephen Neuendorffer wrote: This includes code for new fifo-based xps_hwicap in addition to the older opb_hwicap, which has a significantly different interface. The common code between the two drivers is largely shared. Significant differences exists between this driver

Re: section breakage on ppc64 (aka __devinitconst is broken by design)

2008-02-08 Thread Sam Ravnborg
On Fri, Feb 08, 2008 at 08:14:11AM +, Jan Beulich wrote: I cannot see any other way out of this than to loose all the newly added consts. We have to different behavior across platforms to find a suitable solution that is reliable. [Kept rest of mail as I added Jan - hope he have some

Re: [PATCH] USB: mark USB drivers as being GPL only

2008-02-08 Thread Diego Zuccato
Lee Mathers ha scritto: Now we have hardware ASIC that depend on the most part a (dll in windows) or .ko .o file under linux to provide the entire instruction set. Think Winmodems, Winprinters etc Well, winmodem case is the only I could *almost* understand closed-source drivers: the

Re: [PATCH 2/5] Provide acpi_check_{mem_}region.

2008-02-08 Thread Thomas Renninger
On Thu, 2008-02-07 at 23:40 -0800, Andrew Morton wrote: On Wed, 24 Oct 2007 16:32:59 +0200 Thomas Renninger [EMAIL PROTECTED] wrote: Provide acpi_check_{mem_}region. Drivers can additionally check against possible ACPI interference by also invoking this shortly before they call

Re: [PATCH] USB: mark USB drivers as being GPL only

2008-02-08 Thread Marcel Holtmann
Hi David, I think you're missing my point: as long as the license stays the way it is now, you can never distribute proprietary code unless you've consulted a lawyer and even then you run the risk of being sued for infringement if the copyright holder thinks what you have is derived

Re: section breakage on ppc64 (aka __devinitconst is broken by design)

2008-02-08 Thread Jan Beulich
Al posted the following: ; cat a.c 'EOF' const char foo[] __attribute__ ((__section__(.blah))) = ; const char * const bar __attribute__((__section__(.blah))) = ; EOF ; gcc -m32 -S a.c ; gcc -m64 -S a.c a.c:2: error: bar causes a

[PATCH 1/1] mxser: convert large macros to functions

2008-02-08 Thread Jiri Slaby
From: Christoph Hellwig [EMAIL PROTECTED] From: Christoph Hellwig [EMAIL PROTECTED] Signed-off-by: Christoph Hellwig [EMAIL PROTECTED] Acked-by: Jiri Slaby [EMAIL PROTECTED] --- drivers/char/mxser.c | 229 ++ drivers/char/mxser.h | 137

Re: MM kernels 2.6.24-rc*-mm*, 2.6.24-mm1: gnome-terminal stuck in tty_poll

2008-02-08 Thread Peter Zijlstra
On Thu, 2008-02-07 at 19:26 -0600, Jay Cliburn wrote: On Thu, 07 Feb 2008 21:24:47 +0100 Peter Zijlstra [EMAIL PROTECTED] wrote: The trace isn't from me; it's from Zan. He's running -mm, I'm not, if that makes a difference. Call Trace:

Re: [PATCH] arch/arm/Kconfig: Make UIO available on ARM architecture

2008-02-08 Thread David Woodhouse
On Thu, 2008-02-07 at 21:23 +0100, Sam Ravnborg wrote: Both situations are trivially fixable by introducing HAVE_IDE and HAVE_MTD. See attached patch. HAVE_MTD is wrong. The actual problem we're trying to solve is that when the architecture lacks alignment fixups, certain patterns of write

Re: [LINUX-KERNEL] C++ in linux kernel

2008-02-08 Thread Bernd Petrovitsch
On Fre, 2008-02-08 at 10:51 +0530, rohit h wrote: Hi, I am a kernel newbie. I tried to insmod a C++ module containing classes, inheritance. I am getting 'unresolved symbol' error when I use the 'new' keyword. What could the problem be? That you used C++ is the problem. Use plain C and

Re: [PATCH] arch/arm/Kconfig: Make UIO available on ARM architecture

2008-02-08 Thread David Woodhouse
On Fri, 2008-02-08 at 09:04 +, David Woodhouse wrote: We could add get_unaligned() in certain places in the code, but that isn't ideal for the majority of architectures. Actually, we already did that, despite the fact that it isn't optimal. So there's no need to omit anything MTD-related

Re: [RFC] ext3 freeze feature

2008-02-08 Thread Takashi Sato
Hi, Ted wrote: And I do agree that we probably should just implement this in filesystem independent way, in which case all of the filesystems that support this already have super_operations functions write_super_lockfs() and unlockfs(). So if this is done using a new system call, there should

Re: [PATCH] arch/arm/Kconfig: Make UIO available on ARM architecture

2008-02-08 Thread David Woodhouse
On Fri, 2008-02-08 at 10:23 +, Russell King - ARM Linux wrote: That would be misleading though - !CPU_CP15_MMU does not mean we support unaligned accesses. It means that we may have no way to support fixing up unaligned accesses. Doesn't that mean you should disallow MTD (or at least

Re: [PATCH] sysctl: allow embedded targets to disable sysctl_check.c

2008-02-08 Thread Eric W. Biederman
Andrew Morton [EMAIL PROTECTED] writes: On Thu, 7 Feb 2008 14:38:58 +0100 Holger Schurig [EMAIL PROTECTED] wrote: Disable sysctl_check.c for embedded targets. This saves about about 11 kB in .text and another 11 kB in .data on a PXA255 embedded platform. Nice improvement. But iirc

Re: Integration of SCST in the mainstream Linux kernel

2008-02-08 Thread Vladislav Bolkhovitin
[EMAIL PROTECTED] wrote: On Thu, 7 Feb 2008, Vladislav Bolkhovitin wrote: Bart Van Assche wrote: - It has been discussed which iSCSI target implementation should be in the mainstream Linux kernel. There is no agreement on this subject yet. The short-term options are as follows: 1) Do not

Re: [PATCH] arch/arm/Kconfig: Make UIO available on ARM architecture

2008-02-08 Thread Russell King - ARM Linux
On Fri, Feb 08, 2008 at 10:18:31AM +, David Woodhouse wrote: But still, it's HAVE_UNALIGNED_ACCESS which we want to depend on, not a newly-invented HAVE_MTD. And there are other places we really ought to be depending on HAVE_UNALIGNED_ACCESS too. That would be misleading though -

[BUILD_FAILURE] 2.6.24-git18 build fails section type conflict psmouse-base

2008-02-08 Thread Kamalesh Babulal
Hi, The 2.6.24-git18 kernel build fails on the power machine with following message drivers/input/mouse/psmouse-base.c:44: error: __param_proto causes a section type conflict drivers/input/mouse/psmouse-base.c:44: error: __param_proto causes a section type conflict make[3]: ***

  1   2   3   4   5   6   7   8   9   10   >