[PATCH v2 2/4] ASoC: sunxi: Add Allwinner A10 Digital Audio driver

2016-06-15 Thread Maxime Ripard
The Allwinner A10 and later come with a hardware block that used for the PCM and I2S interfaces. Add a driver for it in ASoC. Signed-off-by: Maxime Ripard --- sound/soc/sunxi/Kconfig | 9 + sound/soc/sunxi/Makefile| 2 +- sound/soc/sunxi/sun4i-i2s.c | 703

Re: [PATCH] tools/perf: fix the word selected in find_*_bit

2016-06-15 Thread Yury Norov
On Wed, Jun 15, 2016 at 10:51:27PM +0300, Yury Norov wrote: > Hi Madhavan, > > On Wed, Jun 15, 2016 at 05:12:53PM +0530, Madhavan Srinivasan wrote: > > When decoding the perf_regs mask in regs_dump__printf(), > > we loop through the mask using find_first_bit and find_next_bit functions. > > And

[PATCH v2 0/4] ASoC: sunxi: Add i2s controller support

2016-06-15 Thread Maxime Ripard
Hi everyone, This is the second version of the I2S support for the controller found in the Allwinner A10 and later SoCs. Playback has been tested with an UDA1380 on an A20-Olinuxino. Capture is not implemented yet, but will come eventually. Let me know what you think, Maxime Changes from v1:

[PATCH v2 4/4] ARM: sun7i: Add DAI nodes

2016-06-15 Thread Maxime Ripard
Add the new DAI blocks to the device tree. Signed-off-by: Maxime Ripard --- arch/arm/boot/dts/sun7i-a20.dtsi | 39 +++ 1 file changed, 39 insertions(+) diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi

[PATCH v2 0/4] ASoC: sunxi: Add i2s controller support

2016-06-15 Thread Maxime Ripard
Hi everyone, This is the second version of the I2S support for the controller found in the Allwinner A10 and later SoCs. Playback has been tested with an UDA1380 on an A20-Olinuxino. Capture is not implemented yet, but will come eventually. Let me know what you think, Maxime Changes from v1:

[PATCH v2 4/4] ARM: sun7i: Add DAI nodes

2016-06-15 Thread Maxime Ripard
Add the new DAI blocks to the device tree. Signed-off-by: Maxime Ripard --- arch/arm/boot/dts/sun7i-a20.dtsi | 39 +++ 1 file changed, 39 insertions(+) diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi index

Re: [PATCH] rtlwifi: use s8 instead of char

2016-06-15 Thread Jes Sorensen
Arnd Bergmann writes: > Compiling the rtlwifi drivers for ARM with gcc -Wextra warns about lots of > incorrect code that results from 'char' being unsigned here, e.g. > > realtek/rtlwifi/rc.c:113:18: error: comparison is always true due to limited > range of data type

Re: [PATCH] rtlwifi: use s8 instead of char

2016-06-15 Thread Jes Sorensen
Arnd Bergmann writes: > Compiling the rtlwifi drivers for ARM with gcc -Wextra warns about lots of > incorrect code that results from 'char' being unsigned here, e.g. > > realtek/rtlwifi/rc.c:113:18: error: comparison is always true due to limited > range of data type [-Werror=type-limits] >

Re: [PATCH] arm/arm64/irqchip/pci: fix PCI_MSI dependencies

2016-06-15 Thread Arnd Bergmann
On Wednesday, June 15, 2016 4:02:11 PM CEST Bjorn Helgaas wrote: > I applied this to pci/msi, minus the crypto change that looks unrelated: > > > @@ -1038,6 +1038,8 @@ source "arch/arm64/Kconfig.debug" > > source "security/Kconfig" > > > > source "crypto/Kconfig" > > +if CRYPTO > > source

Re: [PATCH] arm/arm64/irqchip/pci: fix PCI_MSI dependencies

2016-06-15 Thread Arnd Bergmann
On Wednesday, June 15, 2016 4:02:11 PM CEST Bjorn Helgaas wrote: > I applied this to pci/msi, minus the crypto change that looks unrelated: > > > @@ -1038,6 +1038,8 @@ source "arch/arm64/Kconfig.debug" > > source "security/Kconfig" > > > > source "crypto/Kconfig" > > +if CRYPTO > > source

Re: [PATCH] arm/arm64/irqchip/pci: fix PCI_MSI dependencies

2016-06-15 Thread Bjorn Helgaas
On Wed, Jun 15, 2016 at 10:09:38PM +0200, Arnd Bergmann wrote: > The PCI_MSI symbol is used inconsistently throughout the tree, > with some drivers using 'select' and others using 'depends on', > or using conditional selects. This keeps causing problems, > and the latest one is a result of

Re: [PATCH] arm/arm64/irqchip/pci: fix PCI_MSI dependencies

2016-06-15 Thread Bjorn Helgaas
On Wed, Jun 15, 2016 at 10:09:38PM +0200, Arnd Bergmann wrote: > The PCI_MSI symbol is used inconsistently throughout the tree, > with some drivers using 'select' and others using 'depends on', > or using conditional selects. This keeps causing problems, > and the latest one is a result of

Re: [PATCH v3 7/8] acpi: add support for configfs

2016-06-15 Thread Rafael J. Wysocki
On Wed, Jun 15, 2016 at 12:20 PM, Octavian Purdila wrote: > On Wed, Jun 15, 2016 at 1:59 AM, Rafael J. Wysocki wrote: >> Hi Octavian, >> >> On Wednesday, June 15, 2016 06:43:21 AM kbuild test robot wrote: >>> Hi, >>> >>> [auto build test ERROR on

Re: [PATCH v3 7/8] acpi: add support for configfs

2016-06-15 Thread Rafael J. Wysocki
On Wed, Jun 15, 2016 at 12:20 PM, Octavian Purdila wrote: > On Wed, Jun 15, 2016 at 1:59 AM, Rafael J. Wysocki wrote: >> Hi Octavian, >> >> On Wednesday, June 15, 2016 06:43:21 AM kbuild test robot wrote: >>> Hi, >>> >>> [auto build test ERROR on pm/linux-next] >>> [also build test ERROR on

[PATCH] rtlwifi: use s8 instead of char

2016-06-15 Thread Arnd Bergmann
Compiling the rtlwifi drivers for ARM with gcc -Wextra warns about lots of incorrect code that results from 'char' being unsigned here, e.g. realtek/rtlwifi/rc.c:113:18: error: comparison is always true due to limited range of data type [-Werror=type-limits]

[PATCH] rtlwifi: use s8 instead of char

2016-06-15 Thread Arnd Bergmann
Compiling the rtlwifi drivers for ARM with gcc -Wextra warns about lots of incorrect code that results from 'char' being unsigned here, e.g. realtek/rtlwifi/rc.c:113:18: error: comparison is always true due to limited range of data type [-Werror=type-limits]

[PATCH] bridge: netfilter: spanning tree: Add masked_ether_addr_equal and neatening

2016-06-15 Thread Joe Perches
There is code duplication of a masked ethernet address comparison here so make it a separate function instead. Miscellanea: o Neaten alignment of FWINV macro uses to make it clearer for the reader Signed-off-by: Joe Perches --- This masked_ether_addr_equal function could go

[PATCH] bridge: netfilter: spanning tree: Add masked_ether_addr_equal and neatening

2016-06-15 Thread Joe Perches
There is code duplication of a masked ethernet address comparison here so make it a separate function instead. Miscellanea: o Neaten alignment of FWINV macro uses to make it clearer for the reader Signed-off-by: Joe Perches --- This masked_ether_addr_equal function could go into

Re: [PATCH v8 0/5] skb_array: array based FIFO for skbs

2016-06-15 Thread David Miller
From: "Michael S. Tsirkin" Date: Mon, 13 Jun 2016 23:54:26 +0300 > This is in response to the proposal by Jason to make tun > rx packet queue lockless using a circular buffer. > My testing seems to show that at least for the common usecase > in networking, which isn't lockless,

Re: [PATCH v8 0/5] skb_array: array based FIFO for skbs

2016-06-15 Thread David Miller
From: "Michael S. Tsirkin" Date: Mon, 13 Jun 2016 23:54:26 +0300 > This is in response to the proposal by Jason to make tun > rx packet queue lockless using a circular buffer. > My testing seems to show that at least for the common usecase > in networking, which isn't lockless, circular buffer >

Re: [PATCH 2/2] iommu/amd: Destroy api_lock mutex when freeing domain

2016-06-15 Thread Borislav Petkov
On Wed, Jun 15, 2016 at 05:53:15PM +, Vesely, Jan wrote: > There are no specific bugs/oopses that these patches fix (that I'm > aware of). Both were found while I was familiarizing myself with the > code looking for memory corruption (which turned out to be [0]). > Either issue would be very

[PATCH 2/2] scsi: wd7000: print sector number as 64-bit

2016-06-15 Thread Arnd Bergmann
Enabling format checking in dprintk() shows that wd7000_biosparam uses an incorrect format string for sector_t: drivers/scsi/wd7000.c: In function 'wd7000_biosparam': drivers/scsi/wd7000.c:1594:21: error: format '%d' expects argument of type 'int', but argument 3 has type 'sector_t {aka long

Re: [PATCH 2/2] iommu/amd: Destroy api_lock mutex when freeing domain

2016-06-15 Thread Borislav Petkov
On Wed, Jun 15, 2016 at 05:53:15PM +, Vesely, Jan wrote: > There are no specific bugs/oopses that these patches fix (that I'm > aware of). Both were found while I was familiarizing myself with the > code looking for memory corruption (which turned out to be [0]). > Either issue would be very

[PATCH 2/2] scsi: wd7000: print sector number as 64-bit

2016-06-15 Thread Arnd Bergmann
Enabling format checking in dprintk() shows that wd7000_biosparam uses an incorrect format string for sector_t: drivers/scsi/wd7000.c: In function 'wd7000_biosparam': drivers/scsi/wd7000.c:1594:21: error: format '%d' expects argument of type 'int', but argument 3 has type 'sector_t {aka long

Re: [linux-sunxi] [PATCH] [V2] ARM: dts: sun7i: Add dts file for Bananapi M1 Plus board

2016-06-15 Thread Maxime Ripard
Hi Chen-Yu, On Mon, Jun 13, 2016 at 11:01:53AM +0800, Chen-Yu Tsai wrote: > On Fri, Jun 10, 2016 at 5:38 PM, Maxime Ripard > wrote: > > On Thu, Jun 02, 2016 at 11:15:55AM +0200, Bernhard Nortmann wrote: > >> Am 02.06.2016 um 10:16 schrieb Maxime Ripard: > >>

Re: [linux-sunxi] [PATCH] [V2] ARM: dts: sun7i: Add dts file for Bananapi M1 Plus board

2016-06-15 Thread Maxime Ripard
Hi Chen-Yu, On Mon, Jun 13, 2016 at 11:01:53AM +0800, Chen-Yu Tsai wrote: > On Fri, Jun 10, 2016 at 5:38 PM, Maxime Ripard > wrote: > > On Thu, Jun 02, 2016 at 11:15:55AM +0200, Bernhard Nortmann wrote: > >> Am 02.06.2016 um 10:16 schrieb Maxime Ripard: > >> >[...] > >> >Yes, everything that is

lk 4.7 regression: EDAC, amd64_edac: Drop pci_register_driver() use

2016-06-15 Thread Tony Battersby
The following commit is causing an oops: 3f37a36b6282 ("EDAC, amd64_edac: Drop pci_register_driver() use") The oops happens when I "modprobe amd64_edac_mod" on an Intel Xeon-based system, or when booting the same system with amd64_edac built-in. Obviously the module is not meant for this

lk 4.7 regression: EDAC, amd64_edac: Drop pci_register_driver() use

2016-06-15 Thread Tony Battersby
The following commit is causing an oops: 3f37a36b6282 ("EDAC, amd64_edac: Drop pci_register_driver() use") The oops happens when I "modprobe amd64_edac_mod" on an Intel Xeon-based system, or when booting the same system with amd64_edac built-in. Obviously the module is not meant for this

Re: [PATCH 02/13] irq: Introduce IRQD_AFFINITY_MANAGED flag

2016-06-15 Thread Bart Van Assche
On 06/15/2016 10:12 PM, Keith Busch wrote: On Wed, Jun 15, 2016 at 04:06:55PM -0400, Keith Busch wrote: 0: A0 B0 1: A1 B1 2: A2 B2 3: A3 B3 4: A4 B4 5: A5 B5 6: A6 B6 7: A7 B7 8: (none) ... 31: (none) I'll need to look at the follow on patches do to confirm, but that's not what this should

Re: [PATCH 02/13] irq: Introduce IRQD_AFFINITY_MANAGED flag

2016-06-15 Thread Bart Van Assche
On 06/15/2016 10:12 PM, Keith Busch wrote: On Wed, Jun 15, 2016 at 04:06:55PM -0400, Keith Busch wrote: 0: A0 B0 1: A1 B1 2: A2 B2 3: A3 B3 4: A4 B4 5: A5 B5 6: A6 B6 7: A7 B7 8: (none) ... 31: (none) I'll need to look at the follow on patches do to confirm, but that's not what this should

Re: [PATCH 1/2] mlx5: only register devlink when ethernet is available

2016-06-15 Thread Arnd Bergmann
On Wednesday, June 15, 2016 7:04:54 PM CEST Saeed Mahameed wrote: > > Hi Arnd, > > We already took care of those issues, they only apply to Leon's tree > https://git.kernel.org/cgit/linux/kernel/git/leon/linux-rdma.git/, > this tree is meant to maintain MLX5 Shared code between netdev and >

Re: [PATCH 1/2] mlx5: only register devlink when ethernet is available

2016-06-15 Thread Arnd Bergmann
On Wednesday, June 15, 2016 7:04:54 PM CEST Saeed Mahameed wrote: > > Hi Arnd, > > We already took care of those issues, they only apply to Leon's tree > https://git.kernel.org/cgit/linux/kernel/git/leon/linux-rdma.git/, > this tree is meant to maintain MLX5 Shared code between netdev and >

Re: [PATCH] amdgpu: use NULL instead of 0 for pointer

2016-06-15 Thread Christian König
Am 15.06.2016 um 22:15 schrieb Arnd Bergmann: In the AMD powerplay driver, a pointer is checked for validity by comparing against an integer '0', which causes a harmless warning when building with "make W=1": drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/processpptables.c:1502:16: error:

Re: [PATCH] amdgpu: use NULL instead of 0 for pointer

2016-06-15 Thread Christian König
Am 15.06.2016 um 22:15 schrieb Arnd Bergmann: In the AMD powerplay driver, a pointer is checked for validity by comparing against an integer '0', which causes a harmless warning when building with "make W=1": drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/processpptables.c:1502:16: error:

Re: [PATCH v9 3/4] Add Cyclomatic complexity GCC plugin

2016-06-15 Thread Emese Revfy
On Tue, 14 Jun 2016 12:29:59 -0700 Laura Abbott wrote: > On 05/23/2016 03:10 PM, Emese Revfy wrote: > 1) make mrproper > 2) make defconfig > 3) enable GCC_PLUGINS, GCC_PLUGIN_CYC_COMPLEXITY > 4) enable FUNCTION_TRACER (it will select other options as well) > 5) make && make

Re: [PATCH v9 3/4] Add Cyclomatic complexity GCC plugin

2016-06-15 Thread Emese Revfy
On Tue, 14 Jun 2016 12:29:59 -0700 Laura Abbott wrote: > On 05/23/2016 03:10 PM, Emese Revfy wrote: > 1) make mrproper > 2) make defconfig > 3) enable GCC_PLUGINS, GCC_PLUGIN_CYC_COMPLEXITY > 4) enable FUNCTION_TRACER (it will select other options as well) > 5) make && make modules > > ERROR:

[PATCH] objtool: fix STACK_FRAME_NON_STANDARD macro checking for function symbols

2016-06-15 Thread Josh Poimboeuf
Mathieu Desnoyers reported that the STACK_FRAME_NON_STANDARD macro wasn't working with the lttng_filter_interpret_bytecode() function in the lttng-modules code. Usually the relocation created by STACK_FRAME_NON_STANDARD creates a reference to a section symbol like this: Offset

[PATCH] objtool: fix STACK_FRAME_NON_STANDARD macro checking for function symbols

2016-06-15 Thread Josh Poimboeuf
Mathieu Desnoyers reported that the STACK_FRAME_NON_STANDARD macro wasn't working with the lttng_filter_interpret_bytecode() function in the lttng-modules code. Usually the relocation created by STACK_FRAME_NON_STANDARD creates a reference to a section symbol like this: Offset

Re: [PATCH v3 2/4] Add the latent_entropy gcc plugin

2016-06-15 Thread Emese Revfy
On Wed, 15 Jun 2016 11:07:08 -0700 Kees Cook wrote: > On Tue, Jun 14, 2016 at 3:20 PM, Emese Revfy wrote: > This doesn't look right to me: these are CFLAGS_REMOVE_* entries, and > I think you want to _add_ the DISABLE_LATENT_ENTROPY_PLUGIN to the >

Re: [PATCH v3 2/4] Add the latent_entropy gcc plugin

2016-06-15 Thread Emese Revfy
On Wed, 15 Jun 2016 11:07:08 -0700 Kees Cook wrote: > On Tue, Jun 14, 2016 at 3:20 PM, Emese Revfy wrote: > This doesn't look right to me: these are CFLAGS_REMOVE_* entries, and > I think you want to _add_ the DISABLE_LATENT_ENTROPY_PLUGIN to the > CFLAGS here. Thanks for the report. I think

Re: stack validation warning on lttng-modules bytecode interpreter

2016-06-15 Thread Mathieu Desnoyers
- On Jun 15, 2016, at 4:28 PM, Josh Poimboeuf jpoim...@redhat.com wrote: > On Wed, Jun 15, 2016 at 03:24:52PM -0500, Josh Poimboeuf wrote: >> Thanks, figured it out. It was an objtool bug. It was expecting the >> macro to create a section symbol (STT_SECTION), but for some reason this >>

Re: stack validation warning on lttng-modules bytecode interpreter

2016-06-15 Thread Mathieu Desnoyers
- On Jun 15, 2016, at 4:28 PM, Josh Poimboeuf jpoim...@redhat.com wrote: > On Wed, Jun 15, 2016 at 03:24:52PM -0500, Josh Poimboeuf wrote: >> Thanks, figured it out. It was an objtool bug. It was expecting the >> macro to create a section symbol (STT_SECTION), but for some reason this >>

[PATCH v2] of: fix memory leak related to safe_name()

2016-06-15 Thread Frank Rowand
From: Frank Rowand Fix a memory leak resulting from memory allocation in safe_name(). This patch fixes all call sites of safe_name(). Mathieu Malaterre reported the memory leak on boot: On my PowerMac device-tree would generate a duplicate name: [0.023043]

[PATCH v2] of: fix memory leak related to safe_name()

2016-06-15 Thread Frank Rowand
From: Frank Rowand Fix a memory leak resulting from memory allocation in safe_name(). This patch fixes all call sites of safe_name(). Mathieu Malaterre reported the memory leak on boot: On my PowerMac device-tree would generate a duplicate name: [0.023043] device-tree: Duplicate name in

[PATCH 1/2] scsi: lpfc: avoid harmless comparison warning

2016-06-15 Thread Arnd Bergmann
When building with -Wextra, we get a lot of warnings for the lpfc driver concerning expressions that are always true, starting with: drivers/scsi/lpfc/lpfc_attr.c: In function 'lpfc_enable_npiv_init': drivers/scsi/lpfc/lpfc_attr.c:2786:77: error: comparison of unsigned expression >= 0 is always

[PATCH 1/2] scsi: lpfc: avoid harmless comparison warning

2016-06-15 Thread Arnd Bergmann
When building with -Wextra, we get a lot of warnings for the lpfc driver concerning expressions that are always true, starting with: drivers/scsi/lpfc/lpfc_attr.c: In function 'lpfc_enable_npiv_init': drivers/scsi/lpfc/lpfc_attr.c:2786:77: error: comparison of unsigned expression >= 0 is always

Re: [PATCH 3/3] drivers/media/media-device: fix double free bug in _unregister()

2016-06-15 Thread Max Kellermann
On 2016/06/15 22:32, Shuah Khan wrote: > This change introduces memory leaks, since drivers are relying on > media_device_unregister() to free interfaces. This is what I thought, too, until I checked the code paths. Who adds entries to that list? Only

[GIT PULL] UBI fixes for 4.7-rc4

2016-06-15 Thread Richard Weinberger
Linus, The following changes since commit db06d759d6cf903aeda8c107fd3abd366dd80200: Merge branch 'for-4.7-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/percpu (2016-06-13 19:54:46 -1000) are available in the git repository at: git://git.infradead.org/linux-ubifs.git

Re: [PATCH 3/3] drivers/media/media-device: fix double free bug in _unregister()

2016-06-15 Thread Max Kellermann
On 2016/06/15 22:32, Shuah Khan wrote: > This change introduces memory leaks, since drivers are relying on > media_device_unregister() to free interfaces. This is what I thought, too, until I checked the code paths. Who adds entries to that list? Only media_gobj_create() does, and only when

[GIT PULL] UBI fixes for 4.7-rc4

2016-06-15 Thread Richard Weinberger
Linus, The following changes since commit db06d759d6cf903aeda8c107fd3abd366dd80200: Merge branch 'for-4.7-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/percpu (2016-06-13 19:54:46 -1000) are available in the git repository at: git://git.infradead.org/linux-ubifs.git

[PATCH] staging/rtlwifi: use s8 instead of char

2016-06-15 Thread Arnd Bergmann
Compiling the rtlwifi drivers for ARM with gcc -Wextra warns about lots of incorrect code that results from 'char' being unsigned here, e.g. staging/rtl8192e/rtl8192e/r8192E_phy.c:1072:36: error: comparison is always false due to limited range of data type [-Werror=type-limits]

[PATCH v2] writeback: inode cgroup wb switch should not call ihold()

2016-06-15 Thread Tahsin Erdogan
Asynchronous wb switching of inodes takes an additional ref count on an inode to make sure inode remains valid until switchover is completed. However, anyone calling ihold() must already have a ref count on inode, but in this case inode->i_count may already be zero: [ cut here

[PATCH] staging/rtlwifi: use s8 instead of char

2016-06-15 Thread Arnd Bergmann
Compiling the rtlwifi drivers for ARM with gcc -Wextra warns about lots of incorrect code that results from 'char' being unsigned here, e.g. staging/rtl8192e/rtl8192e/r8192E_phy.c:1072:36: error: comparison is always false due to limited range of data type [-Werror=type-limits]

[PATCH v2] writeback: inode cgroup wb switch should not call ihold()

2016-06-15 Thread Tahsin Erdogan
Asynchronous wb switching of inodes takes an additional ref count on an inode to make sure inode remains valid until switchover is completed. However, anyone calling ihold() must already have a ref count on inode, but in this case inode->i_count may already be zero: [ cut here

Re: [PATCH] of: fix memory leak related to safe_name()

2016-06-15 Thread Frank Rowand
On 06/15/16 12:12, Rob Herring wrote: > On Wed, Jun 15, 2016 at 1:13 PM, Frank Rowand wrote: >> From: Frank Rowand >> >> Fix a memory leak resulting from memory allocation in safe_name(). >> This patch fixes all call sites of safe_name(). >> >>

Re: [PATCH] of: fix memory leak related to safe_name()

2016-06-15 Thread Frank Rowand
On 06/15/16 12:12, Rob Herring wrote: > On Wed, Jun 15, 2016 at 1:13 PM, Frank Rowand wrote: >> From: Frank Rowand >> >> Fix a memory leak resulting from memory allocation in safe_name(). >> This patch fixes all call sites of safe_name(). >> >> Mathieu Malaterre reported the memory leak on boot:

Re: [PATCH v3 0/4] Introduce the latent_entropy gcc plugin

2016-06-15 Thread Emese Revfy
On Wed, 15 Jun 2016 11:55:44 -0700 Kees Cook wrote: > The limit on the length of lines is 80 columns and this is a strongly > preferred limit. I think the code looks worse when it is truncated to 80 columns but I'll do it and resend the patches. -- Emese

Re: [PATCH v3 0/4] Introduce the latent_entropy gcc plugin

2016-06-15 Thread Emese Revfy
On Wed, 15 Jun 2016 11:55:44 -0700 Kees Cook wrote: > The limit on the length of lines is 80 columns and this is a strongly > preferred limit. I think the code looks worse when it is truncated to 80 columns but I'll do it and resend the patches. -- Emese

Re: [PATCH 3/3] drivers/media/media-device: fix double free bug in _unregister()

2016-06-15 Thread Shuah Khan
On 06/15/2016 02:15 PM, Max Kellermann wrote: > While removing all interfaces in media_device_unregister(), all > media_interface pointers are freed. This is illegal and results in > double kfree() if any media_interface is still linked at this point; > maybe because a userspace process still has

Re: [PATCH 3/3] drivers/media/media-device: fix double free bug in _unregister()

2016-06-15 Thread Shuah Khan
On 06/15/2016 02:15 PM, Max Kellermann wrote: > While removing all interfaces in media_device_unregister(), all > media_interface pointers are freed. This is illegal and results in > double kfree() if any media_interface is still linked at this point; > maybe because a userspace process still has

Re: [PATCH v5 2/3] drm/arm: Add support for Mali Display Processors

2016-06-15 Thread Daniel Vetter
On Wed, Jun 15, 2016 at 10:05 PM, Russell King - ARM Linux wrote: > On Wed, Jun 15, 2016 at 09:29:38PM +0200, Daniel Vetter wrote: >> On Wed, Jun 15, 2016 at 7:21 PM, Liviu Dudau wrote: >> > Could be the tda998x_drv fault, but I'm getting this splat:

Re: [PATCH v5 2/3] drm/arm: Add support for Mali Display Processors

2016-06-15 Thread Daniel Vetter
On Wed, Jun 15, 2016 at 10:05 PM, Russell King - ARM Linux wrote: > On Wed, Jun 15, 2016 at 09:29:38PM +0200, Daniel Vetter wrote: >> On Wed, Jun 15, 2016 at 7:21 PM, Liviu Dudau wrote: >> > Could be the tda998x_drv fault, but I'm getting this splat: >> >> Yeah, tda9998x needs to be fixed to

Re: [PATCH 2/4] scripts: add reqs python library

2016-06-15 Thread Julia Lawall
On Wed, 15 Jun 2016, Luis R. Rodriguez wrote: > On Wed, Jun 15, 2016 at 09:11:45PM +0200, Michal Marek wrote: > > Dne 15.6.2016 v 18:02 Luis R. Rodriguez napsal(a): > > > On Wed, Jun 15, 2016 at 09:50:11AM +0200, Michal Marek wrote: > > >> On 2016-06-15 00:10, Luis R. Rodriguez wrote: > > >>> +

Re: [PATCH 2/4] scripts: add reqs python library

2016-06-15 Thread Julia Lawall
On Wed, 15 Jun 2016, Luis R. Rodriguez wrote: > On Wed, Jun 15, 2016 at 09:11:45PM +0200, Michal Marek wrote: > > Dne 15.6.2016 v 18:02 Luis R. Rodriguez napsal(a): > > > On Wed, Jun 15, 2016 at 09:50:11AM +0200, Michal Marek wrote: > > >> On 2016-06-15 00:10, Luis R. Rodriguez wrote: > > >>> +

[PATCH] net: sfc: avoid -Wtype-limits warning

2016-06-15 Thread Arnd Bergmann
When building with -Wextra, we get a harmless warning from the EFX_EXTRACT_OWORD32 macro: ethernet/sfc/farch.c: In function 'efx_farch_test_registers': ethernet/sfc/farch.c:119:30: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits] ethernet/sfc/farch.c:124:144:

[PATCH] net: sfc: avoid -Wtype-limits warning

2016-06-15 Thread Arnd Bergmann
When building with -Wextra, we get a harmless warning from the EFX_EXTRACT_OWORD32 macro: ethernet/sfc/farch.c: In function 'efx_farch_test_registers': ethernet/sfc/farch.c:119:30: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits] ethernet/sfc/farch.c:124:144:

[PATCH] nl80211: improve nl80211_parse_mesh_config type checking

2016-06-15 Thread Arnd Bergmann
When building a kernel with W=1, the nl80211.c file causes a number of warnings, all about the same problem: net/wireless/nl80211.c: In function 'nl80211_parse_mesh_config': net/wireless/nl80211.c:5287:103: error: comparison is always false due to limited range of data type [-Werror=type-limits]

Re: [PATCH 1/6] staging: i4l: icn: do not use return as a function

2016-06-15 Thread Luis de Bethencourt
On 11/06/16 22:10, Sudip Mukherjee wrote: > return is not a function so no need to use the parenthesis. > > Signed-off-by: Sudip Mukherjee > --- > drivers/staging/i4l/icn/icn.c | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) > All the

Re: [PATCH 1/6] staging: i4l: icn: do not use return as a function

2016-06-15 Thread Luis de Bethencourt
On 11/06/16 22:10, Sudip Mukherjee wrote: > return is not a function so no need to use the parenthesis. > > Signed-off-by: Sudip Mukherjee > --- > drivers/staging/i4l/icn/icn.c | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) > All the patches in this series look like

[PATCH] nl80211: improve nl80211_parse_mesh_config type checking

2016-06-15 Thread Arnd Bergmann
When building a kernel with W=1, the nl80211.c file causes a number of warnings, all about the same problem: net/wireless/nl80211.c: In function 'nl80211_parse_mesh_config': net/wireless/nl80211.c:5287:103: error: comparison is always false due to limited range of data type [-Werror=type-limits]

[PATCH v2] powerpc/pseries: start rtasd before PCI probing

2016-06-15 Thread Greg Kurz
A strange behaviour is observed when comparing PCI hotplug in QEMU, between x86 and pseries. If you consider the following steps: - start a VM - add a PCI device via the QEMU monitor before the rtasd has started (for example starting the VM in paused state, or hotplug during FW or boot loader)

Re: [PATCH v2] Linux VM workaround for Knights Landing A/D leak

2016-06-15 Thread Nadav Amit
Dave Hansen wrote: > On 06/15/2016 01:04 PM, Nadav Amit wrote: >> Be careful here. According to the SDM when invalidating a huge-page, >> each 4KB page needs to be invalidated separately. In practice, when >> Linux invalidates 2MB/1GB pages it performs a full TLB

Re: [PATCH 2/4] scripts: add reqs python library

2016-06-15 Thread Luis R. Rodriguez
On Wed, Jun 15, 2016 at 09:11:45PM +0200, Michal Marek wrote: > Dne 15.6.2016 v 18:02 Luis R. Rodriguez napsal(a): > > On Wed, Jun 15, 2016 at 09:50:11AM +0200, Michal Marek wrote: > >> On 2016-06-15 00:10, Luis R. Rodriguez wrote: > >>> +weight = (int(rel_specs['VERSION'])<< 32) + \ >

Re: [PATCH 2/2] iommu/amd: Destroy api_lock mutex when freeing domain

2016-06-15 Thread Vesely, Jan
On Wed, 2016-06-15 at 13:54 +0200, j...@8bytes.org wrote: > On Thu, Jun 09, 2016 at 03:48:44PM +, Vesely, Jan wrote: > > On Sat, 2016-05-21 at 14:11 -0400, Jan Vesely wrote: > > > From: Jan Vesely > > > > > > Signed-off-by: Jan Vesely > > > --- > > >  

Re: stack validation warning on lttng-modules bytecode interpreter

2016-06-15 Thread Josh Poimboeuf
On Wed, Jun 15, 2016 at 03:24:52PM -0500, Josh Poimboeuf wrote: > Thanks, figured it out. It was an objtool bug. It was expecting the > macro to create a section symbol (STT_SECTION), but for some reason this > file's use of the macro creates a function symbol (STT_FUNC). Actually, to be

Re: [PATCH 2/2] iommu/amd: Destroy api_lock mutex when freeing domain

2016-06-15 Thread Vesely, Jan
On Wed, 2016-06-15 at 13:54 +0200, j...@8bytes.org wrote: > On Thu, Jun 09, 2016 at 03:48:44PM +, Vesely, Jan wrote: > > On Sat, 2016-05-21 at 14:11 -0400, Jan Vesely wrote: > > > From: Jan Vesely > > > > > > Signed-off-by: Jan Vesely > > > --- > > >  drivers/iommu/amd_iommu.c | 1 + > > >  

Re: stack validation warning on lttng-modules bytecode interpreter

2016-06-15 Thread Josh Poimboeuf
On Wed, Jun 15, 2016 at 03:24:52PM -0500, Josh Poimboeuf wrote: > Thanks, figured it out. It was an objtool bug. It was expecting the > macro to create a section symbol (STT_SECTION), but for some reason this > file's use of the macro creates a function symbol (STT_FUNC). Actually, to be

[PATCH v2] powerpc/pseries: start rtasd before PCI probing

2016-06-15 Thread Greg Kurz
A strange behaviour is observed when comparing PCI hotplug in QEMU, between x86 and pseries. If you consider the following steps: - start a VM - add a PCI device via the QEMU monitor before the rtasd has started (for example starting the VM in paused state, or hotplug during FW or boot loader)

Re: [PATCH v2] Linux VM workaround for Knights Landing A/D leak

2016-06-15 Thread Nadav Amit
Dave Hansen wrote: > On 06/15/2016 01:04 PM, Nadav Amit wrote: >> Be careful here. According to the SDM when invalidating a huge-page, >> each 4KB page needs to be invalidated separately. In practice, when >> Linux invalidates 2MB/1GB pages it performs a full TLB flush. The >> full flush may not

Re: [PATCH 2/4] scripts: add reqs python library

2016-06-15 Thread Luis R. Rodriguez
On Wed, Jun 15, 2016 at 09:11:45PM +0200, Michal Marek wrote: > Dne 15.6.2016 v 18:02 Luis R. Rodriguez napsal(a): > > On Wed, Jun 15, 2016 at 09:50:11AM +0200, Michal Marek wrote: > >> On 2016-06-15 00:10, Luis R. Rodriguez wrote: > >>> +weight = (int(rel_specs['VERSION'])<< 32) + \ >

Re: [patch 00/20] timer: Refactor the timer wheel

2016-06-15 Thread Paul E. McKenney
On Wed, Jun 15, 2016 at 07:02:38PM +0200, Thomas Gleixner wrote: > On Wed, 15 Jun 2016, Paul E. McKenney wrote: > > On Mon, Jun 13, 2016 at 09:15:14AM -0700, Paul E. McKenney wrote: > > > On Mon, Jun 13, 2016 at 08:40:50AM -, Thomas Gleixner wrote: > > > > The current timer wheel has some

Re: [PATCH] staging:vt6656:card.c:Fix comment block issue

2016-06-15 Thread Luis de Bethencourt
On 11/06/16 21:08, Rithvik Patibandla wrote: > Fix "Block comments use * on subsequent lines" and "Block comments use > */ on trailing lines" warnings thrown by checkpatch.pl > > Signed-off-by: Rithvik Patibandla > --- > drivers/staging/vt6656/card.c | 3 ++- > 1 file

Re: [PATCH] staging:vt6656:card.c:Fix comment block issue

2016-06-15 Thread Luis de Bethencourt
On 11/06/16 21:08, Rithvik Patibandla wrote: > Fix "Block comments use * on subsequent lines" and "Block comments use > */ on trailing lines" warnings thrown by checkpatch.pl > > Signed-off-by: Rithvik Patibandla > --- > drivers/staging/vt6656/card.c | 3 ++- > 1 file changed, 2 insertions(+),

Re: [patch 00/20] timer: Refactor the timer wheel

2016-06-15 Thread Paul E. McKenney
On Wed, Jun 15, 2016 at 07:02:38PM +0200, Thomas Gleixner wrote: > On Wed, 15 Jun 2016, Paul E. McKenney wrote: > > On Mon, Jun 13, 2016 at 09:15:14AM -0700, Paul E. McKenney wrote: > > > On Mon, Jun 13, 2016 at 08:40:50AM -, Thomas Gleixner wrote: > > > > The current timer wheel has some

Re: [PATCH] init, allow blacklisting of module_init functions

2016-06-15 Thread Rasmus Villemoes
On Wed, Jun 15 2016, Prarit Bhargava wrote: > At some point I was 100% sure this worked. I do remember testing it against > just a loadable module and had positive testing results. I think the current %ps/%pf behaviour was introduced in 4796dd200db9 (way back in 2012). >

[PATCH v2] ARM: mm: fix location of _etext

2016-06-15 Thread Kees Cook
The _etext position is defined to be the end of the kernel text code, and should not include any part of the data segments. This interferes with things that might check memory ranges and expect executable code up to _etext. Just to be conservative, leave the kernel resource as it was, using

[PATCH 1/3] drivers/media/dvb-core/en50221: use kref to manage struct dvb_ca_private

2016-06-15 Thread Max Kellermann
Don't free the object until the file handle has been closed. Fixes use-after-free bug which occurs when I disconnect my DVB-S received while VDR is running. Signed-off-by: Max Kellermann --- drivers/media/dvb-core/dvb_ca_en50221.c | 24 +++- 1 file

Re: stack validation warning on lttng-modules bytecode interpreter

2016-06-15 Thread Josh Poimboeuf
On Wed, Jun 15, 2016 at 08:01:09PM +, Mathieu Desnoyers wrote: > - On Jun 15, 2016, at 3:38 PM, Josh Poimboeuf jpoim...@redhat.com wrote: > > > On Wed, Jun 15, 2016 at 07:13:39PM +, Mathieu Desnoyers wrote: > >> - On Jun 15, 2016, at 2:18 PM, Josh Poimboeuf jpoim...@redhat.com >

Re: stack validation warning on lttng-modules bytecode interpreter

2016-06-15 Thread Josh Poimboeuf
On Wed, Jun 15, 2016 at 08:01:09PM +, Mathieu Desnoyers wrote: > - On Jun 15, 2016, at 3:38 PM, Josh Poimboeuf jpoim...@redhat.com wrote: > > > On Wed, Jun 15, 2016 at 07:13:39PM +, Mathieu Desnoyers wrote: > >> - On Jun 15, 2016, at 2:18 PM, Josh Poimboeuf jpoim...@redhat.com >

Re: [PATCH] init, allow blacklisting of module_init functions

2016-06-15 Thread Rasmus Villemoes
On Wed, Jun 15 2016, Prarit Bhargava wrote: > At some point I was 100% sure this worked. I do remember testing it against > just a loadable module and had positive testing results. I think the current %ps/%pf behaviour was introduced in 4796dd200db9 (way back in 2012). > In any case this is

[PATCH v2] ARM: mm: fix location of _etext

2016-06-15 Thread Kees Cook
The _etext position is defined to be the end of the kernel text code, and should not include any part of the data segments. This interferes with things that might check memory ranges and expect executable code up to _etext. Just to be conservative, leave the kernel resource as it was, using

[PATCH 1/3] drivers/media/dvb-core/en50221: use kref to manage struct dvb_ca_private

2016-06-15 Thread Max Kellermann
Don't free the object until the file handle has been closed. Fixes use-after-free bug which occurs when I disconnect my DVB-S received while VDR is running. Signed-off-by: Max Kellermann --- drivers/media/dvb-core/dvb_ca_en50221.c | 24 +++- 1 file changed, 23

Re: [PATCH 1/1] selinuxfs: fix type mismatch

2016-06-15 Thread Paul Moore
On Fri, Jun 10, 2016 at 5:14 PM, Heinrich Schuchardt wrote: > avc_cache_threshold is of type unsigned int. > > Do not use a signed new_value in > sscanf(page, "%u", _value). > > Signed-off-by: Heinrich Schuchardt > --- > security/selinux/selinuxfs.c | 2

Re: [PATCH 1/1] selinuxfs: fix type mismatch

2016-06-15 Thread Paul Moore
On Fri, Jun 10, 2016 at 5:14 PM, Heinrich Schuchardt wrote: > avc_cache_threshold is of type unsigned int. > > Do not use a signed new_value in > sscanf(page, "%u", _value). > > Signed-off-by: Heinrich Schuchardt > --- > security/selinux/selinuxfs.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [PATCH] ses: Fix racy cleanup of /sys in remove_dev()

2016-06-15 Thread Calvin Owens
On Thursday 06/02 at 15:50 -0700, Calvin Owens wrote: > On 05/13/2016 01:28 PM, Calvin Owens wrote: > > Currently we free the resources backing the enclosure device before we > > call device_unregister(). This is racy: during rmmod of low-level SCSI > > drivers that hook into enclosure, we end up

Re: [PATCH] ses: Fix racy cleanup of /sys in remove_dev()

2016-06-15 Thread Calvin Owens
On Thursday 06/02 at 15:50 -0700, Calvin Owens wrote: > On 05/13/2016 01:28 PM, Calvin Owens wrote: > > Currently we free the resources backing the enclosure device before we > > call device_unregister(). This is racy: during rmmod of low-level SCSI > > drivers that hook into enclosure, we end up

[PATCH 3/3] drivers/media/media-device: fix double free bug in _unregister()

2016-06-15 Thread Max Kellermann
While removing all interfaces in media_device_unregister(), all media_interface pointers are freed. This is illegal and results in double kfree() if any media_interface is still linked at this point; maybe because a userspace process still has a file handle. Once the process closes the file

[PATCH 2/3] drivers/media/media-entity: clear media_gobj.mdev in _destroy()

2016-06-15 Thread Max Kellermann
media_gobj_destroy() may be called twice on one instance - once by media_device_unregister() and again by dvb_media_device_free(). The function media_remove_intf_links() establishes and documents the convention that mdev==NULL means that the object is not registered, but nobody ever NULLs this

[PATCH 3/3] drivers/media/media-device: fix double free bug in _unregister()

2016-06-15 Thread Max Kellermann
While removing all interfaces in media_device_unregister(), all media_interface pointers are freed. This is illegal and results in double kfree() if any media_interface is still linked at this point; maybe because a userspace process still has a file handle. Once the process closes the file

[PATCH 2/3] drivers/media/media-entity: clear media_gobj.mdev in _destroy()

2016-06-15 Thread Max Kellermann
media_gobj_destroy() may be called twice on one instance - once by media_device_unregister() and again by dvb_media_device_free(). The function media_remove_intf_links() establishes and documents the convention that mdev==NULL means that the object is not registered, but nobody ever NULLs this

<    1   2   3   4   5   6   7   8   9   10   >