[GIT pull] x86 fix for 4.8

2016-09-04 Thread Thomas Gleixner
Linus, please pull the latest x86-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86-urgent-for-linus A single fix for an AMD erratum so machines without a BIOS fix work. Thanks, tglx --> Emanuel Czirai (1):

[GIT pull] x86 fix for 4.8

2016-09-04 Thread Thomas Gleixner
Linus, please pull the latest x86-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86-urgent-for-linus A single fix for an AMD erratum so machines without a BIOS fix work. Thanks, tglx --> Emanuel Czirai (1):

[PATCH] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.

2016-09-04 Thread Amit Ghadge
This is a patch to the ni_daq_dio24.c that fixes checkpatch warning: WARNING: Block comments use * on subsequent lines Signed-off-by: Amit Ghadge --- drivers/staging/comedi/drivers/ni_daq_dio24.c | 52 +-- 1 file changed, 26 insertions(+), 26

[PATCH] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.

2016-09-04 Thread Amit Ghadge
This is a patch to the ni_daq_dio24.c that fixes checkpatch warning: WARNING: Block comments use * on subsequent lines Signed-off-by: Amit Ghadge --- drivers/staging/comedi/drivers/ni_daq_dio24.c | 52 +-- 1 file changed, 26 insertions(+), 26 deletions(-) diff --git

Re: [PATCH 1/2] IB/hfi1: Fix a parameter of find_first_bit.

2016-09-04 Thread Leon Romanovsky
On Fri, Sep 02, 2016 at 10:39:11AM -0400, Doug Ledford wrote: > On 8/28/2016 2:06 AM, Leon Romanovsky wrote: > > On Fri, Aug 26, 2016 at 03:34:48PM -0400, Doug Ledford wrote: > >> On 8/26/2016 3:29 PM, Leon Romanovsky wrote: > >>> On Fri, Aug 26, 2016 at 02:01:55PM -0400, Doug Ledford wrote: >

Re: [PATCH 1/2] IB/hfi1: Fix a parameter of find_first_bit.

2016-09-04 Thread Leon Romanovsky
On Fri, Sep 02, 2016 at 10:39:11AM -0400, Doug Ledford wrote: > On 8/28/2016 2:06 AM, Leon Romanovsky wrote: > > On Fri, Aug 26, 2016 at 03:34:48PM -0400, Doug Ledford wrote: > >> On 8/26/2016 3:29 PM, Leon Romanovsky wrote: > >>> On Fri, Aug 26, 2016 at 02:01:55PM -0400, Doug Ledford wrote: >

RE: [PATCH] Fix chance of sign extension to nsec after its msb is set during calculation.

2016-09-04 Thread Thomas Gleixner
On Sun, 4 Sep 2016, Liav Rehana wrote: Please do not top post and trim your reply. > The root of the problem is that in case the multiplication of delta and > tkr->mult in the line that I've changed is too big that the MSB of the > result is set, then the shift will cause an unwanted sign

RE: [PATCH] Fix chance of sign extension to nsec after its msb is set during calculation.

2016-09-04 Thread Thomas Gleixner
On Sun, 4 Sep 2016, Liav Rehana wrote: Please do not top post and trim your reply. > The root of the problem is that in case the multiplication of delta and > tkr->mult in the line that I've changed is too big that the MSB of the > result is set, then the shift will cause an unwanted sign

[PATCH] perf/x86: Use kmalloc_array() in merge_attr()

2016-09-04 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 4 Sep 2016 10:45:20 +0200 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kmalloc_array". This issue was

[PATCH] perf/x86: Use kmalloc_array() in merge_attr()

2016-09-04 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 4 Sep 2016 10:45:20 +0200 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kmalloc_array". This issue was detected by using the Coccinelle

Re: [PATCH] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.

2016-09-04 Thread Amit Ghadge
On Sun, Sep 4, 2016 at 2:30 PM, Amit Ghadge wrote: > This is a patch to the ni_daq_dio24.c that fixes checkpatch warning: > > WARNING: Block comments use * on subsequent lines > > Signed-off-by: Amit Ghadge > --- > drivers/staging/comedi/comedidev.h

Re: [PATCH] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.

2016-09-04 Thread Amit Ghadge
On Sun, Sep 4, 2016 at 2:30 PM, Amit Ghadge wrote: > This is a patch to the ni_daq_dio24.c that fixes checkpatch warning: > > WARNING: Block comments use * on subsequent lines > > Signed-off-by: Amit Ghadge > --- > drivers/staging/comedi/comedidev.h| 8 ++--- >

[PATCH] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.

2016-09-04 Thread Amit Ghadge
This is a patch to the ni_daq_dio24.c that fixes checkpatch warning: WARNING: Block comments use * on subsequent lines Signed-off-by: Amit Ghadge --- drivers/staging/comedi/comedidev.h| 8 ++--- drivers/staging/comedi/drivers/ni_daq_dio24.c | 52

[PATCH] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.

2016-09-04 Thread Amit Ghadge
This is a patch to the ni_daq_dio24.c that fixes checkpatch warning: WARNING: Block comments use * on subsequent lines Signed-off-by: Amit Ghadge --- drivers/staging/comedi/comedidev.h| 8 ++--- drivers/staging/comedi/drivers/ni_daq_dio24.c | 52 +-- 2

Re: [PATCH] vhost: Add polling mode

2016-09-04 Thread Razya Ladelsky
"Michael S. Tsirkin" wrote on 10/08/2014 10:45:59 PM: > From: "Michael S. Tsirkin" > To: Razya Ladelsky/Haifa/IBM@IBMIL, > Cc: k...@vger.kernel.org, Alex Glikson/Haifa/IBM@IBMIL, Eran > Raichstein/Haifa/IBM@IBMIL, Yossi Kuperman1/Haifa/IBM@IBMIL, Joel >

Re: [PATCH] vhost: Add polling mode

2016-09-04 Thread Razya Ladelsky
"Michael S. Tsirkin" wrote on 10/08/2014 10:45:59 PM: > From: "Michael S. Tsirkin" > To: Razya Ladelsky/Haifa/IBM@IBMIL, > Cc: k...@vger.kernel.org, Alex Glikson/Haifa/IBM@IBMIL, Eran > Raichstein/Haifa/IBM@IBMIL, Yossi Kuperman1/Haifa/IBM@IBMIL, Joel > Nider/Haifa/IBM@IBMIL,

[PATCH 4/4] ARM: dts: use definition in rockchip pinctrl header to describe gpios on Popmetal-RK3288

2016-09-04 Thread Andy Yan
Use definition in rockchip pinctrl header to describe gpios, this will make it more clearer. Signed-off-by: Andy Yan --- arch/arm/boot/dts/rk3288-popmetal.dts | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git

[PATCH 4/4] ARM: dts: use definition in rockchip pinctrl header to describe gpios on Popmetal-RK3288

2016-09-04 Thread Andy Yan
Use definition in rockchip pinctrl header to describe gpios, this will make it more clearer. Signed-off-by: Andy Yan --- arch/arm/boot/dts/rk3288-popmetal.dts | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/arch/arm/boot/dts/rk3288-popmetal.dts

[PATCH 3/4] include: dt-bindings: Add more GPIO bank and index definition for rockchip pinctrl

2016-09-04 Thread Andy Yan
There are 8 gpio banks on RK3288, so add the missing RK_GPIO7 and RK_GPIO8. Also add gpio index definition to make it easier to description GPIO in dts. Signed-off-by: Andy Yan --- include/dt-bindings/pinctrl/rockchip.h | 35 ++ 1 file

[PATCH 3/4] include: dt-bindings: Add more GPIO bank and index definition for rockchip pinctrl

2016-09-04 Thread Andy Yan
There are 8 gpio banks on RK3288, so add the missing RK_GPIO7 and RK_GPIO8. Also add gpio index definition to make it easier to description GPIO in dts. Signed-off-by: Andy Yan --- include/dt-bindings/pinctrl/rockchip.h | 35 ++ 1 file changed, 35 insertions(+)

[PATCH 2/4] ARM: dts: rockchip: fix i2c address L3G4200D on PopMetal-RK3288 board

2016-09-04 Thread Andy Yan
The i2c address of the three-axis digital gyroscope L3G4200D should be 0x69 according to hardware design. Also add power supply reference for L3G3200D and the 3-axis Electronic Compass AK8963. Signed-off-by: Andy Yan --- arch/arm/boot/dts/rk3288-popmetal.dts | 8

[PATCH 2/4] ARM: dts: rockchip: fix i2c address L3G4200D on PopMetal-RK3288 board

2016-09-04 Thread Andy Yan
The i2c address of the three-axis digital gyroscope L3G4200D should be 0x69 according to hardware design. Also add power supply reference for L3G3200D and the 3-axis Electronic Compass AK8963. Signed-off-by: Andy Yan --- arch/arm/boot/dts/rk3288-popmetal.dts | 8 ++-- 1 file changed, 6

Re: [PATCH 2/2] Staging: comedi: ni_670x.c: Fix warnings and check.

2016-09-04 Thread Greg KH
On Sun, Sep 04, 2016 at 01:41:03AM +0530, Amit Ghadge wrote: > Fixes checkpatch warning: > WARNING: Block comments use * on subsequent lines > > Replace (1<<7) by BIT(7) in the file ni_670x.c to get rid > of checkpatch.pl "CHECK" output "Prefer using the BIT macro". > Replace Avoid CamelCase

Re: [PATCH 2/2] Staging: comedi: ni_670x.c: Fix warnings and check.

2016-09-04 Thread Greg KH
On Sun, Sep 04, 2016 at 01:41:03AM +0530, Amit Ghadge wrote: > Fixes checkpatch warning: > WARNING: Block comments use * on subsequent lines > > Replace (1<<7) by BIT(7) in the file ni_670x.c to get rid > of checkpatch.pl "CHECK" output "Prefer using the BIT macro". > Replace Avoid CamelCase

[PATCH 1/4] ARM: dts: rockchip: enable usbotg for Popemtal-rk3288 board

2016-09-04 Thread Andy Yan
Enable USB OTG port on RK3288 Popmetal board, So we can run some usb gadget functions like Android adb on this board. Signed-off-by: Andy Yan --- arch/arm/boot/dts/rk3288-popmetal.dts | 4 1 file changed, 4 insertions(+) diff --git

[PATCH 1/4] ARM: dts: rockchip: enable usbotg for Popemtal-rk3288 board

2016-09-04 Thread Andy Yan
Enable USB OTG port on RK3288 Popmetal board, So we can run some usb gadget functions like Android adb on this board. Signed-off-by: Andy Yan --- arch/arm/boot/dts/rk3288-popmetal.dts | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/rk3288-popmetal.dts

RE: [PATCH] qed: Remove OOM messages

2016-09-04 Thread Yuval Mintz
> These messages are unnecessary as OOM allocation failures already do a > dump_stack() giving more or less the same information. > > $ size drivers/net/ethernet/qlogic/qed/built-in.o* (defconfig x86-64) >text data bss dec hex filename > 126849 27968 32800

RE: [PATCH] qed: Remove OOM messages

2016-09-04 Thread Yuval Mintz
> These messages are unnecessary as OOM allocation failures already do a > dump_stack() giving more or less the same information. > > $ size drivers/net/ethernet/qlogic/qed/built-in.o* (defconfig x86-64) >text data bss dec hex filename > 126849 27968 32800

[PATCH 0/4] One fix and some improvements for RK3288 Popmetal board

2016-09-04 Thread Andy Yan
This series fix one sensor i2c device address on Popmetal board, and change some pinctrl description to make it more clearly, also enable the usb otg function on this board. Andy Yan (4): ARM: dts: rockchip: enable usbotg for Popemtal-rk3288 board ARM: dts: rockchip: fix i2c address

[PATCH 0/4] One fix and some improvements for RK3288 Popmetal board

2016-09-04 Thread Andy Yan
This series fix one sensor i2c device address on Popmetal board, and change some pinctrl description to make it more clearly, also enable the usb otg function on this board. Andy Yan (4): ARM: dts: rockchip: enable usbotg for Popemtal-rk3288 board ARM: dts: rockchip: fix i2c address

[PATCH] [SCSI] bfa: mark symbols static where possible

2016-09-04 Thread Baoyou Xie
We get a few warnings when building kernel with W=1: drivers/scsi/bfa/bfad.c:1502:1: warning: no previous prototype for 'restart_bfa' [-Wmissing-prototypes] drivers/scsi/bfa/bfad_attr.c:447:1: warning: no previous prototype for 'bfad_im_issue_fc_host_lip' [-Wmissing-prototypes]

[PATCH] [SCSI] bfa: mark symbols static where possible

2016-09-04 Thread Baoyou Xie
We get a few warnings when building kernel with W=1: drivers/scsi/bfa/bfad.c:1502:1: warning: no previous prototype for 'restart_bfa' [-Wmissing-prototypes] drivers/scsi/bfa/bfad_attr.c:447:1: warning: no previous prototype for 'bfad_im_issue_fc_host_lip' [-Wmissing-prototypes]

arch/mips/vdso/gettimeofday.c:1:0: error: '-march=r3000' requires '-mfp32'

2016-09-04 Thread kbuild test robot
Hi Guenter, First bad commit (maybe != root cause): tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 28e68154c5e2793123b248d38cf17b34dcb16d87 commit: 398c7500a1f5f74e207bd2edca1b1721b3cc1f1e MIPS: VDSO: Fix build error with binutils 2.24 and earlier

arch/mips/vdso/gettimeofday.c:1:0: error: '-march=r3000' requires '-mfp32'

2016-09-04 Thread kbuild test robot
Hi Guenter, First bad commit (maybe != root cause): tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 28e68154c5e2793123b248d38cf17b34dcb16d87 commit: 398c7500a1f5f74e207bd2edca1b1721b3cc1f1e MIPS: VDSO: Fix build error with binutils 2.24 and earlier

Re: sparc: bpf_jit: Rename jump labels in bpf_jit_compile()

2016-09-04 Thread SF Markus Elfring
> It's not because I find improvements "uncomfortable", but rather it's > because your changes are not seen as improvements in the first place. What is your software development opinion for the update step "[1/4] sparc: bpf_jit: Use kmalloc_array() in bpf_jit_compile()" from this small patch

Re: sparc: bpf_jit: Rename jump labels in bpf_jit_compile()

2016-09-04 Thread SF Markus Elfring
> It's not because I find improvements "uncomfortable", but rather it's > because your changes are not seen as improvements in the first place. What is your software development opinion for the update step "[1/4] sparc: bpf_jit: Use kmalloc_array() in bpf_jit_compile()" from this small patch

arch/mips/vdso/elf.S:1:0: error: '-march=r3000' requires '-mfp32'

2016-09-04 Thread kbuild test robot
Hi Alex, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 28e68154c5e2793123b248d38cf17b34dcb16d87 commit: ebb5e78cc63417a35254a791de66e1cc84f963cc MIPS: Initial implementation of a VDSO date: 10 months ago

arch/mips/vdso/elf.S:1:0: error: '-march=r3000' requires '-mfp32'

2016-09-04 Thread kbuild test robot
Hi Alex, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 28e68154c5e2793123b248d38cf17b34dcb16d87 commit: ebb5e78cc63417a35254a791de66e1cc84f963cc MIPS: Initial implementation of a VDSO date: 10 months ago

Re: sparc: bpf_jit: Rename jump labels in bpf_jit_compile()

2016-09-04 Thread SF Markus Elfring
>> https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/Documentation/CodingStyle?id=865a1caa4b6b886babdd9d67e7c3608be4567a51 > > You seem to lack understanding of the difference between absolute > requirements and "advice". > > As Sparc maintainer I can choose to not take

Re: sparc: bpf_jit: Rename jump labels in bpf_jit_compile()

2016-09-04 Thread SF Markus Elfring
>> https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/Documentation/CodingStyle?id=865a1caa4b6b886babdd9d67e7c3608be4567a51 > > You seem to lack understanding of the difference between absolute > requirements and "advice". > > As Sparc maintainer I can choose to not take

Re: sparc: bpf_jit: Rename jump labels in bpf_jit_compile()

2016-09-04 Thread David Miller
From: SF Markus Elfring Date: Sun, 4 Sep 2016 09:20:55 +0200 > I guess that I will stumble on more software improvement opportunities > you find harder to become comfortable with. Improvement is a matter of opinion. So your statement assumes that your changes are

Re: sparc: bpf_jit: Rename jump labels in bpf_jit_compile()

2016-09-04 Thread David Miller
From: SF Markus Elfring Date: Sun, 4 Sep 2016 09:20:55 +0200 > I guess that I will stumble on more software improvement opportunities > you find harder to become comfortable with. Improvement is a matter of opinion. So your statement assumes that your changes are an improvement, and everyone

drivers/gpio/gpio-mcp23s08.c:568:11: error: 'struct gpio_chip' has no member named 'of_gpio_n_cells'

2016-09-04 Thread kbuild test robot
Hi Linus, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 28e68154c5e2793123b248d38cf17b34dcb16d87 commit: 2527ecc9195e9c66252af24c4689e8a67cd4ccb9 gpio: Fix OF build problem on UM date: 2 weeks ago config:

drivers/gpio/gpio-mcp23s08.c:568:11: error: 'struct gpio_chip' has no member named 'of_gpio_n_cells'

2016-09-04 Thread kbuild test robot
Hi Linus, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 28e68154c5e2793123b248d38cf17b34dcb16d87 commit: 2527ecc9195e9c66252af24c4689e8a67cd4ccb9 gpio: Fix OF build problem on UM date: 2 weeks ago config:

Re: sparc: bpf_jit: Move four assignments in bpf_jit_compile()

2016-09-04 Thread Julian Calaby
Hi Markus, On Sun, Sep 4, 2016 at 5:07 PM, SF Markus Elfring wrote: >> I really wish he'd concentrate on the former rather than the latter. > > I am on the way for such a software development adventure. > There are further improvement opportunities to consider

Re: sparc: bpf_jit: Move four assignments in bpf_jit_compile()

2016-09-04 Thread Julian Calaby
Hi Markus, On Sun, Sep 4, 2016 at 5:07 PM, SF Markus Elfring wrote: >> I really wish he'd concentrate on the former rather than the latter. > > I am on the way for such a software development adventure. > There are further improvement opportunities to consider besides the main > route, > aren't

RE: [PATCH] Fix chance of sign extension to nsec after its msb is set during calculation.

2016-09-04 Thread Liav Rehana
Hi Thomas, The root of the problem is that in case the multiplication of delta and tkr->mult in the line that I've changed is too big that the MSB of the result is set, then the shift will cause an unwanted sign extension. That sign extension will be avoided completely if the variable nsec was

RE: [PATCH] Fix chance of sign extension to nsec after its msb is set during calculation.

2016-09-04 Thread Liav Rehana
Hi Thomas, The root of the problem is that in case the multiplication of delta and tkr->mult in the line that I've changed is too big that the MSB of the result is set, then the shift will cause an unwanted sign extension. That sign extension will be avoided completely if the variable nsec was

Re: sparc: bpf_jit: Move four assignments in bpf_jit_compile()

2016-09-04 Thread SF Markus Elfring
> In Markus' defence, he does occasionally write okay patches, > (for example the kmalloc(a * b) => kmalloc_array(a, b) changes > get my small tick of approval) Thanks for another bit of acceptance for this kind of software change. > however he also submits a lot of patches which are little

Re: sparc: bpf_jit: Move four assignments in bpf_jit_compile()

2016-09-04 Thread SF Markus Elfring
> In Markus' defence, he does occasionally write okay patches, > (for example the kmalloc(a * b) => kmalloc_array(a, b) changes > get my small tick of approval) Thanks for another bit of acceptance for this kind of software change. > however he also submits a lot of patches which are little

[PATCH] lpfc: mark symbols static where possible

2016-09-04 Thread Baoyou Xie
We get a few warnings when building kernel with W=1: drivers/scsi/lpfc/lpfc_sli.c:5693:1: warning: no previous prototype for 'lpfc_set_features' [-Wmissing-prototypes] drivers/scsi/lpfc/lpfc_sli.c:8972:1: warning: no previous prototype for 'lpfc_sli_calc_ring' [-Wmissing-prototypes]

[PATCH] lpfc: mark symbols static where possible

2016-09-04 Thread Baoyou Xie
We get a few warnings when building kernel with W=1: drivers/scsi/lpfc/lpfc_sli.c:5693:1: warning: no previous prototype for 'lpfc_set_features' [-Wmissing-prototypes] drivers/scsi/lpfc/lpfc_sli.c:8972:1: warning: no previous prototype for 'lpfc_sli_calc_ring' [-Wmissing-prototypes]

[PATCH] [SCSI] bnx2fc: mark symbols static where possible

2016-09-04 Thread Baoyou Xie
We get a few warnings when building kernel with W=1: drivers/scsi/bnx2fc/bnx2fc_els.c:257:6: warning: no previous prototype for 'bnx2fc_srr_compl' [-Wmissing-prototypes] drivers/scsi/bnx2fc/bnx2fc_els.c:367:6: warning: no previous prototype for 'bnx2fc_rec_compl' [-Wmissing-prototypes]

[PATCH] [SCSI] bnx2fc: mark symbols static where possible

2016-09-04 Thread Baoyou Xie
We get a few warnings when building kernel with W=1: drivers/scsi/bnx2fc/bnx2fc_els.c:257:6: warning: no previous prototype for 'bnx2fc_srr_compl' [-Wmissing-prototypes] drivers/scsi/bnx2fc/bnx2fc_els.c:367:6: warning: no previous prototype for 'bnx2fc_rec_compl' [-Wmissing-prototypes]

Re: sparc: bpf_jit: Rename jump labels in bpf_jit_compile()

2016-09-04 Thread David Miller
From: SF Markus Elfring Date: Sun, 4 Sep 2016 08:50:20 +0200 >>> NAK, just noise. >> >> And frankly I hate that leading space. > > Would you like to comment the recent update of the document "CodingStyle" any > more? >

Re: sparc: bpf_jit: Rename jump labels in bpf_jit_compile()

2016-09-04 Thread David Miller
From: SF Markus Elfring Date: Sun, 4 Sep 2016 08:50:20 +0200 >>> NAK, just noise. >> >> And frankly I hate that leading space. > > Would you like to comment the recent update of the document "CodingStyle" any > more? >

Re: sparc: bpf_jit: Rename jump labels in bpf_jit_compile()

2016-09-04 Thread SF Markus Elfring
>> NAK, just noise. > > And frankly I hate that leading space. Would you like to comment the recent update of the document "CodingStyle" any more? https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/Documentation/CodingStyle?id=865a1caa4b6b886babdd9d67e7c3608be4567a51

Re: sparc: bpf_jit: Rename jump labels in bpf_jit_compile()

2016-09-04 Thread SF Markus Elfring
>> NAK, just noise. > > And frankly I hate that leading space. Would you like to comment the recent update of the document "CodingStyle" any more? https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/Documentation/CodingStyle?id=865a1caa4b6b886babdd9d67e7c3608be4567a51

Re: sparc: bpf_jit: Move four assignments in bpf_jit_compile()

2016-09-04 Thread SF Markus Elfring
>> Which test environments would you find acceptable for further clarification? > > Compiling it on GCC for Sparc, obviously. Are there any more configuration details to consider? >>> I must also point out that these sorts of optimisations are things the >>> compiler does automatically when

Re: sparc: bpf_jit: Move four assignments in bpf_jit_compile()

2016-09-04 Thread SF Markus Elfring
>> Which test environments would you find acceptable for further clarification? > > Compiling it on GCC for Sparc, obviously. Are there any more configuration details to consider? >>> I must also point out that these sorts of optimisations are things the >>> compiler does automatically when

[PATCH] [SCSI] aacraid: mark aac_src_select_comm() static

2016-09-04 Thread Baoyou Xie
We get 1 warning when building kernel with W=1: drivers/scsi/aacraid/src.c:616:5: warning: no previous prototype for 'aac_src_select_comm' [-Wmissing-prototypes] In fact, this function is only used in the file in which it is declared and don't need a declaration, but can be made static. so this

[PATCH] [SCSI] aacraid: mark aac_src_select_comm() static

2016-09-04 Thread Baoyou Xie
We get 1 warning when building kernel with W=1: drivers/scsi/aacraid/src.c:616:5: warning: no previous prototype for 'aac_src_select_comm' [-Wmissing-prototypes] In fact, this function is only used in the file in which it is declared and don't need a declaration, but can be made static. so this

[PATCH] drm/imx: Fix of_node ref counting

2016-09-04 Thread Christophe JAILLET
This code is spurious. It takes a ref on a node, then call 'of_node_put' on it and then store this node somewhere. It is likely that taking the ref on the parent node and releasing the child node was expected instead. So, use 'of_get_next_parent' instead. It does all this in just one function

[PATCH] drm/imx: Fix of_node ref counting

2016-09-04 Thread Christophe JAILLET
This code is spurious. It takes a ref on a node, then call 'of_node_put' on it and then store this node somewhere. It is likely that taking the ref on the parent node and releasing the child node was expected instead. So, use 'of_get_next_parent' instead. It does all this in just one function

Re: sparc: bpf_jit: Move four assignments in bpf_jit_compile()

2016-09-04 Thread Julian Calaby
Hi David, On Sun, Sep 4, 2016 at 4:32 PM, David Miller wrote: > > Markus, I'm really not going to consider any of these changes. > > And your replies to the feedback you were given disappoint me even > more. > > Please don't submit any more sparc patches until you can get

Re: sparc: bpf_jit: Move four assignments in bpf_jit_compile()

2016-09-04 Thread Julian Calaby
Hi David, On Sun, Sep 4, 2016 at 4:32 PM, David Miller wrote: > > Markus, I'm really not going to consider any of these changes. > > And your replies to the feedback you were given disappoint me even > more. > > Please don't submit any more sparc patches until you can get you act > in gear and

Re: sparc: bpf_jit: Move four assignments in bpf_jit_compile()

2016-09-04 Thread David Miller
Markus, I'm really not going to consider any of these changes. And your replies to the feedback you were given disappoint me even more. Please don't submit any more sparc patches until you can get you act in gear and not waste everyone's time. Thank you.

Re: sparc: bpf_jit: Move four assignments in bpf_jit_compile()

2016-09-04 Thread David Miller
Markus, I'm really not going to consider any of these changes. And your replies to the feedback you were given disappoint me even more. Please don't submit any more sparc patches until you can get you act in gear and not waste everyone's time. Thank you.

[PATCH] staging: media: omap4iss: mark omap4iss_flush() static

2016-09-04 Thread Baoyou Xie
We get 1 warning when building kernel with W=1: drivers/staging/media/omap4iss/iss.c:64:6: warning: no previous prototype for 'omap4iss_flush' [-Wmissing-prototypes] In fact, this function is only used in the file in which it is declared and don't need a declaration, but can be made static. so

[PATCH] staging: media: omap4iss: mark omap4iss_flush() static

2016-09-04 Thread Baoyou Xie
We get 1 warning when building kernel with W=1: drivers/staging/media/omap4iss/iss.c:64:6: warning: no previous prototype for 'omap4iss_flush' [-Wmissing-prototypes] In fact, this function is only used in the file in which it is declared and don't need a declaration, but can be made static. so

[PATCH] staging: ks7010: mark symbols static where possible

2016-09-04 Thread Baoyou Xie
We get 2 warnings when building kernel with W=1: drivers/staging/ks7010/ks_hostif.c:72:6: warning: no previous prototype for 'ks_wlan_hw_wakeup_task' [-Wmissing-prototypes] drivers/staging/ks7010/ks_hostif.c:1508:6: warning: no previous prototype for 'hostif_infrastructure_set2_request'

[PATCH] staging: ks7010: mark symbols static where possible

2016-09-04 Thread Baoyou Xie
We get 2 warnings when building kernel with W=1: drivers/staging/ks7010/ks_hostif.c:72:6: warning: no previous prototype for 'ks_wlan_hw_wakeup_task' [-Wmissing-prototypes] drivers/staging/ks7010/ks_hostif.c:1508:6: warning: no previous prototype for 'hostif_infrastructure_set2_request'

Re: sparc: bpf_jit: Move four assignments in bpf_jit_compile()

2016-09-04 Thread David Miller
From: SF Markus Elfring Date: Sun, 4 Sep 2016 07:45:04 +0200 >> and wasting everyone's time in the process. > > I assume that a few contributors can take the presented ideas for further > considerations. > Will their value evolve a bit more later? No, really,

[PATCH] Staging: rtl8192e: mark symbols static where possible

2016-09-04 Thread Baoyou Xie
We get a few warnings when building kernel with W=1: drivers/staging/rtl8192e/rtllib_softmac.c:279:13: warning: no previous declaration for 'softmac_ps_mgmt_xmit' [-Wmissing-declarations] drivers/staging/rtl8192e/rtllib_softmac.c:773:24: warning: no previous declaration for

Re: sparc: bpf_jit: Move four assignments in bpf_jit_compile()

2016-09-04 Thread David Miller
From: SF Markus Elfring Date: Sun, 4 Sep 2016 07:45:04 +0200 >> and wasting everyone's time in the process. > > I assume that a few contributors can take the presented ideas for further > considerations. > Will their value evolve a bit more later? No, really, you are wasting everyone's time.

[PATCH] Staging: rtl8192e: mark symbols static where possible

2016-09-04 Thread Baoyou Xie
We get a few warnings when building kernel with W=1: drivers/staging/rtl8192e/rtllib_softmac.c:279:13: warning: no previous declaration for 'softmac_ps_mgmt_xmit' [-Wmissing-declarations] drivers/staging/rtl8192e/rtllib_softmac.c:773:24: warning: no previous declaration for

Re: [PATCH 4/4] sparc: bpf_jit: Rename jump labels in bpf_jit_compile()

2016-09-04 Thread David Miller
From: Daniel Borkmann Date: Sat, 03 Sep 2016 18:52:44 +0200 > On 09/03/2016 06:41 PM, SF Markus Elfring wrote: >> From: Markus Elfring >> Date: Sat, 3 Sep 2016 18:14:19 +0200 >> >> Adjust jump labels according to the current Linux coding

Re: [PATCH 4/4] sparc: bpf_jit: Rename jump labels in bpf_jit_compile()

2016-09-04 Thread David Miller
From: Daniel Borkmann Date: Sat, 03 Sep 2016 18:52:44 +0200 > On 09/03/2016 06:41 PM, SF Markus Elfring wrote: >> From: Markus Elfring >> Date: Sat, 3 Sep 2016 18:14:19 +0200 >> >> Adjust jump labels according to the current Linux coding style >> convention. >> >> Signed-off-by: Markus Elfring

Re: sparc: bpf_jit: Move four assignments in bpf_jit_compile()

2016-09-04 Thread Julian Calaby
Hi Markus, On Sun, Sep 4, 2016 at 3:45 PM, SF Markus Elfring wrote: >>> I hope so. - I propose to give the refactorings "Reduce scope of variable" >>> and "Extract a function" (and the corresponding consequences) another look. >> >> So you _think_ it does. Come

Re: sparc: bpf_jit: Move four assignments in bpf_jit_compile()

2016-09-04 Thread Julian Calaby
Hi Markus, On Sun, Sep 4, 2016 at 3:45 PM, SF Markus Elfring wrote: >>> I hope so. - I propose to give the refactorings "Reduce scope of variable" >>> and "Extract a function" (and the corresponding consequences) another look. >> >> So you _think_ it does. Come back with real proof. > > Which

<    1   2   3   4   5   6