Linus,
Please pull the siginfo-linus branch from the git tree:
git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace.git
siginfo-linus
HEAD: 9026e820cbd2ea39a06a129ecdddf2739bd3602b fs/signalfd: fix build error
for BUS_MCEERR_AR
This change fixes a build error that shou
tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/urgent
head: f60606c4ce402963dc552c62910ffa7080b4a628
commit: f60606c4ce402963dc552c62910ffa7080b4a628 [3/3] x86/apic/vector: Handle
vector release on CPU unplug correctly
config: x86_64-randconfig-x017-201807 (attached as .
Then you are good to go.
York
Sent from my iPhone
> On Feb 22, 2018, at 22:40, Rasmus Villemoes
> wrote:
>
>> On 2018-02-20 22:01, York Sun wrote:
>> Sorry for top posting. I am on vacation and replying from my phone.
>>
>> The controller is compatible and the driver should work. Please doub
Chrome platform installed a Chrome EC notify handler which prevents
default EC GPE handler getting called. Add pm_system_wakeup to the
Chrome EC notify handler so wake up from s2idle can happen.
Suggested-by: Rafael J. Wysocki
Signed-off-by: Wenkai Du
---
drivers/platform/chrome/cros_ec_lpc.c |
On Thu, Feb 22, 2018 at 1:07 PM, Rasmus Villemoes
wrote:
> On 2018-02-22 19:04, Linus Torvalds wrote:
>>
>> Lookie here (in a fully built tree):
>>
>> find . -name '*.o.cmd' |
>> xargs grep -L linux/compiler_types.h |
>> xargs grep -l linux/kconfig.h |
>> while read i;
On Thu, Feb 22, 2018 at 1:07 PM, Rasmus Villemoes
wrote:
>
> It does, both per the documentation and testing it. But fixdep
> explicitly removes include/linux/kconfig.h along with
> include/generated/autoconf.h and a few others. So when you rebuilt after
> adding the #include to kconfig.h, I think
From: Markus Elfring
Date: Thu, 22 Feb 2018 21:45:47 +0100
Some local variables will be set to an appropriate value before usage.
Thus omit explicit initialisations at the beginning of these functions.
Signed-off-by: Markus Elfring
---
v2:
Hans Verkuil insisted on patch squashing. Thus some ch
On Thu, 22 Feb 2018 17:11:28 +0800 Baoquan He wrote:
> It's used to record how many memory sections are marked as present
> during system boot up, and will be used in the later patch.
>
> --- a/mm/sparse.c
> +++ b/mm/sparse.c
> @@ -202,6 +202,7 @@ static inline int next_present_section_nr(int se
Dave Hansen wrote:
>
> From: Dave Hansen
>
> In creating its page tables, the espfix code masks its PGTABLE_PROT
> value with the supported mask: __supported_pte_mask. This ensures
> that unsupported bits are not set in the final PTE. But, it also
> sets _PAGE_GLOBAL which we do not want for
tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/urgent
head: f60606c4ce402963dc552c62910ffa7080b4a628
commit: f60606c4ce402963dc552c62910ffa7080b4a628 [3/3] x86/apic/vector: Handle
vector release on CPU unplug correctly
config: i386-randconfig-x079-201807 (attached as .co
On 02/22/2018 01:27 PM, Nadav Amit wrote:
> Dave Hansen wrote:
>> From: Dave Hansen
>> In creating its page tables, the espfix code masks its PGTABLE_PROT
>> value with the supported mask: __supported_pte_mask. This ensures
>> that unsupported bits are not set in the final PTE. But, it also
>>
Commit-ID: c16721c5cece64bfe12cdc302a0228026d8089d7
Gitweb: https://git.kernel.org/tip/c16721c5cece64bfe12cdc302a0228026d8089d7
Author: Thomas Gleixner
AuthorDate: Thu, 22 Feb 2018 12:08:06 +0100
Committer: Thomas Gleixner
CommitDate: Thu, 22 Feb 2018 22:25:50 +0100
x86/apic/vector: Ha
This reverts commit e04653a9dcf4d98defe2149c885382e5cc72082f.
It is no longer needed to install Chrome EC GPE handler to have
GPE enabled in suspend to idle path. It is found that with this
handler installed, EC wake up doesn't work because default EC
event handler that can wake up system is not g
On 2018-02-22 22:07, Rasmus Villemoes wrote:
>
> The whole point of fixdep and the include/config hierarchy is to be able
> to remove the dependency on autoconf.h, but I'm not sure I understand
> why kconfig.h itself is also forcibly removed.
Ah, 6a5be57f "fixdep: fix extraneous dependencies",
On February 22, 2018 9:08:44 PM GMT+01:00, Dmitry Osipenko
wrote:
>On 22.02.2018 17:38, Marcel Ziswiler wrote:
>> From: Marcel Ziswiler
>>
>> Since commit f8f8f1d04494 ("clk: Don't touch hardware when
>reparenting
>> during registration") ULPI has been broken on Tegra20 leading to the
>> foll
On Wed, 21 Feb 2018, Tariq Toukan wrote:
> On 20/02/2018 8:18 PM, Thomas Gleixner wrote:
> > On Tue, 20 Feb 2018, Thomas Gleixner wrote:
> > > On Tue, 20 Feb 2018, Tariq Toukan wrote:
> > >
> > > Is there CPU hotplugging in play?
>
> No.
Ok.
> > >
> > > I'll come back to you tomorrow with a pl
If regmap_update_bits() fails in lpc18xx_usb_otg_phy_power_on(),
lpc->clk is left enabled.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Alexey Khoroshilov
---
drivers/phy/phy-lpc18xx-usb-otg.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --
On Tue, Jan 30, 2018 at 1:41 AM, Greg KH wrote:
> On Mon, Jan 29, 2018 at 08:08:11PM -0600, Richard Gong wrote:
>> Hi Greg,
>>
>> Many thanks for your reviews.
>>
>>
>> On 01/25/2018 10:53 AM, Greg KH wrote:
>> > On Thu, Jan 25, 2018 at 10:39:03AM -0600, richard.g...@linux.intel.com
>> > wrote:
>
On Thu, Feb 22, 2018 at 10:24:29AM +0100, Andrea Parri wrote:
> Replace each occurrence of __ASM__MB with a (trailing) smp_mb() in
> xchg(), cmpxchg(), and remove the now unused __ASM__MB definitions;
> this improves readability, with no additional synchronization cost.
>
> Suggested-by: Will Deac
Dave Hansen wrote:
>
> From: Dave Hansen
>
>
> +static inline pgprotval_t check_pgprot(pgprot_t pgprot)
> +{
> + pgprotval_t massaged_val = massage_pgprot(pgprot);
> +
> + WARN_ONCE(pgprot_val(pgprot) != massaged_val,
> + "attempted to set unsupported pgprot: %016lx "
>
On Thu, Feb 22, 2018 at 10:24:48AM +0100, Andrea Parri wrote:
> Successful RMW operations are supposed to be fully ordered, but
> Alpha's xchg() and cmpxchg() do not align to this requirement.
>
> Will reported that:
>
> > So MP using xchg:
> >
> > WRITE_ONCE(x, 1)
> > xchg(y, 1)
> >
> > smp_load
On Thu, Feb 22, 2018 at 6:32 PM, Rafael J. Wysocki wrote:
> On Thu, Feb 22, 2018 at 5:45 PM, Dominik Brodowski
> wrote:
>> On Wed, Feb 21, 2018 at 01:24:16PM +0100, Rafael J. Wysocki wrote:
>>> Avoid that by using a new socket state flag, SOCKET_IN_RESUME,
>>> to indicate that socket_early_resume
Side note - and this may be crazy talk - I wonder if it might make
sense to have a mode where we allow executable read-only kernel pages
to be marked global too (but only in the kernel mapping).
Yes, yes, that potentially means that you can run meltdown on recently
run kernel code that is still in
Hi Greg,
Commit
cc738c1a69da ("staging: lustre: opencode cfs_cap_{raise, lower, raised}")
is missing a Signed-off-by from its author.
--
Cheers,
Stephen Rothwell
pgpD6UJGgBkad.pgp
Description: OpenPGP digital signature
On 02/22/2018 01:46 PM, Nadav Amit wrote:
>>
>> +static inline pgprotval_t check_pgprot(pgprot_t pgprot)
>> +{
>> +pgprotval_t massaged_val = massage_pgprot(pgprot);
>> +
>> +WARN_ONCE(pgprot_val(pgprot) != massaged_val,
>> + "attempted to set unsupported pgprot: %016lx "
>> +
On Thu, Feb 22, 2018 at 1:23 PM, Linus Torvalds
wrote:
>
> Hah. So it was the lack of kconfig.h dependency that bit my testing ;)
Confirmed. Rasmus was right, doing a full build after cleaning
everything up did fix this. So it's really just
itself that is missing from dependencies.
On Thu, Feb 22, 2018 at 1:34 PM, Rasmus Villemoes
wrote:
>
> Hm, we should probably make sure that kconfig.h is always on the
> dependency list in .o.cmd, but just exclude it from being processed for
> the CONFIG_ pattern.
That sounds sensible to me.
Not that this likely has ever bit anybody out
On Thu, Feb 22, 2018 at 9:30 PM, Dave Hansen
wrote:
> On 02/22/2018 01:27 PM, Nadav Amit wrote:
>> Dave Hansen wrote:
>>> From: Dave Hansen
>>> In creating its page tables, the espfix code masks its PGTABLE_PROT
>>> value with the supported mask: __supported_pte_mask. This ensures
>>> that unsu
On 02/22/2018 01:59 PM, Andy Lutomirski wrote:
>> I think it's good practice to just expose only the *minimal* amount of
>> data necessary. It's easier to audit and less likely to expose things
>> accidentall.
> But espfix64 is geniunely global. I'm confused.
I'm the confused one.
In my *first*
> On Feb 22, 2018, at 10:26 AM, Christoph Hellwig wrote:
>
> Can we move this into common code as a a generic_sriov_configure
> helper? Nothing is really virtio specific, and it seems like
> some other drivers could also use it, e.g. ena or nvme.
That seems like a good idea to me, especially if
lov - the logical object volume manager - is responsible for
striping data across multiple volumes.
So when it is given a request, it creates one or more
sub-requests, one for each target volume. Each sub_io
request has a sub_env environment which it operates in.
When lov_io_data_version_end() c
First two patches fix bugs that have been prevented the test suite
from finished for me - now it completes with about 10% of tests
failing.
Third patch fixes a tiny bug I noticed while reviewing another recent
patch to the same file.
Thanks,
NeilBrown
---
NeilBrown (3):
staging: lustre: l
If lstcon_test_add sets 'ret' (passed by reference) to 1,
then lst_test_add_ioctl() ignores the return value.
This isn't justified - the return value must be zero for 'ret'
to be meaningful.
Signed-off-by: NeilBrown
---
drivers/staging/lustre/lnet/selftest/conctl.c |2 +-
1 file changed, 1 i
Commit 8f18c8a48b73 ("staging: lustre: lmv: separate master object
with master stripe") changed how lmo_root inodes were managed,
particularly when LMV_HASH_FLAG_MIGRATION is not set.
Previously lsm_md_oinfo[0].lmo_root was always a borrowed
inode reference and didn't need to by iput().
Since the c
Dave Hansen wrote:
>
> From: Dave Hansen
>
> The __PAGE_KERNEL_* page permissions are "raw". They contain bits
> that may or may not be supported on the current processor. They
> need to be filtered by a mask (currently __supported_pte_mask) to
> turn them into a value that we can actually s
On 02/21/2018 03:03 AM, Oleksandr Andrushchenko wrote:
> +static struct xenbus_driver xen_driver = {
> + .ids = xen_drv_ids,
> + .probe = xen_drv_probe,
> + .remove = xen_drv_remove,
> + .otherend_changed = backend_on_changed,
What does "_on_" stand for?
-boris
First of all, this is a much-improved changelog. Thanks for that!
On 02/22/2018 01:11 AM, Baoquan He wrote:
> In sparse_init(), two temporary pointer arrays, usemap_map and map_map
> are allocated with the size of NR_MEM_SECTIONS. They are used to store
> each memory section's usemap and mem map
On 02/22/2018 02:21 PM, Nadav Amit wrote:
> Dave Hansen wrote:
>> From: Dave Hansen
>> The __PAGE_KERNEL_* page permissions are "raw". They contain bits
>> that may or may not be supported on the current processor. They
>> need to be filtered by a mask (currently __supported_pte_mask) to
>> tur
On Tue, Feb 20, 2018 at 12:10 PM, Dietmar Eggemann
wrote:
> Commit 343a8d17fa8d ("cpufreq: scpi: remove arm_big_little dependency")
> changed the cpufreq driver on juno from arm_big_little to scpi.
>
> The scpi set_target function does not call the frequency-invariance
> setter function arch_set_f
Thanks!
Jason
Hardware Info
-
Processor - Broadcom BCM4709C0KFEBG dual-core @ 1.4 GHz
Switch - BCM53012 in BCM4709C0KFEBG & external BCM53125
DDR3 RAM- 256 MB
Flash - 128 MB (Toshiba TC58BVG0S3HTA00)
2.4GHz - BCM4366 4×4 2.4/5G single chip 802.11ac SoC
Power
On Thu, Feb 22, 2018 at 8:17 PM, Richard Kuo wrote:
> On Thu, Feb 22, 2018 at 04:45:06PM +0100, Arnd Bergmann wrote:
>> * Hexagon is Qualcomm's DSP architecture. It is being actively used
>> in all Snapdragon ARM SoCs, but the kernel code appears to be
>> the result of a failed research projec
On Fri, Feb 23 2018, Stephen Rothwell wrote:
> Hi Greg,
>
> Commit
>
> cc738c1a69da ("staging: lustre: opencode cfs_cap_{raise, lower, raised}")
>
> is missing a Signed-off-by from its author.
>
Eek - sorry 'bout that.
Please add
Signed-off-by: NeilBrown
Thanks,
NeilBrown
signature.asc
D
ebied...@xmission.com (Eric W. Biederman) writes:
> Miklos Szeredi writes:
>
>> On Wed, Feb 21, 2018 at 9:29 PM, Eric W. Biederman
>> wrote:
>>> Ensure the translation happens by failing to read or write
>>> posix acls when the filesystem has not indicated it supports
>>> posix acls.
>>
>> For t
On Tue, Feb 20, 2018 at 09:32:08PM -0800, Cameron Gutman wrote:
> On 02/20/2018 11:33 AM, Rodrigo Rivas Costa wrote:
> > +static void steam_work_connect_cb(struct work_struct *work)
> > +{
> > + struct steam_device *steam = container_of(work, struct steam_device,
> > +
On Wed, 21 Feb 2018 12:22:08 +
Shameer Kolothum wrote:
> This allows the user-space to retrieve the supported IOVA
> range(s), excluding any reserved regions. The implementation
> is based on capability chains, added to VFIO_IOMMU_GET_INFO ioctl.
>
> Signed-off-by: Shameer Kolothum
> ---
>
On Thu, Feb 22, 2018 at 9:08 PM, Eric Anholt wrote:
> Arnd Bergmann writes:
>
>> We cannot select a symbol without meeting its other dependencies:
>>
>> warning: (DRM_PL111) selects DRM_DUMB_VGA_DAC which has unmet direct
>> dependencies (HAS_IOMEM && DRM && DRM_BRIDGE && OF)
>> drivers/gpu/drm/
We've got a few reports now [1] from users who are seeing a NULL pointer
dereference in the radix tree code. I've tracked it down to bad PTEs.
I don't think it's been seen on 64-bit x86, but it's definitely been
seen on 32-bit x86 running under Xen.
Feb 9 14:31:27 cs01 kernel: Bad swp_entry: 20
On Thu, 1 Feb 2018 01:27:38 -0500
Suravee Suthikulpanit wrote:
> VFIO IOMMU type1 currently upmaps IOVA pages synchronously, which requires
> IOTLB flushing for every unmapping. This results in large IOTLB flushing
> overhead when handling pass-through devices has a large number of mapped
> IOVA
On Tue, Feb 06, 2018 at 11:11:06PM +0100, Ulf Magnusson wrote:
> 'default N' should be 'default n', though they happen to have the same
> effect here, due to undefined symbols (N in this case) evaluating to n
> in a tristate sense.
>
> Remove the default instead of changing it. bool and tristate s
Thanks, applied to the dma mapping tree for 4.16, including the Fixes
tag.
Turns out latest upstream U-Boot does not configure/enable pllu which
leaves it at some default rate of 500 kHz:
root@apalis-t30:~# cat /sys/kernel/debug/clk/clk_summary | grep pll_u
pll_u 330 50 0
Of course this won't quite work leading t
Remove CONFIG_CAVIUM_OCTEON_CVMSEG_SIZE and automatically calculate
the amount of CVMSEG space needed.
1st 128-bytes: Use by IOBDMA
2nd 128-bytes: Reserved by kernel for scratch/TLS emulation.
3rd 128-bytes: OCTEON-III LMTLINE
New config variable CONFIG_CAVIUM_OCTEON_EXTRA_CVMSEG provisions
addit
From: Carlos Munoz
Add a global resource manager to manage tagged pointers within
bootmem allocated memory. This is used by various functional
blocks in the Octeon core like the FPA, Ethernet nexus, etc.
Signed-off-by: Carlos Munoz
Signed-off-by: Steven J. Hill
Signed-off-by: David Daney
---
We want to add the Cavium OCTEON-III network driver. But since
interacting with the input and output queues is done via special CPU
local memory, we also need to add support to the MIPS/Octeon
architecture code. Aren't SoCs nice in this way? These are the
prerequisite patches that are needed bef
From: Carlos Munoz
LMTDMA/LMTST operations move data between cores and I/O devices:
* LMTST operations can send an address and a variable length
(up to 128 bytes) of data to an I/O device.
* LMTDMA operations can send an address and a variable length
(up to 128) of data to the I/O device and
Previous patch sets USE_ASYNC_IOBDMA to 1 unconditionally. Remove
USE_ASYNC_IOBDMA from all if statements. Remove dead code caused by
the change.
Acked-by: Greg Kroah-Hartman
Signed-off-by: David Daney
---
drivers/staging/octeon/ethernet-defines.h | 6 ---
drivers/staging/octeon/ethernet-rx.
On 2/22/2018 4:26 PM, Dave Hansen wrote:
> On 02/22/2018 02:21 PM, Nadav Amit wrote:
>> Dave Hansen wrote:
>>> From: Dave Hansen
>>> The __PAGE_KERNEL_* page permissions are "raw". They contain bits
>>> that may or may not be supported on the current processor. They
>>> need to be filtered by a
On Tue, 20 Feb 2018 02:17:28 PST (-0800), parri.and...@gmail.com wrote:
Introduce __smp_{mb,rmb,wmb}, and rely on the generic definitions
for smp_{mb,rmb,wmb}. A first consequence is that smp_{mb,rmb,wmb}
map to a compiler barrier on !SMP (while their definition remains
unchanged on SMP). As a fu
On Tue, Feb 13, 2018 at 08:00:07PM +0300, Mika Westerberg wrote:
> The ICM firmware may reject devices for different reasons, even if we
> have asked it to accept anything. If we notice a device is rejected, we
> just log the event and bail out.
>
> Signed-off-by: Mika Westerberg
> ---
> drivers
On 02/21/2018 03:03 AM, Oleksandr Andrushchenko wrote:
> +
> +static int cfg_connector(struct xen_drm_front_info *front_info,
> + struct xen_drm_front_cfg_connector *connector,
> + const char *path, int index)
> +{
> + char *connector_path;
> +
> + connector_path = d
Add 'timeout-ms' property to support boards where the 3s timeout that the
current driver defaults to is too short.
Signed-off-by: Moritz Fischer
---
Changes from v2:
- Addressed Rob's feedback (timeout_ms -> timeout-ms)
Changes from v1:
- Addressed Rob's feedback (timeout -> timeout_ms)
- Added
Add support for reading a timeout value from device property.
Fall back to previous default of 3s if nothing is specified.
Signed-off-by: Moritz Fischer
---
Changes from v2:
- use device_property_read_{bool,u32} instead of of equivalent
Changes from v1:
- of_property_read_u32() overwrites the ou
Eric Anholt writes:
> [ Unknown signature status ]
> Tuomas Tynkkynen writes:
>
>> The Raspberry Pi 3 uses the 8250-based auxilary UART of the BCM2837 SoC
>> as the primary serial console of the board, so enable it in the
>> multiplatform defconfig.
>>
>> Signed-off-by: Tuomas Tynkkynen
>
> Rev
We are adding the Cavium OCTEON-III network driver. Since interacting
with the input and output queues is done via special CPU local memory,
we also need to add support to the MIPS/Octeon architecture code. The
four patch set to add this prerequisite code has been split out to a
seperate patch se
From: Carlos Munoz
Add bindings for Common Ethernet Interface (BGX) block.
Acked-by: Rob Herring
Signed-off-by: Carlos Munoz
Signed-off-by: Steven J. Hill
Signed-off-by: David Daney
---
.../devicetree/bindings/net/cavium-bgx.txt | 61 ++
1 file changed, 61 insert
Signed-off-by: David Daney
---
MAINTAINERS | 6 ++
1 file changed, 6 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 9a7f76eadae9..b36371ae590f 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3259,6 +3259,12 @@ W: http://www.cavium.com
S: Supported
F: drivers/mmc/ho
On Fri, Feb 23, 2018 at 12:00 AM, Bjorn Helgaas wrote:
> On Tue, Feb 06, 2018 at 11:11:06PM +0100, Ulf Magnusson wrote:
>> 'default N' should be 'default n', though they happen to have the same
>> effect here, due to undefined symbols (N in this case) evaluating to n
>> in a tristate sense.
>>
>>
David Howells wrote:
> + l = min(len, PAGE_SIZE);
Sigh. This needs to be a min_t().
David
Hi Lina,
On Thu, Feb 22, 2018 at 8:58 AM, Lina Iyer wrote:
> On Wed, Feb 21 2018 at 22:07 +, Evan Green wrote:
>>
>> Hi Lina,
>>
>> On Thu, Feb 15, 2018 at 9:35 AM, Lina Iyer wrote:
>
> [...]
>
>>> +static struct cache_req *cache_rpm_request(struct rpmh_client *rc,
>>> +
I've posted an update that converts the min() to a min_t() and tagged it:
https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/tag/?h=keys-fixes-20180222-2
Do you want me to repost the patches?
David
Hi Lina,
On Thu, Feb 22, 2018 at 9:04 AM, Lina Iyer wrote:
> On Wed, Feb 21 2018 at 23:25 +, Evan Green wrote:
>>
>> Hello Lina,
>>
>> On Thu, Feb 15, 2018 at 9:35 AM, Lina Iyer wrote:
>>>
>>> Platform drivers need make a lot of resource state requests at the same
>>> time, say, at the start
On 02/22/2018 04:04 PM, Marcel Ziswiler wrote:
Turns out latest upstream U-Boot does not configure/enable pllu which
leaves it at some default rate of 500 kHz:
I assume this is only because U-Boot just happened not to access any USB
devices. In other words, if you break into the U-Boot boot fl
On Thu, Feb 22, 2018 at 04:45:06PM +0100, Arnd Bergmann wrote:
> While building the cross-toolchains, I noticed that overall, we can build
> almost
> all linux target architectures with upstream binutils and gcc these days,
> however there are still some exceptions, and I'd like to find out if any
On Tue, Feb 20, 2018 at 07:19:27PM -0800, Feng Kan wrote:
> The Ampere Computing PCIe root port does not support ACS at this point.
> However, the hardware provides isolation and source validation through the
> SMMU. The stream ID generated by the PCIe ports contain both the
> bus/device/function n
On 02/21/2018 03:03 AM, Oleksandr Andrushchenko wrote:
> +
> +static irqreturn_t evtchnl_interrupt_ctrl(int irq, void *dev_id)
> +{
> + struct xen_drm_front_evtchnl *evtchnl = dev_id;
> + struct xen_drm_front_info *front_info = evtchnl->front_info;
> + struct xendispl_resp *resp;
> +
dentry_kill() holds dentry->d_lock and needs to acquire both
dentry->d_inode->i_lock and dentry->d_parent->d_lock. This cannot be
done with spin_lock() operations because it's the reverse of the
regular lock order. To avoid ABBA deadlocks it is done with two
trylock loops.
Trylock loops are proble
shrink_dentry_list() holds dentry->d_lock and needs to acquire
dentry->d_inode->i_lock. This cannot be done with a spin_lock()
operation because it's the reverse of the regular lock order.
To avoid ABBA deadlocks it is done with a trylock loop.
Trylock loops are problematic in two scenarios:
1)
A subsequent patch will modify dentry_kill() to call lock_parent().
Move the dentry_kill() implementation "as is" below lock_parent()
first. This will help simplify the review of the subsequent patch
with dentry_kill() changes.
Signed-off-by: John Ogness
---
fs/dcache.c | 62
Thank you Al Viro, Linus Torvalds, Peter Zijlstra, Amir Goldstein
for the detailed feedback.
Changes in v2:
. dentry_lock_inode()
- added quick out on trylock success
- added comments to rcu section
- expanded rcu coverage to all inode usage
- if inode changes during d_lock window,
res
d_delete() holds dentry->d_lock and needs to acquire
dentry->d_inode->i_lock. This cannot be done with a spin_lock()
operation because it's the reverse of the regular lock order. To avoid
the ABBA deadlock it is done with a trylock loop.
Trylock loops are problematic in two scenarios:
1) PREEMP
On Wed, Feb 07, 2018 at 04:01:19PM +0530, Vivek Gautam wrote:
> From: Sricharan R
>
> The smmu device probe/remove and add/remove master device callbacks
> gets called when the smmu is not linked to its master, that is without
> the context of the master device. So calling runtime apis in those p
Commit 0d98439ea3c6 ("vfs: use lockred "dead" flag to mark unrecoverably
dead dentries") removed the `ref' parameter in dentry_kill() but its
documentation remained. Remove it.
Signed-off-by: John Ogness
---
fs/dcache.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/dcache.c b/fs/dcache.c
shrink_dentry_list() holds dentry->d_lock and needs to acquire
dentry->d_inode->i_lock. This cannot be done with a spin_lock()
operation because it's the reverse of the regular lock order.
To avoid ABBA deadlocks it is done with a trylock loop.
Trylock loops are problematic in two scenarios:
1)
On Thu, 2018-02-22 at 10:40 -0700, Jonathan Corbet wrote:
> That said, we can add this one; I'll take the patch if I get an ack from
> Joe.
Meh-ed-by: Joe Perches
On Wed, Feb 07, 2018 at 10:10:55AM -0800, Matthew Wilcox wrote:
> On Wed, Feb 07, 2018 at 05:45:13PM +0100, Jesper Dangaard Brouer wrote:
> > On Wed, 7 Feb 2018 08:57:00 -0500
> > Steven Rostedt wrote:
> > > To me kvfree() is a special case and should not be used by RCU as a
> > > generic function
On 02/22/18 at 01:24pm, Andrew Morton wrote:
> On Thu, 22 Feb 2018 17:11:28 +0800 Baoquan He wrote:
>
> > It's used to record how many memory sections are marked as present
> > during system boot up, and will be used in the later patch.
> >
> > --- a/mm/sparse.c
> > +++ b/mm/sparse.c
> > @@ -202
This patchset fixes warnings and errors found by checkpatch.pl in the
drm/virtio:
* Removes return from void function;
* Adds */ in block comments to separate line;
* Adds blank line after variable declarations;
* Adds tabs at the start of a line;
* Replaces 'unsigned' for 'unsigned int';
* Remove
This patch fixes the checkpatch.pl errors:
drivers/gpu/drm/virtio/virtgpu_drv.h:371: ERROR: code indent should use
tabs where possible
...
Signed-off-by: Rodrigo Siqueira
---
drivers/gpu/drm/virtio/virtgpu_display.c | 2 +-
drivers/gpu/drm/virtio/virtgpu_drv.h | 6 +++---
2 files changed, 4
This patch fixes the checkpatch.pl warning:
virtgpu_ioctl.c:551: WARNING: Block comments use a trailing */ on a
separate line
...
Signed-off-by: Rodrigo Siqueira
---
drivers/gpu/drm/virtio/virtgpu_ioctl.c | 3 ++-
drivers/gpu/drm/virtio/virtgpu_prime.c | 3 ++-
drivers/gpu/drm/virtio/virtgpu_vq
This patch fixes the checkpatch.pl warnings:
virtgpu_drv.c:57: WARNING: Missing a blank line after declarations
virtgpu_display.c:99: WARNING: Missing a blank line after declarations
...
Signed-off-by: Rodrigo Siqueira
---
drivers/gpu/drm/virtio/virtgpu_display.c | 1 +
drivers/gpu/drm/virtio/v
This patch fixes the checkpatch.pl warning:
virtgpu_ttm.c:181: WARNING: void function return statements are not
generally useful
...
Signed-off-by: Rodrigo Siqueira
---
drivers/gpu/drm/virtio/virtgpu_ttm.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/virtio/virtgpu_ttm.c
This patch fixes the checkpatch.pl warning:
drivers/gpu/drm/virtio/virtgpu_display.c:64: WARNING: Prefer 'unsigned
int' to bare use of 'unsigned'
...
Signed-off-by: Rodrigo Siqueira
---
drivers/gpu/drm/virtio/virtgpu_display.c | 4 ++--
drivers/gpu/drm/virtio/virtgpu_drv.h | 2 +-
drivers/g
This patch fixes the checkpatch.pl check:
virtgpu_ioctl.c:535: CHECK: spaces preferred around that '|' (ctx:VxV)
virtgpu_vq.c:277: CHECK: spaces preferred around that '+' (ctx:VxV)
...
Signed-off-by: Rodrigo Siqueira
---
drivers/gpu/drm/virtio/virtgpu_ioctl.c | 18 +-
drivers/gp
This patch fixes the checkpatch.pl check:
virtgpu_drv.c:116: CHECK: Please don't use multiple blank lines
virtgpu_vq.c:599: CHECK: Please don't use multiple blank lines
virtgpu_prime.c:42: CHECK: Please don't use multiple blank lines
Signed-off-by: Rodrigo Siqueira
---
drivers/gpu/drm/virtio/vi
On Thu, Feb 22, 2018 at 2:26 PM, kbuild test robot wrote:
> Hi Kees,
>
> I love your patch! Yet something to improve:
>
> [auto build test ERROR on linus/master]
> [also build test ERROR on v4.16-rc2 next-20180222]
> [if your patch is applied to the wrong git tree, ple
Hi Haiyue,
On Thu, 22 Feb 2018, at 19:20, Wang, Haiyue wrote:
> Dear Andrew & Joel,
>
> Since you are ASPEED BMC experts, any time and interest in eSPI code
> review ? I've sent
>
> it before, but no more response. Intel recommends eSPI bus than LPC as I
> know. I just kept
>
> the minimal eS
Hi Masami,
On Thu, Feb 22, 2018 at 04:45:01PM +0900, Masami Hiramatsu wrote:
> In Documentation/trace/kprobetrace.txt, it says
>
> @SYM[+|-offs] : Fetch memory at SYM +|- offs (SYM should be a data symbol)
>
> However, the parser doesn't parse minus offset correctly, since
> commit 2fba0c8867af
Helge Deller writes:
> * Eric W. Biederman :
>> Setting si_code to 0 results in a userspace seeing an si_code of 0.
>> This is the same si_code as SI_USER. Posix and common sense requires
>> that SI_USER not be a signal specific si_code. As such this use of 0
>> for the si_code is a pretty horr
On Thu, Feb 22, 2018 at 4:03 PM, Kees Cook wrote:
> On Thu, Feb 22, 2018 at 2:26 PM, kbuild test robot wrote:
>> Hi Kees,
>>
>> I love your patch! Yet something to improve:
>>
>> [auto build test ERROR on linus/master]
>> [also build test ERROR on v4.16-
701 - 800 of 952 matches
Mail list logo
