Re: [PATCH net-next 0/2] br_netfilter: enable in non-initial netns

2019-03-07 Thread Florian LAUNAY
Hi everyone, Can someone help move this topic forward ? This issue simply prevents any advanced use of docker in LXC. Thank you in advance! Florian LAUNAY On 07/11/2018 14:48, Christian Brauner wrote: Hey everyone, Over time I have seen multiple reports by users who want to run applications

Re: [PATCH/RFC] driver core: Postpone DMA tear-down until after devres release

2019-03-07 Thread John Garry
On 07/03/2019 14:52, Robin Murphy wrote: Hi John, Hi Robin, ok, fine. It's a pain bisecting another rmmod issue with it... Cheers, On 07/03/2019 14:45, John Garry wrote: [...] Hi guys, Any idea what happened to this fix? It's been in -next for a while (commit 376991db4b64) - I assume

Re: [PATCH 0/14] v2 multi-die/package topology support

2019-03-07 Thread Morten Rasmussen
On Tue, Feb 26, 2019 at 07:53:58PM +0100, Peter Zijlstra wrote: > On Tue, Feb 26, 2019 at 01:19:58AM -0500, Len Brown wrote: > > Added sysfs package_threads, package_threads_list > > > > Added this attribute to show threads siblings in a package. > > Exactly same as "core_siblings above",

[PATCH] can: flexcan: bump FLEXCAN_TIMEOUT_US to 250

2019-03-07 Thread Rasmus Villemoes
While trying to add support for the Flexcan modules on the MPC8309, I'm hitting ETIMEDOUT in flexcan_chip_disable(). With this, probing succeeds. Checking the leftover value of timeout with a primitive pr_err("%s: timeout==%d\n", __func__, timeout); after the loop in chip_disable() typically

Re: [PATCH v4 1/2] Provide in-kernel headers for making it easy to extend the kernel

2019-03-07 Thread Joel Fernandes
On Thu, Mar 07, 2019 at 09:58:24AM +0100, Geert Uytterhoeven wrote: > Hi Joel, > > On Fri, Mar 1, 2019 at 5:10 PM Joel Fernandes (Google) > wrote: > > Introduce in-kernel headers and other artifacts which are made available > > as an archive through proc (/proc/kheaders.tar.xz file). This

Re: [PATCH v1] arch_topology: Make cpu_capacity sysfs node as ready-only

2019-03-07 Thread Sudeep Holla
On Thu, Mar 07, 2019 at 12:14:03PM +, Quentin Perret wrote: > On Thursday 07 Mar 2019 at 10:57:50 (+0100), Juri Lelli wrote: > > If people think it's best to simply make this RO, I won't be against it. > > Just pointed out a conversation we recently had. Guess we could also > > make it RW

Re: [PATCH v3] page cache: Store only head pages in i_pages

2019-03-07 Thread Matthew Wilcox
On Wed, Mar 06, 2019 at 02:36:35AM -0700, William Kucharski wrote: > > Other than the bug Song found in memfd_tag_pins(), I'd like to suggest two > quick > but pedantic changes to mm/filemap.c: > > Though not modified in this patch, in line 284, the parenthesis should be > moved > to after the

Re: [PATCH] bcache: add cond_resched() in __bch_cache_cmp()

2019-03-07 Thread Shile Zhang
On 2019/3/7 18:34, Coly Li wrote: On 2019/3/7 1:15 下午, shile.zh...@linux.alibaba.com wrote: From: Shile Zhang Read /sys/fs/bcache//cacheN/priority_stats can take very long time with huge cache after long run. Signed-off-by: Shile Zhang Hi Shile, Do you test your change ? It will be

[PATCH] x86/cpufeature: Remove __pure attribute to _static_cpu_has()

2019-03-07 Thread Borislav Petkov
On Mon, Feb 11, 2019 at 12:32:41PM -0800, Nadav Amit wrote: > BTW: the “__pure” attribute is useless when “__always_inline” is used. > Unless it is intended to be some sort of comment, of course. --- From: Borislav Petkov Date: Thu, 7 Mar 2019 15:54:51 +0100 __pure is used to make gcc do Common

[PATCH v2] iio: cros_ec: Fix the maths for gyro scale calculation

2019-03-07 Thread Enric Balletbo i Serra
From: Gwendal Grignou Calculation did not use IIO_DEGREE_TO_RAD and implemented a variant to avoid precision loss as we aim a nano value. The offset added to avoid rounding error, though, doesn't give us a close result to the expected value. E.g. For 1000dps, the result should be: (1000 *

Re: [PATCH 2/3] ASoC: ti: remove compat dma probing

2019-03-07 Thread Arnd Bergmann
On Thu, Mar 7, 2019 at 2:22 PM Peter Ujfalusi wrote: > > Hi Arnd, > > On 04/03/2019 22.30, Arnd Bergmann wrote: > > After running into a link error: > > > > sound/soc/ti/edma-pcm.o:(.rodata+0x18): undefined reference to > > `edma_filter_fn' > > > > I checked all users of this, and they have

Re: [PATCH/RFC] driver core: Postpone DMA tear-down until after devres release

2019-03-07 Thread Greg Kroah-Hartman
On Thu, Mar 07, 2019 at 02:52:55PM +, Robin Murphy wrote: > Hi John, > > On 07/03/2019 14:45, John Garry wrote: > [...] > > Hi guys, > > > > Any idea what happened to this fix? > > It's been in -next for a while (commit 376991db4b64) - I assume it will land > shortly and hit stable

[PATCH 5/9] arm64: dts: meson: g12a: add reset controller

2019-03-07 Thread Neil Armstrong
From: Jerome Brunet Add the reset controller device of g12a SoC family Signed-off-by: Jerome Brunet Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/amlogic/meson-g12a.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm64/boot/dts/amlogic/meson-g12a.dtsi

[PATCH 6/9] arm64: dts: meson: g12a: Add UART A, B & C nodes and pins

2019-03-07 Thread Neil Armstrong
This patch adds the 2 UART nodes in the EE power domain with the corresponding pinctrl nodes. Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/amlogic/meson-g12a.dtsi | 82 + 1 file changed, 82 insertions(+) diff --git a/arch/arm64/boot/dts/amlogic/meson-g12a.dtsi

[PATCH 1/9] arm64: dts: meson: g12a: Add AO Clock + Reset Controller support

2019-03-07 Thread Neil Armstrong
Add nodes and properties for the AO Clocks and Resets. Signed-off-by: Neil Armstrong Signed-off-by: Jerome Brunet --- arch/arm64/boot/dts/amlogic/meson-g12a.dtsi | 17 + 1 file changed, 17 insertions(+) diff --git a/arch/arm64/boot/dts/amlogic/meson-g12a.dtsi

[PATCH 8/9] arm64: dts: meson: g12a: Add G12A USB nodes

2019-03-07 Thread Neil Armstrong
This patch adds the nodes for the USB Complex found in the Amlogic G12A SoC. It includes the : - 2 USB2 PHYs - 1 USB3 + PCIE Combo PHY - the USB Glue with it's DWC2 and DWC3 sub-nodes Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/amlogic/meson-g12a.dtsi | 78 + 1

[PATCH 9/9] arm64: dts: meson: g12a: Add mali-g31 gpu node

2019-03-07 Thread Neil Armstrong
This patch adds the ARM Mali G31 GPU node. Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/amlogic/meson-g12a.dtsi | 27 + 1 file changed, 27 insertions(+) diff --git a/arch/arm64/boot/dts/amlogic/meson-g12a.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12a.dtsi index

[PATCH 7/9] arm64: dts: meson: g12a: Add SAR ADC node

2019-03-07 Thread Neil Armstrong
This patch adds the SAR ADC controller node. Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/amlogic/meson-g12a.dtsi | 14 ++ 1 file changed, 14 insertions(+) diff --git a/arch/arm64/boot/dts/amlogic/meson-g12a.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12a.dtsi index

[PATCH 0/9] arm64: dts: g12a: Add peripherals

2019-03-07 Thread Neil Armstrong
Add following peripherals : - AO Clock + Reset Controller - AO Secure Node, used for chipid - Pinctrl - UARTs - SAR-ADC - USB - Mali GPU USB depends on the PCIE clock and missing Reset bindings. SARADC, USB & Mali GPU bindings are yet to be merged but are in review. Jerome Brunet (3): arm64:

[PATCH 2/9] arm64: dts: meson: g12a: Add AO Secure node

2019-03-07 Thread Neil Armstrong
This adds the Always-On ao-secure system control registers node, which is used by the meson-gx-socinfo driver to detect the SoC IDs. Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/amlogic/meson-g12a.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git

[PATCH 3/9] arm64: dts: meson: g12a: add pinctrl support controllers

2019-03-07 Thread Neil Armstrong
From: Jerome Brunet Add the peripheral and always-on pinctrl controllers to the g12a soc. Signed-off-by: Jerome Brunet Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/amlogic/meson-g12a.dtsi | 41 + 1 file changed, 41 insertions(+) diff --git

[PATCH 4/9] arm64: dts: meson: g12a: add uart_ao_a pinctrl

2019-03-07 Thread Neil Armstrong
From: Jerome Brunet Add the always on UART pinctrl setting to the g12a soc DT and use it for the u200 reference design Signed-off-by: Jerome Brunet Signed-off-by: Neil Armstrong --- .../arm64/boot/dts/amlogic/meson-g12a-u200.dts | 2 ++ arch/arm64/boot/dts/amlogic/meson-g12a.dtsi| 18

Re: [PATCH] enic: fix build warning without CONFIG_CPUMASK_OFFSTACK

2019-03-07 Thread Nathan Chancellor
On Thu, Mar 07, 2019 at 10:33:02AM +0100, Arnd Bergmann wrote: > The enic driver relies on the CONFIG_CPUMASK_OFFSTACK feature to > dynamically allocate a struct member, but this is normally intended for > local variables. > > Building with clang, I get a warning for a few locations that check

Re: [PATCH] davinci_emac: always build in CONFIG_OF code

2019-03-07 Thread Nathan Chancellor
On Thu, Mar 07, 2019 at 10:31:20AM +0100, Arnd Bergmann wrote: > clang warns about what seems to be an unintended use of an obscure C > language feature where a forward declaration of an array remains usable > when the final definition is never seen: > >

[PATCH 1/3] ASoC: ti: remove compat dma probing

2019-03-07 Thread Arnd Bergmann
After running into a link error: sound/soc/ti/edma-pcm.o:(.rodata+0x18): undefined reference to `edma_filter_fn' I checked all users of this, and they have new-style 'dma_slave_map' tables, so none of them should still need it. Removing the associated lines simplifies the code and avoids the

[PATCH 2/3] dmaengine: omap-dma: make omap_dma_filter_fn private

2019-03-07 Thread Arnd Bergmann
With the audio driver no longer referring to this function, it can be made private to the dmaengine driver itself, and the header file removed. Signed-off-by: Arnd Bergmann --- drivers/dma/ti/omap-dma.c | 3 ++- include/linux/omap-dma.h | 2 -- include/linux/omap-dmaengine.h | 21

Re: [PATCH] isdn: isdnloop: fix pointer dereference bug

2019-03-07 Thread Nathan Chancellor
On Thu, Mar 07, 2019 at 10:32:07AM +0100, Arnd Bergmann wrote: > clang has spotted an ancient code bug and warns about it with: > > drivers/isdn/isdnloop/isdnloop.c:573:12: error: address of array > 'card->rcard' will always evaluate to 'true' > [-Werror,-Wpointer-bool-conversion] > > This is

[PATCH 3/3] dmaengine: edma: make edma_filter_fn private

2019-03-07 Thread Arnd Bergmann
With the audio driver no longer referring to this function, it can be made private to the dmaengine driver itself, and the header file removed. Signed-off-by: Arnd Bergmann --- drivers/dma/ti/edma.c | 5 +++-- include/linux/edma.h | 29 - 2 files changed, 3

Re: [PATCHv6 07/10] acpi/hmat: Register processor domain to its memory

2019-03-07 Thread Keith Busch
Hi Brice, Please see v7 of this series from last week instead for reviews: https://patchwork.kernel.org/cover/10832365/

Re: [PATCH v1] arch_topology: Make cpu_capacity sysfs node as ready-only

2019-03-07 Thread Sudeep Holla
On Wed, Mar 06, 2019 at 08:57:53PM +0530, Lingutla Chandrasekhar wrote: > If user updates any cpu's cpu_capacity, then the new value is going to > be applied to all its online sibling cpus. But this need not to be correct > always, as sibling cpus (in ARM, same micro architecture cpus) would have

[PATCH v2] ARM: multi_v7_defconfig: Enable missing drivers for supported Chromebooks

2019-03-07 Thread Enric Balletbo i Serra
Enable following drivers for merged devices: - Batteries with BQ27XXX chips for Minnie boards. - Elan eKTH I2C touchscreen for Minnie boards. - GPIO charger for all Veyron boards. - Rockchip SARADC driver for all rk3288 boards. - Rockchip eFUSE driver for all rk3288 boards. - TPM security chip for

Re: [PATCH] mmc: pxamci: fix enum type confusion

2019-03-07 Thread Nathan Chancellor
On Thu, Mar 07, 2019 at 11:09:19AM +0100, Arnd Bergmann wrote: > clang points out several instances of mismatched types in this drivers, > all coming from a single declaration: > > drivers/mmc/host/pxamci.c:193:15: error: implicit conversion from enumeration > type 'enum dma_transfer_direction'

Re: [PATCH] mmc: davinci: remove extraneous __init annotation

2019-03-07 Thread Nathan Chancellor
On Thu, Mar 07, 2019 at 11:10:11AM +0100, Arnd Bergmann wrote: > Building with clang finds a mistaken __init tag: > > WARNING: vmlinux.o(.text+0x5e4250): Section mismatch in reference from the > function davinci_mmcsd_probe() to the function .init.text:init_mmcsd_host() > The function

Re: [PATCH for-4.19] staging: erofs: fix mis-acted TAIL merging behavior

2019-03-07 Thread Greg KH
On Thu, Mar 07, 2019 at 09:04:06PM +0800, Gao Xiang wrote: > Hi Greg, > > On 2019/3/7 20:25, Greg KH wrote: > > On Thu, Mar 07, 2019 at 01:34:04PM +0800, Gao Xiang wrote: > >> commit a112152f6f3a2a88caa6f414d540bd49e406af60 upstream. > >> > >> EROFS has an optimized path called TAIL merging,

Re: [PATCH] ASoC: ams-delta: remove duplicate 'const'

2019-03-07 Thread Nathan Chancellor
On Thu, Mar 07, 2019 at 11:10:49AM +0100, Arnd Bergmann wrote: > clang points out that SOC_ENUM_SINGLE_EXT_DECL() contains a 'const' > modifier already, so adding another one does not make it more const: > > sound/soc/ti/ams-delta.c:203:14: error: duplicate 'const' declaration > specifier

Re: [PATCH v4 1/2] Provide in-kernel headers for making it easy to extend the kernel

2019-03-07 Thread Greg KH
On Thu, Mar 07, 2019 at 10:03:43AM -0500, Joel Fernandes wrote: > On Thu, Mar 07, 2019 at 09:58:24AM +0100, Geert Uytterhoeven wrote: > > Hi Joel, > > > > On Fri, Mar 1, 2019 at 5:10 PM Joel Fernandes (Google) > > wrote: > > > Introduce in-kernel headers and other artifacts which are made

Re: [PATCH] ASoC: davinci-mcasp: Fix clang warning without CONFIG_PM

2019-03-07 Thread Nathan Chancellor
On Thu, Mar 07, 2019 at 11:11:30AM +0100, Arnd Bergmann wrote: > Building with clang shows a variable that is only used by the > suspend/resume functions but defined outside of their #ifdef block: > > sound/soc/ti/davinci-mcasp.c:48:12: error: variable 'context_regs' is not > needed and will not

Re: [PATCH] [RFC] spi: pxa2xx: Do cs if restart the SSP during pxa2xx_spi_transfer_one()

2019-03-07 Thread Jarkko Nikula
Hi Is this also related to the regression with d5898e19c0d7 ("spi: pxa2xx: Use core message processing loop") you have found or another issue? Comments below. On 3/7/19 9:24 AM, xiao jin wrote: The spi-pxa2xx can't read and write data correctly on our board. The pxa_ssp_type is LPSS_BXT_SSP

Re: [PATCH v5 07/10] perf record: implement -z,--compression_level=n option and compression

2019-03-07 Thread Alexey Budankov
On 07.03.2019 15:14, Jiri Olsa wrote: > On Thu, Mar 07, 2019 at 11:39:46AM +0300, Alexey Budankov wrote: >> >> On 05.03.2019 15:25, Jiri Olsa wrote: >>> On Fri, Mar 01, 2019 at 06:58:32PM +0300, Alexey Budankov wrote: >>> >>> SNIP >>> /* * Increment md->refcount to guard

Re: [PATCH] cpufreq: pxa2xx: remove incorrect __init annotation

2019-03-07 Thread Nathan Chancellor
On Thu, Mar 07, 2019 at 11:22:41AM +0100, Arnd Bergmann wrote: > pxa_cpufreq_init_voltages() is marked __init but usually inlined into > the non-__init pxa_cpufreq_init() function. When building with clang, > it can stay as a standalone function in a discarded section, and produce > this warning:

Re: [Y2038] Question regarding support of old time interfaces beyond y2038

2019-03-07 Thread Arnd Bergmann
On Thu, Mar 7, 2019 at 3:43 PM Lukasz Majewski wrote: > > On Thu, Mar 7, 2019 at 8:53 AM Lukasz Majewski wrote: > > > > On Tue, Mar 5, 2019 at 10:24 AM Lukasz Majewski > To be more specific: > > I'm thinking of settimeofday/gettimeofday syscalls. > > In the kernel we use internally

Re: [PATCH v8 2/2] pwm: sifive: Add a driver for SiFive SoC PWM

2019-03-07 Thread Uwe Kleine-König
Hello, On Fri, Mar 01, 2019 at 04:23:19PM +0530, Yash Shah wrote: > Adds a PWM driver for PWM chip present in SiFive's HiFive Unleashed SoC. > > Signed-off-by: Wesley W. Terpstra > [Atish: Various fixes and code cleanup] > Signed-off-by: Atish Patra > Signed-off-by: Yash Shah > --- >

Re: [PATCH] signal: fix building with clang

2019-03-07 Thread Oleg Nesterov
On 03/07, Arnd Bergmann wrote: > > clang warns about the sigset_t manipulating functions (sigaddset, sigdelset, > sigisemptyset, ...) because it performs semantic analysis before discarding > dead code, unlike gcc that does this in the reverse order. > > The result is a long list of warnings like:

[PATCH 1/2] iio: imu: adis16480: Add support for external clock

2019-03-07 Thread Stefan Popa
Inertial sensor data collection and processing can be controlled by configuring one of the DIOx lines as an external clock input. This option is available for all devices supported by this driver. However, only adis1649x devices support different modes for the external clock. Sync mode is

[PATCH 2/2] dt-bindings: iio: imu: adis16480: Document external clock

2019-03-07 Thread Stefan Popa
Add documentation for optional use of external clock. All devices supported by this driver can work with an external clock in sync mode. Another mode, called Pulse Per Second (PPS) is supported only by adis1649x devices. The mode is selected by using the "clock-names" property. The pin which is

Re: [PATCH] scripts/package/mkdebian: expose KCONFIG_CONFIG to debian/rules

2019-03-07 Thread Masahiro Yamada
On Fri, Feb 22, 2019 at 7:21 AM Arseny Maslennikov wrote: > > If KCONFIG_CONFIG is passed to `make deb-pkg` as a makeflag or > environment variable, the source tarball produced contains whatever > specified by that variable instead of the usual `.config'. > > While `make deb-pkg' yields a correct

Re: Banana Pi-R1 stabil

2019-03-07 Thread Maxime Ripard
On Wed, Mar 06, 2019 at 09:03:00PM +0100, Gerhard Wiesinger wrote: > while true; do echo ""; echo -n > "CPU_FREQ0: "; cat /sys/devices/system/cpu/cpu0/cpufreq/cpuinfo_cur_freq; > echo -n "CPU_FREQ1: "; cat >

[PATCH v4] page cache: Store only head pages in i_pages

2019-03-07 Thread Matthew Wilcox
Transparent Huge Pages are currently stored in i_pages as pointers to consecutive subpages. This patch changes that to storing consecutive pointers to the head page in preparation for storing huge pages more efficiently in i_pages. Large parts of this are "inspired" by Kirill's patch

Re: [PATCH] peak_usb: fix clang build warning

2019-03-07 Thread Nathan Chancellor
On Thu, Mar 07, 2019 at 11:31:55AM +0100, Arnd Bergmann wrote: > Clang points out undefined behavior when building the pcan_usb_pro driver: > > drivers/net/can/usb/peak_usb/pcan_usb_pro.c:136:15: error: passing an object > that undergoes default argument promotion to 'va_start' has undefined >

Re: [PATCH] scripts/package/Makefile: put proper config in source tarball

2019-03-07 Thread Masahiro Yamada
On Fri, Feb 22, 2019 at 7:19 AM Arseny Maslennikov wrote: > > It is widely known that one can build a kernel without a .config in the > source tree "without a .config in the source file" means KCONFIG_CONFIG will probably contain '..' or absolute path. ex1) KCONFIG_CONFIG=../my_dir/.config

Re: [PATCH] drm/amd/display: avoid passing enum as NULL pointer

2019-03-07 Thread Nathan Chancellor
On Thu, Mar 07, 2019 at 11:34:29AM +0100, Arnd Bergmann wrote: > The mod_freesync_build_vrr_infopacket() function uses rather obscure > calling conventions, where an enum is passed in through a pointer, > and a NULL pointer is expected to behave the same way as the zero-value >

Re: [RFC PATCH V2 5/5] vhost: access vq metadata through kernel virtual address

2019-03-07 Thread Michael S. Tsirkin
On Thu, Mar 07, 2019 at 10:45:57AM +0800, Jason Wang wrote: > > On 2019/3/7 上午12:31, Michael S. Tsirkin wrote: > > > +static void vhost_set_vmap_dirty(struct vhost_vmap *used) > > > +{ > > > + int i; > > > + > > > + for (i = 0; i < used->npages; i++) > > > +

[PATCHv2 5/8] perf tools: Get precise_ip from the pmu config

2019-03-07 Thread Jiri Olsa
On Tue, Mar 05, 2019 at 08:40:17AM -0800, Andi Kleen wrote: > On Tue, Mar 05, 2019 at 05:28:54PM +0100, Jiri Olsa wrote: > > On Tue, Mar 05, 2019 at 08:13:19AM -0800, Andi Kleen wrote: > > > On Tue, Mar 05, 2019 at 04:25:33PM +0100, Jiri Olsa wrote: > > > > Getting precise_ip field from the

Re: [PATCH] ARM: omap2: remove incorrect __init annotation

2019-03-07 Thread Nathan Chancellor
On Thu, Mar 07, 2019 at 11:35:50AM +0100, Arnd Bergmann wrote: > omap3xxx_prm_enable_io_wakeup() is marked __init, but its caller is not, so > we get a warning with clang-8: > > WARNING: vmlinux.o(.text+0x343c8): Section mismatch in reference from the > function omap3xxx_prm_late_init() to the

Re: [PATCH] bcache: add cond_resched() in __bch_cache_cmp()

2019-03-07 Thread Coly Li
On 2019/3/7 11:06 下午, Shile Zhang wrote: > > On 2019/3/7 18:34, Coly Li wrote: >> On 2019/3/7 1:15 下午, shile.zh...@linux.alibaba.com wrote: >>> From: Shile Zhang >>> >>> Read /sys/fs/bcache//cacheN/priority_stats can take very long >>> time with huge cache after long run. >>> >>> Signed-off-by:

Re: [PATCH] signal: fix building with clang

2019-03-07 Thread Arnd Bergmann
On Thu, Mar 7, 2019 at 4:28 PM Oleg Nesterov wrote: > > On 03/07, Arnd Bergmann wrote: > > > > clang warns about the sigset_t manipulating functions (sigaddset, sigdelset, > > sigisemptyset, ...) because it performs semantic analysis before discarding > > dead code, unlike gcc that does this in

Re: [PATCH] peak_usb: fix clang build warning

2019-03-07 Thread Arnd Bergmann
On Thu, Mar 7, 2019 at 4:31 PM Nathan Chancellor wrote: > > On Thu, Mar 07, 2019 at 11:31:55AM +0100, Arnd Bergmann wrote: > > Clang points out undefined behavior when building the pcan_usb_pro driver: > > > > drivers/net/can/usb/peak_usb/pcan_usb_pro.c:136:15: error: passing an > > object that

Re: [PATCH v9 2/5] drm/sun4i: sun6i_mipi_dsi: Fix TCON DRQ set bits

2019-03-07 Thread Maxime Ripard
On Thu, Mar 07, 2019 at 05:49:07PM +0530, Jagan Teki wrote: > On Mon, Mar 4, 2019 at 9:13 PM Maxime Ripard > wrote: > > > > On Sun, Mar 03, 2019 at 11:05:24PM +0530, Jagan Teki wrote: > > > TCON DRQ for non-burst DSI mode can computed based on horizontal > > > front porch value, but the current

Re: [PATCH 1/2] ipmr: Make cache queue length configurable

2019-03-07 Thread Stephen Hemminger
On Thu, 7 Mar 2019 09:19:55 +1300 Brodie Greenfield wrote: > +ip_mr_cache_queue_length - INTEGER > + Limit the number of multicast packets we can have in the queue to be > + resolved. > + Bear in mind that when an unresolved multicast packet is received, > + there is an O(n)

Re: [PATCH] Avoid that check_shl_overflow() triggers a compiler warning when building with W=1

2019-03-07 Thread Leon Romanovsky
On Thu, Mar 07, 2019 at 06:53:54AM -0800, Bart Van Assche wrote: > On 3/6/19 11:24 PM, Leon Romanovsky wrote: > > My simple patch passes too :). > > Can you repost your patch? https://patchwork.kernel.org/patch/10841079/ As Rasmus wrote, the thing is to avoid a < 0 check. In my patch, I

Re: [PATCH RFC v2] mac80211: debugfs option to force TX status frames

2019-03-07 Thread Kalle Valo
Julius Niedworok writes: > At Technical University of Munich we use MAC 802.11 TX status frames to > perform several measurements in MAC 802.11 setups. > > With ath based drivers this was possible until commit d94a461d7a7df6 > ("ath9k: use ieee80211_tx_status_noskb where possible") as the driver

[PATCH] hwspinlock: stm32: implement the relax() ops

2019-03-07 Thread Fabien Dessenne
Implement this optional ops, called by hwspinlock core while spinning on a lock, between two successive invocations of trylock(). Signed-off-by: Fabien Dessenne --- drivers/hwspinlock/stm32_hwspinlock.c | 7 +++ 1 file changed, 7 insertions(+) diff --git

Re: next/master boot bisection: next-20190215 on beaglebone-black

2019-03-07 Thread Dan Williams
On Thu, Mar 7, 2019 at 1:17 AM Guillaume Tucker wrote: > > On 06/03/2019 14:05, Mike Rapoport wrote: > > On Wed, Mar 06, 2019 at 10:14:47AM +, Guillaume Tucker wrote: > >> On 01/03/2019 23:23, Dan Williams wrote: > >>> On Fri, Mar 1, 2019 at 1:05 PM Guillaume Tucker > >>> wrote: > >>> > >>>

Re: [PATCH] bcache: add cond_resched() in __bch_cache_cmp()

2019-03-07 Thread Vojtech Pavlik
On Thu, Mar 07, 2019 at 11:36:18PM +0800, Coly Li wrote: > On 2019/3/7 11:06 下午, Shile Zhang wrote: > > > > On 2019/3/7 18:34, Coly Li wrote: > >> On 2019/3/7 1:15 下午, shile.zh...@linux.alibaba.com wrote: > >>> From: Shile Zhang > >>> > >>> Read /sys/fs/bcache//cacheN/priority_stats can take

Re: [RFC PATCH V2 5/5] vhost: access vq metadata through kernel virtual address

2019-03-07 Thread Michael S. Tsirkin
On Wed, Mar 06, 2019 at 02:18:12AM -0500, Jason Wang wrote: > +static const struct mmu_notifier_ops vhost_mmu_notifier_ops = { > + .invalidate_range = vhost_invalidate_range, > +}; > + > void vhost_dev_init(struct vhost_dev *dev, > struct vhost_virtqueue **vqs, int nvqs, int

Re: [PATCH] enic: fix build warning without CONFIG_CPUMASK_OFFSTACK

2019-03-07 Thread Arnd Bergmann
On Thu, Mar 7, 2019 at 4:14 PM Nathan Chancellor wrote: > > A slightly less intrusive change would be using cpumask_available, which > was specifically introduced for this purpose in commit f7e30f01a9e2 > ("cpumask: Add helper cpumask_available()"). Ah nice, I wasn't aware of that function. I'll

[PATCH] [v2] enic: fix build warning without CONFIG_CPUMASK_OFFSTACK

2019-03-07 Thread Arnd Bergmann
The enic driver relies on the CONFIG_CPUMASK_OFFSTACK feature to dynamically allocate a struct member, but this is normally intended for local variables. Building with clang, I get a warning for a few locations that check the address of the cpumask_var_t:

[PULL 0/8] xtensa updates for v5.1

2019-03-07 Thread Max Filippov
/xtensa-20190307 for you to fetch changes up to 60deebe6149a3f02fa6a9fa988dda500effda43f: xtensa: simplify trap_init (2019-02-07 12:35:32 -0800) Xtensa updates for v5.1: - use generic spinlock/rwlock implementations - clean up IPI

[PATCH] drm/stm: fix CONFIG_FB dependency

2019-03-07 Thread Arnd Bergmann
The DRM_STM driver can be built independently of the framebuffer layer, but it causes a Kconfig warning: WARNING: unmet direct dependencies detected for FB_PROVIDE_GET_FB_UNMAPPED_AREA Depends on [n]: HAS_IOMEM [=y] && FB [=n] Selected by [y]: - DRM_STM [=y] && HAS_IOMEM [=y] && DRM [=y] &&

[PATCH] hwspinlock: ignore disabled device

2019-03-07 Thread Fabien Dessenne
Do not wait for hwspinlock device registration if it is not available for use. Signed-off-by: Fabien Dessenne --- drivers/hwspinlock/hwspinlock_core.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/hwspinlock/hwspinlock_core.c b/drivers/hwspinlock/hwspinlock_core.c index

Re: [PATCH] habanalabs: use %px instead of %p in error print

2019-03-07 Thread Kees Cook
On Wed, Mar 6, 2019 at 9:42 PM Oded Gabbay wrote: > > On Thu, Mar 7, 2019 at 5:46 AM Kees Cook wrote: > > > > On Sat, Mar 2, 2019 at 1:43 AM Oded Gabbay wrote: > > > > > > When parsing the address of an internal command buffer, the driver prints > > > an error if the buffer's address is not in

Re: [PATCH v9 2/5] drm/sun4i: sun6i_mipi_dsi: Fix TCON DRQ set bits

2019-03-07 Thread Jagan Teki
On Thu, Mar 7, 2019 at 9:09 PM Maxime Ripard wrote: > > On Thu, Mar 07, 2019 at 05:49:07PM +0530, Jagan Teki wrote: > > On Mon, Mar 4, 2019 at 9:13 PM Maxime Ripard > > wrote: > > > > > > On Sun, Mar 03, 2019 at 11:05:24PM +0530, Jagan Teki wrote: > > > > TCON DRQ for non-burst DSI mode can

[PATCH] [v3] spi: work around clang bug in SPI_BPW_RANGE_MASK()

2019-03-07 Thread Arnd Bergmann
Clang-8 evaluates both sides of a ?: expression to check for valid arithmetic even in the side that is never taken. This results in a build warning: drivers/spi/spi-sh-msiof.c:1052:24: error: shift count >= width of type [-Werror,-Wshift-count-overflow] .bits_per_word_mask =

Re: [PATCH v5 07/10] perf record: implement -z,--compression_level=n option and compression

2019-03-07 Thread Alexey Budankov
On 07.03.2019 18:26, Alexey Budankov wrote: > > On 07.03.2019 15:14, Jiri Olsa wrote: >> On Thu, Mar 07, 2019 at 11:39:46AM +0300, Alexey Budankov wrote: >>> >>> On 05.03.2019 15:25, Jiri Olsa wrote: On Fri, Mar 01, 2019 at 06:58:32PM +0300, Alexey Budankov wrote: SNIP >

Re: [PATCH] pblk: fix max_io calculation

2019-03-07 Thread Matias Bjørling
On 3/7/19 1:18 PM, Javier González wrote: When calculating the maximun I/O size allowed into the buffer, consider the write size (ws_opt) used by the write thread in order to cover the case in which, due to flushes, the mem and subm pointers are disaligned by (ws_opt - 1). This case currently

[PATCH 0/2] hwspinlock: add the 'in_atomic' API

2019-03-07 Thread Fabien Dessenne
In its current implementation, the hwspinlock framework relies on jiffies to handle the timeout of the hwspin_lock_timeout_xxx() API. In an atomic context (or more precisely when irq are disabled) jiffies does not increase, which prevents the timeout to reach its target value (infinite loop).

[PATCH 1/2] hwspinlock: document the hwspinlock 'raw' API

2019-03-07 Thread Fabien Dessenne
Document the hwspin_lock_timeout_raw(), hwspin_trylock_raw() and hwspin_unlock_raw() API. Signed-off-by: Fabien Dessenne --- Documentation/hwspinlock.txt | 42 ++ 1 file changed, 42 insertions(+) diff --git a/Documentation/hwspinlock.txt

[PATCH 2/2] hwspinlock: add the 'in_atomic' API

2019-03-07 Thread Fabien Dessenne
Add the 'in_atomic' mode which can be called from an atomic context. This mode relies on the existing 'raw' mode (no lock, no preemption/irq disabling) with the difference that the timeout is not based on jiffies (jiffies won't increase when irq are disabled) but handled with busy-waiting udelay()

Re: [PATCH] [v2] enic: fix build warning without CONFIG_CPUMASK_OFFSTACK

2019-03-07 Thread Nathan Chancellor
On Thu, Mar 07, 2019 at 04:52:24PM +0100, Arnd Bergmann wrote: > The enic driver relies on the CONFIG_CPUMASK_OFFSTACK feature to > dynamically allocate a struct member, but this is normally intended for > local variables. > > Building with clang, I get a warning for a few locations that check

Re: [PATCH] ethtool: reduce stack usage with clang

2019-03-07 Thread Arnd Bergmann
On Thu, Mar 7, 2019 at 11:06 AM Michal Kubecek wrote: > > On Thu, Mar 07, 2019 at 10:33:35AM +0100, Arnd Bergmann wrote: > > @@ -2533,7 +2535,7 @@ static int ethtool_set_fecparam(struct net_device > > *dev, void __user *useraddr) > > > > /* The main entry point in this file. Called from

Re: [PATCH 02/27] Add a SysRq option to lift kernel lockdown

2019-03-07 Thread David Howells
Matthew Garrett wrote: > + /* Ban synthetic events from some sysrq functionality */ > + if ((from == SYSRQ_FROM_PROC || from == SYSRQ_FROM_SYNTHETIC) && > + op_p->enable_mask & SYSRQ_DISABLE_USERSPACE) > + printk("This sysrq operation

Re: [PATCH] pblk: fix max_io calculation

2019-03-07 Thread Jens Axboe
On 3/7/19 8:57 AM, Matias Bjørling wrote: > On 3/7/19 1:18 PM, Javier González wrote: >> When calculating the maximun I/O size allowed into the buffer, consider >> the write size (ws_opt) used by the write thread in order to cover the >> case in which, due to flushes, the mem and subm pointers are

[PATCH] [v2] ethtool: reduce stack usage with clang

2019-03-07 Thread Arnd Bergmann
clang inlines the dev_ethtool() more aggressively than gcc does, leading to a larger amount of used stack space: net/core/ethtool.c:2536:24: error: stack frame size of 1216 bytes in function 'dev_ethtool' [-Werror,-Wframe-larger-than=] Marking the sub-functions that require the most stack space

Re: [PATCH] lockdep: avoid a clang warning

2019-03-07 Thread Bart Van Assche
On Thu, 2019-03-07 at 08:52 +0100, Arnd Bergmann wrote: > Clang warns about a tentative array definition without a length: > > kernel/locking/lockdep.c:845:12: error: tentative array definition assumed to > have one element [-Werror] > > There is no real reason to do this here, so just set the

Re: [PATCH] drm/i915/ddi: Fix default eDP detection on port A

2019-03-07 Thread Thomas Preston
On 07/03/2019 10:34, Jani Nikula wrote: There are dangers with default VBTs too. They might contain incorrect information about the specific board you have. You'll also have to set up the opregion, not just VBT. I'm afraid I can't help you there. You already know where to look to see how the

Re: [PATCH v9 3/5] drm/sun4i: sun6i_mipi_dsi: Support vblk timing for 4-lane devices

2019-03-07 Thread Jagan Teki
On Mon, Mar 4, 2019 at 9:19 PM Maxime Ripard wrote: > > On Sun, Mar 03, 2019 at 11:05:25PM +0530, Jagan Teki wrote: > > Like other dsi setup timings, or hblk for that matter vblk would > > also require compute the timings based payload equation along with > > packet overhead. > > > > But, on the

Re: [PATCH v2 RFC] x86/kvm/mmu: make mmu->prev_roots cache work for NPT case

2019-03-07 Thread Sean Christopherson
On Thu, Mar 07, 2019 at 03:07:05PM +0100, Vitaly Kuznetsov wrote: > Vitaly Kuznetsov writes: > > > Alternative patch: remove the filtering from kvm_mmu_get_page() and check > > for direct on call sites. cr4_pae setting in kvm_calc_mmu_role_common() > > can be preserved for consistency. > > > >

Re: [PATCH] [RFC] spi: pxa2xx: Do cs if restart the SSP during pxa2xx_spi_transfer_one()

2019-03-07 Thread Mark Brown
On Thu, Mar 07, 2019 at 05:26:53PM +0200, Jarkko Nikula wrote: > On 3/7/19 9:24 AM, xiao jin wrote: > > The patch is to do cs again if spi-pxa2xx restar the SSP during > > pxa2xx_spi_transfer_one() > Hmm.. please correct me if I'm wrong but pxa2xx_spi_unprepare_transfer() is > called always when

Re: [PATCH v5 1/9] clk: mediatek: Disable tuner_en before change PLL rate

2019-03-07 Thread Matthias Brugger
On 05/03/2019 06:05, Weiyi Lu wrote: > From: Owen Chen > > PLLs with tuner_en bit, such as APLL1, need to disable > tuner_en before apply new frequency settings, or the new frequency > settings (pcw) will not be applied. > The tuner_en bit will be disabled during changing PLL rate > and be

Re: [PATCH v5 00/18] mfd: demodularization of non-modular drivers

2019-03-07 Thread Tony Lindgren
* Pavel Machek [190307 08:35]: > > > > Pavel, I hope this more extended explanation makes sense to you, and > > > that you simply have not seen me write these same details in the past. > > > > Blimey. That's a really long winded way of saying: > > > > "Modular-ness is actually broken in

[PATCH] irqchip: stm32: don't set rising configuration registers at init

2019-03-07 Thread Fabien Dessenne
The rising configuration status register (rtsr) is not banked. As it is shared with the co-processor, it should not be written at probe time, else the co-processor configuration will be lost. Signed-off-by: Fabien Dessenne --- drivers/irqchip/irq-stm32-exti.c | 5 - 1 file changed, 5

Re: [PATCH] fs/select: avoid clang stack usage warning

2019-03-07 Thread Andi Kleen
On Thu, Mar 07, 2019 at 10:01:36AM +0100, Arnd Bergmann wrote: > The select() implementation is carefully tuned to put a sensible amount > of data on the stack for holding a copy of the user space fd_set, > but not too large to risk overflowing the kernel stack. > > When building a 32-bit kernel

Re: [RFC/RFT] HID: primax: Fix wireless keyboards descriptor

2019-03-07 Thread Nicolas Saenz Julienne
On Fri, 2019-03-01 at 10:48 +0100, Benjamin Tissoires wrote: > On Thu, Feb 28, 2019 at 7:01 PM Nicolas Saenz Julienne > wrote: > > On Thu, 2019-02-28 at 17:02 +, Junge, Terry wrote: > > > This could also be a parser error. In the HID specification section > > > 6.2.2.8 it > > > states that

[PATCH] net: stmmac: Avoid sometimes uninitialized Clang warnings

2019-03-07 Thread Nathan Chancellor
When building with -Wsometimes-uninitialized, Clang warns: drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:495:3: warning: variable 'ns' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:495:3: warning:

[PATCH] irqchip: stm32: add a second level init to request hwspinlock

2019-03-07 Thread Fabien Dessenne
Requesting hwspinlock, at the first time it is used, is not correct: indeed, at that moment we are under raw_spin_lock_irqsave() context and hwspin_lock_request_specific() may sleep ("BUG: sleeping function called from invalid context"). Requesting hwspinlock during the init

[GIT PULL for v5.1-rc1] media updates

2019-03-07 Thread Mauro Carvalho Chehab
Hi Linus, Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media media/v5.1-1 For: - Removal of sensor drivers that got converted from soc_camera; - Remaining soc_camera drivers got moved to staging; - Some documentation cleanups and improvements; - the imx

[PATCH BUGFIX IMPROVEMENT 0/8] block, bfq: fix bugs, reduce exec time and boost performance

2019-03-07 Thread Paolo Valente
Hi, since I didn't make it to submit these ones for 5.1, let me be early for 5.2 :) These patches fix some bug affecting performance, reduce execution time a little bit, and boost throughput and responsiveness. They are meant to be applied on top of the last series I submitted:

[PATCH BUGFIX IMPROVEMENT 3/8] block, bfq: tune service injection basing on request service times

2019-03-07 Thread Paolo Valente
The processes associated with a bfq_queue, say Q, may happen to generate their cumulative I/O at a lower rate than the rate at which the device could serve the same I/O. This is rather probable, e.g., if only one process is associated with Q and the device is an SSD. It results in Q becoming often

[PATCH BUGFIX IMPROVEMENT 2/8] block, bfq: do not idle for lowest-weight queues

2019-03-07 Thread Paolo Valente
In most cases, it is detrimental for throughput to plug I/O dispatch when the in-service bfq_queue becomes temporarily empty (plugging is performed to wait for the possible arrival, soon, of new I/O from the in-service queue). There is however a case where plugging is needed for service

[PATCH BUGFIX IMPROVEMENT 4/8] block, bfq: do not merge queues on flash storage with queueing

2019-03-07 Thread Paolo Valente
To boost throughput with a set of processes doing interleaved I/O (i.e., a set of processes whose individual I/O is random, but whose merged cumulative I/O is sequential), BFQ merges the queues associated with these processes, i.e., redirects the I/O of these processes into a common, shared queue.

<    2   3   4   5   6   7   8   9   10   11   >