Re: [PATCH] Staging: kpc2000: kpc_dma: resolve checkpath errors and warnings

2019-05-11 Thread Greg KH
On Sat, May 11, 2019 at 01:08:33AM +0530, Vandana BN wrote: > This patch resolves coding style errors and warnings reported by chechpatch > > ERROR: "(foo*)" should be "(foo *)" > ERROR: trailing whitespace > ERROR: space required before the open brace '{' > ERROR: "foo * bar" should be "foo

Re: [PATCH] vt: Fix a missing-check bug in drivers/tty/vt/vt.c file of Linux 5.0.14

2019-05-11 Thread Greg KH
On Sat, May 11, 2019 at 09:21:39AM +0800, Gen Zhang wrote: > On Fri, May 10, 2019 at 11:12:50PM +0800, Greg KH < > gre...@linuxfoundation.org> wrote: > >Still impossible to apply :( > > > >Also, what about Dave's response to you? This really can never be hit, > >like other early-init tty

Re: Linux v5.1.1

2019-05-11 Thread Bhaskar Chowdhury
"Dinner happened before I could get to them all :)" he he he he Greg! :) ROFL On 07:52 Sat 11 May , Greg Kroah-Hartman wrote: On Fri, May 10, 2019 at 09:47:14PM +0200, Sedat Dilek wrote: Hi Greg, I have seen that all other Linux-stable Git branches got a new release. What happened to

Re: kobject_init_and_add() confusion

2019-05-11 Thread Tobin C. Harding
On Fri, May 10, 2019, at 19:40, Petr Mladek wrote: > On Fri 2019-05-10 12:35:38, Tobin C. Harding wrote: > > On Wed, May 01, 2019 at 09:54:16AM +0200, Rafael J. Wysocki wrote: > > > On Wed, May 1, 2019 at 1:38 AM Tobin C. Harding wrote: > > > > TODO > > > > > > > > > > > > - Fix all the

Re: Linux 4.9.175

2019-05-11 Thread Greg KH
diff --git a/Makefile b/Makefile index f5836837df15..e52b0579e176 100644 --- a/Makefile +++ b/Makefile @@ -1,6 +1,6 @@ VERSION = 4 PATCHLEVEL = 9 -SUBLEVEL = 174 +SUBLEVEL = 175 EXTRAVERSION = NAME = Roaring Lionus diff --git a/arch/arm/boot/compressed/efi-header.S

Linux 4.9.175

2019-05-11 Thread Greg KH
I'm announcing the release of the 4.9.175 kernel. All users of the 4.9 kernel series must upgrade. The updated 4.9.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-4.9.y and can be browsed at the normal kernel.org git web browser:

Re: Linux 4.14.118

2019-05-11 Thread Greg KH
diff --git a/Makefile b/Makefile index efe716372985..a856457cab8f 100644 --- a/Makefile +++ b/Makefile @@ -1,7 +1,7 @@ # SPDX-License-Identifier: GPL-2.0 VERSION = 4 PATCHLEVEL = 14 -SUBLEVEL = 117 +SUBLEVEL = 118 EXTRAVERSION = NAME = Petit Gorille diff --git

Linux 4.19.42

2019-05-11 Thread Greg KH
I'm announcing the release of the 4.19.42 kernel. All users of the 4.19 kernel series must upgrade. The updated 4.19.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-4.19.y and can be browsed at the normal kernel.org git web

Linux 4.14.118

2019-05-11 Thread Greg KH
I'm announcing the release of the 4.14.118 kernel. All users of the 4.14 kernel series must upgrade. The updated 4.14.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-4.14.y and can be browsed at the normal kernel.org git web

Linux 5.0.15

2019-05-11 Thread Greg KH
I'm announcing the release of the 5.0.15 kernel. All users of the 5.0 kernel series must upgrade. The updated 5.0.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-5.0.y and can be browsed at the normal kernel.org git web browser:

Linux 5.1.1

2019-05-11 Thread Greg KH
I'm announcing the release of the 5.1.1 kernel. All users of the 5.1 kernel series must upgrade. The updated 5.1.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-5.1.y and can be browsed at the normal kernel.org git web browser:

Re: Linux 5.1.1

2019-05-11 Thread Greg KH
diff --git a/Makefile b/Makefile index 26c92f892d24..bf604f77e5e5 100644 --- a/Makefile +++ b/Makefile @@ -1,7 +1,7 @@ # SPDX-License-Identifier: GPL-2.0 VERSION = 5 PATCHLEVEL = 1 -SUBLEVEL = 0 +SUBLEVEL = 1 EXTRAVERSION = NAME = Shy Crocodile diff --git a/arch/arm64/include/asm/futex.h

Re: [PATCH V2 4/7] irqchip/irq-csky-mpintc: Add triger type and priority

2019-05-11 Thread Guo Ren
Thx Marc, On Fri, May 10, 2019 at 07:12:18PM +0100, Marc Zyngier wrote: > On Fri, 10 May 2019 09:25:10 +0100, > Guo Ren wrote: > > > > Thx Marc, > > > > Sorry for late reply: > > > > On Mon, Feb 18, 2019 at 02:38:23PM +, Marc Zyngier wrote: > > > On Mon, 18 Feb 2019 10:04:40 +0800 > > >

Re: Linux 5.1.1

2019-05-11 Thread Bhaskar Chowdhury
Thanks, a bunch Greg! :) On 08:50 Sat 11 May , Greg KH wrote: I'm announcing the release of the 5.1.1 kernel. All users of the 5.1 kernel series must upgrade. The updated 5.1.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-5.1.y

Re: [PATCH] nvme/pci: Use host managed power state for suspend

2019-05-11 Thread Christoph Hellwig
A couple nitpicks, mostly leftover from the previous iteration (I didn't see replies to those comments from you, despite seeing a reply to my mail, assuming it didn't get lost): > +int nvme_set_power(struct nvme_ctrl *ctrl, unsigned ps) > +{ > + return nvme_set_features(ctrl,

Re: [PATCH] perf: Remove duplicate headers

2019-05-11 Thread Souptick Joarder
On Tue, Apr 16, 2019 at 5:27 PM Souptick Joarder wrote: > > On Sun, Apr 7, 2019 at 12:20 AM Mukesh Ojha wrote: > > > > > > On 4/6/2019 7:06 PM, Souptick Joarder wrote: > > > Removed duplicate headers which are included twice. > > > Signed-off-by: Souptick Joarder > > Reviewed-by: Mukesh Ojha >

Re: [PATCH] arm64: dts: qcom: qcs404: Update memory map to v3

2019-05-11 Thread Vinod Koul
On 06-03-19, 09:51, Bjorn Andersson wrote: > Update the reserved-memory map to version 3, to adjust to changes in the > remoteprocs. Reviewed-by: Vinod Koul -- ~Vinod

Re: [PATCH] staging: wlan-ng: collect return status without variable

2019-05-11 Thread Hariprasad Kelam
On Fri, May 10, 2019 at 09:40:11PM +0300, Dan Carpenter wrote: > On Fri, May 10, 2019 at 10:53:08PM +0530, Hariprasad Kelam wrote: > > On Fri, May 10, 2019 at 01:57:54PM +0300, Dan Carpenter wrote: > > > On Fri, May 10, 2019 at 08:09:00AM +0530, Hariprasad Kelam wrote: > > > > diff --git

Re: Linux v5.1.1

2019-05-11 Thread Sedat Dilek
On Sat, May 11, 2019 at 7:52 AM Greg Kroah-Hartman wrote: > > On Fri, May 10, 2019 at 09:47:14PM +0200, Sedat Dilek wrote: > > Hi Greg, > > > > I have seen that all other Linux-stable Git branches got a new release. > > > > What happened to Linux-stable-5.1.y and v5.1.1 release? > > Dinner

Re: [PATCH] mm: Change count_mm_mlocked_page_nr return type

2019-05-11 Thread Souptick Joarder
On Mon, Apr 22, 2019 at 4:08 PM Weikang shi wrote: > > From: swkhack > > In 64-bit machine,the value of "vma->vm_end - vma->vm_start" > maybe negative in 32bit int and the "count >> PAGE_SHIFT"'s rusult s/rusult/result. > will be wrong.So change the local variable and return > value to

Re: [PATCH] spi: TI power management: add missing of table registration

2019-05-11 Thread Daniel G
On Wed, May 8, 2019 at 12:27 PM Lee Jones wrote: > > The subject line is not correct. This is an MFD driver. > > When submitting you should follow the convention for the subsystem you > are patching against. The following command is helpful: > > `git log --oneline -- ` > > I will fix it for

Re: [PATCH v2 1/2] fs: make all new mount api fds cloexec by default

2019-05-11 Thread David Howells
Christian Brauner wrote: > This makes all file descriptors returned from new syscalls of the new mount > api cloexec by default. > > From a userspace perspective it is rarely the case that fds are supposed to > be inherited across exec. Having them not cloexec by default forces > userspace to

Re: [PATCH v2 2/2] fsopen: use square brackets around "fscontext"

2019-05-11 Thread David Howells
Christian Brauner wrote: > Make the name of the anon inode fd "[fscontext]" instead of "fscontext". > This is minor but most core-kernel anon inode fds already carry square > brackets around their name: > > [eventfd] > [eventpoll] > [fanotify] > [io_uring] > [pidfd] > [signalfd] > [timerfd] >

[GIT PULL] GPIO bulk changes for v5.2

2019-05-11 Thread Linus Walleij
Hi Linus, here is the big pull request for GPIO for v5.2. A bit later than usual because I was ironing out my own mistakes. I'm holding some stuff back for the next kernel as a result, and this should be a healthy and well tested batch. I merged in v5.1-rc3 at one point to get rid of some nasty

[PATCH] power: supply: olpc_battery: force the le/be casts

2019-05-11 Thread Lubomir Rintel
The endianness of data returned from the EC depends on the particular EC version determined at run time. Cast from little/big endian explicitey in the routine that flips endianness to the native one to make sparse happy. Signed-off-by: Lubomir Rintel Reported-by: kbuild test robot Fixes:

Re: [PATCH] iio: dummy_evgen: check iio_evgen in iio_dummy_evgen_free()

2019-05-11 Thread Jonathan Cameron
On Thu, 9 May 2019 10:04:47 +0800 Kefeng Wang wrote: > if iio_dummy_evgen_create() fails, iio_evgen should be NULL, when call > iio_evgen_release() to cleanup, it throws some warning and could cause > double free. > > Reported-by: Hulk Robot > Signed-off-by: Kefeng Wang Hi Kefeng, I'm not

Re: [PATCH v2 1/3] iio: Add driver for Infineon DPS310

2019-05-11 Thread Jonathan Cameron
On Wed, 8 May 2019 14:35:26 -0500 Eddie James wrote: > From: Joel Stanley > > The DPS310 is a temperature and pressure sensor. It can be accessed over > i2c and SPI. > > Signed-off-by: Eddie James Hi Eddie, Ideally we'll get a sign off form Joel as well on this. A few comments inline. I

[PATCH] nfs/dns_resolve.c: Move redundant headers to the top

2019-05-11 Thread Bharath Vedartham
NFS uses either the kernel's DNS service or its own depending on whether CONFIG_NFS_USE_KERNEL_DNS is enabled or not. 4 header files which are: (i) #include (ii) #include (iii) #include (iv) #include "dns_resolve.h" These 4 header files are used regardless of whether CONFIG_NFS_USE_KERNEL_DNS

Re: [PATCH v2 3/3] iio: dps310: Add pressure sensing capability

2019-05-11 Thread Jonathan Cameron
On Wed, 8 May 2019 14:35:28 -0500 Eddie James wrote: > The DPS310 supports measurement of pressure, so support that in the > driver. Use background measurement like the temperature sensing and > default to lowest precision and lowest measurement rate. > > Signed-off-by: Eddie James Hi Eddie,

[Patch v2] drivers: staging : wlan-ng : collect return status without variable

2019-05-11 Thread Hariprasad Kelam
As caller rdev_set_default_key not particular about -EFAULT. We can preserve the return value of prism2_domibset_uint32. Signed-off-by: Hariprasad Kelam - Changes in v2: - remove masking of original return value with EFAULT --- drivers/staging/wlan-ng/cfg80211.c | 9 +++-- 1 file

Re: [PATCH 1/3] iio: Add driver for Infineon DPS310

2019-05-11 Thread Jonathan Cameron
On Tue, 7 May 2019 11:01:36 -0500 Eddie James wrote: > On 5/6/19 4:18 PM, Peter Meerwald-Stadler wrote: > > On Mon, 6 May 2019, Eddie James wrote: > > > >> From: Joel Stanley > > some comments below > > > Thanks for the quick review! Will get these in for v2, I did have a > couple of

[PATCH v3 0/2] media: v4l2-subdev: Verify arguments of v4l2_subdev_call()

2019-05-11 Thread Janusz Krzysztofik
Correctness of format type (try or active) and pad number parameters passed to subdevice operation callbacks is now verified only for IOCTL calls. However, those callbacks are also used by drivers, e.g., V4L2 host interfaces. Since both subdev_do_ioctl() and drivers are using

[PATCH v3 1/2] media: v4l2-subdev: Verify arguments of v4l2_subdev_call()

2019-05-11 Thread Janusz Krzysztofik
Correctness of format type (try or active) and pad number parameters passed to subdevice operation callbacks is now verified only for IOCTL calls. However, those callbacks are also used by drivers, e.g., V4L2 host interfaces. Since both subdev_do_ioctl() and drivers are using v4l2_subdev_call()

[PATCH v3 2/2] media: v4l2-subdev: Verify pad config argument

2019-05-11 Thread Janusz Krzysztofik
Extend parameter checks performed by v4l2_subdev_call() with a check for a non-NULL pad config pointer if V4L2_SUBDEV_FORMAT_TRY format type is requested so drivers don't need to care. Signed-off-by: Janusz Krzysztofik --- drivers/media/v4l2-core/v4l2-subdev.c | 30 +++

Re: [PATCH 1/5] iio: stmpe-adc: Add compatible name

2019-05-11 Thread Jonathan Cameron
On Tue, 7 May 2019 16:36:11 +0200 Philippe Schenker wrote: > From: Philippe Schenker > > Add the compatible name to the driver so it gets loaded when the proper > node in DT is detected. > > Signed-off-by: Philippe Schenker Applied thanks, Jonathan > --- > > drivers/iio/adc/stmpe-adc.c

[PATCH v2] mfd: madera: Add missing of table registration

2019-05-11 Thread Daniel Gomez
MODULE_DEVICE_TABLE(of, should be called to complete DT OF mathing mechanism and register it. Before this patch: modinfo ./drivers/mfd/madera.ko | grep alias After this patch: modinfo ./drivers/mfd/madera.ko | grep alias alias: of:N*T*Ccirrus,wm1840C* alias:

[PATCH v4 0/3] add support for is25wp256 spi-nor device.

2019-05-11 Thread Sagar Shrikant Kadam
The patch set is tested on HiFive Unleashed board and is based on mainline kernel v5.1. Its intended to add support for 32 MB spi-nor flash mounted on the board. Memory Device supports 4/32/and 64 KB sectors size. The device id table is updated accordingly. Flash parameter table for ISSI device

[PATCH v4 1/3] mtd: spi-nor: add support for is25wp256

2019-05-11 Thread Sagar Shrikant Kadam
Update spi_nor_id table for is25wp256 (32MB)device from ISSI, present on HiFive Unleashed dev board (Rev: A00). Set method to enable quad mode for ISSI device in flash parameters table. Based on code originally written by Wesley Terpstra and/or Palmer Dabbelt

[PATCH v4 3/3] mtd: spi-nor: add locking support for is25xxxxx device

2019-05-11 Thread Sagar Shrikant Kadam
Implement a locking scheme for ISSI devices based on stm_lock mechanism. The is25x devices have 4 bits for selecting the range of blocks to be locked/protected from erase/write operations and function register gives feasibility to select TOP / Bottom area for protection. The current

Re: [PATCH 2/5] iio: stmpe-adc: Reinit completion struct on begin conversion

2019-05-11 Thread Jonathan Cameron
On Tue, 7 May 2019 16:36:12 +0200 Philippe Schenker wrote: > From: Philippe Schenker > > In some cases, the wait_completion got interrupted. This caused the > error-handling to mutex_unlock the function. The before turned on > interrupt then got called anyway. In the ISR then completion() was

[PATCH v4 2/3] mtd: spi-nor: add support to unlock flash device.

2019-05-11 Thread Sagar Shrikant Kadam
Nor device (is25wp256 mounted on HiFive unleashed Rev A00 board) from ISSI have memory blocks guarded by block protection bits BP[0,1,2,3]. Clearing block protection bits,unlocks the flash memory regions The unlock scheme is registered during nor scans. Based on code developed by Wesley Terpstra

Re: [PATCH 3/5] iio: stmpe-adc: Enable all stmpe-adc interrupts just once

2019-05-11 Thread Jonathan Cameron
On Tue, 7 May 2019 16:36:13 +0200 Philippe Schenker wrote: > From: Philippe Schenker > > This commit will enable the interrupts of all channels handled by this > driver only once in the probe function. > > This will improve performance because one byte less has to be written over > i2c on

[PATCH v4 1/2] media: v4l2-subdev: Verify arguments of v4l2_subdev_call()

2019-05-11 Thread Janusz Krzysztofik
Correctness of format type (try or active) and pad number parameters passed to subdevice operation callbacks is now verified only for IOCTL calls. However, those callbacks are also used by drivers, e.g., V4L2 host interfaces. Since both subdev_do_ioctl() and drivers are using v4l2_subdev_call()

[PATCH v4 2/2] media: v4l2-subdev: Verify pad config argument

2019-05-11 Thread Janusz Krzysztofik
Extend parameter checks performed by v4l2_subdev_call() with a check for a non-NULL pad config pointer if V4L2_SUBDEV_FORMAT_TRY format type is requested so drivers don't need to care. Signed-off-by: Janusz Krzysztofik --- drivers/media/v4l2-core/v4l2-subdev.c | 30 +++

[PATCH v4 0/2] media: v4l2-subdev: Verify arguments of v4l2_subdev_call()

2019-05-11 Thread Janusz Krzysztofik
Correctness of format type (try or active) and pad number parameters passed to subdevice operation callbacks is now verified only for IOCTL calls. However, those callbacks are also used by drivers, e.g., V4L2 host interfaces. Since both subdev_do_ioctl() and drivers are using

Re: [PATCH 4/5] iio: stmpe-adc: Use wait_for_completion_timeout

2019-05-11 Thread Jonathan Cameron
On Tue, 7 May 2019 16:36:14 +0200 Philippe Schenker wrote: > From: Philippe Schenker > > Use wait_for_completion_timeout instead of > wait_for_completion_interuptible_timeout. > > The interruptible variant gets constantly interrupted if a user > program is compiled with the -pg option. > The

Re: [PATCH 5/5] iio: stmpe-adc: Reset possible interrupts

2019-05-11 Thread Jonathan Cameron
On Tue, 7 May 2019 16:36:15 +0200 Philippe Schenker wrote: > From: Philippe Schenker > > Clear any interrupt that still is on the device on every channel > this driver is activated for in probe and specific channels in > the timeout handler. > > Signed-off-by: Philippe Schenker I'm never

Re: [RFC v2] iio: input-bridge: optionally bridge iio acceleometers to create a /dev/input interface

2019-05-11 Thread Jonathan Cameron
On Thu, 9 May 2019 11:09:26 +0200 "H. Nikolaus Schaller" wrote: > Hi Jonathan, > sorry for the delayed response, but I have to focus on other topics now. No worries. I have the same 'problem'! Hence nothing yet from my side on an alternative. > > Just some small comments came to my mind to

Re: [PATCH] m68k: io: Fix io{read,write}{16,32}be() for Coldfire peripherals

2019-05-11 Thread Angelo Dureghello
Hi, On Mon, Apr 29, 2019 at 02:39:47PM +0200, Arnd Bergmann wrote: > On Mon, Apr 29, 2019 at 10:19 AM Geert Uytterhoeven > wrote: > > > > The generic definitions of mmio_{read,write}{16,32}be() in lib/iomap.c > > assume that the {read,write}[wl]() I/O accessors always use little > > endian

Re: [Letux-kernel] [RFC v2] iio: input-bridge: optionally bridge iio acceleometers to create a /dev/input interface

2019-05-11 Thread Jonathan Cameron
On Thu, 9 May 2019 19:02:49 +0200 "H. Nikolaus Schaller" wrote: > > Am 09.05.2019 um 11:09 schrieb H. Nikolaus Schaller : > > > > Hi Jonathan, > >> > >> > >> And how does that work on the common case of a sensor in the lid of a > >> laptop? > >> how do you know what angle the screen is at?

Re: [PATCH 4.19 00/66] 4.19.42-stable review

2019-05-11 Thread Pavel Machek
Hi! > This is the start of the stable review cycle for the 4.19.42 release. > There are 66 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Responses should be made by Sat 11 May 2019 06:11:18 PM

Re: [PATCH 1/2] iio: dac: ds4422/ds4424 drop of_node check

2019-05-11 Thread Jonathan Cameron
On Sun, 5 May 2019 12:24:36 -0700 Ruslan Babayev wrote: > The driver doesn't actually rely on any DT properties. Removing this > check makes it usable on ACPI based platforms. > > Signed-off-by: Ruslan Babayev > Cc: xe-linux-exter...@cisco.com Applied to the togreg branch of iio.git and

ext3/ext4 filesystem corruption under post 5.1.0 kernels

2019-05-11 Thread Arthur Marsh
I have yet to bisect, but have had trouble with recent, post 5.1.0 kernels built from Linus' git head on both i386 (Pentium 4 pc) and amd64 (Athlon II X4 640). The easiest way to trigger the problem is: git gc on the kernel source tree, although the problem can occur without doing a git gc.

Re: [PATCH 2/2] iio: dac: ds4422/ds4424 fix chip verification

2019-05-11 Thread Jonathan Cameron
On Sun, 5 May 2019 12:24:37 -0700 Ruslan Babayev wrote: > The ds4424_get_value function takes channel number as it's 3rd > argument and translates it internally into I2C address using > DS4424_DAC_ADDR macro. The caller ds4424_verify_chip was passing an > already translated I2C address as its

[PATCH] afs: remove redundant assignment to variable ret

2019-05-11 Thread Colin King
From: Colin Ian King The variable ret is being assigned a value however this is never read and later it is being reassigned to a new value. The assignment is redundant and hence can be removed. Addresses-Coverity: ("Unused Value") Signed-off-by: Colin Ian King --- fs/afs/xattr.c | 1 - 1 file

[PATCH] x86: Hide the int3_emulate_call/jmp functions from UML

2019-05-11 Thread Steven Rostedt
From: "Steven Rostedt (VMware)" User Mode Linux does not have access to the ip or sp fields of the pt_regs, and accessing them causes UML to fail to build. Hide the int3_emulate_jmp() and int3_emulate_call() instructions from UML, as it doesn't need them anyway. Reported-by: kbuild test robot

Re: ext3/ext4 filesystem corruption under post 5.1.0 kernels

2019-05-11 Thread Richard Weinberger
[CC'in linux-ext4] On Sat, May 11, 2019 at 1:47 PM Arthur Marsh wrote: > > I have yet to bisect, but have had trouble with recent, post 5.1.0 kernels > built from Linus' git head on both i386 (Pentium 4 pc) and amd64 (Athlon II > X4 640). > > The easiest way to trigger the problem is: > > git

Re: [RESEND PATCH 4/4] um: irq: don't set the chip for all irqs

2019-05-11 Thread Bartosz Golaszewski
pt., 10 maj 2019 o 18:22 Anton Ivanov napisał(a): > > > On 10/05/2019 17:20, Bartosz Golaszewski wrote: > > pt., 10 maj 2019 o 11:16 Bartosz Golaszewski napisał(a): > >> śr., 8 maj 2019 o 09:13 Richard Weinberger napisał(a): > >>> - Ursprüngliche Mail - > > Can you please check? >

[PATCH] sched: remove redundant assignment to variable utime

2019-05-11 Thread Colin King
From: Colin Ian King The variable utime is being assigned a value however this is never read and later it is being reassigned to a new value. The assignment is redundant and hence can be removed. Addresses-Coverity: ("Unused Value") Signed-off-by: Colin Ian King --- kernel/sched/cputime.c | 4

[PATCH] orangefs: remove redundant assignment to variable buffer_index

2019-05-11 Thread Colin King
From: Colin Ian King The variable buffer_index is being initialized however this is never read and later it is being reassigned to a new value. The initialization is redundant and hence can be removed. Addresses-Coverity: ("Unused Value") Signed-off-by: Colin Ian King --- fs/orangefs/file.c |

[RFC] irqchip/gic-its: fix command queue pointer comparison bug

2019-05-11 Thread Heyi Guo
When we run several VMs with PCI passthrough and GICv4 enabled, not pinning vCPUs, we will occasionally see below warnings in dmesg: ITS queue timeout (65440 65504 480) ITS cmd its_build_vmovp_cmd failed The reason for the above issue is that in BUILD_SINGLE_CMD_FUNC: 1. Post the write command.

[PATCH] ARM: Remove duplicate header

2019-05-11 Thread Sabyasachi Gupta
Remove linux/tty.h which is included more than once Signed-off-by: Sabyasachi Gupta --- arch/arm/mach-sa1100/hackkit.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/mach-sa1100/hackkit.c b/arch/arm/mach-sa1100/hackkit.c index 643d5f2..0016d25 100644 ---

[PATCH] staging: vc04_services: bcm2835-camera: remove redundant assignment to variable ret

2019-05-11 Thread Colin King
From: Colin Ian King The variable ret is being initialized however this is never read and later it is being reassigned to a new value. The initialization is redundant and hence can be removed. Addresses-Coverity: ("Unused Value") Signed-off-by: Colin Ian King ---

Re: [GIT PULL] security subsystem: Tomoyo updates for v5.2

2019-05-11 Thread Linus Torvalds
On Fri, May 10, 2019 at 6:09 PM James Morris wrote: > > These patches include fixes to enable fuzz testing, and a fix for > calculating whether a filesystem is user-modifiable. So now these have been very recently rebased (on top of a random merge-window "tree of the day" version) instead of

Re: [PULL 0/7] xtensa updates for v5.2

2019-05-11 Thread pr-tracker-bot
The pull request you sent on Fri, 10 May 2019 12:41:02 -0700: > git://github.com/jcmvbkbc/linux-xtensa.git tags/xtensa-20190510 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/7a5575212ce4b6a41581b92fe03b6be1134793ba Thank you! -- Deet-doot-dot, I am a bot.

Re: [GIT PULL] VFIO updates for v5.2-rc1

2019-05-11 Thread pr-tracker-bot
The pull request you sent on Fri, 10 May 2019 15:50:57 -0600: > git://github.com/awilliam/linux-vfio.git tags/vfio-v5.2-rc1 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/6fe567df04a27468b306ae5c53fa7a1cd3acc5e1 Thank you! -- Deet-doot-dot, I am a bot.

Re: [GIT PULL] GPIO bulk changes for v5.2

2019-05-11 Thread pr-tracker-bot
The pull request you sent on Sat, 11 May 2019 10:45:05 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git > tags/gpio-v5.2-1 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/8148c17b179d8acad190551fe0fb90d8f5193990 Thank you! --

Re: [GIT PULL] security subsystem: Tomoyo updates for v5.2

2019-05-11 Thread pr-tracker-bot
The pull request you sent on Sat, 11 May 2019 08:09:22 +1000 (AEST): > git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git > next-tomoyo2 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/c367dc8d0dd2a1e1ed9fdc2dd831053bdfdf0968 Thank you! --

[PATCH v4] ASoC: tlv320aic3x: Add support for high power analog output

2019-05-11 Thread Saravanan Sekar
Add support to output level control for the analog high power output drivers HPOUT and HPCOM. Signed-off-by: Saravanan Sekar --- Notes: Notes: Changes in V4: -Added separate mono playback volume control -grouped volume controls with corresponding switch

Re: [PATCH] afs: remove redundant assignment to variable ret

2019-05-11 Thread Joe Perches
On Sat, 2019-05-11 at 13:36 +0100, Colin King wrote: > The variable ret is being assigned a value however this is never > read and later it is being reassigned to a new value. The assignment > is redundant and hence can be removed. [] > diff --git a/fs/afs/xattr.c b/fs/afs/xattr.c [] > @@ -71,7

Re: [PATCH v8 1/3] arm64: dts: fsl: librem5: Add a device tree for the Librem5 devkit

2019-05-11 Thread Fabio Estevam
Hi Angus, This looks good. Only minor issues: On Wed, May 1, 2019 at 7:57 PM Angus Ainslie (Purism) wrote: > +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts > @@ -0,0 +1,823 @@ > +/* SPDX-License-Identifier: GPL-2.0+ This should be // SPDX-License-Identifier: GPL-2.0+ as pointed

Re: [PATCH 5/5] arm64: dts: meson: sei510: add network support

2019-05-11 Thread Jerome Brunet
On Fri, 2019-05-10 at 15:45 -0700, Kevin Hilman wrote: > Jerome Brunet writes: > > > Enable the network interface of the SEI510 which use the internal PHY. > > > > Signed-off-by: Jerome Brunet > > I tried testing this series on SEI510, but I must still be missing some > defconfig options, as

Re: [PATCH 1/2] arm64: dts: meson: sei510: consistently order nodes

2019-05-11 Thread Jerome Brunet
On Fri, 2019-05-10 at 14:43 -0700, Kevin Hilman wrote: > minor nit: I kind of like "aliases" and "chosen" at the top since they > are kind of special nodes, but honestly, I can't think of a really good > reason other than personal preference, so keeping things sorted as > you've done here is

Re: [PATCH v6 5/6] binfmt_*: scope path resolution of interpreters

2019-05-11 Thread Aleksa Sarai
On 2019-05-11, Christian Brauner wrote: > > In my opinion, the problems here are: > > > > - Apparently some people run untrusted containers without user > >namespaces. It would be really nice if people could not do that. > >(Probably the biggest problem here.) > > I know I sound like a

Charity Gift !!!

2019-05-11 Thread Mr Mikhail M. Fridman
-- I, Mikhail Fridman have selected you specifically as one of my beneficiaries for my Charitable Donation of $5 Million Dollars, Check the link below for confirmation: https://www.rt.com/business/343781-mikhail-fridman-will-charity/ I await your earliest response. Best Regards, Mikhail

Re: [PATCH v5 1/6] dt-bindings: pinctrl: add a 'drive-strength-microamp' property

2019-05-11 Thread Martin Blumenstingl
On Fri, May 10, 2019 at 10:23 AM Guillaume La Roque wrote: > > This property allow drive-strength parameter in uA instead of mA. > > Signed-off-by: Guillaume La Roque Reviewed-by: Martin Blumenstingl

Re: [PATCH v5 3/6] dt-bindings: pinctrl: meson: Add drive-strength-microamp property

2019-05-11 Thread Martin Blumenstingl
On Fri, May 10, 2019 at 10:23 AM Guillaume La Roque wrote: > > Add optional drive-strength-microamp property > > Signed-off-by: Guillaume La Roque Reviewed-by: Martin Blumenstingl

Re: [PATCH v5 4/6] pinctrl: meson: Rework enable/disable bias part

2019-05-11 Thread Martin Blumenstingl
On Fri, May 10, 2019 at 10:23 AM Guillaume La Roque wrote: > > rework bias enable/disable part to prepare drive-strength integration > no functional changes > > Signed-off-by: Guillaume La Roque Reviewed-by: Martin Blumenstingl no problems spotted while boot-testing on one of my Meson8m2

Re: [PATCH v5 6/6] pinctrl: meson: g12a: add DS bank value

2019-05-11 Thread Martin Blumenstingl
On Fri, May 10, 2019 at 10:23 AM Guillaume La Roque wrote: > > add drive-strength bank regiter and bit value for G12A SoC > > Signed-off-by: Guillaume La Roque Reviewed-by: Martin Blumenstingl

Re: [PATCH v3 0/8] Allwinner H6 Mali GPU support

2019-05-11 Thread Clément Péron
Hi Maxime, Is this series ok for you ? Thanks, Clement On Wed, 17 Apr 2019 at 19:30, Clément Péron wrote: > > Hi, > > The Allwinner H6 has a Mali-T720 MP2. The drivers are > out-of-tree so this series only introduce the dt-bindings. > > The first patch is from Neil Amstrong and has been

Re: [PATCH v5 5/6] pinctrl: meson: add support of drive-strength-microamp

2019-05-11 Thread Martin Blumenstingl
Hi Guillaume, On Fri, May 10, 2019 at 10:23 AM Guillaume La Roque wrote: > > drive-strength-microamp is a new feature needed for G12A SoC. > the default DS setting after boot is usually 500uA and it is not enough for > many functions. We need to be able to set the drive strength to reliably >

Re: [PATCH 3/5] arm64: dts: meson: g12a: add mdio multiplexer

2019-05-11 Thread Martin Blumenstingl
Hi Jerome, On Fri, May 10, 2019 at 6:49 PM Jerome Brunet wrote: > > Add the g12a mdio multiplexer which allows to connect to either > an external phy through the SoC pins or the internal 10/100 phy > > Signed-off-by: Jerome Brunet > --- > arch/arm64/boot/dts/amlogic/meson-g12a.dtsi | 32

Re: [PATCH v6 5/6] binfmt_*: scope path resolution of interpreters

2019-05-11 Thread Andy Lutomirski
> On May 10, 2019, at 3:55 PM, Jann Horn wrote: > >> On Fri, May 10, 2019 at 02:20:23PM -0700, Andy Lutomirski wrote: >>> On Fri, May 10, 2019 at 1:41 PM Jann Horn wrote: >>> On Tue, May 07, 2019 at 05:17:35AM +1000, Aleksa Sarai wrote: > On 2019-05-06, Jann Horn wrote: > In

Re: [PATCH 2/5] arm64: dts: meson: g12a: add ethernet pinctrl definitions

2019-05-11 Thread Martin Blumenstingl
Hi Jerome, On Fri, May 10, 2019 at 6:49 PM Jerome Brunet wrote: > > Add the ethernet pinctrl settings for RMII, RGMII and internal phy leds > > Signed-off-by: Jerome Brunet > --- > arch/arm64/boot/dts/amlogic/meson-g12a.dtsi | 37 + > 1 file changed, 37 insertions(+) > >

[PATCH] irqchip: ingenic: Drop dependency on MACH_INGENIC, use COMPILE_TEST

2019-05-11 Thread Paul Cercueil
Depending on MACH_INGENIC prevent us from creating a generic kernel that works on more than one MIPS board. Instead, we just depend on MIPS being set. On other architectures, this driver can still be built, thanks to COMPILE_TEST. This is used by automated tools to find bugs, for instance.

Re: [PATCH 5/5] arm64: dts: meson: sei510: add network support

2019-05-11 Thread Martin Blumenstingl
Hi Kevin, On Sat, May 11, 2019 at 12:45 AM Kevin Hilman wrote: > > Jerome Brunet writes: > > > Enable the network interface of the SEI510 which use the internal PHY. > > > > Signed-off-by: Jerome Brunet > > I tried testing this series on SEI510, but I must still be missing some > defconfig

Re: [PATCH v2] jbd2: fix potential double free

2019-05-11 Thread Theodore Ts'o
On Fri, May 10, 2019 at 06:36:48PM +0800, Chengguang Xu wrote: > When fail from creating cache jbd2_inode_cache, we will > destroy previously created cache jbd2_handle_cache twice. > This patch fixes it by sperating each cache > initialization/destruction to individual function. > >

Re: [PATCH v2] ext4: fix use-after-free in dx_release()

2019-05-11 Thread Theodore Ts'o
On Wed, May 08, 2019 at 02:04:03PM +0530, Sahitya Tummala wrote: > The buffer_head (frames[0].bh) and it's corresping page can be > potentially free'd once brelse() is done inside the for loop > but before the for loop exits in dx_release(). It can be free'd > in another context, when the page

Re: [PATCH][next] ext4: fix two cases where a u32 is being checked for a less than zero error return

2019-05-11 Thread Theodore Ts'o
On Fri, Apr 26, 2019 at 11:09:08PM +0100, Colin King wrote: > From: Colin Ian King > > There are two cases where u32 variables n and err are being checked > for less than zero error values, the checks is always false because > the variables are not signed. Fix this by making the variables ints.

Re: [PATCH v6 5/6] binfmt_*: scope path resolution of interpreters

2019-05-11 Thread Aleksa Sarai
On 2019-05-11, Andy Lutomirski wrote: > >> I've lost track of the context here, but it seems to me that > >> mitigating attacks involving accidental following of /proc links > >> shouldn't depend on dumpability. What's the actual problem this is > >> trying to solve again? > > > > The one

Re: [PATCH 2/5] arm64: dts: meson: g12a: add ethernet pinctrl definitions

2019-05-11 Thread Jerome Brunet
On Sat, 2019-05-11 at 19:06 +0200, Martin Blumenstingl wrote: > Hi Jerome, > > On Fri, May 10, 2019 at 6:49 PM Jerome Brunet wrote: > > Add the ethernet pinctrl settings for RMII, RGMII and internal phy leds > > > > Signed-off-by: Jerome Brunet > > --- > >

Re: [PATCH v6 5/6] binfmt_*: scope path resolution of interpreters

2019-05-11 Thread Linus Torvalds
On Sat, May 11, 2019 at 1:00 PM Andy Lutomirski wrote: > > A better “spawn” API should fix this. Andy, stop with the "spawn would be better". Spawn is garbage. It's garbage because it's fundamentally too inflexible, and it's garbage because it is quite complex to try to work around the

Re: [PATCH 5/5] arm64: dts: meson: sei510: add network support

2019-05-11 Thread Jerome Brunet
On Sat, 2019-05-11 at 19:16 +0200, Martin Blumenstingl wrote: > Hi Kevin, > > On Sat, May 11, 2019 at 12:45 AM Kevin Hilman wrote: > > Jerome Brunet writes: > > > > > Enable the network interface of the SEI510 which use the internal PHY. > > > > > > Signed-off-by: Jerome Brunet > > > > I

Re: [PATCH v6 5/6] binfmt_*: scope path resolution of interpreters

2019-05-11 Thread Aleksa Sarai
On 2019-05-11, Linus Torvalds wrote: > On Sat, May 11, 2019 at 1:21 PM Linus Torvalds > wrote: > > > > Notice? None of the real problems are about execve or would be solved > > by any spawn API. You just think that because you've apparently been > > talking to too many MS people that think fork

Re: [PATCH v6 5/6] binfmt_*: scope path resolution of interpreters

2019-05-11 Thread Linus Torvalds
On Sat, May 11, 2019 at 1:21 PM Linus Torvalds wrote: > > Notice? None of the real problems are about execve or would be solved > by any spawn API. You just think that because you've apparently been > talking to too many MS people that think fork (and thus indirectly > execve()) is bad process

Re: [PATCH 3/5] arm64: dts: meson: g12a: add mdio multiplexer

2019-05-11 Thread Jerome Brunet
On Sat, 2019-05-11 at 18:59 +0200, Martin Blumenstingl wrote: > Hi Jerome, > > On Fri, May 10, 2019 at 6:49 PM Jerome Brunet wrote: > > Add the g12a mdio multiplexer which allows to connect to either > > an external phy through the SoC pins or the internal 10/100 phy > > > > Signed-off-by:

Re: [PATCH v2] jbd2: fix potential double free

2019-05-11 Thread Theodore Ts'o
On Fri, May 10, 2019 at 06:36:48PM +0800, Chengguang Xu wrote: > diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c > index 37e16d969925..0f1ac43d0560 100644 > --- a/fs/jbd2/journal.c > +++ b/fs/jbd2/journal.c > @@ -2299,7 +2299,7 @@ static void jbd2_journal_destroy_slabs(void) > } > } >

Re: [PATCH v8 1/3] arm64: dts: fsl: librem5: Add a device tree for the Librem5 devkit

2019-05-11 Thread Angus Ainslie
Hi Fabio, On 2019-05-11 08:34, Fabio Estevam wrote: Hi Angus, This looks good. Only minor issues: On Wed, May 1, 2019 at 7:57 PM Angus Ainslie (Purism) wrote: +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts @@ -0,0 +1,823 @@ +/* SPDX-License-Identifier: GPL-2.0+ This should

Re: [PATCH v6 5/6] binfmt_*: scope path resolution of interpreters

2019-05-11 Thread Christian Brauner
On May 11, 2019 7:43:44 PM GMT+02:00, Linus Torvalds wrote: >On Sat, May 11, 2019 at 1:31 PM Aleksa Sarai wrote: >> >> Yup, I've dropped the patch for the next version. (To be honest, I'm >not >> sure why I included any of the other flags -- the only one that >would've >> been necessary to deal

Re: [PATCH v6 5/6] binfmt_*: scope path resolution of interpreters

2019-05-11 Thread Linus Torvalds
On Sat, May 11, 2019 at 1:31 PM Aleksa Sarai wrote: > > Yup, I've dropped the patch for the next version. (To be honest, I'm not > sure why I included any of the other flags -- the only one that would've > been necessary to deal with CVE-2019-5736 was AT_NO_MAGICLINKS.) I do wonder if we could

  1   2   >