Re: [PATCH] sched/fair: Cleanup definition of NOHZ blocked load functions

2019-06-03 Thread Vincent Guittot
On Mon, 3 Jun 2019 at 11:38, Peter Zijlstra wrote: > > On Sun, Jun 02, 2019 at 05:41:10PM +0100, Valentin Schneider wrote: > > cfs_rq_has_blocked() and others_have_blocked() are only used within > > update_blocked_averages(). The !CONFIG_FAIR_GROUP_SCHED version of the > > latter calls them

[PATCH v8 2/2] media: v4l: xilinx: Add Xilinx MIPI CSI-2 Rx Subsystem driver

2019-06-03 Thread Vishal Sagar
The Xilinx MIPI CSI-2 Rx Subsystem soft IP is used to capture images from MIPI CSI-2 camera sensors and output AXI4-Stream video data ready for image processing. Please refer to PG232 for details. The driver is used to set the number of active lanes, if enabled in hardware. The CSI2 Rx controller

[PATCH v8 0/2] Add support for Xilinx CSI2 Receiver Subsystem

2019-06-03 Thread Vishal Sagar
Xilinx MIPI CSI-2 Receiver Subsystem The Xilinx MIPI CSI-2 Receiver Subsystem Soft IP consists of a DPHY which gets the data, an optional I2C, a CSI-2 Receiver which parses the data and converts it into AXIS data. This stream output maybe connected to a

[PATCH v8 1/2] media: dt-bindings: media: xilinx: Add Xilinx MIPI CSI-2 Rx Subsystem

2019-06-03 Thread Vishal Sagar
Add bindings documentation for Xilinx MIPI CSI-2 Rx Subsystem. The Xilinx MIPI CSI-2 Rx Subsystem consists of a CSI-2 Rx controller, a DPHY in Rx mode, an optional I2C controller and a Video Format Bridge. Signed-off-by: Vishal Sagar Reviewed-by: Hyun Kwon Reviewed-by: Rob Herring

Re: hid-related 5.2-rc1 boot hang

2019-06-03 Thread Hans de Goede
Hi Again, On 03-06-19 11:11, Hans de Goede wrote: not sure about the rest of logitech issues yet) next week. The main problem seems to be the request_module patches. Although I also have 2 reports of problems with hid-logitech-dj driving the 0xc52f product-id, so we may need to drop that

Re: Testing the recent RISC-V DT patchsets

2019-06-03 Thread Loys Ollivier
On Wed 29 May 2019 at 12:25, Troy Benjegerdes wrote: >> On May 29, 2019, at 5:04 AM, Loys Ollivier wrote: >> >> On Wed 29 May 2019 at 00:50, Atish Patra wrote: >> >>> On 5/28/19 8:36 AM, Karsten Merker wrote: On Tue, May 28, 2019 at 05:10:42PM +0200, Loys Ollivier wrote: > On Tue

[PATCH 1/4] arm64: dts: meson-g12a-sei510: add 32k clock to bluetooth node

2019-06-03 Thread Neil Armstrong
The 32k low power clock is necessary for the bluetooth part of the combo module to initialize correctly, simply add the same clock we use for the sdio pwrseq. Fixes: d1c023af1988 ("arm64: dts: meson-g12a-sei510: Add ADC Key and BT support") Signed-off-by: Neil Armstrong ---

[PATCH 0/4] arm64: dts: meson-g12a: bluetooth fixups

2019-06-03 Thread Neil Armstrong
These patches : - adds the 32khz low power clock to the bluetooth node, since this clock is needed for the bluetooth part of the module to initialize - bumps the bus speed to 2Mbaud/s Neil Armstrong (4): arm64: dts: meson-g12a-sei510: add 32k clock to bluetooth node arm64: dts:

Re: [PATCH v2] sched/core: add __sched tag for io_schedule()

2019-06-03 Thread Peter Zijlstra
On Mon, Jun 03, 2019 at 05:13:38PM +0800, Gao Xiang wrote: > non-inline io_schedule() was introduced in > commit 10ab56434f2f ("sched/core: Separate out io_schedule_prepare() and > io_schedule_finish()") > Keep in line with io_schedule_timeout, Otherwise > "/proc//wchan" will report io_schedule()

[PATCH 2/4] arm64: dts: meson-g12a-x96-max: add 32k clock to bluetooth node

2019-06-03 Thread Neil Armstrong
The 32k low power clock is necessary for the bluetooth part of the combo module to initialize correctly, simply add the same clock we use for the sdio pwrseq. Fixes: c5c9c7cff269 ("arm64: dts: meson-g12a-x96-max: Enable BT Module") Signed-off-by: Neil Armstrong ---

Re: [PATCH] sched/fair: don't restart enqueued cfs quota slack timer

2019-06-03 Thread Peter Zijlstra
On Mon, Jun 03, 2019 at 12:43:09PM +0800, Liangyan wrote: > From: "liangyan.ply" > > start_cfs_slack_bandwidth() will restart the quota slack timer, > if it is called frequently, this timer will be restarted continuously > and may have no chance to expire to unthrottle cfs tasks. > This will

[PATCH 4/4] arm64: dts: meson-g12a-x96-max: bump bluetooth bus speed to 2Mbaud/s

2019-06-03 Thread Neil Armstrong
Setting to 2Mbaud/s is the nominal bus speed for common usages. Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts

[PATCH 3/4] arm64: dts: meson-g12a-sei510: bump bluetooth bus speed to 2Mbaud/s

2019-06-03 Thread Neil Armstrong
Setting to 2Mbaud/s is the nominal bus speed for common usages. Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/amlogic/meson-g12a-sei510.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/amlogic/meson-g12a-sei510.dts

Re: [PATCH v3 3/5] dt-bindings: mfd: mt6397: Add bindings for MT6392 PMIC

2019-06-03 Thread Lee Jones
On Wed, 15 May 2019, Fabien Parent wrote: > Add the currently supported bindings for the MT6392 PMIC. > > Signed-off-by: Fabien Parent > Reviewed-by: Rob Herring > --- > > V3: > * No change > > V2: > * New patch > > --- > Documentation/devicetree/bindings/mfd/mt6397.txt | 12

RE: [PATCH v7 2/2] media: v4l: xilinx: Add Xilinx MIPI CSI-2 Rx Subsystem driver

2019-06-03 Thread Vishal Sagar
Hi Sakari, Thanks for the review. > -Original Message- > From: Sakari Ailus [mailto:sakari.ai...@linux.intel.com] > Sent: Friday, March 22, 2019 9:31 PM > To: Vishal Sagar > Cc: Hyun Kwon ; laurent.pinch...@ideasonboard.com; > mche...@kernel.org; robh...@kernel.org;

Re: [PATCH] sched/fair: Cleanup definition of NOHZ blocked load functions

2019-06-03 Thread Peter Zijlstra
On Sun, Jun 02, 2019 at 05:41:10PM +0100, Valentin Schneider wrote: > cfs_rq_has_blocked() and others_have_blocked() are only used within > update_blocked_averages(). The !CONFIG_FAIR_GROUP_SCHED version of the > latter calls them within a #define CONFIG_NO_HZ_COMMON block, whereas > the

Re: rcu_read_lock lost its compiler barrier

2019-06-03 Thread Paul E. McKenney
On Mon, Jun 03, 2019 at 01:26:26PM +0800, Herbert Xu wrote: > On Sun, Jun 02, 2019 at 08:47:07PM -0700, Paul E. McKenney wrote: > > > > 1. These guarantees are of full memory barriers, -not- compiler > > barriers. > > What I'm saying is that wherever they are, they must come with > compiler

Re: [PATCH v3 4/5] mfd: mt6397: Add support for MT6392 pmic

2019-06-03 Thread Lee Jones
On Wed, 15 May 2019, Fabien Parent wrote: > Update the MT6397 MFD driver to support the MT6392 PMIC. > > Signed-off-by: Fabien Parent > --- > > V3: > * No change > > V2: > * Pass IRQ comain to fix invalid MFD devices IRQs. > * Remove resources and mfd cells for device we

Re: hid-related 5.2-rc1 boot hang

2019-06-03 Thread Hans de Goede
Hi, On 03-06-19 11:11, Hans de Goede wrote: Hi, On 01-06-19 00:15, Jiri Kosina wrote: On Thu, 30 May 2019, Dave Hansen wrote: On 5/29/19 2:17 AM, Hans de Goede wrote: ... Dave, can you try building your initrd without the hid-logitech-dj module included in the initrd? I did this on a

Re: [RFC PATCH 00/11] mm / virtio: Provide support for paravirtual waste page treatment

2019-06-03 Thread David Hildenbrand
On 30.05.19 23:53, Alexander Duyck wrote: > This series provides an asynchronous means of hinting to a hypervisor > that a guest page is no longer in use and can have the data associated > with it dropped. To do this I have implemented functionality that allows > for what I am referring to as

Re: [PATCH v4 1/2] drivers: base: cacheinfo: Add variable to record max cache line size

2019-06-03 Thread Greg Kroah-Hartman
On Tue, May 28, 2019 at 10:16:53AM +0800, Shaokun Zhang wrote: > Add coherency_max_size variable to record the maximum cache line size > for different cache levels. If it is available, we will synchronize > it as cache line size, otherwise we will use CTR_EL0.CWG reporting > in cache_line_size()

Re: rcu_read_lock lost its compiler barrier

2019-06-03 Thread Paul E. McKenney
On Mon, Jun 03, 2019 at 11:03:24AM +0800, Herbert Xu wrote: > On Sun, Jun 02, 2019 at 05:06:17PM -0700, Paul E. McKenney wrote: > > > > Please note that preemptible Tree RCU has lacked the compiler barrier on > > all but the outermost rcu_read_unlock() for years before Boqun's patch. > > Actually

Re: [PATCH 1/3] clocksource/arm_arch_timer: mark arch_counter_get_* as notrace

2019-06-03 Thread Marc Zyngier
Hi Anders, On 03/06/2019 10:12, Anders Roxell wrote: > When CONFIG_FUNCTION_GRAPH_TRACER is enabled we end up in this circular > call trace since function arch_counter_get_cntvct() isn't marked with no > trace: > > [ 17.914934] Call trace: > [ 17.915211]

[PATCH] scsi: fcoe: Fix possible memleak in fcoe_if_init

2019-06-03 Thread YueHaibing
If it fails to alloc fcoe_vport_scsi_transport in fcoe_if_init, we should check the err and free allocted fcoe_nport_scsi_transport. Also return ENOMEM instead of ENODEV. Fixes: 8ca86f84dd5f ("[SCSI] fcoe: prepare fcoe for using fcoe transport") Signed-off-by: YueHaibing ---

Re: [PATCH] mfd: stmfx: Uninitialized variable in stmfx_irq_handler()

2019-06-03 Thread Amelie DELAUNAY
Hi Dan, Thanks for your patch. One minor comment: On 5/15/19 11:31 AM, Dan Carpenter wrote: > The problem is that on 64bit systems then we don't clear the higher > bits of the "pending" variable. So when we do: > > ack = pending & ~BIT(STMFX_REG_IRQ_SRC_EN_GPIO); > if (ack) { > >

[PATCH 4.19 05/32] ipv4/igmp: fix build error if !CONFIG_IP_MULTICAST

2019-06-03 Thread Greg Kroah-Hartman
From: Eric Dumazet [ Upstream commit 903869bd10e6719b9df6718e785be7ec725df59f ] ip_sf_list_clear_all() needs to be defined even if !CONFIG_IP_MULTICAST Fixes: 3580d04aa674 ("ipv4/igmp: fix another memory leak in igmpv3_del_delrec()") Signed-off-by: Eric Dumazet Reported-by: kbuild test robot

[PATCH 5.0 25/36] net: stmmac: dma channel control register need to be init first

2019-06-03 Thread Greg Kroah-Hartman
From: Weifeng Voon stmmac_init_chan() needs to be called before stmmac_init_rx_chan() and stmmac_init_tx_chan(). This is because if PBLx8 is to be used, "DMA_CH(#i)_Control.PBLx8" needs to be set before programming "DMA_CH(#i)_TX_Control.TxPBL" and "DMA_CH(#i)_RX_Control.RxPBL". Fixes:

[PATCH v5 1/3] dt-bindings: arm: amlogic: add G12B bindings

2019-06-03 Thread Neil Armstrong
Add compatible for the Amlogic G12B SoC, sharing most of the features and architecture with the G12A SoC. Signed-off-by: Neil Armstrong Reviewed-by: Rob Herring Reviewed-by: Martin Blumenstingl --- Documentation/devicetree/bindings/arm/amlogic.yaml | 4 1 file changed, 4 insertions(+)

[PATCH 4.19 22/32] net: stmmac: dma channel control register need to be init first

2019-06-03 Thread Greg Kroah-Hartman
From: Weifeng Voon stmmac_init_chan() needs to be called before stmmac_init_rx_chan() and stmmac_init_tx_chan(). This is because if PBLx8 is to be used, "DMA_CH(#i)_Control.PBLx8" needs to be set before programming "DMA_CH(#i)_TX_Control.TxPBL" and "DMA_CH(#i)_RX_Control.RxPBL". Fixes:

[PATCH 5.1 26/40] net: stmmac: dma channel control register need to be init first

2019-06-03 Thread Greg Kroah-Hartman
From: Weifeng Voon stmmac_init_chan() needs to be called before stmmac_init_rx_chan() and stmmac_init_tx_chan(). This is because if PBLx8 is to be used, "DMA_CH(#i)_Control.PBLx8" needs to be set before programming "DMA_CH(#i)_TX_Control.TxPBL" and "DMA_CH(#i)_RX_Control.RxPBL". Fixes:

[PATCH 4.19 25/32] net/tls: dont ignore netdev notifications if no TLS features

2019-06-03 Thread Greg Kroah-Hartman
From: Jakub Kicinski [ Upstream commit c3f4a6c39cf269a40d45f813c05fa830318ad875 ] On device surprise removal path (the notifier) we can't bail just because the features are disabled. They may have been enabled during the lifetime of the device. This bug leads to leaking netdev references and

[PATCH] seqlock: mark raw_read_seqcount and read_seqcount_retry as __always_inline

2019-06-03 Thread Anders Roxell
If CONFIG_FUNCTION_GRAPH_TRACER is enabled function sched_clock() in kernel/time/sched_clock.c is marked as notrace. However, functions raw_read_seqcount and read_seqcount_retry are marked as inline. If CONFIG_OPTIMIZE_INLINING is set that will make the two functions tracable which they shouldn't.

[PATCH 4.19 26/32] crypto: vmx - ghash: do nosimd fallback manually

2019-06-03 Thread Greg Kroah-Hartman
From: Daniel Axtens commit 357d065a44cdd77ed5ff35155a989f2a763e96ef upstream. VMX ghash was using a fallback that did not support interleaving simd and nosimd operations, leading to failures in the extended test suite. If I understood correctly, Eric's suggestion was to use the same data

[PATCH v5 2/3] dt-bindings: arm: amlogic: add Odroid-N2 binding

2019-06-03 Thread Neil Armstrong
Add compatible for the Amlogic G12B (S922X) SoC based Odroid-N2 SBC from HardKernel. Signed-off-by: Neil Armstrong Reviewed-by: Rob Herring Reviewed-by: Martin Blumenstingl --- Documentation/devicetree/bindings/arm/amlogic.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PATCH 4.19 24/32] net/tls: fix state removal with feature flags off

2019-06-03 Thread Greg Kroah-Hartman
From: Jakub Kicinski [ Upstream commit 3686637e507b48525fcea6fb91e1988bdbc14530 ] TLS offload drivers shouldn't (and currently don't) block the TLS offload feature changes based on whether there are active offloaded connections or not. This seems to be a good idea, because we want the admin to

[PATCH 4.19 27/32] include/linux/compiler*.h: define asm_volatile_goto

2019-06-03 Thread Greg Kroah-Hartman
From: ndesaulni...@google.com commit 8bd66d147c88bd441178c7b4c774ae5a185f19b8 upstream. asm_volatile_goto should also be defined for other compilers that support asm goto. Fixes commit 815f0ddb346c ("include/linux/compiler*.h: make compiler-*.h mutually exclusive"). Signed-off-by: Nick

[PATCH v5 0/3] arm64: Add initial support for Odroid-N2

2019-06-03 Thread Neil Armstrong
This patchset adds basic support for : - Amlogic G12B, which is very similar to G12A - The HardKernel Odroid-N2 based on the S922X SoC The Amlogic G12B SoC is very similar with the G12A SoC, sharing most of the features and architecture, but with these differences : - The first CPU cluster only

[PATCH 4.19 09/32] net: dsa: mv88e6xxx: fix handling of upper half of STATS_TYPE_PORT

2019-06-03 Thread Greg Kroah-Hartman
From: Rasmus Villemoes [ Upstream commit 84b3fd1fc9592d431e23b077e692fa4e3fd0f086 ] Currently, the upper half of a 4-byte STATS_TYPE_PORT statistic ends up in bits 47:32 of the return value, instead of bits 31:16 as they should. Fixes: 6e46e2d821bb ("net: dsa: mv88e6xxx: Fix u64 statistics")

[PATCH 4.19 14/32] net: phy: marvell10g: report if the PHY fails to boot firmware

2019-06-03 Thread Greg Kroah-Hartman
From: Russell King [ Upstream commit 3d3ced2ec5d71b99d72ae6910fbdf890bc2eccf0 ] Some boards do not have the PHY firmware programmed in the 3310's flash, which leads to the PHY not working as expected. Warn the user when the PHY fails to boot the firmware and refuse to initialise. Fixes:

[PATCH 5.0 18/36] r8169: fix MAC address being lost in PCI D3

2019-06-03 Thread Greg Kroah-Hartman
From: Heiner Kallweit [ Upstream commit 59715171fbd0172a579576f46821031800a63bc5 ] (At least) RTL8168e forgets its MAC address in PCI D3. To fix this set the MAC address when resuming. For resuming from runtime-suspend we had this in place already, for resuming from S3/S5 it was missing. The

[PATCH 4.19 29/32] jump_label: move asm goto support test to Kconfig

2019-06-03 Thread Greg Kroah-Hartman
From: Masahiro Yamada commit e9666d10a5677a494260d60d1fa0b73cc7646eb3 upstream. Currently, CONFIG_JUMP_LABEL just means "I _want_ to use jump label". The jump label is controlled by HAVE_JUMP_LABEL, which is defined like this: #if defined(CC_HAVE_ASM_GOTO) && defined(CONFIG_JUMP_LABEL) #

[PATCH 5.0 01/36] bonding/802.3ad: fix slave link initialization transition states

2019-06-03 Thread Greg Kroah-Hartman
From: Jarod Wilson [ Upstream commit 334031219a84b9994594015aab85ed7754c80176 ] Once in a while, with just the right timing, 802.3ad slaves will fail to properly initialize, winding up in a weird state, with a partner system mac address of 00:00:00:00:00:00. This started happening after a fix

[PATCH 4.19 16/32] net: stmmac: fix reset gpio free missing

2019-06-03 Thread Greg Kroah-Hartman
From: Jisheng Zhang [ Upstream commit 49ce881c0d4c4a7a35358d9dccd5f26d0e56fc61 ] Commit 984203ceff27 ("net: stmmac: mdio: remove reset gpio free") removed the reset gpio free, when the driver is unbinded or rmmod, we miss the gpio free. This patch uses managed API to request the reset gpio, so

[PATCH 5.0 04/36] ipv4/igmp: fix another memory leak in igmpv3_del_delrec()

2019-06-03 Thread Greg Kroah-Hartman
From: Eric Dumazet [ Upstream commit 3580d04aa674383c42de7b635d28e52a1e5bc72c ] syzbot reported memory leaks [1] that I have back tracked to a missing cleanup from igmpv3_del_delrec() when (im->sfmode != MCAST_INCLUDE) Add ip_sf_list_clear_all() and kfree_pmc() helpers to explicitely handle

[PATCH 5.0 09/36] mlxsw: spectrum_acl: Avoid warning after identical rules insertion

2019-06-03 Thread Greg Kroah-Hartman
From: Jiri Pirko [ Upstream commit ef74422020aa8c224b00a927e3e47faac4d8fae3 ] When identical rules are inserted, the latter one goes to C-TCAM. For that, a second eRP with the same mask is created. These 2 eRPs by the nature cannot be merged and also one cannot be parent of another. Teach

[PATCH 5.0 30/36] net/tls: dont ignore netdev notifications if no TLS features

2019-06-03 Thread Greg Kroah-Hartman
From: Jakub Kicinski [ Upstream commit c3f4a6c39cf269a40d45f813c05fa830318ad875 ] On device surprise removal path (the notifier) we can't bail just because the features are disabled. They may have been enabled during the lifetime of the device. This bug leads to leaking netdev references and

Re: hid-related 5.2-rc1 boot hang

2019-06-03 Thread Hans de Goede
Hi, On 01-06-19 00:15, Jiri Kosina wrote: On Thu, 30 May 2019, Dave Hansen wrote: On 5/29/19 2:17 AM, Hans de Goede wrote: ... Dave, can you try building your initrd without the hid-logitech-dj module included in the initrd? I did this on a vanilla 5.2-rc2 kernel (without the reverts) and

[PATCH 5.0 19/36] usbnet: fix kernel crash after disconnect

2019-06-03 Thread Greg Kroah-Hartman
From: Kloetzke Jan [ Upstream commit ad70411a978d1e6e97b1e341a7bde9a79af0c93d ] When disconnecting cdc_ncm the kernel sporadically crashes shortly after the disconnect: [ 57.868812] Unable to handle kernel NULL pointer dereference at virtual address ... [ 58.006653] PC is

[PATCH] mm: kasan: mark file report so ftrace doesn't trace it

2019-06-03 Thread Anders Roxell
__kasan_report() triggers ftrace and the preempt_count() in ftrace causes a call to __asan_load4(), breaking the circular dependency by making report as no trace for ftrace. Signed-off-by: Anders Roxell --- mm/kasan/Makefile | 3 +++ 1 file changed, 3 insertions(+) diff --git

[PATCH 5.0 21/36] tipc: Avoid copying bytes beyond the supplied data

2019-06-03 Thread Greg Kroah-Hartman
From: Chris Packham TLV_SET is called with a data pointer and a len parameter that tells us how many bytes are pointed to by data. When invoking memcpy() we need to careful to only copy len bytes. Previously we would copy TLV_LENGTH(len) bytes which would copy an extra 4 bytes past the end of

[PATCH 5.0 06/36] ipv6: Consider sk_bound_dev_if when binding a raw socket to an address

2019-06-03 Thread Greg Kroah-Hartman
From: Mike Manning [ Upstream commit 72f7cfab6f93a8ea825fab8ccfb016d064269f7f ] IPv6 does not consider if the socket is bound to a device when binding to an address. The result is that a socket can be bound to eth0 and then bound to the address of eth1. If the device is a VRF, the result is

[PATCH 5.0 33/36] crypto: vmx - ghash: do nosimd fallback manually

2019-06-03 Thread Greg Kroah-Hartman
From: Daniel Axtens commit 357d065a44cdd77ed5ff35155a989f2a763e96ef upstream. VMX ghash was using a fallback that did not support interleaving simd and nosimd operations, leading to failures in the extended test suite. If I understood correctly, Eric's suggestion was to use the same data

[PATCH 5.0 35/36] Revert "tipc: fix modprobe tipc failed after switch order of device registration"

2019-06-03 Thread Greg Kroah-Hartman
From: David S. Miller commit 5593530e56943182ebb6d81eca8a3be6db6dbba4 upstream. This reverts commit 532b0f7ece4cb2ffd24dc723ddf55242d1188e5e. More revisions coming up. Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/tipc/core.c | 14 +++--- 1 file

Re: [PATCH v3 14/16] powerpc/32: implement fast entry for syscalls on BOOKE

2019-06-03 Thread Christophe Leroy
On 05/28/2019 05:03 PM, Christophe Leroy wrote: Michael Ellerman a écrit : Christophe Leroy writes: Le 23/05/2019 à 09:00, Christophe Leroy a écrit : [...] arch/powerpc/kernel/head_fsl_booke.o: In function `SystemCall': arch/powerpc/kernel/head_fsl_booke.S:416: undefined reference to

[PATCH 4.19 18/32] net/mlx5: Avoid double free in fs init error unwinding path

2019-06-03 Thread Greg Kroah-Hartman
From: Parav Pandit [ Upstream commit 9414277a5df3669c67e818708c0f881597e0118e ] In below code flow, for ingress acl table root ns memory leads to double free. mlx5_init_fs init_ingress_acls_root_ns() init_ingress_acl_root_ns kfree(steering->esw_ingress_root_ns); /*

[PATCH 4.19 15/32] net: sched: dont use tc_action->order during action dump

2019-06-03 Thread Greg Kroah-Hartman
From: Vlad Buslov [ Upstream commit 4097e9d250fb17958c1d9b94538386edd3f20144 ] Function tcf_action_dump() relies on tc_action->order field when starting nested nla to send action data to userspace. This approach breaks in several cases: - When multiple filters point to same shared action,

[PATCH 5.0 17/36] net: stmmac: fix reset gpio free missing

2019-06-03 Thread Greg Kroah-Hartman
From: Jisheng Zhang [ Upstream commit 49ce881c0d4c4a7a35358d9dccd5f26d0e56fc61 ] Commit 984203ceff27 ("net: stmmac: mdio: remove reset gpio free") removed the reset gpio free, when the driver is unbinded or rmmod, we miss the gpio free. This patch uses managed API to request the reset gpio, so

[PATCH 5.1 05/40] ipv4/igmp: fix another memory leak in igmpv3_del_delrec()

2019-06-03 Thread Greg Kroah-Hartman
From: Eric Dumazet [ Upstream commit 3580d04aa674383c42de7b635d28e52a1e5bc72c ] syzbot reported memory leaks [1] that I have back tracked to a missing cleanup from igmpv3_del_delrec() when (im->sfmode != MCAST_INCLUDE) Add ip_sf_list_clear_all() and kfree_pmc() helpers to explicitely handle

[PATCH 5.1 37/40] net: correct zerocopy refcnt with udp MSG_MORE

2019-06-03 Thread Greg Kroah-Hartman
From: Willem de Bruijn [ Upstream commit 100f6d8e09905c59be45b6316f8f369c0be1b2d8 ] TCP zerocopy takes a uarg reference for every skb, plus one for the tcp_sendmsg_locked datapath temporarily, to avoid reaching refcnt zero as it builds, sends and frees skbs inside its inner loop. UDP and RAW

[PATCH 5.0 28/36] bnxt_en: Reduce memory usage when running in kdump kernel.

2019-06-03 Thread Greg Kroah-Hartman
From: Michael Chan [ Upstream commit d629522e1d66561f38e5c8d4f52bb6d254ec0707 ] Skip RDMA context memory allocations, reduce to 1 ring, and disable TPA when running in the kdump kernel. Without this patch, the driver fails to initialize with memory allocation errors when running in a typical

[PATCH 5.1 01/40] bonding/802.3ad: fix slave link initialization transition states

2019-06-03 Thread Greg Kroah-Hartman
From: Jarod Wilson [ Upstream commit 334031219a84b9994594015aab85ed7754c80176 ] Once in a while, with just the right timing, 802.3ad slaves will fail to properly initialize, winding up in a weird state, with a partner system mac address of 00:00:00:00:00:00. This started happening after a fix

[PATCH 5.1 07/40] ipv6: Consider sk_bound_dev_if when binding a raw socket to an address

2019-06-03 Thread Greg Kroah-Hartman
From: Mike Manning [ Upstream commit 72f7cfab6f93a8ea825fab8ccfb016d064269f7f ] IPv6 does not consider if the socket is bound to a device when binding to an address. The result is that a socket can be bound to eth0 and then bound to the address of eth1. If the device is a VRF, the result is

[PATCH 4.19 11/32] net-gro: fix use-after-free read in napi_gro_frags()

2019-06-03 Thread Greg Kroah-Hartman
From: Eric Dumazet [ Upstream commit a4270d6795b0580287453ea55974d948393e66ef ] If a network driver provides to napi_gro_frags() an skb with a page fragment of exactly 14 bytes, the call to gro_pull_from_frag0() will 'consume' the fragment by calling skb_frag_unref(skb, 0), and the page might

[PATCH 4.19 21/32] net/mlx5e: Disable rxhash when CQE compress is enabled

2019-06-03 Thread Greg Kroah-Hartman
From: Saeed Mahameed [ Upstream commit c0194e2d0ef0e5ce5e21a35640d23a706827ae28 ] When CQE compression is enabled (Multi-host systems), compressed CQEs might arrive to the driver rx, compressed CQEs don't have a valid hash offload and the driver already reports a hash value of 0 and invalid

[PATCH 2/4] zstd: use U16 data type for rankPos

2019-06-03 Thread Maninder Singh
rankPos structure variables value can not be more than 512. So it can easily be declared as U16 rather than U32. It will reduce stack usage of HUF_sort from 256 bytes to 128 bytes original: e92ddbf0push{r4, r5, r6, r7, r8, r9, fp, ip, lr, pc} e24cb004sub fp, ip, #4

[PATCH 5.1 00/40] 5.1.7-stable review

2019-06-03 Thread Greg Kroah-Hartman
This is the start of the stable review cycle for the 5.1.7 release. There are 40 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Wed 05 Jun 2019 09:04:46 AM UTC. Anything

[PATCH 4.19 28/32] compiler.h: give up __compiletime_assert_fallback()

2019-06-03 Thread Greg Kroah-Hartman
From: Masahiro Yamada commit 81b45683487a51b0f4d3b29d37f20d6d078544e4 upstream. __compiletime_assert_fallback() is supposed to stop building earlier by using the negative-array-size method in case the compiler does not support "error" attribute, but has never worked like that. You can simply

[PATCH 5.1 30/40] net/tls: fix lowat calculation if some data came from previous record

2019-06-03 Thread Greg Kroah-Hartman
From: Jakub Kicinski [ Upstream commit 46a1695960d0600d58da7af33c65f24f3d839674 ] If some of the data came from the previous record, i.e. from the rx_list it had already been decrypted, so it's not counted towards the "decrypted" variable, but the "copied" variable. Take that into account when

[PATCH 5.1 35/40] net/tls: dont ignore netdev notifications if no TLS features

2019-06-03 Thread Greg Kroah-Hartman
From: Jakub Kicinski [ Upstream commit c3f4a6c39cf269a40d45f813c05fa830318ad875 ] On device surprise removal path (the notifier) we can't bail just because the features are disabled. They may have been enabled during the lifetime of the device. This bug leads to leaking netdev references and

[PATCH 5.0 22/36] net/mlx5: Allocate root ns memory using kzalloc to match kfree

2019-06-03 Thread Greg Kroah-Hartman
From: Parav Pandit [ Upstream commit 25fa506b70cadb580c1e9cbd836d6417276d4bcd ] root ns is yet another fs core node which is freed using kfree() by tree_put_node(). Rest of the other fs core objects are also allocated using kmalloc variants. However, root ns memory is allocated using

[PATCH 4.19 07/32] ipv6: Fix redirect with VRF

2019-06-03 Thread Greg Kroah-Hartman
From: David Ahern [ Upstream commit 31680ac265802397937d75461a2809a067b9fb93 ] IPv6 redirect is broken for VRF. __ip6_route_redirect walks the FIB entries looking for an exact match on ifindex. With VRF the flowi6_oif is updated by l3mdev_update_flow to the l3mdev index and the

[PATCH 0/4] zstd: reduce stack usage

2019-06-03 Thread Maninder Singh
This patch set reduces stack usage for zstd code, because target like ARM has limited 8KB kernel stack, which is getting overflowed due to hight stack usage of zstd code with call flow like: (FSE_compress_usingCTable) from (HUF_compressWeights_wksp+0x140/0x200)

[PATCH 4.19 17/32] usbnet: fix kernel crash after disconnect

2019-06-03 Thread Greg Kroah-Hartman
From: Kloetzke Jan [ Upstream commit ad70411a978d1e6e97b1e341a7bde9a79af0c93d ] When disconnecting cdc_ncm the kernel sporadically crashes shortly after the disconnect: [ 57.868812] Unable to handle kernel NULL pointer dereference at virtual address ... [ 58.006653] PC is

[PATCH 5.1 33/40] selftests/tls: add test for sleeping even though there is data

2019-06-03 Thread Greg Kroah-Hartman
From: Jakub Kicinski [ Upstream commit 043556d0917a1a5ea58795fe1656a2bce06d2649 ] Add a test which sends 15 bytes of data, and then tries to read 10 byes twice. Previously the second read would sleep indifinitely, since the record was already decrypted and there is only 5 bytes left, not full

[PATCH 5.0 14/36] net: mvpp2: fix bad MVPP2_TXQ_SCHED_TOKEN_CNTR_REG queue value

2019-06-03 Thread Greg Kroah-Hartman
From: Antoine Tenart [ Upstream commit 21808437214637952b61beaba6034d97880fbeb3 ] MVPP2_TXQ_SCHED_TOKEN_CNTR_REG() expects the logical queue id but the current code is passing the global tx queue offset, so it ends up writing to unknown registers (between 0x8280 and 0x82fc, which seemed to be

[PATCH 4.19 08/32] llc: fix skb leak in llc_build_and_send_ui_pkt()

2019-06-03 Thread Greg Kroah-Hartman
From: Eric Dumazet [ Upstream commit 8fb44d60d4142cd2a440620cd291d346e23c131e ] If llc_mac_hdr_init() returns an error, we must drop the skb since no llc_build_and_send_ui_pkt() caller will take care of this. BUG: memory leak unreferenced object 0x8881202b6800 (size 2048): comm

[PATCH 5.0 11/36] net: fec: fix the clk mismatch in failed_reset path

2019-06-03 Thread Greg Kroah-Hartman
From: Andy Duan [ Upstream commit ce8d24f9a5965a58c588f9342689702a1024433c ] Fix the clk mismatch in the error path "failed_reset" because below error path will disable clk_ahb and clk_ipg directly, it should use pm_runtime_put_noidle() instead of pm_runtime_put() to avoid to call runtime

[PATCH 4.19 00/32] 4.19.48-stable review

2019-06-03 Thread Greg Kroah-Hartman
This is the start of the stable review cycle for the 4.19.48 release. There are 32 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Wed 05 Jun 2019 09:02:49 AM UTC. Anything

[PATCH 5.0 12/36] net-gro: fix use-after-free read in napi_gro_frags()

2019-06-03 Thread Greg Kroah-Hartman
From: Eric Dumazet [ Upstream commit a4270d6795b0580287453ea55974d948393e66ef ] If a network driver provides to napi_gro_frags() an skb with a page fragment of exactly 14 bytes, the call to gro_pull_from_frag0() will 'consume' the fragment by calling skb_frag_unref(skb, 0), and the page might

[PATCH 5.0 16/36] net: sched: dont use tc_action->order during action dump

2019-06-03 Thread Greg Kroah-Hartman
From: Vlad Buslov [ Upstream commit 4097e9d250fb17958c1d9b94538386edd3f20144 ] Function tcf_action_dump() relies on tc_action->order field when starting nested nla to send action data to userspace. This approach breaks in several cases: - When multiple filters point to same shared action,

[PATCH 4.19 20/32] net/mlx5: Allocate root ns memory using kzalloc to match kfree

2019-06-03 Thread Greg Kroah-Hartman
From: Parav Pandit [ Upstream commit 25fa506b70cadb580c1e9cbd836d6417276d4bcd ] root ns is yet another fs core node which is freed using kfree() by tree_put_node(). Rest of the other fs core objects are also allocated using kmalloc variants. However, root ns memory is allocated using

[PATCH 5.0 10/36] net: dsa: mv88e6xxx: fix handling of upper half of STATS_TYPE_PORT

2019-06-03 Thread Greg Kroah-Hartman
From: Rasmus Villemoes [ Upstream commit 84b3fd1fc9592d431e23b077e692fa4e3fd0f086 ] Currently, the upper half of a 4-byte STATS_TYPE_PORT statistic ends up in bits 47:32 of the return value, instead of bits 31:16 as they should. Fixes: 6e46e2d821bb ("net: dsa: mv88e6xxx: Fix u64 statistics")

[PATCH 4.19 23/32] bnxt_en: Fix aggregation buffer leak under OOM condition.

2019-06-03 Thread Greg Kroah-Hartman
From: Michael Chan [ Upstream commit 296d5b54163964b7ae536b8b57dfbd21d4e868e1 ] For every RX packet, the driver replenishes all buffers used for that packet and puts them back into the RX ring and RX aggregation ring. In one code path where the RX packet has one RX buffer and one or more

[PATCH 4.19 19/32] tipc: Avoid copying bytes beyond the supplied data

2019-06-03 Thread Greg Kroah-Hartman
From: Chris Packham TLV_SET is called with a data pointer and a len parameter that tells us how many bytes are pointed to by data. When invoking memcpy() we need to careful to only copy len bytes. Previously we would copy TLV_LENGTH(len) bytes which would copy an extra 4 bytes past the end of

[PATCH 3/4] zstd: move params structure to global variable to reduce stack usage

2019-06-03 Thread Maninder Singh
As params structure remains same for lifetime, just initialise it at init time and make it global variable. Signed-off-by: Maninder Singh Signed-off-by: Vaneet Narang --- crypto/zstd.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/crypto/zstd.c b/crypto/zstd.c

[PATCH 5.0 29/36] net/tls: fix state removal with feature flags off

2019-06-03 Thread Greg Kroah-Hartman
From: Jakub Kicinski [ Upstream commit 3686637e507b48525fcea6fb91e1988bdbc14530 ] TLS offload drivers shouldn't (and currently don't) block the TLS offload feature changes based on whether there are active offloaded connections or not. This seems to be a good idea, because we want the admin to

[PATCH 5.0 31/36] cxgb4: Revert "cxgb4: Remove SGE_HOST_PAGE_SIZE dependency on page size"

2019-06-03 Thread Greg Kroah-Hartman
From: Vishal Kulkarni [ Upstream commit ab0610efabb4c4f419a531455708caf1dd29357e ] This reverts commit 2391b0030e241386d710df10e53e2cfc3c5d4fc1 which has introduced regression. Now SGE's BAR2 Doorbell/GTS Page Size is interpreted correctly in the firmware itself by using actual host page size.

[PATCH 5.1 09/40] llc: fix skb leak in llc_build_and_send_ui_pkt()

2019-06-03 Thread Greg Kroah-Hartman
From: Eric Dumazet [ Upstream commit 8fb44d60d4142cd2a440620cd291d346e23c131e ] If llc_mac_hdr_init() returns an error, we must drop the skb since no llc_build_and_send_ui_pkt() caller will take care of this. BUG: memory leak unreferenced object 0x8881202b6800 (size 2048): comm

[PATCH 4.19 06/32] ipv6: Consider sk_bound_dev_if when binding a raw socket to an address

2019-06-03 Thread Greg Kroah-Hartman
From: Mike Manning [ Upstream commit 72f7cfab6f93a8ea825fab8ccfb016d064269f7f ] IPv6 does not consider if the socket is bound to a device when binding to an address. The result is that a socket can be bound to eth0 and then bound to the address of eth1. If the device is a VRF, the result is

[PATCH 4.19 13/32] net: mvpp2: fix bad MVPP2_TXQ_SCHED_TOKEN_CNTR_REG queue value

2019-06-03 Thread Greg Kroah-Hartman
From: Antoine Tenart [ Upstream commit 21808437214637952b61beaba6034d97880fbeb3 ] MVPP2_TXQ_SCHED_TOKEN_CNTR_REG() expects the logical queue id but the current code is passing the global tx queue offset, so it ends up writing to unknown registers (between 0x8280 and 0x82fc, which seemed to be

[PATCH 5.1 13/40] net-gro: fix use-after-free read in napi_gro_frags()

2019-06-03 Thread Greg Kroah-Hartman
From: Eric Dumazet [ Upstream commit a4270d6795b0580287453ea55974d948393e66ef ] If a network driver provides to napi_gro_frags() an skb with a page fragment of exactly 14 bytes, the call to gro_pull_from_frag0() will 'consume' the fragment by calling skb_frag_unref(skb, 0), and the page might

[PATCH 2/3] arm64: arch_timer: mark functions as __always_inline

2019-06-03 Thread Anders Roxell
If CONFIG_FUNCTION_GRAPH_TRACER is enabled function arch_counter_get_cntvct() is marked as notrace. However, function __arch_counter_get_cntvct is marked as inline. If CONFIG_OPTIMIZE_INLINING is set that will make the two functions tracable which they shouldn't. Rework so that functions

[PATCH 5.1 39/40] Revert "tipc: fix modprobe tipc failed after switch order of device registration"

2019-06-03 Thread Greg Kroah-Hartman
From: David S. Miller commit 5593530e56943182ebb6d81eca8a3be6db6dbba4 upstream. This reverts commit 532b0f7ece4cb2ffd24dc723ddf55242d1188e5e. More revisions coming up. Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/tipc/core.c | 14 +++--- 1 file

[PATCH 5.1 12/40] net: fec: fix the clk mismatch in failed_reset path

2019-06-03 Thread Greg Kroah-Hartman
From: Andy Duan [ Upstream commit ce8d24f9a5965a58c588f9342689702a1024433c ] Fix the clk mismatch in the error path "failed_reset" because below error path will disable clk_ahb and clk_ipg directly, it should use pm_runtime_put_noidle() instead of pm_runtime_put() to avoid to call runtime

[PATCH 5.1 08/40] ipv6: Fix redirect with VRF

2019-06-03 Thread Greg Kroah-Hartman
From: David Ahern [ Upstream commit 31680ac265802397937d75461a2809a067b9fb93 ] IPv6 redirect is broken for VRF. __ip6_route_redirect walks the FIB entries looking for an exact match on ifindex. With VRF the flowi6_oif is updated by l3mdev_update_flow to the l3mdev index and the

[PATCH 4.19 10/32] net: fec: fix the clk mismatch in failed_reset path

2019-06-03 Thread Greg Kroah-Hartman
From: Andy Duan [ Upstream commit ce8d24f9a5965a58c588f9342689702a1024433c ] Fix the clk mismatch in the error path "failed_reset" because below error path will disable clk_ahb and clk_ipg directly, it should use pm_runtime_put_noidle() instead of pm_runtime_put() to avoid to call runtime

[PATCH 5.0 15/36] net: phy: marvell10g: report if the PHY fails to boot firmware

2019-06-03 Thread Greg Kroah-Hartman
From: Russell King [ Upstream commit 3d3ced2ec5d71b99d72ae6910fbdf890bc2eccf0 ] Some boards do not have the PHY firmware programmed in the 3310's flash, which leads to the PHY not working as expected. Warn the user when the PHY fails to boot the firmware and refuse to initialise. Fixes:

[PATCH 5.0 13/36] net: mvneta: Fix err code path of probe

2019-06-03 Thread Greg Kroah-Hartman
From: Jisheng Zhang [ Upstream commit d484e06e25ebb937d841dac02ac1fe76ec7d4ddd ] Fix below issues in err code path of probe: 1. we don't need to unregister_netdev() because the netdev isn't registered. 2. when register_netdev() fails, we also need to destroy bm pool for HWBM case. Fixes:

[PATCH 5.1 06/40] ipv4/igmp: fix build error if !CONFIG_IP_MULTICAST

2019-06-03 Thread Greg Kroah-Hartman
From: Eric Dumazet [ Upstream commit 903869bd10e6719b9df6718e785be7ec725df59f ] ip_sf_list_clear_all() needs to be defined even if !CONFIG_IP_MULTICAST Fixes: 3580d04aa674 ("ipv4/igmp: fix another memory leak in igmpv3_del_delrec()") Signed-off-by: Eric Dumazet Reported-by: kbuild test robot

[PATCH 4.19 32/32] tipc: fix modprobe tipc failed after switch order of device registration

2019-06-03 Thread Greg Kroah-Hartman
From: Junwei Hu commit 526f5b851a96566803ee4bee60d0a34df56c77f8 upstream. Error message printed: modprobe: ERROR: could not insert 'tipc': Address family not supported by protocol. when modprobe tipc after the following patch: switch order of device registration, commit 7e27e8d6130c ("tipc:

<    5   6   7   8   9   10   11   12   13   >