Re: [patch 08/11] mm: memcg: remove needless !mm fixup to init_mm when charging

2012-07-09 Thread Wanpeng Li
On Tue, Jul 10, 2012 at 08:21:04AM +0200, Michal Hocko wrote: >On Tue 10-07-12 14:10:21, Wanpeng Li wrote: >> On Mon, Jul 09, 2012 at 05:20:58PM +0200, Michal Hocko wrote: >> >On Thu 05-07-12 02:45:00, Johannes Weiner wrote: >> >> It does not matter to __mem_cgroup_try_charge() if the passed mm is

Re: [PATCH v1 08/11] arm/dts: Add twl4030-usb data

2012-07-09 Thread ABRAHAM, KISHON VIJAY
Hi, On Tue, Jul 10, 2012 at 11:43 AM, Rajendra Nayak wrote: > On Thursday 28 June 2012 05:21 PM, Kishon Vijay Abraham I wrote: >> >> Add twl4030-usb data node in twl4030 device tree file. >> >> Signed-off-by: Kishon Vijay Abraham I >> --- >> arch/arm/boot/dts/twl4030.dtsi | 21 +++

Re: [PATCH 1/2] acpi : cpu hot-remove returns error number when cpu_down() fails

2012-07-09 Thread Srivatsa S. Bhat
On 07/10/2012 10:44 AM, Yasuaki Ishimatsu wrote: > Hi Srivatsa, > > 2012/07/10 9:13, Yasuaki Ishimatsu wrote: >> Hi Srivatsa, >> >> 2012/07/09 20:25, Srivatsa S. Bhat wrote: >>> On 07/09/2012 08:01 AM, Yasuaki Ishimatsu wrote: Hi Srivatsa, Thank you for your reviewing. 201

Re: [PATCH v1 07/11] drivers: usb: twl4030: Add device tree support for twl4030 usb

2012-07-09 Thread ABRAHAM, KISHON VIJAY
Hi, On Tue, Jul 10, 2012 at 11:32 AM, Rajendra Nayak wrote: > On Thursday 28 June 2012 05:21 PM, Kishon Vijay Abraham I wrote: >> >> Add device tree support for twl6030 usb driver. > > > twl4030? My bad. Will fix it. > > >> Update the Documentation with device tree binding information. >> >> Sign

Re: [PATCH 1/2] acpi : cpu hot-remove returns error number when cpu_down() fails

2012-07-09 Thread Srivatsa S. Bhat
On 07/10/2012 05:43 AM, Yasuaki Ishimatsu wrote: > Hi Srivatsa, > > 2012/07/09 20:25, Srivatsa S. Bhat wrote: >> On 07/09/2012 08:01 AM, Yasuaki Ishimatsu wrote: >>> Hi Srivatsa, >>> >>> Thank you for your reviewing. >>> >>> 2012/07/06 18:51, Srivatsa S. Bhat wrote: On 07/06/2012 08:46 AM, Ya

Re: linux-next: manual merge of the arm-soc tree with the i2c-embedded tree

2012-07-09 Thread Stephen Rothwell
Hi all, On Tue, 10 Jul 2012 16:41:30 +1000 Stephen Rothwell wrote: > > Hi all, > > Today's linux-next merge of the arm-soc tree got a conflict in > drivers/i2c/busses/i2c-nomadik.c between commit af97bace2cca > ("i2c-nomadik: move header to ") from Also commit 235602146ec9 ("i2c-nomadik: turn

Re: Boot regression on Mackerel with current mainline

2012-07-09 Thread Guennadi Liakhovetski
Hi Chris On Tue, 10 Jul 2012, Chris Ball wrote: > Hi Guennadi, > > On Wed, Jul 04 2012, Guennadi Liakhovetski wrote: > > On Tue, 3 Jul 2012, Rafael J. Wysocki wrote: > > > >> On Tuesday, July 03, 2012, Guennadi Liakhovetski wrote: > >> > Hi Rafael > >> > > >> > On Tue, 3 Jul 2012, Rafael J. Wys

Re: [PATCH v1 01/11] drivers: usb: otg: add a new driver for omap usb2 phy

2012-07-09 Thread Rajendra Nayak
+ +static int __devinit omap_usb2_probe(struct platform_device *pdev) +{ + struct omap_usb *phy; + struct usb_otg *otg; + struct resource *res; + + phy = devm_kzalloc(&pdev->dev, sizeof(*phy), GFP_KERNEL); + if (!phy)

Re: [PATCH] pwm: add lpc32xx pwm support

2012-07-09 Thread Thierry Reding
On Mon, Jul 09, 2012 at 04:27:54PM -0300, Alexandre Pereira da Silva wrote: > Add lpc32xx soc pwm driver. > > Signed-off-by: Alexandre Pereira da Silva > --- > .../devicetree/bindings/pwm/lpc32xx-pwm.txt| 12 ++ > drivers/pwm/Kconfig| 11 ++ > drivers/

Re: [PATCH v1 01/11] drivers: usb: otg: add a new driver for omap usb2 phy

2012-07-09 Thread ABRAHAM, KISHON VIJAY
Hi, On Tue, Jul 10, 2012 at 11:33 AM, Venu Byravarasu wrote: >> > + >> > +#ifdef CONFIG_PM > > Should it not be CONFIG_PM_SLEEP instead of just CONFIG_PM? Why? I think we should have CONFIG_PM_SLEEP only when we have *suspend*, *resume* hooks. But this driver has only *runtime_suspend* and *runt

[PATCH 6/6] staging/phison: use module_pci_driver macro

2012-07-09 Thread Devendra Naga
remove the duplication of module_pci_driver and use this macro instead module_pci_driver macro does the same things as the code below does static int __init pci_test_dev_init(void) { return pci_register_driver(&pci_test_driver_ops); } static void __exit pci_test_dev_exit(void) { pc

[PATCH 5/6] staging/media/solo6x10: use module_pci_driver macro

2012-07-09 Thread Devendra Naga
the driver duplicates the module_pci_driver code, how? module_pci_driver is used for those drivers whose init and exit paths does only register and unregister to pci API and nothing else. so use the module_pci_driver macro instead Signed-off-by: Devendra Naga --- drivers

Re: [PATCH v1 05/11] drivers: usb: twl6030: Add dt support for twl6030 usb

2012-07-09 Thread Rajendra Nayak
On Tuesday 10 July 2012 11:58 AM, ABRAHAM, KISHON VIJAY wrote: Hi, On Tue, Jul 10, 2012 at 11:28 AM, Rajendra Nayak wrote: On Thursday 28 June 2012 05:21 PM, Kishon Vijay Abraham I wrote: Add device tree support for twl6030 usb driver. Update the Documentation with device tree binding inform

[PATCH 4/6] staging/media/dt3155v4l: use module_pci_driver macro

2012-07-09 Thread Devendra Naga
the driver duplicates the module_pci_driver code, remove the duplicate code and use the module_pci_driver macro. Signed-off-by: Devendra Naga --- drivers/staging/media/dt3155v4l/dt3155v4l.c | 15 +-- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/drivers/staging/medi

[PATCH 3/6] staging/sep: use module_pci_driver macro

2012-07-09 Thread Devendra Naga
this driver duplicates the module_pci_driver code, so remove the duplicated code and use module_pci_driver and also remove the obvious comments about _init and _exit. Signed-off-by: Devendra Naga --- drivers/staging/sep/sep_main.c | 27 +-- 1 file changed, 1 insertion(+

linux-next: manual merge of the arm-soc tree with the i2c-embedded tree

2012-07-09 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the arm-soc tree got a conflict in drivers/i2c/busses/i2c-nomadik.c between commit af97bace2cca ("i2c-nomadik: move header to ") from the i2c-embedded tree and commits 32e42c687e0a ("ARM: ux500: Remove unused i2c platform_data initialisation code") and 8214fd238

[PATCH 2/6] staging/et131x: use module_pci_driver macro

2012-07-09 Thread Devendra Naga
remove code duplicating module_pci_driver and also the obvious comments about the _init and _exit points. Signed-off-by: Devendra Naga --- drivers/staging/et131x/et131x.c | 22 +- 1 file changed, 1 insertion(+), 21 deletions(-) diff --git a/drivers/staging/et131x/et131x.c

[PATCH 1/6] staging/sbe-2t3e3: use module_pci_driver macro

2012-07-09 Thread Devendra Naga
the _init and _exit functions do nothing but pci_register_driver, and pci_unregister_driver, so replace these and also the module _init and _exit macros with the module_pci_driver macro. Signed-off-by: Devendra Naga --- drivers/staging/sbe-2t3e3/module.c | 13 + 1 file changed, 1

Re: [PATCH v1 01/11] drivers: usb: otg: add a new driver for omap usb2 phy

2012-07-09 Thread ABRAHAM, KISHON VIJAY
Hi, On Tue, Jul 10, 2012 at 11:16 AM, Rajendra Nayak wrote: >> diff --git a/Documentation/devicetree/bindings/usb/omap-usb.txt >> b/Documentation/devicetree/bindings/usb/omap-usb.txt >> new file mode 100644 >> index 000..80a28c9 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/usb/

Re: [PATCH v8] input: keyboard: Add keys driver for the LPC32xx SoC

2012-07-09 Thread Dmitry Torokhov
Hi Roland, On Thu, Jun 28, 2012 at 12:03:16AM +0200, Roland Stigge wrote: > + > +struct lpc32xx_kscan_drv { > + struct input_dev *input; > + struct clk *clk; > + void __iomem *kscan_base; > + u8 lastkeystates[8]; > + u32 io_p_start; > + u32 io_p_size; > + u32 matrix_sz;

[PATCH] usb: twl6030-usb: variable otg not declared in twl6030_usbotg_irq() in linux-next

2012-07-09 Thread Gerard Snitselaar
commit ff9cce82 added back 2 lines that were removed by commit c83a8542 causing build of twl6030-usb to get an error due to otg being referenced, but not declared. This patch removes those 2 lines again to restore intent of commit c83a8542. Signed-off-by: Gerard Snitselaar --- drivers/usb/otg/tw

Re: [PATCH v1 11/11] arm: omap: phy: remove unused functions from omap-phy-internal.c

2012-07-09 Thread Rajendra Nayak
On Thursday 28 June 2012 05:21 PM, Kishon Vijay Abraham I wrote: All the unnessary functions in omap-phy-internal is removed. These functionality are now handled by omap-usb2 phy driver. Cc: Felipe Balbi Signed-off-by: Kishon Vijay Abraham I Acked-by: Tony Lindgren --- arch/arm/mach-omap2/omap

Re: [PATCH v1 05/11] drivers: usb: twl6030: Add dt support for twl6030 usb

2012-07-09 Thread ABRAHAM, KISHON VIJAY
Hi, On Tue, Jul 10, 2012 at 11:28 AM, Rajendra Nayak wrote: > On Thursday 28 June 2012 05:21 PM, Kishon Vijay Abraham I wrote: >> >> Add device tree support for twl6030 usb driver. >> Update the Documentation with device tree binding information. >> >> Signed-off-by: Kishon Vijay Abraham I >> ---

Re: [PATCH v1 10/11] arm/dts: omap: Add usb_otg and glue data

2012-07-09 Thread Rajendra Nayak
On Thursday 28 June 2012 05:21 PM, Kishon Vijay Abraham I wrote: Add usb otg data node in omap4/omap3 device tree file. Also update the node with board specific setting in omapx-.dts file. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/omap3-beagle.dts |6 ++ arch/arm/boo

Re: [PATCH 7/9] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping

2012-07-09 Thread Lee Jones
On 10/07/12 08:17, Dmitry Torokhov wrote: On Mon, Jul 09, 2012 at 10:59:43PM +0200, Lee Jones wrote: Sorry for the cock-up(s). From: Lee Jones Date: Tue, 26 Jun 2012 10:46:50 +0100 Subject: [PATCH 1/1] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping Before we can use any domain allocat

Re: [patch 08/11] mm: memcg: remove needless !mm fixup to init_mm when charging

2012-07-09 Thread Michal Hocko
On Tue 10-07-12 14:10:21, Wanpeng Li wrote: > On Mon, Jul 09, 2012 at 05:20:58PM +0200, Michal Hocko wrote: > >On Thu 05-07-12 02:45:00, Johannes Weiner wrote: > >> It does not matter to __mem_cgroup_try_charge() if the passed mm is > >> NULL or init_mm, it will charge the root memcg in either case

Re: [PATCH 7/9] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping

2012-07-09 Thread Dmitry Torokhov
On Mon, Jul 09, 2012 at 10:59:43PM +0200, Lee Jones wrote: > Sorry for the cock-up(s). > > From: Lee Jones > Date: Tue, 26 Jun 2012 10:46:50 +0100 > Subject: [PATCH 1/1] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping > > Before we can use any domain allocated IRQ, we need to first create

Re: [PATCH v1 08/11] arm/dts: Add twl4030-usb data

2012-07-09 Thread Rajendra Nayak
On Thursday 28 June 2012 05:21 PM, Kishon Vijay Abraham I wrote: Add twl4030-usb data node in twl4030 device tree file. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/twl4030.dtsi | 21 + 1 files changed, 21 insertions(+), 0 deletions(-) diff --git a/arch/a

Re: [RESEND/PATCHv5 1/2] drivers: input: keypad: Add device tree support

2012-07-09 Thread Dmitry Torokhov
Hi Sourav, On Fri, Jun 08, 2012 at 04:22:59PM +0530, Sourav Poddar wrote: > Update the Documentation with omap4 keypad device tree > binding information. > Add device tree support for omap4 keypad driver. > > Tested on omap4430 sdp. > Sorry for the delay, I have a few comments: > > /* p

Re: [PATCH 6/6] x86: Exit RCU extended QS on notify resume

2012-07-09 Thread Paul E. McKenney
On Fri, Jul 06, 2012 at 01:43:29PM -0700, Josh Triplett wrote: > On Fri, Jul 06, 2012 at 09:33:38AM -0700, Paul E. McKenney wrote: > > On Fri, Jul 06, 2012 at 02:00:18PM +0200, Frederic Weisbecker wrote: > > > --- a/arch/x86/Kconfig > > > +++ b/arch/x86/Kconfig > > > @@ -95,6 +95,7 @@ config X86 >

[PATCH v2 3/3] acpi : acpi_bus_trim() stops removing devices when failing to remove the device

2012-07-09 Thread Yasuaki Ishimatsu
acpi_bus_trim() stops removing devices, when acpi_bus_remove() return error number. But acpi_bus_remove() cannot return error number correctly. acpi_bus_remove() only return -EINVAL, when dev argument is NULL. Thus even if device cannot be removed correctly, acpi_bus_trim() ignores and continues to

Re: [patch 08/11] mm: memcg: remove needless !mm fixup to init_mm when charging

2012-07-09 Thread Wanpeng Li
On Mon, Jul 09, 2012 at 05:20:58PM +0200, Michal Hocko wrote: >On Thu 05-07-12 02:45:00, Johannes Weiner wrote: >> It does not matter to __mem_cgroup_try_charge() if the passed mm is >> NULL or init_mm, it will charge the root memcg in either case. You can also change the comment in __mem_cgroup_t

[PATCH v2 2/3] acpi : prevent cpu from becoming online

2012-07-09 Thread Yasuaki Ishimatsu
Even if acpi_processor_handle_eject() offlines cpu, there is a chance to online the cpu after that. So the patch closes the window by using get/put_online_cpus(). Why does the patch change _cpu_up() logic? The patch cares the race of hot-remove cpu and _cpu_up(). If the patch does not change it,

[PATCH v2 1/3] acpi : cpu hot-remove returns error when cpu_down() fails

2012-07-09 Thread Yasuaki Ishimatsu
Even if cpu_down() fails, acpi_processor_remove() continues to remove the cpu. But in this case, it should return error number since some process may run on the cpu. If the cpu has a running process and the cpu is turned the power off, the system may not work well. Signed-off-by: Yasuaki Ishimatsu

Re: [PATCH 1/4] staging:rts_pstor: Fix coding style issue in ms.c

2012-07-09 Thread Hitoshi NAKAMORI
Dear Greg. Thank you for your indication. I will rewrite this and send later. I'm sorry to let you have trouble. Regards -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.or

RE: [PATCH v1 01/11] drivers: usb: otg: add a new driver for omap usb2 phy

2012-07-09 Thread Venu Byravarasu
> > + > > +#ifdef CONFIG_PM Should it not be CONFIG_PM_SLEEP instead of just CONFIG_PM? > > + > > +static int omap_usb2_runtime_suspend(struct device *dev) > > +{ > > + struct platform_device *pdev = to_platform_device(dev); > > + struct omap_usb *phy = platform_get_drvdata(pdev); > > + >

Re: [PATCH v1 07/11] drivers: usb: twl4030: Add device tree support for twl4030 usb

2012-07-09 Thread Rajendra Nayak
On Thursday 28 June 2012 05:21 PM, Kishon Vijay Abraham I wrote: Add device tree support for twl6030 usb driver. twl4030? Update the Documentation with device tree binding information. Signed-off-by: Kishon Vijay Abraham I --- .../devicetree/bindings/usb/twl-usb.txt| 19 +

Re: [PATCH v1 05/11] drivers: usb: twl6030: Add dt support for twl6030 usb

2012-07-09 Thread Rajendra Nayak
On Thursday 28 June 2012 05:21 PM, Kishon Vijay Abraham I wrote: Add device tree support for twl6030 usb driver. Update the Documentation with device tree binding information. Signed-off-by: Kishon Vijay Abraham I --- .../devicetree/bindings/usb/twl-usb.txt| 18 drivers

linux-next: manual merge of the usb tree with the mfd tree

2012-07-09 Thread Stephen Rothwell
Hi Greg, Today's linux-next merge of the usb tree got a conflict in drivers/usb/host/ehci-omap.c between commit 2761a6394516 ("mfd: USB: Fix the omap-usb EHCI ULPI PHY reset fix issues") from the mfd tree and commit 1a49e2ac9651 ("EHCI: centralize controller initialization") from the usb tree. I

[PATCH 2/2] staging/sm7xxfb: return a proper err for smtc_alloc_fb_info failure

2012-07-09 Thread Devendra Naga
as smtc_alloc_fb_info can fail, but we are returning the 0, how? because the pci_enable_device succeeded, which makes the probe return 0, and may cause panics or some strange problems at remove when driver unloaded by modprobe -r. so return err properly as smtc_alloc_fb_info is doing kzallocs its

[PATCH 1/2] staging/sm7xxfb: use module_pci_driver macro

2012-07-09 Thread Devendra Naga
as the manual of module_pci_driver says that it can be used when the init and exit functions of the module does nothing but the pci_register_driver and pci_unregister_driver. use it for the sm7xxfb driver, as the driver does nothing in its _init and _exit functions but the register and unregister.

Re: [PATCH v1 01/11] drivers: usb: otg: add a new driver for omap usb2 phy

2012-07-09 Thread Rajendra Nayak
diff --git a/Documentation/devicetree/bindings/usb/omap-usb.txt b/Documentation/devicetree/bindings/usb/omap-usb.txt new file mode 100644 index 000..80a28c9 --- /dev/null +++ b/Documentation/devicetree/bindings/usb/omap-usb.txt @@ -0,0 +1,16 @@ +OMAP USB PHY + +OMAP USB2 PHY + +Required prope

Re: [PATCH net-next 6/6] r8169: support RTL8168G

2012-07-09 Thread Hayes Wang
fix incorrct argument in rtl_hw_init_8168g. Signed-off-by: Hayes Wang --- drivers/net/ethernet/realtek/r8169.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c index 7ff3423..c29c5fb 100644 ---

Re: [PATCH 2/2 v2] memory-hotplug: fix kswapd looping forever problem

2012-07-09 Thread Aaditya Kumar
On Mon, Jul 9, 2012 at 7:59 PM, Minchan Kim wrote: Hello Minchan, > May I add your tested-by in next spin which will include automatic type > conversion > problem ? Yeah sure. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.

linux-next: build failure after merge of the driver-core tree

2012-07-09 Thread Stephen Rothwell
Hi Greg, After merging the driver-core tree, today's linux-next build (x86_64 allmodconfig) failed like this: ERROR: "devm_gpio_request_one" [drivers/extcon/extcon-arizona.ko] undefined! Caused by commit 01eaf2458773 ("extcon: Convert extcon_gpio to devm_gpio_request_one"). devm_gpio_request_on

[PATCH] thermal: add Renesas R-Car thermal sensor support

2012-07-09 Thread Kuninori Morimoto
This patch add basic Renesas R-Car thermal sensor support. It was tested on R-Car H1 Marzen board. Signed-off-by: Kuninori Morimoto --- drivers/thermal/Kconfig|8 ++ drivers/thermal/Makefile |3 +- drivers/thermal/rcar_thermal.c | 239 ++

Re: [linux-pm] [PATCH v4 0/5] thermal: exynos: Add kernel thermal support for exynos platform

2012-07-09 Thread amit daniel kachhap
Hi Len, These set of patches were accepted by you for 3.5 merge window. Can you again apply them on your for-next branch for 3.6 merge? I have some arch enablement and clean up patches based on them. It is really important for me to mainline everything in this merge window. Thanks, Amit Daniel O

[PATCH] gpio/gpio-tps65910: gpio_chip.of_node referenced without CONFIG_OF_GPIO defined

2012-07-09 Thread Gerard Snitselaar
From: Jerry Snitselaar commit 626f9914 added code to initialize gpio_chip.of_node, but if CONFIG_OF_GPIO is not defined gps-tps65910 fails to build with an error complaining gpio_chip has no member of_node. I ran into this while doing a allyesconfig build on linux-next. Signed-off-by: Gerard Sni

Re: [PATCH 1/2] acpi : cpu hot-remove returns error number when cpu_down() fails

2012-07-09 Thread Yasuaki Ishimatsu
Hi Srivatsa, 2012/07/10 9:13, Yasuaki Ishimatsu wrote: > Hi Srivatsa, > > 2012/07/09 20:25, Srivatsa S. Bhat wrote: >> On 07/09/2012 08:01 AM, Yasuaki Ishimatsu wrote: >>> Hi Srivatsa, >>> >>> Thank you for your reviewing. >>> >>> 2012/07/06 18:51, Srivatsa S. Bhat wrote: On 07/06/2012 08:46

Re: + checkpatch-add-check-for-use-of-sizeof-without-parenthesis.patch added to -mm tree

2012-07-09 Thread Joe Perches
On Mon, 2012-07-09 at 19:21 -0700, David Rientjes wrote: > On Mon, 9 Jul 2012, Joe Perches wrote: > > > I don't really care what style a large block of code > > uses. I care that it mostly has the same form. > Same form?? The sizeof operator has two forms depending on whether it's a > unary ex

[PATCH V2] staging/ft1000: remove all spaces, tabs issue in while loop of ft1000_interrupt

2012-07-09 Thread Devendra Naga
all spaces in the main while loop of ft1000_interrupt are converted to tabs. Signed-off-by: Devendra Naga --- Greg, You mean to say this only right? drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c | 60 +++--- 1 file changed, 31 insertions(+), 29 deletions(-) diff --

[patch]block: stack unplug

2012-07-09 Thread Shaohua Li
MD raid1 prepares to dispatch request in unplug callback. If make_request in low level queue also uses unplug callback to dispatch request, the low level queue's unplug callback will not be called. Recheck the callback list helps this case. Signed-off-by: Shaohua Li diff --git a/block/blk-core.c

Re: [PATCH 1/2] acpi : cpu hot-remove returns error number when cpu_down() fails

2012-07-09 Thread Yasuaki Ishimatsu
Hi Toshi, 2012/07/10 6:15, Toshi Kani wrote: On Mon, 2012-07-09 at 16:55 +0530, Srivatsa S. Bhat wrote: On 07/09/2012 08:01 AM, Yasuaki Ishimatsu wrote: Hi Srivatsa, Thank you for your reviewing. 2012/07/06 18:51, Srivatsa S. Bhat wrote: On 07/06/2012 08:46 AM, Yasuaki Ishimatsu wrote: Eve

Re: Subject: [PATCH] tty ldisc: Close/Reopen race prevention should check the proper flag

2012-07-09 Thread Shachar Shemesh
On 07/09/2012 07:44 PM, Greg KH wrote: Yes, that worked, but then I would have to edit the body to include the above information in the patch properly. So, care to resend it all in a "clean" format that I can apply it in? thanks, greg k-h After a few tests, it seems the only reliable way to

Re: [PATCH 2/6] workqueue: factor out worker_pool from global_cwq

2012-07-09 Thread Namhyung Kim
Hi, Tejun Just nitpicks.. On Mon, 9 Jul 2012 11:41:51 -0700, Tejun Heo wrote: > Move worklist and all worker management fields from global_cwq into > the new struct worker_pool. worker_pool points back to the containing > gcwq. worker and cpu_workqueue_struct are updated to point to > worker_

Re: rcu_dyntick and suspicious RCU usage

2012-07-09 Thread Fengguang Wu
Hi Paul, Fortunately this bug is bisectable and the first bad commit is: commit 9b2e4f1880b789be1f24f9684f7a54b90310b5c0 Author: Paul E. McKenney Date: Fri Sep 30 12:10:22 2011 -0700 rcu: Track idleness independent of idle tasks However, at that commit, th

Re: [PATCH v4 1/5] thermal: Add generic cpufreq cooling implementation

2012-07-09 Thread amit kachhap
Hi Rob/Eduardo, As these patches have still not made into mainline. I will rebase the whole set along with your suggestion and send them shortly. Sorry for late reply. Thanks, Amit Daniel On Tue, Jun 26, 2012 at 1:12 PM, Valentin, Eduardo wrote: > Hey Rob and Amit, > > On Tue, Jun 26, 2012 at 6

Re: why Linux kernel will update BIOS's interrupt remapping table base address ? why does Linux Kernel create a new table instead of the one that BIOS provided ?

2012-07-09 Thread Yinghai Lu
On Mon, Jul 9, 2012 at 8:17 PM, Lin-Bao Zhang <2004.zh...@gmail.com> wrote: > for this thing , we have known that , we can append "x2apic_phys" to > tell linux kernel we support x2apic physical mode. > but I found that x2apic_phys is not enough .we still found panic info > in RHEL6.2(2.6.32) kernel

Re: [PATCH v3] ext4: fix hole punch failure when depth is greater than 0

2012-07-09 Thread Ashish Sangwan
Please ignore the last sent mail. I will re-send the patch in new mail chain. Thanks, Ashish On Tue, Jul 10, 2012 at 6:13 AM, Ashish Sangwan wrote: > Whether to continue removing extents or not is decided by the return value > of function ext4_ext_more_to_rm() which checks 2 conditions: > a) if t

Re: [PATCH v1] usb: host: Fix possible kernel crash

2012-07-09 Thread Venu Byravarasu
Thanks Alan for your comments. On Monday 09 July 2012 08:04 PM, Alan Stern wrote: On Mon, 9 Jul 2012, Venu Byravarasu wrote: In functions itd_complete & sitd_complete, a pointer by name stream may get dereferenced after freeing it, when iso_stream_put is called with stream->refcount = 2. I d

Re: [PATCH] net: cgroup: fix access the unallocated memory in netprio cgroup

2012-07-09 Thread Eric Dumazet
On Tue, 2012-07-10 at 10:31 +0800, Gao feng wrote: > there are some out of bound accesses in netprio cgroup. > when creating a new netprio cgroup,we only set a prioidx for > the new cgroup,without allocate memory for dev->priomap. > > because we don't want to see additional bound checkings in > fa

Re: Boot regression on Mackerel with current mainline

2012-07-09 Thread Chris Ball
Hi Guennadi, On Wed, Jul 04 2012, Guennadi Liakhovetski wrote: > On Tue, 3 Jul 2012, Rafael J. Wysocki wrote: > >> On Tuesday, July 03, 2012, Guennadi Liakhovetski wrote: >> > Hi Rafael >> > >> > On Tue, 3 Jul 2012, Rafael J. Wysocki wrote: >> > >> > > Hi, >> > > >> > > We seem to have a functi

[PATCH] apple-gmux: Restore switch registers on suspend/resume

2012-07-09 Thread Arun Raghavan
After suspend and resume, the values of these registers seem to change from what they were at suspend time, potentially preventing the actual output lines from being enabled post-resume. This saves relevant state at suspend and restores it when resumed. This is at least required on the MacBook Pro

Re: [PATCH 0/3] PCI: P2P bridge window fixes

2012-07-09 Thread Bjorn Helgaas
On Mon, Jul 9, 2012 at 2:31 PM, Bjorn Helgaas wrote: > Two fixes here: > > 1) Zero is a legal P2P bridge window base and BAR value and is likely to > occur when there is an offset between bus addresses and CPU addresses. > Stop disallowing it. > > 2) The Intel-specific 1K I/O window granularity fo

Re: [PATCH 0/2] PCI: decode disable fixes

2012-07-09 Thread Bjorn Helgaas
On Mon, Jul 9, 2012 at 12:20 PM, Bjorn Helgaas wrote: > Since 2.6.36 (253d2e5498), we've disabled MEM & IO decoding while we size > BARs (except for host bridge devices). These patches tweak this in two > ways: > > 1) We only kept decoding disabled while sizing the low-order dword > of 64-bit BAR

Re: [PATCH -v2 0/8] PCI: Add 'pci_fixup_final' quirks into hot-plug paths

2012-07-09 Thread Bjorn Helgaas
On Mon, Jul 9, 2012 at 3:35 PM, Myron Stowe wrote: > PCI's final quirks (pci_fixup_final) are currently invoked by > pci_apply_final_quirk() which traverses the platform's list of PCI > devices. The calling mechanism, and to some point the use of the device > list, limits the quirk invocations to

Re: why Linux kernel will update BIOS's interrupt remapping table base address ? why does Linux Kernel create a new table instead of the one that BIOS provided ?

2012-07-09 Thread Lin-Bao Zhang
for this thing , we have known that , we can append "x2apic_phys" to tell linux kernel we support x2apic physical mode. but I found that x2apic_phys is not enough .we still found panic info in RHEL6.2(2.6.32) kernel,but on linux kernel-3.4.4 ,no this issue again. any comment for this bug ? Initia

linux-next: build failure after merge of the net-next tree

2012-07-09 Thread Stephen Rothwell
Hi all, After merging the net-next tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/net/usb/qmi_wwan.c:381:13: error: 'qmi_wwan_unbind_shared' undeclared here (not in a function) Caused by a bad automatic merge between commit 6fecd35d4cd7 ("net: qmi_wwan: add ZTE M

Re: + checkpatch-add-check-for-use-of-sizeof-without-parenthesis.patch added to -mm tree

2012-07-09 Thread David Rientjes
On Mon, 9 Jul 2012, Linus Torvalds wrote: > sizeof without parenthesis is an abomination, and should never be used. > > Sure, you don't need to have the parenthesis (except when you do - for > actual types), but it's a parsing oddity. > > The sane solution is: just add the f*cking parenthesis, a

[PATCH 5/5] staging: csr: Remove unused macros

2012-07-09 Thread Marcos Paulo de Souza
These macros are not used, so remove it. Signed-off-by: Marcos Paulo de Souza --- drivers/staging/csr/csr_wifi_hip_card_sdio.c |3 --- drivers/staging/csr/drv.c|1 - drivers/staging/csr/firmware.c |1 - drivers/staging/csr/mlme.c |

[PATCH 4/5] staging: csr: unifi_sme.c: Remove unused macros

2012-07-09 Thread Marcos Paulo de Souza
These macros are not used, so remove it. Signed-off-by: Marcos Paulo de Souza --- drivers/staging/csr/unifi_sme.c |6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/csr/unifi_sme.c b/drivers/staging/csr/unifi_sme.c index 6e7cbbf..5ad1d5f 100644 --- a/drivers/staging/csr/

[PATCH 2/5] staging: csr: csr_util.h: Remove commented macros

2012-07-09 Thread Marcos Paulo de Souza
All these macros are commented, so we can removed it. Signed-off-by: Marcos Paulo de Souza --- drivers/staging/csr/csr_util.h |7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/csr/csr_util.h b/drivers/staging/csr/csr_util.h index ce39c7e..5cd6cb4 100644 --- a/drivers/s

Re: [PATCH 0/3] staging: bcm: Cleanup bcm driver

2012-07-09 Thread Marcos Souza
2012/7/9 Kevin McKinney : > On Mon, Jul 09, 2012 at 10:32:37PM -0300, Marcos Paulo de Souza wrote: >> Hi Kernel guys! >> >> This new patchset tries to clean a little the bcm driver, removing >> some unused macros and some dead code. >> >> These macros and dead code were reported by the forgotten-ma

[PATCH 3/5] staging: csr: netdev.c: Remove unused macros

2012-07-09 Thread Marcos Paulo de Souza
These macros are not used, so we can remove it. Signed-off-by: Marcos Paulo de Souza --- drivers/staging/csr/netdev.c |5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/csr/netdev.c b/drivers/staging/csr/netdev.c index cf19f11..55149df 100644 --- a/drivers/staging/csr/net

[PATCH 1/5] staging: csr: Remove dead code

2012-07-09 Thread Marcos Paulo de Souza
All this code is dead, so remove it. Signed-off-by: Marcos Paulo de Souza --- drivers/staging/csr/monitor.c | 57 drivers/staging/csr/unifi_native.h | 19 2 files changed, 76 deletions(-) diff --git a/drivers/staging/csr/monitor.c b/dri

[PATCH 0/5] staging: csr: Cleanup driver

2012-07-09 Thread Marcos Paulo de Souza
Hi kernel guys! This patchset aims to clean a little the csr driver by removing dead code and unused/commented macros. All the macros and dead code was reported by the forgotten-macros tool (https://github.com/marcosps/forgotten_macros). This patchset is against staging-next. I hope you like it

Re: [PATCH 0/3] staging: bcm: Cleanup bcm driver

2012-07-09 Thread Kevin McKinney
On Mon, Jul 09, 2012 at 10:32:37PM -0300, Marcos Paulo de Souza wrote: > Hi Kernel guys! > > This new patchset tries to clean a little the bcm driver, removing > some unused macros and some dead code. > > These macros and dead code were reported by the forgotten-macros tool > (https://github

Re: [PATCH] net: cgroup: fix out of bounds accesses

2012-07-09 Thread David Miller
From: Gao feng Date: Tue, 10 Jul 2012 10:33:23 +0800 > Please see my patch in this thread, I think it's a better way to fix this bug. You'll need to work that out with Eric, fwiw I think his patch was clean and just fine and it's staying in my tree. -- To unsubscribe from this list: send the lin

Re: [PATCH 3/4] zsmalloc: add details to zs_map_object boiler plate

2012-07-09 Thread Minchan Kim
On 07/03/2012 06:15 AM, Seth Jennings wrote: > Add information on the usage limits of zs_map_object() > > Signed-off-by: Seth Jennings > --- > drivers/staging/zsmalloc/zsmalloc-main.c |7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/zsmalloc/zsma

Re: [PATCH] net: cgroup: fix out of bounds accesses

2012-07-09 Thread Gao feng
于 2012年07月10日 05:51, David Miller 写道: > From: Gao feng > Date: Mon, 09 Jul 2012 16:15:29 +0800 > >> 于 2012年07月09日 15:45, Eric Dumazet 写道: >>> From: Eric Dumazet >>> >>> dev->priomap is allocated by extend_netdev_table() called from >>> update_netdev_tables(). >>> And this is only called if write

[PATCH] net: cgroup: fix access the unallocated memory in netprio cgroup

2012-07-09 Thread Gao feng
there are some out of bound accesses in netprio cgroup. when creating a new netprio cgroup,we only set a prioidx for the new cgroup,without allocate memory for dev->priomap. because we don't want to see additional bound checkings in fast path, so I think the best way is to allocate memory when we

RE: [PATCH V3 5/6] Avoid duplicate probe for of platform devices

2012-07-09 Thread Jia Hongtao-B38951
> -Original Message- > From: Rob Herring [mailto:robherri...@gmail.com] > Sent: Monday, July 09, 2012 9:58 PM > To: Li Yang-R58472 > Cc: Jia Hongtao-B38951; Greg KH; devicetree-disc...@lists.ozlabs.org; > linux-kernel@vger.kernel.org > Subject: Re: [PATCH V3 5/6] Avoid duplicate probe for

Re: + checkpatch-add-check-for-use-of-sizeof-without-parenthesis.patch added to -mm tree

2012-07-09 Thread Linus Torvalds
On Mon, Jul 9, 2012 at 6:50 PM, David Rientjes wrote: > > This doesn't suggest parenthesis for sizeof at all times sizeof without parenthesis is an abomination, and should never be used. Sure, you don't need to have the parenthesis (except when you do - for actual types), but it's a parsing oddi

Re: [PATCH 2/4] zsmalloc: add single-page object fastpath in unmap

2012-07-09 Thread Minchan Kim
On 07/03/2012 06:15 AM, Seth Jennings wrote: > Improve zs_unmap_object() performance by adding a fast path for > objects that don't span pages. > > Signed-off-by: Seth Jennings > --- > drivers/staging/zsmalloc/zsmalloc-main.c | 15 ++- > 1 file changed, 10 insertions(+), 5 deletion

Re: + checkpatch-add-check-for-use-of-sizeof-without-parenthesis.patch added to -mm tree

2012-07-09 Thread David Rientjes
On Mon, 9 Jul 2012, Joe Perches wrote: > I don't really care what style a large block of code > uses. I care that it mostly has the same form. > Same form?? The sizeof operator has two forms depending on whether it's a unary expression or a type as specified by the standard. The issue here i

Re: [PATCH 1/4] zsmalloc: remove x86 dependency

2012-07-09 Thread Minchan Kim
On 07/03/2012 06:15 AM, Seth Jennings wrote: > This patch replaces the page table assisted object mapping > method, which has x86 dependencies, with a arch-independent > method that does a simple copy into a temporary per-cpu > buffer. > > While a copy seems like it would be worse than mapping the

Re: [PATCH v2] fail dentry revalidation after namespace change

2012-07-09 Thread Andrew Morton
On Mon, 09 Jul 2012 18:51:37 -0700 ebied...@xmission.com (Eric W. Biederman) wrote: > Andrew Morton writes: > > > On Mon, 09 Jul 2012 17:30:48 -0700 ebied...@xmission.com (Eric W. > > Biederman) wrote: > > > >> Andrew Morton writes: > >> > >> >> { > >> >> struct sysfs_dirent *sd; >

RE: [PATCH V2 3/7] regulator: s5m8767: Modify function and variable name

2012-07-09 Thread Sangbeom Kim
Hi Monday, July 09, 2012 10:03 PM +0900, Mark Brown wrote: > This needs to be squashed down into the patch doing the rename in the > core to avoid build breakage. Otherwise looks good. Ok, I will squash and resend it. Thanks, Sangbeom. -- To unsubscribe from this list: send the line "unsubscri

Re: [PATCH] cgroup: fix dentry still in use bug when dropping css refs after umount

2012-07-09 Thread Li Zefan
On 2012/7/8 14:35, Tejun Heo wrote: > Hello, Li. > > On Wed, Jul 04, 2012 at 02:19:15PM +0800, Li Zefan wrote: >>> I think we're horridly broken for >>> root cgroup tho - and it has been broken for very long time. I think >>> it's mostly hidden because most (all?) controllers short-circuit root

Re: [PATCH v2] mm/hugetlb: fix error code in hugetlbfs_alloc_inode

2012-07-09 Thread Wanpeng Li
On Mon, Jul 09, 2012 at 07:02:39PM -0700, David Rientjes wrote: >On Tue, 10 Jul 2012, Wanpeng Li wrote: > >> diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c >> index c4b85d0..79a0f33 100644 >> --- a/fs/hugetlbfs/inode.c >> +++ b/fs/hugetlbfs/inode.c >> @@ -696,7 +696,7 @@ static struct ino

Re: + checkpatch-add-check-for-use-of-sizeof-without-parenthesis.patch added to -mm tree

2012-07-09 Thread Joe Perches
On Mon, 2012-07-09 at 18:50 -0700, David Rientjes wrote: > On Mon, 9 Jul 2012, Joe Perches wrote: > > > CodingStyle already does suggest parenthesis around sizeof > > > > 3.1: Spaces > > > > Linux kernel style for use of spaces depends (mostly) on > > function-versus-keyword usage. Use a space

RE: [PATCH V2 0/7] Initial release of Samsung S2MPS11 pmic driver

2012-07-09 Thread Sangbeom Kim
Hi! On Mon, Jul 09, 2012 at 08:13PM +0900, Samuel Ortiz wrote: > Hi Sangbeom, > > On Sat, Jul 07, 2012 at 06:39:12PM +0900, Sangbeom Kim wrote: > > The S2MPS11 is comprised of high efficient Buck converters, > > various LDOs, and an RTC and tightly coupled with Multi Core Samsung > > Application P

Re: [PATCH v2] mm/hugetlb: fix error code in hugetlbfs_alloc_inode

2012-07-09 Thread David Rientjes
On Tue, 10 Jul 2012, Wanpeng Li wrote: > diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c > index c4b85d0..79a0f33 100644 > --- a/fs/hugetlbfs/inode.c > +++ b/fs/hugetlbfs/inode.c > @@ -696,7 +696,7 @@ static struct inode *hugetlbfs_alloc_inode(struct > super_block *sb) > p = kmem_c

Re: [PATCH] mm/hugetlb: fix error code in hugetlbfs_alloc_inode

2012-07-09 Thread David Rientjes
On Tue, 10 Jul 2012, Wanpeng Li wrote: > >>diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c > >>index c4b85d0..79a0f33 100644 > >>--- a/fs/hugetlbfs/inode.c > >>+++ b/fs/hugetlbfs/inode.c > >>@@ -696,7 +696,7 @@ static struct inode *hugetlbfs_alloc_inode(struct > >>super_block *sb) > >>

Re: [PATCH v2] fail dentry revalidation after namespace change

2012-07-09 Thread Eric W. Biederman
Andrew Morton writes: > On Mon, 09 Jul 2012 17:30:48 -0700 ebied...@xmission.com (Eric W. Biederman) > wrote: > >> Andrew Morton writes: >> >> >> { >> >> struct sysfs_dirent *sd; >> >> int is_dir; >> >> + int type; >> >> >> >> if (nd->flags & LOOKUP_RCU) >> >> return -ECHILD

Re: + checkpatch-add-check-for-use-of-sizeof-without-parenthesis.patch added to -mm tree

2012-07-09 Thread David Rientjes
On Mon, 9 Jul 2012, Joe Perches wrote: > CodingStyle already does suggest parenthesis around sizeof > > 3.1: Spaces > > Linux kernel style for use of spaces depends (mostly) on > function-versus-keyword usage. Use a space after (most) keywords. The > notable exceptions are sizeof, typeof, ali

Re: linux-next: build failure after merge of the ext4 tree

2012-07-09 Thread Aditya Kali
739:4: error: implicit declaration of function > 'ext4_enable_quotas' [-Werror=implicit-function-declaration] > > Caused by commit 182bb8fec8f5 ("ext4: make quota as first class supported > feature"). The quota code needs to be protected by CONFIG_QUOTA. > > I hav

Re: [PATCH 01/13] rbtree: reference Documentation/rbtree.txt for usage instructions

2012-07-09 Thread Rik van Riel
On 07/09/2012 07:35 PM, Michel Lespinasse wrote: include/linux/rbtree.h included some basic usage instructions, while Documentation/rbtree.txt had some more complete and easier to follow instructions. Replacing the former with a reference to the latter. Signed-off-by: Michel Lespinasse Acked-

btrfs_inode.h and Oracle

2012-07-09 Thread Chris Jones
Just checking out some btrfs stuff and notices the copyright notes in btfrs_inode.h belong to Oracle. I had no idea that btrfs had anything to do with Oracle. What's the link with Oracle? Regards -- Chris Jones @ kernel.devproj...@gmail.com also on oracle.kernel...@gmail.com a

[PATCH 3/3] staging: bcm: Misc.c: Remove unused macros

2012-07-09 Thread Marcos Paulo de Souza
These macros were reported by forgotten-macros tool (https://github.com/marcosps/forgotten_macros). Signed-off-by: Marcos Paulo de Souza --- drivers/staging/bcm/Misc.c |3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/bcm/Misc.c b/drivers/staging/bcm/Misc.c index d7c662d..

  1   2   3   4   5   6   7   8   >