Re: [PATCH v7 2/2] clocksource: add J-Core timer/clocksource driver

2016-10-01 Thread Paul E. McKenney
On Sat, Oct 01, 2016 at 08:00:49PM -0400, Rich Felker wrote: > On Sat, Oct 01, 2016 at 10:58:37AM -0700, Paul E. McKenney wrote: > > On Sat, Oct 01, 2016 at 01:05:08PM -0400, Rich Felker wrote: > > > On Fri, Sep 30, 2016 at 06:48:35AM -0700, Paul E. McKenney wrote: > > > > On Fri, Sep 30, 2016 at 0

arch/ia64/kernel/entry.S:621: Error: Operand 2 of `adds' should be a 14-bit integer (-8192-8191)

2016-10-01 Thread kbuild test robot
Hi Will, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: f51fdffad5b7709d0ade40736b58a2da2707fa15 commit: da48d094ce5d7c7dcdad9011648a81c42fd1c2ef Kconfig: remove HAVE_LATENCYTOP_SUPPORT date: 9 months ago config:

[PATCH] drm: Release resources with a safer function

2016-10-01 Thread Christophe JAILLET
We should use 'ida_simple_remove()' instead of 'ida_remove()' when freeing resources allocated with 'ida_simple_get()'. This as been spotted with the following coccinelle script which tries to detect missing 'ida_simple_remove()' call in error handling paths. /// @@ expression x; iden

Re: [PATCH v7 2/2] clocksource: add J-Core timer/clocksource driver

2016-10-01 Thread Paul E. McKenney
On Sat, Oct 01, 2016 at 11:59:25PM -0400, Rich Felker wrote: > On Sat, Oct 01, 2016 at 08:00:49PM -0400, Rich Felker wrote: > > > > > > > - During the whole sequence, hrtimer expiration times are being > > > > > > > set to > > > > > > > exact jiffies (@ 100 Hz), whereas before it they're quite

[PATCH] staging: sm750fb: rename macro roundedDiv to rounded_div in ddk750_chip.c

2016-10-01 Thread Moshe Green
Rename CamelCased macro roundedDiv to rounded_div. This issue was found by checkpatch.pl Signed-off-by: Moshe Green --- drivers/staging/sm750fb/ddk750_chip.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750f

Re: [PATCH v7 2/2] clocksource: add J-Core timer/clocksource driver

2016-10-01 Thread Rich Felker
On Sat, Oct 01, 2016 at 08:00:49PM -0400, Rich Felker wrote: > > > > > > - During the whole sequence, hrtimer expiration times are being set > > > > > > to > > > > > > exact jiffies (@ 100 Hz), whereas before it they're quite > > > > > > arbitrary. > > > > > > > > > > When a CPU goes into NOHZ

[PATCH perf/core] perf script: fix a use after free crash.

2016-10-01 Thread Krister Johansen
If dso__load_kcore frees all of the existing maps, but one has already been attached to a callchain cursor node, then we can get a SIGSEGV in any function that happens to try to use this cursor with the invalid map. Use the existing map refcount mechanism to forestall cleanup of a map until the cu

arch/mips/vdso/gettimeofday.c:1:0: error: '-march=r3900' requires '-mfp32'

2016-10-01 Thread kbuild test robot
Hi Guenter, First bad commit (maybe != root cause): tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: f51fdffad5b7709d0ade40736b58a2da2707fa15 commit: 398c7500a1f5f74e207bd2edca1b1721b3cc1f1e MIPS: VDSO: Fix build error with binutils 2.24 and earlier date

arch/mips/vdso/elf.S:1:0: error: '-march=r3900' requires '-mfp32'

2016-10-01 Thread kbuild test robot
Hi Alex, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: f51fdffad5b7709d0ade40736b58a2da2707fa15 commit: ebb5e78cc63417a35254a791de66e1cc84f963cc MIPS: Initial implementation of a VDSO date: 11 months ago config:

[PATCH] selftests/futex: Check ANSI terminal color support

2016-10-01 Thread SeongJae Park
Because test for color support of the running shell does not aware ANSI type terminals, it does not print colorful messages on some environemnt. This commit modifies the test to aware ANSI type terminal, too. Signed-off-by: SeongJae Park --- tools/testing/selftests/futex/functional/run.sh | 2 +-

[PATCH] padata: add helper function for queue length

2016-10-01 Thread Jason A. Donenfeld
Since padata has a maximum number of inflight jobs, currently 1000, it's very useful to know how many jobs are currently queued up. This adds a simple helper function to expose this information. Signed-off-by: Jason A. Donenfeld --- include/linux/padata.h | 2 ++ kernel/padata.c| 16 +++

vgacon.c:undefined reference to `screen_info'

2016-10-01 Thread kbuild test robot
Hi Chen, It's probably a bug fix that unveils the link errors. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: f51fdffad5b7709d0ade40736b58a2da2707fa15 commit: f69405ce6c0fc9f4a039011007371b31f80b470d openrisc: include: asm: Kbuild: add default "vga.h"

include/linux/kprobes.h:361:2: error: invalid use of undefined type 'struct kprobe_ctlblk'

2016-10-01 Thread kbuild test robot
Hi Russell, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: f51fdffad5b7709d0ade40736b58a2da2707fa15 commit: b2c0b2cbb282f0cf42518ffacbe197e6f2884168 nmi: create generic NMI backtrace implementation date: 1 year,

[PATCH] ARM: dts: vfxxx: Add node corresponding to OCOTP

2016-10-01 Thread Andrey Smirnov
Add node corresponding to OCOTP IP block. Signed-off-by: Andrey Smirnov --- arch/arm/boot/dts/vfxxx.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/boot/dts/vfxxx.dtsi b/arch/arm/boot/dts/vfxxx.dtsi index 2c13ec6..75850c0 100644 --- a/arch/arm/boot/dts/vfxxx.dtsi +++ b/ar

[PATCH] ARM: dts: vf610-zii-dev-rev-b: Remove I2C3

2016-10-01 Thread Andrey Smirnov
I2C3 bus was only brought out in revision A1 of the board and revision B1 only brings out 3 I2C busses (I2C0, I2C1 and I2C2). Signed-off-by: Andrey Smirnov --- arch/arm/boot/dts/vf610-zii-dev-rev-b.dts | 14 -- 1 file changed, 14 deletions(-) diff --git a/arch/arm/boot/dts/vf610-zii

drivers/gpu/drm/i915/i915_gem_gtt.c:2367: error: 'gtt_entry' may be used uninitialized in this function

2016-10-01 Thread kbuild test robot
Hi Dave, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: f51fdffad5b7709d0ade40736b58a2da2707fa15 commit: 85d1225ec066b2ef46fbd0ed1bae78ae1f3e6c91 drm/i915: Introduce & use new lightweight SGL iterators date: 5 mo

Re: [PATCH v3 07/13] futex: Throughput-optimized (TP) futexes

2016-10-01 Thread Waiman Long
On 10/01/2016 02:47 AM, Thomas Gleixner wrote: On Fri, 30 Sep 2016, Waiman Long wrote: + WRITE_ONCE(state->owner, current); + preempt_disable(); + for (;;) { + ret = futex_trylock(uaddr, vpid,&uval, true); Did you actually read what I said? You CANNOT access user

Re: [PATCH RFC 2/5] x86,fpu: delay FPU register loading until switch to userspace

2016-10-01 Thread Rik van Riel
On Sat, 2016-10-01 at 16:44 -0700, Andy Lutomirski wrote: > On Sat, Oct 1, 2016 at 1:31 PM,   wrote: > >  > > > > +static inline void switch_fpu_finish(void) > >  { > > +   set_thread_flag(TIF_LOAD_FPU); > >  } > > I can imagine this causing problems with kernel code that accesses > current's

Re: [PATCH v2 1/1] mm/percpu.c: fix potential memory leakage for pcpu_embed_first_chunk()

2016-10-01 Thread zijun_hu
Hi Tejun, as we discussed, i include some discussion content in the commit message. could you give some new comments or acknowledgment for this patch? On 2016/9/30 19:30, zijun_hu wrote: > From: zijun_hu > > it will cause memory leakage for pcpu_embed_first_chunk() to go to > label @out_free i

Re: [PATCH RFC 2/5] x86,fpu: delay FPU register loading until switch to userspace

2016-10-01 Thread Rik van Riel
On Sat, 2016-10-01 at 16:44 -0700, Andy Lutomirski wrote: > On Sat, Oct 1, 2016 at 1:31 PM,   wrote: > >  > >  #define CREATE_TRACE_POINTS > >  #include > > @@ -197,6 +198,9 @@ __visible inline void > > prepare_exit_to_usermode(struct pt_regs *regs) > > if (unlikely(cached_flags & EXIT_TO_

Re: [PATCH v7 2/2] clocksource: add J-Core timer/clocksource driver

2016-10-01 Thread Rich Felker
On Sat, Oct 01, 2016 at 10:58:37AM -0700, Paul E. McKenney wrote: > On Sat, Oct 01, 2016 at 01:05:08PM -0400, Rich Felker wrote: > > On Fri, Sep 30, 2016 at 06:48:35AM -0700, Paul E. McKenney wrote: > > > On Fri, Sep 30, 2016 at 03:15:11PM +0200, Thomas Gleixner wrote: > > > > On Tue, 27 Sep 2016,

[PATCH] fnic: Use time64_t to represent trace timestamps

2016-10-01 Thread Deepa Dinamani
trace timestamps use struct timespec and CURRENT_TIME which are not y2038 safe. These timestamps are only part of the trace log on the machine and are not shared with the fnic. Replace then with y2038 safe struct timespec64 and ktime_get_real_ts64(), respectively. Signed-off-by: Deepa Dinamani Re

[PATCH] fs: nfs: Make nfs boot time y2038 safe

2016-10-01 Thread Deepa Dinamani
boot_time is represented as a struct timespec. struct timespec and CURRENT_TIME are not y2038 safe. Overall, the plan is to use timespec64 and ktime_t for all internal kernel representation of timestamps. CURRENT_TIME will also be removed. boot_time is used to construct the nfs client boot verifie

net/sunrpc/stats.c:204: undefined reference to `_GLOBAL_OFFSET_TABLE_'

2016-10-01 Thread kbuild test robot
Hi Nicolas, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: f51fdffad5b7709d0ade40736b58a2da2707fa15 commit: 461a5e51060c93f5844113f4be9dba513cc92830 do_div(): generic optimization for constant divisor on 32-bit mac

Re: [PATCH RFC 2/5] x86,fpu: delay FPU register loading until switch to userspace

2016-10-01 Thread Andy Lutomirski
On Sat, Oct 1, 2016 at 1:31 PM, wrote: > From: Rik van Riel > > Delay the loading of FPU registers until a process switches back to > userspace. This allows us to skip FPU saving & restoring for kernel > threads, the idle task, and tasks that are spinning in kernel space. > > It also allows us t

[PATCH] audit: Use timespec64 to represent audit timestamps

2016-10-01 Thread Deepa Dinamani
struct timespec is not y2038 safe. Audit timestamps are recorded in string format into an audit buffer for a given context. These mark the entry timestamps for the syscalls. Use y2038 safe struct timespec64 to represent the times. The log strings can handle this transition as strings can hold upto

[PATCH] fs: ocfs2: Replace CURRENT_TIME macro

2016-10-01 Thread Deepa Dinamani
CURRENT_TIME is not y2038 safe. Use y2038 safe ktime_get_real_seconds() here for timestamps. struct heartbeat_block's hb_seq and deletetion time are already 64 bits wide and accommodate times beyond y2038. Also use y2038 safe ktime_get_real_ts64() for on disk inode timestamps. These are also wide

[PATCH] fs: ocfs2: Use time64_t to represent orphan scan times

2016-10-01 Thread Deepa Dinamani
struct timespec is not y2038 safe. Use time64_t which is y2038 safe to represent orphan scan times. time64_t is sufficient here as only the seconds delta times are relevant. Also use appropriate time functions that return time in time64_t format. Time functions now return monotonic time instead of

Re: [PATCH v4 2/5] driver core: Functional dependencies tracking support

2016-10-01 Thread Rafael J. Wysocki
On Sat, Oct 1, 2016 at 9:43 AM, Lukas Wunner wrote: > On Thu, Sep 29, 2016 at 02:38:04AM +0200, Rafael J. Wysocki wrote: >> +static int device_reorder_to_tail(struct device *dev, void *not_used) >> +{ >> + struct device_link *link; >> + >> + /* >> + * Devices that have not been regist

[PATCH] fs: f2fs: Use ktime_get_real_seconds for sit_info times

2016-10-01 Thread Deepa Dinamani
CURRENT_TIME_SEC is not y2038 safe. Replace use of CURRENT_TIME_SEC with ktime_get_real_seconds in segment timestamps used by GC algorithm including the segment mtime timestamps. Signed-off-by: Deepa Dinamani Reviewed-by: Arnd Bergmann Cc: Jaegeuk Kim Cc: Changman Lee Cc: linux-f2fs-de...@lis

Re: [PATCH RFC 1/5] x86,fpu: split prev/next task fpu state handling

2016-10-01 Thread Andy Lutomirski
On Oct 1, 2016 1:49 PM, wrote: > > From: Rik van Riel > > Move all handling of the next state FPU state handling into > switch_fpu_finish, in preparation for more lazily switching > FPU states. > > CR0.TS state is mirrored in a per-cpu variable, instead of > being passed around in a local variabl

Re: [PATCH] realtek: rtl8xxxu: Use const init arrays

2016-10-01 Thread Jes Sorensen
Joe Perches writes: > On Sat, 2016-10-01 at 16:32 -0400, Jes Sorensen wrote: >> Your output shows it moving to the text segment - if it's in a different >> segment, eg. rodata, you should use output demonstrating that to justify >> the change. > > For size, rodata _is_ text Well then maybe use so

cris-linux-objcopy: error: the input file 'arch/cris/boot/rescue/rescue.o' has no sections

2016-10-01 Thread kbuild test robot
Hi Joe, First bad commit (maybe != root cause): tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: f51fdffad5b7709d0ade40736b58a2da2707fa15 commit: cb984d101b30eb7478d32df56a0023e4603cba7f compiler-gcc: integrate the various compiler-gcc[345].h files date:

Re: [PATCH] fs: btrfs: Use ktime_get_real_ts for root ctime

2016-10-01 Thread David Sterba
On Sat, Oct 01, 2016 at 10:23:34AM -0700, Deepa Dinamani wrote: > btrfs_root_item maintains the ctime for root updates. > This is not part of vfs_inode. > > Since current_time() uses struct inode* as an argument > as Linus suggested, this cannot be used to update root > times unless, we modify the

[PATCH] usb: xhci: add support for performing fake doorbell

2016-10-01 Thread Rafał Miłecki
From: Rafał Miłecki Broadcom's Northstar XHCI controllers seem to need a special start procedure to work correctly. There isn't any official documentation on this, the problem is that controller doesn't detect any connected devices with default setup. Moreover connecting USB device to controller

Re: [PATCH] realtek: rtl8xxxu: Use const init arrays

2016-10-01 Thread Joe Perches
On Sat, 2016-10-01 at 16:32 -0400, Jes Sorensen wrote: > Your output shows it moving to the text segment - if it's in a different > segment, eg. rodata, you should use output demonstrating that to justify > the change. For size, rodata _is_ text

Re: [PATCH] Coccinelle: limit memdup_user transformation to GFP_KERNEL case

2016-10-01 Thread Michal Marek
Dne 21.9.2016 v 17:48 Julia Lawall napsal(a): > Memdup_user encapsulates a memory allocation with the flag GFP_KERNEL, so > only allow this flag in the original code. > > Signed-off-by: Julia Lawall Applied to kbuild.git#misc. Thanks, Michal

Re: [PATCH] Coccinelle: pm_runtime: ensure relevance of pm_runtime reports

2016-10-01 Thread Michal Marek
Dne 22.9.2016 v 10:28 Julia Lawall napsal(a): > pm_runtime.cocci starts with one rule that searches for a variety of > functions calls, followed by various rules that report errors. Previously, > the only connection between the first rule and the rest was to check that > the first rule had matched

[PATCH] [media] : Removing warnings caught by checkpatch.pl

2016-10-01 Thread Harman Kalra
Removing warnings caught by checkpatch.pl Signed-off-by: Harman Kalra --- drivers/staging/media/omap4iss/iss_video.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/media/omap4iss/iss_video.c b/drivers/staging/media/omap4iss/iss_video.c index c1692

[PATCH 01/15 v2] UBIFS: improve function-level documentation

2016-10-01 Thread Julia Lawall
Fix various inconsistencies in the documentation associated with various functions. In the case of fs/ubifs/lprops.c, the second parameter of ubifs_get_lp_stats was renamed from st to lst in commit 84abf972ccff ("UBIFS: add re-mount debugging checks") In the case of fs/ubifs/lpt_commit.c, the exc

[PATCH RFC 4/5] x86,fpu: lazily skip FPU restore when still loaded

2016-10-01 Thread riel
From: Rik van Riel When the FPU register set has not been touched by anybody else, we can lazily skip the restore. Intel has a number of clever optimizations to reduce the FPU restore overhead, but those optimizations do not work across the guest/host virtualization boundary, and even on bare me

[PATCH RFC 2/5] x86,fpu: delay FPU register loading until switch to userspace

2016-10-01 Thread riel
From: Rik van Riel Delay the loading of FPU registers until a process switches back to userspace. This allows us to skip FPU saving & restoring for kernel threads, the idle task, and tasks that are spinning in kernel space. It also allows us to not repeatedly save & restore the userspace FPU con

[PATCH 14/15 v2] irqchip/metag-ext: improve function-level documentation

2016-10-01 Thread Julia Lawall
Drop the variable irq which ceased to be a parameter in commit bd0b9ac405e1 ("genirq: Remove irq argument from irq flow handlers") Issue detected using Coccinelle (http://coccinelle.lip6.fr/) Signed-off-by: Julia Lawall Acked-by: James Hogan --- v2: correct commit reference, independent of the

[PATCH RFC 3/5] x86,fpu: add kernel fpu argument to __kernel_fpu_begin

2016-10-01 Thread riel
From: Rik van Riel Most kernel FPU contexts are transient, but a KVM VCPU context persists. Add a kernel FPU argument to __kernel_fpu_begin, so we can know whether or not the KVM VCPU context got clobbered by another kernel FPU context. Signed-off-by: Rik van Riel --- arch/x86/include/asm/efi

[PATCH RFC 1/5] x86,fpu: split prev/next task fpu state handling

2016-10-01 Thread riel
From: Rik van Riel Move all handling of the next state FPU state handling into switch_fpu_finish, in preparation for more lazily switching FPU states. CR0.TS state is mirrored in a per-cpu variable, instead of being passed around in a local variable, because that will not be possible later in th

[PATCH RFC 5/5] x86,fpu: kinda sorta fix up signal path

2016-10-01 Thread riel
From: Rik van Riel Need to ensure that the FPU save code and the lazy restore code do not use invalid kernel or floating point register state and copy it over to the other location. I am pretty sure this is incomplete. Signed-off-by: Rik van Riel --- arch/x86/kernel/fpu/core.c | 1 + arch/x

[PATCH RFC 0/5] x86,fpu: make FPU context switching much lazier

2016-10-01 Thread riel
This series is an attempt at making the x86 FPU context switching code much lazier. By only reloading the FPU context when a task switches to user mode, we can avoid switching FPU context for tasks that spin in kernel mode, and avoid reloading the FPU context for tasks that get interrupted by a ke

Re: [PATCH 0/2] Moving runnable code from Documentation (last 2 patches)

2016-10-01 Thread Michal Marek
Dne 1.10.2016 v 09:10 Jonathan Corbet napsal(a): > On Fri, 30 Sep 2016 07:57:51 -0600 > Shuah Khan wrote: > >>> This patch series contains the last 2 patches to complete moving runnable >>> code from Documentation to selftests, samples, and tools. >>> >>> The first patch moves blackfin gptimers-e

Re: [PATCH] Input: synaptics-rmi4 - Fix error handling in I2C transport driver

2016-10-01 Thread Guenter Roeck
On 10/01/2016 12:04 PM, Dmitry Torokhov wrote: On Sat, Oct 01, 2016 at 10:27:42AM -0700, Andrew Duggan wrote: On Fri, Sep 30, 2016, at 08:44 PM, Guenter Roeck wrote: On 09/30/2016 04:02 PM, Dmitry Torokhov wrote: On Fri, Sep 30, 2016 at 03:54:03PM -0700, Dmitry Torokhov wrote: On Thu, Sep 2

Re: [PATCH 00/15] improve function-level documentation

2016-10-01 Thread Julia Lawall
On Sat, 1 Oct 2016, Joe Perches wrote: > On Sat, 2016-10-01 at 21:46 +0200, Julia Lawall wrote: > > These patches fix cases where the documentation above a function definition > > is not consistent with the function header. Issues are detected using the > > semantic patch below (http://coccinel

Re: [PATCH 14/15] irqchip/metag-ext: improve function-level documentation

2016-10-01 Thread James Hogan
Hi Julia, On 1 October 2016 at 20:46, Julia Lawall wrote: > Drop the variable irq which ceased to be a parameter in bd0b9ac4. I think 12 nibbles of the hash is recommended now due to collisions, as is quoting the subject line, e.g. commit bd0b9ac405e1 ("genirq: Remove irq argument from irq flow

Re: [PATCH] realtek: rtl8xxxu: Use const init arrays

2016-10-01 Thread Jes Sorensen
Joe Perches writes: > On Sat, 2016-10-01 at 14:53 -0400, Jes Sorensen wrote: >> Joe Perches writes: >> > Make the init arrays const to reduce data. >> > $ size drivers/net/wireless/realtek/rtl8xxxu/built-in.o* >> > (allyesconfig: x86-32) >> >   text data bss dec hex filename >>

Re:Humanitarian Services.

2016-10-01 Thread Mrs. Kimberly Hills
I am Mrs. Kimberly Hills the wife of late Engineer William Hills We has been married for years before his sudden death although we were childless. I have been diagnosed with cancer and I have been battling with the sickness when my late lovely husband was alive. My Husband left the sum of US

Re: [PATCH 00/15] improve function-level documentation

2016-10-01 Thread Joe Perches
On Sat, 2016-10-01 at 21:46 +0200, Julia Lawall wrote: > These patches fix cases where the documentation above a function definition > is not consistent with the function header. Issues are detected using the > semantic patch below (http://coccinelle.lip6.fr/). Basically, the semantic > patch par

[PATCH 00/15] improve function-level documentation

2016-10-01 Thread Julia Lawall
These patches fix cases where the documentation above a function definition is not consistent with the function header. Issues are detected using the semantic patch below (http://coccinelle.lip6.fr/). Basically, the semantic patch parses a file to find comments, then matches each function header,

[PATCH] fs: cifs: Replace CURRENT_TIME by get_seconds

2016-10-01 Thread Deepa Dinamani
This is in preparation for the change that transitions filesystem timestamps to use 64 bit time and hence make them y2038 safe. CURRENT_TIME macro will be deleted before merging the aforementioned patch. Filesystems will use current_time() instead of CURRENT_TIME. Use ktime_get_real_seconds() her

[PATCH 01/15] UBIFS: improve function-level documentation

2016-10-01 Thread Julia Lawall
Fix various inconsistencies in the documentation associated with various functions. In the case of fs/ubifs/lprops.c, the second parameter of ubifs_get_lp_stats was renamed from st to lst in 84abf972. In the case of fs/ubifs/lpt_commit.c, the excess variables have never existed in the associated

[PATCH 05/15] dma-buf/sw_sync: improve function-level documentation

2016-10-01 Thread Julia Lawall
Adjust the documentation to use the names that appear in the function parameter list. Issue detected using Coccinelle (http://coccinelle.lip6.fr/) Signed-off-by: Julia Lawall --- drivers/dma-buf/sw_sync.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/dma-

[PATCH 04/15] lru_cache: improve function-level documentation

2016-10-01 Thread Julia Lawall
Use the actual function name and reorder the listed variables to correspond to their order in the function parameter list. Issue detected using Coccinelle (http://coccinelle.lip6.fr/) Signed-off-by: Julia Lawall --- lib/lru_cache.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[PATCH 11/15] kobject: improve function-level documentation

2016-10-01 Thread Julia Lawall
In the first case, rename the second variable to correspond to the name found in the function parameter list. In the remaining cases, reorder the variables to correspond to their order in the parameter list. Issue detected using Coccinelle (http://coccinelle.lip6.fr/) Signed-off-by: Julia Lawall

[PATCH 09/15] gma500: improve function-level documentation

2016-10-01 Thread Julia Lawall
Delete a reference to a variable that has never been used by the function in the first case, and rename a variable to that of the corresponding parameter name in the second case. Issue detected using Coccinelle (http://coccinelle.lip6.fr/) Signed-off-by: Julia Lawall --- drivers/gpu/drm/gma500

[PATCH 10/15] clk: keystone: improve function-level documentation

2016-10-01 Thread Julia Lawall
Adjust the documentation to use the actual function names. Issue detected using Coccinelle (http://coccinelle.lip6.fr/) Signed-off-by: Julia Lawall --- drivers/clk/keystone/pll.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/keystone/pll.c b/drivers/clk

[PATCH 06/15] mfd: tc3589x: improve function-level documentation

2016-10-01 Thread Julia Lawall
Use the correct function name in one case and adjust a variable name to that of the corresponding function parameter in another case. Issue detected using Coccinelle (http://coccinelle.lip6.fr/) Signed-off-by: Julia Lawall --- drivers/mfd/tc3589x.c |4 ++-- 1 file changed, 2 insertions(+),

[PATCH 08/15] power: improve function-level documentation

2016-10-01 Thread Julia Lawall
In drivers/power/supply/ab8500_fg.c, fix two typos and adjust the function name in two cases to correspond to the names of the defined functions. In drivers/power/supply/power_supply_core.c, change two variable names to the names of the corresponding parameters. Issue detected using Coccinelle (h

[PATCH 13/15] irqchip: vic: improve function-level documentation

2016-10-01 Thread Julia Lawall
The associated function, vic_init_cascaded, has never had a variable irq_start. Issue detected using Coccinelle (http://coccinelle.lip6.fr/) Signed-off-by: Julia Lawall --- drivers/irqchip/irq-vic.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/irqchip/irq-vic.c b/drivers/irqch

[PATCH 07/15] clk: sunxi: mod0: improve function-level documentation

2016-10-01 Thread Julia Lawall
Use the actual function name in the function documentation. Issue detected using Coccinelle (http://coccinelle.lip6.fr/) Signed-off-by: Julia Lawall --- drivers/clk/sunxi/clk-mod0.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/sunxi/clk-mod0.c b/drivers/cl

[PATCH 15/15] drm/omap: improve function-level documentation

2016-10-01 Thread Julia Lawall
Use the names of the corresponding functions. Issue detected using Coccinelle (http://coccinelle.lip6.fr/) Signed-off-by: Julia Lawall --- drivers/gpu/drm/omapdrm/omap_drv.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c b/drivers

[PATCH 12/15] clk: tegra: dfll: improve function-level documentation

2016-10-01 Thread Julia Lawall
Adjust variables to correspond to the names used in the parameter list of the function. Move the struct device * variable up to the place where it appears in the parameter list. Issue detected using Coccinelle (http://coccinelle.lip6.fr/) Signed-off-by: Julia Lawall --- drivers/clk/tegra/cvb.

[PATCH 14/15] irqchip/metag-ext: improve function-level documentation

2016-10-01 Thread Julia Lawall
Drop the variable irq which ceased to be a parameter in bd0b9ac4. Issue detected using Coccinelle (http://coccinelle.lip6.fr/) Signed-off-by: Julia Lawall --- drivers/irqchip/irq-metag-ext.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/irqchip/irq-metag-ext.c b/drivers/irqchip

[PATCH 03/15] fscrypto: improve function-level documentation

2016-10-01 Thread Julia Lawall
Correct spelling mistakes in the documentation associated with two functions in fs/crypto/crypto.c. Use actual function names in the documentation associated with two functions in fs/crypto/fname.c. Issue detected using Coccinelle (http://coccinelle.lip6.fr/) Signed-off-by: Julia Lawall --- f

[PATCH 02/15] netlink: improve function-level documentation

2016-10-01 Thread Julia Lawall
Rename a variable in the documentation so that it corresponds to the name of the function parameter. Issue detected using Coccinelle (http://coccinelle.lip6.fr/) Signed-off-by: Julia Lawall --- lib/nlattr.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/nlattr.c b/l

[PATCH] fs: cifs: Replace CURRENT_TIME with ktime_get_real_ts()

2016-10-01 Thread Deepa Dinamani
This is in preparation for the patch that transitions vfs timestamps to use 64 bit time and hence make them y2038 safe. CURRENT_TIME macro will be deleted before merging the aforementioned patch. Filesystem times will use current_fs_time() instead of CURRENT_TIME. Use ktime_get_real_ts() here as

Re: [PATCH] realtek: rtl8xxxu: Use const init arrays

2016-10-01 Thread Joe Perches
On Sat, 2016-10-01 at 14:53 -0400, Jes Sorensen wrote: > Joe Perches writes: > > Make the init arrays const to reduce data. > > $ size drivers/net/wireless/realtek/rtl8xxxu/built-in.o* (allyesconfig: > > x86-32) > >   textdata bss dec hex filename > >   80107 13651

[PATCH RESEND 2/3] tpm: replace dynamically allocated bios_dir with a static array

2016-10-01 Thread Jarkko Sakkinen
This commit is based on a commit by Nayna Jain. Replaced dynamically allocated bios_dir with a static array as the size is always constant. Suggested-by: Jason Gunthorpe Signed-off-by: Nayna Jain Signed-off-by: Jarkko Sakkinen --- drivers/char/tpm/tpm-chip.c | 9 +++--- drivers/char/tpm/t

[PATCH RESEND 3/3] tpm: drop tpm1_chip_register(/unregister)

2016-10-01 Thread Jarkko Sakkinen
Check for TPM2 chip in tpm_sysfs_add_device, tpm_bios_log_setup and tpm_bios_log_teardown in order to make code flow cleaner and to enable to implement TPM 2.0 support later on. This is partially derived from the commit by Nayna Jain with the extension that also tpm1_chip_register is dropped. Sign

[PATCH RESEND 0/3] Clean up handling of event log files

2016-10-01 Thread Jarkko Sakkinen
Meld a common function for opening measurements files and keep the dentries in a static array. Jarkko Sakkinen (2): tpm: replace dynamically allocated bios_dir with a static array tpm: drop tpm1_chip_register(/unregister) Nayna Jain (1): tpm: define a generic open() method for ascii & bios

[PATCH RESEND 1/3] tpm: define a generic open() method for ascii & bios measurements

2016-10-01 Thread Jarkko Sakkinen
From: Nayna Jain open() method for event log ascii and binary bios measurements file operations are very similar. This patch refactors the code into a single open() call by passing seq_operations as i_node->private data. Suggested-by: Jason Gunthorpe Signed-off-by: Nayna Jain Reviewed-by: Jark

Re: [PATCH 2/2] tpm: replace dynamically allocated bios_dir with a static array

2016-10-01 Thread Jarkko Sakkinen
On Sat, Oct 01, 2016 at 10:49:32AM -0600, Jason Gunthorpe wrote: > On Sat, Oct 01, 2016 at 03:41:17PM +0300, Jarkko Sakkinen wrote: > > - bin_file = > > + chip->bios_dir[cnt] = > > securityfs_create_file("binary_bios_measurements", > > - S_IRUSR | S_IRGRP, t

Re: [PATCH] Input: synaptics-rmi4 - Fix error handling in I2C transport driver

2016-10-01 Thread Dmitry Torokhov
On Sat, Oct 01, 2016 at 10:27:42AM -0700, Andrew Duggan wrote: > > > On Fri, Sep 30, 2016, at 08:44 PM, Guenter Roeck wrote: > > On 09/30/2016 04:02 PM, Dmitry Torokhov wrote: > > > On Fri, Sep 30, 2016 at 03:54:03PM -0700, Dmitry Torokhov wrote: > > >> On Thu, Sep 29, 2016 at 10:55:40AM -0700, B

Re: [PATCH] net: Use ns_capable_noaudit() when determining net sysctl permissions

2016-10-01 Thread Dmitry Torokhov
On Sat, Oct 01, 2016 at 03:25:04AM -0400, David Miller wrote: > From: Dmitry Torokhov > Date: Fri, 30 Sep 2016 15:24:31 -0700 > > > From: Tyler Hicks > > > > The capability check should not be audited since it is only being used > > to determine the inode permissions. A failed check does not in

[PATCH 2/2] ipc/sem: Add hysteresis.

2016-10-01 Thread Manfred Spraul
sysv sem has two lock modes: One with per-semaphore locks, one lock mode with a single global lock for the whole array. When switching from the per-semaphore locks to the global lock, all per-semaphore locks must be scanned for ongoing operations. The patch adds a hysteresis for switching from the

[PATCH 1/2] ipc/sem.c: Avoid using spin_unlock_wait()

2016-10-01 Thread Manfred Spraul
a) The ACQUIRE in spin_lock() applies to the read, not to the store, at least for powerpc. This forces to add a smp_mb() into the fast path. b) The memory barrier provided by spin_unlock_wait() is right now arch dependent. Therefore: Use spin_lock()/spin_unlock() instead of spin_unlock_wait(). A

[PATCH 0/2] ipc/sem.c: sem_lock fixes

2016-10-01 Thread Manfred Spraul
Hi Andrew, Hi Peter, Hi Davidlohr, New idea for ipc/sem: The ACQUIRE from spin_lock() will continue to apply only for the load, not for the store. Thus: If we don't want to add arch dependencies into ipc/sem, the only safe option is to use spin_lock()/spin_unlock() instead of spin_unlock_wait().

Re: [PATCH] realtek: rtl8xxxu: Use const init arrays

2016-10-01 Thread Jes Sorensen
Joe Perches writes: > Make the init arrays const to reduce data. > > $ size drivers/net/wireless/realtek/rtl8xxxu/built-in.o* (allyesconfig: > x86-32) >text data bss dec hex filename > 80107 13651 58 93816 16e78 > drivers/net/wireless/realtek/rtl8xxxu/

[PATCH v2 6/6] arm: dts: imx7-colibri: Use enable-gpios for BL_ON

2016-10-01 Thread Bhuvanchandra DV
Use pwm-backlight driver 'enable-gpios' property for backlight on/off control. Signed-off-by: Bhuvanchandra DV --- arch/arm/boot/dts/imx7-colibri.dtsi | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx7-colibri.dtsi b/arch/arm/boot/dts/imx7-colib

Re: [RFC] arm64: Enforce observed order for spinlock and data

2016-10-01 Thread Mark Rutland
Hi Brent, Evidently my questions weren't sufficiently clear; even with your answers it's not clear to me what precise issue you're attempting to solve. I've tried to be more specific this time. At a high-level, can you clarify whether you're attempting to solve is: (a) a functional correctness i

Re: [PATCH v7 2/2] clocksource: add J-Core timer/clocksource driver

2016-10-01 Thread Paul E. McKenney
On Sat, Oct 01, 2016 at 01:05:08PM -0400, Rich Felker wrote: > On Fri, Sep 30, 2016 at 06:48:35AM -0700, Paul E. McKenney wrote: > > On Fri, Sep 30, 2016 at 03:15:11PM +0200, Thomas Gleixner wrote: > > > On Tue, 27 Sep 2016, Rich Felker wrote: > > > > I've managed to get a trace with a stall. I'm n

Re: [PATCH] Input: synaptics-rmi4 - Fix error handling in I2C transport driver

2016-10-01 Thread Andrew Duggan
On Sat, Oct 1, 2016, at 10:45 AM, Guenter Roeck wrote: > On 10/01/2016 10:27 AM, Andrew Duggan wrote: > > > > > > On Fri, Sep 30, 2016, at 08:44 PM, Guenter Roeck wrote: > >> On 09/30/2016 04:02 PM, Dmitry Torokhov wrote: > >>> On Fri, Sep 30, 2016 at 03:54:03PM -0700, Dmitry Torokhov wrote: > >>

Re: 4.7 regression: ACPI: No IRQ available for PCI Interrupt Link [LNKD]. Try pci=noacpi or acpi=off

2016-10-01 Thread Sinan Kaya
On 9/30/2016 5:27 PM, Rafael J. Wysocki wrote: >>> >> What's the drawback, if any? >> > >> > I don't see any drawback to be honest. > I'd go for it then, if Bjorn doesn't hate it. > I posted a follow up patch a minute ago. [PATCH 1/3] Revert "ACPI,PCI,IRQ: reduce static IRQ array size to 16" [P

[PATCH 3/3] Revert "ACPI,PCI,IRQ: remove SCI penalize function"

2016-10-01 Thread Sinan Kaya
This reverts commit 9e5ed6d1fb87 ("ACPI,PCI,IRQ: remove SCI penalize function"). SCI penalty API was replaced by the runtime penalty calculation based on the value of acpi_gbl_FADT.sci_interrupt. acpi_gbl_FADT.sci_interrupt type does not get updated at the right time for some platforms and results

[PATCH 1/3] Revert "ACPI,PCI,IRQ: reduce static IRQ array size to 16"

2016-10-01 Thread Sinan Kaya
This reverts commit 5c5087a55390 ("ACPI,PCI,IRQ: reduce static IRQ array size to 16"). The code maintains a fixed size array for IRQ penalties. The array gets updated by external calls such as acpi_penalize_sci_irq, acpi_penalize_isa_irq to reflect the actual interrupt usage of the system. Since t

[PATCH 2/3] ACPI, PCI IRQ: add PCI_USING penalty for ISA interrupts

2016-10-01 Thread Sinan Kaya
The change introduced in commit 103544d86976 ("ACPI,PCI,IRQ: reduce resource requirements") removed PCI_USING penalty from acpi_pci_link_allocate function as there is no longer a fixed size penalty array for both PCI and IRQ interrupts. We need to add the PCI_USING penalty for ISA interrupts too i

Re: [PATCH] Input: synaptics-rmi4 - Fix error handling in I2C transport driver

2016-10-01 Thread Guenter Roeck
On 10/01/2016 10:27 AM, Andrew Duggan wrote: On Fri, Sep 30, 2016, at 08:44 PM, Guenter Roeck wrote: On 09/30/2016 04:02 PM, Dmitry Torokhov wrote: On Fri, Sep 30, 2016 at 03:54:03PM -0700, Dmitry Torokhov wrote: On Thu, Sep 29, 2016 at 10:55:40AM -0700, Bjorn Andersson wrote: On Wed 28 Sep

[PATCH] realtek: rtl8xxxu: Use const init arrays

2016-10-01 Thread Joe Perches
Make the init arrays const to reduce data. $ size drivers/net/wireless/realtek/rtl8xxxu/built-in.o* (allyesconfig: x86-32) textdata bss dec hex filename 80107 13651 58 93816 16e78 drivers/net/wireless/realtek/rtl8xxxu/built-in.o.new 65303 28435 58 93796

Re: [PATCH 0/4] ARM: davinci: Remove DMA resources for MMC/SPI

2016-10-01 Thread Sekhar Nori
On Wednesday 28 September 2016 04:05 PM, Peter Ujfalusi wrote: > Hi, > > The drivers for davinci MMC and SPI have been converted to the new DMAengine > API > and no longer rely on the IORESOURCE_DMA. > This is the case for at least one release cycle so now we can remove the > IORESOURCE_DMA for t

Re: [PATCH] Input: synaptics-rmi4 - Fix error handling in I2C transport driver

2016-10-01 Thread Andrew Duggan
On Fri, Sep 30, 2016, at 08:44 PM, Guenter Roeck wrote: > On 09/30/2016 04:02 PM, Dmitry Torokhov wrote: > > On Fri, Sep 30, 2016 at 03:54:03PM -0700, Dmitry Torokhov wrote: > >> On Thu, Sep 29, 2016 at 10:55:40AM -0700, Bjorn Andersson wrote: > >>> On Wed 28 Sep 17:37 PDT 2016, Guenter Roeck wro

[PATCH] fs: btrfs: Use ktime_get_real_ts for root ctime

2016-10-01 Thread Deepa Dinamani
btrfs_root_item maintains the ctime for root updates. This is not part of vfs_inode. Since current_time() uses struct inode* as an argument as Linus suggested, this cannot be used to update root times unless, we modify the signature to use inode. Since btrfs uses nanosecond time granularity, it c

Re: [PATCH v7 2/2] clocksource: add J-Core timer/clocksource driver

2016-10-01 Thread Rich Felker
On Fri, Sep 30, 2016 at 06:48:35AM -0700, Paul E. McKenney wrote: > On Fri, Sep 30, 2016 at 03:15:11PM +0200, Thomas Gleixner wrote: > > On Tue, 27 Sep 2016, Rich Felker wrote: > > > I've managed to get a trace with a stall. I'm not sure what the best > > > way to share the full thing is, since it'

[PATCH] fs: ufs: Use ktime_get_real_ts64() for birthtime

2016-10-01 Thread Deepa Dinamani
CURRENT_TIME is not y2038 safe. Replace it with ktime_get_real_ts64(). Inode time formats are already 64 bit long and accommodates time64_t. Signed-off-by: Deepa Dinamani Cc: Evgeniy Dushistov --- fs/ufs/ialloc.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/fs/ufs/i

Re: [PATCH net v2] L2TP:Adjust intf MTU,factor underlay L3,overlay L2

2016-10-01 Thread James Chapman
On 30/09/16 03:39, R. Parameswaran wrote: > >>> + /* Adjust MTU, factor overhead - underlay L3 hdr, overlay L2 hdr*/ >>> + if (tunnel->sock->sk_family == AF_INET) >>> + overhead += (ETH_HLEN + sizeof(struct iphdr)); >>> + else if (tunnel->sock->sk_family == AF_INET6) >>> +

  1   2   >