Re: [PATCH v4 2/2] tpm: add support for partial reads

2018-11-17 Thread Jarkko Sakkinen
On Fri, Nov 16, 2018 at 09:51:51AM -0800, Tadeusz Struk wrote: > Currently to read a response from the TPM device an application needs > provide big enough buffer for the whole response and read it in one go. > The application doesn't know how big the response it beforehand so it > always needs to

Re: [PATCH v4 2/2] tpm: add support for partial reads

2018-11-17 Thread Jarkko Sakkinen
On Fri, Nov 16, 2018 at 09:51:51AM -0800, Tadeusz Struk wrote: > Currently to read a response from the TPM device an application needs > provide big enough buffer for the whole response and read it in one go. > The application doesn't know how big the response it beforehand so it > always needs to

Re: [PATCH 1/2] tpm: rename data_pending to transmit_result

2018-11-17 Thread Jarkko Sakkinen
On Fri, Nov 16, 2018 at 09:51:13AM -0800, Tadeusz Struk wrote: > The file_priv->data_pending name is not adequate as it > doesn't contain any data, but the result from the last > successful call to tpm_transmit() function, so rename it > to transmit_result. Also its type should be size_t instead >

Re: [PATCH 1/2] tpm: rename data_pending to transmit_result

2018-11-17 Thread Jarkko Sakkinen
On Fri, Nov 16, 2018 at 09:51:13AM -0800, Tadeusz Struk wrote: > The file_priv->data_pending name is not adequate as it > doesn't contain any data, but the result from the last > successful call to tpm_transmit() function, so rename it > to transmit_result. Also its type should be size_t instead >

Re: [PATCH v8 16/17] tpm: take TPM chip power gating out of tpm_transmit()

2018-11-17 Thread Jarkko Sakkinen
On Fri, Nov 16, 2018 at 12:02:17PM -0500, Stefan Berger wrote: > On 11/16/18 7:38 AM, Jarkko Sakkinen wrote: > > Call tpm_chip_start() and tpm_chip_stop() in > > > > * tpm_try_get_ops() and tpm_put_ops() > > * tpm_chip_register() > > * tpm2_del_space() > > > > And remove these calls from

Re: [PATCH v8 16/17] tpm: take TPM chip power gating out of tpm_transmit()

2018-11-17 Thread Jarkko Sakkinen
On Fri, Nov 16, 2018 at 12:02:17PM -0500, Stefan Berger wrote: > On 11/16/18 7:38 AM, Jarkko Sakkinen wrote: > > Call tpm_chip_start() and tpm_chip_stop() in > > > > * tpm_try_get_ops() and tpm_put_ops() > > * tpm_chip_register() > > * tpm2_del_space() > > > > And remove these calls from

Re: [PATCH v8 08/17] tpm: call tpm2_flush_space() on error in tpm_try_transmit()

2018-11-17 Thread Jarkko Sakkinen
On Fri, Nov 16, 2018 at 11:19:57AM -0500, Sasha Levin wrote: > On Fri, Nov 16, 2018 at 02:38:32PM +0200, Jarkko Sakkinen wrote: > > Always call tpm2_flush_space() on failure in tpm_try_transmit() so that > > the volatile memory of the TPM gets cleared. If /dev/tpm0 does not have > > sufficient

Re: [PATCH v8 08/17] tpm: call tpm2_flush_space() on error in tpm_try_transmit()

2018-11-17 Thread Jarkko Sakkinen
On Fri, Nov 16, 2018 at 11:19:57AM -0500, Sasha Levin wrote: > On Fri, Nov 16, 2018 at 02:38:32PM +0200, Jarkko Sakkinen wrote: > > Always call tpm2_flush_space() on failure in tpm_try_transmit() so that > > the volatile memory of the TPM gets cleared. If /dev/tpm0 does not have > > sufficient

Re: [PATCH v5 6/7] tpm: ensure that the output of PCR read contains the correct digest size

2018-11-17 Thread Jarkko Sakkinen
On Fri, Nov 16, 2018 at 05:06:48PM +0100, Roberto Sassu wrote: > On 11/16/2018 2:41 PM, Jarkko Sakkinen wrote: > > On Wed, Nov 14, 2018 at 04:31:07PM +0100, Roberto Sassu wrote: > > > This patch protects against data corruption that could happen in the bus, > > > by checking that that the digest

Re: [PATCH v5 6/7] tpm: ensure that the output of PCR read contains the correct digest size

2018-11-17 Thread Jarkko Sakkinen
On Fri, Nov 16, 2018 at 05:06:48PM +0100, Roberto Sassu wrote: > On 11/16/2018 2:41 PM, Jarkko Sakkinen wrote: > > On Wed, Nov 14, 2018 at 04:31:07PM +0100, Roberto Sassu wrote: > > > This patch protects against data corruption that could happen in the bus, > > > by checking that that the digest

Re: [PATCH v5 7/7] tpm: pass an array of tpm_bank_list structures to tpm_pcr_extend()

2018-11-17 Thread Jarkko Sakkinen
On Fri, Nov 16, 2018 at 04:55:36PM +0100, Roberto Sassu wrote: > I understood from a previous email that you want to include all API > changes for crypto agility in the same patch set. Hmm.. maybe there is some misunderstading. Can you point me to the comment? Thanks. /Jarkko

Re: [PATCH v5 7/7] tpm: pass an array of tpm_bank_list structures to tpm_pcr_extend()

2018-11-17 Thread Jarkko Sakkinen
On Fri, Nov 16, 2018 at 04:55:36PM +0100, Roberto Sassu wrote: > I understood from a previous email that you want to include all API > changes for crypto agility in the same patch set. Hmm.. maybe there is some misunderstading. Can you point me to the comment? Thanks. /Jarkko

Re: [PATCH v5 7/7] tpm: pass an array of tpm_bank_list structures to tpm_pcr_extend()

2018-11-17 Thread Jarkko Sakkinen
On Fri, Nov 16, 2018 at 04:55:36PM +0100, Roberto Sassu wrote: > On 11/16/2018 4:03 PM, Jarkko Sakkinen wrote: > > On Wed, Nov 14, 2018 at 04:31:08PM +0100, Roberto Sassu wrote: > > > Currently, tpm_pcr_extend() accepts as an input only a SHA1 digest. > > > > > > This patch modifies the

Re: [PATCH v5 7/7] tpm: pass an array of tpm_bank_list structures to tpm_pcr_extend()

2018-11-17 Thread Jarkko Sakkinen
On Fri, Nov 16, 2018 at 04:55:36PM +0100, Roberto Sassu wrote: > On 11/16/2018 4:03 PM, Jarkko Sakkinen wrote: > > On Wed, Nov 14, 2018 at 04:31:08PM +0100, Roberto Sassu wrote: > > > Currently, tpm_pcr_extend() accepts as an input only a SHA1 digest. > > > > > > This patch modifies the

Re: RFC: userspace exception fixups

2018-11-17 Thread Jarkko Sakkinen
On Sun, Nov 18, 2018 at 09:15:48AM +0200, Jarkko Sakkinen wrote: > On Thu, Nov 01, 2018 at 10:53:40AM -0700, Andy Lutomirski wrote: > > Hi all- > > > > The people working on SGX enablement are grappling with a somewhat > > annoying issue: the x86 EENTER instruction is used from user code and > >

Re: RFC: userspace exception fixups

2018-11-17 Thread Jarkko Sakkinen
On Sun, Nov 18, 2018 at 09:15:48AM +0200, Jarkko Sakkinen wrote: > On Thu, Nov 01, 2018 at 10:53:40AM -0700, Andy Lutomirski wrote: > > Hi all- > > > > The people working on SGX enablement are grappling with a somewhat > > annoying issue: the x86 EENTER instruction is used from user code and > >

Re: RFC: userspace exception fixups

2018-11-17 Thread Jarkko Sakkinen
On Thu, Nov 01, 2018 at 10:53:40AM -0700, Andy Lutomirski wrote: > Hi all- > > The people working on SGX enablement are grappling with a somewhat > annoying issue: the x86 EENTER instruction is used from user code and > can, as part of its normal-ish operation, raise an exception. It is > also

Re: RFC: userspace exception fixups

2018-11-17 Thread Jarkko Sakkinen
On Thu, Nov 01, 2018 at 10:53:40AM -0700, Andy Lutomirski wrote: > Hi all- > > The people working on SGX enablement are grappling with a somewhat > annoying issue: the x86 EENTER instruction is used from user code and > can, as part of its normal-ish operation, raise an exception. It is > also

Re: [PATCH v1 2/2] i2c: i2c-stm32f7: SYSCFG Fast Mode Plus support for I2C STM32F7

2018-11-17 Thread kbuild test robot
Hi Pierre-Yves, I love your patch! Yet something to improve: [auto build test ERROR on wsa/i2c/for-next] [also build test ERROR on v4.20-rc2 next-20181116] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v1 2/2] i2c: i2c-stm32f7: SYSCFG Fast Mode Plus support for I2C STM32F7

2018-11-17 Thread kbuild test robot
Hi Pierre-Yves, I love your patch! Yet something to improve: [auto build test ERROR on wsa/i2c/for-next] [also build test ERROR on v4.20-rc2 next-20181116] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v1 2/2] i2c: i2c-stm32f7: SYSCFG Fast Mode Plus support for I2C STM32F7

2018-11-17 Thread kbuild test robot
Hi Pierre-Yves, I love your patch! Yet something to improve: [auto build test ERROR on wsa/i2c/for-next] [also build test ERROR on v4.20-rc2 next-20181116] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v1 2/2] i2c: i2c-stm32f7: SYSCFG Fast Mode Plus support for I2C STM32F7

2018-11-17 Thread kbuild test robot
Hi Pierre-Yves, I love your patch! Yet something to improve: [auto build test ERROR on wsa/i2c/for-next] [also build test ERROR on v4.20-rc2 next-20181116] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v1 2/5] perf cs-etm: Avoid stale branch samples when flush packet

2018-11-17 Thread leo . yan
On Fri, Nov 16, 2018 at 04:05:11PM -0700, Mathieu Poirier wrote: [...] > > -static int cs_etm__flush(struct cs_etm_queue *etmq) > > +static int cs_etm__flush(struct cs_etm_queue *etmq, bool new_packet) > > { > > int err = 0; > > struct cs_etm_auxtrace *etm = etmq->etm; > > @@ -989,6

Re: [PATCH v1 2/5] perf cs-etm: Avoid stale branch samples when flush packet

2018-11-17 Thread leo . yan
On Fri, Nov 16, 2018 at 04:05:11PM -0700, Mathieu Poirier wrote: [...] > > -static int cs_etm__flush(struct cs_etm_queue *etmq) > > +static int cs_etm__flush(struct cs_etm_queue *etmq, bool new_packet) > > { > > int err = 0; > > struct cs_etm_auxtrace *etm = etmq->etm; > > @@ -989,6

Re: [PATCH 3/8] kbuild: refactor modversions build rules

2018-11-17 Thread Masahiro Yamada
Hi Sam, On Sat, Nov 17, 2018 at 5:01 AM Sam Ravnborg wrote: > > Hi Masahiro > > On Thu, Nov 15, 2018 at 05:27:10PM +0900, Masahiro Yamada wrote: > > Let $(CC) compile objects into normal files *.o instead of .tmp_*.o > > whether CONFIG_MODVERSIONS is enabled or not. This will help simplify > >

Re: [PATCH 3/8] kbuild: refactor modversions build rules

2018-11-17 Thread Masahiro Yamada
Hi Sam, On Sat, Nov 17, 2018 at 5:01 AM Sam Ravnborg wrote: > > Hi Masahiro > > On Thu, Nov 15, 2018 at 05:27:10PM +0900, Masahiro Yamada wrote: > > Let $(CC) compile objects into normal files *.o instead of .tmp_*.o > > whether CONFIG_MODVERSIONS is enabled or not. This will help simplify > >

[PATCH v2 2/7] staging:iio:ad2s90: Remove spi setup that should be done via dt

2018-11-17 Thread Matheus Tavares
The ad2s90 driver currently sets some spi settings (max_speed_hz and mode) at ad2s90_probe. Since the maximum frequency is a required element in DT binding for spi slave devices and because the spi mode for the device can be either (0,0) or (1,1), these settings should be handled via device tree,

[PATCH v2 6/7] staging:iio:ad2s90: Add comment to device state mutex

2018-11-17 Thread Matheus Tavares
From: Victor Colombo Fix the checkpatch.pl issue: "CHECK: struct mutex definition without comment". Signed-off-by: Victor Colombo Signed-off-by: Matheus Tavares --- Changes in v2: - Patch added in v2 drivers/staging/iio/resolver/ad2s90.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH v2 4/7] dt-bindings:iio:resolver: Add docs for ad2s90

2018-11-17 Thread Matheus Tavares
This patch adds the device tree binding documentation for the ad2s90 resolver-to-digital converter. Signed-off-by: Matheus Tavares --- Changes in v2: - Rewritten 'spi-cpol and spi-cpha' item to say that the device can work in either mode (0,0) or (1,1) and explain how they should be specified

[PATCH v2 2/7] staging:iio:ad2s90: Remove spi setup that should be done via dt

2018-11-17 Thread Matheus Tavares
The ad2s90 driver currently sets some spi settings (max_speed_hz and mode) at ad2s90_probe. Since the maximum frequency is a required element in DT binding for spi slave devices and because the spi mode for the device can be either (0,0) or (1,1), these settings should be handled via device tree,

[PATCH v2 6/7] staging:iio:ad2s90: Add comment to device state mutex

2018-11-17 Thread Matheus Tavares
From: Victor Colombo Fix the checkpatch.pl issue: "CHECK: struct mutex definition without comment". Signed-off-by: Victor Colombo Signed-off-by: Matheus Tavares --- Changes in v2: - Patch added in v2 drivers/staging/iio/resolver/ad2s90.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH v2 4/7] dt-bindings:iio:resolver: Add docs for ad2s90

2018-11-17 Thread Matheus Tavares
This patch adds the device tree binding documentation for the ad2s90 resolver-to-digital converter. Signed-off-by: Matheus Tavares --- Changes in v2: - Rewritten 'spi-cpol and spi-cpha' item to say that the device can work in either mode (0,0) or (1,1) and explain how they should be specified

[PATCH v2 5/7] staging:iio:ad2s90: Replace license text w/ SPDX identifier

2018-11-17 Thread Matheus Tavares
This patch removes the license boilerplate text at the top of ad2s90.c and, instead, adds the SPDX GPL-2.0 license identifier, which solves the checkpatch.pl warning: "WARNING: Missing or malformed SPDX-License-Identifier tag in line 1". Signed-off-by: Matheus Tavares --- Changes in v2: -

[PATCH v2 7/7] staging:iio:ad2s90: Move out of staging

2018-11-17 Thread Matheus Tavares
Move ad2s90 resolver driver out of staging to the main tree. Signed-off-by: Matheus Tavares Signed-off-by: Victor Colombo --- Changes in v2: - Disabled git move detection, to see the whole code, as Jonathan suggested drivers/iio/resolver/Kconfig | 10 ++

[PATCH v2 1/7] staging:iio:ad2s90: Add device tree support

2018-11-17 Thread Matheus Tavares
This patch adds device tree support to ad2s90 with standard device tree id table. Signed-off-by: Matheus Tavares --- Changes in v2: - none drivers/staging/iio/resolver/ad2s90.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/staging/iio/resolver/ad2s90.c

[PATCH v2 3/7] staging:iio:ad2s90: Add max frequency check at probe

2018-11-17 Thread Matheus Tavares
From: Alexandru Ardelean This patch adds a max frequency check at the beginning of ad2s90_probe function so that when it is set to a value above 0.83Mhz, dev_err is called with an appropriate message and -EINVAL is returned. The defined limit is 0.83Mhz instead of 2Mhz, which is the chip's max

[PATCH v2 5/7] staging:iio:ad2s90: Replace license text w/ SPDX identifier

2018-11-17 Thread Matheus Tavares
This patch removes the license boilerplate text at the top of ad2s90.c and, instead, adds the SPDX GPL-2.0 license identifier, which solves the checkpatch.pl warning: "WARNING: Missing or malformed SPDX-License-Identifier tag in line 1". Signed-off-by: Matheus Tavares --- Changes in v2: -

[PATCH v2 7/7] staging:iio:ad2s90: Move out of staging

2018-11-17 Thread Matheus Tavares
Move ad2s90 resolver driver out of staging to the main tree. Signed-off-by: Matheus Tavares Signed-off-by: Victor Colombo --- Changes in v2: - Disabled git move detection, to see the whole code, as Jonathan suggested drivers/iio/resolver/Kconfig | 10 ++

[PATCH v2 1/7] staging:iio:ad2s90: Add device tree support

2018-11-17 Thread Matheus Tavares
This patch adds device tree support to ad2s90 with standard device tree id table. Signed-off-by: Matheus Tavares --- Changes in v2: - none drivers/staging/iio/resolver/ad2s90.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/staging/iio/resolver/ad2s90.c

[PATCH v2 3/7] staging:iio:ad2s90: Add max frequency check at probe

2018-11-17 Thread Matheus Tavares
From: Alexandru Ardelean This patch adds a max frequency check at the beginning of ad2s90_probe function so that when it is set to a value above 0.83Mhz, dev_err is called with an appropriate message and -EINVAL is returned. The defined limit is 0.83Mhz instead of 2Mhz, which is the chip's max

[PATCH v2 0/7] staging:iio:ad2s90: Add dt support and move out of staging

2018-11-17 Thread Matheus Tavares
This series adds device tree support to ad2s90, adds the respective dt-binding documentation, solves all remaining codestyle problems in the driver code and move it out of staging.

[PATCH v2 0/7] staging:iio:ad2s90: Add dt support and move out of staging

2018-11-17 Thread Matheus Tavares
This series adds device tree support to ad2s90, adds the respective dt-binding documentation, solves all remaining codestyle problems in the driver code and move it out of staging.

Re: [PATCH v2 1/2] Makefile: Fix distcc compilation with x86 macros

2018-11-17 Thread Masahiro Yamada
On Sat, Nov 17, 2018 at 6:02 AM Nadav Amit wrote: > > From: Masahiro Yamada > Sent: November 16, 2018 at 7:45:45 AM GMT > > To: Nadav Amit > > Cc: Ingo Molnar , Michal Marek , > > Thomas Gleixner , Borislav Petkov , H. > > Peter Anvin , X86 ML , Linux Kbuild > > mailing list , Linux Kernel

Re: [PATCH v2 1/2] Makefile: Fix distcc compilation with x86 macros

2018-11-17 Thread Masahiro Yamada
On Sat, Nov 17, 2018 at 6:02 AM Nadav Amit wrote: > > From: Masahiro Yamada > Sent: November 16, 2018 at 7:45:45 AM GMT > > To: Nadav Amit > > Cc: Ingo Molnar , Michal Marek , > > Thomas Gleixner , Borislav Petkov , H. > > Peter Anvin , X86 ML , Linux Kbuild > > mailing list , Linux Kernel

[PATCH] clk: rockchip: fix ID of 8ch clock of I2S1 for rk3328

2018-11-17 Thread Katsuhiro Suzuki
This patch fixes mistakes in HCLK_I2S1_8CH for running I2S1 successfully. Signed-off-by: Katsuhiro Suzuki --- include/dt-bindings/clock/rk3328-cru.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/dt-bindings/clock/rk3328-cru.h

[PATCH] clk: rockchip: fix ID of 8ch clock of I2S1 for rk3328

2018-11-17 Thread Katsuhiro Suzuki
This patch fixes mistakes in HCLK_I2S1_8CH for running I2S1 successfully. Signed-off-by: Katsuhiro Suzuki --- include/dt-bindings/clock/rk3328-cru.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/dt-bindings/clock/rk3328-cru.h

[PATCH] clk: rockchip: fix I2S1 clock gate register for rk3328

2018-11-17 Thread Katsuhiro Suzuki
This patch fixes definition of I2S1 clock gate register for rk3328. Current setting is not related I2S clocks. - bit6 of CRU_CLKGATE_CON0 means clk_ddrmon_en - bit6 of CRU_CLKGATE_CON1 means clk_i2s1_en Signed-off-by: Katsuhiro Suzuki --- drivers/clk/rockchip/clk-rk3328.c | 2 +- 1 file

[PATCH] clk: rockchip: fix I2S1 clock gate register for rk3328

2018-11-17 Thread Katsuhiro Suzuki
This patch fixes definition of I2S1 clock gate register for rk3328. Current setting is not related I2S clocks. - bit6 of CRU_CLKGATE_CON0 means clk_ddrmon_en - bit6 of CRU_CLKGATE_CON1 means clk_i2s1_en Signed-off-by: Katsuhiro Suzuki --- drivers/clk/rockchip/clk-rk3328.c | 2 +- 1 file

Re: [PATCH] kbuild: rpm-pkg: fix binrpm-pkg breakage when O= is used

2018-11-17 Thread Masahiro Yamada
Hi Laurent, On Sun, Nov 18, 2018 at 4:22 AM Laurent Pinchart wrote: > > Hi Yamada-san, > > On Monday, 5 November 2018 09:51:49 EET Masahiro Yamada wrote: > > Zhenzhong Duan reported that running 'make O=/build/kernel binrpm-pkg' > > failed with the following errors: > > > > Running 'make

Re: [PATCH] kbuild: rpm-pkg: fix binrpm-pkg breakage when O= is used

2018-11-17 Thread Masahiro Yamada
Hi Laurent, On Sun, Nov 18, 2018 at 4:22 AM Laurent Pinchart wrote: > > Hi Yamada-san, > > On Monday, 5 November 2018 09:51:49 EET Masahiro Yamada wrote: > > Zhenzhong Duan reported that running 'make O=/build/kernel binrpm-pkg' > > failed with the following errors: > > > > Running 'make

[no subject]

2018-11-17 Thread Major Dennis Hornbeck
I am in the military unit here in Afghanistan, we have some amount of funds that we want to move out of the country. My partners and I need a good partner someone we can trust. It is risk free and legal. Reply to this email: majordennis...@gmail.com Regards,Major Dennis Hornbeck.

[no subject]

2018-11-17 Thread Major Dennis Hornbeck
I am in the military unit here in Afghanistan, we have some amount of funds that we want to move out of the country. My partners and I need a good partner someone we can trust. It is risk free and legal. Reply to this email: majordennis...@gmail.com Regards,Major Dennis Hornbeck.

[no subject]

2018-11-17 Thread Major Dennis Hornbeck
I am in the military unit here in Afghanistan, we have some amount of funds that we want to move out of the country. My partners and I need a good partner someone we can trust. It is risk free and legal. Reply to this email: majordennis...@gmail.com Regards,Major Dennis Hornbeck.

[no subject]

2018-11-17 Thread Major Dennis Hornbeck
I am in the military unit here in Afghanistan, we have some amount of funds that we want to move out of the country. My partners and I need a good partner someone we can trust. It is risk free and legal. Reply to this email: majordennis...@gmail.com Regards,Major Dennis Hornbeck.

Re: [PATCH V2 1/2] clocksource: imx-gpt: add support for ARM64

2018-11-17 Thread Daniel Lezcano
On 05/11/2018 02:10, Anson Huang wrote: > This patch allows building and compile-testing the i.MX > GPT driver also for ARM64. The delay_timer is only > supported on ARMv7. > > Signed-off-by: Anson Huang > --- > no change since V1. Applied, thanks. -- Daniel --

Re: [PATCH V2 1/2] clocksource: imx-gpt: add support for ARM64

2018-11-17 Thread Daniel Lezcano
On 05/11/2018 02:10, Anson Huang wrote: > This patch allows building and compile-testing the i.MX > GPT driver also for ARM64. The delay_timer is only > supported on ARMv7. > > Signed-off-by: Anson Huang > --- > no change since V1. Applied, thanks. -- Daniel --

Re: [PATCH V2 2/2] clocksource: imx-gpt: add necessary kfree to avoid resource leak

2018-11-17 Thread Daniel Lezcano
Hi Anson, On 06/11/2018 10:12, Anson Huang wrote: [ ... ] Please convert to timer-of API. >>> >>> This patch mainly to fix the potential resource leak issue, for >>> converting to timer-of API, should I add another patch for it? Since >>> it is a different subject. >> >> Actually I was

Re: [PATCH V2 2/2] clocksource: imx-gpt: add necessary kfree to avoid resource leak

2018-11-17 Thread Daniel Lezcano
Hi Anson, On 06/11/2018 10:12, Anson Huang wrote: [ ... ] Please convert to timer-of API. >>> >>> This patch mainly to fix the potential resource leak issue, for >>> converting to timer-of API, should I add another patch for it? Since >>> it is a different subject. >> >> Actually I was

Re: [PATCH v2] riscv: add asm/unistd.h UAPI header

2018-11-17 Thread Nick Kossifidis
Hello David, Στις 2018-11-08 21:02, David Abdurachmanov έγραψε: Marcin Juszkiewicz reported issues while generating syscall table for riscv using 4.20-rc1. The patch refactors our unistd.h files to match some other architectures. - Add asm/unistd.h UAPI header, which has __ARCH_WANT_NEW_STAT

Re: [PATCH v2] riscv: add asm/unistd.h UAPI header

2018-11-17 Thread Nick Kossifidis
Hello David, Στις 2018-11-08 21:02, David Abdurachmanov έγραψε: Marcin Juszkiewicz reported issues while generating syscall table for riscv using 4.20-rc1. The patch refactors our unistd.h files to match some other architectures. - Add asm/unistd.h UAPI header, which has __ARCH_WANT_NEW_STAT

Re: [RFC v2 5/7] clocksource/drivers/rtl8186: Add RTL8186 timer driver

2018-11-17 Thread Daniel Lezcano
Hi Yasha, except the few details below, the driver looks good to me. On 01/10/2018 12:29, Yasha Cherikovsky wrote: > The Realtek RTL8186 SoC is a MIPS based SoC > used in some home routers [1][2]. > > This adds a driver to handle the built-in timers > on this SoC. > > Timers 0 and 1 are

Re: [RFC v2 5/7] clocksource/drivers/rtl8186: Add RTL8186 timer driver

2018-11-17 Thread Daniel Lezcano
Hi Yasha, except the few details below, the driver looks good to me. On 01/10/2018 12:29, Yasha Cherikovsky wrote: > The Realtek RTL8186 SoC is a MIPS based SoC > used in some home routers [1][2]. > > This adds a driver to handle the built-in timers > on this SoC. > > Timers 0 and 1 are

Re: [PATCH 1/2] clocksource: Demote dbx500 PRCMU clocksource

2018-11-17 Thread Daniel Lezcano
On 15/11/2018 14:32, Linus Walleij wrote: > Demote the DBx500 PRCMU clocksource to quality 100 and > mark it as NONSTOP so it will still be used for > timekeeping across suspend/resume. > > The Nomadik MTU timer which has higher precision will > be used when the system is up and running, thanks

Re: [PATCH 1/2] clocksource: Demote dbx500 PRCMU clocksource

2018-11-17 Thread Daniel Lezcano
On 15/11/2018 14:32, Linus Walleij wrote: > Demote the DBx500 PRCMU clocksource to quality 100 and > mark it as NONSTOP so it will still be used for > timekeeping across suspend/resume. > > The Nomadik MTU timer which has higher precision will > be used when the system is up and running, thanks

Re: [PATCH v2 0/2] clocksource/meson6_timer: implement ARM delay timer

2018-11-17 Thread Daniel Lezcano
On 15/11/2018 23:46, Martin Blumenstingl wrote: > While trying to add support for the ARM TWD Timer and the ARM Global > Timer on Meson8, Meson8b and Meson8m2 (ARM Cortex-A5 and Cortex-A9 SoCs) > I did a review of the existing driver. > Unfortunately I found it hard to review because the

Re: [PATCH v2 0/2] clocksource/meson6_timer: implement ARM delay timer

2018-11-17 Thread Daniel Lezcano
On 15/11/2018 23:46, Martin Blumenstingl wrote: > While trying to add support for the ARM TWD Timer and the ARM Global > Timer on Meson8, Meson8b and Meson8m2 (ARM Cortex-A5 and Cortex-A9 SoCs) > I did a review of the existing driver. > Unfortunately I found it hard to review because the

Re: [PATCH] clockevents/drivers/tegra20: Remove obsolete inclusion of

2018-11-17 Thread Daniel Lezcano
On 15/11/2018 11:00, Geert Uytterhoeven wrote: > As of commit da4a686a2cfb077a ("ARM: smp_twd: convert to use CLKSRC_OF > init"), this header file is no longer used. > > Signed-off-by: Geert Uytterhoeven > --- Applied. Thanks! -- Linaro.org │ Open source software for

Re: [PATCH] clockevents/drivers/tegra20: Remove obsolete inclusion of

2018-11-17 Thread Daniel Lezcano
On 15/11/2018 11:00, Geert Uytterhoeven wrote: > As of commit da4a686a2cfb077a ("ARM: smp_twd: convert to use CLKSRC_OF > init"), this header file is no longer used. > > Signed-off-by: Geert Uytterhoeven > --- Applied. Thanks! -- Linaro.org │ Open source software for

Re: [PATCH] mm: use this_cpu_cmpxchg_double in put_cpu_partial

2018-11-17 Thread Wei Yang
On Fri, Nov 16, 2018 at 05:33:35PM -0800, Wengang Wang wrote: >The this_cpu_cmpxchg makes the do-while loop pass as long as the >s->cpu_slab->partial as the same value. It doesn't care what happened to >that slab. Interrupt is not disabled, and new alloc/free can happen in the Well, I seems to

Re: [PATCH] mm: use this_cpu_cmpxchg_double in put_cpu_partial

2018-11-17 Thread Wei Yang
On Fri, Nov 16, 2018 at 05:33:35PM -0800, Wengang Wang wrote: >The this_cpu_cmpxchg makes the do-while loop pass as long as the >s->cpu_slab->partial as the same value. It doesn't care what happened to >that slab. Interrupt is not disabled, and new alloc/free can happen in the Well, I seems to

Re: [PATCH v7 1/4] dt-bindings: pps: descriptor-based gpio, capture-clear addition

2018-11-17 Thread tom burkart
Quoting Rob Herring : On Sat, Nov 17, 2018 at 4:35 AM tom burkart wrote: Quoting Rob Herring : > On Wed, Nov 14, 2018 at 11:54:29PM +1100, Tom Burkart wrote: >> This patch changes the devicetree bindings for the pps-gpio driver >> from the integer based ABI to the descriptor based ABI. > ?

Re: [PATCH v7 1/4] dt-bindings: pps: descriptor-based gpio, capture-clear addition

2018-11-17 Thread tom burkart
Quoting Rob Herring : On Sat, Nov 17, 2018 at 4:35 AM tom burkart wrote: Quoting Rob Herring : > On Wed, Nov 14, 2018 at 11:54:29PM +1100, Tom Burkart wrote: >> This patch changes the devicetree bindings for the pps-gpio driver >> from the integer based ABI to the descriptor based ABI. > ?

Re: [PATCH v5 12/18] arm64: dts: qcom: pms405: add gpios

2018-11-17 Thread Bjorn Andersson
On Fri 09 Nov 01:44 PST 2018, Vinod Koul wrote: > Add the GPIOs present on PMS405 chip. > > Signed-off-by: Vinod Koul Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > arch/arm64/boot/dts/qcom/pms405.dtsi | 19 +++ > 1 file changed, 19 insertions(+) > > diff --git

Re: [PATCH v5 12/18] arm64: dts: qcom: pms405: add gpios

2018-11-17 Thread Bjorn Andersson
On Fri 09 Nov 01:44 PST 2018, Vinod Koul wrote: > Add the GPIOs present on PMS405 chip. > > Signed-off-by: Vinod Koul Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > arch/arm64/boot/dts/qcom/pms405.dtsi | 19 +++ > 1 file changed, 19 insertions(+) > > diff --git

Re: [PATCH v5 02/18] arm64: dts: qcom: qcs404-evb: add dts files for EVBs

2018-11-17 Thread Bjorn Andersson
On Fri 09 Nov 01:44 PST 2018, Vinod Koul wrote: > QCS404 has two EVBs, EVB-1000 and EVB-4000. These boards are mostly > similar with few differences in the peripherals used. > > So use a common qcs404-evb.dtsi which contains the common parts and use > qcs404-evb-1000.dts and qcs404-evb-4000.dts

Re: [PATCH v5 02/18] arm64: dts: qcom: qcs404-evb: add dts files for EVBs

2018-11-17 Thread Bjorn Andersson
On Fri 09 Nov 01:44 PST 2018, Vinod Koul wrote: > QCS404 has two EVBs, EVB-1000 and EVB-4000. These boards are mostly > similar with few differences in the peripherals used. > > So use a common qcs404-evb.dtsi which contains the common parts and use > qcs404-evb-1000.dts and qcs404-evb-4000.dts

Re: [PATCH v5 01/18] arm64: dts: qcom: qcs404: add base dts files

2018-11-17 Thread Bjorn Andersson
On Fri 09 Nov 01:44 PST 2018, Vinod Koul wrote: > Add base dts files for QCS404 chipset along with cpu, timer, > gcc and uart2 nodes. > > Signed-off-by: Vinod Koul Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > arch/arm64/boot/dts/qcom/qcs404.dtsi | 175 >

Re: [PATCH v5 01/18] arm64: dts: qcom: qcs404: add base dts files

2018-11-17 Thread Bjorn Andersson
On Fri 09 Nov 01:44 PST 2018, Vinod Koul wrote: > Add base dts files for QCS404 chipset along with cpu, timer, > gcc and uart2 nodes. > > Signed-off-by: Vinod Koul Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > arch/arm64/boot/dts/qcom/qcs404.dtsi | 175 >

Re: [PATCH] mtd: rawnand: qcom: Namespace prefix some commands

2018-11-17 Thread Miquel Raynal
Hi Olof, Olof Johansson wrote on Fri, 16 Nov 2018 19:43:27 -0800: > PAGE_READ is used by RISC-V arch code included through mm headers, > and it makes sense to bring in a prefix on these in the driver. > > drivers/mtd/nand/raw/qcom_nandc.c:153: warning: "PAGE_READ" redefined > #define

Re: [PATCH] mtd: rawnand: qcom: Namespace prefix some commands

2018-11-17 Thread Miquel Raynal
Hi Olof, Olof Johansson wrote on Fri, 16 Nov 2018 19:43:27 -0800: > PAGE_READ is used by RISC-V arch code included through mm headers, > and it makes sense to bring in a prefix on these in the driver. > > drivers/mtd/nand/raw/qcom_nandc.c:153: warning: "PAGE_READ" redefined > #define

Re: [PATCH v6 1/3] staging: mt7621-mmc: Remove #if 0 blocks in sd.c

2018-11-17 Thread NeilBrown
On Thu, Oct 04 2018, Nishad Kamdar wrote: > This patch removes #if 0 code blocks and usages of > functions defined in the #if 0 blocks in sd.c. > > Signed-off-by: Nishad Kamdar Hi Nishad, thanks for this patch (and others) and apologies for not reviewing/testing it earlier. Unfortunately

Re: [PATCH v6 1/3] staging: mt7621-mmc: Remove #if 0 blocks in sd.c

2018-11-17 Thread NeilBrown
On Thu, Oct 04 2018, Nishad Kamdar wrote: > This patch removes #if 0 code blocks and usages of > functions defined in the #if 0 blocks in sd.c. > > Signed-off-by: Nishad Kamdar Hi Nishad, thanks for this patch (and others) and apologies for not reviewing/testing it earlier. Unfortunately

[of] deadlock b/c of gpiochip and pinctrl dependency

2018-11-17 Thread Robert Abel
Hi! I found a dependency issue with gpiochip and pinctrl while using the gpio-hog feature that was implemented by Benoit Parrot in f625d4601759f. Relevant device-tree overlay shown below [3]. I ran into a deadlock situation, because adding a gpiochip requires a registered pinctrl with

[of] deadlock b/c of gpiochip and pinctrl dependency

2018-11-17 Thread Robert Abel
Hi! I found a dependency issue with gpiochip and pinctrl while using the gpio-hog feature that was implemented by Benoit Parrot in f625d4601759f. Relevant device-tree overlay shown below [3]. I ran into a deadlock situation, because adding a gpiochip requires a registered pinctrl with

linux-next: Unable to mount a cgroup file system

2018-11-17 Thread Andrei Vagin
Hello, We run CRIU tests on linux-next kernels. Today, I found that our test robot hangs up on mounting a cgroup file system. https://travis-ci.org/avagin/linux/jobs/455732006 632 ?Ssl0:00 /usr/bin/containerd 843 ?Sl 0:00 \_ containerd-shim -namespace moby -workdir

linux-next: Unable to mount a cgroup file system

2018-11-17 Thread Andrei Vagin
Hello, We run CRIU tests on linux-next kernels. Today, I found that our test robot hangs up on mounting a cgroup file system. https://travis-ci.org/avagin/linux/jobs/455732006 632 ?Ssl0:00 /usr/bin/containerd 843 ?Sl 0:00 \_ containerd-shim -namespace moby -workdir

Re: [PATCH v2 4/4] clk: meson-gxbb: Add video clocks

2018-11-17 Thread Martin Blumenstingl
Hi Neil, On Tue, Nov 6, 2018 at 3:59 PM Neil Armstrong wrote: > > Add the clocks entries used in the video clock path, the clock path > is doubled to permit having different synchronized clocks for different > parts of the video pipeline. > > All dividers are flagged with CLK_GET_RATE_NOCACHE,

Re: [PATCH v2 4/4] clk: meson-gxbb: Add video clocks

2018-11-17 Thread Martin Blumenstingl
Hi Neil, On Tue, Nov 6, 2018 at 3:59 PM Neil Armstrong wrote: > > Add the clocks entries used in the video clock path, the clock path > is doubled to permit having different synchronized clocks for different > parts of the video pipeline. > > All dividers are flagged with CLK_GET_RATE_NOCACHE,

Disabling CPU vulnerabilities workarounds (second try)

2018-11-17 Thread Artem S. Tashkinov
Hello, I'm resending my last email since the first one didn't draw enough attention despite the gravity of the situation and the issue has been exacerbated by the recent kernel 4.20 changes which incur even a larger performance loss - up to 50% according to the most recent Phoronix testing:

Disabling CPU vulnerabilities workarounds (second try)

2018-11-17 Thread Artem S. Tashkinov
Hello, I'm resending my last email since the first one didn't draw enough attention despite the gravity of the situation and the issue has been exacerbated by the recent kernel 4.20 changes which incur even a larger performance loss - up to 50% according to the most recent Phoronix testing:

Re: [PATCH v2 2/3] soc: amlogic: Add Meson GX Clock Measure driver

2018-11-17 Thread Martin Blumenstingl
Hi Neil, On Wed, Nov 14, 2018 at 2:18 PM Neil Armstrong wrote: > > The Amlogic Meson GX SoCs embeds a clock measurer IP to measure the internal > clock paths frequencies. I would remove "GX" from that sentence > The precision is determined by stepping into the divider until the counter >

Re: [PATCH v2 2/3] soc: amlogic: Add Meson GX Clock Measure driver

2018-11-17 Thread Martin Blumenstingl
Hi Neil, On Wed, Nov 14, 2018 at 2:18 PM Neil Armstrong wrote: > > The Amlogic Meson GX SoCs embeds a clock measurer IP to measure the internal > clock paths frequencies. I would remove "GX" from that sentence > The precision is determined by stepping into the divider until the counter >

Re: [PATCH v2 1/3] dt-bindings: amlogic: Add Internal Clock Measurer bindings

2018-11-17 Thread Martin Blumenstingl
Hi Neil, On Wed, Nov 14, 2018 at 2:16 PM Neil Armstrong wrote: > > The Amlogic Meson GX SoCs embeds a clock measurer IP to measure the internal > clock paths frequencies. I would skip the "GX" in that sentence: there's a similar (identical?) clock measurer in Meson6, Meson8, Meson8b and Meson8m2

Re: [PATCH v2 1/3] dt-bindings: amlogic: Add Internal Clock Measurer bindings

2018-11-17 Thread Martin Blumenstingl
Hi Neil, On Wed, Nov 14, 2018 at 2:16 PM Neil Armstrong wrote: > > The Amlogic Meson GX SoCs embeds a clock measurer IP to measure the internal > clock paths frequencies. I would skip the "GX" in that sentence: there's a similar (identical?) clock measurer in Meson6, Meson8, Meson8b and Meson8m2

Re: [PATCH] Allow hwrng to initialize crng.

2018-11-17 Thread Michael Niewöhner
Hi Louis, On Wed, 2018-09-26 at 11:24 +0800, Louis Collard wrote: > Some systems, for example embedded systems, do not generate > enough entropy on boot through interrupts, and boot may be blocked for > several minutes waiting for a call to getrandom to complete. > > Currently, random data is

Re: [PATCH] Allow hwrng to initialize crng.

2018-11-17 Thread Michael Niewöhner
Hi Louis, On Wed, 2018-09-26 at 11:24 +0800, Louis Collard wrote: > Some systems, for example embedded systems, do not generate > enough entropy on boot through interrupts, and boot may be blocked for > several minutes waiting for a call to getrandom to complete. > > Currently, random data is

U.S. Customs and Border??

2018-11-17 Thread Ronald Vitiello
-- U.S. Customs and Border Protection Acting Deputy Commissioner I am writing. in regards of your Package in our custody. with Mr. Jerry A. Benson, A Diplomats from Global Agent Service was stopped at the border in possession of the above mention metal box weight of about 25kg (Internal

U.S. Customs and Border??

2018-11-17 Thread Ronald Vitiello
-- U.S. Customs and Border Protection Acting Deputy Commissioner I am writing. in regards of your Package in our custody. with Mr. Jerry A. Benson, A Diplomats from Global Agent Service was stopped at the border in possession of the above mention metal box weight of about 25kg (Internal

U.S. Customs and Border??

2018-11-17 Thread Ronald Vitiello
-- U.S. Customs and Border Protection Acting Deputy Commissioner I am writing. in regards of your Package in our custody. with Mr. Jerry A. Benson, A Diplomats from Global Agent Service was stopped at the border in possession of the above mention metal box weight of about 25kg (Internal

U.S. Customs and Border??

2018-11-17 Thread Ronald Vitiello
-- U.S. Customs and Border Protection Acting Deputy Commissioner I am writing. in regards of your Package in our custody. with Mr. Jerry A. Benson, A Diplomats from Global Agent Service was stopped at the border in possession of the above mention metal box weight of about 25kg (Internal

  1   2   3   >