reference to Linux Foundation NDA program obsolete?

2020-05-23 Thread Lukas Bulwahn
Hi Jonathan, while reading the process documentation, I noticed this reference to the Linux Foundation NDA program in Documentation/process/3.Early-stage.rst: --> That said, there are also cases where a company legitimately cannot disclose its plans early in the development process. Companies

[PATCH] media: venus: core: Fix runtime PM imbalance in venus_probe

2020-05-23 Thread Dinghao Liu
pm_runtime_get_sync() increments the runtime PM usage counter even when it returns an error code. Thus a pairing decrement is needed on the error handling path to keep the counter balanced. For other error paths after this call, things are the same. Signed-off-by: Dinghao Liu ---

drivers/misc/pci_endpoint_test.c:347:6: warning: Local variable 'irq_type' shadows outer variable [shadowVariable]

2020-05-23 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: caffb99b6929f41a69edbb5aef3a359bf45f3315 commit: b2ba9225e0313b1de631a44b7b48c109032bffec misc: pci_endpoint_test: Avoid using module parameter to determine irqtype date: 7 weeks ago compiler: gcc-7

KVM broken after suspend in most recent kernels.

2020-05-23 Thread Brad Campbell
G'day all. Machine is a Macbook Pro Retina ~ 2014. Kernels are always vanilla kernel and compiled on the machine. No additional patches. vendor_id : GenuineIntel cpu family : 6 model : 69 model name : Intel(R) Core(TM) i5-4278U CPU @ 2.60GHz stepping: 1

[PATCH v7 4/4] gpio: xilinx: Utilize for_each_set_clump macro

2020-05-23 Thread Syed Nayyar Waris
This patch reimplements the xgpio_set_multiple function in drivers/gpio/gpio-xilinx.c to use the new for_each_set_clump macro. Instead of looping for each bit in xgpio_set_multiple function, now we can check each channel at a time and save cycles. Cc: Bartosz Golaszewski Cc: Michal Simek

[PATCH v7 3/4] gpio: thunderx: Utilize for_each_set_clump macro

2020-05-23 Thread Syed Nayyar Waris
This patch reimplements the thunderx_gpio_set_multiple function in drivers/gpio/gpio-thunderx.c to use the new for_each_set_clump macro. Instead of looping for each bank in thunderx_gpio_set_multiple function, now we can skip bank which is not set and save cycles. Cc: Robert Richter Cc: Bartosz

Re: [PATCH V3] thermal: imx: Add missing of_node_put()

2020-05-23 Thread Daniel Lezcano
On 24/05/2020 05:26, Anson Huang wrote: > Gentle ping... It is applied, sorry for not letting you know. >> Subject: [PATCH V3] thermal: imx: Add missing of_node_put() >> >> After finishing using cpu node got from of_get_cpu_node(), of_node_put() >> needs to be called, the cpufreq policy also

[PATCH v7 2/4] lib/test_bitmap.c: Add for_each_set_clump test cases

2020-05-23 Thread Syed Nayyar Waris
The introduction of the generic for_each_set_clump macro need test cases to verify the implementation. This patch adds test cases for scenarios in which clump sizes are 8 bits, 24 bits, 30 bits and 6 bits. The cases contain situations where clump is getting split at the word boundary and also when

[PATCH v7 1/4] bitops: Introduce the the for_each_set_clump macro

2020-05-23 Thread Syed Nayyar Waris
This macro iterates for each group of bits (clump) with set bits, within a bitmap memory region. For each iteration, "start" is set to the bit offset of the found clump, while the respective clump value is stored to the location pointed by "clump". Additionally, the bitmap_get_value and

[PATCH v7 0/4] Introduce the for_each_set_clump macro

2020-05-23 Thread Syed Nayyar Waris
Hello Linus, Since this patchset primarily affects GPIO drivers, would you like to pick it up through your GPIO tree? This patchset introduces a new generic version of for_each_set_clump. The previous version of for_each_set_clump8 used a fixed size 8-bit clump, but the new generic version can

[PATCH] arm64: ptrace: Fix PTRACE_SINGLESTEP into signal handler

2020-05-23 Thread Keno Fischer
Executing PTRACE_SINGLESTEP at a signal stop is special. It is supposed to step merely the signal setup work that the kernel does, but not any instructions in user space. Since not all architectures have the ability to generate a single-step exception directly upon return from user-space, there is

[PATCH] media: venus: venc: Fix runtime PM imbalance in venc_open

2020-05-23 Thread Dinghao Liu
pm_runtime_get_sync() increments the runtime PM usage counter even when it returns an error code. Thus a pairing decrement is needed on the error handling path to keep the counter balanced. Signed-off-by: Dinghao Liu --- drivers/media/platform/qcom/venus/venc.c | 3 +-- 1 file changed, 1

[linux-next RFC v2] mm/gup.c: Convert to use get_user_{page|pages}_fast_only()

2020-05-23 Thread Souptick Joarder
API __get_user_pages_fast() renamed to get_user_pages_fast_only() to align with pin_user_pages_fast_only(). As part of this we will get rid of write parameter. Instead caller will pass FOLL_WRITE to get_user_pages_fast_only(). This will not change any existing functionality of the API. All the

Re: [PATCH v2] Makefile: support compressed debug info

2020-05-23 Thread Masahiro Yamada
On Fri, May 22, 2020 at 6:57 AM 'Nick Desaulniers' via Clang Built Linux wrote: > > On Wed, May 20, 2020 at 7:48 PM Masahiro Yamada wrote: > > > > > Suggested-by: Fangrui Song > > > > > > Suggested-by -> Reviewed-by > > > > https://patchwork.kernel.org/patch/11524939/#23349551 > > Yes, my

[PATCH V2] media: s3c-camif: fix missing disable in tegra_adma_probe().

2020-05-23 Thread wu000273
From: Qiushi Wu "pm_runtime_enable()" was not handled by "pm_runtime_disable()" after a call of the function “pm_runtime_get_sync()” failed. Thus move the jump target “err_pm” before calling function "calling pm_runtime_disable()". Fixes: babde1c243b2 ("[media] V4L: Add driver for

drivers/gpu/drm/i915/display/intel_color.c:1840 ilk_read_lut_8() error: potential null dereference 'blob'. (drm_property_create_blob returns null)

2020-05-23 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: caffb99b6929f41a69edbb5aef3a359bf45f3315 commit: 100882673ab83b55ea0e9ed3ad301125d36039a3 drm/i915: Split i9xx_read_lut_8() to gmch vs. ilk variants date: 3 months ago config: i386-allyesconfig (attached

[PATCH] media: exynos4-is: Fix runtime PM imbalance in isp_video_open

2020-05-23 Thread Dinghao Liu
pm_runtime_get_sync() increments the runtime PM usage counter even when it returns an error code. Thus a pairing decrement is needed on the error handling path to keep the counter balanced. Signed-off-by: Dinghao Liu --- drivers/media/platform/exynos4-is/fimc-isp-video.c | 1 + 1 file changed,

next-20200522 - build fail in fs/binfmt_elf_fdpic.c

2020-05-23 Thread Valdis Klētnieks
Eric: looks like you missed one? commit b8a61c9e7b4a0fec493d191429e9653d66a79ccc Author: Eric W. Biederman Date: Thu May 14 15:17:40 2020 -0500 exec: Generic execfd support CHECK fs/binfmt_elf_fdpic.c fs/binfmt_elf_fdpic.c:591:34: error: undefined identifier 'BINPRM_FLAGS_EXECFD'

RE: [PATCH V3] thermal: imx: Add missing of_node_put()

2020-05-23 Thread Anson Huang
Gentle ping... > Subject: [PATCH V3] thermal: imx: Add missing of_node_put() > > After finishing using cpu node got from of_get_cpu_node(), of_node_put() > needs to be called, the cpufreq policy also needs to be put unconditionally. > > Signed-off-by: Anson Huang > --- > Changes since V2: >

Re: [RFC PATCH 2/2] drm: xlnx: driver for Xilinx DSI TX Subsystem

2020-05-23 Thread Laurent Pinchart
Hi GVRao, Thank you for the patch. On Mon, May 04, 2020 at 11:43:48AM -0700, Hyun Kwon wrote: > On Mon, 2020-04-20 at 14:20:56 -0700, Venkateshwar Rao Gannavarapu wrote: > > The Xilinx MIPI DSI Tx Subsystem soft IP is used to display video > > data from AXI-4 stream interface. > > > > It

Re: [RFC PATCH 1/2] dt-bindings: display: xlnx: Add Xilinx DSI TX subsystem bindings

2020-05-23 Thread Laurent Pinchart
Hi GVRao, On Sat, Apr 25, 2020 at 10:29:19PM +0200, Sam Ravnborg wrote: > On Tue, Apr 21, 2020 at 02:50:55AM +0530, Venkateshwar Rao Gannavarapu wrote: > > This add a dt binding for Xilinx DSI TX subsystem. > > > > The Xilinx MIPI DSI (Display serial interface) Transmitter Subsystem > >

[PATCH] media: exynos4-is: Fix runtime PM imbalance in fimc_is_probe

2020-05-23 Thread Dinghao Liu
pm_runtime_get_sync() increments the runtime PM usage counter even when it returns an error code. Thus a pairing decrement is needed on the error handling path to keep the counter balanced. For all error paths after pm_runtime_get_sync(), things are the same. Signed-off-by: Dinghao Liu ---

Re: [PATCH 0/3] fs: reduce export usage of kerne_read*() calls

2020-05-23 Thread Mimi Zohar
On Fri, 2020-05-22 at 16:25 -0700, Scott Branden wrote: > Hi Kees, > > On 2020-05-22 4:04 p.m., Kees Cook wrote: > > On Fri, May 22, 2020 at 03:24:32PM -0700, Scott Branden wrote: > >> On 2020-05-18 5:37 a.m., Mimi Zohar wrote: > >>> On Sun, 2020-05-17 at 23:22 -0700, Christoph Hellwig wrote: >

[PATCH] iio: magnetometer: ak8974: Fix runtime PM imbalance on error

2020-05-23 Thread Dinghao Liu
When devm_regmap_init_i2c() returns an error code, a pairing runtime PM usage counter decrement is needed to keep the counter balanced. For error paths after ak8974_set_power(), ak8974_detect() and ak8974_reset(), things are the same. However, When iio_triggered_buffer_setup() returns an error

[PATCH 4/6] arm64: dts: qcom: sm8250: Add USB and PHY device nodes

2020-05-23 Thread Jonathan Marek
Add device nodes for the USB3 controller, QMP SS PHY and SNPS HS PHY. Signed-off-by: Jonathan Marek --- arch/arm64/boot/dts/qcom/sm8250.dtsi | 180 +++ 1 file changed, 180 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi

[PATCH 2/6] arm64: dts: qcom: sm8250: add apps_smmu node

2020-05-23 Thread Jonathan Marek
Add the apps_smmu node for sm8250. Note that adding the iommus field for UFS is required because initializing the iommu removes the bypass mapping that created by the bootloader. Signed-off-by: Jonathan Marek --- arch/arm64/boot/dts/qcom/sm8250.dtsi | 107 +++ 1 file

[PATCH 0/6] arm64: dts: qcom: smmu/USB nodes and HDK855/HDK865 dts

2020-05-23 Thread Jonathan Marek
Add dts nodes for apps_smmu and USB for both sm8150 and sm8250. Also add initial dts files for HDK855 and HDK865, based on mtp dts, with a few changes. Notably, the HDK865 dts has regulator config changed a bit based on downstream (I think sm8250-mtp.dts is wrong and copied too much from sm8150).

[PATCH 5/6] arm64: dts: qcom: add sm8150 hdk dts

2020-05-23 Thread Jonathan Marek
Add initial HDK855 dts, based on sm8150-mtp, with a few changes. Signed-off-by: Jonathan Marek --- arch/arm64/boot/dts/qcom/Makefile | 1 + arch/arm64/boot/dts/qcom/sm8150-hdk.dts | 461 2 files changed, 462 insertions(+) create mode 100644

[PATCH 3/6] arm64: dts: qcom: sm8150: Add secondary USB and PHY nodes

2020-05-23 Thread Jonathan Marek
Add dts nodes for the secondary USB controller and related PHY nodes. Signed-off-by: Jonathan Marek --- arch/arm64/boot/dts/qcom/sm8150.dtsi | 89 1 file changed, 89 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi

[PATCH 6/6] arm64: dts: qcom: add sm8250 hdk dts

2020-05-23 Thread Jonathan Marek
Add initial HDK865 dts, based on sm8250-mtp, with a few changes. Notably, regulator configs are changed a bit. Signed-off-by: Jonathan Marek --- arch/arm64/boot/dts/qcom/Makefile | 1 + arch/arm64/boot/dts/qcom/sm8250-hdk.dts | 454 2 files changed, 455

[PATCH 1/6] arm64: dts: qcom: sm8150: add apps_smmu node

2020-05-23 Thread Jonathan Marek
Add the apps_smmu node for sm8150. Note that adding the iommus field for UFS is required because initializing the iommu removes the bypass mapping that created by the bootloader. Signed-off-by: Jonathan Marek --- arch/arm64/boot/dts/qcom/sm8150.dtsi | 91 1 file

Re: [PATCH v13 2/2] media: v4l: xilinx: Add Xilinx MIPI CSI-2 Rx Subsystem driver

2020-05-23 Thread Laurent Pinchart
Hi Vishal, Thank you for the patch. On Tue, May 12, 2020 at 08:49:47PM +0530, Vishal Sagar wrote: > The Xilinx MIPI CSI-2 Rx Subsystem soft IP is used to capture images > from MIPI CSI-2 camera sensors and output AXI4-Stream video data ready > for image processing. Please refer to PG232 for

[PATCH] drm/qxl: Replace deprecated function in qxl_display

2020-05-23 Thread Sidong Yang
Hi, Dave. This is resended e-mail for your advice. I'm a newbie interested in linux kernel and qxl module. Please check this patch and give me advice for me. Also I'll be glad if there is any task that you bothered. Thanks. Sidong. Replace deprecated function drm_modeset_lock/unlock_all with

[PATCH] drm/panfrost: Fix runtime PM imbalance in panfrost_perfcnt_enable_locked

2020-05-23 Thread Dinghao Liu
pm_runtime_get_sync() increments the runtime PM usage counter even when it returns an error code. Thus a pairing decrement is needed on the error handling path to keep the counter balanced. For all error paths after pm_runtime_get_sync(), things are the same. Signed-off-by: Dinghao Liu ---

[PATCH 2/3] phy: qcom-qmp: Add QMP V4 USB3 UNIPHY

2020-05-23 Thread Jonathan Marek
Add support for the USB3 PHY used by the secondary usb controller on sm8150 Signed-off-by: Jonathan Marek --- drivers/phy/qualcomm/phy-qcom-qmp.c | 150 drivers/phy/qualcomm/phy-qcom-qmp.h | 5 + 2 files changed, 155 insertions(+) diff --git

[PATCH 3/3] phy: qcom-qmp: Add QMP V4 USB3 PHY support for sm8250

2020-05-23 Thread Jonathan Marek
Add both the DP and UNI PHY for primary/secondary usb controllers. The tables are very similar to sm8150 (serdes_tbl is identical), but there are some differences. Signed-off-by: Jonathan Marek --- drivers/phy/qualcomm/phy-qcom-qmp.c | 206

[PATCH 1/3] phy: qcom-qmp: Allow different values for second lane

2020-05-23 Thread Jonathan Marek
The primary USB PHY on sm8250 sets some values differently for the second lane. This makes it possible to represent that. Signed-off-by: Jonathan Marek --- drivers/phy/qualcomm/phy-qcom-qmp.c | 52 ++--- 1 file changed, 40 insertions(+), 12 deletions(-) diff --git

[PATCH 0/3] phy: qcom-qmp: add V4 USB PHYs

2020-05-23 Thread Jonathan Marek
Add support for sm8150 secondary USB PHY and both sm8250 USB PHYs. Jonathan Marek (3): phy: qcom-qmp: Allow different values for second lane phy: qcom-qmp: Add QMP V4 USB3 UNIPHY phy: qcom-qmp: Add QMP V4 USB3 PHY support for sm8250 drivers/phy/qualcomm/phy-qcom-qmp.c | 408

Re: [RFC PATCH v12 10/11] arm64: add mechanism to let user choose which counter to return

2020-05-23 Thread Richard Cochran
On Fri, May 22, 2020 at 04:37:23PM +0800, Jianyong Wu wrote: > In general, vm inside will use virtual counter compered with host use > phyical counter. But in some special scenarios, like nested > virtualization, phyical counter maybe used by vm. A interface added in > ptp_kvm driver to offer a

Re: [PATCH] sparc32: use PUD rather than PGD to get PMD in srmmu_nocache_init()

2020-05-23 Thread Guenter Roeck
On 5/23/20 5:15 PM, Linus Torvalds wrote: > On Sat, May 23, 2020 at 3:47 PM Guenter Roeck wrote: >> >> This quite innocent looking patch crashes all my sparc32 boot tests. >> Crash log and bisect results below. Reverting it fixes the problem. > > It should also fixed by 0cfc8a8d70dc ("sparc32:

[PATCH] drm/i915/selftests: Fix runtime PM imbalance on error

2020-05-23 Thread Dinghao Liu
When drm_dev_init() returns an error code, a pairing runtime PM usage counter decrement is needed to keep the counter balanced. For error paths after this call, things are the same. Signed-off-by: Dinghao Liu --- drivers/gpu/drm/i915/selftests/mock_gem_device.c | 1 + 1 file changed, 1

Re: [PATCH v13 1/2] media: dt-bindings: media: xilinx: Add Xilinx MIPI CSI-2 Rx Subsystem

2020-05-23 Thread Laurent Pinchart
Hi Vishal, Thank you for the patch. On Tue, May 12, 2020 at 08:49:46PM +0530, Vishal Sagar wrote: > Add bindings documentation for Xilinx MIPI CSI-2 Rx Subsystem. > > The Xilinx MIPI CSI-2 Rx Subsystem consists of a CSI-2 Rx controller, a > D-PHY in Rx mode and a Video Format Bridge. > >

[PATCH] mm,thp: stop leaking unreleased file pages

2020-05-23 Thread Hugh Dickins
When collapse_file() calls try_to_release_page(), it has already isolated the page: so if releasing buffers happens to fail (as it sometimes does), remember to putback_lru_page(): otherwise that page is left unreclaimable and unfreeable, and the file extent uncollapsible. Signed-off-by: Hugh

Re: [RFC PATCH v12 10/11] arm64: add mechanism to let user choose which counter to return

2020-05-23 Thread Richard Cochran
On Fri, May 22, 2020 at 04:37:23PM +0800, Jianyong Wu wrote: > To use this feature, you should call PTP_EXTTS_REQUEST(2) ioctl with flag > set bit PTP_KVM_ARM_PHY_COUNTER in its argument then call > PTP_SYS_OFFSET_PRECISE(2) ioctl to get the cross timestamp and phyical > counter will return. If

Re: [PATCH v12 1/2] media: dt-bindings: media: xilinx: Add Xilinx MIPI CSI-2 Rx Subsystem

2020-05-23 Thread Laurent Pinchart
Hi Vishal, On Fri, May 08, 2020 at 01:52:36PM +, Vishal Sagar wrote: > On Tuesday, May 5, 2020 7:53 PM, Laurent Pinchart wrote: > > On Thu, Apr 23, 2020 at 09:00:37PM +0530, Vishal Sagar wrote: > > > Add bindings documentation for Xilinx MIPI CSI-2 Rx Subsystem. > > > > > > The Xilinx MIPI

Re: [RFC PATCH v12 09/11] ptp: extend input argument for getcrosstimestamp API

2020-05-23 Thread Richard Cochran
On Fri, May 22, 2020 at 04:37:22PM +0800, Jianyong Wu wrote: > sometimes we may need tell getcrosstimestamp call back how to perform > itself. Extending input arguments for getcrosstimestamp API to offer more > exquisite control for the operation. This text does not offer any justification for

Re: [PATCH V4 13/17] arm64/cpufeature: Add remaining feature bits in ID_AA64MMFR1 register

2020-05-23 Thread Anshuman Khandual
On 05/19/2020 07:14 PM, Suzuki K Poulose wrote: > On 05/19/2020 10:40 AM, Anshuman Khandual wrote: >> Enable ETS, TWED, XNX and SPECSEI features bits in ID_AA64MMFR1 register as >> per ARM DDI 0487F.a specification. >> >> Cc: Catalin Marinas >> Cc: Will Deacon >> Cc: Mark Rutland >> Cc:

Re: [PATCH V4 15/17] arm64/cpufeature: Add remaining feature bits in ID_AA64DFR0 register

2020-05-23 Thread Anshuman Khandual
On 05/20/2020 07:27 PM, Suzuki K Poulose wrote: > On 05/19/2020 10:40 AM, Anshuman Khandual wrote: >> Enable MTPMU and TRACEFILT features bits in ID_AA64DFR0 register as per ARM >> DDI 0487F.a specification. >> >> Cc: Catalin Marinas >> Cc: Will Deacon >> Cc: Mark Rutland >> Cc: Suzuki K

Re: [PATCH] mm/compaction: avoid VM_BUG_ON(PageSlab()) in page_mapcount()

2020-05-23 Thread Hugh Dickins
On Wed, 13 May 2020, Konstantin Khlebnikov wrote: > Function isolate_migratepages_block() runs some checks out of lru_lock > when choose pages for migration. After checking PageLRU() it checks extra > page references by comparing page_count() and page_mapcount(). Between > these two checks page

kernel/livepatch/../sched/sched.h:1619:25: sparse: sparse: incompatible types in comparison expression (different address spaces):

2020-05-23 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 0cfc8a8d70dcd51db783e8e87917e02149c71458 commit: 4104a562e0ca62e971089db9d3c47794a0d7d4eb sched/core: Annotate curr pointer in rq with __rcu date: 3 months ago config: x86_64-randconfig-s002-20200524

RE: [PATCH] thermal: imx8mm: Add get_trend ops

2020-05-23 Thread Anson Huang
Hi, Daniel > Subject: Re: [PATCH] thermal: imx8mm: Add get_trend ops > > On 23/05/2020 02:35, Anson Huang wrote: > > Hi, Daniel > > > > > >> Subject: Re: [PATCH] thermal: imx8mm: Add get_trend ops > >> > >> On 13/05/2020 04:58, Anson Huang wrote: > >>> Add get_trend ops for i.MX8MM thermal to

Re: [PATCH] x86/reboot/quirks: Add MacBook6,1 reboot quirk

2020-05-23 Thread Hill Ma
gentle ping again and happy weekend to all :)

Re: [PATCH -next] pwm: pca9685: Remove set but not used variable 'pwm'

2020-05-23 Thread Sven Van Asbroeck
Hi Uwe, On Sat, May 23, 2020 at 4:17 PM Uwe Kleine-König wrote: > > Is this patch still relevant? A slightly different version of this patch has already landed in mainline. Clemens Gruber had relevant hardware available, and was able to test it out. See Linus's tree here:

Re: [GIT] Networking

2020-05-23 Thread pr-tracker-bot
The pull request you sent on Sat, 23 May 2020 17:06:54 -0700 (PDT): > git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git refs/heads/master has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/caffb99b6929f41a69edbb5aef3a359bf45f3315 Thank you! -- Deet-doot-dot,

Re: [PATCH] sparc32: use PUD rather than PGD to get PMD in srmmu_nocache_init()

2020-05-23 Thread Linus Torvalds
On Sat, May 23, 2020 at 3:47 PM Guenter Roeck wrote: > > This quite innocent looking patch crashes all my sparc32 boot tests. > Crash log and bisect results below. Reverting it fixes the problem. It should also fixed by 0cfc8a8d70dc ("sparc32: fix page table traversal in srmmu_nocache_init()").

[GIT] Networking

2020-05-23 Thread David Miller
Merge tag 'rxrpc-fixes-20200520' of git://git.kernel.org/.../dhowells/linux-fs Merge branch 'netdevsim-Two-small-fixes' Merge branch 'mlxsw-Various-fixes' Merge tag 'rxrpc-fixes-20200523-v2' of git://git.kernel.org/.../dhowells/linux-fs Merge tag 'mlx5-fixes-2020-05-22' of git

Re: [PATCH v3 3/3] vfio-pci: Invalidate mmaps and block MMIO access on disabled memory

2020-05-23 Thread Peter Xu
(CC Andrea too) On Sat, May 23, 2020 at 07:52:57PM -0400, Peter Xu wrote: > On Sat, May 23, 2020 at 05:06:02PM -0600, Alex Williamson wrote: > > On Sat, 23 May 2020 15:34:17 -0400 > > Peter Xu wrote: > > > > > Hi, Alex, > > > > > > On Fri, May 22, 2020 at 01:17:43PM -0600, Alex Williamson

Re: [PATCH v2 0/5] net: provide a devres variant of register_netdev()

2020-05-23 Thread David Miller
From: Bartosz Golaszewski Date: Sat, 23 May 2020 15:27:06 +0200 > From: Bartosz Golaszewski > > Using devres helpers allows to shrink the probing code, avoid memory leaks in > error paths make sure the order in which resources are freed is the exact > opposite of their allocation. This series

Re: [PATCH v3 3/3] vfio-pci: Invalidate mmaps and block MMIO access on disabled memory

2020-05-23 Thread Peter Xu
On Sat, May 23, 2020 at 05:06:02PM -0600, Alex Williamson wrote: > On Sat, 23 May 2020 15:34:17 -0400 > Peter Xu wrote: > > > Hi, Alex, > > > > On Fri, May 22, 2020 at 01:17:43PM -0600, Alex Williamson wrote: > > > @@ -1346,15 +1526,32 @@ static vm_fault_t vfio_pci_mmap_fault(struct > > >

Re: [PATCH] net: smsc911x: Fix runtime PM imbalance on error

2020-05-23 Thread David Miller
From: Dinghao Liu Date: Sat, 23 May 2020 16:08:20 +0800 > Remove runtime PM usage counter decrement when the > increment function has not been called to keep the > counter balanced. > > Signed-off-by: Dinghao Liu Applied, thank you.

Re: [PATCH net-next v2] net: psample: fix build error when CONFIG_INET is not enabled

2020-05-23 Thread David Miller
From: Randy Dunlap Date: Fri, 22 May 2020 13:05:26 -0700 > From: Randy Dunlap > > Fix psample build error when CONFIG_INET is not set/enabled by > bracketing the tunnel code in #ifdef CONFIG_NET / #endif. > > ../net/psample/psample.c: In function ‘__psample_ip_tun_to_nlattr’: >

Re: lockdep trace with xfs + mm in it from 5.7.0-rc5

2020-05-23 Thread Dave Chinner
On Fri, May 22, 2020 at 01:43:08PM -0700, Darrick J. Wong wrote: > On Fri, May 22, 2020 at 10:30:27AM +1000, Dave Chinner wrote: > > On Thu, May 21, 2020 at 04:13:12PM -0700, Darrick J. Wong wrote: > > > [cc linux-xfs] > > > > > > On Fri, May 22, 2020 at 08:21:50AM +1000, Dave Airlie wrote: > > >

Re: [PATCH v2] net/mlx4_core: fix a memory leak bug.

2020-05-23 Thread David Miller
From: wu000...@umn.edu Date: Fri, 22 May 2020 14:07:15 -0500 > From: Qiushi Wu > > In function mlx4_opreq_action(), pointer "mailbox" is not released, > when mlx4_cmd_box() return and error, causing a memory leak bug. > Fix this issue by going to "out" label, mlx4_free_cmd_mailbox() can > free

Re: [PATCH] net: ethernet: ti: cpsw: fix ASSERT_RTNL() warning during suspend

2020-05-23 Thread David Miller
From: Grygorii Strashko Date: Fri, 22 May 2020 19:39:31 +0300 > vlan_for_each() are required to be called with rtnl_lock taken, otherwise > ASSERT_RTNL() warning will be triggered - which happens now during System > resume from suspend: > cpsw_suspend() > |- cpsw_ndo_stop() > |-

Re: [PATCH net v2] net: phy: mscc: fix initialization of the MACsec protocol mode

2020-05-23 Thread David Miller
From: Antoine Tenart Date: Fri, 22 May 2020 17:55:45 +0200 > At the very end of the MACsec block initialization in the MSCC PHY > driver, the MACsec "protocol mode" is set. This setting should be set > based on the PHY id within the package, as the bank used to access the > register used depends

Re: [PATCH] net: stmmac: don't attach interface until resume finishes

2020-05-23 Thread David Miller
From: Leon Yu Date: Fri, 22 May 2020 23:29:43 +0800 > Commit 14b41a2959fb ("net: stmmac: Delete txtimer in suspend") was the > first attempt to fix a race between mod_timer() and setup_timer() > during stmmac_resume(). However the issue still exists as the commit > only addressed half of the

Re: [PATCH] net: Fix return value about devm_platform_ioremap_resource()

2020-05-23 Thread David Miller
From: Tiezhu Yang Date: Fri, 22 May 2020 19:03:21 +0800 > When call function devm_platform_ioremap_resource(), we should use IS_ERR() > to check the return value and return PTR_ERR() if failed. > > Signed-off-by: Tiezhu Yang Applied, thanks.

Re: [PATCH net-next] net: phy: at803x: fix PHY ID masks

2020-05-23 Thread David Miller
From: Michael Walle Date: Fri, 22 May 2020 11:53:31 +0200 > Ever since its first commit 0ca7111a38f05 ("phy: add AT803x driver") the > PHY ID mask was set to 0xffef. It is unclear to me why this mask was > chosen in the first place. Both the AR8031/AR8033 and the AR8035 > datasheets mention

Re: [PATCH v1 1/3] drm/msm: Attach the IOMMU device during initialization

2020-05-23 Thread Rob Clark
On Sat, May 23, 2020 at 12:23 AM Shawn Guo wrote: > > On Fri, May 22, 2020 at 04:03:14PM -0600, Jordan Crouse wrote: > > diff --git a/drivers/gpu/drm/msm/msm_gpummu.c > > b/drivers/gpu/drm/msm/msm_gpummu.c > > index 34980d8eb7ad..0ad0f848560a 100644 > > --- a/drivers/gpu/drm/msm/msm_gpummu.c > >

Re: [PATCH v9 00/14] KVM: Dirty ring interface

2020-05-23 Thread Peter Xu
On Sat, May 23, 2020 at 06:56:45PM -0400, Peter Xu wrote: > KVM branch: > https://github.com/xzpeter/linux/tree/kvm-dirty-ring > > QEMU branch for testing: > https://github.com/xzpeter/qemu/tree/kvm-dirty-ring > > v9: > - patch 3: __x86_set_memory_region: squash another trivial change to

[PATCH v9 13/14] KVM: selftests: Let dirty_log_test async for dirty ring test

2020-05-23 Thread Peter Xu
Previously the dirty ring test was working in synchronous way, because only with a vmexit (with that it was the ring full event) we'll know the hardware dirty bits will be flushed to the dirty ring. With this patch we first introduced the vcpu kick mechanism by using SIGUSR1, meanwhile we can

[PATCH v9 14/14] KVM: selftests: Add "-c" parameter to dirty log test

2020-05-23 Thread Peter Xu
It's only used to override the existing dirty ring size/count. If with a bigger ring count, we test async of dirty ring. If with a smaller ring count, we test ring full code path. Async is default. It has no use for non-dirty-ring tests. Reviewed-by: Andrew Jones Signed-off-by: Peter Xu ---

Re: [PATCH v3 3/3] vfio-pci: Invalidate mmaps and block MMIO access on disabled memory

2020-05-23 Thread Alex Williamson
On Sat, 23 May 2020 15:34:17 -0400 Peter Xu wrote: > Hi, Alex, > > On Fri, May 22, 2020 at 01:17:43PM -0600, Alex Williamson wrote: > > @@ -1346,15 +1526,32 @@ static vm_fault_t vfio_pci_mmap_fault(struct > > vm_fault *vmf) > > { > > struct vm_area_struct *vma = vmf->vma; > > struct

[PATCH v9 07/14] KVM: Don't allocate dirty bitmap if dirty ring is enabled

2020-05-23 Thread Peter Xu
Because kvm dirty rings and kvm dirty log is used in an exclusive way, Let's avoid creating the dirty_bitmap when kvm dirty ring is enabled. At the meantime, since the dirty_bitmap will be conditionally created now, we can't use it as a sign of "whether this memory slot enabled dirty tracking".

[PATCH v9 12/14] KVM: selftests: Add dirty ring buffer test

2020-05-23 Thread Peter Xu
Add the initial dirty ring buffer test. The current test implements the userspace dirty ring collection, by only reaping the dirty ring when the ring is full. So it's still running synchronously like this: vcpu main thread 1. vcpu dirties pages 2.

[PATCH v9 08/14] KVM: selftests: Always clear dirty bitmap after iteration

2020-05-23 Thread Peter Xu
We don't clear the dirty bitmap before because KVM_GET_DIRTY_LOG will clear it for us before copying the dirty log onto it. However we'd still better to clear it explicitly instead of assuming the kernel will always do it for us. More importantly, in the upcoming dirty ring tests we'll start to

[PATCH v9 10/14] KVM: selftests: Use a single binary for dirty/clear log test

2020-05-23 Thread Peter Xu
Remove the clear_dirty_log test, instead merge it into the existing dirty_log_test. It should be cleaner to use this single binary to do both tests, also it's a preparation for the upcoming dirty ring test. The default behavior will run all the modes in sequence. Reviewed-by: Andrew Jones

[PATCH v9 02/14] KVM: Cache as_id in kvm_memory_slot

2020-05-23 Thread Peter Xu
Cache the address space ID just like the slot ID. It will be used in order to fill in the dirty ring entries. Suggested-by: Paolo Bonzini Suggested-by: Sean Christopherson Signed-off-by: Peter Xu --- include/linux/kvm_host.h | 1 + virt/kvm/kvm_main.c | 1 + 2 files changed, 2

[PATCH v9 11/14] KVM: selftests: Introduce after_vcpu_run hook for dirty log test

2020-05-23 Thread Peter Xu
Provide a hook for the checks after vcpu_run() completes. Preparation for the dirty ring test because we'll need to take care of another exit reason. Reviewed-by: Andrew Jones Signed-off-by: Peter Xu --- tools/testing/selftests/kvm/dirty_log_test.c | 36 +--- 1 file changed,

[PATCH v9 05/14] KVM: X86: Implement ring-based dirty memory tracking

2020-05-23 Thread Peter Xu
This patch is heavily based on previous work from Lei Cao and Paolo Bonzini . [1] KVM currently uses large bitmaps to track dirty memory. These bitmaps are copied to userspace when userspace queries KVM for its dirty page information. The use of bitmaps is mostly sufficient for live migration,

[PATCH v9 09/14] KVM: selftests: Sync uapi/linux/kvm.h to tools/

2020-05-23 Thread Peter Xu
This will be needed to extend the kvm selftest program. Signed-off-by: Peter Xu --- tools/include/uapi/linux/kvm.h | 53 ++ 1 file changed, 53 insertions(+) diff --git a/tools/include/uapi/linux/kvm.h b/tools/include/uapi/linux/kvm.h index

[PATCH v9 04/14] KVM: Pass in kvm pointer into mark_page_dirty_in_slot()

2020-05-23 Thread Peter Xu
The context will be needed to implement the kvm dirty ring. Signed-off-by: Peter Xu --- virt/kvm/kvm_main.c | 33 +++-- 1 file changed, 19 insertions(+), 14 deletions(-) diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index ebdd98a30e82..a7460e93d457 100644

[PATCH v9 00/14] KVM: Dirty ring interface

2020-05-23 Thread Peter Xu
KVM branch: https://github.com/xzpeter/linux/tree/kvm-dirty-ring QEMU branch for testing: https://github.com/xzpeter/qemu/tree/kvm-dirty-ring v9: - patch 3: __x86_set_memory_region: squash another trivial change to return (0xdeadull << 48) always for slot removal [Sean] - pick r-bs for

[PATCH v9 01/14] KVM: X86: Change parameter for fast_page_fault tracepoint

2020-05-23 Thread Peter Xu
It would be clearer to dump the return value to know easily on whether did we go through the fast path for handling current page fault. Remove the old two last parameters because after all the old/new sptes were dumped in the same line. Signed-off-by: Peter Xu --- arch/x86/kvm/mmutrace.h | 9

[PATCH v9 03/14] KVM: X86: Don't track dirty for KVM_SET_[TSS_ADDR|IDENTITY_MAP_ADDR]

2020-05-23 Thread Peter Xu
Originally, we have three code paths that can dirty a page without vcpu context for X86: - init_rmode_identity_map - init_rmode_tss - kvmgt_rw_gpa init_rmode_identity_map and init_rmode_tss will be setup on destination VM no matter what (and the guest cannot even see them), so it does not

[PATCH v9 06/14] KVM: Make dirty ring exclusive to dirty bitmap log

2020-05-23 Thread Peter Xu
There's no good reason to use both the dirty bitmap logging and the new dirty ring buffer to track dirty bits. We should be able to even support both of them at the same time, but it could complicate things which could actually help little. Let's simply make it the rule before we enable dirty

Re: [PATCH] sparc32: use PUD rather than PGD to get PMD in srmmu_nocache_init()

2020-05-23 Thread Guenter Roeck
Hi, On Fri, May 22, 2020 at 10:23:09PM -0700, Mike Rapoport wrote: > The kbuild test robot reported the following warning: > > arch/sparc/mm/srmmu.c: In function 'srmmu_nocache_init': > arch/sparc/mm/srmmu.c:300:9: error: variable 'pud' set but not used > [-Werror=unused-but-set-variable] >

Re: [PATCH v1 07/25] lockdep: Add preemption disabled assertion API

2020-05-23 Thread Peter Zijlstra
On Sat, May 23, 2020 at 04:59:42PM +0200, Sebastian A. Siewior wrote: > On 2020-05-22 19:55:03 [+0200], Peter Zijlstra wrote: > > That is both more consistent with the things you claim it's modelled > > after and also completely avoids that header dependency. > > So we need additionally: > > -

Re: [PATCH v2 0/4] mm/gup, drm/i915: refactor gup_fast, convert to pin_user_pages()

2020-05-23 Thread John Hubbard
On 2020-05-23 02:41, Chris Wilson wrote: Quoting John Hubbard (2020-05-22 06:19:27) The purpose of posting this series is to launch a test in the intel-gfx-ci tree. (The patches have already been merged into Andrew's linux-mm tree.) This applies to today's linux.git (note the base-commit tag

Re: [PATCH v2 0/7] Share events between metrics

2020-05-23 Thread Jiri Olsa
On Fri, May 22, 2020 at 10:56:59AM -0700, Ian Rogers wrote: SNIP > >> > #11 0x004b6911 in cmd_test (argc=1, argv=0x7fffd7f0) > >> > at tests/builtin-test.c:772 > >> > #12 0x004e977b in run_builtin (p=0xa7eee8 , > >> > argc=3, argv=0x7fffd7f0) at perf.c:312 >

Re: [PATCH net-next v2 4/4] net: dp83869: Add RGMII internal delay configuration

2020-05-23 Thread Andrew Lunn
> > Any why is your PHY special, in that is does care about out of range > > delays, when others using new the new core helper don't? > > We are not rounding to nearest here.  Basically the helper works to find the > best match > > If the delay passed in is less than or equal to the smallest

arch/powerpc/kexec/ima.c:156:21: sparse: sparse: incorrect type in assignment (different base types)

2020-05-23 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 423b8baf18a8c03f2d6fa99aa447ed0da189bb95 commit: 793b08e2efff3ec020c5c5861d00ed394fcdd488 powerpc/kexec: Move kexec files into a dedicated subdir. date: 6 months ago config:

Re: [PATCH net-next v2 4/4] net: dp83869: Add RGMII internal delay configuration

2020-05-23 Thread Dan Murphy
Andrew On 5/23/20 10:09 AM, Andrew Lunn wrote: + dp83869->tx_id_delay = DP83869_RGMII_CLK_DELAY_INV; + ret = of_property_read_u32(of_node, "tx-internal-delay-ps", + >tx_id_delay); + if (!ret && dp83869->tx_id_delay >

Re: [PATCH v2] fpga: dfl: afu: convert get_user_pages() --> pin_user_pages()

2020-05-23 Thread John Hubbard
On 2020-05-23 13:57, Moritz Fischer wrote: On Fri, May 22, 2020 at 06:52:34PM -0700, John Hubbard wrote: On 2020-05-19 13:14, John Hubbard wrote: This code was using get_user_pages_fast(), in a "Case 2" scenario (DMA/RDMA), using the categorization from [1]. That means that it's time to

Re: [RFC][PATCH 0/4] x86/entry: disallow #DB more

2020-05-23 Thread Peter Zijlstra
On Sat, May 23, 2020 at 02:59:40PM +0200, Peter Zijlstra wrote: > On Fri, May 22, 2020 at 03:13:57PM -0700, Andy Lutomirski wrote: > > This is great, except that the unconditional DR7 write is going to > > seriously hurt perf performance. Fortunately, no one cares about > > perf, right? :) > >

[PATCH] staging: rtl8723bs: Use shared header constants

2020-05-23 Thread Pascal Terjan
This is one of the 9 drivers redefining rfc1042_header. Signed-off-by: Pascal Terjan --- drivers/staging/rtl8723bs/core/rtw_recv.c | 15 ++- drivers/staging/rtl8723bs/include/rtw_recv.h | 2 -- drivers/staging/rtl8723bs/os_dep/recv_linux.c | 5 +++-- 3 files changed, 9

[PATCH] atmel: Use shared constant for rfc1042 header

2020-05-23 Thread Pascal Terjan
This is one of the 9 drivers redefining rfc1042_header. Signed-off-by: Pascal Terjan --- drivers/net/wireless/atmel/atmel.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/wireless/atmel/atmel.c b/drivers/net/wireless/atmel/atmel.c index

[PATCH] libertas: Use shared constant for rfc1042 header

2020-05-23 Thread Pascal Terjan
This is one of the 9 drivers redefining rfc1042_header. Signed-off-by: Pascal Terjan --- drivers/net/wireless/marvell/libertas/rx.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/wireless/marvell/libertas/rx.c b/drivers/net/wireless/marvell/libertas/rx.c

Re: linux-next: build failure after merge of the tip tree

2020-05-23 Thread Paul E. McKenney
On Sat, May 23, 2020 at 09:05:24PM +0200, Thomas Gleixner wrote: > "Paul E. McKenney" writes: > > On Sat, May 23, 2020 at 11:54:26AM +0200, Thomas Gleixner wrote: > >> core/rcu is the one which diverged and caused the merge conflict with > >> PPC to happen twice. So Paul needs to remove the stale

[PATCH] staging: rtl8712: Fix IEEE80211_ADDBA_PARAM_BUF_SIZE_MASK

2020-05-23 Thread Pascal Terjan
The value in shared headers was fixed 9 years ago in commit 8d661f1e462d ("ieee80211: correct IEEE80211_ADDBA_PARAM_BUF_SIZE_MASK macro") and while looking at using shared headers for other duplicated constants I noticed this driver uses the old value. The macros are also defined twice in this

  1   2   3   4   >