Re: [PATCH v3 3/5] arm64: dts: qcom: pmi8998: Add nodes for LAB and IBB regulators

2020-05-28 Thread Bjorn Andersson
On Thu 28 May 08:46 PDT 2020, Sumit Semwal wrote: > From: Nisha Kumari > > This patch adds devicetree nodes for LAB and IBB regulators. > Reviewed-by: Bjorn Andersson > Signed-off-by: Nisha Kumari > Signed-off-by: Sumit Semwal > > -- > v2: sumits: updated f

Re: [PATCH v3 1/5] regulator: Allow regulators to verify enabled during enable()

2020-05-28 Thread Bjorn Andersson
On Thu 28 May 08:46 PDT 2020, Sumit Semwal wrote: > Some regulators might need to verify that they have indeed been enabled > after the enable() call is made and enable_time delay has passed. > > This is implemented by repeatedly checking is_enabled() upto > poll_enabled_time, waiting for the

Re: [PATCH] net: qrtr: Allocate workqueue before kernel_bind

2020-05-28 Thread Bjorn Andersson
work and workqueue structs are > allocated and initialized before qrtr_ns_data_ready can be called. > Reviewed-by: Bjorn Andersson Regards, Bjorn > Fixes: 0c2204a4ad71 ("net: qrtr: Migrate nameservice to kernel from > userspace") > Signed-off-by: Chris Lew > --- > net

Re: [PATCH 08/10] clk: qcom: Add graphics clock controller driver for SM8250

2020-05-28 Thread Bjorn Andersson
On Mon 25 May 02:47 PDT 2020, Sai Prakash Ranjan wrote: > Hi Jonathan, > > On 2020-05-25 02:36, Jonathan Marek wrote: > > Add support for the graphics clock controller found on SM8250 > > based devices. This would allow graphics drivers to probe and > > control their clocks. > > > > This is

[PATCH v6 2/5] remoteproc: qcom: Introduce helper to store pil info in IMEM

2020-05-26 Thread Bjorn Andersson
-by: Bjorn Andersson --- Changes since v5: - Picked up reviewed-bys drivers/remoteproc/Kconfig | 3 + drivers/remoteproc/Makefile| 1 + drivers/remoteproc/qcom_pil_info.c | 124 + drivers/remoteproc/qcom_pil_info.h | 7 ++ 4 files changed, 135

[PATCH v6 5/5] arm64: dts: qcom: sdm845: Add IMEM and PIL info region

2020-05-26 Thread Bjorn Andersson
Add a simple-mfd representing IMEM on SDM845 and define the PIL relocation info region, so that post mortem tools will be able to locate the loaded remoteprocs. Reviewed-by: Stephen Boyd Reviewed-by: Vinod Koul Signed-off-by: Bjorn Andersson --- Changes since v5: - Picked up reviewed-bys

[PATCH v6 4/5] arm64: dts: qcom: qcs404: Add IMEM and PIL info region

2020-05-26 Thread Bjorn Andersson
Add a simple-mfd representing IMEM on QCS404 and define the PIL relocation info region, so that post mortem tools will be able to locate the loaded remoteprocs. Reviewed-by: Stephen Boyd Reviewed-by: Vinod Koul Signed-off-by: Bjorn Andersson --- Changes since v5: - Picked up reviewed-bys

[PATCH v6 3/5] remoteproc: qcom: Update PIL relocation info on load

2020-05-26 Thread Bjorn Andersson
Update the PIL relocation information in IMEM with information about where the firmware for various remoteprocs are loaded. Reviewed-by: Vinod Koul Signed-off-by: Bjorn Andersson --- Changes since v5: - Added select QCOM_PIL_INFO to all relevant Kconfig options - Replaced mem_reloc

[PATCH v6 1/5] dt-bindings: remoteproc: Add Qualcomm PIL info binding

2020-05-26 Thread Bjorn Andersson
Add a devicetree binding for the Qualcomm peripheral image loader relocation information region found in the IMEM. Reviewed-by: Mathieu Poirier Reviewed-by: Rob Herring Reviewed-by: Stephen Boyd Reviewed-by: Vinod Koul Signed-off-by: Bjorn Andersson --- Changes since v5: - Picked up

[PATCH v6 0/5] remoteproc: qcom: PIL info support

2020-05-26 Thread Bjorn Andersson
Introduce support for filling out the relocation information in IMEM, to aid post mortem debug tools to locate the various remoteprocs. Bjorn Andersson (5): dt-bindings: remoteproc: Add Qualcomm PIL info binding remoteproc: qcom: Introduce helper to store pil info in IMEM remoteproc: qcom

Re: [PATCH] arm64: dts: qcom: enable pm8150 rtc

2020-05-22 Thread Bjorn Andersson
On Fri 22 May 21:12 PDT 2020, Jonathan Marek wrote: > I don't see any reason for it to be disabled by default. > Reviewed-by: Bjorn Andersson Regards, Bjorn > Signed-off-by: Jonathan Marek > --- > arch/arm64/boot/dts/qcom/pm8150.dtsi | 2 -- > 1 file changed, 2 deletions(

Re: [PATCH] clk: qcom: sm8250 gcc depends on QCOM_GDSC

2020-05-22 Thread Bjorn Andersson
On Fri 22 May 21:09 PDT 2020, Jonathan Marek wrote: > The driver will always fail to probe without QCOM_GDSC, so select it. > Reviewed-by: Bjorn Andersson Regards, Bjorn > Signed-off-by: Jonathan Marek > --- > drivers/clk/qcom/Kconfig | 1 + > 1 file changed, 1 insertion(

Re: [PATCH 3/4] remoteproc: add support for a new 64-bit trace version

2020-05-22 Thread Bjorn Andersson
On Fri 22 May 09:54 PDT 2020, Suman Anna wrote: > On 5/21/20 2:42 PM, Suman Anna wrote: > > Hi Bjorn, > > > > On 5/21/20 1:04 PM, Bjorn Andersson wrote: > > > On Wed 25 Mar 13:47 PDT 2020, Suman Anna wrote: [..] > > > > diff --git a/include/linux

Re: [PATCH V2 2/3] mmc: sdhci-msm: Use internal voltage control

2020-05-22 Thread Bjorn Andersson
On Fri 22 May 06:27 PDT 2020, Veerabhadrarao Badiganti wrote: > Hi Bjorn, > > On 5/22/2020 12:37 AM, Bjorn Andersson wrote: > > On Thu 21 May 08:23 PDT 2020, Veerabhadrarao Badiganti wrote: > > > > > On qcom SD host controllers voltage switching be do

Re: [PATCH v2 0/4] TI K3 DSP remoteproc driver for C66x DSPs

2020-05-21 Thread Bjorn Andersson
On Thu 21 May 15:23 PDT 2020, Mathieu Poirier wrote: > Gents, > > On Thu, May 21, 2020 at 12:01:41PM -0700, Bjorn Andersson wrote: > > On Thu 21 May 11:59 PDT 2020, Suman Anna wrote: > > > > > Hi Bjorn, > > > > > > On 5

Re: [PATCH 2/4] remoteproc: introduce version element into resource type field

2020-05-21 Thread Bjorn Andersson
On Thu 21 May 12:29 PDT 2020, Suman Anna wrote: > On 5/21/20 2:21 PM, Bjorn Andersson wrote: > > On Thu 21 May 12:06 PDT 2020, Suman Anna wrote: > > > > > Hi Bjorn, > > > > > > On 5/21/20 12:54 PM, Bjorn Andersson wrote: > > &g

Re: [PATCH 2/4] remoteproc: introduce version element into resource type field

2020-05-21 Thread Bjorn Andersson
On Thu 21 May 12:06 PDT 2020, Suman Anna wrote: > Hi Bjorn, > > On 5/21/20 12:54 PM, Bjorn Andersson wrote: > > On Wed 25 Mar 13:46 PDT 2020, Suman Anna wrote: > > > > > The current remoteproc core has supported only 32-bit remote > > > processors a

Re: [PATCH V2 2/3] mmc: sdhci-msm: Use internal voltage control

2020-05-21 Thread Bjorn Andersson
On Thu 21 May 08:23 PDT 2020, Veerabhadrarao Badiganti wrote: > On qcom SD host controllers voltage switching be done after the HW > is ready for it. The HW informs its readiness through power irq. > The voltage switching should happen only then. > > Use the internal voltage switching and then

Re: [PATCH v2 0/4] TI K3 DSP remoteproc driver for C66x DSPs

2020-05-21 Thread Bjorn Andersson
On Thu 21 May 11:59 PDT 2020, Suman Anna wrote: > Hi Bjorn, > > On 5/20/20 7:10 PM, Suman Anna wrote: > > Hi All, > > > > The following is v2 of the K3 DSP remoteproc driver supporting the C66x DSPs > > on the TI K3 J721E SoCs. The patches are based on the latest commit on the > > rproc-next

Re: [PATCH v2 4/4] remoteproc/k3-dsp: Add support for L2RAM loading on C66x DSPs

2020-05-21 Thread Bjorn Andersson
> Note that the local resets are a no-op on C71x cores, and the hardware > does not supporting loading into its internal RAMs. > > Signed-off-by: Suman Anna Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > v2: > - Dropped the local-reset no-op checks from k3_dsp_rproc

Re: [PATCH v2 1/4] remoteproc: Introduce rproc_of_parse_firmware() helper

2020-05-21 Thread Bjorn Andersson
being used by multiple drivers, so this helper can avoid > repeating equivalent code in remoteproc drivers. > > Signed-off-by: Suman Anna Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > v2: New patch > > drivers/remoteproc/remoteproc_core.c | 23 ++

Re: [PATCH v2 3/4] remoteproc/k3-dsp: Add a remoteproc driver of K3 C66x DSPs

2020-05-21 Thread Bjorn Andersson
interfaces to talk to the System Controller > (DMSC) for managing configuration, power and reset management of these > cores. IPC between the A72 cores and the DSP cores is supported through > the virtio rpmsg stack using shared memory and OMAP Mailboxes. > There's room for more devm_

Re: [PATCH V1 2/3] mmc: sdhci-msm: Use internal voltage control

2020-05-21 Thread Bjorn Andersson
On Wed 20 May 04:16 PDT 2020, Veerabhadrarao Badiganti wrote: > > Thanks Bjorn for the review. For major comments I'm responding. > Other comments, i will take care of them in my next patch-set. > > On 5/19/2020 1:27 AM, Bjorn Andersson wrote: > > On Fri 15 May 04:18 PDT

Re: [PATCH 3/4] remoteproc: add support for a new 64-bit trace version

2020-05-21 Thread Bjorn Andersson
On Wed 25 Mar 13:47 PDT 2020, Suman Anna wrote: > Introduce a new trace entry resource structure that accommodates > a 64-bit device address to support 64-bit processors. This is to > be used using an overloaded version value of 1 in the upper 32-bits > of the previous resource type field. The

Re: [PATCH 2/4] remoteproc: introduce version element into resource type field

2020-05-21 Thread Bjorn Andersson
On Wed 25 Mar 13:46 PDT 2020, Suman Anna wrote: > The current remoteproc core has supported only 32-bit remote > processors and as such some of the current resource structures > may not scale well for 64-bit remote processors, and would > require new versions of resource types. Each resource is

Re: [PATCH] clk: qcom: gcc: Fix parent for gpll0_out_even

2020-05-20 Thread Bjorn Andersson
Jonathan Marek > Signed-off-by: Vinod Koul Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > drivers/clk/qcom/gcc-sm8150.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/clk/qcom/gcc-sm8150.c b/drivers/clk/qcom/gcc-sm8150.c > index

Re: [PATCH v3 03/14] remoteproc: Add new operation and flags for synchronistation

2020-05-20 Thread Bjorn Andersson
On Wed 20 May 15:06 PDT 2020, Mathieu Poirier wrote: > On Mon, May 18, 2020 at 05:55:00PM -0700, Bjorn Andersson wrote: > > On Fri 15 May 12:24 PDT 2020, Mathieu Poirier wrote: > > > > > Good day Bjorn, > > > > > > On Wed, May 13, 2020 at 06:32:24PM -0

Re: [PATCH v3 0/3] Even moar rpmh cleanups

2020-05-20 Thread Bjorn Andersson
On Wed 20 May 18:21 PDT 2020, Stephen Boyd wrote: > We remove the tcs_is_free() API and then do super micro optimizations on > the irq handler. I haven't tested anything here so most likely there's a > bug (again again)! > > Changes from v2: > * Went back in time and used the v1 patch for the

Re: [PATCH 2/3] arm64: dts: qcom: Add initial sm6125 SoC support

2020-05-20 Thread Bjorn Andersson
On Tue 19 May 04:18 PDT 2020, Eli Riggs wrote: > On Mon, 18 May 2020 23:08:48 -0700 > Bjorn Andersson wrote: > > > Please use dual GPL/BSD license for dts files, if you can. > > Unfortunately the downstream tree I ported has a GPL-2-only header. > > > [...review]

Re: [RFC PATCH 0/8] Qualcomm Cloud AI 100 driver

2020-05-19 Thread Bjorn Andersson
On Tue 19 May 21:59 PDT 2020, Greg Kroah-Hartman wrote: > On Tue, May 19, 2020 at 10:41:15PM +0200, Daniel Vetter wrote: > > > Ok, that's a decision you are going to have to push upward on, as we > > > really can't take this without a working, open, userspace. > > > > Uh wut. > > > > So the

Re: [PATCH v3 3/3] remoteproc: Add coredump debugfs entry

2020-05-19 Thread Bjorn Andersson
is interface. > This functionality can be configured differently for different > remote processors. > Reviewed-by: Bjorn Andersson Regards, Bjorn > Signed-off-by: Rishabh Bhatnagar > --- > drivers/remoteproc/remoteproc_debugfs.c | 86 > +

Re: [PATCH v3 2/3] remoteproc: Add inline coredump functionality

2020-05-19 Thread Bjorn Andersson
On Thu 14 May 13:07 PDT 2020, Rishabh Bhatnagar wrote: > The current coredump implementation uses vmalloc area to copy > all the segments. But this might put strain on low memory targets > as the firmware size sometimes is in tens of MBs. The situation > becomes worse if there are multiple remote

Re: [PATCH v3 1/3] remoteproc: Move coredump functionality to a new file

2020-05-19 Thread Bjorn Andersson
On Thu 14 May 13:07 PDT 2020, Rishabh Bhatnagar wrote: > Move all coredump functionality to an individual file. This is > being done so that the current functionality can be extended > in future patchsets. > Reviewed-by: Bjorn Andersson Thanks, Bjorn > Signed-off-by: Ri

Re: [PATCH v3] arm64: dts: qcom: apq8016-sbc-d3: Add Qualcomm APQ8016 SBC + D3Camera mezzanine

2020-05-19 Thread Bjorn Andersson
On Tue 19 May 03:22 PDT 2020, Manivannan Sadhasivam wrote: > Hi Robert, > > On Mon, May 18, 2020 at 10:21:29AM +0200, Robert Foss wrote: > > Add device treee support for the Qualcomm APQ8016 SBC, otherwise known as > > the Dragonboard 410c with the D3Camera mezzanine expansion board. > > > >

Re: [PATCH] net: qrtr: Fix passing invalid reference to qrtr_local_enqueue()

2020-05-19 Thread Bjorn Andersson
; eventhough the object is not used. > > So fix this by passing NULL to qrtr_local_enqueue(). > > Fixes: bdabad3e363d ("net: Add Qualcomm IPC router") > Reported-by: kbuild test robot > Reported-by: Julia Lawall Reviewed-by: Bjorn Andersson Regards, Bjorn

Re: [PATCH v5 3/5] remoteproc: qcom: Update PIL relocation info on load

2020-05-19 Thread Bjorn Andersson
On Tue 19 May 11:14 PDT 2020, risha...@codeaurora.org wrote: > On 2020-05-12 22:56, Bjorn Andersson wrote: > > Update the PIL relocation information in IMEM with information about > > where the firmware for various remoteprocs are loaded. > > > > Sig

Re: [PATCH v3 2/2] remoteproc: qcom: Add notification types to SSR

2020-05-19 Thread Bjorn Andersson
On Tue 28 Apr 15:16 PDT 2020, Rishabh Bhatnagar wrote: > From: Siddharth Gupta > > The SSR subdevice only adds callback for the unprepare event. Add callbacks > for unprepare, start and prepare events. The client driver for a particular > remoteproc might be interested in knowing the status of

Re: [PATCH v3 1/2] remoteproc: qcom: Add per subsystem SSR notification

2020-05-19 Thread Bjorn Andersson
On Tue 28 Apr 15:16 PDT 2020, Rishabh Bhatnagar wrote: > Currently there is a single notification chain which is called whenever any > remoteproc shuts down. This leads to all the listeners being notified, and > is not an optimal design as kernel drivers might only be interested in > listening to

Re: [PATCH 3/3] arm64: dts: qcom: Add initial support for Xiaomi Redmi Note 8T

2020-05-19 Thread Bjorn Andersson
On Sun 17 May 04:54 PDT 2020, Eli Riggs wrote: > Adds initial device tree for Xiaomi Redmi Note 8T, codename xiaomi-willow. > It uses the sm6125 SoC. Currently only boots into initrd shell over UART. > Requires appended DTB with qcom,board-id = <0x22 0x0> and > qcom,msm-id = <0x18a 0x1> to

Re: [PATCH 2/3] arm64: dts: qcom: Add initial sm6125 SoC support

2020-05-19 Thread Bjorn Andersson
On Sun 17 May 04:54 PDT 2020, Eli Riggs wrote: > Initial support for SM6125 SoC. CPUs, fixed clocks, > interrupt controller, and UART. > > This DTSI is ported from the forked vendor version from > XiaoMi which can be found at [0]. It seems internally > this board is referred to as "Trinket". >

Re: [PATCH] usb: xhci: fix USB_XHCI_PCI depends

2020-05-18 Thread Bjorn Andersson
ci-pci.c:345: undefined reference to > `renesas_xhci_check_request_fw' > > Fix this by adding USB_XHCI_PCI having depends on USB_XHCI_PCI_RENESAS > || !USB_XHCI_PCI_RENESAS so that both can be either inbuilt or modules. > Reviewed-by: Bjorn Andersson Regards, Bjorn > Reported-b

Re: [PATCH] interconnect: Disallow interconnect core to be built as a module

2020-05-18 Thread Bjorn Andersson
On Mon 18 May 20:31 PDT 2020, Viresh Kumar wrote: > On 18-05-20, 11:40, Bjorn Andersson wrote: > > It most certainly does. > > > > With INTERCONNECT as a bool we can handle its absence with stub > > functions - like every other framework does. But as a tristate then &

Re: [PATCH v3] arm64: dts: qcom: apq8016-sbc-d3: Add Qualcomm APQ8016 SBC + D3Camera mezzanine

2020-05-18 Thread Bjorn Andersson
On Mon 18 May 01:21 PDT 2020, Robert Foss wrote: > Add device treee support for the Qualcomm APQ8016 SBC, otherwise known as > the Dragonboard 410c with the D3Camera mezzanine expansion board. > > The D3Camera mezzanine ships in a kit with a OmniVision 5640 sensor module, > which is what this DT

Re: [PATCH V1 2/3] mmc: sdhci-msm: Use internal voltage control

2020-05-18 Thread Bjorn Andersson
On Mon 18 May 12:57 PDT 2020, Bjorn Andersson wrote: > On Fri 15 May 04:18 PDT 2020, Veerabhadrarao Badiganti wrote: > > diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c [..] > > +static int sdhci_msm_register_vreg(struct sdhci_msm_host *msm_host) > > +

Re: [PATCH] arm64: dts: qcom: sc7180: Correct the pdc interrupt ranges

2020-05-18 Thread Bjorn Andersson
On Mon 18 May 05:20 PDT 2020, Maulik Shah wrote: > Few PDC interrupts do not map to respective parent GIC interrupt. > Fix this by correcting the pdc interrupt map. > > Fixes: 22f185ee81d2 ("arm64: dts: qcom: sc7180: Add pdc interrupt controller") > Cc: devicet...@vger.kernel.org >

Re: [PATCH] pinctrl: msm: Add check for pinctrl group is valid

2020-05-18 Thread Bjorn Andersson
On Mon 18 May 08:50 PDT 2020, Mayank Grover wrote: > The list of reserved gpio pins for platform are populated > in gpiochip valid_mask. > > Here on MSM common driver introduce ability to check if > pingroup is valid, by parsing pins in pingroup against > reserved pins for gpios. This does not

Re: [RFC] dt-bindings: mailbox: add doorbell support to ARM MHU

2020-05-18 Thread Bjorn Andersson
On Thu 14 May 22:17 PDT 2020, Viresh Kumar wrote: > From: Sudeep Holla > > Hi Rob, Arnd and Jassi, > > This stuff has been doing rounds on the mailing list since several years > now with no agreed conclusion by all the parties. And here is another > attempt to get some feedback from everyone

Re: [PATCH v3 03/14] remoteproc: Add new operation and flags for synchronistation

2020-05-18 Thread Bjorn Andersson
On Fri 15 May 12:24 PDT 2020, Mathieu Poirier wrote: > Good day Bjorn, > > On Wed, May 13, 2020 at 06:32:24PM -0700, Bjorn Andersson wrote: > > On Fri 08 May 14:01 PDT 2020, Mathieu Poirier wrote: > > > > > On Tue, May 05, 2020 at 05:22:53PM -0700, Bjorn Andersso

Re: [PATCH v3 05/14] remoteproc: Refactor function rproc_fw_boot()

2020-05-18 Thread Bjorn Andersson
On Fri 15 May 12:46 PDT 2020, Mathieu Poirier wrote: > On Wed, May 13, 2020 at 07:10:55PM -0700, Bjorn Andersson wrote: > > On Fri 08 May 14:27 PDT 2020, Mathieu Poirier wrote: > > > > > On Tue, May 05, 2020 at 05:33:41PM -0700, Bjorn Andersson wrote: > > &g

Re: [PATCH v7 4/5] remoteproc: ingenic: Added remoteproc driver

2020-05-18 Thread Bjorn Andersson
On Fri 15 May 03:43 PDT 2020, Paul Cercueil wrote: > This driver is used to boot, communicate with and load firmwares to the > MIPS co-processor found in the VPU hardware of the JZ47xx SoCs from > Ingenic. > > Signed-off-by: Paul Cercueil > Acked-by: Mathieu Poirier Series applied Thanks,

Re: [PATCH] arm64: defconfig: enable Qualcomm IPA and RMNet modules

2020-05-18 Thread Bjorn Andersson
On Mon 18 May 14:54 PDT 2020, Alex Elder wrote: > Enable building the Qualcomm IPA driver as a kernel module. To be > useful, the IPA driver also requires RMNet, so enable building that > as a module as well. > > Signed-off-by: Alex Elder Applied Thanks, Bjorn > --- >

Re: [PATCH] arm64: dts: qcom: sc7180: add IPA information

2020-05-18 Thread Bjorn Andersson
On Mon 18 May 14:49 PDT 2020, Alex Elder wrote: > Add IPA-related nodes and definitions to "sc7180.dtsi". > > Signed-off-by: Alex Elder Applied Thanks, Bjorn > --- > arch/arm64/boot/dts/qcom/sc7180.dtsi | 51 > 1 file changed, 51 insertions(+) > > diff --git

Re: [PATCH] arm64: dts: qcom: sdm845-mtp: enable IPA

2020-05-18 Thread Bjorn Andersson
On Mon 18 May 14:48 PDT 2020, Alex Elder wrote: > Enable IPA on the SDM845 MTP. > > Signed-off-by: Alex Elder > --- > arch/arm64/boot/dts/qcom/sdm845-mtp.dts | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts >

Re: [PATCH v13 3/5] usb: xhci: Add support for Renesas controller with memory

2020-05-18 Thread Bjorn Andersson
On Mon 18 May 12:57 PDT 2020, Vinod Koul wrote: > Hi Anders, > > On 18-05-20, 19:53, Anders Roxell wrote: > > On Wed, 6 May 2020 at 08:01, Vinod Koul wrote: > > > > > > Some rensas controller like uPD720201 and uPD720202 need firmware to be > > > loaded. Add these devices in pci table and

Re: [PATCH 1/2] arm64: dts: qcom: sc7180: Support ETMv4 power management

2020-05-18 Thread Bjorn Andersson
On Mon 18 May 12:08 PDT 2020, Sai Prakash Ranjan wrote: > Hi Bjorn, > > On 2020-05-19 00:21, Bjorn Andersson wrote: > > On Fri 15 May 03:55 PDT 2020, Sai Prakash Ranjan wrote: > > [...] > > > > > > > > > > The previous ver

Re: [PATCH] remoteproc: wcss: Fix function call for new API

2020-05-18 Thread Bjorn Andersson
On Mon 18 May 14:14 PDT 2020, Valdis Kl??tnieks wrote: > On Mon, 18 May 2020 17:08:26 -0400, "Valdis Kl??tnieks" said: > > commit 8a226e2c71: remoteproc: wcss: add support for rpmsg communication > > > > throws a compile error: > > > >CC [M] drivers/remoteproc/qcom_q6v5_wcss.o > >

Re: [PATCH V1 2/3] mmc: sdhci-msm: Use internal voltage control

2020-05-18 Thread Bjorn Andersson
On Fri 15 May 04:18 PDT 2020, Veerabhadrarao Badiganti wrote: > From: Vijay Viswanath > > On qcom SD host controllers voltage switching be done after the HW > is ready for it. The HW informs its readiness through power irq. > The voltage switching should happen only then. > > Use the internal

Re: [PATCH 1/2] arm64: dts: qcom: sc7180: Support ETMv4 power management

2020-05-18 Thread Bjorn Andersson
On Fri 15 May 03:55 PDT 2020, Sai Prakash Ranjan wrote: > Hi Bjorn, > Hi Sai, > On 2020-05-15 16:21, Sai Prakash Ranjan wrote: > > Now that deep idle states are properly supported on SC7180, > > we need to add "coresight-loses-context-with-cpu" property > > to avoid failure of trace session

Re: [PATCH] interconnect: Disallow interconnect core to be built as a module

2020-05-18 Thread Bjorn Andersson
On Fri 15 May 00:11 PDT 2020, Greg Kroah-Hartman wrote: > On Fri, May 15, 2020 at 07:48:47AM +0300, Georgi Djakov wrote: > > On 9/12/19 19:33, Bjorn Andersson wrote: > > > On Thu, Aug 29, 2019 at 1:07 AM Viresh Kumar > > > wrote: > > >> > > >

Re: [PATCH v7 2/4] usb: dwc3: qcom: Add interconnect support in dwc3 driver

2020-05-18 Thread Bjorn Andersson
On Thu 14 May 23:29 PDT 2020, Felipe Balbi wrote: > > Hi, > > Georgi Djakov writes: > >> Sandeep Maheswaram writes: > >>> +static int dwc3_qcom_interconnect_init(struct dwc3_qcom *qcom) > >>> +{ > >>> + struct device *dev = qcom->dev; > >>> + int ret; > >>> + >

Re: [PATCH] soc: qmi: move tlv-micros to header file

2020-05-18 Thread Bjorn Andersson
On Sun 12 Apr 20:57 PDT 2020, Wang Wenhu wrote: > It's highly helpful to move the definitions of TLV related micros > into header file for user reference. The OPTIONAL_TLV_TYPE_START > should be known to any user that might define messages containing > optional fields. SIZE fields are the same,

Re: [PATCH V4 8/8] arm64: dts: ipq6018: Add a53 pll and apcs clock

2020-05-18 Thread Bjorn Andersson
On Tue 12 May 20:55 PDT 2020, Sivaprakash Murugesan wrote: > Hi Bjorn, > > On 5/13/2020 1:54 AM, Bjorn Andersson wrote: > > On Sun 03 May 23:20 PDT 2020, Sivaprakash Murugesan wrote: > > > > > add support for apps pll and apcs clock. > > > >

Re: linux-next: build failure after merge of the qcom tree

2020-05-18 Thread Bjorn Andersson
On Sun 17 May 22:16 PDT 2020, Stephen Rothwell wrote: > Hi all, > > On Mon, 20 Apr 2020 19:41:56 -0700 John Stultz wrote: > > > > On Mon, Apr 20, 2020 at 4:29 PM Stephen Rothwell > > wrote: > > > > > > On Tue, 14 Apr 2020 18:18:11 -0700 John Stultz > > > wrote: > > > > > > > > On Tue, Apr

Re: [PATCH v6 0/3] rpmsg: core: Add support for name extension

2020-05-15 Thread Bjorn Andersson
On Fri 15 May 13:56 PDT 2020, Mathieu Poirier wrote: > This patchset adds the capability to supplement the base definition > published by an rpmsg_driver with a postfix description so that it > is easy to differentiate entities that use the same name service. > > Applies cleanly on rpmsg-next

Re: [PATCH v6 3/5] kernel/cpu_pm: Fix uninitted local in cpu_pm

2020-05-15 Thread Bjorn Andersson
On Thu 14 May 19:32 PDT 2020, Doug Anderson wrote: > Hi, > > On Mon, May 4, 2020 at 10:50 AM Douglas Anderson > wrote: > > > > cpu_pm_notify() is basically a wrapper of notifier_call_chain(). > > notifier_call_chain() doesn't initialize *nr_calls to 0 before it > > starts incrementing

[PATCH] phy: qcom-qmp: Ensure register indirection arrays initialized

2020-05-14 Thread Bjorn Andersson
Use proper PWRDOWN offset for sm8150 USB") Signed-off-by: Bjorn Andersson --- drivers/phy/qualcomm/phy-qcom-qmp.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c index 594

[PATCH] remoteproc: wcss: Fix arguments passed to qcom_add_glink_subdev()

2020-05-14 Thread Bjorn Andersson
tion") Reported-by: kbuild test robot Signed-off-by: Bjorn Andersson --- drivers/remoteproc/qcom_q6v5_wcss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/remoteproc/qcom_q6v5_wcss.c b/drivers/remoteproc/qcom_q6v5_wcss.c index 48d16d81f94d..88c76b9417fa 100644 ---

Re: [PATCH] arm64: dts: qcom: msm8916-samsung-a3u: add nodes for display panel

2020-05-14 Thread Bjorn Andersson
On Thu 14 May 10:01 PDT 2020, michael.s...@seznam.cz wrote: > From: Michael Srba > > This patch wires up display support on Samsung Galaxy A3 2015. > > Signed-off-by: Michael Srba > > --- > .../qcom/msm8916-samsung-a2015-common.dtsi| 44 +++ >

Re: [PATCH 3/4] hwspinlock: qcom: Allow mmio usage in addition to syscon

2020-05-14 Thread Bjorn Andersson
On Tue 12 May 20:57 PDT 2020, Baolin Wang wrote: > On Wed, May 13, 2020 at 8:55 AM Bjorn Andersson > wrote: > > > > In all modern Qualcomm platforms the mutex region of the TCSR is forked > > off into its own block, all with a offset of 0 and stride of 4096. So >

Re: [PATCH 3/4] hwspinlock: qcom: Allow mmio usage in addition to syscon

2020-05-14 Thread Bjorn Andersson
On Thu 14 May 07:15 PDT 2020, Vinod Koul wrote: > On 12-05-20, 17:54, Bjorn Andersson wrote: > > In all modern Qualcomm platforms the mutex region of the TCSR is forked > > off into its own block, all with a offset of 0 and stride of 4096. So > > add support for di

Re: [PATCH] firmware: qcom_scm: Prefer initialisation during the descriptor declaration

2020-05-14 Thread Bjorn Andersson
ns") > Signed-off-by: Amit Kucheria Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > drivers/firmware/qcom_scm.c | 8 +--- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c > ind

Re: [PATCH 1/2] dt-bindings: pinctrl: qcom: Add sm8250 pinctrl bindings

2020-05-14 Thread Bjorn Andersson
On Thu 14 May 07:12 PDT 2020, Linus Walleij wrote: > On Thu, May 14, 2020 at 8:04 AM Bjorn Andersson > wrote: > > On Wed 29 Apr 14:34 PDT 2020, Rob Herring wrote: > > > On Thu, Apr 16, 2020 at 11:19:06PM -0700, Bjorn Andersson wrote: > > > > diff --git &

Re: [PATCH] arm64: dts: qcom: db820c: fix audio configuration

2020-05-14 Thread Bjorn Andersson
On Thu 14 May 06:43 PDT 2020, Vinod Koul wrote: > On 17-04-20, 10:23, Srinivas Kandagatla wrote: > > After patch f864edff110d ("ASoC: qdsp6: q6routing: remove default routing") > > and 9b60441692d9 ("ASoC: qdsp6: q6asm-dai: only enable dais from device > > tree") > > asm dais and routing needs

Re: [PATCH 1/2] dt-bindings: pinctrl: qcom: Add sm8250 pinctrl bindings

2020-05-14 Thread Bjorn Andersson
On Wed 29 Apr 14:34 PDT 2020, Rob Herring wrote: > On Thu, Apr 16, 2020 at 11:19:06PM -0700, Bjorn Andersson wrote: > > diff --git > > a/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml > > b/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctr

Re: [PATCH v5 2/6] spi: spi-geni-qcom: Use OPP API to set clk/perf state

2020-05-13 Thread Bjorn Andersson
On Wed 13 May 22:03 PDT 2020, Rajendra Nayak wrote: > > [].. > > > > spi->bus_num = -1; > > > spi->dev.of_node = dev->of_node; > > > @@ -596,6 +607,9 @@ static int spi_geni_probe(struct platform_device > > > *pdev) > > > spi_geni_probe_runtime_disable: > > >

Re: [PATCH v2 11/12] remoteproc: stm32: Introduce new loaded rsc ops for synchronisation

2020-05-13 Thread Bjorn Andersson
ux-remoteproc/list/?series=239877 > > Signed-off-by: Mathieu Poirier > Reviewed-by: Loic Pallardy Reviewed-by: Bjorn Andersson But I would have preferred if we during probe (when we discover rsc_va) could just set it on the rproc. Regards, Bjorn > --- > drivers/remoteproc/s

Re: [PATCH v2 10/12] remoteproc: stm32: Introduce new parse fw ops for synchronisation

2020-05-13 Thread Bjorn Andersson
On Fri 24 Apr 13:25 PDT 2020, Mathieu Poirier wrote: > Introduce new parse firmware rproc_ops functions to be used when > synchonising with an MCU. > > Mainly based on the work published by Arnaud Pouliquen [1]. > > [1]. https://patchwork.kernel.org/project/linux-remoteproc/list/?series=239877

Re: [PATCH v2 05/12] remoteproc: stm32: Parse syscon that will manage M4 synchronisation

2020-05-13 Thread Bjorn Andersson
t/linux-remoteproc/list/?series=239877 > > Signed-off-by: Mathieu Poirier > Reviewed-by: Loic Pallardy Reviewed-by: Bjorn Andersson > --- > drivers/remoteproc/stm32_rproc.c | 26 ++ > 1 file changed, 26 insertions(+) > > diff --git a/dri

Re: [PATCH v2 04/12] remoteproc: stm32: Remove memory translation from DT parsing

2020-05-13 Thread Bjorn Andersson
rse_dt() can be extended to look for synchronisation > related binding in a clean way. > > Signed-off-by: Mathieu Poirier > Reviewed-by: Loic Pallardy Reviewed-by: Bjorn Andersson > --- > drivers/remoteproc/stm32_rproc.c | 6 +- > 1 file changed, 5 insertions(+), 1 dele

Re: [PATCH v2 03/12] remoteproc: stm32: Decouple rproc from DT parsing

2020-05-13 Thread Bjorn Andersson
with the M4 or not. > > Signed-off-by: Mathieu Poirier Reviewed-by: Bjorn Andersson > --- > drivers/remoteproc/stm32_rproc.c | 25 ++--- > 1 file changed, 14 insertions(+), 11 deletions(-) > > diff --git a/drivers/remoteproc/stm32_rproc.c > b/driv

Re: [PATCH v2 02/12] remoteproc: stm32: Request IRQ with platform device

2020-05-13 Thread Bjorn Andersson
Mathieu Poirier > Reviewed-by: Loic Pallardy Reviewed-by: Bjorn Andersson > --- > drivers/remoteproc/stm32_rproc.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/remoteproc/stm32_rproc.c > b/drivers/remoteproc/stm32_rproc.c >

Re: [PATCH v2 01/12] remoteproc: stm32: Decouple rproc from memory translation

2020-05-13 Thread Bjorn Andersson
On Fri 24 Apr 13:24 PDT 2020, Mathieu Poirier wrote: > Remove the remote processor from the process of parsing the memory > ranges since there is no correlation between them. > > Signed-off-by: Mathieu Poirier > Reviewed-by: Loic Pallardy Reviewed-by: Bjorn Andersson &

Re: [PATCH v3 05/14] remoteproc: Refactor function rproc_fw_boot()

2020-05-13 Thread Bjorn Andersson
On Fri 08 May 14:27 PDT 2020, Mathieu Poirier wrote: > On Tue, May 05, 2020 at 05:33:41PM -0700, Bjorn Andersson wrote: > > On Fri 24 Apr 13:01 PDT 2020, Mathieu Poirier wrote: > > > > > Refactor function rproc_fw_boot() in order to better reflect the work > >

Re: [PATCH v3 03/14] remoteproc: Add new operation and flags for synchronistation

2020-05-13 Thread Bjorn Andersson
On Fri 08 May 14:01 PDT 2020, Mathieu Poirier wrote: > On Tue, May 05, 2020 at 05:22:53PM -0700, Bjorn Andersson wrote: > > On Fri 24 Apr 13:01 PDT 2020, Mathieu Poirier wrote: > > > > > Add a new sync_ops to support use cases where the remoteproc > > > core

Re: [PATCH] arm64: dts: qcom: msm8916: Disable coresight by default

2020-05-13 Thread Bjorn Andersson
On Wed 13 May 11:47 PDT 2020, michael.s...@seznam.cz wrote: > From: Michael Srba > > On some msm8916 devices, attempts at initializing coresight cause the boot to > fail. This was fixed by disabling the coresight-related nodes in the board dts > files. However, a cleaner approach was chosen for

Re: [PATCH v5 2/6] spi: spi-geni-qcom: Use OPP API to set clk/perf state

2020-05-13 Thread Bjorn Andersson
On Wed 13 May 04:12 PDT 2020, Rajendra Nayak wrote: > geni spi needs to express a perforamnce state requirement on CX > depending on the frequency of the clock rates. Use OPP table from > DT to register with OPP framework and use dev_pm_opp_set_rate() to > set the clk/perf state. > >

[PATCH v5 3/5] remoteproc: qcom: Update PIL relocation info on load

2020-05-12 Thread Bjorn Andersson
Update the PIL relocation information in IMEM with information about where the firmware for various remoteprocs are loaded. Signed-off-by: Bjorn Andersson --- Changes since v4: - Dropped unnecessary comment about ignoring return value. drivers/remoteproc/Kconfig | 3 +++ drivers

[PATCH v5 4/5] arm64: dts: qcom: qcs404: Add IMEM and PIL info region

2020-05-12 Thread Bjorn Andersson
Add a simple-mfd representing IMEM on QCS404 and define the PIL relocation info region, so that post mortem tools will be able to locate the loaded remoteprocs. Reviewed-by: Stephen Boyd Signed-off-by: Bjorn Andersson --- Changes since v4: - imem is no longer compatible with "syscon&qu

[PATCH v5 5/5] arm64: dts: qcom: sdm845: Add IMEM and PIL info region

2020-05-12 Thread Bjorn Andersson
Add a simple-mfd representing IMEM on SDM845 and define the PIL relocation info region, so that post mortem tools will be able to locate the loaded remoteprocs. Reviewed-by: Stephen Boyd Signed-off-by: Bjorn Andersson --- Changes since v4: - imem is no longer compatible with "syscon&qu

[PATCH v5 1/5] dt-bindings: remoteproc: Add Qualcomm PIL info binding

2020-05-12 Thread Bjorn Andersson
Add a devicetree binding for the Qualcomm peripheral image loader relocation information region found in the IMEM. Reviewed-by: Stephen Boyd Signed-off-by: Bjorn Andersson --- Changes since v4: - Fixed reg in example to make it compile .../bindings/remoteproc/qcom,pil-info.yaml| 44

[PATCH v5 2/5] remoteproc: qcom: Introduce helper to store pil info in IMEM

2020-05-12 Thread Bjorn Andersson
A region in IMEM is used to communicate load addresses of remoteproc to post mortem debug tools. Implement a helper function that can be used to store this information in order to enable these tools to process collected ramdumps. Signed-off-by: Bjorn Andersson --- Changes since v4: - Replaced

[PATCH v5 0/5] remoteproc: qcom: PIL info support

2020-05-12 Thread Bjorn Andersson
Introduce support for filling out the relocation information in IMEM, to aid post mortem debug tools to locate the various remoteprocs. Bjorn Andersson (5): dt-bindings: remoteproc: Add Qualcomm PIL info binding remoteproc: qcom: Introduce helper to store pil info in IMEM remoteproc: qcom

[PATCH 0/4] hwspinlock: qcom: Allow dropping the intermediate TCSR mutex syscon

2020-05-12 Thread Bjorn Andersson
In all modern Qualcomm platforms the mutex region of the TCSR is forked off into its own block, all with a offset of 0 and stride of 4096. Update the binding to allow the hardware block to be described directly on the mmio bus, in addition to allowing the existing syscon based definition. Bjorn

[PATCH 2/4] dt-bindings: hwlock: qcom: Allow device on mmio bus

2020-05-12 Thread Bjorn Andersson
-off-by: Bjorn Andersson --- .../bindings/hwlock/qcom-hwspinlock.yaml | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/hwlock/qcom-hwspinlock.yaml b/Documentation/devicetree/bindings/hwlock/qcom-hwspinlock.yaml index

[PATCH 1/4] dt-bindings: hwlock: qcom: Migrate binding to YAML

2020-05-12 Thread Bjorn Andersson
Migrate the Qualcomm TCSR mutex binding to YAML to allow validation. Signed-off-by: Bjorn Andersson --- .../bindings/hwlock/qcom-hwspinlock.yaml | 51 +++ 1 file changed, 51 insertions(+) create mode 100644 Documentation/devicetree/bindings/hwlock/qcom-hwspinlock.yaml

[PATCH 4/4] arm64: dts: qcom: sm8250: Drop tcsr_mutex syscon

2020-05-12 Thread Bjorn Andersson
Now that we don't need the intermediate syscon to represent the TCSR mutexes, update the dts to describe the TCSR mutex directly. Signed-off-by: Bjorn Andersson --- arch/arm64/boot/dts/qcom/sm8250.dtsi | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/arch/arm64

[PATCH 3/4] hwspinlock: qcom: Allow mmio usage in addition to syscon

2020-05-12 Thread Bjorn Andersson
In all modern Qualcomm platforms the mutex region of the TCSR is forked off into its own block, all with a offset of 0 and stride of 4096. So add support for directly memory mapping this register space, to avoid the need to represent this block using a syscon. Signed-off-by: Bjorn Andersson

Re: [PATCH] hwspinlock: Simplify Kconfig

2020-05-12 Thread Bjorn Andersson
On Wed 06 May 19:39 PDT 2020, Ezequiel Garcia wrote: > Hello, > > On Wed, 15 Apr 2020 at 10:33, Baolin Wang wrote: > > > > Hi Ezequiel, > > > > On Wed, Apr 15, 2020 at 6:09 AM Ezequiel Garcia > > wrote: > > > > > > Every hwspinlock driver is expected to depend on the > > > hwspinlock core, so

Re: [PATCH v3 0/2] Misc. rproc fixes around fixed memory region support

2020-05-12 Thread Bjorn Andersson
On Fri 08 May 08:14 PDT 2020, Suman Anna wrote: > Hi Bjorn, > > On 5/2/20 1:29 PM, Suman Anna wrote: > > Hi Bjorn, > > > > On 4/20/20 11:05 AM, Suman Anna wrote: > > > Hi Bjorn, > > > > > > This is another minor revision of the fixes around fixed memory region > > > support [1] series. Patch 1

Re: [PATCH] pinctrl: qcom: Add affinity callbacks to msmgpio IRQ chip

2020-05-12 Thread Bjorn Andersson
RQs. > > Fixes: e35a6ae0eb3a ("pinctrl/msm: Setup GPIO chip in hierarchy") > Signed-off-by: Venkata Narendra Kumar Gutta > [mkshah: updated commit text and minor code fixes] > Signed-off-by: Maulik Shah Reviewed-by: Bjorn Andersson Regards, Bjorn > ---

<    7   8   9   10   11   12   13   14   15   16   >