Re: [PATCH] ath9k: release allocated buffer if timed out

2020-05-20 Thread Brian Norris
On Wed, May 13, 2020 at 12:02 PM Brian Norris wrote: > > On Wed, May 13, 2020 at 12:05 AM Kalle Valo wrote: > > Actually it's already reverted in -next, nobody just realised that it's > > a regression from commit 728c1e2a05e4: > > > > ced21a

Re: [PATCH v2 12/15] ath10k: use new module_firmware_crashed()

2020-05-21 Thread Brian Norris
On Tue, May 19, 2020 at 10:37 PM Emmanuel Grumbach wrote: > So I believe we already have this uevent, it is the devcoredump. All > we need is to add the unique id. I think there are a few reasons that devcoredump doesn't satisfy what either Luis or I want. 1) it can be disabled entirely [1], for

Re: [PATCH v4 7/7] pwm: cros-ec: Simplify EC error handling

2020-08-06 Thread Brian Norris
On Thu, Aug 6, 2020 at 8:33 AM Guenter Roeck wrote: > > With enhanced error reporting from cros_ec_cmd_xfer_status() in place, > we can fully use it and no longer rely on EC error codes. > > Signed-off-by: Guenter Roeck Reviewed-by: Brian Norris

Re: [PATCH 1/1] mwifiex: Fix possible buffer overflows in mwifiex_config_scan

2021-01-11 Thread Brian Norris
(Note: this is version 1; there's a later version posted, which does not have a v2 tag...) https://lore.kernel.org/linux-wireless/20201208150951.35866-1-ruc_zhangxiao...@163.com/ On Sat, Jan 9, 2021 at 7:11 AM Peter Seiderer wrote: > On Tue, 8 Dec 2020 20:45:23 +0800, Xiaohui Zhang > wrote: >

Re: [PATCH] ath10k: Remove voltage regulator votes during wifi disable

2020-12-10 Thread Brian Norris
On Thu, Dec 10, 2020 at 7:09 AM Rakesh Pillai wrote: > --- a/drivers/net/wireless/ath/ath10k/snoc.c > +++ b/drivers/net/wireless/ath/ath10k/snoc.c > @@ -1045,14 +1085,18 @@ static int ath10k_snoc_hif_power_up(struct ath10k *ar, > ret = ath10k_snoc_init_pipes(ar); > if (ret) { >

Re: [PATCH] ath10k: Fix error handling in case of CE pipe init failure

2020-12-11 Thread Brian Norris
QCAHLSWMTPLZ-1 > > Fixes: 4945af5b264f ("ath10k: enable SRRI/DRRI support on ddr for WCN3990") > Signed-off-by: Rakesh Pillai Reviewed-by: Brian Norris

Re: [PATCH 1/1] mwifiex: Fix possible buffer overflows in mwifiex_config_scan

2020-12-08 Thread Brian Norris
On Tue, Dec 8, 2020 at 7:14 AM Xiaohui Zhang wrote: > > From: Zhang Xiaohui > > mwifiex_config_scan() calls memcpy() without checking > the destination size may trigger a buffer overflower, > which a local user could use to cause denial of service > or the execution of arbitrary code. > Fix it by

Re: [PATCH 1/1] mwifiex: Fix possible buffer overflows in mwifiex_uap_bss_param_prepare

2020-12-08 Thread Brian Norris
(FWIW, this author's mail has been routed to my spam mailbox. That's partly my fault and/or my "choice" of mail provider, but that's why I only see these once Kalle replies to them.) On Tue, Dec 8, 2020 at 8:03 AM Xiaohui Zhang wrote: > > From: Zhang Xiaohui > > mwifiex_uap_bss_param_prepare() c

Re: [PATCH] marvell/mwifiex: replace one-element array with flexible-array member.

2021-01-19 Thread Brian Norris
Hi, On Fri, Jan 15, 2021 at 1:39 AM Jiapeng Zhong wrote: > > Fix the follow coccicheck warnings: > > ./drivers/net/wireless/marvell/mwifiex/fw.h: WARNING use flexible-array > member instead(https://www.kernel.org/doc/html/latest/process/ > deprecated.html#zero-length-and-one-element-arrays) > > R

Re: [PATCH] marvell/mwifiex: replace one-element array with flexible-array member.

2021-01-19 Thread Brian Norris
One more thing, for context: On Tue, Jan 19, 2021 at 11:11 AM Brian Norris wrote: > On Fri, Jan 15, 2021 at 1:39 AM Jiapeng Zhong > wrote: > > > > Fix the follow coccicheck warnings: > > > > ./drivers/net/wireless/marvell/mwifiex/fw.h: WARNING use flexible-

Re: [RFC 2/7] ath10k: Add support to process rx packet in thread

2021-03-22 Thread Brian Norris
On Mon, Mar 22, 2021 at 4:58 PM Ben Greear wrote: > On 7/22/20 6:00 AM, Felix Fietkau wrote: > > On 2020-07-22 14:55, Johannes Berg wrote: > >> On Wed, 2020-07-22 at 14:27 +0200, Felix Fietkau wrote: > >> > >>> I'm considering testing a different approach (with mt76 initially): > >>> - Add a mac80

Re: [PATCH] wireless/marvell/mwifiex: Fix a double free in mwifiex_send_tdls_action_frame

2021-04-13 Thread Brian Norris
er, action_code, > > dialog_token, status_code, > > skb)) { > > - dev_kfree_skb_any(skb); Good catch, and this looks correct for most cases, but I'll note that you missed one issu

Re: [PATCH 1/2] platform/chrome: cros_ec_proto: Use EC_HOST_EVENT_MASK not BIT

2020-12-09 Thread Brian Norris
ocess/submitting-patches.html#describe-changes With luck, maintainers can fix that up when applying, so you don't need to resend. Otherwise, both patches look good to me, thanks! Reviewed-by: Brian Norris

Re: [PATCH 0/3] mac80211: Trigger disconnect for STA during recovery

2020-12-17 Thread Brian Norris
On Tue, Dec 15, 2020 at 10:23:33AM -0800, Ben Greear wrote: > On 12/15/20 9:21 AM, Youghandhar Chintala wrote: > > From: Rakesh Pillai > > > > Currently in case of target hardware restart ,we just reconfig and > > re-enable the security keys and enable the network queues to start > > data traffic

Re: [PATCH 0/3] mac80211: Trigger disconnect for STA during recovery

2020-12-17 Thread Brian Norris
On Tue, Dec 15, 2020 at 10:51:13PM +0530, Youghandhar Chintala wrote: > From: Rakesh Pillai I meant to mention in my other reply: the threading on this series is broken (as in, it doesn't exist). It looks like you're using git-send-email (good!), but somehow it doesn't have any In-Reply-To or Ref

Re: [PATCH 0/3] mac80211: Trigger disconnect for STA during recovery

2020-12-17 Thread Brian Norris
On Thu, Dec 17, 2020 at 2:57 PM Ben Greear wrote: > On 12/17/20 2:24 PM, Brian Norris wrote: > > I'd also note that we don't operate in AP mode -- only STA -- and IIRC > > Ben, you've complained about AP mode in the past. > > I complain about all sorts of thing

Re: [PATCH v2] ath10k: skip the wait for completion to recovery in shutdown path

2020-12-01 Thread Brian Norris
On Thu, Nov 26, 2020 at 9:16 AM Youghandhar Chintala wrote: > --- a/drivers/net/wireless/ath/ath10k/snoc.c > +++ b/drivers/net/wireless/ath/ath10k/snoc.c > @@ -1790,9 +1790,6 @@ static int ath10k_snoc_remove(struct platform_device > *pdev) > > reinit_completion(&ar->driver_recovery); > >

Re: [PATCH] mwifiex: pcie: add enable_device_dump module parameter

2020-11-20 Thread Brian Norris
(Sorry if anything's a bit slow here. I don't really have time to write out full proposals myself.) On Fri, Oct 30, 2020 at 3:30 AM Tsuchiya Yuto wrote: > Let me know if splitting this patch like this works. 1) The first patch > is to add this module parameter but don't change the default behavio

Re: [PATCH 1/3] mwifiex: disable ps_mode explicitly by default instead

2020-11-20 Thread Brian Norris
On Fri, Oct 30, 2020 at 1:04 AM Tsuchiya Yuto wrote: > On Thu, 2020-10-29 at 11:25 -0700, Brian Norris wrote: > > For the record, Chrome OS supports plenty of mwifiex systems with 8897 > > (SDIO only) and 8997 (PCIe), with PS enabled, and you're hurting > > those.

Re: [PATCH] MTD: atmel_nand: POI fall back is not an issue: change log level

2014-02-22 Thread Brian Norris
On Wed, Feb 12, 2014 at 12:42:00PM +0100, Alexandre Belloni wrote: > Small nitpick, subject should read PIO, not POI. Amended the commit message and pushed to l2-mtd.git. Thanks! Brian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...

[GIT PULL] MTD fixes for 3.14-rc

2014-02-25 Thread Brian Norris
ted in Linux. The expected layouts are now documented in the commit messages, and we plan to add this under Documentation/mtd/nand/ eventually. ---- Brian Norris (1): mtd: nand: fix off-by-one read retry mode counting Pekon Gu

Re: [PATCH 1/2] jffs2: Fix segmentation fault found in stress test

2014-02-25 Thread Brian Norris
On Mon, Jan 06, 2014 at 07:06:54PM +0530, Kamlakant Patel wrote: > Creating a large file on a JFFS2 partition sometimes crashes with this call > trace: [...] > > This crash is caused because the 'positions' is declared as an array of signed > short. The value of position is in the range 0..65535,

Re: [PATCH -next] mtd: nand: omap: fix error return code in omap_nand_probe()

2013-11-05 Thread Brian Norris
On Thu, Oct 31, 2013 at 7:18 PM, Jingoo Han wrote: > On Friday, November 01, 2013 9:16 AM, Wei Yongjun wrote: >> >> From: Wei Yongjun >> >> Fix to return a negative error code from the error handling >> case instead of 0, as done elsewhere in this function. > > Commit message is right? :-( It so

Re: [PATCH 2/2] mtd: cmdlinepart: use cmdline partition parser lib

2013-11-05 Thread Brian Norris
On Tue, Nov 5, 2013 at 2:43 PM, Andrew Morton wrote: > On Tue, 22 Oct 2013 13:14:17 + Caizhiyong > wrote: > >> In the previous version, adjust the cmdline parser code to library-style >> code, and move it to a separate file "block/cmdline-parser.c", we can use >> it in some client code. ther

Re: [PATCH -next] mtd: nand: omap: fix error return code in omap_nand_probe()

2013-11-06 Thread Brian Norris
On Tue, Nov 05, 2013 at 07:45:27PM -0300, Ezequiel Garcia wrote: > On Tue, Nov 05, 2013 at 01:59:25PM -0800, Brian Norris wrote: > > On Thu, Oct 31, 2013 at 7:18 PM, Jingoo Han wrote: > > > On Friday, November 01, 2013 9:16 AM, Wei Yongjun wrote: > > >> > > >

Re: [PATCH -next] mtd: nand: omap: fix error return code in omap_nand_probe()

2013-11-06 Thread Brian Norris
On Wed, Nov 06, 2013 at 06:06:25PM +, Pekon Gupta wrote: > > From: Brian Norris [mailto:computersforpe...@gmail.com] > > > On Thu, Oct 31, 2013 at 7:18 PM, Jingoo Han > > >> From: Wei Yongjun > > >> > > >> Fix to return a negative error co

Re: [PATCH] mtd: nand: remove deprecated IRQF_DISABLED

2013-11-07 Thread Brian Norris
On Sun, Oct 13, 2013 at 08:21:32AM +0200, Michael Opdenacker wrote: > This patch proposes to remove the use of the IRQF_DISABLED flag > > It's a NOOP since 2.6.35 and it will be removed one day. > > Signed-off-by: Michael Opdenacker Pushed to l2-mtd.git. Thanks! Brian -- To unsubscribe from th

Re: What is wrong?

2014-03-04 Thread Brian Norris
On Mon, Mar 03, 2014 at 03:13:36PM -0600, Andrew Ruder wrote: > On Thu, Feb 27, 2014 at 01:22:08PM -0800, Brian Norris wrote: > > Perhaps Richard or Andrew can comment on whether this patch should help > > you. But I think JFFS2 on NAND uses write-buffered support which can be >

Re: [PATCH v2 RESEND 1/2] mtd: Add a retlen parameter to _get_{fact,user}_prot_info

2014-03-04 Thread Brian Norris
On Tue, Jan 28, 2014 at 09:29:44AM +0100, Christian Riesch wrote: > Signed-off-by: Christian Riesch > Cc: Artem Bityutskiy > Cc: Brian Norris > --- > drivers/mtd/chips/cfi_cmdset_0001.c | 31 +-- > drivers/mtd/devices/mtd_dataflash.c |7

Re: [PATCH v2 RESEND 2/2] mtd: Fix the behavior of otp write if there is not enough room for data

2014-03-04 Thread Brian Norris
Hi Christian, A few comments below. On Tue, Jan 28, 2014 at 09:29:45AM +0100, Christian Riesch wrote: > An OTP write shall write as much data as possible to the OTP memory > and return the number of bytes that have actually been written. > If no data could be written at all due to lack of OTP mem

Re: [PATCH v2 RESEND 2/2] mtd: Fix the behavior of otp write if there is not enough room for data

2014-03-04 Thread Brian Norris
A few more things... On Tue, Mar 04, 2014 at 11:20:10PM -0800, Brian Norris wrote: > On Tue, Jan 28, 2014 at 09:29:45AM +0100, Christian Riesch wrote: > > An OTP write shall write as much data as possible to the OTP memory > > and return the number of bytes that have actually been

Re: [PATCH] mtd: m25p80: Flash protection support for STmicro chips

2014-03-05 Thread Brian Norris
+ Marek, Angus On Thu, Feb 27, 2014 at 03:34:06PM +0100, Gerlando Falauto wrote: > Hi, > > it's me again. > In my opinion (and experience) this introduces a pretty serious bug > (not to mention the compatibility issues), yet I haven't heard a > single word or found a patch applied about it in thr

Re: [PATCH] mtd: m25p80: Flash protection support for STmicro chips

2014-03-05 Thread Brian Norris
Different email for Austin? On Wed, Mar 05, 2014 at 12:10:08AM -0800, Brian Norris wrote: > + Marek, Angus > > On Thu, Feb 27, 2014 at 03:34:06PM +0100, Gerlando Falauto wrote: > > Hi, > > > > it's me again. > > In my opinion (and experience) this intro

Re: [PATCH v2 RESEND 2/2] mtd: Fix the behavior of otp write if there is not enough room for data

2014-03-06 Thread Brian Norris
Hi, On Wed, Mar 05, 2014 at 09:50:35AM +0100, Christian Riesch wrote: > On March 04, 2014 23:20 -0800 Brian Norris > wrote: > >On Tue, Jan 28, 2014 at 09:29:45AM +0100, Christian Riesch wrote: > >>An OTP write shall write as much data as possible to the OTP memory > &g

Re: [PATCH 3/4] mtd: block2mtd: check device size

2014-03-06 Thread Brian Norris
Hi, On Wed, Jan 29, 2014 at 08:51:05PM +0800, Fabian Frederick wrote: > On Wed, 29 Jan 2014 07:04:25 -0300 Ezequiel Garcia > wrote: > > I saw you sent a v2 for one of the patches on this series, > > but maybe this is worth considering too. > > > > On Thu, Jan 23, 2014 at 08:53:31PM +0100, Fabia

Re: What is wrong?

2014-02-27 Thread Brian Norris
+ others Hi Leon, Can you please keep the CC list intact? And please try to reply below the quotes and trim context, rather than top-posting. Thanks! On Thu, Feb 27, 2014 at 02:00:25PM +0200, Leon Pollak wrote: > I am VERY(!) thankful to you for the answer. > First, I am calm now that there is n

Re: [PATCH v6 01/35] mtd: st_spi_fsm: Allocate resources and register with MTD framework

2014-03-20 Thread Brian Norris
Hi Lee, I really can't take this patch separately. You'll need to resend the whole series soon. On Tue, Mar 11, 2014 at 08:23:16AM +, Lee Jones wrote: > Sorry about the previous fixup misses. There were a couple of patches > which I had failed to squash into the pack. Hopefully the rest of th

Re: [PATCH 27/35] mtd: st_spi_fsm: Supply a busy wait for post-write status

2014-03-20 Thread Brian Norris
On Tue, Feb 18, 2014 at 02:55:54PM +, Lee Jones wrote: > When we write data to the Serial Flash chip we'll wait a predetermined > period of time before giving up. During that period of time we poll the > status register until completion. > > Acked-by Angus Clark > Signed-off-by: Lee Jones >

Re: [PATCH 11/35] mtd: st_spi_fsm: Use device size to determine address width

2014-03-20 Thread Brian Norris
On Tue, Feb 18, 2014 at 02:55:38PM +, Lee Jones wrote: > Take some known parameters, namely size and number of sectors and use > them to determine weather a device can support 32bit addressing or not. > If it can, set the associated flash capability flag for latter use. > > Acked-by Angus Clar

Re: [PATCH 25/35] mtd: st_spi_fsm: Add the ability to read from a Serial Flash device

2014-03-20 Thread Brian Norris
On Tue, Feb 18, 2014 at 02:55:52PM +, Lee Jones wrote: > diff --git a/drivers/mtd/devices/st_spi_fsm.c > b/drivers/mtd/devices/st_spi_fsm.c > index fe538bb..e4815fe 100644 > --- a/drivers/mtd/devices/st_spi_fsm.c > +++ b/drivers/mtd/devices/st_spi_fsm.c > @@ -942,6 +945,100 @@ static int stfsm

Re: [PATCH v5 00/35] mtd: st_spi_fsm: Add new driver

2014-03-20 Thread Brian Norris
On Tue, Feb 18, 2014 at 02:55:27PM +, Lee Jones wrote: > This should be the final version. :) I had a few more comments. Contrary to my comment on patch 1, I don't think too many of my comments were repeats. But nothing too big anyway. I expect that I'll merge this as soon as you address my l

Re: [PATCH v6 00/36] mtd: st_spi_fsm: Add new driver

2014-03-20 Thread Brian Norris
On Thu, Mar 20, 2014 at 09:20:32AM +, Lee Jones wrote: > This should be the final version (again) :) > > Version 6: > Serviced 3 nits picked up by Brian during final review. I'm really sorry to do this again, but can you *please* read *all* of my comments? You're missing at least the follow

Re: [PATCH v6 00/36] mtd: st_spi_fsm: Add new driver

2014-03-20 Thread Brian Norris
On Thu, Mar 20, 2014 at 09:20:32AM +, Lee Jones wrote: > This should be the final version (again) :) > > Version 6: > Serviced 3 nits picked up by Brian during final review. > [...] > Documentation/devicetree/bindings/mtd/st-fsm.txt | 26 ++ > arch/arm/boot/dts/stih416-pinctrl.dtsi

Re: [PATCH v6 36/36] ARM: STi: Add support for the FSM Serial Flash Controller

2014-03-20 Thread Brian Norris
e terms of the GNU General Public License version 2 as > + * publishhed by the Free Software Foundation. > + */ > +/ { > + soc { > + spifsm: spifsm@fe902000 { > + #address-cells = <1>; > + #size-cells= <1>;

Re: [PATCH 0/5] mtd: st_spi_fsm: Sweep-up remaining blocking-issues

2014-03-20 Thread Brian Norris
On Thu, Mar 20, 2014 at 11:11:42AM +, Lee Jones wrote: > Sincerest apologies for missing these before. > > I hope this now covers all of points you raised. Looks good. Thanks for following up. Pushed all to l2-mtd.git. Thanks, Brian -- To unsubscribe from this list: send the line "unsubscrib

Re: [PATCH 1/5] mtd: st_spi_fsm: Remove useless consts from function arguments

2014-03-20 Thread Brian Norris
On Thu, Mar 20, 2014 at 04:48:10AM -0700, Joe Perches wrote: > On Thu, 2014-03-20 at 11:41 +, Lee Jones wrote: > > On Thu, 20 Mar 2014, Joe Perches wrote: > > > On Thu, 2014-03-20 at 11:11 +, Lee Jones wrote: > > > > Reported-by: Brian Norris &g

Re: [PATCH 1/5] mtd: st_spi_fsm: Remove useless consts from function arguments

2014-03-20 Thread Brian Norris
On Thu, Mar 20, 2014 at 5:03 AM, Lee Jones wrote: >> Signed-off-by: Brian Norris > > Patch looks good to me: > Acked-by: Lee Jones Squashed into $SUBJECT patch and pushed to l2-mtd.git. Brian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel"

Re: [PATCH 1/5] mtd: st_spi_fsm: Remove useless consts from function arguments

2014-03-20 Thread Brian Norris
On Thu, Mar 20, 2014 at 5:13 AM, Joe Perches wrote: > On Thu, 2014-03-20 at 12:03 +, Lee Jones wrote: >> > Good catch. That wasn't my intention. >> > > Why? >> An oversight. > > That's still not an explanation. > > Why, unless cast away by the code itself, is > const removal a good thing? It'

Re: [PATCH 1/5] mtd: st_spi_fsm: Remove useless consts from function arguments

2014-03-20 Thread Brian Norris
On Thu, Mar 20, 2014 at 05:44:45AM -0700, Joe Perches wrote: > On Thu, 2014-03-20 at 05:41 -0700, Brian Norris wrote: > > I also don't think that a function parameter is the right place to > > mark const like this. Function arguments are always pass-by-value, so > >

Re: [PATCH 2/3] mtd: davinci-nand: add dts property for NAND_NO_SUBPAGE_WRITE option

2014-03-20 Thread Brian Norris
On Thu, Mar 20, 2014 at 01:12:35PM -0400, Santosh Shilimkar wrote: > Boris, Who's Boris? And why should Boris be taking this patch? It's an MTD patch. > On Thursday 20 March 2014 01:06 PM, Ivan Khoronzhuk wrote: > > From: Murali Karicheri > > > > After testing NAND flash with ubifs for k2hk-emv

Re: [PATCH 2/3] mtd: davinci-nand: add dts property for NAND_NO_SUBPAGE_WRITE option

2014-03-20 Thread Brian Norris
On Thu, Mar 20, 2014 at 01:37:42PM -0400, Santosh Shilimkar wrote: > On Thursday 20 March 2014 01:29 PM, Brian Norris wrote: > > On Thu, Mar 20, 2014 at 01:12:35PM -0400, Santosh Shilimkar wrote: > >> Boris, > > > > Who's Boris? And why should Boris be takin

Re: [PATCH 2/3] mtd: davinci-nand: add dts property for NAND_NO_SUBPAGE_WRITE option

2014-03-20 Thread Brian Norris
On Thu, Mar 20, 2014 at 02:02:39PM -0400, Santosh Shilimkar wrote: > On Thursday 20 March 2014 01:44 PM, Warner Losh wrote: > > I though sub page writing was one of the fields in the onfi and/or > > jedec(toggle) meta data structures. Have you looked there? > > > Am not sure if I follow you. The

Re: [PATCH] mtd: nand: fix erronous read_buf call in nand_write_page_raw_syndrome

2014-02-11 Thread Brian Norris
On Sat, Feb 01, 2014 at 07:10:28PM +0100, Boris BREZILLON wrote: > read_buf is called in place of write_buf in the > nand_write_page_raw_syndrome function. > > Signed-off-by: Boris BREZILLON Good catch! I guess no one really tests this function. I can understand that, since it's in the "raw" ver

Re: [PATCH 0/8] mtd: Remove unnecessary OOM messages

2014-02-11 Thread Brian Norris
On Thu, Feb 06, 2014 at 03:07:19PM +0900, Jingoo Han wrote: > The site-specific OOM messages are unnecessary, because they > duplicate the MM subsystem generic OOM message. For example, > k.alloc and v.alloc failures use dump_stack(). > > Jingoo Han (8): > mtd: devices: elm: Remove unnecessa

Re: [PATCH 15/28] Remove TI_AEMIF

2014-02-11 Thread Brian Norris
+ Ivan, others On Sun, Feb 09, 2014 at 09:54:02PM +0100, Paul Bolle wrote: > On Sun, 2014-02-09 at 19:47 +0100, Richard Weinberger wrote: > > The symbol is an orphan, get rid of it. > > > > Signed-off-by: Richard Weinberger > > --- > > drivers/mtd/nand/Kconfig | 2 +- > > 1 file changed, 1 inse

Re: [PATCH 2/3] jffs2: avoid soft-lockup in jffs2_reserve_space_gc()

2014-02-11 Thread Brian Norris
Hi Andrew, On Tue, Feb 11, 2014 at 3:54 PM, Andrew Morton wrote: > On Sat, 8 Feb 2014 10:15:39 +0800 Li Zefan wrote: > I now have four jffs2 bugfixes but cannot unload them on anyone. > Waddup? Well, at best we have 3 "maintainers" involved in MTD (David, Artem, and me), but David is often quit

Re: [PATCH] mtd: nand: MTD_NAND_SH_FLCTL should depend on HAS_DMA

2014-02-21 Thread Brian Norris
Hi Geert, On Fri, Feb 21, 2014 at 09:27:27PM +0100, Laurent Pinchart wrote: > On Friday 21 February 2014 20:54:34 Geert Uytterhoeven wrote: > > If NO_DMA=y: > > > > drivers/built-in.o: In function `flctl_dma_fifo0_transfer': > > sh_flctl.c:(.text+0x210398): undefined reference to `dma_map

Re: [PATCH v4 00/36] mtd: st_spi_fsm: Add new driver

2014-01-22 Thread Brian Norris
Hi Lee, On Wed, Jan 22, 2014 at 12:50:49PM +, Lee Jones wrote: > > Version 4: > > Tended to Brian's previous review comments > > - Checkpatch acceptance > > - MODULE_DEVICE_TABLE() name slip correction > > - Timeout issue(s) resolved > > - Potential infinite loop mitigated >

Re: [RFC PATCH 1/9] mtd: nand: retrieve ECC requirements from Hynix READ ID byte 4

2014-01-22 Thread Brian Norris
+ Huang Hi Boris, On Wed, Jan 08, 2014 at 03:21:56PM +0100, Boris BREZILLON wrote: > The Hynix nand flashes store their ECC requirements in byte 4 of its id > (returned on READ ID command). > > Signed-off-by: Boris BREZILLON I haven't verified yet (perhaps Huang can confirm?), but this may be

[GIT PULL] MTD changes for 3.15

2014-04-06 Thread Brian Norris
uf call in nand_write_page_raw_syndrome Brian Norris (3): mtd: nand: force NAND_CMD_READID onto 8-bit bus mtd: nand: don't use read_buf for 8-bit ONFI transfers mtd: m25p80: add Macronix mx66l1g55g 1Gbit SPI flash Cai Zhiyong (1): mtd: nand: remove unused function input parameter Chri

Re: [PATCH v3] ARM: davinci: aemif: get rid of davinci-nand driver dependency on aemif

2014-01-09 Thread Brian Norris
> Do you agree if this patch will go through Davinci tree? > > > > This is the last one we need to reuse Davinci Nand driver for Keystone. > > Since we never got an ack from MTD folks, I am going and go ahead and > try pushing this through ARM-SoC regardless. I w

Re: [PATCH 1/7] mtd: denali: Drop print of build date/time

2014-01-09 Thread Brian Norris
On Thu, Dec 26, 2013 at 05:24:53PM +0900, Jingoo Han wrote: > On Tuesday, December 24, 2013 6:55 AM, Josh Triplett wrote: > > > > The kernel already has this information, and individual drivers > > shouldn't duplicate that. BTW, it is possible for modules to be built at a different time than the

Re: [PATCH] mtd: nand: assign mtd->name in find_full_id_nand

2014-01-11 Thread Brian Norris
Hi, On Thu, Dec 26, 2013 at 10:19:39AM +0800, Huang Shijie wrote: > On Thu, Dec 26, 2013 at 01:51:58AM +, Caizhiyong wrote: > > From: Cai Zhiyong > > Date: Wed, 25 Dec 2013 21:19:21 +0800 > > Subject: [PATCH] mtd: nand: assign mtd->name in find_full_id_nand > > > > This patch assigned the ty

Re: [PATCH] MIPS: Alchemy: add missing platform_set_drvdata() in au1550nd_probe()

2013-11-26 Thread Brian Norris
On Mon, Nov 11, 2013 at 02:18:29PM +0800, Wei Yongjun wrote: > From: Wei Yongjun > > Add missing platform_set_drvdata() in au1550nd_probe(), otherwise > calling platform_get_drvdata() in remove returns NULL. An alternative solution: just allocate ctx with devm_kzalloc(). Then you don't have to k

Re: [PATCH 07/12] memory: davinci-aemif: introduce AEMIF driver

2013-11-26 Thread Brian Norris
On Tue, Nov 26, 2013 at 01:26:44PM -0500, Santosh Shilimkar wrote: > On Tuesday 26 November 2013 12:21 PM, Sekhar Nori wrote: > > On 11/26/2013 8:35 PM, Santosh Shilimkar wrote: > >> On Tuesday 26 November 2013 02:20 AM, Sekhar Nori wrote: > >>> On Monday 11 November 2013 10:36 PM, Khoronzhuk, Ivan

Re: [PATCH v2 00/10] Reuse davinci-nand driver for Keystone arch

2013-11-26 Thread Brian Norris
Hi Ivan, On Thu, Nov 21, 2013 at 01:28:15PM +0200, Ivan Khoronzhuk wrote: > This series contains fixes and updates of Davinci nand driver in > order to reuse it for Keystone platform. > > The series is combination of two following series: > - Davinci nand driver fixes and updates: > https://lkm

Re: [PATCH] MIPS: Alchemy: add missing platform_set_drvdata() in au1550nd_probe()

2013-11-26 Thread Brian Norris
Hi Jingoo, On Wed, Nov 27, 2013 at 09:14:18AM +0900, Jingoo Han wrote: > On Wednesday, November 27, 2013 8:50 AM, Brian Norris wrote: > > On Mon, Nov 11, 2013 at 02:18:29PM +0800, Wei Yongjun wrote: > > > From: Wei Yongjun > > > > > > Add missing plat

Re: [PATCH 00/23] mtd: st_spi_fsm: Add new device

2013-11-26 Thread Brian Norris
+ Huang, Mark, SPI list There seem to be multiple efforts going on that are vaguely related. I'd like to see more of the same people appearing on the CC list, to keep better coordinated. On that topic, is the SPI dev list relevant, or would anybody working on the intersection of SPI and MTD be on

Re: [PATCH] mtd: nand: assign mtd->name in find_full_id_nand

2014-01-12 Thread Brian Norris
On Mon, Jan 13, 2014 at 04:12:45AM +, Caizhiyong wrote: > > -Original Message- > > From: Brian Norris [mailto:computersforpe...@gmail.com] > > Sent: Sunday, January 12, 2014 4:10 AM > > > > On Thu, Dec 26, 2013 at 10:19:39AM +0800, Huang Shijie wrote: &g

Re: [PATCH] mtd: Move major number definitions to major.h

2013-10-15 Thread Brian Norris
+ LKML On Sun, Oct 13, 2013 at 2:05 PM, Ezequiel Garcia wrote: > This patch moves the char and block major number definitions > to major.h to be with the rest of the major numbers. > While doing this, include major.h in the files that need it. The patch looks good to me. It touches a common file

Re: [PATCH] mtg: docg3: use free_bch() instead of kfree()

2013-10-11 Thread Brian Norris
On Fri, Oct 11, 2013 at 12:40:21PM +0800, Wei Yongjun wrote: > From: Wei Yongjun > > Use free_bch() instead of kfree() to free init_bch() > allocated data. > > Signed-off-by: Wei Yongjun Pushed to l2-mtd.git. Thanks! Brian -- To unsubscribe from this list: send the line "unsubscribe linux-ker

Re: [PATCH -next] mtd: remove duplicated include from mtdcore.c

2013-10-30 Thread Brian Norris
On Wed, Oct 30, 2013 at 06:56:41AM -0300, Ezequiel Garcia wrote: > On Wed, Oct 30, 2013 at 01:34:22PM +0800, Wei Yongjun wrote: > > From: Wei Yongjun > > > > Remove duplicated include. > > > > Signed-off-by: Wei Yongjun > > --- > > drivers/mtd/mtdcore.c | 1 - > > 1 file changed, 1 deletion(-)

[GIT PULL] MTD fixes for 3.13-rc

2013-12-12 Thread Brian Norris
Hi Linus, Here are two MTD fixes for the pxa3xx-nand driver. Brian The following changes since commit 6ce4eac1f600b34f2f7f58f9cd8f0503d79e42ae: Linux 3.13-rc1 (2013-11-22 11:30:55 -0800) are available in the git repository at: git://git.infradead.org/linux-mtd.git tags/for-linus-20131212

Re: [PATCH] mtd: increase max page/OOB size to support 16K pagesize NAND

2013-12-12 Thread Brian Norris
On Fri, Dec 13, 2013 at 05:01:56AM +, Caizhiyong wrote: > The Toshiba's TC58TEG5DCJTA pagesize is 16K, oob size is 1280 bytes. > So increase the NAND_MAX_OOBSIZE and NAND_MAX_PAGESIZE. > > Signed-off-by: Huang Shijie > Signed-off-by: Artem Bityutskiy > Signed-off-by: David Woodhouse Huh? I

Re: [PATCH] mtd: increase max page/OOB size to support 16K pagesize NAND

2013-12-13 Thread Brian Norris
On Fri, Dec 13, 2013 at 05:03:49AM +, Caizhiyong wrote: > From: Cai Zhiyong > Date: Fri, 13 Dec 2013 12:52:46 +0800 > Subject: [PATCH] mtd: increase max page/OOB size to support 16K pagesize NAND. > > The Toshiba's TC58TEG5DCJTA pagesize is 16K, oob size is 1280 bytes. > So increase the NAND_

Re: [PATCH] mtd: increase max page/OOB size to support 16K pagesize NAND

2013-12-13 Thread Brian Norris
On Fri, Dec 13, 2013 at 03:27:12PM +0800, Huang Shijie wrote: > On Fri, Dec 13, 2013 at 05:03:49AM +, Caizhiyong wrote: > > --- a/include/linux/mtd/nand.h > > +++ b/include/linux/mtd/nand.h > > @@ -56,8 +56,8 @@ extern int nand_unlock(struct mtd_info *mtd, loff_t ofs, > > uint64_t len); > >

Re: [GIT PULL] MTD fixes for 3.13-rc

2013-12-13 Thread Brian Norris
On Fri, Dec 13, 2013 at 11:37:36AM -0800, Linus Torvalds wrote: > I do note that your pgp key still has very few signatures, and none of > them in my normal key ring. Any possibility that you might expand on > your signatures a bit? I'll see what I can do. dwmw2 offered to sign, but we're not exac

Re: [PATCH 0/2] MTD maintenance updates

2013-12-13 Thread Brian Norris
On Thu, Dec 05, 2013 at 10:34:48AM +0200, Artem Bityutskiy wrote: > On Wed, 2013-12-04 at 15:28 -0800, Brian Norris wrote: > > BTW, I'd like to get David's "ack" for these patches, and it'd be nice > > to hear > > from Artem too, since he has previo

Re: [GIT PULL] MTD fixes for 3.13-rc

2013-12-14 Thread Brian Norris
On Sat, Dec 14, 2013 at 12:59:55PM +0100, Richard Weinberger wrote: > On Sat, Dec 14, 2013 at 6:03 AM, Brian Norris > wrote: > > On Fri, Dec 13, 2013 at 11:37:36AM -0800, Linus Torvalds wrote: > >> I do note that your pgp key still has very few signatures, and none of >

Re: [PATCH] MIPS: Alchemy: add missing platform_set_drvdata() in au1550nd_probe()

2013-12-17 Thread Brian Norris
On Tue, Nov 26, 2013 at 07:35:55PM -0800, Brian Norris wrote: > On Wed, Nov 27, 2013 at 09:14:18AM +0900, Jingoo Han wrote: > > On Wednesday, November 27, 2013 8:50 AM, Brian Norris wrote: > > > On Mon, Nov 11, 2013 at 02:18:29PM +0800, Wei Yongjun wrote: > > > > ---

Re: [PATCH v3 9/9] mtd: nand: davinci: don't request AEMIF address range

2013-12-17 Thread Brian Norris
On Thu, Dec 05, 2013 at 07:25:57PM +0200, Ivan Khoronzhuk wrote: > The TI AEMIF driver registers are used to setup timings for each chip > select. The same registers range is used to setup NAND settings. > The AEMIF and NAND drivers not use the same registers in this range. > > In case with TI AEM

Re: [PATCH v3 7/9] mtd: nand: davinci: adjust DT properties to MTD generic

2013-12-17 Thread Brian Norris
On Thu, Dec 05, 2013 at 07:25:55PM +0200, Ivan Khoronzhuk wrote: > --- a/drivers/mtd/nand/davinci_nand.c > +++ b/drivers/mtd/nand/davinci_nand.c > @@ -558,6 +557,8 @@ static struct davinci_nand_pdata > "ti,davinci-mask-chipsel", &prop)) > pdata->mask_chip

Re: [PATCH v3 1/9] mtd: nand: davinci: fix driver registration

2013-12-17 Thread Brian Norris
On Thu, Dec 05, 2013 at 07:25:49PM +0200, Ivan Khoronzhuk wrote: > --- a/drivers/mtd/nand/davinci_nand.c > +++ b/drivers/mtd/nand/davinci_nand.c > @@ -877,6 +877,7 @@ static int __exit nand_davinci_remove(struct > platform_device *pdev) > } > > static struct platform_driver nand_davinci_driver

Re: [PATCH v3 1/9] mtd: nand: davinci: fix driver registration

2013-12-17 Thread Brian Norris
On Tue, Dec 17, 2013 at 2:21 AM, ivan.khoronzhuk wrote: > On 12/17/2013 11:24 AM, Brian Norris wrote: >> On Thu, Dec 05, 2013 at 07:25:49PM +0200, Ivan Khoronzhuk wrote: >>> --- a/drivers/mtd/nand/davinci_nand.c >>> +++ b/drivers/mtd/nand/davinci_nand.c >>> @

[PATCH v8 10/11] ARM: brcmstb: select GISB arbiter and interrupt drivers

2014-07-21 Thread Brian Norris
Signed-off-by: Brian Norris Acked-by: Florian Fainelli --- arch/arm/mach-bcm/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig index 9782e8d80647..58c01aed9752 100644 --- a/arch/arm/mach-bcm/Kconfig +++ b/arch/arm/mach-bcm

[PATCH v8 08/11] ARM: brcmstb: gic: add compatible string for Broadcom Brahma15

2014-07-21 Thread Brian Norris
From: Marc Carino Document the Broadcom Brahma B15 GIC implementation as compatible with the ARM GIC standard. Signed-off-by: Marc Carino Acked-by: Florian Fainelli Signed-off-by: Brian Norris --- Documentation/devicetree/bindings/arm/gic.txt | 1 + 1 file changed, 1 insertion(+) diff

[PATCH v8 11/11] MAINTAINERS: add entry for Broadcom ARM STB architecture

2014-07-21 Thread Brian Norris
Signed-off-by: Brian Norris --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 61a8f486306b..8e9cce53f618 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1969,6 +1969,15 @@ F: arch/arm/mach-bcm/bcm_5301x.c F: arch/arm/boot/dts

[PATCH v8 03/11] ARM: brcmstb: add debug UART for earlyprintk support

2014-07-21 Thread Brian Norris
From: Marc Carino Add the UART definitions needed to support earlyprintk on brcmstb machines. Signed-off-by: Marc Carino Acked-by: Florian Fainelli Signed-off-by: Brian Norris --- arch/arm/Kconfig.debug | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a

[PATCH v8 09/11] ARM: brcmstb: dts: add a reference DTS for Broadcom 7445

2014-07-21 Thread Brian Norris
From: Marc Carino Add a sample DTS which will allow bootup of a board populated with the BCM7445 chip. Signed-off-by: Marc Carino Signed-off-by: Brian Norris Cc: Matt Porter --- arch/arm/boot/dts/Makefile | 2 + arch/arm/boot/dts/bcm7445-bcm97445svmb.dts | 14 arch

[PATCH v8 05/11] ARM: Enable erratum 798181 for Broadcom Brahma-B15

2014-07-21 Thread Brian Norris
From: Gregory Fong Broadcom Brahma-B15 (r0p0..r0p2) is also affected by Cortex-A15 erratum 798181, so enable the workaround for Brahma-B15. Signed-off-by: Gregory Fong Acked-by: Marc Carino Signed-off-by: Brian Norris Cc: Rob Herring Cc: Will Deacon --- arch/arm/kernel/smp_tlb.c | 20

[PATCH v8 06/11] ARM: brcmstb: add CPU binding for Broadcom Brahma15

2014-07-21 Thread Brian Norris
From: Marc Carino Add the Broadcom Brahma B15 CPU to the DT CPU binding list. Signed-off-by: Marc Carino Signed-off-by: Brian Norris --- Documentation/devicetree/bindings/arm/cpus.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/cpus.txt b

[PATCH v8 04/11] ARM: do CPU-specific init for Broadcom Brahma15 cores

2014-07-21 Thread Brian Norris
From: Marc Carino Perform any CPU-specific initialization required on the Broadcom Brahma-15 core. Signed-off-by: Marc Carino Acked-by: Florian Fainelli Signed-off-by: Brian Norris Cc: Russell King --- arch/arm/mm/proc-v7.S | 11 +++ 1 file changed, 11 insertions(+) diff --git a

[PATCH v8 07/11] ARM: brcmstb: add misc. DT bindings for brcmstb

2014-07-21 Thread Brian Norris
From: Marc Carino Document the bindings that the Broadcom STB platform needs for proper bootup. Signed-off-by: Marc Carino Acked-by: Florian Fainelli Signed-off-by: Brian Norris --- .../devicetree/bindings/arm/brcm-brcmstb.txt | 95 ++ 1 file changed, 95 insertions

[PATCH v8 01/11] ARM: brcmstb: add infrastructure for ARM-based Broadcom STB SoCs

2014-07-21 Thread Brian Norris
From: Marc Carino The BCM7xxx series of Broadcom SoCs are used primarily in set-top boxes. This patch adds machine support for the ARM-based Broadcom SoCs. Signed-off-by: Marc Carino Signed-off-by: Brian Norris --- arch/arm/configs/multi_v7_defconfig | 1 + arch/arm/mach-bcm/Kconfig

[PATCH v8 02/11] power: reset: Add reboot driver for brcmstb

2014-07-21 Thread Brian Norris
From: Marc Carino Add support for reboot functionality on boards with ARM-based Broadcom STB chipsets. Signed-off-by: Marc Carino Signed-off-by: Brian Norris Cc: Dmitry Eremin-Solenikov Cc: David Woodhouse --- arch/arm/mach-bcm/Kconfig| 1 + drivers/power/reset/Kconfig

[PATCH v8 00/11] ARM: brcmstb: Add Broadcom STB SoC support

2014-07-21 Thread Brian Norris
isc. minor cleanups from mailing-list discussion for v2 v2 (https://lkml.org/lkml/2013/11/26/570): - rebased to v3.13-rc1 - moved implementation to 'mach-bcm' folder - added CPU init for B16RM v1: - initial submission [1] http://www.broadcom.com/products/Cable/Cable-Set-Top-Box-Solutio

Re: [PATCH 2/2] mtd: nand: add ONFI timing mode to nand_timings converter

2014-07-21 Thread Brian Norris
On Fri, Jul 11, 2014 at 09:49:42AM +0200, Boris BREZILLON wrote: > --- /dev/null > +++ b/drivers/mtd/nand/nand_timings.c > @@ -0,0 +1,250 @@ > +/* > + * Copyright (C) 2014 Free Electrons > + * > + * Author: Boris BREZILLON > + * > + * This program is free software; you can redistribute it and/or

Re: [PATCH 0/2] mtd: nand: add basic SDR NAND timings infrastructure

2014-07-21 Thread Brian Norris
On Fri, Jul 11, 2014 at 09:49:40AM +0200, Boris BREZILLON wrote: > These two patches add SDR NAND timings definition and ONFI timing mode to > NAND timings converter. > > This infrastructure will be used by NAND controller drivers to configure > their signal timings according to NAND chip capabili

Re: [PATCH 1/2] mxc_nand: fix err_limit and err_mask

2014-07-21 Thread Brian Norris
Hi Michael, Since I had a few comments for changes on patch 2, might as well comment here... On Thu, Jun 26, 2014 at 10:42:47PM +0200, Michael Grzeschik wrote: > This patch fixes the error detection limits for the used > eccsize of the 1, 4 and 8 bit eccmode. > > Signed-off-by: Michael Grzeschik

Re: [RFC][PATCH] irq: Rework IRQF_NO_SUSPENDED

2014-07-29 Thread Brian Norris
Hi Peter, On Fri, Jul 25, 2014 at 07:58:47AM +0200, Peter Zijlstra wrote: > On Fri, Jul 25, 2014 at 01:10:36AM +0200, Rafael J. Wysocki wrote: > > Yes, drivers using enable_irq_wake() will likely want IRQF_NO_SUSPEND to > > be set for their irqactions, but that should not imply "no suspend" for >

<    1   2   3   4   5   6   7   8   9   10   >