RE: [PATCH] misc: xilinx_sdfec: add compat_ptr_ioctl()

2020-10-30 Thread Dragan Cvetic
> Cc: Derek Kiernan ; Dragan Cvetic ; > a...@arndb.de; Michal Simek > ; linux-arm-ker...@lists.infradead.org; > linux-kernel@vger.kernel.org > Subject: [PATCH] misc: xilinx_sdfec: add compat_ptr_ioctl() > > Driver has a trivial helper function to convert > the pointer arg

RE: [PATCH 07/22] misc: xlink-pcie: lh: Add PCIe EPF driver for Local Host

2020-12-01 Thread Dragan Cvetic
.org; > markgr...@kernel.org; adam.r.gretzin...@intel.com; Srikanth Thokala > ; Derek Kiernan ; Dragan > Cvetic ; Arnd Bergmann > > Subject: Re: [PATCH 07/22] misc: xlink-pcie: lh: Add PCIe EPF driver for > Local Host > > On Tue, Dec 01, 2020 at 11:13:05AM +0100, Greg Kroah-Hartma

RE: [PATCH] misc: xilinx_sdfec: add compat_ptr_ioctl()

2020-11-09 Thread Dragan Cvetic
> -Original Message- > From: Harshal Chaudhari > Sent: Monday 26 October 2020 15:58 > To: gre...@linuxfoundation.org > Cc: Derek Kiernan ; Dragan Cvetic ; > a...@arndb.de; Michal Simek > ; linux-arm-ker...@lists.infradead.org; > linux-kernel@vger.kernel.org

RE: [PATCH] misc: xilinx-sdfec: remove check for ioctl cmd and argument.

2020-11-09 Thread Dragan Cvetic
> -Original Message- > From: Harshal Chaudhari > Sent: Sunday 1 November 2020 17:10 > To: gre...@linuxfoundation.org; Dragan Cvetic > Cc: Derek Kiernan ; a...@arndb.de; Michal Simek > ; linux-arm- > ker...@lists.infradead.org; linux-kernel@vger.kernel.org &g

RE: [PATCH 0/3] misc: xilinx-sdfec: convert get_user_pages() --> pin_user_pages()

2020-05-29 Thread Dragan Cvetic
Hi John, Thank you for the suggestion, please find my comment below: > -Original Message- > From: John Hubbard > Sent: Wednesday 27 May 2020 02:26 > To: LKML > Cc: Souptick Joarder ; John Hubbard > ; Derek Kiernan ; Dragan > Cvetic ; Arnd Bergmann ; Greg >

RE: [PATCH V4 04/12] misc: xilinx_sdfec: Add open, close and ioctl

2019-06-08 Thread Dragan Cvetic
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Friday 7 June 2019 16:58 > To: Dragan Cvetic > Cc: a...@arndb.de; Michal Simek ; > linux-arm-ker...@lists.infradead.org; robh...@kernel.org; > mark.rutl...@arm.com; devicet...@vger

[PATCH V5 01/11] dt-bindings: xilinx-sdfec: Add SDFEC binding

2019-06-08 Thread Dragan Cvetic
Add the Soft Decision Forward Error Correction (SDFEC) Engine bindings which is available for the Zynq UltraScale+ RFSoC FPGA's. Signed-off-by: Dragan Cvetic Signed-off-by: Derek Kiernan --- .../devicetree/bindings/misc/xlnx,sd-fec.txt | 58 ++ 1 file changed, 58

[PATCH V5 04/11] misc: xilinx_sdfec: Store driver config and state

2019-06-08 Thread Dragan Cvetic
Stores configuration based on parameters from the DT node and values from the SD-FEC core plus reads the default state from the SD-FEC core. To obtain values from the core register read, write capabilities have been added plus related register map details. Tested-by: Dragan Cvetic Signed-off

[PATCH V5 02/11] misc: xilinx-sdfec: add core driver

2019-06-08 Thread Dragan Cvetic
Implement a platform driver that matches with xlnx, sd-fec-1.1 device tree node and registers as a character device, including: - SD-FEC driver binds to sdfec DT node. - creates and initialise an initial driver dev structure. - add the driver in Linux build and Kconfig. Tested-by: Dragan Cvetic

[PATCH V5 10/11] Docs: misc: xilinx_sdfec: Add documentation

2019-06-08 Thread Dragan Cvetic
Add SD-FEC driver documentation. Signed-off-by: Derek Kiernan Signed-off-by: Dragan Cvetic --- Documentation/misc-devices/index.rst| 1 + Documentation/misc-devices/xilinx_sdfec.rst | 291 2 files changed, 292 insertions(+) create mode 100644

[PATCH V5 05/11] misc: xilinx_sdfec: Add ability to configure turbo

2019-06-08 Thread Dragan Cvetic
Add the capability to configure and retrieve turbo mode via the ioctls XSDFEC_SET_TURBO and XSDFEC_GET_TURBO. Add char device interface per DT node present and support file operations: - open(), - close(), - unlocked_ioctl(), - compat_ioctl(). Tested-by: Dragan Cvetic Signed-off-by: Derek

[PATCH V5 00/12] misc: xilinx sd-fec drive

2019-06-08 Thread Dragan Cvetic
. Tested-by: Santhosh Dyavanapally Tested by: Punnaiah Choudary Kalluri Tested-by: Dragan Cvetic Signed-off-by: Derek Kiernan Signed-off-by: Dragan Cvetic Changes V1 -> V2: - Removed unnecesary comenting from the commit messages. - Removed error log messages which can be triggered from u

[PATCH V5 11/11] MAINTAINERS: add maintainer for SD-FEC

2019-06-08 Thread Dragan Cvetic
support Add maintainer entry for Xilinx SD-FEC driver support. Signed-off-by: Derek Kiernan Signed-off-by: Dragan Cvetic --- MAINTAINERS | 11 +++ 1 file changed, 11 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index bfe48cb..2b754a8 100644 --- a/MAINTAINERS +++ b/MAINTAINERS

[PATCH V5 08/11] misc: xilinx_sdfec: Support poll file operation

2019-06-08 Thread Dragan Cvetic
type of errors: coding errors (ECC) and a data interface errors (TLAST). The errors are events which can trigger an IRQ if enabled. The driver can monitor and detect these errors through IRQ. Also the driver updates the statistical data. Tested-by: Dragan Cvetic Signed-off-by: Derek Kiernan

[PATCH V5 07/11] misc: xilinx_sdfec: Add ability to get/set config

2019-06-08 Thread Dragan Cvetic
. Tested-by: Dragan Cvetic Signed-off-by: Derek Kiernan Signed-off-by: Dragan Cvetic --- drivers/misc/xilinx_sdfec.c | 88 include/uapi/misc/xilinx_sdfec.h | 57 ++ 2 files changed, 145 insertions(+) diff --git a/drivers/misc

[PATCH V5 03/11] misc: xilinx_sdfec: Add CCF support

2019-06-08 Thread Dragan Cvetic
Add the support for Linux Clock Control Framework (CCF). Registers and enables clocks with the Clock Control Framework (CCF), to prevent shared clocks from been disabled. Tested-by: Dragan Cvetic Signed-off-by: Derek Kiernan Signed-off-by: Dragan Cvetic --- drivers/misc/xilinx_sdfec.c | 191

[PATCH V5 09/11] misc: xilinx_sdfec: Add stats & status ioctls

2019-06-08 Thread Dragan Cvetic
Tested-by: Santhosh Dyavanapally Tested by: Punnaiah Choudary Kalluri Tested-by: Derek Kiernan Tested-by: Dragan Cvetic Signed-off-by: Derek Kiernan Signed-off-by: Dragan Cvetic --- drivers/misc/xilinx_sdfec.c | 125 +++ include/uapi/misc/xilinx_sdfec.h

[PATCH V5 06/11] misc: xilinx_sdfec: Add ability to configure LDPC

2019-06-08 Thread Dragan Cvetic
Add the capability to configure LDPC mode via the ioctl XSDFEC_ADD_LDPC_CODE_PARAMS. Tested-by: Dragan Cvetic Signed-off-by: Derek Kiernan Signed-off-by: Dragan Cvetic --- drivers/misc/xilinx_sdfec.c | 324 +++ include/uapi/misc/xilinx_sdfec.h | 98

RE: [PATCH V5 02/11] misc: xilinx-sdfec: add core driver

2019-06-09 Thread Dragan Cvetic
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Sunday 9 June 2019 12:23 > To: Dragan Cvetic > Cc: a...@arndb.de; Michal Simek ; > linux-arm-ker...@lists.infradead.org; robh...@kernel.org; > mark.rutl...@arm.com; devicet...@vger

RE: [PATCH V5 04/11] misc: xilinx_sdfec: Store driver config and state

2019-06-09 Thread Dragan Cvetic
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Sunday 9 June 2019 12:28 > To: Dragan Cvetic > Cc: a...@arndb.de; Michal Simek ; > linux-arm-ker...@lists.infradead.org; robh...@kernel.org; > mark.rutl...@arm.com; devicet...@vger

[PATCH V6 00/11] misc: xilinx sd-fec drive

2019-06-10 Thread Dragan Cvetic
. Tested-by: Santhosh Dyavanapally Tested by: Punnaiah Choudary Kalluri Tested-by: Dragan Cvetic Signed-off-by: Derek Kiernan Signed-off-by: Dragan Cvetic Changes V1 -> V2: - Removed unnecesary comenting from the commit messages. - Removed error log messages which can be triggered from u

[PATCH V6 11/11] MAINTAINERS: add maintainer for SD-FEC

2019-06-10 Thread Dragan Cvetic
support Add maintainer entry for Xilinx SD-FEC driver support. Signed-off-by: Derek Kiernan Signed-off-by: Dragan Cvetic --- MAINTAINERS | 11 +++ 1 file changed, 11 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index bfe48cb..2b754a8 100644 --- a/MAINTAINERS +++ b/MAINTAINERS

[PATCH V6 03/11] misc: xilinx_sdfec: Add CCF support

2019-06-10 Thread Dragan Cvetic
Add the support for Linux Clock Control Framework (CCF). Registers and enables clocks with the Clock Control Framework (CCF), to prevent shared clocks from been disabled. Tested-by: Dragan Cvetic Signed-off-by: Derek Kiernan Signed-off-by: Dragan Cvetic --- drivers/misc/xilinx_sdfec.c | 193

[PATCH V6 08/11] misc: xilinx_sdfec: Support poll file operation

2019-06-10 Thread Dragan Cvetic
type of errors: coding errors (ECC) and a data interface errors (TLAST). The errors are events which can trigger an IRQ if enabled. The driver can monitor and detect these errors through IRQ. Also the driver updates the statistical data. Tested-by: Dragan Cvetic Signed-off-by: Derek Kiernan

[PATCH V6 04/11] misc: xilinx_sdfec: Store driver config and state

2019-06-10 Thread Dragan Cvetic
Stores configuration based on parameters from the DT node and values from the SD-FEC core plus reads the default state from the SD-FEC core. To obtain values from the core register read, write capabilities have been added plus related register map details. Tested-by: Dragan Cvetic Signed-off

[PATCH V6 05/11] misc: xilinx_sdfec: Add ability to configure turbo

2019-06-10 Thread Dragan Cvetic
Add the capability to configure and retrieve turbo mode via the ioctls XSDFEC_SET_TURBO and XSDFEC_GET_TURBO. Add char device interface per DT node present and support file operations: - open(), - close(), - unlocked_ioctl(), - compat_ioctl(). Tested-by: Dragan Cvetic Signed-off-by: Derek

[PATCH V6 09/11] misc: xilinx_sdfec: Add stats & status ioctls

2019-06-10 Thread Dragan Cvetic
Tested-by: Santhosh Dyavanapally Tested by: Punnaiah Choudary Kalluri Tested-by: Derek Kiernan Tested-by: Dragan Cvetic Signed-off-by: Derek Kiernan Signed-off-by: Dragan Cvetic --- drivers/misc/xilinx_sdfec.c | 125 +++ include/uapi/misc/xilinx_sdfec.h

[PATCH V6 10/11] Docs: misc: xilinx_sdfec: Add documentation

2019-06-10 Thread Dragan Cvetic
Add SD-FEC driver documentation. Signed-off-by: Derek Kiernan Signed-off-by: Dragan Cvetic --- Documentation/misc-devices/index.rst| 1 + Documentation/misc-devices/xilinx_sdfec.rst | 291 2 files changed, 292 insertions(+) create mode 100644

[PATCH V6 01/11] dt-bindings: xilinx-sdfec: Add SDFEC binding

2019-06-10 Thread Dragan Cvetic
Add the Soft Decision Forward Error Correction (SDFEC) Engine bindings which is available for the Zynq UltraScale+ RFSoC FPGA's. Signed-off-by: Dragan Cvetic Signed-off-by: Derek Kiernan --- .../devicetree/bindings/misc/xlnx,sd-fec.txt | 58 ++ 1 file changed, 58

[PATCH V6 02/11] misc: xilinx-sdfec: add core driver

2019-06-10 Thread Dragan Cvetic
Implement a platform driver that matches with xlnx, sd-fec-1.1 device tree node and registers as a character device, including: - SD-FEC driver binds to sdfec DT node. - creates and initialise an initial driver dev structure. - add the driver in Linux build and Kconfig. Tested-by: Dragan Cvetic

[PATCH V6 07/11] misc: xilinx_sdfec: Add ability to get/set config

2019-06-10 Thread Dragan Cvetic
. Tested-by: Dragan Cvetic Signed-off-by: Derek Kiernan Signed-off-by: Dragan Cvetic --- drivers/misc/xilinx_sdfec.c | 88 include/uapi/misc/xilinx_sdfec.h | 57 ++ 2 files changed, 145 insertions(+) diff --git a/drivers/misc

[PATCH V6 06/11] misc: xilinx_sdfec: Add ability to configure LDPC

2019-06-10 Thread Dragan Cvetic
Add the capability to configure LDPC mode via the ioctl XSDFEC_ADD_LDPC_CODE_PARAMS. Tested-by: Dragan Cvetic Signed-off-by: Derek Kiernan Signed-off-by: Dragan Cvetic --- drivers/misc/xilinx_sdfec.c | 324 +++ include/uapi/misc/xilinx_sdfec.h | 98

RE: [PATCH V7 00/11] misc: xilinx sd-fec drive

2019-07-31 Thread Dragan Cvetic
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Wednesday 31 July 2019 13:49 > To: Dragan Cvetic > Cc: a...@arndb.de; Michal Simek ; > linux-arm-ker...@lists.infradead.org; robh...@kernel.org; > mark.rutl...@arm.com; devic

RE: [PATCH][next] misc: xilinx_sdfec: fix spelling mistake: "Schdule" -> "Schedule"

2019-08-22 Thread Dragan Cvetic
Hi Colin, > -Original Message- > From: Colin King [mailto:colin.k...@canonical.com] > Sent: Monday 19 August 2019 10:42 > To: Derek Kiernan ; Dragan Cvetic ; > Arnd Bergmann ; Greg Kroah- > Hartman ; Michal Simek ; > linux-arm-ker...@lists.infradead.o

RE: [PATCH 1/4] misc: xilinx_sdfec: Fix a couple small information leaks

2019-08-22 Thread Dragan Cvetic
Hi Dan, > -Original Message- > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > Sent: Wednesday 21 August 2019 08:06 > To: Derek Kiernan ; Dragan Cvetic > Cc: Arnd Bergmann ; Greg Kroah-Hartman > ; Michal Simek ; > linux-arm-ker...@lists.infrad

RE: [PATCH 2/4] misc: xilinx_sdfec: Return -EFAULT if copy_from_user() fails

2019-08-22 Thread Dragan Cvetic
Hi Dan, > -Original Message- > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > Sent: Wednesday 21 August 2019 08:07 > To: Derek Kiernan ; Dragan Cvetic > Cc: Arnd Bergmann ; Greg Kroah-Hartman > ; Michal Simek ; > linux-arm-ker...@lists.infrad

RE: [PATCH 4/4] misc: xilinx_sdfec: Prevent integer overflow in xsdfec_table_write()

2019-08-22 Thread Dragan Cvetic
Hi Dan, > -Original Message- > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > Sent: Wednesday 21 August 2019 08:11 > To: Derek Kiernan ; Dragan Cvetic > Cc: Arnd Bergmann ; Greg Kroah-Hartman > ; Michal Simek ; > linux-arm-ker...@lists.infrad

RE: [PATCH 3/4] misc: xilinx_sdfec: Prevent a divide by zero in xsdfec_reg0_write()

2019-08-23 Thread Dragan Cvetic
Hi Dan, > -Original Message- > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > Sent: Wednesday 21 August 2019 08:10 > To: Derek Kiernan ; Dragan Cvetic > Cc: Arnd Bergmann ; Greg Kroah-Hartman > ; Michal Simek ; > linux-arm-ker...@lists.infrad

[PATCH V4 06/12] misc: xilinx_sdfec: Add ability to configure turbo

2019-05-25 Thread Dragan Cvetic
mode Add the capability to configure and retrieve turbo mode via the ioctls XSDFEC_SET_TURBO and XSDFEC_GET_TURBO. Tested-by: Dragan Cvetic Signed-off-by: Derek Kiernan Signed-off-by: Dragan Cvetic --- drivers/misc/xilinx_sdfec.c | 61 ++ include/uapi

[PATCH V4 00/12] misc: xilinx sd-fec drive

2019-05-25 Thread Dragan Cvetic
. Tested-by: Santhosh Dyavanapally Tested by: Punnaiah Choudary Kalluri Tested-by: Dragan Cvetic Signed-off-by: Derek Kiernan Signed-off-by: Dragan Cvetic Changes V1 -> V2: - Removed unnecesary comenting from the commit messages. - Removed error log messages which can be triggered from u

[PATCH V4 09/12] misc: xilinx_sdfec: Support poll file operation

2019-05-25 Thread Dragan Cvetic
type of errors: coding errors (ECC) and a data interface errors (TLAST). The errors are events which can trigger an IRQ if enabled. The driver can monitor and detect these errors through IRQ. Also the driver updates the statistical data. Tested-by: Dragan Cvetic Signed-off-by: Derek Kiernan

[PATCH V4 12/12] MAINTAINERS: add maintainer for SD-FEC

2019-05-25 Thread Dragan Cvetic
support Add maintainer entry for Xilinx SD-FEC driver support. Signed-off-by: Derek Kiernan Signed-off-by: Dragan Cvetic --- MAINTAINERS | 12 1 file changed, 12 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 5cfbea4..6e558ae 100644 --- a/MAINTAINERS +++ b

[PATCH V4 07/12] misc: xilinx_sdfec: Add ability to configure LDPC

2019-05-25 Thread Dragan Cvetic
Add the capability to configure LDPC mode via the ioctl XSDFEC_ADD_LDPC_CODE_PARAMS. Tested-by: Dragan Cvetic Signed-off-by: Derek Kiernan Signed-off-by: Dragan Cvetic --- drivers/misc/xilinx_sdfec.c | 332 +++ include/uapi/misc/xilinx_sdfec.h | 98

[PATCH V4 01/12] dt-bindings: xilinx-sdfec: Add SDFEC binding

2019-05-25 Thread Dragan Cvetic
Add the Soft Decision Forward Error Correction (SDFEC) Engine bindings which is available for the Zynq UltraScale+ RFSoC FPGA's. Signed-off-by: Dragan Cvetic Signed-off-by: Derek Kiernan --- .../devicetree/bindings/misc/xlnx,sd-fec.txt | 58 ++ 1 file changed, 58

[PATCH V4 05/12] misc: xilinx_sdfec: Store driver config and state

2019-05-25 Thread Dragan Cvetic
Stores configuration based on parameters from the DT node and values from the SD-FEC core plus reads the default state from the SD-FEC core. To obtain values from the core register read, write capabilities have been added plus related register map details. Tested-by: Dragan Cvetic Signed-off

[PATCH V4 02/12] misc: xilinx-sdfec: add core driver

2019-05-25 Thread Dragan Cvetic
Implements an platform driver that matches with xlnx, sd-fec-1.1 device tree node and registers as a character device, including: - SD-FEC driver binds to sdfec DT node. - creates and initialise an initial driver dev structure. - add the driver in Linux build and Kconfig. Tested-by: Dragan Cvetic

[PATCH V4 10/12] misc: xilinx_sdfec: Add stats & status ioctls

2019-05-25 Thread Dragan Cvetic
Tested-by: Santhosh Dyavanapally Tested by: Punnaiah Choudary Kalluri Tested-by: Derek Kiernan Tested-by: Dragan Cvetic Signed-off-by: Derek Kiernan Signed-off-by: Dragan Cvetic --- drivers/misc/xilinx_sdfec.c | 121 +++ include/uapi/misc/xilinx_sdfec.h

[PATCH V4 04/12] misc: xilinx_sdfec: Add open, close and ioctl

2019-05-25 Thread Dragan Cvetic
Add char device interface per DT node present and support file operations: - open(), - close(), - unlocked_ioctl(), - compat_ioctl(). Tested-by: Dragan Cvetic Signed-off-by: Derek Kiernan Signed-off-by: Dragan Cvetic --- drivers/misc/xilinx_sdfec.c | 57

[PATCH V4 08/12] misc: xilinx_sdfec: Add ability to get/set config

2019-05-25 Thread Dragan Cvetic
. Tested-by: Dragan Cvetic Signed-off-by: Derek Kiernan Signed-off-by: Dragan Cvetic --- drivers/misc/xilinx_sdfec.c | 99 include/uapi/misc/xilinx_sdfec.h | 57 +++ 2 files changed, 156 insertions(+) diff --git a/drivers/misc

[PATCH V4 03/12] misc: xilinx_sdfec: Add CCF support

2019-05-25 Thread Dragan Cvetic
Add the support for Linux Clock Control Framework (CCF). Registers and enables clocks with the Clock Control Framework (CCF), to prevent shared clocks from been disabled. Tested-by: Dragan Cvetic Signed-off-by: Derek Kiernan Signed-off-by: Dragan Cvetic --- drivers/misc/xilinx_sdfec.c | 185

[PATCH V4 11/12] Docs: misc: xilinx_sdfec: Add documentation

2019-05-25 Thread Dragan Cvetic
Add SD-FEC driver documentation. Signed-off-by: Derek Kiernan Signed-off-by: Dragan Cvetic --- Documentation/misc-devices/index.rst| 1 + Documentation/misc-devices/xilinx_sdfec.rst | 291 2 files changed, 292 insertions(+) create mode 100644

RE: [PATCH V7 04/11] misc: xilinx_sdfec: Store driver config and state

2019-06-21 Thread Dragan Cvetic
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Friday 21 June 2019 15:15 > To: Dragan Cvetic > Cc: a...@arndb.de; Michal Simek ; > linux-arm-ker...@lists.infradead.org; robh...@kernel.org; > mark.rutl...@arm.com; devicet...@vger

RE: [PATCH V7 00/11] misc: xilinx sd-fec drive

2019-06-21 Thread Dragan Cvetic
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Friday 21 June 2019 15:16 > To: Dragan Cvetic > Cc: a...@arndb.de; Michal Simek ; > linux-arm-ker...@lists.infradead.org; robh...@kernel.org; > mark.rutl...@arm.com; devicet...@vger

RE: [PATCH V7 00/11] misc: xilinx sd-fec drive

2019-06-22 Thread Dragan Cvetic
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Saturday 22 June 2019 07:02 > To: Dragan Cvetic > Cc: a...@arndb.de; Michal Simek ; > linux-arm-ker...@lists.infradead.org; robh...@kernel.org; > mark.rutl...@arm.com; devicet...@vger

RE: [PATCH V7 00/11] misc: xilinx sd-fec drive

2019-07-03 Thread Dragan Cvetic
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Saturday 22 June 2019 07:02 > To: Dragan Cvetic > Cc: a...@arndb.de; Michal Simek ; > linux-arm-ker...@lists.infradead.org; robh...@kernel.org; > mark.rutl...@arm.com; devicet...@vger

RE: [PATCH V4 02/12] misc: xilinx-sdfec: add core driver

2019-06-06 Thread Dragan Cvetic
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Thursday 6 June 2019 14:25 > To: Dragan Cvetic > Cc: a...@arndb.de; Michal Simek ; > linux-arm-ker...@lists.infradead.org; robh...@kernel.org; > mark.rutl...@arm.com; devicet...@vger

RE: [PATCH V4 04/12] misc: xilinx_sdfec: Add open, close and ioctl

2019-06-06 Thread Dragan Cvetic
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Thursday 6 June 2019 14:26 > To: Dragan Cvetic > Cc: a...@arndb.de; Michal Simek ; > linux-arm-ker...@lists.infradead.org; robh...@kernel.org; > mark.rutl...@arm.com; devicet...@vger

RE: [PATCH V4 04/12] misc: xilinx_sdfec: Add open, close and ioctl

2019-06-06 Thread Dragan Cvetic
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Thursday 6 June 2019 14:29 > To: Dragan Cvetic > Cc: a...@arndb.de; Michal Simek ; > linux-arm-ker...@lists.infradead.org; robh...@kernel.org; > mark.rutl...@arm.com; devicet...@vger

RE: [PATCH V4 10/12] misc: xilinx_sdfec: Add stats & status ioctls

2019-06-06 Thread Dragan Cvetic
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Thursday 6 June 2019 15:12 > To: Dragan Cvetic > Cc: a...@arndb.de; Michal Simek ; > linux-arm-ker...@lists.infradead.org; robh...@kernel.org; > mark.rutl...@arm.com; devicet...@vger

RE: [PATCH V4 04/12] misc: xilinx_sdfec: Add open, close and ioctl

2019-06-07 Thread Dragan Cvetic
> On Sat, May 25, 2019 at 12:37:17PM +0100, Dragan Cvetic wrote: > > +static int xsdfec_dev_open(struct inode *iptr, struct file *fptr) > > +{ > > + return 0; > > +} > > + > > +static int xsdfec_dev_release(struct inode *iptr, struct file *fptr) > >

[PATCH V8 7/8] Docs: misc: xilinx_sdfec: Add documentation

2019-07-06 Thread Dragan Cvetic
Add SD-FEC driver documentation. Signed-off-by: Derek Kiernan Signed-off-by: Dragan Cvetic --- Documentation/misc-devices/index.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/misc-devices/index.rst b/Documentation/misc-devices/index.rst index a57f92d..f11c5da 100644

[PATCH V8 0/8] misc: xilinx sd-fec drive

2019-07-06 Thread Dragan Cvetic
. Tested-by: Santhosh Dyavanapally Tested by: Punnaiah Choudary Kalluri Tested-by: Dragan Cvetic Signed-off-by: Derek Kiernan Signed-off-by: Dragan Cvetic Changes V1 -> V2: - Removed unnecesary comenting from the commit messages. - Removed error log messages which can be triggered from u

[PATCH V8 8/8] MAINTAINERS: add maintainer for SD-FEC

2019-07-06 Thread Dragan Cvetic
support Add maintainer entry for Xilinx SD-FEC driver support. Signed-off-by: Derek Kiernan Signed-off-by: Dragan Cvetic --- MAINTAINERS | 11 +++ 1 file changed, 11 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 1fc7baf..6a9db56 100644 --- a/MAINTAINERS +++ b/MAINTAINERS

[PATCH V8 1/8] misc: xilinx_sdfec: Store driver config and state

2019-07-06 Thread Dragan Cvetic
Stores configuration based on parameters from the DT node and values from the SD-FEC core plus reads the default state from the SD-FEC core. To obtain values from the core register read, write capabilities have been added plus related register map details. Tested-by: Dragan Cvetic Signed-off

[PATCH V8 6/8] misc: xilinx_sdfec: Add stats & status ioctls

2019-07-06 Thread Dragan Cvetic
Tested-by: Santhosh Dyavanapally Tested by: Punnaiah Choudary Kalluri Tested-by: Derek Kiernan Tested-by: Dragan Cvetic Signed-off-by: Derek Kiernan Signed-off-by: Dragan Cvetic --- drivers/misc/xilinx_sdfec.c | 125 +++ include/uapi/misc/xilinx_sdfec.h

[PATCH V8 5/8] misc: xilinx_sdfec: Support poll file operation

2019-07-06 Thread Dragan Cvetic
type of errors: coding errors (ECC) and a data interface errors (TLAST). The errors are events which can trigger an IRQ if enabled. The driver can monitor and detect these errors through IRQ. Also the driver updates the statistical data. Tested-by: Dragan Cvetic Signed-off-by: Derek Kiernan

[PATCH V8 3/8] misc: xilinx_sdfec: Add ability to configure LDPC

2019-07-06 Thread Dragan Cvetic
Add the capability to configure LDPC mode via the ioctl XSDFEC_ADD_LDPC_CODE_PARAMS. Tested-by: Dragan Cvetic Signed-off-by: Derek Kiernan Signed-off-by: Dragan Cvetic --- drivers/misc/xilinx_sdfec.c | 324 +++ include/uapi/misc/xilinx_sdfec.h | 98

[PATCH V8 2/8] misc: xilinx_sdfec: Add ability to configure turbo

2019-07-06 Thread Dragan Cvetic
Add the capability to configure and retrieve turbo mode via the ioctls XSDFEC_SET_TURBO and XSDFEC_GET_TURBO. Add char device interface per DT node present and support file operations: - open(), - close(), - unlocked_ioctl(), - compat_ioctl(). Tested-by: Dragan Cvetic Signed-off-by: Derek

[PATCH V8 4/8] misc: xilinx_sdfec: Add ability to get/set config

2019-07-06 Thread Dragan Cvetic
. Tested-by: Dragan Cvetic Signed-off-by: Derek Kiernan Signed-off-by: Dragan Cvetic --- drivers/misc/xilinx_sdfec.c | 88 include/uapi/misc/xilinx_sdfec.h | 57 ++ 2 files changed, 145 insertions(+) diff --git a/drivers/misc

[PATCH V7 09/11] misc: xilinx_sdfec: Add stats & status ioctls

2019-06-11 Thread Dragan Cvetic
Tested-by: Santhosh Dyavanapally Tested by: Punnaiah Choudary Kalluri Tested-by: Derek Kiernan Tested-by: Dragan Cvetic Signed-off-by: Derek Kiernan Signed-off-by: Dragan Cvetic --- drivers/misc/xilinx_sdfec.c | 125 +++ include/uapi/misc/xilinx_sdfec.h

[PATCH V7 07/11] misc: xilinx_sdfec: Add ability to get/set config

2019-06-11 Thread Dragan Cvetic
. Tested-by: Dragan Cvetic Signed-off-by: Derek Kiernan Signed-off-by: Dragan Cvetic --- drivers/misc/xilinx_sdfec.c | 88 include/uapi/misc/xilinx_sdfec.h | 57 ++ 2 files changed, 145 insertions(+) diff --git a/drivers/misc

[PATCH V7 04/11] misc: xilinx_sdfec: Store driver config and state

2019-06-11 Thread Dragan Cvetic
Stores configuration based on parameters from the DT node and values from the SD-FEC core plus reads the default state from the SD-FEC core. To obtain values from the core register read, write capabilities have been added plus related register map details. Tested-by: Dragan Cvetic Signed-off

[PATCH V7 06/11] misc: xilinx_sdfec: Add ability to configure LDPC

2019-06-11 Thread Dragan Cvetic
Add the capability to configure LDPC mode via the ioctl XSDFEC_ADD_LDPC_CODE_PARAMS. Tested-by: Dragan Cvetic Signed-off-by: Derek Kiernan Signed-off-by: Dragan Cvetic --- drivers/misc/xilinx_sdfec.c | 324 +++ include/uapi/misc/xilinx_sdfec.h | 98

[PATCH V7 01/11] dt-bindings: xilinx-sdfec: Add SDFEC binding

2019-06-11 Thread Dragan Cvetic
Add the Soft Decision Forward Error Correction (SDFEC) Engine bindings which is available for the Zynq UltraScale+ RFSoC FPGA's. Signed-off-by: Dragan Cvetic Signed-off-by: Derek Kiernan --- .../devicetree/bindings/misc/xlnx,sd-fec.txt | 58 ++ 1 file changed, 58

[PATCH V7 03/11] misc: xilinx_sdfec: Add CCF support

2019-06-11 Thread Dragan Cvetic
Add the support for Linux Clock Control Framework (CCF). Registers and enables clocks with the Clock Control Framework (CCF), to prevent shared clocks from been disabled. Tested-by: Dragan Cvetic Signed-off-by: Derek Kiernan Signed-off-by: Dragan Cvetic --- drivers/misc/xilinx_sdfec.c | 193

[PATCH V7 02/11] misc: xilinx-sdfec: add core driver

2019-06-11 Thread Dragan Cvetic
Implement a platform driver that matches with xlnx, sd-fec-1.1 device tree node and registers as a character device, including: - SD-FEC driver binds to sdfec DT node. - creates and initialise an initial driver dev structure. - add the driver in Linux build and Kconfig. Tested-by: Dragan Cvetic

[PATCH V7 11/11] MAINTAINERS: add maintainer for SD-FEC

2019-06-11 Thread Dragan Cvetic
support Add maintainer entry for Xilinx SD-FEC driver support. Signed-off-by: Derek Kiernan Signed-off-by: Dragan Cvetic --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index bfe48cb..9fde3e8 100644 --- a/MAINTAINERS +++ b/MAINTAINERS

[PATCH V7 08/11] misc: xilinx_sdfec: Support poll file operation

2019-06-11 Thread Dragan Cvetic
type of errors: coding errors (ECC) and a data interface errors (TLAST). The errors are events which can trigger an IRQ if enabled. The driver can monitor and detect these errors through IRQ. Also the driver updates the statistical data. Tested-by: Dragan Cvetic Signed-off-by: Derek Kiernan

[PATCH V7 05/11] misc: xilinx_sdfec: Add ability to configure turbo

2019-06-11 Thread Dragan Cvetic
Add the capability to configure and retrieve turbo mode via the ioctls XSDFEC_SET_TURBO and XSDFEC_GET_TURBO. Add char device interface per DT node present and support file operations: - open(), - close(), - unlocked_ioctl(), - compat_ioctl(). Tested-by: Dragan Cvetic Signed-off-by: Derek

[PATCH V7 10/11] Docs: misc: xilinx_sdfec: Add documentation

2019-06-11 Thread Dragan Cvetic
Add SD-FEC driver documentation. Signed-off-by: Derek Kiernan Signed-off-by: Dragan Cvetic --- Documentation/misc-devices/index.rst| 1 + Documentation/misc-devices/xilinx_sdfec.rst | 291 2 files changed, 292 insertions(+) create mode 100644

[PATCH V7 00/11] misc: xilinx sd-fec drive

2019-06-11 Thread Dragan Cvetic
. Tested-by: Santhosh Dyavanapally Tested by: Punnaiah Choudary Kalluri Tested-by: Dragan Cvetic Signed-off-by: Derek Kiernan Signed-off-by: Dragan Cvetic Changes V1 -> V2: - Removed unnecesary comenting from the commit messages. - Removed error log messages which can be triggered from u

RE: [PATCH] misc: xilinx-sdfec: convert to module_platform_driver()

2020-05-11 Thread Dragan Cvetic
> -Original Message- > From: Harshal Chaudhari > Sent: Sunday 10 May 2020 17:43 > To: gre...@linuxfoundation.org > Cc: Derek Kiernan ; Dragan Cvetic ; > a...@arndb.de; Michal Simek > ; linux-arm-ker...@lists.infradead.org; > linux-kernel@vger.kernel.org;

[PATCH V9 4/8] misc: xilinx_sdfec: Add ability to get/set config

2019-07-27 Thread Dragan Cvetic
. Tested-by: Dragan Cvetic Signed-off-by: Derek Kiernan Signed-off-by: Dragan Cvetic --- drivers/misc/xilinx_sdfec.c | 88 include/uapi/misc/xilinx_sdfec.h | 57 ++ 2 files changed, 145 insertions(+) diff --git a/drivers/misc

[PATCH V9 6/8] misc: xilinx_sdfec: Add stats & status ioctls

2019-07-27 Thread Dragan Cvetic
Tested-by: Santhosh Dyavanapally Tested by: Punnaiah Choudary Kalluri Tested-by: Derek Kiernan Tested-by: Dragan Cvetic Signed-off-by: Derek Kiernan Signed-off-by: Dragan Cvetic --- drivers/misc/xilinx_sdfec.c | 125 +++ include/uapi/misc/xilinx_sdfec.h

[PATCH V9 7/8] Docs: misc: xilinx_sdfec: Add documentation

2019-07-27 Thread Dragan Cvetic
Add SD-FEC driver documentation. Signed-off-by: Derek Kiernan Signed-off-by: Dragan Cvetic --- Documentation/misc-devices/index.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/misc-devices/index.rst b/Documentation/misc-devices/index.rst index a57f92d..f11c5da 100644

[PATCH V9 2/8] misc: xilinx_sdfec: Add ability to configure turbo

2019-07-27 Thread Dragan Cvetic
Add the capability to configure and retrieve turbo mode via the ioctls XSDFEC_SET_TURBO and XSDFEC_GET_TURBO. Add char device interface per DT node present and support file operations: - open(), - close(), - unlocked_ioctl(), - compat_ioctl(). Tested-by: Dragan Cvetic Signed-off-by: Derek

[PATCH V9 5/8] misc: xilinx_sdfec: Support poll file operation

2019-07-27 Thread Dragan Cvetic
type of errors: coding errors (ECC) and a data interface errors (TLAST). The errors are events which can trigger an IRQ if enabled. The driver can monitor and detect these errors through IRQ. Also the driver updates the statistical data. Tested-by: Dragan Cvetic Signed-off-by: Derek Kiernan

[PATCH V9 3/8] misc: xilinx_sdfec: Add ability to configure LDPC

2019-07-27 Thread Dragan Cvetic
Add the capability to configure LDPC mode via the ioctl XSDFEC_ADD_LDPC_CODE_PARAMS. Tested-by: Dragan Cvetic Signed-off-by: Derek Kiernan Signed-off-by: Dragan Cvetic --- drivers/misc/xilinx_sdfec.c | 324 +++ include/uapi/misc/xilinx_sdfec.h | 98

[PATCH V9 8/8] MAINTAINERS: add maintainer for SD-FEC

2019-07-27 Thread Dragan Cvetic
support Add maintainer entry for Xilinx SD-FEC driver support. Signed-off-by: Derek Kiernan Signed-off-by: Dragan Cvetic --- MAINTAINERS | 11 +++ 1 file changed, 11 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index c8c506b..2ae7376 100644 --- a/MAINTAINERS +++ b/MAINTAINERS

[PATCH V9 1/8] misc: xilinx_sdfec: Store driver config and state

2019-07-27 Thread Dragan Cvetic
Stores configuration based on parameters from the DT node and values from the SD-FEC core plus reads the default state from the SD-FEC core. To obtain values from the core register read, write capabilities have been added plus related register map details. Tested-by: Dragan Cvetic Signed-off

[PATCH V9 0/8] misc: xilinx sd-fec drive

2019-07-27 Thread Dragan Cvetic
. Tested-by: Santhosh Dyavanapally Tested by: Punnaiah Choudary Kalluri Tested-by: Dragan Cvetic Signed-off-by: Derek Kiernan Signed-off-by: Dragan Cvetic Changes V1 -> V2: - Removed unnecesary comenting from the commit messages. - Removed error log messages which can be triggered from u

RE: [PATCH AUTOSEL 5.4 199/266] misc: xilinx-sdfec: improve get_user_pages_fast() error handling

2020-06-19 Thread Dragan Cvetic
Hi Sasha, Thank you for the patch. > -Original Message- > From: Sasha Levin > Sent: Thursday 18 June 2020 02:15 > To: linux-kernel@vger.kernel.org; sta...@vger.kernel.org > Cc: John Hubbard ; Derek Kiernan ; > Dragan Cvetic ; Arnd > Bergmann ; Greg Kroah-Hart

RE: [PATCH V2 02/12] misc: xilinx-sdfec: add core driver

2019-04-26 Thread Dragan Cvetic
Hi Greg, Please find my inline comments below. > -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Thursday 25 April 2019 21:26 > To: Dragan Cvetic > Cc: a...@arndb.de; Michal Simek ; > linux-arm-ker...@lists.infradead.org; linux-kern

RE: [PATCH V2 01/12] dt-bindings: xilinx-sdfec: Add SDFEC binding

2019-04-26 Thread Dragan Cvetic
Hi Greg, > -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Thursday 25 April 2019 21:24 > To: Dragan Cvetic > Cc: a...@arndb.de; Michal Simek ; > linux-arm-ker...@lists.infradead.org; linux-kernel@vger.kernel.org; Derek > Kiernan

RE: [PATCH V3 02/12] misc: xilinx-sdfec: add core driver

2019-05-06 Thread Dragan Cvetic
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Saturday 4 May 2019 08:55 > To: Dragan Cvetic > Cc: a...@arndb.de; Michal Simek ; > linux-arm-ker...@lists.infradead.org; robh...@kernel.org; > mark.rutl...@arm.com; devicet...@vger

RE: [PATCH V3 02/12] misc: xilinx-sdfec: add core driver

2019-05-07 Thread Dragan Cvetic
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Monday 6 May 2019 13:34 > To: Dragan Cvetic > Cc: a...@arndb.de; Michal Simek ; > linux-arm-ker...@lists.infradead.org; robh...@kernel.org; > mark.rutl...@arm.com; devicet...@vger

RE: [PATCH V3 02/12] misc: xilinx-sdfec: add core driver

2019-05-07 Thread Dragan Cvetic
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Tuesday 7 May 2019 10:40 > To: Dragan Cvetic > Cc: a...@arndb.de; Michal Simek ; > linux-arm-ker...@lists.infradead.org; robh...@kernel.org; > mark.rutl...@arm.com; devicet...@vger

RE: [PATCH V3 02/12] misc: xilinx-sdfec: add core driver

2019-05-07 Thread Dragan Cvetic
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Tuesday 7 May 2019 13:21 > To: Dragan Cvetic > Cc: a...@arndb.de; Michal Simek ; > linux-arm-ker...@lists.infradead.org; robh...@kernel.org; > mark.rutl...@arm.com; devicet...@vger

RE: [PATCH V3 01/12] dt-bindings: xilinx-sdfec: Add SDFEC binding

2019-05-02 Thread Dragan Cvetic
Hi Rob, Please find my inline comments below Thank you Dragan > -Original Message- > From: Rob Herring [mailto:r...@kernel.org] > Sent: Wednesday 1 May 2019 20:48 > To: Dragan Cvetic > Cc: a...@arndb.de; gre...@linuxfoundation.org; Michal Simek > ; linux-arm-ker...@l

RE: [PATCH V3 02/12] misc: xilinx-sdfec: add core driver

2019-05-03 Thread Dragan Cvetic
Hi Greg, Please find my inline comments below, Regards Dragan > -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Thursday 2 May 2019 18:20 > To: Dragan Cvetic > Cc: a...@arndb.de; Michal Simek ; > linux-arm-ker...@lists.infradead.org;

  1   2   >