[PATCH 20/35] staging: comedi: cb_pcimdda: store the pci_dev in the comedi_device

2012-08-16 Thread H Hartley Sweeten
Use the hw_dev pointer in the comed_device struct to hold the pci_dev instead of carrying it in the private data. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers

[PATCH 21/35] staging: comedi: cb_pcimdda: cleanup the 8255 subdevice init

2012-08-16 Thread H Hartley Sweeten
. For aesthetic reasons, rename the local variable 'err' to 'ret'. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/cb_pcimdda.c | 31 + 1 file

[PATCH 22/35] staging: comedi: cb_pcimdda: remove the DIO_METHODS

2012-08-16 Thread H Hartley Sweeten
The digital i/o on this card is handled by an 8255 compatible device. There are not other options. Remove the DIO_METHODS enum as well as the dio_method variable in the boardinfo and the code dealing with it. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo

[PATCH 23/35] staging: comedi: cb_pcimdda: remove dio_chans from the private data

2012-08-16 Thread H Hartley Sweeten
The cards supported by this driver always have 8255 compatible device. Remove the dio_chans variable from the private data and always initialize the 8255 subdevice. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre

[PATCH 24/35] staging: comedi: cb_pcimdda: define the register map

2012-08-16 Thread H Hartley Sweeten
Add defines for the register map of the card. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/cb_pcimdda.c | 6 ++ 1 file changed, 6 insertions(+) diff --git

[PATCH 25/35] staging: comedi: cb_pcimdda: remove dio_offset from the boardinfo

2012-08-16 Thread H Hartley Sweeten
The 8255 device is located at a fixed offset from the base address of the card. There is not need to carry this offset in the boardinfo. Remove it. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org

[PATCH 26/35] staging: comedi: cb_pcimdda: remove regs_badrindex and reg_sz from boardinfo

2012-08-16 Thread H Hartley Sweeten
The base address of the card is always found in pci resource 3. There is no need to carry this information in the boardinfo. The reg_sz is not used in the driver. Remove them. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre

[PATCH 27/35] staging: comedi: cb_pcimdda: remove ao_chans and ao_bits from boardinfo

2012-08-16 Thread H Hartley Sweeten
This board always has 6, 16-bit analog outputs. There is no need to carry this information in the boardinfo. Remove it. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi

[PATCH 28/35] staging: comedi: cb_pcimdda: remove boardinfo

2012-08-16 Thread H Hartley Sweeten
The boardinfo struct and associated code is no longer needed by this driver. Remove it. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/cb_pcimdda.c | 38

[PATCH 29/35] staging: comedi: cb_pcimdda: remove attached_to_8255 from private data

2012-08-16 Thread H Hartley Sweeten
. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/cb_pcimdda.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/staging/comedi

[PATCH 30/35] staging: comedi: cb_pcimdda: fix bug in call to subdev_8255_cleanup

2012-08-16 Thread H Hartley Sweeten
-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/cb_pcimdda.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/cb_pcimdda.c

[PATCH 31/35] staging: comedi: cb_pcimdda: minor cleanup of the private data

2012-08-16 Thread H Hartley Sweeten
Remove the cut-and-paste comment from the skel driver and for aesthetic reasons, move the #define out of the struct. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers

[PATCH 32/35] staging: comedi: cb_pcimdda: cleanup the analog out read/write

2012-08-16 Thread H Hartley Sweeten
' just makes it clearer. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/cb_pcimdda.c | 63 - 1 file changed, 26 insertions(+), 37 deletions

[PATCH 33/35] staging: comedi: cb_pcimdda: use attach_pci callback

2012-08-16 Thread H Hartley Sweeten
' callback, an assumption is made that the jumper is in the factory setting position for +/-5V outputs. This does not effect the operation of the board just the range info that is returned to the user. A sysfs method will be investigated to allow the user to change the range. Signed-off-by: H Hartley

[PATCH 34/35] staging: comedi: dyna_pci10xx: remove manual legacy attach

2012-08-16 Thread H Hartley Sweeten
This driver uses the 'attach_pci' callback to attach the pci device to the comedi subsystem. Since the 'attach' callback is now optional it can be removed from the driver. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre

[PATCH 35/35] staging: comedi: ke_counter: use attach_pci callback

2012-08-16 Thread H Hartley Sweeten
Convert this PCI driver to use the comedi PCI auto config attach mechanism by adding an 'attach_pci' callback function. Since the driver does not require any external configuration options, and the legacy 'attach' callback is now optional, remove it. Signed-off-by: H Hartley Sweeten hswee

RE: [PATCH 00/35] staging: comedi: update comedi pci drivers

2012-08-17 Thread H Hartley Sweeten
On Friday, August 17, 2012 1:44 AM, Ian Abbott wrote: On 2012-08-17 03:40, H Hartley Sweeten wrote: Remove the manual legacy 'attach' callback in the comedi pci drivers that have it stubbed out. The 'attach' callback is not optional in the comedi core. Just to avoid confusion, I think

[PATCH] staging: comedi: contec_pci: remove manual legacy attach

2012-08-17 Thread H Hartley Sweeten
This driver uses the 'attach_pci' callback to attach the pci device to the comedi subsystem. Since the 'attach' callback is now optional it can be removed from the driver. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre

[PATCH 00/20] staging: comedi: update comedi pci drivers part 2

2012-08-17 Thread H Hartley Sweeten
Another round of updates to the comedi pci drivers. * remove function trace messages * remove devpriv and thisboard type macros * cleanup the boardinfo * remove forward declarations * use attach_pci and remove legacy attach (when possible) * misc. other changes H Hartley Sweeten (20): staging

[PATCH 01/20] staging: comedi: adv_pci1710: remove function trace messages

2012-08-17 Thread H Hartley Sweeten
The macros PCI171X_EXTDEBUG and DPRINTK enable a number of function trace messages. These trace messages should not be in the final driver. Remove them. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org

[PATCH 02/20] staging: comedi: adv_pci1710: remove devpriv and this_board macros

2012-08-17 Thread H Hartley Sweeten
These macros rely on a local variable having a specific name. Remove them and use the comedi_board() helper to get the this_board pointer. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers

[PATCH 03/20] staging: comedi: adv_pci1710: convert boardinfo initialization to C99 format

2012-08-17 Thread H Hartley Sweeten
Convert the boardinfo initialization to C99 format to make it less error prone. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/adv_pci1710.c | 152

[PATCH 04/20] staging: comedi: adv_pci1710: remove '0' and 'NULL' boardinfo data

2012-08-17 Thread H Hartley Sweeten
Remove all the boardinfo data that is set to '0' or 'NULL'. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/adv_pci1710.c | 23 --- 1 file

[PATCH 05/20] staging: comedi: adv_pci1710: remove forward declarations

2012-08-17 Thread H Hartley Sweeten
Move some of the functions to remove the need for the forward declarations. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/adv_pci1710.c | 297

[PATCH 06/20] staging: comedi: adv_pci1723: remove function trace messages

2012-08-17 Thread H Hartley Sweeten
Remove the DPRINTK function trace messages. These should not be in the final driver. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/adv_pci1723.c | 5 - 1 file

[PATCH 07/20] staging: comedi: adv_pci1723: remove devpriv and this_board macros

2012-08-17 Thread H Hartley Sweeten
. Remove this macro also by making sure the dev-board_ptr is set in the pci1723_find_pci_dev() function and using the comedi_board() helper to get the pointer in pci1723_attach(). Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre

[PATCH 08/20] staging: comedi: adv_pci1723: remove range_pci1723

2012-08-17 Thread H Hartley Sweeten
This comedi_lrange is the same as the global range_bipolar10 exported by the comedi core. Use that range instead. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers

[PATCH 09/20] staging: comedi: adv_pci1723: fix initial dio subdevice state and io_bits

2012-08-17 Thread H Hartley Sweeten
The initial state and io_bits for the dio subdevice is determined in the pci1723_attach() but it's being saved in the wrong subdevice. Move the code so it gets saved correctly. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman

[PATCH 10/20] staging: comedi: adv_pci1723: remove boardinfo

2012-08-17 Thread H Hartley Sweeten
This driver only supports one board type. Remove the boardinfo and associated code. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/adv_pci1723.c | 139

[PATCH 11/20] staging: comedi: adv_pci1723: use attach_pci callback

2012-08-17 Thread H Hartley Sweeten
Convert this PCI driver to use the comedi PCI auto config attach mechanism by adding an 'attach_pci' callback function. Since the driver does not require any external configuration options, and the legacy 'attach' callback is now optional, remove it. Signed-off-by: H Hartley Sweeten hswee

[PATCH 12/20] staging: comedi: adv_pci1723: cleanup card reset

2012-08-17 Thread H Hartley Sweeten
' function. Checking if dev-iobase is valid works just as well. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/adv_pci1723.c | 17 +++-- 1 file changed, 3

[PATCH 13/20] staging: comedi: adv_pci_dio: remove function trace messages

2012-08-17 Thread H Hartley Sweeten
Remove the DPRINTK function trace messages and associated PCI_DIO_EXTDEBUG define. These should not be in the final driver. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi

[PATCH 14/20] staging: comedi: adv_pci_dio: remove devpriv and this_board macros

2012-08-17 Thread H Hartley Sweeten
These macros rely on a local variable having a specific name. Remove them and use the comedi_board() helper to get the this_board pointer. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers

[PATCH 15/20] staging: comedi: adv_pci_dio: use attach_pci callback

2012-08-17 Thread H Hartley Sweeten
Convert this PCI driver to use the comedi PCI auto config attach mechanism by adding an 'attach_pci' callback function. Since the driver does not require any external configuration options, and the legacy 'attach' callback is now optional, remove it. Signed-off-by: H Hartley Sweeten hswee

[PATCH 16/20] staging: comedi: adv_pci_dio: convert boardinfo initialization to C99 format

2012-08-17 Thread H Hartley Sweeten
Convert the boardinfo initialization to C99 format to make it less error prone. The struct diosubd_data information is not converted to C99 format yet because some of it will be removed. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah

[PATCH 17/20] staging: comedi: adv_pci_dio: remove '0' boardinfo data

2012-08-17 Thread H Hartley Sweeten
Remove all the boardinfo data that is simply '0'. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/adv_pci_dio.c | 84 1 file changed

[PATCH 18/20] staging: comedi: adv_pci_dio: add the number of subdevices to the boardinfo

2012-08-17 Thread H Hartley Sweeten
Instead of calculating the number of subdevices in the 'attach' simply add the number to the boardinfo. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers

[PATCH 19/20] staging: comedi: adv_pci_dio: simplify the 'detach'

2012-08-17 Thread H Hartley Sweeten
-type is COMEDI_SUBD_DIO. Use that to know when to call the cleanup for the 8255 subdevice. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/adv_pci_dio.c | 27

[PATCH 20/20] staging: comedi: adv_pci_dio: fix bug in 'detach'

2012-08-17 Thread H Hartley Sweeten
The 'attach' function can fail between when the devpriv and the comedi subdevices are allocated. If it does the 'detach' will try to access unallocated memory when it goes thru the subdevices. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg

[PATCH 0/4] staging: comedi: update the aio_aio12_8 driver

2012-08-20 Thread H Hartley Sweeten
H Hartley Sweeten (4): staging: comedi: aio_aio12_8: remove devpriv macro staging: comedi: aio_aio12_8: add ai and ao only card versions staging: comedi: aio_aio12_8: document the register map staging: comedi: aio_aio12_8: fix i/o region size drivers/staging/comedi/drivers/aio_aio12_8.c

[PATCH 1/4] staging: comedi: aio_aio12_8: remove devpriv macro

2012-08-20 Thread H Hartley Sweeten
This macro relies on a local variable having a specific name. Remove it. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/aio_aio12_8.c | 11 +++ 1 file

[PATCH 2/4] staging: comedi: aio_aio12_8: add ai and ao only card versions

2012-08-20 Thread H Hartley Sweeten
but stub in the subdevice information so it can easily be added. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/aio_aio12_8.c | 90 +++- 1 file

[PATCH 3/4] staging: comedi: aio_aio12_8: document the register map

2012-08-20 Thread H Hartley Sweeten
Fully document the register map and add namespace to all the defines. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/aio_aio12_8.c | 129

[PATCH 4/4] staging: comedi: aio_aio12_8: fix i/o region size

2012-08-20 Thread H Hartley Sweeten
This board has jumpers to set the board base address. These jumpers are marked A5 through A9 and A5 is the least significant bit of the address. This makes the address reqion for the board 32 bytes not 24. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo

[PATCH 0/5] staging: comedi: cleaup comedi_bond driver

2012-08-20 Thread H Hartley Sweeten
H Hartley Sweeten (5): staging: comedi: comedi_bond: remove boardinfo staging: comedi: comedi_bond: remove devpriv macro staging: comedi: comedi_bond: remove private printk macros staging: comedi: comedi_bond: remove the STR macro staging: comedi: comedi_bond: remove MODULE_NAME macro

[PATCH 1/5] staging: comedi: comedi_bond: remove boardinfo

2012-08-20 Thread H Hartley Sweeten
and driver name are identical we can simplify this driver a bit bu just removing the boardinfo completely. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/comedi_bond.c

[PATCH 2/5] staging: comedi: comedi_bond: remove devpriv macro

2012-08-20 Thread H Hartley Sweeten
This macro relies on a local variable having a specific name. Remove it. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/comedi_bond.c | 25

[PATCH 3/5] staging: comedi: comedi_bond: remove private printk macros

2012-08-20 Thread H Hartley Sweeten
Remove the macros LOG_MSG, DEBUG, WARNING, and ERROR. Convert the printk's into dev_printk format. The DEBUG macro is not being used in the file so the module parameter 'debug' can also be removed. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc

[PATCH 4/5] staging: comedi: comedi_bond: remove the STR macro

2012-08-20 Thread H Hartley Sweeten
This macro is not used in the file. Remove it. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/comedi_bond.c | 4 1 file changed, 4 deletions(-) diff --git

[PATCH 5/5] staging: comedi: comedi_bond: remove MODULE_NAME macro

2012-08-20 Thread H Hartley Sweeten
This macro is only used in the MODULE_DESCRIPTION. Just remove it. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/comedi_bond.c | 4 +--- 1 file changed, 1

[PATCH 0/4] staging: comedi: cleanup comedi_parport

2012-08-20 Thread H Hartley Sweeten
H Hartley Sweeten (4): staging: comedi: comedi_parport: remove devpriv macro staging: comedi: comedi_parport: cleanup dev-board_name staging: comedi: comedi_parport: cleanup 'attach' printk's staging: comedi: comedi_parport: remove the printk noise drivers/staging/comedi/drivers

[PATCH 1/4] staging: comedi: comedi_parport: remove devpriv macro

2012-08-20 Thread H Hartley Sweeten
This macro relies on a local variable having a specific name, Remove it. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/comedi_parport.c | 16 ++-- 1

[PATCH 2/4] staging: comedi: comedi_parport: cleanup dev-board_name

2012-08-20 Thread H Hartley Sweeten
Use the 'dev-driver-driver_name' for the 'dev-board_name'. And use the 'dev-board_name' for the resource name passed to request_region and request_irq. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org

[PATCH 3/4] staging: comedi: comedi_parport: cleanup 'attach' printk's

2012-08-20 Thread H Hartley Sweeten
Convert the printk messages in the 'attach' to dev_printk messages. Consolidate the attach message into one message after the device is attached. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org

[PATCH 4/4] staging: comedi: comedi_parport: remove the printk noise

2012-08-20 Thread H Hartley Sweeten
Remove the function trace message in parport_intr_cancel() and the bogus irq... message is parport_interrupt(). They are just added noise. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers

RE: [PATCH 09/20] staging: comedi: adv_pci1723: fix initial dio subdevice state and io_bits

2012-08-20 Thread H Hartley Sweeten
On Monday, August 20, 2012 2:49 PM, Dan Carpenter wrote: On Fri, Aug 17, 2012 at 06:17:38PM -0700, H Hartley Sweeten wrote: +if (this_board-n_diochan) { +s = dev-subdevices + subdev; This pointer math sucks still... I feel like the unreadable code is part of what caused

[PATCH 0/3] staging: comedi: cleanup conedi_test driver

2012-08-20 Thread H Hartley Sweeten
H Hartley Sweeten (3): staging: comedi: comedi_test: remove devpriv macro staging: comedi: comedi_test: remove boardinfo staging: comedi: comedi_test: convert attach message to dev_info drivers/staging/comedi/drivers/comedi_test.c | 61 1 file changed, 27

[PATCH 1/3] staging: comedi: comedi_test: remove devpriv macro

2012-08-20 Thread H Hartley Sweeten
This macro relies on a local variable having a specific name. Remove it. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/comedi_test.c | 20 1

[PATCH 2/3] staging: comedi: comedi_test: remove boardinfo

2012-08-20 Thread H Hartley Sweeten
. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/comedi_test.c | 31 +--- 1 file changed, 5 insertions(+), 26 deletions(-) diff --git

[PATCH 3/3] staging: comedi: comedi_test: convert attach message to dev_info

2012-08-20 Thread H Hartley Sweeten
Convert the 'attach' message from a printk to a dev_info. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/comedi_test.c | 10 ++ 1 file changed, 6

RE: [PATCH 09/20] staging: comedi: adv_pci1723: fix initial dio subdevice state and io_bits

2012-08-20 Thread H Hartley Sweeten
On Monday, August 20, 2012 2:51 PM, H Hartley Sweeten wrote: On Monday, August 20, 2012 2:49 PM, Dan Carpenter wrote: On Fri, Aug 17, 2012 at 06:17:38PM -0700, H Hartley Sweeten wrote: + if (this_board-n_diochan) { + s = dev-subdevices + subdev; This pointer math sucks still

[PATCH 00/83] staging: comedi: rtd520: initial cleanup

2012-07-10 Thread H Hartley Sweeten
refactored to follow the style of the other comedi pci drivers. The range tables are also cleaned up for aesthetic reasons. The large whitespace causes some pretty nasty line breaks in order to keep the lines 80 characters. H Hartley Sweeten (83): staging: comedi: rtd520: remove RtdResetBoard macro

[PATCH 01/83] staging: comedi: rtd520: remove RtdResetBoard macro

2012-07-10 Thread H Hartley Sweeten
This macro uses the 'devpriv' macro which relies on a local variable having a specific name. Plus it's just a wrapper around a simple 'writel'. Remove the macro. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre

[PATCH 02/83] staging: comedi: rtd520: remove RtdResetCGT macro

2012-07-10 Thread H Hartley Sweeten
This macro uses the 'devpriv' macro which relies on a local variable having a specific name. It's also not used. Remove it. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi

[PATCH 03/83] staging: comedi: rtd520: remove RtdClearCGT macro

2012-07-10 Thread H Hartley Sweeten
This macro uses the 'devpriv' macro which relies on a local variable having a specific name. Plus it's just a wrapper around a simple 'writel'. Remove the macro. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre

[PATCH 04/83] staging: comedi: rtd520: remove RtdEnableCGT macro

2012-07-10 Thread H Hartley Sweeten
This macro uses the 'devpriv' macro which relies on a local variable having a specific name. Plus it's just a wrapper around a simple 'writel'. Remove the macro. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre

[PATCH 05/83] staging: comedi: rtd520: remove RtdWriteCGTable macro

2012-07-10 Thread H Hartley Sweeten
This macro uses the 'devpriv' macro which relies on a local variable having a specific name. Plus it's just a wrapper around a simple 'writel'. Remove the macro. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre

[PATCH 06/83] staging: comedi: rtd520: remove RtdWriteCGLatch macro

2012-07-10 Thread H Hartley Sweeten
This macro uses the 'devpriv' macro which relies on a local variable having a specific name. Plus it's just a wrapper around a simple 'writel'. Remove the macro. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre

[PATCH 07/83] staging: comedi: rtd520: remove RtdAdcClearFifo macro

2012-07-10 Thread H Hartley Sweeten
This macro uses the 'devpriv' macro which relies on a local variable having a specific name. Plus it's just a wrapper around a simple 'writel'. Remove the macro. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre

[PATCH 08/83] staging: comedi: rtd520: remove RtdAdcConversionSource macro

2012-07-10 Thread H Hartley Sweeten
This macro uses the 'devpriv' macro which relies on a local variable having a specific name. Plus it's just a wrapper around a simple 'writel'. Remove the macro. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre

[PATCH 09/83] staging: comedi: rtd520: remove RtdBurstStartSource macro

2012-07-10 Thread H Hartley Sweeten
This macro uses the 'devpriv' macro which relies on a local variable having a specific name. Plus it's just a wrapper around a simple 'writel'. Remove the macro. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre

[PATCH 10/83] staging: comedi: rtd520: remove RtdPacerStartSource macro

2012-07-10 Thread H Hartley Sweeten
This macro uses the 'devpriv' macro which relies on a local variable having a specific name. Plus it's just a wrapper around a simple 'writel'. Remove the macro. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre

[PATCH 11/83] staging: comedi: rtd520: remove RtdPacerStopSource macro

2012-07-10 Thread H Hartley Sweeten
This macro uses the 'devpriv' macro which relies on a local variable having a specific name. Plus it's just a wrapper around a simple 'writel'. Remove the macro. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre

[PATCH 12/83] staging: comedi: rtd520: remove RtdPacerClockSource macro

2012-07-10 Thread H Hartley Sweeten
This macro uses the 'devpriv' macro which relies on a local variable having a specific name. Plus it's just a wrapper around a simple 'writel'. Remove the macro. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre

[PATCH 13/83] staging: comedi: rtd520: remove RtdAdcSampleCounterSource macro

2012-07-10 Thread H Hartley Sweeten
This macro uses the 'devpriv' macro which relies on a local variable having a specific name. It's also not used. Remove it. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi

[PATCH 14/83] staging: comedi: rtd520: remove RtdPacerTriggerMode macro

2012-07-10 Thread H Hartley Sweeten
This macro uses the 'devpriv' macro which relies on a local variable having a specific name. It's also not used. Remove it. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi

[PATCH 15/83] staging: comedi: rtd520: remove RtdAboutStopEnable macro

2012-07-10 Thread H Hartley Sweeten
This macro uses the 'devpriv' macro which relies on a local variable having a specific name. Plus it's just a wrapper around a simple 'writel'. Remove the macro. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre

[PATCH 16/83] staging: comedi: rtd520: remove RtdTriggerPolarity macro

2012-07-10 Thread H Hartley Sweeten
This macro uses the 'devpriv' macro which relies on a local variable having a specific name. It's also not used. Remove it. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi

[PATCH 17/83] staging: comedi: rtd520: remove RtdAdcStart macro

2012-07-10 Thread H Hartley Sweeten
This macro uses the 'devpriv' macro which relies on a local variable having a specific name. Plus it's just a wrapper around a simple 'writel'. Remove the macro. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre

[PATCH 18/83] staging: comedi: rtd520: remove RtdAdcFifoGet macro

2012-07-10 Thread H Hartley Sweeten
This macro uses the 'devpriv' macro which relies on a local variable having a specific name. Plus it's just a wrapper around a simple 'readw'. Remove the macro. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre

[PATCH 19/83] staging: comedi: rtd520: remove RtdAdcFifoGet2 macro

2012-07-10 Thread H Hartley Sweeten
This macro uses the 'devpriv' macro which relies on a local variable having a specific name. It's also not used and the comment says it does not work. Remove it. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre

[PATCH 20/83] staging: comedi: rtd520: remove RtdFifoStatus macro

2012-07-10 Thread H Hartley Sweeten
This macro uses the 'devpriv' macro which relies on a local variable having a specific name. Plus it's just a wrapper around a simple 'readl'. Remove the macro. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre

[PATCH 21/83] staging: comedi: rtd520: remove RtdPacerStart macro

2012-07-10 Thread H Hartley Sweeten
This macro uses the 'devpriv' macro which relies on a local variable having a specific name. Plus it's just a wrapper around a simple 'readl'. Remove the macro. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre

[PATCH 22/83] staging: comedi: rtd520: remove RtdPacerStop macro

2012-07-10 Thread H Hartley Sweeten
This macro uses the 'devpriv' macro which relies on a local variable having a specific name. Plus it's just a wrapper around a simple 'writel'. Remove the macro. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre

[PATCH 23/83] staging: comedi: rtd520: remove RtdInterruptStatus macro

2012-07-10 Thread H Hartley Sweeten
This macro uses the 'devpriv' macro which relies on a local variable having a specific name. Plus it's just a wrapper around a simple 'readw'. Remove the macro. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre

[PATCH 24/83] staging: comedi: rtd520: remove RtdInterruptMask macro

2012-07-10 Thread H Hartley Sweeten
This macro uses the 'devpriv' macro which relies on a local variable having a specific name. Plus it's just a wrapper around a simple 'writew'. Remove the macro. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre

[PATCH 25/83] staging: comedi: rtd520: remove RtdInterruptClear macro

2012-07-10 Thread H Hartley Sweeten
This macro uses the 'devpriv' macro which relies on a local variable having a specific name. Plus it's just a wrapper around a simple 'readw'. Remove the macro. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre

[PATCH 26/83] staging: comedi: rtd520: remove RtdInterruptClearMask macro

2012-07-10 Thread H Hartley Sweeten
This macro uses the 'devpriv' macro which relies on a local variable having a specific name. Plus it's just a wrapper around a simple 'writew'. Remove the macro. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre

[PATCH 27/83] staging: comedi: rtd520: remove RtdInterruptOverrunStatus macro

2012-07-10 Thread H Hartley Sweeten
This macro uses the 'devpriv' macro which relies on a local variable having a specific name. Plus it's just a wrapper around a simple 'readl'. Remove the macro. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre

[PATCH 28/83] staging: comedi: rtd520: remove RtdInterruptOverrunClear macro

2012-07-10 Thread H Hartley Sweeten
This macro uses the 'devpriv' macro which relies on a local variable having a specific name. Plus it's just a wrapper around a simple 'writel'. Remove the macro. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre

[PATCH 29/83] staging: comedi: rtd520: remove RtdPacerCount macro

2012-07-10 Thread H Hartley Sweeten
This macro uses the 'devpriv' macro which relies on a local variable having a specific name. It's also not used. Remove the macro. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging

[PATCH 30/83] staging: comedi: rtd520: remove RtdPacerCounter macro

2012-07-10 Thread H Hartley Sweeten
This macro uses the 'devpriv' macro which relies on a local variable having a specific name. Plus it's just a wrapper around a simple 'writel'. Remove the macro. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre

[PATCH 31/83] staging: comedi: rtd520: remove RtdBurstCount macro

2012-07-10 Thread H Hartley Sweeten
This macro uses the 'devpriv' macro which relies on a local variable having a specific name. It's also not used. Remove the macro. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging

[PATCH 32/83] staging: comedi: rtd520: remove RtdBurstCounter macro

2012-07-10 Thread H Hartley Sweeten
This macro uses the 'devpriv' macro which relies on a local variable having a specific name. Plus it's just a wrapper around a simple 'writel'. Remove the macro. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre

[PATCH 33/83] staging: comedi: rtd520: remove RtdDelayCount macro

2012-07-10 Thread H Hartley Sweeten
This macro uses the 'devpriv' macro which relies on a local variable having a specific name. It's also not used. Remove the macro. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging

[PATCH 34/83] staging: comedi: rtd520: remove RtdDelayCounter macro

2012-07-10 Thread H Hartley Sweeten
This macro uses the 'devpriv' macro which relies on a local variable having a specific name. It's also not used. Remove the macro. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging

[PATCH 35/83] staging: comedi: rtd520: remove RtdAboutCount macro

2012-07-10 Thread H Hartley Sweeten
This macro uses the 'devpriv' macro which relies on a local variable having a specific name. It's also not used. Remove the macro. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging

[PATCH 36/83] staging: comedi: rtd520: remove RtdAboutCounter macro

2012-07-10 Thread H Hartley Sweeten
This macro uses the 'devpriv' macro which relies on a local variable having a specific name. Plus it's just a wrapper around a simple 'writel'. Remove the macro. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre

[PATCH 37/83] staging: comedi: rtd520: remove RtdAdcSampleCount macro

2012-07-10 Thread H Hartley Sweeten
This macro uses the 'devpriv' macro which relies on a local variable having a specific name. It's also not used. Remove the macro. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging

[PATCH 38/83] staging: comedi: rtd520: remove RtdAdcSampleCounter macro

2012-07-10 Thread H Hartley Sweeten
This macro uses the 'devpriv' macro which relies on a local variable having a specific name. It's also not used. Remove the macro. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging

<    1   2   3   4   5   6   7   8   9   10   >