[PATCHv4 0/8] perf, tool: Allow to use hw events in PMU syntax

2012-10-10 Thread Jiri Olsa
hw event as pmu event term 8/8 perf test: Add automated tests for pmu sysfs translated events jirka Suggested-by: Peter Zijlstra a.p.zijls...@chello.nl Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Ingo

[PATCH 4/8] perf x86: Adding hardware events translations for amd cpus

2012-10-10 Thread Jiri Olsa
-cycles-backend stalled-cycles-frontend Suggested-by: Peter Zijlstra a.p.zijls...@chello.nl Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Ingo Molnar mi...@elte.hu Cc: Paul Mackerras pau...@samba.org Cc

[PATCH 6/8] perf tools: Fix pmu object alias initialization

2012-10-10 Thread Jiri Olsa
The pmu_lookup should return pmus that do not expose the 'events' group attribute in sysfs. Also it should fail when any other error during 'events' lookup is hit (pmu_aliases fails). Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Peter Zijlstra

[PATCH 7/8] perf tools: Add support to specify hw event as pmu event term

2012-10-10 Thread Jiri Olsa
, the rest is already handled by the pmu alias code. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Ingo Molnar mi...@elte.hu Cc: Paul Mackerras pau...@samba.org Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc

[PATCH 8/8] perf test: Add automated tests for pmu sysfs translated events

2012-10-10 Thread Jiri Olsa
) and that modifier is properly set. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Ingo Molnar mi...@elte.hu Cc: Paul Mackerras pau...@samba.org Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic

[PATCH 5/8] perf x86: Adding hardware events translations for p6 cpus

2012-10-10 Thread Jiri Olsa
-cycles-backend stalled-cycles-frontend Suggested-by: Peter Zijlstra a.p.zijls...@chello.nl Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Ingo Molnar mi...@elte.hu Cc: Paul Mackerras pau...@samba.org Cc

[PATCH 3/8] perf x86: Adding hardware events translations for intel cpus

2012-10-10 Thread Jiri Olsa
-cycles-backend stalled-cycles-frontend Suggested-by: Peter Zijlstra a.p.zijls...@chello.nl Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Ingo Molnar mi...@elte.hu Cc: Paul Mackerras pau...@samba.org Cc

[PATCH 1/8] perf x86: Making hardware events translations available in sysfs

2012-10-10 Thread Jiri Olsa
-backend event=0xb1,umask=0x01,inv,cmask=0x01 Suggested-by: Peter Zijlstra a.p.zijls...@chello.nl Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Ingo Molnar mi...@elte.hu Cc: Paul Mackerras pau...@samba.org Cc

[PATCH 2/8] perf x86: Filter out undefined events from sysfs events attribute

2012-10-10 Thread Jiri Olsa
The sysfs events group attribute currently shows all hw events, including also undefined ones. This patch filters out all undefined events out of the sysfs events group attribute, so they don't even show up. Suggested-by: Peter Zijlstra a.p.zijls...@chello.nl Signed-off-by: Jiri Olsa jo

Re: [PATCHv4 0/8] perf, tool: Allow to use hw events in PMU syntax

2012-10-10 Thread Jiri Olsa
On Wed, Oct 10, 2012 at 03:34:53PM +0200, Stephane Eranian wrote: On Wed, Oct 10, 2012 at 2:53 PM, Jiri Olsa jo...@redhat.com wrote: hi, here's the change to make following syntax available: perf stat -e cpu/event=instructions/u ls perf stat -e cpu/cycles/u ls Unless, I am mistaken

Re: [PATCH 4/8] perf x86: Adding hardware events translations for amd cpus

2012-10-10 Thread Jiri Olsa
On Wed, Oct 10, 2012 at 04:11:42PM +0200, Peter Zijlstra wrote: On Wed, 2012-10-10 at 14:53 +0200, Jiri Olsa wrote: +static ssize_t amd_event_sysfs_show(char *page, u64 config) +{ + u64 event = (config ARCH_PERFMON_EVENTSEL_EVENT) | + (config AMD64_EVENTSEL_EVENT

Re: [PATCH 00/11] perf tool: Add PERF_SAMPLE_READ sample read support

2012-10-26 Thread Jiri Olsa
On Fri, Oct 26, 2012 at 11:14:45AM +0200, Peter Zijlstra wrote: On Fri, 2012-10-26 at 10:29 +0900, Namhyung Kim wrote: Hi Jiri, On Sat, 20 Oct 2012 16:33:08 +0200, Jiri Olsa wrote: hi, adding support to read sample values through the PERF_SAMPLE_READ sample type. It's now possible

Re: [PATCH 4/5] perf tools: Always show CHK message when doing try-cc

2012-10-26 Thread Jiri Olsa
On Fri, Oct 26, 2012 at 05:55:51PM +0900, Namhyung Kim wrote: From: Namhyung Kim namhyung@lge.com It might be useful to see what's happening behind us rather than just waiting few seconds during the config checking. Do we want to see all that within just simple 'make' also in case

Re: [PATCH 24/33] perf, tools: Move parse_events error printing to parse_events_options

2012-10-27 Thread Jiri Olsa
parse_filter(const struct option *opt, const char *str, -- 1.7.7.6 Acked-by: Jiri Olsa jo...@redhat.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH 25/33] perf, tools: Support events with - in the name

2012-10-27 Thread Jiri Olsa
On Fri, Oct 26, 2012 at 01:30:07PM -0700, Andi Kleen wrote: From: Andi Kleen a...@linux.intel.com - looks nicer than _, so allow - in the event names. Used for various of the arch perfmon and Haswell events. Signed-off-by: Andi Kleen a...@linux.intel.com ---

Re: [PATCH 27/33] tools, perf: Add a precise event qualifier

2012-10-27 Thread Jiri Olsa
On Fri, Oct 26, 2012 at 01:30:09PM -0700, Andi Kleen wrote: From: Andi Kleen a...@linux.intel.com Add a precise qualifier, like cpu/event=0x3c,precise=1/ hm, I think this works already via 'p' modifier like: cpu/event=0x3c/p jirka -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 31/33] perf, tools: Support generic events as pmu event names v2

2012-10-27 Thread Jiri Olsa
On Fri, Oct 26, 2012 at 01:30:13PM -0700, Andi Kleen wrote: From: Andi Kleen a...@linux.intel.com Extend the parser/lexer to allow generic event names like instructions as a sysfs supplied PMU event name. This resolves the problem that cpu/instructions/ gives a parse error, even when the

Re: [PATCH 32/33] perf, tools: Default to cpu// for events v2

2012-10-27 Thread Jiri Olsa
On Fri, Oct 26, 2012 at 01:30:14PM -0700, Andi Kleen wrote: From: Andi Kleen a...@linux.intel.com When an event fails to parse and it's not in a new style format, try to parse it again as a cpu event. This allows to use sysfs exported events directly without //, so I can use perf record

Re: [PATCH 33/33] perf, tools: List kernel supplied event aliases in perf list v2

2012-10-27 Thread Jiri Olsa
On Fri, Oct 26, 2012 at 01:30:15PM -0700, Andi Kleen wrote: From: Andi Kleen a...@linux.intel.com List the kernel supplied pmu event aliases in perf list It's better when the users can actually see them. with the HW events being part of PMU 'events' dir we get single HW events listed twice

Re: [BUG] perf parser: does not support arbitrary new sysfs events

2012-10-27 Thread Jiri Olsa
On Fri, Oct 26, 2012 at 10:23:09PM +0200, Stephane Eranian wrote: Hi, The latest round of perf parser changes broke my PEBS-LL patch series (at the last minute). For PEBS-LL, I need to add to generic events but I want to keep them PMU specific. As such, they need to live in the sysfs events

[PATCH 2/5] perf tool: Move BUILD_ID_SIZE into build-id object

2012-10-27 Thread Jiri Olsa
Moving BUILD_ID_SIZE define into build-id object, plus include related changes. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis...@gmail.com Cc: Ingo Molnar mi...@elte.hu Cc: Namhyung Kim namhy...@kernel.org Cc: Paul Mackerras

[PATCH 5/5] perf tool: Move dso_* related functions into dso object

2012-10-27 Thread Jiri Olsa
Moving dso_* related functions into dso object. Keeping symbol loading related functions still in the symbol object as it seems more convenient. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis...@gmail.com Cc: Ingo Molnar mi

[PATCH 3/5] perf tool: Move hex2u64 into util object

2012-10-27 Thread Jiri Olsa
Moving hex2u64 function into util object. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis...@gmail.com Cc: Ingo Molnar mi...@elte.hu Cc: Namhyung Kim namhy...@kernel.org Cc: Paul Mackerras pau...@samba.org Cc: Peter Zijlstra

[PATCH 1/5] perf tool: Move build_id__sprintf into build-id object

2012-10-27 Thread Jiri Olsa
Moving build_id__sprintf function into build-id object. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis...@gmail.com Cc: Ingo Molnar mi...@elte.hu Cc: Namhyung Kim namhy...@kernel.org Cc: Paul Mackerras pau...@samba.org Cc

[PATCH 0/5] perf dso: Separate dso symbols to separate object

2012-10-27 Thread Jiri Olsa
hi, separating dso related stuff into dso object plus some other symbol object cleanup. It's just a code moving, no actual change was done. Attached patches: 1/5 perf tool: Move build_id__sprintf into build-id object 2/5 perf tool: Move BUILD_ID_SIZE into build-id object 3/5 perf tool: Move

[PATCH 4/5] perf tool: Move strxfrchar into string object

2012-10-27 Thread Jiri Olsa
Moving strxfrchar function into string object. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis...@gmail.com Cc: Ingo Molnar mi...@elte.hu Cc: Namhyung Kim namhy...@kernel.org Cc: Paul Mackerras pau...@samba.org Cc: Peter

Re: [BUG] perf parser: does not support arbitrary new sysfs events

2012-10-27 Thread Jiri Olsa
On Sun, Oct 28, 2012 at 01:13:59AM +0200, Stephane Eranian wrote: On Sat, Oct 27, 2012 at 10:34 PM, Jiri Olsa jo...@redhat.com wrote: On Fri, Oct 26, 2012 at 10:23:09PM +0200, Stephane Eranian wrote: Hi, The latest round of perf parser changes broke my PEBS-LL patch series (at the last

Re: [PATCH 5/5] perf tool: Move dso_* related functions into dso object

2012-10-28 Thread Jiri Olsa
On Sun, Oct 28, 2012 at 11:37:02AM -0200, Arnaldo Carvalho de Melo wrote: Em Sat, Oct 27, 2012 at 11:18:32PM +0200, Jiri Olsa escreveu: Moving dso_* related functions into dso object. Keeping symbol loading related functions still in the symbol object as it seems more convenient

Re: [PATCH 27/33] tools, perf: Add a precise event qualifier

2012-10-28 Thread Jiri Olsa
On Sun, Oct 28, 2012 at 08:13:13PM +0100, Andi Kleen wrote: On Sat, Oct 27, 2012 at 09:35:44PM +0200, Jiri Olsa wrote: On Fri, Oct 26, 2012 at 01:30:09PM -0700, Andi Kleen wrote: From: Andi Kleen a...@linux.intel.com Add a precise qualifier, like cpu/event=0x3c,precise=1/ hm, I

Re: [PATCH 0/5] perf dso: Separate dso symbols to separate object

2012-10-29 Thread Jiri Olsa
On Mon, Oct 29, 2012 at 08:07:48PM +0900, Namhyung Kim wrote: Hi Jiri, On Sat, 27 Oct 2012 23:18:27 +0200, Jiri Olsa wrote: hi, separating dso related stuff into dso object plus some other symbol object cleanup. It's just a code moving, no actual change was done. Attached patches

[PATCH 01/12] perf tests: Move test__vmlinux_matches_kallsyms into separate object

2012-11-09 Thread Jiri Olsa
Separating test__vmlinux_matches_kallsyms test from the builtin-test into vmlinux-kallsyms object. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis...@gmail.com Cc: Ingo Molnar mi...@elte.hu Cc: Paul Mackerras pau...@samba.org

[PATCH 06/12] perf tests: Move test__rdpmc into separate object

2012-11-09 Thread Jiri Olsa
Separating test__rdpmc test from the builtin-test into rdpmc object. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis...@gmail.com Cc: Ingo Molnar mi...@elte.hu Cc: Paul Mackerras pau...@samba.org Cc: Peter Zijlstra a.p.zijls

[PATCH 10/12] perf tests: Move pmu tests into separate object

2012-11-09 Thread Jiri Olsa
Separating pmu's object tests into pmu object under tests directory. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis...@gmail.com Cc: Ingo Molnar mi...@elte.hu Cc: Paul Mackerras pau...@samba.org Cc: Peter Zijlstra a.p.zijls

[PATCH 08/12] perf tests: Move perf_evsel__tp_sched_test into separate object

2012-11-09 Thread Jiri Olsa
Separating perf_evsel__tp_sched_test test from the builtin-test into evsel-tp-sched object. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis...@gmail.com Cc: Ingo Molnar mi...@elte.hu Cc: Paul Mackerras pau...@samba.org Cc

[PATCH 09/12] perf tests: Move test__syscall_open_tp_fields into separate object

2012-11-09 Thread Jiri Olsa
Separating test__syscall_open_tp_fields test from the builtin-test into open-syscall-tp-fields object. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis...@gmail.com Cc: Ingo Molnar mi...@elte.hu Cc: Paul Mackerras pau

[PATCH 02/12] perf tests: Move test__open_syscall_event into separate object

2012-11-09 Thread Jiri Olsa
Separating test__open_syscall_event test from the builtin-test into open-syscall object. Adding util object under tests directory to gather help functions common to more tests. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis

[PATCH 07/12] perf tests: Move perf_evsel__roundtrip_name_test into separate object

2012-11-09 Thread Jiri Olsa
Separating perf_evsel__roundtrip_name_test test from the builtin-test into evsel-roundtrip-name object. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis...@gmail.com Cc: Ingo Molnar mi...@elte.hu Cc: Paul Mackerras pau

[PATCH 04/12] perf tests: Move test__basic_mmap into separate object

2012-11-09 Thread Jiri Olsa
Separating test__basic_mmap test from the builtin-test into mmap-basic object. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis...@gmail.com Cc: Ingo Molnar mi...@elte.hu Cc: Paul Mackerras pau...@samba.org Cc: Peter Zijlstra

[PATCH 03/12] perf tests: Move test__open_syscall_event_on_all_cpus into separate object

2012-11-09 Thread Jiri Olsa
Separating test__open_syscall_event_on_all_cpus test from the builtin-test into open-syscall-all-cpus object. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis...@gmail.com Cc: Ingo Molnar mi...@elte.hu Cc: Paul Mackerras pau

[PATCH 12/12] perf tests: Check for mkstemp return value in dso-data test

2012-11-09 Thread Jiri Olsa
Adding check for mkstemp return error value in dso-data test. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis...@gmail.com Cc: Ingo Molnar mi...@elte.hu Cc: Paul Mackerras pau...@samba.org Cc: Peter Zijlstra a.p.zijls

[PATCH 05/12] perf tests: Move test__PERF_RECORD into separate object

2012-11-09 Thread Jiri Olsa
Separating test__PERF_RECORD test from the builtin-test into perf-record object. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis...@gmail.com Cc: Ingo Molnar mi...@elte.hu Cc: Paul Mackerras pau...@samba.org Cc: Peter Zijlstra

[PATCH 00/12] perf tests: Move tests from builtin-test

2012-11-09 Thread Jiri Olsa
hi, I discussed with Arnaldo of moving tests from builtin-test into separated objects.. here it is. I swear not to touch test code for a while after this one ;-) Attached patches: 01/12 perf tests: Move test__vmlinux_matches_kallsyms into separate object 02/12 perf tests: Move

[PATCH 11/12] perf tests: Final cleanup for builtin-test move

2012-11-09 Thread Jiri Olsa
Final function renames to match test__* style and include cleanup. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis...@gmail.com Cc: Ingo Molnar mi...@elte.hu Cc: Paul Mackerras pau...@samba.org Cc: Peter Zijlstra a.p.zijls

Re: [GIT PULL 00/21] perf/core improvements and fixes

2012-11-12 Thread Jiri Olsa
On Mon, Nov 12, 2012 at 11:10:52AM +0900, Namhyung Kim wrote: Hi Arnaldo, On Fri, 9 Nov 2012 18:42:49 -0300, Arnaldo Carvalho de Melo wrote: Hi Ingo, Please consider pulling. - Arnaldo The following changes since commit 8dfec403e39b7c37fd6e8813bacc01da1e1210ab: perf

[PATCH 1/5] perf tool: Fix attributes for '{}' defined event groups

2012-11-12 Thread Jiri Olsa
' option. Making above attributes values based on the 'evsel-leader' as this is common to both group definition. Moving perf_evlist__set_leader call within builtin-record ahead perf_evlist__config_attrs call, because the latter needs possible group leader links in place. Signed-off-by: Jiri Olsa jo

[PATCH 3/5] perf tool: Ensure single disable call per event in record comand

2012-11-12 Thread Jiri Olsa
It's possible we issue the event disable ioctl multiple times until we read the final portion of the mmap buffer. Ensuring just single disable ioctl call for event, because there's no need to do that more than once. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Corey Ashford cjash

[PATCH 0/5] perf tool: Fix enable/disable events logic for record command

2012-11-12 Thread Jiri Olsa
hi, this patchset fixes the event enable/disable logic for record command (patches 1 - 4) plus small fix for event parsing (patch 5). Attached patches: 1/5 perf tool: Fix attributes for '{}' defined event groups 2/5 perf tool: Fix 'disabled' attribute config for record command 3/5 perf

[PATCH 4/5] perf tool: Omit group members from perf_evlist__disable/enable

2012-11-12 Thread Jiri Olsa
There's no need to disable/enable ordinary group member events, because they are initialy enabled and get scheduled by the leader. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis...@gmail.com Cc: Ingo Molnar mi...@elte.hu Cc

[PATCH 2/5] perf tool: Fix 'disabled' attribute config for record command

2012-11-12 Thread Jiri Olsa
. Fixing appropriate perf_event_attr test case to cover this change. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis...@gmail.com Cc: Ingo Molnar mi...@elte.hu Cc: Paul Mackerras pau...@samba.org Cc: Peter Zijlstra a.p.zijls

[PATCH 5/5] perf tool: Add basic event modifier sanity check

2012-11-12 Thread Jiri Olsa
Updating event parser to allow any non zero string containing [ukhpGH] characters for event modifier. The modifier sanity is checked later in parse-event object logic. The check validates modifier to contain only one instance of any modifier (apart from 'p') present. Signed-off-by: Jiri Olsa jo

[PATCHv2 5/5] perf tool: Add basic event modifier sanity check

2012-11-13 Thread Jiri Olsa
On Tue, Nov 13, 2012 at 11:22:24AM +0900, Namhyung Kim wrote: Hi Jiri, On Mon, 12 Nov 2012 18:34:04 +0100, Jiri Olsa wrote: Updating event parser to allow any non zero string containing [ukhpGH] characters for event modifier. The modifier sanity is checked later in parse-event object

Re: [PATCH 3/4] perf/POWER7: Make event translations available in sysfs

2012-11-14 Thread Jiri Olsa
On Wed, Nov 07, 2012 at 11:19:28AM -0800, Sukadev Bhattiprolu wrote: SNIP +struct perf_pmu_events_attr { + struct device_attribute attr; + u64 id; +}; + +extern ssize_t power_events_sysfs_show(struct device *dev, + struct device_attribute *attr, char

Re: [PATCH 4/4] perf: Create a sysfs entry for Power event format

2012-11-14 Thread Jiri Olsa
On Wed, Nov 07, 2012 at 11:19:52AM -0800, Sukadev Bhattiprolu wrote: From bafc551c31ce23c1cba0b75d23de6c46aba90f26 Mon Sep 17 00:00:00 2001 From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com Date: Tue, 6 Nov 2012 16:30:28 -0800 Subject: [PATCH 4/4] perf: Create a sysfs entry for Power

Re: [PATCH] perf ui/browser: Fix off-by-two bug on the first column

2012-10-15 Thread Jiri Olsa
-diff) output. Reported-by: Markus Trippelsdorf mar...@trippelsdorf.de Cc: Jiri Olsa jo...@redhat.com Signed-off-by: Namhyung Kim namhy...@kernel.org eek, missed that one ;) thanks! Acked-by: Jiri Olsa jo...@redhat.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: [PATCH 00/20] perf report: Add support for event group view (v3)

2012-10-18 Thread Jiri Olsa
-pick Jiri's hpp changes * add missing bswap_32 on reading nr_groups (Jiri) * remove perf_evlist__recalc_nr_groups() in favor of list_is_last (Jiri) Acked-by: Jiri Olsa jo...@redhat.com for patches 10 to 20, the rest is already in thanks, jirka -- To unsubscribe from this list: send the line

Re: [PATCHv3 0/3] perf tool: Add new event group management

2012-07-18 Thread Jiri Olsa
On Tue, Jul 17, 2012 at 09:15:23AM +0200, Stephane Eranian wrote: On Mon, Jul 9, 2012 at 1:05 PM, Jiri Olsa jo...@redhat.com wrote: On Fri, Jul 06, 2012 at 03:42:54AM +0200, Stephane Eranian wrote: On Fri, Jul 6, 2012 at 3:32 AM, Ulrich Drepper drep...@gmail.com wrote: On Thu, Jul 5

Re: [PATCHv3 0/3] perf tool: Add new event group management

2012-07-18 Thread Jiri Olsa
On Wed, Jul 18, 2012 at 08:34:10AM -0400, Ulrich Drepper wrote: On Wed, Jul 18, 2012 at 6:21 AM, Jiri Olsa jo...@redhat.com wrote: Well, I personally like the '{}' syntax more than '--group-events or --group-reads option in front', it feels more user friendly.. anyway, we can easily have

[PATCH 2/4] perf, tool: Add support to update event modifier

2012-07-19 Thread Jiri Olsa
by default or by event modifier. Keeping the current behaviour, that any event/group modifier reset the defaults for exclude_host (0) and exclude_guest (1). Signed-off-by: Jiri Olsa jo...@redhat.com --- tools/perf/util/evsel.h|2 ++ tools/perf/util/parse-events.c | 74

[PATCHv4 0/4] perf tool: Add new event group management

2012-07-19 Thread Jiri Olsa
hi, adding support for creating event groups based on the way they are specified on the command line. This patchset adds the '{}' style grammar to express event group, allowing so far only the 'event modifier' as group modifier. v4 changes: - group modifier updates events modifiers (not

[PATCH 3/4] perf, tool: Enable grouping logic for parsed events

2012-07-19 Thread Jiri Olsa
over all events in the group and updates each event modifier settings, for example: # perf record -r '{faults:k,cache-references}:p' resulting in ':kp' modifier being used for 'faults' and ':p' modifier being used for 'cache-references' event. Signed-off-by: Jiri Olsa jo...@redhat.com --- tools

[PATCH 1/4] perf, tool: Add support to parse event group syntax

2012-07-19 Thread Jiri Olsa
-by: Jiri Olsa jo...@redhat.com --- tools/perf/util/parse-events.c | 14 +- tools/perf/util/parse-events.h |4 +- tools/perf/util/parse-events.l |2 + tools/perf/util/parse-events.y | 93 ++-- 4 files changed, 97 insertions(+), 16 deletions(-) diff

[PATCH 4/4] perf, test: Add automated tests for event group parsing

2012-07-19 Thread Jiri Olsa
Adding 5 more tests for new event group syntax. Tests are executed within the 'perf test parse' test suite. Signed-off-by: Jiri Olsa jo...@redhat.com --- tools/perf/util/parse-events-test.c | 303 ++- 1 file changed, 300 insertions(+), 3 deletions(-) diff --git

Re: [PATCHv4 0/4] perf tool: Add new event group management

2012-07-20 Thread Jiri Olsa
On Fri, Jul 20, 2012 at 05:09:33PM +0900, Namhyung Kim wrote: Hi, Jiri On Thu, 19 Jul 2012 23:53:53 +0200, Jiri Olsa wrote: hi, adding support for creating event groups based on the way they are specified on the command line. This patchset adds the '{}' style grammar to express event

Re: [PATCH 0/5] perf: Add support for hardware breakpoint address masks

2013-04-15 Thread Jiri Olsa
On Tue, Apr 09, 2013 at 12:21:48PM -0500, Jacob Shin wrote: The following patchset adds address masks to existing perf hardware breakpoint mechanism to allow trapping on an address range (currently only single address) on supported architectures. perf uapi is updated, x86 AMD implementation

Re: [RFC/PATCH] perf: Expand definition of sysfs format attribute

2013-04-08 Thread Jiri Olsa
On Mon, Apr 08, 2013 at 09:57:50PM +1000, Michael Ellerman wrote: SNIP ISTR discussing this with Jiri at some point.. I think we ended up with being fine with overlapping ranges but having perf issue a warning (not an error) when attributes of a single event have overlap. OK great.

[PATCH 02/27] perf tools: Fix tab vs spaces issue in Makefile ifdef/endif

2013-04-01 Thread Jiri Olsa
Unmatched spaces/tabs Makefile indentation could make the Makefile fails. While the tabed line could be considered sometimes as follow up for rule command, the mixed space tab meses up with makefile if conditions. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo

[PATCH 06/27] perf tools: Move libelf check config into config/Makefile

2013-04-01 Thread Jiri Olsa
Moving libelf check config into config/Makefile. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Ingo Molnar mi...@elte.hu Cc: Paul Mackerras pau...@samba.org Cc: Corey Ashford cjash...@linux.vnet.ibm.com

[PATCH 05/27] perf tools: Move compiler and linker flags check into config/Makefile

2013-04-01 Thread Jiri Olsa
Moving compiler and linker flags check into config/Makefile. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Ingo Molnar mi...@elte.hu Cc: Paul Mackerras pau...@samba.org Cc: Corey Ashford cjash

[PATCH 09/27] perf tools: Move libaudit check config into config/Makefile

2013-04-01 Thread Jiri Olsa
Moving libaudit check config into config/Makefile. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Ingo Molnar mi...@elte.hu Cc: Paul Mackerras pau...@samba.org Cc: Corey Ashford cjash

[PATCH 04/27] perf tools: Move programs check into config/Makefile

2013-04-01 Thread Jiri Olsa
Moving programs check into config/Makefile. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Ingo Molnar mi...@elte.hu Cc: Paul Mackerras pau...@samba.org Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc

[RFC 00/27] perf tools: Build changes and kbuild support

2013-04-01 Thread Jiri Olsa
Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Ingo Molnar mi...@elte.hu Cc: Paul Mackerras pau...@samba.org Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis...@gmail.com Cc

[PATCH 12/27] perf tools: Move libperl check config into config/Makefile

2013-04-01 Thread Jiri Olsa
Moving libperl check config into config/Makefile. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Ingo Molnar mi...@elte.hu Cc: Paul Mackerras pau...@samba.org Cc: Corey Ashford cjash

[PATCH 15/27] perf tools: Move stdlib check config into config/Makefile

2013-04-01 Thread Jiri Olsa
Moving stdlib check config into config/Makefile. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Ingo Molnar mi...@elte.hu Cc: Paul Mackerras pau...@samba.org Cc: Corey Ashford cjash...@linux.vnet.ibm.com

[PATCH 16/27] perf tools: Move libnuma check config into config/Makefile

2013-04-01 Thread Jiri Olsa
Moving libnuma check config into config/Makefile Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Ingo Molnar mi...@elte.hu Cc: Paul Mackerras pau...@samba.org Cc: Corey Ashford cjash...@linux.vnet.ibm.com

[PATCH 17/27] perf tools: Move paths config into config/Makefile

2013-04-01 Thread Jiri Olsa
Moving paths config into config/Makefile. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Ingo Molnar mi...@elte.hu Cc: Paul Mackerras pau...@samba.org Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc

[PATCH 18/27] perf tools: Final touches for CHK config move

2013-04-01 Thread Jiri Olsa
Removing no longer needed ifdefs. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Ingo Molnar mi...@elte.hu Cc: Paul Mackerras pau...@samba.org Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic

[PATCH 14/27] perf tools: Move libbfd check config into config/Makefile

2013-04-01 Thread Jiri Olsa
Moving libbfd check config into config/Makefile. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Ingo Molnar mi...@elte.hu Cc: Paul Mackerras pau...@samba.org Cc: Corey Ashford cjash...@linux.vnet.ibm.com

[PATCH 23/27] kbuild: Introduce KBUILD_AUTOCONF variable for auto.conf include

2013-04-01 Thread Jiri Olsa
Introducing KBUILD_AUTOCONF variable for auto.conf include allowing to specify custom auto.conf file. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Ingo Molnar mi...@elte.hu Cc: Paul Mackerras pau

[PATCH 26/27] perf tools: Kbuild source related fixies

2013-04-01 Thread Jiri Olsa
Fixing several sources config dependencies to allow separate config builds. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Ingo Molnar mi...@elte.hu Cc: Paul Mackerras pau...@samba.org Cc: Corey Ashford

[PATCH 25/27] perf tools: Kbuild builtin source related fixies

2013-04-01 Thread Jiri Olsa
Adding CONFIG_BUILTIN_* defines to govern builtin commands. This will be usefull for kbuild process switch. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Ingo Molnar mi...@elte.hu Cc: Paul Mackerras pau

[PATCH 27/27] perf tools: Add kbuild support into Makefile.kbuild

2013-04-01 Thread Jiri Olsa
. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Ingo Molnar mi...@elte.hu Cc: Paul Mackerras pau...@samba.org Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: Frederic Weisbecker fweis...@gmail.com Cc

[PATCH 24/27] kbuild: Introduce KCONFIG_AUTOCONFIGDEP variable for conf tool

2013-04-01 Thread Jiri Olsa
Introducing KCONFIG_AUTOCONFIGDEP variable for conf tool allowing to specify custom auto.conf.cmd file. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Ingo Molnar mi...@elte.hu Cc: Paul Mackerras pau

[PATCH 22/27] perf tools: Add NO_BIONIC variable to confiure bionic setup

2013-04-01 Thread Jiri Olsa
Adding NO_BIONIC variable to confiure bionic setup Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Ingo Molnar mi...@elte.hu Cc: Paul Mackerras pau...@samba.org Cc: Corey Ashford cjash

[PATCH 13/27] perf tools: Move libpython check config into config/Makefile

2013-04-01 Thread Jiri Olsa
Moving libpython check config into config/Makefile. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Ingo Molnar mi...@elte.hu Cc: Paul Mackerras pau...@samba.org Cc: Corey Ashford cjash

[PATCH 21/27] perf tools: Switch to full patch C include directories

2013-04-01 Thread Jiri Olsa
Switching to full patch C include directories, to make the includes clear. Plus little include cleanup. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Ingo Molnar mi...@elte.hu Cc: Paul Mackerras pau

[PATCH 01/27] perf tools: Add automated make test suite

2013-04-01 Thread Jiri Olsa
tests/make MAKE_DEBUG MAKE_DEBUG: cd . make -f Makefile DEBUG=1 TEST: test -x ./perf At this moment tests checks for succesfull build and for existence of several built files. Additional after-build checks could be added. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo

[PATCH 03/27] perf tools: Move arch check into config/Makefile

2013-04-01 Thread Jiri Olsa
Moving arch check into config/Makefile. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Ingo Molnar mi...@elte.hu Cc: Paul Mackerras pau...@samba.org Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc

[PATCH 07/27] perf tools: Move libdw check config into config/Makefile

2013-04-01 Thread Jiri Olsa
Moving libdw check config into config/Makefile. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Ingo Molnar mi...@elte.hu Cc: Paul Mackerras pau...@samba.org Cc: Corey Ashford cjash...@linux.vnet.ibm.com

[PATCH 10/27] perf tools: Move slang check config into config/Makefile

2013-04-01 Thread Jiri Olsa
Moving slang check config into config/Makefile. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Ingo Molnar mi...@elte.hu Cc: Paul Mackerras pau...@samba.org Cc: Corey Ashford cjash...@linux.vnet.ibm.com

[PATCH 11/27] perf tools: Move gtk2 check config into config/Makefile

2013-04-01 Thread Jiri Olsa
Moving gtk2 check config into config/Makefile. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Ingo Molnar mi...@elte.hu Cc: Paul Mackerras pau...@samba.org Cc: Corey Ashford cjash...@linux.vnet.ibm.com

[PATCH 08/27] perf tools: Move libunwind check config into config/Makefile

2013-04-01 Thread Jiri Olsa
Moving libunwind check config into config/Makefile. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Ingo Molnar mi...@elte.hu Cc: Paul Mackerras pau...@samba.org Cc: Corey Ashford cjash

[PATCH 20/27] perf tools: Merge all *LDFLAGS* make variable into LDFLAGS

2013-04-01 Thread Jiri Olsa
Merging all *LDFLAGS* make variable into LDFLAGS to eliminate all special *LDFLAGS* variables and make the setup clear. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Ingo Molnar mi...@elte.hu Cc: Paul

[PATCH 19/27] perf tools: Merge all *CFLAGS* make variable into CFLAGS

2013-04-01 Thread Jiri Olsa
Merging all *CFLAGS* make variable into CFLAGS to eliminate all special *_CFLAGS_* variables and make the setup clear. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Ingo Molnar mi...@elte.hu Cc: Paul

Re: [PATCH 5/9] perf sort: Separate out memory-specific sort keys

2013-04-01 Thread Jiri Olsa
On Mon, Apr 01, 2013 at 08:35:21PM +0900, Namhyung Kim wrote: SNIP + int sort_dimension__add(const char *tok) { unsigned int i; @@ -964,6 +971,33 @@ int sort_dimension__add(const char *tok) return 0; } + for (i = 0; i

Re: [PATCH 6/9] perf sort: Add 'addr' sort key

2013-04-01 Thread Jiri Olsa
On Mon, Apr 01, 2013 at 08:35:22PM +0900, Namhyung Kim wrote: From: Namhyung Kim namhyung@lge.com New addr sort key provides a way to sort the entries by the symbol addresses. It can be helpful to figure out symbol resolution problem when a dso cannot do it properly as well as finding

Re: [PATCH 27/27] perf tools: Add kbuild support into Makefile.kbuild

2013-04-01 Thread Jiri Olsa
On Mon, Apr 01, 2013 at 10:03:42PM +0200, Sam Ravnborg wrote: On Mon, Apr 01, 2013 at 09:18:50PM +0200, Jiri Olsa wrote: Adding kbuild support into Makefile.kbuild. The 'legacy' Makefile still stays untouched as it was. When readign the Kbuild file I get confused. the obj-y syntax is used

Re: [PATCH 03/27] perf tools: Move arch check into config/Makefile

2013-04-01 Thread Jiri Olsa
On Mon, Apr 01, 2013 at 09:54:46PM +0200, Sam Ravnborg wrote: SNIP diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile new file mode 100644 index 000..fe317c2 --- /dev/null +++ b/tools/perf/config/Makefile @@ -0,0 +1,34 @@ +uname_M := $(shell uname -m

Re: [PATCH 01/27] perf tools: Add automated make test suite

2013-04-01 Thread Jiri Olsa
On Mon, Apr 01, 2013 at 09:53:18PM +0200, Sam Ravnborg wrote: SNIP + +MAKE_DEBUG := DEBUG=1 +MAKE_NO_LIBPERL := NO_LIBPERL=1 Why all these ugly UPPERCASE names? In kbuild files the unwritten rule is that variables with global scope are upper-case. And variables with

Re: [PATCH 02/27] perf tools: Fix tab vs spaces issue in Makefile ifdef/endif

2013-04-01 Thread Jiri Olsa
On Mon, Apr 01, 2013 at 09:49:05PM +0200, Sam Ravnborg wrote: On Mon, Apr 01, 2013 at 09:18:25PM +0200, Jiri Olsa wrote: Unmatched spaces/tabs Makefile indentation could make the Makefile fails. While the tabed line could be considered sometimes as follow up for rule command, the mixed

Re: [RFC 00/27] perf tools: Build changes and kbuild support

2013-04-01 Thread Jiri Olsa
On Mon, Apr 01, 2013 at 02:45:09PM -0600, David Ahern wrote: Hi Jiri: On 4/1/13 1:18 PM, Jiri Olsa wrote: hi, sending RFC for build changes and kbuild support. Have you seen this patch set: https://lkml.org/lkml/2012/8/20/59 yep, I remember checking it.. but I decided to start over

<    1   2   3   4   5   6   7   8   9   10   >