han add an explosion of arches to the #ifdef, switch to an
alternate method to calculate the physical start of highmem using
the page before highmem starts. This avoids the need for the #ifdef and
extra __pa_nodebug calls.
Signed-off-by: Laura Abbott
---
mm/cma.c | 15 +--
1 file changed, 5
its bounds check based on the entire possible image space which is well
beyond where _end would end up.
There are a few dependencies outside of arm64, so I don't know if
it will be easier for this to eventually go through arm64 or the mm tree.
Thanks,
Laura
Laura Abbott (6):
lib/Kconfig.
On 10/29/2016 02:39 AM, Ard Biesheuvel wrote:
On 28 October 2016 at 23:07, Laura Abbott wrote:
diff --git a/arch/arm64/mm/physaddr.c b/arch/arm64/mm/physaddr.c
new file mode 100644
index 000..6c271e2
--- /dev/null
+++ b/arch/arm64/mm/physaddr.c
@@ -0,0 +1,17 @@
+#include
+
+#include
On 10/29/2016 02:08 PM, Linus Torvalds wrote:
On Mon, Oct 24, 2016 at 5:06 PM, Linus Torvalds
wrote:
Then I could just enable "--binary" and "-M", and see what happens.
Let's see what happens with 4.9-rc3. Will anybody notice? Did I do it right?
Linus
'git apply' works at le
diff --git a/arch/arm64/mm/physaddr.c b/arch/arm64/mm/physaddr.c
new file mode 100644
index 000..6c271e2
--- /dev/null
+++ b/arch/arm64/mm/physaddr.c
@@ -0,0 +1,17 @@
+#include
+
+#include
+
+unsigned long __virt_to_phys(unsigned long x)
+{
+phys_addr_t __x = (phys_addr_t)x;
+
+if (_
On 10/28/2016 07:49 AM, Mark Rutland wrote:
Hi Laura,
On Thu, Oct 27, 2016 at 05:18:12PM -0700, Laura Abbott wrote:
x86 has an option CONFIG_DEBUG_VIRTUAL to do additional checks
on virt_to_phys calls. The goal is to catch users who are calling
virt_to_phys on non-linear addresses immediately
On 10/28/2016 12:52 AM, Ard Biesheuvel wrote:
Hi Laura,
On 28 October 2016 at 01:18, Laura Abbott wrote:
x86 has an option CONFIG_DEBUG_VIRTUAL to do additional checks
on virt_to_phys calls. The goal is to catch users who are calling
virt_to_phys on non-linear addresses immediately. As
debugging so just drop the call to __pa on the ioremapped
address.
Fixes: 6ae5fd381251 ("clk: xgene: Silence sparse warnings")
Signed-off-by: Laura Abbott
---
v2: Fix up one more format string
I put the fixes tag to match with the cleanup that was done.
If there is interest in this fix f
ioremapped
address.
Fixes: 6ae5fd381251 ("clk: xgene: Silence sparse warnings")
Signed-off-by: Laura Abbott
---
v2: Fix up one more format string
I put the fixes tag to match with the cleanup that was done.
If there is interest in this fix for pre-4.2 kernels for
stable, I can submit a patc
bad virt_to_phys
usage.
Signed-off-by: Laura Abbott
---
This has been on my TODO list for a while. It caught a few bugs with
CONFIG_VMAP_STACK on x86 so when that eventually gets added
for arm64 it will be useful to have. This caught one driver calling __pa on an
ioremapped address already. RFC for
On 10/27/2016 04:21 PM, Laura Abbott wrote:
ioremaped addresses are not linearly mapped so the physical
address can not be figured out via __pa. More generally, there
is no guarantee that backing value of an ioremapped address
is a physical address at all. The value here is only used
for
ioremapped
address.
Signed-off-by: Laura Abbott
---
Found while working on virt_to_phys debugging for arm64
---
drivers/clk/clk-xgene.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/clk/clk-xgene.c b/drivers/clk/clk-xgene.c
index 3433132..4697bf9 100644
--- a
Tested-by: Mark Rutland
Signed-off-by: Laura Abbott
---
v4: Reviewed-by from Ard
---
arch/arm64/Kconfig.debug | 6 +-
arch/arm64/include/asm/ptdump.h| 15 +--
arch/arm64/mm/Makefile | 3 ++-
arch/arm64/mm/dump.c | 26
rk Rutland
Signed-off-by: Laura Abbott
---
v4: Changed pr_info -> pr_warn. Added a separate count variable for uxn to avoid
double counting.
---
arch/arm64/Kconfig.debug| 29 ++
arch/arm64/include/asm/ptdump.h | 8 +++
arch/arm64/mm/dump.c
Hi,
This is v4 of the implementation to check for writable and executable pages on
arm64. This version contains a review from Ard and makes the UXN page count
a separate variable. Overall, minor changes.
Thanks,
Laura
Laura Abbott (4):
arm64: dump: Make ptdump debugfs a separate option
max_addr was added as part of struct ptdump_info but has never actually
been used. Remove it.
Reviewed-by: Kees Cook
Reviewed-by: Mark Rutland
Tested-by: Mark Rutland
Signed-off-by: Laura Abbott
---
v4: No changes
---
arch/arm64/include/asm/ptdump.h | 1 -
1 file changed, 1 deletion
: Mark Rutland
Acked-by: Mark Rutland
Signed-off-by: Laura Abbott
---
v4: No changes
---
arch/arm64/mm/dump.c | 26 +++---
1 file changed, 19 insertions(+), 7 deletions(-)
diff --git a/arch/arm64/mm/dump.c b/arch/arm64/mm/dump.c
index f0f0be7..bb36649 100644
--- a/arch/arm64
On 10/26/2016 04:34 PM, Linus Torvalds wrote:
On Wed, Oct 26, 2016 at 3:55 PM, Laura Abbott wrote:
I was playing around with overflowing stacks and I managed to generate a
test
case that hung the kernel with vmapped stacks. The test case is just
static void noinline foo1(void
On 10/26/2016 08:05 AM, Benjamin Gaignard wrote:
2016-10-26 16:44 GMT+02:00 Sumit Semwal :
On 26 October 2016 at 20:11, Benjamin Gaignard
wrote:
2016-10-26 15:51 GMT+02:00 Sumit Semwal :
Hello Benjamin,
On 26 October 2016 at 19:02, Benjamin Gaignard
wrote:
It is more or less a copy of Hisi
Hi,
I was playing around with overflowing stacks and I managed to generate a test
case that hung the kernel with vmapped stacks. The test case is just
static void noinline foo1(void)
{
pr_info("%p\n", (void *)current_stack_pointer());
foo2();
}
where foo$n is the same function wit
On 10/20/2016 05:03 AM, Matt Fleming wrote:
On Wed, 19 Oct, at 02:13:00PM, Laura Abbott wrote:
On 10/19/2016 01:04 PM, Laura Abbott wrote:
Hi,
Fedora received a bug report https://bugzilla.redhat.com/show_bug.cgi?id=1384238
of a bootup failure with stable 4.7.6. efi=noruntime fixed the bootup
On 10/20/2016 03:32 AM, Ard Biesheuvel wrote:
On 18 October 2016 at 23:01, Laura Abbott wrote:
Page mappings with full RWX permissions are a security risk. x86
has an option to walk the page tables and dump any bad pages.
(See e1a58320a38d ("x86/mm: Warn on W^X mappings")). Add
he correct return value in cpufreq-set.
See https://bugzilla.redhat.com/show_bug.cgi?id=1374212
Fixes: ac5a181d065d ("cpupower: Add cpuidle parts into library")
Reported-by: Julian Seward
Signed-off-by: Laura Abbott
---
v2: Drop another redundant cpupower_is_cpu_online
Resend becaus
On 10/19/2016 01:04 PM, Laura Abbott wrote:
Hi,
Fedora received a bug report https://bugzilla.redhat.com/show_bug.cgi?id=1384238
of a bootup failure with stable 4.7.6. efi=noruntime fixed the bootup problem.
1297667083d5442aafe3e337b9413bf02b114edb was linked as the cause
of the problem.
x86
Hi,
Fedora received a bug report https://bugzilla.redhat.com/show_bug.cgi?id=1384238
of a bootup failure with stable 4.7.6. efi=noruntime fixed the bootup problem.
1297667083d5442aafe3e337b9413bf02b114edb was linked as the cause
of the problem.
x86/efi: Only map RAM into EFI page tables if in m
-off-by: Laura Abbott
---
v3: Minor header guard fixup.
Mark Rutland pointed out that this needs to be reviewed by the EFI maintainers
so I'm explicitly adding appropriate people/lists.
---
arch/arm64/Kconfig.debug | 6 +-
arch/arm64/include/asm/ptdump.h| 15 +--
: Mark Rutland
Acked-by: Mark Rutland
Signed-off-by: Laura Abbott
---
v3: No changes
---
arch/arm64/mm/dump.c | 26 +++---
1 file changed, 19 insertions(+), 7 deletions(-)
diff --git a/arch/arm64/mm/dump.c b/arch/arm64/mm/dump.c
index f0f0be7..bb36649 100644
--- a/arch/arm64
rk Rutland
Signed-off-by: Laura Abbott
---
v3: Rebased for header guard fixup, whitespace fixes
---
arch/arm64/Kconfig.debug| 29 +++
arch/arm64/include/asm/ptdump.h | 8 +++
arch/arm64/mm/dump.c| 52 +
arch/arm6
max_addr was added as part of struct ptdump_info but has never actually
been used. Remove it.
Reviewed-by: Kees Cook
Reviewed-by: Mark Rutland
Tested-by: Mark Rutland
Signed-off-by: Laura Abbott
---
v3: No changes
---
arch/arm64/include/asm/ptdump.h | 1 -
1 file changed, 1 deletion
Hi,
This is v3 of the implementation to check for writable and executable pages on
arm64. This is a basically a rebase + acks.
Laura Abbott (4):
arm64: dump: Make ptdump debugfs a separate option
arm64: dump: Make the page table dumping seq_file optional
arm64: dump: Remove max_addr
Aside from one issue below, this looks good to me.
On Wed, Oct 12, 2016 at 03:31:59PM -0700, Laura Abbott wrote:
diff --git a/arch/arm64/include/asm/ptdump.h b/arch/arm64/include/asm/ptdump.h
index 07b8ed0..7c35689 100644
--- a/arch/arm64/include/asm/ptdump.h
+++ b/arch/arm64/include/asm/ptdump.h
@@
Hi,
Some of the files in documentation are binary (pdfs/jpg/png etc.)
and do not play nicely with patches
$ curl -s https://cdn.kernel.org/pub/linux/kernel/v4.x/testing/patch-4.9-rc1.xz | xzcat |
grep "Binary files"
Binary files a/Documentation/media/media_api_files/typical_media_device.pdf and
On 10/10/2016 07:31 PM, ming.ling wrote:
From: Ming Ling
So far some ion heaps such as carveout_heap, chunk_heap,
system_heap have freed buffers asynchrounously. Freed buffers
are placed on a free list and freed from a low priority background
thread. If allocations from a particular heap fail,
On 10/12/2016 03:45 PM, Kees Cook wrote:
On Wed, Oct 12, 2016 at 3:31 PM, Laura Abbott wrote:
ptdump_register currently initializes a set of page table information and
registers debugfs. There are uses for the ptdump option without wanting the
debugfs options. Split this out to make it a
Page mappings with full RWX permissions are a security risk. x86
has an option to walk the page tables and dump any bad pages.
(See e1a58320a38d ("x86/mm: Warn on W^X mappings")). Add a similar
implementation for arm64.
Signed-off-by: Laura Abbott
---
v2: Check only init_mm, style cle
The page table dumping code always assumes it will be dumping to a
seq_file to userspace. Future code will be taking advantage of
the page table dumping code but will not need the seq_file. Make
the seq_file optional for these cases.
Acked-by: Mark Rutland
Signed-off-by: Laura Abbott
---
v2
max_addr was added as part of struct ptdump_info but has never actually
been used. Remove it.
Signed-off-by: Laura Abbott
---
New for v2 of the series
---
arch/arm64/include/asm/ptdump.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/include/asm/ptdump.h b/arch/arm64/include/asm
ptdump_register currently initializes a set of page table information and
registers debugfs. There are uses for the ptdump option without wanting the
debugfs options. Split this out to make it a separate option.
Signed-off-by: Laura Abbott
---
v2: Minor style fixups per Mark Rutland
Rutland.
Laura Abbott (4):
arm64: dump: Make ptdump debugfs a separate option
arm64: dump: Make the page table dumping seq_file optional
arm64: dump: Remove max_addr
arm64: dump: Add checking for writable and exectuable pages
arch/arm64/Kconfig.debug | 34 ++-
arch
On 10/12/2016 03:12 AM, Jiri Olsa wrote:
On Tue, Oct 11, 2016 at 02:18:49PM -0700, Laura Abbott wrote:
On 10/11/2016 01:59 PM, Jiri Olsa wrote:
On Tue, Oct 11, 2016 at 01:43:36PM -0700, Laura Abbott wrote:
Hi,
While building today's Fedora rawhide kernel, there was a failure
building
Hi,
While building today's Fedora rawhide kernel, there was a failure
building perf with -j4 [1]:
gcc -Wp,-MD,./.plugin_scsi.o.d,-MT,plugin_scsi.o -O2 -g -pipe -Wall -Werror=format-security
-Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4
-grecord-gcc-
debug driver removal. The text can be
changed later when more drivers are fixed up.
Signed-off-by: Laura Abbott
---
drivers/base/Kconfig | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/base/Kconfig b/drivers/base/Kconfig
index fdf44ca..d02e7c0 100644
--- a/drivers
On 10/06/2016 09:06 PM, Rob Herring wrote:
On Thu, Oct 6, 2016 at 6:53 PM, Laura Abbott wrote:
On a whim, I decided to turn on CONFIG_DEBUG_TEST_DRIVER_REMOVE on
Fedora rawhide since it sounded harmless enough. It spewed warnings
and panicked some systems. Clearly it's doing its job
we
On 10/06/2016 08:56 PM, Greg Kroah-Hartman wrote:
On Thu, Oct 06, 2016 at 04:53:20PM -0700, Laura Abbott wrote:
On a whim, I decided to turn on CONFIG_DEBUG_TEST_DRIVER_REMOVE on
Fedora rawhide since it sounded harmless enough. It spewed warnings
and panicked some systems. Clearly it's
On a whim, I decided to turn on CONFIG_DEBUG_TEST_DRIVER_REMOVE on
Fedora rawhide since it sounded harmless enough. It spewed warnings
and panicked some systems. Clearly it's doing its job
well of finding drivers that can't handle remove properly and I
underestimated it. I was expecting to maybe
An extra entry for MDIO_XGENE got added during merging.
Delete it.
Reviewed-by: Andrew Lunn
Signed-off-by: Laura Abbott
---
drivers/net/phy/Kconfig | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig
index 5078a0d
Hi,
While working on the Fedora tree today, I noticed that there
seem to be two entries for CONFIG_MDIO_XGENE. It looks like
this might have been fall out from d75b4a22b255 ("net: phy:
Sort Makefile and Kconfig"). I can submit the following if
this isn't fixed up elsewhere already
diff --git a/d
On 09/30/2016 01:18 AM, Xu YiPing wrote:
ion_alloc may get into slow path to get free page,
the call stack:
__alloc_pages_slowpath
ion_page_pool_alloc_pages
alloc_buffer_page
ion_system_heap_allocate
ion_buffer_create <-- hold ion_device->lock
ion_alloc
after that, kernel invokes low-memory ki
On 09/29/2016 05:48 PM, Mark Rutland wrote:
On Thu, Sep 29, 2016 at 05:31:09PM -0700, Laura Abbott wrote:
On 09/29/2016 05:13 PM, Mark Rutland wrote:
On Thu, Sep 29, 2016 at 02:32:55PM -0700, Laura Abbott wrote:
+int ptdump_register(struct ptdump_info *info, const char *name
On 09/29/2016 05:13 PM, Mark Rutland wrote:
Hi,
On Thu, Sep 29, 2016 at 02:32:55PM -0700, Laura Abbott wrote:
ptdump_register currently initializes a set of page table information and
registers debugfs. There are uses for the ptdump option without wanting the
debugfs options. Split this out to
Page mappings with full RWX permissions are a security risk. x86
has an option to walk the page tables and dump any bad pages.
(See e1a58320a38d ("x86/mm: Warn on W^X mappings")). Add a similar
implementation for arm64.
Signed-off-by: Laura Abbott
---
arch/arm64/Kconfig.debug
The page table dumping code always assumes it will be dumping to a
seq_file to userspace. The dumping code is useful in other situations.
Let the seq_file be optional.
Signed-off-by: Laura Abbott
---
arch/arm64/mm/dump.c | 26 +++---
1 file changed, 19 insertions(+), 7
ptdump_register currently initializes a set of page table information and
registers debugfs. There are uses for the ptdump option without wanting the
debugfs options. Split this out to make it a separate option.
Signed-off-by: Laura Abbott
---
arch/arm64/Kconfig.debug| 6 +-
arch
now though.
- Once this is merged, I'd like to see about moving DEBUG_WX to the top level
instead of having each arch call it in mark_rodata.
Laura Abbott (3):
arm64: dump: Make ptdump debugfs a separate option
arm64: dump: Make the page table dumping seq_file optional
arm64: dump: A
On 09/23/2016 11:03 AM, Antti Keränen wrote:
This patch fixes the alignment of an allocation flag block comment
and moves the comments before each #define.
Acked-by: Laura Abbott
Signed-off-by: Antti Keränen
---
In addition to fixing the alignment issue, this version of the patch moves
he correct return value in cpufreq-set.
See https://bugzilla.redhat.com/show_bug.cgi?id=1374212
Fixes: ac5a181d065d ("cpupower: Add cpuidle parts into library")
Reported-by: Julian Seward
Signed-off-by: Laura Abbott
---
v2: Drop another redundant cpupower_is_cpu_online
---
tools/
pe for
'ion_setup_heap_common' [-Wmissing-prototypes]
In fact, these functions are only used in the file in which they are
declared and don't need a declaration, but can be made static.
so this patch marks these functions with 'static'.
Acked-by: Laura Abbott
Sign
On 09/22/2016 08:59 AM, Antti Keränen wrote:
Correctly align an unaligned block comment
Signed-off-by: Antti Keränen
---
drivers/staging/android/uapi/ion.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/android/uapi/ion.h
b/drivers/staging/android/uapi/ion
);
The patch looks fine though so assuming nothing else has
changed
Acked-by: Laura Abbott
[] worker_thread+0x9c/0x73c
[] kthread+0x138/0x154
[] ret_from_fork+0x10/0x40
The packet is being accessed for statistics after it has been freed.
Save the packet type before sending for statistics afterwards.
Signed-off-by: Laura Abbott
---
Originally found and tested on 4.4 based branch.
---
drivers
ix this by only performing the pfn_valid check on addresses that
have the potential to be valid.
Acked-by: Mark Rutland
Signed-off-by: Laura Abbott
---
v2: Properly parenthesize macro arguments. Re-factor to common macro.
Also in case it wasn't clear, there's no need to try and s
On 09/21/2016 10:58 AM, Mark Rutland wrote:
Hi,
On Wed, Sep 21, 2016 at 10:28:48AM -0700, Laura Abbott wrote:
virt_addr_valid is supposed to return true if and only if virt_to_page
returns a valid page structure. The current macro does math on whatever
address is given and passes that to
On 09/21/2016 10:28 AM, Laura Abbott wrote:
virt_addr_valid is supposed to return true if and only if virt_to_page
returns a valid page structure. The current macro does math on whatever
address is given and passes that to pfn_valid to verify. vmalloc and
module addresses can happen to generate
ix this by only performing the pfn_valid check on addresses that
have the potential to be valid.
Signed-off-by: Laura Abbott
---
This caused a bug at least twice in hardened usercopy so it is an
actual problem. A further TODO is full DEBUG_VIRTUAL support to
catch these types of mistakes.
---
On 09/20/2016 04:01 PM, Kees Cook wrote:
On Tue, Sep 20, 2016 at 8:56 AM, Laura Abbott wrote:
While running a compile on arm64, I hit a memory exposure
usercopy: kernel memory exposure attempt detected from fcf3b1a8
(buffer_head) (1 bytes)
[ cut here ]
kernel
On 09/15/2016 06:49 AM, Mark Rutland wrote:
Building atop of Andy's work on x86 and generic code, these patches move
arm64's thread_info off of the stack and into task_struct. This protects
thread_info from corruption in the face of stack overflow, and serves as
a step towards fully robust stack
a module address. Modules may have compiled in
strings which could get copied to userspace. In this instance, it
looks like "." which matches with a size of 1 byte. Extend the
is_vmalloc_addr check to be is_vmalloc_or_module_addr to cover
all possible cases.
Signed-off-by: Laura Abbott
On 09/19/2016 10:36 AM, Brent DeGraaf wrote:
According to section 6.3.8 of the ARM Programmer's Guide, non-temporal
loads and stores do not verify that address dependency is met between a
load of an address to a register and a subsequent non-temporal load or
store using that address on the execut
On 09/16/2016 10:46 AM, Linus Torvalds wrote:
On Fri, Sep 16, 2016 at 8:16 AM, Laura Abbott wrote:
Fedora received a bug report[1] after pushing 4.7.2 that named
was segfaulting with named-chroot. With some help (thank you
tibbs!), it was noted that on older kernels named was spitting
out
Hi,
Fedora received a bug report[1] after pushing 4.7.2 that named
was segfaulting with named-chroot. With some help (thank you
tibbs!), it was noted that on older kernels named was spitting
out
mmap: named (671): VmData 27566080 exceed data ulimit 23068672.
Will be forbidden soon.
and with f4f
On 09/14/2016 07:20 PM, Wei Yongjun wrote:
From: Wei Yongjun
In case of error, the function ion_device_create() returns ERR_PTR() and
never returns NULL. The NULL test in the return value check should be
replaced with IS_ERR().
Acked-by: Laura Abbott
Signed-off-by: Wei Yongjun
_data'
This selects the symbol when needed.
Acked-by: Laura Abbott
Signed-off-by: Arnd Bergmann
Fixes: 2b40182a19bc ("staging: android: ion: Add ion driver for Hi6220 SoC
platform")
---
drivers/staging/android/ion/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/dri
ce to `of_platform_device_create'
Add a dependency on OF_ADDRESS
Reported-by: Guenter Roeck
Signed-off-by: Laura Abbott
---
Based on next-20160914
---
drivers/staging/android/ion/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/android/ion/Kconfig
b/drive
On 09/13/2016 08:14 AM, Will Deacon wrote:
On Tue, Sep 13, 2016 at 08:02:20AM -0700, Laura Abbott wrote:
On 09/13/2016 02:19 AM, Will Deacon wrote:
On Mon, Sep 12, 2016 at 02:32:56PM -0700, Laura Abbott wrote:
arm64 may need to guarantee the caches are synced. Implement versions of
the
On 09/13/2016 02:19 AM, Will Deacon wrote:
Hi Laura,
On Mon, Sep 12, 2016 at 02:32:56PM -0700, Laura Abbott wrote:
arm64 may need to guarantee the caches are synced. Implement versions of
the kernel_force_cache API to allow this.
Signed-off-by: Laura Abbott
---
v3: Switch to calling cache
arm64 may need to guarantee the caches are synced. Implement versions of
the kernel_force_cache API to allow this.
Signed-off-by: Laura Abbott
---
v3: Switch to calling cache operations directly instead of relying on
DMA mapping.
---
arch/arm64/include/asm/cacheflush.h | 8
arch
arm64 may need to guarantee the caches are synced. Implement
versions of the kernel_force_cache API for v7. Other versions
are stubbed out and can be added as appropriate.
Signed-off-by: Laura Abbott
---
v3: Switch to force implementations per CPU instead of relying
on dma_map/dma_unmap. v7 is
Now that there exists a proper set of cache sync APIs, move away
from the dma_sync and do less bad things.
Signed-off-by: Laura Abbott
---
v3: Rebased to latest-next
---
drivers/staging/android/ion/ion.c | 22 --
drivers/staging/android/ion/ion_carveout_heap.c
dma_buf added support for a userspace syncing ioctl. It is implemented
by calling dma_buf_begin_cpu_access and dma_buf_end_cpu_access. Ion
currently lacks cache operations on this code path. Add them for
compatibility with the dma_buf ioctl.
Signed-off-by: Laura Abbott
---
drivers/staging
Some frameworks (e.g. Ion) may need to do explicit cache management
to meet performance/correctness requirements. Rather than piggy-back
on another API and hope the semantics don't change, introduce a
set of APIs to force a page to be cleaned/invalidated in the cache.
Signed-off-by: Laura A
pen'
to do the right thing but they aren't guaranteed.
I'm hoping at v3 there are no objections to the general concept but if they
exist please express them.
Thanks,
Laura
[1]http://www.mail-archive.com/driverdev-devel@linuxdriverproject.org/msg49406.html
Laura Abbott (5):
On 09/10/2016 08:01 AM, Jonathan Cameron wrote:
On 09/09/16 16:47, Laura Abbott wrote:
On 09/09/2016 08:35 AM, Daniel Baluta wrote:
On Fri, Sep 9, 2016 at 6:24 PM, Laura Abbott wrote:
The iio tools have been updated as new event types have been added to
the kernel. The tools currently use
he correct return value in cpufreq-set.
See https://bugzilla.redhat.com/show_bug.cgi?id=1374212
Fixes: ac5a181d065d ("cpupower: Add cpuidle parts into library")
Reported-by: Julian Seward
Signed-off-by: Laura Abbott
---
tools/power/cpupower/utils/cpufreq-set.c | 4 ++--
1 file changed
On 09/09/2016 08:35 AM, Daniel Baluta wrote:
On Fri, Sep 9, 2016 at 6:24 PM, Laura Abbott wrote:
The iio tools have been updated as new event types have been added to
the kernel. The tools currently use the standard system headers which
means that the system may not have the newest
.c:97:3: note: (near initialization for
‘iio_modifier_names’)
: recipe for target 'iio_event_monitor.o' failed
Switch to using the header from the kernel tree to ensure the newest
defintions are always picked up.
Signed-off-by: Laura Abbott
---
tools/iio/iio_event_monitor.c | 2 +-
1 f
On 09/07/2016 12:37 PM, Arnd Bergmann wrote:
On Wednesday, September 7, 2016 11:49:59 AM CEST Laura Abbott wrote:
- if (dir & _IOC_WRITE)
- if (copy_from_user(&data, (void __user *)arg, _IOC_SIZE(cmd)))
- return -EFAULT;
+ /*
+
The number of Ion ioctls may continue to grow along with necessary
validation. Pull it out into a separate file for easier management
and review.
Signed-off-by: Laura Abbott
---
v3: Rebase to staging-next
---
drivers/staging/android/ion/Makefile| 3 +-
drivers/staging/android/ion/ion
about
ion_dummy cleanup but I've decided to have that be a separate patch.
Laura Abbott (2):
staging: android: ion: Pull out ion ioctls to a separate file
staging: android: ion: Add ioctl to query available heaps
drivers/staging/android/ion/Makefile| 3 +-
drivers/staging/android/io
Ion clients currently lack a good method to determine what
heaps are available and what ids they map to. This leads
to tight coupling between user and kernel space and headaches.
Add a query ioctl to let userspace know the availability of
heaps.
Signed-off-by: Laura Abbott
---
v3: Include some
On 09/05/2016 04:20 AM, Brian Starkey wrote:
Hi,
On Fri, Sep 02, 2016 at 12:36:25PM -0700, Laura Abbott wrote:
On 09/02/2016 06:41 AM, Brian Starkey wrote:
Hi Laura,
On Thu, Sep 01, 2016 at 03:40:41PM -0700, Laura Abbott wrote:
There is no advantage to having heap types be a mask. The ion
* may generate a warning on 32-bit systems about a cast
from an integer to a pointer of different size. There is a macro to
deal with this which hides an ugly double cast. Add a reference to
this macro.
Signed-off-by: Laura Abbott
---
I can split these into two separate patches if necessary
On 09/02/2016 02:33 PM, Arnd Bergmann wrote:
On Friday, September 2, 2016 1:33:44 PM CEST Laura Abbott wrote:
On 09/02/2016 02:02 AM, Arnd Bergmann wrote:
On Thursday, September 1, 2016 3:40:43 PM CEST Laura Abbott wrote:
--- a/drivers/staging/android/ion/ion-ioctl.c
+++ b/drivers/staging
On 09/02/2016 02:37 PM, Arnd Bergmann wrote:
On Friday, September 2, 2016 2:27:21 PM CEST Laura Abbott wrote:
All warnings (new ones prefixed by >>):
drivers/staging/android/ion/ion.c: In function 'ion_query_heaps':
drivers/staging/android/ion/ion.c:1181:3: warning: cast
git(>=2.9.0) format-patch --base= (or --base=auto for
convenience) to record what (public, well-known) commit your patch series was built on]
[Check https://git-scm.com/docs/git-format-patch for more information]
url:
https://github.com/0day-ci/linux/commits/Laura-Abbott/staging-android-
On 09/01/2016 11:14 PM, Greg Kroah-Hartman wrote:
On Thu, Sep 01, 2016 at 03:40:44PM -0700, Laura Abbott wrote:
Ion clients currently lack a good method to determine what
heaps are available and what ids they map to. This leads
to tight coupling between user and kernel space and headaches.
Add
On 09/02/2016 02:02 AM, Arnd Bergmann wrote:
On Thursday, September 1, 2016 3:40:43 PM CEST Laura Abbott wrote:
--- a/drivers/staging/android/ion/ion-ioctl.c
+++ b/drivers/staging/android/ion/ion-ioctl.c
@@ -22,6 +22,29 @@
#include "ion_priv.h"
#include "compat_ion.h"
On 09/01/2016 11:10 PM, Greg Kroah-Hartman wrote:
On Thu, Sep 01, 2016 at 03:40:43PM -0700, Laura Abbott wrote:
The current Ion ioctls lack a good way to tell what ioctls are
available. Introduce an ioctl to give an ABI version. This way when the
ABI inevitably gets screwed up userspace will
On 09/02/2016 05:44 AM, Greg Kroah-Hartman wrote:
On Thu, Sep 01, 2016 at 03:40:42PM -0700, Laura Abbott wrote:
The number of Ion ioctls may continue to grow along with necessary
validation. Pull it out into a separate file for easier management
and review.
Signed-off-by: Laura Abbott
On 09/02/2016 06:41 AM, Brian Starkey wrote:
Hi Laura,
On Thu, Sep 01, 2016 at 03:40:41PM -0700, Laura Abbott wrote:
There is no advantage to having heap types be a mask. The ion client has
long since dropped the mask. Drop the notion of heap type masks as well.
I know this is the same
There is no advantage to having heap types be a mask. The ion client has
long since dropped the mask. Drop the notion of heap type masks as well.
Signed-off-by: Laura Abbott
---
drivers/staging/android/uapi/ion.h | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/android
801 - 900 of 1476 matches
Mail list logo
