Hi,
On Mon, Mar 25, 2013 at 03:41:35PM +0530, Viresh Kumar wrote:
This patch moves cpufreq driver of ARM based imx platform to drivers/cpufreq.
I sent a patch that removes imx-cpufreq which was applied by Shawn:
http://lists.infradead.org/pipermail/linux-arm-kernel/2013-March/158497.html
No DMA of-function alters the name, so this patch changes the name arguments
to be constant. Most drivers will probably request DMA channels using a
constant name.
Signed-off-by: Markus Pargmann m...@pengutronix.de
---
drivers/dma/dmaengine.c | 2 +-
drivers/dma/of-dma.c | 6
continued until the kernel had no memory left. This is a
special situation but there are many drivers that overwrite the of_node
property in their probe function. So they can actually match with a
different driver on the second or third probe attempt.
Regards,
Markus Pargmann
--
Pengutronix e.K
On Fri, Sep 13, 2013 at 10:10:46AM -0700, Greg Kroah-Hartman wrote:
On Fri, Sep 13, 2013 at 05:53:31PM +0200, Markus Pargmann wrote:
Hi,
I ran into a serious problem with overwriting device of_node property as
it is done in many drivers for ARM. If probing fails in such a
situation
On Sat, Sep 14, 2013 at 01:28:09PM +0100, Russell King - ARM Linux wrote:
On Sat, Sep 14, 2013 at 05:17:29AM -0700, Greg Kroah-Hartman wrote:
On Sat, Sep 14, 2013 at 09:16:53AM +0200, Markus Pargmann wrote:
3. We could fix up all drivers that change the of_node. But there are
ARM DT
On Sat, Sep 14, 2013 at 12:20:56PM +0100, Russell King - ARM Linux wrote:
On Sat, Sep 14, 2013 at 09:16:53AM +0200, Markus Pargmann wrote:
I think there are three options to solve this:
1. Break out of the driver list iteration loop as soon as a driver probe
function fails. This way
-by: Jan Luebbe j...@pengutronix.de
Signed-off-by: Markus Pargmann m...@pengutronix.de
---
drivers/misc/eeprom/at25.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/misc/eeprom/at25.c b/drivers/misc/eeprom/at25.c
index 840b359..4f3bca1 100644
--- a/drivers/misc/eeprom/at25.c
+++ b
Hi Fabio,
On Mon, Feb 24, 2014 at 02:23:50PM -0300, Fabio Estevam wrote:
On Sun, Feb 23, 2014 at 2:12 AM, Mark Brown broo...@kernel.org wrote:
On Thu, Feb 20, 2014 at 05:36:02PM +0100, Markus Pargmann wrote:
Hi,
These two patches replace all ops-enable/disable by
_regulator_do_disable
Regulator dummy does not have any enable operations. So it is always_on.
Signed-off-by: Markus Pargmann m...@pengutronix.de
---
drivers/regulator/dummy.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/regulator/dummy.c b/drivers/regulator/dummy.c
index df9f425
Hi,
The second patch adds a check for dummy regulators that are not always_on. The
first patch adds a always_on constraint to the dummy regulator.
Regards,
Markus
Markus Pargmann (2):
regulator: dummy: Should be always-on
regulator: core: Error on not always_on dummy regulators
drivers
not be enabled.
Signed-off-by: Markus Pargmann m...@pengutronix.de
---
drivers/regulator/core.c | 27 ---
1 file changed, 24 insertions(+), 3 deletions(-)
diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index 6f71985..cb10faf 100644
--- a/drivers/regulator
() for always-on
regulator.
This patch seperates _regulator_do_enable_no_delay from the
_regulator_do_enable function to be able to call the enable function
without delays. It then fixes the always_on behaviour by using this
function.
Cc: sta...@vger.kernel.org
Signed-off-by: Markus Pargmann m
On Tue, Feb 18, 2014 at 09:14:20AM +0900, Mark Brown wrote:
On Sun, Feb 16, 2014 at 08:00:56PM +0100, Markus Pargmann wrote:
Please use more standard subject lines, don't do things like core
bugfix, just write a normal changelog.
Okay, will fix.
+static int _regulator_do_enable_no_delay
Hi,
These two patches replace all ops-enable/disable by
_regulator_do_disable/enable function calls. These wrappers also handle gpio
regulators.
v2 enables all regulators with delays and I added a patch to fix all direct
disable calls.
Regards,
Markus
Markus Pargmann (2):
regulator: core
-on and always-on gpio regulators are not
enabled on registration.
This patch replaces all ops-enable calls by _regulator_do_enable.
Cc: sta...@vger.kernel.org # 3.10+
Signed-off-by: Markus Pargmann m...@pengutronix.de
---
drivers/regulator/core.c | 12 ++--
1 file changed, 6 insertions(+), 6
There are many places where ops-disable is called directly. Instead we
should use _regulator_do_disable() which also handles gpio regulators.
Cc: sta...@vger.kernel.org # 3.10+
Signed-off-by: Markus Pargmann m...@pengutronix.de
---
drivers/regulator/core.c | 32
On Thu, Feb 20, 2014 at 12:07:52PM +0100, Markus Pargmann wrote:
There are many places where ops-disable is called directly. Instead we
should use _regulator_do_disable() which also handles gpio regulators.
Cc: sta...@vger.kernel.org # 3.10+
Signed-off-by: Markus Pargmann m...@pengutronix.de
On Thu, Feb 20, 2014 at 09:51:30PM +0900, Mark Brown wrote:
On Thu, Feb 20, 2014 at 12:07:52PM +0100, Markus Pargmann wrote:
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -1908,8 +1908,6 @@ static int _regulator_do_disable(struct regulator_dev
*rdev
() to
_regulator_disable(). This way, _regulator_force_disable() can use
different flags for _notifier_call_chain() without calling it twice.
Cc: sta...@vger.kernel.org # 3.10+
Signed-off-by: Markus Pargmann m...@pengutronix.de
---
drivers/regulator/core.c | 34 +-
1 file changed
ops-disable usage).
Regards,
Markus
Markus Pargmann (2):
regulator: core: Replace direct ops-enable usage
regulator: core: Replace direct ops-disable usage
drivers/regulator/core.c | 46 +++---
1 file changed, 19 insertions(+), 27 deletions
-on and always-on gpio regulators are not
enabled on registration.
This patch replaces all ops-enable calls by _regulator_do_enable.
Cc: sta...@vger.kernel.org # 3.10+
Signed-off-by: Markus Pargmann m...@pengutronix.de
---
drivers/regulator/core.c | 12 ++--
1 file changed, 6 insertions(+), 6
Signed-off-by: Markus Pargmann m...@pengutronix.de
Acked-by: Evgeniy Polyakov z...@ioremap.net
---
drivers/w1/masters/w1-gpio.c | 28 +---
1 file changed, 9 insertions(+), 19 deletions(-)
diff --git a/drivers/w1/masters/w1-gpio.c b/drivers/w1/masters/w1-gpio.c
index
The first DT gpio is necessary for this driver, but errors returned for
of_get_gpio are ignored.
This patch adds a return value check for the first of_get_gpio.
Signed-off-by: Markus Pargmann m...@pengutronix.de
Acked-by: Evgeniy Polyakov z...@ioremap.net
---
drivers/w1/masters/w1-gpio.c | 7
us
Signed-off-by: Markus Pargmann m...@pengutronix.de
---
Notes:
Changes in v2:
- Small changes, find_next_bit - ffs and other
drivers/net/can/c_can/c_can.c | 22 --
1 file changed, 12 insertions(+), 10 deletions(-)
diff --git a/drivers/net/can/c_can/c_can.c b
On Tue, Oct 29, 2013 at 01:34:48AM -0700, Joe Perches wrote:
On Tue, 2013-10-29 at 09:27 +0100, Markus Pargmann wrote:
This patch speeds up the rx_poll function by reducing the number of
register reads.
[]
125kbit:
Function HitTimeAvg
On Tue, Oct 29, 2013 at 09:24:05AM -0700, Joe Perches wrote:
On Tue, 2013-10-29 at 09:58 +0100, Markus Pargmann wrote:
On Tue, Oct 29, 2013 at 01:34:48AM -0700, Joe Perches wrote:
On Tue, 2013-10-29 at 09:27 +0100, Markus Pargmann wrote:
This patch speeds up the rx_poll function
Signed-off-by: Markus Pargmann m...@pengutronix.de
---
Notes:
Changes in v3:
- Update commit message (measurements and ffs)
Changes in v2:
- Small changes, find_next_bit - ffs and other
drivers/net/can/c_can/c_can.c | 22 --
1 file changed, 12 insertions
before EOB packets.
Signed-off-by: Markus Pargmann m...@pengutronix.de
---
drivers/net/can/c_can/c_can.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/can/c_can/c_can.c b/drivers/net/can/c_can/c_can.c
index a668cd4..e3fc07c 100644
--- a/drivers/net/can/c_can
6016656 us
Signed-off-by: Markus Pargmann m...@pengutronix.de
---
drivers/net/can/c_can/c_can.c | 30 --
1 file changed, 20 insertions(+), 10 deletions(-)
diff --git a/drivers/net/can/c_can/c_can.c b/drivers/net/can/c_can/c_can.c
index a668cd4..31af033 100644
--- a/drivers
On Mon, Oct 28, 2013 at 10:12:16AM -0700, Joe Perches wrote:
On Mon, 2013-10-28 at 17:59 +0100, Markus Pargmann wrote:
This patch speeds up the rx_poll function by reducing the number of
register reads.
trivial notes:
diff --git a/drivers/net/can/c_can/c_can.c b/drivers/net/can/c_can
register writing in the kernel.
This patch also fixes the file mode when the regmap debugfs write code is
compiled.
Cc: Dimitris Papastamos d...@opensource.wolfsonmicro.com
Signed-off-by: Markus Pargmann m...@pengutronix.de
---
drivers/base/regmap/Kconfig | 14 ++
drivers/base
Hi,
On Tue, Jun 17, 2014 at 12:56:54PM -0700, David Rientjes wrote:
On Tue, 17 Jun 2014, Markus Pargmann wrote:
To enable writing of registers through the regmap debugfs interface, it
was necessary to alter the regmap-debugfs.c source code. This is not
really practical
...@gtsys.com.hk
Reviewed-by: Markus Pargmann m...@pengutronix.de
Perhaps this should go to the stable tree too for 3.13 and 3.14?
Regards,
Markus
---
drivers/pinctrl/pinctrl-imx1-core.c |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/pinctrl/pinctrl-imx1
the real values.
Signed-off-by: Chris Ruehl chris.ru...@gtsys.com.hk
Markus: this OK? I want your review tag on it.
Yes this one is also ok.
Reviewed-by: Markus Pargmann m...@pengutronix.de
Regards,
Markus
--
Pengutronix e.K. | |
Industrial
On Sat, Dec 28, 2013 at 11:02:35AM +0800, Axel Lin wrote:
BBCH_BBCHEN_MASK is equivalent to TPS65910_SUPPLY_STATE_ENABLED.
So all regulators have the same enable_mask setting.
Thanks for spotting this. You could also remove BBCH_BBCHEN_* from
include/linux/mfd/tps65910.h.
Regards,
Markus
Hi,
On Wed, Apr 30, 2014 at 12:43:49PM +0800, Xiubo Li wrote:
[...]
diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c
index 8e8cea1..946e901 100644
--- a/drivers/base/regmap/regmap.c
+++ b/drivers/base/regmap/regmap.c
@@ -15,6 +15,7 @@
#include linux/export.h
Hi,
On Wed, Jun 18, 2014 at 01:11:27AM +0100, Mark Brown wrote:
On Tue, Jun 17, 2014 at 09:36:35PM +0200, Markus Pargmann wrote:
To enable writing of registers through the regmap debugfs interface, it
was necessary to alter the regmap-debugfs.c source code. This is not
really practical
Papastamos d...@opensource.wolfsonmicro.com
Signed-off-by: Markus Pargmann m...@pengutronix.de
---
Hi,
as the kconfig option will probably not be merged, I extracted the mode fix of
my previous patch.
Regards,
Markus
drivers/base/regmap/regmap-debugfs.c | 9 -
1 file changed, 8 insertions
Hi Uwe,
On Mon, Jun 30, 2014 at 07:45:07AM +0200, Uwe Kleine-König wrote:
Hi Markus,
On Sat, Jun 28, 2014 at 03:23:11PM +0200, Markus Pargmann wrote:
The macro REGMAP_ALLOW_WRITE_DEBUGFS can be used to enable write
minor nit: I'd not call it macro, but cpp symbol because macro
sounds more
Hi Steven,
On Fri, Aug 15, 2014 at 01:42:21PM -0400, Steven Rostedt wrote:
Hi,
I'm using my BeagleBone White to debug some ftrace code and with the
help from people like Robert Nelson I was finally able to boot it and
test my kernel.
But I'm still having some other issues. The most
Papastamos d...@opensource.wolfsonmicro.com
Signed-off-by: Markus Pargmann m...@pengutronix.de
---
Notes:
Changes in v2:
- Change registers_mode type to umode_t.
drivers/base/regmap/regmap-debugfs.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/base
Hi,
On Tue, Sep 09, 2014 at 05:18:07PM +0800, Shengjiu Wang wrote:
Move the ipg clock enable and disable operation to startup and shutdown,
that is only enable ipg clock when ssi is working. we don't need to enable
ipg clock in probe.
Another register accessing need the ipg clock, so use
Hi,
On Tue, Sep 09, 2014 at 12:29:29PM +0200, Lisovy Rostislav wrote:
Hello;
If my understanding is correct, the purpose of the watchdog subsystem
is to provide an unified interface from user-space to watchdog devices
(via /dev). The issue I am trying to solve is how to start the watchdog
Hi,
On Fri, Sep 12, 2014 at 10:01:12AM +0800, Shengjiu Wang wrote:
On Thu, Sep 11, 2014 at 03:57:37PM -0700, Nicolin Chen wrote:
On Thu, Sep 11, 2014 at 01:38:29PM +0800, Shengjiu Wang wrote:
Move the ipg clock enable and disable operation to startup and shutdown,
that is only enable ipg
On Fri, Sep 12, 2014 at 03:14:28PM +0800, Shengjiu Wang wrote:
On Fri, Sep 12, 2014 at 08:17:06AM +0200, Markus Pargmann wrote:
Hi,
On Fri, Sep 12, 2014 at 10:01:12AM +0800, Shengjiu Wang wrote:
On Thu, Sep 11, 2014 at 03:57:37PM -0700, Nicolin Chen wrote:
On Thu, Sep 11, 2014 at 01
On Fri, Sep 12, 2014 at 06:35:15PM +0800, Shengjiu Wang wrote:
Check if ipg clock is in clock-names property, then we can move the
ipg clock enable and disable operation to startup and shutdown, that
is only enable ipg clock when ssi is working and keep clock is disabled
when ssi is in idle.
On Mon, Sep 15, 2014 at 06:22:27PM +0800, Shengjiu Wang wrote:
On Mon, Sep 15, 2014 at 12:05:41PM +0200, Markus Pargmann wrote:
On Fri, Sep 12, 2014 at 06:35:15PM +0800, Shengjiu Wang wrote:
Check if ipg clock is in clock-names property, then we can move the
ipg clock enable and disable
On Mon, Sep 15, 2014 at 06:37:15PM +0800, Shengjiu Wang wrote:
On Mon, Sep 15, 2014 at 12:32:13PM +0200, Markus Pargmann wrote:
On Mon, Sep 15, 2014 at 06:22:27PM +0800, Shengjiu Wang wrote:
On Mon, Sep 15, 2014 at 12:05:41PM +0200, Markus Pargmann wrote:
On Fri, Sep 12, 2014 at 06:35
On Tue, Oct 07, 2014 at 10:46:27AM +0200, Krzysztof Kozłowski wrote:
On 06.10.2014 22:17, Markus Pargmann wrote:
This patch sets the new field ena_gpio_valid for all drivers which set a
valid ena_gpio.
Signed-off-by: Markus Pargmann m...@pengutronix.de
---
(... looking only on s2m/s5m
On Tue, Oct 07, 2014 at 10:52:29AM +0200, Krzysztof Kozłowski wrote:
On 06.10.2014 22:17, Markus Pargmann wrote:
It is not necessary to setup config.ena_gpio with -EINVAL or similar.
This patch removes these unnecessary initializations.
Signed-off-by: Markus Pargmann m...@pengutronix.de
Hi,
On Tue, Oct 07, 2014 at 12:53:35PM +0100, Mark Brown wrote:
On Mon, Oct 06, 2014 at 10:17:11PM +0200, Markus Pargmann wrote:
Most drivers do not set the ena_gpio field of struct regulator_config
before passing it to the regulator core. This is fine as long as the
gpio identifier
Hi,
On Tue, Oct 07, 2014 at 12:58:17PM +0100, Mark Brown wrote:
On Mon, Oct 06, 2014 at 10:17:12PM +0200, Markus Pargmann wrote:
This patch sets the new field ena_gpio_valid for all drivers which set a
valid ena_gpio.
config.ena_gpio = arizona-pdata.ldoena
On Tue, Oct 07, 2014 at 01:01:06PM +0100, Mark Brown wrote:
On Mon, Oct 06, 2014 at 10:17:14PM +0200, Markus Pargmann wrote:
Use gpio_is_valid instead of custom check.
Patches per driver please, this isn't just a mechanical transformation.
Okay, but you mean just patches 4 and 5
On Tue, Oct 07, 2014 at 05:19:33PM +0100, Mark Brown wrote:
On Tue, Oct 07, 2014 at 03:03:20PM +0200, Markus Pargmann wrote:
On Tue, Oct 07, 2014 at 12:53:35PM +0100, Mark Brown wrote:
This should be part of the patch adding meaningful behaviour for the
flag, it's pointless separately
Use gpio_is_valid instead of an explicit comparison with 0.
Signed-off-by: Markus Pargmann m...@pengutronix.de
---
drivers/regulator/gpio-regulator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regulator/gpio-regulator.c
b/drivers/regulator/gpio-regulator.c
index
Use gpio_is_valid instead of an explicit comparison with 0.
Signed-off-by: Markus Pargmann m...@pengutronix.de
---
drivers/regulator/fixed.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regulator/fixed.c b/drivers/regulator/fixed.c
index 441a3e90e266..696f53cc1927
or ena_gpio_initialized before handling it
as a gpio. This way we maintain backwards compatibility and fix the
behaviour for gpio number 0.
Signed-off-by: Markus Pargmann m...@pengutronix.de
---
Notes:
Changes in v2:
- Squash all regulator core changes into one patch
- Fix the ena_gpio check
Markus Pargmann (4):
regulator: Add ena_gpio_initialized to regulator_config
regulator: Set ena_gpio_initialized in regulator drivers
regulator: fixed: Use gpio_is_valid
regulator: gpio: Use gpio_is_valid
drivers/regulator/arizona-ldo1.c | 1 +
drivers/regulator/core.c
This patch sets ena_gpio_initialized for all drivers which set a
ena_gpio from parsed DT properties. Drivers using pdata may get zero
initialized pdata and therefore copy a 0 into the regulator_config
ena_gpio field.
Signed-off-by: Markus Pargmann m...@pengutronix.de
---
drivers/regulator
This patch sets the new field ena_gpio_valid for all drivers which set a
valid ena_gpio.
Signed-off-by: Markus Pargmann m...@pengutronix.de
---
drivers/regulator/arizona-ldo1.c | 1 +
drivers/regulator/da9055-regulator.c | 1 +
drivers/regulator/fixed.c | 4 +++-
drivers
.
Signed-off-by: Markus Pargmann m...@pengutronix.de
---
include/linux/regulator/driver.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/linux/regulator/driver.h b/include/linux/regulator/driver.h
index bbe03a1924c0..c561f0faaf61 100644
--- a/include/linux/regulator/driver.h
+++ b
Use gpio_is_valid instead of custom check.
Signed-off-by: Markus Pargmann m...@pengutronix.de
---
drivers/regulator/fixed.c| 2 +-
drivers/regulator/gpio-regulator.c | 2 +-
drivers/regulator/wm8994-regulator.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git
It is not necessary to setup config.ena_gpio with -EINVAL or similar.
This patch removes these unnecessary initializations.
Signed-off-by: Markus Pargmann m...@pengutronix.de
---
drivers/regulator/pfuze100-regulator.c | 1 -
drivers/regulator/s5m8767.c| 2 --
2 files changed, 3
Use the introduced ena_gpio_valid field to check if ena_gpio stores a
valid gpio.
Signed-off-by: Markus Pargmann m...@pengutronix.de
---
drivers/regulator/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index
.
Otherwise ena_gpio is ignored.
Patch 1 introduces 'ena_gpio_valid'. Patch 2 updates all drivers that set
ena_gpio. Patch 3 changes the regulator core check for ena_gpio.
Patch 4 and 5 are minor changes to regulator drivers unrelated to the gpio-0
issue.
Best regards,
Markus
Markus Pargmann (5
On Tue, Sep 09, 2014 at 11:38:05AM -0700, Nicolin Chen wrote:
On Tue, Sep 09, 2014 at 05:18:07PM +0800, Shengjiu Wang wrote:
@@ -1321,7 +1333,11 @@ static int fsl_ssi_probe(struct platform_device
*pdev)
return -ENOMEM;
}
- ssi_private-regs =
Hi,
On Wed, Sep 10, 2014 at 06:30:06PM +0800, Shengjiu Wang wrote:
On Wed, Sep 10, 2014 at 08:21:18AM +0200, Markus Pargmann wrote:
On Tue, Sep 09, 2014 at 11:38:05AM -0700, Nicolin Chen wrote:
On Tue, Sep 09, 2014 at 05:18:07PM +0800, Shengjiu Wang wrote:
@@ -1321,7 +1333,11 @@ static
Hi,
On Wed, Sep 10, 2014 at 04:46:46PM +0300, Dmitry Lavnikevich wrote:
This is driver for i.MX6 boards with tlv320aic3x audio codecs.
Signed-off-by: Dmitry Lavnikevich d.lavnikev...@sam-solutions.com
---
.../bindings/sound/fsl,imx-audio-tlv320aic3x.txt | 27
sound/soc/fsl/Kconfig
On Wed, Sep 10, 2014 at 10:42:04AM -0700, Nicolin Chen wrote:
On Wed, Sep 10, 2014 at 04:12:53PM +0800, Shengjiu Wang wrote:
Then we can get a patch like:
open() {
+ clk_prepare_enable();
}
close() {
+ clk_disable_unprepare()
}
what is the open()
On Wed, Sep 10, 2014 at 11:14:15AM -0700, Nicolin Chen wrote:
On Wed, Sep 10, 2014 at 7:27 AM, Markus Pargmann m...@pengutronix.de wrote:
Hi,
On Wed, Sep 10, 2014 at 04:46:46PM +0300, Dmitry Lavnikevich wrote:
This is driver for i.MX6 boards with tlv320aic3x audio codecs.
Signed-off
Estevam fabio.este...@freescale.com
Cc: Denis Carikli de...@eukrea.com
Cc: Markus Pargmann m...@pengutronix.de
Cc: Greg Ungerer g...@uclinux.org
Cc: Sascha Hauer s.ha...@pengutronix.de
Signed-off-by: Linus Walleij linus.wall...@linaro.org
---
drivers/pinctrl/Kconfig
Hi,
On Mon, Nov 03, 2014 at 10:26:43AM +0900, Hugh Kang wrote:
From: hugh.kang hugh.k...@lge.com
If a regulator is set by always-on option, the regulator will be set forever.
For example, suppose LDO1 is set to always-on at RevA.dts with including of
a.dtsi. After that
RevB.dts may wants
Hi,
Sorry for the delay, holiday and so on.
On Mon, Oct 13, 2014 at 04:42:35PM +0200, Mark Brown wrote:
On Wed, Oct 08, 2014 at 03:47:06PM +0200, Markus Pargmann wrote:
--- a/drivers/regulator/max8952.c
+++ b/drivers/regulator/max8952.c
@@ -225,6 +225,8 @@ static int max8952_pmic_probe
On Mon, Oct 13, 2014 at 04:47:33PM +0200, Mark Brown wrote:
On Wed, Oct 08, 2014 at 03:47:07PM +0200, Markus Pargmann wrote:
Use gpio_is_valid instead of an explicit comparison with 0.
Signed-off-by: Markus Pargmann m...@pengutronix.de
---
drivers/regulator/fixed.c | 2 +-
1 file
.
- Fixed a of_node check in max8952
- Fixed ena_gpio_initialized for the 'fixed' regulator to only be set for
gpios from DT
Best regards,
Markus
Markus Pargmann (4):
regulator: Set ena_gpio_initialized in regulator drivers
regulator: fixed: Use gpio_is_valid
regulator: gpio: Use
Use gpio_is_valid instead of an explicit comparison with 0.
Signed-off-by: Markus Pargmann m...@pengutronix.de
---
drivers/regulator/fixed.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regulator/fixed.c b/drivers/regulator/fixed.c
index 17f6a7d331f8..709fba19e596
This patch sets ena_gpio_initialized for all drivers which set a
ena_gpio from parsed DT properties. Drivers using pdata may get zero
initialized pdata and therefore copy a 0 into the regulator_config
ena_gpio field.
Signed-off-by: Markus Pargmann m...@pengutronix.de
---
drivers/regulator
The config is used for multiple regulators within a for loop. The config
field is not cleared before it is used for the next item. To avoid any
issues this patch adds a proper initialization for the config-ena_gpio
field in case no gpio is available.
Signed-off-by: Markus Pargmann m
Use gpio_is_valid instead of an explicit comparison with 0.
Signed-off-by: Markus Pargmann m...@pengutronix.de
---
drivers/regulator/gpio-regulator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regulator/gpio-regulator.c
b/drivers/regulator/gpio-regulator.c
index
On Wed, Oct 08, 2014 at 04:53:33PM +0200, Krzysztof Kozlowski wrote:
On śro, 2014-10-08 at 15:47 +0200, Markus Pargmann wrote:
This patch sets ena_gpio_initialized for all drivers which set a
ena_gpio from parsed DT properties. Drivers using pdata may get zero
initialized pdata
I think it would be better to
remove irq_dispose_mapping() instead.
Best Regards,
Markus Pargmann
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany
Hi Paul,
On Mon, Jan 26, 2015 at 11:16:12AM -0500, Paul Clements wrote:
Markus,
This refactor looks OK with the exception of one thing...
On Tue, Jan 13, 2015 at 8:44 AM, Markus Pargmann m...@pengutronix.de wrote:
/* Must be called with tx_lock held */
static int __nbd_ioctl
On Tue, Jan 13, 2015 at 02:44:25PM +0100, Markus Pargmann wrote:
Adding support to nbd to use it as a root device. This code essentially
provides a minimal nbd-client implementation within the kernel. It opens
a socket and makes the negotiation with the server. Afterwards it passes
the socket
Hi Paul,
On Tue, Jan 13, 2015 at 09:45:27AM -0500, Paul Clements wrote:
All,
I've maintained the NBD driver since 2003, but alas, I no longer have
the time and energy to continue maintaining it. If someone would like
to take over, let me know.
Quite a long time of maintaining the driver,
Signed-off-by: Markus Pargmann m...@pengutronix.de
---
drivers/block/nbd.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
index f2c1973c486a..170c148dc036 100644
--- a/drivers/block/nbd.c
+++ b/drivers/block/nbd.c
@@ -280,7
The mentioned problem is not present anymore.
Signed-off-by: Markus Pargmann m...@pengutronix.de
---
drivers/block/nbd.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
index 60a38b06a79b..3a3e0057e991 100644
--- a/drivers
the ingoing ioctls which should be
replaceable by strace or similar stuff.
Signed-off-by: Markus Pargmann m...@pengutronix.de
---
drivers/block/nbd.c | 86 -
1 file changed, 19 insertions(+), 67 deletions(-)
diff --git a/drivers/block/nbd.c b/drivers
The block subsystem uses loff_t to store the device size. Change the
type for nbd_device bytesize to loff_t.
Signed-off-by: Markus Pargmann m...@pengutronix.de
---
drivers/block/nbd.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
The header is not included anywhere. Remove it and include the private
nbd_device struct in nbd.c.
Signed-off-by: Markus Pargmann m...@pengutronix.de
---
drivers/block/nbd.c | 22 ++
include/linux/nbd.h | 46 --
2 files changed, 22
Reformat the existing documentation to have more structure. This allows
for more documentation seperated from the existing paragraphs.
Signed-off-by: Markus Pargmann m...@pengutronix.de
---
Documentation/blockdev/nbd.txt | 34 +++---
1 file changed, 19 insertions
patches change some minor things.
Best Regards,
Markus
Markus Pargmann (9):
Documentation: nbd: Reformat to allow more documentation
Documentation: nbd: Add list of module parameters
nbd: Remove kernel internal header
nbd: Replace kthread_create with kthread_run
nbd: Fix device
By returning the error code directly, we can avoid the jump label
error_out.
Signed-off-by: Markus Pargmann m...@pengutronix.de
---
drivers/block/nbd.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
index 3a3e0057e991
Add a list of available module parameters as attachment to the
documentation.
Signed-off-by: Markus Pargmann m...@pengutronix.de
---
Documentation/blockdev/nbd.txt | 10 ++
1 file changed, 10 insertions(+)
diff --git a/Documentation/blockdev/nbd.txt b/Documentation/blockdev/nbd.txt
kthread_run includes the wake_up_process() call, so instead of
kthread_create() followed by wake_up_process() we can use this macro.
Signed-off-by: Markus Pargmann m...@pengutronix.de
---
drivers/block/nbd.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/block
On Thu, Feb 12, 2015 at 01:08:48PM -0800, Joe Perches wrote:
On Thu, 2015-02-12 at 21:57 +0100, Markus Pargmann wrote:
dprintk has some name collisions with other frameworks and drivers. It
is also not necessary to have these custom debug print filters. Dynamic
debug offers the same amount
Hi,
On Fri, Feb 13, 2015 at 02:05:27AM -0800, Joe Perches wrote:
On Fri, 2015-02-13 at 10:58 +0100, Markus Pargmann wrote:
On Thu, Feb 12, 2015 at 01:08:48PM -0800, Joe Perches wrote:
On Thu, 2015-02-12 at 21:57 +0100, Markus Pargmann wrote:
dprintk has some name collisions with other
On Wed, Jan 28, 2015 at 02:12:02PM -0500, Paul Clements wrote:
Small typo, but otherwise, I approve.
On Wed, Jan 28, 2015 at 1:35 PM, Markus Pargmann m...@pengutronix.de wrote:
Paul stops maintining NBD and I will take his place from now on.
Signed-off-by: Markus Pargmann m
Paul stops maintining NBD and I will take his place from now on.
Signed-off-by: Markus Pargmann m...@pengutronix.de
---
MAINTAINERS | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 2ebb056cbe0a..4a83259e7f45 100644
--- a/MAINTAINERS
+++ b
On Wed, Jan 28, 2015 at 12:19:40PM -0700, Jens Axboe wrote:
On 01/28/2015 11:35 AM, Markus Pargmann wrote:
Paul stops maintining NBD and I will take his place from now on.
Signed-off-by: Markus Pargmann m...@pengutronix.de
Applied, with the typo that Paul pointed out fixed.
Okay, then I
Hi,
On Sat, Jan 31, 2015 at 03:43:16PM +0100, Andreas Klauer wrote:
On Sat, Jan 31, 2015 at 08:52:18AM -0500, Paul Clements wrote:
The pid is also used to break a hung connection. See nbd_xmit_timeout.
I'm using the pid to find the first free NBD device...
If it's going away I guess
1 - 100 of 800 matches
Mail list logo
