Re: [PATCH 2/5] MFD: ti_tscadc: Add support for TI's TSC/ADC MFDevice

2012-08-23 Thread Matthias Kaehlcke
, NULL); same as above best regards -- Matthias Kaehlcke Embedded Linux Developer Amsterdam The only way to do great work is to love what you do (Steve Jobs) .''`. using free software / Debian

Re: [PATCH 4/5] IIO : ADC: tiadc: Add support of TI's ADC driver

2012-08-23 Thread Matthias Kaehlcke
-- Matthias Kaehlcke Embedded Linux Developer Amsterdam If sharing a thing in no way diminishes it, it is not rightly owned if it is not shared .''`. using free software / Debian GNU/Linux | http

Re: [PATCH v2] rtc: tps65910: Add RTC driver for TPS65910 PMIC RTC

2012-08-01 Thread Matthias Kaehlcke
. normally this shouldn't happen as the RTC interrupts are disabled after reset, but the interrupts could have been enabled for example by the bootloader best regards -- Matthias Kaehlcke Embedded Linux Developer Amsterdam Anyone who has never made a mistake has never tried anything new

Re: [PATCH v2] rtc: tps65910: Add RTC driver for TPS65910 PMIC RTC

2012-08-02 Thread Matthias Kaehlcke
Hi Venu, thanks for you reply El Thu, Aug 02, 2012 at 10:28:47AM +0530 Venu Byravarasu ha dit: -Original Message- From: Matthias Kaehlcke [mailto:matthias.l...@kaehlcke.net] Sent: Thursday, August 02, 2012 1:48 AM To: Venu Byravarasu Cc: a.zu...@towertech.it; sa

[PATCH] ti-st: Fix check for pdata-chip_awake function pointer

2012-08-02 Thread Matthias Kaehlcke
ll_device_want_to_wakeup(): Fix the NULL pointer check on pdata-chip_awake, which is performed on the wrong function pointer Signed-off-by: Matthias Kaehlcke matth...@kaehlcke.net --- drivers/misc/ti-st/st_ll.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc

[PATCH] COSA/SRP: Convert channel_data.rsem to mutex

2008-02-17 Thread Matthias Kaehlcke
COSA/SRP driver: The semaphore channel_data.rsem is used as a mutex, convert it to the mutex API Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED] -- Index: linux-2.6/drivers/net/wan/cosa.c === --- linux-2.6.orig/drivers/net/wan

[PATCH] Prism54: Convert mgmt_sem to the mutex API

2007-11-04 Thread Matthias Kaehlcke
Prism54: Convert mgmt_sem to the mutex API Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED] -- diff --git a/drivers/net/wireless/prism54/islpci_dev.c b/drivers/net/wireless/prism54/islpci_dev.c index 219dd65..dbb538c 100644 --- a/drivers/net/wireless/prism54/islpci_dev.c +++ b/drivers/net

Re: [PATCH] Prism54: Convert mgmt_sem to the mutex API

2007-11-05 Thread Matthias Kaehlcke
El Mon, Nov 05, 2007 at 12:36:13AM +0100 Michael Buesch ha dit: On Thursday 01 November 2007 08:19:02 Matthias Kaehlcke wrote: Prism54: Convert mgmt_sem to the mutex API Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED] Uhm, so this mutex is not used? Why not remove it then? i

[PATCH] misc/st_kim: Free resources in the error path of probe()

2012-11-22 Thread Matthias Kaehlcke
Signed-off-by: Matthias Kaehlcke matth...@kaehlcke.net --- drivers/misc/ti-st/st_kim.c | 30 +- 1 file changed, 21 insertions(+), 9 deletions(-) diff --git a/drivers/misc/ti-st/st_kim.c b/drivers/misc/ti-st/st_kim.c index 04a8199..9ff942a 100644 --- a/drivers/misc

[PATCH 0/5] use mutex instead of semaphore in several drivers

2007-07-13 Thread Matthias Kaehlcke
This patchset converts semaphores that are used as mutexes to the mutex API in the following drivers/code: SPI core/init code USB gadget serial ELAN U132 adapter Adutux FTDI ELAN -- Matthias Kaehlcke Linux Application Developer Barcelona You must have a plan. If you don't have

[PATCH 1/5] use mutex instead of semaphore in SPI core/init code

2007-07-13 Thread Matthias Kaehlcke
The SPI core/init code uses a semaphore as mutex. Use the mutex API instead of the (binary) semaphore. Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED] -- diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index 4831edb..018884d 100644 --- a/drivers/spi/spi.c +++ b/drivers/spi/spi.c @@ -23,6

[PATCH 2/5] use mutex instead of semaphore in the USB gadget serial driver

2007-07-13 Thread Matthias Kaehlcke
The USB gadget serial driver uses a semaphore as mutex. Use the mutex API instead of the (binary) semaphore. Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED] -- diff --git a/drivers/usb/gadget/serial.c b/drivers/usb/gadget/serial.c index dd33ff0..4192d24 100644 --- a/drivers/usb/gadget

[PATCH 3/5] use mutex instead of semaphore in the ELAN U132 adapter driver

2007-07-13 Thread Matthias Kaehlcke
The ELAN U132 adapter driver uses the semaphore u132_module_lock as mutex. Use the mutex API instead of the (binary) semaphore. Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED] -- diff --git a/drivers/usb/host/u132-hcd.c b/drivers/usb/host/u132-hcd.c index e98df2e..7f765ec 100644

[PATCH 4/5] use mutex instead of semaphore in the Adutux driver

2007-07-13 Thread Matthias Kaehlcke
The Adutux driver uses a semaphore as mutex. Use the mutex API instead of the (binary) semaphore. Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED] -- diff --git a/drivers/usb/misc/adutux.c b/drivers/usb/misc/adutux.c index d72c42e..274d08e 100644 --- a/drivers/usb/misc/adutux.c +++ b/drivers

Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3

2007-06-13 Thread Matthias Kaehlcke
to my house for dinner. I'll cook, you bring the wine. A mashup in the truest sense. Best, Jonathan President, Chief Executive Officer, Sun Microsystems, Inc. http://blogs.sun.com/jonathan/entry/one_plus_one_is_fifty -- Matthias Kaehlcke Linux Application Developer Barcelona Yo soy como

Re: heartbeat problems on linux 2.6.21.[34]

2007-06-14 Thread Matthias Kaehlcke
, your problem seems to be a *heartbeat* issue and not a *kernel* one -- Matthias Kaehlcke Linux Application Developer Barcelona Yo soy como soy y tú eres como eres, construyamos un mundo donde yo pueda ser sin dejar de ser yo, donde tú puedas ser sin dejar de ser tú, y donde ni yo ni

Re: How do you allocate huge pages.

2007-06-19 Thread Matthias Kaehlcke
afaik is impossible with a standard kernel. vmalloc() allocates virtually contiguous memory, as opposed to kmalloc() which allocates physically contiguous memory. -- Matthias Kaehlcke Linux Application Developer Barcelona La libertad es como la mañana. Hay quienes esperan dormidos a que

Re: [PATCH] drivers/block/ub.c: use list_for_each_entry()

2007-05-30 Thread Matthias Kaehlcke
El Wed, May 30, 2007 at 12:38:40PM -0700 Pete Zaitcev ha dit: On Wed, 30 May 2007 10:47:52 +0200, Matthias Kaehlcke [EMAIL PROTECTED] wrote: @@ -1608,8 +1605,7 @@ static void ub_reset_task(struct work_struct *work) spin_lock_irqsave(sc-lock, flags); sc-reset = 0

Re: [PATCH] use mutex instead of semaphore in tty_io.c

2007-05-31 Thread Matthias Kaehlcke
drivers/char/tty_io.c: Use spinlock instead of a (binary) semaphore Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED] -- diff --git a/drivers/char/tty_io.c b/drivers/char/tty_io.c index 7a32df5..ff27587 100644 --- a/drivers/char/tty_io.c +++ b/drivers/char/tty_io.c @@ -137,7 +137,7

Re: [PATCH] use mutex instead of semaphore in tty_io.c

2007-06-01 Thread Matthias Kaehlcke
El Thu, May 31, 2007 at 03:37:12PM -0700 Andrew Morton ha dit: On Thu, 31 May 2007 15:42:26 +0200 Matthias Kaehlcke [EMAIL PROTECTED] wrote: drivers/char/tty_io.c: Use spinlock instead of a (binary) semaphore hm. We end up with this: /* find a device

[PATCH] Videopix Frame Grabber: Fix unreleased lock in vfc_debug()

2007-07-01 Thread Matthias Kaehlcke
Videopix Frame Grabber: vfc_debug() doesn't release the device lock when copy_from_user() fails Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED] --- diff --git a/drivers/sbus/char/vfc_dev.c b/drivers/sbus/char/vfc_dev.c index 6afc7e5..1cbdabd 100644 --- a/drivers/sbus/char/vfc_dev.c +++ b

[PATCH 0/5] use mutex instead of semaphore in several drivers

2007-07-01 Thread Matthias Kaehlcke
This patchset converts semaphores that are used as mutexes to the mutex API in the following drivers: Megaraid Mailbox Philips webcam SMSC LPC47M192 Virtual Video VLSI 82C147 IrDA controller -- Matthias Kaehlcke Linux Application Developer Barcelona Insanity: doing the same

[PATCH 1/5] use mutex instead of semaphore in Megaraid Mailbox driver

2007-07-01 Thread Matthias Kaehlcke
The Megaraid Mailbox driver uses a semaphore as mutex. Use the mutex API instead of the (binary) semaphore. Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED] -- diff --git a/drivers/scsi/megaraid/mega_common.h b/drivers/scsi/megaraid/mega_common.h index 26e1e6c..fef9ac9 100644 --- a/drivers

[PATCH 2/5] use mutex instead of semaphore in Philips webcam driver

2007-07-01 Thread Matthias Kaehlcke
The Philips webcam driver uses a semaphore as mutex. Use the mutex API instead of the (binary) semaphore. Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED] -- diff --git a/drivers/media/video/pwc/pwc-if.c b/drivers/media/video/pwc/pwc-if.c index 085332a..9c0e8d1 100644 --- a/drivers/media

[PATCH 3/5] use mutex instead of semaphore in SMSC LPC47M192 driver

2007-07-01 Thread Matthias Kaehlcke
The SMSC LPC47M192 driver uses a semaphore as mutex. Use the mutex API instead of the (binary) semaphore. Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED] -- diff --git a/drivers/hwmon/smsc47m192.c b/drivers/hwmon/smsc47m192.c index a012f39..7c5cfa2 100644 --- a/drivers/hwmon/smsc47m192.c

[PATCH 4/5] use mutex instead of semaphore in Virtual Video driver

2007-07-01 Thread Matthias Kaehlcke
The Virtual Video driver uses a semaphore as mutex. Use the mutex API instead of the (binary) semaphore. Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED] -- diff --git a/drivers/media/video/vivi.c b/drivers/media/video/vivi.c index f7e1d19..e86f4cd 100644 --- a/drivers/media/video/vivi.c

[PATCH 5/5] use mutex instead of semaphore in VLSI 82C147 IrDA controller driver

2007-07-01 Thread Matthias Kaehlcke
The VLSI 82C147 IrDA controller driver uses a semaphore as mutex. Use the mutex API instead of the (binary) semaphore. Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED] -- diff --git a/drivers/net/irda/vlsi_ir.c b/drivers/net/irda/vlsi_ir.c index bf78ef1..0538ca9 100644 --- a/drivers/net/irda

Re: use mutex instead of semaphore in RocketPort driver

2007-05-22 Thread Matthias Kaehlcke
? if(mutex_lock_interruptible(info-write_mtx)) return -ERESTARTSYS thanks for your comments -- Matthias Kaehlcke Linux Application Developer Barcelona Nothing is more despicable than respect based on fear (Albert Camus

Re: [PATCH] fix unchecked mutex_lock_interruptible (was Re: use mutex instead of semaphore in RocketPort driver)

2007-05-23 Thread Matthias Kaehlcke
El Wed, May 23, 2007 at 06:25:49PM +0530 Satyam Sharma ha dit: On 5/23/07, Jiri Slaby [EMAIL PROTECTED] wrote: Simon Arlott napsal(a): On 22/05/07 21:06, Matthias Kaehlcke wrote: would the following resolve the problem? if(mutex_lock_interruptible(info-write_mtx)) return

[PATCH 0/2] use list_for_each() for iteration in hostap and prism54 driver

2007-05-25 Thread Matthias Kaehlcke
This patchset uses the list_for_each() macro instead of manual iteration in the following drivers: Host AP Prism54 -- Matthias Kaehlcke Linux Application Developer Barcelona The salvation of mankind lies only in making everything the concern of all (Alexander

[PATCH 2/2] use list_for_each() for iteration in Prism 54 driver

2007-05-25 Thread Matthias Kaehlcke
Use list_for_each() in the Prism54 driver to iterate over the MAC list Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED] -- diff --git a/drivers/net/wireless/prism54/isl_ioctl.c b/drivers/net/wireless/prism54/isl_ioctl.c index 283be4a..34cf13c 100644 --- a/drivers/net/wireless/prism54

[PATCH 1/2] use list_for_each() for iteration in Host AP driver

2007-05-25 Thread Matthias Kaehlcke
Use list_for_each() in the Host AP driver to iterate over the MAC restrictions and the STA info lists Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED] -- diff --git a/drivers/net/wireless/hostap/hostap_ap.c b/drivers/net/wireless/hostap/hostap_ap.c index 5b3abd5..0718eeb 100644 --- a/drivers

[PATCH 1/2] use list_for_each_entry() for iteration in hostap_ap.c

2007-05-27 Thread Matthias Kaehlcke
El Fri, May 25, 2007 at 03:30:05PM +0100 Christoph Hellwig ha dit: On Fri, May 25, 2007 at 03:03:08PM +0200, Matthias Kaehlcke wrote: Use list_for_each() in the Host AP driver to iterate over the MAC restrictions and the STA info lists please go all the way to a proper list_for_each_entry

[PATCH 2/2] use list_for_each_entry() for iteration in Prism 54 driver

2007-05-27 Thread Matthias Kaehlcke
El Fri, May 25, 2007 at 03:04:44PM +0200 Matthias Kaehlcke ha dit: Use list_for_each() in the Prism54 driver to iterate over the MAC list In response to a similar patch Christoph Hellwig suggests the use of list_for_each_entry() instead of list_for_each(). Here is a evolution of the patch

[PATCH] Block device elevator: use list_for_each_entry() instead of list_for_each()

2007-05-27 Thread Matthias Kaehlcke
Use list_for_each_entry() instead of list_for_each() in the block device elevator Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED] -- diff --git a/block/elevator.c b/block/elevator.c index ce866eb..4769a25 100644 --- a/block/elevator.c +++ b/block/elevator.c @@ -112,12 +112,8 @@ static inline

Re: [PATCH 1/2] use list_for_each_entry() for iteration in hostap_ap.c

2007-05-28 Thread Matthias Kaehlcke
Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED] -- Matthias Kaehlcke Linux Application Developer Barcelona La posibilidad de realizar un suenyo es lo que hace que la vida sea interesante

[PATCH] kernel/sched.c: use list_for_each_entry_safe() in __wake_up_common()

2007-05-28 Thread Matthias Kaehlcke
Use list_for_each_entry_safe() instead of list_for_each_safe() in __wake_up_common() Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED] -- diff --git a/kernel/sched.c b/kernel/sched.c index 799d23b..38723b7 100644 --- a/kernel/sched.c +++ b/kernel/sched.c @@ -3775,10 +3775,9 @@ EXPORT_SYMBOL

[PATCH] drivers/block/ub.c: use list_for_each_entry()

2007-05-30 Thread Matthias Kaehlcke
Low performance USB storage driver: Use list_for_each_entry() instead of list_for_each() Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED] -- diff --git a/drivers/block/ub.c b/drivers/block/ub.c index 746a118..18c8b6c 100644 --- a/drivers/block/ub.c +++ b/drivers/block/ub.c @@ -1547,10 +1547,8

[PATCH] fs/block_dev.c: use list_for_each_entry()

2007-05-30 Thread Matthias Kaehlcke
fs/block_dev.c: Use list_for_each_entry() instead of list_for_each() in nr_blockdev_pages() Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED] -- diff --git a/fs/block_dev.c b/fs/block_dev.c index 7428992..a63faab 100644 --- a/fs/block_dev.c +++ b/fs/block_dev.c @@ -590,12 +590,10

[PATCH 5/5] use mutex instead of semaphore in the FTDI ELAN driver

2007-07-13 Thread Matthias Kaehlcke
The FTDI ELAN driver uses a semaphore as mutex. Use the mutex API instead of the (binary) semaphore. Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED] -- diff --git a/drivers/usb/misc/ftdi-elan.c b/drivers/usb/misc/ftdi-elan.c index e0f122e..7cc6883 100644 --- a/drivers/usb/misc/ftdi-elan.c

PATCH [0/5] file system core: use list_for_each_entry() instead of list_for_each()

2007-07-15 Thread Matthias Kaehlcke
This patchset replaces some list_for_each() loops by list_for_each_entry() loops in the following file system functions: fs_may_remount_ro() ep_poll_safewake(() sget() posix_locks_deadlock() get_locks_status() nr_blockdev_pages() -- Matthias Kaehlcke Linux Application Developer Barcelona

PATCH [1/5] fs/file_table.c: use list_for_each_entry() instead of list_for_each()

2007-07-15 Thread Matthias Kaehlcke
fs/file_table.c: use list_for_each_entry() instead of list_for_each() in fs_may_remount_ro() Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED] -- diff --git a/fs/file_table.c b/fs/file_table.c index d17fd69..3ddd993 100644 --- a/fs/file_table.c +++ b/fs/file_table.c @@ -264,12 +264,11 @@ void

PATCH [2/5] fs/eventpoll.c: use list_for_each_entry() instead of list_for_each()

2007-07-15 Thread Matthias Kaehlcke
fs/eventpoll.c: use list_for_each_entry() instead of list_for_each() in ep_poll_safewake() Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED] -- diff --git a/fs/eventpoll.c b/fs/eventpoll.c index 0b73cd4..fada1f9 100644 --- a/fs/eventpoll.c +++ b/fs/eventpoll.c @@ -325,15 +325,14 @@ static void

PATCH [3/5] fs/super.c: use list_for_each_entry() instead of list_for_each()

2007-07-15 Thread Matthias Kaehlcke
fs/super.c: use list_for_each_entry() instead of list_for_each() in sget() Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED] -- diff --git a/fs/super.c b/fs/super.c index 5260d62..6866c92 100644 --- a/fs/super.c +++ b/fs/super.c @@ -335,14 +335,12 @@ struct super_block *sget(struct

PATCH [4/5] fs/locks.c: use list_for_each_entry() instead of list_for_each()

2007-07-15 Thread Matthias Kaehlcke
fs/locks.c: use list_for_each_entry() instead of list_for_each() in posix_locks_deadlock() and get_locks_status() Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED] -- diff --git a/fs/locks.c b/fs/locks.c index 431a8b8..d09c6bd 100644 --- a/fs/locks.c +++ b/fs/locks.c @@ -702,13 +702,12

PATCH [5/5] fs/block_dev.c: use list_for_each_entry() instead of list_for_each()

2007-07-15 Thread Matthias Kaehlcke
fs/block_dev.c: use list_for_each_entry() instead of list_for_each() in nr_blockdev_pages() Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED] -- diff --git a/fs/block_dev.c b/fs/block_dev.c index b3e9bfa..da5f051 100644 --- a/fs/block_dev.c +++ b/fs/block_dev.c @@ -588,12 +588,10

[PATCH 0/5] use mutex instead of semaphore in several drivers

2007-05-14 Thread Matthias Kaehlcke
This patchset converts semaphores that are used as mutexes to the mutex API in the following drivers/code: I2O IDE CAPI 2.0 ST M25Pxx MTD DataFlash MTD -- Matthias Kaehlcke Linux Application Developer Barcelona You must have a plan. If you don't have a plan, you'll

[PATCH 1/5] Use mutexes instead of semaphores in I2O driver

2007-05-14 Thread Matthias Kaehlcke
The I2O driver uses two semaphores as mutexes. Use the mutex API instead of the (binary) semaphores. Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED] -- diff --git a/drivers/message/i2o/device.c b/drivers/message/i2o/device.c index b9df143..80e35e8 100644 --- a/drivers/message/i2o/device.c

[PATCH 2/5] Use mutex instead of semaphore in IDE driver

2007-05-14 Thread Matthias Kaehlcke
The IDE driver uses a semaphore as mutex. Use the mutex API instead of the (binary) semaphore. Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED] -- diff --git a/drivers/ide/ide-disk.c b/drivers/ide/ide-disk.c index 7fff773..af67fd2 100644 --- a/drivers/ide/ide-disk.c +++ b/drivers/ide/ide

[PATCH 3/5] Use mutex instead of semaphore in CAPI 2.0 driver

2007-05-14 Thread Matthias Kaehlcke
The CAPI 2.0 driver uses a semaphore as mutex. Use the mutex API instead of the (binary) semaphore. Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED] -- diff --git a/drivers/isdn/capi/kcapi.c b/drivers/isdn/capi/kcapi.c index 3ed34f7..9f73bc2 100644 --- a/drivers/isdn/capi/kcapi.c +++ b

[PATCH 4/5] Use mutex instead of semaphore in the MTD ST M25Pxx driver

2007-05-14 Thread Matthias Kaehlcke
The MTD ST M25Pxx driver uses a semaphore as mutex. Use the mutex API instead of the (binary) semaphore. Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED] -- diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c index 78c2511..b32806a 100644 --- a/drivers/mtd/devices/m25p80.c

[PATCH 5/5] Use mutex instead of semaphore in the MTD DataFlash driver

2007-05-14 Thread Matthias Kaehlcke
The MTD DataFlash driver uses a semaphore as mutex. Use the mutex API instead of the (binary) semaphore. Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED] -- diff --git a/drivers/mtd/devices/mtd_dataflash.c b/drivers/mtd/devices/mtd_dataflash.c index a987e91..a5ed6d2 100644 --- a/drivers/mtd

Re: [PATCH 1/5] Power Management: use mutexes instead of semaphores

2007-05-04 Thread Matthias Kaehlcke
El Thu, May 03, 2007 at 10:54:32PM -0700 Andrew Morton ha dit: On Fri, 27 Apr 2007 10:43:22 +0200 Matthias Kaehlcke [EMAIL PROTECTED] wrote: the Power Management code uses semaphores as mutexes. use the mutex API instead of the (binary) semaphores I know it's a little thing, but given

[PATCH] regulator: Add devm_regulator_get_exclusive()

2013-08-25 Thread Matthias Kaehlcke
Add a resource managed regulator_get_exclusive() Signed-off-by: Matthias Kaehlcke matth...@kaehlcke.net --- drivers/regulator/core.c | 30 ++ include/linux/regulator/consumer.h |2 ++ 2 files changed, 32 insertions(+) diff --git a/drivers/regulator

[PATCH 1/2] mfd: ti_am335x_tscadc: Fix idle timeout value

2013-09-10 Thread Matthias Kaehlcke
Signed-off-by: Matthias Kaehlcke matth...@kaehlcke.net --- include/linux/mfd/ti_am335x_tscadc.h | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/include/linux/mfd/ti_am335x_tscadc.h b/include/linux/mfd/ti_am335x_tscadc.h index db1791b..9e6a775 100644

[PATCH 2/2] iio: ti_am335x_adc: Take touchscreen channels into account for conversion timeout

2013-09-10 Thread Matthias Kaehlcke
-by: Matthias Kaehlcke matth...@kaehlcke.net --- drivers/iio/adc/ti_am335x_adc.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/iio/adc/ti_am335x_adc.c b/drivers/iio/adc/ti_am335x_adc.c index 3ceac3e..898fc78 100644 --- a/drivers/iio/adc/ti_am335x_adc.c +++ b/drivers/iio/adc/ti_am335x_adc.c

Re: [PATCH 2/2] iio: ti_am335x_adc: Take touchscreen channels into account for conversion timeout

2013-09-15 Thread Matthias Kaehlcke
Hi Jonathan, thanks for your comments El Sun, Sep 15, 2013 at 05:17:30PM +0100 Jonathan Cameron ha dit: On 09/10/13 22:02, Matthias Kaehlcke wrote: The calculation of the old conversion timeout value was based on the number of channels used by this driver. This doesn't take into account

[PATCH v2] iio: ti_am335x_adc: Take touchscreen steps into account for conversion timeout

2013-09-16 Thread Matthias Kaehlcke
The calculation of the old conversion timeout value was based on the number of steps used by this driver. This doesn't take into account that other steps can be used by the touchscreen driver. Select the timeout value based on the steps used by both drivers Signed-off-by: Matthias Kaehlcke matth

[PATCH] cyttsp: Fix swap of mfg_stat and mfg_cmd registers

2013-06-04 Thread Matthias Kaehlcke
The command and status register in the driver were swapped with respect to the order specified in the datasheet (CY8CTMA140). Confirmed with Cypress that the order in the datasheet is correct. Signed-off-by: Matthias Kaehlcke matth...@kaehlcke.net --- drivers/input/touchscreen/cyttsp_core.h

Re: [PATCH v2] iio: ti_am335x_adc: Take touchscreen steps into account for conversion timeout

2013-09-22 Thread Matthias Kaehlcke
Hi, El Sat, Sep 21, 2013 at 01:25:42PM +0100 Jonathan Cameron ha dit: On 09/16/13 22:17, Matthias Kaehlcke wrote: The calculation of the old conversion timeout value was based on the number of steps used by this driver. This doesn't take into account that other steps can be used

Re: [PATCH 2/2] iio: ti_am335x_adc: Take touchscreen channels into account for conversion timeout

2013-09-23 Thread Matthias Kaehlcke
Hi Sebastian, El Mon, Sep 23, 2013 at 03:31:14PM +0200 Sebastian Andrzej Siewior ha dit: On 09/10/2013 11:02 PM, Matthias Kaehlcke wrote: The calculation of the old conversion timeout value was based on the number of channels used by this driver. This doesn't take into account that other

[PATCH] mfd: ti_am335x_tscadc: Restore clock divider on resume

2013-09-23 Thread Matthias Kaehlcke
The ADC clock divider needs to be restored on resume as the register content is lost when the ADC is powered down Signed-off-by: Matthias Kaehlcke matth...@kaehlcke.net --- drivers/mfd/ti_am335x_tscadc.c | 10 ++ include/linux/mfd/ti_am335x_tscadc.h |1 + 2 files changed, 7

[PATCH] input: touchscreen: ti_am335x_tsc: Enable FIFO threshold interrupt on resume

2013-09-23 Thread Matthias Kaehlcke
When returning from suspend the FIFO threshold interrupt is disabled, re-enable it on resume Signed-off-by: Matthias Kaehlcke matth...@kaehlcke.net --- drivers/input/touchscreen/ti_am335x_tsc.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/input/touchscreen/ti_am335x_tsc.c b

Re: [v3,2/6] power: add power sequence library

2016-07-29 Thread Matthias Kaehlcke
Hi Peter, Thanks for your work on this, a few comments inline On 07/20/2016 02:40 AM, Peter Chen wrote: ... +static int pwrseq_generic_on(struct device_node *np, struct pwrseq *pwrseq) +{ ... + if (gpiod_reset) { + u32 duration_us = 50; + +

Re: [PATCH v5 2/6] power: add power sequence library

2016-08-08 Thread Matthias Kaehlcke
off-by: Peter Chen <peter.c...@nxp.com> > Tested-by Joshua Clayton <stillcompil...@gmail.com> Reviewed-by: Matthias Kaehlcke <m...@chromium.org> Tested-by: Matthias Kaehlcke <m...@chromium.org>

Re: [PATCH v4 2/6] power: add power sequence library

2016-08-03 Thread Matthias Kaehlcke
El Tue, Aug 02, 2016 at 11:30:48AM +0800 Peter Chen ha dit: > diff --git a/drivers/power/pwrseq/core.c b/drivers/power/pwrseq/core.c > > ... > > +static DEFINE_MUTEX(pwrseq_list_mutex); > +static LIST_HEAD(pwrseq_list); > + > +int pwrseq_get(struct device_node *np, struct pwrseq *p) > +{ > +

Re: [PATCH v1] regulator: Add driver for voltage controlled regulators

2017-02-24 Thread Matthias Kaehlcke
Rob, thanks for your comments! El Tue, Feb 21, 2017 at 06:22:14PM -0600 Rob Herring ha dit: > On Fri, Feb 10, 2017 at 12:43:48PM -0800, Matthias Kaehlcke wrote: > > The output voltage of a voltage controlled regulator can be controlled > > through the voltage of another regulat

[PATCH v1] regulator: Add driver for voltage controlled regulators

2017-02-10 Thread Matthias Kaehlcke
The output voltage of a voltage controlled regulator can be controlled through the voltage of another regulator. The current version of this driver assumes that the output voltage is a linear function of the control voltage. Signed-off-by: Matthias Kaehlcke <m...@chromium.org> --

Re: [PATCH v1] regulator: Add driver for voltage controlled regulators

2017-02-10 Thread Matthias Kaehlcke
El Fri, Feb 10, 2017 at 12:43:48PM -0800 Matthias Kaehlcke ha dit: > The output voltage of a voltage controlled regulator can be controlled > through the voltage of another regulator. The current version of this > driver assumes that the output voltage is a linear function of th

Re: [PATCH v1] regulator: Add driver for voltage controlled regulators

2017-02-28 Thread Matthias Kaehlcke
El Fri, Feb 24, 2017 at 07:19:19PM -0800 Matthias Kaehlcke ha dit: > El Tue, Feb 21, 2017 at 06:22:14PM -0600 Rob Herring ha dit: > > > > > +Optional properties: > > > + > > > ... > > > +- min-slew-down-rate : Describes how s

[PATCH v4 1/4] regulator: Add set_voltage_time op

2016-09-06 Thread Matthias Kaehlcke
of the stabilization time is done in the same place for both types of regulators. Signed-off-by: Matthias Kaehlcke <m...@chromium.org> --- Changes in v4: - This patch is new for v4. drivers/regulator/core.c | 140 +-- include/linux/regulator/driver.h | 8 +++ 2

[PATCH v4 2/4] regulator: pwm: Use core functionality to delay after changing voltage

2016-09-06 Thread Matthias Kaehlcke
Use the new set_voltage_time() op to calculate the stabilization time instead of duplicating the calculation in the core code. Signed-off-by: Matthias Kaehlcke <m...@chromium.org> --- Changes in v4: - This patch is new for v4. drivers/regulator/pwm-regulator.c | 10 +- 1 file chan

[PATCH v4 4/4] regulator: Prevent falling too fast

2016-09-06 Thread Matthias Kaehlcke
ouglas Anderson <diand...@chromium.org> Signed-off-by: Matthias Kaehlcke <m...@chromium.org> --- Changes in v4: - Moved from PWM regulator to regulator core - Added 'regulator' prefix to device tree properties .../devicetree/bindings/regulator/regulator.txt| 7 +++ driver

[PATCH v4 3/4] regulator: Add support for a fixed delay after voltage increases

2016-09-06 Thread Matthias Kaehlcke
Signed-off-by: Matthias Kaehlcke <m...@chromium.org> Signed-off-by: Douglas Anderson <diand...@chromium.org> --- Changes in v4: - Moved from PWM regulator to regulator core - Added 'regulator' prefix to device tree property .../devicetree/bindings/regulator/regulator.txt| 2 ++ dr

Re: [PATCH v4 4/4] regulator: Prevent falling too fast

2016-09-13 Thread Matthias Kaehlcke
Hi Mark, thanks for your review, please find my comments (including info from our EE) below. El Mon, Sep 12, 2016 at 07:56:33PM +0100 Mark Brown ha dit: > On Tue, Sep 06, 2016 at 12:05:24PM -0700, Matthias Kaehlcke wrote: > > > On some boards it's possible that transitioning the P

Re: [PATCH v4 1/4] regulator: Add set_voltage_time op

2016-09-13 Thread Matthias Kaehlcke
El Mon, Sep 12, 2016 at 06:18:31PM -0700 Matthias Kaehlcke ha dit: > El Tue, Sep 13, 2016 at 12:57:58AM +0100 Mark Brown ha dit: > > > On Mon, Sep 12, 2016 at 04:18:51PM -0700, Matthias Kaehlcke wrote: > > > El Mon, Sep 12, 2016 at 07:32:30PM +0100 Mark Brown ha dit: > &g

[PATCH v5 4/6] regulator: core: Add set_voltage_time op

2016-09-14 Thread Matthias Kaehlcke
is used to calculate the delay. This change also removes the ramp_delay calculation in the PWM regulator, since the driver now uses the core code for the calculation of the delay. Signed-off-by: Matthias Kaehlcke <m...@chromium.org> --- Changes in v5: - Use _regulator_set_voltage_time() as d

[PATCH v5 6/6] regulator: core: Prevent falling too fast

2016-09-14 Thread Matthias Kaehlcke
<diand...@chromium.org> Signed-off-by: Matthias Kaehlcke <m...@chromium.org> --- Changes in v5: - Leave set_voltage tracepoints where they were - Fixed error handling in code dealing with the device tree, return an error if configuration is invalid - Fixed coding style and formatting issues - Upda

[PATCH v5 5/6] regulator: core: Add support for a fixed delay after voltage changes

2016-09-14 Thread Matthias Kaehlcke
. This change introduces the device tree properties "regulator-settle-time-up-us"/"regulator-settle-time-down-us" which allow to specify a fixed delay after a voltage increase or decrease. Signed-off-by: Matthias Kaehlcke <m...@chromium.org> --- Changes in v5: - Added support for

[PATCH v5 2/6] regulator: core: Simplify error flow in _regulator_do_set_voltage()

2016-09-14 Thread Matthias Kaehlcke
If the voltage can not be set jump to the end of the function. This avoids having to check for an error multiple times and eliminates one level of nesting in a follow-up change. Signed-off-by: Matthias Kaehlcke <m...@chromium.org> --- Changes in v5: - This patch is new for v5. drivers/reg

[PATCH v5 1/6] regulator: core: Use local ops variable in _regulator_do_set_voltage()

2016-09-14 Thread Matthias Kaehlcke
Signed-off-by: Matthias Kaehlcke <m...@chromium.org> --- Changes in v5: - This patch is new for v5. drivers/regulator/core.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index db320e8..b

[PATCH v5 3/6] regulator: core: Don't skip set_voltage_time when ramp delay disabled

2016-09-14 Thread Matthias Kaehlcke
delay is specified. Remove the check in _regulator_do_set_voltage(), the functions calculating the ramp delay return 0 anyway when the ramp delay is not configured. Signed-off-by: Matthias Kaehlcke <m...@chromium.org> --- Changes in v5: - This patch is new for v5. drivers/regulator/core

Re: [PATCH v4 1/4] regulator: Add set_voltage_time op

2016-09-12 Thread Matthias Kaehlcke
El Tue, Sep 13, 2016 at 12:57:58AM +0100 Mark Brown ha dit: > On Mon, Sep 12, 2016 at 04:18:51PM -0700, Matthias Kaehlcke wrote: > > El Mon, Sep 12, 2016 at 07:32:30PM +0100 Mark Brown ha dit: > > > On Tue, Sep 06, 2016 at 12:03:15PM -0700, Matthias Kaehlcke wrote: > &g

Re: [PATCH v4 1/4] regulator: Add set_voltage_time op

2016-09-12 Thread Matthias Kaehlcke
Hi Mark, thanks for your review, please find some comments below. El Mon, Sep 12, 2016 at 07:32:30PM +0100 Mark Brown ha dit: > On Tue, Sep 06, 2016 at 12:03:15PM -0700, Matthias Kaehlcke wrote: > > Whatever you're using to send these is not threading things as expected > a

Re: [PATCH v4 4/4] regulator: Prevent falling too fast

2016-09-15 Thread Matthias Kaehlcke
Hi Mark, El Thu, Sep 15, 2016 at 03:39:45PM +0100 Mark Brown ha dit: > On Tue, Sep 13, 2016 at 10:21:40AM -0700, Matthias Kaehlcke wrote: > > > Optimizing the delay time depends on the SoC; we have not measured > > this across a wide variety of devices and thus have

Re: [PATCH v4 4/4] regulator: Prevent falling too fast

2016-09-16 Thread Matthias Kaehlcke
El Fri, Sep 16, 2016 at 05:32:53PM +0100 Mark Brown ha dit: > On Thu, Sep 15, 2016 at 11:02:23AM -0700, Matthias Kaehlcke wrote: > > El Thu, Sep 15, 2016 at 03:39:45PM +0100 Mark Brown ha dit: > > > > The obvious question here is how the OVP hardware knows about the new

[PATCH v2] pwm-regulator: Add support for a fixed delay after duty cycle changes

2016-08-26 Thread Matthias Kaehlcke
pecify a fixed delay after a voltage increase or decrease. Often it is not strictly necessary for a voltage decrease to complete, therefore the delays may be asymmetric. For regulators with a ramp delay the corresponding settle time is added to the ramp delay. Signed-off-by: Matthias Kaehlck

[PATCH] pwm-regulator: Add support for a fixed delay after duty cycle changes

2016-08-26 Thread Matthias Kaehlcke
mp delay. Change-Id: Ib3543a250e1dfc14964ec72bd2684237728a08a3 Signed-off-by: Matthias Kaehlcke <m...@chromium.org> --- .../bindings/regulator/pwm-regulator.txt | 10 + drivers/regulator/pwm-regulator.c | 24 ++ 2 files changed, 30 insertions(+), 4 deletions(-) diff --git

Re: [PATCH] regulator: core: silence warning: "VDD1: ramp_delay not set"

2016-10-27 Thread Matthias Kaehlcke
Hi, El Thu, Oct 27, 2016 at 07:45:32PM +0200 H. Nikolaus Schaller ha dit: > > Am 27.10.2016 um 19:41 schrieb Matthias Kaehlcke <m...@chromium.org>: > > > > El Thu, Oct 27, 2016 at 02:31:39PM +0200 H. Nikolaus Schaller ha dit: > > > >> commit 73e705bf81ce

Re: [PATCH] regulator: core: silence warning: "VDD1: ramp_delay not set"

2016-10-27 Thread Matthias Kaehlcke
El Thu, Oct 27, 2016 at 02:31:39PM +0200 H. Nikolaus Schaller ha dit: > commit 73e705bf81ce ("regulator: core: Add set_voltage_time op") > > introduced a new rdev_warn() if the ramp_delay is 0. > > Apparently, on omap3/twl4030 platforms with dynamic voltage > management this results in

Re: [PATCH v4 4/4] regulator: Prevent falling too fast

2016-12-13 Thread Matthias Kaehlcke
Hi, El Tue, Dec 13, 2016 at 12:00:32PM -0800 Doug Anderson ha dit: > On Tue, Dec 13, 2016 at 9:19 AM, Mark Brown <broo...@kernel.org> wrote: > > On Mon, Dec 12, 2016 at 01:15:02PM -0800, Matthias Kaehlcke wrote: > >> El Fri, Oct 28, 2016 at 07:15:21PM +0100 Mark Brown ha

Re: [PATCH v4 4/4] regulator: Prevent falling too fast

2016-12-12 Thread Matthias Kaehlcke
El Fri, Oct 28, 2016 at 07:15:21PM +0100 Mark Brown ha dit: > On Mon, Sep 26, 2016 at 10:41:59AM -0700, Doug Anderson wrote: > > > I guess I think of the whole network of components as the PWM > > regulator and not the individual discreet BUCK. I'm also not quite > > sure how you would model it

Re: [PATCH v2 1/2] regulator: core: add regulator_has_continuous_voltage_range()

2017-03-23 Thread Matthias Kaehlcke
El Mon, Mar 20, 2017 at 12:06:15PM + Mark Brown ha dit: > On Fri, Mar 17, 2017 at 05:03:30PM -0700, Matthias Kaehlcke wrote: > > > In principle I totally agree with you that consumers should be able > > to enumerate the supported voltages with the existing functions

Re: [PATCH] regulator: core: Limit propagation of parent voltage count and list

2017-03-27 Thread Matthias Kaehlcke
El Mon, Mar 27, 2017 at 01:54:50PM -0400 Javier Martinez Canillas ha dit: > On 03/27/2017 01:39 PM, Matthias Kaehlcke wrote: > > >>>> +if (ops->get_voltage || ops->get_voltage_sel) > >> > >> It's valid to have a .get_voltage_sel callbac

Re: [PATCH] regulator: core: Limit propagation of parent voltage count and list

2017-03-27 Thread Matthias Kaehlcke
Thanks for the reviews and testing! El Sat, Mar 25, 2017 at 02:05:47AM -0300 Javier Martinez Canillas ha dit: On 03/24/2017 05:38 PM, Brian Norris wrote: > > On Fri, Mar 24, 2017 at 01:09:52PM -0700, Matthias Kaehlcke wrote: > >> diff --git a/drivers/regulator/core.c b/drivers/r

Re: [PATCH] cfg80211: Fix array-bounds warning in fragment copy

2017-03-27 Thread Matthias Kaehlcke
El Mon, Mar 27, 2017 at 12:47:59PM +0200 Johannes Berg ha dit: > On Fri, 2017-03-24 at 18:06 -0700, Matthias Kaehlcke wrote: > > __ieee80211_amsdu_copy_frag intentionally initializes a pointer to > > array[-1] to increment it later to valid values. clang rightfully > > gene

[PATCH v2] cfg80211: Fix array-bounds warning in fragment copy

2017-03-27 Thread Matthias Kaehlcke
after consume. Signed-off-by: Matthias Kaehlcke <m...@chromium.org> --- net/wireless/util.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/wireless/util.c b/net/wireless/util.c index 68e5f2ecee1a..52795ae5337f 100644 --- a/net/wireless/util.c +++ b/net/wireless/

[PATCH] regulator: core: Limit propagation of parent voltage count and list

2017-03-24 Thread Matthias Kaehlcke
ect normal continuous regulators can leak details of their supplies and provide consumers with inconsistent information. Limit the propagation of the voltage count and list to regulators which don't have get_voltage(_sel) and list_voltage ops. Signed-off-by: Matthias Kaehlcke <m...@chromium.org&

[PATCH] cfg80211: Fix array-bounds warning in fragment copy

2017-03-24 Thread Matthias Kaehlcke
to leave the rest of the algorithm untouched. Signed-off-by: Matthias Kaehlcke <m...@chromium.org> --- net/wireless/util.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/wireless/util.c b/net/wireless/util.c index 68e5f2ecee1a..d3d459e4a070 100644 --- a/net/wi

[PATCH] kbuild: Add better clang cross build support

2017-03-24 Thread Matthias Kaehlcke
_TOOLCHAIN. From: Behan Webster <beh...@converseincode.com> Signed-off-by: Behan Webster <beh...@converseincode.com> Reviewed-by: Jan-Simon Möller <dl...@gmx.de> Reviewed-by: Mark Charlebois <charl...@gmail.com> Signed-off-by: Greg Hackmann <ghackm...@google.com

<    1   2   3   4   5   6   7   8   9   10   >