, NULL);
same as above
best regards
--
Matthias Kaehlcke
Embedded Linux Developer
Amsterdam
The only way to do great work is to love what you do
(Steve Jobs)
.''`.
using free software / Debian
--
Matthias Kaehlcke
Embedded Linux Developer
Amsterdam
If sharing a thing in no way diminishes it,
it is not rightly owned if it is not shared
.''`.
using free software / Debian GNU/Linux | http
. normally this shouldn't happen as
the RTC interrupts are disabled after reset, but the interrupts could
have been enabled for example by the bootloader
best regards
--
Matthias Kaehlcke
Embedded Linux Developer
Amsterdam
Anyone who has never made a mistake has never tried anything new
Hi Venu,
thanks for you reply
El Thu, Aug 02, 2012 at 10:28:47AM +0530 Venu Byravarasu ha dit:
-Original Message-
From: Matthias Kaehlcke [mailto:matthias.l...@kaehlcke.net]
Sent: Thursday, August 02, 2012 1:48 AM
To: Venu Byravarasu
Cc: a.zu...@towertech.it; sa
ll_device_want_to_wakeup(): Fix the NULL pointer check on pdata-chip_awake,
which is performed on the wrong function pointer
Signed-off-by: Matthias Kaehlcke matth...@kaehlcke.net
---
drivers/misc/ti-st/st_ll.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc
COSA/SRP driver: The semaphore channel_data.rsem is used as a mutex,
convert it to the mutex API
Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED]
--
Index: linux-2.6/drivers/net/wan/cosa.c
===
--- linux-2.6.orig/drivers/net/wan
Prism54: Convert mgmt_sem to the mutex API
Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED]
--
diff --git a/drivers/net/wireless/prism54/islpci_dev.c
b/drivers/net/wireless/prism54/islpci_dev.c
index 219dd65..dbb538c 100644
--- a/drivers/net/wireless/prism54/islpci_dev.c
+++ b/drivers/net
El Mon, Nov 05, 2007 at 12:36:13AM +0100 Michael Buesch ha dit:
On Thursday 01 November 2007 08:19:02 Matthias Kaehlcke wrote:
Prism54: Convert mgmt_sem to the mutex API
Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED]
Uhm, so this mutex is not used? Why not remove it then?
i
Signed-off-by: Matthias Kaehlcke matth...@kaehlcke.net
---
drivers/misc/ti-st/st_kim.c | 30 +-
1 file changed, 21 insertions(+), 9 deletions(-)
diff --git a/drivers/misc/ti-st/st_kim.c b/drivers/misc/ti-st/st_kim.c
index 04a8199..9ff942a 100644
--- a/drivers/misc
This patchset converts semaphores that are used as mutexes to the
mutex API in the following drivers/code:
SPI core/init code
USB gadget serial
ELAN U132 adapter
Adutux
FTDI ELAN
--
Matthias Kaehlcke
Linux Application Developer
Barcelona
You must have a plan. If you don't have
The SPI core/init code uses a semaphore as mutex. Use the mutex
API instead of the (binary) semaphore.
Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED]
--
diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
index 4831edb..018884d 100644
--- a/drivers/spi/spi.c
+++ b/drivers/spi/spi.c
@@ -23,6
The USB gadget serial driver uses a semaphore as mutex. Use the
mutex API instead of the (binary) semaphore.
Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED]
--
diff --git a/drivers/usb/gadget/serial.c b/drivers/usb/gadget/serial.c
index dd33ff0..4192d24 100644
--- a/drivers/usb/gadget
The ELAN U132 adapter driver uses the semaphore u132_module_lock
as mutex. Use the mutex API instead of the (binary) semaphore.
Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED]
--
diff --git a/drivers/usb/host/u132-hcd.c b/drivers/usb/host/u132-hcd.c
index e98df2e..7f765ec 100644
The Adutux driver uses a semaphore as mutex. Use the mutex API
instead of the (binary) semaphore.
Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED]
--
diff --git a/drivers/usb/misc/adutux.c b/drivers/usb/misc/adutux.c
index d72c42e..274d08e 100644
--- a/drivers/usb/misc/adutux.c
+++ b/drivers
to my house for dinner. I'll
cook, you bring the wine. A mashup in the truest sense.
Best,
Jonathan
President, Chief Executive Officer,
Sun Microsystems, Inc.
http://blogs.sun.com/jonathan/entry/one_plus_one_is_fifty
--
Matthias Kaehlcke
Linux Application Developer
Barcelona
Yo soy como
, your problem seems to be a
*heartbeat* issue and not a *kernel* one
--
Matthias Kaehlcke
Linux Application Developer
Barcelona
Yo soy como soy y tú eres como eres, construyamos un mundo donde yo
pueda ser sin dejar de ser yo, donde tú puedas ser sin dejar de ser
tú, y donde ni yo ni
afaik is impossible with a standard kernel.
vmalloc() allocates virtually contiguous memory, as opposed to
kmalloc() which allocates physically contiguous memory.
--
Matthias Kaehlcke
Linux Application Developer
Barcelona
La libertad es como la mañana. Hay quienes esperan dormidos a que
El Wed, May 30, 2007 at 12:38:40PM -0700 Pete Zaitcev ha dit:
On Wed, 30 May 2007 10:47:52 +0200, Matthias Kaehlcke [EMAIL PROTECTED]
wrote:
@@ -1608,8 +1605,7 @@ static void ub_reset_task(struct work_struct *work)
spin_lock_irqsave(sc-lock, flags);
sc-reset = 0
drivers/char/tty_io.c: Use spinlock instead of a (binary) semaphore
Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED]
--
diff --git a/drivers/char/tty_io.c b/drivers/char/tty_io.c
index 7a32df5..ff27587 100644
--- a/drivers/char/tty_io.c
+++ b/drivers/char/tty_io.c
@@ -137,7 +137,7
El Thu, May 31, 2007 at 03:37:12PM -0700 Andrew Morton ha dit:
On Thu, 31 May 2007 15:42:26 +0200
Matthias Kaehlcke [EMAIL PROTECTED] wrote:
drivers/char/tty_io.c: Use spinlock instead of a (binary) semaphore
hm.
We end up with this:
/* find a device
Videopix Frame Grabber: vfc_debug() doesn't release the device lock
when copy_from_user() fails
Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED]
---
diff --git a/drivers/sbus/char/vfc_dev.c b/drivers/sbus/char/vfc_dev.c
index 6afc7e5..1cbdabd 100644
--- a/drivers/sbus/char/vfc_dev.c
+++ b
This patchset converts semaphores that are used as mutexes to the
mutex API in the following drivers:
Megaraid Mailbox
Philips webcam
SMSC LPC47M192
Virtual Video
VLSI 82C147 IrDA controller
--
Matthias Kaehlcke
Linux Application Developer
Barcelona
Insanity: doing the same
The Megaraid Mailbox driver uses a semaphore as mutex. Use the mutex
API instead of the (binary) semaphore.
Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED]
--
diff --git a/drivers/scsi/megaraid/mega_common.h
b/drivers/scsi/megaraid/mega_common.h
index 26e1e6c..fef9ac9 100644
--- a/drivers
The Philips webcam driver uses a semaphore as mutex. Use the mutex API
instead of the (binary) semaphore.
Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED]
--
diff --git a/drivers/media/video/pwc/pwc-if.c b/drivers/media/video/pwc/pwc-if.c
index 085332a..9c0e8d1 100644
--- a/drivers/media
The SMSC LPC47M192 driver uses a semaphore as mutex. Use the mutex API
instead of the (binary) semaphore.
Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED]
--
diff --git a/drivers/hwmon/smsc47m192.c b/drivers/hwmon/smsc47m192.c
index a012f39..7c5cfa2 100644
--- a/drivers/hwmon/smsc47m192.c
The Virtual Video driver uses a semaphore as mutex. Use the mutex API
instead of the (binary) semaphore.
Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED]
--
diff --git a/drivers/media/video/vivi.c b/drivers/media/video/vivi.c
index f7e1d19..e86f4cd 100644
--- a/drivers/media/video/vivi.c
The VLSI 82C147 IrDA controller driver uses a semaphore as mutex. Use
the mutex API instead of the (binary) semaphore.
Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED]
--
diff --git a/drivers/net/irda/vlsi_ir.c b/drivers/net/irda/vlsi_ir.c
index bf78ef1..0538ca9 100644
--- a/drivers/net/irda
?
if(mutex_lock_interruptible(info-write_mtx))
return -ERESTARTSYS
thanks for your comments
--
Matthias Kaehlcke
Linux Application Developer
Barcelona
Nothing is more despicable than respect based on fear
(Albert Camus
El Wed, May 23, 2007 at 06:25:49PM +0530 Satyam Sharma ha dit:
On 5/23/07, Jiri Slaby [EMAIL PROTECTED] wrote:
Simon Arlott napsal(a):
On 22/05/07 21:06, Matthias Kaehlcke wrote:
would the following resolve the problem?
if(mutex_lock_interruptible(info-write_mtx)) return
This patchset uses the list_for_each() macro instead of manual
iteration in the following drivers:
Host AP
Prism54
--
Matthias Kaehlcke
Linux Application Developer
Barcelona
The salvation of mankind lies only in making everything the concern of all
(Alexander
Use list_for_each() in the Prism54 driver to iterate over the MAC list
Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED]
--
diff --git a/drivers/net/wireless/prism54/isl_ioctl.c
b/drivers/net/wireless/prism54/isl_ioctl.c
index 283be4a..34cf13c 100644
--- a/drivers/net/wireless/prism54
Use list_for_each() in the Host AP driver to iterate over the MAC
restrictions and the STA info lists
Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED]
--
diff --git a/drivers/net/wireless/hostap/hostap_ap.c
b/drivers/net/wireless/hostap/hostap_ap.c
index 5b3abd5..0718eeb 100644
--- a/drivers
El Fri, May 25, 2007 at 03:30:05PM +0100 Christoph Hellwig ha dit:
On Fri, May 25, 2007 at 03:03:08PM +0200, Matthias Kaehlcke wrote:
Use list_for_each() in the Host AP driver to iterate over the MAC
restrictions and the STA info lists
please go all the way to a proper list_for_each_entry
El Fri, May 25, 2007 at 03:04:44PM +0200 Matthias Kaehlcke ha dit:
Use list_for_each() in the Prism54 driver to iterate over the MAC list
In response to a similar patch Christoph Hellwig suggests the use of
list_for_each_entry() instead of list_for_each(). Here is a evolution
of the patch
Use list_for_each_entry() instead of list_for_each() in the block
device elevator
Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED]
--
diff --git a/block/elevator.c b/block/elevator.c
index ce866eb..4769a25 100644
--- a/block/elevator.c
+++ b/block/elevator.c
@@ -112,12 +112,8 @@ static inline
Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED]
--
Matthias Kaehlcke
Linux Application Developer
Barcelona
La posibilidad de realizar un suenyo es lo
que hace que la vida sea interesante
Use list_for_each_entry_safe() instead of list_for_each_safe() in
__wake_up_common()
Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED]
--
diff --git a/kernel/sched.c b/kernel/sched.c
index 799d23b..38723b7 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -3775,10 +3775,9 @@ EXPORT_SYMBOL
Low performance USB storage driver: Use list_for_each_entry() instead
of list_for_each()
Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED]
--
diff --git a/drivers/block/ub.c b/drivers/block/ub.c
index 746a118..18c8b6c 100644
--- a/drivers/block/ub.c
+++ b/drivers/block/ub.c
@@ -1547,10 +1547,8
fs/block_dev.c: Use list_for_each_entry() instead of list_for_each()
in nr_blockdev_pages()
Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED]
--
diff --git a/fs/block_dev.c b/fs/block_dev.c
index 7428992..a63faab 100644
--- a/fs/block_dev.c
+++ b/fs/block_dev.c
@@ -590,12 +590,10
The FTDI ELAN driver uses a semaphore as mutex. Use the mutex API
instead of the (binary) semaphore.
Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED]
--
diff --git a/drivers/usb/misc/ftdi-elan.c b/drivers/usb/misc/ftdi-elan.c
index e0f122e..7cc6883 100644
--- a/drivers/usb/misc/ftdi-elan.c
This patchset replaces some list_for_each() loops by
list_for_each_entry() loops in the following file system functions:
fs_may_remount_ro()
ep_poll_safewake(()
sget()
posix_locks_deadlock()
get_locks_status()
nr_blockdev_pages()
--
Matthias Kaehlcke
Linux Application Developer
Barcelona
fs/file_table.c: use list_for_each_entry() instead of list_for_each()
in fs_may_remount_ro()
Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED]
--
diff --git a/fs/file_table.c b/fs/file_table.c
index d17fd69..3ddd993 100644
--- a/fs/file_table.c
+++ b/fs/file_table.c
@@ -264,12 +264,11 @@ void
fs/eventpoll.c: use list_for_each_entry() instead of list_for_each()
in ep_poll_safewake()
Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED]
--
diff --git a/fs/eventpoll.c b/fs/eventpoll.c
index 0b73cd4..fada1f9 100644
--- a/fs/eventpoll.c
+++ b/fs/eventpoll.c
@@ -325,15 +325,14 @@ static void
fs/super.c: use list_for_each_entry() instead of list_for_each() in
sget()
Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED]
--
diff --git a/fs/super.c b/fs/super.c
index 5260d62..6866c92 100644
--- a/fs/super.c
+++ b/fs/super.c
@@ -335,14 +335,12 @@ struct super_block *sget(struct
fs/locks.c: use list_for_each_entry() instead of list_for_each() in
posix_locks_deadlock() and get_locks_status()
Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED]
--
diff --git a/fs/locks.c b/fs/locks.c
index 431a8b8..d09c6bd 100644
--- a/fs/locks.c
+++ b/fs/locks.c
@@ -702,13 +702,12
fs/block_dev.c: use list_for_each_entry() instead of list_for_each()
in nr_blockdev_pages()
Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED]
--
diff --git a/fs/block_dev.c b/fs/block_dev.c
index b3e9bfa..da5f051 100644
--- a/fs/block_dev.c
+++ b/fs/block_dev.c
@@ -588,12 +588,10
This patchset converts semaphores that are used as mutexes to the
mutex API in the following drivers/code:
I2O
IDE
CAPI 2.0
ST M25Pxx MTD
DataFlash MTD
--
Matthias Kaehlcke
Linux Application Developer
Barcelona
You must have a plan. If you don't have a plan,
you'll
The I2O driver uses two semaphores as mutexes. Use the mutex API
instead of the (binary) semaphores.
Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED]
--
diff --git a/drivers/message/i2o/device.c b/drivers/message/i2o/device.c
index b9df143..80e35e8 100644
--- a/drivers/message/i2o/device.c
The IDE driver uses a semaphore as mutex. Use the mutex API instead of
the (binary) semaphore.
Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED]
--
diff --git a/drivers/ide/ide-disk.c b/drivers/ide/ide-disk.c
index 7fff773..af67fd2 100644
--- a/drivers/ide/ide-disk.c
+++ b/drivers/ide/ide
The CAPI 2.0 driver uses a semaphore as mutex. Use the mutex API
instead of the (binary) semaphore.
Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED]
--
diff --git a/drivers/isdn/capi/kcapi.c b/drivers/isdn/capi/kcapi.c
index 3ed34f7..9f73bc2 100644
--- a/drivers/isdn/capi/kcapi.c
+++ b
The MTD ST M25Pxx driver uses a semaphore as mutex. Use the mutex API
instead of the (binary) semaphore.
Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED]
--
diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c
index 78c2511..b32806a 100644
--- a/drivers/mtd/devices/m25p80.c
The MTD DataFlash driver uses a semaphore as mutex. Use the mutex API
instead
of the (binary) semaphore.
Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED]
--
diff --git a/drivers/mtd/devices/mtd_dataflash.c
b/drivers/mtd/devices/mtd_dataflash.c
index a987e91..a5ed6d2 100644
--- a/drivers/mtd
El Thu, May 03, 2007 at 10:54:32PM -0700 Andrew Morton ha dit:
On Fri, 27 Apr 2007 10:43:22 +0200 Matthias Kaehlcke [EMAIL PROTECTED]
wrote:
the Power Management code uses semaphores as mutexes. use the mutex
API instead of the (binary) semaphores
I know it's a little thing, but given
Add a resource managed regulator_get_exclusive()
Signed-off-by: Matthias Kaehlcke matth...@kaehlcke.net
---
drivers/regulator/core.c | 30 ++
include/linux/regulator/consumer.h |2 ++
2 files changed, 32 insertions(+)
diff --git a/drivers/regulator
Signed-off-by: Matthias Kaehlcke matth...@kaehlcke.net
---
include/linux/mfd/ti_am335x_tscadc.h | 19 ---
1 file changed, 12 insertions(+), 7 deletions(-)
diff --git a/include/linux/mfd/ti_am335x_tscadc.h
b/include/linux/mfd/ti_am335x_tscadc.h
index db1791b..9e6a775 100644
-by: Matthias Kaehlcke matth...@kaehlcke.net
---
drivers/iio/adc/ti_am335x_adc.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/iio/adc/ti_am335x_adc.c b/drivers/iio/adc/ti_am335x_adc.c
index 3ceac3e..898fc78 100644
--- a/drivers/iio/adc/ti_am335x_adc.c
+++ b/drivers/iio/adc/ti_am335x_adc.c
Hi Jonathan,
thanks for your comments
El Sun, Sep 15, 2013 at 05:17:30PM +0100 Jonathan Cameron ha dit:
On 09/10/13 22:02, Matthias Kaehlcke wrote:
The calculation of the old conversion timeout value was based on the number
of
channels used by this driver. This doesn't take into account
The calculation of the old conversion timeout value was based on the number of
steps used by this driver. This doesn't take into account that other steps
can be used by the touchscreen driver. Select the timeout value based on the
steps used by both drivers
Signed-off-by: Matthias Kaehlcke matth
The command and status register in the driver were swapped with
respect to the order specified in the datasheet (CY8CTMA140).
Confirmed with Cypress that the order in the datasheet is correct.
Signed-off-by: Matthias Kaehlcke matth...@kaehlcke.net
---
drivers/input/touchscreen/cyttsp_core.h
Hi,
El Sat, Sep 21, 2013 at 01:25:42PM +0100 Jonathan Cameron ha dit:
On 09/16/13 22:17, Matthias Kaehlcke wrote:
The calculation of the old conversion timeout value was based on the number
of
steps used by this driver. This doesn't take into account that other steps
can be used
Hi Sebastian,
El Mon, Sep 23, 2013 at 03:31:14PM +0200 Sebastian Andrzej Siewior ha dit:
On 09/10/2013 11:02 PM, Matthias Kaehlcke wrote:
The calculation of the old conversion timeout value was based on the number
of
channels used by this driver. This doesn't take into account that other
The ADC clock divider needs to be restored on resume as the register content
is lost when the ADC is powered down
Signed-off-by: Matthias Kaehlcke matth...@kaehlcke.net
---
drivers/mfd/ti_am335x_tscadc.c | 10 ++
include/linux/mfd/ti_am335x_tscadc.h |1 +
2 files changed, 7
When returning from suspend the FIFO threshold interrupt is
disabled, re-enable it on resume
Signed-off-by: Matthias Kaehlcke matth...@kaehlcke.net
---
drivers/input/touchscreen/ti_am335x_tsc.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/input/touchscreen/ti_am335x_tsc.c
b
Hi Peter,
Thanks for your work on this, a few comments inline
On 07/20/2016 02:40 AM, Peter Chen wrote:
...
+static int pwrseq_generic_on(struct device_node *np, struct pwrseq *pwrseq)
+{
...
+ if (gpiod_reset) {
+ u32 duration_us = 50;
+
+
off-by: Peter Chen <peter.c...@nxp.com>
> Tested-by Joshua Clayton <stillcompil...@gmail.com>
Reviewed-by: Matthias Kaehlcke <m...@chromium.org>
Tested-by: Matthias Kaehlcke <m...@chromium.org>
El Tue, Aug 02, 2016 at 11:30:48AM +0800 Peter Chen ha dit:
> diff --git a/drivers/power/pwrseq/core.c b/drivers/power/pwrseq/core.c
>
> ...
>
> +static DEFINE_MUTEX(pwrseq_list_mutex);
> +static LIST_HEAD(pwrseq_list);
> +
> +int pwrseq_get(struct device_node *np, struct pwrseq *p)
> +{
> +
Rob, thanks for your comments!
El Tue, Feb 21, 2017 at 06:22:14PM -0600 Rob Herring ha dit:
> On Fri, Feb 10, 2017 at 12:43:48PM -0800, Matthias Kaehlcke wrote:
> > The output voltage of a voltage controlled regulator can be controlled
> > through the voltage of another regulat
The output voltage of a voltage controlled regulator can be controlled
through the voltage of another regulator. The current version of this
driver assumes that the output voltage is a linear function of the control
voltage.
Signed-off-by: Matthias Kaehlcke <m...@chromium.org>
--
El Fri, Feb 10, 2017 at 12:43:48PM -0800 Matthias Kaehlcke ha dit:
> The output voltage of a voltage controlled regulator can be controlled
> through the voltage of another regulator. The current version of this
> driver assumes that the output voltage is a linear function of th
El Fri, Feb 24, 2017 at 07:19:19PM -0800 Matthias Kaehlcke ha dit:
> El Tue, Feb 21, 2017 at 06:22:14PM -0600 Rob Herring ha dit:
> >
> > > +Optional properties:
> > > +
> > > ...
> > > +- min-slew-down-rate : Describes how s
of the stabilization time is done in the same place for both types of
regulators.
Signed-off-by: Matthias Kaehlcke <m...@chromium.org>
---
Changes in v4:
- This patch is new for v4.
drivers/regulator/core.c | 140 +--
include/linux/regulator/driver.h | 8 +++
2
Use the new set_voltage_time() op to calculate the stabilization time
instead of duplicating the calculation in the core code.
Signed-off-by: Matthias Kaehlcke <m...@chromium.org>
---
Changes in v4:
- This patch is new for v4.
drivers/regulator/pwm-regulator.c | 10 +-
1 file chan
ouglas Anderson <diand...@chromium.org>
Signed-off-by: Matthias Kaehlcke <m...@chromium.org>
---
Changes in v4:
- Moved from PWM regulator to regulator core
- Added 'regulator' prefix to device tree properties
.../devicetree/bindings/regulator/regulator.txt| 7 +++
driver
Signed-off-by: Matthias Kaehlcke <m...@chromium.org>
Signed-off-by: Douglas Anderson <diand...@chromium.org>
---
Changes in v4:
- Moved from PWM regulator to regulator core
- Added 'regulator' prefix to device tree property
.../devicetree/bindings/regulator/regulator.txt| 2 ++
dr
Hi Mark,
thanks for your review, please find my comments (including info from
our EE) below.
El Mon, Sep 12, 2016 at 07:56:33PM +0100 Mark Brown ha dit:
> On Tue, Sep 06, 2016 at 12:05:24PM -0700, Matthias Kaehlcke wrote:
>
> > On some boards it's possible that transitioning the P
El Mon, Sep 12, 2016 at 06:18:31PM -0700 Matthias Kaehlcke ha dit:
> El Tue, Sep 13, 2016 at 12:57:58AM +0100 Mark Brown ha dit:
>
> > On Mon, Sep 12, 2016 at 04:18:51PM -0700, Matthias Kaehlcke wrote:
> > > El Mon, Sep 12, 2016 at 07:32:30PM +0100 Mark Brown ha dit:
> &g
is used to calculate the delay.
This change also removes the ramp_delay calculation in the PWM
regulator, since the driver now uses the core code for the calculation
of the delay.
Signed-off-by: Matthias Kaehlcke <m...@chromium.org>
---
Changes in v5:
- Use _regulator_set_voltage_time() as d
<diand...@chromium.org>
Signed-off-by: Matthias Kaehlcke <m...@chromium.org>
---
Changes in v5:
- Leave set_voltage tracepoints where they were
- Fixed error handling in code dealing with the device tree, return an error if
configuration is invalid
- Fixed coding style and formatting issues
- Upda
. This change introduces the device tree properties
"regulator-settle-time-up-us"/"regulator-settle-time-down-us" which
allow to specify a fixed delay after a voltage increase or decrease.
Signed-off-by: Matthias Kaehlcke <m...@chromium.org>
---
Changes in v5:
- Added support for
If the voltage can not be set jump to the end of the function. This
avoids having to check for an error multiple times and eliminates one
level of nesting in a follow-up change.
Signed-off-by: Matthias Kaehlcke <m...@chromium.org>
---
Changes in v5:
- This patch is new for v5.
drivers/reg
Signed-off-by: Matthias Kaehlcke <m...@chromium.org>
---
Changes in v5:
- This patch is new for v5.
drivers/regulator/core.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index db320e8..b
delay is specified. Remove the check in
_regulator_do_set_voltage(), the functions calculating the ramp delay
return 0 anyway when the ramp delay is not configured.
Signed-off-by: Matthias Kaehlcke <m...@chromium.org>
---
Changes in v5:
- This patch is new for v5.
drivers/regulator/core
El Tue, Sep 13, 2016 at 12:57:58AM +0100 Mark Brown ha dit:
> On Mon, Sep 12, 2016 at 04:18:51PM -0700, Matthias Kaehlcke wrote:
> > El Mon, Sep 12, 2016 at 07:32:30PM +0100 Mark Brown ha dit:
> > > On Tue, Sep 06, 2016 at 12:03:15PM -0700, Matthias Kaehlcke wrote:
>
&g
Hi Mark,
thanks for your review, please find some comments below.
El Mon, Sep 12, 2016 at 07:32:30PM +0100 Mark Brown ha dit:
> On Tue, Sep 06, 2016 at 12:03:15PM -0700, Matthias Kaehlcke wrote:
>
> Whatever you're using to send these is not threading things as expected
> a
Hi Mark,
El Thu, Sep 15, 2016 at 03:39:45PM +0100 Mark Brown ha dit:
> On Tue, Sep 13, 2016 at 10:21:40AM -0700, Matthias Kaehlcke wrote:
>
> > Optimizing the delay time depends on the SoC; we have not measured
> > this across a wide variety of devices and thus have
El Fri, Sep 16, 2016 at 05:32:53PM +0100 Mark Brown ha dit:
> On Thu, Sep 15, 2016 at 11:02:23AM -0700, Matthias Kaehlcke wrote:
> > El Thu, Sep 15, 2016 at 03:39:45PM +0100 Mark Brown ha dit:
>
> > > The obvious question here is how the OVP hardware knows about the new
pecify a
fixed delay after a voltage increase or decrease. Often it is not
strictly necessary for a voltage decrease to complete, therefore the
delays may be asymmetric. For regulators with a ramp delay the
corresponding settle time is added to the ramp delay.
Signed-off-by: Matthias Kaehlck
mp delay.
Change-Id: Ib3543a250e1dfc14964ec72bd2684237728a08a3
Signed-off-by: Matthias Kaehlcke <m...@chromium.org>
---
.../bindings/regulator/pwm-regulator.txt | 10 +
drivers/regulator/pwm-regulator.c | 24 ++
2 files changed, 30 insertions(+), 4 deletions(-)
diff --git
Hi,
El Thu, Oct 27, 2016 at 07:45:32PM +0200 H. Nikolaus Schaller ha dit:
> > Am 27.10.2016 um 19:41 schrieb Matthias Kaehlcke <m...@chromium.org>:
> >
> > El Thu, Oct 27, 2016 at 02:31:39PM +0200 H. Nikolaus Schaller ha dit:
> >
> >> commit 73e705bf81ce
El Thu, Oct 27, 2016 at 02:31:39PM +0200 H. Nikolaus Schaller ha dit:
> commit 73e705bf81ce ("regulator: core: Add set_voltage_time op")
>
> introduced a new rdev_warn() if the ramp_delay is 0.
>
> Apparently, on omap3/twl4030 platforms with dynamic voltage
> management this results in
Hi,
El Tue, Dec 13, 2016 at 12:00:32PM -0800 Doug Anderson ha dit:
> On Tue, Dec 13, 2016 at 9:19 AM, Mark Brown <broo...@kernel.org> wrote:
> > On Mon, Dec 12, 2016 at 01:15:02PM -0800, Matthias Kaehlcke wrote:
> >> El Fri, Oct 28, 2016 at 07:15:21PM +0100 Mark Brown ha
El Fri, Oct 28, 2016 at 07:15:21PM +0100 Mark Brown ha dit:
> On Mon, Sep 26, 2016 at 10:41:59AM -0700, Doug Anderson wrote:
>
> > I guess I think of the whole network of components as the PWM
> > regulator and not the individual discreet BUCK. I'm also not quite
> > sure how you would model it
El Mon, Mar 20, 2017 at 12:06:15PM + Mark Brown ha dit:
> On Fri, Mar 17, 2017 at 05:03:30PM -0700, Matthias Kaehlcke wrote:
>
> > In principle I totally agree with you that consumers should be able
> > to enumerate the supported voltages with the existing functions
El Mon, Mar 27, 2017 at 01:54:50PM -0400 Javier Martinez Canillas ha dit:
> On 03/27/2017 01:39 PM, Matthias Kaehlcke wrote:
>
> >>>> +if (ops->get_voltage || ops->get_voltage_sel)
> >>
> >> It's valid to have a .get_voltage_sel callbac
Thanks for the reviews and testing!
El Sat, Mar 25, 2017 at 02:05:47AM -0300 Javier Martinez Canillas ha dit:
On 03/24/2017 05:38 PM, Brian Norris wrote:
> > On Fri, Mar 24, 2017 at 01:09:52PM -0700, Matthias Kaehlcke wrote:
> >> diff --git a/drivers/regulator/core.c b/drivers/r
El Mon, Mar 27, 2017 at 12:47:59PM +0200 Johannes Berg ha dit:
> On Fri, 2017-03-24 at 18:06 -0700, Matthias Kaehlcke wrote:
> > __ieee80211_amsdu_copy_frag intentionally initializes a pointer to
> > array[-1] to increment it later to valid values. clang rightfully
> > gene
after consume.
Signed-off-by: Matthias Kaehlcke <m...@chromium.org>
---
net/wireless/util.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/net/wireless/util.c b/net/wireless/util.c
index 68e5f2ecee1a..52795ae5337f 100644
--- a/net/wireless/util.c
+++ b/net/wireless/
ect normal continuous regulators can leak details of their
supplies and provide consumers with inconsistent information.
Limit the propagation of the voltage count and list to regulators which
don't have get_voltage(_sel) and list_voltage ops.
Signed-off-by: Matthias Kaehlcke <m...@chromium.org&
to leave the rest of the
algorithm untouched.
Signed-off-by: Matthias Kaehlcke <m...@chromium.org>
---
net/wireless/util.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/wireless/util.c b/net/wireless/util.c
index 68e5f2ecee1a..d3d459e4a070 100644
--- a/net/wi
_TOOLCHAIN.
From: Behan Webster <beh...@converseincode.com>
Signed-off-by: Behan Webster <beh...@converseincode.com>
Reviewed-by: Jan-Simon Möller <dl...@gmx.de>
Reviewed-by: Mark Charlebois <charl...@gmail.com>
Signed-off-by: Greg Hackmann <ghackm...@google.com
101 - 200 of 2887 matches
Mail list logo