[PATCH v3 06/12] PM / devfreq: Make update_devfreq() public

Currently update_devfreq() is only visible to devfreq governors outside of devfreq.c. Make it public to allow drivers that adjust devfreq policies to cause a re-evaluation of the frequency after a policy change. Signed-off-by: Matthias Kaehlcke Acked-by: MyungJoo Ham --- Changes in v3: - none

[PATCH v3 09/12] dt-bindings: PM / OPP: add opp-throttlers property

The optional opp-throttlers property is used to configure the throttlers (see drivers/misc/throttler/*) that use a given OPP to throttle the corresponding device(s). Signed-off-by: Matthias Kaehlcke --- Changes in v3: - none Changes in v2: - patch added to series Documentation/devicetree

[PATCH v3 11/12] misc: throttler: Add Chrome OS EC throttler

The driver subscribes to throttling events from the Chrome OS embedded controller and enables/disables system throttling based on these events. Signed-off-by: Matthias Kaehlcke Reviewed-by: Enric Balletbo i Serra --- Changes in v3: - change module license to GPL v2 as in the SPDX identifier

[PATCH v3 07/12] PM / devfreq: export devfreq_class

Exporting the device class allows other parts of the kernel to enumerate the devfreq devices and receive notification when a devfreq device is added or removed. Signed-off-by: Matthias Kaehlcke --- Changes in v3: - none Changes in v2: - patch added to series drivers/devfreq/devfreq.c | 3

[PATCH v3 10/12] misc: throttler: Add core support for non-thermal throttling

is done by another (possibly platform specific) driver. Signed-off-by: Matthias Kaehlcke --- Changes in v3: - Kconfig: don't select CPU_FREQ and PM_DEVFREQ - added CONFIG_THROTTLER_DEBUG option - changed 'level' sysfs attribute to debugfs - introduced thr_ macros for logging - added debug logs - added

[PATCH v3 12/12] mfd: cros_ec: Add throttler sub-device

Instantiate the CrOS EC throttler if it is enabled in the kernel configuration. Signed-off-by: Matthias Kaehlcke --- Changes in v3: - patch added to series drivers/mfd/cros_ec.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/mfd/cros_ec.c b/drivers/mfd/cros_ec.c

[PATCH] kvm: x86: mmu: Add cast to negated bitmasks in update_permission_bitmask()

also raises a warning (see https://godbolt.org/g/6JWfWk), however it doesn't seem to be universally enabled) Signed-off-by: Matthias Kaehlcke --- arch/x86/kvm/mmu.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c index d634f033

Re: [PATCH] kvm: x86: mmu: Add cast to negated bitmasks in update_permission_bitmask()

On Fri, Jun 15, 2018 at 11:18:12AM -0700, Joe Perches wrote: > On Fri, 2018-06-15 at 11:04 -0700, Nick Desaulniers wrote: > > On Fri, Jun 15, 2018 at 10:47 AM Matthias Kaehlcke > > wrote: > > > > > > update_permission_bitmask() negates u8 bitmask values an

Re: [PATCH v3 01/12] PM / devfreq: Init user limits from OPP limits, not viceversa

On Fri, Jun 15, 2018 at 02:06:21PM -0700, Brian Norris wrote: > Hi, > > On Thu, Jun 14, 2018 at 12:47:01PM -0700, Matthias Kaehlcke wrote: > > Commit ab8f58ad72c4 ("PM / devfreq: Set min/max_freq when adding > > the devfreq device") introduced the initializa

clang: objtool: native_machine_emergency_restart() falls through to next function

Hi Josh, with your work on objtool and the upcoming implementation of -fno-delete-null-pointer-checks (https://reviews.llvm.org/D47894, https://reviews.llvm.org/D47895) in clang most objtool warnings for clang builds will be fixed. However even with -fno-delete-null-pointer-checks we currently

Re: [PATCH v7 2/2] regulator: add QCOM RPMh regulator driver

ers/regulator/Kconfig | 9 + > drivers/regulator/Makefile | 1 + > drivers/regulator/qcom-rpmh-regulator.c | 753 > > 3 files changed, 763 insertions(+) > create mode 100644 drivers/regulator/qcom-rpmh-regulator.c Reviewed-by: Matthias Kaehlcke

Re: [PATCH v6 2/2] regulator: add QCOM RPMh regulator driver

Hi David, On Mon, Jun 04, 2018 at 12:15:12PM -0700, David Collins wrote: > Add the QCOM RPMh regulator driver to manage PMIC regulators > which are controlled via RPMh on some Qualcomm Technologies, Inc. > SoCs. RPMh is a hardware block which contains several > accelerators which are used to

[PATCH] regulator: Fix typo in comment of struct regulator_linear_range

regulator_map_linar_range() => regulator_map_linear_range() Signed-off-by: Matthias Kaehlcke --- include/linux/regulator/driver.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/regulator/driver.h b/include/linux/regulator/driver.h index 4fc96cb8e

Re: [PATCH] kvm: x86: mmu: Add cast to negated bitmasks in update_permission_bitmask()

On Tue, Jun 19, 2018 at 11:07:47AM -0700, Joe Perches wrote: > On Tue, 2018-06-19 at 19:35 +0200, Paolo Bonzini wrote: > > On 19/06/2018 19:23, Joe Perches wrote: > > > On Tue, 2018-06-19 at 10:08 -0700, Nick Desaulniers wrote: > > > > On Tue, Jun 19, 2018 at 8:19 AM Paolo Bonzini > > > > wrote:

Re: [PATCH] kvm: x86: mmu: Add cast to negated bitmasks in update_permission_bitmask()

On Tue, Jun 19, 2018 at 07:13:41PM +0200, Paolo Bonzini wrote: > On 19/06/2018 19:08, Nick Desaulniers wrote: > >> This one really makes the code uglier though, so I'm not really inclined > >> to applying the patch. > > Note that of the three variables (w, u, x), only u is used later on. > > What

[PATCH v2] kvm: x86: mmu: Add cast to negated bitmasks in update_permission_bitmask()

also raises a warning (see https://godbolt.org/g/6JWfWk), however it doesn't seem to be universally enabled) Suggested-by: Nick Desaulniers Signed-off-by: Matthias Kaehlcke --- Changes in v2: - negate the bitmask at initialization and rename variables to not_X arch/x86/kvm/mmu.c | 11 ++

Re: [PATCH v3 12/12] mfd: cros_ec: Add throttler sub-device

> > > On Thu, Jun 14, 2018 at 12:47:12PM -0700, Matthias Kaehlcke wrote: > > > Instantiate the CrOS EC throttler if it is enabled in the kernel > > > configuration. > > > > > > Signed-off-by: Matthias Kaehlcke > > > --- >

Re: [PATCH] objtool: Add machine_real_restart() to the noreturn list

.o: warning: objtool: > native_machine_emergency_restart() falls through to next function > machine_power_off() > > Reported-by: Matthias Kaehlcke > Signed-off-by: Josh Poimboeuf Tested-by: Matthias Kaehlcke Reviewed-by: Matthias Kaehlcke Thanks!

Re: [PATCH v3 12/12] mfd: cros_ec: Add throttler sub-device

On Mon, Jun 18, 2018 at 04:21:10PM -0700, Brian Norris wrote: > Hi, > > On Thu, Jun 14, 2018 at 12:47:12PM -0700, Matthias Kaehlcke wrote: > > Instantiate the CrOS EC throttler if it is enabled in the kernel > > configuration. > > > > Signed-off-by: Matthias Ka

Re: [PATCH] kvm: x86: mmu: Add cast to negated bitmasks in update_permission_bitmask()

On Tue, Jun 19, 2018 at 12:11:27PM -0700, Joe Perches wrote: > On Tue, 2018-06-19 at 11:36 -0700, Matthias Kaehlcke wrote: > > On Tue, Jun 19, 2018 at 11:07:47AM -0700, Joe Perches wrote: > > > On Tue, 2018-06-19 at 19:35 +0200, Paolo Bonzini wrote: > > > > On 19/06

Re: [PATCH] kvm: x86: mmu: Add cast to negated bitmasks in update_permission_bitmask()

On Tue, Jun 19, 2018 at 02:55:05PM -0700, Joe Perches wrote: > On Tue, 2018-06-19 at 14:10 -0700, Matthias Kaehlcke wrote: > > On Tue, Jun 19, 2018 at 12:11:27PM -0700, Joe Perches wrote: > > > -Wconstant-conversion is only issued when a *constant value* is assigned > >

Re: [PATCH v2 09/11] misc: throttler: Add core support for non-thermal throttling

Hi, On Mon, Jun 11, 2018 at 06:49:13PM -0700, Brian Norris wrote: > Hi! > > A few comments, but I didn't get to finish a thorough review yet. > > > On Thu, Jun 07, 2018 at 11:12:12AM -0700, Matthias Kaehlcke wrote: > > The purpose of the throttler is to provide

Re: [PATCH 02/11] PM / devfreq: Fix handling of min/max_freq == 0

On Mon, May 28, 2018 at 03:37:47PM +0900, Chanwoo Choi wrote: > Hi, > > On 2018년 05월 26일 05:30, Matthias Kaehlcke wrote: > > Commit ab8f58ad72c4 ("PM / devfreq: Set min/max_freq when adding the > > devfreq device") initializes df->min/max_freq with the min/ma

Re: [PATCH 07/11] PM / devfreg: Add support policy notifiers

gt; >Also add a few helpers: > > - devfreq_verify_within_[dev_]limits() > >- should be used by the notifiers for policy adjustments. > > - dev_to_devfreq() > >- lookup a devfreq strict from a device pointer > > > >Signed-of

Re: [PATCH 01/11] PM / devfreq: Init user limits from OPP limits, not viceversa

On Mon, May 28, 2018 at 02:26:49PM +0900, Chanwoo Choi wrote: > Hi, > > On 2018년 05월 26일 05:30, Matthias Kaehlcke wrote: > > Commit ab8f58ad72c4 ("PM / devfreq: Set min/max_freq when adding > > the devfreq device") introduced the initialization of the user > >

Re: [PATCH 05/11] PM / devfreq: governors: Return device frequency limits instead of user limits

t; >with the user limits if necessary, therefore we can return > >df->scaling_min/max_freq instead, which is the min/max frequency > >supported by the device at a given time (depending on the > >enabled/disabled OPPs) > > > >Signed-off-by: Matthias Kaehlc

Re: [PATCH 02/11] PM / devfreq: Fix handling of min/max_freq == 0

On Wed, May 30, 2018 at 05:04:14PM +0900, Chanwoo Choi wrote: > Hi, > > On 2018년 05월 30일 03:57, Matthias Kaehlcke wrote: > > On Mon, May 28, 2018 at 03:37:47PM +0900, Chanwoo Choi wrote: > >> Hi, > >> > >> On 2018년 05월 26일 05:30, Matthias Kaehlcke wrote

Re: [PATCH 09/11] misc: throttler: Add core support for non-thermal throttling

On Mon, May 28, 2018 at 10:08:26AM +0200, Greg Kroah-Hartman wrote: > On Fri, May 25, 2018 at 01:30:41PM -0700, Matthias Kaehlcke wrote: > > diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile > > index 20be70c3f118..01a1714dd2ad 100644 > > --- a/drivers/misc/Makefile &

Re: [PATCH 09/11] misc: throttler: Add core support for non-thermal throttling

the effort to get a limited version of the driver merged, and then learn that I wasted my own and the reviewers time because it is a dead end. > On 2018년 05월 26일 05:30, Matthias Kaehlcke wrote: > > The purpose of the throttler is to provide support for non-thermal > > throttling. Thr

Re: [PATCH 10/11] dt-bindings: misc: add bindings for throttler

Hi Rob, On Thu, May 31, 2018 at 11:31:59AM -0500, Rob Herring wrote: > On Fri, May 25, 2018 at 01:30:42PM -0700, Matthias Kaehlcke wrote: > > Commit msg? Will add some more info in the next revision. > > Signed-off-by: Matthias Kaehlcke > > --- > > .../devicetree/

Re: [PATCH 11/11] misc/throttler: Add Chrome OS EC throttler

> 2018-05-25 22:30 GMT+02:00 Matthias Kaehlcke : > > The driver subscribes to throttling events from the Chrome OS > > embedded controller and enables/disables system throttling based > > on these events. > > > > Signed-off-by: Matthias Kaehlcke > > ---

Re: [PATCH 10/11] dt-bindings: misc: add bindings for throttler

On Thu, May 31, 2018 at 03:04:18PM -0500, Rob Herring wrote: > On Thu, May 31, 2018 at 1:34 PM, Matthias Kaehlcke wrote: > > Hi Rob, > > > > On Thu, May 31, 2018 at 11:31:59AM -0500, Rob Herring wrote: > >> On Fri, May 25, 2018 at 01:30:42PM -0700, Matthias Kaehlc

Re: [PATCH 3/3] arm64: dts: qcom: pm8998: Add thermal zone

On Thu, Jun 28, 2018 at 03:58:41PM -0700, Doug Anderson wrote: > Hi, > > On Thu, Jun 28, 2018 at 2:09 PM, Matthias Kaehlcke wrote: > > Add pm8998 thermal zone based on the examples in the spmi-temp-alarm > > bindings. > > > > Note: devices with the pm8998 ne

Re: [PATCH 1/3] arm64: dts: qcom: sdm845: Add thermal-zones node

On Thu, Jun 28, 2018 at 03:52:57PM -0700, Doug Anderson wrote: > Hi, > > On Thu, Jun 28, 2018 at 2:09 PM, Matthias Kaehlcke wrote: > > The node is empty for now. It is needed to allow other DT snippets > > to add thermal zone entries. > > > > Signed-off-by: Mat

Re: [PATCH v8 4/7] Bluetooth: hci_qca: Add wrapper functions for setting UART speed

On Fri, Jun 29, 2018 at 08:59:38PM +0530, Balakrishna Godavarthi wrote: > Hi Matthias, > > On 2018-06-27 00:32, Matthias Kaehlcke wrote: > > On Tue, Jun 26, 2018 at 07:01:18AM +0530, Balakrishna Godavarthi wrote: > > > Hi Matthias, > > > > > > On

Re: [PATCH 3/3] arm64: dts: qcom: pm8998: Add thermal zone

On Fri, Jun 29, 2018 at 02:29:55PM -0700, David Collins wrote: > Hello Matthias, > > On 06/29/2018 11:51 AM, Matthias Kaehlcke wrote: > > On Thu, Jun 28, 2018 at 03:58:41PM -0700, Doug Anderson wrote: > >> Hi, > >> > >> On Thu, Jun 28, 2018 at 2:09 PM,

Re: [PATCH v8 4/7] Bluetooth: hci_qca: Add wrapper functions for setting UART speed

On Tue, Jun 26, 2018 at 10:43:31AM +0530, Balakrishna Godavarthi wrote: > Hi Matthias, > > On 2018-06-26 05:35, Matthias Kaehlcke wrote: > > On Mon, Jun 25, 2018 at 04:43:54PM -0700, Matthias Kaehlcke wrote: > > > This is a nice improvement, a few remaining questions inl

Re: [PATCH v8 4/7] Bluetooth: hci_qca: Add wrapper functions for setting UART speed

On Tue, Jun 26, 2018 at 07:01:18AM +0530, Balakrishna Godavarthi wrote: > Hi Matthias, > > On 2018-06-26 05:13, Matthias Kaehlcke wrote: > > This is a nice improvement, a few remaining questions inline. > > > > On Mon, Jun 25, 2018 at 07:10:10PM +0530, B

Re: [PATCH] Bluetooth: hci_qca: Replace open-coded msleep()

Make things clearer by just calling msleep() instead. > > Cc: Thierry Escande > Signed-off-by: Stephen Boyd Reviewed-off-by: Matthias Kaehlcke

Re: [PATCH v4 09/12] dt-bindings: PM / OPP: add opp-throttlers property

On Tue, Jun 26, 2018 at 09:49:49AM -0600, Rob Herring wrote: > On Mon, Jun 25, 2018 at 2:03 PM Matthias Kaehlcke wrote: > > > > On Mon, Jun 25, 2018 at 11:50:37AM -0700, Matthias Kaehlcke wrote: > > > Hi Rob, > > > > > > On Mon, Jun 25, 2018 at 09:33:41A

Re: [PATCH v8 3/7] Bluetooth: btqca: Redefine qca_uart_setup() to generic function.

On Tue, Jun 26, 2018 at 06:53:47AM +0530, Balakrishna Godavarthi wrote: > Hi Matthias, > > On 2018-06-26 04:50, Matthias Kaehlcke wrote: > > On Mon, Jun 25, 2018 at 07:10:09PM +0530, Balakrishna Godavarthi wrote: > > > Redefinition of qca_uart_setup will help future Qual

Re: [PATCH v2] kvm: x86: mmu: Add cast to negated bitmasks in update_permission_bitmask()

Hi Paolo, On Mon, Jun 25, 2018 at 06:05:01PM +0200, Paolo Bonzini wrote: > On 19/06/2018 21:25, Matthias Kaehlcke wrote: > > update_permission_bitmask() negates u8 bitmask values and assigns them > > to variables of type u8. Since the MSB is set in the bitmask values the >

Re: [PATCH v8 2/7] Bluetooth: btqca: Rename ROME specific functions to Generic functions

> bt_dev_dbg updated from ROME to QCA where ever possible. This avoids > confusion to user, when using the future Qualcomm Bluetooth SoC's. > Updated BT_DBG, BT_ERR and BT_INFO with bt_dev_dbg, bt_dev_err and > bt_dev_info where ever applicable. > > Signed-off-by: Balakrishna Godavarthi Reviewed-by: Matthias Kaehlcke

Re: [PATCH v8 3/7] Bluetooth: btqca: Redefine qca_uart_setup() to generic function.

On Mon, Jun 25, 2018 at 07:10:09PM +0530, Balakrishna Godavarthi wrote: > Redefinition of qca_uart_setup will help future Qualcomm Bluetooth > SoC, to use the same function instead of duplicating the function. > Added new arguments soc_type and soc_ver to the functions. > > These arguments will

Re: [PATCH v8 4/7] Bluetooth: hci_qca: Add wrapper functions for setting UART speed

On Mon, Jun 25, 2018 at 04:43:54PM -0700, Matthias Kaehlcke wrote: > This is a nice improvement, a few remaining questions inline. > > On Mon, Jun 25, 2018 at 07:10:10PM +0530, Balakrishna Godavarthi wrote: > > In function qca_setup, we set initial and operating speeds for Qualcom

Re: [PATCH v8 4/7] Bluetooth: hci_qca: Add wrapper functions for setting UART speed

This is a nice improvement, a few remaining questions inline. On Mon, Jun 25, 2018 at 07:10:10PM +0530, Balakrishna Godavarthi wrote: > In function qca_setup, we set initial and operating speeds for Qualcomm > Bluetooth SoC's. This block of code is common across different > Qualcomm Bluetooth

Re: [PATCH v8 7/7] Bluetooth: hci_qca: Add support for Qualcomm Bluetooth chip wcn3990

On Mon, Jun 25, 2018 at 07:10:13PM +0530, Balakrishna Godavarthi wrote: > Add support to set voltage/current of various regulators > to power up/down Bluetooth chip wcn3990. > > Signed-off-by: Balakrishna Godavarthi > --- > changes in v8: > * closing qca buffer, if qca_power_setup fails >

Re: [PATCH v4 09/12] dt-bindings: PM / OPP: add opp-throttlers property

On Mon, Jun 25, 2018 at 11:50:37AM -0700, Matthias Kaehlcke wrote: > Hi Rob, > > On Mon, Jun 25, 2018 at 09:33:41AM -0600, Rob Herring wrote: > > On Wed, Jun 20, 2018 at 06:52:34PM -0700, Matthias Kaehlcke wrote: > > > The optional opp-throttlers property is used to

Re: [PATCH v4 09/12] dt-bindings: PM / OPP: add opp-throttlers property

Hi Rob, On Mon, Jun 25, 2018 at 09:33:41AM -0600, Rob Herring wrote: > On Wed, Jun 20, 2018 at 06:52:34PM -0700, Matthias Kaehlcke wrote: > > The optional opp-throttlers property is used to configure the throttlers > > (see drivers/misc/throttler/*) that use a given

Re: [PATCH v4 10/12] misc: throttler: Add core support for non-thermal throttling

On Thu, Jun 21, 2018 at 07:04:33PM -0700, Brian Norris wrote: > Hi, > > A few more things I noticed; probably my last thoughts on this > particular patch; and I think I reviewed the rest: > > On Wed, Jun 20, 2018 at 06:52:35PM -0700, Matthias Kaehlcke wrote: > > The

Re: [PATCH] kvm: x86: mmu: Add cast to negated bitmasks in update_permission_bitmask()

On Tue, Jun 19, 2018 at 05:18:02PM -0700, Joe Perches wrote: > On Tue, 2018-06-19 at 16:45 -0700, Matthias Kaehlcke wrote: > > On Tue, Jun 19, 2018 at 02:55:05PM -0700, Joe Perches wrote: > > > Well, you advocate to disable a possibly useful warning globally ... > > > Y

[PATCH v4 10/12] misc: throttler: Add core support for non-thermal throttling

is done by another (possibly platform specific) driver. Signed-off-by: Matthias Kaehlcke --- Changes in v4: - removed OOM logs - "does have no" => "has no" in log message - changed 'level' to unsigned int - hold mutex in throttler_set_level() when checking if level has change

[PATCH v4 06/12] PM / devfreq: Make update_devfreq() public

Currently update_devfreq() is only visible to devfreq governors outside of devfreq.c. Make it public to allow drivers that adjust devfreq policies to cause a re-evaluation of the frequency after a policy change. Signed-off-by: Matthias Kaehlcke Acked-by: MyungJoo Ham Reviewed-by: Brian Norris

[PATCH v4 07/12] PM / devfreq: export devfreq_class

Exporting the device class allows other parts of the kernel to enumerate the devfreq devices and receive notification when a devfreq device is added or removed. Signed-off-by: Matthias Kaehlcke Reviewed-by: Brian Norris --- Changes in v4: - added 'Reviewed-by: Brian Norris ' tag Changes in v3

[PATCH v4 05/12] PM / devfreq: Add support for policy notifiers

for policy adjustments. - dev_to_devfreq() - lookup a devfreq strict from a device pointer Signed-off-by: Matthias Kaehlcke Reviewed-by: Brian Norris --- Changes in v4: - Fixed typo in commit message: devfreg => devfreq - added 'Reviewed-by: Brian Norris ' tag Changes in v3: - devfreq.h: fi

[PATCH v4 03/12] PM / devfreq: Don't adjust to user limits in governors

let update_devfreq() take care of any adjustments. Signed-off-by: Matthias Kaehlcke Reviewed-by: Brian Norris --- Changes in v4: - added 'Reviewed-by: Brian Norris ' tag Changes in v3: - none Changes in v2: - squashed "PM / devfreq: Remove redundant frequency adjustment from governors&qu

[PATCH v4 02/12] PM / devfreq: Fix handling of min/max_freq == 0

lue of 0. This also prevents df->max_freq from being set below the min OPP when df->min_freq is 0, and similar for min_freq. Since it is now guaranteed that df->min/max_freq can't be 0 the checks for this case can be removed. Fixes: f1d981eaecf8 ("PM / devfreq: Use the availa

[PATCH v4 04/12] PM / devfreq: Add struct devfreq_policy

fo.min/max_freq df->governor => p->governor df->governor_name => p->governor_name Signed-off-by: Matthias Kaehlcke Reviewed-by: Brian Norris --- Changes in v4: - added 'Reviewed-by: Brian Norris ' tag Changes in v3: - none Changes in v2: - perfo

[PATCH v4 12/12] mfd: cros_ec: Add throttler sub-device

Instantiate the CrOS EC throttler if it is enabled in the kernel configuration. Signed-off-by: Matthias Kaehlcke --- Changes in v4: - register throttler in cros_ec_dev.c instead of cros_ec.c Changes in v3: - patch added to series --- drivers/mfd/cros_ec_dev.c | 19 +++ 1 file

[PATCH v4 11/12] misc: throttler: Add Chrome OS EC throttler

The driver subscribes to throttling events from the Chrome OS embedded controller and enables/disables system throttling based on these events. Signed-off-by: Matthias Kaehlcke Reviewed-by: Enric Balletbo i Serra Reviewed-by: Brian Norris --- Changes in v4: - adapt to parent being struct

Re: [PATCH] kvm: x86: mmu: Add cast to negated bitmasks in update_permission_bitmask()

On Wed, Jun 20, 2018 at 10:02:15AM +0200, Paolo Bonzini wrote: > On 20/06/2018 01:45, Matthias Kaehlcke wrote: > > > > v4.16 with an x86 allyesconfig and a few drivers disabled since they > > don't build with clang (yet): > > > > 16 occurrences of -Wconstant-con

[PATCH v4 08/12] cpufreq: Add stub for cpufreq_update_policy()

cpufreq_update_policy() allows the throttler driver to be built without ugly #ifdef'ery when cpufreq is disabled. Signed-off-by: Matthias Kaehlcke Reviewed-by: Brian Norris --- Changes in v4: - added 'Reviewed-by: Brian Norris ' tag Changes in v3: - patch added to series --- include/linux/cpufreq.h | 1 + 1

[PATCH v4 00/12] Add throttler driver for non-thermal throttling

devices the series introduces the concept of a devfreq policy and the DEVFREQ_ADJUST notifier (similar to CPUFREQ_ADJUST). Further it includes some related devfreq bugfixes and improvements that change some of the code that is also touched by the policy changes. Matthias Kaehlcke (12): PM / devfreq

[PATCH v4 09/12] dt-bindings: PM / OPP: add opp-throttlers property

The optional opp-throttlers property is used to configure the throttlers (see drivers/misc/throttler/*) that use a given OPP to throttle the corresponding device(s). Signed-off-by: Matthias Kaehlcke Reviewed-by: Brian Norris --- Changes in v4: - added 'Reviewed-by: Brian Norris ' tag Changes

[PATCH v4 01/12] PM / devfreq: Init user limits from OPP limits, not viceversa

q with the OPP freqs and then the user limts min/max_freq with scaling_min/ max_freq. Needless to say that this change is a NOP, intended to improve readability. Signed-off-by: Matthias Kaehlcke Reviewed-by: Chanwoo Choi Reviewed-by: Brian Norris --- Changes in v4: - added 'Reviewed-by: Brian Norris

Re: [PATCH v5 1/8] interconnect: Add generic on-chip interconnect API

Hi Georgi, On Wed, Jun 20, 2018 at 03:11:34PM +0300, Georgi Djakov wrote: > This patch introduce a new API to get requirements and configure the nit: s/introduce/introduces/ > interconnect buses across the entire chipset to fit with the current > demand. > > The API is using a

Re: [PATCH v5 4/8] interconnect: qcom: Add RPM communication

On Wed, Jun 20, 2018 at 03:11:37PM +0300, Georgi Djakov wrote: > On some Qualcomm SoCs, there is a remote processor, which controls some of > the Network-On-Chip interconnect resources. Other CPUs express their needs > by communicating with this processor. Add a driver to handle comminication

Re: [PATCH v5 1/8] interconnect: Add generic on-chip interconnect API

On Tue, Jun 26, 2018 at 01:57:21PM -0700, Evan Green wrote: > Hi Georgi. Thanks for the new spin of this. > > On Wed, Jun 20, 2018 at 5:11 AM Georgi Djakov > wrote: > > > > This patch introduce a new API to get requirements and configure the > > interconnect buses across the entire chipset to

Re: [PATCH v2 1/2] arm64: dts: qcom: pm8998: Add spmi-temp-alarm node

On Mon, Jul 02, 2018 at 01:12:01PM -0700, Doug Anderson wrote: > Hi, > > On Mon, Jul 2, 2018 at 11:10 AM, Matthias Kaehlcke wrote: > > This adds the spmi-temp-alarm node to pm8998 based on the examples in the > > bindings. > > > > Signed-off-by: Matthias Ka

Re: [PATCH v2 2/2] arm64: dts: qcom: pm8998: Add pm8998 thermal zone

On Mon, Jul 02, 2018 at 01:46:11PM -0700, Matthias Kaehlcke wrote: > On Mon, Jul 02, 2018 at 12:53:44PM -0700, Doug Anderson wrote: > > Hi, > > > > On Mon, Jul 2, 2018 at 11:10 AM, Matthias Kaehlcke > > wrote: > > > The thermal zone uses spmi

Re: [PATCH v2 2/2] arm64: dts: qcom: pm8998: Add pm8998 thermal zone

On Mon, Jul 02, 2018 at 12:53:44PM -0700, Doug Anderson wrote: > Hi, > > On Mon, Jul 2, 2018 at 11:10 AM, Matthias Kaehlcke wrote: > > The thermal zone uses spmi-temp-alarm as sensor. If the sensor is > > configured without an IIO input it always reports 37°C for temperature

[PATCH v2 2/2] arm64: dts: qcom: pm8998: Add pm8998 thermal zone

. Signed-off-by: Matthias Kaehlcke --- Changes in v2: - defined 'thermal-zones' node in pm8998.dtsi instead of using a label to refer to it - use 105°C hardware trip point as critical trip point - reduced number of trip points to 2 - lowered temperature of passive trip point - updated trip point

[PATCH v2 1/2] arm64: dts: qcom: pm8998: Add spmi-temp-alarm node

This adds the spmi-temp-alarm node to pm8998 based on the examples in the bindings. Signed-off-by: Matthias Kaehlcke --- Changes in v2: - none arch/arm64/boot/dts/qcom/pm8998.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/pm8998.dtsi b/arch/arm64/boot

Re: [Intel-gfx] [PATCH v2] drm/i915: Disable some extra clang warnings

On Mon, Apr 30, 2018 at 10:01:50PM +0100, Chris Wilson wrote: > Quoting Matthias Kaehlcke (2018-04-30 21:51:45) > > On Mon, Apr 30, 2018 at 09:01:49PM +0100, Chris Wilson wrote: > > > Quoting Matthias Kaehlcke (2018-04-30 20:31:19) > > > > On Mon, Mar 19, 2018

[PATCH v3] drm/i915: Disable some extra clang warnings

e code has been fixed. Signed-off-by: Matthias Kaehlcke <m...@chromium.org> --- Changes in v3: - don't disable -Wunneeded-internal-declaration , the only occurrence can be fixed in the code - removed 'Fixes' tag, since backporting is not necessary drivers/gpu/drm/i915/Makefile | 4 1

Re: [PATCH v6 04/10] drivers: qcom: rpmh: add RPMH helper functions

Hi Lina, On Thu, Apr 19, 2018 at 04:16:29PM -0600, Lina Iyer wrote: > Sending RPMH requests and waiting for response from the controller > through a callback is common functionality across all platform drivers. > To simplify drivers, add a library functions to create RPMH client and > send

Re: [Intel-gfx] [PATCH v2] drm/i915: Disable some extra clang warnings

On Mon, Apr 30, 2018 at 09:01:49PM +0100, Chris Wilson wrote: > Quoting Matthias Kaehlcke (2018-04-30 20:31:19) > > On Mon, Mar 19, 2018 at 12:14:51PM -0700, Matthias Kaehlcke wrote: > > > Commit 39bf4de89ff7 ("drm/i915: Add -Wall -Wextra to our build, set > > >

Re: [PATCH v6 05/10] drivers: qcom: rpmh-rsc: write sleep/wake requests to TCS

Hi Lina, On Tue, May 01, 2018 at 10:10:10AM -0600, Lina Iyer wrote: > On Fri, Apr 27 2018 at 17:24 -0600, Doug Anderson wrote: > > Hi, > > > > On Fri, Apr 27, 2018 at 2:54 PM, Matthias Kaehlcke <m...@chromium.org> > > wrote: > >

Re: [PATCH v2] drm/i915: Disable some extra clang warnings

On Mon, Mar 19, 2018 at 12:14:51PM -0700, Matthias Kaehlcke wrote: > Commit 39bf4de89ff7 ("drm/i915: Add -Wall -Wextra to our build, set > warnings to full") enabled extra warnings for i915 to spot possible > bugs in new code, and then disabled a subset of these warnings to keep

Re: [PATCH v7 05/10] drivers: qcom: rpmh-rsc: write sleep/wake requests to TCS

Hi Lina, On Wed, May 02, 2018 at 01:37:44PM -0600, Lina Iyer wrote: > Sleep and wake requests are sent when the application processor > subsystem of the SoC is entering deep sleep states like in suspend. > These requests help lower the system power requirements when the > resources are not in

Re: [PATCH v7 06/10] drivers: qcom: rpmh-rsc: allow invalidation of sleep/wake TCS

Hi Lina, On Wed, May 02, 2018 at 01:37:45PM -0600, Lina Iyer wrote: > Allow sleep and wake commands to be cleared from the respective TCSes, > so that they can be re-populated. > > Signed-off-by: Lina Iyer > --- > > Changes in v7: > - Move bitmap_zero() outside the

[PATCH v5 10/12] misc: throttler: Add core support for non-thermal throttling

is done by another (possibly platform specific) driver. Signed-off-by: Matthias Kaehlcke -- Changes in v5: - read throttling OPPs using new device tree binding (throttler-opps = <...>) - thr_get_throttling_freq(): removed warning - thr_handle_cpufreq_event(): merged similar

[PATCH v5 07/12] PM / devfreq: export devfreq_class

Exporting the device class allows other parts of the kernel to enumerate the devfreq devices and receive notification when a devfreq device is added or removed. Signed-off-by: Matthias Kaehlcke Reviewed-by: Brian Norris --- Changes in v5: - none Changes in v4: - added 'Reviewed-by: Brian

[PATCH v5 05/12] PM / devfreq: Add support for policy notifiers

for policy adjustments. - dev_to_devfreq() - lookup a devfreq strict from a device pointer Signed-off-by: Matthias Kaehlcke Reviewed-by: Brian Norris --- Changes in v5: - none Changes in v4: - Fixed typo in commit message: devfreg => devfreq - added 'Reviewed-by: Brian Norris ' tag Changes in

[PATCH v5 11/12] misc: throttler: Add Chrome OS EC throttler

The driver subscribes to throttling events from the Chrome OS embedded controller and enables/disables system throttling based on these events. Signed-off-by: Matthias Kaehlcke Reviewed-by: Enric Balletbo i Serra Reviewed-by: Brian Norris --- Changes in v5: - none Changes in v4: - adapt

[PATCH v5 09/12] dt-bindings: misc: add bindings for throttler

The Throttler is used for non-thermal throttling of system components like CPUs or devfreq devices. Signed-off-by: Matthias Kaehlcke -- Changes in v5: - patch added to the series (replacing "dt-bindings: PM / OPP: add opp-throttlers property") --- .../devicetree/bindings/misc/thr

[PATCH v5 12/12] mfd: cros_ec: Add throttler sub-device

Instantiate the CrOS EC throttler if it is enabled in the kernel configuration. Signed-off-by: Matthias Kaehlcke Reviewed-by: Brian Norris --- Changes in v5: - added 'Reviewed-by: Brian Norris ' tag Changes in v4: - register throttler in cros_ec_dev.c instead of cros_ec.c Changes in v3

[PATCH v5 06/12] PM / devfreq: Make update_devfreq() public

Currently update_devfreq() is only visible to devfreq governors outside of devfreq.c. Make it public to allow drivers that adjust devfreq policies to cause a re-evaluation of the frequency after a policy change. Signed-off-by: Matthias Kaehlcke Acked-by: MyungJoo Ham Reviewed-by: Brian Norris

[PATCH v5 01/12] PM / devfreq: Init user limits from OPP limits, not viceversa

q with the OPP freqs and then the user limts min/max_freq with scaling_min/ max_freq. Needless to say that this change is a NOP, intended to improve readability. Signed-off-by: Matthias Kaehlcke Reviewed-by: Chanwoo Choi Reviewed-by: Brian Norris --- Changes in v5: - none Changes in v4: - added 'Revie

[PATCH v5 03/12] PM / devfreq: Don't adjust to user limits in governors

let update_devfreq() take care of any adjustments. Signed-off-by: Matthias Kaehlcke Reviewed-by: Brian Norris --- Changes in v5: - none Changes in v4: - added 'Reviewed-by: Brian Norris ' tag Changes in v3: - none Changes in v2: - squashed "PM / devfreq: Remove redundant frequency adjustm

[PATCH v5 04/12] PM / devfreq: Add struct devfreq_policy

fo.min/max_freq df->governor => p->governor df->governor_name => p->governor_name Signed-off-by: Matthias Kaehlcke Reviewed-by: Brian Norris --- Changes in v5: - none Changes in v4: - added 'Reviewed-by: Brian Norris ' tag Changes in v3: - none Cha

[PATCH v5 00/12] Add throttler driver for non-thermal throttling

devices the series introduces the concept of a devfreq policy and the DEVFREQ_ADJUST notifier (similar to CPUFREQ_ADJUST). Further it includes some related devfreq bugfixes and improvements that change some of the code that is also touched by the policy changes. Matthias Kaehlcke (12): PM / devfreq

[PATCH v5 02/12] PM / devfreq: Fix handling of min/max_freq == 0

lue of 0. This also prevents df->max_freq from being set below the min OPP when df->min_freq is 0, and similar for min_freq. Since it is now guaranteed that df->min/max_freq can't be 0 the checks for this case can be removed. Fixes: f1d981eaecf8 ("PM / devfreq: Use the availa

[PATCH v5 08/12] cpufreq: Add stub for cpufreq_update_policy()

cpufreq_update_policy() allows the throttler driver to be built without ugly #ifdef'ery when cpufreq is disabled. Signed-off-by: Matthias Kaehlcke Reviewed-by: Brian Norris --- Changes in v5: - none Changes in v4: - added 'Reviewed-by: Brian Norris ' tag Changes in v3: - patch added to series --- include/linux

Re: [PATCH v4 6/6] arm64: dts: sdm845: Add tsens nodes

Hi, On Mon, Jul 02, 2018 at 06:14:09PM +0530, Amit Kucheria wrote: > SDM845 has two tsens blocks, one with 13 sensors and the other with 8 > sensors. > > Signed-off-by: Amit Kucheria > --- > arch/arm64/boot/dts/qcom/sdm845.dtsi | 16 > 1 file changed, 16 insertions(+) > >

Re: [PATCH] ASoC: codecs: dmic: Use channel map for configs with a single mic

El Fri, Jan 05, 2018 at 12:04:55PM + Mark Brown ha dit: > On Fri, Jan 05, 2018 at 11:45:43AM +0100, Arnaud Pouliquen wrote: > > > >> + num-channels = <1>; > > > In your implementation seems not linked to hardware but software... > > > DMIC driver description specifies the

[PATCH] ASoC: codecs: dmic: Use channel map for configs with a single mic

userspace that the capture device is mono. Signed-off-by: Matthias Kaehlcke <m...@chromium.org> --- Documentation/devicetree/bindings/sound/dmic.txt | 2 + sound/soc/codecs/dmic.c | 72 +--- 2 files changed, 65 insertions(+), 9 deletions(-) diff

Re: [PATCH] ASoC: codecs: dmic: Use channel map for configs with a single mic

+ Brian & Dylan El Thu, Jan 04, 2018 at 11:48:48AM -0800 Matthias Kaehlcke ha dit: > The DMIC DAI driver specifies a number of 1 to 8 channels for each DAI. > The actual number of mics can currently not be configured in the device > tree or audio glue, but is derived from the min

[PATCH] ASoC: codecs: dmic: Make number of channels configurable

of the codec. Signed-off-by: Matthias Kaehlcke <m...@chromium.org> --- Documentation/devicetree/bindings/sound/dmic.txt | 2 ++ sound/soc/codecs/dmic.c | 24 +++- 2 files changed, 25 insertions(+), 1 deletion(-) diff --git a/Documentation/devi

[PATCH] ASoC: rockchip: i2s: Support mono capture

The Rockchip I2S controller only allows to configure even numbers of capture channels. It is still possible to capture monophonic audio by using dual-channel mode and ignoring the 'data' from the second channel. Signed-off-by: Matthias Kaehlcke <m...@chromium.org> --- sound/soc/ro

<    2   3   4   5   6   7   8   9   10   11   >