Re: linux-next: build failure after merge of the drm tree

On 01/29/2015 04:38 AM, Stephen Rothwell wrote: After merging the drm tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/gpu/drm/amd/amdkfd/kfd_device.c: In function 'kgd2kfd_device_init': drivers/gpu/drm/amd/amdkfd/kfd_device.c:193:11: error:

Re: linux-next: manual merge of the drm tree with Linus' tree

On 01/29/2015 04:17 AM, Stephen Rothwell wrote: Hi Dave, Today's linux-next merge of the drm tree got conflicts in drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c and drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.h between commits b8cbab042cd6 (drm/amdkfd: Allow user to limit only

Re: [PATCH 2/2] iommu/amd: use handle_mm_fault directly v2

On 11/13/2014 12:10 AM, Jesse Barnes wrote: This could be useful for debug in the future if we want to track major/minor faults more closely, and also avoids the put_page trick we used with gup. In order to do this, we also track the task struct in the PASID state structure. This lets us

Re: [BUG] 3.19-rc1 net: less interrupt masking in NAPI

On 01/10/2015 11:50 PM, Eric Dumazet wrote: On Sat, 2015-01-10 at 23:30 +0200, Oded Gabbay wrote: Yes, no problem. I will update on the result. Please try this more complete patch, solving the TX pressure problem as well, and not lying about NAPI budget. thanks ! diff --git

[BUG] 3.19-rc1 net: less interrupt masking in NAPI

Hi, Commit d75b1ade567ffab085e8adbbdacf0092d10cd09c breaks my Qualcomm Atheros AR8161 Gigabit Ethernet (rev 10) Ethernet controller, which is handled by the alx network driver. ogabbay@odedg-ubuntu:~$ lspci -s 01:00.0 -k 01:00.0 Ethernet controller: Qualcomm Atheros AR8161 Gigabit

Re: [BUG] 3.19-rc1 net: less interrupt masking in NAPI

On 01/10/2015 10:58 PM, Eric Dumazet wrote: On Sat, 2015-01-10 at 22:39 +0200, Oded Gabbay wrote: Hi, Commit d75b1ade567ffab085e8adbbdacf0092d10cd09c breaks my Qualcomm Atheros AR8161 Gigabit Ethernet (rev 10) Ethernet controller, which is handled by the alx network driver. ogabbay@odedg

Re: [BUG] 3.19-rc1 net: less interrupt masking in NAPI

On 01/11/2015 12:05 AM, Oded Gabbay wrote: On 01/10/2015 11:50 PM, Eric Dumazet wrote: On Sat, 2015-01-10 at 23:30 +0200, Oded Gabbay wrote: Yes, no problem. I will update on the result. Please try this more complete patch, solving the TX pressure problem as well, and not lying about

Re: [BUG] 3.19-rc1 net: less interrupt masking in NAPI

On 01/10/2015 11:30 PM, Oded Gabbay wrote: On 01/10/2015 10:58 PM, Eric Dumazet wrote: On Sat, 2015-01-10 at 22:39 +0200, Oded Gabbay wrote: Hi, Commit d75b1ade567ffab085e8adbbdacf0092d10cd09c breaks my Qualcomm Atheros AR8161 Gigabit Ethernet (rev 10) Ethernet controller, which

[BUG] 3.19-rc3+ - mm: prevent endless growth of anon_vma hierarchy

Hello, Today I took latest branch from Linus repo to check for amdkfd regressions due to my fixes pulled for 3.19-rc4, and I got a kernel bug (see below dmesg output). I did a bisect and the first bad commit is: 7a3ef208e662f4b63d43a23f61a64a129c525bbc is the first bad commit commit

Re: BUG in 3.19.0-rc3+

) 12: 00 00 add%al,(%rax) +Added Oded Gabbay oded.gab...@amd.com into cc, he's reported this problem too. Thanks for the fast reply. I applied the patch and tested it. I wasn't able to reproduce *my* problem, so you are definitely in the right direction

Re: BUG in 3.19.0-rc3+

.byte 0xf f: 1f (bad) 10: 84 00 test %al,(%rax) 12: 00 00 add%al,(%rax) +Added Oded Gabbay oded.gab...@amd.com into cc, he's reported this problem too. Thanks for the fast reply. I applied the patch and tested it. I

Re: [LKP] [PATCH] drm/radeon: Try to init amdkfd only if 64 bit kernel

On 01/07/2015 12:58 AM, Rusty Russell wrote: Kees Cook keesc...@chromium.org writes: On Sun, Jan 4, 2015 at 8:28 PM, Rusty Russell ru...@rustcorp.com.au wrote: Kees, as far as I can tell you need another 0-terminated vmlinux.relocs section for weak symbols. These should not be relocated if

Re: [PATCH 1/6] mmu_notifier: add event information to address invalidation v6

On 01/06/2015 12:44 AM, j.gli...@gmail.com wrote: From: Jérôme Glisse jgli...@redhat.com The event information will be useful for new user of mmu_notifier API. The event argument differentiate between a vma disappearing, a page being write protected or simply a page being unmaped. This

Re: [PATCH 1/6] mmu_notifier: add event information to address invalidation v6

On 01/11/2015 02:24 PM, Oded Gabbay wrote: On 01/06/2015 12:44 AM, j.gli...@gmail.com wrote: From: Jérôme Glisse jgli...@redhat.com The event information will be useful for new user of mmu_notifier API. The event argument differentiate between a vma disappearing, a page being write

Re: [PATCH 3/6] HMM: introduce heterogeneous memory management v2.

On 01/06/2015 12:44 AM, j.gli...@gmail.com wrote: From: Jérôme Glisse jgli...@redhat.com This patch only introduce core HMM functions for registering a new mirror and stopping a mirror as well as registering and unregistering a device. The lifecycle of HMM object is handled differently

Re: [PATCH 3/6] HMM: introduce heterogeneous memory management v2.

On 01/12/2015 05:46 PM, Jerome Glisse wrote: On Sun, Jan 11, 2015 at 03:24:42PM +0200, Oded Gabbay wrote: On 01/06/2015 12:44 AM, j.gli...@gmail.com wrote: From: Jérôme Glisse jgli...@redhat.com This patch only introduce core HMM functions for registering a new mirror and stopping

Re: [PATCH] drm/radeon: do not left queue acquired if timeout happens in kgd_hqd_destroy()

On 01/04/2015 01:31 AM, Alexey Khoroshilov wrote: If timeout happens, kgd_hqd_destroy() just returns -ETIME leaving queue acquired. It may cause a deadlock, so the patch proposes to release queue before return. Found by Linux Driver Verification project (linuxtesting.org).

Re: [PATCH 0/2] Change order of linkage in kernel makefiles for amdkfd

, 2014 at 10:34:32AM +0100, Christian König wrote: Am 29.12.2014 um 09:16 schrieb Laurent Pinchart: Hi Oded, On Sunday 28 December 2014 13:36:50 Oded Gabbay wrote: On 12/26/2014 11:19 AM, Laurent Pinchart wrote: On Thursday 25 December 2014 14:20:59 Thierry Reding wrote: On Mon, Dec 22, 2014

Re: Linux XIA - merge proposal

On 03/17/2015 02:25 PM, Michel Machado wrote: On 03/15/2015 05:37 AM, Greg KH wrote: On Fri, Mar 13, 2015 at 11:26:46AM -0400, Michel Machado wrote: On 03/10/2015 01:01 PM, Bjorn Helgaas wrote: From my point of view (far outside the networking world and completely incompetent to judge the

Re: Linux XIA - merge proposal

On 03/15/2015 11:37 AM, Greg KH wrote: On Fri, Mar 13, 2015 at 11:26:46AM -0400, Michel Machado wrote: On 03/10/2015 01:01 PM, Bjorn Helgaas wrote: From my point of view (far outside the networking world and completely incompetent to judge the merits of XIA), this email seems like a

Re: [RFC][PATCH] amdkfd: Convert timestamping to use 64bit time accessors

On 03/13/2015 01:24 PM, Arnd Bergmann wrote: On Thursday 12 March 2015 10:23:40 John Stultz wrote: Convert the timestamping in the amdkfd driver to use a timespec64 and 64bit time accessors. Cc: Arnd Bergmann a...@arndb.de Cc: Oded Gabbay oded.gab...@amd.com Cc: David Airlie airl...@linux.ie

[PATCH] radeon: Update Kaveri MEC firmware to #396

This patch updates the Kaveri MEC firmware to #396 (from #391). The MEC firmware is mainly used for amdkfd - AMD's HSA Linux kernel driver. Signed-off-by: Oded Gabbay oded.gab...@amd.com --- radeon/kaveri_mec.bin | Bin 17024 - 17024 bytes radeon/kaveri_mec2.bin | Bin 17024 - 17024 bytes 2

Re: [PATCH] iommu/amd: Fix bug in put_pasid_state_wait

Hi Joerg, Could you please take a look at this patch ? I want it to be included in stable asap so Fedora 22 will pick it up. Thanks, Oded On 04/16/2015 05:08 PM, Oded Gabbay wrote: This patch fixes a bug in put_pasid_state_wait that appeared in kernel 4.0 The bug is that pasid_state

Re: Interacting with coherent memory on external devices

On 04/23/2015 07:22 PM, Jerome Glisse wrote: On Thu, Apr 23, 2015 at 09:20:55AM -0500, Christoph Lameter wrote: On Thu, 23 Apr 2015, Benjamin Herrenschmidt wrote: There are hooks in glibc where you can replace the memory management of the apps if you want that. We don't control the app.

Re: [git pull] IOMMU Updates for Linux v4.1

Hi Joerg, I sent to you (cc iommu mailing list) an important fix on Apr-16 for a bug in amd_iommu_v2.c (from kernel 4.0). See: http://lists.linuxfoundation.org/pipermail/iommu/2015-April/012757.html Could you please add that to the pull request ? Its creating problems when running HSA

Re: [git pull] IOMMU Updates for Linux v4.1

a look, ack it and pull it to -rc3/4 ? I can send you the patch again with git or I can also send it through Dave's drm pull request if that's more convenient for you. Thanks, Oded On 04/20/2015 09:23 AM, Oded Gabbay wrote: Hi Joerg, I sent to you (cc iommu mailing list) an important fix

Re: [git pull] IOMMU Updates for Linux v4.1

On 05/03/2015 01:14 AM, Joerg Roedel wrote: Hi Oded, On Sat, May 02, 2015 at 07:59:39PM +0300, Oded Gabbay wrote: However, Joerg is not answering my emails for some reason (vacation/sick?) Sorry, I was travelling for the last 3 weeks and had bad internet access. But I am back and will take

Re: [git pull] IOMMU Updates for Linux v4.1

On Tue, May 5, 2015 at 9:22 PM, Josh Boyer jwbo...@fedoraproject.org wrote: On Sun, May 3, 2015 at 2:18 AM, Oded Gabbay oded.gab...@amd.com wrote: On 05/03/2015 01:14 AM, Joerg Roedel wrote: Hi Oded, On Sat, May 02, 2015 at 07:59:39PM +0300, Oded Gabbay wrote: However, Joerg

[PATCH] MAINTAINERS: update amdkfd Oded's email address

Leaving AMD soon so need to update my email address to @gmail.com Signed-off-by: Oded Gabbay oded.gab...@gmail.com --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 781e099..d68df93 100644 --- a/MAINTAINERS +++ b/MAINTAINERS

[PATCH] drm/amdkfd: Don't report local memory size

for HSA, we need this patch. Cc: sta...@vger.kernel.org Reviewed-by: Alex Deucher alexander.deuc...@amd.com Signed-off-by: Oded Gabbay oded.gab...@gmail.com --- drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdkfd

[PATCH] iommu/amd: Fix bug in put_pasid_state_wait

. Signed-off-by: Oded Gabbay oded.gab...@amd.com Cc: sta...@vger.kernel.org --- drivers/iommu/amd_iommu_v2.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/iommu/amd_iommu_v2.c b/drivers/iommu/amd_iommu_v2.c index 6d5a5c4..173e70d 100644 --- a/drivers/iommu/amd_iommu_v2.c +++ b/drivers

[PATCH] drm/amdkfd: destroy mqd when destroying kernel queue

@amd.com Reviewed-by: Alex Deucher alexander.deuc...@amd.com Cc: sta...@vger.kernel.org Signed-off-by: Oded Gabbay oded.gab...@amd.com --- drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd

[PATCH] drm/amdkfd: Initialize only amdkfd's assigned pipelines

because it calls BUG_ON() Signed-off-by: Oded Gabbay oded.gab...@amd.com Cc: sta...@vger.kernel.org Tested-by: Michel Dänzer michel.daen...@amd.com --- drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm

Re: [PATCH 03/12] drm/amdkfd: Use DECLARE_BITMAP

On Wed, May 20, 2015 at 4:37 AM, Joe Perches j...@perches.com wrote: Use the generic mechanism to declare a bitmap instead of unsigned long. It seems that struct kfd_process.allocated_queue_bitmap is unused. Maybe it could be deleted instead. Signed-off-by: Joe Perches j...@perches.com ---

Re: linux-next: build failure after merge of the drm tree

On Wed, May 20, 2015 at 8:31 AM, Stephen Rothwell s...@canb.auug.org.au wrote: Hi Dave, On Wed, 20 May 2015 15:25:38 +1000 Stephen Rothwell s...@canb.auug.org.au wrote: On Wed, 20 May 2015 05:41:46 +0100 (IST) Dave Airlie airl...@linux.ie wrote: After merging the drm tree, today's

Re: [PATCH] drm/amdkfd: avoid CONFIG_ prefix for non-Kconfig symbols

On Fri, Jun 5, 2015 at 11:27 AM, Valentin Rothberg valentinrothb...@gmail.com wrote: The CONFIG_ prefix is reserved for Kconfig options in Make and CPP syntax. Various static analysis tools rely on this naming convention and check if CONFIG_ prefixed symbols are defined Kconfig. Hence add

Re: [patch] drm/amdkfd: fix some range checks in address watch ioctl

On Thu, Jun 11, 2015 at 6:19 PM, Dan Carpenter dan.carpen...@oracle.com wrote: diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c index 96c904b..54a608a 100644 --- a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c +++

Re: [patch] drm/amdkfd: fix some range checks in address watch ioctl

On Thu, Jun 11, 2015 at 6:19 PM, Dan Carpenter dan.carpen...@oracle.com wrote: #include kfd_dbgmgr.h +#include ../../radeon/cik_reg.h static long kfd_ioctl(struct file *, unsigned int, unsigned long); We can't include radeon files in kfd_chardev.c, because amdkfd works with two device

Re: [PATCH] iommu/amd: Allow non-ATS devices in IOMMUv2 domains

Joerg, Why amdkfd's devices are considered a non-IOMMUv2 capable devices ? After all, they contain the IOMMUv2 H/W and use it constantly for HSA. ODed On Thu, Jul 30, 2015 at 1:05 PM, Joerg Roedel j...@8bytes.org wrote: From: Joerg Roedel jroe...@suse.de With the grouping of multi-function

Re: [PATCH 0/5] AMD IOMMU Fixes for v4.2-rc4

___ iommu mailing list io...@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu This series, with the additional patch, is: Tested-by: Oded Gabbay oded.gab...@gmail.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [PATCH] iommu/amd: Allow non-ATS devices in IOMMUv2 domains

This series, with the additional patch is: Tested-by: Oded Gabbay oded.gab...@gmail.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

Re: [PATCH 0/5] AMD IOMMU Fixes for v4.2-rc4

Hi Joerg, I tested your patches on Kaveri, and while they do fix the initial setup between amdkfd and IOMMU, the kernel crashes when an HSA process tries to do any simple action that involves the kernel, such as to create a compute queue. So while I suppose the above patches should be included,

Re: [RFC][PATCH 1/1] drm/amdkfd: Remove redundant pdd validation

On Mon, Jun 29, 2015 at 7:33 AM, Maninder Singh maninder...@samsung.com wrote: pdd is already dereferenced before this check. So it is redundtant to validate pdd here. Signed-off-by: Maninder Singh maninder...@samsung.com --- drivers/gpu/drm/amd/amdkfd/kfd_process.c |3 +-- 1 file

Re: [PATCH v2] drm/amdkfd: validate pdd where it acquired first

On Thu, Jul 9, 2015 at 12:11 PM, Maninder Singh maninder...@samsung.com wrote: Currently pdd is validate after dereferencing it, which is not correct, Thus validate pdd before its first use. Signed-off-by: Maninder Singh maninder...@samsung.com --- v1: remove validation of pdd after its

Re: [PATCH 3/9] amdkfd: use linux/mman.h instead of uapi/asm-generic/mman-common.h

On Fri, Aug 28, 2015 at 10:27 AM, Christoph Hellwig h...@lst.de wrote: The latter is a default version of asm/mman.h and not for driver use. Signed-off-by: Christoph Hellwig h...@lst.de --- drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 2 +- drivers/gpu/drm/amd/amdkfd/kfd_flat_memory.c |

Re: [PATCH 0/4 v2] Implement access checks in iommu page fault paths

On Tue, Nov 17, 2015 at 5:11 PM, Joerg Roedel wrote: > Hi, > > here is the second version of the patch-set to implement > proper access checks into the io-page-fault handlers of the > AMD IOMMU and Intel VT-d drivers. > > Two additional patches clean up the AMD part a bit

Re: [PATCH v3] gpu: drm: amd: amdkfd: Remove create_workqueue()

On Sun, May 29, 2016 at 6:44 PM, Bhaktipriya Shridhar wrote: > alloc_workqueue replaces deprecated create_workqueue(). > > create_workqueue has been replaced with alloc_workqueue with max_active > as 0 since there is no need for throttling the number of active work items.

Re: [RFT v3] drm: use late_initcall() for amdkfd and radeon

On Tue, May 31, 2016 at 8:15 PM, Luis R. Rodriguez <mcg...@kernel.org> wrote: > On Sun, May 29, 2016 at 05:49:17PM +0300, Oded Gabbay wrote: >> On Fri, May 27, 2016 at 4:18 AM, Luis R. Rodriguez <mcg...@kernel.org> wrote: >> > diff --git a/drivers/gpu/drm/radeon/ra

Re: [PATCH v2] gpu: drm: amd: amdkfd: Remove create_workqueue()

On Thu, May 26, 2016 at 10:37 PM, Bhaktipriya Shridhar wrote: > alloc_workqueue replaces deprecated create_workqueue(). > > create_workqueue has been replaced with alloc_workqueue with max_active > as 0 since there is no need for throttling the number of active work

Re: [RFT v3] drm: use late_initcall() for amdkfd and radeon

On Fri, May 27, 2016 at 4:18 AM, Luis R. Rodriguez wrote: > To get KFD support in radeon we need the following > initialization to happen in this order, their > respective driver file that has its init routine > listed next to it: > > 0. AMD IOMMUv1:

Re: [PATCH] gpu: drm: amd: amdkfd: Remove unnecessary cast in kfree

On Mon, Jan 25, 2016 at 7:33 PM, Amitoj Kaur Chawla wrote: > Remove an unnecassary cast in the argument to kfree. > > Found using Coccinelle. The semantic patch used to find this is as follows: > > // > @@ > type T; > expression *f; > @@ > > - kfree((T *)(f)); > + kfree(f);

Re: [PATCH] drm/amdgpu: fix non-ANSI declaration of amdgpu_amdkfd_gfx_*_get_functions()

On Fri, Jan 22, 2016 at 7:35 PM, Colin King wrote: > From: Colin Ian King > > amdgpu_amdkfd_gfx_7_get_functions and amdgpu_amdkfd_gfx_8_0_get_functions > have no parameters, so use the normal void parameter convention to make > them match

Re: [PATCH] mm: Export symbols unmapped_area() & unmapped_area_topdown()

On Thu, Mar 17, 2016 at 4:37 PM, Jerome Glisse wrote: > On Wed, Mar 16, 2016 at 05:10:34PM +, Olu Ogunbowale wrote: >> From: Olujide Ogunbowale >> >> Export the memory management functions, unmapped_area() & >> unmapped_area_topdown(), as GPL

Re: [RFT] iommu/amd: use subsys_initcall() on amdv2 iommu

On Wed, Mar 16, 2016 at 12:12 AM, Luis R. Rodriguez wrote: > We need to ensure amd iommu v2 initializes before > driver uses such as drivers/gpu/drm/amd/amdkfd/kfd_module.c, > to do this make its init routine a subsys_initcall() which > ensures its load init is called first

Re: [RFT] iommu/amd: use subsys_initcall() on amdv2 iommu

On Wed, Mar 16, 2016 at 12:14 PM, Joerg Roedel <j...@8bytes.org> wrote: > On Wed, Mar 16, 2016 at 09:02:43AM +0200, Oded Gabbay wrote: >> fwiw, we currently have this covered by the ugly hack of putting iommu >> subsystem in front of gpu subsystem in the main

Re: [patch] drm/amdkfd: uninitialized variable in dbgdev_wave_control_set_registers()

On Fri, Mar 11, 2016 at 9:51 AM, Dan Carpenter wrote: > At the end of the function we expect "status" to be zero, but it's > either -EINVAL or unitialized. > > Fixes: 788bf83db301 ('drm/amdkfd: Add wave control operation to debugger') > Signed-off-by: Dan Carpenter

Re: [RFC 1/7] drm/amdkfd: avoid fragile and inefficient snprintf use

On Tue, Mar 8, 2016 at 10:40 PM, Rasmus Villemoes wrote: > Passing overlapping source and destination buffers to snprintf > formally has undefined behaviour and is rather fragile. While the > rather special case of passing the output buffer as the argument >

Re: [RFT v2] iommu/amd: use subsys_initcall() on amdv2 iommu

gt; This reverts the old work around implemented through commit >>> 1bacc894c227fad8a7 ("drivers: Move iommu/ before gpu/ in Makefile"), >>> instead of making the dependency implicit by linker order this >>> makes the ordering requirement explicit through p

Re: [RFT v2] iommu/amd: use subsys_initcall() on amdv2 iommu

On Wed, Apr 13, 2016 at 1:07 AM, Luis R. Rodriguez <mcg...@kernel.org> wrote: > On Mon, Apr 11, 2016 at 03:52:43PM +0200, Christian König wrote: >> Am 11.04.2016 um 15:39 schrieb Oded Gabbay: >> >On Mon, Apr 11, 2016 at 4:28 PM, Christian König >> ><chri

Re: [RFT v2] iommu/amd: use subsys_initcall() on amdv2 iommu

On Mon, Apr 18, 2016 at 9:55 AM, Luis R. Rodriguez <mcg...@kernel.org> wrote: > > On Apr 18, 2016 7:48 AM, "Oded Gabbay" <oded.gab...@gmail.com> wrote: >> >> On Wed, Apr 13, 2016 at 1:07 AM, Luis R. Rodriguez <mcg...@kernel.org> >> wrote: >

Re: [PATCH] drm/amdkfd: print doorbell offset as a hex value

On Wed, Jul 13, 2016 at 10:36 AM, Colin King wrote: > From: Colin Ian King > > The doorbell offset is formatted with a 0x prefix to suggest it is > a hexadecimal value, when in fact %d is being used and this is confusing. > Use %X instead to

Re: [PATCH] amdkfd: fix spelling mistake in kfd_ioctl_dbg_unrgesiter

On Sat, Nov 12, 2016 at 7:33 PM, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake, rename kfd_ioctl_dbg_unrgesiter > to kfd_ioctl_dbg_unregister > > Signed-off-by: Colin Ian King > --- >

Re: [PATCH trivial] drm/amdkfd: Spelling s/apreture/aperture/

On Thu, Jun 1, 2017 at 1:28 PM, Geert Uytterhoeven wrote: > Signed-off-by: Geert Uytterhoeven > --- > drivers/gpu/drm/amd/amdkfd/kfd_process.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git

Re: [PATCH] drm/amdkfd: check for null dev to avoid a null pointer dereference

On Fri, Sep 8, 2017 at 5:13 PM, Colin King wrote: > From: Colin Ian King > > The call to kfd_device_by_id can potentially return null, so check that > dev is null and return with -EINVAL to avoid a null pointer dereference. > > Detected by

Re: [PATCH] sparc64: mmu_context: Add missing include files

34315e1f0ed 100644 > --- a/arch/sparc/include/asm/mmu_context_64.h > +++ b/arch/sparc/include/asm/mmu_context_64.h > @@ -7,9 +7,11 @@ > > #include > #include > +#include > > #include > #include > +#include > > static inline void enter_lazy_tlb(struct mm_str

Re: [PATCH v06 36/36] uapi linux/kfd_ioctl.h: use __u32 and __u64 instead of uint32_t and uint64_t

ixes user space compilation errors like: >> >> linux/kfd_ioctl.h:33:2: error: unknown type name ‘uint32_t’ >> uint32_t major_version; /* from KFD */ >> ^~~~ >> >> Signed-off-by: Mikko Rapeli <mikko.rap...@iki.fi> >> Cc: Yair Shachar <yair.shac

Re: [PATCH] drm/amdkfd: remove memset before memcpy

On Tue, Aug 29, 2017 at 10:03 PM, Himanshu Jha wrote: > calling memcpy immediately after memset with the same region of memory > makes memset redundant. > > Signed-off-by: Himanshu Jha > --- >

Re: [PATCH] drm: fix amdkfd use-after-free GP fault

It was sent to Dave Airle (drm maintainer) to be included in 4.15-rc2 or 4.15-rc3 (depends when Dave will send his drm fixes). Oded On Wed, Nov 29, 2017 at 12:41 AM, Randy Dunlap <rdun...@infradead.org> wrote: > On 11/13/2017 08:09 AM, Oded Gabbay wrote: >> On Sat, Nov 11, 2017 at

Re: [PATCH] pci: add class codes for processing accelerators

On Thu, Nov 23, 2017 at 4:11 PM, Greg KH <gre...@linuxfoundation.org> wrote: > On Thu, Nov 23, 2017 at 04:04:22PM +0200, Oded Gabbay wrote: >> Add PCI codes to include/linux/pci_ids.h for Processing Accelerators. There >> are new ASICs (now in development) for Deep Learn

[PATCH] pci: add class codes for processing accelerators

Add PCI codes to include/linux/pci_ids.h for Processing Accelerators. There are new ASICs (now in development) for Deep Learning that will utilize this base class. Signed-off-by: Oded Gabbay <oded.gab...@gmail.com> --- include/linux/pci_ids.h | 3 +++ 1 file changed, 3 insertions(+) diff

Re: [PATCH] drm: fix amdkfd use-after-free GP fault

50 4d 85 c0 74 2b 48 8b 86 88 00 00 00 48 85 c0 74 25 <48> > 8b 08 0f be 7b 01 48 c7 c2 96 0a aa 97 31 c0 83 ef 30 e8 7f > [ 947.650339] RIP: __dev_printk+0x29/0x90 RSP: a51e409c7e48 > [ 947.650388] ---[ end trace c41965e147ae98ae ]--- > > Signed-off-by: Randy Dunlap <rdun

Re: [PATCH] uapi: fix linux/kfd_ioctl.h userspace compilation errors

On Mon, Nov 13, 2017 at 2:35 AM, Dmitry V. Levin wrote: > Consistently use types provided by via > to fix the following linux/kfd_ioctl.h userspace compilation errors: > > /usr/include/linux/kfd_ioctl.h:236:2: error: unknown type name 'uint64_t' > uint64_t va_addr; /* to

[PATCH] microblaze: add missing include to mmu_context_mm.h

of linux/sched.h to mmu_context_mm.h to avoid such errors. Signed-off-by: Oded Gabbay <oded.gab...@gmail.com> --- arch/microblaze/include/asm/mmu_context_mm.h | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/microblaze/include/asm/mmu_context_mm.h b/arch/microblaze/inclu

Re: [PATCHv3] drm/amdkfd: Remove vla

On Thu, May 3, 2018 at 12:49 AM, Kees Cook wrote: > On Fri, Apr 13, 2018 at 2:24 PM, Laura Abbott wrote: >> >> There's an ongoing effort to remove VLAs[1] from the kernel to eventually >> turn on -Wvla. Switch to a constant value that covers all

Re: linux-next: build failure after merge of the drm tree

ject: [PATCH] drm/amdgpu: include pagemap.h for release_pages() > > Fixes: 5ae0283e831a ("drm/amdgpu: Add userptr support for KFD" > Cc: Felix Kuehling <felix.kuehl...@amd.com> > Cc: Oded Gabbay <oded.gab...@gmail.com> > Signed-off-by: Stephen Rothwell <s...@

Re: [PATCH 2/8] drm/amdgpu: fix 32-bit build warning

t; WREG32(SOC15_REG_OFFSET(GC, 0, mmCP_PQ_WPTR_POLL_CNTL1), >get_queue_mask(adev, pipe_id, queue_id)); > } > -- > 2.9.0 > There is a change scheduled for the next merge window that will cause this file to not build anymore on 32-bit targets (because the am

Re: [PATCH v2] drm/amdkfd: Fix potential NULL pointer dereferences

ct kfd_dev > *dev) > mutex_lock(>mutex); > pdd = kfd_get_process_device_data(dev, p); > > + if (WARN_ON(!pdd)) { > + mutex_unlock(>mutex); > + continue; > + } > + >

Re: [PATCH] drm/amdkfd: Use ARRAY_SIZE macro in kfd_build_sysfs_node_entry

On Sat, Jan 20, 2018 at 12:30 AM, Gustavo A. R. Silva wrote: > > Quoting Felix Kuehling : > >> Looks good. This change is Reviewed-by: Felix Kuehling >> >> > > Thanks Felix. > -- > Gustavo > Applied to -next Oded > > > >

Re: [PATCH] drm/amdkfd: Use ARRAY_SIZE macro in kfd_build_sysfs_node_entry

Hi Gustavo, The patch is queued for the merge window of kernel 4.17 (opens in about 7 weeks from now). Oded On Wed, Feb 14, 2018 at 11:30 PM, Gustavo A. R. Silva wrote: > Hi all, > > I was just wondering about the status of this patch. > > Thanks > -- > Gustavo > > > On

Re: [PATCH] drm/amdkfd: Delete an error message for a failed memory allocation in kfd_topology_init()

On Thu, Feb 8, 2018 at 11:33 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Thu, 8 Feb 2018 22:23:57 +0100 > > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using

Re: [PATCH -next] drm/amdgpu: fix error return code in amdgpu_amdkfd_gpuvm_create_process_vm()

On Wed, Mar 28, 2018 at 4:20 PM, Wei Yongjun wrote: > Fix to return error code -ENOMEM from the eviction fence create fail > error handling case instead of 0, as done elsewhere in this function. > > Fixes: a46a2cd103a8 ("drm/amdgpu: Add GPUVM memory management functions

Re: [PATCH -next] drm/amdkfd: Fix the error return code in kfd_ioctl_unmap_memory_from_gpu()

On Mon, Apr 2, 2018 at 9:02 PM, Felix Kuehling wrote: > Thanks for catching that. I'd use -ENODEV to match what is done a few > lines below for peer_pdd. With that fixed, this patch is Reviewed-by: > Felix Kuehling > > Regards, > Felix > > > On

Re: [PATCH] amdkfd: always select MMU_NOTIFIER

Thanks, but I took Randy's patch as it was earlier in my email queue. Oded On Thu, Apr 19, 2018 at 8:47 PM, Felix Kuehling wrote: > On 2018-04-19 06:56 AM, Anders Roxell wrote: >> On 28 March 2018 at 18:04, Christian König wrote: >>> Am

Re: [PATCH] uapi: fix linux/kfd_ioctl.h userspace compilation errors

Thanks, but already fixed in latest upstream tree Oded On Thu, Apr 5, 2018 at 7:26 AM, Dmitry V. Levin wrote: > Consistently use types provided by via > to fix the following linux/kfd_ioctl.h userspace compilation errors: > > /usr/include/linux/kfd_ioctl.h:266:2: error:

Re: [PATCH -next] drm/amdkfd: Make function kfd_dev_is_large_bar() static

On Mon, Apr 2, 2018 at 9:03 PM, Felix Kuehling wrote: > This patch is Reviewed-by: Felix Kuehling > > > On 2018-03-29 10:25 PM, Wei Yongjun wrote: >> Fixes the following sparse warning: >> >> drivers/gpu/drm/amd/amdkfd/kfd_chardev.c:1150:6:

Re: [PATCH] gpu/drm/amd/amdkfd: fix build, select MMU_NOTIFIER

led by default] >> ../drivers/gpu/drm/amd/amdkfd/kfd_process.c:439:2: warning: (near >> initialization for 'kfd_process_mmu_notifier_ops') [enabled by default] >> ../drivers/gpu/drm/amd/amdkfd/kfd_process.c:534:2: error: implicit >> declaration of function 'mmu_notifier_register'

Re: [PATCH] drm/amdkfd: fix uninitialized variable use

On Thu, Mar 15, 2018 at 6:49 PM, Arnd Bergmann wrote: > When CONFIG_ACPI is disabled, we never initialize the acpi_table > structure in kfd_create_crat_image_virtual: > > drivers/gpu/drm/amd/amdkfd/kfd_crat.c: In function > 'kfd_create_crat_image_virtual': >

[PATCH v2 1/2] MMC: P2020 SDHC: Add support for 8-bit bus width and non-removable card

detecs if the non-removable property is set in the device tree. The function esdhc_pltfm_bus_width was added because the bus width configuration is platform specific. Signed-off-by: Oded Gabbay Reviewed-by: Anton Vorontsov --- drivers/mmc/host/sdhci-esdhc.h| 7 +++ drivers/mmc/host/sdhci

[PATCH v2 2/2] MMC: P2020 SDHC: Fix bug when writing to SDHCI_HOST_CONTROL register

tch depends on the first patch of this set (total of 2 patches) Signed-off-by: Oded Gabbay Reviewed-by: Anton Vorontsov --- drivers/mmc/host/sdhci-of-esdhc.c | 14 ++ include/linux/mmc/sdhci.h | 2 ++ 2 files changed, 16 insertions(+) diff --git a/drivers/mmc/host/sd

[PATCH 3/3] MMC: FSL SDHC: Add support for hard-wired (permanent) card. Kernel version 3.4.47

Signed-off-by: Oded Gabbay --- Documentation/devicetree/bindings/mmc/fsl-esdhc.txt | 3 +++ drivers/mmc/host/sdhci-of-esdhc.c | 4 2 files changed, 7 insertions(+) diff --git a/Documentation/devicetree/bindings/mmc/fsl-esdhc.txt b/Documentation/devicetree/bindings/mmc/fsl-esdhc

[PATCH 2/3] MMC: P2020 SDHC: Fix bug when writing to SDHCI_HOST_CONTROL register. Kernel version 3.4.47

off-by: Oded Gabbay --- drivers/mmc/host/sdhci-of-esdhc.c | 10 ++ include/linux/mmc/sdhci.h | 2 ++ 2 files changed, 12 insertions(+) diff --git a/drivers/mmc/host/sdhci-of-esdhc.c b/drivers/mmc/host/sdhci-of-esdhc.c index 6f433b8..e70f22f 100644 --- a/drivers/mmc/host/sd

[PATCH 1/3] MMC: P2020 SDHC: Add support for 8-bit bus width connection. Kernel version 3.4.47

-by: Oded Gabbay --- drivers/mmc/host/sdhci-esdhc.h| 7 ++ drivers/mmc/host/sdhci-of-esdhc.c | 49 ++- 2 files changed, 55 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci-esdhc.h b/drivers/mmc/host/sdhci-esdhc.h index d25f9ab..6f9a018

[PATCH 00/83] AMD HSA kernel driver

n: adding synchronization for GRBM GFX hsa/radeon: fixing clock counters bug drm/radeon: Extending kfd interface hsa/radeon: Adding max clock speeds to topology hsa/radeon: Alternating the source of max clock hsa/radeon: Exclusive access for perf. counters Michael Varga (1): hsa/radeo

[PATCH 01/83] mm: Add kfd_process pointer to mm_struct

, it releases the kfd_process object and all relevant resources. Signed-off-by: Oded Gabbay --- include/linux/mm_types.h | 14 ++ 1 file changed, 14 insertions(+) diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h index 678097c..6179107 100644 --- a/include/linux/mm_types.h +++ b

[PATCH 02/83] drm/radeon: reduce number of free VMIDs and pipes in KV

To support HSA on KV, we need to limit the number of vmids and pipes that are available for radeon's use with KV. This patch reserves VMIDs 8-15 for KFD (so radeon can only use VMIDs 0-7) and also makes radeon thinks that KV has only a single MEC with a single pipe in it Signed-off-by: Oded

[PATCH 06/83] drm/radeon: Add kfd-->kgd interfaces of memory allocation/mapping

Signed-off-by: Oded Gabbay --- drivers/gpu/drm/radeon/radeon_kfd.c | 129 include/linux/radeon_kfd.h | 23 +++ 2 files changed, 152 insertions(+) diff --git a/drivers/gpu/drm/radeon/radeon_kfd.c b/drivers/gpu/drm/radeon/radeon_kfd.c index 1b859b5

[PATCH 03/83] drm/radeon: Report doorbell configuration to kfd

Radeon and KFD share the doorbell aperture. Radeon sets it up, takes the doorbells required for its own rings and reports the setup to KFD. Radeon reserved doorbells are at the start of the doorbell aperture. Signed-off-by: Oded Gabbay --- drivers/gpu/drm/radeon/radeon.h| 4

[PATCH 08/83] drm/radeon: Add calls to initialize and finalize kfd from radeon

, the initialize call fails and the radeon driver continues normally. This patch also adds calls to probe, initialize and finalize a kfd device per radeon device using the kgd-->kfd interface. Signed-off-by: Oded Gabbay --- drivers/gpu/drm/radeon/radeon_drv.c | 6 ++ drivers/gpu/drm/rad

[PATCH 07/83] drm/radeon: Add kfd-->kgd interface of locking srbm_gfx_cntl register

This patch adds a new interface to kfd2kgd_calls structure, which allows the kfd to lock and unlock the srbm_gfx_cntl register Signed-off-by: Oded Gabbay --- drivers/gpu/drm/radeon/radeon_kfd.c | 20 include/linux/radeon_kfd.h | 4 2 files changed, 24

[PATCH 13/83] hsa/radeon: Add 2 new IOCTL to kfd, CREATE_QUEUE and DESTROY_QUEUE

. Signed-off-by: Oded Gabbay --- drivers/gpu/hsa/radeon/kfd_chardev.c | 155 ++ drivers/gpu/hsa/radeon/kfd_doorbell.c | 11 +++ include/uapi/linux/kfd_ioctl.h| 69 +++ 3 files changed, 235 insertions(+) create mode 100644 include/uapi/linux

<    1   2   3   4   5   6   7   8   9   10   >