Re: [PATCH] LICENSES: Replace HTTP links with HTTPS ones

[Philippe Ombredanne]

Hi Alexander:

On Tue, Jul 21, 2020 at 4:50 PM Greg KH  wrote:
>
> On Mon, Jul 13, 2020 at 10:42:31AM +0200, Alexander A. Klimov wrote:
> > Rationale:
> > Reduces attack surface on kernel devs opening the links for MITM
> > as HTTPS traffic is much harder to manipulate.
> >
> > Deterministic algorithm:
> > For each file:
> >   If not .svg:
> > For each line:
> >   If doesn't contain `\bxmlns\b`:
> > For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:
> > If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`:
> > If both the HTTP and HTTPS versions
> > return 200 OK and serve the same content:
> >   Replace HTTP with HTTPS.
> >
> > Signed-off-by: Alexander A. Klimov 
> > ---
> >  Continuing my work started at 93431e0607e5.
> >  See also: git log --oneline '--author=Alexander A. Klimov 
> > ' v5.7..master
> >  (Actually letting a shell for loop submit all this stuff for me.)
> >
> >  If there are any URLs to be removed completely or at least not just 
> > HTTPSified:
> >  Just clearly say so and I'll *undo my change*.
> >  See also: https://lkml.org/lkml/2020/6/27/64
> >
> >  If there are any valid, but yet not changed URLs:
> >  See: https://lkml.org/lkml/2020/6/26/837
> >
> >  If you apply the patch, please let me know.
> >
> >  Sorry again to all maintainers who complained about subject lines.
> >  Now I realized that you want an actually perfect prefixes,
> >  not just subsystem ones.
> >  I tried my best...
> >  And yes, *I could* (at least half-)automate it.
> >  Impossible is nothing! :)
> >
> >
> >  LICENSES/dual/Apache-2.0 | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/LICENSES/dual/Apache-2.0 b/LICENSES/dual/Apache-2.0
> > index 6e89ddeab187..fd71308fd2c3 100644
> > --- a/LICENSES/dual/Apache-2.0
> > +++ b/LICENSES/dual/Apache-2.0
> > @@ -15,7 +15,7 @@ Apache License
> >
> >  Version 2.0, January 2004
> >
> > -http://www.apache.org/licenses/
> > +https://www.apache.org/licenses/
> >
> >  TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
> >
> > --
> > 2.27.0
> >
>
> You can't change the text of a license that comes from elsewhere.  This
> file is fine as-is.

It is so fine that -FWIW- even the Apache folks toyed with the idea of
updating their license text to switch to HTTPS there and decided not
to [1] which is IMHO a sane thing.

[1] https://issues.apache.org/jira/browse/LEGAL-457
-- 
Cordially
Philippe Ombredanne

Re: [PATCH v2] module: Cure the MODULE_LICENSE "GPL" vs. "GPL v2" bogosity

[Philippe Ombredanne]

 ongoing effort to clean up the
> license mess of the kernel.
>
> Therefore remove the well meant, but ill defined, distinction between "GPL"
> and "GPL v2" and document that:
>
>   - "GPL" and "GPL v2" both express that the module is licensed under GPLv2
> (without a distinction of 'only' and 'or later') and is therefore kernel
> license compliant.
>
>   - None of the MODULE_LICENSE strings can be used for expressing or
> determining the exact license
>
>   - Their sole purpose is to decide whether the module is free software or
> not.
>
> Add a MODULE_LICENSE subsection to the license rule documentation as well.
>
> Signed-off-by: Thomas Gleixner 
> Reviewed-by: Greg Kroah-Hartman 
> Acked-by: Philippe Ombredanne 
> Acked-by: Joe Perches 
>
> ---
>
> V2: Fixed the "GPL v2" hickup and the typo spotted by Jessica.
>
>  Documentation/process/license-rules.rst |   62 
> 
>  include/linux/module.h  |   18 -
>  2 files changed, 79 insertions(+), 1 deletion(-)
>
> --- a/Documentation/process/license-rules.rst
> +++ b/Documentation/process/license-rules.rst
> @@ -372,3 +372,65 @@ in the LICENSE subdirectories. This is r
>  verification (e.g. checkpatch.pl) and to have the licenses ready to read
>  and extract right from the source, which is recommended by various FOSS
>  organizations, e.g. the `FSFE REUSE initiative <https://reuse.software/>`_.
> +
> +_`MODULE_LICENSE`
> +-
> +
> +   Loadable kernel modules also require a MODULE_LICENSE() tag. This tag is
> +   neither a replacement for proper source code license information
> +   (SPDX-License-Identifier) nor in any way relevant for expressing or
> +   determining the exact license under which the source code of the module
> +   is provided.
> +
> +   The sole purpose of this tag is to provide sufficient information
> +   whether the module is free software or proprietary for the kernel
> +   module loader and for user space tools.
> +
> +   The valid license strings for MODULE_LICENSE() are:
> +
> += 
> =
> +"GPL"Module is licensed under GPL version 2. This
> + does not express any distinction between
> + GPL-2.0-only or GPL-2.0-or-later. The exact
> + license information can only be determined
> + via the license information in the
> + corresponding source files.
> +
> +"GPL v2" Same as "GPL". It exists for historic
> + reasons.
> +
> +"GPL and additional rights"   Historical variant of expressing that the
> + module source is dual licensed under a
> + GPL v2 variant and MIT license. Please do
> + not use in new code.
> +
> +"Dual MIT/GPL"   The correct way of expressing that the
> + module is dual licensed under a GPL v2
> + variant or MIT license choice.
> +
> +"Dual BSD/GPL"   The module is dual licensed under a GPL v2
> + variant or BSD license choice. The exact
> + variant of the BSD license can only be
> + determined via the license information
> + in the corresponding source files.
> +
> +"Dual MPL/GPL"   The module is dual licensed under a GPL v2
> + variant or Mozilla Public License (MPL)
> + choice. The exact variant of the MPL
> + license can only be determined via the
> + license information in the corresponding
> + source files.
> +
> +"Proprietary"The module is under a proprietary license.
> + This string is solely for proprietary third
> + party modules and cannot be used for modules
> + which have their source code in the kernel
> + tree. Modules tagged that way are tainting
> + the kernel with the 'P' flag when loaded and
> +  

Re: [PATCH][RFC] module: Cure the MODULE_LICENSE "GPL" vs. "GPL v2" bogosity

[Philippe Ombredanne]

Thomas:
On Mon, Jan 28, 2019 at 11:39 PM Thomas Gleixner  wrote:
[...]
> As an unintended side effect this distinction causes a major headache for
> license compliance, license scanners and the ongoing effort to clean up the
> license mess of the kernel.

Glad to be of service and sorry for having helped a bit surface these!

>
> Therefore remove the well meant, but ill defined, distinction between "GPL"
> and "GPL v2" and document that:
>
>   - "GPL" and "GPL v2" both express that the module is licensed under GPLv2
> (without a distinction of 'only' and 'or later') and is therefore kernel
> license compliant.
>
>   - None of the MODULE_LICENSE strings can be used for expressing or
> determining the exact license
>
>   - Their sole purpose is to decide whether the module is free software or
> not.
>
> Add a MODULE_LICENSE subsection to the license rule documentation as well.
>
> Signed-off-by: Thomas Gleixner 


Thank you ++ for documenting all this : this is a small change but a big
step towards licensing clarity! Great that you found the commit that
introduced this too.

Feel free to add this if you want:
Acked-by: Philippe Ombredanne 

--
Cordially

Philippe Ombredanne

Re: [PATCH 2/3] ARM: tegra: apalis-tk1: Add SPDX license (GPL-2.0 OR X11) identifiers

[Philippe Ombredanne]

Hi Krzysztof,

On Wed, Jul 18, 2018 at 9:48 PM, Krzysztof Kozlowski  wrote:
> Three files dual-licensed were missing the SPDX license identifiers.
>
> Signed-off-by: Krzysztof Kozlowski 
> ---
>  arch/arm/boot/dts/tegra124-apalis-emc.dtsi | 38 
> +-
>  arch/arm/boot/dts/tegra124-apalis-eval.dts | 38 
> +-
>  arch/arm/boot/dts/tegra124-apalis.dtsi | 38 
> +-
>  3 files changed, 3 insertions(+), 111 deletions(-)
>
> diff --git a/arch/arm/boot/dts/tegra124-apalis-emc.dtsi 
> b/arch/arm/boot/dts/tegra124-apalis-emc.dtsi
> index ca2c3a557895..cdbbb3562fb9 100644
> --- a/arch/arm/boot/dts/tegra124-apalis-emc.dtsi
> +++ b/arch/arm/boot/dts/tegra124-apalis-emc.dtsi
> @@ -1,42 +1,6 @@
> +// SPDX-License-Identifier: GPL-2.0 OR X11
>  /*
>   * Copyright 2016 Toradex AG
> - *
> - * This file is dual-licensed: you can use it either under the terms
> - * of the GPL or the X11 license, at your option. Note that this dual
> - * licensing only applies to this file, and not this project as a
> - * whole.

This is weirdly enough not what is called an X11 license [1] even
though it is named this way here... but this is an  MIT license [2]
with a small variation. (See below)

> - *
> - *  a) This file is free software; you can redistribute it and/or
> - * modify it under the terms of the GNU General Public License
> - * version 2 as published by the Free Software Foundation.
> - *
> - * This file is distributed in the hope that it will be useful
> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> - * GNU General Public License for more details.
> - *
> - * Or, alternatively
> - *
> - *  b) Permission is hereby granted, free of charge, to any person
> - * obtaining a copy of this software and associated documentation
> - * files (the "Software"), to deal in the Software without
> - * restriction, including without limitation the rights to use
> - * copy, modify, merge, publish, distribute, sublicense, and/or
> - * sell copies of the Software, and to permit persons to whom the
> - * Software is furnished to do so, subject to the following
> - * conditions:
> - *
> - * The above copyright notice and this permission notice shall be
> - * included in all copies or substantial portions of the Software.
> - *
> - * THE SOFTWARE IS PROVIDED , WITHOUT WARRANTY OF ANY KIND

The MIT standard text [2] has a few extra commas and states instead:

THE SOFTWARE IS PROVIDED "AS IS",

Here "AS IS" is omitted. I am not sure this is material but IMHO it
would be good to get Toradex signoff on this.

> - * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
> - * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
> - * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
> - * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY
> - * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> - * OTHER DEALINGS IN THE SOFTWARE.
>   */




With all this said, I think that your expression should be this
instead (and this applies to other places too):

SPDX-License-Identifier: GPL-2.0 OR MIT

[1]  
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/LICENSES/other/X11?h=v4.18-rc5
[2]  
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/LICENSES/preferred/MIT?h=v4.18-rc5

-- 
Cordially
Philippe Ombredanne

Re: [PATCH 2/4] clocksource: timer-imx-gpt: Switch to SPDX identifier

[Philippe Ombredanne]

Hi Daniel,

On Wed, May 23, 2018 at 10:06 AM, Daniel Lezcano
 wrote:
> On 23/05/2018 01:05, Fabio Estevam wrote:
>> From: Fabio Estevam 
>>
>> Adopt the SPDX license identifier headers to ease license compliance
>> management.
>>
>> Signed-off-by: Fabio Estevam 
>> ---
>>  drivers/clocksource/timer-imx-gpt.c | 26 ++
>>  1 file changed, 6 insertions(+), 20 deletions(-)
>>
>> diff --git a/drivers/clocksource/timer-imx-gpt.c 
>> b/drivers/clocksource/timer-imx-gpt.c
>> index b63b834..165fbbb 100644
>> --- a/drivers/clocksource/timer-imx-gpt.c
>> +++ b/drivers/clocksource/timer-imx-gpt.c
>> @@ -1,23 +1,9 @@
>> -/*
>> - *  Copyright (C) 2000-2001 Deep Blue Solutions
>> - *  Copyright (C) 2002 Shane Nay (sh...@minirl.com)
>> - *  Copyright (C) 2006-2007 Pavel Pisa (pp...@pikron.com)
>> - *  Copyright (C) 2008 Juergen Beisert (ker...@pengutronix.de)
>> - *
>> - * This program is free software; you can redistribute it and/or
>> - * modify it under the terms of the GNU General Public License
>> - * as published by the Free Software Foundation; either version 2
>> - * of the License, or (at your option) any later version.
>> - * This program is distributed in the hope that it will be useful,
>> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> - * GNU General Public License for more details.
>> - *
>> - * You should have received a copy of the GNU General Public License
>> - * along with this program; if not, write to the Free Software
>> - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
>> - * MA 02110-1301, USA.
>> - */
>> +// SPDX-License-Identifier: GPL-2.0+
>> +//
>> +//  Copyright (C) 2000-2001 Deep Blue Solutions
>> +//  Copyright (C) 2002 Shane Nay (sh...@minirl.com)
>> +//  Copyright (C) 2006-2007 Pavel Pisa (pp...@pikron.com)
>> +//  Copyright (C) 2008 Juergen Beisert (ker...@pengutronix.de)
>
> Hi Philippe,
>
> I went through the code and didn't find any information about the format
> of the lines following the SPDX, it seems it is relatively free.
>
> Can you confirm the above changes are ok ?

This looks fine to me especially if this all you have in terms of top
level comment. (e.g. license then copyrights)
Some may not agree with me on using C++ style comments beyond the SPDX
license line though ;)
-- 
Cordially
Philippe Ombredanne

Re: [patch V2 7/7] scripts: Add SPDX checker script

[Philippe Ombredanne]

Thomas,
Sorry for the very late reply!

On Wed, Apr 25, 2018 at 10:30 PM, Thomas Gleixner  wrote:
> The SPDX-License-Identifiers are growing in the kernel and so grow
> expression failures and license IDs are used which have no corresponding
> license text file in the LICENSES directory.
>
> Add a script which gathers information from the LICENSES directory,
> i.e. the various tags in the licenses and exception files and then scans
> either input from stdin, which it treats as a single file or if started
> without arguments it scans the full kernel tree.
>
> It checks whether the license expression syntax is correct and also
> validates whether the license identifiers used in the expressions are
> available in the LICENSES files.

Looking good to me! And the use of ply is sleek.
-- 
Cordially
Philippe Ombredanne

Re: [PATCH v3] ata: add Amiga Gayle PATA controller driver

[Philippe Ombredanne]

Tejun,

On Mon, Mar 19, 2018 at 7:41 AM, Tejun Heo  wrote:
> Hello,
>
> On Sat, Mar 17, 2018 at 10:24:18PM -0700, Philippe Ombredanne wrote:
>> > v2:
>> > - clarify license version (it should be GPL 2.0)
>> > - use SPDX header
>>
>> For the use of SPDX ids, you have my ack: (I am not qualified for the rest)
>>
>> Acked-by: Philippe Ombredanne 
>
> I don't think it's a good idea to add this acked-by when it's purely
> based on a single liner license tag.  I understand that you want to
> encourage use of the new tags but this can be misleading and it'd be
> great if you reconsider sending out acks like this.
>
> Thanks.


You have a good point. I find it confusing myself.
Please, remove this ack!

-- 
Cordially
Philippe Ombredanne

Re: [PATCH 1/5 v4] add compression algorithm zBeWalgo

[Philippe Ombredanne]

Benjamin,

On Wed, Mar 21, 2018 at 12:32 AM, Benjamin Warnke
<4bwar...@informatik.uni-hamburg.de> wrote:
> Ok, I will use
>
> /* SPDX-License-Identifier: GPL-2.0 */
> /*
>  * Copyright (c) 2018 Benjamin Warnke <4bwar...@informatik.uni-hamburg.de>
> ...
>
> at the top of my files instead of that boilerplate text. And
>
> MODULE_LICENSE("GPL");
>
> at the bottom of the module-files.


>
> I used the file "crypto/lz4.c" - since it is a compression algorithm too - as 
> an example of how to format the licensing text.
> Unfortunately there is the same 'error'.
> I fixed this error in all of my files in all patches.

Actually to be consistent if you want to use GPL-2-0 (and not "or
later") you should use:

1. at the top, for a c. file:
// SPDX-License-Identifier: GPL-2.0

or for a .h file:
/* SPDX-License-Identifier: GPL-2.0 */

The doc explains it all. Including the comment style (a topic that has
been discussed also on list quite bit: Linus had the final word there)

2. and in your MODULE_LICENSE macro:

MODULE_LICENSE("GPL v2");

 because a MODULE_LICENSE("GPL"); would mean GPL-2.0+ (e.g. or any
later version) and this would not match your top level license tag.

I know this may seem confusing, but there is little hope we can change
the MODULE_LICENSE tags that are used by many external module loaders.
Comments in module.h explain it all.

-- 
Cordially
Philippe Ombredanne

Re: [PATCH 1/5 v4] add compression algorithm zBeWalgo

[Philippe Ombredanne]

Hi Benjamin,

On Tue, Mar 20, 2018 at 7:04 AM, Benjamin Warnke
<4bwar...@informatik.uni-hamburg.de> wrote:
> zBeWalgo is a completely new algorithm - Currently it is not published
> somewhere else right now, googleing it would not show up any results. The
> following section describes how the algorithm works.



> diff --git a/lib/zbewalgo/zbewalgo.c b/lib/zbewalgo/zbewalgo.c
> new file mode 100644
> index 0..ef922bc27
> --- /dev/null
> +++ b/lib/zbewalgo/zbewalgo.c
> @@ -0,0 +1,723 @@
> +/*
> + * Copyright (c) 2018 Benjamin Warnke <4bwar...@informatik.uni-hamburg.de>
> + *
> + * This program is free software; you can redistribute it and/or modify it
> + * under the terms of the GNU General Public License version 2 as published 
> by
> + * the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful, but 
> WITHOUT
> + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
> + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
> + * more details.
> + *
> + * You should have received a copy of the GNU General Public License along 
> with
> + * this program.
> + *

Would you mind using SPDX ids [1] instead of this fine boilerplate
here and throughout your patches?



> +MODULE_LICENSE("GPL");
> +MODULE_DESCRIPTION("zBeWalgo Compression Algorithm");

Here your MODULE_LICENSE does not match your top level license. See
module.h [2] for a description of values: GPL would mean "GNU Public
License v2 or later" whereas your top level license (best expressed
with SPDX) would mean GPL-2.0 and no other version. To avoid
confusion, you would need to state the same thing in the
MODULE_LICENSE and your SPDX tags.

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst
[2] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/linux/module.h#n175
-- 
Cordially
Philippe Ombredanne

Re: [PATCH v3] ata: add Amiga Gayle PATA controller driver

[Philippe Ombredanne]

On Fri, Mar 16, 2018 at 9:15 AM, Bartlomiej Zolnierkiewicz
 wrote:
> Add Amiga Gayle PATA controller driver. It enables libata support
> for the on-board IDE interfaces on some Amiga models (A600, A1200,
> A4000 and A4000T) and also for IDE interfaces on the Zorro expansion
> bus (M-Tech E-Matrix 530 expansion card).
>
> Thanks to John Paul Adrian Glaubitz and Michael Schmitz for help
> with testing the driver.
>
> Tested-by: John Paul Adrian Glaubitz 
> Cc: Michael Schmitz 
> Cc: Geert Uytterhoeven 
> Cc: Philippe Ombredanne 
> Cc: Andy Shevchenko 
> Signed-off-by: Bartlomiej Zolnierkiewicz 
> ---
> v3:
> - fix minor issues reported by Andy
>
> v2:
> - clarify license version (it should be GPL 2.0)
> - use SPDX header

For the use of SPDX ids, you have my ack: (I am not qualified for the rest)

Acked-by: Philippe Ombredanne 

-- 
Cordially
Philippe Ombredanne

Re: [PATCH v0 1/3] livepatch: add sample cumulative patch

[Philippe Ombredanne]

Miroslav,

On Tue, Feb 27, 2018 at 3:54 AM, Miroslav Benes  wrote:
> On Sat, 24 Feb 2018, Philippe Ombredanne wrote:
>
>> Joe,
>>
>> On Fri, Feb 23, 2018 at 1:33 PM, Joe Lawrence  
>> wrote:
>> > Add a simple atomic replace / cumulative livepatch example.
>> >
>> > Signed-off-by: Joe Lawrence 
>> > ---
>> >  samples/livepatch/Makefile   |   1 +
>> >  samples/livepatch/livepatch-cumulative.c | 216 
>> > +++
>> >  2 files changed, 217 insertions(+)
>> >  create mode 100644 samples/livepatch/livepatch-cumulative.c
>> >
>> > diff --git a/samples/livepatch/Makefile b/samples/livepatch/Makefile
>> > index 2472ce39a18d..dd0e2a8af1af 100644
>> > --- a/samples/livepatch/Makefile
>> > +++ b/samples/livepatch/Makefile
>> > @@ -5,3 +5,4 @@ obj-$(CONFIG_SAMPLE_LIVEPATCH) += livepatch-shadow-fix2.o
>> >  obj-$(CONFIG_SAMPLE_LIVEPATCH) += livepatch-callbacks-demo.o
>> >  obj-$(CONFIG_SAMPLE_LIVEPATCH) += livepatch-callbacks-mod.o
>> >  obj-$(CONFIG_SAMPLE_LIVEPATCH) += livepatch-callbacks-busymod.o
>> > +obj-$(CONFIG_SAMPLE_LIVEPATCH) += livepatch-cumulative.o
>> > diff --git a/samples/livepatch/livepatch-cumulative.c 
>> > b/samples/livepatch/livepatch-cumulative.c
>> > new file mode 100644
>> > index ..ab036439e08c
>> > --- /dev/null
>> > +++ b/samples/livepatch/livepatch-cumulative.c
>> > @@ -0,0 +1,216 @@
>> > +/*
>> > + * Copyright (C) 2018 Joe Lawrence 
>> > + *
>> > + * This program is free software; you can redistribute it and/or
>> > + * modify it under the terms of the GNU General Public License
>> > + * as published by the Free Software Foundation; either version 2
>> > + * of the License, or (at your option) any later version.
>> > + *
>> > + * This program is distributed in the hope that it will be useful,
>> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> > + * GNU General Public License for more details.
>> > + *
>> > + * You should have received a copy of the GNU General Public License
>> > + * along with this program; if not, see <http://www.gnu.org/licenses/>.
>> > + */
>>
>> May be you could use the new SPDX tags instead of this fine but long
>> legalese? [1]
>> This would replace ~12 lines of comment by a single line with the same 
>> effect.
>> Thanks!
>
> I don't know about that. How come it is perceived as equivalent? I mean,
> we have a well-established way how to say that a particular source
> code/file is distributed with GPL license. Well-established means that
> it's been tested in court AFAIK many times. Even the license itself (found
> in COPYING file) mentions this as way how to attach the license to a file.
>
> Now you want it to be replaced with a tag. Does it say the same? It might.
> It might not. Do we know? Have you got a court ruling which would say that
> this is also a way how to attach a license to a file? I doubt it. It may
> seem trivially clear, but there are no such things in the legal world.
>
> Don't make me wrong. I don't like that copyright thingie much. I don't
> like that you can find even different versions of the text in the kernel
> source code (and not only there).
>
> However I'd prefer to leave at least a note there that the file is still
> distributed under the terms of GPL found in COPYING file. The tag can be
> there too, if it makes someone happy.
>
> Regards,
> Miroslav
>
>> [1]  
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst
>> --
>> Philippe
>>
>

To the best of my knowledge, this has been debated in person and on
list among maintainers and agreed to.
This has also been reviewed by the LF lawyers. The result of is the
documentation in [1]
You are welcomed not to agree of course, but this would make your
contributions stand out with its legalese boilerplate when we are
trying to get of it.

Greg, anything else to add?

CC: Greg Kroah-Hartman 
-- 
Cordially
Philippe Ombredanne

Re: [PATCH v6 03/20] firmware: arm_scmi: add basic driver infrastructure for SCMI

[Philippe Ombredanne]

Sudeep,

On Fri, Feb 23, 2018 at 8:23 AM, Sudeep Holla  wrote:
> The SCMI is intended to allow OSPM to manage various functions that are
> provided by the hardware platform it is running on, including power and
> performance functions. SCMI provides two levels of abstraction, protocols
> and transports. Protocols define individual groups of system control and
> management messages. A protocol specification describes the messages
> that it supports. Transports describe the method by which protocol
> messages are communicated between agents and the platform.
>
> This patch adds basic infrastructure to manage the message allocation,
> initialisation, packing/unpacking and shared memory management.
>
> Cc: Arnd Bergmann 
> Cc: Greg Kroah-Hartman 
> Signed-off-by: Sudeep Holla 




> --- /dev/null
> +++ b/drivers/firmware/arm_scmi/common.h
> @@ -0,0 +1,77 @@
> +/*
> + * System Control and Management Interface (SCMI) Message Protocol
> + * driver common header file containing some definitions, structures
> + * and function prototypes used in all the different SCMI protocols.
> + *
> + * Copyright (C) 2017 ARM Ltd.
> + *
> + * This program is free software; you can redistribute it and/or modify it
> + * under the terms and conditions of the GNU General Public License,
> + * version 2, as published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope it will be useful, but WITHOUT
> + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
> + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
> + * more details.
> + *
> + * You should have received a copy of the GNU General Public License along
> + * with this program. If not, see <http://www.gnu.org/licenses/>.
> + */

Would you consider using the SPDX tags [1] instead of this legalese?
Thanks!

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst
-- 
Cordially
Philippe Ombredanne

Re: [PATCH v0 1/3] livepatch: add sample cumulative patch

[Philippe Ombredanne]

Joe,

On Fri, Feb 23, 2018 at 1:33 PM, Joe Lawrence  wrote:
> Add a simple atomic replace / cumulative livepatch example.
>
> Signed-off-by: Joe Lawrence 
> ---
>  samples/livepatch/Makefile   |   1 +
>  samples/livepatch/livepatch-cumulative.c | 216 
> +++
>  2 files changed, 217 insertions(+)
>  create mode 100644 samples/livepatch/livepatch-cumulative.c
>
> diff --git a/samples/livepatch/Makefile b/samples/livepatch/Makefile
> index 2472ce39a18d..dd0e2a8af1af 100644
> --- a/samples/livepatch/Makefile
> +++ b/samples/livepatch/Makefile
> @@ -5,3 +5,4 @@ obj-$(CONFIG_SAMPLE_LIVEPATCH) += livepatch-shadow-fix2.o
>  obj-$(CONFIG_SAMPLE_LIVEPATCH) += livepatch-callbacks-demo.o
>  obj-$(CONFIG_SAMPLE_LIVEPATCH) += livepatch-callbacks-mod.o
>  obj-$(CONFIG_SAMPLE_LIVEPATCH) += livepatch-callbacks-busymod.o
> +obj-$(CONFIG_SAMPLE_LIVEPATCH) += livepatch-cumulative.o
> diff --git a/samples/livepatch/livepatch-cumulative.c 
> b/samples/livepatch/livepatch-cumulative.c
> new file mode 100644
> index ..ab036439e08c
> --- /dev/null
> +++ b/samples/livepatch/livepatch-cumulative.c
> @@ -0,0 +1,216 @@
> +/*
> + * Copyright (C) 2018 Joe Lawrence 
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License
> + * as published by the Free Software Foundation; either version 2
> + * of the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, see .
> + */

May be you could use the new SPDX tags instead of this fine but long
legalese? [1]
This would replace ~12 lines of comment by a single line with the same effect.
Thanks!

[1]  
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst
--
Philippe

Re: [PATCH 08/10] gpio: Add gpio driver for Actions OWL S900 SoC

[Philippe Ombredanne]

Manivannan,

On Sat, Feb 17, 2018 at 9:44 PM, Manivannan Sadhasivam
 wrote:
> Add gpio driver for Actions Semi OWL family S900 SoC. Set of registers
> controlling the gpio shares the same register range with pinctrl block.
>
> GPIO registers are organized as 6 banks and each bank controls the
> maximum of 32 gpios.
>
> Signed-off-by: Manivannan Sadhasivam 



> --- /dev/null
> +++ b/drivers/gpio/gpio-owl.c
> @@ -0,0 +1,258 @@
> +// SPDX-License-Identifier: GPL-2.0+



> +MODULE_LICENSE("GPL v2");

Please sync this with your SPDX id above. nodule.h has the doc on the
meaning of MODULE_LICENSE macros.
Here you have stated a combo of GPL-2.0 and GPL-2.0 or later

-- 
Cordially
Philippe Ombredanne

Re: [PATCH 04/10] pinctrl: actions: Add Actions S900 pinctrl driver

[Philippe Ombredanne]

Dear Manivannan,

On Sat, Feb 17, 2018 at 9:44 PM, Manivannan Sadhasivam
 wrote:
> Add pinctrl driver for Actions Semi S900 SoC. The driver supports
> pinctrl, pinmux and pinconf functionalities through a range of registers
> common to both gpio driver and pinctrl driver.
>
> Pinmux functionality is available only for the pin groups while the
> pinconf functionality is available for both pin groups and individual
> pins.
>
> Signed-off-by: Manivannan Sadhasivam 





> --- /dev/null
> +++ b/drivers/pinctrl/actions/pinctrl-s900.c
> @@ -0,0 +1,2536 @@
> +// SPDX-License-Identifier: GPL-2.0+



> +MODULE_LICENSE("GPL v2");

This does not match your license above. Per module.h "GPL v2" means
GPL-2.0 where you license above GPL-2.0+ means or later

-- 
Cordially
Philippe Ombredanne

Re: [PATCH v3 2/2] net: ethernet: nixge: Add support for National Instruments XGE netdev

[Philippe Ombredanne]

Hi Moritz,

On Fri, Feb 16, 2018 at 6:00 PM, Moritz Fischer  wrote:
> Add support for the National Instruments XGE 1/10G network device.
>
> It uses the EEPROM on the board via NVMEM.
>
> Signed-off-by: Moritz Fischer 



> --- /dev/null
> +++ b/drivers/net/ethernet/ni/nixge.c
> @@ -0,0 +1,1352 @@
> +// SPDX-License-Identifier: GPL-2.0



> +MODULE_LICENSE("GPL");

This does not match your license above. Per module.h "GPL" would mean "GPL-2.0+"
Can you use one or the other an\d ensure both of these are in sync?

-- 
Cordially
Philippe Ombredanne

Re: [PATCH] auxdisplay: Replace licenses with SPDX identifiers

[Philippe Ombredanne]

On Sun, Feb 18, 2018 at 9:18 PM, Joe Perches  wrote:
> On Sun, 2018-02-18 at 20:37 +0100, Geert Uytterhoeven wrote:
>> Hi Philippe,
>>
>> On Sun, Feb 18, 2018 at 8:04 PM, Philippe Ombredanne
>>  wrote:
>> > On Sat, Feb 17, 2018 at 8:39 PM, Miguel Ojeda
>> >  wrote:
>> > > Cc: Willy Tarreau 
>> > > Cc: Geert Uytterhoeven 
>> > > Cc: Linus Walleij 
>> > > Cc: Robin van der Gracht 
>> > > Cc: Paul Burton 
>> > > Signed-off-by: Miguel Ojeda 
>> > > ---
>> >
>> > 
>> >
>> > > diff --git a/include/linux/cfag12864b.h b/include/linux/cfag12864b.h
>> > > index b454dfce60d9..aa960efc32f6 100644
>> > > --- a/include/linux/cfag12864b.h
>> > > +++ b/include/linux/cfag12864b.h
>> > > @@ -1,25 +1,11 @@
>> > > +// SPDX-License-Identifier: GPL-2.0
>> >
>> > Per the doc [1] you should be using instead this in a .h:
>> > /* SPDX-License-Identifier: GPL-2.0 */
>> >
>> > I know this can be surprising. This has been discussed on list quite
>> > lot and the doc has some rationale.
>> >
>> > 
>> >
>> > > diff --git a/include/linux/ks0108.h b/include/linux/ks0108.h
>> > > index cb311798e0bc..2a1c985fedea 100644
>> > > --- a/include/linux/ks0108.h
>> > > +++ b/include/linux/ks0108.h
>> > > @@ -1,25 +1,11 @@
>> > > +// SPDX-License-Identifier: GPL-2.0
>> >
>> > Same comment as above.
>> >
>> > [1] 
>> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst
>> >
>>
>> Obviously we need a check in scripts/checkpatch.pl, to catch this
>> before submission...
>>
>> Care to send a patch?
>
> There's one already in progress.
> https://lkml.org/lkml/2018/2/8/712
>


And I will try to help there as much as I can. Time to dust off my Perl!
-- 
Cordially
Philippe Ombredanne

Re: [RFCv4 09/21] v4l2: add request API support

[Philippe Ombredanne]

On Tue, Feb 20, 2018 at 5:44 AM, Alexandre Courbot
 wrote:
> Add a v4l2 request entity data structure that takes care of storing the
> request-related state of a V4L2 device ; in this case, its controls.
>
> Signed-off-by: Alexandre Courbot 



> --- /dev/null
> +++ b/drivers/media/v4l2-core/v4l2-request.c
> @@ -0,0 +1,178 @@
> +/*
> + * Media requests support for V4L2
> + *
> + * Copyright (C) 2018, The Chromium OS Authors.  All rights reserved.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */

Do you mind using SPDX tags per [1] rather that this fine but long
legalese. (Here and in the whole patch series)

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst
-- 
Cordially
Philippe Ombredanne

Re: [PATCH v7 15/61] xarray: Add xa_load

[Philippe Ombredanne]

Matthew,

On Mon, Feb 19, 2018 at 8:45 PM, Matthew Wilcox  wrote:
> From: Matthew Wilcox 
>
> This first function in the XArray API brings with it a lot of support
> infrastructure.  The advanced API is based around the xa_state which is
> a more capable version of the radix_tree_iter.
>
> As the test-suite demonstrates, it is possible to use the xarray and
> radix tree APIs on the same data structure.
>
> Signed-off-by: Matthew Wilcox 




> --- /dev/null
> +++ b/tools/testing/radix-tree/xarray-test.c
> @@ -0,0 +1,56 @@
> +/*
> + * xarray-test.c: Test the XArray API
> + * Copyright (c) 2017 Microsoft Corporation 
> + *
> + * This program is free software; you can redistribute it and/or modify it
> + * under the terms and conditions of the GNU General Public License,
> + * version 2, as published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope it will be useful, but WITHOUT
> + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
> + * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
> + * more details.
> + */

Do you mind using SPDX tags per [1] rather that this fine but long legalese?
Unless you are a legalese lover of course.

You will also get bonus karma points if you can spread the word within
your group!

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst
-- 
Cordially
Philippe Ombredanne

Re: [v3,04/11] watchdog/hpwdt: white space changes

[Philippe Ombredanne]

Jerry,

On Sat, Feb 17, 2018 at 5:17 PM, Guenter Roeck  wrote:
> On Thu, Feb 15, 2018 at 04:43:53PM -0700, Jerry Hoemann wrote:
>> Minor white space changes and some name clean up.
>>
>> Signed-off-by: Jerry Hoemann 
>> ---
>>  drivers/watchdog/hpwdt.c | 49 
>> +++-
>>  1 file changed, 23 insertions(+), 26 deletions(-)
>>
>> diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c
>> index 07810caabf74..d5989acf3e37 100644
>> --- a/drivers/watchdog/hpwdt.c
>> +++ b/drivers/watchdog/hpwdt.c
>> @@ -1,11 +1,9 @@
>>  /*
>>   *   HPE WatchDog Driver
>> - *   based on
>>   *
>> - *   SoftDog 0.05:   A Software Watchdog Device
>> - *
>> - *   (c) Copyright 2015 Hewlett Packard Enterprise Development LP
>> + *   (c) Copyright 2018 Hewlett Packard Enterprise Development LP
>>   *   Thomas Mingarelli 
>> + *   Jerry Hoemann 
>>   *
>>   *   This program is free software; you can redistribute it and/or
>>   *   modify it under the terms of the GNU General Public License

It would be awesome if you could adopt SPDX ids here and in all HPE
existing and future contributions [1] rather than this fine legalese.

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst
-- 
Cordially
Philippe Ombredanne

Re: [PATCH 05/17] trace doc: convert trace/ftrace.txt to rst format

[Philippe Ombredanne]

Changbin, Steven,

On Sat, Feb 17, 2018 at 6:39 AM,   wrote:
> From: Changbin Du 
>
> This converts the plain text documentation to reStructuredText format and
> add it into Sphinx TOC tree. No essential content change.
>
> Cc: Steven Rostedt 
> Signed-off-by: Changbin Du 
> ---
>  Documentation/trace/ftrace.rst | 3332 
> 
>  Documentation/trace/ftrace.txt | 3220 --
>  Documentation/trace/index.rst  |1 +
>  3 files changed,  insertions(+), 3220 deletions(-)
>  create mode 100644 Documentation/trace/ftrace.rst
>  delete mode 100644 Documentation/trace/ftrace.txt
>
> diff --git a/Documentation/trace/ftrace.rst b/Documentation/trace/ftrace.rst
> new file mode 100644
> index 000..636aa9bf
> --- /dev/null
> +++ b/Documentation/trace/ftrace.rst
> @@ -0,0 +1,3332 @@
> +
> +ftrace - Function Tracer
> +
> +
> +Copyright 2008 Red Hat Inc.
> +
> +:Author:   Steven Rostedt 
> +:License:  The GNU Free Documentation License, Version 1.2
> +  (dual licensed under the GPL v2)


Do you mind using an SPDX id per [1] rather that this?

Steven, are you OK with this? Can you ack?

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst
-- 
Cordially
Philippe Ombredanne

Re: [PATCH 2/4] ARM: OMAP2+: Introduce low-level suspend code for AM43XX

[Philippe Ombredanne]

Dave,

On Fri, Feb 16, 2018 at 10:40 PM, Dave Gerlach  wrote:
> Although similar to AM33XX, introduce a new low-level asm file for
> suspend containing new context save and restore paths for EMIF and l2
> cache disabling and enabling.
>
> Signed-off-by: Dave Gerlach 
> ---
>  arch/arm/mach-omap2/sleep43xx.S | 393 
> 
>  1 file changed, 393 insertions(+)
>  create mode 100644 arch/arm/mach-omap2/sleep43xx.S
>
> diff --git a/arch/arm/mach-omap2/sleep43xx.S b/arch/arm/mach-omap2/sleep43xx.S
> new file mode 100644
> index ..3a8bfd62a33c
> --- /dev/null
> +++ b/arch/arm/mach-omap2/sleep43xx.S
> @@ -0,0 +1,393 @@
> +/*
> + * Low level suspend code for AM43XX SoCs
> + *
> + * Copyright (C) 2013-2018 Texas Instruments Incorporated - 
> http://www.ti.com/
> + * Dave Gerlach, Vaibhav Bedia
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation version 2.
> + *
> + * This program is distributed "as is" WITHOUT ANY WARRANTY of any
> + * kind, whether express or implied; without even the implied warranty
> + * of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */

Do you mind using SPDX tags per [1] rather that this fine but long
legalese here and in the whole patch set? Unless you are a legalese
lover of course!

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst
-- 
Cordially
Philippe Ombredanne

Re: [PATCH] auxdisplay: Replace licenses with SPDX identifiers

[Philippe Ombredanne]

Miguel,

On Sat, Feb 17, 2018 at 8:39 PM, Miguel Ojeda
 wrote:
> Cc: Willy Tarreau 
> Cc: Geert Uytterhoeven 
> Cc: Linus Walleij 
> Cc: Robin van der Gracht 
> Cc: Paul Burton 
> Signed-off-by: Miguel Ojeda 
> ---



> diff --git a/include/linux/cfag12864b.h b/include/linux/cfag12864b.h
> index b454dfce60d9..aa960efc32f6 100644
> --- a/include/linux/cfag12864b.h
> +++ b/include/linux/cfag12864b.h
> @@ -1,25 +1,11 @@
> +// SPDX-License-Identifier: GPL-2.0

Per the doc [1] you should be using instead this in a .h:
/* SPDX-License-Identifier: GPL-2.0 */

I know this can be surprising. This has been discussed on list quite
lot and the doc has some rationale.



> diff --git a/include/linux/ks0108.h b/include/linux/ks0108.h
> index cb311798e0bc..2a1c985fedea 100644
> --- a/include/linux/ks0108.h
> +++ b/include/linux/ks0108.h
> @@ -1,25 +1,11 @@
> +// SPDX-License-Identifier: GPL-2.0

Same comment as above.

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst

-- 
Cordially
Philippe Ombredanne

Re: [PATCH v4] rtc: isl12026: Add driver.

[Philippe Ombredanne]

Hi David,

On Fri, Feb 16, 2018 at 8:44 PM, David Daney  wrote:
> The ISL12026 is a combination RTC and EEPROM device with I2C
> interface.  The standard RTC driver interface is provided.  The EEPROM
> is accessed via the NVMEM interface via the "eeprom0" directory in the
> sysfs entry for the device.
>
> Reviewed-by: Andy Shevchenko 
> Signed-off-by: David Daney 



> --- /dev/null
> +++ b/drivers/rtc/rtc-isl12026.c
> @@ -0,0 +1,529 @@
> +// SPDX-License-Identifier: GPL-2.0



> +MODULE_LICENSE("GPL");

Your MODULE_LICENSE does not match your SPDX tag.
Per module.h, GPL would mean GPL-2.0+ not GPL-2.0
It would be best if you can sync the two.

-- 
Cordially
Philippe Ombredanne

Re: [PATCH v3 6/7] arm64: tegra: Add Tegra194 chip device tree

[Philippe Ombredanne]

Mikko,

On Thu, Feb 15, 2018 at 3:52 PM, Mikko Perttunen  wrote:
> Add the chip-level device tree, including binding headers, for the
> NVIDIA Tegra194 "Xavier" system-on-chip. Only a small subset of devices
> are initially available, enough to boot to UART console.
>
> Signed-off-by: Mikko Perttunen 
> ---
>
> Notes:
> v3:
> - added hypervisor-related apertures to GIC node
> - removed GPL boilerplate in favor of SPDX and harmonized
>   copyright headers

Thanks for this boilerplate removal! but see a few nits below.



> --- /dev/null
> +++ b/include/dt-bindings/clock/tegra194-clock.h
> @@ -0,0 +1,653 @@
> +/*
> + * Copyright (c) 2018, NVIDIA CORPORATION. All rights reserved.
> + *
> + * SPDX-License-Identifier: GPL-2.0
> + */

The proper style should be this for a .h header on the first line per [1]

> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Copyright (c) 2018, NVIDIA CORPORATION. All rights reserved.
> + *
> + */

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst



> --- /dev/null
> +++ b/include/dt-bindings/gpio/tegra194-gpio.h
> @@ -0,0 +1,64 @@
> +/*
> + * Copyright (c) 2018, NVIDIA CORPORATION. All rights reserved.
> + *
> + * SPDX-License-Identifier: GPL-2.0
> + */
> +



Same as above

> --- /dev/null
> +++ b/include/dt-bindings/power/tegra194-powergate.h
> @@ -0,0 +1,38 @@
> +/*
> + * Copyright (c) 2018, NVIDIA CORPORATION. All rights reserved.
> + *
> + * SPDX-License-Identifier: GPL-2.0
> + */



Same as above

> --- /dev/null
> +++ b/include/dt-bindings/reset/tegra194-reset.h
> @@ -0,0 +1,155 @@
> +/*
> + * Copyright (c) 2018, NVIDIA CORPORATION. All rights reserved.
> + *
> + * SPDX-License-Identifier: GPL-2.0
> + */



Same as above
-- 
Cordially
Philippe Ombredanne

Re: [PATCH v2 1/1] clk: npcm7xx: add clock controler. fixed clock at DT

[Philippe Ombredanne]

Tali,

On Thu, Feb 15, 2018 at 2:30 PM, Tali Perry  wrote:
> --- /dev/null
> +++ b/drivers/clk/clk-npcm7xx.c
> @@ -0,0 +1,759 @@
> +/*
> + * Nuvoton NPCM7xx Clock Generator
> + * All the clocks are initialized by the bootloader, so this driver allow 
> only
> + * reading of current settings directly from the hardware.
> + *
> + * Copyright (C) 2018 Nuvoton Technologies tali.pe...@nuvoton.com
> + *
> + * SPDX-License-Identifier: GPL-2.0
> + * Released under the GPLv2 only.
> + */

Thank you for using the SPDX tags! but this can be streamlined a bit per [1]

The correct way would come out as this: (note the tag placement and
comment style and the removal of the now redundant unstructured
notice)

> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Nuvoton NPCM7xx Clock Generator
> + * All the clocks are initialized by the bootloader, so this driver allow 
> only
> + * reading of current settings directly from the hardware.
> + *
> + * Copyright (C) 2018 Nuvoton Technologies tali.pe...@nuvoton.com
> + */

And yes you may be surprised by the use of C++ style comment for
this... This has been discussed on list and is what Linus prefers.

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst
-- 
Cordially
Philippe Ombredanne

Re: [PATCHv4 2/4] ASoC: codec: cpcap: new codec

[Philippe Ombredanne]

Dear Sebastian,

On Wed, Feb 14, 2018 at 11:07 PM, Sebastian Reichel
 wrote:
> Motorola CPCAP is a PMIC with audio functionality, that can be
> found on Motorola Droid 4 and probably a few other phones from
> Motorola's Droid series.
>
> The driver has been written from scratch using Motorola's Android
> driver, register dumps from running Android and datasheet for NXP
> MC13783UG (which is similar to Motorola CPCAP, but not the same).
>
> The chip provides two audio interfaces, that can be muxed to two
> different audio codecs. One provides support for stereo output
> (named StDAC or HiFi), while the other only provides mono output
> (named Voice). Only the Voice codec provides a Capture interface.
>
> Signed-off-by: Sebastian Reichel 



> --- /dev/null
> +++ b/sound/soc/codecs/cpcap.c
> @@ -0,0 +1,1588 @@
> +/*
> + * ALSA SoC CPCAP codec driver
> + *
> + * Copyright (C) 2017 - 2018 Sebastian Reichel 
> + *
> + * Very loosely based on original driver from Motorola:
> + * Copyright (C) 2007 - 2009 Motorola, Inc.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + */

Could you consider using the new SPDX tags instead of this fine but
long legalese? [1]



> +MODULE_ALIAS("platform:cpcap-codec");
> +MODULE_DESCRIPTION("ASoC CPCAP codec driver");
> +MODULE_AUTHOR("Sebastian Reichel");
> +MODULE_LICENSE("GPL");

This does not match your license: per module.h, GPL means GPL-2.0 or
later. You notice above is GPL-2.0, not "or later"

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst

-- 
Cordially
Philippe Ombredanne

Re: [PATCH v5 10/12] drm/sun4i: Implement A83T HDMI driver

[Philippe Ombredanne]

On Wed, Feb 14, 2018 at 9:09 PM, Jernej Skrabec  wrote:
> A83T has DW HDMI IP block with a custom PHY similar to Synopsys gen2
> HDMI PHY.
>
> Only video output was tested, while HW also supports audio and CEC.
> Support for them will be added later.
>
> Signed-off-by: Jernej Skrabec 

...

> --- /dev/null
> +++ b/drivers/gpu/drm/sun4i/sun8i_dw_hdmi.h
> @@ -0,0 +1,44 @@
> +// SPDX-License-Identifier: GPL-2.0+

This should be

/* SPDX-License-Identifier: GPL-2.0+ /* in a .h per [1]

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst
-- 
Cordially
Philippe Ombredanne

Re: [PATCH v3 4/8] MIPS: mscc: Add initial support for Microsemi MIPS SoCs

[Philippe Ombredanne]

Alexandre,

On Wed, Feb 14, 2018 at 5:51 PM, James Hogan  wrote:
> On Tue, Jan 16, 2018 at 11:12:36AM +0100, Alexandre Belloni wrote:

...

>> diff --git a/arch/mips/mscc/Platform b/arch/mips/mscc/Platform
>> new file mode 100644
>> index ..9ae874c8f136
>> --- /dev/null
>> +++ b/arch/mips/mscc/Platform
>> @@ -0,0 +1,12 @@
>> +# SPDX-License-Identifier: (GPL-2.0 OR MIT)
>> +#
>> +# Microsemi MIPS SoC support
>> +#
>> +# License: Dual MIT/GPL

IMHO you should remove this line as it exactly repeats the
SPDX-License-Identifier: (GPL-2.0 OR MIT) line in a less clear and
precise way.
The whole purpose of the SPDX things is to make licensing eventually
as clear ass possible
Thanks!
-- 
Cordially
Philippe Ombredanne

Re: [PATCH v3 1/2] ASoC: codecs: Add support for AK4458 DAC driver

[Philippe Ombredanne]

On Wed, Feb 14, 2018 at 2:21 PM, Cosmin-Gabriel Samoila
 wrote:
> The AK4458 is a 32-bit 8ch Premium DAC that corresponds
> to a 768kHz PCM input and an 11.2MHz DSD input at maximum.
> It supports I2S, DSD and TDM modes with 24 or 32 bit MSB
> or 16, 24, 32 LSB formats. Its datasheet is available here:
> https://www.akm.com/akm/en/file/datasheet/AK4458VN.pdf
>
> Signed-off-by: Junichi Wakasugi 
> Signed-off-by: Mihai Serban 
> Signed-off-by: Shengjiu Wang 
> Signed-off-by: Cosmin-Gabriel Samoila 
> ---

> --- /dev/null
> +++ b/sound/soc/codecs/ak4458.c
> @@ -0,0 +1,659 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Audio driver for AK4458 DAC
> + *
> + * Copyright (C) 2016 Asahi Kasei Microdevices Corporation
> + * Copyright 2018 NXP

Thanks for using the proper SPDX tag here yet see my comments below.



> +MODULE_AUTHOR("Junichi Wakasugi ");
> +MODULE_AUTHOR("Mihai Serban ");
> +MODULE_DESCRIPTION("ASoC AK4458 DAC driver");
> +MODULE_LICENSE("GPL");

This means GPL-2.0+ per module.h and therefore does not match your
GPL-2.0 SPDX tag above.
Go one way or the other, but not both way please.

> diff --git a/sound/soc/codecs/ak4458.h b/sound/soc/codecs/ak4458.h
> new file mode 100644
> index 000..16d9d22
> --- /dev/null
> +++ b/sound/soc/codecs/ak4458.h
> @@ -0,0 +1,86 @@
> +// SPDX-License-Identifier: GPL-2.0

As weird as it sounds the style should be plain /*
SPDX-License-Identifier: GPL-2.0 /* here per [1]

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst

-- 
Cordially
Philippe Ombredanne

Re: [PATCH 1/3] HID: add driver for Valve Steam Controller

[Philippe Ombredanne]

Benjamin, Rodrigo,

On Wed, Feb 14, 2018 at 3:45 PM, Benjamin Tissoires
 wrote:
> On Tue, Feb 13, 2018 at 1:03 PM, Rodrigo Rivas Costa 
>  wrote:


>> --- /dev/null
>> +++ b/drivers/hid/hid-steam.c
>> @@ -0,0 +1,480 @@
>> +// SPDX-License-Identifier: GPL-2.0
>
> Non standard header

Benjamin:
What do you mean by this?
This is following the proper style for this line as documented (and
discussed on list at great length) [1]

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst


>> +/*
>> + * HID driver for Valve Steam Controller
>> + *
>> + * Supports both the wired and wireless interfaces.
>> + *
>> + * Copyright (c) 2018 Rodrigo Rivas Costa 
>> + */
>> +
>> +/*
>> + * This program is free software; you can redistribute it and/or modify it
>> + * under the terms of the GNU General Public License as published by the 
>> Free
>> + * Software Foundation; either version 2 of the License, or (at your option)
>> + * any later version.
>> + */

Rodrigo,
Since you used the proper SPDX tag (in the proper style as explained
in the doc), you can remove this boilerplate alright as it does double
duty with the tag.

-- 
Cordially
Philippe Ombredanne

Re: [PATCH 05/15] ARM64: dts: Add R-Car Salvator-x M3-N support

[Philippe Ombredanne]

Jacopo,

On Wed, Feb 14, 2018 at 2:58 PM, Geert Uytterhoeven
 wrote:

>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dts
>> @@ -0,0 +1,30 @@
>> +// SPDX-License-Identifier: GPL-2.

This should be GPL-2.0



>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
>> @@ -0,0 +1,495 @@
>> +// SPDX-License-Identifier: GPL-2.

This should be GPL-2.0 too.
-- 
Cordially
Philippe Ombredanne

Re: [PATCH 4/4] staging: iio: accel: Move adis16201 driver out of staging

[Philippe Ombredanne]

On Mon, Feb 12, 2018 at 3:37 PM, Himanshu Jha
 wrote:
> On Mon, Feb 12, 2018 at 03:10:56PM +0100, Philippe Ombredanne wrote:
>> On Mon, Feb 12, 2018 at 12:54 PM, Himanshu Jha
>>  wrote:
>> > Move the adis16201 driver out of staging directory and merge to the
>> > mainline IIO directory.
>> >
>> > Signed-off-by: Himanshu Jha 
>>
>> 
>> > --- /dev/null
>> > +++ b/drivers/iio/accel/adis16201.c
>> > @@ -0,0 +1,315 @@
>> > +// SPDX-License-Identifier: GPL-2.0+
>>
>> 
>>
>> > +MODULE_AUTHOR("Barry Song <21cn...@gmail.com>");
>> > +MODULE_DESCRIPTION("Analog Devices ADIS16201 Dual-Axis Digital 
>> > Inclinometer and Accelerometer");
>> > +MODULE_LICENSE("GPL v2");
>> > +MODULE_ALIAS("spi:adis16201");
>>
>> Your MODULE_LICENSE does not match your SPDX license id.
>> MODULE_LICENSE("GPL v2"); means SPDX GPL-2.0
>> MODULE_LICENSE("GPL"); means SPDX GPL-2.0+
>>
>
> I didn't knew about that! Thanks for pointing.

Sure thing. I reckon this can be a tad surprising.
FWIW, the reference for the SPDX tag is in
Documentation/process/license-rules.rst and for the MODULE_LICENSE
macro this is in module.h
It is unlikely module.h will ever evolve there as this would break all
third-party module loaders/tools that rely on the documented data
values and conventions

-- 
Cordially
Philippe Ombredanne

Re: [PATCH] ata: add Amiga Gayle PATA controller driver

[Philippe Ombredanne]

On Mon, Feb 12, 2018 at 2:49 PM, Bartlomiej Zolnierkiewicz
 wrote:
> Add Amiga Gayle PATA controller driver. It enables libata support
> for the on-board IDE interfaces on some Amiga models (A600, A1200,
> A4000 and A4000T) and also for IDE interfaces on the Zorro expansion
> bus (M-Tech E-Matrix 530 expansion card).
>
> Thanks to John Paul Adrian Glaubitz and Michael Schmitz for help
> with testing the driver.
>
> Tested-by: John Paul Adrian Glaubitz 
> Cc: Michael Schmitz 
> Cc: Geert Uytterhoeven 
> Signed-off-by: Bartlomiej Zolnierkiewicz 


> + *
> + * This file is subject to the terms and conditions of the GNU General Public
> + * License.  See the file "COPYING" in the main directory of this archive
> + * for more details.
> + */

Do you mind using the new SDPX ids? (well not so new anymore). [1]


> +
> +MODULE_AUTHOR("Bartlomiej Zolnierkiewicz");
> +MODULE_DESCRIPTION("low-level driver for Amiga Gayle PATA");
> +MODULE_LICENSE("GPL");
> +MODULE_ALIAS("platform:amiga-gayle-ide");
> +MODULE_VERSION(DRV_VERSION);
>

 and while doing it please make sure your MODULE_LICENSE matches
the license.
Here for instance it is not clear to me if this a GPL-2.0 or a GPL-2.0+


Thanks!
[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst
-- 
Cordially
Philippe Ombredanne

+1 650 799 0949 | pombreda...@nexb.com
DejaCode - What's in your code?! - http://www.dejacode.com
AboutCode - Open source for open source - https://www.aboutcode.org
nexB Inc. - http://www.nexb.com

CONFIDENTIALITY NOTICE:  This e-mail (including attachments) may
contain information that is proprietary or confidential. If you are
not the intended recipient or a person responsible for its delivery to
the intended recipient, do not copy or distribute it. Please
permanently delete the e-mail and any attachments, and notify us
immediately at (650) 799 0949.

Re: [PATCH 2/6] mfd: Add ST Multi-Function eXpander core driver

[Philippe Ombredanne]

Amelie,

On Mon, Feb 12, 2018 at 1:06 PM, Lee Jones  wrote:
> On Thu, 08 Feb 2018, Amelie Delaunay wrote:
>
>> ST Multi-Function eXpander (MFX) is a slave controller using I2C
>> for communication with the main MCU. Main features are:
>> - 16 fast GPIOs individually configurable in input/output
>> - 8 alternate GPIOs individually configurable in input/output
>> - Main MCU IDD measurement
>> - Resistive touchscreen controller
>>
>> Only GPIO expander (16 fast GPIOs + 8 alternate) feature is
>> supported for the moment.
>>
>> Signed-off-by: Amelie Delaunay 



>> --- /dev/null
>> +++ b/drivers/mfd/st-mfx.c
>> @@ -0,0 +1,526 @@
>> +/*
>> + * STMicroelectronics Multi-Function eXpander (ST-MFX) Core Driver
>> + *
>> + * Copyright (C) 2017, STMicroelectronics - All Rights Reserved
>> + * Author(s): Amelie Delaunay  for 
>> STMicroelectronics.
>
> You don't need to put "for STMicroelectronics".  This was something we
> made up when submitting from a different (!st.com) email address.
>
>> + * License terms: GPL V2.0.
>> + *
>> + * st-mfx Core Driver is free software; you can redistribute it and/or 
>> modify it
>> + * under the terms of the GNU General Public License version 2 as published 
>> by
>> + * the Free Software Foundation.
>> + *
>> + * st-mfx Core Driver is distributed in the hope that it will be useful, but
>> + * WITHOUT ANY WARRANTY; without even the implied warranty of 
>> MERCHANTABILITY or
>> + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for 
>> more
>> + * details.
>> + *
>> + * You should have received a copy of the GNU General Public License along 
>> with
>> + * st-mfx Core Driver. If not, see <http://www.gnu.org/licenses/>.
>
> You should be able to use the short version of the licensing
> agreement.  Also, please grep for "SPDX".

You can check the doc for the (fairly new) way to remove legalese
boilerplate at Documentation/process/license-rules.rst or [1]
It helps keep the focus on the code and less on licensing!

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst
-- 
Cordially
Philippe Ombredanne

Re: [PATCH 4/4] staging: iio: accel: Move adis16201 driver out of staging

[Philippe Ombredanne]

On Mon, Feb 12, 2018 at 12:54 PM, Himanshu Jha
 wrote:
> Move the adis16201 driver out of staging directory and merge to the
> mainline IIO directory.
>
> Signed-off-by: Himanshu Jha 


> --- /dev/null
> +++ b/drivers/iio/accel/adis16201.c
> @@ -0,0 +1,315 @@
> +// SPDX-License-Identifier: GPL-2.0+



> +MODULE_AUTHOR("Barry Song <21cn...@gmail.com>");
> +MODULE_DESCRIPTION("Analog Devices ADIS16201 Dual-Axis Digital Inclinometer 
> and Accelerometer");
> +MODULE_LICENSE("GPL v2");
> +MODULE_ALIAS("spi:adis16201");

Your MODULE_LICENSE does not match your SPDX license id.
MODULE_LICENSE("GPL v2"); means SPDX GPL-2.0
MODULE_LICENSE("GPL"); means SPDX GPL-2.0+


-- 
Cordially
Philippe Ombredanne

Re: [RFC PATCH] soc: zynqmp: Add support for tap delay settings

[Philippe Ombredanne]

On Mon, Feb 12, 2018 at 11:35 AM, Manish Narani
 wrote:
> This patch add support for tep delays programming for zynqmp platform.
> This also adds dll reset support.
>
> Signed-off-by: Manish Narani 



> --- /dev/null
> +++ b/drivers/soc/xilinx/zynqmp/tap_delays.c
> @@ -0,0 +1,270 @@
> +/*
> + * Xilinx Zynq MPSoC Tap Delay Programming
> + *
> + *  Copyright (C) 2016 Xilinx, Inc.
> + *
> + * This program is free software: you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation, either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program.  If not, see <http://www.gnu.org/licenses/>.
> + */

Dear Manish,
Why not using the SPDX ids there too and elsewhere? You are using them
alright in many other places in this patch. See
Documentation/process/license-rules.rst for details
-- 
Cordially
Philippe Ombredanne

Re: [PATCH 14/17] s390/kexec_file: Add kexec_file_load system call

[Philippe Ombredanne]

On Mon, Feb 12, 2018 at 11:07 AM, Philipp Rudo  wrote:
> This patch adds the kexec_file_load system call to s390 as well as the arch
> specific functions common code requires to work. Loaders for the different
> file types will be added later.
>
> Signed-off-by: Philipp Rudo 



> --- /dev/null
> +++ b/arch/s390/kernel/machine_kexec_file.c
> @@ -0,0 +1,174 @@
> +/* SPDX-License-Identifier: GPL-2.0 */

I know this may sound weird but in .c files this should be instead:

// SPDX-License-Identifier: GPL-2.0

See Documentation/process/license-rules.rst for why.
-- 
Cordially
Philippe Ombredanne

Re: [PATCH v3 2/3] arm64: dts: sdm845: Add minimal dts files for sdm845 SoC/MTP

[Philippe Ombredanne]

On Mon, Feb 12, 2018 at 7:28 AM, Rajendra Nayak  wrote:
> Add a skeletal sdm845 SoC dtsi and MTP board dts/dtsi files
>
> Signed-off-by: Rajendra Nayak 
> ---
>  arch/arm64/boot/dts/qcom/Makefile   |   1 +
>  arch/arm64/boot/dts/qcom/sdm845-mtp.dts |  13 ++
>  arch/arm64/boot/dts/qcom/sdm845.dtsi| 275 
> 
>  3 files changed, 289 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/qcom/sdm845-mtp.dts
>  create mode 100644 arch/arm64/boot/dts/qcom/sdm845.dtsi
>
> diff --git a/arch/arm64/boot/dts/qcom/Makefile 
> b/arch/arm64/boot/dts/qcom/Makefile
> index 55ec5ee7f7e8..9319e74b8906 100644
> --- a/arch/arm64/boot/dts/qcom/Makefile
> +++ b/arch/arm64/boot/dts/qcom/Makefile
> @@ -6,3 +6,4 @@ dtb-$(CONFIG_ARCH_QCOM) += msm8916-mtp.dtb
>  dtb-$(CONFIG_ARCH_QCOM)+= msm8992-bullhead-rev-101.dtb
>  dtb-$(CONFIG_ARCH_QCOM)+= msm8994-angler-rev-101.dtb
>  dtb-$(CONFIG_ARCH_QCOM)+= msm8996-mtp.dtb
> +dtb-$(CONFIG_ARCH_QCOM)+= sdm845-mtp.dtb
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts 
> b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts
> new file mode 100644
> index ..617c7bb25fb1
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts
> @@ -0,0 +1,13 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (c) 2018, The Linux Foundation. All rights reserved.
> + */

This is more cosmetic, but since there is only a single line of
copyright statement and no other comments, it would make sense to use
C++ style // for that line too IMHO (and other similar cases)
-- 
Cordially
Philippe Ombredanne

Re: [PATCH v2 04/11] watchdog/hpwdt: white space changes

[Philippe Ombredanne]

Jerry,

On Mon, Feb 12, 2018 at 6:21 AM, Jerry Hoemann  wrote:
> Minor white space changes and some name clean up.
>
> Signed-off-by: Jerry Hoemann 
> ---
>  drivers/watchdog/hpwdt.c | 49 
> +++-
>  1 file changed, 23 insertions(+), 26 deletions(-)
>
> diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c
> index 6f7949ef9a23..ee9a92220ece 100644
> --- a/drivers/watchdog/hpwdt.c
> +++ b/drivers/watchdog/hpwdt.c
> @@ -1,11 +1,9 @@
>  /*
>   * HPE WatchDog Driver
> - * based on
>   *
> - * SoftDog 0.05:   A Software Watchdog Device
> - *
> - * (c) Copyright 2015 Hewlett Packard Enterprise Development LP
> + * (c) Copyright 2018 Hewlett Packard Enterprise Development LP
>   * Thomas Mingarelli 
> + * Jerry Hoemann 
>   *
>   * This program is free software; you can redistribute it and/or
>   * modify it under the terms of the GNU General Public License

Since you are updating the copyright, why not updating the licensing
to use the new concise SPDX ids instead? [1]
And you get a big good karma bonus if you can also do the same for all
HPE-copyrighted files, tree-wide ;) and/or spread the word inside your
team.

Thank you for your kind consideration!

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst

Cordially
Philippe Ombredanne

Re: [PATCH v5 01/11] scsi: ufs: sysfs: attribute group for existing sysfs entries.

[Philippe Ombredanne]

Dear Stanislav,

On Mon, Feb 12, 2018 at 2:06 AM, Jaegeuk Kim  wrote:
> On 02/06, Stanislav Nijnikov wrote:
>> This patch introduces attribute group to show existing sysfs entries.
>>
>> Signed-off-by: Stanislav Nijnikov 



>> --- /dev/null
>> +++ b/drivers/scsi/ufs/ufs-sysfs.c
>> @@ -0,0 +1,156 @@
>> +// SPDX-License-Identifier: GPL-2.0-only

I commend you for using license ids here. But there is an issue with
your attempt to use the latest and greatest license ids from SPDX:
GPL-2.0-only is not a documented license id in our doc [1]
Until this is updated (help welcomed including patching a few 10K+
files) , this should be GPL-2.0 instead to avoid confusion and keep
things homogeneous and tidy.

FYI, using only the doc as the reference was brought forward by
Russell King and Christoph Hellwig and in particular with this:

On Thu, Nov 9, 2017 at 5:44 PM, Russell King  wrote:

> I'd be more comfortable if we could have something in the kernel tree
> that identifies the SPDX tags and their meaning, maybe with the
> _standard_ file header for that license included, so there is no
> argument about what any particular SPDX tag means.

Based on this, Thomas Gleixner updated the doc alright following this
important point. So, in case of doubt the doc should be the reference
for this and nothing else. And if there are issue with the doc, then
we can fix it with a patch ;)

CC: Russell King 
CC: Christoph Hellwig 
CC: Thomas Gleixner 

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst
-- 
Cordially
Philippe Ombredanne

Re: [linux-sunxi] [PATCH v2 5/6] arm64: allwinner: h6: add the basical Allwinner H6 DTSI file

[Philippe Ombredanne]

Icenowy,

On Mon, Feb 12, 2018 at 12:26 AM, André Przywara  wrote:
> Hi,
>
> On 03/02/18 15:49, Icenowy Zheng wrote:
>> Allwinner H6 is a new SoC with Cortex-A53 cores from Allwinner, with its
>> memory map fully reworked and some high-speed peripherals (PCIe, USB
>> 3.0) introduced.
>>
>> This commit adds the basical DTSI file of it, including the clock
>> support and UART support.
>
> Checked the MMIO addresses and the interrupt numbers against the manual.
>
>> Signed-off-by: Icenowy Zheng 
>
> Reviewed-by: Andre Przywara 
>
> Thanks!
> Andre.
>
>> ---
>> Changes in v2:
>> - Add APB1 clock as PIO's APB clock.
>> - Switched to SPDX license identifier.
>>
>>  arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 178 
>> +++
>>  1 file changed, 178 insertions(+)
>>  create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
>>
>> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi 
>> b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
>> new file mode 100644
>> index ..d4697bb42496
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
>> @@ -0,0 +1,178 @@
>> +/*
>> + * Copyright (C) 2017 Icenowy Zheng 
>> + *
>> + * SPDX-License-Identifier: (GPL-2.0+ or MIT)
>> + */

Thank you for using SPDX ids: this needs to be on the first line
though! [1] and eventually some special comments style.

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst

-- 
Cordially
Philippe Ombredanne

Re: [PATCH 2/6] genalloc: selftest

[Philippe Ombredanne]

On Sun, Feb 11, 2018 at 4:19 AM, Igor Stoppa  wrote:
> Introduce a set of macros for writing concise test cases for genalloc.
>
> The test cases are meant to provide regression testing, when working on
> new functionality for genalloc.
>
> Primarily they are meant to confirm that the various allocation strategy
> will continue to work as expected.
>
> The execution of the self testing is controlled through a Kconfig option.
>
> Signed-off-by: Igor Stoppa 



> --- /dev/null
> +++ b/include/linux/genalloc-selftest.h
> @@ -0,0 +1,26 @@
> +/* SPDX-License-Identifier: GPL-2.0

nit... For a comment in .h this line should be instead its own comment
as the first line:
> +/* SPDX-License-Identifier: GPL-2.0 */



> --- /dev/null
> +++ b/lib/genalloc-selftest.c
> @@ -0,0 +1,400 @@
> +/* SPDX-License-Identifier: GPL-2.0

And for a comment in .c this line should use C++ style as the first line:

> +// SPDX-License-Identifier: GPL-2.0

Please check the docs for this (I know this can feel surprising but
this has been debated at great length on list)

Thank you!
-- 
Cordially
Philippe Ombredanne

Re: [PATCH] watchdog: coh901327: make license text and module licence match

[Philippe Ombredanne]

On Sat, Feb 10, 2018 at 10:27 AM, Marcus Folkesson
 wrote:
> Licence text is specifying "GPLv2" but the MODULE_LICENSE is set to "GPLv2
> or later".
>
> See include/linux/module.h:
> "GPL"   [GNU Public License v2 or later]
> "GPL v2"[GNU Public License v2]
>
> When on it, add SPDX identifier tag.
>
> Signed-off-by: Marcus Folkesson 
> ---
>  drivers/watchdog/coh901327_wdt.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/watchdog/coh901327_wdt.c 
> b/drivers/watchdog/coh901327_wdt.c
> index 5d8eb9a30879..7b71e0a3e6cc 100644
> --- a/drivers/watchdog/coh901327_wdt.c
> +++ b/drivers/watchdog/coh901327_wdt.c
> @@ -1,8 +1,8 @@
> +// SPDX-License-Identifier: GPL-2.0
>  /*
>   * coh901327_wdt.c
>   *
>   * Copyright (C) 2008-2009 ST-Ericsson AB
> - * License terms: GNU General Public License (GPL) version 2
>   * Watchdog driver for the ST-Ericsson AB COH 901 327 IP core
>   * Author: Linus Walleij 
>   */
> @@ -420,5 +420,5 @@ MODULE_DESCRIPTION("COH 901 327 Watchdog");
>  module_param(margin, uint, 0);
>  MODULE_PARM_DESC(margin, "Watchdog margin in seconds (default 60s)");
>
> -MODULE_LICENSE("GPL");
> +MODULE_LICENSE("GPL v2");
>  MODULE_ALIAS("platform:coh901327-watchdog");

Thank you!

Reviewed-by: Philippe Ombredanne 

-- 
Cordially
Philippe Ombredanne

Re: [PATCH 5/6] ARM: dts: tegra: apalis-tk1: copyright period, spurious newlines

[Philippe Ombredanne]

On Sat, Feb 10, 2018 at 9:40 AM, Marcel Ziswiler  wrote:

> Yes, I'm already in the process of preparing a separate patch set fixing this
> across all Toradex files. However I'm running this through our legal as well
> first to make absolutely sure it's all proper.

That's the way to go and thank you for this.
Do not hesitate to ping here or privately if there is any legal
concern that comes up.

-- 
Cordially
Philippe Ombredanne

Re: [PATCH v3 01/11] dt-bindings: clock: Add Actions S900 clock bindings

[Philippe Ombredanne]

Dear Manivannan,

On Sat, Feb 10, 2018 at 3:41 AM, Manivannan Sadhasivam
 wrote:
> Add Actions Semi S900 clock bindings.
>
> Signed-off-by: Manivannan Sadhasivam 
> Acked-by: Rob Herring 



> diff --git a/include/dt-bindings/clock/actions,s900-cmu.h 
> b/include/dt-bindings/clock/actions,s900-cmu.h
> new file mode 100644
> index ..2fa94e19922b
> --- /dev/null
> +++ b/include/dt-bindings/clock/actions,s900-cmu.h
> @@ -0,0 +1,139 @@
> +/*
> + * Device Tree binding constants for Actions S900 Clock Management Unit
> + *
> + * Copyright (c) 2014 Actions Semi Inc.
> + * Copyright (c) 2017 Linaro Ltd.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + */

Would you consider using the new SPDX license ids rather that this
time-tested but rather boring legalese?

The (still new and fresh) license documentation contributed by tglx
--the only maintainer that I know that understands both the innards of
Spectre and Meltdown and the beauty of reStructuredText -- is in:
Documentation/process/license-rules.rst

Practically this means replacing the above by a simple single line and
getting rid of a whopping 8 comment lines!

SPDX-License-Identifier: GPL-2.0+

You get to save a few tree as a bonus if you also do the same for all
Linaro-copyrighted files. Yes this is saving trees because I will use
less paper each time I print a listing of the kernel source code.
Which is something that I rarely if ever do: but somebody must do it
somewhere for sure.

If I do the math: we have ~60K files in the kernel, and say we can
remove roughly 5 lines of legalese per file on average. Each printed
source code page is roughly 60 lines : this will mean a saving of
about 6000 paper sheets saved on each printout! A letter-size paper
ream is 500 pages, about 2.5 Kg and costs about ~$8.  You can extract
about 10K to 20k sheets of paper per tree [1].
Therefore my Fermi estimate is that using shorter legalese in the
kernel will eventually save roughly ONE FULL smaller tree (6K pages)
each time someone prints the kernel code: incredible, right?

Thank  you for helping make the kernel a mostly legalese-free codebase
and saving trees at the same time!

[1] 
https://www.sierraclub.org/sierra/2014-4-july-august/green-life/how-much-paper-does-one-tree-produce
-- 
Cordially
Philippe Ombredanne

Re: [PATCH 5/6] ARM: dts: tegra: apalis-tk1: copyright period, spurious newlines

[Philippe Ombredanne]

Marcel,

On Sat, Feb 10, 2018 at 2:38 AM, Marcel Ziswiler  wrote:
> From: Marcel Ziswiler 
>
> Update the copyright period and get rid of some spurious newlines.
>
> Signed-off-by: Marcel Ziswiler 
>
> ---
>
>  arch/arm/boot/dts/tegra124-apalis-eval.dts |  6 ++
>  arch/arm/boot/dts/tegra124-apalis.dtsi | 11 +--
>  2 files changed, 3 insertions(+), 14 deletions(-)
>
> diff --git a/arch/arm/boot/dts/tegra124-apalis-eval.dts 
> b/arch/arm/boot/dts/tegra124-apalis-eval.dts
> index f1010cefb993..a6ad759dddb4 100644
> --- a/arch/arm/boot/dts/tegra124-apalis-eval.dts
> +++ b/arch/arm/boot/dts/tegra124-apalis-eval.dts
> @@ -1,5 +1,5 @@
>  /*
> - * Copyright 2016 Toradex AG
> + * Copyright 2016-2018 Toradex AG
>   *
>   * This file is dual-licensed: you can use it either under the terms
>   * of the GPL or the X11 license, at your option. Note that this dual

Since you are fixing copyrights, would you consider also fixing the
license to use a proper SPDX Id instead?

It would be super gentle of you!

And you will get extra good karma point if you feel like doing the
same for every Toradex-copyrighted files ;)

The (still new and fresh) license documentation contributed by tglx
--the only real-time docu-mentalist-- is in:
Documentation/process/license-rules.rst

Thanks!
-- 
Cordially
Philippe Ombredanne

Re: [PATCH 1/2] dt-bindings: clock: reset: Add AXG AO Clock and Reset Bindings

[Philippe Ombredanne]

On Fri, Feb 9, 2018 at 8:00 AM, Yixun Lan  wrote:
> Add dt-bindings headers for the Meson-AXG's AO clock and
> reset controller.
>
> CC: 
> Signed-off-by: Yixun Lan 
> ---
>  include/dt-bindings/clock/axg-aoclkc.h | 26 ++
>  include/dt-bindings/reset/axg-aoclkc.h | 20 
>  2 files changed, 46 insertions(+)
>  create mode 100644 include/dt-bindings/clock/axg-aoclkc.h
>  create mode 100644 include/dt-bindings/reset/axg-aoclkc.h
>
> diff --git a/include/dt-bindings/clock/axg-aoclkc.h 
> b/include/dt-bindings/clock/axg-aoclkc.h
> new file mode 100644
> index ..78683abb4247
> --- /dev/null
> +++ b/include/dt-bindings/clock/axg-aoclkc.h
> @@ -0,0 +1,26 @@
> +/* SPDX-License-Identifier: (GPL-2.0+ OR BSD) */

nit... BSD is not a valid license id as documented in LICENSES [1] :
please use one of these:
BSD-2-Clause or BSD-3-Clause

Thank you!

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/LICENSES/preferred
-- 
Cordially
Philippe Ombredanne

Re: [PATCH v6] checkpatch.pl: Add SPDX license tag check

[Philippe Ombredanne]

On Fri, Feb 9, 2018 at 1:35 AM, Joe Perches  wrote:
> On Fri, 2018-02-02 at 13:18 -0800, Joe Perches wrote:
>> On Fri, 2018-02-02 at 09:40 -0600, Rob Herring wrote:
>> > Add SPDX license tag check based on the rules defined in
>> > Documentation/process/license-rules.rst. To summarize, SPDX license tags
>> > should be on the 1st line (or 2nd line in scripts) using the appropriate
>> > comment style for the file type.
>> >
>> > Cc: Andy Whitcroft 
>> > Cc: Joe Perches 
>> > Cc: Thomas Gleixner 
>> > Cc: Philippe Ombredanne 
>> > Acked-by: Greg Kroah-Hartman 
>> > Signed-off-by: Rob Herring 
>>
>> Signed-off-by: Joe Perches 
>
> Andrew, would you pick this up please?
>
>> > ---
>> > v6:
>> > - Dropped script extension check and only look for #!/... on 1st line. A
>> >   text executable file was not reliable either.
>> > - Support .awk and .tc which may or may not have a #!/.
>> > - Fixed a typo in script "#!" regex and also match on first /.
>> > - Add Greg's ack.
>> >
>> >  scripts/checkpatch.pl | 27 +++
>> >  1 file changed, 27 insertions(+)
>> >
>> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
>> > index ba03f17ff662..6db245e5f93b 100755
>> > --- a/scripts/checkpatch.pl
>> > +++ b/scripts/checkpatch.pl
>> > @@ -2225,6 +2225,8 @@ sub process {
>> >
>> > my $camelcase_file_seeded = 0;
>> >
>> > +   my $checklicenseline = 1;
>> > +
>> > sanitise_line_reset();
>> > my $line;
>> > foreach my $rawline (@rawlines) {
>> > @@ -2416,6 +2418,7 @@ sub process {
>> > } else {
>> > $check = $check_orig;
>> > }
>> > +   $checklicenseline = 1;
>> > next;
>> > }
>> >
>> > @@ -2866,6 +2869,30 @@ sub process {
>> > }
>> > }
>> >
>> > +# check for using SPDX license tag at beginning of files
>> > +   if ($realline == $checklicenseline) {
>> > +   if ($rawline =~ /^[ \+]\s*\#\!\s*\//) {
>> > +   $checklicenseline = 2;
>> > +   } elsif ($rawline =~ /^\+/) {
>> > +   my $comment = "";
>> > +   if ($realfile =~ /\.(h|s|S)$/) {
>> > +   $comment = '/*';
>> > +   } elsif ($realfile =~ /\.(c|dts|dtsi)$/) {
>> > +   $comment = '//';
>> > +   } elsif (($checklicenseline == 2) || $realfile 
>> > =~ /\.(sh|pl|py|awk|tc)$/) {
>> > +   $comment = '#';
>> > +   } elsif ($realfile =~ /\.rst$/) {
>> > +   $comment = '..';
>> > +   }
>> > +
>> > +   if ($comment !~ /^$/ &&
>> > +   $rawline !~ /^\+\Q$comment\E 
>> > SPDX-License-Identifier: /) {
>> > +   WARN("SPDX_LICENSE_TAG",
>> > +"Missing or malformed 
>> > SPDX-License-Identifier tag in line $checklicenseline\n" . $herecurr);
>> > +   }
>> > +   }
>> > +   }
>> > +
>> >  # check we are in a valid source file if not then ignore this hunk
>> > next if ($realfile !~ /\.(h|c|s|S|sh|dtsi|dts)$/);
>> >

BTW I forgot this if you like to add it:

Acked-by: Philippe Ombredanne 

Re: [PATCH v6] checkpatch.pl: Add SPDX license tag check

[Philippe Ombredanne]

Joe,

On Thu, Feb 8, 2018 at 6:24 PM, Joe Perches  wrote:
> On Thu, 2018-02-08 at 15:35 +0100, Philippe Ombredanne wrote:
>> However checking that licenses ids are known and listed in the kernel
>> doc is essential IMHO to avoid drift and insulate the kernel from SPDX
>> updates. Case in point  the new SPDX "GPL-2.0-only" is NOT what was
>> documented by tglx and therefore should not be used and banned until
>> we update the doc accordingly. and until we update ALL the GPL-2.0 to
>> GPL-2.0-only eventually which is best done at once.
>
> Agree and I've attached what I believe to be a
> reasonable script for that conversion only after
> LICENSE directories are updated with the
> appropriate and license files and after
> Documentation/process/license-rules.rst is modified.

Excellent and clean!

>> Otherwise, this is
>> going to be a total mess on top of a complicated topic that requires
>> quite a bit of maintainer energy!
>
> There will always be some energy requirement and
> no doubt some legal advice involvement too.
>
> In another vein:
>
> The existing license files in spdx.org seem
> somewhat sloppily edited and perhaps have less
> clarity and precision than desired.
>
> For instance:
>
> If the newer SPDX descriptor "GPL-2.0-only" is to
> be used, why does this license URL:
>
> https://spdx.org/licenses/GPL-2.0-only.html
>
> still contain the phrase ", or (at your option) any later version".
>
> The current diff between GPL-2.0-only and GPL-2.0-or-later:
>
> $ wget -q https://spdx.org/licenses/GPL-2.0-only.html
> $ wget -q https://spdx.org/licenses/GPL-2.0-or-later.html
> $ diff -U0 GPL-2.0-only.html GPL-2.0-or-later.html
> --- GPL-2.0-only.html   2017-12-28 12:17:20.0 -0800
> +++ GPL-2.0-or-later.html   2017-12-28 12:17:22.0 -0800
> @@ -15 +15 @@
> -GNU General Public License v2.0 only | Software Package Data 
> Exchange (SPDX)
> +GNU General Public License v2.0 or later | Software Package Data 
> Exchange (SPDX)
> @@ -141 +141 @@
> -  GNU General Public License v2.0 only
> +  GNU General Public License v2.0 or later
> @@ -144 +144 @@
> -  GNU 
> General Public License v2.0 only
> +  GNU 
> General Public License v2.0 or later
> @@ -147 +147 @@
> -   property="spdx:licenseId">GPL-2.0-only
> +   property="spdx:licenseId">GPL-2.0-or-later
> @@ -160 +160 @@
> -  This license was released: June 1991 
> This refers to when this GPL 2.0 only is being used (as opposed to GPLv2 or 
> later).
> +  This license was released: June 
> 1991
> @@ -679 +679,2 @@
> -as published by the Free Software Foundation; version 2.
> +   as published by the Free Software Foundation; version 2
> +   or any later version.
>
>
> I am not a lawyer, this is not legal advice, etc... but:
>
> The "1991 This" use in the -only file seems be missing
> a period.
>
> In any case it is awkwardly phrased as "or later" perhaps
> should not be referenced at all.
>
> The GPL 2.0 license as published by the Free Software
> Foundation includes the option for using later versions.
>
> Perhaps the SPDX -only licenses should be more specific
> when it uses the phrase "as published by the Free
> Software Foundation; version ." to specifically
> exclude the option of any later version.

Good points and this is why we have and need to use the kernel doc as
the stable reference IMHO.

FWIW, I have raised a ticket with SPDX [2] so that the issue you have
found can be properly fixed there.  Also, I think this  (the new -only
license ids that I think we should not yet use) has been reviewed in
details by the SPDX legal group and by the FSF. At least rms posted an
article about it last December [2] ?

[1] https://github.com/spdx/license-list-XML/issues/610
[2] 
https://web.archive.org/web/20171221220428/https://www.gnu.org/licenses/identify-licenses-clearly.html

-- 
Cordially
Philippe Ombredanne

Re: [PATCH v2] drm/bridge/synopsys: dsi: Adopt SPDX identifiers

[Philippe Ombredanne]

On Thu, Feb 8, 2018 at 3:58 PM, Philippe Cornu  wrote:
> Add SPDX identifiers to the Synopsys DesignWare MIPI DSI
> host controller driver.
>
> Signed-off-by: Philippe Cornu 
> ---
> Changes in v2: Update to "GPL-2.0+" following comments from Laurent
> Pinchart, Benjamin Gaignard & Philippe Ombredanne.
>
>  drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 6 +-
>  1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c 
> b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
> index 7bac101c285c..99f0e4f51716 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
> @@ -1,12 +1,8 @@
> +// SPDX-License-Identifier: GPL-2.0+
>  /*
>   * Copyright (c) 2016, Fuzhou Rockchip Electronics Co., Ltd
>   * Copyright (C) STMicroelectronics SA 2017
>   *
> - * This program is free software; you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License as published by
> - * the Free Software Foundation; either version 2 of the License, or
> - * (at your option) any later version.
> - *
>   * Modified by Philippe Cornu 
>   * This generic Synopsys DesignWare MIPI DSI host driver is based on the
>   * Rockchip version from rockchip/dw-mipi-dsi.c with phy & bridge APIs.
> --
> 2.15.1
>

Thank you.

Acked-by: Philippe Ombredanne 

Re: [PATCH v2 05/16] arm64: dts: mt7622: add PMIC MT6380 related nodes

[Philippe Ombredanne]

Sean,

On Tue, Feb 6, 2018 at 10:52 AM,   wrote:
> From: Sean Wang 
>
> Enable pwrap and MT6380 on mt7622-rfb1 board. Also add all mt6380
> regulator nodes in an alone file to allow similar boards using MT6380
> able to resue the configuration.
>
> Signed-off-by: Sean Wang 
> Cc: Mark Brown 
> Cc: Matthias Brugger 
> Cc: Philippe Ombredanne 

Thank you for the use of SPDX licenses ids!

Acked-by: Philippe Ombredanne 

Re: [PATCH v6] checkpatch.pl: Add SPDX license tag check

[Philippe Ombredanne]

On Sat, Feb 3, 2018 at 2:41 PM, Igor Stoppa  wrote:
>
>
> On 02/02/18 21:06, Joe Perches wrote:
>> On Fri, 2018-02-02 at 12:27 -0600, Rob Herring wrote:
>>> On Fri, Feb 2, 2018 at 9:49 AM, Igor Stoppa  wrote:
>>>> On 02/02/18 17:40, Rob Herring wrote:
>>>>> Add SPDX license tag check based on the rules defined in
>>>>
>>>> Shouldn't it also check that the license is compatible?
>>>>
>>>
>>> Perhaps we shouldn't try to script legal advice.
>>
>> True.
>>
>> I believe what was meant was that the
>> entry was a valid SPDX License entry
>> that already exists as a specific file
>> in the LICENSES/ path.
>
> I expect that there is a finite number of compatible licenses.
> Maybe I'm too optimistic about what can be taken as legal advice or not,
> but I would expect that a warning about unmatched license type does not
> constitute legal advice.
>
> Is it too optimistic? :-D

That's very reasonable IMHO and this not legal advice alright to me.
This would be just a tool that warns you that your license expression
does not match known licenses in the kernel.

-- 
Cordially
Philippe Ombredanne

Re: [PATCH v6] checkpatch.pl: Add SPDX license tag check

[Philippe Ombredanne]

Kate,

On Fri, Feb 2, 2018 at 9:18 PM, Kate Stewart
 wrote:
> This is the new way to represent GPLv2 only, as described above.
> While the GPL-2.0 and GPL-2.0+ notation is still valid,  it is deprecated
> in the latest version, so transitioning existing over time will probably
> be needed.   So I think the list of licenses to be added to
> LICENSES/ path is:
>
> APACHE-2.0
> BSD
> CDDL
> CDDL-1.0
> ISC
> GPL-1.0-only
> GPL-1.0-or-later (note: actually same contents as one GPL-1.0-only)
> GPL-2.0-only
> GPL-2.0-or-later (same contents as GPL-2.0-only)
> LGPL-2.0-only
> LGPL-2.0-or-later (same contents as LGPL-2.0-only)
> LGPL-2.1-only
> LGPL-2.1-or-later (same contents as LGPL-2.1-only)
> OpenSSL

Yes, this is the new SPDX was (-only) but this is not yet the kernel
way and doc.

IMHO as long as the new SPDX "GPL-2.0-only" are not what is in the
kernel doc they should not be used and banned. Otherwise, we are
looking at creating an infinite source of confusion
therefore we should not add the -only license for now until they
become the kernel ways.
Joe already spotted drifts and I tried to fight these as much as I
could. One id for one license at a time is the only sane way to go.
-- 
Cordially
Philippe Ombredanne

Re: [PATCH v6] checkpatch.pl: Add SPDX license tag check

[Philippe Ombredanne]

 even
On Fri, Feb 2, 2018 at 8:06 PM, Joe Perches  wrote:
> On Fri, 2018-02-02 at 12:27 -0600, Rob Herring wrote:
>> On Fri, Feb 2, 2018 at 9:49 AM, Igor Stoppa  wrote:
>> > On 02/02/18 17:40, Rob Herring wrote:
>> > > Add SPDX license tag check based on the rules defined in
>> >
>> > Shouldn't it also check that the license is compatible?
>> >
>>
>> Perhaps we shouldn't try to script legal advice.
>
> True.
>
> I believe what was meant was that the
> entry was a valid SPDX License entry
> that already exists as a specific file
> in the LICENSES/ path.
>
> So that entry must be some combination of:
>
> $ git ls-files LICENSES/ | cut -f3- -d'/' | sort
> BSD-2-Clause
> BSD-3-Clause
> BSD-3-Clause-Clear
> GPL-1.0
> GPL-2.0
> LGPL-2.0
> LGPL-2.1
> Linux-syscall-note
> MIT
> MPL-1.1
>
> From my perspective, it'd be better if the
> various + uses had their own individual
> license files in the LICENSES/ path.
>
> Right now, there are many missing licenses
> that are already used by various existing
> SPDX-License-Identifier: entries.
>
>
> APACHE-2.0
> BSD
> CDDL
> CDDL-1.0
> ISC
> GPL-1.0+
> GPL-2.0+
> LGPL-2.1+
> OpenSSL
>
> There are odd entries like:
>
> GPL-2.0-only
>
> Parentheses around AND/OR aren't consistent.

Joe,
I have a comprehensive license expressions checker/parser [1] in
Python ;) if it is ever needed, but that's likely overkill for the
kernel. (this is not in Perl for one thing and second it is based on a
boolean expression parser and minimizer, hence overkill for the
limited kernel use case IMHO)

However checking that licenses ids are known and listed in the kernel
doc is essential IMHO to avoid drift and insulate the kernel from SPDX
updates. Case in point  the new SPDX "GPL-2.0-only" is NOT what was
documented by tglx and therefore should not be used and banned until
we update the doc accordingly. and until we update ALL the GPL-2.0 to
GPL-2.0-only eventually which is best done at once. Otherwise, this is
going to be a total mess on top of a complicated topic that requires
quite a bit of maintainer energy!


[1] https://github.com/nexB/license-expression/
-- 
Cordially
Philippe Ombredanne

Re: [PATCH] checkpatch.pl: Add SPDX license tag check

[Philippe Ombredanne]

On Thu, Feb 1, 2018 at 10:14 PM, Rob Herring  wrote:
> Add SPDX license tag check based on the rules defined in
> Documentation/process/license-rules.rst. To summarize, SPDX license tags
> should be on the 1st line (or 2nd line in scripts) using the appropriate
> comment style for the file type.
>
> Cc: Andy Whitcroft 
> Cc: Joe Perches 
> Cc: Greg Kroah-Hartman 
> Cc: Thomas Gleixner 
> Cc: Philippe Ombredanne 
> Cc: Andrew Morton 
> Signed-off-by: Rob Herring 

Acked-by:  Philippe Ombredanne 

(Sorry for the late reply but I was busy with FOSDEM)

Re: [PATCH] PCI: Add SPDX GPL-2.0+ to replace implicit GPL v2 or later statement

[Philippe Ombredanne]

On Tue, Jan 30, 2018 at 1:40 AM, Bjorn Helgaas  wrote:
> From: Bjorn Helgaas 
>
> 7441b0627e22 ("s390/pci: PCI hotplug support via SCLP") added
> s390_pci_hpc.c, which included this license information:
>
>   +MODULE_LICENSE("GPL");
>
> Based on "git show 7441b0627e22:include/linux/module.h", that "GPL" string
> means "GPL v2 or later":
>
>*  "GPL"   [GNU Public License v2 or later]
>
> 0729dcf24832 ("s390: hotplug: make pci_hpc explicitly non-modular")
> subsequently replaced the MODULE_LICENSE() with a "License: GPL" comment.
>
> Add SPDX GPL-2.0+ and remove the "License: GPL" comment, relying on the
> assertion in b24413180f56 ("License cleanup: add SPDX GPL-2.0 license
> identifier to files with no license") that the SPDX identifier may be used
> instead of the full boilerplate text.
>
> Signed-off-by: Bjorn Helgaas 
> ---
>  drivers/pci/hotplug/s390_pci_hpc.c |3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/pci/hotplug/s390_pci_hpc.c 
> b/drivers/pci/hotplug/s390_pci_hpc.c
> index 530d0e49f2ed..ffdc2977395d 100644
> --- a/drivers/pci/hotplug/s390_pci_hpc.c
> +++ b/drivers/pci/hotplug/s390_pci_hpc.c
> @@ -1,3 +1,4 @@
> +// SPDX-License-Identifier: GPL-2.0+
>  /*
>   * PCI Hot Plug Controller Driver for System z
>   *
> @@ -5,8 +6,6 @@
>   *
>   * Author(s):
>   *   Jan Glauber 
> - *
> - * License: GPL
>   */
>
>  #define KMSG_COMPONENT "zpci"

Thanks!
I have CCed too: Jan Glauber  too just in case!


Reviewed-by: Philippe Ombredanne 

Re: [PATCH] PCI: Add SPDX tag for s390_pci_hpc.c

[Philippe Ombredanne]

Bjorn,

On Tue, Jan 30, 2018 at 1:40 AM, Bjorn Helgaas  wrote:
> I previously posted patches [1] to add SPDX tags to all drivers/pci files
> except drivers/pci/hotplug/s390_pci_hpc.c.  I omitted that one because it
> contained only a "License: GPL" comment, which I thought was ambiguous.
>
> However, I think it is actually unambiguous because the file was added with
> a 'MODULE_LICENSE("GPL")', and include/linux/module.h shows that means "GPL
> v2 or later".
>
> So this patch adds the GPL-2.0+ tag to the file.  I plan to include this
> for v4.16 unless somebody objects.

As I as said in a previous email, context matters a lot in these case
and you made the right choice.
When there is a MODULE_LICENSE and a super terse "GPL" license notice,
the two taken together can provide the proper context e.g. here
GPL-2.0+ rather than a less common GPL-1.0+

Thank you for your efforts there!

-- 
Cordially
Philippe Ombredanne

Re: [PATCH 0/4] PCI: Add SPDX tags

[Philippe Ombredanne]

Bjorn,

On Fri, Jan 26, 2018 at 10:32 PM, Bjorn Helgaas  wrote:
> b24413180f56 ("License cleanup: add SPDX GPL-2.0 license identifier to
> files with no license") added SPDX GPL-2.0 tags to several PCI files.
>
> These patches add SPDX tags to almost all remaining PCI files.  For ease of
> reviewing they're split into several cases (GPL v2, GPL v2+, etc.)

Better late than never: thank you ++ for this: my hero!

> One file (drivers/pci/hotplug/s390_pci_hpc.c) specifies only "GPL"; I don't
> know what to do with that, so I left it unchanged.

This is the way to go when there are ambiguities alright. One
interpretation of a bare GPL is GPL-1.0+ but the context matters a
lot!

-- 
Cordially
Philippe Ombredanne

Re: [PATCH] drm/bridge/synopsys: dsi: Adopt SPDX identifiers

[Philippe Ombredanne]

Benjamin,

On Wed, Jan 24, 2018 at 9:57 AM, Benjamin Gaignard
 wrote:
> 2018-01-24 0:32 GMT+01:00 Laurent Pinchart 
> :
>> Hi Philippe,
>>
>> On Tuesday, 23 January 2018 12:25:51 EET Philippe CORNU wrote:
>>> On 01/23/2018 12:30 AM, Laurent Pinchart wrote:
>>> > On Monday, 22 January 2018 12:26:08 EET Philippe Cornu wrote:
>>> >> Add SPDX identifiers to the Synopsys DesignWare MIPI DSI
>>> >> host controller driver.
>>> >>
>>> >> Signed-off-by: Philippe Cornu 
>>> >> ---
>>> >>
>>> >>   drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 6 +-
>>> >>   1 file changed, 1 insertion(+), 5 deletions(-)
>>> >>
>>> >> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
>>> >> b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c index
>>> >> 46b0e73404d1..e06836dec77c 100644
>>> >> --- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
>>> >> +++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
>>> >> @@ -1,12 +1,8 @@
>>> >> +// SPDX-License-Identifier: GPL-2.0
>>> >
>>> > According to Documentation/process/license-rules.txt this would change
>>> > the existing license. The correct identifier is GPL-2.0+.
>>>
>>> You are right, I did not put the correct identifier :(
>>>
>>> After reading more spdx.org, I wonder if the correct value should be
>>> GPL-2.0-or-later instead of GPL-2.0+
>>>
>>> https://spdx.org/licenses/GPL-2.0-or-later.html
>>> https://spdx.org/licenses/GPL-2.0+.html
>>>
>>> What is your opinion?
>>
>> I agree in principle, and I've even asked for that before, but I've been told
>> that we should stick to the license identifiers defined in Documentation/
>> process/license-rules.txt. The file might get updated to use GPL-2.0-or-later
>> and GPL-2.0-only later, and kernel sources will likely then get patched in 
>> one
>> go.
>
> + Philippe O. to check what I'm writing just below.
>
> In -next branch I only see reference to GPL-2.0+ identifier so for me
> it fine to use it here.
> Is that right ? or should we use GPL-2.0-or-later keyword ?


Sorry for the late reply!
IMHO it is essential to stick to what is in the kernel doc, meaning
that you should not use the GPL-2.0-or-later identifier until it is
part of the kernel doc. Otherwise this is going to be a mess ;)
Consistency matters a lot.
-- 
Cordially
Philippe Ombredanne

Re: [PATCH 2/8] thermal/drivers/cpu_cooling: Add Software Package Data Exchange (SPDX)

[Philippe Ombredanne]

Daniel,

On Tue, Jan 23, 2018 at 4:34 PM, Daniel Lezcano
 wrote:
> For license auditing purpose, let's add the SPDX tag.
>
> Cc: Philippe Ombredanne 
> Signed-off-by: Daniel Lezcano 
> ---
>  drivers/thermal/cpu_cooling.c | 16 +---
>  1 file changed, 1 insertion(+), 15 deletions(-)
>
> diff --git a/drivers/thermal/cpu_cooling.c b/drivers/thermal/cpu_cooling.c
> index 988fc55..e62be75 100644
> --- a/drivers/thermal/cpu_cooling.c
> +++ b/drivers/thermal/cpu_cooling.c
> @@ -1,3 +1,4 @@
> +// SPDX-License-Identifier: GPL-2.0
>  /*
>   *  linux/drivers/thermal/cpu_cooling.c
>   *
> @@ -8,21 +9,6 @@
>   *  Authors:   Amit Daniel 
>   * Viresh Kumar 
>   *
> - * ~~
> - *  This program is free software; you can redistribute it and/or modify
> - *  it under the terms of the GNU General Public License as published by
> - *  the Free Software Foundation; version 2 of the License.
> - *
> - *  This program is distributed in the hope that it will be useful, but
> - *  WITHOUT ANY WARRANTY; without even the implied warranty of
> - *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> - *  General Public License for more details.
> - *
> - *  You should have received a copy of the GNU General Public License along
> - *  with this program; if not, write to the Free Software Foundation, Inc.,
> - *  59 Temple Place, Suite 330, Boston, MA 02111-1307 USA.
> - *
> - * ~~~~~~
>   */
>  #include 
>  #include 


Sorry for the late reply!
Thank you.
Acked-by: Philippe Ombredanne 

--
Philippe

Re: [PATCH 05/12] arm64: dts: mt7622: add PMIC MT6380 related nodes

[Philippe Ombredanne]

Sean,
sorry for the late reply and thanks you for this research.

On Fri, Jan 12, 2018 at 4:33 AM, Sean Wang  wrote:
> Currently, I'm really confused about what usage STYLE of SPDX license
> identifier I should use for each type of file.
>
> could you point me where I can find the related document describing SPDX
> usage style for those files expected by the community in the future?

The doc is in this patchset [1]

[1] https://lkml.org/lkml/2017/12/28/326


> I found more than one way STYLE of SPDX present at current code, for
> example as below. If there's no absolute definition for them, and then
> which way that is better?
> 1)
> for *.dts, applied with "// " at head or within " /* */ " not at head
> such as
>
> arch/arm/boot/dts/bcm953012hr.dts:2: *  SPDX-License-Identifier:
> BSD-3-Clause

This is a "style bug". The comment style for .dts should be //

> 2)
> for *.c, applied with "// " at head or within " /* */ " not at head
> such as
> drivers/soc/xilinx/zynqmp/pm.c:10: * SPDX-License-Identifier:   GPL-2.0+

This is a "style bug". The comment style for .c should be //

> 3)
> for *.h, applied with "// " at head or within " /* */ " at head
> such as
> drivers/usb/dwc3/gadget.h:1:// SPDX-License-Identifier: GPL-2.0

This is a "style bug". The comment style for .h should be /**/

> 4)
> no issue, Makefile, or Kconfig, definitely applied with "# " at head

That's the correct way.

So the net-net is that these "style bugs" should be fixed.

-- 
Cordially
Philippe Ombredanne

Re: [PATCH v6 15/15] MIPS: ingenic: Initial GCW Zero support

[Philippe Ombredanne]

Paul:

On Wed, Jan 10, 2018 at 11:59 PM, Paul Cercueil  wrote:
> Hi Philippe,
>
> Le dim. 7 janv. 2018 à 17:18, Philippe Ombredanne  a
> écrit :
>>
>> On Fri, Jan 5, 2018 at 7:25 PM, Paul Cercueil 
>> wrote:
>>>
>>>  The GCW Zero (http://www.gcw-zero.com) is a retro-gaming focused
>>>  handheld game console, successfully kickstarted in ~2012, running Linux.
>>>
>>>  Signed-off-by: Paul Cercueil 
>>>  Acked-by: Mathieu Malaterre 
>>>  ---
>>>   arch/mips/boot/dts/ingenic/Makefile |  1 +
>>>   arch/mips/boot/dts/ingenic/gcw0.dts | 62
>>> +
>>>   arch/mips/configs/gcw0_defconfig| 27 
>>>   arch/mips/jz4740/Kconfig|  4 +++
>>>   4 files changed, 94 insertions(+)
>>>   create mode 100644 arch/mips/boot/dts/ingenic/gcw0.dts
>>>   create mode 100644 arch/mips/configs/gcw0_defconfig
>>>
>>>   v2: No change
>>>   v3: No change
>>>   v4: No change
>>>   v5: Use SPDX license identifier
>>>   Drop custom CROSS_COMPILE from defconfig
>>>   v6: Add "model" property in devicetree
>>
>>
>> For the use of SPDX tags for the whole patch set: thank you!
>>
>> Acked-by: Philippe Ombredanne 
>
>
> Is your Acked-by for the whole patchset? Or just this one patch?

Sorry for the late reply!
This is  for the whole patchset for your use of SPDX tags.

-- 
Cordially
Philippe Ombredanne

Re: [PATCH v4 3/9] v4l: platform: Add Renesas CEU driver

[Philippe Ombredanne]

On Fri, Jan 12, 2018 at 2:38 PM, jacopo mondi  wrote:
> Hi Philippe, Laurent, Geert,
>
> On Fri, Jan 12, 2018 at 11:36:31AM +0100, Philippe Ombredanne wrote:
>> On Tue, Jan 9, 2018 at 5:25 PM, Jacopo Mondi  
>> wrote:
>> > Add driver for Renesas Capture Engine Unit (CEU).
>>
>> 
>>
>> > --- /dev/null
>> > +++ b/drivers/media/platform/renesas-ceu.c
>> > @@ -0,0 +1,1648 @@
>> > +// SPDX-License-Identifier: GPL-2.0
>>
>> 
>>
>> > +MODULE_DESCRIPTION("Renesas CEU camera driver");
>> > +MODULE_AUTHOR("Jacopo Mondi ");
>> > +MODULE_LICENSE("GPL");
>>
>> Jacopo,
>> the MODULE_LICENSE does not match the SPDX tag. Per module.h "GPL"
>> means GPL-2.0 or later ;)
>>
>> It should be instead:
>>
>> > +MODULE_LICENSE("GPL v2");
>>
>> ... to match your
>>
>> > +// SPDX-License-Identifier: GPL-2.0
>
> I will update this in next v5.
> Laurent, Geert: I'll keep SPDX identifier to "GPL-2.0" until kernel
> doc does not get updated.

Thanks. Sorry for the late reply!

-- 
Cordially
Philippe Ombredanne

Re: [PATCH v4 3/9] v4l: platform: Add Renesas CEU driver

[Philippe Ombredanne]

On Tue, Jan 9, 2018 at 5:25 PM, Jacopo Mondi  wrote:
> Add driver for Renesas Capture Engine Unit (CEU).



> --- /dev/null
> +++ b/drivers/media/platform/renesas-ceu.c
> @@ -0,0 +1,1648 @@
> +// SPDX-License-Identifier: GPL-2.0



> +MODULE_DESCRIPTION("Renesas CEU camera driver");
> +MODULE_AUTHOR("Jacopo Mondi ");
> +MODULE_LICENSE("GPL");

Jacopo,
the MODULE_LICENSE does not match the SPDX tag. Per module.h "GPL"
means GPL-2.0 or later ;)

It should be instead:

> +MODULE_LICENSE("GPL v2");

... to match your

> +// SPDX-License-Identifier: GPL-2.0

I know this can be confusing, but updating the MODULE_LICENSE tags
definitions in module.h to match SPDX tags is unlikely to happen as it
would create mayhem for everyone and every module loader relying on
this established convention.

-- 
Cordially
Philippe Ombredanne

Re: [PATCH v3 07/13] arm64: Add skeleton to harden the branch predictor against aliasing attacks

[Philippe Ombredanne]

Dear Will,

On Mon, Jan 8, 2018 at 6:32 PM, Will Deacon  wrote:
> Aliasing attacks against CPU branch predictors can allow an attacker to
> redirect speculative control flow on some CPUs and potentially divulge
> information from one context to another.
>
> This patch adds initial skeleton code behind a new Kconfig option to
> enable implementation-specific mitigations against these attacks for
> CPUs that are affected.
>
> Signed-off-by: Marc Zyngier 
> Signed-off-by: Will Deacon 




> --- /dev/null
> +++ b/arch/arm64/kernel/bpi.S
> @@ -0,0 +1,55 @@
> +/*
> + * Contains CPU specific branch predictor invalidation sequences
> + *
> + * Copyright (C) 2018 ARM Ltd.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program.  If not, see <http://www.gnu.org/licenses/>.
> + */

Could you consider using the new SDPX tags [1] instead of this long legalese?
Thanks!

[1] https://lkml.org/lkml/2017/12/28/323
-- 
Cordially
Philippe Ombredanne

Re: [RFC PATCH 2/2] drivers: clk: Add ZynqMP clock driver

[Philippe Ombredanne]

Jolly,

On Mon, Jan 8, 2018 at 11:16 PM, Jolly Shah  wrote:
> This patch adds CCF compliant clock driver for ZynqMP.
> Clock driver queries supported clock information from
> firmware and regiters pll and output clocks with CCF.
>
> Signed-off-by: Jolly Shah 
> Signed-off-by: Rajan Vaja 
> Signed-off-by: Tejas Patel 
> Signed-off-by: Shubhrajyoti Datta 
> ---




>  .../devicetree/bindings/clock/zynq_mpsoc.txt   | 163 +
>  drivers/clk/Kconfig|   1 +
>  drivers/clk/Makefile   |   1 +
>  drivers/clk/zynqmp/Kconfig |   8 +
>  drivers/clk/zynqmp/Makefile|   3 +
>  drivers/clk/zynqmp/clk-gate-zynqmp.c   | 158 +
>  drivers/clk/zynqmp/clk-mux-zynqmp.c| 190 ++
>  drivers/clk/zynqmp/clkc.c  | 707 
> +
>  drivers/clk/zynqmp/divider.c   | 239 +++
>  drivers/clk/zynqmp/pll.c   | 384 +++
>  include/linux/clk/zynqmp.h |  46 ++
>  11 files changed, 1900 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/clock/zynq_mpsoc.txt
>  create mode 100644 drivers/clk/zynqmp/Kconfig
>  create mode 100644 drivers/clk/zynqmp/Makefile
>  create mode 100644 drivers/clk/zynqmp/clk-gate-zynqmp.c
>  create mode 100644 drivers/clk/zynqmp/clk-mux-zynqmp.c
>  create mode 100644 drivers/clk/zynqmp/clkc.c
>  create mode 100644 drivers/clk/zynqmp/divider.c
>  create mode 100644 drivers/clk/zynqmp/pll.c
>  create mode 100644 include/linux/clk/zynqmp.h
>
> diff --git a/Documentation/devicetree/bindings/clock/zynq_mpsoc.txt 
> b/Documentation/devicetree/bindings/clock/zynq_mpsoc.txt
> new file mode 100644
> index 000..9061b57
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/zynq_mpsoc.txt
> @@ -0,0 +1,163 @@
> +Device Tree Clock bindings for the Zynq Ultrascale+ MPSoC
> +
> +The Zynq Ultrascale+ MPSoC has several different clk providers,
> +each with there own bindings.
> +The purpose of this document is to document their usage.
> +
> +See clock_bindings.txt for more information on the generic clock bindings.
> +
> +== Clock Controller ==
> +The clock controller is a logical abstraction of Zynq Ultrascale+ MPSoC clock
> +tree. It reads required input clock frequencies from the devicetree and acts
> +as clock provider for all clock consumers of PS clocks.
> +
> +Required properties:
> + - #clock-cells : Must be 1
> + - compatible : "xlnx,zynqmp-clkc"
> + - clocks : list of clock specifiers which are external input clocks to the
> +   given clock controller. Please refer the next section to find
> +   the input clocks for a given controller.
> + - clock-names : list of names of clocks which are exteral input clocks to 
> the
> +given clock controller. Please refer to the clock bindings
> +for more details
> +
> +Input clocks for zynqmp Ultrascale+ clock controller:
> +The Zynq UltraScale+ MPSoC has one primary and four alternative reference 
> clock
> +inputs.
> +These required clock inputs are the
> + - pss_ref_clk (PS reference clock)
> + - video_clk (reference clock for video system )
> + - pss_alt_ref_clk (alternative PS reference clock)
> + - aux_ref_clk
> + - gt_crx_ref_clk (transceiver reference clock)
> +
> +The following strings are optional parameters to the 'clock-names' property 
> in
> +order to provide an optional (E)MIO clock source.
> + - swdt0_ext_clk
> + - swdt1_ext_clk
> + - gem0_emio_clk
> + - gem1_emio_clk
> + - gem2_emio_clk
> + - gem3_emio_clk
> + - mio_clk_XX  # with XX = 00..77
> + - mio_clk_50_or_51#for the mux clock to gem tsu from 50 or 51
> +
> +
> +Output clocks for zynqmp Ultrascale+ clock controller:
> +Output clocks are registered based on clock information received from 
> firmware.
> +Output clock indexes are mentioned below:
> +
> +Clock ID:  Output clock name:
> +-
> +0  iopll
> +1  rpll
> +2  apll
> +3  dpll
> +4  vpll
> +5  iopll_to_fpd
> +6  rpll_to_fpd
> +7  apll_to_lpd
> +8  dpll_to_lpd
> +9  vpll_to_lpd
> +10 acpu
> +11 acpu_half
> +12 dbf_fpd
> +13 dbf_lpd
> +14 dbg_trace
> +15 dbg_tstmp
> +16 dp_video_ref
> +17 dp_audio_ref
> +18 dp_stc_ref
> +19 gdma_ref
> +20 dpdma_ref
> +21 ddr_ref
> +22 sata_ref
> +23 pcie_ref
> +24 gpu_ref
> +25 gpu_pp0_ref
> +26 gpu_pp1_ref
> +27 topsw_main
> +28 topsw_lsbus
> +29 gtgref0_ref
> +30 lpd_switch
> +31 lpd_lsbus
> +32 usb0_bus_ref
> +33 usb1_bus_ref
> +34 

Re: [RFC PATCH] drivers: soc: xilinx: Add ZynqMP power domain driver

[Philippe Ombredanne]

Jolly,

On Mon, Jan 8, 2018 at 11:12 PM, Jolly Shah  wrote:
> The zynqmp-genpd driver communicates the usage requirements
> for logical power domains / devices to the platform FW.
> FW is responsible for choosing appropriate power states,
> taking Linux' usage information into account.
>
> Signed-off-by: Jolly Shah 
> Signed-off-by: Rajan Vaja 
> ---



> --- /dev/null
> +++ b/drivers/soc/xilinx/zynqmp/pm_domains.c
> @@ -0,0 +1,343 @@
> +/*
> + * ZynqMP Generic PM domain support
> + *
> + *  Copyright (C) 2014-2017 Xilinx, Inc.
> + *
> + *  Davorin Mista 
> + *  Jolly Shah 
> + *  Rajan Vaja 
> + *
> + * SPDX-License-Identifier: GPL-2.0+
> + */

This tag should be on the fist line as this:

// SPDX-License-Identifier: GPL-2.0+

-- 
Cordially
Philippe Ombredanne

Re: [PATCH] drivers: firmware: xilinx: Add ZynqMP firmware driver

[Philippe Ombredanne]

Jolly,

On Mon, Jan 8, 2018 at 11:07 PM, Jolly Shah  wrote:
> This patch is adding communication layer with firmware.
> Firmware driver provides an interface to firmware APIs.
> Interface APIs can be used by any driver to communicate to
> PMUFW(Platform Management Unit). All requests go through ATF.
> Firmware-debug provides debugfs interface to all APIs.
> Firmware-ggs provides read/write interface to
> global storage registers.
>
> Signed-off-by: Jolly Shah 
> Signed-off-by: Rajan Vaja 



> --- /dev/null
> +++ b/drivers/firmware/xilinx/Kconfig
> @@ -0,0 +1,4 @@
> +# SPDX-License-Identifier: GPL-2.0+

Thank you++ for using the SPDX tags: here is my cheerful ack for this:

Acked-by: Philippe Ombredanne 

Re: [PATCH v6 4/9] drm: Add some HDCP related #defines

[Philippe Ombredanne]

Sean,

On Mon, Jan 8, 2018 at 8:55 PM, Sean Paul  wrote:
> In preparation for implementing HDCP in i915, add some HDCP related
> register offsets and defines. The dpcd register offsets will go in
> drm_dp_helper.h whereas the ddc offsets along with generic HDCP stuff
> will get stuffed in drm_hdcp.h, which is new.
>
> Changes in v2:
> - drm_hdcp.h gets MIT license (Daniel)
> Changes in v3:
> - None
> Changes in v4:
> - None
> Changes in v5:
> - None
> Changes in v6:
> - SPDX license
>
> Cc: Daniel Vetter 
> Reviewed-by: Ramalingam C 
> Signed-off-by: Sean Paul 



> --- /dev/null
> +++ b/include/drm/drm_hdcp.h
> @@ -0,0 +1,39 @@
> +/* SPDX-License-Identifier: MIT */
> +/*
> + * Copyright (C) 2017 Google, Inc.
> + *
> + * Authors:
> + * Sean Paul 
> + */

Thank you++ for using the SPDX tags!
Acked-by: Philippe Ombredanne 

-- 
Cordially
Philippe Ombredanne

Re: [PATCH v4] selftest/vm: Move the 128 TB mmap boundary test to the generic VM directory

[Philippe Ombredanne]

Anesh,

On Mon, Jan 8, 2018 at 5:14 PM, Ingo Molnar  wrote:
>
> * Aneesh Kumar K.V  wrote:
>
>> Architectures like ppc64 do support mmap hint addr based large address space
>> selection. This test can be run on those architectures too. Move the test to
>> selftest/vm so that other archs can use the same.
>>
>> We also add a few new test scenarios in this patch. We do test few boundary
>> condition before we do a high address mmap. ppc64 use the addr limit to 
>> validate
>> addr in the fault path. We had bugs in this area w.r.t slb fault handling
>> before we updated the addr limit.
>>
>> We also touch the allocated space to make sure we don't have any bugs in the
>> fault handling path.
>>
>> Signed-off-by: Aneesh Kumar K.V 



> --- /dev/null
> +++ b/tools/testing/selftests/vm/va_128TBswitch.c
> @@ -0,0 +1,297 @@
> +/*
> + *
> + * Authors: Kirill A. Shutemov 
> + * Authors: Aneesh Kumar K.V 
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License, version 2, as
> + * published by the Free Software Foundation.
> +
> + * This program is distributed in the hope that it would be useful, but
> + * WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
> + *
> + */

Would you mind using an SPDX tag instead of this fine legalese?
See Thomas doc [1] for details.
Thanks!

[1] https://lkml.org/lkml/2017/12/28/323
-- 
Cordially
Philippe Ombredanne

Re: [PATCH v5 5/9] drm/i915: Add HDCP framework + base implementation

[Philippe Ombredanne]

Sean,

On Mon, Jan 8, 2018 at 4:50 PM, Sean Paul  wrote:
> This patch adds the framework required to add HDCP support to intel
> connectors. It implements Aksv loading from fuse, and parts 1/2/3
> of the HDCP authentication scheme.
>
> Note that without shim implementations, this does not actually implement
> HDCP. That will come in subsequent patches.



> --- /dev/null
> +++ b/drivers/gpu/drm/i915/intel_hdcp.c
> @@ -0,0 +1,740 @@
> +/*
> + * Copyright (C) 2017 Google, Inc.
> + *
> + * Permission is hereby granted, free of charge, to any person obtaining a
> + * copy of this software and associated documentation files (the "Software"),
> + * to deal in the Software without restriction, including without limitation
> + * the rights to use, copy, modify, merge, publish, distribute, sublicense,
> + * and/or sell copies of the Software, and to permit persons to whom the
> + * Software is furnished to do so, subject to the following conditions:
> + *
> + * The above copyright notice and this permission notice shall be included in
> + * all copies or substantial portions of the Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
> + * THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM, DAMAGES OR
> + * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
> + * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> + * OTHER DEALINGS IN THE SOFTWARE.

Would you mind using an SPDX tag instead of this fine but long legalese?
See Thomas doc [1] for details.
Thanks!

[1] https://lkml.org/lkml/2017/12/28/323
-- 
Cordially
Philippe Ombredanne

Re: [PATCH v3 1/3] PCI/AER: factor out error reporting from AER

[Philippe Ombredanne]

Oza,

On Mon, Jan 8, 2018 at 8:55 AM, Oza Pawandeep  wrote:
> This patch factors out error reporting callbacks, which are currently
> tightly coupled with AER.
> DPC should be able to call these callbacks when DPC trigger event occurs.
>
> Signed-off-by: Oza Pawandeep 



> --- /dev/null
> +++ b/drivers/pci/pcie/pcie-err.c
> @@ -0,0 +1,335 @@
> +/*
> + * Copyright (c) 2017, The Linux Foundation. All rights reserved.
> +
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 and
> + * only version 2 as published by the Free Software Foundation.
> +
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */

Do you mind using an SPDX tag there instead of this fine legalese?

-- 
Cordially
Philippe Ombredanne

Re: [PATCH 6/7] arm64: allwinner: h6: add the basical Allwinner H6 DTSI file

[Philippe Ombredanne]

On Sat, Jan 6, 2018 at 6:09 AM, Icenowy Zheng  wrote:
> Allwinner H6 is a new SoC with Cortex-A53 cores from Allwinner, with its
> memory map fully reworked and some high-speed peripherals (PCIe, USB
> 3.0) introduced.
>
> This commit adds the basical DTSI file of it, including the clock
> support and UART support.
>
> Signed-off-by: Icenowy Zheng 
> ---
>  arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 214 
> +++
>  1 file changed, 214 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi 
> b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
> new file mode 100644
> index ..482f5cb64d07
> --- /dev/null
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
> @@ -0,0 +1,214 @@
> +/*
> + * Copyright (C) 2017 Icenowy Zheng 
> + *
> + * This file is dual-licensed: you can use it either under the terms
> + * of the GPL or the X11 license, at your option. Note that this dual
> + * licensing only applies to this file, and not this project as a
> + * whole.
> + *
> + *  a) This file is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of the
> + * License, or (at your option) any later version.
> + *
> + * This file is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * Or, alternatively,
> + *
> + *  b) Permission is hereby granted, free of charge, to any person
> + * obtaining a copy of this software and associated documentation
> + * files (the "Software"), to deal in the Software without
> + * restriction, including without limitation the rights to use,
> + * copy, modify, merge, publish, distribute, sublicense, and/or
> + * sell copies of the Software, and to permit persons to whom the
> + * Software is furnished to do so, subject to the following
> + * conditions:
> + *
> + * The above copyright notice and this permission notice shall be
> + * included in all copies or substantial portions of the Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
> + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
> + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
> + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
> + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> + * OTHER DEALINGS IN THE SOFTWARE.
> + */

Icenowy,
This is a very long legalese indeed!
Do you mind using the new concise SPDX tags instead here and in the
rest of your patch?
See Thomas doc [1]
Thanks!

[1] https://lkml.org/lkml/2017/12/28/323
-- 
Cordially
Philippe Ombredanne

Re: [PATCH v6 15/15] MIPS: ingenic: Initial GCW Zero support

[Philippe Ombredanne]

On Fri, Jan 5, 2018 at 7:25 PM, Paul Cercueil  wrote:
> The GCW Zero (http://www.gcw-zero.com) is a retro-gaming focused
> handheld game console, successfully kickstarted in ~2012, running Linux.
>
> Signed-off-by: Paul Cercueil 
> Acked-by: Mathieu Malaterre 
> ---
>  arch/mips/boot/dts/ingenic/Makefile |  1 +
>  arch/mips/boot/dts/ingenic/gcw0.dts | 62 
> +
>  arch/mips/configs/gcw0_defconfig| 27 
>  arch/mips/jz4740/Kconfig|  4 +++
>  4 files changed, 94 insertions(+)
>  create mode 100644 arch/mips/boot/dts/ingenic/gcw0.dts
>  create mode 100644 arch/mips/configs/gcw0_defconfig
>
>  v2: No change
>  v3: No change
>  v4: No change
>  v5: Use SPDX license identifier
>  Drop custom CROSS_COMPILE from defconfig
>  v6: Add "model" property in devicetree

For the use of SPDX tags for the whole patch set: thank you!

Acked-by: Philippe Ombredanne 
-- 
Cordially
Philippe Ombredanne

Re: [PATCH v2 01/27] staging: ccree: SPDXify driver

[Philippe Ombredanne]

Gilad,

On Sun, Jan 7, 2018 at 11:13 AM, Gilad Ben-Yossef  wrote:
> On Wed, Jan 3, 2018 at 5:01 PM, Philippe Ombredanne
>  wrote:
>> Gilad,
>>
>> On Wed, Jan 3, 2018 at 2:35 PM, Gilad Ben-Yossef  wrote:
>>> Replace verbatim GPL v2 copy with SPDX tag.
>>>
>>> Signed-off-by: Gilad Ben-Yossef 
>>
>> 
>>
>>> --- a/drivers/staging/ccree/cc_crypto_ctx.h
>>> +++ b/drivers/staging/ccree/cc_crypto_ctx.h
>>> @@ -1,18 +1,5 @@
>>> -/*
>>> - * Copyright (C) 2012-2017 ARM Limited or its affiliates.
>>> - *
>>> - * This program is free software; you can redistribute it and/or modify
>>> - * it under the terms of the GNU General Public License version 2 as
>>> - * published by the Free Software Foundation.
>>> - *
>>> - * This program is distributed in the hope that it will be useful,
>>> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
>>> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>>> - * GNU General Public License for more details.
>>> - *
>>> - * You should have received a copy of the GNU General Public License
>>> - * along with this program; if not, see <http://www.gnu.org/licenses/>.
>>> - */
>>> +/* SPDX-License-Identifier: GPL-2.0-only */
>>> +/* Copyright (C) 2012-2018 ARM Limited or its affiliates. */
>>
>> Thank you for using the SPDX tags!
>>
>> Now, while I appreciate your attempt to use the latest and greatest
>> SPDX license id definitions (published by SPDX a few days agao), THIS
>> IS NOT a welcomed initiative. Please stick instead to use ONLY the
>> SPDX license ids that are defined in Thomas doc patches [1]: e.g. use
>> instead:  SPDX-License-Identifier: GPL-2.0 and please DO NOT USE
>> GPL-2.0-only for now.
>
> Oh dear. It seems I have been over enthusiastic with this.
> I shall post a revised  patch set. Sorry for the noise.
>
>>
>> The rationale is simple: from a kernel standpoint we cannot depend on
>> the latest changes of an external spec such as SPDX (and I am involved
>> with SPDX alright but I am wearing a kernel hat here). This is why
>> things have been carefully documented for the kernel proper by Thomas.
>> It is perfectly fine at some times in the future to adopt the newest
>> license ids, but this will have to happen in an orderly fashion with a
>> proper doc update and the eventual tree-wide changes to update every
>> occurrence. This cannot happen any other way or this would defeat the
>> whole purpose to have clear licensing kernel-wide: using the latest
>> and greatest introduces variations and creates a mess that we want to
>> avoid in the first place.
>>
>> CC: Thomas Gleixner 
>>
>> [1] https://lkml.org/lkml/2017/12/28/323
>>
>
> Just a thought - it might be useful to have an SPDX revision as part of the 
> tag,
> e.g.
>
> SPDX-3.0-License-Identifier: GPL-2.0-only
>
> It seems it will make transitions such as this easier, me thinks.
>
> Maybe something to consider for SPDX 3.1 :-)

That would make things a tad more complicated on the contributor side
IMHO. Instead and since the reference is the kernel doc and nothing
else (and not the latest and greatest SPDX updates of last week),
there is no need to version things at all, we just need to rev up the
doc and tools when and if we update things with newer SPDX versions.

Consider this analogy:
When you use zlib in the kernel you can only use exactly the subset of
the zlib API that is vendored in the kernel. You cannot use a new zlib
function in the latest and greatest release of zlib without updating
the vendored version first.
Here Thomas's doc is exactly this: a subset of the SPDX and license
ids as used exactly in the kernel as of now and "vendored" in the
kernel through this doc. You cannot use anything outside of this short
of updating the doc, tools like checkpatch and _every_ place that
could be impacted by this doc update.

-- 
Cordially
Philippe Ombredanne

Re: [PATCH v3 1/1] runchecks: Generalize make C={1,2} to support multiple checkers

[Philippe Ombredanne]

Knut,

On Fri, Jan 5, 2018 at 3:30 PM, Jani Nikula  wrote:
> On Thu, 04 Jan 2018, Knut Omang  wrote:
>> On Thu, 2018-01-04 at 17:50 +0200, Jani Nikula wrote:
>>> On Thu, 04 Jan 2018, Knut Omang  wrote:
>>> > Add scripts/runchecks which has generic support for running
>>> > checker tools in a convenient and user friendly way that
>>> > the author hopes can contribute to rein in issues detected
>>> > by these tools in a manageable and convenient way.



>>> > --- /dev/null
>>> > +++ b/scripts/runchecks
>>> > @@ -0,0 +1,734 @@
>>> > +#!/usr/bin/python
>>> > +
>>> > +# SPDX-License-Identifier: GPL-2.0

Thank you for using an SPDX tag here   .



>>> > +#
>>> > +# This program is free software; you can redistribute it and/or modify
>>> > +# it under the terms of the GNU General Public License version 2
>>> > +# as published by the Free Software Foundation.
>>> > +

but then please DRY: do not add this extra legalese which is redundant.

-- 
Cordially
Philippe Ombredanne

Re: [PATCH v2 1/6] ARM: at91: add TCB registers definitions

[Philippe Ombredanne]

On Fri, Jan 5, 2018 at 3:30 PM, Alexandre Belloni
 wrote:
> Add registers and bits definitions for the timer counter blocks found on
> Atmel ARM SoCs.
>
> Signed-off-by: Alexandre Belloni 
> ---
>  include/soc/at91/atmel_tcb.h | 229 
> +++
>  1 file changed, 229 insertions(+)
>  create mode 100644 include/soc/at91/atmel_tcb.h
>
> diff --git a/include/soc/at91/atmel_tcb.h b/include/soc/at91/atmel_tcb.h
> new file mode 100644
> index ..f48e60f8ab92
> --- /dev/null
> +++ b/include/soc/at91/atmel_tcb.h
> @@ -0,0 +1,229 @@
> +/*
> + * Copyright (C) 2016 Atmel
> + *
> + * This program is free software; you can redistribute it and/or modify it
> + * under the terms of the GNU General Public License version 2 as published 
> by
> + * the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful, but 
> WITHOUT
> + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
> + * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
> + * more details.
> + *
> + * You should have received a copy of the GNU General Public License along 
> with
> + * this program.  If not, see <http://www.gnu.org/licenses/>.
> + */

Alexandre,
Would you mind using SPDx tags here like you did in
/drivers/clocksource/timer-atmel-tcb.c ?
Thanks!
-- 
Cordially
Philippe Ombredanne

Re: [PATCH 05/12] arm64: dts: mt7622: add PMIC MT6380 related nodes

[Philippe Ombredanne]

Sean,

On Fri, Jan 5, 2018 at 4:42 AM, Sean Wang  wrote:
> On Thu, 2018-01-04 at 11:27 +0100, Philippe Ombredanne wrote:
>> Sean,
>>
>> On Thu, Jan 4, 2018 at 10:40 AM,   wrote:
>> > From: Sean Wang 
>> >
>> > Enable pwrap and MT6380 on mt7622-rfb1 board. Also add all mt6380
>> > regulator nodes in an alone file to allow similar boards using MT6380
>> > able to resue the configuration.
>> >
>> > Signed-off-by: Sean Wang 
>> > Cc: Mark Brown 
>> > Cc: Matthias Brugger 
>> > ---
>> >  arch/arm64/boot/dts/mediatek/mt6380.dtsi | 91 
>> > 
>> >  arch/arm64/boot/dts/mediatek/mt7622-rfb1.dts |  8 +++
>> >  arch/arm64/boot/dts/mediatek/mt7622.dtsi | 12 
>> >  3 files changed, 111 insertions(+)
>> >  create mode 100644 arch/arm64/boot/dts/mediatek/mt6380.dtsi
>> >
>> > diff --git a/arch/arm64/boot/dts/mediatek/mt6380.dtsi 
>> > b/arch/arm64/boot/dts/mediatek/mt6380.dtsi
>> > new file mode 100644
>> > index 000..7eb7dc2
>> > --- /dev/null
>> > +++ b/arch/arm64/boot/dts/mediatek/mt6380.dtsi
>> > @@ -0,0 +1,91 @@
>> > +/*
>> > + * Copyright (c) 2018 MediaTek Inc.
>> > + * Author: Chenglin Xu 
>> > + *Sean Wang 
>> > + *
>> > + * This program is free software; you can redistribute it and/or modify
>> > + * it under the terms of the GNU General Public License version 2 as
>> > + * published by the Free Software Foundation.
>> > + *
>> > + * This program is distributed in the hope that it will be useful,
>> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> > + * GNU General Public License for more details.
>> > + */
>>
>> Would you mind using SPDX tags instead of this fine but long legalese?
>> This is documented in Thomas patches [1].
>
>> Also if you could spread the word in your team, this would earn you
>> good karma points.
>> Thank you!
>>
>> [1] https://lkml.org/lkml/2017/12/28/323
>
>
> Hi, Philippe
>
> thanks for your suggestion
>
> Certainly, this can be replaced with
>
> SPDX-License-Identifier: GPL-2.0
>
> most drivers from MediaTek use the similar disclaimer, it should be fine
> to use SPDX tags instead.
>
> Sean
>

Thank you! that's great.

-- 
Cordially
Philippe Ombredanne

Re: [PATCH] of: Use SPDX license tag for DT files

[Philippe Ombredanne]

-1,13 +1,10 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
>  /*
>   * OF helpers for DMA request / controller
>   *
>   * Based on of_gpio.h
>   *
>   * Copyright (C) 2012 Texas Instruments Incorporated - http://www.ti.com/
> - *
> - * This program is free software; you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License version 2 as
> - * published by the Free Software Foundation.
>   */
>
>  #ifndef __LINUX_OF_DMA_H
> diff --git a/include/linux/of_fdt.h b/include/linux/of_fdt.h
> index 013c5418aeec..1799b0945a6b 100644
> --- a/include/linux/of_fdt.h
> +++ b/include/linux/of_fdt.h
> @@ -1,12 +1,9 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
>  /*
>   * Definitions for working with the Flattened Device Tree data format
>   *
>   * Copyright 2009 Benjamin Herrenschmidt, IBM Corp
>   * b...@kernel.crashing.org
> - *
> - * This program is free software; you can redistribute it and/or
> - * modify it under the terms of the GNU General Public License
> - * version 2 as published by the Free Software Foundation.
>   */
>
>  #ifndef _LINUX_OF_FDT_H
> diff --git a/include/linux/of_gpio.h b/include/linux/of_gpio.h
> index 1fe205582111..f6af4276fd51 100644
> --- a/include/linux/of_gpio.h
> +++ b/include/linux/of_gpio.h
> @@ -1,14 +1,10 @@
> +/* SPDX-License-Identifier: GPL-2.0+ */
>  /*
>   * OF helpers for the GPIO API
>   *
>   * Copyright (c) 2007-2008  MontaVista Software, Inc.
>   *
>   * Author: Anton Vorontsov 
> - *
> - * This program is free software; you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License as published by
> - * the Free Software Foundation; either version 2 of the License, or
> - * (at your option) any later version.
>   */
>
>  #ifndef __LINUX_OF_GPIO_H
> diff --git a/include/linux/of_graph.h b/include/linux/of_graph.h
> index 3e058f05ab04..01038a6aade0 100644
> --- a/include/linux/of_graph.h
> +++ b/include/linux/of_graph.h
> @@ -1,3 +1,4 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
>  /*
>   * OF graph binding parsing helpers
>   *
> @@ -6,10 +7,6 @@
>   *
>   * Copyright (C) 2012 Renesas Electronics Corp.
>   * Author: Guennadi Liakhovetski 
> - *
> - * This program is free software; you can redistribute it and/or modify
> - * it under the terms of version 2 of the GNU General Public License as
> - * published by the Free Software Foundation.
>   */
>  #ifndef __LINUX_OF_GRAPH_H
>  #define __LINUX_OF_GRAPH_H
> diff --git a/include/linux/of_pdt.h b/include/linux/of_pdt.h
> index 7e09244bb679..d0b183ab65c6 100644
> --- a/include/linux/of_pdt.h
> +++ b/include/linux/of_pdt.h
> @@ -1,13 +1,9 @@
> +/* SPDX-License-Identifier: GPL-2.0+ */
>  /*
>   * Definitions for building a device tree by calling into the
>   * Open Firmware PROM.
>   *
>   * Copyright (C) 2010  Andres Salomon 
> - *
> - * This program is free software; you can redistribute it and/or
> - * modify it under the terms of the GNU General Public License
> - * as published by the Free Software Foundation; either version
> - * 2 of the License, or (at your option) any later version.
>   */
>
>  #ifndef _LINUX_OF_PDT_H
> diff --git a/include/linux/of_platform.h b/include/linux/of_platform.h
> index fb908e598348..84a966623e78 100644
> --- a/include/linux/of_platform.h
> +++ b/include/linux/of_platform.h
> @@ -1,14 +1,9 @@
> +/* SPDX-License-Identifier: GPL-2.0+ */
>  #ifndef _LINUX_OF_PLATFORM_H
>  #define _LINUX_OF_PLATFORM_H
>  /*
>   *Copyright (C) 2006 Benjamin Herrenschmidt, IBM Corp.
>   *  
> - *
> - *  This program is free software; you can redistribute it and/or
> - *  modify it under the terms of the GNU General Public License
> - *  as published by the Free Software Foundation; either version
> - *  2 of the License, or (at your option) any later version.
> - *
>   */
>
>  #include 
> --
> 2.14.1
>

Reviewed-by: Philippe Ombredanne 

FWIW, I also checked that there were no mismatch with any
MODULE_LICENSE in these file (that do not have one anyway).

-- 
Cordially
Philippe Ombredanne

Re: [patch V5 02/11] LICENSES: Add the GPL 2.0 license

[Philippe Ombredanne]

Carmen,

On Thu, Jan 4, 2018 at 5:25 PM, Carmen Bianca Bakker
 wrote:
> Hi all,
>
> Since December, `GPL-2.0` is no longer the correct identifier for the
> licence.  The American FSF has been in talks with the SPDX Workgroup to
> change it to `GPL-2.0-only`.
>
> See the rationale here:
>
> https://www.gnu.org/licenses/identify-licenses-clearly.html
>
> See the new canonical licence list here:
>
> https://spdx.org/licenses/
>
> This change is valid for all GPL licences.  Similarly, `GPL-2.0+` has
> been changed to `GPL-2.0-or-later`.

This is exactly to insulate against these kinds of changes that this
doc patch exists in the first place and documents what things mean for
the kernel.

> I believe that this patch should be changed to reflect that.  The
> identifiers used in this patch are still valid, but deprecated.

Kernel-wise I do not think we can be assume that changes such as these
could be implemented right away so there is no need to change the doc
at this stage.
For now the kernel doc is the reference and nothing else. So this
patch should NOT be changed IMHO at least not now.
Eventually this could happen in the future, but not out of order with
actual patches to update the code and tooling and certainly not now.

-- 
Cordially
Philippe Ombredanne

Re: [PATCH V2] perf script: add script to profile and resolve physical mem type

[Philippe Ombredanne]

rg/lkml/2017/12/28/323

>> +
>> +from __future__ import division
>> +import os
>> +import sys
>> +import struct
>> +import re
>> +import bisect
>> +import collections
>> +
>> +sys.path.append(os.environ['PERF_EXEC_PATH'] + \
>> + '/scripts/python/Perf-Trace-Util/lib/Perf/Trace')
>> +
>> +system_ram = []
>> +pmem = []
>> +f = None
>> +load_mem_type_cnt = collections.Counter()
>> +event_name = None

nit. may be it does not matter too much but using globals
throughout as opposed to return values makes the script harder to read
IMHO.

>> +
>> +def parse_iomem():
>> + global f
>> + f = open('/proc/iomem', 'r')
>> + for i, j in enumerate(f):
>> + m = re.split('-|:',j,2)
>> + if m[2].strip() == 'System RAM':
>> + system_ram.append(long(m[0], 16))
>> + system_ram.append(long(m[1], 16))
>> + if m[2].strip() == 'Persistent Memory':
>> + pmem.append(long(m[0], 16))
>> + pmem.append(long(m[1], 16))
>> +
>> +def print_memory_type():
>> + print "Event: %s" % (event_name)
>> + print "%-40s  %10s  %10s\n" % ("Memory type", "count",
>> "percentage"),
>> + print "%-40s  %10s  %10s\n" % 
>> ("", \
>> + "---", "---"),
>> + total = sum(load_mem_type_cnt.values())
>> + for mem_type, count in sorted(load_mem_type_cnt.most_common(),
>> \
>> + key = lambda(k, v): (v, k), reverse =
>> True):
>> + print "%-40s  %10d  %10.1f%%\n" % (mem_type, count, 100 *
>> count / total),
>> +
>> +def trace_begin():
>> + parse_iomem()
>> +
>> +def trace_end():
>> + print_memory_type()
>> + f.close()
>> +
>> +def is_system_ram(phys_addr):
>> + #/proc/iomem is sorted
>> + position = bisect.bisect(system_ram, phys_addr)
>> + if position % 2 == 0:
>> + return False
>> + return True
>> +
>> +def is_persistent_mem(phys_addr):
>> + position = bisect.bisect(pmem, phys_addr)
>> + if position % 2 == 0:
>> + return False
>> + return True
>> +
>> +def find_memory_type(phys_addr):
>> + if phys_addr == 0:
>> + return "N/A"
>> + if is_system_ram(phys_addr):
>> + return "System RAM"
>> +
>> + if is_persistent_mem(phys_addr):
>> + return "Persistent Memory"
>> +
>> + #slow path, search all
>> + f.seek(0, 0)
>> + for j in f:
>> + m = re.split('-|:',j,2)
>> + if long(m[0], 16) <= phys_addr <= long(m[1], 16):
>> + return m[2]
>> + return "N/A"
>> +
>> +def process_event(param_dict):
>> + name   = param_dict["ev_name"]
>> + sample = param_dict["sample"]
>> + phys_addr  = sample["phys_addr"]
>> +
>> + global event_name
>> + if event_name == None:
>> + event_name = name
>> + load_mem_type_cnt[find_memory_type(phys_addr)] += 1
>> diff --git a/tools/perf/util/scripting-engines/trace-event-python.c
>> b/tools/perf/util/scripting-engines/trace-event-python.c
>> index c7187f0..8cd6317 100644
>> --- a/tools/perf/util/scripting-engines/trace-event-python.c
>> +++ b/tools/perf/util/scripting-engines/trace-event-python.c
>> @@ -500,6 +500,8 @@ static PyObject *get_perf_sample_dict(struct
>> perf_sample *sample,
>>   PyLong_FromUnsignedLongLong(sample->time));
>>   pydict_set_item_string_decref(dict_sample, "period",
>>   PyLong_FromUnsignedLongLong(sample->period));
>> + pydict_set_item_string_decref(dict_sample, "phys_addr",
>> + PyLong_FromUnsignedLongLong(sample-
>> >phys_addr));
>>   set_sample_read_in_dict(dict_sample, sample, evsel);
>>   pydict_set_item_string_decref(dict, "sample", dict_sample);
>>
>> --
>> 2.7.4
>


-- 
Cordially
Philippe Ombredanne

Re: [PATCH 05/12] arm64: dts: mt7622: add PMIC MT6380 related nodes

[Philippe Ombredanne]

Sean,

On Thu, Jan 4, 2018 at 10:40 AM,   wrote:
> From: Sean Wang 
>
> Enable pwrap and MT6380 on mt7622-rfb1 board. Also add all mt6380
> regulator nodes in an alone file to allow similar boards using MT6380
> able to resue the configuration.
>
> Signed-off-by: Sean Wang 
> Cc: Mark Brown 
> Cc: Matthias Brugger 
> ---
>  arch/arm64/boot/dts/mediatek/mt6380.dtsi | 91 
> 
>  arch/arm64/boot/dts/mediatek/mt7622-rfb1.dts |  8 +++
>  arch/arm64/boot/dts/mediatek/mt7622.dtsi | 12 
>  3 files changed, 111 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/mediatek/mt6380.dtsi
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt6380.dtsi 
> b/arch/arm64/boot/dts/mediatek/mt6380.dtsi
> new file mode 100644
> index 000..7eb7dc2
> --- /dev/null
> +++ b/arch/arm64/boot/dts/mediatek/mt6380.dtsi
> @@ -0,0 +1,91 @@
> +/*
> + * Copyright (c) 2018 MediaTek Inc.
> + * Author: Chenglin Xu 
> + *Sean Wang 
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */

Would you mind using SPDX tags instead of this fine but long legalese?
This is documented in Thomas patches [1].

Also if you could spread the word in your team, this would earn you
good karma points.
Thank you!

[1] https://lkml.org/lkml/2017/12/28/323
-- 
Cordially
Philippe Ombredanne

Re: [PATCH 6/6] add test for aio poll and io_pgetevents

[Philippe Ombredanne]

Dear Christoph,

On Thu, Jan 4, 2018 at 9:03 AM, Christoph Hellwig  wrote:
> Signed-off-by: Christoph Hellwig 
> ---
>  harness/cases/22.t | 149 
> +
>  1 file changed, 149 insertions(+)
>  create mode 100644 harness/cases/22.t
>
> diff --git a/harness/cases/22.t b/harness/cases/22.t
> new file mode 100644
> index 000..a9fec6b
> --- /dev/null
> +++ b/harness/cases/22.t
> @@ -0,0 +1,149 @@
> +/*
> + * Copyright (C) 2006-2018 Free Software Foundation, Inc.
> + * Copyright (C) 2018 Christoph Hellwig.
> + * License: LGPLv2.1 or later.

Would you consider using an SPDX tag instead as documented in Thomas
doc patches [1]? This rather close to what you use today and would
come out as this, on the first line:

SPDX-License-Identifier: LGPL-2.1+

Thank you!

[1] https://lkml.org/lkml/2017/12/28/323
-- 
Cordially
Philippe Ombredanne, your kernel licensing scruffy

Re: [PATCH bpf-next v5 3/4] libbpf: add missing SPDX-License-Identifier

[Philippe Ombredanne]

On Thu, Jan 4, 2018 at 9:21 AM, Eric Leblond  wrote:
> Signed-off-by: Eric Leblond 
> Acked-by: Alexei Starovoitov 
> ---
>  tools/lib/bpf/bpf.c| 2 ++
>  tools/lib/bpf/bpf.h| 2 ++
>  tools/lib/bpf/libbpf.c | 2 ++
>  tools/lib/bpf/libbpf.h | 2 ++
>  4 files changed, 8 insertions(+)
>
> diff --git a/tools/lib/bpf/bpf.c b/tools/lib/bpf/bpf.c
> index 10d71b9fdbd0..38d720466fe8 100644
> --- a/tools/lib/bpf/bpf.c
> +++ b/tools/lib/bpf/bpf.c
> @@ -1,3 +1,5 @@
> +// SPDX-License-Identifier: LGPL-2.1
> +
>  /*
>   * common eBPF ELF operations.
>   *
> diff --git a/tools/lib/bpf/bpf.h b/tools/lib/bpf/bpf.h
> index 9f44c196931e..8d18fb73d7fb 100644
> --- a/tools/lib/bpf/bpf.h
> +++ b/tools/lib/bpf/bpf.h
> @@ -1,3 +1,5 @@
> +/* SPDX-License-Identifier: LGPL-2.1 */
> +
>  /*
>   * common eBPF ELF operations.
>   *
> diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c
> index 5fe8aaa2123e..924a8b8431ab 100644
> --- a/tools/lib/bpf/libbpf.c
> +++ b/tools/lib/bpf/libbpf.c
> @@ -1,3 +1,5 @@
> +// SPDX-License-Identifier: LGPL-2.1
> +
>  /*
>   * Common eBPF ELF object loading operations.
>   *
> diff --git a/tools/lib/bpf/libbpf.h b/tools/lib/bpf/libbpf.h
> index e42f96900318..f85906533cdd 100644
> --- a/tools/lib/bpf/libbpf.h
> +++ b/tools/lib/bpf/libbpf.h
> @@ -1,3 +1,5 @@
> +/* SPDX-License-Identifier: LGPL-2.1 */
> +
>  /*
>   * Common eBPF ELF object loading operations.
>   *
> --
> 2.15.1
>

Reviewed-by: Philippe Ombredanne 

Thank you for using the SPDX tags!

-- 
Cordially
Philippe Ombredanne

Re: [PATCH v2 01/27] staging: ccree: SPDXify driver

[Philippe Ombredanne]

Gilad,

On Wed, Jan 3, 2018 at 2:35 PM, Gilad Ben-Yossef  wrote:
> Replace verbatim GPL v2 copy with SPDX tag.
>
> Signed-off-by: Gilad Ben-Yossef 



> --- a/drivers/staging/ccree/cc_crypto_ctx.h
> +++ b/drivers/staging/ccree/cc_crypto_ctx.h
> @@ -1,18 +1,5 @@
> -/*
> - * Copyright (C) 2012-2017 ARM Limited or its affiliates.
> - *
> - * This program is free software; you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License version 2 as
> - * published by the Free Software Foundation.
> - *
> - * This program is distributed in the hope that it will be useful,
> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> - * GNU General Public License for more details.
> - *
> - * You should have received a copy of the GNU General Public License
> - * along with this program; if not, see <http://www.gnu.org/licenses/>.
> - */
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +/* Copyright (C) 2012-2018 ARM Limited or its affiliates. */

Thank you for using the SPDX tags!

Now, while I appreciate your attempt to use the latest and greatest
SPDX license id definitions (published by SPDX a few days agao), THIS
IS NOT a welcomed initiative. Please stick instead to use ONLY the
SPDX license ids that are defined in Thomas doc patches [1]: e.g. use
instead:  SPDX-License-Identifier: GPL-2.0 and please DO NOT USE
GPL-2.0-only for now.

The rationale is simple: from a kernel standpoint we cannot depend on
the latest changes of an external spec such as SPDX (and I am involved
with SPDX alright but I am wearing a kernel hat here). This is why
things have been carefully documented for the kernel proper by Thomas.
It is perfectly fine at some times in the future to adopt the newest
license ids, but this will have to happen in an orderly fashion with a
proper doc update and the eventual tree-wide changes to update every
occurrence. This cannot happen any other way or this would defeat the
whole purpose to have clear licensing kernel-wide: using the latest
and greatest introduces variations and creates a mess that we want to
avoid in the first place.

CC: Thomas Gleixner 

[1] https://lkml.org/lkml/2017/12/28/323

-- 
Cordially
Philippe Ombredanne

Re: [PATCH 01/26] staging: ccree: SPDXify driver

[Philippe Ombredanne]

Gilad,

On Mon, Jan 1, 2018 at 1:06 PM, Gilad Ben-Yossef  wrote:
> Replace verbatim GPL v2 copy with SPDX tag.
>
> Signed-off-by: Gilad Ben-Yossef 



> --- a/drivers/staging/ccree/cc_crypto_ctx.h
> +++ b/drivers/staging/ccree/cc_crypto_ctx.h
> @@ -1,18 +1,5 @@
> -/*
> - * Copyright (C) 2012-2017 ARM Limited or its affiliates.
> - *
> - * This program is free software; you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License version 2 as
> - * published by the Free Software Foundation.
> - *
> - * This program is distributed in the hope that it will be useful,
> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> - * GNU General Public License for more details.
> - *
> - * You should have received a copy of the GNU General Public License
> - * along with this program; if not, see <http://www.gnu.org/licenses/>.
> - */
> +// SPDX-License-Identifier: GPL-2.0
> +// Copyright (C) 2012-2017 ARM Limited or its affiliates.
>

For a .h file the style should be C comments as explained in Thomas
doc patches. .e.g.

> +/* SPDX-License-Identifier: GPL-2.0 */

And then it might makes sense there too:

> +/* Copyright (C) 2012-2017 ARM Limited or its affiliates. */

-- 
Cordially
Philippe Ombredanne

Re: [PATCH] input: pxrc: new driver for PhoenixRC Flight Controller Adapter

[Philippe Ombredanne]

Markus,

On Sun, Dec 31, 2017 at 9:09 PM, Marcus Folkesson
 wrote:
> This driver let you plug in your RC controller to the adapter and
> use it as input device in various RC simulators.
>
> Signed-off-by: Marcus Folkesson 



> --- /dev/null
> +++ b/drivers/input/joystick/pxrc.c
> @@ -0,0 +1,254 @@
> +// SPDX-License-Identifier: GPL-2.0



> +MODULE_LICENSE("GPL");

This MODULE_LICENSE means GPL 2.0 or later per module.h and this does
not match your top level SPDX tag which means GPL 2.0 only.
Could you make sure they are in sync?

-- 
Cordially
Philippe Ombredanne

Re: [PATCHv2 1/8] MIPS: Loongson64: cleanup all cs5536 files to use SPDX Identifier

[Philippe Ombredanne]

On Sun, Dec 31, 2017 at 2:14 PM, Jiaxun Yang  wrote:
> On 2017-12-31 Sun 12:17 +0100，Philippe Ombredanne wrote：
>> Did you CC the original authors? You would need their signoff or at
>> least an ack IMHO
>
> Yeah, I CC Huacai Chen in v1 as the Lemote staff who in charge of
> Loongson's mainline kernel. Can he sign-off for all the original
> authors who were from ICT and Lemote?
> As far as I know, some authors are no longer working in Lemote. And I
> can't see their new email addresses so it may hard to get their ack or
> sign-off.
> Thanks for your adivce.
>
> --
> Best Regards
> Jiaxun Yang

It would best if you can get all acks, at least one authoritative from
each org involved or from each individual involved if not part of an
org. I reckon it may be difficult. But then you can document with your
patch set who you contacted, who you got ack from and who you did not.

Then again you are not changing anything about the licensing: just
replacing licensing by value (e.g. a full notice) by a license by
reference (e.g. an SPDX tag that references the full text).

-- 
Cordially
Philippe Ombredanne

Re: [PATCH bpf-next v4 2/3] libbpf: add error reporting in XDP

[Philippe Ombredanne]

On Sat, Dec 30, 2017 at 9:41 PM, Eric Leblond  wrote:
> Parse netlink ext attribute to get the error message returned by
> the card. Code is partially take from libnl.
>
> Signed-off-by: Eric Leblond 
> Acked-by: Alexei Starovoitov 



> --- /dev/null
> +++ b/tools/lib/bpf/nlattr.c
> @@ -0,0 +1,187 @@
> +// SPDX-License-Identifier: LGPL-2.1
> +
> +/*
> + * NETLINK  Netlink attributes
> + *
> + * This library is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU Lesser General Public
> + * License as published by the Free Software Foundation version 2.1
> + * of the License.
> + *
> + * Copyright (c) 2003-2013 Thomas Graf 
> + */

Do you think you could get an ack or signoff from the author
(i.e.Thomas Graf)  to get a more streamlined thing such as this:

> +// SPDX-License-Identifier: LGPL-2.1
> +// NETLINK  Netlink attributes
> +// Copyright (c) 2003-2013 Thomas Graf 


-- 
Cordially
Philippe Ombredanne

Re: [PATCHv2 1/8] MIPS: Loongson64: cleanup all cs5536 files to use SPDX Identifier

[Philippe Ombredanne]

On Sat, Dec 30, 2017 at 7:28 PM, Jiaxun Yang  wrote:
> To reduce unnecessary license text.
>
> Signed-off-by: Jiaxun Yang 
> ---
>  arch/mips/loongson64/common/cs5536/Makefile   | 1 +
>  arch/mips/loongson64/common/cs5536/cs5536_acc.c   | 6 ++
>  arch/mips/loongson64/common/cs5536/cs5536_ehci.c  | 6 ++
>  arch/mips/loongson64/common/cs5536/cs5536_ide.c   | 6 ++
>  arch/mips/loongson64/common/cs5536/cs5536_isa.c   | 6 ++
>  arch/mips/loongson64/common/cs5536/cs5536_mfgpt.c | 6 ++
>  arch/mips/loongson64/common/cs5536/cs5536_ohci.c  | 6 ++
>  arch/mips/loongson64/common/cs5536/cs5536_pci.c   | 7 ++-
>  8 files changed, 15 insertions(+), 29 deletions(-)
>
> diff --git a/arch/mips/loongson64/common/cs5536/Makefile 
> b/arch/mips/loongson64/common/cs5536/Makefile
> index f12e64007347..b0c805a0dcc6 100644
> --- a/arch/mips/loongson64/common/cs5536/Makefile
> +++ b/arch/mips/loongson64/common/cs5536/Makefile
> @@ -1,3 +1,4 @@
> +# SPDX-License-Identifier: GPL-2.0
>  #
>  # Makefile for CS5536 support.
>  #
> diff --git a/arch/mips/loongson64/common/cs5536/cs5536_acc.c 
> b/arch/mips/loongson64/common/cs5536/cs5536_acc.c
> index ab4d6cc57384..ba0474bb4a3d 100644
> --- a/arch/mips/loongson64/common/cs5536/cs5536_acc.c
> +++ b/arch/mips/loongson64/common/cs5536/cs5536_acc.c
> @@ -1,3 +1,5 @@
> +// SPDX-License-Identifier: GPL-2.0
> +
>  /*
>   * the ACC Virtual Support Module of AMD CS5536
>   *
> @@ -7,10 +9,6 @@
>   * Copyright (C) 2009 Lemote, Inc.
>   * Author: Wu Zhangjin, wuzhang...@gmail.com
>   *
> - * This program is free software; you can redistribute it and/or modify it
> - * under  the terms of the GNU General  Public License as published by the
> - * Free Software Foundation;  either version 2 of the  License, or (at your
> - * option) any later version.
>   */

Did you CC the original authors? You would need their signoff or at
least an ack IMHO
-- 
Cordially
Philippe Ombredanne

Re: [PATCH V2] ARM: imx: introduce imx_l2c310_write_sec

[Philippe Ombredanne]

On Sat, Dec 30, 2017 at 1:34 PM, Peng Fan  wrote:
> Some PL310 registers could only be wrote in secure world, so
> introduce imx_l2c310_write_sec to support Linux running in
> non-secure world configure PL310.
>
> Signed-off-by: Peng Fan 
> Cc: Shawn Guo 
> Cc: Sascha Hauer 
> Cc: Fabio Estevam 
> Cc: Dong Aisheng 
> ---
>
> V2:
>  Use SPDX Tag
>  Use CONFIG_HAVE_ARM_SMCCC to fix build error for armv5.
>  Add IS_ENABLED(CONFIG_OPTEE) check when assigning write_sec
>
>  arch/arm/mach-imx/system.c| 27 ++-
>  include/soc/imx/imx_sip_smc.h | 21 +
>  2 files changed, 47 insertions(+), 1 deletion(-)
>  create mode 100644 include/soc/imx/imx_sip_smc.h
>
> diff --git a/arch/arm/mach-imx/system.c b/arch/arm/mach-imx/system.c
> index c06af650e6b1..2c27e52d8c7d 100644
> --- a/arch/arm/mach-imx/system.c
> +++ b/arch/arm/mach-imx/system.c
> @@ -23,11 +23,13 @@
>  #include 
>  #include 
>  #include 
> +#include 
>
>  #include 
>  #include 
>  #include 
>  #include 
> +#include 
>
>  #include "common.h"
>  #include "hardware.h"
> @@ -92,6 +94,22 @@ void __init imx1_reset_init(void __iomem *base)
>  #endif
>
>  #ifdef CONFIG_CACHE_L2X0
> +#ifdef CONFIG_HAVE_ARM_SMCCC
> +void imx_l2c310_write_sec(unsigned long val, unsigned int reg)
> +{
> +   struct arm_smccc_res res;
> +
> +   arm_smccc_smc(IMX_SIP_SMC_L2C310, val, reg, 0, 0, 0, 0, 0, &res);
> +
> +   if (res.a0 != 0)
> +   pr_err("Failed to write l2c310 0x%x: 0x%lx\n", reg, res.a0);
> +}
> +#else
> +void imx_l2c310_write_sec(unsigned long val, unsigned int reg)
> +{
> +}
> +#endif
> +
>  void __init imx_init_l2cache(void)
>  {
> void __iomem *l2x0_base;
> @@ -102,6 +120,10 @@ void __init imx_init_l2cache(void)
> if (!np)
> return;
>
> +   if (IS_ENABLED(CONFIG_OPTEE) &&
> +   of_find_compatible_node(NULL, NULL, "linaro,optee-tz"))
> +   outer_cache.write_sec = imx_l2c310_write_sec;
> +
> l2x0_base = of_iomap(np, 0);
> if (!l2x0_base)
> goto put_node;
> @@ -117,7 +139,10 @@ void __init imx_init_l2cache(void)
> val &= ~L310_PREFETCH_CTRL_OFFSET_MASK;
> val |= 15;
>
> -   writel_relaxed(val, l2x0_base + L310_PREFETCH_CTRL);
> +   if (outer_cache.write_sec)
> +   outer_cache.write_sec(val, L310_PREFETCH_CTRL);
> +   else
> +   writel_relaxed(val, l2x0_base + L310_PREFETCH_CTRL);
> }
>
> iounmap(l2x0_base);
> diff --git a/include/soc/imx/imx_sip_smc.h b/include/soc/imx/imx_sip_smc.h
> new file mode 100644
> index ..c35ae69e0d2f
> --- /dev/null
> +++ b/include/soc/imx/imx_sip_smc.h
> @@ -0,0 +1,21 @@
> +/*
> + * Copyright 2017 NXP
> + *
> + * SPDX-License-Identifier: GPL-2.0
> + */
> +

Thanks! but the SPDX tag should be on the first line as its own
comment. So this would come out something like this

> +/* SPDX-License-Identifier: GPL-2.0 */
> +/* Copyright 2017 NXP */

or

> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Copyright 2017 NXP
> + */



> +#ifndef __IMX_SIP_SMC_H_
> +#define __IMX_SIP_SMC_H_
> +
> +#include 
> +
> +#define IMX_SIP_SMC_VAL(func) ARM_SMCCC_CALL_VAL(ARM_SMCCC_FAST_CALL, \
> +ARM_SMCCC_SMC_32, \
> +ARM_SMCCC_OWNER_SIP, \
> +(func))
> +
> +#define IMX_L2C310 0x1
> +
> +#define IMX_SIP_SMC_L2C310 IMX_SIP_SMC_VAL(IMX_L2C310)
> +
> +#endif
> --
> 2.14.1
>



-- 
Cordially
Philippe Ombredanne

Re: [patch V5 01/11] Documentation: Add license-rules.rst to describe how to properly identify file licenses

[Philippe Ombredanne]

On Fri, Dec 29, 2017 at 7:54 PM, Theodore Ts'o  wrote:
> On Fri, Dec 29, 2017 at 08:19:59AM -0800, Joe Perches wrote:
>>
>> Has it been legally reviewed and accepted that removal
>> of the BSD license text from individual source files is
>> appropriate and meets the legal requirements of
>> following the BSD license on a per-file basis?
>>
>> And if so, who did this review?
>>
>> Is there any license that does not allow removal of the
>> license text and does not allow simple substitution of
>> the SPDX license identifier in each individual file?
>
> The work to use SPDX lines instead of individual licenses was done by
> Greg K-H in close consultation with Linux Foundation counsels, so I
> would assume that they did look at that particular issue.

This is correct. And this is in addition to the discussion in the SPDX
group  at the LF (that includes several FOSS-savvy and prominent FOSS
lawyers) that did design the SPDX spec.

> IANAL, but I've talked to lawyers about this issue, and in my
> experience if you talk to three lawyers you will easily get six
> opinions.

And that's on a good day: you may get more than six on a bad one. But
on the other hand, they tend also to defer to standards, and
established community norms.

> As far as I know, none of the licenses explicitly say
> copyright license must be on each file.  Just that the distribution of
> source must include the copyright and license statement.  Exactly how
> that is done is not explicitly specified.

This is also my take. What is done here is not much different than
refactoring duplicated code so it leaves in a single place:

- by "value" at the root in COPYING and in the Documentation.
- by "reference" in the code proper as SPDX ids.

Therefore essential and common requirements to include the license
text is fulfilled in the kernel.

Note that there are a few offenders that will need to clean up their
acts as they came up will both long and "un-removable and
un-alterable" crazy legalese blurbs [1] prefix this:

"DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER"

These will have to be taken care on a case by case basis. These are
pretty stupid and IMHO should have never been allowed to be added to
the kernel in the first place and are ugly warts. It could very well
be that these are not really GPL-compliant notices FWIW: keeping
notices and copyrights is quite different from a restriction of
altering things by moving them around which is exactly what is
happening with the SPDX-ification here.

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/staging/lustre/include/linux/libcfs/libcfs.h?h=v4.15-rc5#n5

-- 
Cordially
Philippe Ombredanne

Re: [PATCH v2 1/5] ARM: sun9i: Support SMP on A80 with Multi-Cluster Power Management (MCPM)

[Philippe Ombredanne]

Mylène, Chen-Yu,

On Fri, Dec 29, 2017 at 11:55 AM, Mylène Josserand
 wrote:
> From: Chen-Yu Tsai 
>
> The A80 is a big.LITTLE SoC with 1 cluster of 4 Cortex-A7s and
> 1 cluster of 4 Cortex-A15s.



> --- /dev/null
> +++ b/arch/arm/mach-sunxi/mcpm.c
> @@ -0,0 +1,391 @@
> +/*
> + * Copyright (c) 2015 Chen-Yu Tsai
> + *
> + * Chen-Yu Tsai 
> + *
> + * arch/arm/mach-sunxi/mcpm.c
> + *
> + * Based on arch/arm/mach-exynos/mcpm-exynos.c and Allwinner code
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + */

Would you mind using a concise SPDX tag instead, as documented by
Thomas doc patches?

Thank you for your kind consideration!
-- 
Cordially
Philippe Ombredanne

Re: [patch V5 00/11] LICENSES: Add documentation and initial License files

[Philippe Ombredanne]

 sets of license terms need to be
> adhered to is::
>
> -  // SPDX-License-Identifier: (GPL-1.0+ AND LGPL-2.1+)
> +  // SPDX-License-Identifier: GPL-1.0+ AND LGPL-2.1+
>
>  License identifiers
>  ---
>
>

I reviewed carefully this updated V5 patch series.

Thank you for pulling this through and I wish you and all kernel
contributors a happy new year: 2018 is going to be The Year of The
Penguin [1] in my personal revised version of the Chinese calendar.

"Intelligent, curious, and social, those born under the sign of the
Penguin love nothing more than coming up with creative solutions to
any kind of problem. This is the sign of thinkers and analysts, those
inquisitive about how everything works. Members of this sign are often
very intellectually advanced at an early age, and this strong desire
to learn drives the majority of their life decisions as they grow up."

And a reminder to all that January 20th is "Penguin Awareness Day" [2]

[1] http://www.primalastrology.com/penguin.html
[2] https://www.daysoftheyear.com/days/penguin-awareness-day/

Reviewed-by: Philippe Ombredanne 

-- 
Cordially
Philippe Ombredanne

Re: [patch V5 02/11] LICENSES: Add the GPL 2.0 license

[Philippe Ombredanne]

Thomas,

On Thu, Dec 28, 2017 at 4:27 PM, Thomas Gleixner  wrote:
> Add the full text of the GPL 2.0 license to the LICENSES directory.  It was
> copied directly from the COPYING file in the kernel source tree as it
> differs from the public available version of the license in various places
> including the FSF.
>
> Philippe did some research on the GPL2.0 history:
>
>   There is NO trustworthy version of an official GPL 2.0 text: the FSF
>   official texts are all fubar (if only in small and subtle ways). The FSF
>   texts should be authoritative, but then which one? They published more
>   GPL 2.0 versions than most. So we would be hard pressed to blame SPDX or
>   the OSI for having their own minor variant.
>
>   Then in digging further, I found the ONE true original GPL with a file
>   time stamp on June 2 1991, 01:50 (AM?, PM? unknown time zone?)  ! in an
>   old GCC archive.
>
>   For the posterity and everyone's enjoyment I have built a git history
>   of GPL 2.0 Mark1 to Mark6
>
>   See https://github.com/pombredanne/gpl-history/commits/master/COPYING
>
>   I also added a shorter history of the Linux COPYING text. The first
>   version in Linus's git tree is based on the very fine and well tuned GPL
>   2 Mark4, the first fully Y2K compliant version of the GPL 2, as you can
>   see from the diffs with the former Mark3: that was dangerously stuck in
>   the last century.
>
>   The current version in is based on a rare GPL 2.0 Mark5.1 aka "Franklin
>   St", that I do not have in my history yet and spells "Franklin St."
>   rather than "Franklin Street."  Therefore there is likely another GPL 2.0
>   version between Mark4 and Mark5 that I have yet to find and may not have
>   been caught by the archive.org spiders. Here help and patches welcomed:
>   this is likely an important missing link.
>
>   Further information about this archaelogical research;
>
>   
> http://lkml.kernel.org/r/CAOFm3uEzRMf261+O-Nm+9HDoEn9RbFjH=5j9i1c2ggmug2g...@mail.gmail.com
>
> Add the required tags for reference and tooling.
>
> Signed-off-by: Thomas Gleixner 
> Reviewed-by: Greg Kroah-Hartman 
> Reviewed-by: Philippe Ombredanne 
> Reviewed-by: Jonas Oberg 
> Reviewed-by: Darrick J. Wong 
>
> ---
>  LICENSES/preferred/GPL-2.0 |  353 
> +
>  1 file changed, 353 insertions(+)
>  create mode 100644 LICENSES/GPL-2.0
>
> --- /dev/null
> +++ b/LICENSES/preferred/GPL-2.0
> @@ -0,0 +1,353 @@
> +Valid-License-Identifier: GPL-2.0
> +Valid-License-Identifier: GPL-2.0+
> +SPDX-URL: https://spdx.org/licenses/GPL-2.0.html
> +Usage-Guide:
> +  To use this license in source code, put one of the following SPDX
> +  tag/value pairs into a comment according to the placement
> +  guidelines in the licensing rules documentation.
> +  For 'GNU General Public License (GPL) version 2 only' use:
> +SPDX-License-Identifier: GPL-2.0
> +  For 'GNU General Public License (GPL) version 2 or any later version' use:
> +SPDX-License-Identifier: GPL-2.0+
> +License-Text:
> +
> +   GNU GENERAL PUBLIC LICENSE
> +  Version 2, June 1991
> +
> + Copyright (C) 1989, 1991 Free Software Foundation, Inc.
> +   51 Franklin St, Fifth Floor, Boston, MA  02110-1301  
> USA
> + Everyone is permitted to copy and distribute verbatim copies
> + of this license document, but changing it is not allowed.
> +
> +   Preamble
> +
> +  The licenses for most software are designed to take away your
> +freedom to share and change it.  By contrast, the GNU General Public
> +License is intended to guarantee your freedom to share and change free
> +software--to make sure the software is free for all its users.  This
> +General Public License applies to most of the Free Software
> +Foundation's software and to any other program whose authors commit to
> +using it.  (Some other Free Software Foundation software is covered by
> +the GNU Library General Public License instead.)  You can apply it to
> +your programs, too.
> +
> +  When we speak of free software, we are referring to freedom, not
> +price.  Our General Public Licenses are designed to make sure that you
> +have the freedom to distribute copies of free software (and charge for
> +this service if you wish), that you receive source code or can get it
> +if you want it, that you can change the software or use pieces of it
> +in new free programs; and that you know you can do these things.
> +
> +  To protect your rights, we need to make restrictions that forbid
> +anyone to deny you these rights or to ask you to surrender the rights.
> +Th

Re: [patch V5 01/11] Documentation: Add license-rules.rst to describe how to properly identify file licenses

[Philippe Ombredanne]

Thomas,

On Thu, Dec 28, 2017 at 11:17 PM, Thomas Gleixner  wrote:
> On Thu, 28 Dec 2017, Thomas Gleixner wrote:
>
> Sorry for the spam. I somehow missed to refresh the patch before generating
> the mbox. Find below the correct version of that one which has ALL braces
> removed which we don't need.
>
> Thanks,
>
> tglx
>
> 8<--
> Subject: Documentation: Add license-rules.rst to describe how to properly 
> identify file licenses
> From: Thomas Gleixner 
> Date: Fri, 10 Nov 2017 09:30:00 +0100
>
> Add a file to the Documentation directory to describe how file licenses
> should be described in all kernel files, using the SPDX identifier, as well
> as where all licenses should be in the kernel source tree for people to
> refer to (LICENSES/).
>
> Thanks to Kate and Greg for review and editing and Jonas for the
> suggestions concerning the meta tags in the licenses files.
>
> Signed-off-by: Thomas Gleixner 
> Reviewed-by: Jonas Oberg 
> Reviewed-by: Jonathan Corbet 
> Reviewed-by: Philippe Ombredanne 
> Reviewed-by: Kate Stewart 
> Reviewed-by: Greg Kroah-Hartman 
>
> ---
>  Documentation/index.rst |   12 +
>  Documentation/process/license-rules.rst |  370 
> 
>  2 files changed, 382 insertions(+)
>  create mode 100644 Documentation/license-rules.rst
>
> --- a/Documentation/index.rst
> +++ b/Documentation/index.rst
> @@ -13,6 +13,18 @@ documents into a coherent whole.  Please
>  documentation are welcome; join the linux-doc list at vger.kernel.org if
>  you want to help out.
>
> +Licensing documentation
> +---
> +
> +The following describes the license of the Linux kernel source code
> +(GPLv2), how to properly mark the license of individual files in the source
> +tree, as well as links to the full license text.
> +
> +.. toctree::
> +   :maxdepth: 2
> +
> +   process/license-rules.rst
> +
>  User-oriented documentation
>  ---
>
> --- /dev/null
> +++ b/Documentation/process/license-rules.rst
> @@ -0,0 +1,370 @@
> +.. SPDX-License-Identifier: GPL-2.0
> +
> +Linux kernel licensing rules
> +
> +
> +The Linux Kernel is provided under the terms of the GNU General Public
> +License version 2 only (GPL-2.0), as published by the Free Software
> +Foundation, and provided in the COPYING file.  This documentation file is
> +not meant to replace the COPYING file, but provides a description of how
> +each source file should be annotated to make the licensing it is governed
> +under clear and unambiguous.
> +
> +The license in the COPYING file applies to the kernel source as a whole,
> +though individual source files can have a different license which is
> +required to be compatible with the GPL-2.0::
> +
> +GPL-1.0+  :  GNU General Public License v1.0 or later
> +GPL-2.0+  :  GNU General Public License v2.0 or later
> +LGPL-2.0  :  GNU Library General Public License v2 only
> +LGPL-2.0+ :  GNU Library General Public License v2 or later
> +LGPL-2.1  :  GNU Lesser General Public License v2.1 only
> +LGPL-2.1+ :  GNU Lesser General Public License v2.1 or later
> +
> +Aside from that, individual files can be provided under a dual license,
> +e.g. one of the compatible GPL variants and alternatively under a
> +permissive license like BSD, MIT etc.
> +
> +The User-space API (UAPI) header files, which describe the interface of
> +user-space programs to the kernel are a special case.  According to the
> +note in the kernel COPYING file, the syscall interface is a clear boundary,
> +which does not extend the GPL requirements to any software which uses it to
> +communicate with the kernel.  Because the UAPI headers must be includable
> +into any source files which create an executable running on the Linux
> +kernel, the exception must be documented by a special license expression.
> +
> +The common way of expressing the license of a source file is to add the
> +matching boilerplate text into the top comment of the file.  Due to
> +formatting, typos etc. these "boilerplates" are hard to validate for
> +tools which are used in the context of license compliance.
> +
> +An alternative to boilerplate text is the use of Software Package Data
> +Exchange (SPDX) license identifiers in each source file.  SPDX license
> +identifiers are machine parsable and precise shorthands for the license
> +under which the content of the file is contributed.  SPDX license
> +identifiers are managed by the SPDX Workgroup at the Linux Foundation and
> +have been agreed on by partners throughout the industry, tool vendors, and
> +legal teams.  For

Re: [PATCH] ARM: imx: introduce imx_l2c310_write_sec

[Philippe Ombredanne]

Dear Peng,

On Thu, Dec 28, 2017 at 10:35 AM, Peng Fan  wrote:
> Some PL310 registers could only be wrote in secure world, so
> introduce imx_l2c310_write_sec to support Linux running in
> non-secure world.



> --- /dev/null
> +++ b/include/soc/imx/imx_sip_smc.h
> @@ -0,0 +1,23 @@
> +/*
> + * Copyright 2017 NXP
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + */

Do you mind using a simpler SPDX identifier instead of this longer
legalese boilerplate? This is documented in Thomas doc patches.
If you could also spread the word in your team that would be much welcomed.
Thanks!

--
Cordially
Philippe Ombredanne

Re: [PATCH v4 06/15] clk: Add Ingenic jz4770 CGU driver

[Philippe Ombredanne]

Dear Mr Crapouillou-Cercueil-Sir,

On Thu, Dec 28, 2017 at 2:56 PM, Paul Cercueil  wrote:
> Add support for the clocks provided by the CGU in the Ingenic JZ4770
> SoC.



> --- /dev/null
> +++ b/drivers/clk/ingenic/jz4770-cgu.c
> @@ -0,0 +1,487 @@
> +/*
> + * JZ4770 SoC CGU driver
> + *
> + * Copyright 2017, Paul Cercueil 
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 or later
> + * as published by the Free Software Foundation.
> + */

Do you mind using a simpler one-line SPDX identifier instead of this
fine but clearly crapouillish legalese boilerplate? Unless you are
trying to turn the kernel in a legal compendium, of course ;)

This is documented in Thomas doc patches. This would apply to your
entire patch set.
Thank you for your kind consideration!
-- 
Cordially
Philippe Ombredanne

Re: [PATCH v2 6/9] v4l: i2c: Copy ov772x soc_camera sensor driver

[Philippe Ombredanne]

Jacopo,

On Thu, Dec 28, 2017 at 3:01 PM, Jacopo Mondi  wrote:
> Copy the soc_camera based driver in v4l2 sensor driver directory.
> This commit just copies the original file without modifying it.
> No modification to KConfig and Makefile as soc_camera framework
> dependencies need to be removed first in next commit.
>
> Signed-off-by: Jacopo Mondi 
> Acked-by: Laurent Pinchart 
> ---
>  drivers/media/i2c/ov772x.c | 1124 
> 
>  1 file changed, 1124 insertions(+)
>  create mode 100644 drivers/media/i2c/ov772x.c
>
> diff --git a/drivers/media/i2c/ov772x.c b/drivers/media/i2c/ov772x.c
> new file mode 100644
> index 000..8063835
> --- /dev/null
> +++ b/drivers/media/i2c/ov772x.c
> @@ -0,0 +1,1124 @@
> +/*
> + * ov772x Camera Driver
> + *
> + * Copyright (C) 2008 Renesas Solutions Corp.
> + * Kuninori Morimoto 
> + *
> + * Based on ov7670 and soc_camera_platform driver,
> + *
> + * Copyright 2006-7 Jonathan Corbet 
> + * Copyright (C) 2008 Magnus Damm
> + * Copyright (C) 2008, Guennadi Liakhovetski 
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + */

Do you mind using a simpler SPDX identifier instead of this long
legalese boilerplate?
This is documented in Thomas doc patches. This applies to your entire
patch set of course.
Thanks!
-- 
Cordially
Philippe Ombredanne