Am Montag, 18. März 2019, 09:41:28 CET schrieb Colin Ian King:
> On 17/03/2019 23:49, Richard Weinberger wrote:
> > Am Montag, 18. März 2019, 00:09:09 CET schrieb Colin King:
> >> From: Colin Ian King
> >>
> >> The function link_file declaration in the heade
Am Montag, 18. März 2019, 00:09:09 CET schrieb Colin King:
> From: Colin Ian King
>
> The function link_file declaration in the header file has the order
> of the two arguments (from, to) swapped when compared to the definition
> arguments of (to, from). Fix this by swapping them around to match
On Tue, Mar 12, 2019 at 4:14 PM Richard Weinberger wrote:
>
> Linus,
>
> The following changes since commit 1c163f4c7b3f621efff9b28a47abb36f7378d783:
>
> Linux 5.0 (2019-03-03 15:21:29 -0800)
>
> are available in the Git repository at:
>
> git://git.kernel.o
Ted,
Am Freitag, 15. März 2019, 14:51:28 CET schrieb Theodore Ts'o:
> On Fri, Mar 15, 2019 at 08:48:10AM +0100, Richard Weinberger wrote:
> > Ted,
> >
> > Am Freitag, 15. März 2019, 00:07:02 CET schrieb Theodore Ts'o:
> > > Richard --- stepping back
Ted,
Am Freitag, 15. März 2019, 00:07:02 CET schrieb Theodore Ts'o:
> Richard --- stepping back for a moment, in your use case, are you
> assuming that the encryption key is always going to be present while
> the system is running?
it is not a hard requirement, it is something what is common on e
Eric,
Am Donnerstag, 14. März 2019, 18:49:14 CET schrieb Eric Biggers:
> Hi Richard,
>
> On Thu, Mar 14, 2019 at 06:15:59PM +0100, Richard Weinberger wrote:
> > Usually fscrypt allows limited access to encrypted files even
> > if no key is available.
> > Encrypted fi
This series is an RFC, it outlines how an filesystem, in this case UBIFS,
could implement a mount option to disable filesystem operations on encrypted
files where no key is present.
The desired byproduct is that in this case ->d_revalidate() is not needed
anymore and VFS folks are in less fear abou
access is denied with the -ENOKEY error code.
The side benefit of this is that we don't need ->d_revalidate().
Not having ->d_revalidate() makes an encrypted ubifs usable
as overlayfs upper directory.
Signed-off-by: Richard Weinberger
---
fs/ubifs/crypto.c | 2 +-
fs/ubifs/di
fscrypt_get_encryption_info() does not return -ENOKEY,
there is no need to handle this case.
Signed-off-by: Richard Weinberger
---
fs/ubifs/dir.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/ubifs/dir.c b/fs/ubifs/dir.c
index 5767b373a8ff..b0cb913697c5 100644
If a filesystem sets FS_CFLG_OWN_D_OPS it manages dentry operations
itself and fscrypt is not allowed to set them.
Signed-off-by: Richard Weinberger
---
fs/crypto/hooks.c | 4 +++-
include/linux/fscrypt.h | 1 +
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/fs/crypto
If a filesystem manages dentry operations itself it might want to
re-use fscrypt_d_ops.
Signed-off-by: Richard Weinberger
---
fs/crypto/crypto.c | 1 +
fs/crypto/fscrypt_private.h | 1 -
include/linux/fscrypt.h | 1 +
3 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/fs
Am Mittwoch, 13. März 2019, 23:26:11 CET schrieb Eric Biggers:
> On Wed, Mar 13, 2019 at 09:33:10PM +0100, Richard Weinberger wrote:
> > Am Mittwoch, 13. März 2019, 15:26:54 CET schrieb Amir Goldstein:
> > > IMO, the best thing for UBIFS to do would be to modify fscrypt to suppor
Am Mittwoch, 13. März 2019, 15:26:54 CET schrieb Amir Goldstein:
> IMO, the best thing for UBIFS to do would be to modify fscrypt to support
> opting out of the revalidate behavior, IWO, sanitize your hack to an API.
Given the WTF/s rate this thread has, this might me a good option.
Actually peopl
Am Mittwoch, 13. März 2019, 17:13:52 CET schrieb James Bottomley:
> > What do you mean by "containment breaches by other tenants"? Note
> > that while the key is added, fscrypt doesn't prevent access to the
> > encrypted files.
>
> You mean it's not multiuser safe? Even if user a owns the key th
Am Mittwoch, 13. März 2019, 16:16:33 CET schrieb Theodore Ts'o:
> So before we talk about how to make things work from a technical
> perspective, we should consider what the use case happens to be, and
> what are the security requirements. *Why* are we trying to use the
> combination of overlayfs
- Reject unsupported ioctl flags in UBIFS (xfstests found it)
Dan Carpenter (1):
ubi: wl: Silence uninitialized variable warning
Hou Tao (1):
ubifs: Reject unsupported ioctl flags explicitly
Richard Weinberger (2):
ubi
Am Mittwoch, 13. März 2019, 14:24:47 CET schrieb Miklos Szeredi:
> > The use case is that you can delete these files if the DAC/MAC permissions
> > allow it.
> > Just like on NTFS. If a user encrypts files, the admin cannot read them but
> > can
> > remove them if the user is gone or loses the ke
Am Mittwoch, 13. März 2019, 13:58:11 CET schrieb Miklos Szeredi:
> On Wed, Mar 13, 2019 at 1:47 PM Richard Weinberger wrote:
> >
> > Am Mittwoch, 13. März 2019, 13:36:02 CET schrieb Miklos Szeredi:
> > > I don't get it. Does fscrypt try to check permissions via
>
Am Mittwoch, 13. März 2019, 13:36:02 CET schrieb Miklos Szeredi:
> I don't get it. Does fscrypt try to check permissions via
> ->d_revalidate? Why is it not doing that via ->permission()?
Please let me explain. Suppose we have a fscrypto directory /mnt and
I *don't* have the key.
When reading
Hi!
overlayfs and fscrypt are not friends.
Currently it is not possible to use a fscrypt encrypted directory as upper
directory with overlayfs.
The reason for that is, fscrypt implements ->d_revalidate().
>From fscrypt's point of view having ->d_revalidate() makes sense because it
wants to hide
Am Mittwoch, 13. März 2019, 00:40:33 CET schrieb Linus Torvalds:
> On Tue, Mar 12, 2019 at 3:18 PM Linus Torvalds
> wrote:
> >
> > On Tue, Mar 12, 2019 at 8:13 AM Richard Weinberger wrote:
> > >
> > > git://git.infradead.org/linux-ubifs.git tags/upstream-5
ioctl flags in UBIFS (xfstests found it)
Dan Carpenter (1):
ubi: wl: Silence uninitialized variable warning
Hou Tao (1):
ubifs: Reject unsupported ioctl flags explicitly
Richard Weinberger (2):
ubi: Introduce in_pq
Linus,
The following changes since commit 1c163f4c7b3f621efff9b28a47abb36f7378d783:
Linux 5.0 (2019-03-03 15:21:29 -0800)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/rw/uml.git for-linus-5.1-rc1
for you to fetch changes up to aea05eb56e47046de1e5b5
Am Mittwoch, 6. März 2019, 19:32:44 CET schrieb Enrico Weigelt, metux IT
consult:
Here please also a changelog. :-)
Thanks,
//richard
> Signed-off-by: Enrico Weigelt, metux IT consult
> ---
> arch/um/drivers/Kconfig | 352
>
> 1 file changed,
Am Mittwoch, 6. März 2019, 19:28:17 CET schrieb Enrico Weigelt, metux IT
consult:
Can we please have a changelog?
Thanks,
//richard
> Signed-off-by: Enrico Weigelt, metux IT consult
> ---
> arch/um/Kconfig | 52 ++--
> 1 file changed, 26 inserti
nsidering how even the toolchains cannot create a.out
> executables in its default configuration, let's deprecate a.out support
> and remove it a couple of releases later, instead.
>
> Signed-off-by: Borislav Petkov
> Cc: Al Viro
> Cc: Anton Ivanov
> Cc: Jann Horn
Am Freitag, 1. März 2019, 22:38:18 CET schrieb Gustavo A. R. Silva:
> Hi all,
>
> Friendly ping:
>
> Who can take this, please?
/me points to Miquel. :)
Thanks,
//richard
Am Mittwoch, 27. Februar 2019, 06:46:35 CET schrieb YueHaibing:
>
> Friendly ping:
>
> Who can take this, please?
The winner takes it all. ;-)
Just kidding, Anton and I take care.
Thanks,
//richard
On Sun, Feb 24, 2019 at 4:38 PM Bharath Vedartham wrote:
> I understand. I am starting out kernel hacking. I have been working on
> fixing checkpatch.pl warnings. If you have any tasks for me in the
> kernel, it would be great.
>
> I have also noticed a lot of warnings to replace printk with subsy
Am Samstag, 16. Februar 2019, 09:53:35 CET schrieb yuyufen:
> ping?
Sorry for the delay.
I didn't forget (completely) about this one.
The thing is, I don't really maintain jffs2 but I will collect and test patches
for the upcoming merge window and carry them via my ubifs tree.
David, I hope I h
[CC'in relevant folks]
On Thu, Feb 14, 2019 at 12:19 AM Samuel Dionne-Riel
wrote:
>
> Hi,
>
> I am posting as a representative of the NixOS Linux distribution,
> about a userspace regression on 5.0-rc* which recently was backported
> to the 4.14.99, 4.19.21 and 4.20.8 current LTS and stable versi
On Wed, Jan 30, 2019 at 3:49 PM Luis Chamberlain wrote:
>
> On Mon, Jan 28, 2019 at 10:05:45AM -0800, Andrew Morton wrote:
> > On Mon, 28 Jan 2019 09:49:59 +0100 Vincent Whitchurch
> > wrote:
> > > --- a/init/Kconfig
> > > +++ b/init/Kconfig
> > > @@ -1242,6 +1242,20 @@ config SYSCTL_SYSCALL
> >
Am Montag, 21. Januar 2019, 09:59:10 CET schrieb yang.yan...@zte.com.cn:
> Thanks for reply.
> But I think if (*dstlen < 2) is not good enough.
Not enough in terms of what?
My patch does what the commit message says, it fixes the out of bound access.
What do I miss?
> Because if the length of da
On Mon, Jan 21, 2019 at 1:21 AM Yang Yang wrote:
>
> KASAN reports a BUG when download file in jffs2 filesystem.
> The board name is nxp-ls1043ardb-ls1043a.
> It is because when dstlen == 1, cpage_out will write array out of bounds.
> Actually, there's no meaning for jffs2_zlib_compress() to compr
Am Freitag, 18. Januar 2019, 21:00:22 CET schrieb Anton Ivanov:
> >> Hi Sabyasachi,
> >>
> >> I believe we have an identical patch enqueued already from a couple of
> >> weeks back.
> >
> > Hmm, did I miss that one in patchwork?
> >
> > Thanks,
> > //richard
> >
> >
> >
> > ___
Am Freitag, 18. Januar 2019, 20:23:07 CET schrieb Anton Ivanov:
>
> On 18/01/2019 14:58, Sabyasachi Gupta wrote:
> > Remove sys/socket.h and sys/uio.h which are included more than once
> >
> > Signed-off-by: Sabyasachi Gupta
> > ---
> > arch/um/drivers/vector_user.c | 2 --
> > 1 file changed
+14081,7 @@ F:arch/arm/mach-spear/
>
> SPI NOR SUBSYSTEM
> M: Marek Vasut
> +M: Tudor Ambarus
> L: linux-...@lists.infradead.org
> W: http://www.linux-mtd.infradead.org/
> Q: http://patchwork.ozlabs.org/project/linux-mtd/list/
Nice to have you on board! :-)
Acked-by: Richard Weinberger
Thanks,
//richard
Am Montag, 14. Januar 2019, 16:17:09 CET schrieb Pali Rohár:
> On Tuesday 08 January 2019 16:39:04 Richard Weinberger wrote:
> > Am Dienstag, 8. Januar 2019, 16:32:55 CET schrieb Andy Shevchenko:
> > > On Fri, Dec 28, 2018 at 12:18 AM Pali Rohár wrote:
> > > > On Mo
Am Dienstag, 8. Januar 2019, 16:32:55 CET schrieb Andy Shevchenko:
> On Fri, Dec 28, 2018 at 12:18 AM Pali Rohár wrote:
> > On Monday 17 December 2018 10:50:04 Pali Rohár wrote:
> > > On Wednesday 12 December 2018 14:57:36 Pali Rohár wrote:
>
> > > Thanks for review of #94! As next you can take #
Flush TLB for force/fork case
Add Anton Ivanov to UML maintainers
um: Remove obsolete reenable_XX calls
Christoph Hellwig (1):
um: writev needs
Hernán Gonzalez (1):
um: Add HAVE_DEBUG_BUGVERBOSE
Masahiro Yamada (1):
um: remove redundant generic-y
Richard Wei
Am Dienstag, 25. Dezember 2018, 03:42:37 CET schrieb zhangjun:
> Hello,richard
>
>
> Before fully understanding this regression, in order to fix the bug of
> cma_alloc(),
> submit a conservative patch that modifies count in iomap_migrate_page().
> Can you consider merging first?
No. There is no
On Fri, Dec 21, 2018 at 9:58 AM Christoph Hellwig wrote:
>
> On Thu, Dec 20, 2018 at 05:01:58PM -0500, Theodore Y. Ts'o wrote:
> > That's simply not true. Number one, fsverity is not mandatory for all
> > file systems to implement. If XFS doesn't want to implement fscrypt
> > or fsverity, it doe
Am Samstag, 15. Dezember 2018, 16:01:30 CET schrieb Richard Weinberger:
> The page migration code assumes that a page with PG_private
> set has its page count elevated by 1.
> UBIFS never did this and therefore the migration code was unable
> to migrate some pages owned by UBIFS.
&
used
ubi: Do not drop UBI device reference before using
Richard Weinberger (1):
ubifs: Handle re-linking of inodes correctly while recovery
drivers/mtd/ubi/build.c | 2 +-
drivers/mtd/ubi/kapi.c | 2 +-
fs/ubifs/Kconfig| 16 +--
fs/ubifs/lpt.c | 12
Am Donnerstag, 20. Dezember 2018, 11:43:08 CET schrieb Hou Tao:
>
> On 2018/12/16 0:23, Richard Weinberger wrote:
> > The rtime compressor assumes that at least two bytes are
> > compressed.
> > If we try to compress just one byte, the loop condition will
> > wr
Am Montag, 17. Dezember 2018, 11:59:44 CET schrieb Kirill A. Shutemov:
> On Sat, Dec 15, 2018 at 04:01:30PM +0100, Richard Weinberger wrote:
> > The page migration code assumes that a page with PG_private
> > set has its page count elevated by 1.
> > UBIFS never did t
0x11e0
> worker_thread+0x8f/0xfe0
> kthread+0x2ae/0x3a0
> ret_from_fork+0x35/0x40
>
> Fix the problem by checking the validity of wbuf_verify before
> using it in jffs2_verify_write().
>
> Cc: sta...@vger.kernel.org
> Fixes: 0029da3bf430 ("JFFS2: add
The rtime compressor assumes that at least two bytes are
compressed.
If we try to compress just one byte, the loop condition will
wrap around and an out-of-bounds write happens.
Cc:
Signed-off-by: Richard Weinberger
---
fs/jffs2/compr_rtime.c | 3 +++
1 file changed, 3 insertions(+)
diff
using get/put_page when changing PG_private.
Cc:
Cc: zhangjun
Fixes: 4ac1c17b2044 ("UBIFS: Implement ->migratepage()")
Reported-by: zhangjun
Signed-off-by: Richard Weinberger
---
zhangjun,
Please give this patch a try!
Thanks,
//richard
---
fs/ubifs/file.c | 7 +++
1 fi
On Sat, Dec 15, 2018 at 2:23 PM Hou Tao wrote:
>
> ping ?
Sorry for the delay.
I'll try now to review all the pending jffs2 patches.
> On 2018/12/9 14:21, Hou Tao wrote:
> > For xattr modification, we do not write a new jffs2_raw_xref with
> > delete marker into flash, so if a xattr is modified
Am Samstag, 15. Dezember 2018, 11:51:12 CET schrieb Christoph Hellwig:
> FYI, for iomap we got a patch to just increment the page count when
> setting the private data, and it finally got merged into mainline after
> a while.
>
> Not that it totally makes sense to me, but it is what it is. It wou
dlers: Simplify list operation")
Signed-off-by: Richard Weinberger
---
Andreas,
since you maintain the attr package too, I report it right here. :-)
This jffs2 bug lead to a crash in attr_list().
for() will loop to crash when there is no trailing \0 in the
list of xattrs.
for (l = lbuf;
Am Freitag, 14. Dezember 2018, 15:38:53 CET schrieb David Laight:
> From: Richard Weinberger
> > Sent: 13 December 2018 09:05
> > On Thu, Dec 13, 2018 at 6:03 AM Kevin Easton wrote:
> > >
> > > On Tue, Dec 11, 2018 at 11:29:14AM +0100, John Paul Adrian Glaubitz
[CC'ing Kees]
On Wed, Dec 12, 2018 at 1:37 PM Markus F.X.J. Oberhumer
wrote:
>
> I still claim that (0xf000, 4096) is not a valid C "pointer
> to an object" according to the C standard - please see my reply below.
>
> And I thought ASLR was introduced to improve security and not to cr
Am Freitag, 14. Dezember 2018, 13:26:28 CET schrieb Gao Xiang:
> Hi Richard,
>
> On 2018/12/14 19:25, Richard Weinberger wrote:
> > This is the third place which needs this workaround.
> > UBIFS, F2FS, and now iomap.
> >
> > I agree with Dave that nobody can
[CC'ing authors of the code plus mm folks]
Am Freitag, 14. Dezember 2018, 06:56:01 CET schrieb zhangjun:
> IOMAP uses PG_private a little different with buffer_head based
> filesystem.
> It uses it as marker and when set, the page counter is not incremented,
> migrate_page_move_mapping() assumes t
Am Donnerstag, 13. Dezember 2018, 23:00:00 CET schrieb Kirill A. Shutemov:
> > Let's wait a few days to give Kirill a chance to review, then I'll apply
> > the patch.
>
> I don't remmeber much context now...
>
> Could you remind me why ubifs doesn't take additional pin when sets
> PG_private?
B
On Sun, Dec 9, 2018 at 7:52 AM Boris Brezillon
wrote:
>
> On Sat, 20 Oct 2018 19:07:53 +0800
> Hou Tao wrote:
>
> > When jffs2_xattr_ref is dead, xref->ic or xref->xd will be invalid
> > because these fields will be reused as xref->ino or xref->xid,
> > so access xref->ic->ino or xref->xd->xid wi
Am Donnerstag, 13. Dezember 2018, 20:20:17 CET schrieb zhangjun:
> Because the PagePrivate() in UBIFS is different meanings,
...has different meanings...
I'll fix up that myself after applying your patch. No need to send a v3.
> alloc_cma() will fail when one dirty page cache located in
> the ty
Hello zhangjun,
thanks a lot for bringing this up!
Am Mittwoch, 12. Dezember 2018, 15:13:57 CET schrieb zhangjun:
> Because the PagePrivate() in UBIFS is different meanings,
> alloc_cma() will fail when one dirty page cache located in
> the type of MIGRATE_CMA
>
> If not adjust the 'extra_count'
On Thu, Dec 13, 2018 at 6:03 AM Kevin Easton wrote:
>
> On Tue, Dec 11, 2018 at 11:29:14AM +0100, John Paul Adrian Glaubitz wrote:
> ...
> > I can't say anything about the syscall interface. However, what I do know
> > is that the weird combination of a 32-bit userland with a 64-bit kernel
> > int
Am Dienstag, 11. Dezember 2018, 20:08:30 CET schrieb Nick Desaulniers:
> > But in this particular case, DKIM is pretty good spam protection
> > mechanism so enabling it is a good idea.
>
> Internal Gmail developers were able to help me verify that SPF was
> setup correctly, but indeed there's no D
r flag
> >
> > GNU linker's -z common-page-size's default value is based on the target
> > architecture. arch/x86/um/vdso/Makefile sets it to the architecture
> > default, which is implicit and redundant. Drop it so that one more LLVM
> > build issue gets add
.so.1 \
> - -Wl,-z,max-page-size=4096 -Wl,-z,common-page-size=4096
> + -Wl,-z,max-page-size=4096
Acked-by: Richard Weinberger
Thanks,
//richard
Am Samstag, 8. Dezember 2018, 07:35:47 CET schrieb Masahiro Yamada:
> x86 maintainers,
>
>
> Ping.
I thought you carry this via your kbuild tree.
That said, I can merge it also via the um tree.
x86 is of course also fine. :-)
>
>
> On Tue, Nov 13, 2018 at 6:48 PM Rich
On Sun, Dec 2, 2018 at 9:09 PM Greg KH wrote:
>
> On Sun, Dec 02, 2018 at 08:10:16AM -0800, Christoph Hellwig wrote:
> > As someone who has done xfs stable backports for a while I really don't
> > think the autoselection is helpful at all.
>
> autoselection for xfs patches has been turned off for
Sasha,
Am Sonntag, 2. Dezember 2018, 15:35:43 CET schrieb Sasha Levin:
> On Sun, Dec 02, 2018 at 11:50:33AM +, Sudip Mukherjee wrote:
> >> > Now queued up for 4.14.y, thanks.
> >>
> >> can you *please* slow a little down?
> >
> >True. It will really help if you can have some sort of fixed sche
Greg,
Am Donnerstag, 29. November 2018, 09:09:23 CET schrieb Greg KH:
> On Mon, Nov 26, 2018 at 11:38:42AM +0100, Martin Kepplinger wrote:
> > From: Richard Weinberger
> >
> > [ Upstream commit 34653fd8c46e771585fce5975e4243f8fd401914 ]
> >
> > This co
On Fri, Nov 30, 2018 at 8:28 PM Jarkko Sakkinen
wrote:
>
> In order to comply with the CoC, replace with a hug.
Please explain in detail why the CoC forces us to avoid this word.
Your patch seems more like self-censorship.
--
Thanks,
//richard
On Sat, Nov 24, 2018 at 4:32 PM Daniel Santos wrote:
>
> Ping 2!
>
> On 11/05/2018 03:38 PM, Daniel Santos wrote:
> > Ping.
> >
> > Daniel
> >
> > On 10/21/2018 07:32 PM, Hou Tao wrote:
> >> On 2018/10/19 16:30, Daniel Santos wrote:
> >>> jffs2_sync_fs makes the assumption that if CONFIG_JFFS2_FS_
Am Donnerstag, 15. November 2018, 21:38:50 CET schrieb Garry McNulty:
> If the call to ubifs_read_nnode() fails in ubifs_lpt_calc_hash() an
> error is returned without freeing the memory allocated to 'buf'.
> Jump to 'out' label to free allocated memory and return the error code.
>
> Detected by C
Am Donnerstag, 8. November 2018, 15:26:42 CET schrieb Boris Brezillon:
> On Wed, 7 Nov 2018 23:16:19 +0100
> Richard Weinberger wrote:
>
> > +/**
> > + * ubi_bitflip_check - Check an eraseblock for bitflips and scrub it if
> > needed.
> > + * @ubi: UBI device
Using UBI_IOCRPEB and UBI_IOCSPEB userspace can force
reading and scrubbing of PEBs.
In case of bitflips UBI will automatically take action
and move data to a different PEB.
This interface allows a daemon to foster your NAND.
Signed-off-by: Richard Weinberger
---
drivers/mtd/ubi/cdev.c
This function works like in_wl_tree() but checks whether an ubi_wl_entry
is currently in the protection queue.
We need this function to query the current state of an ubi_wl_entry.
Signed-off-by: Richard Weinberger
---
drivers/mtd/ubi/wl.c | 30 +++---
1 file changed, 23
org
Cc: Russell Senior
Cc: Rafał Miłecki
Reported-by: Russell Senior
Reported-by: Rafał Miłecki
Signed-off-by: Richard Weinberger
---
fs/ubifs/replay.c | 37 +
1 file changed, 37 insertions(+)
diff --git a/fs/ubifs/replay.c b/fs/ubifs/replay.c
ind
On Wed, Nov 7, 2018 at 9:07 AM Sascha Hauer wrote:
>
> On Mon, Nov 05, 2018 at 09:25:40AM +0100, Geert Uytterhoeven wrote:
> > Instead of adding yet another dependency on UBIFS_FS, wrap the whole
> > block of ubifs config options in a single "if UBIFS_FS".
> >
> > Fixes: d8a22773a12c6d78 ("ubifs:
On Wed, Nov 7, 2018 at 7:05 PM Nikunj Kela (nkela) wrote:
> I had tried to use configs to start with via the following patch however I
> was advised to have a mount option:
> http://lists.infradead.org/pipermail/linux-mtd/2018-November/085126.html
Just show performance numbers on how your implem
Am Sonntag, 4. November 2018, 23:45:50 CET schrieb Linus Torvalds:
> On Sun, Nov 4, 2018 at 11:25 AM Richard Weinberger
> wrote:
> >
> > I'm sorry to pester you a second time.
> > The first ping had you only in CC,
> > let's hope this mail passes your spam
Am Freitag, 2. November 2018, 22:14:44 CET schrieb Daniel Walker:
> > Make it a mount option and store the endianness mode in the super block.
>
> It's actually a mkfs option currently. I'm not sure how that factors in,
>
> from the mkfs.jffs2 man page,
>
>-l, --little-endian
>
Am Freitag, 2. November 2018, 16:39:24 CET schrieb Arnd Bergmann:
> Having two shash descriptors on the stack cause a very significant kernel
> stack usage that can cross the warning threshold:
>
> fs/ubifs/replay.c: In function 'authenticate_sleb':
> fs/ubifs/replay.c:633:1: error: the frame size
On Fri, Nov 2, 2018 at 3:04 PM Daniel Walker wrote:
> Do you have any thought on how to implement it ? I was think abstracting the
> endian functions in the nodelist.h
Yes, see what UFS does.
> static inline jint16_t cpu_to_je16(jint16_t x) {
> if (check_big_endian()) {
>
Am Freitag, 2. November 2018, 12:11:22 CET schrieb Arnd Bergmann:
> The new authentication support causes a build failure
> when CONFIG_KEYS is disabled, so add a dependency.
>
> fs/ubifs/auth.c: In function 'ubifs_init_authentication':
> fs/ubifs/auth.c:249:16: error: implicit declaration of func
On Fri, Nov 2, 2018 at 9:46 AM Joakim Tjernlund
wrote:
>
> On Thu, 2018-11-01 at 15:56 -0700, Nikunj Kela wrote:
> > CAUTION: This email originated from outside of the organization. Do not
> > click links or open attachments unless you recognize the sender and know
> > the content is safe.
> >
>
Linus,
On Wed, Oct 31, 2018 at 10:22 PM Richard Weinberger wrote:
> The following changes since commit 84df9525b0c27f3ebc2ebb1864fa62a97fdedb7d:
>
> Linux 4.19 (2018-10-22 07:37:37 +0100)
>
> are available in the Git repository at:
>
> git://git.infradead.org/linu
- Remove stale fs/hppfs/ reference
- Point to our patchwork queue
Signed-off-by: Richard Weinberger
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index b91bbec94f98..3779bbab1715 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
Am Donnerstag, 1. November 2018, 09:55:53 CET schrieb Rafał Miłecki:
> On Sun, 28 Oct 2018 at 22:44, Richard Weinberger wrote:
> > UBIFS's recovery code strictly assumes that a deleted inode will never
> > come back, therefore it removes all data which belongs to that inode
Am Mittwoch, 31. Oktober 2018, 23:48:07 CET schrieb Linus Torvalds:
> On Wed, Oct 31, 2018 at 2:22 PM Richard Weinberger wrote:
> >
> > - Removal of old and dead code
> > - A bug fix for our tty driver
> > - Other minor cleanups across the code base
>
> Pulled. I
base
Anton Ivanov (1):
um: Make line/tty semantics use true write IRQ
Christoph Hellwig (1):
um: remove unused AIO code
Colin Ian King (1):
um: trap: fix spelling mistake, EACCESS -> EACCES
Richard Weinberger (3):
um: Drop own defin
Linus,
The following changes since commit 84df9525b0c27f3ebc2ebb1864fa62a97fdedb7d:
Linux 4.19 (2018-10-22 07:37:37 +0100)
are available in the Git repository at:
git://git.infradead.org/linux-ubifs.git tags/tags/upstream-4.20-rc1
for you to fetch changes up to 84db119f5a83e1bf9cffbc6d9cf1
Am Dienstag, 30. Oktober 2018, 00:21:46 CET schrieb Colin King:
> From: Colin Ian King
>
> Currently a failure when calling ubifs_read_nnode results in a leak
> of desc and buf because of a direct return. Fix this by exiting via
> label 'out' that performs the necessary free'ing of the resources.
org
Reported-by: Russell Senior
Reported-by: Rafał Miłecki
Signed-off-by: Richard Weinberger
---
Russel, Rafał,
please give this patch another testing.
I'll also run it on different test systems before merging.
Thanks,
//richard
---
fs/ubifs/replay.c | 33 +
From: Christoph Hellwig
There is no good reason to create a scatterlist in the ubd driver,
it can just iterate the request directly.
Signed-off-by: Christoph Hellwig
[rw: Folded in improvements as discussed with hch and jens]
Signed-off-by: Richard Weinberger
---
arch/um/drivers/ubd_kern.c
Joe,
On Sat, Sep 29, 2018 at 12:06 AM Joe Perches wrote:
>
> Please fix this defect appropriately.
Care to send a patch?
--
Thanks,
//richard
int jffs2_fill_super(struct super_block *sb,
> > void *data, int silent)
> > sb->s_fs_info = c;
> >
> > ret = jffs2_parse_options(c, data);
> > - if (ret) {
> > - kfree(c);
> > + if (ret)
> > return -EINVAL;
> > - }
Reviewed-by: Richard Weinberger
We can carry this via the MTD tree.
--
Thanks,
//richard
Randy,
On Sat, Oct 13, 2018 at 3:48 AM Randy Dunlap wrote:
>
> Hi,
>
> Linux 4.19-rc7, x86_64 laptop.
>
> I don't have an ubifs filesystem. When I just modprobe ubifs and then
> rmmod ubifs, I get 2 WARNINGs from these 2 lines:
>
> static void __exit ubifs_exit(void)
> {
> WARN_ON(list_e
n two ubifs_assert() into a WARN_ON()")
Signed-off-by: Richard Weinberger
---
Greg,
can you please take this patch directly?
It fixes a brown paper bug which was introduced in rc1, I'd like to avoid
having it in a release and going the -stable path.
Thanks,
//richard
---
fs/ubifs/super.c |
Sasha,
Am Freitag, 5. Oktober 2018, 18:17:50 CEST schrieb Sasha Levin:
> From: Richard Weinberger
>
> [ Upstream commit 37f31b6ca4311b94d985fb398a72e5399ad57925 ]
>
> The requested device name can be NULL or an empty string.
> Check for that and refuse to continue. UB
index cc02050fd0c4..523cb36b72eb 100644
> --- a/kernel/sysctl.c
> +++ b/kernel/sysctl.c
> @@ -66,7 +66,6 @@
> #include
> #include
> #include
> -#include
>
> #include
> #include
Reviewed-by: Richard Weinberger
--
Thanks,
//richard
On Mon, Oct 1, 2018 at 10:01 PM Andreas Dilger wrote:
> If the current dosfstools maintainer is non-responsive, you could always
> fork the project in GitHub, land the critical patches into your branch,
> and make a release on your own. If the maintainer surfaces again, then
> they can pull in y
Am Dienstag, 25. September 2018, 02:09:20 CEST schrieb Diego Viola:
> > Diego, I know you can do better. :-)
> > How about running linux-next and hunting down regressions?
> > I think we suggested this already on IRC.
>
> OK. I'll do that after I'm done with the documentation.
By the definition o
301 - 400 of 2394 matches
Mail list logo
