Re: [PATCH v11 01/27] clk: davinci: pll: allow dev == NULL

ay(n_clks, sizeof(*clks), GFP_KERNEL); > if (!clks) > return -ENOMEM; This should be: if (!clks) { kfree(clk_data); return -ENOMEM; } With that fixed: Reviewed-by: Sekhar Nori <nsek...@ti.com> Thanks, Sekhar

Re: [RFC PATCH 5/6] arm64: dts: ti: Add Support for AM654 SoC

Hi Tony, On Friday 15 June 2018 10:31 AM, Tony Lindgren wrote: > * Nishanth Menon [180614 13:07]: >> On 12:38-20180614, Tony Lindgren wrote: >> From A53 view, a more accurate view might be - from an interconnect >> view of the world (still simplified - i have ignored the sub bus >> segments in

Re: [RFC PATCH 3/6] serial: 8250_omap: Add support for AM654 UART controller

; support and control paths. Introduce a base definition that allows us >> to build up the differences in follow on patches. >> >> Cc: Sekhar Nori >> Cc: Vignesh R >> Signed-off-by: Nishanth Menon >> --- >> Documentation/devicetree/bindings/seria

Re: [PATCH v11 00/27] ARM: davinci: convert to common clock framework​

Hi David, On Sunday 17 June 2018 09:18 PM, David Lechner wrote: > Hi Sekhar, > > On 05/22/2018 04:38 AM, Sekhar Nori wrote: >> Hi David, >> >> On Friday 18 May 2018 10:18 PM, David Lechner wrote: >>> This series converts mach-davinci to use the common clock

Re: [PATCH 0/9] clk: davinci: outstanding fixes

On Thursday 31 May 2018 01:39 AM, Michael Turquette wrote: > Hi David, > > Quoting David Lechner (2018-05-25 11:11:41) >> This is a resend of all of the outstanding DaVinci clock patches plus one new >> patch. All of the patches (except the new one) have been reviewed and tested >> by someone

[PATCH] gpio: davinci: fix build warning when !CONFIG_OF

) ^~ Signed-off-by: Sekhar Nori --- drivers/gpio/gpio-davinci.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c index 987126c4c6f6..b574ecff7761 100644 --- a/drivers/gpio/gpio-davinci.c +++ b/drivers/gpio/gpio-davinci.c

Re: [PATCH 9/9] clk: davinci: Fix link errors when not all SoCs are enabled

On Friday 25 May 2018 11:41 PM, David Lechner wrote: > This fixes linker errors due to undefined symbols when one or more of > the TI DaVinci SoCs is not enabled in the kernel config. > > Signed-off-by: David Lechner > --- > drivers/clk/davinci/pll.c | 16

Re: [PATCH v7 3/4] ARM: davinci: dts: make psc0 a reset provider

On Thursday 21 June 2018 01:07 PM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > The psc driver registers with the reset framework as a provider. Add > the #reset-cells property to the psc0 node. > > Signed-off-by: Bartosz Golaszewski > Reviewed-by: David Lechner Applied to

Re: [PATCH v7 4/4] ARM: davinci: dts: add a reset control to the dsp node

On Thursday 21 June 2018 01:07 PM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > The davinci-rproc driver will soon use the reset framework. Add the > resets property to the dsp node in da850.dtsi. > > Signed-off-by: Bartosz Golaszewski > Reviewed-by: David Lechner > --- >

Re: [PATCH v7 0/4] ARM: davinci: complete the conversion to using the reset framework

Hi Bjorn, On Thursday 21 June 2018 05:11 PM, Bartosz Golaszewski wrote: > 2018-06-21 12:52 GMT+02:00 Sekhar Nori : >> Hi Bartosz, >> >> On Thursday 21 June 2018 01:07 PM, Bartosz Golaszewski wrote: >>> From: Bartosz Golaszewski >>> >>> These are th

Re: [PATCH v3 00/13] ARM: davinci: remove duplicate aemif support

Hi David, Stephen, On Thursday 28 June 2018 03:27 PM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > This series moves all aemif/nand users to using the ti-aemif platform > driver located in drivers/memory instead of the older API located in > mach-davinci. > > First five patches

Re: [PATCH 1/2] ARM: dts: da850-lego-ev3: Add Bluetooth nodes

On Friday 01 June 2018 01:55 AM, David Lechner wrote: > This adds nodes for describing the Bluetooth chip and connections on > LEGO MINDSTORMS EV3 to da850-lego-ev3.dts. > > Signed-off-by: David Lechner Applied for v4.19. Thanks, Sekhar

Re: [PATCH v11 00/27] ARM: davinci: convert to common clock framework​

On Friday 25 May 2018 11:51 PM, David Lechner wrote: > On 05/22/2018 04:38 AM, Sekhar Nori wrote: >> Hi David, >> >> On Friday 18 May 2018 10:18 PM, David Lechner wrote: >>> This series converts mach-davinci to use the common clock framework. >>> >>>

Re: [PATCH v2 06/13] ARM: davinci: omapl138-hawk: add aemif & nand support

On Tuesday 26 June 2018 02:55 PM, Bartosz Golaszewski wrote: > arch/arm/mach-davinci/board-omapl138-hawk.c | 132 > 1 file changed, 132 insertions(+) > > diff --git a/arch/arm/mach-davinci/board-omapl138-hawk.c > b/arch/arm/mach-davinci/board-omapl138-hawk.c > index

Re: [PATCH v2 04/13] clk: davinci: psc-dm646x: use two lookup entries for the aemif clock

On Wednesday 27 June 2018 03:33 PM, Bartosz Golaszewski wrote: > 2018-06-27 12:01 GMT+02:00 Sekhar Nori : >> On Tuesday 26 June 2018 02:55 PM, Bartosz Golaszewski wrote: >>> From: Bartosz Golaszewski >>> >>> We want to be able to get the clock both from the b

Re: [PATCH] ARM: dts: da850: Add power-domains to PWM nodes

On Tuesday 26 June 2018 08:58 PM, David Lechner wrote: > This adds the power-domains property to both the ECAP and EHRPWM PWM > nodes. Both have drivers that use pm_runtime to enable the clocks, so > they need this property in order to find and enable the clock properly. > > Signed-off-by: David

Re: [PATCH v2 04/13] clk: davinci: psc-dm646x: use two lookup entries for the aemif clock

On Tuesday 26 June 2018 02:55 PM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > We want to be able to get the clock both from the board file by its > con_id and from the aemif driver by dev_id. > > Signed-off-by: Bartosz Golaszewski I see the DM365 and DM644x EVM board files

Re: [PATCH 2/2] ARM: davinci_all_defconfig: Enable Bluetooth

On Friday 01 June 2018 01:55 AM, David Lechner wrote: > This enables Bluetooth modules in davinic_all_defconfig needed for LEGO davinci_all_defconfig > MINDSTORMS EV3. > > Signed-off-by: David Lechner > --- > arch/arm/configs/davinci_all_defconfig | 9 + > 1 file changed, 9

Re: [RESEND (again) PATCH] clkdev: don't call __of_clk_get_by_name() unnecessarily from clk_get()

; It was not obvious at first glance how clk_get(dev, NULL) will work in >> board-file mode since we always call __of_clk_get_by_name(). Let's make >> it clearer by checking if of_node is NULL and skipping right to >> clk_get_sys(). >> >> Cc: Sekhar Nori >> Cc: Kevin Hi

Re: [PATCH v2] ARM: dts: da850: Fix interrups property for gpio

On Tuesday 05 June 2018 03:37 PM, Keerthy wrote: > The intc #interrupt-cells is equal to 1. Currently gpio > node has 2 cells per IRQ which is wrong. Remove the additional > cell for each of the interrupts. > > Signed-off-by: Keerthy > Fixes: 2e38b946dc54 ("ARM: davinci: da850: add GPIO DT

Re: [PATCH v7 0/4] ARM: davinci: complete the conversion to using the reset framework

On Monday 02 July 2018 08:57 PM, David Lechner wrote: > On 07/02/2018 07:08 AM, Sekhar Nori wrote: >> Hi Bjorn, >> >> On Thursday 21 June 2018 05:11 PM, Bartosz Golaszewski wrote: >>> 2018-06-21 12:52 GMT+02:00 Sekhar Nori : >>>> Hi Bartosz, >>&g

Re: [PATCH v9 24/27] dt-bindings: timer: new bindings for TI DaVinci timer

On Wednesday 02 May 2018 07:22 AM, David Lechner wrote: > Sekhar, > > On 04/27/2018 09:05 AM, Rob Herring wrote: >> On Thu, Apr 26, 2018 at 07:17:42PM -0500, David Lechner wrote: >>> This adds new device tree bindings for the timer IP block of TI >>> DaVinci-like SoCs. >>> >>> Signed-off-by:

Re: [PATCH] arm: dts: am437x-sk-evm: add wilink8 support

On Tuesday 01 May 2018 12:54 PM, Eyal Reizer wrote: > enable mmc3 used for wlan and uart1 used for bluetooth > configure the gpios used for wlan and bluetooth controls > add fixed voltage regulator used for wlan power control > > Signed-off-by: Eyal Reizer ARM should be

Re: [PATCH 01/12] mtd: nand: davinci: store the core chipselect number in platform data

On Wednesday 02 May 2018 04:15 PM, Bartosz Golaszewski wrote: > 2018-05-01 12:29 GMT+02:00 Sekhar Nori <nsek...@ti.com>: >> On Tuesday 01 May 2018 03:23 PM, Sekhar Nori wrote: >>> On Tuesday 01 May 2018 02:55 PM, Sekhar Nori wrote: >>>> On Monday 30 April 2018

Re: [PATCH v9 03/27] clk: davinci: psc: allow for dev == NULL

On Wednesday 02 May 2018 07:19 AM, David Lechner wrote: > On 05/01/2018 09:02 AM, Sekhar Nori wrote: >> On Friday 27 April 2018 05:47 AM, David Lechner wrote: >>> +static inline void *_devm_kzalloc(struct device *dev, size_t size, >>> gfp_t flags) >>> +{ &

Re: [PATCH v9 05/27] ARM: davinci: da830: add new clock init using common clock framework

; > Also clean up the #includes since we are adding some here. > > Signed-off-by: David Lechner <da...@lechnology.com> Reviewed-by: Sekhar Nori <nsek...@ti.com> Thanks, Sekhar

Re: [PATCH v9 06/27] ARM: davinci: da850: add new clock init using common clock framework

; > Also clean up the #includes since we are adding some here. > > Some CFGCHIP macros were removed because we are now including > linux/mfd/da8xx-cfgchip.h which defines the same values. > > Signed-off-by: David Lechner <da...@lechnology.com> Reviewed-by: Sekhar Nori <nsek...@ti.com> Thanks, Sekhar

Re: [PATCH v9 00/27] ARM: davinci: convert to common clock framework​

On Friday 27 April 2018 05:47 AM, David Lechner wrote: > This series converts mach-davinci to use the common clock framework. > > The series works like this, the first 3 patches fix some issues with the clock > drivers that have already been accepted into the mainline kernel. > > Then, starting

Re: [PATCH 01/12] mtd: nand: davinci: store the core chipselect number in platform data

On Monday 30 April 2018 01:54 PM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > We have the 'ti,davinci-chipselect' property in the device tree, but > when using platform data the driver silently uses the id field of > struct platform_device as the

Re: [PATCH 00/12] mtd: nand: davinci: stop using pdev->id as chipselect

On Monday 30 April 2018 10:17 PM, Boris Brezillon wrote: > On Mon, 30 Apr 2018 18:45:06 +0200 > Bartosz Golaszewski wrote: > >> 2018-04-30 12:09 GMT+02:00 Boris Brezillon : >>> Hi Bartosz, >>> >>> On Mon, 30 Apr 2018 10:24:41 +0200 >>> Bartosz

Re: [PATCH 01/12] mtd: nand: davinci: store the core chipselect number in platform data

On Tuesday 01 May 2018 03:23 PM, Sekhar Nori wrote: > On Tuesday 01 May 2018 02:55 PM, Sekhar Nori wrote: >> On Monday 30 April 2018 01:54 PM, Bartosz Golaszewski wrote: >>> From: Bartosz Golaszewski <bgolaszew...@baylibre.com> >>> >>> We have the 'ti,

Re: [PATCH v6 0/7] ARM: davinci: complete the conversion to using the reset framework

Hi Bartosz, On Tuesday 17 April 2018 11:00 PM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > This series converts the only user of the handcoded, mach-specific reset > routines in the davinci platform to using the reset framework. > > Patches 1-2 add

Re: [PATCH 01/12] mtd: nand: davinci: store the core chipselect number in platform data

On Tuesday 01 May 2018 02:55 PM, Sekhar Nori wrote: > On Monday 30 April 2018 01:54 PM, Bartosz Golaszewski wrote: >> From: Bartosz Golaszewski <bgolaszew...@baylibre.com> >> >> We have the 'ti,davinci-chipselect' property in the device tree, but >> when using

Re: [PATCH 00/12] mtd: nand: davinci: stop using pdev->id as chipselect

On Monday 30 April 2018 03:39 PM, Boris Brezillon wrote: > Hi Bartosz, > > On Mon, 30 Apr 2018 10:24:41 +0200 > Bartosz Golaszewski wrote: > >> From: Bartosz Golaszewski >> >> We have the 'ti,davinci-chipselect' property in the device tree, but >> when

Re: [PATCH 01/12] mtd: nand: davinci: store the core chipselect number in platform data

On Tuesday 01 May 2018 03:59 PM, Sekhar Nori wrote: > On Tuesday 01 May 2018 03:23 PM, Sekhar Nori wrote: >> On Tuesday 01 May 2018 02:55 PM, Sekhar Nori wrote: >>> On Monday 30 April 2018 01:54 PM, Bartosz Golaszewski wrote: >>>> From: Bartosz Golaszewski <bgolas

Re: [PATCH v9 02/27] clk: davinci: da850-pll: change PLL0 to CLK_OF_DECLARE

On Friday 27 April 2018 05:47 AM, David Lechner wrote: > PLL0 on davinci/da850-type device needs to be registered early in boot > because it is needed for clocksource/clockevent. Change the driver > to use CLK_OF_DECLARE for this special case. > > Signed-off-by: David Lechner

Re: [PATCH v9 01/27] clk: davinci: pll: allow dev == NULL

On Friday 27 April 2018 05:47 AM, David Lechner wrote: > This modifies the TI DaVinci PLL clock driver to allow for the case > when dev == NULL. On some (most) SoCs that use this driver, the PLL > clock needs to be registered during early boot because it is used > for clocksource/clockevent and

Re: [PATCH v9 03/27] clk: davinci: psc: allow for dev == NULL

On Friday 27 April 2018 05:47 AM, David Lechner wrote: > +static inline void *_devm_kzalloc(struct device *dev, size_t size, gfp_t > flags) > +{ > + if (dev) > + return devm_kzalloc(dev, size, flags); > + > + return kzalloc(size, flags); > +} I have the same question on the

Re: [PATCH v9 04/27] ARM: davinci: pass clock as parameter to davinci_timer_init()

to have a clock with con_id > of "timer0", which will be good for DT bindings since clock-names = > "timer0" doesn't really make sense. > > Also, drop use of extern in header file since we are touching the > definition. > > Signed-off-by: David Lechne

Re: [PATCH v9 07/27] ARM: davinci: dm355: add new clock init using common clock framework

On Friday 27 April 2018 05:47 AM, David Lechner wrote: > This adds the new board-specific clock init in mach-davinci/dm355.c > using the new common clock framework drivers. > > The #ifdefs are needed to prevent compile errors until the entire > ARCH_DAVINCI is converted. > > Also clean up the

Re: [PATCH 00/12] mtd: nand: davinci: stop using pdev->id as chipselect

Hi Boris, On Monday 30 April 2018 10:17 PM, Boris Brezillon wrote: > On Mon, 30 Apr 2018 18:45:06 +0200 > Bartosz Golaszewski wrote: > >> 2018-04-30 12:09 GMT+02:00 Boris Brezillon : >>> Hi Bartosz, >>> >>> On Mon, 30 Apr 2018 10:24:41 +0200 >>>

Re: [PATCH v9 09/27] ARM: davinci: dm644x: add new clock init using common clock framework

On Friday 27 April 2018 05:47 AM, David Lechner wrote: > void __init dm644x_init_time(void) > { > +#ifdef CONFIG_COMMON_CLK > + void __iomem *pll1, *psc; > + struct clk *clk; > + > + clk_register_fixed_rate(NULL, "ref_clk", NULL, 0, DM644X_REF_FREQ); > + > + pll1 =

Re: [PATCH 06/11] ARM: davinci: constify gpio_led

On Wednesday 20 December 2017 02:17 PM, Arvind Yadav wrote: > gpio_led are not supposed to change at runtime. > struct gpio_led_platform_data working with const gpio_led > provided by . So mark the non-const structs > as const. > > Signed-off-by: Arvind Yadav This

Re: [PATCH v4 6/7] ARM: davinci: convert to common clock framework

On Saturday 06 January 2018 07:12 AM, David Lechner wrote: > On 01/05/2018 04:42 AM, Sekhar Nori wrote: >> On Friday 05 January 2018 08:29 AM, David Lechner wrote: >>> On 01/04/2018 11:50 AM, David Lechner wrote: >>>> On 1/4/18 6:39 AM, Sekhar Nori wrote: >> >

Re: [PATCH v5 01/44] dt-bindings: clock: Add new bindings for TI Davinci PLL clocks

On Thursday 11 January 2018 06:15 PM, Adam Ford wrote: > On Wed, Jan 10, 2018 at 8:50 PM, David Lechner wrote: >> On 01/10/2018 04:24 PM, Adam Ford wrote: >>> >>> >>> I am available tomorrow to build and test patches against the >>> da850-evm. I just need to know which

Re: [PATCH v4 6/7] ARM: davinci: convert to common clock framework

On Friday 05 January 2018 08:29 AM, David Lechner wrote: > On 01/04/2018 11:50 AM, David Lechner wrote: >> On 1/4/18 6:39 AM, Sekhar Nori wrote: >>> This is a pretty huge patch again and I hope it can be broken down. >>> Ideally one per SoC converted and t

Re: [PATCH 07/12] ARM: davinci: drop unneeded newline

On Wednesday 27 December 2017 08:21 PM, Julia Lawall wrote: > gpio_request uses its second argument as a label, so it doesn't seem > appropriate for it to have a newline. Done using Coccinelle. > > Signed-off-by: Julia Lawall Applied to my v4.16/soc branch Thanks, Sekhar

Re: [PATCH v5 01/44] dt-bindings: clock: Add new bindings for TI Davinci PLL clocks

On Wednesday 10 January 2018 08:31 AM, David Lechner wrote: > On 01/09/2018 06:35 AM, Sekhar Nori wrote: >> On Monday 08 January 2018 09:59 PM, David Lechner wrote: >>> On 01/08/2018 08:00 AM, Sekhar Nori wrote: >>>> On Monday 08 January 2018 07:47 AM, David Le

Re: [PATCH v2 0/2] ARM: davinici: move watchdog restart from mach to drivers

On Sunday 07 January 2018 08:40 AM, David Lechner wrote: > This series moves the watchdog restart code from arch/arm/mach-davinci > to drivers/watchdog. > > Tested working on LEGO MINDSTORMS EV3 (TI AM1808 processor). > > v2 changes: > * rebased on linux-davinci/master (fixed conflict with

Re: [PATCH v5 01/44] dt-bindings: clock: Add new bindings for TI Davinci PLL clocks

On Monday 08 January 2018 09:59 PM, David Lechner wrote: > On 01/08/2018 08:00 AM, Sekhar Nori wrote: >> On Monday 08 January 2018 07:47 AM, David Lechner wrote: >>> This adds a new binding for the PLL IP blocks in the mach-davinci family >>> of processors. Currently,

Re: [PATCH v5 01/44] dt-bindings: clock: Add new bindings for TI Davinci PLL clocks

On Monday 08 January 2018 07:47 AM, David Lechner wrote: > This adds a new binding for the PLL IP blocks in the mach-davinci family > of processors. Currently, only the SYSCLKn and AUXCLK outputs are needed, > but in the future additional child nodes could be added for OBSCLK and > BPDIV. > >

Re: [PATCH v5 16/44] clk: davinci: Add platform information for TI DM646x PSC

On Monday 08 January 2018 07:47 AM, David Lechner wrote: > +void __init dm646x_psc_clk_init(void __iomem *psc) > +{ > + struct clk_onecell_data *clk_data; > + > + clk_data = davinci_psc_register_clocks(psc, dm646x_psc_info, 41); > + if (!clk_data) > + return; > + > +

Re: [PATCH v5 19/44] clk: davinci: New driver for TI DA8XX CFGCHIP clocks

On Monday 08 January 2018 07:47 AM, David Lechner wrote: > This adds a new driver for the gate and multiplexer clocks in the > CFGCHIPn syscon registers on TI DA8XX-type SoCs. > > Signed-off-by: David Lechner > --- > drivers/clk/davinci/Makefile| 2 + >

Re: [PATCH v5 15/44] clk: davinci: Add platform information for TI DM644x PSC

On Monday 08 January 2018 07:47 AM, David Lechner wrote: > This adds platform-specific declarations for the PSC clocks on TI > DaVinci 644x based systems. > > Signed-off-by: David Lechner Looks good to me except comments I already gave for similar patches. Thanks, Sekhar

Re: [PATCH v5 43/44] ARM: da8xx-dt: switch to device tree clocks

On Monday 08 January 2018 07:55 AM, David Lechner wrote: > This removes all of the clock init code from da8xx-dt.c. This includes > all of the OF_DEV_AUXDATA that was just used for looking up clocks. > > Note: You need to have clocks defined in your device tree or your system > won't boot after

Re: [PATCH v5 33/44] ARM: davinci: switch to common clock framework

On Monday 08 January 2018 07:53 AM, David Lechner wrote: > diff --git a/arch/arm/mach-davinci/Makefile b/arch/arm/mach-davinci/Makefile > index 4e81780..8a8f413 100644 > --- a/arch/arm/mach-davinci/Makefile > +++ b/arch/arm/mach-davinci/Makefile > @@ -5,7 +5,7 @@ > # > > # Common objects >

Re: [PATCH v5 21/44] clk: davinci: New driver for TI DA8XX USB PHY clocks

On Monday 08 January 2018 07:47 AM, David Lechner wrote: > +static int da8xx_usb1_phy_clk_set_parent(struct clk_hw *hw, u8 index) > +{ > + struct da8xx_usb1_phy_clk *clk = to_da8xx_usb1_phy_clk(hw); > + unsigned int mask, val; > + > + /* Set the USB 1.1 PHY clock mux based on the

Re: [PATCH v5 29/44] ARM: da8xx: add new USB PHY clock init using common clock framework

On Monday 08 January 2018 07:47 AM, David Lechner wrote: > +int __init da8xx_register_usb20_phy_clk(bool use_usb_refclkin) > +{ > + struct regmap *cfgchip; > + struct clk *usb0_psc_clk, *clk; > + struct clk_hw *parent; > + > + cfgchip =

Re: [PATCH v5 24/44] ARM: da850: add new clock init using common clock framework

On Monday 08 January 2018 07:47 AM, David Lechner wrote: > +#ifndef CONFIG_COMMON_CLK > static int da850_set_armrate(struct clk *clk, unsigned long rate); > static int da850_round_armrate(struct clk *clk, unsigned long rate); > static int da850_set_pll0rate(struct clk *clk, unsigned long

Re: [PATCH v5 20/44] dt-bindings: clock: Add bindings for TI DA8XX USB PHY clocks

On Monday 08 January 2018 07:47 AM, David Lechner wrote: > This adds a new binding for TI DA8XX USB PHY clocks. These clocks are part > of a syscon register called CFGCHIP3. CFGCHIP2 > > Signed-off-by: David Lechner > +Examples: > + > + cfgchip: syscon@1417c { > +

Re: [PATCH v5 02/44] clk: davinci: New driver for davinci PLL clocks

On Saturday 13 January 2018 07:43 AM, David Lechner wrote: > On 01/12/2018 03:21 AM, Sekhar Nori wrote: >> On Monday 08 January 2018 07:47 AM, David Lechner wrote: >>> +static unsigned long davinci_pll_clk_recalc(struct clk_hw *hw, >>> +  

Re: [PATCH v5 05/44] clk: davinci: Add platform information for TI DM355 PLL

On Monday 08 January 2018 07:47 AM, David Lechner wrote: > This adds platform-specific declarations for the PLL clocks on TI > DaVinci 355 based systems. DM355 > > Signed-off-by: David Lechner <da...@lechnology.com> Reviewed-by: Sekhar Nori <nsek...@ti.com> Thanks, Sekhar

Re: [PATCH v5 04/44] clk: davinci: Add platform information for TI DA850 PLL

en changing the PLL, but I feel its more readable with the additional spacing suggested. Same comment for other patches too with similar function implemented. With that minor comment: Reviewed-by: Sekhar Nori <nsek...@ti.com> Thanks, Sekhar

Re: [PATCH v5 07/44] clk: davinci: Add platform information for TI DM644x PLL

; + davinci_pll_clk_register("pll2", "ref_clk", pll2); > + for (info = dm644x_pll2_divclk_info; info->name; info++) > + davinci_pll_divclk_register(info, pll2); > + davinci_pll_bpdiv_clk_register("pll2_sysclkbp", "ref_clk", pll2); > +} Here too, more line spacing will help. With those minor comments. Reviewed-by: Sekhar Nori <nsek...@ti.com> Thanks, Sekhar

Re: [PATCH] ARM: davinci_all_defconfig: set CONFIG_DAVINCI_WATCHDOG=y

e > watchdog driver, devices cannot reboot unless the watchdog driver is > loaded, so make it a compiled-in option so that we can always reboot, even > when modules are not loaded. > > Cc: Sekhar Nori <nsek...@ti.com> > Suggested-by: Adam Ford <aford...@gmail.com> > Sign

Re: [PATCH v5 02/44] clk: davinci: New driver for davinci PLL clocks

On Saturday 13 January 2018 06:41 AM, David Lechner wrote: > On 01/12/2018 10:18 AM, Sekhar Nori wrote: >> On Friday 12 January 2018 08:55 PM, David Lechner wrote: >>>> >>>> PLL output on DA850 must never be below 300MHz or above 600MHz (see >>>> data

Re: [PATCH v5 06/44] clk: davinci: Add platform information for TI DM365 PLL

ot;clkout1", "ref_clk", pll2); > + davinci_pll_obs_clk_register("clkout1", dm365_pll_obsclk_parent_names, > + ARRAY_SIZE(dm365_pll_obsclk_parent_names), > + pll2, dm365_pll_obsclk_table); > + for (info = dm365_pll2_divclk_info; info->name; info++) > + davinci_pll_divclk_register(info, pll2); > +} With that and the empty line comment I gave earlier. Reviewed-by: Sekhar Nori <nsek...@ti.com> Thanks, Sekhar

Re: [PATCH v5 10/44] clk: davinci: New driver for davinci PSC clocks

On Monday 08 January 2018 07:47 AM, David Lechner wrote: > This adds a new driver for mach-davinci PSC clocks. This is porting the > code from arch/arm/mach-davinci/psc.c to the common clock framework and > is converting it to use regmap to simplify the code. Additionally, it adds > device tree

Re: [PATCH v5 01/44] dt-bindings: clock: Add new bindings for TI Davinci PLL clocks

Hi Adam, David, On Friday 12 January 2018 03:04 AM, Adam Ford wrote: > Thanks for clarifying. I was able to make it work with the following patch: > > diff --git a/drivers/clk/davinci/psc-da850.c b/drivers/clk/davinci/psc-da850.c > index 3b4583d..a76b8682 100644 > ---

Re: [PATCH v5 08/44] clk: davinci: Add platform information for TI DM646x PLL

. Apart from those: Reviewed-by: Sekhar Nori <nsek...@ti.com> Thanks, Sekhar

Re: [PATCH v5 11/44] clk: davinci: Add platform information for TI DA830 PSC

On Monday 08 January 2018 07:47 AM, David Lechner wrote: > This adds platform-specific declarations for the PSC clocks on TI DA830/ > OMAP-L137/AM17XX SoCs. > > Signed-off-by: David Lechner > --- > drivers/clk/davinci/Makefile| 1 + > drivers/clk/davinci/psc-da830.c |

Re: [PATCH v5 13/44] clk: davinci: Add platform information for TI DM355 PSC

On Monday 08 January 2018 07:47 AM, David Lechner wrote: > This adds platform-specific declarations for the PSC clocks on TI > DaVinci 355 based systems. > > Signed-off-by: David Lechner Apart from some comments on other patches that apply to this too, I have no new

Re: [PATCH v5 14/44] clk: davinci: Add platform information for TI DM365 PSC

On Monday 08 January 2018 07:47 AM, David Lechner wrote: > This adds platform-specific declarations for the PSC clocks on TI > DaVinci 365 based systems. > > Signed-off-by: David Lechner Apart from some comments on other patches that apply to this too, I have no new

Re: [PATCH v5 20/44] dt-bindings: clock: Add bindings for TI DA8XX USB PHY clocks

On Friday 19 January 2018 12:30 AM, David Lechner wrote: > On 01/18/2018 06:10 AM, Sekhar Nori wrote: >> On Monday 08 January 2018 07:47 AM, David Lechner wrote: >>> This adds a new binding for TI DA8XX USB PHY clocks. These clocks are >>> part >>>

Re: [PATCH v5 43/44] ARM: da8xx-dt: switch to device tree clocks

On Friday 19 January 2018 12:10 AM, David Lechner wrote: > On 01/18/2018 09:27 AM, Sekhar Nori wrote: >> On Monday 08 January 2018 07:55 AM, David Lechner wrote: >>> This removes all of the clock init code from da8xx-dt.c. This includes >>> all of the OF_DEV_AUXDATA tha

Re: [PATCH 0/6] ARM: davinci: common clock prep work

On Saturday 20 January 2018 08:50 AM, David Lechner wrote: > This series contains some changes needed for the conversion of arch/arm/mach- > davinci to the common clock framework. > > Most of the boards in mach-davinci do not have device tree support. However, > CFGCHIP, which is a syscon regmap,

Re: [PATCH 1/6] mfd: syscon: Add syscon_register() function

On Saturday 20 January 2018 08:50 AM, David Lechner wrote: > This adds a new syscon_register() function that creates a new syscon > regmap and adds it to the lookup list. > > This function serves two purposes: > > 1. This is needed for platforms without device tree support where the >syscon

Re: [PATCH 1/6] mfd: syscon: Add syscon_register() function

On Monday 22 January 2018 04:38 PM, Arnd Bergmann wrote: > On Mon, Jan 22, 2018 at 11:53 AM, Sekhar Nori <nsek...@ti.com> wrote: >> On Saturday 20 January 2018 08:50 AM, David Lechner wrote: >>> This adds a new syscon_register() function that creates a new sy

Re: [PATCH] i2c: davinci: fix the cpufreq transition

gt; > Signed-off-by: Bartosz Golaszewski <bgolaszew...@baylibre.com> I assume you tested this on a board where I2C-controlled PMIC changes voltage during CPUfreq (DA850 LogicPD EVM should have this hardware support). Perhaps also add: Fixes: 82c0de11b734 ("i2c: davinci: Add cpufreq supp

Re: [PATCH 4/6] ARM: davinci: move davinci_clk_init() to init_time

On Saturday 20 January 2018 08:50 AM, David Lechner wrote: > This moves the call of davinci_clk_init() from map_io to init_time for all > boards. > > This is the proper place to init clocks. This is also done in preparation > for moving to the common clock framework. > > dm646x is a special case

Re: [PATCH v5 12/44] clk: davinci: Add platform information for TI DA850 PSC

On Thursday 18 January 2018 12:38 AM, David Lechner wrote: > It is looking like this: > > > static const struct davinci_psc_clkdev_info emfia_clkdev[] __initconst = { > LPSC_CLKDEV(NULL,    "ti-aemif"), > LPSC_CLKDEV("aemif",    "davinci-nand.0"), > { } > }; > > static const struct

Re: [PATCH v5 11/44] clk: davinci: Add platform information for TI DA830 PSC

On Wednesday 17 January 2018 11:02 PM, David Lechner wrote: > +    clk_register_clkdev(clk_data->clks[3], "gpio", NULL); This is pretty bad (and no fault of yours) - having a con_id but no device name. Can you please make a pre-series which passes NULL con_id in

Re: [PATCH v5 12/44] clk: davinci: Add platform information for TI DA850 PSC

On Monday 08 January 2018 07:47 AM, David Lechner wrote: > +void __init da850_psc_clk_init(void __iomem *psc0, void __iomem *psc1) > +{ > + struct clk_onecell_data *clk_data; > + > + clk_data = davinci_psc_register_clocks(psc0, da850_psc0_info, 16); > + if (!clk_data) > +

Re: [PATCH] ARM: davinci_all_defconfig: set CONFIG_DAVINCI_WATCHDOG=y

On Tuesday 16 January 2018 05:47 PM, Adam Ford wrote: > On Mon, Jan 15, 2018 at 11:59 PM, Sekhar Nori <nsek...@ti.com> wrote: >> On Monday 15 January 2018 10:59 PM, David Lechner wrote: >>> This changes CONFIG_DAVINCI_WATCHDOG from a module to a compiled-in >>> opt

Re: [PATCH v5 03/44] clk: davinci: Add platform information for TI DA830 PLL

On Monday 08 January 2018 07:47 AM, David Lechner wrote: > This adds platform-specific declarations for the PLL clocks on TI DA830/ > OMAP-L137/AM17XX SoCs. > > Signed-off-by: David Lechner <da...@lechnology.com> Reviewed-by: Sekhar Nori <nsek...@ti.com> Thanks, Sekhar

Re: [PATCH v5 02/44] clk: davinci: New driver for davinci PLL clocks

+++ b/MAINTAINERS > @@ -13554,6 +13554,12 @@ F: arch/arm/mach-davinci/ > F: drivers/i2c/busses/i2c-davinci.c > F: arch/arm/boot/dts/da850* > > +TI DAVINCI SERIES CLOCK DRIVER > +M: David Lechner <da...@lechnology.com> Please also add: R: Sekhar Nori <nsek...@

Re: [PATCH v6 00/41] ARM: davinci: convert to common clock framework​

On Thursday 25 January 2018 09:48 PM, David Lechner wrote: > On 01/25/2018 06:53 AM, Sekhar Nori wrote: >> On Wednesday 24 January 2018 01:33 PM, Bartosz Golaszewski wrote: >>> 2018-01-23 21:23 GMT+01:00 David Lechner <da...@lechnology.com>: >>>> On 01/2

Re: [PATCH] ARM: da8xx: use platform data for CFGCHIP syscon regmap

+ Arnd, Kishon and Lee for their information. On Wednesday 24 January 2018 05:06 AM, David Lechner wrote: > This converts from using a platform device for the CFGCHIP syscon > regmap to using platform data to pass the regmap to consumers. > > A lazy getter function is used so that the regmap

Re: [RESEND] phy: da8xx-usb: rename clock con_ids

On Tuesday 23 January 2018 11:44 PM, David Lechner wrote: > This renames the clock con_ids in the DA8XX USB PHY driver as well as > the matching names in the mach clock registration code. > > This is in preparation for using device tree clocks where these names > will become part of the device

Re: [PATCH v6 00/41] ARM: davinci: convert to common clock framework​

On Wednesday 24 January 2018 01:33 PM, Bartosz Golaszewski wrote: > 2018-01-23 21:23 GMT+01:00 David Lechner : >> On 01/23/2018 02:05 PM, David Lechner wrote: >>> >>> On 01/23/2018 02:01 PM, David Lechner wrote: On 01/23/2018 01:53 PM, Bartosz Golaszewski wrote:

Re: [PATCH v5 02/44] clk: davinci: New driver for davinci PLL clocks

On Friday 12 January 2018 08:55 PM, David Lechner wrote: >> >> PLL output on DA850 must never be below 300MHz or above 600MHz (see >> datasheet table "Allowed PLL Operating Conditions"). Does this take care >> of that? Thats one of the main reasons I recall I went with some >> specific values of

Re: [PATCH v5 01/44] dt-bindings: clock: Add new bindings for TI Davinci PLL clocks

On Friday 12 January 2018 03:16 AM, David Lechner wrote: > > Sekhar, have you had a chance to look at the rest of the patches in the > series? Not yet. Sorry about the slow (and piecemeal) review. > > I'll wait a bit before I send a v6 to see if any other comments come. Yes. I will let you

Re: [PATCH v6 01/41] dt-bindings: clock: Add new bindings for TI Davinci PLL clocks

On Wednesday 31 January 2018 12:16 AM, David Lechner wrote: > On 01/30/2018 08:50 AM, Rob Herring wrote: >> On Mon, Jan 29, 2018 at 3:14 PM, David Lechner >> wrote: >>> On 01/29/2018 01:53 PM, Rob Herring wrote: On Sat, Jan 20, 2018 at 11:13:40AM -0600, David

Re: [PATCH v6 19/41] clk: davinci: New driver for TI DA8XX USB PHY clocks

On Saturday 20 January 2018 10:43 PM, David Lechner wrote: > diff --git a/include/linux/clk/davinci.h b/include/linux/clk/davinci.h > index 54ea3ff..04b48b3 100644 > --- a/include/linux/clk/davinci.h > +++ b/include/linux/clk/davinci.h > @@ -9,6 +9,9 @@ > > #include > > +struct clk; >

Re: [PATCH v6 20/41] ARM: da830: add new clock init using common clock framework

On Saturday 20 January 2018 10:43 PM, David Lechner wrote: > void __init da830_init_time(void) > { > +#ifdef CONFIG_COMMON_CLK > + void __iomem *pll0, *psc0, *psc1; > + struct clk *clk; > + > + pll0 = ioremap(DA8XX_PLL0_BASE, SZ_4K); > + psc0 = ioremap(DA8XX_PSC0_BASE, SZ_4K); >

Re: [PATCH v6 22/41] ARM: dm355: add new clock init using common clock framework

; > Also clean up the #includes since we are adding some here. > > Signed-off-by: David Lechner <da...@lechnology.com> Reviewed-by: Sekhar Nori <nsek...@ti.com> Thanks, Sekhar

Re: [PATCH v6 24/41] ARM: dm644x: add new clock init using common clock framework

; > Also clean up the #includes since we are adding some here. > > Signed-off-by: David Lechner <da...@lechnology.com> I did not notice this before, but the subject line for this and other patches needs to be "ARM: davinci: " Apart from that: Reviewed-by: Sekhar Nori <nsek...@ti.com> Thanks, Sekhar

Re: [PATCH v6 27/41] ARM: da8xx: add new sata_refclk init using common clock framework

rted. > > Also, the #includes are sorted since we are adding some here. > > Signed-off-by: David Lechner <da...@lechnology.com> Reviewed-by: Sekhar Nori <nsek...@ti.com> Thanks, Sekhar

Re: [PATCH v6 18/41] clk: davinci: New driver for TI DA8XX CFGCHIP clocks

On Friday 02 February 2018 06:49 PM, Sekhar Nori wrote: > On Saturday 20 January 2018 10:43 PM, David Lechner wrote: >> +static const struct clk_ops da8xx_cfgchip_div4p5_clk_ops = { >> +.enable = da8xx_cfgchip_gate_clk_enable, >> +.disable= da8xx_cfg

Re: [PATCH v6 21/41] ARM: da850: add new clock init using common clock framework

On Saturday 20 January 2018 10:44 PM, David Lechner wrote: > void __init da850_init_time(void) > { > +#ifdef CONFIG_COMMON_CLK > + void __iomem *pll0, *pll1, *psc0, *psc1; > + struct regmap *cfgchip; > + struct clk *clk; > + struct clk_hw *parent; > + > + pll0 =

<    5   6   7   8   9   10   11   12   13   14   >