Re: [PATCH 2/2] mfd: sec: Add support for S2MPS15 PMIC

2014-10-14 Thread Thomas Abraham
On Tue, Oct 14, 2014 at 2:11 PM, Krzysztof Kozłowski wrote: > On 14.10.2014 10:14, Thomas Abraham wrote: >> Add support for S2MPS15 PMIC which is similar to S2MPS11 PMIC. The S2MPS15 >> PMIC supports 27 LDO regulators, 10 buck regulators, RTC, three 32.768KHz >> clock output

Re: [PATCH 1/2] dt-bindings: mfd: s2mps11: add documentation for s2mps15 PMIC

2014-10-14 Thread Thomas Abraham
On Tue, Oct 14, 2014 at 2:13 PM, Krzysztof Kozłowski wrote: > On 14.10.2014 10:14, Thomas Abraham wrote: >> Add dt-binding documentation for s2mps15 PMIC device. The s2mps15 device >> is similar to s2mps11/14 PMIC device and has 27 LDO and 10 buck regulators. >> >> Cc:

Re: [PATCH] regulator: s2mps11: add support for S2MPS15 regulators

2014-10-14 Thread Thomas Abraham
On Tue, Oct 14, 2014 at 2:18 PM, Krzysztof Kozłowski wrote: > On 14.10.2014 10:17, Thomas Abraham wrote: >> The S2MPS15 PMIC is similar in functionality to S2MPS11/14 PMIC. It contains >> 27 LDO and 10 Buck regulators and allows programming these regulators via a >> I2C inter

[PATCH] regulator: s2mps11: add support for S2MPS15 regulators

2014-10-14 Thread Thomas Abraham
The S2MPS15 PMIC is similar in functionality to S2MPS11/14 PMIC. It contains 27 LDO and 10 Buck regulators and allows programming these regulators via a I2C interface. This patch adds initial support for LDO/Buck regulators of S2MPS15 PMIC. Signed-off-by: Thomas Abraham --- drivers/regulator

[PATCH 0/2] mfd: sec: add S2MPS15 PMIC support

2014-10-14 Thread Thomas Abraham
eries adds initial support for LDO/Buck regulators of S2MPS15 PMIC. Thomas Abraham (2): dt-bindings: mfd: s2mps11: add documentation for s2mps15 PMIC mfd: sec: Add support for S2MPS15 PMIC Documentation/devicetree/bindings/mfd/s2mps11.txt | 11 +- drivers/mfd/

[PATCH 1/2] dt-bindings: mfd: s2mps11: add documentation for s2mps15 PMIC

2014-10-14 Thread Thomas Abraham
Add dt-binding documentation for s2mps15 PMIC device. The s2mps15 device is similar to s2mps11/14 PMIC device and has 27 LDO and 10 buck regulators. Cc: devicet...@vger.kernel.org Signed-off-by: Thomas Abraham --- Documentation/devicetree/bindings/mfd/s2mps11.txt | 11 --- 1 files

[PATCH 2/2] mfd: sec: Add support for S2MPS15 PMIC

2014-10-14 Thread Thomas Abraham
Add support for S2MPS15 PMIC which is similar to S2MPS11 PMIC. The S2MPS15 PMIC supports 27 LDO regulators, 10 buck regulators, RTC, three 32.768KHz clock outputs and battery charger. This patch adds initial support for LDO and buck regulators of S2MPS15 device. Signed-off-by: Thomas Abraham

Re: [RFC/PATCH 02/12] clk: Add safe switch hook

2014-07-29 Thread Thomas Abraham
On Tue, Jul 29, 2014 at 11:35 AM, Mike Turquette wrote: > Quoting Stephen Boyd (2014-06-24 17:06:13) >> Sometimes clocks can't accept their parent source turning off >> while the source is reprogrammed to a different rate. Most >> notably some CPU clocks require a way to switch away from the >> cu

Re: [PATCH] ARM: dts: add CPU nodes for Exynos4 SoCs

2014-07-21 Thread Thomas Abraham
On Mon, Jul 21, 2014 at 6:40 PM, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Monday, July 21, 2014 01:43:53 PM Daniel Drake wrote: >> On Fri, Jul 18, 2014 at 5:00 PM, Bartlomiej Zolnierkiewicz >> wrote: >> > Recent patch by Tomasz Figa ("irqchip: gic: Fix core ID calculation >> > when topolog

Re: [PATCHv2 0/3] cpufreq: Use cpufreq-cpu0 driver for Exynos3250

2014-06-18 Thread Thomas Abraham
On Wed, Jun 18, 2014 at 2:09 PM, Chanwoo Choi wrote: > This patchset use cpufreq-cpu0 driver to support Exynos3250 cpufreq. So, this > patchset is based on following patchset[1] by Thomas Abraham. > [1] http://www.spinics.net/lists/arm-kernel/msg339392.html > > Changes from v1:

Re: [PATCH V2 0/3] cpufreq: add support for intermediate (stable)

2014-05-16 Thread Thomas Abraham
On Fri, May 16, 2014 at 2:33 PM, Viresh Kumar wrote: > Douglas Anderson, recently pointed out an interesting problem due to which > udelay() was expiring earlier than it should. > > While transitioning between frequencies few platforms may temporarily switch > to > a stable frequency, waiting for

Re: [PATCH 0/2] PM / OPP: move cpufreq specific helpers out of OPP layer

2014-05-13 Thread Thomas Abraham
nclude/linux/cpufreq.h | 21 > include/linux/pm_opp.h | 20 --- > 7 files changed, 167 insertions(+), 146 deletions(-) > create mode 100644 drivers/cpufreq/cpufreq_opp.c Works fine on Exynos. Tested-by: Thomas Abraham > > -- > 1.7.9.5 > > --

Re: [PATCH v2] USB: ehci-s5p: Fix phy reset

2013-03-14 Thread Thomas Abraham
On 14 March 2013 17:31, Alexander Graf wrote: > > On 14.03.2013, at 05:19, Thomas Abraham wrote: > >> On 14 March 2013 05:29, Alexander Graf wrote: >>> On my Exynos 5 based Arndale system, I need to pull the reset line down >>> and then let it go up again to

Re: [PATCH v2] USB: ehci-s5p: Fix phy reset

2013-03-13 Thread Thomas Abraham
On 14 March 2013 05:29, Alexander Graf wrote: > On my Exynos 5 based Arndale system, I need to pull the reset line down > and then let it go up again to actually perform a reset. Without that > reset, I can't find any USB hubs on my bus, rendering the USB controller > useless. > > We also only nee

Re: [PATCH v2 0/3] pinctrl: exynos: add support for Samsung's Exynos5250

2013-03-06 Thread Thomas Abraham
On 7 March 2013 05:41, Kukjin Kim wrote: > Thomas Abraham wrote: >> >> Changes since v1: >> - Change the compatible string from "samsung,pinctrl-exynos5250" to >> "samsung,exynos5250-pinctrl". >> - Rebased to v3.9-rc1 >> > > Thom

[PATCH v2 1/3] pinctrl: exynos: add exynos5250 SoC specific data

2013-03-06 Thread Thomas Abraham
Add Samsung Exynos5250 SoC specific data to enable pinctrl support for all platforms based on Exynos5250. Signed-off-by: Thomas Abraham Reviewed-by: Tomasz Figa Acked-by: Linus Walleij --- drivers/pinctrl/pinctrl-exynos.c | 108 + drivers/pinctrl/pinctrl

[PATCH v2 3/3] arm: exynos: skip wakeup interrupt registration for exynos5250 if pinctrl is enabled

2013-03-06 Thread Thomas Abraham
Skip the wakeup interrupt registration for Exynos5250 if pinctrl support is enabled for Exynos5250. Signed-off-by: Thomas Abraham Reviewed-by: Tomasz Figa Acked-by: Linus Walleij --- arch/arm/mach-exynos/common.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch

[PATCH v2 2/3] gpio: samsung: skip gpiolib registration if pinctrl support is enabled for exynos5250

2013-03-06 Thread Thomas Abraham
Skip exynos5250 gpiolib registration if pinctrl support for exynos5250 is enabled. Signed-off-by: Thomas Abraham Reviewed-by: Tomasz Figa Acked-by: Linus Walleij --- drivers/gpio/gpio-samsung.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/gpio/gpio

[PATCH v2 0/3] pinctrl: exynos: add support for Samsung's Exynos5250

2013-03-06 Thread Thomas Abraham
fic data which is used by the Samsung pinctrl driver to setup the pinctrl/pinmux/eint controllers. The second and third patches skips the wakeup interrupt and gpiolib registration if the pinctrl support is enabled for Exynos5250. Thomas Abraham (3): pinctrl: exynos: add exynos5250 SoC specific d

Re: [PATCH 1/3] pinctrl: exynos: add exynos5250 SoC specific data

2013-03-05 Thread Thomas Abraham
On 27 December 2012 22:28, Kukjin Kim wrote: > Thomas Abraham wrote: >> >> Hi Linus, >> >> On 14 December 2012 21:21, Linus Walleij wrote: >> > On Thu, Dec 13, 2012 at 12:54 PM, Thomas Abraham >> > wrote: >> > >> >> Add

Re: [PATCH 4/4] regulator: add device tree support for s5m8767

2013-01-08 Thread Thomas Abraham
L; > + } > + > + return 0; > +} > +#else > +static int s5m8767_pmic_dt_parse_pdata(struct sec_pmic_dev *iodev, > + struct sec_platform_data *pdata) > +{ > + return 0; > +} > +#endif /* CONFIG_OF */ > + >

Re: [PATCH] ARM: DTS: exynos4210-origen: Add MAX8997 node entry

2013-01-04 Thread Thomas Abraham
On 4 January 2013 00:23, Tushar Behera wrote: > The node entry is added as per documentation and legacy board file. > > Signed-off-by: Tushar Behera > --- > The patch is rebased on v3.8-rc1. > > arch/arm/boot/dts/exynos4210-origen.dts | 150 > +++ > 1 files changed,

Re: [PATCH] mmc: host: dw_mmc-exynos: Add support for pinctrl

2012-12-30 Thread Thomas Abraham
On 21 December 2012 09:11, Dongjin Kim wrote: > This patch adds support for pin configuration using pinctrl subsystem to > dw_mmc-exynos driver. The property 'wp-gpios' can be specified for write > protect but 'samsung,cd-pinmux-gpio' and gpios used for clock, command and > data lines will be igno

Re: [PATCH 1/4] ODROID-X: dts: Add board dts file for ODROID-X

2012-12-17 Thread Thomas Abraham
Hi Dongjin, On 17 December 2012 13:55, Dongjin Kim wrote: > Add initial dtb file for Hardkernel's ODROID-X board based on EXYNOS4412 SoC. > > Signed-off-by: Dongjin Kim > --- > arch/arm/boot/dts/Makefile |1 + > arch/arm/boot/dts/exynos4412-odroidx.dts | 52 > ++

Re: [PATCH] ARM: EXYNOS: Fix MSHC clocks instance names

2012-12-14 Thread Thomas Abraham
> }, > }, { > .clk= { > - .name = "sclk_dwmmc", > + .name = "ciu", > .parent = &exynos4_clk_dout_mmc4.clk, >

Re: [PATCH] ARM: EXYNOS: Fix MSHC clocks instance names

2012-12-14 Thread Thomas Abraham
Hi Dongjin, On 14 December 2012 20:29, Dongjin Kim wrote: > Replace clock instance name of MSHC controller for BIC and CIU of Exynos4412. > > Signed-off-by: Dongjin Kim > --- > arch/arm/mach-exynos/clock-exynos4.c | 25 ++--- > 1 file changed, 14 insertions(+), 11 deletion

Re: [PATCH 1/3] pinctrl: exynos: add exynos5250 SoC specific data

2012-12-14 Thread Thomas Abraham
Hi Linus, On 14 December 2012 21:21, Linus Walleij wrote: > On Thu, Dec 13, 2012 at 12:54 PM, Thomas Abraham > wrote: > >> Add Samsung Exynos5250 SoC specific data to enable pinctrl support for >> all platforms based on Exynos5250. >> >> Signed-off-by: Th

[PATCH 3/3] arm: exynos: skip wakeup interrupt registration for exynos5250 if pinctrl is enabled

2012-12-13 Thread Thomas Abraham
Skip the wakeup interrupt registration for Exynos5250 if pinctrl support is enabled for Exynos5250. Signed-off-by: Thomas Abraham --- arch/arm/mach-exynos/common.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-exynos/common.c b/arch/arm/mach-exynos

[PATCH 2/3] gpio: samsung: skip gpiolib registration if pinctrl support is enabled for exynos5250

2012-12-13 Thread Thomas Abraham
Skip exynos5250 gpiolib registration if pinctrl support for exynos5250 is enabled. Signed-off-by: Thomas Abraham --- drivers/gpio/gpio-samsung.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/gpio/gpio-samsung.c b/drivers/gpio/gpio-samsung.c index 01f7fe9

[PATCH 1/3] pinctrl: exynos: add exynos5250 SoC specific data

2012-12-13 Thread Thomas Abraham
Add Samsung Exynos5250 SoC specific data to enable pinctrl support for all platforms based on Exynos5250. Signed-off-by: Thomas Abraham --- drivers/pinctrl/pinctrl-exynos.c | 108 + drivers/pinctrl/pinctrl-samsung.c |2 + drivers/pinctrl/pinctrl

[PATCH 0/3] pinctrl: exynos: add support for Samsung's Exynos5250

2012-12-13 Thread Thomas Abraham
iolib registration if the pinctrl support is enabled for Exynos5250. Thomas Abraham (3): pinctrl: exynos: add exynos5250 SoC specific data gpio: samsung: skip gpiolib registration if pinctrl support is enabled for exynos5250 arm: exynos: skip wakeup interrupt registration for exynos5250 if pi

Re: [PATCH] pinctrl: exynos5440/samsung: Staticize pcfgs

2012-12-03 Thread Thomas Abraham
ctrl] Error 2 > make: *** [drivers] Error 2 > > Signed-off-by: Axel Lin Acked-by: Thomas Abraham Dear Mr. Kim, Could you please consider this patch in your next pull request for fixes. Thanks, Thomas. [...] -- To unsubscribe from this list: send the line "unsubscribe linu

Re: [PATCH 1/3] i2c: exynos5: add High Speed I2C controller driver

2012-11-27 Thread Thomas Abraham
On 27 November 2012 18:30, Naveen Krishna Chatradhi wrote: > Adds support for High Speed I2C driver found in Exynos5 and later > SoCs from Samsung. This driver currently supports Auto mode. > > Driver only supports Device Tree method. > > Signed-off-by: Taekgyun Ko > Signed-off-by: Naveen Krishna

[PATCH] regulator: add device tree support for max8997

2012-11-27 Thread Thomas Abraham
Add device tree based discovery support for max8997. Cc: Karol Lewandowski Cc: Rajendra Nayak Cc: Rob Herring Cc: Grant Likely Signed-off-by: Thomas Abraham Acked-by: MyungJoo Ham Reviewed-by: Tomasz Figa --- This patch is based on 'topic/max8997' branch of Mark Brown's

Re: [PATCH 3/3] regulator: add device tree support for max8997

2012-11-26 Thread Thomas Abraham
On 26 November 2012 19:41, Mark Brown wrote: > On Mon, Nov 26, 2012 at 07:16:04PM +0530, Thomas Abraham wrote: > >> and this patch applied cleanly. Could you please let me know if there >> is anything I need to be doing differently for this. > > Hrm, try applying it on t

Re: [PATCH 3/3] regulator: add device tree support for max8997

2012-11-26 Thread Thomas Abraham
On 26 November 2012 15:21, Mark Brown wrote: > On Sat, Nov 24, 2012 at 11:46:51PM +0530, Thomas Abraham wrote: > >> The max8997 driver is mainlined. I actually meant to say that, this v6 >> version of dt support patch for max8997, is similar in functionality >> to the v5

Re: [PATCH 3/3] regulator: add device tree support for max8997

2012-11-24 Thread Thomas Abraham
On 24 November 2012 23:29, Mark Brown wrote: > On Fri, Nov 23, 2012 at 01:33:15PM +0530, Thomas Abraham wrote: > >> This v6 patch is rebased to the latest max8997 driver code and there are no >> functional changes from v5. > > That doesn't seem to be in mainline yet

[PATCH 3/3] regulator: add device tree support for max8997

2012-11-22 Thread Thomas Abraham
Add device tree based discovery support for max8997. Cc: Karol Lewandowski Cc: Rajendra Nayak Cc: Rob Herring Cc: Grant Likely Signed-off-by: Thomas Abraham Acked-by: MyungJoo Ham --- This is the sixth version of this patch. The link to v5 version of this patch is http://www.mail

[PATCH 2/3] regulator: max8997: limit the number of dvs registers programmed in non-dvs mode

2012-11-22 Thread Thomas Abraham
In case the gpio based volatage selection mode is not used for either of buck 1/2/5, then only the BUCKxDVS1 register need to be programmed. So determine whether dvs mode is used and limit the loop count appropriately. Cc: MyungJoo Ham Signed-off-by: Thomas Abraham --- drivers/regulator

[PATCH 1/3] regulator: max8997: reorder buck1/2/5 dvs setup code

2012-11-22 Thread Thomas Abraham
The BUCKxDVSx register programming is now moved prior to setting up of the gpio based dvs mode. This will ensure that all the BUCKxDVSx registers are programmed with appropriate voltage values before the gpio based dvs mode is selected for buck1/2/5. Cc: MyungJoo Ham Signed-off-by: Thomas

[PATCH 0/3] regulator: max8997: minor updates and device tree support

2012-11-22 Thread Thomas Abraham
This patch series includes two minor updates to the gpio dvs code in max8997 regulator driver and adds device tree support for the same driver. Thomas Abraham (3): regulator: max8997: reorder buck1/2/5 dvs setup code regulator: max8997: limit the number of dvs registers programmed in non-dvs

Re: [PATCH] regulator: max8997: skip gpio dvs setup if not used

2012-11-22 Thread Thomas Abraham
Dear Mr. Ham, Thanks for your comments. On 21 November 2012 20:01, MyungJoo Ham wrote: > On Wed, Nov 21, 2012 at 11:23 PM, Thomas Abraham > wrote: >> If gpio based voltage selection for buck 1/2/5 are not used, then the >> execution >> of gpio dvs setup code dur

[PATCH] regulator: max8997: skip gpio dvs setup if not used

2012-11-21 Thread Thomas Abraham
If gpio based voltage selection for buck 1/2/5 are not used, then the execution of gpio dvs setup code during probe can be skipped completly. Cc: MyungJoo Ham Cc: Mark Brown Signed-off-by: Thomas Abraham --- drivers/regulator/max8997.c | 31 ++- 1 files changed

Re: [PATCH v2] pinctrl: samsung: Add ifdef CONFIG_OF_GPIO guard for gc->of_node

2012-11-05 Thread Thomas Abraham
On 5 November 2012 21:14, Axel Lin wrote: > This fixes below build error when !CONFIG_OF_GPIO. > > CC drivers/pinctrl/pinctrl-samsung.o > drivers/pinctrl/pinctrl-samsung.c: In function > 'samsung_pinctrl_parse_dt_pins': > drivers/pinctrl/pinctrl-samsung.c:557:19: warning: unused variable '

[PATCH] ARM: Exynos: move interrupt combiner controller driver to drivers/irqchip

2012-10-30 Thread Thomas Abraham
parameter is added to combiner_init function that allows non-dt platform code to specify the number of combiners available. Signed-off-by: Thomas Abraham --- arch/arm/mach-exynos/common.c | 210 +-- drivers/irqchip/Makefile|1 + drivers/irqchip

Re: [PATCH] dw_mmc: fix multiple drv_data NULL dereferences

2012-10-16 Thread Thomas Abraham
ata->parse_dt) { > + ret = drv_data->parse_dt(host); > if (ret) > return ERR_PTR(ret); > } > @@ -2080,6 +2084,7 @@ static struct dw_mci_board *dw_mci_parse_dt(struct > dw_mci *host) > > int dw_mci_probe(struct dw_mci

Re: [PATCH 2/2] ARM: Exynos4: Register clocks via common clock framework

2012-10-07 Thread Thomas Abraham
Hi Sylwester, Thanks for reviewing this patch series. On 6 October 2012 00:21, Sylwester Nawrocki wrote: > Hello, > > On 10/01/2012 02:09 PM, chander.kash...@linaro.org wrote: >> From: Thomas Abraham >> >> Register clocks for Exynos4 platfotms using common clock fram

Re: [PATCH 2/2] ARM: Exynos4: Register clocks via common clock framework

2012-10-07 Thread Thomas Abraham
.kash...@linaro.org wrote: >> From: Thomas Abraham >> >> Register clocks for Exynos4 platfotms using common clock framework. >> Also included are set of helper functions for clock registration >> that can be reused on other Samsung platforms as well. >&

Re: [PATCH 2/2] ARM: Exynos4: Register clocks via common clock framework

2012-10-07 Thread Thomas Abraham
Hi Tomasz, On 3 October 2012 19:40, Tomasz Figa wrote: > Hi Chander, Thomas, > > I can see one more problem here. > > Based on the fact that sdhci-s3c driver receives only the endpoint gate > clock (hsmmc), doesn't the following setup make the driver unable to change > the frequency of this clock

Re: [PATCH 0/2] ARM: Exynos4: Migrate to common clock framework.

2012-10-07 Thread Thomas Abraham
Hi Tomasz, Thanks for reviewing this patch series. On 3 October 2012 16:26, Tomasz Figa wrote: > Hi Chander, Thomas, > > On Monday 01 of October 2012 17:39:19 chander.kash...@linaro.org wrote: >> From: Thomas Abraham >> >> This patch series migrates Exynos4 cl

Re: [PATCH v3 1/4] pinctrl: add samsung pinctrl and gpiolib driver

2012-09-05 Thread Thomas Abraham
On 5 September 2012 19:20, Tomasz Figa wrote: > Hi Thomas, > > Thomas Abraham wrote: >> Add a new device tree enabled pinctrl and gpiolib driver for Samsung >> SoC's. This driver provides a common and extensible framework for all >> Samsung SoC's to i

[PATCH v3 1/4] pinctrl: add samsung pinctrl and gpiolib driver

2012-09-04 Thread Thomas Abraham
nformation about the pins, pin groups, pin functions and gpio chips, which are SoC specific, are parsed from device tree node. Cc: Linus Walleij Cc: Kukjin Kim Signed-off-by: Thomas Abraham --- This is a repost of the v3 version of this patch and includes the fixes suggested by Stephen Wa

Re: [PATCH v3 1/4] pinctrl: add samsung pinctrl and gpiolib driver

2012-09-04 Thread Thomas Abraham
On 3 September 2012 16:44, Linus Walleij wrote: > On Thu, Aug 23, 2012 at 1:15 PM, Thomas Abraham > wrote: > >> Add a new device tree enabled pinctrl and gpiolib driver for Samsung >> SoC's. This driver provides a common and extensible framework for all >> Sam

Re: [PATCH v2 1/4] pinctrl: add samsung pinctrl and gpiolib driver

2012-08-27 Thread Thomas Abraham
On 28 August 2012 04:52, Linus Walleij wrote: > On Tue, Aug 21, 2012 at 9:22 PM, Thomas Abraham > wrote: [...] >>>> +/* list of all possible config options supported */ >>>> +struct pin_config { >>>> + char*prop_cfg; >>&g

Re: [PATCH v3 1/4] pinctrl: add samsung pinctrl and gpiolib driver

2012-08-23 Thread Thomas Abraham
On 24 August 2012 04:42, Stephen Warren wrote: > On 08/23/2012 05:15 AM, Thomas Abraham wrote: >> Add a new device tree enabled pinctrl and gpiolib driver for Samsung >> SoC's. This driver provides a common and extensible framework for all >> Samsung SoC's to

[PATCH v3 2/4] pinctrl: add exynos4210 specific extensions for samsung pinctrl driver

2012-08-23 Thread Thomas Abraham
: Thomas Abraham --- drivers/pinctrl/Kconfig |4 + drivers/pinctrl/Makefile |1 + drivers/pinctrl/pinctrl-exynos.c | 560 ++ drivers/pinctrl/pinctrl-exynos.h | 217 +++ 4 files changed, 782 insertions(+), 0 deletions

[PATCH v3 4/4] ARM: EXYNOS: skip wakeup interrupt setup if pinctrl driver is used

2012-08-23 Thread Thomas Abraham
Pinctrl driver includes support for configuring the external wakeup interrupts. On exynos platforms that use pinctrl driver, the setup of wakeup interrupts in the exynos platform code can be skipped. Cc: Kukjin Kim Signed-off-by: Thomas Abraham --- arch/arm/mach-exynos/common.c | 26

[PATCH v3 1/4] pinctrl: add samsung pinctrl and gpiolib driver

2012-08-23 Thread Thomas Abraham
nformation about the pins, pin groups, pin functions and gpio chips, which are SoC specific, are parsed from device tree node. Cc: Linus Walleij Cc: Kukjin Kim Signed-off-by: Thomas Abraham --- .../bindings/pinctrl/samsung-pinctrl.txt | 196 + drivers/pinct

[PATCH v3 3/4] gpio: exynos4: skip gpiolib registration if pinctrl driver is used

2012-08-23 Thread Thomas Abraham
Pinctrl driver, when enabled, registers all the gpio pins and hence the registration of gpio pins by this driver can be skipped. Signed-off-by: Thomas Abraham Acked-by: Grant Likely Acked-by: Linus Walleij --- drivers/gpio/gpio-samsung.c | 21 + 1 files changed, 21

[PATCH v3 0/4] pinctrl: add support for samsung pinctrl driver

2012-08-23 Thread Thomas Abraham
e pin-control driver. Thomas Abraham (4): pinctrl: add samsung pinctrl and gpiolib driver pinctrl: add exynos4210 specific extensions for samsung pinctrl driver gpio: exynos4: skip gpiolib registration if pinctrl driver is used ARM: EXYNOS: skip wakeup interrupt setup if pinctrl driver is

Re: [PATCH v2 1/4] pinctrl: add samsung pinctrl and gpiolib driver

2012-08-21 Thread Thomas Abraham
On 22 August 2012 03:08, Stephen Warren wrote: > On 08/21/2012 05:25 AM, Linus Walleij wrote: >> On Wed, Aug 15, 2012 at 9:57 PM, Thomas Abraham >> wrote: >> >>> Add a new device tree enabled pinctrl and gpiolib driver for Samsung >>> SoC's. >

Re: [PATCH v2 4/4] ARM: EXYNOS: skip wakeup interrupt setup if pinctrl driver is used

2012-08-21 Thread Thomas Abraham
On 21 August 2012 17:34, Linus Walleij wrote: > On Wed, Aug 15, 2012 at 9:57 PM, Thomas Abraham > wrote: > >> Pinctrl driver includes support for configuring the external wakeup >> interrupts. On exynos platforms that use pinctrl driver, the setup >> of wakeup interr

Re: [PATCH v2 3/4] gpio: exynos4: skip gpiolib registration if pinctrl driver is used

2012-08-21 Thread Thomas Abraham
On 21 August 2012 17:35, Linus Walleij wrote: > On Wed, Aug 15, 2012 at 9:57 PM, Thomas Abraham > wrote: > >> Pinctrl driver, when enabled, registers all the gpio pins and hence the >> registration of gpio pins by this driver can be skipped. >> >> Acked-by:

Re: [PATCH v2 2/4] pinctrl: add exynos4210 specific extensions for samsung pinctrl driver

2012-08-21 Thread Thomas Abraham
On 21 August 2012 17:32, Linus Walleij wrote: > On Wed, Aug 15, 2012 at 9:57 PM, Thomas Abraham > wrote: > >> Add information about the Exynos4210 pin banks and driver data which is >> used by the Samsung pinctrl driver. In addition to this, the support for >> externa

Re: [PATCH v2 1/4] pinctrl: add samsung pinctrl and gpiolib driver

2012-08-21 Thread Thomas Abraham
Hi Linus, Thanks for your time to review the Samsung pinctrl driver patches. I have inlined the reply to your comments. On 21 August 2012 16:55, Linus Walleij wrote: > On Wed, Aug 15, 2012 at 9:57 PM, Thomas Abraham > wrote: > >> Add a new device tree enabled pinctrl and gpi

Re: [PATCH v6 5/6] ARM: exynos: add thermal sensor driver platform data support

2012-08-16 Thread Thomas Abraham
; --- > drivers/thermal/exynos_thermal.c | 111 > +- > 1 files changed, 110 insertions(+), 1 deletions(-) Reviewed-by: Thomas Abraham Few minor comments inline below. > > diff --git a/drivers/thermal/exynos_thermal.c > b/drivers/thermal/exynos_thermal.c > i

[PATCH v2 2/4] pinctrl: add exynos4210 specific extensions for samsung pinctrl driver

2012-08-15 Thread Thomas Abraham
: Thomas Abraham --- drivers/pinctrl/Kconfig |7 + drivers/pinctrl/Makefile |1 + drivers/pinctrl/pinctrl-exynos.c | 555 ++ drivers/pinctrl/pinctrl-exynos.h | 213 +++ 4 files changed, 776 insertions(+), 0 deletions

[PATCH v2 4/4] ARM: EXYNOS: skip wakeup interrupt setup if pinctrl driver is used

2012-08-15 Thread Thomas Abraham
Pinctrl driver includes support for configuring the external wakeup interrupts. On exynos platforms that use pinctrl driver, the setup of wakeup interrupts in the exynos platform code can be skipped. Cc: Kukjin Kim Signed-off-by: Thomas Abraham --- arch/arm/mach-exynos/common.c | 26

[PATCH v2 3/4] gpio: exynos4: skip gpiolib registration if pinctrl driver is used

2012-08-15 Thread Thomas Abraham
Pinctrl driver, when enabled, registers all the gpio pins and hence the registration of gpio pins by this driver can be skipped. Acked-by: Grant Likely Acked-by: Linus Walleij Signed-off-by: Thomas Abraham --- drivers/gpio/gpio-samsung.c | 21 + 1 files changed, 21

[PATCH v2 1/4] pinctrl: add samsung pinctrl and gpiolib driver

2012-08-15 Thread Thomas Abraham
nformation about the pins, pin groups, pin functions and gpio chips, which are SoC specific, are parsed from device tree node. Cc: Linus Walleij Cc: Kukjin Kim Signed-off-by: Thomas Abraham --- .../bindings/pinctrl/samsung-pinctrl.txt | 176 drivers/pinct

[PATCH v2 0/4] pinctrl: add support for samsung pinctrl driver

2012-08-15 Thread Thomas Abraham
p the gpio pin registrations if pinctrl driver support is found to be enabled. The fourth patch skips the external wakeup interrupt configuration process in the Exynos4 platform code if the external wakeup interrupt support is provided by the pin-control driver. Thomas Abraham (4): pinctrl

Re: [PATCH 10/11] spi/s3c64xx: improve error handling

2012-08-09 Thread Thomas Abraham
ion [-Wuninitialized] > > Signed-off-by: Arnd Bergmann > Cc: Thomas Abraham > Cc: Jaswinder Singh > Cc: Grant Likely > Cc: Kukjin Kim > --- > drivers/spi/spi-s3c64xx.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/spi/spi-

Re: [PATCH 05/11] ARM: exynos: exynos_pm_add_dev_to_genpd may be unused

2012-08-09 Thread Thomas Abraham
utomatically discard > it. > > Without this patch, building exynos_defconfig results in: > > arch/arm/mach-exynos/pm_domains.c:118:123: warning: > 'exynos_pm_add_dev_to_genpd' defined but not used [-Wunused-function] > > Signed-off-by: Arnd Bergmann > Cc: Thomas A

Re: [PATCH 3/4] arm/dts: exynos4: Add DTS file for ODROID-X

2012-08-07 Thread Thomas Abraham
On 8 August 2012 00:42, Dongjin Kim wrote: > This patch create a DTS file for ODROID-X, it desribes PMIC max77686 and LED > gpios base. > > Signed-off-by: Dongjin Kim > --- > arch/arm/boot/dts/exynos4412-odroidx.dts | 148 > ++ > 1 file changed, 148 insertions(+) >

Re: [PATCH 2/4] arm/dts: exynos4: Add DTS files derived from common Exynos4

2012-08-07 Thread Thomas Abraham
On 8 August 2012 00:36, Dongjin Kim wrote: > This patch creates a DTS file, exynos4.dtsi, for Exynos4210/4x12 and it > describes common device nodes. SoC specific device nodes are described in > another DTS file derived from this, exynos4210.dtsi and exynos4412.dtsi. > > exynos4412.dtsi is added n

Re: [PATCH] ARM: EXYNOS: Add gpio functions for Exynos4412

2012-08-07 Thread Thomas Abraham
On 6 August 2012 19:27, Dongjin Kim wrote: > GPIO functions are not registered for Exynos4412 yet, > therefore exynos4_gpiolib_init() is added to initialize Exynos4412 SoC. > > Change-Id: I5945d94c6fbfc309ccf882eba067864a338c04ca > Signed-off-by: Dongjin Kim > --- > drivers/gpio/gpio-samsung.c |

Re: 회신: 회신: [PATCH] ODROID-X: hkdk4412: Add new hardware based on Exynos4412

2012-08-06 Thread Thomas Abraham
On 7 August 2012 07:58, Olof Johansson wrote: > Hi, > > On Mon, Aug 6, 2012 at 7:05 PM, Dongjin Kim > wrote: >> Hello, >> >> I am trying to understand what I have to do for device tree. >> >> In order to create dts file for ODROID-X hardware, it seems I may need dts >> file of EXYNOS4412 SoC. >>

Re: [PATCH] ODROID-X: hkdk4412: Add new hardware based on Exynos4412

2012-08-06 Thread Thomas Abraham
On 6 August 2012 19:40, Dongjin Kim wrote: > The HKDK4412 is the CPU module developed by Hardkernel which is based on > Exynos 4412. mach_hkdk4412.c is to run on ODROID-X hardware and Machine ID > (4289) is registered. > > Change-Id: I3af02808c03b9acea916c310390a4904ad92d761 > Signed-off-by: Dong

Re: [PATCH] gpio: samsung: Fix off-by-one bug in gpio addresses

2012-07-30 Thread Thomas Abraham
s.wall...@stericsson.com; >> linux-kernel@vger.kernel.org; >> ol...@chromium.org; Sangsu Park; Thomas Abraham; Kukjin Kim >> Subject: Re: [PATCH] gpio: samsung: Fix off-by-one bug in gpio addresses >> >> Acked-by: Doug Anderson >> >> --- >> &

Re: [PATCH v3 6/6] mmc: dw_mmc: add samsung exynos5250 specific extentions

2012-07-22 Thread Thomas Abraham
On 20 July 2012 16:08, Seungwon Jeon wrote: > July 20, 2012, Thomas Abraham wrote: >> On 19 July 2012 09:21, Seungwon Jeon wrote: [...] >> >> +static unsigned long exynos5250_dwmmc_caps[4] = { >> >> + MMC_CAP_UHS_DDR50 | MMC_CAP_1_8V_DDR | >&

Re: [PATCH v3 0/6] mmc: dw_mmc: add support for device tree based instantiation

2012-07-19 Thread Thomas Abraham
r Exynos SoC's for now. Splitting into different files will need to defined new callbacks which I fell is not really required. Thanks, Thomas. > > Best Regards, > Jaehoon Chung > > On 07/12/2012 09:54 PM, Thomas Abraham wrote: >> This patch series adds device tree suppor

Re: [PATCH v3 6/6] mmc: dw_mmc: add samsung exynos5250 specific extentions

2012-07-19 Thread Thomas Abraham
On 19 July 2012 09:21, Seungwon Jeon wrote: > Hi, > > This version does not seems to consider previous reviews fully. > Could you check the comments below? I did try to address all the comments. I will check again and resubmit if I have missed anything. > > July 12, 2012, Tho

[PATCH 3/9] mmc: dw_mmc: lookup for optional biu and ciu clocks

2012-07-17 Thread Thomas Abraham
Some platforms allow for clock gating and control of bus interface unit clock and card interface unit clock. Add support for clock lookup of optional biu and ciu clocks for clock gating and clock speed determination. Signed-off-by: Abhilash Kesavan Signed-off-by: Thomas Abraham --- drivers/mmc

[PATCH 5/9] mmc: dw_mmc: add device tree support

2012-07-17 Thread Thomas Abraham
Add device tree based discovery support. Signed-off-by: Thomas Abraham --- .../devicetree/bindings/mmc/synposis-dw-mshc.txt | 99 ++ drivers/mmc/host/dw_mmc-pltfm.c| 23 +++ drivers/mmc/host/dw_mmc.c | 201 +++- drivers

Re: [PATCH v3 5/6] mmc: dw_mmc: add device tree support

2012-07-17 Thread Thomas Abraham
On 16 July 2012 09:53, Chris Ball wrote: > Hi, > > On Thu, Jul 12 2012, Thomas Abraham wrote: >> diff --git a/Documentation/devicetree/bindings/mmc/synposis-dw-mshc.txt >> b/Documentation/devicetree/bindings/mmc/synposis-dw-mshc.txt >> new file mode 100644 >> i

Re: [PATCH v3 5/6] mmc: dw_mmc: add device tree support

2012-07-17 Thread Thomas Abraham
On 16 July 2012 09:45, Girish K S wrote: > On 12 July 2012 18:24, Thomas Abraham wrote: [...] >> >> +#ifdef CONFIG_OF >> +static struct dw_mci_drv_data synopsis_drv_data = { >> + .ctrl_type = DW_MCI_TYPE_SYNOPSIS, >> +}; >> + >> +static

[PATCH v3 2/6] mmc: dw_mmc: allow probe to succeed even if one slot is initialized

2012-07-12 Thread Thomas Abraham
Instead of aborting the probe in case a slot initialization fails, allow initialization of as many slots as possible. If there are atleast one instance of slot that is successfully initialized, allow the driver probe to succeed. Signed-off-by: Thomas Abraham --- drivers/mmc/host/dw_mmc.c | 23

[PATCH v3 3/6] mmc: dw_mmc: lookup for optional biu and ciu clocks

2012-07-12 Thread Thomas Abraham
Some platforms allow for clock gating and control of bus interface unit clock and card interface unit clock. Add support for clock lookup of optional biu and ciu clocks for clock gating and clock speed determination. Signed-off-by: Abhilash Kesavan Signed-off-by: Thomas Abraham --- drivers/mmc

[PATCH v3 5/6] mmc: dw_mmc: add device tree support

2012-07-12 Thread Thomas Abraham
Add device tree based discovery support. Signed-off-by: Thomas Abraham --- .../devicetree/bindings/mmc/synposis-dw-mshc.txt | 108 +++ drivers/mmc/host/dw_mmc-pltfm.c| 24 +++ drivers/mmc/host/dw_mmc.c | 201

[PATCH v3 6/6] mmc: dw_mmc: add samsung exynos5250 specific extentions

2012-07-12 Thread Thomas Abraham
extenstions. Signed-off-by: Abhilash Kesavan Signed-off-by: Thomas Abraham --- .../devicetree/bindings/mmc/synposis-dw-mshc.txt | 38 ++- drivers/mmc/host/dw_mmc-pltfm.c| 15 +++ drivers/mmc/host/dw_mmc.c | 40

[PATCH v3 4/6] mmc: dw_mmc: add quirk to indicate missing write protect line

2012-07-12 Thread Thomas Abraham
with device tree support enabled, such platform callbacks cannot be supported. Add a new quirk for notifying the driver about the missing write protect line so the driver can assume that the card write protection is disabled. Signed-off-by: Thomas Abraham Acked-by: Will Newton --- drivers/mmc

[PATCH v3 1/6] mmc: dw_mmc: convert copy of struct device in struct dw_mci to a reference

2012-07-12 Thread Thomas Abraham
dw_mci' is then incorrect. Fix this by converting the copy of 'struct device' in 'struct dw_mci' to a reference. Signed-off-by: Thomas Abraham --- drivers/mmc/host/dw_mmc-pci.c |2 +- drivers/mmc/host/dw_mmc-pltfm.c |2 +- drivers/mmc/host/dw_mmc.c | 56 +++

[PATCH v3 0/6] mmc: dw_mmc: add support for device tree based instantiation

2012-07-12 Thread Thomas Abraham
sixth patch add Samsung Exynos5250 specific extentions to the driver. This patchset is based on Samsung kernel tree's for-next branch with the mmc tree's mmc-next branch merged. Thomas Abraham (6): mmc: dw_mmc: convert copy of struct device in struct dw_mci to a reference mmc: dw_