RE: [PATCH 1/3] i2c: add DMA support for freescale i2c driver

Hi Marek, Thank you very much for your suggestion. -Original Message- From: Marek Vasut [mailto:ma...@denx.de] Sent: Friday, February 28, 2014 4:40 AM To: linux-arm-ker...@lists.infradead.org Cc: Yuan Yao-B46683; w...@the-dreams.de; mark.rutl...@arm.com; shawn@linaro.org;

RE: [PATCH 1/3] i2c: add DMA support for freescale i2c driver

Hi Marek, On Friday, February 28, 2014 at 06:19:18 AM, Yao Yuan wrote: [...] @@ -213,6 +238,7 @@ static struct imx_i2c_hwdata vf610_i2c_hwdata = { .ndivs = ARRAY_SIZE(vf610_i2c_clk_div), .i2sr_clr_opcode= I2SR_CLR_OPCODE_W1C

RE: [PATCH 1/3] i2c: add DMA support for freescale i2c driver

Hi, Marek Marek Vasut wrote: On Thursday, February 27, 2014 at 07:05:14 AM, Yuan Yao wrote: [...] +static void i2c_imx_dma_free(struct imx_i2c_struct *i2c_imx) { + struct imx_i2c_dma *dma = i2c_imx-dma; + struct dma_chan *dma_chan; + + dma_chan = dma-chan_tx; +

RE: [PATCH v2 1/2] i2c: add DMA support for freescale i2c driver

On Thu, March 06, 2014 at 11:23:50 AM, Marek Vasut wrote: On Wednesday, March 05, 2014 at 07:52:31 AM, Yuan Yao wrote: Add dma support for i2c. This function depend on DMA driver. You can turn on it by write both the dmas and dma-name properties in dts node. Signed-off-by: Yuan Yao

RE: [PATCH v2 1/2] i2c: add DMA support for freescale i2c driver

On Thu, March 06, 2014 at 12:44:14 PM, Marek Vasut wrote: On Thursday, March 06, 2014 at 05:36:14 AM, Yao Yuan wrote: On Thu, March 06, 2014 at 11:23:50 AM, Marek Vasut wrote: On Wednesday, March 05, 2014 at 07:52:31 AM, Yuan Yao wrote: Add dma support for i2c. This function depend

答复: [PATCH v2 1/2] i2c: add DMA support for freescale i2c driver

On Thursday, March 06, 2014 at 09:46:03 PM, Marek Vasut wrote: On Thursday, March 06, 2014 at 06:02:03 AM, Yao Yuan wrote: On Thu, March 06, 2014 at 12:44:14 PM, Marek Vasut wrote: On Thursday, March 06, 2014 at 05:36:14 AM, Yao Yuan wrote: On Thu, March 06, 2014 at 11:23:50 AM, Marek

RE: [PATCH v2 1/2] i2c: add DMA support for freescale i2c driver

On Thu, Mar 10, 2014 at 10:01:42 AM, Marek Vasut wrote: On Thu, Mar 06, 2014 at 12:57:42PM +0100, Marek Vasut wrote: On Thursday, March 06, 2014 at 06:02:03 AM, Yao Yuan wrote: On Thu, March 06, 2014 at 12:44:14 PM, Marek Vasut wrote: On Thursday, March 06, 2014 at 05:36:14 AM, Yao Yuan

RE: [PATCHv9 1/4] pwm: Add Freescale FTM PWM driver support

Subject: [PATCHv9 1/4] pwm: Add Freescale FTM PWM driver support The FTM PWM device can be found on Vybrid VF610 Tower and Layerscape LS-1 SoCs. Signed-off-by: Xiubo Li li.xi...@freescale.com --- For this patch series, Reviewed-by: Yuan Yao yao.y...@freescale.com Thanks. Hi

RE: [PATCH v3 1/2] i2c: add DMA support for freescale i2c driver

On Sunday, March 23, 2014 @ 11:50:00 AM, Marek Vasut wrote: On Thursday, March 13, 2014 at 02:47:56 AM, Yuan Yao wrote: Add dma support for i2c. This function depend on DMA driver. You can turn on it by write both the dmas and dma-name properties in dts node. Signed-off-by: Yuan Yao

RE: [PATCH v3 1/2] i2c: add DMA support for freescale i2c driver

On Wednesday, March 26, 2014 at 11:43:27 AM, Marek Vasut wrote: On Wednesday, March 26, 2014 at 04:08:27 AM, Yao Yuan wrote: [...] + i2c_imx-use_dma = false; + } else if (i2c_imx_dma_request(i2c_imx, (dma_addr_t)phy_addr)) { + dev_info(pdev-dev

RE: [PATCH v3 1/2] i2c: add DMA support for freescale i2c driver

On Wednesday, March 26, 2014 at 02:27:46 PM, Marek Vasut wrote: On Wednesday, March 26, 2014 at 06:56:34 AM, Yao Yuan wrote: On Wednesday, March 26, 2014 at 11:43:27 AM, Marek Vasut wrote: On Wednesday, March 26, 2014 at 04:08:27 AM, Yao Yuan wrote: [...] + i2c_imx

Re: [PATCH v4 1/2] i2c: add DMA support for freescale i2c driver

On Friday, April 04, 2014 at 22:29:32 PM, Marek Vasut wrote: On Friday, April 04, 2014 at 04:41:11 AM, Yuan Yao wrote: Add dma support for i2c. This function depend on DMA driver. You can turn on it by write both the dmas and dma-name properties in dts node. Signed-off-by: Yuan Yao

RE: [PATCH v5 1/2] i2c: add DMA support for freescale i2c driver

Marek Vasut wrote: On Wednesday, July 23, 2014 at 02:15:02 PM, Lothar Waßmann wrote: Hi, Varka Bhadram wrote: On 07/23/2014 04:41 PM, Yao Yuan wrote: Hi, Thanks for your review. Lothar Waßmann wrote: Yuan Yao wrote: Add dma support for i2c. This function

RE: [PATCH v5 1/2] i2c: add DMA support for freescale i2c driver

Hi, Thanks for your review. Lothar Waßmann wrote: Yuan Yao wrote: Add dma support for i2c. This function depend on DMA driver. You can turn on it by write both the dmas and dma-name properties in dts node. Signed-off-by: Yuan Yao yao.y...@freescale.com ---

RE: [PATCH v4 1/2] i2c: add DMA support for freescale i2c driver

On Fri, May 21, 2014 at 4:01 PM +0200, Wolfram Sang wrote: Ping. Any updates? I think this was pretty close to inclusion? Hi, Wolfram Thanks for your concern. Sorry for my reply so late. I had on a business trip for months. At that time I have no device to debug it. Now, I'm come back

RE: [PATCH v5 0/2] i2c: add DMA support for freescale i2c driver

Hi, Marek Vasut wrote: On Wednesday, July 23, 2014 at 10:24:41 AM, Yuan Yao wrote: Changed in v5: - add *chan_dev = dma-chan_using-device-dev for reduce the call time. Did you check if the compiler generates different code ? Sorry, I didn't compare the assembly code. It's a subtle

RE: [PATCH v6 1/2] i2c: imx: add DMA support for freescale i2c driver

Thanks for your review. Varka Bhadram wrote: On 08/05/2014 03:26 PM, Yuan Yao wrote: (...) +fail_rx: + dma_release_channel(dma-chan_rx); +fail_tx: + dma_release_channel(dma-chan_tx); +fail_al: + devm_kfree(dev, dma); no need to use devm_kfree() if we use devm_kzalloc()...

RE: [PATCH v6 1/2] i2c: imx: add DMA support for freescale i2c driver

Hi Fugang, Duan Fugang wrote: [...] + dma_sconfig.dst_addr_width = DMA_SLAVE_BUSWIDTH_1_BYTE; + dma_sconfig.dst_maxburst = 1; The maxburst is 1 cause very slow efficiency for DMA copy, which system performance even is slower Than cpu mode. There is no FIFO for IMX i2c, so the

RE: [PATCH v6 1/2] i2c: imx: add DMA support for freescale i2c driver

Hi Fugang, + /* Waiting for Transfer complete. */ + while (timeout--) { + temp = imx_i2c_read_reg(i2c_imx, IMX_I2C_I2SR); + if (temp I2SR_ICF) + break; + udelay(10); + } Whether there have better method like interrupt to avoid dead wait

RE: [PATCH v7 1/2] i2c: imx: add DMA support for freescale i2c driver

On Thursday, September 04, 2014 10:39 PM, Marek Vasut wrote: On Wednesday, August 13, 2014 at 11:46:54 AM, Yuan Yao wrote: Add dma support for i2c. This function depend on DMA driver. You can turn on it by write both the dmas and dma-name properties in dts node. DMA is optional, even DMA

RE: [PATCH v8 1/2] i2c: imx: add DMA support for freescale i2c driver

-Original Message- From: Wolfram Sang [mailto:w...@the-dreams.de] Sent: Friday, October 03, 2014 3:55 PM To: Yuan Yao-B46683 Cc: ma...@denx.de; l...@karo-electronics.de; mark.rutl...@arm.com; Duan Fugang-B38611; shawn@linaro.org; linux-kernel@vger.kernel.org; linux-

RE: [PATCH v7 1/2] i2c: imx: add DMA support for freescale i2c driver

On Friday, September 05, 2014 6:41 PM, Marek Vasut wrote: On Friday, September 05, 2014 at 12:32:40 PM, Yao Yuan wrote: [...] +static int i2c_imx_dma_write(struct imx_i2c_struct *i2c_imx, + struct i2c_msg *msgs) +{ + int result

RE: [PATCH v7 1/2] i2c: imx: add DMA support for freescale i2c driver

Hi Wolfram, I fixed the mentioned issues before in v7. Could you please help to review this patch? Thanks Regards Yuan Yao -Original Message- From: linux-arm-kernel [mailto:linux-arm-kernel-boun...@lists.infradead.org] On Behalf Of Yuan Yao Sent: Wednesday, August 13, 2014 5:47 PM

RE: [PATCH v7 1/2] i2c: imx: add DMA support for freescale i2c driver

On Wednesday, September 17, 2014 2:17 AM, Marek Vasut wrote: On Wednesday, September 10, 2014 at 04:48:01 PM, Yao Yuan wrote: On Friday, September 05, 2014 6:41 PM, Marek Vasut wrote: On Friday, September 05, 2014 at 12:32:40 PM, Yao Yuan wrote: [...] +static int

Re: [PATCH v7 1/2] i2c: imx: add DMA support for freescale i2c driver

Marek Vasut wrote: On Wednesday, September 17, 2014 at 04:50:34 PM, Yao Yuan wrote: [...] Would that mean that the crashed DMA would be running until the next transmission is scheduled ? [Yuan Yao] No, In fact any DMA timeout will result the failure of I2C transmission

RE: [PATCH v8 1/2] i2c: imx: add DMA support for freescale i2c driver

-Original Message- From: Duan Fugang-B38611 Sent: Thursday, September 25, 2014 5:25 PM To: Yuan Yao-B46683; w...@the-dreams.de; ma...@denx.de Cc: l...@karo-electronics.de; mark.rutl...@arm.com; shawn@linaro.org; linux-kernel@vger.kernel.org; linux-arm-ker...@lists.infradead.org;

RE: [PATCH v9 3/3] i2c: imx: add DMA support for freescale i2c driver

Hi Wolfram, I have fixed the issues in v9. Could you please help to review this patch? Thanks Regards Yuan Yao -Original Message- From: linux-arm-kernel [mailto:linux-arm-kernel- boun...@lists.infradead.org] On Behalf Of Yuan Yao Sent: Saturday, October 11, 2014 6:57 PM To:

RE: [PATCH v9 3/3] i2c: imx: add DMA support for freescale i2c driver

Thanks for your review. Your suggestions is really helpful. I will correct them in v10. Best Regards, Yuan Yao -Original Message- From: Wolfram Sang [mailto:w...@the-dreams.de] Sent: Sunday, November 09, 2014 1:35 AM To: Yuan Yao-B46683 Cc: ma...@denx.de; l...@karo-electronics.de;

RE: [PATCH v10 3/3] i2c: imx: add DMA support for freescale i2c driver

Hi Wolfram, Thank you for having found the bug, I indeed missed initializing it('orig_jiffies'). I will do more detailed review and send the v11 soon. Best Regards, Yuan Yao -Original Message- From: Wolfram Sang [mailto:w...@the-dreams.de] Sent: Tuesday, November 18, 2014 2:24 AM

RE: [PATCH 1/2] dmaengine: fsl-edma: add dma memcpy support

Hi Stefan, Thanks for your test. Yes, it's not a huge number. The number is always very small especially when the test_buf_size is small. For dmatest tool, the measure transmission time is far greater than the actual transmission time. So the number is small. In fact, the DMA with memory copy

RE: [PATCH 1/2] dma: Add Freescale qDMA engine driver support

Thanks for your review. I will fix it in the next version. Best Regards, Yuan Yao -Original Message- From: Paul Bolle [mailto:pebo...@tiscali.nl] Sent: Wednesday, March 18, 2015 2:57 AM To: Yuan Yao-B46683 Cc: vinod.k...@intel.com; shawn@linaro.org; dan.j.willi...@intel.com;

RE: [PATCH 1/2] dmaengine: fsl-edma: add dma memcpy support

Hi Vinod, Could you please take some times help to review the two patches? Thanks. Best Regards, Yuan Yao -Original Message- From: linux-arm-kernel [mailto:linux-arm-kernel-boun...@lists.infradead.org] On Behalf Of Jingchang Lu Sent: Wednesday, January 14, 2015 5:37 PM To: Lu

RE: [PATCH v2] dmaengine: fsl-edma: add PM suspend/resume support

On Sat, Aug 15, 2015 at 7:48 AM, pku.leo pku@gmail.com wrote: On Fri, Aug 14, 2015 at 1:24 AM, Yao Yuan yao.y...@freescale.com wrote: Hi Leo, Thanks for your review. About those two methods for DMA suspend that you have mentioned. We have a lot of the discussions in other DMA

RE: [PATCH v2] dmaengine: fsl-edma: add PM suspend/resume support

Hi Nigel, On Mon, Aug 17, 2015 at 2:49 PM, Nigel Cunningham ni...@nigelcunningham.com.au wrote: On 17/08/15 13:59, Yao Yuan wrote: On Sat, Aug 15, 2015 at 7:48 AM, pku.leo pku@gmail.com wrote: On Fri, Aug 14, 2015 at 1:24 AM, Yao Yuan yao.y...@freescale.com wrote: Hi Leo

RE: [PATCH v2] dmaengine: fsl-edma: add PM suspend/resume support

Hi Vinod, After our discuss, I have already send the v2. Could you please take some times help to review this patch again? Thanks. Best Regards, Yuan Yao -Original Message- From: linux-arm-kernel [mailto:linux-arm-kernel-boun...@lists.infradead.org] On Behalf Of Yuan Yao Sent:

RE: [PATCH v2] dmaengine: fsl-edma: add PM suspend/resume support

Hi Leo, Thanks for your review. About those two methods for DMA suspend that you have mentioned. We have a lot of the discussions in other DMA driver like DMA for Freescale PowerPC. Finally, we think the device which used the DMA transmission service should cancel the transmission service in

RE: [PATCH] dmaengine: fsl-edma: add PM suspend/resume support

Hi Arnd, Ok, I will remove the #ifdef in the next version. Thanks. Hi All, Is there any others comments? Thanks for your review. Best Regards, Yuan Yao On Wednesday, July 15, 2015 10:55 PM Arnd wrote: On Wednesday 15 July 2015 10:29:55 Yao Yuan wrote: Hi Arnd, Thanks for your review

RE: Re: [PATCH 2/2] dmaengine: fsl-edma: add PM suspend/resume support

Hi Vinod, Thanks for your review, now I will take over the eDMA. I have some different in understanding with PM suspend/resume support. And I will send a patch for RFC later. Also please check my comment in line for this patch. I hope you can help to review it for me. Thanks. Best Regards,

RE: Re: [PATCH 2/2] dmaengine: fsl-edma: add PM suspend/resume support

Hi Stefan, Thanks for your review, now I will take over the eDMA. I have some different in understanding with PM suspend/resume support. And I will send a patch for RFC later. Also please check my comment in line for this patch. I hope you can help to review it for me. Thanks. Best Regards,

RE: [PATCH] dmaengine: fsl-edma: add PM suspend/resume support

Hi Arnd, Thanks for your review. And can you give me more information? In my opinion, The fsl_edma_pm_state will just be used when CONFIG_PM support. So why not use the #ifdefs to remove the unnecessary code? Since the PM will not be selected in many use cases. Thanks. Best Regards, Yuan Yao

RE: [PATCH] dmaengine: fsl-edma: add PM suspend/resume support

Hi Vinod, eDMA sullpies the data transmission service for other IPs, so it should be suspended later and resumed earlier. For example: Synchronous Audio Interface (SAI), SAI use DMA to transfer the data. When suspend: 1, SAI using suspend handlers to stop the DMA transmission. 2, DMA using

RE: [PATCH 1/2] dma: Add Freescale qDMA engine driver support

Hi Vinod, Thanks for your review, please see my comments inline. Best Regards, Yuan Yao > -Original Message- > From: Vinod Koul [mailto:vinod.k...@intel.com] > Sent: Monday, October 05, 2015 10:37 PM > To: Yuan Yao-B46683 > Cc: shawn@linaro.org;

RE: [PATCH v3] dmaengine: fsl-edma: add PM suspend/resume support

Hi Vinod, Thanks for your review. I did the test and it seems that it should be ok when CONFIG_PM is not defined. So I removed the protection code to make it more readable. Do you think is it ok? Best Regards, Yuan Yao > -Original Message- > From: Vinod Koul

RE: [PATCH] mtd: spi-nor: fsl-quadspi: add big-endian support

On Wed, 2015-11-11 at 11:51 -0600, Han Xu wrote: > On Fri, Oct 30, 2015 at 04:49:41AM -0500, Yuan Yao-B46683 wrote: > > Hi Fabio Estevam, > > > > Thanks for your suggestion. > > We have an internal discussions for that. > > > > We think that: > > According to the initial commit message of regmap,

RE: [PATCH v2 1/3] dma: Add Freescale qDMA engine driver support

On Wed, Nov 11, 2015 4:14 PM, Vinod Koul wrote: > On Fri, Oct 23, 2015 at 09:59:11AM +0800, Yuan Yao wrote: > > > +config FSL_QDMA > > + tristate "Freescale qDMA engine support" > > + depends on SOC_LS1021A || ARCH_LAYERSCAPE > > Where is this ARCH defined, quick grep revealed none > This

RE: [PATCH] mtd: spi-nor: fsl-quadspi: add big-endian support

Hi Brian, Thanks for your information. Best Regards, Yuan Yao On Mon, Nov 16, 2015 at 12:22:30PM +, Brian Norris wrote: > On Mon, Nov 16, 2015 at 04:08:39AM +0000, Yao Yuan wrote: > > It looks like easier to read, use and change. > > Is it? > > It looks

RE: [PATCH] mtd: spi-nor: fsl-quadspi: add big-endian support

ddr); else iowrite32(val, addr); } It looks like easier to read, use and change. Is it? And David Woodhouse, Xu Han, Mark Brown is there any other comments from you? Thank. On Thu, Nov 12, 2015 3:04 AM Brian Norris wrote: > On Fri, Oct 30, 2015 at 09:49:41AM +0000, Yao Yuan

RE: [PATCH] mtd: spi-nor: fsl-quadspi: add big-endian support

Hi Fabio Estevam, Thanks for your suggestion. We have an internal discussions for that. We think that: According to the initial commit message of regmap, it is targeting non-memory mapped buses. (regmap: Add generic non-memory mapped register access API) But in the imx2_wdt driver, it is used

RE: [PATCH v2] dmaengine: fsl-edma: add PM suspend/resume support

On Thu, Aug 20, 2015 at 12:08:00PM +0800, Vinod Koul wrote: > On Mon, Aug 17, 2015 at 02:10:46PM -0500, Li Yang wrote: > > >> Think of it from the end user perspective. Would you like your > > >> laptop (or > > >> whatever) to refuse to suspend because of this condition? The user > > >> may well

RE: [PATCH] arm/dts: Add node for ina220 on LS1021ATWR

Thanks for your review. I will be care for other patches. Best Regards, Yuan Yao > -Original Message- > From: Shawn Guo [mailto:shawn...@kernel.org] > Sent: Thursday, September 24, 2015 8:05 PM > To: Yuan Yao-B46683 > Cc: linux-arm-ker...@lists.infradead.org;

RE: [PATCH v2] mtd: spi-nor: fsl-quadspi: add big-endian support

Hi Woodhouse, Norris, Do you have any comments for this patch? Thanks for your review. Best Regards, Yuan Yao > -Original Message- > From: Han Xu [mailto:han...@freescale.com] > Sent: Thursday, November 26, 2015 3:09 AM > To: Yuan Yao-B46683 > Cc:

Re: [PATCH v3 1/4] mtd: spi-nor: fsl-quadspi: add big-endian support

On Tue, Jan 05, 2015 at 04:58AM, Han Xu wrote: > On Thu, Dec 24, 2015 at 07:00:18PM +0800, Yuan Yao wrote: > > Add R/W functions for big- or little-endian registers: > > The qSPI controller's endian is independent of the CPU core's endian. > > So far, the qSPI have two versions for big-endian and

RE: [PATCH v2 1/4] Documentation: fsl-quadspi: Add fsl,ls2080a-dspi compatible string

On Wed, Dec 30, 2015 at 11:20 PM, Rob Herring wrote: > On Tue, Dec 29, 2015 at 9:17 PM, Yao Yuan <yao.y...@nxp.com> wrote: > > Hi Rob, > > > > Thanks for your review. > > So you mean that I should add the commit message for why I add this new > compatible? >

RE: [PATCH v2 1/4] Documentation: fsl-quadspi: Add fsl,ls2080a-dspi compatible string

Hi Rob, Thanks for your review. So you mean that I should add the commit message for why I add this new compatible? Best Regards, Yuan Yao On Wed, Dec 30, 2015 at 02:35AM, Rob Herring wrote: > On Thu, Dec 24, 2015 at 07:01:00PM +0800, Yuan Yao wrote: > > new compatible string:

RE: [PATCH] mtd: spi-nor: fsl-quadspi: add support for ls1021a

Ok. Thanks. -Original Message- From: Han Xu [mailto:han...@freescale.com] Sent: Wednesday, November 25, 2015 2:15 PM To: Yuan Yao-B46683 Cc: dw...@infradead.org; computersforpe...@gmail.com; linux-kernel@vger.kernel.org; linux-...@lists.infradead.org Subject:

RE: [PATCH 4/5] mtd: spi-nor: fsl-quadspi: add support for layerscape

Hi Allen, Yes, I will. In fact, I have already send the patch. This patch will add the new compatible entries in qspi driver for the ls1021a platform. Thanks for your review. Best Regards, Yuan Yao -Original Message- From: Han Xu [mailto:han...@freescale.com] Sent: Wednesday,

RE: [PATCH v4] dmaengine: fsl-edma: add PM suspend/resume support

Hi vinod, Thanks for your review. I have updated the patch as your comments before. And then send the v4. Do you have any comments for it? Thanks. Best Regards, Yuan Yao > -Original Message- > From: linux-arm-kernel [mailto:linux-arm-kernel-boun...@lists.infradead.org] > On Behalf Of

RE: [PATCH] dts/ls1021a: add the DTS for QSPI support

On Tue, Feb 02, 2016 at 03:49PM, Shawn Guo wrote: > On Thu, Jan 28, 2016 at 04:33:26PM +0800, Yuan Yao wrote: > > From: Yuan Yao > > > > Signed-off-by: Yuan Yao > > --- > > Add in v1: > > Can merge, but the function depend on the patch: > >

RE: mtd: spi-nor: fsl-quadspi: add support for ls1021a

On Thu, Jan 21, 2016 at 11:42 PM, Han Xu < xhnj...@gmail.com > wrote: > On Thu, Jan 21, 2016 at 1:53 AM, Yuan Yao wrote: > > This patch set is used for add the fsl-quadspi support for ls1021a and > > ls1043a, so remove the patch: > > mtd: spi-nor: fsl-quadspi: extend

Re: mtd: spi-nor: fsl-quadspi: add support for ls1021a

On Sun, Jan 24, 2016 05:17 AM +0800, Brian Norris wrote: On Fri, Jan 22, 2016 at 11:30:55AM -0600, Han Xu wrote: > On Fri, Jan 22, 2016 at 3:01 AM, Yao Yuan <yao.y...@nxp.com> wrote: > > On Thu, Jan 21, 2016 at 11:42 PM, Han Xu < xhnj...@gmail.com > wrote: > >> O

RE: [PATCH v3 1/4] Documentation: fsl-quadspi: Add fsl,ls2080a-dspi compatible string

On Fri, Jan 22, 2016 at 07:13 AM, Rob Herring wrote: > On Thu, Jan 21, 2016 at 03:09:15PM +0800, Yuan Yao wrote: > > new compatible string: "fsl,ls2080a-qspi". > > > > Signed-off-by: Yuan Yao > > --- > > Changed in v3: > > Add the modifier for new compatible string like: > >

RE: [PATCH 2/2] dts/ls2080a: Update DSPI compatible

s.infradead.org; linux-kernel@vger.kernel.org; > devicet...@vger.kernel.org; Yao Yuan <yao.y...@nxp.com> > Subject: [PATCH 2/2] dts/ls2080a: Update DSPI compatible > > From: Yuan Yao <yao.y...@nxp.com> > > The patch adds LS2085a to DSPI compatible. > The DSPI driver o

RE: [PATCH v6 1/2] Documentation: fsl: dspi: Add fsl,ls2080a-dspi compatible string

Hi Brian Norris, Could you please help to review and merge this patch? Thanks. > On 03/09/2016 08:59 PM, Yao Yuan wrote: > > > > new compatible string: "fsl,ls2080a-dspi". > > > > Signed-off-by: Yuan Yao <yao.y...@nxp.com> > > Acked-by: Rob He

RE: [PATCH 2/2] dts/ls1043a: add the DTS node for QSPI support

On Thu, Apr 12, 2016 at 10:50:01AM +0800, Shawn Guo wrote: > On Thu, Mar 31, 2016 at 02:45:01PM +0800, Yuan Yao wrote: > > From: Yuan Yao > > > > Signed-off-by: Yuan Yao > > Please style of 'arm64: dts: ls1043a: ' for subject prefix. > > > --- > >

RE: [PATCH v6 2/2] dts/ls2080a: update the DTS for QSPI and DSPI support

...@arm.com; Han > Xu <han...@nxp.com>; Yang-Leo Li <leoyang...@nxp.com>; > devicet...@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm- > ker...@lists.infradead.org; Yao Yuan <yao.y...@nxp.com> > Subject: Re: [PATCH v6 2/2] dts/ls2080a: update the DTS for QSPI an

RE: [PATCH v6 2/2] dts/ls2080a: update the DTS for QSPI and DSPI support

Hi All, Could you please help to review and merge this patch? Thanks. Best Regards, Yuan Yao On 03/09/2016 08:59 PM, Yao Yuan wrote: > > Signed-off-by: Yuan Yao <yao.y...@nxp.com> > Acked-by: Han xu <han...@nxp.com> > --- > Changed in v6: > No changes. >

RE: [PATCH v6 1/2] Documentation: fsl: dspi: Add fsl,ls2080a-dspi compatible string

Hi All, Could you please help to review and merge this patch? Thanks. On 03/09/2016 08:59 PM, Yao Yuan wrote: > > new compatible string: "fsl,ls2080a-dspi". > > Signed-off-by: Yuan Yao <yao.y...@nxp.com> > Acked-by: Rob Herring <r...@kernel.org>

RE: [PATCH v4 4/7] Documentation: fsl-quadspi: Add fsl,ls2080a-dspi compatible string

On Tue, Mar 08, 2016 at 4:32AM, Brian Norris wrote: > On Tue, Jan 26, 2016 at 03:23:58PM +0800, Yuan Yao wrote: > > new compatible string: "fsl,ls2080a-qspi". > > ^^ This line doesn't match the subject or the content of the patch. > > > Signed-off-by: Yuan Yao > > Acked-by:

RE: [PATCH v1 4/5] ARM: dts: ls1043a: add qDMA node

On Mon 29 August 2016 03:34:47, : Alexander Stein wrote: > On Thursday 18 August 2016 14:38:47, Yuan Yao wrote: > > From: Yuan Yao > > > > Add the QDMA node for ls1043a platform to support QDMA driver. > > > > Signed-off-by: Yuan Yao > > --- > >

RE: [PATCH v1 1/5] dma: Add QorIQ qDMA engine driver support

On Thu, Aug 18, 2016 at 05:16 PM +0800, Russell King wrote: > On Thu, Aug 18, 2016 at 02:38:44PM +0800, Yuan Yao wrote: > > + spin_lock(_comp->qchan->vchan.lock); > > + if (status == DMA_COMPLETE) > > +

RE: [PATCH v3 6/9] mtd: spi-nor: Support R/W for S25FS-S family flash

On Thu, Nov 18, 2016 at 12:31 PM, Han Xu wrote: > On Thu, Nov 17, 2016 at 3:14 AM, Yao Yuan <yao.y...@nxp.com> wrote: > > On Thu, Nov 17, 2016 at 06:50:55AM +, Krzeminski, Marcin (Nokia - > PL/Wroclaw) wrote: > >> > > > On Thu, Aug 18, 2016 at

RE: [PATCH v3 6/9] mtd: spi-nor: Support R/W for S25FS-S family flash

On Thu, Nov 17, 2016 at 10:14:55AM +, Krzeminski, Marcin (Nokia - PL/Wroclaw) wrote: > > On Thu, Nov 17, 2016 at 06:50:55AM +, Krzeminski, Marcin (Nokia - > > PL/Wroclaw) wrote: > > > > > > On Thu, Aug 18, 2016 at 2:38 AM, Yunhui Cui > > > > > > > > > > > > wrote: >

RE: [PATCH v3 6/9] mtd: spi-nor: Support R/W for S25FS-S family flash

On Thu, Nov 17, 2016 at 06:50:55AM +, Krzeminski, Marcin (Nokia - PL/Wroclaw) wrote: > > > > On Thu, Aug 18, 2016 at 2:38 AM, Yunhui Cui > > > > wrote: > > > > > From: Yunhui Cui > > > > > > > > > > With the physical sectors combination, S25FS-S

RE: [PATCH v3 6/9] mtd: spi-nor: Support R/W for S25FS-S family flash

On Thu, Nov 21, 2016 at 03:15 PM +0800, Krzeminski, Marcin (Nokia - PL/Wroclaw) wrote: > > -Original Message- > > From: Yao Yuan [mailto:yao.y...@nxp.com] > > Sent: Monday, November 21, 2016 7:28 AM > > To: Krzeminski, Marcin (Nokia - PL/Wroclaw) > > <mar

RE: [PATCH v3 6/9] mtd: spi-nor: Support R/W for S25FS-S family flash

On Thu, Nov 18, 2016 at 07:00 PM +, Krzeminski, Marcin (Nokia - PL/Wroclaw) wrote: > > -Original Message- > > From: Yao Yuan [mailto:yao.y...@nxp.com] > > Sent: Friday, November 18, 2016 5:20 AM > > To: Krzeminski, Marcin (Nokia - PL/Wroclaw) > > <mar

RE: [PATCH 5/5] Documentation: fsl-quadspi: Add fsl, ls1012a-qspi compatible string

On Thu, Dec 14, 2016 at 05:23:02PM +0800, Rob Herring wrote: > On Mon, Dec 12, 2016 at 8:47 PM, Yao Yuan <yao.y...@nxp.com> wrote: > > On Thu, Dec 13, 2016 at 05:23:02PM +0800, Rob Herring wrote: > >> On Thu, Dec 08, 2016 at 05:23:04PM +0800, Yuan Yao wrote: > >> &

RE: [PATCH 5/5] Documentation: fsl-quadspi: Add fsl, ls1012a-qspi compatible string

On Thu, Dec 13, 2016 at 05:23:02PM +0800, Rob Herring wrote: > On Thu, Dec 08, 2016 at 05:23:04PM +0800, Yuan Yao wrote: > > From: Yuan Yao > > Same problem in this subject too. > > > > > new compatible string: "fsl,ls1012a-qspi". > > > > Signed-off-by: Yuan Yao

RE: [PATCH 3/5] Documentation: dt: mtd: add chip support for "jedec, spi-nor"

On Thu, Dec 13, 2016 at 05:23:02PM +0800, Rob Herring wrote: > On Thu, Dec 08, 2016 at 05:23:02PM +0800, Yuan Yao wrote: > > From: Yuan Yao > > The compatible string is wrong in the subject. > > > > > "sst25wf040b" and "en25s64" are also chip compatible with SPI NOR flash. > >

RE: [PATCH] serial: fsl_lpuart: Remove the alias node dependence

On Wed, Jan 11, 2016 at 04:33:32PM +0800, Greg KH wrote: > On Wed, Dec 14, 2016 at 04:33:32PM +0800, Yuan Yao wrote: > > From: Yuan Yao > > > > Numbering the ttyLPn space should not depend on the generic name > > "serial". > > > > If don't add the alias node like:"serial0 = ",

RE: [PATCHv9 1/4] pwm: Add Freescale FTM PWM driver support

> Subject: [PATCHv9 1/4] pwm: Add Freescale FTM PWM driver support > > The FTM PWM device can be found on Vybrid VF610 Tower and Layerscape LS-1 > SoCs. > > Signed-off-by: Xiubo Li > --- For this patch series, Reviewed-by: Yuan Yao Thanks. > > > Hi Thierry, > > For this version I just

RE: [PATCH 1/3] i2c: add DMA support for freescale i2c driver

Hi Marek, Thank you very much for your suggestion. > -Original Message- > From: Marek Vasut [mailto:ma...@denx.de] > Sent: Friday, February 28, 2014 4:40 AM > To: linux-arm-ker...@lists.infradead.org > Cc: Yuan Yao-B46683; w...@the-dreams.de; mark.rutl...@arm.com; > shawn@linaro.org;

RE: [PATCH 1/3] i2c: add DMA support for freescale i2c driver

Hi Marek, > On Friday, February 28, 2014 at 06:19:18 AM, Yao Yuan wrote: > > [...] > > > > > @@ -213,6 +238,7 @@ static struct imx_i2c_hwdata vf610_i2c_hwdata > > > > = { > > > > > > > > .ndivs = ARR

RE: [PATCH 1/3] i2c: add DMA support for freescale i2c driver

Hi, Marek Marek Vasut wrote: > On Thursday, February 27, 2014 at 07:05:14 AM, Yuan Yao wrote: > > [...] > > > +static void i2c_imx_dma_free(struct imx_i2c_struct *i2c_imx) { > > + struct imx_i2c_dma *dma = i2c_imx->dma; > > + struct dma_chan *dma_chan; > > + > > + dma_chan = dma->chan_tx;

RE: [PATCH v2 1/2] i2c: add DMA support for freescale i2c driver

On Thu, March 06, 2014 at 11:23:50 AM, Marek Vasut wrote: > On Wednesday, March 05, 2014 at 07:52:31 AM, Yuan Yao wrote: > > Add dma support for i2c. This function depend on DMA driver. > > You can turn on it by write both the dmas and dma-name properties in > > dts node. > > > > Signed-off-by:

RE: [PATCH v2 1/2] i2c: add DMA support for freescale i2c driver

On Thu, March 06, 2014 at 12:44:14 PM, Marek Vasut wrote: > On Thursday, March 06, 2014 at 05:36:14 AM, Yao Yuan wrote: > > On Thu, March 06, 2014 at 11:23:50 AM, Marek Vasut wrote: > > > On Wednesday, March 05, 2014 at 07:52:31 AM, Yuan Yao wrote: > > > > Add dma

答复: [PATCH v2 1/2] i2c: add DMA support for freescale i2c driver

On Thursday, March 06, 2014 at 09:46:03 PM, Marek Vasut wrote: >On Thursday, March 06, 2014 at 06:02:03 AM, Yao Yuan wrote: > > On Thu, March 06, 2014 at 12:44:14 PM, Marek Vasut wrote: > > > On Thursday, March 06, 2014 at 05:36:14 AM, Yao Yuan wrote: > > > > On Thu,

Re: [PATCH v4 1/2] i2c: add DMA support for freescale i2c driver

On Friday, April 04, 2014 at 22:29:32 PM, Marek Vasut wrote: > On Friday, April 04, 2014 at 04:41:11 AM, Yuan Yao wrote: > > Add dma support for i2c. This function depend on DMA driver. > > You can turn on it by write both the dmas and dma-name properties in dts > > node. > > > > Signed-off-by:

RE: [PATCH v3 1/2] i2c: add DMA support for freescale i2c driver

On Sunday, March 23, 2014 @ 11:50:00 AM, Marek Vasut wrote: > On Thursday, March 13, 2014 at 02:47:56 AM, Yuan Yao wrote: > > Add dma support for i2c. This function depend on DMA driver. > > You can turn on it by write both the dmas and dma-name properties in > > dts node. > > > > Signed-off-by:

RE: [PATCH v3 1/2] i2c: add DMA support for freescale i2c driver

On Wednesday, March 26, 2014 at 11:43:27 AM, Marek Vasut wrote: > On Wednesday, March 26, 2014 at 04:08:27 AM, Yao Yuan wrote: > > [...] > > > > > + i2c_imx->use_dma = false; > > > > + } else if (i2c_imx_dm

RE: [PATCH v3 1/2] i2c: add DMA support for freescale i2c driver

On Wednesday, March 26, 2014 at 02:27:46 PM, Marek Vasut wrote: > On Wednesday, March 26, 2014 at 06:56:34 AM, Yao Yuan wrote: > > On Wednesday, March 26, 2014 at 11:43:27 AM, Marek Vasut wrote: > > > On Wednesday, March 26, 2014 at 04:08:27

RE: [PATCH v5 1/2] i2c: add DMA support for freescale i2c driver

Hi, Thanks for your review. Lothar Waßmann wrote: > Yuan Yao wrote: > > Add dma support for i2c. This function depend on DMA driver. > > You can turn on it by write both the dmas and dma-name properties in dts > > node. > > > > Signed-off-by: Yuan Yao > > --- > > drivers/i2c/busses/i2c-imx.c

RE: [PATCH v6 1/2] i2c: imx: add DMA support for freescale i2c driver

Thanks for your review. Varka Bhadram wrote: > On 08/05/2014 03:26 PM, Yuan Yao wrote: > > (...) > > +fail_rx: > > + dma_release_channel(dma->chan_rx); > > +fail_tx: > > + dma_release_channel(dma->chan_tx); > > +fail_al: > > + devm_kfree(dev, dma); > > no need to use devm_kfree() if we

RE: [PATCH v6 1/2] i2c: imx: add DMA support for freescale i2c driver

Hi Fugang, Duan Fugang wrote: [...] >+ dma_sconfig.dst_addr_width = DMA_SLAVE_BUSWIDTH_1_BYTE; >+ dma_sconfig.dst_maxburst = 1; > The maxburst is 1 cause very slow efficiency for DMA copy, which system > performance even is slower Than cpu mode. There is no FIFO for IMX i2c, so the

RE: [PATCH v6 1/2] i2c: imx: add DMA support for freescale i2c driver

Hi Fugang, > >> >+ /* Waiting for Transfer complete. */ > >> >+ while (timeout--) { > >> >+ temp = imx_i2c_read_reg(i2c_imx, IMX_I2C_I2SR); > >> >+ if (temp & I2SR_ICF) > >> >+ break; > >> >+ udelay(10); > >> >+ } > >> Whether there have better method like

RE: [PATCH v4 1/2] i2c: add DMA support for freescale i2c driver

On Fri, May 21, 2014 at 4:01 PM +0200, Wolfram Sang wrote: > > Ping. Any updates? I think this was pretty close to inclusion? Hi, Wolfram Thanks for your concern. Sorry for my reply so late. I had on a business trip for months. At that time I have no device to debug it. Now, I'm come

RE: [PATCH v5 0/2] i2c: add DMA support for freescale i2c driver

Hi, Marek Vasut wrote: > On Wednesday, July 23, 2014 at 10:24:41 AM, Yuan Yao wrote: > > Changed in v5: > > - add "*chan_dev = dma->chan_using->device->dev" for reduce the call time. > > Did you check if the compiler generates different code ? > Sorry, I didn't compare the assembly code. It's

RE: [PATCH v5 1/2] i2c: add DMA support for freescale i2c driver

Marek Vasut wrote: > On Wednesday, July 23, 2014 at 02:15:02 PM, Lothar Waßmann wrote: > > Hi, > > > > Varka Bhadram wrote: > > > On 07/23/2014 04:41 PM, Yao Yuan wrote: > > > > Hi, > > > > > > > > Thanks for your review. > >

RE: [PATCH v9 3/3] i2c: imx: add DMA support for freescale i2c driver

Thanks for your review. Your suggestions is really helpful. I will correct them in v10. Best Regards, Yuan Yao > -Original Message- > From: Wolfram Sang [mailto:w...@the-dreams.de] > Sent: Sunday, November 09, 2014 1:35 AM > To: Yuan Yao-B46683 > Cc: ma...@denx.de;

RE: [PATCH v10 3/3] i2c: imx: add DMA support for freescale i2c driver

Hi Wolfram, Thank you for having found the bug, I indeed missed initializing it('orig_jiffies'). I will do more detailed review and send the v11 soon. Best Regards, Yuan Yao > -Original Message- > From: Wolfram Sang [mailto:w...@the-dreams.de] > Sent: Tuesday, November 18, 2014 2:24

RE: [PATCH v7 1/2] i2c: imx: add DMA support for freescale i2c driver

On Wednesday, September 17, 2014 2:17 AM, Marek Vasut wrote: > On Wednesday, September 10, 2014 at 04:48:01 PM, Yao Yuan wrote: > > On Friday, September 05, 2014 6:41 PM, Marek Vasut wrote: > > > On Friday, September 05, 2014 at 12:32:40 PM, Yao Yuan wrote: > > > [...

  1   2   >