Re: [PATCH v11 2/6] ACPI: Add APEI GHES Table Generation support

2017-08-25 Thread gengdongjiu
Hi Shannon, On 2017/8/24 21:03, Shannon Zhao wrote: > > > On 2017/8/18 22:23, Dongjiu Geng wrote: >> This implements APEI GHES Table by passing the error CPER info >> to the guest via a fw_cfg_blob. After a CPER info is recorded, an >> SEA(Synchronous External Abort)/SEI(SError Interrupt)

Re: [PATCH v6 0/7] Add RAS virtualization support for SEA/SEI notification type in KVM

2017-09-04 Thread gengdongjiu
Hi James On 2017/9/1 1:43, James Morse wrote: > Hi Dongjiu Geng, > > On 28/08/17 11:38, Dongjiu Geng wrote: >> In the firmware-first RAS solution, corrupt data is detected in a >> memory location when guest OS application software executing at EL0 >> or guest OS kernel El1 software are reading

Re: [PATCH v6 1/7] arm64: cpufeature: Detect CPU RAS Extentions

2017-09-04 Thread gengdongjiu
James, On 2017/9/1 1:44, James Morse wrote: > Hi Dongjiu Geng, > > On 28/08/17 11:38, Dongjiu Geng wrote: >> From: Xie XiuQi >> >> ARM's v8.2 Extentions add support for Reliability, Availability and >> Serviceability (RAS). On CPUs with these extensions system software >> can use additional

Re: [PATCH v6 3/7] acpi: apei: remove the unused code

2017-09-04 Thread gengdongjiu
Hi James, On 2017/9/1 1:50, James Morse wrote: > Hi Dongjiu Geng, > > On 28/08/17 11:38, Dongjiu Geng wrote: >> In current code logic, the two functions ghes_sea_add() and >> ghes_sea_remove() are only called when CONFIG_ACPI_APEI_SEA >> is defined. If not, it will return errors in the

Re: [PATCH v6 4/7] arm64: kvm: support user space to query RAS extension feature

2017-09-05 Thread gengdongjiu
James, On 2017/9/1 2:04, James Morse wrote: > Hi Dongjiu Geng, > > On 28/08/17 11:38, Dongjiu Geng wrote: >> In ARMV8.2 RAS extension, a virtual SError exception syndrome >> register(VSESR_EL2) is added. This value may be specified from >> userspace. > > I agree that the CPU support for

[PATCH] arm64: KVM: VHE: save and restore some PSTATE bits

2017-09-05 Thread gengdongjiu
when exit from guest, some host PSTATE bits may be lost, such as PSTATE.PAN or PSTATE.UAO. It is because host and hypervisor all run in the EL2, host PSTATE value cannot be saved and restored via SPSR_EL2. So if guest has changed the PSTATE, host continues with a wrong value guest has set.

Re: [PATCH] arm64: KVM: VHE: save and restore some PSTATE bits

2017-09-05 Thread gengdongjiu
CC Catalin On 2017/9/6 2:58, gengdongjiu wrote: > when exit from guest, some host PSTATE bits may be lost, such as > PSTATE.PAN or PSTATE.UAO. It is because host and hypervisor all run > in the EL2, host PSTATE value cannot be saved and restored via > SPSR_EL2. So if guest has change

Re: [PATCH v11 4/6] target-arm: kvm64: detect guest RAS EXTENSION feature

2017-09-06 Thread gengdongjiu
Hi Peter, Thanks very much for your review, I will check your comments in detail and reply. On 2017/9/6 1:26, Peter Maydell wrote: > On 18 August 2017 at 15:23, Dongjiu Geng wrote: >> check if kvm supports guest RAS EXTENSION. if so, set >> corresponding feature bit for vcpu. >> >>

Re: [PATCH] arm64: KVM: VHE: save and restore some PSTATE bits

2017-09-06 Thread gengdongjiu
Hi Marc, On 2017/9/6 16:17, Marc Zyngier wrote: > On 05/09/17 19:58, gengdongjiu wrote: >> when exit from guest, some host PSTATE bits may be lost, such as >> PSTATE.PAN or PSTATE.UAO. It is because host and hypervisor all run >> in the EL2, host PSTATE value cannot be s

Re: [PATCH] arm64: KVM: VHE: save and restore some PSTATE bits

2017-09-06 Thread gengdongjiu
ate, __sysreg_restore_state_vhe, ARM64_HAS_VIRT_HOST_EXTN); void __hyp_text __sysreg_restore_host_state(struct kvm_cpu_context *ctxt) On 2017/9/6 17:32, gengdongjiu wrote: > Hi Marc, > > On 2017/9/6 16:17, Marc Zyngier wrote: >> On 05/09/17 19:58,

Re: [PATCH] acpi: apei: fix the wrongly parse generic error status block

2017-08-14 Thread gengdongjiu
Hi,Tyler, Yes, I will add a patch based on it, thanks a lot that you will also have a test. On 2017/8/14 22:04, Baicar, Tyler wrote: > This change works too, I think it just makes sense to have the iterations in > the CPER and GHES code match. Do you want to add a patch to your patch here

Re: [PATCH v2] acpi: apei: fix the wrongly iterate generic error status block

2017-08-15 Thread gengdongjiu
Loop more people to review the patch. 2017-08-15 19:15 GMT+08:00, Dongjiu Geng : > The revision 0x300 generic error data entry is different > from the old version, but currently iterating through the > GHES estatus blocks does not take into account this difference. > This will lead to failure to

Re: [PATCH v2] acpi: apei: fix the wrongly iterate generic error status block

2017-08-15 Thread gengdongjiu
Hi Borislav, > > ... and uses that accessor. > > Tyler? > > I'd prefer if you guys merge your two patches, Tyler's from > https://marc.info/?l=linux-acpi=150179595323038=2 and this one into > a single one. I think this patch has merged them to one. > > How does that sound? > > -- >

Re: [PATCH v2] acpi: apei: fix the wrongly iterate generic error status block

2017-08-15 Thread gengdongjiu
Borislav, 2017-08-16 0:32 GMT+08:00, Borislav Petkov : > On Wed, Aug 16, 2017 at 12:30:55AM +0800, gengdongjiu wrote: >> I think this patch has merged them to one. > > Look at both patches again. I ever discuss it with Tyler about it, as shown below link, thanks https://lkml.org

Re: [PATCH v2] acpi: apei: fix the wrongly iterate generic error status block

2017-08-15 Thread gengdongjiu
Hi Tyler , > Hello Boris, > > His patch fixes the define for apei_estatus_for_each_section which in turn > should fix ghes_do_proc(). So my patch should no longer be needed. I'm going > to test this out just to verify if fixes the issue I found. I have verified the issue about the iteration for

Re: [PATCH v2] acpi: apei: fix the wrongly iterate generic error status block

2017-08-16 Thread gengdongjiu
it. thanks. On 2017/8/16 7:26, Baicar, Tyler wrote: > On 8/15/2017 3:34 PM, gengdongjiu wrote: >> Hi Tyler , >> >>> Hello Boris, >>> >>> His patch fixes the define for apei_estatus_for_each_section which in turn >>> should fix ghes_do_proc()

Re: [PATCH v6 5/7] arm64: kvm: route synchronous external abort exceptions to el2

2017-09-14 Thread gengdongjiu
James, On 2017/9/8 0:31, James Morse wrote: > KVM already handles external aborts from lower exception levels, no more work > needs doing for TEA. If it is firmware first solution, that is SCR_EL3.EA=1, all SError interrupt and synchronous External Abort exceptions are taken to EL3, so EL3

Re: [PATCH v6 3/7] acpi: apei: remove the unused code

2017-09-14 Thread gengdongjiu
On 2017/9/14 20:35, James Morse wrote: >> James, whether it is possible you can review the previous v5 patch which >> adds the support for > Spreading 'current discussion' over two versions is a problem for anyone > trying > to follow this series. > > If you post a newer version its normal

Re: [PATCH v9 3/7] acpi: apei: Add SEI notification type support for ARMv8

2018-04-11 Thread gengdongjiu
Dear James, Thanks for this mail and sorry for my late response. 2018-02-16 1:55 GMT+08:00 James Morse : > Hi gengdongjiu, liu jun > > On 05/02/18 11:24, gengdongjiu wrote: [] >> >>> Is the emulated SError routed following the routing rules for HCR_EL2.{

Re: [PATCH v11 0/4] set VSESR_EL2 by user space and support NOTIFY_SEI notification

2018-04-12 Thread gengdongjiu
Hi James, thanks for this mail. On 2018/4/10 22:15, James Morse wrote: > Hi Dongjiu Geng, > > On 09/04/18 22:36, Dongjiu Geng wrote: >> 1. Detect whether KVM can set set guest SError syndrome >> 2. Support to Set VSESR_EL2 and inject SError by user space. >> 3. Support live migration to keep

Re: [PATCH v11 1/4] arm64: KVM: export the capability to set guest SError syndrome

2018-04-12 Thread gengdongjiu
HI James, Thanks for the review. 2018-04-10 22:15 GMT+08:00, James Morse : > Hi Dongjiu Geng, > > On 09/04/18 22:36, Dongjiu Geng wrote: >> Before user space injects a SError, it needs to know whether it can >> specify the guest Exception Syndrome, so KVM should tell user space >> whether it

Re: [PATCH v11 2/4] arm/arm64: KVM: Add KVM_GET/SET_VCPU_EVENTS

2018-04-12 Thread gengdongjiu
Hi James, Thanks for the comments. 2018-04-10 22:15 GMT+08:00, James Morse : > Hi Dongjiu Geng, > > On 09/04/18 22:36, Dongjiu Geng wrote: >> This new IOCTL exports user-invisible states related to SError. >> Together with appropriate user space changes, it can inject >> SError with specified

Re: [PATCH v9 3/7] acpi: apei: Add SEI notification type support for ARMv8

2018-04-13 Thread gengdongjiu
James, Thanks for this mail. On 2018/4/13 0:14, James Morse wrote: > Hi gengdongjiu, > > On 12/04/18 06:00, gengdongjiu wrote: >> 2018-02-16 1:55 GMT+08:00 James Morse : >>> On 05/02/18 11:24, gengdongjiu wrote: >>>>> Is the emulated SE

Re: [PATCH] arm64: rename the function arm64_is_ras_serror() to avoid confusion

2018-03-17 Thread gengdongjiu
Hi James, > Hi gengdongjiu, > > On 26/02/18 16:13, gengdongjiu wrote: > > 2018-02-24 1:58 GMT+08:00 James Morse : > >> On 22/02/18 18:02, Dongjiu Geng wrote: > >>> The RAS SError Syndrome can be Implementation-Defined, > >>> arm64_is_ras_se

Re: [PATCH v10 1/5] arm64: KVM: Prepare set virtual SEI syndrome value

2018-03-17 Thread gengdongjiu
Hi James, > > Hi Dongjiu Geng, > > On 03/03/18 16:09, Dongjiu Geng wrote: > > Export one API to specify virtual SEI syndrome value for guest, and > > add a helper to get the VSESR_EL2 value. > > This patch adds two helpers that nothing calls... its not big, please merge > it with the patch

Re: [PATCH v10 3/5] arm/arm64: KVM: Introduce set and get per-vcpu event

2018-03-18 Thread gengdongjiu
Hi James, Thanks for your review and good suggestion. > > Hi Dongjiu Geng, > > On 03/03/18 16:09, Dongjiu Geng wrote: > > RAS Extension provides VSESR_EL2 register to specify virtual SError > > syndrome value, this patch adds a new IOCTL to export user-invisible > > states related to SError

Re: [PATCH v10 2/5] arm64: KVM: export the capability to set guest SError syndrome

2018-03-18 Thread gengdongjiu
Hi James, Thanks for your time to review and give comments. [...] > > + > > +8.14 KVM_CAP_ARM_SET_SERROR_ESR > > + > > +Architectures: arm, arm64 > > + > > +This capability indicates that userspace can specify syndrome value > > +reported to guest OS when guest takes a virtual SError interrupt

Re: [PATCH v11 0/4] set VSESR_EL2 by user space and support NOTIFY_SEI notification

2018-04-18 Thread gengdongjiu
James, > >> I do not know when it is merge-window. About the apply version, it does not >> have limited. > > 'git fetch' Linus' tree and look at the tags. 'v4.16' lost its '-rc' suffixes, > and there isn't a 'v4.17-rc1' yet, so we are still in the merge window. > > Linus sends a message to

Re: [PATCH v9 5/7] arm64: kvm: Introduce KVM_ARM_SET_SERROR_ESR ioctl

2018-02-04 Thread gengdongjiu
James, Thank you for your time to reply me. On 2018/1/31 3:21, James Morse wrote: > Hi gengdongjiu, > > On 24/01/18 20:06, gengdongjiu wrote: >>> On 06/01/18 16:02, Dongjiu Geng wrote: >>>> The ARM64 RAS SError Interrupt(SEI) syndrome value is specific to the &

Re: [PATCH v9 3/7] acpi: apei: Add SEI notification type support for ARMv8

2018-02-05 Thread gengdongjiu
[...] > > > Yes, I know you are dong that. Your serial's patch will consider all above > things, right? > > Assuming I got it right, yes. It currently makes the race Xie XiuQi spotted > worse, > which I want to fix too. (details on the cover letter) Ok. > > > > If your patch can be consider

Re: [PATCH] arm64: rename the function arm64_is_ras_serror() to avoid confusion

2018-02-26 Thread gengdongjiu
Hi James, Thanks a lot for your review. 2018-02-24 1:58 GMT+08:00 James Morse : > Hi Dongjiu Geng, > > On 22/02/18 18:02, Dongjiu Geng wrote: >> The RAS SError Syndrome can be Implementation-Defined, >> arm64_is_ras_serror() is used to judge whether it is RAS SError, >> but

Re: [PATCH v9 5/7] arm64: kvm: Introduce KVM_ARM_SET_SERROR_ESR ioctl

2018-02-12 Thread gengdongjiu
Hi James, Thanks for the mail. On 2018/2/10 1:44, James Morse wrote: [...] > >> its ESR is 0, can not control the virtual SError's syndrom value, it does >> not have >> such registers to control that. > > My point was its more nuanced than this: the ARM-ARM's > TakeVirtualSErrorException()

Re: [PATCH v4] perf tools: Add ARM Statistical Profiling Extensions (SPE) support

2018-01-11 Thread gengdongjiu
On 2018/1/11 22:17, Adrian Hunter wrote: >> (e.g., via 'perf inject --itrace'), are also not supported >> >> - technically both cs-etm and spe can be used simultaneously, however >> disabled for simplicity in this release >> >> Signed-off-by: Kim Phillips > For what is there now, it looks

Re: [PATCH v4 2/3] arm64: kvm: route synchronous external abort exceptions to el2

2017-06-27 Thread gengdongjiu
correct the commit message: In the firmware-first RAS solution, OS receives an synchronous external abort, then trapped to EL3 by SCR_EL3.EA. Firmware inspects the HCR_EL2.TEA and chooses the target to send APEI's SEA notification. If the SCR_EL3.EA is set, delegates the error exception to

Re: [PATCH v4 3/3] arm64: kvm: inject SError with user space specified syndrome

2017-07-05 Thread gengdongjiu
Hi James, On 2017/7/4 18:14, James Morse wrote: > Hi gengdongjiu, > > Can you give us a specific example of an error you are trying to handle? For example: guest OS user space accesses device type memory, but happen SError. because the SError is asynchronous faults, it does not take im

Re: [PATCH v4] arm64: kvm: inject SError with user space specified syndrome

2017-07-03 Thread gengdongjiu
Hi Christoffer, thank you very much for your review. 2017-07-03 15:50 GMT+08:00, Christoffer Dall : > Hi Dongjiu, > > It seems you sent this patch twice, once on its own and then part of a > series? Christoffer, yes, it is. once on its own and then part of a series > > Also, please use a

Re: [PATCH v4 3/3] arm64: kvm: inject SError with user space specified syndrome

2017-07-03 Thread gengdongjiu
Hi Christoffer, thanks for the review. On 2017/7/3 16:39, Christoffer Dall wrote: > Hi Dongjiu, > > On Mon, Jun 26, 2017 at 08:46:39PM +0800, Dongjiu Geng wrote: >> when SError happen, kvm notifies user space to record the CPER, >> user space specifies and passes the contents of ESR_EL1 on

Re: [PATCH v4 2/3] arm64: kvm: route synchronous external abort exceptions to el2

2017-07-04 Thread gengdongjiu
Hi Christoffer, On 2017/7/3 16:23, Christoffer Dall wrote: > On Tue, Jun 27, 2017 at 08:15:49PM +0800, gengdongjiu wrote: >> correct the commit message: >> >> In the firmware-first RAS solution, OS receives an synchronous >> external abort, then trapped to EL3 by SC

Re: [PATCH v4 1/3] arm64: kvm: support user space to detect RAS extension feature

2017-07-04 Thread gengdongjiu
Hi Christoffer, On 2017/7/3 16:21, Christoffer Dall wrote: > On Mon, Jun 26, 2017 at 08:45:43PM +0800, Dongjiu Geng wrote: >> Handle userspace's detection for RAS extension, because sometimes >> the userspace needs to know the CPU's capacity > > Why? Can you please provide some more rationale.

Re: [PATCH v4 3/3] arm64: kvm: inject SError with user space specified syndrome

2017-07-04 Thread gengdongjiu
Hi James, Thanks for the review. I will read your comments carefully and then reply to you. On 2017/7/4 18:14, James Morse wrote: > Hi gengdongjiu, > > Can you give us a specific example of an error you are trying to handle? > How would a non-KVM user space process handle the err

Re: [PATCH RESEND] arm64: fault: avoid send SIGBUS two times

2017-12-06 Thread gengdongjiu
On 2017/12/7 0:15, Will Deacon wrote: >> --- a/arch/arm64/mm/fault.c >> +++ b/arch/arm64/mm/fault.c >> @@ -570,7 +570,6 @@ static int do_sea(unsigned long addr, unsigned int esr, >> struct pt_regs *regs) >> { >> struct siginfo info; >> const struct fault_info *inf; >> -int ret = 0;

Re: [PATCH v8 7/7] arm64: kvm: handle SError Interrupt by categorization

2017-12-06 Thread gengdongjiu
Hi James, On 2017/12/7 3:04, James Morse wrote: > Hi gengdongjiu, > > On 06/12/17 10:26, gengdongjiu wrote: >> On 2017/11/15 0:00, James Morse wrote: >>>> + * error has not been propagated >>>> + */ >>>> + run->

Re: [PATCH RESEND] arm64: fault: avoid send SIGBUS two times

2017-12-07 Thread gengdongjiu
Hi James, Will On 2017/12/7 22:32, James Morse wrote: > Hi gengdongjiu, Will, > > On 07/12/17 05:55, gengdongjiu wrote: >> On 2017/12/7 0:15, Will Deacon wrote: >>>> --- a/arch/arm64/mm/fault.c >>>> +++ b/arch/arm64/mm/fault.c >>>> @@ -5

[question] handle the page table RAS error

2017-12-03 Thread gengdongjiu
Hi all, Sorry to disturb you. Now the ARM64 has supported the RAS, when enabling this feature, we encounter a issue. If the user space application happen page table RAS error, Memory error handler(memory_failure()) will do nothing except make a poisoned page flag, and fault handler in

Re: [question] handle the page table RAS error

2017-12-04 Thread gengdongjiu
gengdongjiu : > Hi all, >Sorry to disturb you. Now the ARM64 has supported the RAS, when enabling > this feature, we encounter a issue. If the user space application happen page > table RAS error, > Memory error handler(memory_failure()) will do nothing except make a poison

Re: [RESEND PATCH] arm64: v8.4: Support for new floating point multiplication variant

2017-12-11 Thread gengdongjiu
On 2017/12/11 19:59, Dave P Martin wrote: > On Sat, Dec 09, 2017 at 03:28:42PM +, Dongjiu Geng wrote: >> ARM v8.4 extensions include support for new floating point >> multiplication variant instructions to the AArch64 SIMD > > Do we have any human-readable description of what the new

答复: [PATCH RESEND] arm64: fault: avoid send SIGBUS two times

2017-12-11 Thread gengdongjiu
Hi James, Thanks for your review and suggestion. > Hi gengdongjiu, > > On 08/12/17 04:43, gengdongjiu wrote: > > by the way, I think also change the info.si_code to "BUS_MCEERR_AR" is > > better, as shown [1]. > > BUS_MCEERR_AR can tell user s

Re: [RESEND PATCH] arm64: v8.4: Support for new floating point multiplication variant

2017-12-11 Thread gengdongjiu
On 2017/12/11 21:29, Dave Martin wrote: >> Thanks for the point out. >> In fact, this feature only adds two instructions: >> FP16 * FP16 + FP32 >> FP16 * FP16 - FP32 >> >> The spec call this bit to ID_AA64ISAR0_EL1.FHM, I do not know why it >> will call "FHM", I think call it "FMLXL" may be

Re: [RESEND PATCH] arm64: v8.4: Support for new floating point multiplication variant

2017-12-11 Thread gengdongjiu
On 2017/12/12 2:58, Suzuki K Poulose wrote: > Hi gengdongjiu > > Sorry for the late response. I have a similar patch to add the support for > "FHM", which I was about to post it this week. Suzuki, you are welcome. May be you can not post again to avoid the duplicate revie

Re: [RESEND PATCH V2] arm64: fault: avoid send SIGBUS two times

2017-12-11 Thread gengdongjiu
On 2017/12/12 11:31, Xie XiuQi wrote: >> +return 0; > It looks good to me. do_sea() has done all necessary action for SEA, so it > should always return 0, > no matter ghes_notify_sea() return true or false. yes, it is. > > Reviewed-by: Xie XiuQi Thanks XiuQi's review and comments. > >>

Re: [PATCH] arm64: KVM: Skip PSTATE.PAN reest at EL2 in non-VHE

2017-09-11 Thread gengdongjiu
Hi Vladimir, On 2017/9/11 19:20, Vladimir Murzin wrote: > On 11/09/17 12:16, Dongjiu Geng wrote: >> PSTATE.PAN disables reading and/or writing to a userspace virtual >> address from EL1 in non-VHE or from EL2 in VHE. In non-VHE, there is >> no any userspace mapping at EL2, so no need to reest the

Re: [PATCH v6 3/7] acpi: apei: remove the unused code

2017-09-11 Thread gengdongjiu
James, Thanks for the review. On 2017/9/9 2:17, James Morse wrote: > Hi gengdongjiu, > > On 04/09/17 12:43, gengdongjiu wrote: >> On 2017/9/1 1:50, James Morse wrote: >>> On 28/08/17 11:38, Dongjiu Geng wrote: >>>> In current code l

Re: [PATCH v11 6/6] target-arm: kvm64: Handle SError interrupt for the guest OS

2017-09-11 Thread gengdongjiu
Hi peter, > > On 18 August 2017 at 15:23, Dongjiu Geng wrote: > > When guest OS happens SError interrupt(SEI), it will trap to host. > > Host firstly calls memory failure to deal with this error and decide > > whether it needs to deliver SIGBUS signal to userspace. The advantage > > that using

Re: [PATCH] arm64: KVM: Skip PSTATE.PAN reest at EL2 in non-VHE

2017-09-12 Thread gengdongjiu
> On Mon, Sep 11 2017 at 7:16:52 pm BST, Dongjiu Geng > wrote: > > PSTATE.PAN disables reading and/or writing to a userspace virtual > > address from EL1 in non-VHE or from EL2 in VHE. In non-VHE, there is > > no any userspace mapping at EL2, so no need to reest the PSTATE.PAN. > > > >

Re: [PATCH] arm64: KVM: Skip PSTATE.PAN reest at EL2 in non-VHE

2017-09-12 Thread gengdongjiu
> [...] > > >> Nit: > >> In general it is not polite to keep posting patches in a middle of > >> the merge window - people are busy with more important stuff... > > I do not know when you are busy and in merge window > > But maybe it is about time you find out how we work if you intend to be a

Re: [PATCH v6 6/7] KVM: arm64: allow get exception information from userspace

2017-09-13 Thread gengdongjiu
Hi James, On 2017/9/8 0:30, James Morse wrote: > Hi Dongjiu Geng, > > On 28/08/17 11:38, Dongjiu Geng wrote: >> when userspace gets SIGBUS signal, it does not know whether >> this is a synchronous external abort or SError, > > Why would Qemu/kvmtool need to know if the original notification

Re: [PATCH v11 6/6] target-arm: kvm64: Handle SError interrupt for the guest OS

2017-09-13 Thread gengdongjiu
On 2017/9/12 0:39, Peter Maydell wrote: +return kvm_vcpu_ioctl(CPU(cpu), KVM_ARM_SEI, ); >>> This looks odd. If we don't have the RAS extension why do we need to do >>> anything at all here ? >> This is because Qemu may need to support non-RAS extension as discussed with >> ARM James

Re: [PATCH v6 5/7] arm64: kvm: route synchronous external abort exceptions to el2

2017-09-13 Thread gengdongjiu
On 2017/9/8 0:31, James Morse wrote: > Hi Dongjiu Geng, > > On 28/08/17 11:38, Dongjiu Geng wrote: >> ARMv8.2 adds a new bit HCR_EL2.TEA which controls to >> route synchronous external aborts to EL2, and adds a >> trap control bit HCR_EL2.TERR which controls to >> trap all Non-secure EL1&0

Re: [PATCH v11 6/6] target-arm: kvm64: Handle SError interrupt for the guest OS

2017-09-13 Thread gengdongjiu
On 2017/9/13 18:52, Peter Maydell wrote: > This question seems to be not really related to the review > comment that it is responding to. > > (1) If the host does not support notifying us about > errors, then there is clearly nothing to do in this > code, because we will never get a

Re: [PATCH v2] arm64: v8.4: Support for new floating point multiplication instructions

2017-12-12 Thread gengdongjiu
On 2017/12/12 22:53, Dave Martin wrote: >> +HWCAP_FHM > This needs to match the name of the #define in hwcap.h. Thanks for the comments, have changed it. > > With that change, Reviewed-by: Dave Martin Dave, appreciate for the review > > Cheers > ---Dave > >

Re: [RESEND PATCH V2] arm64: fault: avoid send SIGBUS two times

2017-12-12 Thread gengdongjiu
> Reviewed-by: James Morse > > > Nit: Your 'RESEND V2' and 'V2' are not the same patch. > 'RESEND' is to indicate you're reposting exactly the same patch, usually with > a > fixed CC list. Anyone who receives both can ignore one as you've said they are > the same. James, Thanks for the

Re: [PATCH v3] arm64: v8.4: Support for new floating point multiplication instructions

2017-12-13 Thread gengdongjiu
On 2017/12/13 18:09, Suzuki K Poulose wrote: >> Reviewed-by: Dave Martin > > Looks good to me. > > Reviewed-by: Suzuki K Poulose Thanks a lot to Suzuki's review.

RE:[PATCH] sched: Add trace for task wake up latency and leave running time

2020-09-02 Thread gengdongjiu
Hi Peter, Sorry for the late response. > > > diff --git a/include/linux/sched.h b/include/linux/sched.h index > > 93ecd930efd3..edb622c40a90 100644 > > --- a/include/linux/sched.h > > +++ b/include/linux/sched.h > > @@ -1324,6 +1324,13 @@ struct task_struct { > > /* CPU-specific state of

Re: [PATCH v9 3/7] acpi: apei: Add SEI notification type support for ARMv8

2018-01-23 Thread gengdongjiu
Hi James, On 2018/1/23 3:39, James Morse wrote: > Hi Dongjiu Geng, > > (versions of patches 1,2 and 4 have been queued by Catalin) > > (Nit 'ACPI / APEI:' is the normal subject prefix for ghes.c, this helps the > maintainers know which patches they need to pay attention to when you are >

Re: [PATCH v9 3/7] acpi: apei: Add SEI notification type support for ARMv8

2018-01-23 Thread gengdongjiu
sorry fix a typo. On 2018/1/23 17:23, gengdongjiu wrote: >> There are problems with doing this: >> >> Oct. 18, 2017, 10:26 a.m. James Morse wrote: >> | How do SEA and SEI interact? >> | >> | As far as I can see they can both interrupt each other, which isn't

Re: [PATCH v9 5/7] arm64: kvm: Introduce KVM_ARM_SET_SERROR_ESR ioctl

2018-01-24 Thread gengdongjiu
Hi James, Thanks a lot for your review and comments. > > Hi Dongjiu Geng, > > On 06/01/18 16:02, Dongjiu Geng wrote: > > The ARM64 RAS SError Interrupt(SEI) syndrome value is specific to the > > guest and user space needs a way to tell KVM this value. So we add a > > new ioctl. Before user

Re: [PATCH v9 6/7] arm64: kvm: Set Virtual SError Exception Syndrome for guest

2018-01-25 Thread gengdongjiu
Hi James, thanks for the review. On 2018/1/24 3:07, James Morse wrote: > Hi Dongjiu Geng, > > On 06/01/18 16:02, Dongjiu Geng wrote: >> RAS Extension add a VSESR_EL2 register which can provide >> the syndrome value reported to software on taking a virtual >> SError interrupt exception. This

Re: [PATCH v2] acpi: apei: Add SEI notification type support for ARMv8

2017-09-26 Thread gengdongjiu
Hi Tyler, Thank you very much for your test and comments. On 2017/9/27 3:23, Tyler Baicar wrote: >> should identify the address to a invalid value. >> >> Signed-off-by: Dongjiu Geng > Tested-by: Tyler Baicar > > Tested this functionality using SEA support. Thanks for your test. > >

Re: [PATCH v6 6/7] KVM: arm64: allow get exception information from userspace

2017-09-27 Thread gengdongjiu
Hi James, Sorry for my late response, thank you very much for comments. On 2017/9/23 0:51, James Morse wrote: [.] >> >> CC Achin >> >> I have some personal opinion, if you think it is not right, hope you can >> point out. >> >> Synchronous External Abort and SError Interrupt are hardware

Re: [PATCH v2] acpi: apei: Add SEI notification type support for ARMv8

2017-09-27 Thread gengdongjiu
Tyler, Stephen On 2017/9/27 3:23, Tyler Baicar wrote: >> Signed-off-by: Dongjiu Geng > Tested-by: Tyler Baicar > > Tested this functionality using SEA support. > > ++Stephen, > > Something to be aware of, this patch will conflict with > https://lkml.org/lkml/2017/9/14/663 > It may make

Re: [PATCH v6 6/7] KVM: arm64: allow get exception information from userspace

2017-09-27 Thread gengdongjiu
>> What you may be seeing is some awkwardness with the change in the SError ESR >> with v8.2. Previously the VSE mechanism injected an impdef SError, (but they >> were all impdef so it didn't matter). >> With VSESR_EL2 KVM has to specify one, and all-zeros is a bad choice as this >> means

Re: [PATCH v6 6/7] KVM: arm64: allow get exception information from userspace

2017-10-19 Thread gengdongjiu
On 2017/10/7 1:31, James Morse wrote: > Hi gengdongjiu, > > On 27/09/17 12:07, gengdongjiu wrote: >> On 2017/9/23 0:51, James Morse wrote: >>> If this wasn't a firmware-first notification, then you're right KVM hands >>> the >>> guest an asynchronou

Re: [PATCH v7 1/4] arm64: kvm: route synchronous external abort exceptions to EL2

2017-10-20 Thread gengdongjiu
Hi james, Thanks for the mail and sorry for my late response. 2017-10-19 1:21 GMT+08:00, James Morse : > Hi Dongjiu Geng, > > On 17/10/17 15:14, Dongjiu Geng wrote: >> ARMv8.2 adds a new bit HCR_EL2.TEA which controls to >> route synchronous external aborts to EL2, and adds a >> trap control

Re: [PATCH v7] acpi: apei: remove the unused dead-code for SEA/NMI notification type

2017-10-22 Thread gengdongjiu
On 2017/10/21 20:15, Borislav Petkov wrote: >> Signed-off-by: Dongjiu Geng >> Tested-by: Tyler Baicar >> Signed-off-by: Borislav Petkov > I gave you Reviewed-by, not Signed-off-by. > > Before you send more patches, read this: > > Documentation/process/submitting-patches.rst > > You can

Re: [RESEND PATCH v7] acpi: apei: remove the unused dead-code for SEA/NMI notification type

2017-10-22 Thread gengdongjiu
On 2017/10/22 17:38, Rafael J. Wysocki wrote: >> Tested-by: Tyler Baicar >> Reviewed-by: Borislav Petkov > I applied one of the previous iterations. > > Do I need to replace it with this version? > Thanks a lot Rafael's applying. Both for me is OK. If Borislav agreed, may be not. I will pay

Re: [RESEND PATCH v7] acpi: apei: remove the unused dead-code for SEA/NMI notification type

2017-10-22 Thread gengdongjiu
On 2017/10/22 17:38, Rafael J. Wysocki wrote: > On Sun, Oct 22, 2017 at 8:54 AM, Dongjiu Geng wrote: >> For the SEA notification, the two functions ghes_sea_add() and >> ghes_sea_remove() are only called when CONFIG_ACPI_APEI_SEA >> is defined. If not, it will return errors in the ghes_probe()

Re: [PATCH v8 0/7] Support RAS virtualization in KVM

2017-11-15 Thread gengdongjiu
Hi James, Thank you very much for your comments and review. On 2017/11/15 0:00, James Morse wrote: > Hi Dongjiu Geng, > > On 10/11/17 19:54, Dongjiu Geng wrote: >> This series patches mainly do below things: >> >> 1. Trap RAS ERR* registers Accesses to EL2 from Non-secure EL1, >>KVM will

Re: [PATCH v8 7/7] arm64: kvm: handle SError Interrupt by categorization

2017-11-15 Thread gengdongjiu
Hi James, Thanks a lot for the review. On 2017/11/15 0:00, James Morse wrote: > Hi Dongjiu Geng, > > On 10/11/17 19:54, Dongjiu Geng wrote: >> If it is not RAS SError, directly inject virtual SError, >> which will keep the old way. If it is RAS SError, firstly >> let host ACPI module to

Re: [PATCH v5 1/3] arm64/ras: support sea error recovery

2018-02-08 Thread gengdongjiu
On 2018/2/8 3:03, James Morse wrote: > Hi Xie XiuQi, > > On 30/01/18 19:19, James Morse wrote: >> On 26/01/18 12:31, Xie XiuQi wrote: >>> With ARM v8.2 RAS Extension, SEA are usually triggered when memory errors >>> are consumed. According to the existing process, errors occurred in the >>>

Re: [PATCH v8 7/7] arm64: kvm: handle SError Interrupt by categorization

2018-01-20 Thread gengdongjiu
Hi James, Sorry for my late response due to out of office recently. 2018-01-13 2:05 GMT+08:00 James Morse : > Hi gengdongjiu, > > On 15/12/17 03:30, gengdongjiu wrote: >> On 2017/12/7 14:37, gengdongjiu wrote: >>>> We need to tackle (1) and (3) separatel

Re: [PATCH v8 7/7] arm64: kvm: handle SError Interrupt by categorization

2018-01-20 Thread gengdongjiu
2018-01-13 2:05 GMT+08:00 James Morse : > Hi gengdongjiu, > > On 16/12/17 04:47, gengdongjiu wrote: >> [...] >>> >>>> + case ESR_ELx_AET_UER: /* The error has not been propagated */ >>>> + /* >>>> +

Re: [PATCH v8 7/7] arm64: kvm: handle SError Interrupt by categorization

2018-01-20 Thread gengdongjiu
2018-01-15 16:33 GMT+08:00 Christoffer Dall : > On Fri, Jan 12, 2018 at 06:05:23PM +, James Morse wrote: >> On 15/12/17 03:30, gengdongjiu wrote: >> > On 2017/12/7 14:37, gengdongjiu wrote: > > [...] > >> >> (I recall someone saying migration is needed

consult a question about action_result() in memory_failure()

2017-10-24 Thread gengdongjiu
Hi Naoya, very sorry to disturb you, I want to consult you about the handing to error page type in memory_failure(). If the error page is the current task's page table, will the memory_failure not handling that? >From my test, I found the memory_failure() consider the error page table

Re: [PATCH v8 7/7] arm64: kvm: handle SError Interrupt by categorization

2018-01-16 Thread gengdongjiu
Hi Christoffer On 2018/1/15 16:33, Christoffer Dall wrote: > On Fri, Jan 12, 2018 at 06:05:23PM +, James Morse wrote: >> On 15/12/17 03:30, gengdongjiu wrote: >>> On 2017/12/7 14:37, gengdongjiu wrote: > > [...] > >> >> (I recall someone saying

Re: [PATCH v8 7/7] arm64: kvm: handle SError Interrupt by categorization

2018-01-16 Thread gengdongjiu
Hi James, thanks very much for your mail and reply, I will check it ASAP. Due to recently busy with other thing, so reply may be late. On 2018/1/13 2:05, James Morse wrote: > Hi gengdongjiu, > > On 16/12/17 04:47, gengdongjiu wrote: >> [...] >>> >>>> +

Re: [PATCH RESEND v4 2/2] arm/arm64: KVM: Add KVM_GET/SET_VCPU_EVENTS

2018-06-18 Thread gengdongjiu
> On 12/06/18 15:50, gengdongjiu wrote: > > On 2018/6/11 21:36, James Morse wrote: > >> On 08/06/18 20:48, Dongjiu Geng wrote: > >>> For the migrating VMs, user space may need to know the exception > >>> state. For example, in the machine A, KVM make an SE

Re: [PATCH v5 2/2] arm64: KVM: export the capability to set guest SError syndrome

2018-07-01 Thread gengdongjiu
Hi James, On 2018/6/29 23:58, James Morse wrote: > Hi Dongjiu Geng, > > This patch doesn't apply on v4.18-rc2. > > Documentation/virtual/kvm/api.txt already has a 8.18 section. I guess you > based > this on v4.17. Yes, indeed I based on v4.17. > > For posting patches, please use the latest

hrtimer become inaccurate with RT patch

2018-07-02 Thread gengdongjiu
Hi Thomas/Anna/John, Recently I found that the hrtimer become inaccurate when there is a RT process runs on the same cpu core, and the kernel has applied preempt_rt patch. The Linux kernel version is v4.1.46, and the preempt_rt patch is patch-4.1.46-rt52.patch. I know that in the preempt_rt

Re: hrtimer become inaccurate with RT patch

2018-07-02 Thread gengdongjiu
Hi Sebastian , Thanks for the answer. On 2018/7/2 18:14, Sebastian Andrzej Siewior wrote: > On 2018-07-02 17:34:34 [+0800], gengdongjiu wrote: >> The Linux kernel version is v4.1.46, and the preempt_rt patch is >> patch-4.1.46-rt52.patch. > > the 4.1 series is no long

Re: [PATCH] usb: xhci: remove the code build warning

2018-06-05 Thread gengdongjiu
On 2018/6/5 16:40, Greg KH wrote: > On Wed, Jun 06, 2018 at 12:35:00AM +0800, Dongjiu Geng wrote: >> Initialize the 'err' variate to remove the build warning, >> the warning is shown as below: >> >> drivers/usb/host/xhci-tegra.c: In function ‘tegra_xusb_mbox_thread’: >>

Re: Resend: How to handle the SMMU RAS Error in the kernel

2018-11-21 Thread gengdongjiu
Hi James, Thanks for the mail. On 2018/11/20 2:05, James Morse wrote: > Hi gengdongjiu, > > On 17/11/2018 15:41, gengdongjiu wrote: >> In the current kernel, it only handles three kinds of error, which is >> memory error, PCIE device and ARM process. But now the SM

Re: [RFC RESEND PATCH] kvm: arm64: export memory error recovery capability to user space

2018-12-14 Thread gengdongjiu
HI James, Thanks for the mail and comments, I will reply to you in the next mail. 2018-12-14 21:55 GMT+08:00, James Morse : > Hi Dongjiu Geng, > > On 14/12/2018 10:15, Dongjiu Geng wrote: >> When user space do memory recovery, it will check whether KVM and >> guest support the error

Re: [RFC RESEND PATCH] kvm: arm64: export memory error recovery capability to user space

2018-12-14 Thread gengdongjiu
> > On Fri, 14 Dec 2018 at 13:56, James Morse wrote: > > > > Hi Dongjiu Geng, > > > > On 14/12/2018 10:15, Dongjiu Geng wrote: > > > When user space do memory recovery, it will check whether KVM and > > > guest support the error recovery, only when both of them support, > > > user space will do

撤回: [RFC RESEND PATCH] kvm: arm64: export memory error recovery capability to user space

2018-12-14 Thread gengdongjiu
gengdongjiu 将撤回邮件“[RFC RESEND PATCH] kvm: arm64: export memory error recovery capability to user space”。

Re: [RFC RESEND PATCH] kvm: arm64: export memory error recovery capability to user space

2018-12-14 Thread gengdongjiu
> > On Fri, 14 Dec 2018 at 13:56, James Morse wrote: > > > > Hi Dongjiu Geng, > > > > On 14/12/2018 10:15, Dongjiu Geng wrote: > > > When user space do memory recovery, it will check whether KVM and > > > guest support the error recovery, only when both of them support, > > > user space will

Re: [PATCH RESEND v2] arm64: clean the additional checks before calling ghes_notify_sea()

2018-08-09 Thread gengdongjiu
2018-08-10 5:05 GMT+08:00 Tyler Baicar : > On Thu, Aug 9, 2018 at 8:32 AM, gengdongjiu wrote: >> >> 2018-08-08 0:26 GMT+08:00 Dongjiu Geng : >> > In order to remove the additional check before calling the >> > ghes_notify_sea(), make stub definition when !CONF

Re: [PATCH] arm64: clean the additional checks before calling ghes_notify_sea()

2018-08-04 Thread gengdongjiu
2018-07-27 18:06 GMT+08:00 Will Deacon : > On Thu, Jul 26, 2018 at 05:01:47PM -0400, Dongjiu Geng wrote: >> In order to remove the additional check before calling the >> ghes_notify_sea(), make stub definition when !CONFIG_ACPI_APEI_SEA. >> >> Signed-off-by: Dongjiu Geng >> --- > > Acked-by: Will

Re: [PATCH] arm64: clean the additional checks before calling ghes_notify_sea()

2018-08-07 Thread gengdongjiu
On 2018/8/6 22:26, Will Deacon wrote: >> Will, >> This patch will be applied, right? thanks > I haven't queued it in the arm64 tree, since it touches include/acpi/ghes.h > and you don't have an ack from the acpi folks. I acked it so that you could > route it via the acpi tree without me

Re: [PATCH RESEND v2] arm64: clean the additional checks before calling ghes_notify_sea()

2018-08-09 Thread gengdongjiu
CC Borislav 2018-08-08 0:26 GMT+08:00 Dongjiu Geng : > In order to remove the additional check before calling the > ghes_notify_sea(), make stub definition when !CONFIG_ACPI_APEI_SEA. > > After this cleanup, we can simply call the ghes_notify_sea() to let > APEI driver handle the SEA

Re: [RFC RESEND PATCH] kvm: arm64: export memory error recovery capability to user space

2019-01-10 Thread gengdongjiu
Hi James/Peter, thanks for this discussion, and sorry for my late response due to vacation. On 2018/12/22 2:17, James Morse wrote: > Hi Peter, > > On 19/12/2018 19:02, Peter Maydell wrote: >> On Mon, 17 Dec 2018 at 15:56, James Morse wrote: >>> I don't think this really matters. Its only the

<    1   2   3   4   5   >