ned-off-by: Krzysztof Kozlowski
> ---
Acked-by: Charles Keepax
Thanks,
Charles
get(), which will not change the runtime
> PM counter on error.
>
> Signed-off-by: Dinghao Liu
> ---
Acked-by: Charles Keepax
Wow, did not realise that was how that worked. Thanks for fixing
up.
Thanks,
Charles
s accordingly.
>
> Fixes: 5513b411ea5b ("Documentation: rename pinctl to pin-control")
> Signed-off-by: Mauro Carvalho Chehab
> ---
Acked-by: Charles Keepax
Thanks,
Charles
he best choice.
>
> So search available sysclk_divs from 2 to 1 other than from 1 to 2.
>
> Fixes: 84fdc00d519f ("ASoC: codec: wm9860: Refactor PLL out freq search")
> Signed-off-by: Shengjiu Wang
> ---
Acked-by: Charles Keepax
Thanks,
Charles
gt;
> wm8962 3-001a: Unsupported BCLK ratio 9
>
> Fix this by relaxing bitclk divider searching, so that when
> no exact value can be derived from sysclk pick the closest
> value greater than expected bitclk.
>
> Signed-off-by: Shengjiu Wang
> Reviewed-by: Daniel Baluta
&
* 4;
> if (target < 9000) {
> pll->outdiv = 1;
> --
> 2.26.2
>
Content of the patch looks good, the commit message might need a
little work. The subject line needs to be appropriate for the
subsystem. Would be better to start with "ASoC: wm8955: " and
typo is a more standard term than spello :-)
Thanks,
Charles
or nit but it would probably be nice to have some
equivalent debug statement that prints out the actual BCLK we end
up with. There are a couple of statements printing the requested
speed, but nothing that will output what the driver actually
applies after this change.
Otherwise I think the change looks good.
Thanks,
Charles
moved in wm8960_configure_sysclk,
> then wm8960_configure_pll can be called, and there is also bitclk relax
> function in wm8960_configure_pll.
>
> Fixes: 3c01b9ee2ab9 ("ASoC: codec: wm8960: Relax bit clock computation")
> Signed-off-by: Shengjiu Wang
> Signed-off-by: Daniel Baluta
> ---
Acked-by: Charles Keepax
Thanks,
Charles
e machine driver on which rates/bit depths/channels are
supported.
Thanks,
Charles
--
IHR E-MAIL-KONTO WURDE FÜR EINE SPENDE VON 3.500.000,00 USD FÜR
CHARITY AUSGEWÄHLT. Antworten Sie auf die folgende E-Mail, um weitere
Informationen zu erhalten
E-Mail: charlesjackson...@gmail.com
This callback structure has never been used and it is not clear why it
was added in the first place. Remove it to clear up the code a little.
Signed-off-by: Charles Keepax
---
sound/soc/codecs/wm_adsp.c | 10 --
1 file changed, 10 deletions(-)
diff --git a/sound/soc/codecs/wm_adsp.c b
Robot
> Signed-off-by: Wei Yongjun
> ---
Acked-by: Charles Keepax
Thanks,
Charles
--
IHR E-MAIL-KONTO WURDE FÜR EINE SPENDE VON 3.500.000,00 USD FÜR
CHARITY AUSGEWÄHLT. Antworten Sie auf die folgende E-Mail, um weitere
Informationen zu erhalten
E-Mail: charlesjackson...@gmail.com
t; Suggested-by: Andy Shevchenko
> Signed-off-by: Hans de Goede
> ---
Acked-by: Charles Keepax
Tested-by: Charles Keepax
Thanks,
Charles
vices.
>
> Signed-off-by: Hans de Goede
> ---
Acked-by: Charles Keepax
Tested-by: Charles Keepax
Thanks,
Charles
rough snd_soc_card_jack_new() and register
> this jack with the codec through snd_soc_component_set_jack().
>
> Reviewed-by: Andy Shevchenko
> Signed-off-by: Hans de Goede
> ---
Acked-by: Charles Keepax
Tested-by: Charles Keepax
Thanks,
Charles
n on the next jack insertion, which in turn
> causes the EXTCON_JACK_HEADPHONE state to never get set
>
> This fixes both issues by skipping these 2 steps when arizona_hpdet_irq
> runs after the jack has been unplugged.
>
> Reviewed-by: Andy Shevchenko
> Acked-by: Charles Keepax
> Signed-off-by: Hans de Goede
> ---
Tested-by: Charles Keepax
Thanks,
Charles
zona extcon driver into
> a helper library for letting the arizona codec-drivers directly report
> jack state through the standard sound/soc/soc-jack.c functions.
>
> Reviewed-by: Andy Shevchenko
> Signed-off-by: Hans de Goede
> ---
Acked-by: Charles Keepax
Tested-by: Charles Keepax
Thanks,
Charles
a codec-drivers directly report jack
> state through the standard sound/soc/soc-jack.c functions.
>
> Reviewed-by: Andy Shevchenko
> Acked-by: Charles Keepax
> Signed-off-by: Hans de Goede
> ---
Tested-by: Charles Keepax
Thanks,
Charles
on a Lenovo Yoga Tablet 2 1051L with a WM5102 codec.
>
> Reviewed-by: Andy Shevchenko
> Signed-off-by: Hans de Goede
> ---
Acked-by: Charles Keepax
Tested-by: Charles Keepax
Thanks,
Charles
gh pdata (or defaults)
> and cannot be overridden from devicetree. All in-kernel users of the
> pdata (and the fallback defaults) define 6 or less buttons/ranges.
>
> Reviewed-by: Andy Shevchenko
> Signed-off-by: Hans de Goede
> ---
Acked-by: Charles Keepax
Tested-by: Charles Keepax
Thanks,
Charles
of feel like those applied to
the old extcon approach that just internally registered all
the interfaces.
But to be clear not asking for any changes just more about trying
to refine my understanding of things.
Thanks,
Charles
eoretically possible races caused
> by the wrong ordering inside arizona_extcon_remove(), this fixes the
> ordering fixing all possible races, including the reported oops.
>
> Reviewed-by: Andy Shevchenko
> Acked-by: Charles Keepax
> Signed-off-by: Hans de Goede
> ---
Tested-by: Charles Keepax
Thanks,
Charles
mediately after the call.
> This means that we should always use pm_runtime_get_sync().
>
> Reviewed-by: Andy Shevchenko
> Signed-off-by: Hans de Goede
> ---
Tested-by: Charles Keepax
Thanks,
Charles
tly report jack
> state through the standard sound/soc/soc-jack.c functions.
>
> Signed-off-by: Hans de Goede
> ---
Acked-by: Charles Keepax
Tested-by: Charles Keepax
Thanks,
Charles
mediately after the call.
> This means that we should always use pm_runtime_get_sync().
>
> Reviewed-by: Andy Shevchenko
> Signed-off-by: Hans de Goede
> ---
Acked-by: Charles Keepax
Thanks,
Charles
skip the debugfs_create_dir() call in that case, avoiding
> this error getting logged.
>
> Fixes: c33d442328f5 ("debugfs: make error message a bit more verbose")
> Cc: Charles Keepax
> Signed-off-by: Hans de Goede
> ---
Reviewed-by: Charles Keepax
Thanks,
Charles
need to be resolved in there. But that can
probably be done separate from this series.
Thanks,
Charles
On Fri, Jan 22, 2021 at 01:23:44PM +0100, Hans de Goede wrote:
> On 1/22/21 12:26 PM, Charles Keepax wrote:
> > On Thu, Jan 21, 2021 at 05:55:00PM +0100, Hans de Goede wrote:
> >> On 1/19/21 10:51 AM, Richard Fitzgerald wrote:
> >>> On 18/01/2021 17:24, Andy Shevchenk
t want to force the micbias's to be regulated
during button detect, so I think this option has to go.
> Note there is a pretty big issue with the original code here, if
> the MICVDD DAPM pin is on for an internal-mic and then we run through the
> jack-detect mic-detect sequence, we end up setting
> bypass=true causing the micbias for the internal-mic to no longer
> be what was configured. IOW poking the bypass setting underneath the
> DAPM code is racy.
>
The regulator bypass code keeps an internal reference count. All
the users of the regulator need to allow bypass for it to be
placed into bypass mode, so I believe this can't happen.
> Keeping in mind that switching to force_enable fixes the current racy code,
> as well as the KISS-ness of this solution, I personally prefer this option
> over option 1 as it makes the code cleaner and more correct.
> I could easily do this in a next version of this series if people agree
> with going this route.
>
It is pretty problematic to loose the power benefits of the
button detect, for the sake of making the code a little cleaner.
Thanks,
Charles
a codec-drivers directly report jack
> state through the standard sound/soc/soc-jack.c functions.
>
> Signed-off-by: Hans de Goede
> ---
Acked-by: Charles Keepax
Thanks,
Charles
n on the next jack insertion, which in turn
> causes the EXTCON_JACK_HEADPHONE state to never get set
>
> This fixes both issues by skipping these 2 steps when arizona_hpdet_irq
> runs after the jack has been unplugged.
>
> Reviewed-by: Andy Shevchenko
> Signed-off-by: Hans de Goede
> ---
Acked-by: Charles Keepax
Thanks,
Charles
es need will be added in a separate patch.
>
> BugLink: https://github.com/thesofproject/linux/issues/2485
> Co-authored-by: Pierre-Louis Bossart
> Signed-off-by: Pierre-Louis Bossart
> Reviewed-by: Andy Shevchenko
> Signed-off-by: Hans de Goede
> ---
Reviewed-by: Charles Keepax
Thanks,
Charles
ndroid_Yoga_Tablet_2-1051F_Kernel
>
> Cc: Christian Hartmann
> Reviewed-by: Andy Shevchenko
> Signed-off-by: Hans de Goede
> ---
Acked-by: Charles Keepax
Thanks,
Charles
.
>
> While at it also fix a possible NULL pointer deref of the id
> argument to the probe functions (this could happen on e.g. manual
> driver binding through sysfs).
>
> Suggested-by: Andy Shevchenko
> Signed-off-by: Hans de Goede
> ---
Acked-by: Charles Keepax
Thanks,
Charles
On Wed, Dec 30, 2020 at 05:44:41PM +0100, Andrew Lunn wrote:
> On Wed, Dec 30, 2020 at 10:33:09AM +0000, Charles Keepax wrote:
> > A new flag MACB_CAPS_CLK_HW_CHG was added and all callers of
> > macb_set_tx_clk were gated on the presence of this flag.
> >
> > - if (
On Thu, Dec 17, 2020 at 10:27:40AM -0600, Adam Ford wrote:
> The driver can request an optional clock for mclk.
> Update the txt file to reflect this.
>
> Suggested-by: Geert Uytterhoeven
> Signed-off-by: Adam Ford
Acked-by: Charles Keepax
Thanks,
Charles
ot absence of the flag. Update the if statement to
this effect, which repairs the existing users.
Fixes: daafa1d33cc9 ("net: macb: add capability to not set the clock rate")
Suggested-by: Andrew Lunn
Signed-off-by: Charles Keepax
---
Changes since v1:
- Updated flag semantics to skip
On Wed, Dec 30, 2020 at 05:44:41PM +0100, Andrew Lunn wrote:
> On Wed, Dec 30, 2020 at 10:33:09AM +0000, Charles Keepax wrote:
> > A new flag MACB_CAPS_CLK_HW_CHG was added and all callers of
> > macb_set_tx_clk were gated on the presence of this flag.
> >
> > - if (
ot absence of the flag. Update the if statement to
this effect, which repairs the existing users.
Fixes: daafa1d33cc9 ("net: macb: add capability to not set the clock rate")
Suggested-by: Andrew Lunn
Signed-off-by: Charles Keepax
---
Changes since v1:
- Updated flag semantics to skip
On Tue, Dec 29, 2020 at 02:57:38PM +0100, Hans de Goede wrote:
> On 12/29/20 2:06 PM, Charles Keepax wrote:
> > On Mon, Dec 28, 2020 at 04:28:07PM +, Mark Brown wrote:
> >> On Mon, Dec 28, 2020 at 02:16:04PM +0100, Hans de Goede wrote:
> >>
> >>> A
gt;dev, "Error setting clock: %d\n", ret);
> + return ret;
> + }
> +
The rate you set here doesn't actually matter, on wm5102 this
just links the DAI to a specific clock domain and as they all
default to SYSCLK you can omit this call if you want. Although no
harm is caused by leaving it in.
Thanks,
Charles
that audio jacks would have their own
special way rather than just using the connector stuff.
Thanks,
Charles
set extcon state: %d\n",
> ret);
> +}
Would be nice to also print which ID it is that is failing,
would help to narrow things down since we lose the customer error
messages for each case.
Thanks,
Charles
t; it was using a hardcoded GPIOD_OUT_LOW.
>
> Signed-off-by: Hans de Goede
> ---
Acked-by: Charles Keepax
Thanks,
Charles
eoretically possible races caused
> by the wrong ordering inside arizona_extcon_remove(), this fixes the
> ordering fixing all possible races, including the reported oops.
>
> Signed-off-by: Hans de Goede
> ---
Sorry yes there are a few rough corners on the extcon stuff, I
have
-extcon" and the
> modalias must match that.
>
> Signed-off-by: Hans de Goede
> ---
Acked-by: Charles Keepax
Thanks,
Charles
ade the equivalents inline functions to avoid the
issue, the same should work here.
include/linux/irqchip/irq-madera.h
Thanks,
Charles
e existing MODULE_SOFTDEP("pre: wm8994_regulator")
> in the wm8994 code, which has a similar init sequence.
>
> Signed-off-by: Hans de Goede
> ---
Acked-by: Charles Keepax
Thanks,
Charles
Document device tree bindings for STMicroelectronics PM6764tr Voltage
Regulator.
Signed-off-by: Charles Hsu
---
.../bindings/hwmon/pmbus/st,pm6764tr.yaml | 47 +++
.../devicetree/bindings/trivial-devices.yaml | 2 +
2 files changed, 49 insertions(+)
create mode 100644
On Wed, Dec 23, 2020 at 08:24:41PM +0100, Andrew Lunn wrote:
> On Wed, Dec 23, 2020 at 06:41:44PM +0000, Charles Keepax wrote:
> > A new flag MACB_CAPS_CLK_HW_CHG was added and all callers of
> > macb_set_tx_clk were gated on the presence of this flag.
> >
> > if
afa1d33cc9 ("net: macb: add capability to not set the clock rate")
Signed-off-by: Charles Keepax
---
drivers/net/ethernet/cadence/macb_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/cadence/macb_main.c
b/drivers/net/ethernet/caden
>
> >From the user perspective, everything seems fine but no data is produced.
>
> Connecting the Loopback DAI to a dummy DAPM endpoint solves the problem.
>
> Fixes: 8dd26dff00c0 ("ASoC: dapm: Fix handling of custom_stop_condition on
> DAPM graph walks")
> Cc:
Attn: Beneficiary:
Congratulations!! Your payment has been approved and endorsed, with the
instruction and approvals are given from the Authorities Due to the
incessant scam activities going around the globe, the Authorities has
instructed our Financial Institution to use high Performance in
rty);
I can't help but wonder if we should be taking the DAPM lock for
snd_soc_dapm_free_widgets. However your patch doesn't look like it
is making that any more scary and looks like we should be making
sure we remove the widget from the dirty list.
Reviewed-by: Charles Keepax
Thanks,
Charles
it's still on the list,
> leading to a use after free.
>
> Fixes: 78bb3688ea18 ("mfd: Support multiple active WM831x AUXADC conversions")
> Signed-off-by: Dan Carpenter
> ---
Acked-by: Charles Keepax
Thanks,
Charles
The output voltage use the MFR_READ_VOUT 0xD4
Vout value returned is linear11.
Signed-off-by: Charles Hsu
---
v6:
- Fix misspelling.
v5:
- Add MAINTAINERS.
v4:
- Add pm6764tr to Documentation/hwmon/index.rst.
v3:
- Add Documentation(Documentation/hwmon/pm6764tr.rst).
- Fix include order.
v2
On Fri, Dec 11, 2020 at 04:44:40PM +0800, Zheng Yongjun wrote:
> Replace a comma between expression statements by a semicolon.
>
> Signed-off-by: Zheng Yongjun
> ---
Acked-by: Charles Keepax
Thanks,
Charles
--
Ihr E-Mail-Konto wurde für eine Spende von $ 3.500.000,00 USD für
wohltätige Zwecke ausgewählt. Antworten Sie auf die folgende E-Mail,
um weitere Informationen zu erhalten
E-Mail: michaelfis...@gmail.com
onent);
> + unsigned int val = ucontrol->value.integer.value[0];
> +
> + if (val > 1)
> + return -EINVAL;
> +
> + wm8960->dacslope = val;
> +
> + return snd_soc_component_update_bits(component, WM8960_DACCTL1,
> + 0x2, val<<1);
Is the DAC Slope switch not in DACCTL2?
Thanks,
Charles
On 3/12/2020 下午11:48, Guenter Roeck wrote:
On Thu, Dec 03, 2020 at 08:34:32PM +0800, Charles wrote:
[ ... ]
It's really weird. I sent a mail to myself, and it looks good.
@@ -220,6 +220,15 @@ config SENSORS_MP2975
This driver can also be built as a module. If so, the module
IHR E-MAIL-KONTO WURDE FÜR EINE SPENDE VON 3.500.000,00 USD FÜR CHARITY
AUSGEWÄHLT. Antworten Sie auf die folgende E-Mail, um weitere Informationen zu
erhalten
E-Mail: charlesjacksn...@gmail.com
--
This email has been checked for viruses by Avast antivirus software.
IHR E-MAIL-KONTO WURDE FÜR EINE SPENDE VON 3.500.000,00 USD FÜR CHARITY
AUSGEWÄHLT. Antworten Sie auf die folgende E-Mail, um weitere Informationen zu
erhalten
E-Mail: charlesjacksn...@gmail.com
--
This email has been checked for viruses by Avast antivirus software.
IHR E-MAIL-KONTO WURDE FÜR EINE SPENDE VON 3.500.000,00 USD FÜR CHARITY
AUSGEWÄHLT. Antworten Sie auf die folgende E-Mail, um weitere Informationen zu
erhalten
E-Mail: charlesjacksn...@gmail.com
--
This email has been checked for viruses by Avast antivirus software.
IHR E-MAIL-KONTO WURDE FÜR EINE SPENDE VON 3.500.000,00 USD FÜR CHARITY
AUSGEWÄHLT. Antworten Sie auf die folgende E-Mail, um weitere Informationen zu
erhalten
E-Mail: charlesjacksn...@gmail.com
--
This email has been checked for viruses by Avast antivirus software.
--
Ihr E-Mail-Konto wurde für eine Spende von $ 3.500.000,00 USD für
wohltätige Zwecke ausgewählt. Antworten Sie auf die folgende E-Mail,
um weitere Informationen zu erhalten
E-Mail: michaelfis...@gmail.com
--
IHR E-MAIL-KONTO WURDE FÜR EINE SPENDE VON 3.500.000,00 USD FÜR
CHARITY AUSGEWÄHLT. Antworten Sie auf die folgende E-Mail, um weitere
Informationen zu erhalten
E-Mail: charlesjacksn...@gmail.com
On 28/11/2020 上午12:10, Guenter Roeck wrote:
On Fri, Nov 27, 2020 at 09:59:01AM +0800, Charles wrote:
Add the pmbus driver for the STMicroelectronics pm6764 voltage regulator.
the output voltage use the MFR_READ_VOUT 0xD4
vout value returned is linear11
Signed-off-by: Charles Hsu
This patch
On 22/11/2020 下午11:36, Guenter Roeck wrote:
On Wed, Nov 11, 2020 at 03:10:08PM +0800, Charles wrote:
Add the pmbus driver for the STMicroelectronics pm6764 voltage regulator.
the output voltage use the MFR_READ_VOUT 0xD4
vout value returned is linear11
Signed-off-by: Charles Hsu
Please fix
his fixes
> compile warning (!CONFIG_OF on x86_64):
>
> drivers/mfd/wm8994-core.c:618:34: warning: ‘wm8994_of_match’ defined but
> not used [-Wunused-const-variable=]
>
> Signed-off-by: Krzysztof Kozlowski
> ---
Acked-by: Charles Keepax
Thanks,
Charles
ly logs in case of
> success
>
> Signed-off-by: Lucas Tanure
> ---
Reviewed-by: Charles Keepax
Thanks,
Charles
n.
>
> Another candidate for revert is
> commit ada9e3fcc175 ("spi: dw: Correct handling of native chipselect")
> although I don't understand that code well enough to be sure.
>
> Adding Charles Keepax.
Looks like the code has changed a fair amount since my patch. The
Add the pmbus driver for the STMicroelectronics pm6764 voltage regulator.
the output voltage use the MFR_READ_VOUT 0xD4
vout value returned is linear11
Signed-off-by: Charles Hsu
---
v4:
- Add pm6764tr to Documentation/hwmon/index.rst.
v3:
- Add Documentation(Documentation/hwmon
out value returned is linear11
> >
> > Signed-off-by: Charles Hsu
>
> Please use standard Linux kernel code formatting rules.
> Run checkpatch --strict on the patch and make sure it does not report
> any problems.
>
> total: 1 errors, 39 warnings, 3 checks, 96 lines c
m8994_pm_ops = {
> SET_SYSTEM_SLEEP_PM_OPS(wm8994_suspend, wm8994_resume)
Not sure this really makes sense, what is going to stop the
unused function warning if PM isn't configured?
Thanks,
Charles
recommended by the datasheet for DCVDD supplies that take longer than
2mS to rise.
Signed-off-by: Charles Keepax
---
drivers/mfd/madera-core.c | 16 +++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/drivers/mfd/madera-core.c b/drivers/mfd/madera-core.c
index 4ed6ad8ce0020
-by: Charles Keepax
---
drivers/mfd/madera-core.c | 25 -
include/linux/mfd/madera/core.h | 1 +
2 files changed, 21 insertions(+), 5 deletions(-)
diff --git a/drivers/mfd/madera-core.c b/drivers/mfd/madera-core.c
index a9c6f0833f327..a2abc0094def7 100644
On Mon, Oct 19, 2020 at 11:59:37AM -0700, t...@redhat.com wrote:
> From: Tom Rix
>
> A break is not needed if it is preceded by a goto
>
> Signed-off-by: Tom Rix
> ---
Acked-by: Charles Keepax
Thanks,
Charles
Add the pmbus driver for the STMicroelectronics pm6764tr voltage regulator.
Signed-off-by: Charles Hsu
---
drivers/hwmon/pmbus/Kconfig| 8
drivers/hwmon/pmbus/Makefile | 1 +
drivers/hwmon/pmbus/pm6764tr.c | 76 ++
3 files changed, 85 insertions
... when any
> //
>
> Signed-off-by: Julia Lawall
>
> ---
Acked-by: Charles Keepax
Thanks,
Charles
... when any
> //
>
> Signed-off-by: Julia Lawall
>
> ---
Acked-by: Charles Keepax
Thanks,
Charles
recommended by the datasheet for DCVDD supplies that take longer than
2mS to rise.
Signed-off-by: Charles Keepax
---
drivers/mfd/madera-core.c | 16 +++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/drivers/mfd/madera-core.c b/drivers/mfd/madera-core.c
index 4ed6ad8ce0020
-by: Charles Keepax
---
drivers/mfd/madera-core.c | 25 -
include/linux/mfd/madera/core.h | 1 +
2 files changed, 21 insertions(+), 5 deletions(-)
diff --git a/drivers/mfd/madera-core.c b/drivers/mfd/madera-core.c
index a9c6f0833f327..a2abc0094def7 100644
On Mon, Sep 28, 2020 at 09:30:11PM -0400, Sasha Levin wrote:
> From: Charles Keepax
>
> [ Upstream commit 94cc89eb8fa5039fcb6e3e3d50f929ddcccee095 ]
>
> In regmap_debugfs_init the initialisation of the debugfs is delayed
> if the root node isn't ready yet. Most callers of r
memory. Done with the help of Coccinelle.
>
> Signed-off-by: Rikard Falkeborn
> ---
Acked-by: Charles Keepax
Thanks,
Charles
On Mon, Sep 21, 2020 at 10:50:15PM +0200, Krzysztof Kozlowski wrote:
> Use PLATFORM_DEVID_NONE define instead of "-1" value because:
> - it brings some meaning,
> - it might point attention why auto device ID was not used.
>
> Signed-off-by: Krzysztof Kozlowski
> -
On Mon, Sep 21, 2020 at 10:50:16PM +0200, Krzysztof Kozlowski wrote:
> Use PLATFORM_DEVID_NONE define instead of "-1" value because:
> - it brings some meaning,
> - it might point attention why auto device ID was not used.
>
> Signed-off-by: Krzysztof Kozlowski
> -
On Mon, Sep 21, 2020 at 10:49:35PM +0200, Krzysztof Kozlowski wrote:
> Use PLATFORM_DEVID_NONE define instead of "-1" value because:
> - it brings some meaning,
> - it might point attention why auto device ID was not used.
>
> Signed-off-by: Krzysztof Kozlowski
> -
On Thu, Sep 17, 2020 at 06:52:57PM +0200, Krzysztof Kozlowski wrote:
> Include the common GPIO schema in GPIO controllers to be sure all common
> properties are properly validated.
>
> Signed-off-by: Krzysztof Kozlowski
>
> ---
For the Cirrus bits:
Acked-by: Charles Keepax
Thanks,
Charles
On Thu, Sep 17, 2020 at 06:52:56PM +0200, Krzysztof Kozlowski wrote:
> Include the common GPIO schema in GPIO controllers to be sure all common
> properties are properly validated.
>
> Signed-off-by: Krzysztof Kozlowski
>
> ---
For the Cirrus/Wolfson bits:
Acked-by: Charl
Many error paths in __regmap_init rely on ret being pre-initialised to
-EINVAL, add an extra initialisation in after the new call to
regmap_set_name.
Fixes: 94cc89eb8fa5 ("regmap: debugfs: Fix handling of name string for debugfs
init delays")
Reported-by: Dan Carpenter
Signed-off-b
On Fri, Sep 18, 2020 at 03:38:43PM +0300, Dan Carpenter wrote:
> On Fri, Sep 18, 2020 at 12:20:02PM +0100, Charles Keepax wrote:
> > Fixes: 94cc89eb8fa5 ("regmap: debugfs: Fix handling of name string for
> > debugfs init delays")
> > Reported-by: kernel test robot
Fixes: 94cc89eb8fa5 ("regmap: debugfs: Fix handling of name string for debugfs
init delays")
Reported-by: kernel test robot
Reported-by: Dan Carpenter
Signed-off-by: Charles Keepax
---
drivers/base/regmap/regmap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
te the cache to match the exact
hardware. Whilst no users do currently update the name here, given the
use-case it seemed reasonable the name might want to be updated once
the device is better identified.
Signed-off-by: Charles Keepax
---
drivers/base/regmap/internal.h | 4 ++--
drivers/base/r
up the
regmap debugfs root isn't ready yet. Although this doesn't crash it
does result in the debugfs entry not having the correct name.
Signed-off-by: Charles Keepax
---
drivers/base/regmap/regmap-debugfs.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/base/reg
On Wed, Sep 16, 2020 at 05:14:18PM +0100, Mark Brown wrote:
> On Wed, Sep 16, 2020 at 04:44:33PM +0100, Charles Keepax wrote:
>
> > - node->name = name;
> > + node->name = kstrdup(name, GFP_KERNEL);
> > + if (!node->n
think slot_width should be the same as word_size, and I suggest changing
> > it
> > before adding 20/24-bit support.
>
> Generally speaking, the slot width doesn't necessarily match the
> physical width. With TDM for example you may very well have slots
> larger than their samples.
>
> That being said, S24 is explicitly a format where you send a sample of
> 24 bits in a 32-bit word (in the lowest three bytes, little endian)
>
> See:
> https://elixir.bootlin.com/linux/v5.9-rc3/source/sound/core/pcm_misc.c#L75
> https://mailman.alsa-project.org/pipermail/alsa-devel/2013-April/061073.html
>
> 24 bits of data over three bytes like you suggest is S24_3LE
>
My understanding is physical_width refers to the in memory
representation, but shouldn't be used to control the slot width
on the bus. If not specified otherwise (say through the set_tdm
callback), and if the appropriate BCLK is supported, then the slot
should be just large enough to hold the data.
Thanks,
Charles
-by: Charles Keepax
---
drivers/regulator/lochnagar-regulator.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/regulator/lochnagar-regulator.c
b/drivers/regulator/lochnagar-regulator.c
index 5ea3e41416849..cb71fa5f43c3e 100644
--- a/drivers/regulator/lochnagar-regulator.c
+++ b/drivers
e_only flag being set.
>
> Signed-off-by: Sylwester Nawrocki
> ---
Acked-by: Charles Keepax
Thanks,
Charles
onent_update_bits on wm8994-codec"
>
> Signed-off-by: Sylwester Nawrocki
> ---
Acked-by: Charles Keepax
Thanks,
Charles
1 - 100 of 3625 matches
Mail list logo
