Re: [PATCH RESEND 3/4] docs: Add HiSilicon PTT device driver documentation

2021-04-19 Thread Daniel Thompson
On Sat, Apr 17, 2021 at 06:17:10PM +0800, Yicong Yang wrote: > Document the introduction and usage of HiSilicon PTT device driver. > > Signed-off-by: Yicong Yang > --- > Documentation/trace/hisi-ptt.rst | 326 > +++ > 1 file changed, 326 insertions(+) >

Re: [PATCH v3] kdb: Refactor env variables get/set code

2021-04-14 Thread Daniel Thompson
On Mon, Feb 08, 2021 at 01:32:22PM +0530, Sumit Garg wrote: > > Add two new kdb environment access methods as kdb_setenv() and > kdb_printenv() in order to abstract out environment access code > from kdb command functions. > > Also, replace (char *)0 with NULL as an initializer for environment >

Re: [PATCH v2] sched/debug: Use sched_debug_lock to serialize use of cgroup_path[] only

2021-03-30 Thread Daniel Thompson
On Mon, Mar 29, 2021 at 03:32:35PM -0400, Waiman Long wrote: > The handling of sysrq keys should normally be done in an user context > except when MAGIC_SYSRQ_SERIAL is set and the magic sequence is typed > in a serial console. This seems to be a poor summary of the typical calling context for

Re: [PATCH v6 2/4] backlight: rt4831: Adds DT binding document for Richtek RT4831 backlight

2021-03-29 Thread Daniel Thompson
On Sun, Mar 28, 2021 at 11:24:17PM +0800, cy_huang wrote: > From: ChiYuan Huang > > Adds DT binding document for Richtek RT4831 backlight. > > Signed-off-by: ChiYuan Huang Reviewed-by: Daniel Thompson

Re: [PATCH v6 4/4] backlight: rt4831: Adds support for Richtek RT4831 backlight

2021-03-29 Thread Daniel Thompson
It's common used to drive the display WLED. There're four channels Nitpicking but I was expecting the original typo be converted to "commonly". With that addressed: Reviewed-by: Daniel Thompson Daniel.

Re: [PATCH 1/2] sched/debug: Don't disable IRQ when acquiring sched_debug_lock

2021-03-29 Thread Daniel Thompson
On Sat, Mar 27, 2021 at 07:25:28PM -0400, Waiman Long wrote: > The sched_debug_lock was used only in print_cpu(). The > print_cpu() function has two callers - sched_debug_show() and > sysrq_sched_debug_show(). Both of them are invoked by user action > (sched_debug file and sysrq-t). As

Re: [PATCH v5 5/6] backlight: rt4831: Adds support for Richtek RT4831 backlight

2021-03-25 Thread Daniel Thompson
On Thu, Mar 25, 2021 at 04:22:11PM +0800, ChiYuan Huang wrote: > Dear reviewers: > >Didn't get any response about this backlight patch. > Is there any part need to be refined? Thanks for the reminders and sorry for the delay. Have just replied to the original message! Daniel.

Re: [PATCH v5 5/6] backlight: rt4831: Adds support for Richtek RT4831 backlight

2021-03-25 Thread Daniel Thompson
On Thu, Dec 17, 2020 at 11:00:43PM +0800, cy_huang wrote: > From: ChiYuan Huang > > Adds support for Richtek RT4831 backlight. > > Signed-off-by: ChiYuan Huang Looks ok but there are a few minor niggles. > --- > drivers/video/backlight/Kconfig| 8 ++ >

[PATCH] kgdbts: Switch to do_sys_openat2() for breakpoint testing

2021-03-25 Thread Daniel Thompson
address because this is more or less what kdb does in the same circumstances. Re-implement lookup_addr() to be based on kallsyms rather than function pointers. Signed-off-by: Daniel Thompson --- Notes: So less than a week ago I said I had nothing pending for kgdbts. That was entirely true

Re: [PATCH 2/2] video: backlight: qcom-wled: Add PMI8994 compatible

2021-03-23 Thread Daniel Thompson
On Tue, Mar 23, 2021 at 08:39:35AM +, Lee Jones wrote: > On Mon, 22 Mar 2021, Daniel Thompson wrote: > > > On Sun, Feb 28, 2021 at 01:41:05PM +0100, Konrad Dybcio wrote: > > > Add a compatible for PMI8994 WLED. It uses the V4 of WLED IP. > > > >

Re: [PATCH] backlight: journada720: fix Wmisleading-indentation warning

2021-03-23 Thread Daniel Thompson
c0d17 ("backlight: Adds HP Jornada 700 series backlight driver") > Signed-off-by: Arnd Bergmann I'm dubious that the re-indent matches the original authors intent... but it certainly does match what was actually written and tested so on that basis: Reviewed-by: Daniel Thompson Dani

Re: [PATCH] kgdb: fix gcc-11 warning on indentation

2021-03-22 Thread Daniel Thompson
On Mon, Mar 22, 2021 at 10:04:57AM -0700, Doug Anderson wrote: > > + if (verbose)\ > > + printk(KERN_INFO a);\ > > +} while (0) > > +#define v2printk(a...) do {\ > > + if (verbose > 1)\ > > +

Re: [PATCH] kgdb: fix gcc-11 warning on indentation

2021-03-22 Thread Daniel Thompson
ndent it for readability. > > Fixes: e8d31c204e36 ("kgdb: add kgdb internal test suite") > Signed-off-by: Arnd Bergmann Acked-by: Daniel Thompson Which tree do you want to merge this one though? I've got nothing else pending for this file so I am very relaxed about the route..

Re: [PATCH V2] kernel: debug: Ordinary typo fixes in the file gdbstub.c

2021-03-22 Thread Daniel Thompson
On Wed, Mar 17, 2021 at 04:16:58PM +0530, Bhaskar Chowdhury wrote: > s/overwitten/overwritten/ > s/procesing/processing/ > > Signed-off-by: Bhaskar Chowdhury Applied, Thanks! Daniel. > --- > Changes from V1: > As Daniel pointed out, I was misdoing a check,so corrected > >

Re: [PATCH 2/2] video: backlight: qcom-wled: Add PMI8994 compatible

2021-03-22 Thread Daniel Thompson
On Sun, Feb 28, 2021 at 01:41:05PM +0100, Konrad Dybcio wrote: > Add a compatible for PMI8994 WLED. It uses the V4 of WLED IP. > > Signed-off-by: Konrad Dybcio Reviewed-by: Daniel Thompson Daniel. > --- > drivers/video/backlight/qcom-wled.c | 1 + > 1 file ch

Re: [PATCH 1/2] dt-bindings: leds: backlight: qcom-wled: Add PMI8994 compatible

2021-03-22 Thread Daniel Thompson
On Sun, Feb 28, 2021 at 01:41:04PM +0100, Konrad Dybcio wrote: > Document the newly added PMI8994 compatible. > > Signed-off-by: Konrad Dybcio (For Lee) Acked-by: Daniel Thompson Daniel. > --- > Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml | 1 + >

Re: [PATCH v5] kdb: Simplify kdb commands registration

2021-03-22 Thread Daniel Thompson
On Wed, Feb 24, 2021 at 12:38:27PM +0530, Sumit Garg wrote: > Simplify kdb commands registration via using linked list instead of > static array for commands storage. > > Signed-off-by: Sumit Garg Applied, thanks! > --- > > Changes in v5: > - Introduce new method: kdb_register_table() to

Re: [PATCH v2] kdb: Get rid of custom debug heap allocator

2021-03-19 Thread Daniel Thompson
On Mon, Mar 01, 2021 at 11:33:00AM +0530, Sumit Garg wrote: > On Fri, 26 Feb 2021 at 23:07, Daniel Thompson > wrote: > > > > On Fri, Feb 26, 2021 at 06:12:13PM +0530, Sumit Garg wrote: > > > On Fri, 26 Feb 2021 at 16:29, Daniel Thompson > > > wrote: > >

Re: [PATCH] kdb: Refactor kdb_defcmd implementation

2021-03-19 Thread Daniel Thompson
On Tue, Mar 09, 2021 at 05:47:47PM +0530, Sumit Garg wrote: > Switch to use kdbtab_t instead of separate struct defcmd_set since > now we have kdb_register_table() to register pre-allocated kdb commands. This needs rewriting. I've been struggling for some time to figure out what it actually means

Re: [net-next PATCH v7 04/16] of: mdio: Refactor of_phy_find_device()

2021-03-19 Thread Daniel Thompson
On Wed, Mar 17, 2021 at 02:15:20PM +0530, Calvin Johnson wrote: > Hi Daniel, > > On Tue, Mar 16, 2021 at 07:17:19PM +0000, Daniel Thompson wrote: > > On Thu, Mar 11, 2021 at 11:49:59AM +0530, Calvin Johnson wrote: > > > Refactor of_phy_find_device() to us

Re: [PATCH] kernel: debug: Ordinary typo fixes in the file gdbstub.c

2021-03-17 Thread Daniel Thompson
On Wed, Mar 17, 2021 at 02:40:22PM +0530, Bhaskar Chowdhury wrote: > > s/'O'utput/'Output/ > s/overwitten/overwritten/ > s/procesing/processing/ > > Signed-off-by: Bhaskar Chowdhury > --- > kernel/debug/gdbstub.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git

Re: [net-next PATCH v7 04/16] of: mdio: Refactor of_phy_find_device()

2021-03-16 Thread Daniel Thompson
-audio.ko INSTALL sound/usb/snd-usbmidi-lib.ko INSTALL sound/xen/snd_xen_front.ko DEPMOD 5.12.0-rc3-9-g1fda33bf463d depmod: ERROR: Cycle detected: fwnode_mdio -> of_mdio -> fwnode_mdio depmod: ERROR: Found 2 modules in dependency cycles! ~~~ Kconfig can be found here: https://gist.gi

Re: [PATCH] backlight: qcom-wled: Use sink_addr for sync toggle

2021-03-15 Thread Daniel Thompson
Shamoun > Signed-off-by: Konrad Dybcio > Signed-off-by: Marijn Suijten LGTM, although an acked-by from Kiran would be nice to have: Reviewed-by: Daniel Thompson Daniel. > --- > drivers/video/backlight/qcom-wled.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >

Re: [PATCH] drm/nouveau/kms/nve4-nv108: Limit cursors to 128x128

2021-03-08 Thread Daniel Thompson
his patch, which fixed the problem for me. Mine is an Armv8 system but there is nothing particularly exotic from a graphics card or software point of view: Debian bullseye/wayland (gnome-shell 3.38.3, mesa-20.3.4) running on a GT-710. However FWIW: Tested-by: Daniel Thompson Daniel. > --- &

Re: [PATCH V3 2/2] backlight: qcom-wled: Correct the sync_toggle sequence

2021-03-01 Thread Daniel Thompson
ous register state. > > Signed-off-by: Kiran Gunda With one of each of the changes proposed above: Reviewed-by: Daniel Thompson Daniel. > --- > drivers/video/backlight/qcom-wled.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/dr

Re: [PATCH V2 2/2] backlight: qcom-wled: Correct the sync_toggle sequence

2021-03-01 Thread Daniel Thompson
On Mon, Mar 01, 2021 at 02:15:12PM +0530, kgu...@codeaurora.org wrote: > On 2021-02-26 22:56, Daniel Thompson wrote: > > On Fri, Feb 26, 2021 at 05:42:24PM +0530, Kiran Gunda wrote: > > > As per the current implementation, after FSC (Full Scale Current) > > > and brig

Re: [PATCH v2] kdb: Get rid of custom debug heap allocator

2021-02-26 Thread Daniel Thompson
On Fri, Feb 26, 2021 at 06:12:13PM +0530, Sumit Garg wrote: > On Fri, 26 Feb 2021 at 16:29, Daniel Thompson > wrote: > > > > On Fri, Feb 26, 2021 at 03:23:06PM +0530, Sumit Garg wrote: > > > Currently the only user for debug heap is kdbnearsym() which can be &

Re: [PATCH V2 2/2] backlight: qcom-wled: Correct the sync_toggle sequence

2021-02-26 Thread Daniel Thompson
On Fri, Feb 26, 2021 at 05:42:24PM +0530, Kiran Gunda wrote: > As per the current implementation, after FSC (Full Scale Current) > and brightness update the sync bits are transitioned from 1 to 0. This still seems to incorrectly describe the current behaviour. Surely in most cases (i.e. every

Re: [PATCH V2 1/2] backlight: qcom-wled: Fix FSC update issue for WLED5

2021-02-26 Thread Daniel Thompson
htness > update. For an FSC update we need to toggle the SYNC bits instead. > > Fix it by adopting the common wled3_sync_toggle() for WLED5 and > introducing new code to the brightness update path to compensate. > > Signed-off-by: Kiran Gunda Reviewed-by: Daniel Thompson Daniel.

Re: [PATCH v2] kdb: Get rid of custom debug heap allocator

2021-02-26 Thread Daniel Thompson
On Fri, Feb 26, 2021 at 03:23:06PM +0530, Sumit Garg wrote: > Currently the only user for debug heap is kdbnearsym() which can be > modified to rather ask the caller to supply a buffer for symbol name. > So do that and modify kdbnearsym() callers to pass a symbol name buffer > allocated statically

Re: [PATCH] kgdb: Fix to kill breakpoints on initmem after boot

2021-02-25 Thread Daniel Thompson
rior to initmem > pages being freed. > > Suggested-by: Doug Anderson > Signed-off-by: Sumit Garg I saw Andrew has picked this one up. That's ok for me: Acked-by: Daniel Thompson I already enriched kgdbtest to cover this (and they pass) so I guess this is also: Teste

Re: [PATCH] kdb: Get rid of custom debug heap allocator

2021-02-25 Thread Daniel Thompson
... because its pretty nasty. > > This change has been tested using kgdbtest on arm64 which doesn't show > any regressions. > > Suggested-by: Daniel Thompson > Signed-off-by: Sumit Garg > --- > kernel/debug/kdb/kdb_debugger.c | 1 - > kernel/debug/kdb/kdb_main

Re: [PATCH V1 2/2] backlight: qcom-wled: Correct the sync_toggle sequence

2021-02-24 Thread Daniel Thompson
On Wed, Feb 24, 2021 at 09:20:48AM +0530, Kiran Gunda wrote: > Currently the FSC SYNC_BIT and MOD_SYNC_BIT are toggled > from 1 to 0 to update the FSC and brightenss settings. > Change this sequence form 0 to 1 as per the hardware team > recommendation to update the FSC and brightness correctly.

Re: [PATCH V1 1/2] backlight: qcom-wled: Fix FSC update issue for WLED5

2021-02-24 Thread Daniel Thompson
On Wed, Feb 24, 2021 at 09:20:47AM +0530, Kiran Gunda wrote: > Currently, for WLED5, after FSC register update MOD_SYNC_BIT > is toggled instead of SYNC_BIT. MOD_SYNC_BIT has to be toggled > after the brightness update and SYNC_BIT has to be toggled after > FSC update for WLED5. Fix it. Code

Re: [PATCH] kernel: debug: Handle breakpoints in kernel .init.text section

2021-02-23 Thread Daniel Thompson
On Tue, Feb 23, 2021 at 02:33:50PM +0530, Sumit Garg wrote: > Thanks Doug for your comments. > > On Tue, 23 Feb 2021 at 05:28, Doug Anderson wrote: > > > To be clear there is still a very small window between call to > > > free_initmem() and system_state = SYSTEM_RUNNING which can lead to > > >

[GIT PULL] kgdb changes for v5.12

2021-02-22 Thread Daniel Thompson
. Signed-off-by: Daniel Thompson Daniel Thompson (1): kgdb: Remove kgdb_schedule_breakpoint() Lukas Bulwahn (1): kgdb: rectify kernel-doc for kgdb_unregister_io_module() Stephen Zhang (1): kdb: kdb_support: Fix

Re: [PATCH v4] kdb: Simplify kdb commands registration

2021-02-22 Thread Daniel Thompson
On Mon, Feb 22, 2021 at 06:33:18PM +0530, Sumit Garg wrote: > On Mon, 22 Feb 2021 at 17:35, Daniel Thompson > wrote: > > > > On Thu, Feb 18, 2021 at 05:39:58PM +0530, Sumit Garg wrote: > > > Simplify kdb commands registration via using linked list instead of >

Re: [PATCH v4] kdb: Simplify kdb commands registration

2021-02-22 Thread Daniel Thompson
On Thu, Feb 18, 2021 at 05:39:58PM +0530, Sumit Garg wrote: > Simplify kdb commands registration via using linked list instead of > static array for commands storage. > > Signed-off-by: Sumit Garg > --- > > Changes in v4: > - Fix kdb commands memory allocation issue prior to slab being

Re: [PATCH 2/2] MIPS: make kgdb depend on FPU support

2021-02-10 Thread Daniel Thompson
On Wed, Feb 10, 2021 at 03:15:10PM +0100, Maciej W. Rozycki wrote: > On Wed, 10 Feb 2021, Daniel Thompson wrote: > > > > NB if GDB sees a register padded out (FAOD it means all-x's rather than > > > a > > > hex string placed throughout the

[PATCH] kgdb: Remove kgdb_schedule_breakpoint()

2021-02-10 Thread Daniel Thompson
that has also been true for the last 10 years). Thus the main real reason for this patch is to make explicit that the in-tree kgdb features do not require tasklets. Signed-off-by: Daniel Thompson --- Notes: During this cycle two developers have proposed tidying up the DECLARE_TASKLET_OLD

Re: [PATCH 2/2] MIPS: make kgdb depend on FPU support

2021-02-10 Thread Daniel Thompson
On Wed, Feb 10, 2021 at 01:11:28PM +0100, Maciej W. Rozycki wrote: > On Wed, 10 Feb 2021, Daniel Thompson wrote: > > > > Wrapping the relevant parts of this file into #ifdef MIPS_FP_SUPPORT > > > would be as easy though and would qualify as a proper fix given th

Re: [PATCH 1/4] driver core: Use subdir-ccflags-* to inherit debug flag

2021-02-10 Thread Daniel Thompson
On Mon, Feb 08, 2021 at 09:09:20PM +0800, Yicong Yang wrote: > On 2021/2/8 18:47, Greg KH wrote: > > On Mon, Feb 08, 2021 at 06:44:52PM +0800, Yicong Yang wrote: > >> On 2021/2/5 17:53, Greg KH wrote: > >>> What does this offer in benefit of the existing way? What is it fixing? > >>> Why do this

Re: [PATCH 2/2] MIPS: make kgdb depend on FPU support

2021-02-10 Thread Daniel Thompson
On Mon, Feb 08, 2021 at 06:03:08PM +0100, Maciej W. Rozycki wrote: > On Fri, 22 Jan 2021, Arnd Bergmann wrote: > > > From: Arnd Bergmann > > > > kgdb fails to build when the FPU support is disabled: > > > > arch/mips/kernel/kgdb.c: In function 'dbg_set_reg': > > arch/mips/kernel/kgdb.c:147:35:

Re: [PATCH v3] kdb: Simplify kdb commands registration

2021-02-08 Thread Daniel Thompson
On Mon, Feb 08, 2021 at 03:18:19PM +0530, Sumit Garg wrote: > On Mon, 8 Feb 2021 at 15:13, Daniel Thompson > wrote: > > > > On Fri, Jan 29, 2021 at 03:47:07PM +0530, Sumit Garg wrote: > > > @@ -1011,25 +1005,17 @@ int kdb_parse(const char *cmdstr) &

Re: [PATCH v3] kdb: Simplify kdb commands registration

2021-02-08 Thread Daniel Thompson
On Fri, Jan 29, 2021 at 03:47:07PM +0530, Sumit Garg wrote: > @@ -1011,25 +1005,17 @@ int kdb_parse(const char *cmdstr) > ++argv[0]; > } > > - for_each_kdbcmd(tp, i) { > - if (tp->cmd_name) { > - /* > - * If this

Re: [PATCH v2] kdb: Refactor env variables get/set code

2021-02-05 Thread Daniel Thompson
On Thu, Feb 04, 2021 at 03:44:20PM +0530, Sumit Garg wrote: > @@ -318,6 +318,65 @@ int kdbgetintenv(const char *match, int *value) > } > > /* > + * kdb_setenv() - Alter an existing environment variable or create a new one. > + * @var: Name of the variable > + * @val: Value of the variable > +

Re: [PATCH v4] kdb: kdb_support: Fix debugging information problem

2021-02-04 Thread Daniel Thompson
On Thu, Feb 04, 2021 at 08:07:09PM +0800, Stephen Zhang wrote: > There are several common patterns. > > 0: > kdb_printf("...",...); > > which is the normal one. > > 1: > kdb_printf("%s: "...,__func__,...) > > We could improve '1' to this : > > #define

Re: [PATCH] kernel: debug: fix typo issue

2021-02-04 Thread Daniel Thompson
On Wed, Feb 03, 2021 at 04:10:34PM +0800, samirweng1979 wrote: > From: wengjianfeng > > change 'regster' to 'register'. > > Signed-off-by: wengjianfeng Applied. Thanks.

Re: [PATCH] kgdb: rectify kernel-doc for kgdb_unregister_io_module()

2021-02-04 Thread Daniel Thompson
On Mon, Jan 25, 2021 at 03:48:47PM +0100, Lukas Bulwahn wrote: > The command 'find ./kernel/debug/ | xargs ./scripts/kernel-doc -none' > reported a typo in the kernel-doc of kgdb_unregister_io_module(). > > Rectify the kernel-doc, such that no issues remain for ./kernel/debug/. > >

Re: [PATCH] kernel: debug: fix typo issue

2021-02-03 Thread Daniel Thompson
On Wed, Feb 03, 2021 at 07:36:09PM +0800, wengjianfeng wrote: > On Wed, 3 Feb 2021 11:23:59 + > Daniel Thompson wrote: > > > On Wed, Feb 03, 2021 at 04:10:34PM +0800, samirweng1979 wrote: > > > From: wengjianfeng > > > > > > change 'regst

Re: [PATCH] backlight: pcf50633: pdata may be a null pointer, null pointer dereference cause crash

2021-02-03 Thread Daniel Thompson
nting unused and untested special cases that they would have to reason about. Daniel. > > Daniel Thompson 于2021年2月2日周二 上午3:25写道: > > > On Mon, Feb 01, 2021 at 08:41:38AM -0600, Wenjia Zhao wrote: > > > Signed-off-by: Wenjia Zhao > > > > There should be a

Re: [PATCH] kernel: debug: fix typo issue

2021-02-03 Thread Daniel Thompson
On Wed, Feb 03, 2021 at 04:10:34PM +0800, samirweng1979 wrote: > From: wengjianfeng > > change 'regster' to 'register'. > > Signed-off-by: wengjianfeng It looks like the Subject line might not be correct for this patch? Is it really the first time this patch has been circulated or should it

Re: [PATCH] backlight: pcf50633: pdata may be a null pointer, null pointer dereference cause crash

2021-02-02 Thread Daniel Thompson
On Mon, Feb 01, 2021 at 08:41:38AM -0600, Wenjia Zhao wrote: > Signed-off-by: Wenjia Zhao There should be a patch description here explaining why the patch is needed and how it works. > --- > drivers/video/backlight/pcf50633-backlight.c | 3 ++- > 1 file changed, 2 insertions(+), 1

Re: [PATCH] kdb: Refactor env variables get/set code

2021-01-25 Thread Daniel Thompson
On Mon, Jan 25, 2021 at 07:59:45PM +0530, Sumit Garg wrote: > Move kdb environment related get/set APIs to a separate file in order > to provide an abstraction for environment variables access and hence > enhances code readability. > > Signed-off-by: Sumit Garg > --- > kernel/debug/kdb/Makefile

Re: [PATCH] kgdb: use new API for breakpoint tasklet

2021-01-25 Thread Daniel Thompson
On Sat, Jan 23, 2021 at 07:42:37PM +0100, Emil Renner Berthing wrote: > This converts the kgdb_tasklet_breakpoint to use the new API in > commit 12cc923f1ccc ("tasklet: Introduce new initialization API") > > The new API changes the argument passed to the callback function, but > fortunately the

Re: [PATCH v3] kdb: Make memory allocations more robust

2021-01-25 Thread Daniel Thompson
On Fri, Jan 22, 2021 at 09:25:44AM -0800, Doug Anderson wrote: > Hi, > > On Fri, Jan 22, 2021 at 3:06 AM Sumit Garg wrote: > > > > Currently kdb uses in_interrupt() to determine whether its library > > code has been called from the kgdb trap handler or from a saner calling > > context such as

Re: [PATCH v2] kdb: Make memory allocations more robust

2021-01-22 Thread Daniel Thompson
On Fri, Jan 22, 2021 at 03:50:50PM +0530, Sumit Garg wrote: > Currently kdb uses in_interrupt() to determine whether it's library Looks like a good change just a few nitpicks with the description: s/it's/its/ > code has been called from the kgdb trap handler or from a saner calling > context

Re: [PATCH] kdb: Make memory allocations more robust

2021-01-22 Thread Daniel Thompson
On Fri, Jan 22, 2021 at 03:08:31PM +0530, Sumit Garg wrote: > Currently kdb uses in_interrupt() to determine whether it's library > code has been called from the kgdb trap handler or from a saner calling > context such as driver init. This approach is broken because > in_interrupt() alone isn't

Re: [PATCH] kgdb: Schedule breakpoints via workqueue

2021-01-15 Thread Daniel Thompson
On Thu, Jan 14, 2021 at 04:13:44PM -0800, Davidlohr Bueso wrote: > The original functionality was added back in: > > 1cee5e35f15 (kgdb: Add the ability to schedule a breakpoint via a tasklet) > > However tasklets have long been deprecated as being too heavy on > the system by running in irq

Re: [PATCH] kgdbts: Passing ekgdbts to command line causes panic

2021-01-05 Thread Daniel Thompson
Please avoid top posting. Threads on LKML are typically presented as follows. On Tue, Jan 05, 2021 at 11:21:38AM +0800, bodefang wrote: > At 2021-01-04 19:28:54, "Daniel Thompson" > wrote: > >On Mon, Dec 28, 2020 at 09:58:58AM +0800, Defang Bo wrote: > >> Similar

Re: [PATCH] kgdbts: Passing ekgdbts to command line causes panic

2021-01-04 Thread Daniel Thompson
On Mon, Dec 28, 2020 at 09:58:58AM +0800, Defang Bo wrote: > Similar to commit<1bd54d851f50>("kgdboc: Passing ekgdboc to command line > causes panic"), > kgdbts_option_setup does not check input argument before passing it to strlen. > The argument would be a NULL pointer. Something seems to be

Re: [PATCH v2 -next] video: backlight: use DEFINE_MUTEX() for mutex lock

2021-01-04 Thread Daniel Thompson
On Thu, Dec 24, 2020 at 09:26:01PM +0800, Zheng Yongjun wrote: > mutex lock can be initialized automatically with DEFINE_MUTEX() > rather than explicitly calling mutex_init(). > > Signed-off-by: Zheng Yongjun > --- > drivers/video/backlight/backlight.c | 3 +-- > 1 file changed, 1 insertion(+),

Re: [PATCH -next] video: backlight: use DEFINE_MUTEX (and mutex_init() had been too late)

2021-01-04 Thread Daniel Thompson
On Wed, Dec 23, 2020 at 10:10:35PM +0800, Zheng Yongjun wrote: > Signed-off-by: Zheng Yongjun Can you explain the Subject for this patch in more detail? If this patch is required to correct a bug then it looks to me like it is incomplete. Daniel. > --- > drivers/video/backlight/backlight.c

Re: [PATCH -next] misc: use DIV_ROUND_UP macro to do calculation

2020-12-22 Thread Daniel Thompson
On Tue, Dec 22, 2020 at 09:33:44PM +0800, Zheng Yongjun wrote: > Don't open-code DIV_ROUND_UP() kernel macro. > > Signed-off-by: Zheng Yongjun > --- > drivers/misc/kgdbts.c | 5 ++--- Arguably this patch should have kgdbts in the Subject line. > 1 file changed, 2 insertions(+), 3

Re: [PATCH] x86/kgdb: Allow removal of early BPs

2020-12-18 Thread Daniel Thompson
gned-off-by: Stefan Saecherl I took this to be a gap in the kgdbtest suite so I added a couple of tests that cover this area. Before this patch they failed now they pass (at least they do for ARCH=x86). I don't see any new failures either, so: Tested-by: Daniel Thompson Daniel.

Re: [PATCH v4 2/3] backlight: rt4831: Adds DT binding document for Richtek RT4831 backlight

2020-12-14 Thread Daniel Thompson
On Mon, Dec 14, 2020 at 10:40:55PM +0800, ChiYuan Huang wrote: > Hi, > > Daniel Thompson 於 2020年12月14日 週一 下午5:59寫道: > > > > Hi CY > > > > On Sat, Dec 12, 2020 at 12:33:43AM +0800, cy_huang wrote: > > > From: ChiYuan Huang > > > > >

Re: [PATCH -next] backlight: sky81452-backlight: convert comma to semicolon

2020-12-14 Thread Daniel Thompson
On Mon, Dec 14, 2020 at 09:34:58PM +0800, Zheng Yongjun wrote: > Replace a comma between expression statements by a semicolon. > > Signed-off-by: Zheng Yongjun Weird! I guess it was harmless but still seriously weird ;-) Reviewed-by: Daniel Thompson Thanks! > --- > drivers/

Re: [RFC HACK PATCH] PCI: dwc: layerscape: Hack around enumeration problems with Honeycomb LX2K

2020-12-14 Thread Daniel Thompson
On Fri, Dec 11, 2020 at 05:05:58PM +, Daniel Thompson wrote: > On Fri, Dec 11, 2020 at 08:37:40AM -0600, Rob Herring wrote: > > On Fri, Dec 11, 2020 at 6:15 AM Daniel Thompson > > > BTW I noticed many other pcie-designware drivers take advantage > > &g

Re: [PATCH v4 2/3] backlight: rt4831: Adds DT binding document for Richtek RT4831 backlight

2020-12-14 Thread Daniel Thompson
Hi CY On Sat, Dec 12, 2020 at 12:33:43AM +0800, cy_huang wrote: > From: ChiYuan Huang > > Adds DT binding document for Richtek RT4831 backlight. > > Signed-off-by: ChiYuan Huang This patch got keyword filtered and brought to my attention but the rest of the series did not. If it was a

Re: [RFC HACK PATCH] PCI: dwc: layerscape: Hack around enumeration problems with Honeycomb LX2K

2020-12-11 Thread Daniel Thompson
On Fri, Dec 11, 2020 at 08:37:40AM -0600, Rob Herring wrote: > On Fri, Dec 11, 2020 at 6:15 AM Daniel Thompson > wrote: > > > > I have been chasing down a problem enumerating an NVMe drive on a > > Honeycomb LX2K (NXP LX2160A). Specifically the drive can only enumerate &g

Re: [PATCH RESEND net-next 1/2] dpaa2-eth: send a scatter-gather FD instead of realloc-ing

2020-12-11 Thread Daniel Thompson
On Fri, Dec 11, 2020 at 02:01:28PM +, Ioana Ciornei wrote: > On Thu, Dec 10, 2020 at 08:06:36PM +0200, Ioana Ciornei wrote: > > [Added also the netdev mailing list, I haven't heard of linux-netdev > > before but kept it] > > > > On Thu, Dec 10, 2020 at 05:31:56PM +

[RFC HACK PATCH] PCI: dwc: layerscape: Hack around enumeration problems with Honeycomb LX2K

2020-12-11 Thread Daniel Thompson
are currently relying on a call to the console UART code can "mend" the driver runs from calling dw_pcie_setup_rc() in host init to just before we read the state in the link up callback. Signed-off-by: Daniel Thompson --- Notes: This patch is RFC (and HACK) because I don't have much

Re: [PATCH RESEND net-next 1/2] dpaa2-eth: send a scatter-gather FD instead of realloc-ing

2020-12-10 Thread Daniel Thompson
Hi Ioana On Mon, Jun 29, 2020 at 06:47:11PM +, Ioana Ciornei wrote: > Instead of realloc-ing the skb on the Tx path when the provided headroom > is smaller than the HW requirements, create a Scatter/Gather frame > descriptor with only one entry. > > Remove the '[drv] tx realloc frames'

[PATCH] ARM: Kconfig: Select ARCH_HAVE_NMI_SAFE_CMPXCHG where possible

2020-12-08 Thread Daniel Thompson
masking for 8- and 16-bit operations. This patch is conservative and does not change behaviour for CPU_V6. Signed-off-by: Daniel Thompson --- arch/arm/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index 002e0cf025f59..fd434c5958b62 100644 --- a/arch

Re: [PATCH 0/5] drop unused BACKLIGHT_GENERIC option

2020-12-01 Thread Daniel Thompson
op unused BACKLIGHT_GENERIC option > MIPS: configs: drop unused BACKLIGHT_GENERIC option > parisc: configs: drop unused BACKLIGHT_GENERIC option > powerpc/configs: drop unused BACKLIGHT_GENERIC option Whole series: Acked-by: Daniel Thompson Daniel.

Re: [PATCH] Documentation: kgdb: Fix a typo

2020-11-16 Thread Daniel Thompson
On Mon, Nov 16, 2020 at 05:42:47PM +0800, Tiezhu Yang wrote: > "to into" -> "into" > > Reported-by: Sergei Shtylyov > Signed-off-by: Tiezhu Yang Acked-by: Daniel Thompson > --- > Documentation/dev-tools/kgdb.rst | 7 +++ > 1 file changed, 3 i

Re: [PATCH] Replaced hard coded function names in debug messages with __func__ macro.

2020-11-04 Thread Daniel Thompson
On Tue, Nov 03, 2020 at 09:36:54PM +0100, Tabot Kevin wrote: > On Tue, Nov 03, 2020 at 10:04:40AM +0000, Daniel Thompson wrote: > > On Mon, Nov 02, 2020 at 01:15:56PM +0100, Tabot Kevin wrote: > > > On Mon, Nov 02, 2020 at 09:33:24AM +0000, Daniel Thompson wrote: > >

Re: [PATCH v3] MAINTAINERS: add Dan Murphy as TI LP8xxx drivers maintainer

2020-11-03 Thread Daniel Thompson
; > Dear Lee, > > Could you take care about this patch? Just in case Lee wants it: Acked-by: Daniel Thompson Daniel.

Re: [PATCH] Replaced hard coded function names in debug messages with __func__ macro.

2020-11-03 Thread Daniel Thompson
On Mon, Nov 02, 2020 at 01:15:56PM +0100, Tabot Kevin wrote: > On Mon, Nov 02, 2020 at 09:33:24AM +0000, Daniel Thompson wrote: > > On Sat, Oct 31, 2020 at 05:41:03PM +0100, Tabot Kevin wrote: > > > This patch fixes the following: > > > - Uses __func__ macro to print

Re: [PATCH] Replaced hard coded function names in debug messages with __func__ macro.

2020-11-02 Thread Daniel Thompson
On Sat, Oct 31, 2020 at 05:41:03PM +0100, Tabot Kevin wrote: > This patch fixes the following: > - Uses __func__ macro to print function names. > - Got rid of unnecessary braces around single line if statements. > - End of block comments on a seperate line. > - A spelling mistake of the word "on".

Re: [PATCH v6 6/7] kgdb: roundup: Allow runtime arch specific override

2020-11-02 Thread Daniel Thompson
On Mon, Nov 02, 2020 at 11:48:53AM +0530, Sumit Garg wrote: > On Thu, 29 Oct 2020 at 20:51, Daniel Thompson > wrote: > > > > On Thu, Oct 29, 2020 at 08:26:26PM +0530, Sumit Garg wrote: > > > Add a new API kgdb_arch_roundup_cpus() for a particular archichecture to

Re: [PATCH v6 7/7] arm64: kgdb: Roundup cpus using IPI as NMI

2020-10-29 Thread Daniel Thompson
On Thu, Oct 29, 2020 at 04:22:34PM +, Daniel Thompson wrote: > On Thu, Oct 29, 2020 at 08:26:27PM +0530, Sumit Garg wrote: > > arm64 platforms with GICv3 or later supports pseudo NMIs which can be > > leveraged to roundup CPUs which are stuck in hard lockup state with > >

Re: [PATCH v6 7/7] arm64: kgdb: Roundup cpus using IPI as NMI

2020-10-29 Thread Daniel Thompson
On Thu, Oct 29, 2020 at 08:26:27PM +0530, Sumit Garg wrote: > arm64 platforms with GICv3 or later supports pseudo NMIs which can be > leveraged to roundup CPUs which are stuck in hard lockup state with > interrupts disabled that wouldn't be possible with a normal IPI. > > So instead switch to

Re: [PATCH v6 6/7] kgdb: roundup: Allow runtime arch specific override

2020-10-29 Thread Daniel Thompson
On Thu, Oct 29, 2020 at 08:26:26PM +0530, Sumit Garg wrote: > Add a new API kgdb_arch_roundup_cpus() for a particular archichecture to > override default kgdb roundup and if it detects at runtime to not support > NMI roundup then it can fallback to default implementation using async > SMP

Re: [PATCH v3 3/3] backlight: pwm_bl: Fix interpolation

2020-10-28 Thread Daniel Thompson
vision from the table initialization. It was something I was aware of during an earlier review but it was below my personal nitpicking threshold (which could be badly calibrated... hence waiting). However it's all been quiet so: Reviewed-by: Daniel Thompson Daniel.

Re: [PATCH v3 1/3] ARM: dts: rockchip: veyron: Remove 0 point from brightness-levels

2020-10-28 Thread Daniel Thompson
a > 252 long interpolation that would slowly go between 0 and 3, looking > really bad in userspace. So it's almost a noop/cleanup now, but it will > be required in the future. > > Signed-off-by: Alexandru Stan Acked-by: Daniel Thompson > --- > > arch/arm/boot/dts/rk328

Re: [PATCH v3 2/3] arm64: dts: qcom: trogdor: Add brightness-levels

2020-10-28 Thread Daniel Thompson
k without it, > without looking too ugly. > > Signed-off-by: Alexandru Stan Acked-by: Daniel Thompson > --- > > arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi &g

Re: drivers/video/backlight/ltv350qv.c:192:12: warning: stack frame size of 13472 bytes in function 'ltv350qv_power'

2020-10-28 Thread Daniel Thompson
On Sun, Oct 25, 2020 at 12:17:08PM -0700, Andrew Morton wrote: > On Mon, 26 Oct 2020 02:15:37 +0800 kernel test robot wrote: > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > > master > > head: d76913908102044f14381df865bb74df17a538cb > > commit:

Re: [PATCH AUTOSEL 5.4 31/80] kgdb: Make "kgdbcon" work properly with "kgdb_earlycon"

2020-10-27 Thread Daniel Thompson
"kgdb_use_con" and registering the console then. > > As part of this, to avoid pre-declaring things, move the handling of > the "kgdbcon" further down in the file. > > Signed-off-by: Douglas Anderson > Link: > https://lore.kernel.org/r/20200630151422.1.I4

Re: [PATCH v5 1/5] arm64: Add framework to turn IPI as NMI

2020-10-20 Thread Daniel Thompson
On Tue, Oct 20, 2020 at 04:52:43PM +0530, Sumit Garg wrote: > On Tue, 20 Oct 2020 at 15:38, Marc Zyngier wrote: > > > > On 2020-10-20 07:43, Sumit Garg wrote: > > > On Mon, 19 Oct 2020 at 17:07, Marc Zyngier wrote: > > > > [...] > > > > >> > +{ > > >> > + if (!ipi_desc) > > >> > +

[GIT PULL] kgdb changes for v5.10-rc1

2020-10-16 Thread Daniel Thompson
a coverity dead code warning, improved handling of search during multi-line printk and a couple of typo corrections. Signed-off-by: Daniel Thompson Cengiz Can (1): kdb: remove unnecessary null check of dbg_io_ops Daniel Thompson (4

Re: [PATCH v2 3/3] arm64: dts: qcom: trogdor: Add brightness-levels

2020-10-15 Thread Daniel Thompson
On Wed, Oct 14, 2020 at 06:51:19AM -0700, Doug Anderson wrote: > Hi, > > On Wed, Oct 14, 2020 at 4:33 AM Daniel Thompson > wrote: > > > > On Tue, Oct 13, 2020 at 09:28:38AM -0700, Doug Anderson wrote: > > > Hi, > > > > > > On Tue, O

Re: [PATCH v2 2/3] ARM: dts: rockchip: veyron: Remove 0 point from brightness-levels

2020-10-14 Thread Daniel Thompson
t; > Signed-off-by: Alexandru Stan Acked-by: Daniel Thompson Note also shouldn't this be patch 1 of the set. AFAICT it makes sense whether or not the interpolation algorithm is changed. Daniel. > --- > > arch/arm/boot/dts/rk3288-veyron-jaq.dts| 2 +- > arch/arm/boot/dts/r

Re: [PATCH v2 3/3] arm64: dts: qcom: trogdor: Add brightness-levels

2020-10-14 Thread Daniel Thompson
On Tue, Oct 13, 2020 at 09:28:38AM -0700, Doug Anderson wrote: > Hi, > > On Tue, Oct 13, 2020 at 1:01 AM Alexandru Stan wrote: > > > > Now that we have better interpolation for the backlight > > ("backlight: pwm_bl: Fix interpolation"), we can now add the curve to > > the trogdor boards, being

Re: [PATCH v2 1/3] backlight: pwm_bl: Fix interpolation

2020-10-14 Thread Daniel Thompson
On Tue, Oct 13, 2020 at 01:01:01AM -0700, Alexandru Stan wrote: > Whenever num-interpolated-steps was larger than the distance > between 2 consecutive brightness levels the table would get really > discontinuous. The slope of the interpolation would stick with > integers only and if it was 0 the

Re: [PATCH v4 41/52] docs: kgdb.rst: fix :c:type: usages

2020-10-01 Thread Daniel Thompson
Invalid C declaration: Expected end of definition. [error at 14] > kdb_poll_funcs[] > --^ > > Signed-off-by: Mauro Carvalho Chehab Acked-by: Daniel Thompson Daniel. > --- > Documentation/dev-tools/kgdb.rst | 6 +++--- > 1 file changed, 3 in

Re: [PATCH v3 0/3] kgdb: Honour the kprobe blocklist when setting breakpoints

2020-09-28 Thread Daniel Thompson
On Sun, Sep 27, 2020 at 10:15:28PM +0100, Daniel Thompson wrote: > kgdb has traditionally adopted a no safety rails approach to breakpoint > placement. If the debugger is commanded to place a breakpoint at an > address then it will do so even if that breakpoint results in kgdb &

[PATCH v3 1/3] kgdb: Honour the kprobe blocklist when setting breakpoints

2020-09-27 Thread Daniel Thompson
and are compiling for an architecture where we HAVE_KPROBES. Suggested-by: Peter Zijlstra Reviewed-by: Douglas Anderson Reviewed-by: Masami Hiramatsu Signed-off-by: Daniel Thompson --- include/linux/kgdb.h | 18 ++ kernel/debug/debug_core.c | 4 kernel/debug/kdb/kdb_bp.c

[PATCH v3 2/3] kgdb: Add NOKPROBE labels on the trap handler functions

2020-09-27 Thread Daniel Thompson
so given kgdb's users are currently conditioned to avoid recursive traps). Signed-off-by: Daniel Thompson --- kernel/debug/debug_core.c | 16 1 file changed, 16 insertions(+) diff --git a/kernel/debug/debug_core.c b/kernel/debug/debug_core.c index b1277728a835..faa1f99ce65a

[PATCH v3 0/3] kgdb: Honour the kprobe blocklist when setting breakpoints

2020-09-27 Thread Daniel Thompson
It is now optional but the blocklist will be enabled by default for architectures that CONFIG_HAVE_KPROBES Daniel Thompson (3): kgdb: Honour the kprobe blocklist when setting breakpoints kgdb: Add NOKPROBE labels on the trap handler functions kernel: debug: Centralize dbg_[de]activate_sw_b

  1   2   3   4   5   6   7   8   9   10   >