Re: [PATCH rebased] kbuild: rpm-pkg: Fix build with non-default MODLIB

On Friday 2023-11-10 18:44, Michal Suchánek wrote: >> It's a complicated mumble-jumble. Prior art exists as in: >> >> /opt/vendorThing/bin/... >> /usr/X11R6/lib/libXi.so.6 [host binary] >> /usr/x86_64-w64-mingw32/bin/as [host binary] >> /usr/x86_64-w64-mingw32/sys-root/mingw/bin/as.exe [fore

Re: [PATCH kmod v5 5/5] libkmod, depmod, modprobe: Make directory for kernel modules configurable

On Tuesday 2023-10-17 19:50, Lucas De Marchi wrote: >> +AC_ARG_WITH([module_directory], >> +AS_HELP_STRING([--with-module-directory=DIR], [directory in which to >> look for kernel modules - typically '/lib/modules' or >> '${prefix}/lib/modules']), >> +[], [with_module_directory=/lib

Re: [PATCH rebased] kbuild: rpm-pkg: Fix build with non-default MODLIB

On Tuesday 2023-10-17 17:10, Michal Suchánek wrote: > >> In my system (Ubuntu), I see the directory paths >> >> /usr/aarch64-linux-gnu/lib/ >> /usr/i686-linux-gnu/lib/ >> /usr/x86_64-linux-gnu/lib/ >> >> If there were such a crazy distro that supports multiple kernel arches >> within a single ima

Re: [PATCH rebased] kbuild: rpm-pkg: Fix build with non-default MODLIB

On Monday 2023-10-09 17:14, Masahiro Yamada wrote: > >Let me add more context to my question. > >I am interested in the timing when >'pkg-config --print-variables kmod | grep module_directory' >is executed. > >1. Build a SRPM on machine A >2. Copy the SRPM from machine A to machine B >3. Run r

Re: k10temp: ZEN3 readings are broken

On Tuesday 2020-12-22 04:58, Guenter Roeck wrote: >On 12/21/20 5:45 PM, Gabriel C wrote: >> Hello Guenter, >> >> while trying to add ZEN3 support for zenpower out of tree modules, I find out >> the in-kernel k10temp driver is broken with ZEN3 ( and partially ZEN2 even ). > >[...] since I do not

Re: [PATCH v1 01/13] sparc32: Drop sun4m/sun4d support from head_32.S

On Friday 2020-12-18 19:43, Sam Ravnborg wrote: > notsup: >- .asciz "Sparc-Linux sun4/sun4c or MMU-less not supported\n\n" >- .align 4 >- >-sun4e_notsup: >-.asciz "Sparc-Linux sun4e support does not exist\n\n" >+ .asciz "Sparc-Linux sun4* or MMU-less not supported\n\n" >

Re: remaining flexible-array conversions

On Friday 2020-04-24 14:15, Jason Gunthorpe wrote: >> ./usr/include/rdma/ib_user_verbs.h:436:34: warning: field 'base' with >> variable sized type 'struct ib_uverbs_create_cq_resp' not at the end of >> a struct or class is a GNU extension >> [-Wgnu-variable-sized-type-not-at-end] >> struc

Re: [PATCH 04/26] net: add a new sockptr_t type

On Thursday 2020-07-23 08:08, Christoph Hellwig wrote: >+typedef struct { >+ union { >+ void*kernel; >+ void __user *user; >+ }; >+ boolis_kernel : 1; >+} sockptr_t; >+ >+static inline bool sockptr_is_null(sockptr_t sockptr) >+{

Re: Good idea to rename files in include/uapi/ ?

On Monday 2020-06-15 01:34, Alexander A. Klimov wrote: >> >> A header file rename is no problem. We even have dummy headers > Hmm.. if I understand all of you correctly, David, Stefano, Pablo and Al say > like no, not a good idea, but only you, Jan, say like should be no problem. > > Jan, do you

Re: [PATCH] linux++, this: rename "struct notifier_block *this"

On Friday 2020-06-19 09:46, Christoph Hellwig wrote: >On Fri, Jun 19, 2020 at 12:06:45AM +0300, Alexey Dobriyan wrote: >> Rename >> struct notifier_block *this >> to >> struct notifier_block *nb >> >> "nb" is arguably a better name for notifier block. > >But not enough better to cause t

Re: Good idea to rename files in include/uapi/ ?

On Sunday 2020-06-14 22:19, David Howells wrote: >Alexander A. Klimov wrote: > >> *Is it a good idea to rename files in include/uapi/ ?* > >Very likely not. If programs out there are going to be built on a >case-sensitive filesystem (which happens all the time), they're going to break >if you r

Re: [RFC PATCH 0/4] DirectX on Linux

On Tuesday 2020-05-19 22:36, Sasha Levin wrote: > >> - Why DX12 on linux? Looking at this feels like classic divide and > > There is a single usecase for this: WSL2 developer who wants to run > machine learning on his GPU. The developer is working on his laptop, > which is running Windows and tha

Re: [PATCH] netfilter: fix make target xt_TCPMSS.o error.

On Wednesday 2020-05-06 08:50, Huang Qijun wrote: >When compiling netfilter, there will be an error >"No rule to make target 'net/netfilter/xt_TCPMSS.o'", >because the xt_TCPMSS.c in the makefile is uppercase, >and the file name of the source file (xt_tcpmss.c) is lowercase. >-obj-$(CONFIG_NETFIL

Re: [PATCH v9 00/13] arch/resctrl: AMD QoS support

On Nov 21 2018 20:28:23, Moger, Babu wrote: > >This series adds support for AMD64 architectural extensions for >Platform Quality of Service. The term "QoS" is already used for net/sched/. It will be bad naming to have QoS - and then an AMD QoS / Platform QoS as well. Preexisting, decade-old h

Re: [PATCH 04/11] UAPI: bcache: Fix use of embedded flexible array

On Tuesday 2018-10-09 17:41, David Howells wrote: >Jan Engelhardt wrote: > >> """it [the array size expression] shall be a converted constant expression of >> type std::size_t and its value shall be greater than zero.""" >> —http://eel.is/c

Re: [PATCH 04/11] UAPI: bcache: Fix use of embedded flexible array

On Wed, 05 Sep 2018 16:55:03 +0100, David Howells wrote: > >The bkey struct defined by bcache is embedded in the jset struct. However, >this is illegal in C++ as there's a "flexible array" at the end of the struct. >Change this to be a 0-length struct instead. > >- __u64 ptr[]; >+ __u

Re: [netfilter-core] kernel panic: Out of memory and no killable processes... (2)

On Monday 2018-01-29 17:57, Florian Westphal wrote: >> > > vmalloc() once became killable by commit 5d17a73a2ebeb8d1 ("vmalloc: back >> > > off when the current task is killed") but then became unkillable by >> > > commit >> > > b8c8a338f75e052d ("Revert "vmalloc: back off when the current task i

Re: [PATCH] net: netfilter: Replace explicit NULL comparisons

On Sunday 2017-04-09 05:42, Arushi Singhal wrote: >On Sun, Apr 9, 2017 at 1:44 AM, Pablo Neira Ayuso wrote: > On Sat, Apr 08, 2017 at 08:21:56PM +0200, Jan Engelhardt wrote: > > On Saturday 2017-04-08 19:21, Arushi Singhal wrote: > > > > >Replace ex

Re: [PATCH] net: netfilter: Replace explicit NULL comparisons

On Saturday 2017-04-08 19:21, Arushi Singhal wrote: >Replace explicit NULL comparison with ! operator to simplify code. I still wouldn't do this, for the same reason as before. Comparing to NULL explicitly more or less gave an extra guarantee that the other operand was also a pointer.

Re: [PATCH v2] netfilter: Clean up tests if NULL returned on failure

On Wednesday 2017-03-29 11:15, SIMRAN SINGHAL wrote: >> dest = kzalloc(sizeof(struct ip_vs_dest), GFP_KERNEL); >>- if (dest == NULL) >>+ if (!dest) >> return -ENOMEM; > >But, according to me we should prefer !var over ( var ==NULL ) according to the >c

Re: [PATCH v2] netfilter: Clean up tests if NULL returned on failure

On Tuesday 2017-03-28 18:23, SIMRAN SINGHAL wrote: >On Tue, Mar 28, 2017 at 7:24 PM, Jan Engelhardt wrote: >> On Tuesday 2017-03-28 15:13, simran singhal wrote: >> >>>Some functions like kmalloc/kzalloc return NULL on failure. When NULL >>>repres

Re: [PATCH v2] netfilter: Clean up tests if NULL returned on failure

On Tuesday 2017-03-28 15:13, simran singhal wrote: >Some functions like kmalloc/kzalloc return NULL on failure. When NULL >represents failure, !x is commonly used. > >@@ -910,7 +910,7 @@ ip_vs_new_dest(struct ip_vs_service *svc, struct >ip_vs_dest_user_kern *udest, > } > > dest = kza

Re: [PATCH] netfilter: ipset: Use max macro instead of ternary operator

On Tuesday 2017-03-28 15:32, simran singhal wrote: >This patch replaces ternary operator with macro max as it shorter and >thus increases code readability. > >- return (ret < 0 ? 0 : ret); >+ return max(0, ret); While the two are functionally equivalent, "max" conveys a meaning of "upp

Re: [PATCH] net: Remove unnecessary cast on void pointer

On Tuesday 2017-03-28 14:50, simran singhal wrote: >The following Coccinelle script was used to detect this: >@r@ >expression x; >void* e; >type T; >identifier f; >@@ >( > *((T *)e) >| > ((T *)x)[...] >| > ((T*)x)->f >| > >- (T*) > e >) > >Signed-off-by: simran singhal >--- > net/bridge/netfi

Re: [PATCH v4 3/7] x86: put msr-index.h in uapi

On Monday 2017-01-23 18:26, Borislav Petkov wrote: >On Mon, Jan 23, 2017 at 09:21:03AM -0800, Christoph Hellwig wrote: >> Or keep the exported version as-is and never changed it, and use >> a different copy for the kernel itself. > >I guess we'll have to do that if something in userspace has put i

Re: [PATCH v2 7/7] uapi: export all headers under uapi directories

On Thursday 2017-01-12 16:52, Nicolas Dichtel wrote: >Le 09/01/2017 à 13:56, Christoph Hellwig a écrit : >> On Fri, Jan 06, 2017 at 10:43:59AM +0100, Nicolas Dichtel wrote: >>> Regularly, when a new header is created in include/uapi/, the developer >>> forgets to add it in the corresponding Kbuild

Re: [PATCH 1116/1285] Replace numeric parameter like 0444 with macro

On Tuesday 2016-08-02 14:17, Baole Ni wrote: >I find that the developers often just specified the numeric value >when calling a macro which is defined with a parameter for access permission. >As we know, these numeric value for access permission have had the >corresponding macro, >and that using

RE: [PATCH 9/9] netfilter: implement xt_cgroup cgroup2 path match

On Monday 2015-11-23 18:35, David Laight wrote: >From: Florian Westphal >> Sent: 21 November 2015 16:56 >> > +struct xt_cgroup_info_v1 { >> > + charpath[PATH_MAX]; >> > + __u32 classid; >> > + >> > + /* kernel internal data */ >> > + void*priv __attribute__((a

Re: [PATCH 9/9] netfilter: implement xt_cgroup cgroup2 path match

On Saturday 2015-11-21 19:54, Florian Westphal wrote: > >The only other question I have is wheter PATH_MAX might be a possible >ABI breaker in future. It would have to be guaranteed that this is the >same size forever, else you'd get strange errors on rule insertion if >the sizes of the kernel an

Re: [PATCH iptables] libxt_cgroup2: add support for cgroup2 path matching

On Tuesday 2015-11-17 20:42, Tejun Heo wrote: >+static void cgroup2_save(const void *ip, const struct xt_entry_match *match) >+{ >+ const struct xt_cgroup2_info *info = (void *)match->data; >+ >+ printf("%s --path %s", info->invert ? " !" : "", info->path); >+} Can cgroup path names con

Re: [PATCH 5/5] netfilter: implement xt_cgroup2 match

On Tuesday 2015-11-17 20:40, Tejun Heo wrote: >@@ -0,0 +1,14 @@ >+#ifndef _XT_CGROUP2_H >+#define _XT_CGROUP2_H >+ >+#include >+ >+struct xt_cgroup2_info { >+ charpath[PATH_MAX]; >+ __u8invert; Should be included? (For PATH_MAX)

Re: [PATCH 1/5] cgroup: record ancestor IDs and reimplement cgroup_is_descendant() using it

On Tuesday 2015-11-17 20:40, Tejun Heo wrote: >+static inline bool cgroup_is_descendant(struct cgroup *cgrp, >+ struct cgroup *ancestor) (const struct group *cgrp, const struct group *ancestor) >+{ >+ if (cgrp->root != ancestor->root || cgrp->level < anc

Re: [PATCH 2/5] kernfs: implement kernfs_walk_and_get()

On Tuesday 2015-11-17 22:20, David Miller wrote: >> +static char path_buf[PATH_MAX]; /* protected by kernfs_mutex */ >> +int len = strlen(path); > ... >> +if (len >= PATH_MAX) >> +return NULL; >> + >> +memcpy(path_buf, path, len + 1); > > static char path_buf[PATH

Retain all bits of the exit(2) status value

I was made aware of a suggested change to POSIX's exit function. Current issue 7: http://pubs.opengroup.org/onlinepubs/9699919799/functions/exit.html Proposed change: http://austingroupbugs.net/view.php?id=594#c1317 In summary: from "the least significant 8 bits (that is, status & 0377)" to "t

Re: [RFC] kernel random segmentation fault?

On Wednesday 2015-05-06 05:46, long.wanglong wrote: > >int main(int argc, char** argv) >{ >rlim.rlim_cur=20 MB; >rlim.rlim_max=20 MB; >ret = setrlimit(RLIMIT_AS, &rlim); >[...] >char tmp[20 MB]; >for (i = 0; i < 20 MB; i++) >tmp[i]=1; if tmp already takes 20 MB, wh

Re: NULL deref around blkmq in v4.0-rc1–rc7

On Saturday 2015-04-11 19:46, Linus Torvalds wrote: >On Thu, Apr 9, 2015 at 5:07 PM, Linus Torvalds > wrote: >> On Thu, Apr 9, 2015 at 3:29 PM, Jan Engelhardt wrote: >>> >>> Yes, this seems to solve it for me. >> >> Can you humor me, and try t

Re: NULL deref around blkmq in v4.0-rc1–rc7

On Thursday 2015-04-09 19:38, Linus Torvalds wrote: >> >> I reran bisect just to be sure. >> It now shows v4.0-rc1~9 is bad, v4.0-rc1~9^1 is ok, and v4.0-rc~9^2 is >> ok too. So this means that the combination of the both ~9 childs work >> badly together. > >Ok, that's just _odd_. >[...] >So I get

Re: NULL deref around xfs in v4.0-rc1–rc7

On Wednesday 2015-04-08 15:41, Jan Engelhardt wrote: >Starting somewhere around v4.0-rc1 and persisting through commit >v4.0-rc7, there is a new NULL deference apparently happening in >conjunction with xfs. This inhibits this machine's booting, >as xfs is used for the root fil

NULL deref around xfs in v4.0-rc1–rc7

Starting somewhere around v4.0-rc1 and persisting through commit v4.0-rc7, there is a new NULL deference apparently happening in conjunction with xfs. This inhibits this machine's booting, as xfs is used for the root filesystem. First bisection points at first-bad commit v4.0-rc1~8, and since t

Re: [PATCH 43/45] include/uapi/linux/netfilter_bridge.h: include if.h

On Tuesday 2015-02-17 00:05, Mikko Rapeli wrote: >Fixes userspace compilation errors like: > >error: field ‘in’ has incomplete type >struct in_addr in; > >+#include Patch 36/45 included linux/in.h instead of linux/if.h for addressing "in has incomplete type". Should this be used here too? -- T

Re: [PATCH 2/3] x_tables: Use also dev->ifalias for interface matching

On Monday 2015-01-12 17:04, Eric Dumazet wrote: > >iptables should have used ifindex [for interface matching], >it[']s sad we allowed the substring match in first place. How would you solve interface name wildcards with ifindices? (They come in handy if you have something like lots of tun+/veth+

Re: [PATCH 3/3] x_tables: Factor out 16bit aligment ifname_compare()

On Sunday 2015-01-11 22:30, Richard Weinberger wrote: Perhaps this would be better as bool ifname_compare > >Anyway, I agree with Linus wrt. bool. >https://lkml.org/lkml/2013/8/31/138 Had the function return "bool", it would have been obvious enough what to do with its return type. A return

Bug at 3.19-rc3:mm/rmap.c:399

Preliminary report that Linux kernel 3.19-rc3 [eb74926920cfa756087a82e0b081df837177cb95] gives a bug dump. When exiting JOSM (running on openjdk-1.7), the java process would sometimes get shot down. Last known good was v3.18.1. I probably need to turn on some debuginfo… unless you beat me to

Re: [RFC PATCH 1/1] module: Make wait module's refcount to zero procedure as async

On Monday 2013-09-16 05:47, Rusty Russell wrote: > >Here's what I've got in my pending-rebases tree. > >@@ -842,6 +818,11 @@ SYSCALL_DEFINE2(delete_module, const char __user *, >name_user, > return -EFAULT; > name[MODULE_NAME_LEN-1] = '\0'; > >+ if (!(flags & O_NONBLOCK)

Re: i915: pipe state still does not match

On Friday 2013-11-29 11:48, Chris Wilson wrote: >> What I could collect so far: > >Thanks, I broke the handling of cropped XvImages along the fast paths. >It should be fixed by: > >commit fd007d9d465b9b3ddbbaf769931ec921a6f5ecb8 >Author: Chris Wilson >Date: Thu Nov 28 21:13:33 2013 + > >

i915: pipe state still does not match

Greetings. Despite the i915/drm fixes added in v3.11.8, the X server still terminates due to some pipe state bug in 3.11.9. I have a fb setup to span two crtcs in below's configuration, and the kernel problem is easily triggerable for me by moving an Xv window (such as by using mplayer) forth a

Re: Linux 3.12 released .. and 4.0 plans?

On Monday 2013-11-04 01:10, Linus Torvalds wrote: > >Onto a totally different topic: we're getting to release numbers where >I have to take off my socks to count that high again. I'm ok with >3. [...] [4.0 "ok, after 3.19 (or whatever),"] What would you do when the major number becomes such an un

Re: [PATCH 11/12] netfilter: Remove extern from function prototypes

On Monday 2013-09-23 20:37, Joe Perches wrote: >There are a mix of function prototypes with and without extern >in the kernel sources. Standardize on not using extern for >function prototypes. > >Function prototypes don't need to be written with extern. >extern is assumed by the compiler. Its us

Re: Introducing libgadget 0.0.1

On Wednesday 2013-09-04 19:25, Matt Porter wrote: >With the move to configfs for creation of arbitrary USB composite gadgets, >I found myself wanting a simple C library to configure and parse gadgets >in a system. It has no other dependencies other than libc itself. > >It can be found at: > >

fixdep ought to be compiled with -D_FILE_OFFSET_BITS

Because fixdep is compiled without -D_FILE_OFFSET_BITS=64, a 32-bit fixdep (in a chroot build root, for example) may fail to run on a 64-bit host system if any file has an inode larger than 2^32, which can easily happen (in my case, on xfs): [ares07:~/rpmbuild/BUILD/kernel-pae-3.10.9~jng20/linux

Potentially missing "else"

nges up to e4523541e7f26457cf7078d5f30e091d1b24e3a9: depmod: add missing "else" clause (2013-08-07 23:50:51 +0200) -------- Jan Engelhardt (1): depmod: add missing "else" clause libkmod/libkmod-config.c | 2 +- tools/depmod.c

[PATCH] depmod: add missing "else" clause

It occurred to an openSUSE user that our mkinitrd would throw a warning when used with kmod: libkmod: conf_files_list: unsupported file mode /dev/null: 0x21b6 Grepping for the error message revealed that there might be a missing "else" keyword here, since it is unusual to put an "if" directly aft

Re: Read I/O starvation with writeback RAID controller

On Friday 2013-02-22 20:28, Martin Svec wrote: > > Yes, I've already tried the ROW scheduler. It helped for some low iodepths > depending on quantum settings but generally didn't solve the problem. I think > the key issue is that none of the schedulers can throttle I/O according to > e.g. > avera

Re: [Announce] Checkpoint-restore tool v0.4

On Wednesday 2013-02-20 12:18, Pavel Emelyanov wrote: > >As was planned, the v0.4 of C/R tools is out, right after the Linux v3.8. > >The most valuable thing in this release, is that all the kernel patches >we had are now merged, and thus what crtools-v0.4 can do will work on >the upstream kernel

Re: kconfig-frontends-3.8.0.0 release

On Wednesday 2013-02-20 00:21, Yann E. MORIN wrote: >> This seems to install >> /usr/bin/diff[...] > >By default, the binaries should all ne prefixed with 'kconfig-' to avoid >such name-clashing (as root, in a fresh debootstrap of squeeze here): Aha. Seems I hit a peculiarity in rpmbuild

Re: kconfig-frontends-3.8.0.0 release

On Tuesday 2013-02-19 23:14, Yann E. MORIN wrote: >I'm pleased to announce the release of kconfig-frontends 3.8.0.0! >Go download it there: > > http://ymorin.is-a-geek.org/download/kconfig-frontends/kconfig-frontends-3.8.0.0.tar.xz > > http://ymorin.is-a-geek.org/download/kconfig-frontends

Re: IPsec AH use of ahash

On Sunday 2013-01-20 14:54, Tom St Denis wrote: >> >> > You should really try running checkpatch.pl over code that's >> > already in the kernel before you call out new contributors on it. >> > >> > How is this supposed to not be adversarial when I can't even use >> > the Kernel source itself as a

Re: Redefinition of struct in6_addr in and

On Thursday 2013-01-17 03:05, David Miller wrote: >From: Carlos O'Donell >Date: Wed, 16 Jan 2013 20:58:47 -0500 > >> So I just went down the rabbit hole, and the further I get the >> closer I get to having two exact copies of the same definitions >> in both glibc and the kernel and using whicheve

Re: kconfig-frontends-3.6.0-0 released

On Sunday 2013-01-13 19:59, Yann E. MORIN wrote: >> >printf "Running libtoolize...\n" >> >libtoolize --copy --force >> >printf "Running aclocal...\n" >> >aclocal -Wall --force >> >> Not again. autoreconf has existed for so long, why are people still >> hand-coding the boilerplate? > >(Note: this

Re: kconfig-frontends-3.6.0-0 released

On Saturday 2012-10-06 17:55, Yann E. MORIN wrote: >Hello All! > >I'm pleased to announce the release of kconfig-frontends 3.6.0-0! >Go download it there: > > http://ymorin.is-a-geek.org/download/kconfig-frontends/kconfig-frontends-3.6.0-0.tar.xz Please stick to a single separator, i.e. "3.6

Re: [PATCH] vfs: update atimes over one day in the past or future

On Tuesday 2012-12-18 22:14, Dave Chinner wrote: > >> >> CC: sta...@vger.kernel.org >> >> --- >> >> fs/inode.c | 7 --- >> >> 1 ??? 4 ???(+)? 3 ???(-) >> > >> > There's something wrong with the character encoding you are using... >> >> Chinese locale, but proba

Re: [PATCH] make CONFIG_EXPERIMENTAL invisible and default

On Wednesday 2012-10-03 18:17, Greg Kroah-Hartman wrote: >> >> OK, I will bite... How should I flag an option that is initially only >> intended for those willing to take some level of risk? > >In the text say "You really don't want to enable this option, use at >your own risk!" Or something li

Re: Read starvation by sync writes

On Monday 2012-12-10 23:12, Jan Kara wrote: > > I was looking into IO starvation problems where streaming sync writes (in >my case from kjournald but DIO would look the same) starve reads. This is >because reads happen in small chunks and until a request completes we don't >start reading further

Re: [patch 7/7] fs, notify: Add procfs fdinfo helper v6

On Saturday 2012-11-17 00:56, Andrew Morton wrote: >> | pos: 0 >> | flags:0200 >> | inotify wd:3 ino: 9e7e >> | inotify wd:2 ino: a111 >> | inotify wd:1 ino:6b149[...] > >This is a lousy output format. It's sort-of like

percpu section failure with Gold linker

Hi, when compiling a kernel with the gold linker (3.7.0-rc6 26d29d06ea0204, gcc-4.7 and binutils-2.23 in my case), certain pcpu symbols are seemingly errneously copied over from .o files to .ko files, leading to a hard warning during depmod: gold$ make -j8 LD=gold HOSTLD=gold

Re: RFE: tty color features

On Tuesday 2012-09-25 08:01, Dave Yost wrote: >It would be nice to be able to specify fg/bg colors at the tty level, >so that echoed characters can be colorized. The tty layer does not know what $TERM is used, so it cannot reliably produce any codes. But you can edit GNU screen because it has t

Re: Drop support to compressed modules?

On Friday 2012-09-21 23:41, Lucas De Marchi wrote: > >While fixing a bug in kmod related to using compressed modules (that >already existed in module-init-tools) we stopped to think about these >questions. Dave made a couple of benchmarks and performance wise it's >better to use uncompressed modul

Re: [PATCH 00/13] overlay filesystem: request for inclusion (v15)

On Thursday 2012-09-20 22:48, Miklos Szeredi wrote: > >> Miklos, how do you think about this? >> >> Do you think UnionMount is totally gone? > >Unionmount provides almost the same functionality as overlayfs. The big >difference between the

Re: Question on /proc/cpuinfo

On Friday 2012-09-14 14:30, Cong Wang wrote: > On 09/14/2012 07:18 AM, JA Magallón wrote: >> Hi... >> >> Probably it is a stupid question, but... I wan to count the number of >> processors, cores and threads on a linux system. I do it by reading >> /proc/cpuinfo. > > Probably lscpu(1) is better fo

Re: [RFC/PATCH 2/2] block: Adding ROW scheduling algorithm

On Wednesday 2012-09-19 07:29, Jan Engelhardt wrote: >On Monday 2012-08-06 18:35, Jeff Moyer wrote: >>Tatyana Brokhman writes: >> >>> This patch adds the implementation of a new scheduling algorithm - ROW. >>> The policy of this algorithm is to prioritize READ r

Re: [RFC/PATCH 2/2] block: Adding ROW scheduling algorithm

On Monday 2012-08-06 18:35, Jeff Moyer wrote: >Tatyana Brokhman writes: > >> This patch adds the implementation of a new scheduling algorithm - ROW. >> The policy of this algorithm is to prioritize READ requests over WRITE >> as much as possible without starving the WRITE requests. > >Perhaps you

Re: [ANNOUNCE] kmod 10

On Thursday 2012-09-06 21:37, Lucas De Marchi wrote: > >kmod 10 is out: > >ftp://ftp.kernel.org/pub/linux/utils/kernel/kmod/kmod-10.tar.xz >ftp://ftp.kernel.org/pub/linux/utils/kernel/kmod/kmod-10.tar.sign make check fails here with glibc-2.15, gcc-4.7, x86_64, due to what seems to be duplicated

Re: [PATCH] strings: helper for maximum decimal encoding of an unsigned integer

On Friday 2012-09-14 15:46, Jim Rees wrote: >Jan Engelhardt wrote: > > >A pure K&R-C version would use a string: > >#define base10len(i) "\0x1\0x3\0x5\0x8\0x0A\0x0D\0x0F\0x11\0x14"[sizeof(i)] > >(if I converted them properly into hexadecimal) > The

Re: [PATCH] strings: helper for maximum decimal encoding of an unsigned integer

On Friday 2012-09-14 14:30, Jim Rees wrote in an odd quote style (the > are mine): >Bernd Petrovitsch wrote: > > A pure K&R-C version would use a string: > snip > #define base10len(i) "\0x1\0x3\0x5\0x8\0x0A\0x0D\0x0F\0x11\0x14"[sizeof(i)] > snip > (if I converted them p

Re: [PATCH] strings: helper for maximum decimal encoding of an unsigned integer

On Friday 2012-09-14 11:17, Bernd Petrovitsch wrote: >Shouldn't that have been > snip >#define base10len(i) ((const int[]){1,3,5,8,10,13,15,17,20}[sizeof(i)]) > snip Yeah. >A pure K&R-C version would use a string: >#define base10len(i) "\0x1\0x3\0x5\0x8\0x0A\0x0D\0x0F\0x11\0x1

Re: [PATCH] strings: helper for maximum decimal encoding of an unsigned integer

On Tuesday 2012-08-21 23:29, J. Bruce Fields wrote: >I've seen a couple examples recently where we've gotten this wrong. >Maybe something like this would help? Is there some better way? >(Approximation due to Jim Rees). > >+/* >+ * length of the decimal representation of an unsigned integer. Jus

Re: [PATCH 2/2] brd: RAM block module is called 'brd'

On Tuesday 2012-08-21 17:10, Paul Bolle wrote: > >2) "modinfo rd" doesn't work. Apparently one needs to feed modinfo the >actual module name and not an alias. Is that by design? I would say so, because you can call modprobe --resolve-alias rd to figure out the actual module to any given

Re: [PATCH 07/13] overlay: overlay filesystem documentation

On Wednesday 2012-08-15 17:48, Miklos Szeredi wrote: >[...] >+This is most obvious from the 'st_dev' field returned by stat(2). >+ >+While directories will report an st_dev from the overlay-filesystem, >+all non-directory objects will report an st_dev from the lower or >+upper filesystem that is p

Re: [PATCH] Add mach-specific includes

On Friday 2012-08-31 15:45, Michal Marek wrote: >> # Build header package >> (cd $srctree; find . -name Makefile\* -o -name Kconfig\* -o -name \*.pl > >> "$objtree/debian/hdrsrcfiles") >> (cd $srctree; find arch/$SRCARCH/include include scripts -type f >> >> "$objtree/debian/hdrsrcfiles") >>

Re: linux-user-chroot 2012.2

On Monday 2012-08-13 20:10, Andy Lutomirski wrote: > >One of these days, I intend to resurrect my unprivileged chroot kernel >patches. My current thought is to add a new syscall weak_chroot, >which should have these properties: >[...] >3. Can't be used to break out of chroot jail. > >The interfac

Re: Which disk is ata4?

On Thursday 2012-08-30 18:57, Andy Lutomirski wrote: >On Thu, Aug 30, 2012 at 9:14 AM, Jan Engelhardt wrote: >> On Thursday 2012-08-30 06:38, Andy Lutomirski wrote: >> >>>One of my disks went out to lunch for a while. Logs below. >>> >>>[784786.047673]

Re: Which disk is ata4?

On Thursday 2012-08-30 06:38, Andy Lutomirski wrote: >One of my disks went out to lunch for a while. Logs below. > >[784786.047673] ata4.00: exception Emask 0x10 SAct 0x7800 SErr 0x0 >action 0x6 frozen > >Which one is it? The only useful thing in /sys/class/ata_port/ata4 is >the device symlink,

Re: Which disk is ata4?

On Thursday 2012-08-30 17:22, Borislav Petkov wrote: >On Thu, Aug 30, 2012 at 08:17:13AM -0700, Andy Lutomirski wrote: >> $ dmesg |grep ST3000DM001-9YN166 >> [1.064910] ata5.00: ATA-8: ST3000DM001-9YN166, CC4B, max UDMA/133 >> [1.064926] ata3.00: ATA-8: ST3000DM001-9YN166, CC4B, max UDMA/1

Re: [PATCH v3 2/9] rbtree: add __rb_change_child() helper function

On Tuesday 2012-08-21 00:17, Andrew Morton wrote: > >If we have carefully made a decision to inline a function, we should >(now) use __always_inline. >If we have carefully made a decision to not inline a function, we >should use noinline. > >If we don't care, we should omit all such markings. >Thi

Re: [PATCH] fs: Introducing Lanyard Filesystem

On Sunday 2012-08-19 15:34, Dan Luedtke wrote: >I analyzed about 600k file stored on various removable storage devices. >80 volunteers sent in data about their devices, generated by a program >(windows) and scripts (linux, bsd, osx) I wrote for that purpose. The >data shows that people use more

Re: [PATCH] fs: Preserve error code in get_empty_filp()

On Wednesday 2012-08-01 20:19, anatol.pomo...@gmail.com wrote: >Allocating a file structure in function get_empty_filp() might fail because >of several reasons: > - not enough memory for file structures > - operation is not allowed > - user is over its limit > >Currently the function returns NULL

Re: RAID extremely slow

On Thursday 2012-07-26 03:00, Phil Turmel wrote: >> I used atop to show the transfer speeds to each drive. Here's a >> screenshot: >> http://img402.imageshack.us/img402/6484/screenshotfrom201207251.png > >[ The output of "lsdrv" [1] might be useful here, along with >"mdadm -D /dev/md0" and "mdadm

Re: [PATCH] scripts/patch-kernel fix

On Thursday 2012-07-26 12:10, Michal Marek wrote: >On 19.7.2012 23:49, Daniel Wisehart wrote: >> diff --git a/scripts/patch-kernel b/scripts/patch-kernel >> index d000ea3..a7672eb 100755 >> --- a/scripts/patch-kernel >> +++ b/scripts/patch-kernel >> @@ -226,7 +226,7 @@ fi >> >> # This all assum

Re: [vmw_vmci 11/11] Apply the header code to make VMCI build

On Thursday 2012-08-02 22:22, Sam Ravnborg wrote: >> On Friday 2012-07-27 12:34, Sam Ravnborg wrote: >> >> +#ifndef _VMCI_COMMONINT_H_ >> >> +#define _VMCI_COMMONINT_H_ >> >> + >> >> +#include >> >> +#include >> > >> >Use inverse chrismas tree here. >> >Longer include lines first, and soret alph

Re: [PATCH v5 8/8] Added /proc/net/sco via bt_procfs_init()

On Thursday 2012-07-26 06:24, Gustavo Padovan wrote: >Hi Masatake, > >* Masatake YAMATO [2012-07-26 01:30:12 +0900]: > >> Added /proc/net/sco via bt_procfs_init(). >> >> Signed-off-by: Masatake YAMATO >> --- >> net/bluetooth/sco.c |9 + >> 1 file changed, 9 insertions(+) > >All 8 p

Re: [PATCH] scripts/package/builddeb: upgrade to current practices

On Tuesday 2012-07-17 21:46, Martin-Éric Racine wrote: >>> @@ -188,17 +188,17 @@ This is a packacked upstream version of the Linux >>> kernel. >>> The sources may be found at most Linux ftp sites, including: >>> ftp://ftp.kernel.org/pub/linux/kernel >>> >>> -Copyright: 1991 - 2009 Linus Torvald

Re: [PATCH] add blockconsole version 1.1

On Wednesday 2012-07-18 20:53, Jörn Engel wrote: > >> With the include added, it builds fine. Then I took an usb stick and I >> did: >> >> $ ./mkblockconsole /dev/sdc >> >> > >You can also run hdparm -z instead. We have too many ways of doing some things. util-linux conveniently has `blockdev

Re: Regression - /proc/kmsg does not (always) block for 1-byte reads

On Saturday 2012-07-07 23:19, Kay Sievers wrote: >On Fri, Jul 6, 2012 at 10:30 PM, Linus Torvalds > wrote: >> Kay, this needs to be fixed. >> >> Suggested fix: just use the 'seq_printf()' interfaces, which do the >> proper buffering, and allow any size reads of various packetized data. > >I'll hav

Re: [PATCH] MPILIB: Provide count_leading/trailing_zeros() based on arch functions

On Saturday 2012-07-21 02:46, David Miller wrote: >> Arnd Bergmann wrote: >> >>> I don't generally like to put stuff into asm-generic when it's unlikely >>> to be overridden by architectures. It would really belong into >>> include/linux, but then again we have all the other bitops in asm-generi

Re: "Inconsistent kallsyms data" error

On Saturday 2012-07-07 23:40, Michal Marek wrote: >index cd9c6c6..4629038 100644 >--- a/scripts/link-vmlinux.sh >+++ b/scripts/link-vmlinux.sh >@@ -210,8 +210,8 @@ if [ -n "${CONFIG_KALLSYMS}" ]; then > mksysmap ${kallsyms_vmlinux} .tmp_System.map > > if ! cmp -s System.map .tmp_Syste

Re: [PATCH] fat: Refactor shortname parsing

On Friday 2012-08-03 17:06, OGAWA Hirofumi wrote: >>>+static inline unsigned char fat_tolower(unsigned char c) >>>+{ >>>+return ((c >= 'A') && (c <= 'Z')) ? c+32 : c; >>>+} >>>+ >> >> The kernel already has a tolower() function, can that not be used? > >tolower() is not exactly same, right? e.

Re: [PATCH] fat: Refactor shortname parsing

On Tuesday 2012-07-03 13:14, Steven J. Magnani wrote: >Nearly identical shortname parsing is performed in fat_search_long() >and __fat_readdir(). Extract this code into a function that may be >called by both. > >v2: Attempt to clarify difference between vfat and msdos parsing. >Remove decision

Re: [RFC PATCH] netconsole.txt: "nc" needs "-p" to specify the listening port

On Friday 2012-07-27 08:35, Dirk Gouders wrote: >diff --git a/Documentation/networking/netconsole.txt >b/Documentation/networking/netconsole.txt >index 8d02207..ffe30a7 100644 >--- a/Documentation/networking/netconsole.txt >+++ b/Documentation/networking/netconsole.txt >@@ -52,7 +52,7 @@ initiali

Re: [vmw_vmci 11/11] Apply the header code to make VMCI build

On Friday 2012-07-27 12:34, Sam Ravnborg wrote: >> +#ifndef _VMCI_COMMONINT_H_ >> +#define _VMCI_COMMONINT_H_ >> + >> +#include >> +#include > >Use inverse chrismas tree here. >Longer include lines first, and soret alphabetically when >lines are of the same length. So that's where unreadable in

Re: awful kconfig help texts.

On Wednesday 2012-08-01 09:43, Thierry Reding wrote: >> > >> > PWM Support (PWM) [N/y/?] (NEW) ? >> > >> > CONFIG_PWM: >> > This enables PWM support through the generic PWM framework. >> >> Oh, there's one more enlightening sentence in the help: >> >> "You only need to enable this, if you also

  1   2   3   4   5   6   7   8   9   10   >