Re: [PATCH] MAINTAINERS: Remove Jason Cooper's irqchip git tree

2017-07-28 Thread Jason Cooper
$dayjob has had me very busy. Which is a good thing :-) Unfortunately, when I have time for irqchip, I don't always have the time to properly follow up with pull-requests. So, for the time being, I'll stick to reviewing as I can. Acked-by: Jason Cooper thx, Jason.

Re: [PATCH] irqchip/gic/realview: remove unnecessary static in realview_gic_of_init()

2017-07-12 Thread Jason Cooper
gt; the output of the size command, before and after the code change: > > before: >textdata bss dec hex filename >2187 272 642523 9db drivers/irqchip/irq-gic-realview.o > > after: >textdata bss dec hex filename >

Re: [PATCH v2 05/23] MAINTAINERS: Add file patterns for dove device tree bindings

2017-03-17 Thread Jason Cooper
Hi Geert, On Fri, Mar 17, 2017 at 01:02:26PM +0100, Geert Uytterhoeven wrote: > In this particular case both maintainers are the same, but this is not true in > general. Hence deriving a platform maintainer from a Linux subsystem specific > binding document is the wrong way around. Ack. thx, J

Re: [PATCH v2 05/23] MAINTAINERS: Add file patterns for dove device tree bindings

2017-03-13 Thread Jason Cooper
Hi Geert, On Sun, Mar 12, 2017 at 02:16:49PM +0100, Geert Uytterhoeven wrote: > Submitters of device tree binding documentation may forget to CC > the subsystem maintainer if this is missing. > > Signed-off-by: Geert Uytterhoeven > Cc: Jason Cooper > Cc: Andrew Lun

Re: [PATCH] DTS: Linksys Board: Add default trigger for sata led

2017-02-18 Thread Jason Cooper
Please line wrap the commit message. Other than that, > > Signed-off-by: Ansuel Smith Acked-by: Jason Cooper thx, Jason. > --- > arch/arm/boot/dts/armada-385-linksys-caiman.dts | 1 + > arch/arm/boot/dts/armada-385-linksys-cobra.dts | 1 + > arch/arm/boot/dts/armada-xp-

Re: [PATCH] scripts: objdiff: Ignore debug info when comparing

2017-02-17 Thread Jason Cooper
's strip out the debug info and drop the > __bug_table here so that we don't see false positives. There may > be other things to drop later, and it may be architecture > specific, but this works for me with my ARM64 build. > > Cc: Masahiro Yamada > Cc: Jason Cooper >

Re: [PATCH] irqchip: mvebu-odmi: select GENERIC_MSI_IRQ_DOMAIN

2017-02-14 Thread Jason Cooper
Hi Arnd, On Tue, Feb 14, 2017 at 10:24:36PM +0100, Arnd Bergmann wrote: > This driver uses the MSI domain but has no strict dependency on PCI_MSI, so we > may run into a build failure when CONFIG_GENERIC_MSI_IRQ_DOMAIN is disabled: > > drivers/irqchip/irq-mvebu-odmi.c:152:15: error: variable 'odm

Re: [PATCH] ARM: mvebu: add support for the Linksys WRT1900ACS (Shelby)

2017-02-14 Thread Jason Cooper
#x27;imported from https://github.com/openwrt/openwrt commit 8466384db115 "mvebu: add support for 4.1 and switch over"' or something similar? Other than that, Acked-by: Jason Cooper thx, Jason.

[GIT PULL] irqchip: Fixes for v4.10

2017-02-10 Thread Jason Cooper
Thomas, This is a couple of fixes that have unintentionally had plenty of time in linux-next. :-/ Please pull. thx, Jason. The following changes since commit 7ce7d89f48834cefece7804d38fc5d85382edf77: Linux 4.10-rc1 (2016-12-25 16:13:08 -0800) are available in the git repository at: gi

Re: [PATCH] PCI: mvebu: Handle changes to the bridge windows while enabled

2017-01-30 Thread Jason Cooper
as, Jason C? > > > > Signed-off-by: Jason Gunthorpe > > > --- > > > drivers/pci/host/pci-mvebu.c | 101 > > > +-- > > > 1 file changed, 60 insertions(+), 41 deletions(-) Sorry, been on travel and I think Thomas is on holiday. Acked-by: Jason Cooper thx, Jason.

Re: [PATCH] irqchip: keystone: Fix "scheduling while atomic" on rt

2016-12-31 Thread Jason Cooper
Hi Grygorii, On Thu, Dec 08, 2016 at 05:33:10PM -0600, Grygorii Strashko wrote: > From: "Strashko, Grygorii" > > The below call chain generates "scheduling while atomic" backtrace and > causes system crash when Keystone 2 IRQ chip driver is used with RT-kernel: > > gic_handle_irq() > |-__handl

Re: [PATCH v2] staging: skein: threefish_block.c Remove blank lines

2016-11-20 Thread Jason Cooper
Hi Walt, > On Nov 19, 2016, at 11:54, Walt Feasel wrote: > > Make suggested checkpatch modification for > > CHECK: Please don't use multiple blank lines > > Signed-off-by: Walt Feasel I Acked the previous version, so you should place that above your S-o-b when submitting a new version. If n

Re: [PATCH] [STYLE]staging:skein:threefish_block.c remove blank lines

2016-11-15 Thread Jason Cooper
Hi Walt, Please ignore our side conversation, On Sat, Nov 12, 2016 at 03:02:53PM -0500, Walt Feasel wrote: > Made suggested modifications from checkpatch in reference > to CHECK: Please don't use multiple blank lines > > Signed-off-by: Walt Feasel Acked-by: Jason Cooper thx, Jason.

Re: [PATCH] [STYLE]staging:skein:threefish_block.c remove blank lines

2016-11-15 Thread Jason Cooper
Hi Dan, On Mon, Nov 14, 2016 at 01:34:15PM +0300, Dan Carpenter wrote: > Please just delete the blank lines. Sure, if that's what you guys prefer. > You aren't that special like a snow flake. Someone put his grumpy pants on backwards, didn't he? thx, Jason.

Re: [PATCH] [STYLE]staging:skein:threefish_block.c remove blank lines

2016-11-12 Thread Jason Cooper
Hi Walt, Thanks for the patch, unfortunately, it's a NAK. If you search the ml archives, you'll see this has been addressed before. On Sat, Nov 12, 2016 at 03:02:53PM -0500, Walt Feasel wrote: > Made suggested modifications from checkpatch in reference > to CHECK: Please don't use multiple blank

[GIT PULL] irqchip: Core changes for v4.9

2016-09-22 Thread Jason Cooper
: Fix typo "sporious" -> "spurious" Jason Cooper (3): Merge branch 'irqchip/jcore' into irqchip/core Merge branch 'irqchip/mvebu64' into irqchip/core Merge branch 'irqchip/mvebu64' into irqchip/core Paul Burton (1): ir

Re: [PATCH v4 2/9] drivers: irqchip: Add STM32 external interrupts support

2016-09-06 Thread Jason Cooper
On Tue, Sep 06, 2016 at 06:45:34PM +0200, Alexandre TORGUE wrote: > The STM32 external interrupt controller consists of edge detectors that > generate interrupts requests or wake-up events. > > Each line can be independently configured as interrupt or wake-up source, > and triggers either on risin

Re: [Patch v4 01/12] microblaze: irqchip: Move intc driver to irqchip

2016-09-02 Thread Jason Cooper
Hi Michal, Zubair, On Fri, Sep 02, 2016 at 12:27:54PM +0200, Michal Simek wrote: > On 2.9.2016 12:06, Zubair Lutfullah Kakakhel wrote: > > On 09/02/2016 07:25 AM, Michal Simek wrote: ... > >> Also there is another copy of this driver in the tree which was using > >> old ppc405 and ppc440 xilinx pl

Re: [Patch v4 01/12] microblaze: irqchip: Move intc driver to irqchip

2016-09-02 Thread Jason Cooper
Michal Simek wrote: > >>>> On 1.9.2016 18:50, Zubair Lutfullah Kakakhel wrote: > >>>>> V1 -> V2 > >>>>> > >>>>> Renamed irq-xilinx to irq-axi-intc > >>>>> Renamed CONFIG_XILINX_INTC to CONFIG_XILINX_AXI_INTC

Re: [PATCH] irqchip/keystone: fix typo "sporious" -> "spurious"

2016-09-01 Thread Jason Cooper
Hi Colin, On Thu, Sep 01, 2016 at 11:44:54AM +0100, Colin King wrote: > From: Colin Ian King > > Trivial fix to typo in dev_warn message. > > Signed-off-by: Colin Ian King > --- > drivers/irqchip/irq-keystone.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied to irqchip/core

Re: [PATCH v2 17/26] irqchip: mips-cpu: Introduce IPI IRQ domain support

2016-09-01 Thread Jason Cooper
Hi Paul, On Tue, Aug 30, 2016 at 06:29:20PM +0100, Paul Burton wrote: > Introduce support for registering an IPI IRQ domain suitable for use by > systems using the MIPS MT (multithreading) ASE within a single core. > This will allow for such systems to be supported generically, without > the curre

Re: [PATCH v3 6/8] hwrng: amd: Replace global variable with private struct

2016-08-27 Thread Jason Cooper
On Sat, Aug 27, 2016 at 02:43:31PM +, Jason Cooper wrote: > Hi Corentin, > > On Fri, Aug 26, 2016 at 01:11:34PM +0200, LABBE Corentin wrote: > > Instead of having two global variable, it's better to use a > > private struct. This will permit to remove amd_pdev varia

Re: [PATCH v3 0/8] hwrng: amd: rework of the amd hwrng driver

2016-08-27 Thread Jason Cooper
32/iowrite32 > hwrng: amd: Convert to new hwrng read() API > > drivers/char/hw_random/amd-rng.c | 150 > +-- > 1 file changed, 96 insertions(+), 54 deletions(-) Once you've fixed up the casting in #6, you can add my Reviewed-by: Jason Cooper to the series. thx, Jason.

Re: [PATCH v3 6/8] hwrng: amd: Replace global variable with private struct

2016-08-27 Thread Jason Cooper
Hi Corentin, On Fri, Aug 26, 2016 at 01:11:34PM +0200, LABBE Corentin wrote: > Instead of having two global variable, it's better to use a > private struct. This will permit to remove amd_pdev variable > > Signed-off-by: LABBE Corentin > --- > drivers/char/hw_random/amd-rng.c | 57 > ++

Re: [PATCH v2 5/5] hwrng: amd: Rework of the amd768-hwrng driver

2016-08-26 Thread Jason Cooper
Hi Corentin, On Fri, Aug 26, 2016 at 10:38:02AM +0200, LABBE Corentin wrote: > On Thu, Aug 25, 2016 at 02:56:38PM +0000, Jason Cooper wrote: > > On Thu, Aug 25, 2016 at 02:16:35PM +0200, LABBE Corentin wrote: > > > This patch convert the hwrng interface used by amd768-rng to it

Re: [PATCH v2 5/5] hwrng: amd: Rework of the amd768-hwrng driver

2016-08-25 Thread Jason Cooper
Hi Corentin, On Thu, Aug 25, 2016 at 02:16:35PM +0200, LABBE Corentin wrote: > This patch convert the hwrng interface used by amd768-rng to its new API > by replacing data_read()/data_present() by read(). > > Furthermore, Instead of having two global variable, it's better to use a > private struc

Re: [Regression?] Commit cb4f71c429 deliberately changes order of network interfaces

2016-08-24 Thread Jason Cooper
All, On Wed, Aug 24, 2016 at 10:41:02PM +0200, Ralph Sennhauser wrote: > On Wed, 24 Aug 2016 20:15:31 +0200 > Thomas Petazzoni wrote: > > On Wed, 24 Aug 2016 19:10:04 +0200, Ralph Sennhauser wrote: > > > > The people who can take this decision are rather the maintainers of > > the platform itsel

Re: [PATCH] irqchip: mips-gic: Use for_each_set_bit to iterate over IRQs

2016-08-22 Thread Jason Cooper
Hi Paul, On Fri, Aug 19, 2016 at 06:11:19PM +0100, Paul Burton wrote: > The MIPS GIC driver has previously iterated over bits set in a bitmap > representing pending IRQs by calling find_first_bit, clearing that bit > then calling find_first_bit again until all bits are clear. If multiple > interru

Re: [PATCH -next] irqchip/irq-jcore-aic: fix non static symbol warning

2016-08-22 Thread Jason Cooper
Hi Wei Yongjun, On Sat, Aug 20, 2016 at 03:26:28PM +, Wei Yongjun wrote: > Fixes the following sparse warning: > > drivers/irqchip/irq-jcore-aic.c:47:12: warning: > symbol 'aic_irq_of_init' was not declared. Should it be static? > > Signed-off-by: Wei Yongjun > --- > drivers/irqchip/irq-j

Re: [PATCH] sh: Fix building j2_defconfig

2016-08-16 Thread Jason Cooper
Hi Rob, On Tue, Aug 16, 2016 at 04:15:22PM -0500, Rob Landley wrote: > On 08/16/2016 10:41 AM, Jason Cooper wrote: > > When targeting the j2, we need to retain '-m2'. Previously, the > > Makefile blew out -m2 on the next line via :=. > > > > Fix this

[PATCH] sh: Fix building j2_defconfig

2016-08-16 Thread Jason Cooper
When targeting the j2, we need to retain '-m2'. Previously, the Makefile blew out -m2 on the next line via :=. Fix this by s/:=/+=/ when building for the J2. Fixes: 5a846abad07f6 ("sh: add support for J-Core J2 processor") Signed-off-by: Jason Cooper --- Thanks to Richard F

Re: [PATCH 0/4] arm64: marvell: add support for the PIC and PMU

2016-08-16 Thread Jason Cooper
Hi Thomas, On Fri, Aug 05, 2016 at 04:55:17PM +0200, Thomas Petazzoni wrote: > Hello, > > This small patch series intends to add support for the PMU of the > Cortex-A72 cores found in the Marvell Armada 7K/8K SoCs. > > However, the interrupt of the PMU is not directly connected to the > GIC, but

Re: [PATCH v6 0/2] J-Core interrupt controller support

2016-08-16 Thread Jason Cooper
Hi Rich, On Thu, Aug 04, 2016 at 02:31:18PM +, Jason Cooper wrote: > On Thu, Aug 04, 2016 at 04:30:36AM +, Rich Felker wrote: > > Updated based on feedback from Thomas Gleixner. Removal of unnecessary > > data allowed some simplification. Magic numbers have been re

Re: [PATCH 1/9] microblaze: irqchip: Move intc driver to irqchip

2016-08-15 Thread Jason Cooper
Hi Zubair, On Mon, Aug 15, 2016 at 02:55:27PM +0100, Zubair Lutfullah Kakakhel wrote: > The Xilinx AXI Interrupt Controller IP block is used by the MIPS > based xilfpga platform. > > Move the interrupt controller code out of arch/microblaze so that > it can be used by everyone > > Signed-off-by:

Re: [PATCH 8/9] MIPS: xilfpga: Add DT node for AXI emaclite

2016-08-15 Thread Jason Cooper
Hi Zubair, On Mon, Aug 15, 2016 at 02:55:34PM +0100, Zubair Lutfullah Kakakhel wrote: > The xilfpga platform has a Xilinx AXI emaclite block. > > Add the DT node to use it. > > Signed-off-by: Zubair Lutfullah Kakakhel > --- > arch/mips/boot/dts/xilfpga/nexys4ddr.dts | 27 ++

Re: [PATCH 4/9] MIPS: xilfpga: Use Xilinx AXI Interrupt Controller

2016-08-15 Thread Jason Cooper
Hi Zubair, On Mon, Aug 15, 2016 at 02:55:30PM +0100, Zubair Lutfullah Kakakhel wrote: > IRQs from peripherals such as i2c/uart/ethernet come via > the AXI Interrupt controller. > > Select it in Kconfig for xilfpga and add the DT node > > Signed-off-by: Zubair Lutfullah Kakakhel > --- > arch/mi

Re: [PATCH 1/9] microblaze: irqchip: Move intc driver to irqchip

2016-08-15 Thread Jason Cooper
Hi Zubair, On Mon, Aug 15, 2016 at 02:55:27PM +0100, Zubair Lutfullah Kakakhel wrote: > The Xilinx AXI Interrupt Controller IP block is used by the MIPS > based xilfpga platform. > > Move the interrupt controller code out of arch/microblaze so that > it can be used by everyone > > Signed-off-by:

Re: [PATCH v2] RANDOM: ATH9K RNG delivers zero bits of entropy

2016-08-14 Thread Jason Cooper
Hey Ted, On Wed, Aug 10, 2016 at 07:44:25PM -0400, Theodore Ts'o wrote: > On Tue, Aug 09, 2016 at 02:04:44PM +0000, Jason Cooper wrote: > > iiuc, Ted, you're saying using the hw_random framework would be > > disasterous because despite most drivers having a default quali

Re: [PATCH] hwrng: core - Allow for multiple simultaneous active hwrng devices

2016-08-09 Thread Jason Cooper
Hi Keith, On Tue, Aug 09, 2016 at 10:58:05AM -0700, Keith Packard wrote: > Jason Cooper writes: > > Perhaps a /dev/hwrng[0-9] per rng? That would lend itself nicely to a > > sysfs interface for per device quality, rate, and enabled attributes. > > e.g. /sys/class/hw_

Re: [PATCH] hwrng: core - Allow for multiple simultaneous active hwrng devices

2016-08-09 Thread Jason Cooper
Hi Keith, Herbert, On Tue, Aug 09, 2016 at 05:50:58PM +0800, Herbert Xu wrote: > On Mon, Jul 25, 2016 at 01:07:35PM -0700, Keith Packard wrote: > > Instead of having only one hwrng feeding /dev/random at a time, maintain > > a list of devices and cycle between them when filling the entropy pool. >

Re: [PATCH v2] RANDOM: ATH9K RNG delivers zero bits of entropy

2016-08-09 Thread Jason Cooper
Hi Ted, On Tue, Aug 09, 2016 at 07:56:22AM -0400, Theodore Ts'o wrote: > On Tue, Aug 09, 2016 at 06:30:03AM +, Pan, Miaoqing wrote: > > Agree with Jason's point, also understand Stephan's concern. The > > date rate can be roughly estimated by 'cat /dev/random |rngtest -c > > 1000', the averag

Re: [PATCH v2] RANDOM: ATH9K RNG delivers zero bits of entropy

2016-08-08 Thread Jason Cooper
Hi Stephan, On Mon, Aug 08, 2016 at 05:29:30PM +, Jason Cooper wrote: > On Mon, Aug 08, 2016 at 08:41:36AM +0200, Stephan Mueller wrote: ... > > If you think that this patch is a challenge because your driver starts to > > spin, please help and offer another solution. > &

Re: [PATCH v2] RANDOM: ATH9K RNG delivers zero bits of entropy

2016-08-08 Thread Jason Cooper
Hi Stephan, Miaoqing Pan, On Mon, Aug 08, 2016 at 08:41:36AM +0200, Stephan Mueller wrote: > Am Montag, 8. August 2016, 02:03:36 CEST schrieb Pan, Miaoqing: > > The entropy was evaluated by crypto expert, the analysis report show the > > ADC with at least 10bits and up to 22 bits of min-entropy f

Re: [RFC][PATCH] RANDOM: ATH9K RNG delivers zero bits of entropy

2016-08-06 Thread Jason Cooper
Hi Stephan, On Sat, Aug 06, 2016 at 10:03:58PM +0200, Stephan Mueller wrote: > Am Samstag, 6. August 2016, 19:45:51 CEST schrieb Jason Cooper: > > On Fri, Aug 05, 2016 at 05:08:14PM +0200, Stephan Mueller wrote: ... > > > diff --git a/drivers/net/wireless/ath/ath9k/rng.c &

Re: [RFC][PATCH] RANDOM: ATH9K RNG delivers zero bits of entropy

2016-08-06 Thread Jason Cooper
> -ATH9K_RNG_ENTROPY(bytes_read)); This is the only use of this macro. I'd remove the #define on line 25 as well. > + add_hwgenerator_randomness((void *)rng_buf, bytes_read, 0); > } > > kfree(rng_buf); Other than that, Reviewed-by: Jason Cooper thx, Jason.

Re: [PATCH 2/4] irqchip: irq-mvebu-pic: new driver for Marvell Armada 7K/8K PIC

2016-08-05 Thread Jason Cooper
Hi Thomas, On Fri, Aug 05, 2016 at 05:58:12PM +0200, Thomas Petazzoni wrote: > On Fri, 5 Aug 2016 15:31:13 +0000, Jason Cooper wrote: > > > > +config MVEBU_PIC > > > + bool > > > > tri-state? Is there anything else attached to the PIC besides the PMU? &g

Re: [PATCH 2/4] irqchip: irq-mvebu-pic: new driver for Marvell Armada 7K/8K PIC

2016-08-05 Thread Jason Cooper
Hi Thomas, On Fri, Aug 05, 2016 at 04:55:19PM +0200, Thomas Petazzoni wrote: > The Marvell Armada 7K/8K integrates a secondary interrupt controller > very originally named "PIC". It is connected to the main GIC via a > PPI. Amongst other things, this PIC is used for the ARM PMU. > > This commit a

Re: [PATCH v6 0/2] J-Core interrupt controller support

2016-08-04 Thread Jason Cooper
Hi Rich, On Thu, Aug 04, 2016 at 04:30:36AM +, Rich Felker wrote: > Updated based on feedback from Thomas Gleixner. Removal of unnecessary > data allowed some simplification. Magic numbers have been replaced > with meaningful (I hope) macro constants, comments added, and minor > style issues f

Re: [PATCH v3 7/7] random: Remove unused randomize_range()

2016-08-03 Thread Jason Cooper
On Wed, Aug 03, 2016 at 04:48:10PM -0700, Andrew Morton wrote: > On Wed, 3 Aug 2016 23:39:13 +0000 Jason Cooper wrote: > > > All call sites for randomize_range have been updated to use the much > > simpler and more robust randomize_addr. Remove the now un

[PATCH v3 1/7] random: Simplify API for random address requests

2016-08-03 Thread Jason Cooper
ed once all callers have been converted over to randomize_addr(). Signed-off-by: Jason Cooper --- Changes from v2: - s/randomize_addr/randomize_page/ (Kees Cook) - PAGE_ALIGN(start) if it wasn't (Kees Cook, Michael Ellerman) drivers/char/random.c | 33 + includ

[PATCH v3 6/7] unicore32: Use simpler API for random address requests

2016-08-03 Thread Jason Cooper
: Jason Cooper --- Changes from v2: - s/randomize_addr/randomize_page/ (Kees Cook) arch/unicore32/kernel/process.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/unicore32/kernel/process.c b/arch/unicore32/kernel/process.c index 00299c927852..d7c6b676b3a5 100644 --- a/arch

[PATCH v3 7/7] random: Remove unused randomize_range()

2016-08-03 Thread Jason Cooper
All call sites for randomize_range have been updated to use the much simpler and more robust randomize_addr. Remove the now unnecessary code. Signed-off-by: Jason Cooper --- drivers/char/random.c | 19 --- include/linux/random.h | 1 - 2 files changed, 20 deletions(-) diff

[PATCH v3 3/7] ARM: Use simpler API for random address requests

2016-08-03 Thread Jason Cooper
: Jason Cooper --- Changes from v2: - s/randomize_addr/randomize_page/ (Kees Cook) arch/arm/kernel/process.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c index 4a803c5a1ff7..3ee2fb4c9ae6 100644 --- a/arch/arm/kernel

[PATCH v3 2/7] x86: Use simpler API for random address requests

2016-08-03 Thread Jason Cooper
: Jason Cooper --- Changes from v2: - s/randomize_addr/randomize_page/ (Kees Cook) arch/x86/kernel/process.c| 3 +-- arch/x86/kernel/sys_x86_64.c | 5 + 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c index 96becbbb52e0

[PATCH v3 0/7] char/random: Simplify random address requests

2016-08-03 Thread Jason Cooper
Cook) - PAGE_ALIGN(start) if it wasn't (Kees Cook, Michael Ellerman) Changes from v1: - Explicitly mention page_aligned start assumption (Yann Droneaud) - pick random pages vice random addresses (Yann Droneaud) - catch range=0 last - Add Ack for arm64 (Will Deacon) Jason Cooper (7)

[PATCH v3 4/7] arm64: Use simpler API for random address requests

2016-08-03 Thread Jason Cooper
: Jason Cooper Acked-by: Will Deacon --- Changes from v2: - s/randomize_addr/randomize_page/ (Kees Cook) arch/arm64/kernel/process.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/arch/arm64/kernel/process.c b/arch/arm64/kernel/process.c index 6cd2612236dc..6ac2950ffb78

[PATCH v3 5/7] tile: Use simpler API for random address requests

2016-08-03 Thread Jason Cooper
: Jason Cooper --- Changes from v2: - s/randomize_addr/randomize_page/ (Kees Cook) arch/tile/mm/mmap.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/tile/mm/mmap.c b/arch/tile/mm/mmap.c index 851a94e6ae58..ef61c597898b 100644 --- a/arch/tile/mm/mmap.c +++ b/arch/tile/mm

Re: [kernel-hardening] Re: [PATCH v2 1/7] random: Simplify API for random address requests

2016-08-03 Thread Jason Cooper
On Tue, Aug 02, 2016 at 01:35:13PM +1000, Michael Ellerman wrote: > Jason Cooper writes: > > On Mon, Aug 01, 2016 at 12:47:59PM -0700, Kees Cook wrote: > >> On Sun, Jul 31, 2016 at 1:56 PM, Jason Cooper wrote: > >> > >> I have no new call sites in mind,

Re: [PATCH v2 1/7] random: Simplify API for random address requests

2016-08-01 Thread Jason Cooper
Hi Kees, On Mon, Aug 01, 2016 at 12:47:59PM -0700, Kees Cook wrote: > On Sun, Jul 31, 2016 at 1:56 PM, Jason Cooper wrote: > > On Sun, Jul 31, 2016 at 09:46:53AM -0700, Kees Cook wrote: > >> On Sat, Jul 30, 2016 at 8:42 AM, Jason Cooper wrote: > >> > To date,

Re: [PATCH v4 1/3] irqchip/qeic: move qeic driver from drivers/soc/fsl/qe

2016-08-01 Thread Jason Cooper
Hi Zhao Qiang, On Mon, Aug 01, 2016 at 10:53:18AM +0800, Zhao Qiang wrote: > move the driver from drivers/soc/fsl/qe to drivers/irqchip, > merge qe_ic.h and qe_ic.c into irq-qeic.c. > > Signed-off-by: Zhao Qiang > --- > Changes for v2: > - modify the subject and commit msg > Changes for v3

Re: [PATCH 1/1] irqdomain: Export __irq_domain_alloc_irqs() and irq_domain_free_irqs()

2016-08-01 Thread Jason Cooper
Hi Alexander, On Sat, Jul 30, 2016 at 02:21:21AM +0300, Alexander Popov wrote: > On 27.07.2016 14:22, Christoph Hellwig wrote: > > just submit your PV irq chip for the kernel. It's so small that there > > propbably is not need to even make it modular. > > Thanks a lot for your reply! > I'll try

Re: [kernel-hardening] Re: [PATCH] [RFC] Introduce mmap randomization

2016-07-31 Thread Jason Cooper
Hi Daniel, On Fri, Jul 29, 2016 at 06:10:02AM -0400, Daniel Micay wrote: > > > In the Project Zero Stagefright post > > > (http://googleprojectzero.blogspot.com/2015/09/stagefrightened.html) > > > , we see that the linear allocation of memory combined with the > > > low number of bits in the initi

Re: [PATCH v2 1/7] random: Simplify API for random address requests

2016-07-31 Thread Jason Cooper
On Sun, Jul 31, 2016 at 09:46:53AM -0700, Kees Cook wrote: > On Sat, Jul 30, 2016 at 8:42 AM, Jason Cooper wrote: > > To date, all callers of randomize_range() have set the length to 0, and > > check for a zero return value. For the current callers, the only way > > to ge

[PATCH v2 6/7] unicore32: Use simpler API for random address requests

2016-07-30 Thread Jason Cooper
: Jason Cooper --- Changes from v1: - none arch/unicore32/kernel/process.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/unicore32/kernel/process.c b/arch/unicore32/kernel/process.c index 00299c927852..b856178cf167 100644 --- a/arch/unicore32/kernel/process.c +++ b/arch

[PATCH v2 1/7] random: Simplify API for random address requests

2016-07-30 Thread Jason Cooper
ed once all callers have been converted over to randomize_addr(). Signed-off-by: Jason Cooper --- Changes from v1: - Explicitly mention page_aligned start assumption (Yann Droneaud) - pick random pages vice random addresses (Yann Droneaud) - catch range=0 last drivers/char/ran

[PATCH v2 3/7] ARM: Use simpler API for random address requests

2016-07-30 Thread Jason Cooper
: Jason Cooper --- Changes from v1: - none arch/arm/kernel/process.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c index 4a803c5a1ff7..02dee671cded 100644 --- a/arch/arm/kernel/process.c +++ b/arch/arm/kernel/process.c

[PATCH v2 5/7] tile: Use simpler API for random address requests

2016-07-30 Thread Jason Cooper
: Jason Cooper --- Changes from v1: - none arch/tile/mm/mmap.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/tile/mm/mmap.c b/arch/tile/mm/mmap.c index 851a94e6ae58..50f6a693a2b6 100644 --- a/arch/tile/mm/mmap.c +++ b/arch/tile/mm/mmap.c @@ -88,6 +88,5 @@ void

[PATCH v2 4/7] arm64: Use simpler API for random address requests

2016-07-30 Thread Jason Cooper
: Jason Cooper Acked-by: Will Deacon --- Changes from v1: - Add Ack for arm64 (Will Deacon) arch/arm64/kernel/process.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/arch/arm64/kernel/process.c b/arch/arm64/kernel/process.c index 6cd2612236dc..11bf454baf86 100644 --- a

[PATCH v2 2/7] x86: Use simpler API for random address requests

2016-07-30 Thread Jason Cooper
: Jason Cooper --- Changes from v1: - none arch/x86/kernel/process.c| 3 +-- arch/x86/kernel/sys_x86_64.c | 5 + 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c index 96becbbb52e0..a083a2c0744e 100644 --- a/arch/x86/kernel

[PATCH v2 7/7] random: Remove unused randomize_range()

2016-07-30 Thread Jason Cooper
All call sites for randomize_range have been updated to use the much simpler and more robust randomize_addr. Remove the now unnecessary code. Signed-off-by: Jason Cooper --- Changes from v1: - none drivers/char/random.c | 19 --- include/linux/random.h | 1 - 2 files

[PATCH v2 0/7] char/random: Simplify random address requests

2016-07-30 Thread Jason Cooper
from the various subsystems so that we can merge this as one bisectable branch. Changes from v1: - Explicitly mention page_aligned start assumption (Yann Droneaud) - pick random pages vice random addresses (Yann Droneaud) - catch range=0 last - Add Ack for arm64 (Will Deacon) Jason Coop

Re: [PATCH 1/7] random: Simplify API for random address requests

2016-07-29 Thread Jason Cooper
Hi Yann, First, thanks for the review! On Fri, Jul 29, 2016 at 10:59:14AM +0200, Yann Droneaud wrote: > Le jeudi 28 juillet 2016 à 20:47 +0000, Jason Cooper a écrit : > > To date, all callers of randomize_range() have set the length to 0, > > and check for a zero return value.  

[PATCH 0/7] char/random: Simplify random address requests

2016-07-28 Thread Jason Cooper
from the various subsystems so that we can merge this as one bisectable branch. Jason Cooper (7): random: Simplify API for random address requests x86: Use simpler API for random address requests ARM: Use simpler API for random address requests arm64: Use simpler API for random address req

[PATCH 3/7] ARM: Use simpler API for random address requests

2016-07-28 Thread Jason Cooper
: Jason Cooper --- arch/arm/kernel/process.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c index 4a803c5a1ff7..02dee671cded 100644 --- a/arch/arm/kernel/process.c +++ b/arch/arm/kernel/process.c @@ -314,8 +314,7 @@ unsigned

[PATCH 6/7] unicore32: Use simpler API for random address requests

2016-07-28 Thread Jason Cooper
: Jason Cooper --- arch/unicore32/kernel/process.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/unicore32/kernel/process.c b/arch/unicore32/kernel/process.c index 00299c927852..b856178cf167 100644 --- a/arch/unicore32/kernel/process.c +++ b/arch/unicore32/kernel/process.c

[PATCH 2/7] x86: Use simpler API for random address requests

2016-07-28 Thread Jason Cooper
: Jason Cooper --- arch/x86/kernel/process.c| 3 +-- arch/x86/kernel/sys_x86_64.c | 5 + 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c index 96becbbb52e0..a083a2c0744e 100644 --- a/arch/x86/kernel/process.c +++ b/arch/x86

[PATCH 4/7] arm64: Use simpler API for random address requests

2016-07-28 Thread Jason Cooper
: Jason Cooper --- arch/arm64/kernel/process.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/arch/arm64/kernel/process.c b/arch/arm64/kernel/process.c index 6cd2612236dc..11bf454baf86 100644 --- a/arch/arm64/kernel/process.c +++ b/arch/arm64/kernel/process.c @@ -374,12

[PATCH 7/7] random: Remove unused randomize_range()

2016-07-28 Thread Jason Cooper
All call sites for randomize_range have been updated to use the much simpler and more robust randomize_addr. Remove the now unnecessary code. Signed-off-by: Jason Cooper --- drivers/char/random.c | 19 --- include/linux/random.h | 1 - 2 files changed, 20 deletions(-) diff

[PATCH 5/7] tile: Use simpler API for random address requests

2016-07-28 Thread Jason Cooper
: Jason Cooper --- arch/tile/mm/mmap.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/tile/mm/mmap.c b/arch/tile/mm/mmap.c index 851a94e6ae58..50f6a693a2b6 100644 --- a/arch/tile/mm/mmap.c +++ b/arch/tile/mm/mmap.c @@ -88,6 +88,5 @@ void arch_pick_mmap_layout(struct

[PATCH 1/7] random: Simplify API for random address requests

2016-07-28 Thread Jason Cooper
turning the start address on error. randomize_range() will be removed once all callers have been converted over to randomize_addr(). Signed-off-by: Jason Cooper --- drivers/char/random.c | 26 ++ include/linux/random.h | 1 + 2 files changed, 27 insertions(+) diff --gi

Re: [PATCH] [RFC] Introduce mmap randomization

2016-07-28 Thread Jason Cooper
On Wed, Jul 27, 2016 at 09:59:35AM -0700, Nick Kralevich wrote: > On Tue, Jul 26, 2016 at 1:59 PM, Jason Cooper wrote: > >> > One thing I didn't make clear in my commit message is why this is good. > >> > Right > >> > now, if you know An addre

Re: [RFC patch 1/6] random: Simplify API for random address requests

2016-07-28 Thread Jason Cooper
On Tue, Jul 26, 2016 at 10:07:22AM -0700, Kees Cook wrote: > On Tue, Jul 26, 2016 at 10:00 AM, Jason Cooper wrote: ... > > if (range == 0 || ULONG_MAX - range < start) > > return start; > > Should it "abort" like this? I was thinking just cap the range,

Re: [PATCH] [RFC] Introduce mmap randomization

2016-07-26 Thread Jason Cooper
On Tue, Jul 26, 2016 at 09:06:30PM +, Roberts, William C wrote: > > From: owner-linux...@kvack.org [mailto:owner-linux...@kvack.org] On > > Behalf Of Jason Cooper > > On Tue, Jul 26, 2016 at 08:13:23PM +, Roberts, William C wrote: > > > > > From: Jason Co

Re: [PATCH] [RFC] Introduce mmap randomization

2016-07-26 Thread Jason Cooper
Hi William, On Tue, Jul 26, 2016 at 08:13:23PM +, Roberts, William C wrote: > > > From: Jason Cooper [mailto:ja...@lakedaemon.net] > > > On Tue, Jul 26, 2016 at 11:22:26AM -0700, william.c.robe...@intel.com > > > wrote: > > > > Performance Measuremen

Re: [PATCH] [RFC] Introduce mmap randomization

2016-07-26 Thread Jason Cooper
Hi William! On Tue, Jul 26, 2016 at 11:22:26AM -0700, william.c.robe...@intel.com wrote: > From: William Roberts > > This patch introduces the ability randomize mmap locations where the > address is not requested, for instance when ld is allocating pages for > shared libraries. It chooses to ran

Re: [RFC patch 1/6] random: Simplify API for random address requests

2016-07-26 Thread Jason Cooper
Hi Kees, On Mon, Jul 25, 2016 at 09:39:58PM -0700, Kees Cook wrote: > On Mon, Jul 25, 2016 at 8:30 PM, Jason Cooper wrote: > > On Tue, Jul 26, 2016 at 03:01:55AM +0000, Jason Cooper wrote: > >> To date, all callers of randomize_range() have set the length to 0, and > >&

Re: [RFC patch 1/6] random: Simplify API for random address requests

2016-07-26 Thread Jason Cooper
On Mon, Jul 25, 2016 at 09:44:27PM -0700, Kees Cook wrote: > On Mon, Jul 25, 2016 at 8:01 PM, Jason Cooper wrote: > > To date, all callers of randomize_range() have set the length to 0, and > > check for a zero return value. For the current callers, the only way > > to ge

Re: [RFC patch 1/6] random: Simplify API for random address requests

2016-07-25 Thread Jason Cooper
All, On Tue, Jul 26, 2016 at 03:01:55AM +, Jason Cooper wrote: > To date, all callers of randomize_range() have set the length to 0, and > check for a zero return value. For the current callers, the only way > to get zero returned is if end <= start. Since they are all adding

[RFC patch 6/6] unicore32: Use simpler API for random address requests

2016-07-25 Thread Jason Cooper
: Jason Cooper --- arch/unicore32/kernel/process.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/unicore32/kernel/process.c b/arch/unicore32/kernel/process.c index 00299c927852..b856178cf167 100644 --- a/arch/unicore32/kernel/process.c +++ b/arch/unicore32/kernel/process.c

[RFC patch 4/6] arm64: Use simpler API for random address requests

2016-07-25 Thread Jason Cooper
: Jason Cooper --- arch/arm64/kernel/process.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/arch/arm64/kernel/process.c b/arch/arm64/kernel/process.c index 6cd2612236dc..11bf454baf86 100644 --- a/arch/arm64/kernel/process.c +++ b/arch/arm64/kernel/process.c @@ -374,12

[RFC patch 2/6] x86: Use simpler API for random address requests

2016-07-25 Thread Jason Cooper
: Jason Cooper --- arch/x86/kernel/process.c| 3 +-- arch/x86/kernel/sys_x86_64.c | 5 + 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c index 96becbbb52e0..a083a2c0744e 100644 --- a/arch/x86/kernel/process.c +++ b/arch/x86

[RFC patch 5/6] tile: Use simpler API for random address requests

2016-07-25 Thread Jason Cooper
: Jason Cooper --- arch/tile/mm/mmap.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/tile/mm/mmap.c b/arch/tile/mm/mmap.c index 851a94e6ae58..50f6a693a2b6 100644 --- a/arch/tile/mm/mmap.c +++ b/arch/tile/mm/mmap.c @@ -88,6 +88,5 @@ void arch_pick_mmap_layout(struct

[RFC patch 3/6] ARM: Use simpler API for random address requests

2016-07-25 Thread Jason Cooper
: Jason Cooper --- arch/arm/kernel/process.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c index 4a803c5a1ff7..02dee671cded 100644 --- a/arch/arm/kernel/process.c +++ b/arch/arm/kernel/process.c @@ -314,8 +314,7 @@ unsigned

[RFC patch 1/6] random: Simplify API for random address requests

2016-07-25 Thread Jason Cooper
, we should match caller expectations to avoid coming up short (ha!) in the future. Signed-off-by: Jason Cooper --- drivers/char/random.c | 17 - include/linux/random.h | 2 +- 2 files changed, 5 insertions(+), 14 deletions(-) diff --git a/drivers/char/random.c b/drivers/ch

Re: [PATCH] randomize_range: use random long instead of int

2016-07-25 Thread Jason Cooper
Hi William, Kees, On Mon, Jul 25, 2016 at 11:25:41AM -0700, william.c.robe...@intel.com wrote: > From: William Roberts > > Use a long when generating the random range rather than > an int. This will produce better random distributions as > well as matching all the types at hand. > > Signed-off-

Re: [Patch v3 1/3] irqchip/qeic: move qeic driver from drivers/soc/fsl/qe

2016-07-25 Thread Jason Cooper
Hi Zhao Qiang, On Mon, Jul 25, 2016 at 04:59:54PM +0800, Zhao Qiang wrote: > move the driver from drivers/soc/fsl/qe to drivers/irqchip, > merge qe_ic.h and qe_ic.c into irq-qeic.c. > > Signed-off-by: Zhao Qiang > --- > Changes for v2: > - modify the subject and commit msg > Changes for v3

Re: [PATCH v2 02/10] irqchip: add irqchip driver for nuc900

2016-07-21 Thread Jason Cooper
Wan ZongShun, On Fri, Jul 15, 2016 at 12:02:55PM +0200, Arnd Bergmann wrote: > On Friday, July 15, 2016 5:44:50 PM CEST Wan ZongShun wrote: > > 2016-07-15 15:00 GMT+08:00 Arnd Bergmann : > > > On Friday, July 15, 2016 1:15:58 PM CEST Wan Zongshun wrote: ... > > > That assumes that REG_AIC_IPER con

Re: [RFC PATCH v1] irqchip: add support for SMP irq router

2016-07-20 Thread Jason Cooper
Hey Sebastian, On Wed, Jul 20, 2016 at 01:42:45PM +0200, Sebastian Frias wrote: > On 07/06/2016 06:28 PM, Jason Cooper wrote: > > On Wed, Jul 06, 2016 at 01:37:21PM +0200, Sebastian Frias wrote: > >> On 07/05/2016 06:16 PM, Jason Cooper wrote: > >>>> Come to th

Re: [PATCH] irqchip: armada: avoid unused function warnings

2016-07-18 Thread Jason Cooper
/irqchip/irq-armada-370-xp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Jason Cooper Anna-Maria, can you make sure this gets pulled in with the cpuhp changes? afaict, cb5ff2d245c1 is only in the tip/WIP.hotplug and tip/master. thx, Jason.

Re: [PATCH v3 08/12] irqchip: add J-Core AIC driver

2016-07-15 Thread Jason Cooper
Hi Rich, On Wed, May 25, 2016 at 05:43:03AM +, Rich Felker wrote: > There are two versions of the J-Core interrupt controller in use, aic1 > which generates interrupts with programmable priorities, but only > supports 8 irq lines and maps them to cpu traps in the range 17 to 24, > and aic2 whi

  1   2   3   4   5   6   7   8   9   10   >