Re: [PATCH v2] MIPS: fix incorrect mem=X@Y handling

2018-01-31 Thread Marcin Nowakowski
d to an overall cleaner (and probably slightly smaller) code. Marcin On Tue, Jan 23, 2018 at 3:17 PM, James Hogan wrote: On Thu, Dec 21, 2017 at 10:00:59PM +0100, Mathieu Malaterre wrote: From: Marcin Nowakowski Change 73fbc1eba7ff added a fix to ensure that the memory range between

Re: [PATCH 07/14] MIPS: memblock: Mark present sparsemem sections

2018-01-23 Thread Marcin Nowakowski
Hi Serge, On 17.01.2018 23:23, Serge Semin wrote: If sparsemem is activated all sections with present pages must be accordingly marked after memblock is fully initialized. Signed-off-by: Serge Semin --- arch/mips/kernel/setup.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) di

Re: [PATCH v2 1/2] nvmem: add driver for JZ4780 efuse

2017-12-29 Thread Marcin Nowakowski
Hi Mathieu, On 28.12.2017 22:29, Mathieu Malaterre wrote: --- /dev/null +++ b/drivers/nvmem/jz4780-efuse.c @@ -0,0 +1,305 @@ +/* + * JZ4780 EFUSE Memory Support driver + * + * Copyright (c) 2017 PrasannaKumar Muralidharan + * + * This program is free software; you can redistribute it and/or mo

Re: [PATCH 1/2] nvmem: add driver for JZ4780 efuse

2017-12-28 Thread Marcin Nowakowski
Hi Mathieu, On 28.12.2017 08:26, Mathieu Malaterre wrote: Hi Marcin, On Thu, Dec 28, 2017 at 8:13 AM, Marcin Nowakowski mailto:marcin.nowakow...@mips.com>> wrote: > Hi Mathieu, PrasannaKumar, > > On 27.12.2017 13:27, Mathieu Malaterre wrote: >> >> From:

Re: [PATCH 1/2] nvmem: add driver for JZ4780 efuse

2017-12-27 Thread Marcin Nowakowski
Hi Mathieu, PrasannaKumar, On 27.12.2017 13:27, Mathieu Malaterre wrote: From: PrasannaKumar Muralidharan This patch brings support for the JZ4780 efuse. Currently it only expose a read only access to the entire 8K bits efuse memory. Tested-by: Mathieu Malaterre Signed-off-by: PrasannaKumar

Re: [RFC] MIPS memblock: Remove bootmem code and switch to NO_BOOTMEM

2017-12-21 Thread Marcin Nowakowski
Hi Serge, On 19.12.2017 21:14, Serge Semin wrote: Hello folks, Almost a year ago I sent a patchset to the Linux MIPS community. The main target of the patchset was to get rid from the old bootmem allocator usage at the MIPS architecture. Additionally I had a problem with CMA usage on my MIPS

Re: Fwd: stable-rc/linux-4.4.y build: 182 builds: 60 failed, 122 passed, 60 errors, 60 warnings (v4.4.99-60-g803704b287d8)

2017-11-20 Thread Marcin Nowakowski
Hi Arnd, Greg, On 19.11.2017 21:55, Arnd Bergmann wrote: [Adding the others to cc] -- Forwarded message -- From: Arnd Bergmann Date: Sun, Nov 19, 2017 at 9:53 PM Subject: Re: stable-rc/linux-4.4.y build: 182 builds: 60 failed, 122 passed, 60 errors, 60 warnings (v4.4.99-60-g803

Re: [PATCH for 4.9 11/59] MIPS: fix mem=X@Y commandline processing

2017-09-14 Thread Marcin Nowakowski
Hi, On 14.09.2017 21:17, Mathieu Malaterre wrote: On Thu, Sep 14, 2017 at 9:11 PM, Levin, Alexander (Sasha Levin) wrote: On Thu, Sep 14, 2017 at 08:59:05PM +0200, Mathieu Malaterre wrote: On Thu, Sep 14, 2017 at 5:51 PM, Levin, Alexander (Sasha Levin) wrote: From: Marcin Nowakowski

Re: [PATCH] mips: Fix using smp_processor_id() when preemptible

2017-08-10 Thread Marcin Nowakowski
Hi Corey, This has already been fixed here: https://git.linux-mips.org/cgit/ralf/upstream-sfr.git/commit/?id=21da5332327b6d183bd93336ecf29c70bc609b7b https://git.linux-mips.org/cgit/ralf/upstream-sfr.git/commit/?id=735302665c353d6756e7fa2a2cf41b039299f732 Marcin On 09.08.2017 23:25, miny...@ac

Re: [PATCH] MIPS: perf: fix build failure

2017-06-25 Thread Marcin Nowakowski
Hi Sudip, This patch fixes the build error, but leaves the I6500 handling incorrect. I had explained to Ralf how the build should be fixed a while ago so hopefully he will fix it up in his -next branch (dd71e57bacb5 should have been applied on top of f7a31b5e7874, but in Ralf's tree f7a31b5e78

[PATCH 0/3] kselftest build errors

2017-06-23 Thread Marcin Nowakowski
This patch series fixes build errors observed when building net, memfd, gpio and intel_pstate tests Marcin Nowakowski (3): selftests/{net,memfd}: fix undefined references to external libraries selftests/gpio: fix build error selftests/intel_pstate: fix undefined reference when building

[PATCH 3/3] selftests/intel_pstate: fix undefined reference when building

2017-06-23 Thread Marcin Nowakowski
Currently the build fails with: /tmp/ccmgtz8N.o: In function `main': aperf.c:(.text+0x278): undefined reference to `sqrt' collect2: error: ld returned 1 exit status Replace LDFLAGS with LDLIBS to ensure proper ordering of arguments in build rules. Signed-off-by: Marcin Nowakowski

[PATCH 1/3] selftests/{net,memfd}: fix undefined references to external libraries

2017-06-23 Thread Marcin Nowakowski
mplicit rules. Fixes: a8ba798bc8ec ('selftests: enable O and KBUILD_OUTPUT') Signed-off-by: Marcin Nowakowski --- tools/testing/selftests/memfd/Makefile | 4 ++-- tools/testing/selftests/net/Makefile | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/test

[PATCH 2/3] selftests/gpio: fix build error

2017-06-23 Thread Marcin Nowakowski
when invoked recursively from selftests build and this is left as a future task to resolve properly. Fixes: a8ba798bc8ec ('selftests: enable O and KBUILD_OUTPUT') Signed-off-by: Marcin Nowakowski --- tools/testing/selftests/gpio/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 dele

Re: [PATCH v2 15/17] MIPS: JZ4770: Workaround for corrupted DMA transfers

2017-06-22 Thread Marcin Nowakowski
Hi Paul, Maarten, On 20.06.2017 17:18, Paul Cercueil wrote: From: Maarten ter Huurne We have seen MMC DMA transfers read corrupted data from SDRAM when a burst interval ends at physical address 0x1000. To avoid this problem, we remove the final page of low memory from the memory map. Sign

[PATCH] kernel/extable.c: mark core_kernel_text notrace

2017-06-21 Thread Marcin Nowakowski
10/0x1b8 [3.041915] [<804e589c>] ftrace_ops_no_ops+0x114/0x1bc [3.047923] [<8045478c>] core_kernel_text+0x10/0x1b8 [3.053682] [<804119b8>] prepare_ftrace_return+0x6c/0x114 [3.059938] [<80411b2c>] ftrace_graph_caller+0x20/0x44 (...) Mark the function notrace to avoi

[tip:irq/urgent] irqchip/mips-gic: Mark count and compare accessors notrace

2017-06-20 Thread tip-bot for Marcin Nowakowski
Commit-ID: 9f93d87cba63e3d18629261243b1f633519eabb5 Gitweb: http://git.kernel.org/tip/9f93d87cba63e3d18629261243b1f633519eabb5 Author: Marcin Nowakowski AuthorDate: Fri, 9 Jun 2017 09:04:05 +0200 Committer: Thomas Gleixner CommitDate: Tue, 20 Jun 2017 21:41:58 +0200 irqchip/mips-gic

[tip:sched/urgent] sched/fair: Fix typo in printk message

2017-06-11 Thread tip-bot for Marcin Nowakowski
Commit-ID: f67abed585efe251edda52dc9690020d6441890f Gitweb: http://git.kernel.org/tip/f67abed585efe251edda52dc9690020d6441890f Author: Marcin Nowakowski AuthorDate: Fri, 9 Jun 2017 10:00:29 +0200 Committer: Ingo Molnar CommitDate: Sun, 11 Jun 2017 10:00:33 +0200 sched/fair: Fix typo

[PATCH] sched/fair: fix typo in printk message

2017-06-09 Thread Marcin Nowakowski
'schedstats' kernel parameter should be set to enable/disable, so correct the printk hint saying that it should be set to 'enable' rather than 'enabled' to enable scheduler tracepoints. Signed-off-by: Marcin Nowakowski --- kernel/sched/fair.c | 2 +- 1 file chang

[PATCH v2] irqchip/mips-gic: mark count and compare accessors notrace

2017-06-09 Thread Marcin Nowakowski
longer than the update timeout leading to update failure. Signed-off-by: Marcin Nowakowski --- v2: move notrace attribute after return type --- drivers/irqchip/irq-mips-gic.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/irqchip/irq-mips-gic.c b/drivers

Re: [PATCH] irqchip/mips-gic: mark count and compare accessors notrace

2017-06-08 Thread Marcin Nowakowski
Hi Marc, On 08.06.2017 15:26, Marc Zyngier wrote: On Thu, Jun 08 2017 at 3:06:23 pm BST, Marcin Nowakowski wrote: gic_read_count(), gic_write_compare() and gic_write_cpu_compare() are often used in a sequence to update the compare register with a count value increased by a small offset

[PATCH] irqchip/mips-gic: mark count and compare accessors notrace

2017-06-08 Thread Marcin Nowakowski
longer than the update timeout leading to update failure. Signed-off-by: Marcin Nowakowski --- drivers/irqchip/irq-mips-gic.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/irqchip/irq-mips-gic.c b/drivers/irqchip/irq-mips-gic.c index eb7fbe1..ecee073 100644

Re: [PATCH 06/15] serial: 8250_ingenic: Parse earlycon options

2017-06-08 Thread Marcin Nowakowski
Hi Paul, On 07.06.2017 22:04, Paul Cercueil wrote: In the devicetree, it is possible to specify the baudrate, parity, bits, flow of the early console, by passing a configuration string like this: aliases { serial0 = &uart0; }; chosen { stdout-path = "serial0:57600n8"; }; This,

Re: [PATCH 00/21] MIPS memblock: Remove bootmem code and switch to NO_BOOTMEM

2017-05-22 Thread Marcin Nowakowski
Hi Serge, On 22.05.2017 12:26, Serge Semin wrote: Regarding the patchset. I'm still pretty much eager to make it being part of kernel MIPS arch. But there was a problem I outlined in the patchset header message, which I can't fix by myself. Particulary It's connected with Loonson3 or SGI IP27 c

Re: [PATCH 00/21] MIPS memblock: Remove bootmem code and switch to NO_BOOTMEM

2017-05-22 Thread Marcin Nowakowski
Hi Serge, On 19.12.2016 03:07, Serge Semin wrote: Most of the modern platforms supported by linux kernel have already been cleaned up of old bootmem allocator by moving to nobootmem interface wrapping up the memblock. This patchset is the first attempt to do the similar improvement for MIPS for

Re: [PATCH 1/2] pwm: loongson1: Add PWM driver for Loongson1 SoC

2017-02-16 Thread Marcin Nowakowski
Hi Yang, On 15.02.2017 14:09, Yang Ling wrote: + tmp = (unsigned long long)clk_get_rate(pc->clk) * period_ns; + do_div(tmp, 10); NSEC_PER_SEC ? + period = tmp; + + tmp = (unsigned long long)period * duty_ns; + do_div(tmp, period_ns); + duty = peri

Re: [PATCH] tools/lib/api: allow the linker to be overridden

2017-02-15 Thread Marcin Nowakowski
Hi Arnaldo, On 15.02.2017 16:18, Arnaldo Carvalho de Melo wrote: Em Wed, Feb 15, 2017 at 03:56:30PM +0100, Marcin Nowakowski escreveu: Makefile in lib/api unconditionally sets the LD to support cross-compilation. However, when invoked from within the perf build LD may be already appropriately

[PATCH] tools/lib/api: allow the linker to be overridden

2017-02-15 Thread Marcin Nowakowski
override to a conditional one. Fixes: 37b4e2020a5f ('perf build: Add EXTRA_LDFLAGS option to makefile') Fixes: 703e01652d25 ('tools lib api: Respect CROSS_COMPILE for the linker') Signed-off-by: Marcin Nowakowski --- tools/lib/api/Makefile | 2 +- 1 file changed, 1 insertion(+),

Re: [PATCH 1/2] pwm: loongson1: Add PWM driver for Loongson1 SoC

2017-02-14 Thread Marcin Nowakowski
Hi Yang, On 13.02.2017 16:28, Yang Ling wrote: Add support for the PWM controller present in Loongson1 family of SoCs. Signed-off-by: Yang Ling --- drivers/pwm/Kconfig | 9 +++ drivers/pwm/Makefile| 1 + drivers/pwm/pwm-loongson1.c | 169 ++

[PATCH RESEND] Kbuild: add cpp_its_S in ksym_dep_filter

2017-02-13 Thread Marcin Nowakowski
Add a new command cpp_its_S introduced in: cf2a5e0bb4c6 ("MIPS: Support generating Flattened Image Trees (.itb)") to ksym_dep_filter handler - otherwise a warning is produced during the build of MIPS platforms (when vmlinux.*.itb target is chosen) Signed-off-by: Marcin Nowakowski --

[PATCH] Kbuild: add cpp_its_S in ksym_dep_filter

2017-02-13 Thread Marcin Nowakowski
Add a new command cpp_its_S introduced in: cf2a5e0bb4c6 ("MIPS: Support generating Flattened Image Trees (.itb)") to ksym_dep_filter handler - otherwise a warning is produced during the build of MIPS platforms (when vmlinux.*.itb target is chosen) Signed-off-by: Marcin Nowakowski --

[PATCH 1/1] irqchip/mips-gic: Fix local interrupts

2017-01-25 Thread Marcin Nowakowski
n attempting to use perf tool to access hardware performance counters. Fix this by explicitly calling irq_create_fwspec_mapping() for local interrupts. Fixes: e875bd66dfb ("irqchip/mips-gic: Fix local interrupts") Signed-off-by: Marcin Nowakowski Cc: Paul Burton Cc: Thomas Gleixner C

Re: [PATCH 10/21] MIPS memblock: Discard bootmem allocator initialization

2017-01-22 Thread Marcin Nowakowski
Hi Serge, On 19.12.2016 03:07, Serge Semin wrote: Bootmem allocator initialization needs to be discarded. PFN limit constants are still in use by some subsystems, so they need to be properly initialized. The initialization is moved into a separate method and performed with help of commonly used

Re: [PATCH 00/21] MIPS memblock: Remove bootmem code and switch to NO_BOOTMEM

2017-01-22 Thread Marcin Nowakowski
Hi Serge, Thanks for this patch series, it's really useful. I've tested it on Malta and Ci40 and it seems to work well (I've posted a few small comments separately). On 19.12.2016 03:07, Serge Semin wrote: Most of the modern platforms supported by linux kernel have already been cleaned up o

Re: [PATCH 04/21] MIPS memblock: Alter user-defined memory parameter parser

2017-01-22 Thread Marcin Nowakowski
Hi Serge, On 19.12.2016 03:07, Serge Semin wrote: Both new memblock and boot_mem_map subsystems need to be fully cleared before a new memory region is added. So the early parser is correspondingly modified. Signed-off-by: Serge Semin --- arch/mips/kernel/setup.c | 67 +

[PATCH RESEND 0/2] kbuild: dead code elimination: ftrace fixes

2016-12-22 Thread Marcin Nowakowski
properly handle the section names as created by the use of -ffunction-sections. The following 2 patches fix that behaviour. They are based on next-20161208. Marcin Nowakowski (2): kbuild: keep __mcount_loc table through dead code elimination recordmcount: fix mcount recording with -ffunction

[PATCH 1/2] kbuild: keep __mcount_loc table through dead code elimination

2016-12-22 Thread Marcin Nowakowski
When CONFIG_LD_DEAD_CODE_DATA_ELIMINATION is enabled we must ensure __mcount_loc is preserved, as otherwise there are no valid entries for ftrace to work with. Fixes: 4b89b7f7aad5 ('kbuild: keep data tables through dead code elimination') Signed-off-by: Marcin Nowakowski Acked-by

[PATCH 2/2] recordmcount: fix mcount recording with -ffunction-sections

2016-12-22 Thread Marcin Nowakowski
0-9a-zA-Z_]*", add a similar pattern matching to recordmcount script for section detection. To simplify the basic C implementation, replace the regex with a string match on the prefix and a single character match following the '.text.' prefix. Signed-off-by: Marcin Nowakowski

Re: [PATCH RESEND 0/2] kbuild: dead code elimination: ftrace fixes

2016-12-22 Thread Marcin Nowakowski
Hi Nick, On 22.12.2016 10:08, Nicholas Piggin wrote: On Thu, 22 Dec 2016 09:51:45 +0100 Marcin Nowakowski wrote: Enabling dead code & data elimination currently breaks ftrace operation, as the __mcount_loc section is removed (as it is not referenced directly anywhere in the code). More

Re: [tip:perf/urgent] uprobes: Fix uprobes on MIPS, allow for a cache flush after ixol breakpoint creation

2016-12-20 Thread Marcin Nowakowski
Hi Oleg, On 20.12.2016 14:08, Oleg Nesterov wrote: On 12/19, tip-bot for Marcin Nowakowski wrote: uprobes: Fix uprobes on MIPS, allow for a cache flush after ixol breakpoint creation Commit: 72e6ae285a1d ('ARM: 8043/1: uprobes need icache flush after xol write' ... has int

[tip:perf/urgent] uprobes: Fix uprobes on MIPS, allow for a cache flush after ixol breakpoint creation

2016-12-19 Thread tip-bot for Marcin Nowakowski
Commit-ID: 297e765e390a2ac996000b5f7228cbd84d995174 Gitweb: http://git.kernel.org/tip/297e765e390a2ac996000b5f7228cbd84d995174 Author: Marcin Nowakowski AuthorDate: Tue, 13 Dec 2016 11:40:57 +0100 Committer: Ingo Molnar CommitDate: Sun, 18 Dec 2016 09:42:11 +0100 uprobes: Fix uprobes

[PATCH] uprobes: allow for a cache flush after ixol breakpoint creation

2016-12-13 Thread Marcin Nowakowski
ruction is copied, caches are not flushed at all and stale data may be found in icache. Replace a simple copy_to_page() with arch_uprobe_copy_ixol() to allow the arch to ensure all caches are updated accordingly. This change fixes uprobes on MIPS InterAptiv (tested on Creator Ci40). Signed-off-

[PATCH v2 2/2] kprobes/trace: Fix kprobe selftest for newer gcc

2016-12-09 Thread Marcin Nowakowski
lts despite the test method being optimised away. Finally, add __init annotations to find_trace_probe_file() and kprobe_trace_selftest_target() as they are only called from within an __init method. Signed-off-by: Marcin Nowakowski --- kernel/trace/trace_kprobe.c | 28 +++-

[PATCH v2 1/2] tracing/kprobes: add a helper method to return number of probe hits

2016-12-09 Thread Marcin Nowakowski
ff-by: Marcin Nowakowski --- kernel/trace/trace_kprobe.c | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) v2: improved commit message as suggested by Steven Rostedt diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c index eb6c9f1..a2af1bc 100644 --- a/k

Re: [PATCH 1/2] tracing/kprobes: add a helper method to return number of probe hits

2016-12-09 Thread Marcin Nowakowski
On 09.12.2016 15:03, Steven Rostedt wrote: On Fri, 9 Dec 2016 09:00:52 -0500 Steven Rostedt wrote: On Fri, 9 Dec 2016 13:25:51 +0100 Marcin Nowakowski wrote: The number of probe hits is stored in a percpu variable and therefore can't be read directly. Add a helper method trace_kprobe

[PATCH 1/2] tracing/kprobes: add a helper method to return number of probe hits

2016-12-09 Thread Marcin Nowakowski
The number of probe hits is stored in a percpu variable and therefore can't be read directly. Add a helper method trace_kprobe_nhit() that performs the required calculation. Signed-off-by: Marcin Nowakowski --- kernel/trace/trace_kprobe.c | 19 +-- 1 file changed, 13 inser

[PATCH 2/2] kprobes/trace: Fix kprobe selftest for newer gcc

2016-12-09 Thread Marcin Nowakowski
lts despite the test method being optimised away. Finally, add __init annotations to find_trace_probe_file() and kprobe_trace_selftest_target() as they are only called from within an __init method. Signed-off-by: Marcin Nowakowski --- kernel/trace/trace_kprobe.c | 28 +++-

[PATCH] drivers/of: fix missing pr_cont()s in of_print_phandle_args

2016-12-01 Thread Marcin Nowakowski
Since the KERN_CONT changes, the current debug printks have a lot of empty lines making the log messages very hard to read. Signed-off-by: Marcin Nowakowski --- drivers/of/base.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/of/base.c b/drivers/of/base.c

[PATCH] elfcore.h: add trailing semi-colon in elf_core_copy_regs()

2016-11-21 Thread Marcin Nowakowski
* macro invocations throughout this file. Signed-off-by: Marcin Nowakowski --- include/linux/elfcore.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/elfcore.h b/include/linux/elfcore.h index 698d51a..be7 100644 --- a/include/linux/elfcore.h +++ b/include/linux

[PATCH] kbuild: protect compiled-in dtb from dead data elimination

2016-10-26 Thread Marcin Nowakowski
DTBs are compiled into byte arrays that are placed inside .dtb.init.rodata section. As they are never referenced directly from the code, they get removed during dead data elimination and we end up with __dtb_start == __dtb_end. Signed-off-by: Marcin Nowakowski Fixes: b67067f1176d ("kbuild:

[PATCH v4 03/12] tracing/syscalls: drop arch_syscall_match_sym_name

2016-10-14 Thread Marcin Nowakowski
. Next commit will make syscall_match_sym_name implementation a bit larger, so clean it up now to avoid further patching arch code whenever the core method changes. Signed-off-by: Marcin Nowakowski Signed-off-by: Michael Ellerman --- Documentation/trace/ftrace-design.txt | 4 arch/powerpc

[PATCH v4 12/12] parisc/tracing: fix compat syscall handling

2016-10-14 Thread Marcin Nowakowski
Add missing arch code - arch_trace_is_compat_syscall and arch_syscall_addr Signed-off-by: Marcin Nowakowski Cc: Steven Rostedt Cc: Ingo Molnar Cc: "James E.J. Bottomley" Cc: Helge Deller Cc: linux-par...@vger.kernel.org --- arch/parisc/include/asm/ftrace.h | 10 ++ a

[PATCH v4 10/12] tile/tracing: fix compat syscall handling

2016-10-14 Thread Marcin Nowakowski
Add missing arch code - arch_trace_is_compat_syscall and arch_syscall_addr Signed-off-by: Marcin Nowakowski Cc: Steven Rostedt Cc: Ingo Molnar Signed-off-by: Chris Metcalf --- arch/tile/include/asm/ftrace.h | 10 ++ arch/tile/kernel/Makefile | 1 + arch/tile/kernel/ftrace.c

[PATCH v4 02/12] tracing/syscalls: add handling for compat tasks

2016-10-14 Thread Marcin Nowakowski
s. Signed-off-by: Marcin Nowakowski Cc: Steven Rostedt Cc: Ingo Molnar --- arch/mips/kernel/ftrace.c | 4 +- arch/powerpc/kernel/ftrace.c | 2 +- include/linux/ftrace.h| 2 +- kernel/trace/trace.h | 17 +- kernel/trace/trace_syscal

[PATCH v4 04/12] tracing/syscalls: add compat syscall metadata

2016-10-14 Thread Marcin Nowakowski
Now that compat syscalls are properly distinguished from native calls, we can add metadata for compat syscalls as well. All the macros used to generate the metadata are the same as for standard syscalls, but with a compat_ prefix to distinguish them easily. Signed-off-by: Marcin Nowakowski Cc

[PATCH v4 05/12] tracing/syscalls: allow arch to override syscall_get_nr for ftrace

2016-10-14 Thread Marcin Nowakowski
umber from the regs provided. This will be used by x86 in a follow-up change. Signed-off-by: Marcin Nowakowski Cc: Steven Rostedt Cc: Ingo Molnar --- kernel/trace/trace_syscalls.c | 4 1 file changed, 4 insertions(+) diff --git a/kernel/trace/trace_syscalls.c b/kernel/trace/trace_syscal

[PATCH v4 06/12] x86/tracing: fix compat syscall handling

2016-10-14 Thread Marcin Nowakowski
bit from syscall numbers. Signed-off-by: Marcin Nowakowski Cc: Steven Rostedt Cc: Ingo Molnar Cc: Thomas Gleixner Cc: "H. Peter Anvin" Cc: x...@kernel.org --- arch/x86/include/asm/ftrace.h | 14 ++ arch/x86/include/asm/syscall.h | 9 + arch/x86/kernel/ftrace.c

[PATCH v4 05/12] syscall/tracing: allow arch to override syscall_get_nr for ftrace

2016-10-14 Thread Marcin Nowakowski
umber from the regs provided. This will be used by x86 in a follow-up change. Signed-off-by: Marcin Nowakowski Cc: Steven Rostedt Cc: Ingo Molnar --- kernel/trace/trace_syscalls.c | 4 1 file changed, 4 insertions(+) diff --git a/kernel/trace/trace_syscalls.c b/kernel/trace/trace_syscal

[PATCH v4 09/12] powerpc/tracing: fix compat syscall handling

2016-10-14 Thread Marcin Nowakowski
Adapt the code to make use of new syscall handling interface Signed-off-by: Marcin Nowakowski Cc: Steven Rostedt Cc: Ingo Molnar Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Michael Ellerman Cc: linuxppc-...@lists.ozlabs.org --- arch/powerpc/include/asm/ftrace.h | 13

[PATCH v4 07/12] s390/tracing: fix compat syscall handling

2016-10-14 Thread Marcin Nowakowski
Add missing arch code - arch_trace_is_compat_syscall and arch_syscall_addr Signed-off-by: Marcin Nowakowski Cc: Steven Rostedt Cc: Ingo Molnar Cc: Martin Schwidefsky Cc: Heiko Carstens Cc: linux-s...@vger.kernel.org --- arch/s390/include/asm/ftrace.h | 11 +++ arch/s390/include/asm

[PATCH v4 11/12] sparc/tracing: fix compat syscall handling

2016-10-14 Thread Marcin Nowakowski
Add missing arch code - arch_trace_is_compat_syscall and arch_syscall_addr Signed-off-by: Marcin Nowakowski Cc: Steven Rostedt Cc: Ingo Molnar Cc: "David S. Miller" Cc: sparcli...@vger.kernel.org --- arch/sparc/include/asm/ftrace.h | 10 ++ arch/sparc/kernel/Makefile

[PATCH v4 08/12] arm64/tracing: fix compat syscall handling

2016-10-14 Thread Marcin Nowakowski
Add arch_syscall_addr for arm64 and define NR_compat_syscalls, as the number of compat syscalls for arm64 exceeds the number defined by NR_syscalls. Convert the existing uses of __NR_compat_syscalls to the newly introduced NR_compat_syscalls Signed-off-by: Marcin Nowakowski Cc: Steven Rostedt

[PATCH v4 00/12] syscall/tracing: compat syscall support

2016-10-14 Thread Marcin Nowakowski
of linux-next-20161011 - tile: change in_compat_syscall to is_compat_task (suggested and signed-off by Chris Metcalf) Marcin Nowakowski (12): tracing/syscalls: remove syscall_nr from syscall metadata tracing/syscalls: add handling for compat tasks tracing/syscalls: drop arch_syscall_m

[PATCH v4 01/12] tracing/syscalls: remove syscall_nr from syscall metadata

2016-10-14 Thread Marcin Nowakowski
syscall lookup together with the syscall metadata table traversal to register for appropriate events instead. This slightly increases the overhead during event (un)registration, but does not impact the trace events themselves, which still use syscall numbers directly. Signed-off-by: Marcin Nowakowski

Re: [PATCH v3 05/11] x86/tracing: fix compat syscall handling

2016-10-12 Thread Marcin Nowakowski
On 12.10.2016 15:53, Thomas Gleixner wrote: On Tue, 11 Oct 2016, Marcin Nowakowski wrote: -/* - * Because ia32 syscalls do not map to x86_64 syscall numbers - * this screws up the trace output when tracing a ia32 task. - * Instead of reporting bogus syscalls, just do not trace them. - * - * If

Re: [PATCH v3 08/11] powerpc/tracing: fix compat syscall handling

2016-10-12 Thread Marcin Nowakowski
On 12.10.2016 11:59, Michael Ellerman wrote: I went to test this and noticed the exit and enter events appear to be reversed in time? (your series on top of 24532f768121) thanks for testing the patch - I've found a bug that has sneaked in while cleaning up the patches before submission ... I

Re: [PATCH v3 03/11] tracing/syscalls: add compat syscall metadata

2016-10-12 Thread Marcin Nowakowski
On 12.10.2016 10:50, Michael Ellerman wrote: <...> It's annoying that we have to duplicate all that just to do a + 1. How about this as a precursor? > <...> Thanks for the suggestion - unless anyone sees a reason to keep the current solution I'll change it. Marcin

Re: [PATCH v3 07/11] arm64/tracing: fix compat syscall handling

2016-10-12 Thread Marcin Nowakowski
Hi Will, On 11.10.2016 15:36, Will Deacon wrote: On Tue, Oct 11, 2016 at 12:42:52PM +0200, Marcin Nowakowski wrote: Add arch_syscall_addr for arm64 and define NR_compat_syscalls, as the number of compat syscalls for arm64 exceeds the number defined by NR_syscalls. Signed-off-by: Marcin

[PATCH v3 02/11] tracing/syscalls: add handling for compat tasks

2016-10-11 Thread Marcin Nowakowski
s. Signed-off-by: Marcin Nowakowski Cc: Steven Rostedt Cc: Ingo Molnar --- arch/mips/kernel/ftrace.c | 4 +- arch/powerpc/kernel/ftrace.c | 2 +- include/linux/ftrace.h| 2 +- kernel/trace/trace.h | 17 +- kernel/trace/trace_syscal

[PATCH v3 08/11] powerpc/tracing: fix compat syscall handling

2016-10-11 Thread Marcin Nowakowski
Adapt the code to make use of new syscall handling interface Signed-off-by: Marcin Nowakowski Cc: Steven Rostedt Cc: Ingo Molnar Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Michael Ellerman Cc: linuxppc-...@lists.ozlabs.org --- arch/powerpc/include/asm/ftrace.h | 11 +++ arch

[PATCH v3 10/11] sparc/tracing: fix compat syscall handling

2016-10-11 Thread Marcin Nowakowski
Add missing arch code - arch_trace_is_compat_syscall and arch_syscall_addr Signed-off-by: Marcin Nowakowski Cc: Steven Rostedt Cc: Ingo Molnar Cc: "David S. Miller" Cc: sparcli...@vger.kernel.org --- arch/sparc/include/asm/ftrace.h | 10 ++ arch/sparc/kernel/Makefile

[PATCH v3 06/11] s390/tracing: fix compat syscall handling

2016-10-11 Thread Marcin Nowakowski
Add missing arch code - arch_trace_is_compat_syscall and arch_syscall_addr Signed-off-by: Marcin Nowakowski Cc: Steven Rostedt Cc: Ingo Molnar Cc: Martin Schwidefsky Cc: Heiko Carstens Cc: linux-s...@vger.kernel.org --- arch/s390/include/asm/ftrace.h | 11 +++ arch/s390/include/asm

[PATCH v3 00/11] syscall/tracing: compat syscall support

2016-10-11 Thread Marcin Nowakowski
86 which had extra methods to prevent incorrect syscall reporting for compat tasks - this may happen after patch 2 is applied and without x86/tracing patch. version 3: - rebase on top of linux-next-20161011 - tile: change in_compat_syscall to is_compat_task (suggested and signed-off by Chri

[PATCH v3 01/11] tracing/syscalls: remove syscall_nr from syscall metadata

2016-10-11 Thread Marcin Nowakowski
syscall lookup together with the syscall metadata table traversal to register for appropriate events instead. This slightly increases the overhead during event (un)registration, but does not impact the trace events themselves, which still use syscall numbers directly. Signed-off-by: Marcin Nowakowski

[PATCH v3 05/11] x86/tracing: fix compat syscall handling

2016-10-11 Thread Marcin Nowakowski
bit from syscall numbers. Signed-off-by: Marcin Nowakowski Cc: Steven Rostedt Cc: Ingo Molnar Cc: Thomas Gleixner Cc: "H. Peter Anvin" Cc: x...@kernel.org --- arch/x86/include/asm/ftrace.h | 14 ++ arch/x86/include/asm/syscall.h | 9 + arch/x86/kernel/ftrace.c

[PATCH v3 04/11] syscall/tracing: allow arch to override syscall_get_nr for ftrace

2016-10-11 Thread Marcin Nowakowski
umber from the regs provided. This will be used by x86 in a follow-up change. Signed-off-by: Marcin Nowakowski Cc: Steven Rostedt Cc: Ingo Molnar --- kernel/trace/trace_syscalls.c | 4 1 file changed, 4 insertions(+) diff --git a/kernel/trace/trace_syscalls.c b/kernel/trace/trace_syscal

[PATCH v3 03/11] tracing/syscalls: add compat syscall metadata

2016-10-11 Thread Marcin Nowakowski
Now that compat syscalls are properly distinguished from native calls, we can add metadata for compat syscalls as well. All the macros used to generate the metadata are the same as for standard syscalls, but with a compat_ prefix to distinguish them easily. Signed-off-by: Marcin Nowakowski Cc

[PATCH v3 11/11] parisc/tracing: fix compat syscall handling

2016-10-11 Thread Marcin Nowakowski
Add missing arch code - arch_trace_is_compat_syscall and arch_syscall_addr Signed-off-by: Marcin Nowakowski Cc: Steven Rostedt Cc: Ingo Molnar Cc: "James E.J. Bottomley" Cc: Helge Deller Cc: linux-par...@vger.kernel.org --- arch/parisc/include/asm/ftrace.h | 10 ++ a

[PATCH v3 09/11] tile/tracing: fix compat syscall handling

2016-10-11 Thread Marcin Nowakowski
Add missing arch code - arch_trace_is_compat_syscall and arch_syscall_addr Signed-off-by: Marcin Nowakowski Cc: Steven Rostedt Cc: Ingo Molnar Signed-off-by: Chris Metcalf --- arch/tile/include/asm/ftrace.h | 10 ++ arch/tile/kernel/Makefile | 1 + arch/tile/kernel/ftrace.c

[PATCH v3 07/11] arm64/tracing: fix compat syscall handling

2016-10-11 Thread Marcin Nowakowski
Add arch_syscall_addr for arm64 and define NR_compat_syscalls, as the number of compat syscalls for arm64 exceeds the number defined by NR_syscalls. Signed-off-by: Marcin Nowakowski Cc: Steven Rostedt Cc: Ingo Molnar Cc: Catalin Marinas Cc: Will Deacon Cc: linux-arm-ker

Re: [PATCH 2/2] MIPS: set NR_syscall_tables appropriately

2016-09-28 Thread Marcin Nowakowski
On 27.09.2016 14:04, Ralf Baechle wrote: On Mon, Aug 29, 2016 at 11:30:07AM +0200, Marcin Nowakowski wrote: Depending on the kernel configuration, up to 3 syscall tables can be used in parallel - so set the number properly to ensure syscall tracing is set up properly. Signed-off-by: Marcin

[PATCH v2 07/11] arm64/tracing: fix compat syscall handling

2016-09-16 Thread Marcin Nowakowski
Add arch_syscall_addr for arm64 and define NR_compat_syscalls, as the number of compat syscalls for arm64 exceeds the number defined by NR_syscalls. Signed-off-by: Marcin Nowakowski Cc: Steven Rostedt Cc: Ingo Molnar Cc: Catalin Marinas Cc: Will Deacon Cc: linux-arm-ker

[PATCH v2 08/11] powerpc/tracing: fix compat syscall handling

2016-09-16 Thread Marcin Nowakowski
Adapt the code to make use of new syscall handling interface Signed-off-by: Marcin Nowakowski Cc: Steven Rostedt Cc: Ingo Molnar Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Michael Ellerman Cc: linuxppc-...@lists.ozlabs.org --- arch/powerpc/include/asm/ftrace.h | 11 +++ arch

[PATCH v2 10/11] sparc/tracing: fix compat syscall handling

2016-09-16 Thread Marcin Nowakowski
Add missing arch code - arch_trace_is_compat_syscall and arch_syscall_addr Signed-off-by: Marcin Nowakowski Cc: Steven Rostedt Cc: Ingo Molnar Cc: "David S. Miller" Cc: sparcli...@vger.kernel.org --- arch/sparc/include/asm/ftrace.h | 10 ++ arch/sparc/kernel/Makefile

[PATCH v2 09/11] tile/tracing: fix compat syscall handling

2016-09-16 Thread Marcin Nowakowski
Add missing arch code - arch_trace_is_compat_syscall and arch_syscall_addr Signed-off-by: Marcin Nowakowski Cc:Cc: Steven Rostedt Cc: Ingo Molnar Cc: Chris Metcalf --- arch/tile/include/asm/ftrace.h | 10 ++ arch/tile/kernel/Makefile | 1 + arch/tile/kernel/ftrace.c | 13

[PATCH v2 05/11] x86/tracing: fix compat syscall handling

2016-09-16 Thread Marcin Nowakowski
bit from syscall numbers. Signed-off-by: Marcin Nowakowski Cc: Steven Rostedt Cc: Ingo Molnar Cc: Thomas Gleixner Cc: "H. Peter Anvin" Cc: x...@kernel.org --- arch/x86/include/asm/ftrace.h | 14 ++ arch/x86/include/asm/syscall.h | 9 + arch/x86/kernel/ftrace.c

[PATCH v2 11/11] parisc/tracing: fix compat syscall handling

2016-09-16 Thread Marcin Nowakowski
Add missing arch code - arch_trace_is_compat_syscall and arch_syscall_addr Signed-off-by: Marcin Nowakowski Cc: Steven Rostedt Cc: Ingo Molnar Cc: "James E.J. Bottomley" Cc: Helge Deller Cc: linux-par...@vger.kernel.org --- arch/parisc/include/asm/ftrace.h | 10 ++ a

[PATCH v2 03/11] tracing/syscalls: add compat syscall metadata

2016-09-16 Thread Marcin Nowakowski
Now that compat syscalls are properly distinguished from native calls, we can add metadata for compat syscalls as well. All the macros used to generate the metadata are the same as for standard syscalls, but with a compat_ prefix to distinguish them easily. Signed-off-by: Marcin Nowakowski Cc

[PATCH v2 06/11] s390/tracing: fix compat syscall handling

2016-09-16 Thread Marcin Nowakowski
Add missing arch code - arch_trace_is_compat_syscall and arch_syscall_addr Signed-off-by: Marcin Nowakowski Cc: Steven Rostedt Cc: Ingo Molnar Cc: Martin Schwidefsky Cc: Heiko Carstens Cc: linux-s...@vger.kernel.org --- arch/s390/include/asm/ftrace.h | 11 +++ arch/s390/include/asm

[PATCH v2 04/11] syscall/tracing: allow arch to override syscall_get_nr for ftrace

2016-09-16 Thread Marcin Nowakowski
umber from the regs provided. This will be used by x86 in a follow-up change. Signed-off-by: Marcin Nowakowski Cc: Steven Rostedt Cc: Ingo Molnar --- kernel/trace/trace_syscalls.c | 4 1 file changed, 4 insertions(+) diff --git a/kernel/trace/trace_syscalls.c b/kernel/trace/trace_syscal

[PATCH v2 02/11] tracing/syscalls: add handling for compat tasks

2016-09-16 Thread Marcin Nowakowski
s. Signed-off-by: Marcin Nowakowski Cc: Steven Rostedt Cc: Ingo Molnar --- arch/mips/kernel/ftrace.c | 4 +- arch/powerpc/kernel/ftrace.c | 2 +- include/linux/ftrace.h| 2 +- kernel/trace/trace.h | 17 +- kernel/trace/trace_syscal

[PATCH v2 01/11] tracing/syscalls: remove syscall_nr from syscall metadata

2016-09-16 Thread Marcin Nowakowski
syscall lookup together with the syscall metadata table traversal to register for appropriate events instead. This slightly increases the overhead during event (un)registration, but does not impact the trace events themselves, which still use syscall numbers directly. Signed-off-by: Marcin Nowakowski

[PATCH v2 00/11] syscall/tracing: compat syscall support

2016-09-16 Thread Marcin Nowakowski
ections - and most things work as previously until arch-specific patch is applied. The only exception here is x86 which had extra methods to prevent incorrect syscall reporting for compat tasks - this may happen after patch 2 is applied and without x86/tracing patch. Marcin Nowakowski (11): tra

Re: [RFC PATCH 2/3] tracing/syscalls: add handling for compat tasks

2016-09-12 Thread Marcin Nowakowski
Hi Andy, Thanks for your review and the comments, I'll address them in a next iteration. Do you have any other comments on the complete patchset? On 12.09.2016 19:35, Andy Lutomirski wrote: On Sep 9, 2016 1:04 AM, "Marcin Nowakowski" wrote: Extend the syscall tracing subsys

[RFC PATCH 1/3] tracing/syscalls: remove syscall_nr from syscall metadata

2016-09-09 Thread Marcin Nowakowski
ut a major change in how syscall tables and numbers are defined for each arch. Signed-off-by: Marcin Nowakowski --- include/linux/syscalls.h | 1 - include/trace/syscall.h | 2 - kernel/trace/trace_syscalls.c | 150 -- 3 files changed, 100

[RFC PATCH 3/3] tracing/syscalls: add compat syscall metadata

2016-09-09 Thread Marcin Nowakowski
Now that compat syscalls are properly distinguished from native calls, we can add metadata for compat syscalls as well. All the macros used to generate the metadata are the same as for standard syscalls, but with a compat_ prefix to distinguish them easily. Signed-off-by: Marcin Nowakowski

[RFC PATCH 2/3] tracing/syscalls: add handling for compat tasks

2016-09-09 Thread Marcin Nowakowski
ution is reviewed. Signed-off-by: Marcin Nowakowski --- arch/mips/kernel/ftrace.c | 4 +- arch/x86/include/asm/ftrace.h | 10 +--- arch/x86/kernel/ftrace.c | 14 ++ include/linux/ftrace.h| 2 +- kernel/trace/trace.h | 11 +++- kernel/trace/trace_syscalls.c

[RFC PATCH 0/3] syscall/tracing: compat syscall support

2016-09-09 Thread Marcin Nowakowski
ece of information here ... hence this change is sent as an RFC so that I can get valuable feedback on the proposed solution. Finally the last patch adds the missing compat syscall metadata. Marcin Nowakowski (3): tracing/syscalls: remove syscall_nr from syscall metadata tracing/syscalls

Re: [PATCH] uprobes: remove function declarations from arch/{mips,s390}

2016-09-08 Thread Marcin Nowakowski
Hi Andrew, On 03.09.2016 12:59, Heiko Carstens wrote: Signed-off-by: Marcin Nowakowski --- arch/mips/include/asm/uprobes.h | 12 arch/s390/include/asm/uprobes.h | 10 -- 2 files changed, 22 deletions(-) You may either split this patch into two patches (mips/s390) so

[PATCH] uprobes: remove function declarations from arch/{mips,s390}

2016-09-02 Thread Marcin Nowakowski
The declarations of arch-specific functions have been moved to a common header in commit 3820b4d2789f ('uprobes: Move function declarations out of arch'), but MIPS and S390 has added them to their own trees later. Remove the unnecessary duplicates. Signed-off-by: Marcin Nowakowski ---

  1   2   >