Re: Thread scheduler misbehaviour OR Oprofile bug?

2015-01-16 Thread Zoltan Kiss
On 16/01/15 19:37, William Cohen wrote: On 01/16/2015 01:29 PM, Zoltan Kiss wrote: On 16/01/15 15:38, William Cohen wrote: On 01/16/2015 09:01 AM, Zoltan Kiss wrote: Hi, I'm using OProfile to check some suspicious behaviour of dpdk-pktgen, and I can see something which troubl

Re: Thread scheduler misbehaviour OR Oprofile bug?

2015-01-16 Thread Zoltan Kiss
at the wrong place as well. Regards, Zoltan On 16/01/15 15:38, William Cohen wrote: On 01/16/2015 09:01 AM, Zoltan Kiss wrote: Hi, I'm using OProfile to check some suspicious behaviour of dpdk-pktgen, and I can see something which troubles me. Either the scheduler lies about core affini

Re: Thread scheduler misbehaviour OR Oprofile bug?

2015-01-16 Thread Zoltan Kiss
On 16/01/15 15:38, William Cohen wrote: On 01/16/2015 09:01 AM, Zoltan Kiss wrote: Hi, I'm using OProfile to check some suspicious behaviour of dpdk-pktgen, and I can see something which troubles me. Either the scheduler lies about core affinity or Oprofile accounts some samples wr

Re: Thread scheduler misbehaviour OR Oprofile bug?

2015-01-16 Thread Zoltan Kiss
Hi, On 16/01/15 15:38, William Cohen wrote: On 01/16/2015 09:01 AM, Zoltan Kiss wrote: Hi, I'm using OProfile to check some suspicious behaviour of dpdk-pktgen, and I can see something which troubles me. Either the scheduler lies about core affinity or Oprofile accounts some samples wr

Thread scheduler misbehaviour OR Oprofile bug?

2015-01-16 Thread Zoltan Kiss
Hi, I'm using OProfile to check some suspicious behaviour of dpdk-pktgen, and I can see something which troubles me. Either the scheduler lies about core affinity or Oprofile accounts some samples wrongly. This userspace app runs in threads, which are assigned explicitly to one single core wit

Re: [Xen-devel] [PATCH] xen-netfront: Fix handling packets on compound pages with skb_linearize

2014-12-01 Thread Zoltan Kiss
On 01/12/14 13:36, David Vrabel wrote: On 01/12/14 08:55, Stefan Bader wrote: On 11.08.2014 19:32, Zoltan Kiss wrote: There is a long known problem with the netfront/netback interface: if the guest tries to send a packet which constitues more than MAX_SKB_FRAGS + 1 ring slots, it gets

Re: [Xen-devel] BUG in xennet_make_frags with paged skb data

2014-11-10 Thread Zoltan Kiss
On 10/11/14 14:41, David Vrabel wrote: On 10/11/14 14:35, Seth Forshee wrote: On Fri, Nov 07, 2014 at 10:44:15AM +, David Vrabel wrote: On 06/11/14 21:49, Seth Forshee wrote: We've had several reports of hitting the following BUG_ON in xennet_make_frags with 3.2 and 3.13 kernels (I'm cur

Re: [Xen-devel] BUG in xennet_make_frags with paged skb data

2014-11-07 Thread Zoltan Kiss
Hi, On 07/11/14 11:08, Stefan Bader wrote: On 07.11.2014 11:44, David Vrabel wrote: On 06/11/14 21:49, Seth Forshee wrote: We've had several reports of hitting the following BUG_ON in xennet_make_frags with 3.2 and 3.13 kernels (I'm currently awaiting results of testing with 3.17): /

Re: [Xen-devel] BUG in xennet_make_frags with paged skb data

2014-11-07 Thread Zoltan Kiss
On 07/11/14 12:15, Stefan Bader wrote: On 07.11.2014 12:22, Eric Dumazet wrote: On Fri, 2014-11-07 at 09:25 +, Zoltan Kiss wrote: Please do not top post. Hi, AFAIK in this scenario your skb frag is wrong. The page pointer should point to the original compound page (not a member of it

Re: [Xen-devel] BUG in xennet_make_frags with paged skb data

2014-11-07 Thread Zoltan Kiss
Hi, AFAIK in this scenario your skb frag is wrong. The page pointer should point to the original compound page (not a member of it), and offset should be set accordingly. For example, if your compound page is 16K (4 page), then the page pointer should point to the first page, and if the data s

[PATCH] xen-netfront: Fix handling packets on compound pages with skb_linearize

2014-08-11 Thread Zoltan Kiss
, and it can fail much easier as it tries to allocate a big linear area for the whole packet, but probably easier by an order of magnitude than anything else. Probably this code path is not touched very frequently anyway. Signed-off-by: Zoltan Kiss Cc: Wei Liu Cc: Ian Campbell Cc: Paul Durrant Cc

Re: [Xen-devel] [PATCH] xen-netback: Turn off the carrier if the guest is not able to receive

2014-08-11 Thread Zoltan Kiss
On 08/08/14 17:33, Stephen Hemminger wrote: This idea of bouncing carrier is wrong. If guest is flow blocked you don't want to toggle carrier. That will cause problems because applications that are looking for carrier transistions like routing daemons will be notified. If running a routing daemo

[PATCH net-next v2] xen-netback: Don't deschedule NAPI when carrier off

2014-08-11 Thread Zoltan Kiss
In the patch called "xen-netback: Turn off the carrier if the guest is not able to receive" NAPI was descheduled when the carrier was set off. That's not what most of the drivers do, and we don't have any specific reason to do so as well, so revert that change. Signed-off-by:

[PATCH net-next] xen-netback: Don't deschedule NAPI when carrier off

2014-08-08 Thread Zoltan Kiss
In the patch called "xen-netback: Turn off the carrier if the guest is not able to receive" NAPI was descheduled when the carrier was set off. That's not what most of the drivers do, and we don't have any specific reason to do so as well, so revert that change. Signed-off-by:

Re: [PATCH net-next 0/2] xen-netback: Changes around carrier handling

2014-08-07 Thread Zoltan Kiss
On 06/08/14 00:07, David Miller wrote: From: Zoltan Kiss Date: Mon, 4 Aug 2014 16:20:56 +0100 This series starts using carrier off as a way to purge packets when the guest is not able (or willing) to receive them. It is a much faster way to get rid of packets waiting for an overwhelmed guest

Re: [PATCH net-next 0/2] xen-netback: Changes around carrier handling

2014-08-07 Thread Zoltan Kiss
On 06/08/14 22:01, David Miller wrote: From: Zoltan Kiss Date: Wed, 6 Aug 2014 20:20:55 +0100 The fundamental problem with netback that start_xmit place the packet into an internal queue, and then the thread does the actual transmission from that queue, but it doesn't know whether it

[PATCH net-next v2] xen-netback: Fix vif->disable handling

2014-08-07 Thread Zoltan Kiss
In the patch called "xen-netback: Turn off the carrier if the guest is not able to receive" new branches were introduced to this if statement, risking that a queue with non-zero id can reenable the disabled interface. Signed-off-by: Zoltan Kiss Signed-off-by: David Vrabe

Re: [PATCH] xen-netback: Change disable flag from bool to a bit

2014-08-07 Thread Zoltan Kiss
On 06/08/14 22:07, David Miller wrote: From: Zoltan Kiss Date: Wed, 6 Aug 2014 19:16:13 +0100 Signed-off-by: Zoltan Kiss Signed-off-by: David Vrabel Neither this nor your "Small fixes around internal queue purging" patch apply cleanly to my current tree. I have no idea what tr

[PATCH net-next] xen-netback: Fix vif->disable handling

2014-08-06 Thread Zoltan Kiss
In the patch called "xen-netback: Turn off the carrier if the guest is not able to receive" new branches were introduced to this if statement, risking that a queue with non-zero id can reenable the disabled interface. Signed-off-by: Zoltan Kiss Signed-off-by: David Vrabe

Re: [PATCH net-next 0/2] xen-netback: Changes around carrier handling

2014-08-06 Thread Zoltan Kiss
On 06/08/14 00:07, David Miller wrote: From: Zoltan Kiss Date: Mon, 4 Aug 2014 16:20:56 +0100 This series starts using carrier off as a way to purge packets when the guest is not able (or willing) to receive them. It is a much faster way to get rid of packets waiting for an overwhelmed guest

Re: [PATCH net-next 2/2] xen-netback: Turn off the carrier if the guest is not able to receive

2014-08-06 Thread Zoltan Kiss
On 05/08/14 13:45, Wei Liu wrote: On Mon, Aug 04, 2014 at 04:20:58PM +0100, Zoltan Kiss wrote: [...] struct xenvif { diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-netback/interface.c index fbdadb3..48a55cd 100644 --- a/drivers/net/xen-netback/interface.c +++ b/drivers

Re: [PATCH net-next 0/2 v2] xen-netback: Changes around carrier handling

2014-08-06 Thread Zoltan Kiss
Ignore this series, I've pushed the wrong button. Apologies. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.or

Re: [PATCH net-next 1/2] xen-netback: Using a new state bit instead of carrier

2014-08-06 Thread Zoltan Kiss
On 05/08/14 13:45, Wei Liu wrote: On Mon, Aug 04, 2014 at 04:20:57PM +0100, Zoltan Kiss wrote: This patch introduces a new state bit VIF_STATUS_CONNECTED to track whether the vif is in a connected state. Using carrier will not work with the next patch in this series, which aims to turn the

[PATCH net-next 2/2 v2] xen-netback: Turn off the carrier if the guest is not able to receive

2014-08-06 Thread Zoltan Kiss
thread can check what it should do. It also disables NAPI, so the guest can't transmit, but leaves the interrupts on, so it can resurrect. Only the queues which brought down the interface can enable it again, the bit QUEUE_STATUS_RX_STALLED makes sure of that. Signed-off-by: Zoltan Kiss Signe

[PATCH net-next 1/2 v2] xen-netback: Using a new state bit instead of carrier

2014-08-06 Thread Zoltan Kiss
ff-by: Zoltan Kiss Signed-off-by: David Vrabel Cc: net...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: xen-de...@lists.xenproject.org --- v2: - rename the bitshift type to "enum state_bit_shift" here, not in the next patch diff --git a/drivers/net/xen-netback/common.h b/drivers/

[PATCH net-next 1/4 v5] pktgen: Fill the payload optionally with a pattern

2014-08-06 Thread Zoltan Kiss
numbers divided by space. The value of the number is the size of the preceding payload area. E.g. "1 3 5 "..." 1000 1005 1010" If the pattern is used, every frag will have its own page, unlike before, so it needs more memory. [1] 5837574: xen-netback: Fix grant ref resolution in

[PATCH] xen-netback: Change disable flag from bool to a bit

2014-08-06 Thread Zoltan Kiss
Signed-off-by: Zoltan Kiss Signed-off-by: David Vrabel Cc: net...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: xen-de...@lists.xenproject.org diff --git a/drivers/net/xen-netback/common.h b/drivers/net/xen-netback/common.h index 5cb139a..f126920 100644 --- a/drivers/net/xen-netback

[PATCH net-next 0/4 v5] pktgen: Upstreaming features useful for xen-netback/front testing

2014-08-06 Thread Zoltan Kiss
number differs 2/4: fine-grained buffer geometrics 3/4: fix UDP checksuming 4/4: sending TCP GSO packets. This is an RFC yet, as I'm not certain about all things changed here Signed-off-by: Zoltan Kiss Cc: "David S. Miller" Cc: Thomas Graf Cc: Joe Perches Cc: net...@vger.kerne

[PATCH net-next 2/4 v5] pktgen: Allow setting frag sizes individually

2014-08-06 Thread Zoltan Kiss
handle 4k pages. This extension of pktgen is proven to be useful to test that. Signed-off-by: Zoltan Kiss Cc: "David S. Miller" Cc: Thomas Graf Cc: Joe Perches Cc: net...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: xen-de...@lists.xenproject.org --- v2: allocate new compound

[PATCH net-next 4/4 v5] pktgen: Allow sending IPv4 TCP packets

2014-08-06 Thread Zoltan Kiss
This is a prototype patch to enable sending IPv4 TCP packets with pktgen. The original motivation is to test TCP GSO with xen-netback/netfront, but I'm not sure about how the checksum should be set up, and also someone should verify the GSO settings I'm using. Signed-off-by: Zolta

[PATCH net-next 0/2 v2] xen-netback: Changes around carrier handling

2014-08-06 Thread Zoltan Kiss
second turns off the carrier if the guest times out on a queue, and only turn it on again if that queue (or queues) resurrects. Signed-off-by: Zoltan Kiss Signed-off-by: David Vrabel Cc: net...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: xen-de...@lists.xenproject.org -- To unsubscribe

[PATCH net-next 3/4 v5] pktgen: Fixing UPD checksum calculation

2014-08-06 Thread Zoltan Kiss
It passes port number instead of IP address for checksuming. The udp4_hwcsum() call is also bad, but my next patch will get rid of it anyway. The IPv6 code does it correctly already. It also changes replaces 8 with sizeof(struct udphdr) Signed-off-by: Zoltan Kiss Cc: "David S. Miller

[PATCH] xen-netback: Small fixes around internal queue purging

2014-08-06 Thread Zoltan Kiss
This patch adds an extra internal queue purging for xenvif_carrier_off. It makes sense to do this when the carrier is switched off. Also, it uses the proper helper instead of a while loop to the purging at another place. Signed-off-by: Zoltan Kiss Signed-off-by: David Vrabel Cc: net

Re: [PATCH net-next v4 4/4 RFC] pktgen: Allow sending IPv4 TCP packets

2014-08-06 Thread Zoltan Kiss
On 05/08/14 21:09, David Miller wrote: From: Zoltan Kiss Date: Mon, 4 Aug 2014 14:37:14 +0100 @@ -3559,6 +3616,14 @@ static void pktgen_xmit(struct pktgen_dev *pkt_dev) pkt_dev->last_pkt_size = pkt_dev->skb->len; pkt_dev->al

Re: [PATCH] xen-netfront: Fix handling packets on compound pages with skb_segment

2014-08-05 Thread Zoltan Kiss
On 04/08/14 23:24, David Miller wrote: From: Wei Liu Date: Sun, 3 Aug 2014 10:11:10 +0100 On Sat, Aug 02, 2014 at 03:33:37PM -0700, David Miller wrote: From: Wei Liu Date: Fri, 1 Aug 2014 12:02:46 +0100 On Thu, Jul 31, 2014 at 01:25:20PM -0700, David Miller wrote: If you were to have a 64

Re: [PATCH] xen-netfront: Fix handling packets on compound pages with skb_segment

2014-08-04 Thread Zoltan Kiss
On 31/07/14 21:25, David Miller wrote: From: Zoltan Kiss Date: Wed, 30 Jul 2014 14:25:30 +0100 There is a long known problem with the netfront/netback interface: if the guest tries to send a packet which constitues more than MAX_SKB_FRAGS + 1 ring slots, it gets dropped. The reason is that

Re: [PATCH net-next 0/2] xen-netback: Changes around carrier handling

2014-08-04 Thread Zoltan Kiss
On 04/08/14 16:20, Zoltan Kiss wrote: This series starts using carrier off as a way to purge packets when the guest is not able (or willing) to receive them. It is a much faster way to get rid of packets waiting for an overwhelmed guest. The first patch changes current netback code where it

[PATCH net-next 1/2] xen-netback: Using a new state bit instead of carrier

2014-08-04 Thread Zoltan Kiss
ff-by: Zoltan Kiss Signed-off-by: David Vrabel Cc: net...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: xen-de...@lists.xenproject.org v2: - rename the bitshift type to "enum state_bit_shift" here, not in the next patch diff --git a/drivers/net/xen-netback/common.h b/drivers/net/xen-n

[PATCH net-next 2/2] xen-netback: Turn off the carrier if the guest is not able to receive

2014-08-04 Thread Zoltan Kiss
thread can check what it should do. It also disables NAPI, so the guest can't transmit, but leaves the interrupts on, so it can resurrect. Only the queues which brought down the interface can enable it again, the bit QUEUE_STATUS_RX_STALLED makes sure of that. Signed-off-by: Zoltan Kiss Signe

[PATCH net-next 0/2] xen-netback: Changes around carrier handling

2014-08-04 Thread Zoltan Kiss
second turns off the carrier if the guest times out on a queue, and only turn it on again if that queue (or queues) resurrects. Signed-off-by: Zoltan Kiss Signed-off-by: David Vrabel Cc: net...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: xen-de...@lists.xenproject.org -- To unsubscribe

Re: [Xen-devel] [PATCH] xen-netback: Turn off the carrier if the guest is not able to receive

2014-08-04 Thread Zoltan Kiss
On 04/08/14 14:35, David Vrabel wrote: On 30/07/14 20:50, Zoltan Kiss wrote: Currently when the guest is not able to receive more packets, qdisc layer starts a timer, and when it goes off, qdisc is started again to deliver a packet again. This is a very slow way to drain the queues, consumes

Re: [PATCH] xen-netback: Turn off the carrier if the guest is not able to receive

2014-08-04 Thread Zoltan Kiss
On 01/08/14 11:52, Wei Liu wrote: On Wed, Jul 30, 2014 at 08:50:49PM +0100, Zoltan Kiss wrote: --- a/drivers/net/xen-netback/common.h +++ b/drivers/net/xen-netback/common.h @@ -176,9 +176,9 @@ struct xenvif_queue { /* Per-queue data for xenvif */ struct xen_netif_rx_back_ring rx

[PATCH net-next v3 2/4] pktgen: Allow setting frag sizes individually

2014-08-04 Thread Zoltan Kiss
handle 4k pages. This extension of pktgen is proven to be useful to test that. Signed-off-by: Zoltan Kiss Cc: "David S. Miller" Cc: Thomas Graf Cc: Joe Perches Cc: net...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: xen-de...@lists.xenproject.org --- v2: allocate new compound

[PATCH net-next 1/4 v5] pktgen: Fill the payload optionally with a pattern

2014-08-04 Thread Zoltan Kiss
numbers divided by space. The value of the number is the size of the preceding payload area. E.g. "1 3 5 "..." 1000 1005 1010" If the pattern is used, every frag will have its own page, unlike before, so it needs more memory. [1] 5837574: xen-netback: Fix grant ref resolution in

[PATCH net-next v4 0/3] pktgen: Upstreaming features useful for xen-netback/front testing

2014-08-04 Thread Zoltan Kiss
number differs 2/4: fine-grained buffer geometrics 3/4: fix UDP checksuming 4/4: sending TCP GSO packets. This is an RFC yet, as I'm not certain about all things changed here Signed-off-by: Zoltan Kiss Cc: "David S. Miller" Cc: Thomas Graf Cc: Joe Perches Cc: net...@vger.kerne

[PATCH net-next 3/4 RFC] pktgen: Fixing UPD checksum calculation

2014-08-04 Thread Zoltan Kiss
It passes port number instead of IP address for checksuming. The udp4_hwcsum() call is also bad, but my next patch will get rid of it anyway. The IPv6 code does it correctly already. It also changes replaces 8 with sizeof(struct udphdr) Signed-off-by: Zoltan Kiss Cc: "David S. Miller

[PATCH net-next v4 4/4 RFC] pktgen: Allow sending IPv4 TCP packets

2014-08-04 Thread Zoltan Kiss
This is a prototype patch to enable sending IPv4 TCP packets with pktgen. The original motivation is to test TCP GSO with xen-netback/netfront, but I'm not sure about how the checksum should be set up, and also someone should verify the GSO settings I'm using. Signed-off-by: Zolta

Re: [PATCH net-next v3 4/4 RFC] pktgen: Allow sending IPv4 TCP packets

2014-08-04 Thread Zoltan Kiss
On 01/08/14 05:32, David Miller wrote: From: Zoltan Kiss @@ -3017,29 +3029,40 @@ static struct sk_buff *fill_packet_ipv4(struct net_device *odev, iph = (struct iphdr *) skb_put(skb, sizeof(struct iphdr)); skb_set_transport_header(skb, skb->len); - udph = (struct udp

[PATCH] xen-netback: Turn off the carrier if the guest is not able to receive

2014-07-30 Thread Zoltan Kiss
thread can check what it should do. It also disables NAPI, so the guest can't transmit, but leaves the interrupts on, so it can resurrect. Signed-off-by: Zoltan Kiss Signed-off-by: David Vrabel Cc: net...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: xen-de...@lists.xenproject.org

[PATCH] xen-netback: Using a new state bit instead of carrier

2014-07-30 Thread Zoltan Kiss
ff-by: Zoltan Kiss Signed-off-by: David Vrabel Cc: net...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: xen-de...@lists.xenproject.org diff --git a/drivers/net/xen-netback/common.h b/drivers/net/xen-netback/common.h index 28c9822..7231359 100644 --- a/drivers/net/xen-netback/common.h +++ b/driver

[PATCH net-next 3/4 RFC] pktgen: Fixing UPD checksum calculation

2014-07-30 Thread Zoltan Kiss
It passes port number instead of IP address for checksuming. The udp4_hwcsum() call is also bad, but my next patch will get rid of it anyway. The IPv6 code does it correctly already. It also changes replaces 8 with sizeof(struct udphdr) Signed-off-by: Zoltan Kiss Cc: "David S. Miller

[PATCH net-next v3 4/4 RFC] pktgen: Allow sending IPv4 TCP packets

2014-07-30 Thread Zoltan Kiss
This is a prototype patch to enable sending IPv4 TCP packets with pktgen. The original motivation is to test TCP GSO with xen-netback/netfront, but I'm not sure about how the checksum should be set up, and also someone should verify the GSO settings I'm using. Signed-off-by: Zolta

[PATCH net-next v3 0/3] pktgen: Upstreaming features useful for xen-netback/front testing

2014-07-30 Thread Zoltan Kiss
number differs 2/4: fine-grained buffer geometrics 3/4: fix UDP checksuming 4/4: sending TCP GSO packets. This is an RFC yet, as I'm not certain about all things changed here Signed-off-by: Zoltan Kiss Cc: "David S. Miller" Cc: Thomas Graf Cc: Joe Perches Cc: net...@vger.kerne

[PATCH net-next 1/4 v5] pktgen: Fill the payload optionally with a pattern

2014-07-30 Thread Zoltan Kiss
numbers divided by space. The value of the number is the size of the preceding payload area. E.g. "1 3 5 "..." 1000 1005 1010" If the pattern is used, every frag will have its own page, unlike before, so it needs more memory. [1] 5837574: xen-netback: Fix grant ref resolution in

[PATCH net-next v3 2/4] pktgen: Allow setting frag sizes individually

2014-07-30 Thread Zoltan Kiss
handle 4k pages. This extension of pktgen is proven to be useful to test that. Signed-off-by: Zoltan Kiss Cc: "David S. Miller" Cc: Thomas Graf Cc: Joe Perches Cc: net...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: xen-de...@lists.xenproject.org --- v2: allocate new compound

[PATCH] xen-netfront: Fix handling packets on compound pages with skb_segment

2014-07-30 Thread Zoltan Kiss
gment, and calling xennet_start_xmit again on the resulting packets. It also works with the theoretical worst case, where there is a 3 level recursion. The good thing is that skb_segment only copies the header part, the frags will be just referenced again. Signed-off-by: Zoltan Kiss Cc: Wei Liu Cc

[PATCH for stable 3.15 1/4 v2] xen-netback: Fix handling frag_list on grant op error path

2014-07-21 Thread Zoltan Kiss
The error handling for skb's with frag_list was completely wrong, it caused double unmap attempts to happen if the error was on the first skb. Move it to the right place in the loop. Signed-off-by: Zoltan Kiss Reported-by: Armin Zentai Cc: net...@vger.kernel.org Cc: linux-kernel@vger.kerne

[PATCH for stable 3.15 2/4 v2] xen-netback: Fix releasing frag_list skbs in error path

2014-07-21 Thread Zoltan Kiss
at that time. Signed-off-by: Zoltan Kiss Reported-by: Armin Zentai Cc: net...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: xen-de...@lists.xenproject.org --- v2: adding comment diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c index 9b0f482..75b7d1a

[PATCH for stable 3.15 4/4 v2] xen-netback: Fix pointer incrementation to avoid incorrect logging

2014-07-21 Thread Zoltan Kiss
Due to this pointer is increased prematurely, the error log contains rubbish. Signed-off-by: Zoltan Kiss Reported-by: Armin Zentai Cc: net...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: xen-de...@lists.xenproject.org diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen

[PATCH for stable 3.15 3/4 v2] xen-netback: Fix releasing header slot on error path

2014-07-21 Thread Zoltan Kiss
removed from xenvif_idx_unmap, and called separately. Signed-off-by: Zoltan Kiss Reported-by: Armin Zentai Cc: net...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: xen-de...@lists.xenproject.org --- v2: remove stray blank line diff --git a/drivers/net/xen-netback/netback.c b/drivers/net

[PATCH net 2/4 v2] xen-netback: Fix releasing frag_list skbs in error path

2014-07-18 Thread Zoltan Kiss
at that time. Signed-off-by: Zoltan Kiss Reported-by: Armin Zentai Cc: net...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: xen-de...@lists.xenproject.org --- v2: adding comment diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c index a773f20..8cbf60d

[PATCH net 4/4 v2] xen-netback: Fix pointer incrementation to avoid incorrect logging

2014-07-18 Thread Zoltan Kiss
Due to this pointer is increased prematurely, the error log contains rubbish. Signed-off-by: Zoltan Kiss Reported-by: Armin Zentai Cc: net...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: xen-de...@lists.xenproject.org --- diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen

[PATCH net 0/4 v2] xen-netback: Fixing up xenvif_tx_check_gop

2014-07-18 Thread Zoltan Kiss
oblem was first discovered there. The only difference is that the "queue" variable name is replaced to "vif". Signed-off-by: Zoltan Kiss Reported-by: Armin Zentai Cc: net...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: xen-de...@lists.xenproject.org -- To unsubscribe

[PATCH net 3/4 v2] xen-netback: Fix releasing header slot on error path

2014-07-18 Thread Zoltan Kiss
removed from xenvif_idx_unmap, and called separately. Signed-off-by: Zoltan Kiss Reported-by: Armin Zentai Cc: net...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: xen-de...@lists.xenproject.org --- v2: remove stray blank line diff --git a/drivers/net/xen-netback/netback.c b/drivers/net

[PATCH net 1/4 v2] xen-netback: Fix handling frag_list on grant op error path

2014-07-18 Thread Zoltan Kiss
The error handling for skb's with frag_list was completely wrong, it caused double unmap attempts to happen if the error was on the first skb. Move it to the right place in the loop. Signed-off-by: Zoltan Kiss Reported-by: Armin Zentai Cc: net...@vger.kernel.org Cc: linux-kernel@vger.kerne

Re: [PATCH net 3/4] xen-netback: Fix releasing header slot on error path

2014-07-18 Thread Zoltan Kiss
On 18/07/14 16:25, Wei Liu wrote: On Thu, Jul 17, 2014 at 08:09:51PM +0100, Zoltan Kiss wrote: This patch makes this function aware that the first frag and the header might share the same ring slot. That could happen if the first slot is bigger than MAX_SKB_LEN. Due to this the error path might

Re: [PATCH net 1/4] xen-netback: Fix handling frag_list on grant op error path

2014-07-18 Thread Zoltan Kiss
On 18/07/14 16:24, Wei Liu wrote: On Thu, Jul 17, 2014 at 08:09:49PM +0100, Zoltan Kiss wrote: The error handling for skb's with frag_list was completely wrong, it caused double unmap attempts to happen if the error was on the first skb. Move it to the right place in the loop. Signed-o

[PATCH for stable 3.15 2/4] xen-netback: Fix releasing frag_list skbs in error path

2014-07-17 Thread Zoltan Kiss
at that time. Signed-off-by: Zoltan Kiss Reported-by: Armin Zentai Cc: net...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: xen-de...@lists.xenproject.org diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c index 1e19001..8ca6a26 100644 --- a/drivers/net

[PATCH for stable 3.15 4/4] xen-netback: Fix pointer incrementation to avoid incorrect logging

2014-07-17 Thread Zoltan Kiss
Due to this pointer is increased prematurely, the error log contains rubbish. Signed-off-by: Zoltan Kiss Reported-by: Armin Zentai Cc: net...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: xen-de...@lists.xenproject.org diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen

[PATCH net 4/4] xen-netback: Fix pointer incrementation to avoid incorrect logging

2014-07-17 Thread Zoltan Kiss
Due to this pointer is increased prematurely, the error log contains rubbish. Signed-off-by: Zoltan Kiss Reported-by: Armin Zentai Cc: net...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: xen-de...@lists.xenproject.org --- diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen

[PATCH net 3/4] xen-netback: Fix releasing header slot on error path

2014-07-17 Thread Zoltan Kiss
removed from xenvif_idx_unmap, and called separately. Signed-off-by: Zoltan Kiss Reported-by: Armin Zentai Cc: net...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: xen-de...@lists.xenproject.org --- diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c index

[PATCH for stable 3.15 3/4] xen-netback: Fix releasing header slot on error path

2014-07-17 Thread Zoltan Kiss
removed from xenvif_idx_unmap, and called separately. Signed-off-by: Zoltan Kiss Reported-by: Armin Zentai Cc: net...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: xen-de...@lists.xenproject.org diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c index 7b3e806

[PATCH for stable 3.15 1/4] xen-netback: Fix handling frag_list on grant op error path

2014-07-17 Thread Zoltan Kiss
The error handling for skb's with frag_list was completely wrong, it caused double unmap attempts to happen if the error was on the first skb. Move it to the right place in the loop. Signed-off-by: Zoltan Kiss Reported-by: Armin Zentai Cc: net...@vger.kernel.org Cc: linux-kernel@vger.kerne

[PATCH net 1/4] xen-netback: Fix handling frag_list on grant op error path

2014-07-17 Thread Zoltan Kiss
The error handling for skb's with frag_list was completely wrong, it caused double unmap attempts to happen if the error was on the first skb. Move it to the right place in the loop. Signed-off-by: Zoltan Kiss Reported-by: Armin Zentai Cc: net...@vger.kernel.org Cc: linux-kernel@vger.kerne

[PATCH net 2/4] xen-netback: Fix releasing frag_list skbs in error path

2014-07-17 Thread Zoltan Kiss
at that time. Signed-off-by: Zoltan Kiss Reported-by: Armin Zentai Cc: net...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: xen-de...@lists.xenproject.org --- diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c index 604ff71..e9ffb05 100644 --- a/drivers

[PATCH net 0/4] xen-netback: Fixing up xenvif_tx_check_gop

2014-07-17 Thread Zoltan Kiss
oblem was first discovered there. The only difference is that the "queue" variable name is replaced to "vif". Signed-off-by: Zoltan Kiss Reported-by: Armin Zentai Cc: net...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: xen-de...@lists.xenproject.org -- To unsubscribe

"[drm:intel_dp_start_link_train] *ERROR* too many full retries, give up" and others on an ASUS UX32A

2014-07-16 Thread Zoltan Kiss
Hi, I have an ASUS UX32A laptop, which have troubles booting up with an external HDMI display. The BIOS boot screen appears on the external display, and the internal one stays blank during the whole boot. After login I can make it work again if I turn it off and on, e.g. with Ubuntu's display

checkpatch minor issue

2014-07-09 Thread Zoltan Kiss
H net-next 1/3 v4] pktgen: Fill the payload optionally with a pattern Date: Tue, 8 Jul 2014 11:28:38 -0700 From: David Miller To: CC: , , , , , , , From: Zoltan Kiss Date: Wed, 2 Jul 2014 20:54:13 +0100 @@ -1129,11 +1133,13 @@ static ssize_t pktgen_if_write(struct file *file,

Re: [PATCH net-next 1/3 v4] pktgen: Fill the payload optionally with a pattern

2014-07-09 Thread Zoltan Kiss
On 08/07/14 19:28, David Miller wrote: From: Zoltan Kiss Date: Wed, 2 Jul 2014 20:54:13 +0100 @@ -1129,11 +1133,13 @@ static ssize_t pktgen_if_write(struct file *file, i += len; if (node_possible(value)) { + int j

[PATCH net-next v4] xen-netback: Adding debugfs "io_ring_qX" files

2014-07-08 Thread Zoltan Kiss
"kick" into it imitates an interrupt happened, it can be useful to check whether the ring is just stalled due to a missed interrupt. Signed-off-by: Zoltan Kiss Cc: net...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: xen-de...@lists.xenproject.org --- v2: - use sequential f

Re: [Xen-devel] [PATCH net-next v3] xen-netback: Adding debugfs "io_ring_qX" files

2014-07-08 Thread Zoltan Kiss
On 08/07/14 18:39, Konrad Rzeszutek Wilk wrote: + return count; +} + +static int xenvif_dump_open(struct inode *inode, struct file *filp) +{ + int ret; + void *queue = NULL; + + if (inode->i_private) + queue = inode->i_private; + ret = single_open(f

[PATCH net-next v3] xen-netback: Adding debugfs "io_ring_qX" files

2014-07-08 Thread Zoltan Kiss
"kick" into it imitates an interrupt happened, it can be useful to check whether the ring is just stalled due to a missed interrupt. Signed-off-by: Zoltan Kiss Cc: net...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: xen-de...@lists.xenproject.org --- v2: - use sequential f

Re: [Xen-devel] [PATCH net-next v2] xen-netback: Adding debugfs "io_ring_qX" files

2014-07-08 Thread Zoltan Kiss
On 02/07/14 21:02, Konrad Rzeszutek Wilk wrote: On Wed, Jul 02, 2014 at 08:53:50PM +0100, Zoltan Kiss wrote: +static ssize_t +xenvif_write_io_ring(struct file *filp, const char __user *buf, size_t count, +loff_t *ppos) +{ + struct xenvif_queue *queue

[PATCH net-next 1/3 v4] pktgen: Fill the payload optionally with a pattern

2014-07-02 Thread Zoltan Kiss
numbers divided by space. The value of the number is the size of the preceding payload area. E.g. "1 3 5 "..." 1000 1005 1010" If the pattern is used, every frag will have its own page, unlike before, so it needs more memory. [1] 5837574: xen-netback: Fix grant ref resolution in

[PATCH net-next v2 2/3] pktgen: Allow setting frag sizes individually

2014-07-02 Thread Zoltan Kiss
handle 4k pages. This extension of pktgen is proven to be useful to test that. Signed-off-by: Zoltan Kiss Cc: "David S. Miller" Cc: Thomas Graf Cc: Joe Perches Cc: net...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: xen-de...@lists.xenproject.org --- v2: allocate new compound

[PATCH net-next v2 0/3] pktgen: Upstreaming features useful for xen-netback/front testing

2014-07-02 Thread Zoltan Kiss
number differs 2/3: fine-grained buffer geometrics 3/3: sending TCP GSO packets. This is an RFC yet, as I'm not certain about all things changed here Signed-off-by: Zoltan Kiss Cc: "David S. Miller" Cc: Thomas Graf Cc: Joe Perches Cc: net...@vger.kernel.org Cc: linux-kernel@vge

[PATCH net-next v2 3/3 RFC] pktgen: Allow sending TCP packets

2014-07-02 Thread Zoltan Kiss
This is a prototype patch to enable sending TCP packets with pktgen. The original motivation is to test TCP GSO with xen-netback/netfront, but I'm not sure about how the checksum should be set up, and also someone should verify the GSO settings I'm using. Signed-off-by: Zoltan Kiss Cc

[PATCH net-next v2] xen-netback: Adding debugfs "io_ring_qX" files

2014-07-02 Thread Zoltan Kiss
"kick" into it imitates an interrupt happened, it can be useful to check whether the ring is just stalled due to a missed interrupt. Signed-off-by: Zoltan Kiss Cc: net...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: xen-de...@lists.xenproject.org --- v2: - use sequential f

Re: [PATCH net-next] xen-netback: Adding debugfs "io_ring_qX" files

2014-07-02 Thread Zoltan Kiss
On 02/07/14 11:56, Ian Campbell wrote: On Mon, 2014-06-30 at 21:33 +0100, Zoltan Kiss wrote: This patch adds debugfs capabilities to netback. There used to be a similar patch floating around for classic kernel, but it used procfs. It is based on a very similar blkback patch. It creates xen

[PATCH net-next] xen-netback: Adding debugfs "io_ring_qX" files

2014-06-30 Thread Zoltan Kiss
"kick" into it imitates an interrupt happened, it can be useful to check whether the ring is just stalled due to a missed interrupt. Signed-off-by: Zoltan Kiss Cc: net...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: xen-de...@lists.xenproject.org diff --git a/drivers/net/x

Re: [PATCH net-next] pktgen: Fill the payload optionally with a pattern

2014-06-27 Thread Zoltan Kiss
On 27/06/14 20:30, David Miller wrote: From: Zoltan Kiss Date: Fri, 27 Jun 2014 10:01:23 +0100 On 26/06/14 01:54, David Miller wrote: From: Zoltan Kiss Date: Tue, 24 Jun 2014 21:40:15 +0100 Introduces a new flag called PATTERN, which puts a non-periodic, predicatble pattern into the

Re: [PATCH net-next] pktgen: Fill the payload optionally with a pattern

2014-06-27 Thread Zoltan Kiss
On 26/06/14 01:54, David Miller wrote: From: Zoltan Kiss Date: Tue, 24 Jun 2014 21:40:15 +0100 Introduces a new flag called PATTERN, which puts a non-periodic, predicatble pattern into the payload. This was useful to reproduce an otherwise intermittent bug in xen-netback [1], where checksum

Re: [PATCH net-next 3/3 RFC] pktgen: Allow sending TCP packets

2014-06-26 Thread Zoltan Kiss
On 26/06/14 01:44, David Miller wrote: From: Cong Wang Date: Wed, 25 Jun 2014 17:41:47 -0700 On Wed, Jun 25, 2014 at 1:42 PM, Zoltan Kiss wrote: This is a prototype patch to enable sending TCP packets with pktgen. The original motivation is to test TCP GSO with xen-netback/netfront, but I&#

[PATCH net-next v3] pktgen: Fill the payload optionally with a pattern

2014-06-25 Thread Zoltan Kiss
numbers divided by space. The value of the number is the size of the preceding payload area. E.g. "1 3 5 "..." 1000 1005 1010" If the pattern is used, every frag will have its own page, unlike before, so it needs more memory. [1] 5837574: xen-netback: Fix grant ref resolution in

[PATCH net-next] pktgen: Allow setting frag sizes individually

2014-06-25 Thread Zoltan Kiss
handle 4k pages. This extension of pktgen is proven to be useful to test that. Signed-off-by: Zoltan Kiss Cc: "David S. Miller" Cc: Thomas Graf Cc: Joe Perches Cc: net...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: xen-de...@lists.xenproject.org --- net/core/pktgen.c | 134 ++

[PATCH net-next 3/3 RFC] pktgen: Allow sending TCP packets

2014-06-25 Thread Zoltan Kiss
This is a prototype patch to enable sending TCP packets with pktgen. The original motivation is to test TCP GSO with xen-netback/netfront, but I'm not sure about how the checksum should be set up, and also someone should verify the GSO settings I'm using. Signed-off-by: Zoltan Kiss Cc

[PATCH net-next] pktgen: Upstreaming features useful for xen-netback/front testing

2014-06-25 Thread Zoltan Kiss
geometrics 3/3: sending TCP GSO packets. This is an RFC yet, as I'm not certain about all things changed here Signed-off-by: Zoltan Kiss Cc: "David S. Miller" Cc: Thomas Graf Cc: Joe Perches Cc: net...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: xen-de...@lists.xenpro

Re: [PATCH net-next v2] pktgen: Fill the payload optionally with a pattern

2014-06-24 Thread Zoltan Kiss
Sorry, I forgot the v2 from the subject Zoltan On 24/06/14 21:40, Zoltan Kiss wrote: Introduces a new flag called PATTERN, which puts a non-periodic, predicatble pattern into the payload. This was useful to reproduce an otherwise intermittent bug in xen-netback [1], where checksum checking

[PATCH net-next] pktgen: Fill the payload optionally with a pattern

2014-06-24 Thread Zoltan Kiss
numbers divided by space. The value of the number is the size of the preceding payload area. E.g. " 1 3 5"..." 1000 1005 1010" If the pattern is used, every frag will have its own page, unlike before, so it needs more memory. [1] 5837574: xen-netback: Fix grant ref resolution in

[PATCH net-next] pktgen: Fill the payload optionally with a pattern

2014-06-24 Thread Zoltan Kiss
numbers divided by space. The value of the number is the size of the preceding payload area. E.g. " 1 3 5"..." 1000 1005 1010" If the pattern is used, every frag will have its own page, unlike before, so it needs more memory. [1] 5837574: xen-netback: Fix grant ref resolution in

  1   2   3   4   >