Re: [PATCH V2 20/25] perf/x86/intel: Add Alder Lake Hybrid support

2021-03-11 Thread Andi Kleen
> If you want a uarch name, that might be the name of the core > ( something-cove ... I can't keep track of the names of all the GoldenCove for Sapphire Rapids/AlderLake. But keep in mind that they're still different. Kind of like a different distro with different patches and configuration

Re: [PATCH V2 20/25] perf/x86/intel: Add Alder Lake Hybrid support

2021-03-11 Thread Peter Zijlstra
On Thu, Mar 11, 2021 at 09:09:57PM +, Luck, Tony wrote: > >> I think the "sapphire_rapids" is the code name for the server platform. > > > > If that's really the case, then: > > > > #define INTEL_FAM6_SAPPHIRERAPIDS_X 0x8F > > > > is wrong, those things should be uarch name, not platform

RE: [PATCH V2 20/25] perf/x86/intel: Add Alder Lake Hybrid support

2021-03-11 Thread Luck, Tony
>> I think the "sapphire_rapids" is the code name for the server platform. > > If that's really the case, then: > > #define INTEL_FAM6_SAPPHIRERAPIDS_X 0x8F > > is wrong, those things should be uarch name, not platform name. Tony? 0x8F is the model number of the CPU that is named Sapphire

Re: [PATCH V2 20/25] perf/x86/intel: Add Alder Lake Hybrid support

2021-03-11 Thread Peter Zijlstra
On Thu, Mar 11, 2021 at 03:32:44PM -0500, Liang, Kan wrote: > I think the "sapphire_rapids" is the code name for the server platform. If that's really the case, then: #define INTEL_FAM6_SAPPHIRERAPIDS_X 0x8F is wrong, those things should be uarch name, not platform name. Tony?

Re: [PATCH V2 20/25] perf/x86/intel: Add Alder Lake Hybrid support

2021-03-11 Thread Peter Zijlstra
On Thu, Mar 11, 2021 at 12:30:53PM -0800, Andi Kleen wrote: > But what would you do with the information that the core is related > to some other core. Reduce mental clutter I suppose... there are simply too many variations of all this about :-( > In the end you need to know that Alderlake is

Re: [PATCH V2 20/25] perf/x86/intel: Add Alder Lake Hybrid support

2021-03-11 Thread Liang, Kan
On 3/11/2021 2:58 PM, Peter Zijlstra wrote: On Thu, Mar 11, 2021 at 11:53:35AM -0500, Liang, Kan wrote: The "cpu_core" PMU is similar to the Sapphire Rapids PMU, but without PMEM. The "cpu_atom" PMU is similar to Tremont, but with different event_constraints, extra_regs and number of

Re: [PATCH V2 20/25] perf/x86/intel: Add Alder Lake Hybrid support

2021-03-11 Thread Andi Kleen
On Thu, Mar 11, 2021 at 08:58:32PM +0100, Peter Zijlstra wrote: > On Thu, Mar 11, 2021 at 11:53:35AM -0500, Liang, Kan wrote: > > > > > The "cpu_core" PMU is similar to the Sapphire Rapids PMU, but without > > > > PMEM. > > > > The "cpu_atom" PMU is similar to Tremont, but with different > > > >

Re: [PATCH V2 20/25] perf/x86/intel: Add Alder Lake Hybrid support

2021-03-11 Thread Peter Zijlstra
On Thu, Mar 11, 2021 at 11:53:35AM -0500, Liang, Kan wrote: > > > The "cpu_core" PMU is similar to the Sapphire Rapids PMU, but without > > > PMEM. > > > The "cpu_atom" PMU is similar to Tremont, but with different > > > event_constraints, extra_regs and number of counters. > > So do these

Re: [PATCH V2 20/25] perf/x86/intel: Add Alder Lake Hybrid support

2021-03-11 Thread Liang, Kan
On 3/11/2021 11:32 AM, Peter Zijlstra wrote: On Thu, Mar 11, 2021 at 05:09:25PM +0100, Peter Zijlstra wrote: On Wed, Mar 10, 2021 at 08:37:56AM -0800, kan.li...@linux.intel.com wrote: From: Kan Liang Alder Lake Hybrid system has two different types of core, Golden Cove core and Gracemont

Re: [PATCH V2 20/25] perf/x86/intel: Add Alder Lake Hybrid support

2021-03-11 Thread Liang, Kan
On 3/11/2021 11:53 AM, Liang, Kan wrote: On 3/11/2021 11:09 AM, Peter Zijlstra wrote: On Wed, Mar 10, 2021 at 08:37:56AM -0800, kan.li...@linux.intel.com wrote: From: Kan Liang Alder Lake Hybrid system has two different types of core, Golden Cove core and Gracemont core. The Golden Cove

Re: [PATCH V2 20/25] perf/x86/intel: Add Alder Lake Hybrid support

2021-03-11 Thread Liang, Kan
On 3/11/2021 11:09 AM, Peter Zijlstra wrote: On Wed, Mar 10, 2021 at 08:37:56AM -0800, kan.li...@linux.intel.com wrote: From: Kan Liang Alder Lake Hybrid system has two different types of core, Golden Cove core and Gracemont core. The Golden Cove core is registered to "cpu_core" PMU. The

Re: [PATCH V2 20/25] perf/x86/intel: Add Alder Lake Hybrid support

2021-03-11 Thread Peter Zijlstra
On Thu, Mar 11, 2021 at 05:09:25PM +0100, Peter Zijlstra wrote: > On Wed, Mar 10, 2021 at 08:37:56AM -0800, kan.li...@linux.intel.com wrote: > > From: Kan Liang > > > > Alder Lake Hybrid system has two different types of core, Golden Cove > > core and Gracemont core. The Golden Cove core is

Re: [PATCH V2 20/25] perf/x86/intel: Add Alder Lake Hybrid support

2021-03-11 Thread Peter Zijlstra
On Wed, Mar 10, 2021 at 08:37:56AM -0800, kan.li...@linux.intel.com wrote: > From: Kan Liang > > Alder Lake Hybrid system has two different types of core, Golden Cove > core and Gracemont core. The Golden Cove core is registered to > "cpu_core" PMU. The Gracemont core is registered to "cpu_atom"

Re: [PATCH V2 20/25] perf/x86/intel: Add Alder Lake Hybrid support

2021-03-11 Thread Peter Zijlstra
On Wed, Mar 10, 2021 at 08:37:56AM -0800, kan.li...@linux.intel.com wrote: > @@ -4059,6 +4099,34 @@ tfa_get_event_constraints(struct cpu_hw_events *cpuc, > int idx, > return c; > } > > +static struct event_constraint * > +adl_get_event_constraints(struct cpu_hw_events *cpuc, int idx, > +

[PATCH V2 20/25] perf/x86/intel: Add Alder Lake Hybrid support

2021-03-10 Thread kan . liang
From: Kan Liang Alder Lake Hybrid system has two different types of core, Golden Cove core and Gracemont core. The Golden Cove core is registered to "cpu_core" PMU. The Gracemont core is registered to "cpu_atom" PMU. The difference between the two PMUs include: - Number of GP and fixed counters